hazza/dspace-angular
1
0
Fork 1
mirror of https://github.com/DSpace/dspace-angular.git synced 2025-10-07 01:54:15 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,281 Commits 24 Branches 25 Tags
1b717e1a5c763ee37af35afe3c858fc4d9734bdb
Commit Graph

9281 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Yury Bondarenko
1b717e1a5c ESLint: fix RxJs rule violations (pt. 1) 2023-06-27 17:19:53 +02:00
Yury Bondarenko
218ce832a9 ESLint: enforce low-impact recommended RxJs rules 
https://github.com/cartant/eslint-plugin-rxjs#rules

Mainly to steer us away from unsafe patterns

Skipping two recommended rules for now:
rxjs/no-implicit-any-catch → not immediately clear how this should be addressed
rxjs/no-nested-subscribe   → there are quite a few cases, would take some effort to fix all of them
 2023-06-27 17:19:53 +02:00
Yury Bondarenko
8a650a2fb5 ESlint: fix eqeqeq violations 2023-06-27 17:19:45 +02:00
Yury Bondarenko
3ce98cdbac ESLint: enforce Angular HTML eqeqeq 
https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/eqeqeq.md
 2023-06-27 17:19:20 +02:00
Yury Bondarenko
741c6009f4 ESLint: fix no-negated-async violations 2023-06-27 17:19:01 +02:00
Yury Bondarenko
fa2c22d240 ESLint: enforce Angular HTML no-negated-async 
https://github.com/angular-eslint/angular-eslint/blob/main/packages/eslint-plugin-template/docs/rules/no-negated-async.md

Prevents us from writing conditions that may pass/fail before an observable has emitted (this is likely to cause unexpected behaviour)
 2023-06-27 16:47:09 +02:00
Yury Bondarenko
74e9e5fa14 ESLint: fix ban-types violations 2023-06-27 16:47:09 +02:00
Yury Bondarenko
80c9dae417 ESLint: enforce ban-types 
https://typescript-eslint.io/rules/ban-types/
 2023-06-27 16:47:09 +02:00
Yury Bondarenko
6f0c1e003d ESLint: fix no-extra-boolean-cast violations 2023-06-27 16:47:09 +02:00
Yury Bondarenko
ad4205073c ESLint: enforce no-extra-boolean-cast 
https://eslint.org/docs/latest/rules/no-extra-boolean-cast
 2023-06-27 16:47:09 +02:00
Yury Bondarenko
0f1ebfba62 ESLint: fix no-case-declaration violations 2023-06-27 16:47:09 +02:00
Yury Bondarenko
f1a8920d86 ESLint: enforce no-case-declarations 
https://eslint.org/docs/latest/rules/no-case-declarations
 2023-06-27 16:47:09 +02:00
Yury Bondarenko
95d3ff6569 ESLint: fix prefer-const violations 2023-06-27 16:47:09 +02:00
Yury Bondarenko
702246be38 ESLint: enforce prefer-const where possible 
https://eslint.org/docs/latest/rules/prefer-const

In our tests we use this pattern a lot:
```
let something;

beforeEach(() => {
  something = ...;
});
```

This is not valid ~ prefer-const, but can be "let through" with some configuration.
However, this would make the rule too loose for the non-test codebase.

Therefore, we enable it overall but turn it off for tests only -- the `*.spec.ts` overrides apply to test files only and take precedence over `*.ts`
 2023-06-27 16:47:09 +02:00
Tim Donohue
884aa07430 Update version tag for development of next release 2023-06-23 13:04:19 -05:00
Tim Donohue
404ccd9b0e Update version tag for release dspace-7.6 2023-06-23 12:54:41 -05:00
Tim Donohue
990bde43ab Merge pull request #2336 from atmire/w2p-103005_variable-overwrite-fix_contribution 
Fix background-color overwrite issue
 2023-06-23 10:01:53 -05:00
Tim Donohue
db526a0c25 Merge pull request #2331 from tdonohue/ssr_redirect_301 
Implement basic 301 Redirect for DSpace 6.x URLs when SSR is used.
 2023-06-23 08:59:30 -05:00
Tim Donohue
9a5e26f640 Merge pull request #2334 from 4Science/fix-bistream-download-cache 
fix for bitstreams are not visible to crawlers when caching is enabled
 2023-06-23 08:56:02 -05:00
lotte
d4a59dd51c Merge branch 'w2p-103005_variable-overwrite-fix' 2023-06-23 12:07:22 +02:00
lotte
3d133f6166 103005: Fixed issue where bg colours couldn't be overwritten in themes 2023-06-23 11:50:05 +02:00
Giuseppe Digilio
163014306c [DURACOM-172] improve regex 2023-06-23 09:23:28 +02:00
Giuseppe Digilio
d9857a7a9a Merge branch 'main' into fix-bistream-download-cache 2023-06-23 09:16:17 +02:00
Tim Donohue
5331ff68db Merge pull request #2330 from doana/dynamic-scrollable-dropdown-accessibility 
Add the ability to expand / collapse via keyboard
 2023-06-22 15:23:33 -05:00
Tim Donohue
d4a5308d0c Refactor to use HardRedirectService. Update its redirect method to support optional statusCode 2023-06-22 13:37:14 -05:00
Giuseppe Digilio
6a58e49fb4 [DURACOM-172] add check to save only successful response into the SSR cache 2023-06-22 18:16:53 +02:00
Tim Donohue
661b4aef9d Merge pull request #2332 from 4Science/DURACOM-170 
"Add Collection"  form loads
 2023-06-22 11:10:39 -05:00
Alisa Ismailati
47e7eb1a4f [DURACOM-170] Fixed "add collection" behavior 2023-06-22 12:14:15 +02:00
Tim Donohue
0fe33eecd1 Implement basic 301 Redirect when SSR is used. 2023-06-21 15:36:59 -05:00
Adam Doan
275b057b40 Add the ability to expand / collapse via keyboard 2023-06-21 17:37:22 +00:00
Art Lowel
499bfe3154 Merge pull request #2277 from paulo-graca/bugfix/addressing-#2276 
new project metadata representation component
 2023-06-21 09:19:06 +02:00
Tim Donohue
5d39026eb7 Merge pull request #2245 from mwoodiupui/themeable-request-copy 
Make some request-copy components themeable.
 2023-06-20 16:27:45 -05:00
Tim Donohue
ee3e5ca14c Merge pull request #2316 from alanorth/item-count-style 
src/app: adjust item count style
 2023-06-20 16:13:26 -05:00
Tim Donohue
834893249c Merge pull request #2326 from 4Science/DURACOM-160 
[DURACOM-160] Hide "Send feedback" link when CanSendFeedback is false
 2023-06-20 15:50:59 -05:00
Alan Orth
07a8024daa src/app: adjust item count style 
Minor adjustment to community and collection item counts. Instead of
using the Bootstrap `lead` class, which reduces weight but increases
size, we should use the same badge / pill style used in other counts
like on on the browse by pages.
 2023-06-20 22:33:11 +03:00
Paulo Graça
5c10e473e9 Merge branch 'main' into bugfix/addressing-#2276 2023-06-20 17:07:13 +01:00
Paulo Graça
1919f976f4 adding support for DSONameService 2023-06-20 15:30:56 +01:00
Tim Donohue
2fa8ab5365 Merge pull request #2322 from alanorth/english-strings 
src/assets/i18n: update English strings
 2023-06-20 09:27:43 -05:00
Tim Donohue
157eedade4 Merge pull request #2288 from atmire/add-referrer-to-pageview-event-7.6.0-next 
Add referrer to pageview event
 2023-06-20 09:20:42 -05:00
Paulo Graça
f471957c4c adding support for DSONameService 2023-06-20 14:06:48 +01:00
Paulo Graça
72eaf35de1 adding support for DSONameService 2023-06-20 13:35:12 +01:00
Paulo Graça
e6fdc4597a change param name in typescript doc 2023-06-20 10:34:34 +01:00
Paulo Graça
130c3c9496 addressing styling issue 2023-06-20 10:33:03 +01:00
Paulo Graça
82d17d795f add support for dsoNameService 2023-06-20 10:24:53 +01:00
Paulo Graça
52dbb21339 include the project metadata representation component 2023-06-19 15:37:35 +01:00
Davide Negretti
4eb2297910 [DURACOM-160] Hide "Send feedback" link when CanSendFeedback is false 2023-06-19 13:24:10 +02:00
Paulo Graça
1caeecaa50 Merge branch 'main' into bugfix/addressing-#2276 2023-06-19 09:51:46 +01:00
Alan Orth
00aa0271f2 src/assets/i18n: update English strings 
Re-word two messages for better English and consistency with other
similar strings.
 2023-06-19 09:50:46 +03:00
Tim Donohue
471051dd59 Merge pull request #2319 from misilot/patch-1 
Fix typo for the word Series
 2023-06-16 16:36:52 -05:00
Tim Donohue
d728cc227d Merge pull request #2292 from rsaraivac/portuguese_pt-PT-message-keys 
Portuguese (pt_PT) translation keys update
 2023-06-16 16:13:30 -05:00