Commit Graph

11062 Commits

Author SHA1 Message Date
Yury Bondarenko
ac48a49273 Merge remote-tracking branch 'origin/main' into poc-eslint-plugin-autofix-selectors 2024-04-04 18:15:28 +02:00
Tim Donohue
7ebda4a7ed Merge pull request #2887 from DSpace/rename-ds7-2-ds8
Renaming DSpace to DSpace 8
2024-04-04 10:45:51 -05:00
Tim Donohue
7ae6c7e67e Merge pull request #2871 from 4Science/DURACOM-234
Upgrade to angular 16
2024-04-04 10:11:08 -05:00
Paulo Graça
00798934d6 Renaming to DS8 2024-04-04 15:47:38 +01:00
Paulo Graça
dbf222248a Renaming DSpace to DSpace 8 2024-04-04 15:37:04 +01:00
Giuseppe Digilio
c327bf744b [DURACOM-234] Fix merge with main 2024-04-04 09:58:10 +02:00
Giuseppe Digilio
32f1d1096a Merge branch 'main' into DURACOM-234
# Conflicts:
#	src/app/core/data/request.service.ts
#	src/modules/app/browser-app.config.ts
#	src/modules/app/server-app.config.ts
2024-04-04 09:32:38 +02:00
Tim Donohue
86ddd45dc1 Merge pull request #2886 from tdonohue/csrf_fixes
Ensures CSRF token is initialized prior to first modifying (non-`GET`) request
2024-04-03 14:43:40 -05:00
Tim Donohue
bbab56a7da Update build script to use "docker compose" instead of "docker-compose". Fixes random failures starting e2e test backend via Docker 2024-04-03 14:00:42 -05:00
Giuseppe Digilio
35714b7a45 [DURACOM-234] rename guards in order to be complaint to function name convention 2024-04-03 18:57:11 +02:00
Giuseppe Digilio
f1686d5499 [DURACOM-234] rename resolvers in order to be complaint to function name convention 2024-04-03 18:48:14 +02:00
Tim Donohue
f7d31fd341 Fix tests. Add XSRFService to all specs which need it to be initialized 2024-04-03 11:48:13 -05:00
Tim Donohue
cc6b159a8a Update code to use GET request. Cleanup lint errors & add in basic TypeDocs 2024-04-03 10:25:43 -05:00
Art Lowel
617c7d8756 make a call to ensure a correct XSRF token before performing any non-GET requests 2024-04-03 09:46:45 -05:00
Yury Bondarenko
b99d9030cd Fix stray Angular 17 dependency 2024-04-03 12:36:46 +02:00
Giuseppe Digilio
aba04913ce [DURACOM-234] Replace Observable with BehaviorSubject 2024-04-02 18:54:39 +02:00
Giuseppe Digilio
660cf7e4dd [DURACOM-234] Remove assertions on isResponsePending in favour of remote data operators 2024-04-02 18:54:00 +02:00
Giuseppe Digilio
b49d883e0b [DURACOM-234] fix my-dspace.guard 2024-04-02 18:51:00 +02:00
Giuseppe Digilio
b8c26a71c3 [DURACOM-234] Fixes after migrating to functional guards 2024-04-02 18:45:57 +02:00
Giuseppe Digilio
026e16ffd9 [DURACOM-234] Fix tests 2024-04-02 15:28:19 +02:00
Giuseppe Digilio
32b816c1aa [DURACOM-234] Made use of mapToCanActivate for all the guards which are still Class 2024-04-02 13:13:25 +02:00
Giuseppe Digilio
19548fc6d4 [DURACOM-234] Move resolver dependency to relate functional one 2024-04-02 12:31:32 +02:00
Giuseppe Digilio
6a4ad7bdb4 [DURACOM-234] Fix resolver name 2024-04-02 12:28:49 +02:00
Giuseppe Digilio
29f5a17528 [DURACOM-234] Migrate to functional guards WIP 2024-03-29 18:28:32 +01:00
Giuseppe Digilio
5dbc6ce7a8 [DURACOM-237] Fix issue on drag end 2024-03-29 12:47:03 +01:00
Yury Bondarenko
c4b32febc1 Explain themed-component-classes rule 2024-03-29 10:52:55 +01:00
Yury Bondarenko
08a5443cc2 Add generated docs to source 2024-03-29 10:47:04 +01:00
Yury Bondarenko
515e5f00cf Improve documentation 2024-03-29 10:46:20 +01:00
Yury Bondarenko
2c68589416 Move generated documentation to docs/lint/ 2024-03-29 10:12:57 +01:00
Giuseppe Digilio
1f4aca800b [DURACOM-234] Migrate fo functional resolver 2024-03-28 23:34:37 +01:00
Yury Bondarenko
a6e093038c Manual fix: use base components in unit test templates
`Themed*` components should be used in the actual codebase to ensure we retain theme support.
However, in unit tests these components won't work without a fully-functional `ThemeService` & `Store`.

For this reason, the lint plugin allows `ds-base-*` selectors in unit test templates.
2024-03-28 18:52:06 +01:00
Yury Bondarenko
762e4616cc Manual fix: sync removed imports between tests and components
The automatic migration made it so HTML always uses the `Themed*` component, and it must therefore be imported in all standalone components that use it.
Afterwards, many unit tests fail because the removed imports no longer match up (can't inject `ThemeService`).

While we could try to support this as part of the automatic migration, there are too many edge cases for this to be consistent.
2024-03-28 18:52:06 +01:00
Yury Bondarenko
0b9741d252 Manual fix: update i/o for ThemedConfigurationSearchPageComponent
Fixes compile-time errors due to out-of-sync inputs and outputs between ThemedConfigurationSearchPageComponent and SearchComponent

(note that this is was an existing problem in the source code that flew under the radar until we flipped the selector convention!)
2024-03-28 18:52:06 +01:00
Yury Bondarenko
6051b82821 Automatically migrate to new themeable component convention 2024-03-28 18:33:46 +01:00
Yury Bondarenko
e40b6ae612 Update plugins to support standalone components
- ThemedComponent wrappers should always import their base component. This ensures that it's always enough to only import the wrapper when we use it.
- This implies that all themeable components must be standalone

→ added rules to enforce this
→ updated usage rule to improve declaration/import handling
2024-03-28 18:33:46 +01:00
Giuseppe Digilio
549609e2ea [DURACOM-234] Fix Markdown Config 2024-03-28 16:49:14 +01:00
Giuseppe Digilio
a8c3af097d [DURACOM-234] Switch to standalone bootstrapping API 2024-03-26 20:52:26 +01:00
Giuseppe Digilio
0c3e9b1535 [DURACOM-234] Fix NG0600 error 2024-03-26 18:42:29 +01:00
Alan Orth
b3b3ef8203 Merge pull request #2877 from alexandrevryghem/fix-systemwidealert-form-validation_contribute-main
System-wide alert shouldn't be created when the message is empty
2024-03-26 10:11:45 +03:00
Alexandre Vryghem
03e49907c1 Merge branch 'fix-systemwidealert-form-validation_contribute-7.6' into fix-systemwidealert-form-validation_contribute-main 2024-03-23 16:04:25 +01:00
Alexandre Vryghem
767de4b5c8 Prevent system-wide alert to be activated with empty message 2024-03-23 15:12:48 +01:00
Giuseppe Digilio
e0855a46cc [DURACOM-234] Remove unsupported node 16 2024-03-21 17:29:52 +01:00
Giuseppe Digilio
969b42fee1 [DURACOM-234] Fix tests 2024-03-21 16:34:42 +01:00
Giuseppe Digilio
abb284a2d6 [DURACOM-237] Fix tests 2024-03-21 16:33:32 +01:00
Giuseppe Digilio
5d24691bc2 Merged in DURACOM-240-mathjax (pull request #1488)
Replace mathjax pipe with directive
2024-03-21 12:17:44 +00:00
Giuseppe Digilio
b325701f9f [DURACOM-240] Fix test 2024-03-21 13:11:08 +01:00
Giuseppe Digilio
a652600c7f [DURACOM-234] Remove fdescribe 2024-03-21 13:10:33 +01:00
Giuseppe Digilio
e2bbb43395 Merge branch 'DURACOM-234' into DURACOM-240-mathjax
# Conflicts:
#	src/app/shared/utils/markdown.pipe.spec.ts
2024-03-21 12:57:31 +01:00
Giuseppe Digilio
152e724c75 [DURACOM-234] Fix tests 2024-03-21 12:56:45 +01:00
Yury Bondarenko
568574585b Workaround/document edge case where node can't be found by token 2024-03-21 10:35:04 +01:00