Alexandre Vryghem
c23500b7fa
Merge remote-tracking branch 'alex/create-themable-comcolpage-content_contribute-7.4' into minor-themed-component-fixes_contribute-main
...
# Conflicts:
# src/app/browse-by/browse-by-metadata-page/browse-by-metadata-page.component.html
# src/app/collection-page/collection-page.component.html
# src/app/community-page/community-page.component.html
# src/app/shared/comcol/comcol.module.ts
2024-03-09 14:40:48 +01:00
Alexandre Vryghem
bb490f827b
Merge remote-tracking branch 'contributions/w2p-107950_themed-metadata-import-page-component' into minor-themed-component-fixes_contribute-main
...
# Conflicts:
# src/app/admin/admin-routing.module.ts
# src/app/admin/admin.module.ts
# src/themes/custom/lazy-theme.module.ts
2024-03-09 14:19:47 +01:00
Alexandre Vryghem
a18bcb7493
Merge remote-tracking branch 'alex/memory-leak-fixes_contribute-7.6' into minor-themed-component-fixes_contribute-main
...
# Conflicts:
# src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.ts
# src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-drag-handle/item-edit-bitstream-drag-handle.component.ts
# src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream/item-edit-bitstream.component.ts
2024-03-09 13:53:27 +01:00
Alexandre Vryghem
c2c9d28ff2
Merge branch 'minor-themed-component-fixes_contribute-7.6' into minor-themed-component-fixes_contribute-main
...
# Conflicts:
# src/themes/custom/app/shared/comcol-page-browse-by/comcol-page-browse-by.component.ts
# src/themes/custom/app/shared/comcol-page-handle/comcol-page-handle.component.ts
# src/themes/custom/lazy-theme.module.ts
2024-03-09 13:51:41 +01:00
Alan Orth
a8f31948bc
Merge pull request #2777 from TAMULib/dynamic-tag-on-blur
...
Element reference for typeahead directive is only defined when model has authority
2024-03-08 23:12:59 +03:00
Tim Donohue
a2531e5f6e
Merge pull request #2343 from ybnd/more-eslint
...
Stricter ESLint configuration for code quality, consistency & cleaner merges
2024-03-08 09:24:30 -06:00
Yury Bondarenko
33d5253d47
Only log errors for DspaceRestService.get
...
When refactoring to meet the rxjs/no-implicit-any-catch ESLint rule, I'd made it so errors were logged for DspaceRestService.request calls as well, making it a lot more noisy
The console.log in .get is explicitly required by tests though
2024-03-08 11:02:48 +01:00
Yury Bondarenko
86885f7dce
Merge remote-tracking branch 'origin/main' into more-eslint
2024-03-07 09:56:55 +01:00
Yury Bondarenko
5edc689bc1
Fix null/undefined incosistencies
...
- Introduced pipes for combined null/undefined checks: dsHasValue & dsHasNoValue
- Safer to async !== true than async === false
- Went over other instances of async === to confirm that they should be fine
2024-03-07 09:55:36 +01:00
Tim Donohue
a9c58a1d5a
Merge pull request #2856 from 4Science/coar-notify-itempage-error-on-ldnenabled-false
...
fix 'undefined' error on anonymous item page landing
2024-03-06 09:22:40 -06:00
Yury Bondarenko
ebbbd64bae
Fix tests
2024-03-06 11:56:17 +01:00
Yury Bondarenko
3b48d9a26d
Manually fix lint issues
2024-03-06 11:56:17 +01:00
Yury Bondarenko
2b540cd91c
Autofix lint issues
2024-03-06 10:30:19 +01:00
Yury Bondarenko
dbf7fd67fd
Merge remote-tracking branch 'origin/main' into more-eslint
2024-03-06 10:26:07 +01:00
frabacche
e6389a73df
fix e2e test 18x aria on <ul> html tag
2024-03-06 09:30:42 +01:00
frabacche
dd9fc1881f
fix 'undefined' error on anonymous item page landing
2024-03-05 16:13:00 +01:00
Tim Donohue
230055ce6f
Merge pull request #2851 from saschaszott/patch-19
...
fix selector value in CommunitySidebarSearchListElementComponent
2024-03-05 09:12:58 -06:00
Sascha Szott
ad3ef56e06
fix selector value in CommunitySidebarSearchListElementComponent
2024-03-05 11:10:12 +01:00
Tim Donohue
761b0c2203
Merge pull request #2751 from 4Science/coar-notify-7-part-two
...
Coar Notify Integration - Administer/Log
2024-03-04 16:32:23 -06:00
Tim Donohue
76f5d34bbe
Merge pull request #2847 from DSpace/dependabot/npm_and_yarn/sanitize-html-2.12.1
...
Bump sanitize-html from 2.10.0 to 2.12.1
2024-03-04 16:02:23 -06:00
Tim Donohue
4cc5a383cc
Merge pull request #2371 from alexandrevryghem/fix-specs-without-expectations_contribute-main
...
Fix Spec has no expectations errors
2024-03-04 14:11:29 -06:00
frabacche
0f7965ea6e
Merge remote-tracking branch 'github/main' into coar-notify-7-part-two
2024-03-04 17:26:17 +01:00
Tim Donohue
f6f396221d
Merge pull request #2749 from the-library-code/DSpace_detect_duplicates_PR
...
Basic Duplicate Detection
2024-03-04 09:28:26 -06:00
frabacche
add125790a
Merge pull request #78 from 4Science/coar-notify-7-part-two-refactor-enqueue
...
ldn message: move enqueueretry from get to post
2024-03-04 13:25:32 +01:00
FrancescoMolinaro
1fd16a2d3e
Merge remote-tracking branch 'origin/coar-notify-7-part-two' into coar-notify-7-part-two
2024-03-04 11:40:30 +01:00
FrancescoMolinaro
fd1483d537
restyle header
2024-03-04 11:40:06 +01:00
FrancescoMolinaro
c03ab07556
add route guard
2024-03-04 11:38:56 +01:00
FrancescoMolinaro
a79c4036cb
fix menu resolver condition for LDN
2024-03-04 11:38:56 +01:00
FrancescoMolinaro
23cb4ca7b7
Add components descriptions, fix bug on navigation, align labels, add config example
2024-03-04 11:38:56 +01:00
FrancescoMolinaro
38ac31eafe
add route guard
2024-03-04 11:37:27 +01:00
FrancescoMolinaro
f925273d90
fix menu resolver condition for LDN
2024-03-04 11:31:35 +01:00
FrancescoMolinaro
c27e758ffb
Add components descriptions, fix bug on navigation, align labels, add config example
2024-03-04 11:29:02 +01:00
frabacche
4fdade892b
ldn message: move enqueueretry from get to post
2024-03-04 11:17:15 +01:00
Kim Shepherd
e4a91e7261
[TLC-674] New duplicate data service, object reducer tests
2024-03-04 14:29:26 +13:00
Kim Shepherd
ca32314951
[TLC-674] Fix findDuplicates error in claimed task (old code)
...
Update spec tests
2024-03-04 13:31:48 +13:00
Kim Shepherd
2000b1b240
[TLC-674] Resolve sections type list problem (introduced in conflict merge)
2024-03-04 12:00:51 +13:00
Kim Shepherd
1206d61440
[TLC-674] Update duplicate data service to use searchBy method
2024-03-04 11:50:55 +13:00
Kim Shepherd
1e36a10dd5
[TLC-674] Properly test for existence of duplicates section
2024-03-04 11:50:55 +13:00
Kim Shepherd
e76b6c962c
[TLC-674] Duplicate detection frontend changes as per feedback
2024-03-04 11:50:54 +13:00
Kim Shepherd
6229966f7a
[TLC-674] Mock duplicateDataService.findDuplicates()
2024-03-04 11:50:15 +13:00
Kim Shepherd
b79dab3fcb
[TLC-674] Mock duplicateDataService providers in spec tests
2024-03-04 11:50:15 +13:00
Kim Shepherd
0d42af38cd
[TLC-674] Refactor Basic Duplicate detection endpoint / data service
2024-03-04 11:50:14 +13:00
Kim Shepherd
911cf8905c
[TLC-674] Hide empty duplicate section UNLESS config overrides
...
A new config property allows the user to force the duplicate
section to be displayed even if there are no duplicates
as sometimes this is useful information to a reviewer or
submitter
2024-03-04 11:49:24 +13:00
Kim Shepherd
68dd35095c
[TLC-674] Do not display duplicate section if data is empty
2024-03-04 11:49:24 +13:00
Kim Shepherd
a9a87d31ef
[TLC-674] Allow for no duplicate section in submitted workspace item
2024-03-04 11:49:24 +13:00
Kim Shepherd
b4591b1372
[TLC-674] Potential duplicate msg shown as warning alert
2024-03-04 11:49:24 +13:00
Kim Shepherd
7a10834f82
[TLC-674] Dupe layout changes as per review
...
i18n fix
alignment fix
comment fix
2024-03-04 11:49:24 +13:00
Kim Shepherd
b8e2cac399
[TLC-674] Fix duplicate section unit test
2024-03-04 11:49:24 +13:00
Kim Shepherd
db8d47e598
[TLC-674] Refactor duplicates from item link to searchBy
2024-03-04 11:49:24 +13:00
Pascal-Nicolas Becker
140cb88510
Tiny code style fix in pool-search-result-list-element.component.ts
2024-03-04 11:49:24 +13:00
