Commit Graph

11277 Commits

Author SHA1 Message Date
Alexandre Vryghem
fd6d470b3f 111731: Fixed scope not correctly resetting to no scope when clicking on "Search all of DSpace" in the search scope selector 2024-05-07 14:54:48 +02:00
Alexandre Vryghem
ede5f4325a 111731: Force the isActive state to be recalculated when the scope is updated
The BehaviorSubject was necessary because when the result of SearchService#getSelectedValuesForFilter is already cached, the isActive state can be recalculated even before the @Input() scope is updated
2024-05-07 14:22:03 +02:00
Alexandre Vryghem
2dbf69e46b Merge branch 'advanced-search_contribute-7.6' into advanced-search_contribute-main
# Conflicts:
#	src/app/core/shared/search/search-filter.service.ts
#	src/app/core/shared/search/search.service.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter/search-facet-filter.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter/search-facet-filter.component.ts
#	src/app/shared/search/search-filters/search-filter/search-filter.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-filter.component.ts
#	src/app/shared/search/search-filters/search-filter/search-hierarchy-filter/search-hierarchy-filter.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-range-filter/search-range-filter.component.ts
#	src/app/shared/testing/search-service.stub.ts
2024-05-07 13:42:49 +02:00
Alexandre Vryghem
e66035c896 111731: Minimize all the facets when adding filter through advanced component & filter suggestions 2024-05-07 12:09:47 +02:00
Alexandre Vryghem
1f42f92344 111731: Hide the search facets when there are no facet suggestions & the applied filters of that facet don't have the operator equals, authority or range (because those should be displayed in the facets) 2024-05-07 12:07:40 +02:00
Alexandre Vryghem
28088bc8c8 111731: Made the code completely dependent on the SearchService#appliedFilters$ instead of relying on the route query parameters 2024-05-07 00:39:33 +02:00
Alexandre Vryghem
2226cc4d3b Merge branch 'advanced-search_contribute-7.6' into advanced-search_contribute-main 2024-05-05 16:10:26 +02:00
Alexandre Vryghem
58d73875b8 111731: Fixed accessibility issues 2024-05-05 16:00:35 +02:00
Alexandre Vryghem
806b07c084 111731: Fixed tests not mocking SearchConfigurationService 2024-05-05 15:28:54 +02:00
Alexandre Vryghem
e94b094c20 Merge branch 'advanced-search_contribute-7.6' into advanced-search_contribute-main
# Conflicts:
#	src/app/core/shared/search/search-configuration.service.ts
#	src/app/shared/search/advanced-search/advanced-search.component.ts
#	src/app/shared/search/search-sidebar/search-sidebar.component.html
#	src/app/shared/search/search-sidebar/search-sidebar.component.spec.ts
#	src/app/shared/search/search-sidebar/search-sidebar.component.ts
#	src/app/shared/testing/search-configuration-service.stub.ts
2024-05-05 05:43:37 +02:00
Alexandre Vryghem
806430064f 111731: Hide advanced search section when no filters are available and hide it on the home page 2024-05-05 05:19:58 +02:00
Alexandre Vryghem
029359bace 111731: Search page UI fixes
- Hide advanced search when inPlaceSearch is false
- Fixed the search settings being invisible on small screens in the sidebar
- Fixed the view mode buttons not being selected unless the parameter view was defined in the url
2024-05-04 03:05:15 +02:00
Alexandre Vryghem
f5ce79fb54 Merge branch 'use-applied-filter-to-display-label-on-search_contribute-main' into advanced-search_contribute-main
# Conflicts:
#	src/app/shared/search/search-sidebar/search-sidebar.component.html
#	src/app/shared/search/search.component.html
2024-05-04 02:49:02 +02:00
Alexandre Vryghem
b75f589f36 Merge remote-tracking branch 'upstream/main' into use-applied-filter-to-display-label-on-search_contribute-main
# Conflicts:
#	src/app/shared/search/models/search-query-response.model.ts
#	src/app/shared/search/search-filters/themed-search-filters.component.ts
#	src/app/shared/search/search-sidebar/search-sidebar.component.html
#	src/app/shared/search/search-sidebar/themed-search-sidebar.component.ts
#	src/app/shared/search/search.component.html
2024-05-02 22:32:00 +02:00
Tim Donohue
054043a872 Merge pull request #2980 from atmire/w2p-114599_ClickingSaveOnCreateComColProvidesUserFeedback
Clicking save on create community and collection pages provides user feedback
2024-05-02 15:14:10 -05:00
Alexandre Vryghem
561ccc398e 111731: Used yml config to configure the visibility advanced search component & its filters 2024-05-02 22:03:54 +02:00
Alexandre Vryghem
e251c2c341 Merge branch 'advanced-search_contribute-7.6' into advanced-search_contribute-main
# Conflicts:
#	src/app/shared/search-form/search-form.component.spec.ts
#	src/app/shared/search-form/search-form.component.ts
2024-05-02 13:45:48 +02:00
Kuno Vercammen
20146bdcef 114599: Updated the e2e tests so they succeed 2024-05-02 12:38:12 +02:00
Alexandre Vryghem
92cc112ed6 111731: Also minimize the search facets while switching scopes 2024-05-02 11:21:31 +02:00
Kuno Vercammen
6ff3a40929 114599: Adapted the changes after the rebase 2024-05-02 10:21:49 +02:00
Kuno Vercammen
8ac2fe9dcf 114599: Small lint fixes 2024-05-02 10:08:49 +02:00
Kuno Vercammen
fea2ff7b9c 114599: Added loading animation after creating collection or community 2024-05-02 10:08:40 +02:00
Kuno Vercammen
0ac98c5230 114599: Small lint fixes 2024-05-02 10:05:24 +02:00
Kuno Vercammen
9bcd816703 114599: Added e2e test to test the newly added loading component after creating com/col 2024-05-02 10:05:24 +02:00
Kuno Vercammen
fb988610db 114599: Added loading animation after creating collection or community 2024-05-02 10:05:24 +02:00
Alexandre Vryghem
bc35bfb3cd 111731: Refactored SearchFacetFilterWrapperComponent to extend AbstractComponentLoaderComponent 2024-05-02 00:00:47 +02:00
Tim Donohue
0e61cfd0c2 Merge pull request #2933 from atmire/reset-dropdown-values
Reset dropdown values
2024-05-01 16:38:00 -05:00
Alexandre Vryghem
f8759c56ad Merge branch 'use-applied-filter-to-display-label-on-search_contribute-main' into advanced-search_contribute-main
# Conflicts:
#	src/app/core/shared/search/search-configuration.service.spec.ts
#	src/app/core/shared/search/search-filter.service.spec.ts
#	src/app/core/shared/search/search-filter.service.ts
#	src/app/core/shared/search/search.service.ts
#	src/app/shared/search/advanced-search/advanced-search.component.html
#	src/app/shared/search/advanced-search/advanced-search.component.scss
#	src/app/shared/search/advanced-search/advanced-search.component.spec.ts
#	src/app/shared/search/advanced-search/advanced-search.component.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-option/search-facet-option.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-selected-option/search-facet-selected-option.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-selected-option/search-facet-selected-option.component.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-wrapper/search-facet-filter-wrapper.component.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter/search-facet-filter.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter/search-facet-filter.component.ts
#	src/app/shared/search/search-filters/search-filter/search-filter.actions.ts
#	src/app/shared/search/search-filters/search-filter/search-filter.component.ts
#	src/app/shared/search/search-filters/search-filter/search-filter.reducer.ts
#	src/app/shared/search/search-filters/search-filter/search-hierarchy-filter/search-hierarchy-filter.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-hierarchy-filter/search-hierarchy-filter.component.ts
#	src/app/shared/search/search-filters/search-filter/search-range-filter/search-range-filter.component.html
#	src/app/shared/search/search-filters/search-filter/search-range-filter/search-range-filter.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-range-filter/search-range-filter.component.ts
#	src/app/shared/search/search-filters/search-filters.component.html
#	src/app/shared/search/search-filters/search-filters.component.ts
#	src/app/shared/search/search-filters/themed-search-filters.component.ts
#	src/app/shared/search/search-labels/search-label-loader/search-label-loader.component.ts
#	src/app/shared/search/search-labels/search-label-loader/search-label-loader.decorator.ts
#	src/app/shared/search/search-labels/search-label-range/search-label-range.component.html
#	src/app/shared/search/search-labels/search-label-range/search-label-range.component.spec.ts
#	src/app/shared/search/search-labels/search-label-range/search-label-range.component.ts
#	src/app/shared/search/search-labels/search-label/search-label.component.html
#	src/app/shared/search/search-labels/search-label/search-label.component.spec.ts
#	src/app/shared/search/search-labels/search-label/search-label.component.ts
#	src/app/shared/search/search-labels/search-labels.component.ts
#	src/app/shared/search/search-sidebar/search-sidebar.component.html
#	src/app/shared/search/search-sidebar/search-sidebar.component.ts
#	src/app/shared/search/search-sidebar/themed-search-sidebar.component.ts
#	src/app/shared/search/search.component.html
#	src/app/shared/search/search.component.ts
#	src/app/shared/search/search.module.ts
#	src/app/shared/testing/search-configuration-service.stub.ts
#	src/assets/i18n/en.json5
2024-05-01 23:34:19 +02:00
Tim Donohue
0607878799 Merge pull request #2640 from hutattedonmyarm/regex-error-messages
More meaningful regex error messages
2024-05-01 16:20:22 -05:00
Tim Donohue
8c5fe13bb9 Merge pull request #2991 from tdonohue/remove_compose_version
Remove obsolete "version" tag from Docker Compose files (Angular version)
2024-05-01 15:04:59 -05:00
Tim Donohue
d6303de877 Remove obsolete "version" tag from compose files 2024-05-01 14:15:45 -05:00
Tim Donohue
81807da35b Merge pull request #2693 from hutattedonmyarm/2687-radio-buttons-type-bind
Enable type-bind for checkbox inputs during submission
2024-04-30 15:13:12 -05:00
Tim Donohue
41a00e3312 Merge pull request #2976 from 4Science/DURACOM-253
Fix issue with the admin sidebar scrollbar on Firefox/Windows
2024-04-30 12:26:49 -05:00
Tim Donohue
0fa5d189da Merge pull request #2865 from ybnd/poc-eslint-plugin-autofix-selectors
Introduce custom ESLint rules to apply and enforce new themed component selector convention
2024-04-30 12:03:46 -05:00
Alexandre Vryghem
25fd737800 111731: Added missing border to advanced search section 2024-04-30 15:52:29 +02:00
Alexandre Vryghem
f5dc187a93 111731: Minimize the facet filters when updating applied filters 2024-04-30 15:52:29 +02:00
Alexandre Vryghem
36ac6002cb 111731: Migrated the renderSearchLabelFor to standalone form 2024-04-30 13:48:14 +02:00
Alexandre Vryghem
f40a68f05e Merge remote-tracking branch 'upstream/main' into use-applied-filter-to-display-label-on-search_contribute-main
# Conflicts:
#	src/app/shared/search/search-labels/search-label/search-label.component.html
#	src/app/shared/search/search.component.html
2024-04-30 13:45:38 +02:00
Alexandre Vryghem
fb993477cc Merge branch 'main' into use-applied-filter-to-display-label-on-search_contribute-main
# Conflicts:
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-option/search-facet-option.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-option/search-facet-option.component.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-range-option/search-facet-range-option.component.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-selected-option/search-facet-selected-option.component.spec.ts
#	src/app/shared/search/search-filters/search-filter/search-facet-filter-options/search-facet-selected-option/search-facet-selected-option.component.ts
#	src/app/shared/search/search-filters/search-filter/search-filter.component.ts
#	src/app/shared/search/search-filters/search-filter/search-hierarchy-filter/search-hierarchy-filter.component.ts
#	src/app/shared/search/search-filters/search-filter/search-range-filter/search-range-filter.component.ts
#	src/app/shared/search/search-filters/search-filters.component.ts
#	src/app/shared/search/search-labels/search-label/search-label.component.spec.ts
#	src/app/shared/search/search-labels/search-label/search-label.component.ts
#	src/app/shared/search/search-labels/search-labels.component.ts
#	src/app/shared/search/search-sidebar/search-sidebar.component.ts
#	src/app/shared/search/search.component.html
#	src/app/shared/search/search.component.ts
#	src/app/shared/search/search.module.ts
2024-04-30 11:19:05 +02:00
Yury Bondarenko
a48d1991f4 Autofix: remove unneeded base component imports
This is part of the themed-component-usages rule; Themed* components already import the base component, we don't need to import both anymore.
You'll see that all of these changes are also reflected in the base component.

Double-checked and this doesn't compromise the fixes from https://github.com/DSpace/dspace-angular/pull/2984
2024-04-30 10:52:40 +02:00
Yury Bondarenko
c9d9e12fa2 Merge remote-tracking branch 'origin/main' into poc-eslint-plugin-autofix-selectors 2024-04-30 10:47:19 +02:00
Tim Donohue
a8f65cea72 Merge pull request #2710 from DSpace/bram-atmire-patch-1-2709
Update robots.txt.ejs
2024-04-29 16:29:18 -05:00
Tim Donohue
13dbd6ba30 Merge pull request #2675 from atmire/multiline-search-filter-badge_main
Multiline selected facet badge on search page
2024-04-29 15:12:46 -05:00
Tim Donohue
99bfe13c8e Merge pull request #2985 from atmire/w2p-114596_CreatingTemplateItemResultsInPageWhichNeverFinishesLoading
Fixed the problem that creating template item results in page which never finishes loading
2024-04-26 17:13:05 -05:00
Tim Donohue
3568acc696 Merge pull request #2984 from atmire/w2p-114732_CustomThemeNoLongerWorks
Synced the imports of the custom theme with the imports of the base component so custom theme works again
2024-04-26 16:56:43 -05:00
Kuno Vercammen
c5e3b18014 114624: Added small naming fix to e2e test 2024-04-26 13:40:00 +02:00
Kuno Vercammen
a1fd59f517 114732: Synced the imports of the custom theme with the imports of the base component 2024-04-26 11:19:53 +02:00
Yury Bondarenko
3a0c964a49 Upgrade @angular-eslint & get rid of warning in tests 2024-04-25 12:50:38 +02:00
Yury Bondarenko
348dcc47fd Generated docs should use Unix line endings on Windows 2024-04-25 12:30:53 +02:00
Yury Bondarenko
145a0a04b6 Fix lint plugins & tests on Windows 2024-04-25 11:52:12 +02:00