mirror of
https://github.com/DSpace/dspace-angular.git
synced 2025-10-07 01:54:15 +00:00
2.9 KiB
2.9 KiB
DSpace ESLint plugins > HTML rules > dspace-angular-html/themed-component-usages
Themeable components should be used via the selector of their ThemedComponent
wrapper class
This ensures that custom themes can correctly override all instances of this component. The only exception to this rule are unit tests, where we may want to use the base component in order to keep the test setup simple.
Examples
Valid code
use no-prefix selectors in HTML templates
<ds-test-themeable/>
<ds-test-themeable></ds-test-themeable>
<ds-test-themeable [test]="something"></ds-test-themeable>
use no-prefix selectors in TypeScript templates
@Component({
template: '<ds-test-themeable></ds-test-themeable>'
})
class Test {
}
use no-prefix selectors in TypeScript test templates
Filename: lint/test/fixture/src/test.spec.ts
@Component({
template: '<ds-test-themeable></ds-test-themeable>'
})
class Test {
}
base selectors are also allowed in TypeScript test templates
Filename: lint/test/fixture/src/test.spec.ts
@Component({
template: '<ds-base-test-themeable></ds-base-test-themeable>'
})
class Test {
}
Invalid code & automatic fixes
themed override selectors are not allowed in HTML templates
<ds-themed-test-themeable/>
<ds-themed-test-themeable></ds-themed-test-themeable>
<ds-themed-test-themeable [test]="something"></ds-themed-test-themeable>
Will produce the following error(s):
Themeable components should be used via their ThemedComponent wrapper's selector
Themeable components should be used via their ThemedComponent wrapper's selector
Themeable components should be used via their ThemedComponent wrapper's selector
Result of yarn lint --fix
:
<ds-test-themeable/>
<ds-test-themeable></ds-test-themeable>
<ds-test-themeable [test]="something"></ds-test-themeable>
base selectors are not allowed in HTML templates
<ds-base-test-themeable/>
<ds-base-test-themeable></ds-base-test-themeable>
<ds-base-test-themeable [test]="something"></ds-base-test-themeable>
Will produce the following error(s):
Themeable components should be used via their ThemedComponent wrapper's selector
Themeable components should be used via their ThemedComponent wrapper's selector
Themeable components should be used via their ThemedComponent wrapper's selector
Result of yarn lint --fix
:
<ds-test-themeable/>
<ds-test-themeable></ds-test-themeable>
<ds-test-themeable [test]="something"></ds-test-themeable>