Merge pull request #1545 from gethinode/radius

fix: improve init of color mode icons
Merge branch 'main' into radius
2025-10-17 23:13:11 +00:00 · 2025-08-24 14:02:11 +02:00 · 2025-08-24 13:56:27 +02:00 · 2025-08-24 13:55:43 +02:00 · 2025-08-22 10:42:12 +00:00 · 2025-08-22 12:26:58 +02:00
3 changed files with 25 additions and 14 deletions
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -57,7 +57,7 @@ jobs:
        # your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages
    steps:
    - name: Checkout repository
-      uses: actions/checkout@v4
+      uses: actions/checkout@v5

    # Add any setup steps before running the `github/codeql-action/init` action.
    # This includes steps like installing compilers or runtimes (`actions/setup-node`
--- a/assets/js/critical/color.js
+++ b/assets/js/critical/color.js
@@ -43,9 +43,7 @@
      document.documentElement.setAttribute('data-bs-theme', theme)
    }

-    document.querySelectorAll('.navbar-mode-selector').forEach(chk => {
-      chk.checked = (document.documentElement.getAttribute('data-bs-theme') === 'light')
-    })
+    updateSelectors()
  }

  // alternates the currently active theme
@@ -54,6 +52,12 @@
    setTheme(target)
  }

+  function updateSelectors() {
+    document.querySelectorAll('.navbar-mode-selector').forEach(chk => {
+      chk.checked = (document.documentElement.getAttribute('data-bs-theme') === 'light')
+    })
+  }
+
  window.matchMedia('(prefers-color-scheme: dark)').addEventListener('change', () => {
    if (storedTheme !== 'light' || storedTheme !== 'dark') {
      setTheme(getPreferredTheme())
@@ -69,7 +73,12 @@
    })
  })

-  // initialize theme directly when script is invoked
+  window.addEventListener('load', () => {
+    // update the selectors when all elements are ready
+    updateSelectors()
+  })
+
+  // initialize theme as soon as possible to reduce screen flickering
  setTheme(getTheme())
 })()

--- a/package-lock.json
+++ b/package-lock.json
@@ -3431,9 +3431,10 @@
      "license": "MIT"
    },
    "node_modules/brace-expansion": {
-      "version": "1.1.11",
-      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.11.tgz",
-      "integrity": "sha512-iCuPHDFgrHX7H2vEI/5xpz07zSHB00TpugqhmYtVmMO6518mCuRMoOYFldEBl0g187ufozdaHgWKcYFb61qGiA==",
+      "version": "1.1.12",
+      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-1.1.12.tgz",
+      "integrity": "sha512-9T9UjW3r0UW5c1Q7GTwllptXwhvYmEzFhzMfZ9H7FQWt+uZePjZPjBP/W1ZEyZ1twGWom5/56TF4lPcqjnDHcg==",
+      "license": "MIT",
      "dependencies": {
        "balanced-match": "^1.0.0",
        "concat-map": "0.0.1"
@@ -14036,9 +14037,9 @@
      }
    },
    "node_modules/purgecss/node_modules/brace-expansion": {
-      "version": "2.0.1",
-      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
-      "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
+      "version": "2.0.2",
+      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
+      "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
      "license": "MIT",
      "dependencies": {
        "balanced-match": "^1.0.0"
@@ -14652,10 +14653,11 @@
      }
    },
    "node_modules/rimraf/node_modules/brace-expansion": {
-      "version": "2.0.1",
-      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
-      "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
+      "version": "2.0.2",
+      "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.2.tgz",
+      "integrity": "sha512-Jt0vHyM+jmUBqojB7E1NIYadt0vI0Qxjxd2TErW94wDz+E2LAm5vKMXXwg6ZZBTHPuUlDgQHKXvjGBdfcF1ZDQ==",
      "dev": true,
+      "license": "MIT",
      "dependencies": {
        "balanced-match": "^1.0.0"
      }
Author	SHA1	Message	Date
Mark Dumay	0a6dbccb12	Merge pull request #1545 from gethinode/radius fix: improve init of color mode icons	2025-08-24 14:02:11 +02:00
Mark Dumay	c012eb5358	Merge branch 'main' into radius	2025-08-24 13:56:27 +02:00
Mark Dumay	bb2f1b63cf	fix: improve init of color mode icons	2025-08-24 13:55:43 +02:00
github-actions[bot]	d7facc353d	Merge pull request #1543 from gethinode/dependabot/npm_and_yarn/brace-expansion-1.1.12 build(deps): bump brace-expansion from 1.1.11 to 1.1.12	2025-08-22 10:42:12 +00:00
Mark Dumay	4dcae71516	Merge branch 'main' into dependabot/npm_and_yarn/brace-expansion-1.1.12	2025-08-22 12:26:58 +02:00
github-actions[bot]	bac2bed6ad	Merge pull request #1539 from gethinode/dependabot/github_actions/actions/checkout-5 build(deps): bump actions/checkout from 4 to 5	2025-08-22 10:09:14 +00:00
dependabot[bot]	56275d04dc	build(deps): bump brace-expansion from 1.1.11 to 1.1.12 Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](https://github.com/juliangruber/brace-expansion/compare/1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>	2025-08-22 10:00:16 +00:00
Mark Dumay	f32a958cf9	Merge branch 'main' into dependabot/github_actions/actions/checkout-5	2025-08-22 11:59:25 +02:00
dependabot[bot]	7386cf1fb9	build(deps): bump actions/checkout from 4 to 5 Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2025-08-18 17:35:32 +00:00