hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-17 15:03:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

don't run check_allowed until after block resolves

Browse Source 
avoids computing an unused value if blocked_pass is going to halt authorization anyway

no change in behavior
This commit is contained in:
Min RK
2024-01-26 11:24:42 +01:00
parent 041acbc0bf
commit 000b42bdcf
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
jupyterhub/auth.py
View File

@@ -535,14 +535,13 @@ class Authenticator(LoggingConfigurable):
blocked_pass = await maybe_future(
self.check_blocked_users(username, authenticated)
)
allowed_pass = await maybe_future(self.check_allowed(username, authenticated))
if blocked_pass:
pass
else:
if not blocked_pass:
self.log.warning("User %r blocked. Stop authentication", username)
return
allowed_pass = await maybe_future(self.check_allowed(username, authenticated))
if allowed_pass:
if authenticated['admin'] is None:
authenticated['admin'] = await maybe_future(