hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-15 14:03:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

admin: avoid redundant client-side username validation

Browse Source 
username validation is the server-side's responsibility
This commit is contained in:
Min RK
2022-08-16 13:48:36 +02:00
parent bb52351a6e
commit 8a1110f2c0
1 changed files with 5 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
jsx/src/components/EditUser/EditUser.jsx
View File

@@ -125,38 +125,12 @@ const EditUser = (props) => {
if (updatedUsername == "" && admin == has_admin) { if (updatedUsername == "" && admin == has_admin) {
noChangeEvent(); noChangeEvent();
return; return;
} else if (updatedUsername != "") {
if (
updatedUsername.length > 2 &&
/[!@#$%^&*(),.?":{}|<>]/g.test(updatedUsername) == false
) {
editUser(
username,
updatedUsername != "" ? updatedUsername : username,
admin
)
.then((data) => {
data.status < 300
? updateUsers(0, limit)
.then((data) => dispatchPageChange(data, 0))
.then(() => history.push("/"))
.catch(() =>
setErrorAlert(
`Could not update users list.`
)
)
: setErrorAlert(`Failed to edit user.`);
})
.catch(() => {
setErrorAlert(`Failed to edit user.`);
});
} else {
setErrorAlert(
`Failed to edit user. Make sure the username does not contain special characters.`
);
}
} else { } else {
editUser(username, username, admin) editUser(
username,
updatedUsername != "" ? updatedUsername : username,
admin
)
.then((data) => { .then((data) => {
data.status < 300 data.status < 300
? updateUsers(0, limit) ? updateUsers(0, limit)