hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-17 15:03:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stop specifying --ip and --port on the command-line

Browse Source 
JUPYTERHUB_SERVICE_URL env is already enough and has been around for some time

Specifying CLI args can cause some issues for custom entrypoints
This commit is contained in:
Min RK
2021-03-11 15:49:35 +01:00
parent 6535cc6bab
commit e75dd1b79c
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
jupyterhub/spawner.py
View File

@@ -999,17 +999,6 @@ class Spawner(LoggingConfigurable):
""" """
args = [] args = []
if self.ip:
args.append('--ip=%s' % _quote_safe(self.ip))
if self.port:
args.append('--port=%i' % self.port)
elif self.server and self.server.port:
self.log.warning(
"Setting port from user.server is deprecated as of JupyterHub 0.7."
)
args.append('--port=%i' % self.server.port)
if self.notebook_dir: if self.notebook_dir:
notebook_dir = self.format_string(self.notebook_dir) notebook_dir = self.format_string(self.notebook_dir)
args.append('--notebook-dir=%s' % _quote_safe(notebook_dir)) args.append('--notebook-dir=%s' % _quote_safe(notebook_dir))