hazza/jupyterhub
1
0
Fork 0
mirror of https://github.com/jupyterhub/jupyterhub.git synced 2025-10-08 10:34:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1454 from minrk/auto-login-logout

Browse Source 
typo rendering logout page when auto_login=True
This commit is contained in:
Carol Willing
2017-09-27 10:33:42 -07:00
committed by GitHub
parent 6bbfcdfe4f a0042e9302
commit f79b71727b
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
jupyterhub/handlers/login.py
View File

@@ -20,7 +20,7 @@ class LogoutHandler(BaseHandler):
self.clear_login_cookie() self.clear_login_cookie()
self.statsd.incr('logout') self.statsd.incr('logout')
if self.authenticator.auto_login: if self.authenticator.auto_login:
self.render('logout.html') self.render_template('logout.html')
else: else:
self.redirect(self.settings['login_url'], permanent=False) self.redirect(self.settings['login_url'], permanent=False)

13
jupyterhub/tests/test_pages.py
View File

@@ -344,6 +344,19 @@ def test_auto_login(app, request):
r = yield async_requests.get(base_url) r = yield async_requests.get(base_url)
assert r.url == public_url(app, path='hub/dummy') assert r.url == public_url(app, path='hub/dummy')
@pytest.mark.gen_test
def test_auto_login_logout(app):
name = 'burnham'
cookies = yield app.login_user(name)
with mock.patch.dict(app.tornado_application.settings, {
'authenticator': Authenticator(auto_login=True),
}):
r = yield async_requests.get(public_host(app) + app.tornado_settings['logout_url'], cookies=cookies)
r.raise_for_status()
logout_url = public_host(app) + app.tornado_settings['logout_url']
assert r.url == logout_url
assert r.cookies == {}
@pytest.mark.gen_test @pytest.mark.gen_test
def test_logout(app): def test_logout(app):