Commit Graph

5199 Commits

Author SHA1 Message Date
Simon Li
2bc3a22acc Merge pull request #3591 from jupyterhub/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2021-08-31 10:00:12 +01:00
pre-commit-ci[bot]
77a79484c4 [pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/asottile/pyupgrade: v2.24.0 → v2.25.0](https://github.com/asottile/pyupgrade/compare/v2.24.0...v2.25.0)
- [github.com/psf/black: 21.7b0 → 21.8b0](https://github.com/psf/black/compare/21.7b0...21.8b0)
2021-08-30 19:24:04 +00:00
Erik Sundell
5d6eb642d8 Merge pull request #3586 from consideRatio/pr/pyupgrade-3-add-config
Add pyupgrade --py36-plus to pre-commit config
2021-08-26 17:38:38 +02:00
Erik Sundell
0644677a6a Add pyupgrade --py36-plus to pre-commit config 2021-08-26 16:56:51 +02:00
Erik Sundell
409b72ff23 Merge pull request #3585 from consideRatio/pr/pyupgrade-2-rest
pyupgrade: run pyupgrade --py36-plus and black on all but tests
2021-08-26 16:55:50 +02:00
Erik Sundell
bc71ad6d73 Apply suggestions from code review
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
2021-08-26 16:23:38 +02:00
Erik Sundell
d6c48b15fe pyupgrade: run pyupgrade --py36-plus and black on all but tests 2021-08-26 16:23:38 +02:00
Erik Sundell
580d8fd9e2 Merge pull request #3584 from consideRatio/pr/pyupgrade-1-tests
pyupgrade: run pyupgrade --py36-plus and black on jupyterhub/tests
2021-08-26 16:23:17 +02:00
Erik Sundell
c8c7418ed2 pyupgrade: run pyupgrade --py36-plus and black on jupyterhub/tests 2021-08-26 16:05:18 +02:00
Min RK
2c62c4f7ef Merge pull request #3535 from minrk/pagination-gate
add opt-in model for paginated list results
2021-08-26 15:21:55 +02:00
Min RK
b38e3a05f4 symmetry in description of list:services scope 2021-08-26 15:17:30 +02:00
Min RK
ebc3b6f4e5 set minimum pagination limit to 1 2021-08-26 14:42:09 +02:00
Min RK
50219764a0 make order_by explicit in list endpoints
when implicit, ordering is not guaranteed (at least with postgres)
2021-08-24 13:56:11 +02:00
Min RK
d0c2bc051a test pagination limits on users endpoint 2021-08-24 13:56:11 +02:00
Min RK
911d1b5081 default to max page size if pagination is not explicitly requested
improves backward compatibility for clients that haven't implemented pagination
by requesting the max page size by default instead of the new default page size
2021-08-24 13:56:11 +02:00
Min RK
7f480445f6 warn about truncated replies without pagination 2021-08-24 13:56:11 +02:00
Min RK
fd644476a7 add opt-in model for paginated list results
use `Accept: application/jupyterhub-pagination+json`  to opt-in to the new response format

With a paginated API, we need to return pagination info (next page arguments, whether a next page exists, etc.),
but a simple list response doesn't give a good way to do that.

We can follow precedents and use a dict with an `items` field for the actual items,
and a `_pagination` field for info about pagination, including offset, limit, url for the next request
2021-08-24 13:56:11 +02:00
Min RK
8603723dbb add list:users|groups|services scopes
and govern GET /users|groups|services endpoints with these

Greatly simplifies filtering and pagination,
because these filters can be expressed in db filters,
unlike the potentially complex `read:users`.

Now the query itself will never return a model that should be excluded.

While writing the tests, I added more cleanup between tests.
We now ensure cleanup of all users and groups after each test,
which required updating some group tests which relied on this state leaking
2021-08-24 13:56:11 +02:00
Min RK
9f3663769e Merge pull request #3574 from jupyterhub/dependabot/npm_and_yarn/jsx/url-parse-1.5.3
Bump url-parse from 1.5.1 to 1.5.3 in /jsx
2021-08-24 13:27:52 +02:00
Min RK
1b1980c6bf Merge pull request #3582 from minrk/user-model-debug
Remove a couple every-request debug statements
2021-08-24 13:27:28 +02:00
Min RK
3f82a8ff00 Merge pull request #3581 from minrk/doc-override-server-role
[doc] add example specifying scopes for a default role
2021-08-24 13:25:04 +02:00
Min RK
e4dbc22cdf Remove a couple every-request debug statements
logging all scopes every request and for every user model retrieval gets noisy
2021-08-24 09:44:23 +02:00
Min RK
7533cb7602 [doc] add example specifying scopes for a default role 2021-08-24 09:04:08 +02:00
Min RK
dd7f035158 Merge pull request #3543 from dolfinus/fix_zombie_process
Avoid zombie processes in case of using LocalProcessSpawner
2021-08-23 11:06:26 +02:00
Min RK
59b2581370 Merge pull request #3565 from minrk/doc-waiting-server
Add detailed doc for starting/waiting for servers via api
2021-08-18 10:36:26 +02:00
Min RK
1cb4078fed Merge pull request #3564 from minrk/no-rm-servers
don't omit server model if it's empty
2021-08-18 10:36:02 +02:00
Min RK
9a8fec4060 Merge pull request #3572 from eruditehassan/patch-1
Improved Grammar for the Documentation
2021-08-18 10:35:02 +02:00
dependabot[bot]
ed10ac2433 Bump url-parse from 1.5.1 to 1.5.3 in /jsx
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.3.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.1...1.5.3)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-18 08:34:41 +00:00
Min RK
c60ec5a18e Merge pull request #3573 from jupyterhub/dependabot/npm_and_yarn/jsx/path-parse-1.0.7
Bump path-parse from 1.0.6 to 1.0.7 in /jsx
2021-08-18 10:34:08 +02:00
Yuvi Panda
441d0f0e52 Merge pull request #3558 from minrk/rm-deprecated-db
remove very old backward-compat for LocalProcess subclasses
2021-08-18 04:24:24 +05:30
dependabot[bot]
0ac8930270 Bump path-parse from 1.0.6 to 1.0.7 in /jsx
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-13 01:44:01 +00:00
Hassan Raza Bukhari
56c10e8799 Update README.md 2021-08-13 01:16:05 +05:00
Hassan Raza Bukhari
f6178ae51d Improved Grammar for the Documentation
Slight improvements in grammar were done in the ReadMe file.
2021-08-12 21:43:42 +05:00
Min RK
17ba49117c Merge pull request #3566 from nsshah1288/feature/shahn3_explicitRollback
explicit DB rollback for 500 errors
2021-08-10 15:36:19 +02:00
Min RK
3bcc542e27 finish up db rollback checks
- move catch_db_error to utils
- tidy catch/propagate errors in prepare, get_current_user
2021-08-10 15:03:41 +02:00
SHAHN3
044fb23a70 add explicit db rollback
add context manager/decorator for db rollback

add db rollback in top level prepare method

Co-authored-by: Sarath Babu <sbreached@gmail.com>
2021-08-10 14:49:37 +02:00
Min RK
9d96997eae Merge pull request #3568 from paccorsi/proxy-statsd-cmd
Stop injecting statsd parameters into the configurable HTTP proxy
2021-08-10 14:35:45 +02:00
Erik Sundell
7c471fa7e6 Merge pull request #3569 from dolfinus/auth_state_hook_exception_log
Fix wrong name of auth_state_hook in the exception log
2021-08-10 12:00:34 +02:00
Maxim Martynov
c5272604f2 Fix wrong name of auth_state_hook in the exception log 2021-08-10 12:38:27 +03:00
Pierre Accorsi
75e7c95d5c Stop injecting statsd parameters into the configurable HTTP proxy command 2021-08-09 17:07:44 -04:00
Min RK
a32986e9cc server-api doc: final touches 2021-08-06 10:55:43 +02:00
Yuvi Panda
1a1a60b02b Merge pull request #3559 from minrk/support-show-config
support inherited `--show-config` flags from base Application
2021-08-04 21:22:53 +05:30
Min RK
2cad292103 support inherited --show-config args from base traitlets.config.Application
inherits flags & aliases from base classes
2021-08-04 14:34:30 +02:00
Min RK
4f6fa3ddf7 Apply suggestions from code review
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
2021-08-04 14:11:17 +02:00
Min RK
b1b6a9e76c Add detailed doc for starting/stopping/waiting for servers via api
and complete implementation in examples/server-api
2021-08-04 12:49:12 +02:00
Min RK
add69e8b52 Merge pull request #3563 from minrk/404-user
ensure admin requests for missing users 404
2021-08-04 10:55:07 +02:00
Min RK
468738a3df don't omit server model if it's empty
if request has access to read servers, leave it present and empty

only omit it if there's no access to read server models
2021-08-03 20:44:09 +02:00
Min RK
e98890b9ca ensure admin requests for missing users 404 2021-08-03 20:23:12 +02:00
Erik Sundell
71e9767307 Merge pull request #3561 from minrk/rm-old-tasks
remove old, unused tasks.py
2021-08-03 12:38:06 +02:00
Erik Sundell
8c941d25cf Merge pull request #3562 from minrk/rm-distutils
remove use of deprecated distutils
2021-08-03 12:37:50 +02:00