Commit Graph

2419 Commits

Author SHA1 Message Date
Min RK
4729ae4769 tornado 5 fixes
- ._running private attribute is removed. We don't need it anymore,
  since we were only using it while the application was run in a background thread.
- call blocking cleanup in a thread because asyncio doesn't allow multiple loops in one thread.
2018-01-03 14:12:23 +01:00
Min RK
691c4c158f Merge pull request #1606 from willingc/test-readme
Add CHP to dev install and move to CONTRIBUTING
2018-01-03 11:52:27 +01:00
Carol Willing
3c597339ba Add CHP to dev install and move to CONTRIBUTING 2018-01-03 11:52:01 +01:00
Min RK
e5fe174e03 Merge pull request #1607 from willingc/travis-tornado
pin tornado requirement to less than 5.0
2018-01-03 11:50:18 +01:00
Carol Willing
1c25a9d026 pin tornado requirement to less than 5.0 2018-01-02 15:19:35 -08:00
Min RK
2db378e9c1 Merge pull request #1577 from minrk/session-cookie
add session-id cookie
2017-12-19 15:18:02 +01:00
Min RK
a4067ee681 clarify alembic's autogenerated comments [ci skip]
with reformatting
2017-12-19 15:13:44 +01:00
Min RK
edb0831028 check for table before upgrading
avoids raising error, which aborts transactions on postgres
2017-12-19 14:19:49 +01:00
Min RK
dac3b0a6f5 clear cookies for the right domain 2017-12-19 11:05:02 +01:00
Min RK
9a180cc8ad relax failed-upgrade check
since each backend raises a different error, only check that the errors are the same.
2017-12-19 10:54:05 +01:00
Min RK
e81764610e Merge pull request #1588 from willingc/doc-spawner
Clarify resource limits/guarantees in docs and docstrings
2017-12-19 10:50:04 +01:00
Carol Willing
e4e2b627fe add formatting to clarify spawners' limits 2017-12-18 04:43:26 -08:00
Carol Willing
ec55f56725 clarify resource limits in docstrings 2017-12-18 04:33:41 -08:00
Carol Willing
1e4f871bcc update documentation on resource limits 2017-12-18 04:33:01 -08:00
Matthias Bussonnier
69f72919bd Merge pull request #1587 from darky2004/master
Request to add a new JupyterHub service provider
2017-12-15 21:20:32 +01:00
darky2004
dc0336fa45 Update gallery-jhub-deployments.md 2017-12-13 20:36:04 +00:00
darky2004
8c341d262e Update gallery-jhub-deployments.md 2017-12-13 20:35:34 +00:00
Min RK
2b15464e12 make add_columns conditional on table presence
in database upgrade.

For multi-version upgrades (e.g. 0.7 -> 0.9)
2017-12-12 14:38:06 +01:00
Min RK
a686235ffb alembic: add target_metadata
needed for `python -m jupyterhub.dbutil revision --autogenerate -m 'note'`
2017-12-12 10:54:08 +01:00
Min RK
29171a4d05 test logout
verify that:

1. auth is cached
2. oauth tokens are revoked on logout
3. clearing session id avoids cached auth data
2017-12-11 14:20:25 +01:00
Min RK
e9123f55e0 make HubAuth a singleton
allows cache re-use in default case

otherwise, default behavior is to instantiate anew on each request, eliminating cache
2017-12-11 14:20:25 +01:00
Min RK
ee004486bd include session id in cache key
if session id is defined, clearing the session id clears the cache,
allowing immediate revocation of tokens by the Hub.
2017-12-11 14:20:25 +01:00
Min RK
498e234c37 add cache repr for debugging 2017-12-11 14:20:25 +01:00
Min RK
b29f19e206 add session_id for OAuth tokens
allows tracking and revoking tokens for a login session
2017-12-11 12:15:36 +01:00
Min RK
1e00343262 Merge pull request #1581 from yuvipanda/prometheus
Add RED prometheus metrics for all requests
2017-12-11 12:00:25 +01:00
yuvipanda
3cd526c019 Make sure our metrics don't appear & disappear intermittently
Create all timeseries from the beginning, regardless of wether
they happen or not. Also rename metric objects for consistency.
2017-12-10 21:23:32 -08:00
yuvipanda
ea99c58da5 Clarify custom bucket sizes for spawn time histogram 2017-12-10 17:04:44 -08:00
yuvipanda
c64f23a64a Add note about metric naming conventions 2017-12-10 17:04:10 -08:00
yuvipanda
2099cd37fa s/starttime/start_time/ 2017-12-10 17:00:15 -08:00
yuvipanda
2559632079 Expand prometheus related docstrings a bit more 2017-12-10 16:59:35 -08:00
yuvipanda
352df39454 Add version requirement for prometheus_client 2017-12-10 16:52:19 -08:00
yuvipanda
ce3a940b11 Add histogram metric for proxy route addition 2017-12-10 15:01:47 -08:00
yuvipanda
6594e88390 Add metric recording spawn durations
Try to hit every possible exit point from the spawn_single_server
method, with an appropriate status code.

The default histogram buckets are also meant for request latencies,
but spawning usually takes longer so we use custom buckets
2017-12-10 14:54:34 -08:00
yuvipanda
339758ec42 Add RED prometheus metrics for all requests
This patch introduces Prometheus for exposing metrics
about JupyterHub's operation. We expose a standard /metrics
endpoint that can be queried without authentication. We
take on prometheus_client as an unconditional dependency
to both simplify code & because it is a pure python package
with no dependencies itself.

The first pass adds 'RED' style metrics for all HTTP requests.
http://rancher.com/red-method-for-prometheus-3-key-metrics-for-monitoring/
has some info on the RED method, but to summarize:

  For each request type, record at least the following metrics

   Rate – the number of requests, per second, your services are serving.
   Errors – the number of failed requests per second.
   Duration – The amount of time each request takes expressed as a time interval.

This instantly gives us a lot of useful metrics in a very
compact form.
2017-12-10 14:40:11 -08:00
Carol Willing
0b4c7defd4 Merge pull request #1578 from johnkpark/fix-static-file-caching
remove , which was turning timestamp into tuple
2017-12-07 19:55:24 -06:00
John Park
6d71e9065b remove , which was turning timestamp into tuple 2017-12-07 11:28:40 -08:00
Carol Willing
631ab4d4eb Merge pull request #1575 from minrk/rm-catchlog
remove pytest-catchlog in favor of recent pytest
2017-12-07 08:31:46 -06:00
Min RK
589ff47ae6 Merge pull request #1555 from ankitml/docker-compose-file
base dockerfile on alpine linux
2017-12-07 10:23:08 +01:00
Min RK
877034d012 remove pytest-catchlog in favor of recent pytest
pytest-catchlog has been merged into pytest as of pytest 3.3
2017-12-07 10:21:04 +01:00
Carol Willing
3d440bf8f5 Merge pull request #1570 from minrk/sigterm
stop polling proxy process during shutdown
2017-12-04 18:43:09 -06:00
Ankit
138b2be010 updated CMD and jupyterhub version is put into argument 2017-12-04 11:41:56 -05:00
Min RK
b729944480 Merge pull request #1564 from jkinkead/admin_from_authenticator
Allow Authenticators to return an `admin` flag for users.
2017-12-04 10:47:42 +01:00
Min RK
870afd9fac stop polling proxy process during shutdown
avoids proxy being restarted by `.check_running` during cleanup
2017-12-04 10:40:08 +01:00
Carol Willing
e808814725 Merge pull request #1567 from danielballan/build-docs
CI: Verify that the docs build without warnings.
2017-12-01 17:14:40 -06:00
danielballan
122cf2250d CI: Require the docs to build without warnings. 2017-12-01 11:18:47 -05:00
danielballan
fa1d962507 CI: Verify that the documentation builds. 2017-12-01 11:18:46 -05:00
Jesse Kinkead
6504692c5c Commit when setting admin, but only if the field changed. 2017-11-30 11:21:09 -08:00
Carol Willing
bd36962643 Merge pull request #1563 from jkinkead/patch-2
Include instructions for increasing test timeout.
2017-11-29 16:57:55 -06:00
Jesse Kinkead
f5ccfc3f8a Use travis timeout; expand documentation on timeout. 2017-11-29 14:46:18 -08:00
Jesse Kinkead
c1a7e0513b Allow Authenticators to return an admin flag for users. 2017-11-29 14:07:08 -08:00