Min RK
e9123f55e0
make HubAuth a singleton
...
allows cache re-use in default case
otherwise, default behavior is to instantiate anew on each request, eliminating cache
2017-12-11 14:20:25 +01:00
Min RK
ee004486bd
include session id in cache key
...
if session id is defined, clearing the session id clears the cache,
allowing immediate revocation of tokens by the Hub.
2017-12-11 14:20:25 +01:00
Min RK
498e234c37
add cache repr for debugging
2017-12-11 14:20:25 +01:00
Min RK
b29f19e206
add session_id for OAuth tokens
...
allows tracking and revoking tokens for a login session
2017-12-11 12:15:36 +01:00
Min RK
1e00343262
Merge pull request #1581 from yuvipanda/prometheus
...
Add RED prometheus metrics for all requests
2017-12-11 12:00:25 +01:00
yuvipanda
3cd526c019
Make sure our metrics don't appear & disappear intermittently
...
Create all timeseries from the beginning, regardless of wether
they happen or not. Also rename metric objects for consistency.
2017-12-10 21:23:32 -08:00
yuvipanda
ea99c58da5
Clarify custom bucket sizes for spawn time histogram
2017-12-10 17:04:44 -08:00
yuvipanda
c64f23a64a
Add note about metric naming conventions
2017-12-10 17:04:10 -08:00
yuvipanda
2099cd37fa
s/starttime/start_time/
2017-12-10 17:00:15 -08:00
yuvipanda
2559632079
Expand prometheus related docstrings a bit more
2017-12-10 16:59:35 -08:00
yuvipanda
352df39454
Add version requirement for prometheus_client
2017-12-10 16:52:19 -08:00
yuvipanda
ce3a940b11
Add histogram metric for proxy route addition
2017-12-10 15:01:47 -08:00
yuvipanda
6594e88390
Add metric recording spawn durations
...
Try to hit every possible exit point from the spawn_single_server
method, with an appropriate status code.
The default histogram buckets are also meant for request latencies,
but spawning usually takes longer so we use custom buckets
2017-12-10 14:54:34 -08:00
yuvipanda
339758ec42
Add RED prometheus metrics for all requests
...
This patch introduces Prometheus for exposing metrics
about JupyterHub's operation. We expose a standard /metrics
endpoint that can be queried without authentication. We
take on prometheus_client as an unconditional dependency
to both simplify code & because it is a pure python package
with no dependencies itself.
The first pass adds 'RED' style metrics for all HTTP requests.
http://rancher.com/red-method-for-prometheus-3-key-metrics-for-monitoring/
has some info on the RED method, but to summarize:
For each request type, record at least the following metrics
Rate – the number of requests, per second, your services are serving.
Errors – the number of failed requests per second.
Duration – The amount of time each request takes expressed as a time interval.
This instantly gives us a lot of useful metrics in a very
compact form.
2017-12-10 14:40:11 -08:00
Carol Willing
0b4c7defd4
Merge pull request #1578 from johnkpark/fix-static-file-caching
...
remove , which was turning timestamp into tuple
2017-12-07 19:55:24 -06:00
John Park
6d71e9065b
remove , which was turning timestamp into tuple
2017-12-07 11:28:40 -08:00
Carol Willing
631ab4d4eb
Merge pull request #1575 from minrk/rm-catchlog
...
remove pytest-catchlog in favor of recent pytest
2017-12-07 08:31:46 -06:00
Min RK
589ff47ae6
Merge pull request #1555 from ankitml/docker-compose-file
...
base dockerfile on alpine linux
2017-12-07 10:23:08 +01:00
Min RK
877034d012
remove pytest-catchlog in favor of recent pytest
...
pytest-catchlog has been merged into pytest as of pytest 3.3
2017-12-07 10:21:04 +01:00
Carol Willing
3d440bf8f5
Merge pull request #1570 from minrk/sigterm
...
stop polling proxy process during shutdown
2017-12-04 18:43:09 -06:00
Ankit
138b2be010
updated CMD and jupyterhub version is put into argument
2017-12-04 11:41:56 -05:00
Min RK
b729944480
Merge pull request #1564 from jkinkead/admin_from_authenticator
...
Allow Authenticators to return an `admin` flag for users.
2017-12-04 10:47:42 +01:00
Min RK
870afd9fac
stop polling proxy process during shutdown
...
avoids proxy being restarted by `.check_running` during cleanup
2017-12-04 10:40:08 +01:00
Carol Willing
e808814725
Merge pull request #1567 from danielballan/build-docs
...
CI: Verify that the docs build without warnings.
2017-12-01 17:14:40 -06:00
danielballan
122cf2250d
CI: Require the docs to build without warnings.
2017-12-01 11:18:47 -05:00
danielballan
fa1d962507
CI: Verify that the documentation builds.
2017-12-01 11:18:46 -05:00
Jesse Kinkead
6504692c5c
Commit when setting admin
, but only if the field changed.
2017-11-30 11:21:09 -08:00
Carol Willing
bd36962643
Merge pull request #1563 from jkinkead/patch-2
...
Include instructions for increasing test timeout.
2017-11-29 16:57:55 -06:00
Jesse Kinkead
f5ccfc3f8a
Use travis timeout; expand documentation on timeout.
2017-11-29 14:46:18 -08:00
Jesse Kinkead
c1a7e0513b
Allow Authenticators to return an admin
flag for users.
2017-11-29 14:07:08 -08:00
Jesse Kinkead
af71e79371
Include instructions for increasing test timeout.
2017-11-29 13:05:01 -08:00
Min RK
bf911cf3a5
Merge pull request #1545 from ankitksharma/patch-1
...
Publish exposed port in docker run command
2017-11-29 18:15:46 +01:00
Carol Willing
6059a1c444
Merge pull request #1562 from minrk/external-proxy-test
...
wait for proxy to exit in test_external_proxy
2017-11-29 09:03:22 -06:00
Min RK
c4966a4bf2
Merge pull request #1561 from GladysNalvarte/master
...
test token and error pages
2017-11-29 15:24:44 +01:00
Min RK
cb9f356a69
wait for proxy to exit in test_external_proxy
...
.terminate() only sends the signal,
it doesn't wait for the process to exit.
If the process doesn't exit promptly,
the next instance may try to grab the port before the previous process has released it,
causing failure with EADDRINUSE.
2017-11-29 15:22:45 +01:00
Gladys Nalvarte
9d02f6a408
test_token and error pages
2017-11-28 10:09:39 +01:00
Min RK
ee76772e1b
Merge pull request #1560 from GladysNalvarte/version-test
...
Version test
2017-11-27 12:56:42 +01:00
Min RK
f0a030a86d
Merge pull request #1531 from thedataincubator/start_all_button
...
"Start All" button on admin page
2017-11-27 12:52:26 +01:00
Min RK
1a31e56f33
Merge pull request #1532 from minrk/npm-permissions
...
setup.py: run npm with --unsafe-perm
2017-11-27 12:52:06 +01:00
Gladys Nalvarte
04e9e0e687
test check_version
...
add coverage for different cases
2017-11-23 15:14:57 +01:00
Min RK
cec917c2a2
scaffolding for testing version checking
2017-11-23 10:55:35 +01:00
Carol Willing
08989a8797
Merge pull request #1557 from minrk/extra-log-file-warning
...
deprecate extra_log_file
2017-11-22 08:19:40 -08:00
Min RK
b734c331e4
deprecate extra_log_file
...
and add loud warning about discarding information
this has been the cause of many debugging difficulties,
when redirecting output seems to be a better option in ~all cases.
2017-11-22 17:02:43 +01:00
Matthias Bussonnier
fe477a6809
Merge pull request #1554 from smiller5678/remove-redirect-url-param-from-error-pages
...
Remove redirect url parameter from error pages
2017-11-21 23:05:47 +01:00
Carol Willing
6391a4a7f7
Merge pull request #1552 from cfournie/extendable_script_block
...
Add super() calls to child script blocks
2017-11-21 12:35:08 -08:00
Carol Willing
e68220d4b3
Merge pull request #1553 from syutbai/master
...
Add doc for building docs locally.
2017-11-21 12:21:28 -08:00
Ankit
b873149f9b
updated alpine according to PR comments
2017-11-21 14:04:25 -05:00
Seak Pek Chhan
86aebbcaea
Switch to python3 -m pip install instead of calling pip directly, move cd docs closer to make commands.
2017-11-21 14:02:07 -05:00
Ankit
fd260cf32f
updated base name
2017-11-21 13:58:22 -05:00
Min RK
69101a5b14
Merge pull request #1533 from DerekHeldtWerle/master
...
If spawner is pending, always route to /hub/home/:user to resolve iss…
2017-11-21 19:54:51 +01:00