Commit Graph

371 Commits

Author SHA1 Message Date
YuviPanda
b4a760234e Tweak user_redirect_hook API
- Pass in user object & request object only explicitly.
  Much better interface that is harder to break by internal
  refactoring. We can always add more  parameters if needed?
2019-10-21 14:29:59 -07:00
YuviPanda
400c64b4ef Allow admins to customize /user-redirect/ behavior
/user-redirect/ is used to help link to a particular url
in the logged in user's authenticated notebook. For example,
if I'm logged in as user 'yuvipanda' and hit the URL
/hub/user-redirect/git-pull, it'll redirect me to
/user/yuvipanda/git-pull. This is extremely useful in
connecting hub links to notebook server extensions, such
as nbgitpuller.

Admins might want to customize how this redirection is done -
for example, redirect users to different running servers
based on the nbgitpuller repository they are linking from.
Adding a hook here helps accomplish that.
2019-10-20 11:33:24 -07:00
Rajat Goyal
44dccb292f Apply suggestions from code review: Re-raise error after measuring time; Catch Exception class
Co-Authored-By: Min RK <benjaminrk@gmail.com>
2019-10-20 16:00:33 +05:30
rajat404
175c8d0585 Add prometheus metric to measure proxy route deletion times 2019-10-19 11:47:55 +05:30
R. C. Thomas
bc425a78bb Keep admin-enabled services in the list 2019-10-17 18:27:47 -07:00
R. C. Thomas
e0c4f9fc23 No services accessible if user is None
Co-Authored-By: Min RK <benjaminrk@gmail.com>
2019-10-17 18:23:34 -07:00
Rollin Thomas
cd0b3e05e2 Add service links 2019-10-05 10:59:59 -07:00
Min RK
ca00c0eab0 Merge pull request #2698 from Zsailer/eventlog-tests
Instrument JupyterHub to record events with jupyter_telemetry [Part II]
2019-09-24 11:08:45 +02:00
Min RK
54baa0c31a Merge pull request #2721 from minrk/async-init-spawners
Add JupyterHub.init_spawners_timeout
2019-09-24 11:08:16 +02:00
Min RK
ac32ae496e run pre-commit hook 2019-09-19 15:51:02 +02:00
Min RK
74958d9397 catch some CancelledErrors
which can occur during app shutdown
2019-08-28 19:02:58 +02:00
Aaron Huang
2b6ad596d2 Remove user after login cookie cleared
Signed-off-by: Aaron Huang <aaroms9733@gmail.com>
2019-08-27 22:09:18 +08:00
yuvipanda
dcde4020c2 Use EventLog class from jupyter_telemetry
Full circle, since the code in jupyter_telemetry
came from here: https://github.com/jupyter/telemetry/pull/6
2019-08-22 11:05:10 -07:00
yuvipanda
41b2e6e401 Add eventlogging infrastructure
- Introduce the EventLog class from BinderHub for emitting
  structured event data
- Instrument server starts and stops to emit events
- Defaults to not saving any events anywhere
2019-08-22 11:05:10 -07:00
Nico Rikken
b37b13a939 chore: satisfy black checker 2019-07-17 11:05:35 +02:00
Nico Rikken
9d2823e84b fix: user.escaped_name in base.py urls 2019-07-17 09:37:10 +02:00
GeorgianaElena
97c27774b1 fixed running_servers count 2019-07-04 13:23:32 +03:00
Tim Head
f7f82b8214 add activity_resolution config (#2605)
add activity_resolution config
2019-06-19 08:14:09 +02:00
Bruno P. Kinoshita
5e5a976ea6 Replace existing redirect code by Tornado's addslash decorator 2019-06-12 15:27:23 +12:00
Min RK
1cea503292 add activity_resolution config
limits last_activity update interval to 30 seconds by default to avoid a db commit on every authenticated request
2019-06-07 11:44:57 +02:00
Min RK
be97a0c95b Further login redirect validation 2019-04-01 12:29:29 +02:00
Min RK
6e14e86a1a protect against some browsers' buggy handling of backslash as slash 2019-03-28 13:33:23 +01:00
Rollin Thomas
6ff421061d Strip leading / and get server name 2019-03-26 08:17:39 -07:00
Rollin Thomas
0901fa255f Remove log testing messages 2019-03-25 15:05:45 -07:00
Rollin Thomas
3e5b272b80 Server name is second element 2019-03-25 14:50:39 -07:00
Rollin Thomas
693446dba9 Log messages 2019-03-25 13:35:29 -07:00
Carol Willing
76eabb2de8 comment
Co-Authored-By: minrk <benjaminrk@gmail.com>
2019-03-07 10:30:36 +01:00
Carol Willing
5d5ebb2583 docstring clarification
Co-Authored-By: minrk <benjaminrk@gmail.com>
2019-03-07 10:27:20 +01:00
Min RK
89c85aca37 if no referer is given, assume the worst
only way to avoid redirect loops if referers are not set (e.g. python requests)
2019-02-27 15:21:22 +01:00
Min RK
8ea5a957a6 only start ?redirects counter if we are starting from a /user/:name -> /hub/user/:name redirect 2019-02-27 11:13:10 +01:00
Min RK
db3f62b79a try harder to make a useful error message when API requests are made to a not-running server
include link to spawn page
2019-02-26 11:57:36 +01:00
Min RK
f8add6ae6d fix local-redirect check for subdomains 2019-02-26 11:56:28 +01:00
Min RK
1185619bf6 update tests for changed redirects
- handle 503 on not running /hub/user/:name
- handle new spawn-redirect page
2019-02-25 15:43:50 +01:00
Min RK
947b9b1a9e rework handing of /user/:name
- /user/:name no longer triggers implicit spawn at any point
- add /spawn-pending/:user/:server handler for pending page. This page has no side effects.
- spawn links point to /spawn/:user/:server to finish hooking up links for named servers and options_form handling
2019-02-25 14:21:34 +01:00
Min RK
de20c3f3a7 accept default argument in get_next_url
allows different defaults for different contexts
2019-02-25 13:41:38 +01:00
Min RK
5e60582ef3 run autoformat
apologies to anyone finding this commit via git blame or log

run the autoformatting by

    pre-commit run --all-files
2019-02-19 17:00:10 +01:00
Min RK
a7c3ea0906 Merge pull request #2346 from minrk/push-activity
push last_activity to the hub
2019-02-15 11:16:12 +01:00
Erik Sundell
fb4c920996 Allow callable options_form to return an empty form
Closes #2390

This is meant to allow us dynamically decide to bypass the option form
even though it is a async function that in itself evaluates truthy.
2019-02-14 16:49:27 +01:00
Min RK
dcdb8d8a89 add missing trailing slash in / -> /hub/ redirect 2019-02-11 17:29:45 +01:00
Min RK
33a139861b notmybestwork: avoid updating user activity with server api access
this isn't the most important metric (server.last_activity is),
but avoid *probable* server api access incrementing user.last_activity
2019-02-11 16:18:37 +01:00
Min RK
00cafc8392 Merge pull request #2342 from minrk/expire-auth
allow auth to expire
2019-02-05 13:05:00 +01:00
Min RK
b5aa53fe7b only refresh auth of Users 2019-02-04 12:57:10 +01:00
Daisuke Taniwaki
b34bdd2846 Limit max named server per user 2019-01-19 15:48:35 +09:00
Min RK
1431c5a21a test coverage for auth expiry 2019-01-04 11:54:20 +01:00
Min RK
c009b39795 auth_refresh_age is on Authenticator 2019-01-03 12:36:47 +01:00
Min RK
563106c0d2 allow auth to expire
adds Authenticator.auth_refresh_age and Authenticator.refresh_pre_spawn config

- auth_refresh_age allows auth to expire (default: 5 minutes) before calling Authenticator.refresh_user.
- refresh_pre_spawn forces refresh prior to spawn (in case of auth tokens, etc.)
2018-12-14 15:27:38 +01:00
Alejandro del Castillo
df98fb012e refresh_user: add handler parameter
The current request handler might be needed to determine if the auth
data needs to be refreshed.

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
2018-11-15 13:21:24 -06:00
Kristiyan
2070c8c102 improve condition when failing api request, check if user exists, afterwards check if user is not active 2018-11-09 18:17:40 +01:00
Min RK
fe5ca1a67e Merge branch 'master' into jupyter_2105 2018-10-19 09:31:45 +02:00
tuhina2020
b0b7e8d25d add metrics_authentication decorator to /metrics API 2018-10-07 13:38:32 +05:30