yuvipanda
e1deecbbfb
Add role=button attribute to all <a> & <span> buttons
...
Simple accessibility win - screen readers will now be
able to properly present these as buttons than links.
2017-08-27 11:17:22 -04:00
Min RK
e1531ec277
Merge pull request #1366 from minrk/typo
...
typo in proxy recovery
2017-08-26 20:21:51 -04:00
Min RK
d12ac4b1f6
typo in proxy recovery
...
should have been the dict of instantiated services, not the list of service configurations
2017-08-26 15:25:17 -04:00
Min RK
17851b7586
0.8.0b3
2017-08-26 13:51:12 -04:00
Min RK
118e2fa610
Merge pull request #1364 from minrk/test-start-stop-race
...
exercise start/stop race conditions
2017-08-26 13:37:41 -04:00
Min RK
8e3553462c
exercise start/stop race conditions
...
this doesn’t cover all the edge cases of each possible stage for the races, but it gets the basics covered.
2017-08-26 11:57:05 -04:00
Carol Willing
37da47d811
Merge pull request #1356 from minrk/proxy-race
...
rework spawn futures to fix races
2017-08-26 11:07:55 -04:00
Min RK
a640a468fb
Merge pull request #1362 from stuartcampbell/master
...
Improve help comments for SSL key/certs configuration parameters
2017-08-26 09:41:47 -04:00
Min RK
92f034766e
Merge pull request #1355 from minrk/update-oauth-secret
...
update oauth secret if API tokens change
2017-08-26 09:41:14 -04:00
Min RK
f7ea451df8
get the tests running
2017-08-25 18:12:15 -04:00
Stuart Campbell
1b7f54b462
Make SSL cert/key help clearer.
2017-08-25 14:52:23 -04:00
Stuart Campbell
b14b12231a
Correct typo to have consistent comments
2017-08-24 16:53:25 -04:00
Min RK
2866be9462
don’t allow start while stop is pending
...
- start fails with 400 if stop is pending
- set spawn_pending across a whole spawn (including proxy)
- proxy_pending is only around the proxy
2017-08-23 23:35:19 -04:00
Min RK
f8648644bf
ensure _stop_pending is always True on stop_single_user
...
previously there was a race during `delete_route`
apply the same logic as _start_pending
2017-08-23 18:30:49 -04:00
Min RK
69d4d48db0
rework spawn futures to fix races
...
1. set _proxy_pending before first wait to ensure that there is never a gap between setting spawn flags
2. always call `finish_user_spawn` to reduce the number of finalization cases
3. wait for proxy to finish on the slow_spawn timeout, not just start, because we are only interested in the total duration for page responsiveness
2017-08-21 11:27:30 +02:00
Min RK
df309749f2
update oauth secret if API tokens change
...
handle will_resume case correctly, where an API token *may* be re-used.
Previously, we only did it right if the token was *always* reused,
but clearing out a container would get it into a bad state.
2017-08-21 11:23:17 +02:00
Min RK
58751067db
Merge pull request #1354 from minrk/log-typo
...
typo: use app_log, not self.log
2017-08-20 15:49:56 +02:00
Min RK
4fd70cf79b
app_log typo
2017-08-20 15:48:55 +02:00
Carol Willing
ff15bad375
Merge pull request #1353 from minrk/log-connection-error
...
log error when failing to connect to Hub
2017-08-20 10:45:32 +02:00
Min RK
90ac4ab6fe
0.8.0b2
2017-08-20 10:11:45 +02:00
Min RK
cba5bb1676
log error when failing to connect to Hub
...
for better diagnosis
2017-08-20 10:03:52 +02:00
Min RK
4b5fa404fc
Merge pull request #1352 from minrk/singleuser-image
...
build jupyterhub/singleuser on this repo
2017-08-20 09:45:54 +02:00
Min RK
c4ac1240ac
Merge pull request #1347 from minrk/re-use-token
...
handle and test a few unlikely cases when Spawners reuse tokens
2017-08-20 09:45:35 +02:00
Min RK
d384ad2700
ensure notebook is installed
2017-08-18 17:57:53 +02:00
Min RK
c3da0b8073
include singleuser in sdists
2017-08-18 17:55:00 +02:00
Min RK
9919cba375
add BASE_IMAGE as a build arg
2017-08-18 17:45:35 +02:00
Min RK
1e6b94de92
add singleuser build dir from dockerspawner
2017-08-18 17:36:08 +02:00
Min RK
8451a4cd08
clarify and simplify api token tests
2017-08-18 13:09:41 +02:00
Carol Willing
48f1da1b8d
Merge pull request #1348 from minrk/oauth-state
...
use state field for internal OAuth
2017-08-17 19:22:11 +02:00
Carol Willing
e20050b719
Merge pull request #1346 from minrk/test-admin-sort
...
Fix (and test!) sorting of admin page
2017-08-17 19:12:37 +02:00
Min RK
a9c0a46a06
add missing classes to services.auth
2017-08-17 17:29:45 +02:00
Min RK
03bb094b90
update service-whoami examples to include OAuth
2017-08-17 17:29:45 +02:00
Min RK
5d0d552c26
fix check for service startup
2017-08-17 17:29:45 +02:00
Min RK
2d50cef098
implement state handling in HubOAuth
2017-08-17 17:29:45 +02:00
Min RK
d6d0b83b4e
remove redundant oauth callback implementation in singleuser
2017-08-17 17:29:45 +02:00
Min RK
f1dbeda451
regenerate cookie_secret on every single-user spawn
...
ensures that singleuser cookies do not persist across single-user instances
relaunching a singleuser instance invalidates all cookies used with that instance
2017-08-17 17:29:45 +02:00
Min RK
512bbae5cb
handle and test a few unlikely cases when Spawners reuse tokens
...
- test that .will_resume preserves tokens (worked, but wasn't tested)
If a Spawner reuses a token, validate it in the db:
- verify that it's in the db
- if it doesn't map onto the right user, revoke the token
- if it's not in the db, insert it as a user-provided token
The most likely case is prior unclean shutdown of something like DockerSpawner,
where a spawn failed and thus the token was revoked,
but the container was in fact created.
2017-08-17 17:29:33 +02:00
Min RK
8c575d40af
fix sort-by-running on admin page
...
server_id is on Spawner, not User anymore
2017-08-17 17:29:19 +02:00
Min RK
d6b9909bc6
test admin page sort order
...
just exercise the handler, sort results are not verified
2017-08-17 17:29:19 +02:00
Min RK
ef7d6dc091
Merge pull request #1350 from minrk/allow-fail-nightly
...
allow failures on python: nightly
2017-08-17 17:27:54 +02:00
Min RK
57f707bbfd
allow failures on python: nightly
...
since they break stuff sometimes.
2017-08-17 17:27:07 +02:00
Min RK
0ae7213366
Merge pull request #1344 from minrk/0.8-changes
...
Start drafting 0.8 changelog
2017-08-17 17:24:05 +02:00
Min RK
22ff7aa672
begin 0.8 changelog
...
most of the changes I could find!
2017-08-17 17:21:48 +02:00
Carol Willing
ca579fbf4a
Merge pull request #1342 from willingc/toc-tweak
...
Add detail to tutorials toc section
2017-08-16 15:52:22 +02:00
Carol Willing
f2eb30d090
Add detail to tutorials toc section
2017-08-16 15:41:22 +02:00
Min RK
63a4b4744b
Merge pull request #1335 from willingc/upgrade-08
...
Add upgrade to 0.8 doc
2017-08-15 18:09:12 +02:00
Min RK
e03b5b3992
Merge pull request #1340 from zonca/patch-2
...
Fix broken jupyterhub getting started link
2017-08-15 18:08:56 +02:00
Min RK
fa4a27fb1a
0.8.0b1
2017-08-15 18:06:58 +02:00
Andrea Zonca
d3a6aa2471
Fix broken jupyterhub getting started link
2017-08-14 16:02:40 -05:00
Carol Willing
8bd64cff59
Merge pull request #1338 from willingc/update-conrtib
...
Update contributor list [ci skip]
2017-08-13 16:31:50 -07:00
