1
0

115428: Fixed EventEmitter being triggered multiple times because its name was the same as a standard DOM event

(cherry picked from commit 4d89a11943)
This commit is contained in:
Alexandre Vryghem
2024-05-27 17:22:04 +02:00
committed by github-actions[bot]
parent a3a298f51e
commit a77d80946b
4 changed files with 5 additions and 5 deletions

View File

@@ -2,7 +2,7 @@
<ds-sidebar-dropdown
[id]="'search-sidebar-rpp'"
[label]="'search.sidebar.settings.rpp'"
(change)="reloadRPP($event)"
(changed)="reloadRPP($event)"
>
<option *ngFor="let pageSizeOption of (paginationOptions$ | async).pageSizeOptions"
[value]="pageSizeOption"
@@ -10,4 +10,4 @@
{{pageSizeOption}}
</option>
</ds-sidebar-dropdown>
</div>
</div>

View File

@@ -4,7 +4,7 @@
<ds-sidebar-dropdown *ngIf="sortOptionsList"
[id]="'search-sidebar-sort'"
[label]="'search.sidebar.settings.sort-by'"
(change)="reloadOrder($event)">
(changed)="reloadOrder($event)">
<option *ngFor="let sortOptionsEntry of sortOptionsList"
[value]="sortOptionsEntry.field + ',' + sortOptionsEntry.direction.toString()"
[selected]="sortOptionsEntry.field === currentSortOption?.field && sortOptionsEntry.direction === (currentSortOption?.direction)? 'selected': null">

View File

@@ -1,6 +1,6 @@
<div class="setting-option mb-3 p-3">
<h4><label for="{{id}}">{{label | translate}}</label></h4>
<select id="{{id}}" class="form-control" (change)="change.emit($event)">
<select id="{{id}}" class="form-control" (change)="changed.emit($event)">
<ng-content></ng-content>
</select>
</div>

View File

@@ -12,5 +12,5 @@ import { Component, EventEmitter, Input, Output } from '@angular/core';
export class SidebarDropdownComponent {
@Input() id: string;
@Input() label: string;
@Output() change: EventEmitter<any> = new EventEmitter<number>();
@Output() changed: EventEmitter<any> = new EventEmitter<number>();
}