Compare commits

..

8595 Commits

Author SHA1 Message Date
dependabot[bot]
832b641b40 Bump org.scala-lang:scala-library from 2.13.16 to 2.13.17
Bumps [org.scala-lang:scala-library](https://github.com/scala/scala) from 2.13.16 to 2.13.17.
- [Release notes](https://github.com/scala/scala/releases)
- [Commits](https://github.com/scala/scala/compare/v2.13.16...v2.13.17)

---
updated-dependencies:
- dependency-name: org.scala-lang:scala-library
  dependency-version: 2.13.17
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-01 02:36:55 +00:00
Tim Donohue
6ac823d29a Merge pull request #11358 from DSpace/backport-11330-to-dspace-7_x
[Port dspace-7_x] Fix (#9694): Change Solr dynamic field *.year to *_year
2025-09-30 17:29:57 -05:00
JohnnyMendesC
0246588ab5 Fix (#9694): Change Solr dynamic field *.year to *_year
(cherry picked from commit 9fc163fbda)
2025-09-30 21:44:34 +00:00
Tim Donohue
190b908a8a Merge pull request #11355 from DSpace/backport-11328-to-dspace-7_x
[Port dspace-7_x] Fix Hibernate syntax bug in the CollectionDAO
2025-09-30 16:38:57 -05:00
nwoodward
f8ac04b591 lint fixes
(cherry picked from commit b8812aad45)
2025-09-30 21:07:21 +00:00
nwoodward
23cd582801 fix hibernate syntax bug
(cherry picked from commit d9cbb96655)
2025-09-30 21:07:21 +00:00
Tim Donohue
c100eb2567 Merge pull request #11344 from tdonohue/port_11341_to_7x
[Port dspace-7_x] [GitHub Actions] Decrease cache size of our Docker images in GitHub Actions
2025-09-23 16:39:24 -05:00
Tim Donohue
de50420624 Change to "mode=min" in order to minimize our cache size for Docker images 2025-09-23 15:54:55 -05:00
Tim Donohue
988a67d8fe Merge pull request #11338 from DSpace/backport-11337-to-dspace-7_x
[Port dspace-7_x] Remove ratingreviewaction in workflow-actions.xml
2025-09-23 15:09:35 -05:00
Sascha Szott
7a95781068 remove ratingreviewaction in test context
(cherry picked from commit ddccb342d6)
2025-09-23 18:47:37 +00:00
Sascha Szott
cad7e9397b remove ratingreviewaction bean in workflow-actions.xml
(cherry picked from commit 770ab0ca79)
2025-09-23 18:47:36 +00:00
Tim Donohue
f84ddb541d Merge pull request #11318 from tdonohue/port_11261_to_7x
[Port dspace-7_x] Fix/11033 solr logging thumbnail download stats
2025-09-12 16:14:56 -05:00
Tim Donohue
45fa8277d8 Merge pull request #11312 from DSpace/backport-10756-to-dspace-7_x
[Port dspace-7_x] The subscription sends an email with `No items` however there are changes in the collection
2025-09-12 15:58:40 -05:00
JohnnyMendesC
d4c826d871 fix(#11033): Prevent logging of ignored bundles in Solr stats 2025-09-12 15:03:15 -05:00
jm
ee5093b6a6 Fixed https://github.com/DSpace/DSpace/issues/10754 by setting the context user to the current subscriber
(cherry picked from commit 6275d3b756)
2025-09-12 19:25:41 +00:00
Tim Donohue
e672be5eaa Merge pull request #11309 from DSpace/backport-10555-to-dspace-7_x
[Port dspace-7_x] Fix sort order in AbstractHibernateDAO findByX
2025-09-12 13:52:27 -05:00
abhinav
fcde7489d3 Added a test case to verify the sort
(cherry picked from commit 989d930417)
2025-09-12 17:30:09 +00:00
abhinav
4402847f38 129616: Added order by
(cherry picked from commit cc6520bfbb)
2025-09-12 17:30:09 +00:00
Tim Donohue
a180a257cd Merge pull request #11305 from DSpace/backport-11253-to-dspace-7_x
[Port dspace-7_x] Add ORCID document type
2025-09-11 13:56:24 -05:00
Pierre Lasou
467e42ca27 Add ORCID document type
Addiing new mappings between ORCID document type and DSpace default type.

(cherry picked from commit e213f5b305)
2025-09-11 15:59:20 +00:00
Tim Donohue
13c6835656 Merge pull request #11302 from DSpace/backport-10929-to-dspace-7_x
[Port dspace-7_x] Fix SAF Import Open connection leak
2025-09-10 15:50:31 -05:00
Tim Donohue
f700c37a73 Merge pull request #11299 from DSpace/backport-11263-to-dspace-7_x
[Port dspace-7_x] Add familyName and givenName when creating profile author and fix EPe…
2025-09-10 15:49:47 -05:00
Nathan Buckingham
0902db21eb 132206: Saf Imports close connections
(cherry picked from commit 35135c80ae)
2025-09-10 19:32:40 +00:00
Jesiel Viana
11ba34b1fd Add familyName and givenName when creating profile author and fix EPerson#getName
(cherry picked from commit df0dd01776)
2025-09-10 19:22:58 +00:00
Tim Donohue
936cb3c101 Merge pull request #11227 from DSpace/dependabot/maven/dspace-7_x/io.grpc-grpc-context-1.75.0
Bump io.grpc:grpc-context from 1.74.0 to 1.75.0
2025-09-10 09:50:25 -05:00
Tim Donohue
7c7bbeadc5 Merge pull request #11235 from DSpace/dependabot/maven/dspace-7_x/org.ehcache-ehcache-3.11.1
Bump org.ehcache:ehcache from 3.10.8 to 3.11.1
2025-09-10 09:48:33 -05:00
Tim Donohue
5e3c57a920 Merge pull request #11276 from DSpace/dependabot/maven/dspace-7_x/com.amazonaws-aws-java-sdk-s3-1.12.791
Bump com.amazonaws:aws-java-sdk-s3 from 1.12.788 to 1.12.791
2025-09-10 09:40:49 -05:00
Tim Donohue
beb5a096ab Merge pull request #11275 from DSpace/dependabot/maven/dspace-7_x/com.github.spotbugs-spotbugs-maven-plugin-4.9.4.2
Bump com.github.spotbugs:spotbugs-maven-plugin from 4.9.4.0 to 4.9.4.2
2025-09-09 17:10:17 -05:00
Tim Donohue
73a0316f99 Merge pull request #11237 from DSpace/dependabot/maven/dspace-7_x/net.minidev-json-smart-2.6.0
Bump net.minidev:json-smart from 2.5.2 to 2.6.0
2025-09-09 17:06:38 -05:00
Tim Donohue
257dc13d32 Merge pull request #11274 from DSpace/dependabot/maven/dspace-7_x/test-tools-7b258dae6a
Bump the test-tools group with 6 updates
2025-09-09 17:03:06 -05:00
Tim Donohue
dfa38c90df Merge pull request #11295 from DSpace/backport-11170-to-dspace-7_x
[Port dspace-7_x] DS-3796 Fix dates for Not to be processed checker-emailer report
2025-09-09 16:48:05 -05:00
Miika Nurminen
cd62cac431 DS-3796 Fix dates for Not to be processed checker-emailer report
Based on 86de8c74a7 (ResultTypeInDateRange dates have already been fixed in upstream).

(cherry picked from commit fac888793c)
2025-09-09 21:14:21 +00:00
dependabot[bot]
847904cadb Bump com.amazonaws:aws-java-sdk-s3 from 1.12.788 to 1.12.791
Bumps [com.amazonaws:aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.788 to 1.12.791.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.788...1.12.791)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-version: 1.12.791
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-08 20:35:21 +00:00
dependabot[bot]
127770219b Bump com.github.spotbugs:spotbugs-maven-plugin from 4.9.4.0 to 4.9.4.2
Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.9.4.0 to 4.9.4.2.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.9.4.0...spotbugs-maven-plugin-4.9.4.2)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-version: 4.9.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-08 20:34:23 +00:00
dependabot[bot]
98e89caa35 Bump the test-tools group with 6 updates
Bumps the test-tools group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.2.4.Final` | `4.2.6.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.2.4.Final` | `4.2.6.Final` |
| [io.netty:netty-transport-native-unix-common](https://github.com/netty/netty) | `4.2.4.Final` | `4.2.6.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.2.4.Final` | `4.2.6.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.2.4.Final` | `4.2.6.Final` |
| [io.netty:netty-codec](https://github.com/netty/netty) | `4.2.4.Final` | `4.2.6.Final` |


Updates `io.netty:netty-buffer` from 4.2.4.Final to 4.2.6.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.4.Final...netty-4.2.6.Final)

Updates `io.netty:netty-transport` from 4.2.4.Final to 4.2.6.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.4.Final...netty-4.2.6.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.2.4.Final to 4.2.6.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.4.Final...netty-4.2.6.Final)

Updates `io.netty:netty-common` from 4.2.4.Final to 4.2.6.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.4.Final...netty-4.2.6.Final)

Updates `io.netty:netty-handler` from 4.2.4.Final to 4.2.6.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.4.Final...netty-4.2.6.Final)

Updates `io.netty:netty-codec` from 4.2.4.Final to 4.2.6.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.4.Final...netty-4.2.6.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-version: 4.2.6.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-version: 4.2.6.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-version: 4.2.6.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-version: 4.2.6.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-version: 4.2.6.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-version: 4.2.6.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-08 20:33:03 +00:00
Tim Donohue
a063a7a4f6 Merge pull request #11273 from tdonohue/port_11171_to_7x
[Port dspace-7_x] Error in file upload after security fixes
2025-09-08 13:23:38 -05:00
Stefano Maffei
7dd2b5318b [CST-21947] fix security fix 2025-09-08 12:17:59 -05:00
Tim Donohue
29b3ba9c57 Merge pull request #11269 from tdonohue/port_11268_to_7x
[Port dspace-7_x] fix(#11191): Align Content-Disposition with RFC 5987/6266
2025-09-05 17:30:08 -05:00
Tim Donohue
568fdab395 Merge pull request #11264 from DSpace/backport-11245-to-dspace-7_x
[Port dspace-7_x] AIP Packager bitstream URL fix
2025-09-05 16:57:27 -05:00
JohnnyMendesC
fe4077acee fix(#11191): Align Content-Disposition with RFC 5987/6266 2025-09-05 16:55:45 -05:00
Kristof De Langhe
cbecc64a5a 133552: unused import
(cherry picked from commit 93240941d3)
2025-09-05 21:18:54 +00:00
Kristof De Langhe
5ed0b28a36 133552: AIP packager bitstream url fix
(cherry picked from commit 11da562ea4)
2025-09-05 21:18:54 +00:00
Tim Donohue
54a6011e60 Merge pull request #11257 from DSpace/backport-10142-to-dspace-7_x
[Port dspace-7_x] DS-10133: make several usage statistics parameters configurable
2025-09-04 12:03:46 -05:00
nwoodward
be9d2bd2bf make several usage statistics parameters configurable
(cherry picked from commit cd57985934)
2025-09-04 14:31:45 +00:00
Tim Donohue
e4d058f1c9 Merge pull request #11251 from DSpace/backport-11174-to-dspace-7_x
[Port dspace-7_x] Fix #11074 export simple archive format when item has no collection
2025-09-03 15:47:29 -05:00
Tim Donohue
603f638174 Merge pull request #11247 from DSpace/backport-11200-to-dspace-7_x
[Port dspace-7_x] Fix database connection leak on failed login attempts
2025-09-03 14:51:14 -05:00
Martin Walk
66fc49800d Fix #11074 export simple archive format with no collection
(cherry picked from commit d282f92427)
2025-09-03 19:46:19 +00:00
Alexandre Vryghem
376f49e99b 133421: Removed database connection leak on unsuccessful login
(cherry picked from commit 0b0c9fc84c)
2025-09-03 19:09:02 +00:00
Tim Donohue
4dedd1b66f Merge pull request #11242 from DSpace/backport-11195-to-dspace-7_x
[Port dspace-7_x] Implement logging for index out-of-range in MetadataValueRemovePatchOperation
2025-09-02 15:10:25 -05:00
Sascha Szott
8f4a3f963a Implement logging for index out-of-range
Add logging for out-of-range index when removing metadata values.

(cherry picked from commit 7692b02b12)
2025-09-02 19:34:30 +00:00
Tim Donohue
cc35141661 Merge pull request #11226 from DSpace/dependabot/maven/dspace-7_x/build-tools-e11e9b5c2b
Bump the build-tools group with 3 updates
2025-09-02 13:01:34 -05:00
Tim Donohue
fd1aa013a7 Merge pull request #11233 from DSpace/dependabot/maven/dspace-7_x/apache-commons-4538dd79bf
Bump commons-cli:commons-cli from 1.9.0 to 1.10.0 in the apache-commons group
2025-09-02 10:51:10 -05:00
Tim Donohue
3721d231b3 Merge pull request #11234 from DSpace/dependabot/maven/dspace-7_x/jetty.version-9.4.58.v20250814
Bump jetty.version from 9.4.57.v20241219 to 9.4.58.v20250814
2025-09-02 10:48:42 -05:00
Tim Donohue
45b677c20e Merge pull request #11223 from DSpace/dependabot/maven/dspace-7_x/test-tools-2cb88a00ef
Bump the test-tools group with 6 updates
2025-09-02 10:47:02 -05:00
dependabot[bot]
ccf253ddda Bump net.minidev:json-smart from 2.5.2 to 2.6.0
Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.2 to 2.6.0.
- [Release notes](https://github.com/netplex/json-smart-v2/releases)
- [Commits](https://github.com/netplex/json-smart-v2/compare/2.5.2...v2.6.0)

---
updated-dependencies:
- dependency-name: net.minidev:json-smart
  dependency-version: 2.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-01 06:01:09 +00:00
dependabot[bot]
2c34dde3a8 Bump org.ehcache:ehcache from 3.10.8 to 3.11.1
Bumps [org.ehcache:ehcache](https://github.com/ehcache/ehcache3) from 3.10.8 to 3.11.1.
- [Release notes](https://github.com/ehcache/ehcache3/releases)
- [Commits](https://github.com/ehcache/ehcache3/compare/v3.10.8...v3.11.1)

---
updated-dependencies:
- dependency-name: org.ehcache:ehcache
  dependency-version: 3.11.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-01 06:00:09 +00:00
dependabot[bot]
13982618df Bump jetty.version from 9.4.57.v20241219 to 9.4.58.v20250814
Bumps `jetty.version` from 9.4.57.v20241219 to 9.4.58.v20250814.

Updates `org.eclipse.jetty:jetty-server` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-alpn-java-server` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-deploy` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-http` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-io` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-servlet` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-servlets` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-util` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-webapp` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty:jetty-xml` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty.http2:http2-common` from 9.4.57.v20241219 to 9.4.58.v20250814

Updates `org.eclipse.jetty.http2:http2-server` from 9.4.57.v20241219 to 9.4.58.v20250814

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-server
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-alpn-java-server
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-deploy
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-http
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-io
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-servlet
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-servlets
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-util
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-webapp
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-xml
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.http2:http2-common
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.http2:http2-server
  dependency-version: 9.4.58.v20250814
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-01 05:53:13 +00:00
dependabot[bot]
cf3f8e9bb2 Bump commons-cli:commons-cli in the apache-commons group
Bumps the apache-commons group with 1 update: [commons-cli:commons-cli](https://github.com/apache/commons-cli).


Updates `commons-cli:commons-cli` from 1.9.0 to 1.10.0
- [Changelog](https://github.com/apache/commons-cli/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-cli/compare/rel/commons-cli-1.9.0...rel/commons-cli-1.10.0)

---
updated-dependencies:
- dependency-name: commons-cli:commons-cli
  dependency-version: 1.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-01 05:51:23 +00:00
dependabot[bot]
9bef7b58d6 Bump io.grpc:grpc-context from 1.74.0 to 1.75.0
Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.74.0 to 1.75.0.
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](https://github.com/grpc/grpc-java/compare/v1.74.0...v1.75.0)

---
updated-dependencies:
- dependency-name: io.grpc:grpc-context
  dependency-version: 1.75.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-01 05:45:53 +00:00
dependabot[bot]
b78f570dbf Bump the build-tools group with 3 updates
Bumps the build-tools group with 3 updates: [com.github.spotbugs:spotbugs](https://github.com/spotbugs/spotbugs), [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) and [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin).


Updates `com.github.spotbugs:spotbugs` from 4.9.3 to 4.9.4
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.9.3...4.9.4)

Updates `com.github.spotbugs:spotbugs-maven-plugin` from 4.9.3.2 to 4.9.4.0
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.9.3.2...spotbugs-maven-plugin-4.9.4.0)

Updates `org.apache.maven.plugins:maven-javadoc-plugin` from 3.11.2 to 3.11.3
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.11.2...maven-javadoc-plugin-3.11.3)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs
  dependency-version: 4.9.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-version: 4.9.4.0
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-version: 3.11.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-01 05:44:48 +00:00
dependabot[bot]
103d7f754a Bump the test-tools group with 6 updates
Bumps the test-tools group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.2.3.Final` | `4.2.4.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.2.3.Final` | `4.2.4.Final` |
| [io.netty:netty-transport-native-unix-common](https://github.com/netty/netty) | `4.2.3.Final` | `4.2.4.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.2.3.Final` | `4.2.4.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.2.3.Final` | `4.2.4.Final` |
| [io.netty:netty-codec](https://github.com/netty/netty) | `4.2.3.Final` | `4.2.4.Final` |


Updates `io.netty:netty-buffer` from 4.2.3.Final to 4.2.4.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.3.Final...netty-4.2.4.Final)

Updates `io.netty:netty-transport` from 4.2.3.Final to 4.2.4.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.3.Final...netty-4.2.4.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.2.3.Final to 4.2.4.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.3.Final...netty-4.2.4.Final)

Updates `io.netty:netty-common` from 4.2.3.Final to 4.2.4.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.3.Final...netty-4.2.4.Final)

Updates `io.netty:netty-handler` from 4.2.3.Final to 4.2.4.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.3.Final...netty-4.2.4.Final)

Updates `io.netty:netty-codec` from 4.2.3.Final to 4.2.4.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.3.Final...netty-4.2.4.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-version: 4.2.4.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-version: 4.2.4.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-version: 4.2.4.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-version: 4.2.4.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-version: 4.2.4.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-version: 4.2.4.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-09-01 05:44:10 +00:00
Tim Donohue
ff0ebea316 Merge pull request #11188 from DSpace/backport-11160-to-dspace-7_x
[Port dspace-7_x] fix(#8852): Statistics event processor now uses oaiPrefix instead of getHost
2025-08-21 16:56:25 -05:00
JohnnyMendesC
f831acf4d7 fix(#8852): Statistics event processor now uses oaiPrefix instead of getHost
(cherry picked from commit c8fe80c22b)
2025-08-21 21:15:20 +00:00
Tim Donohue
21343d3158 Merge pull request #11184 from DSpace/backport-11161-to-dspace-7_x
[Port dspace-7_x] dspace-api/pom.xml: remove build-helper-maven-plugin
2025-08-21 08:54:54 -05:00
Tim Donohue
abc238cdd0 Merge pull request #11183 from tdonohue/port_11168_to_7x
[Port dspace-7_x] Fix bean initialization with citation-page.enabled_communities
2025-08-21 08:46:31 -05:00
Alan Orth
922109b10a dspace-api/pom.xml: remove build-helper-maven-plugin
Remove the org.codehaus.mojo:build-helper-maven-plugin because the
`maven-version` property has been included by maven itself since
version 3.0.4. This fixes the following warning during build:

    [INFO] --- build-helper:3.6.1:maven-version (default) @ dspace-api ---
    [WARNING]  Goal 'maven-version' is deprecated: Maven since version 3.0.4 has such property build in: MNG-4112 <https://issues.apache.org/jira/browse/MNG-4112>. So goal can be removed.

(cherry picked from commit de3170d4eb)
2025-08-21 13:20:36 +00:00
Tim Donohue
23150bc89a Merge pull request #11180 from tdonohue/port-11166-to-7x
[Port dspace-7_x] .github/workflows/codescan.yml: use codeql-action v3
2025-08-20 17:15:35 -05:00
Miika Nurminen
e51a2537ac Fix bean initialization error on Tomcat startup if citation-page.enabled_communities is set
Arrays.asList produces non-mutable list but with communities, sub-collections are added dynamically on initializaion.
2025-08-20 17:05:46 -05:00
Alan Orth
94a1a0b2e0 .github/workflows/codescan.yml: use codeql-action v3
Version 2 was deprecated in January, 2024 after the release of v3.

See: https://github.blog/changelog/2025-01-10-code-scanning-codeql-action-v2-is-now-deprecated/
2025-08-20 16:30:23 -05:00
Tim Donohue
71af1503ae Merge pull request #11175 from DSpace/backport-11156-to-dspace-7_x
[Port dspace-7_x] Metadata import empty collection column check
2025-08-20 16:28:23 -05:00
Joran De Braekeleer
d063f1ef66 133268: Metadata import empty collection col check
(cherry picked from commit b9513228d7)
2025-08-20 20:50:47 +00:00
kshepherd
be3702f419 Merge pull request #11151 from DSpace/backport-11150-to-dspace-7_x
[Port dspace-7_x] Fix for #9589 Incorrect Export of Search Results with Double Quotation Marks in DSpace 7. Reference PR #10103
2025-08-12 18:10:49 +02:00
im-shubham-vish
aa0fe083a6 Make parse protected to make it override in MetadataExportSearch Add Test for Double Quoted Search CSV Export
(cherry picked from commit 39a45f7f34)
2025-08-12 14:36:37 +00:00
Tim Donohue
38dd432feb Merge pull request #11143 from DSpace/backport-10508-to-dspace-7_x
[Port dspace-7_x] Fix checkpointing for DSpace "checker" command
2025-08-06 16:30:25 -05:00
Tim Donohue
bce865f299 Revert to using java.util.Date instead of Instant to support earlier versions of DSpace. 2025-08-06 15:10:41 -05:00
David P. Steelman
558f0c7bea Fix checkpointing for checksum checking
Fixes the checkpointing for checksum checking by actually committing
the changes to the database.

Replacing "uncacheEntity" with "commit", as testing has shown that this
is necessary to ensure that the checksum status is properly updated in
the most_recent_checksum" table when checksum process is interrupted.

The provided integration test fails if the checksums of bitstreams that
were checked before the interruption are not properly recorded in the
database.

(cherry picked from commit 502b655ef6)
2025-08-06 19:43:04 +00:00
Tim Donohue
eec374a7c5 Merge pull request #11140 from DSpace/backport-11138-to-dspace-7_x
[Port dspace-7_x] FIX uses dc.source for bitstream originalName tag
2025-08-06 14:14:15 -05:00
Tim Donohue
375c0aee1c Merge pull request #11135 from DSpace/backport-11131-to-dspace-7_x
[Port dspace-7_x] Enhance SWORDv1 Integration Tests & fix WRITE Permissions error for submitters
2025-08-06 14:09:11 -05:00
Vincenzo Mecca
56b38bb26d fix: uses dc.source for bitstream originalName tag
Refs: DURACOM-391, #1130
(cherry picked from commit f5c0c17c66)
2025-08-06 18:37:42 +00:00
Tim Donohue
e4f9e90394 Merge pull request #11134 from the-library-code/orcid-identifier-fix-7x_backport
[Port dspace-7_x] ORCID Push: Fix SELF and PART_OF external identifier handling
2025-08-06 13:32:54 -05:00
Tim Donohue
05af860553 getContentAsByteArray() didn't exist in Spring 5. Use readAllBytes() from InputStream instead. 2025-08-06 12:19:14 -05:00
Tim Donohue
ea6e025519 Fix WRITE permissions error when ingesting a new Item. Do not call "updateDSpaceObject" after calling "finishCreateItem" as the latter saves the object and removes submitter privileges from it.
(cherry picked from commit c2d05891ab)
2025-08-06 16:33:00 +00:00
Tim Donohue
b8cbaa053d Add a deposit integration test for SWORDv1 based on the similar SWORDv2 test.
(cherry picked from commit 0589011849)
2025-08-06 16:33:00 +00:00
Kim Shepherd
af654e57f2 [TLC-1097] Additional javadoc for ORCID sync fix 2025-08-06 17:26:12 +02:00
Kim Shepherd
3bca2164be [TLC-1097] ORCID external identifier sync fix
Handle SELF and PART_OF identifiers properly based on
configuration, work type, and identifier type
2025-08-06 17:25:57 +02:00
Tim Donohue
389269e958 Merge pull request #11123 from DSpace/backport-10490-to-dspace-7_x
[Port dspace-7_x] Fix checkpointing for bitstore migration
2025-07-31 16:24:12 -05:00
David P. Steelman
2d353ea995 Fix checkpointing for bitstore migration
Fixes the checkpointing for bitstore migration by actually committing
the changes to the database.

Replacing "dispatchEvents" with "commit" as testing has shown that this
is necessary to ensure that the status of bitstreams is properly
updated when the bitstore migration is interrupted.

The provided integration tests fail if bitstreams successfully migrated
before the interruption are not properly recorded in the database as
being in the destination assetstore.

(cherry picked from commit 3d7c45852d)
2025-07-31 20:52:41 +00:00
Tim Donohue
e0dd7454a4 Merge pull request #11116 from DSpace/dependabot/maven/dspace-7_x/apache-commons-cb46d7dc0f
Bump org.apache.commons:commons-compress from 1.27.1 to 1.28.0 in the apache-commons group
2025-07-31 08:47:43 -05:00
Tim Donohue
7153efe412 Merge pull request #11119 from DSpace/dependabot/maven/dspace-7_x/com.github.spotbugs-spotbugs-maven-plugin-4.9.3.2
Bump com.github.spotbugs:spotbugs-maven-plugin from 4.9.3.0 to 4.9.3.2
2025-07-30 17:08:55 -05:00
Tim Donohue
0a3733db95 Merge pull request #11121 from DSpace/dependabot/maven/dspace-7_x/io.grpc-grpc-context-1.74.0
Bump io.grpc:grpc-context from 1.73.0 to 1.74.0
2025-07-30 15:42:04 -05:00
Tim Donohue
ee45f736cd Merge pull request #11113 from tdonohue/port_11111_to_7x
[Port dspace-7_x] Ensure DSpace defaults to UTC time zone in all code / tests
2025-07-30 14:13:10 -05:00
dependabot[bot]
808135f688 Bump io.grpc:grpc-context from 1.73.0 to 1.74.0
Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.73.0 to 1.74.0.
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](https://github.com/grpc/grpc-java/compare/v1.73.0...v1.74.0)

---
updated-dependencies:
- dependency-name: io.grpc:grpc-context
  dependency-version: 1.74.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-30 18:42:52 +00:00
dependabot[bot]
1ecb5660f8 Bump com.github.spotbugs:spotbugs-maven-plugin from 4.9.3.0 to 4.9.3.2
Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.9.3.0 to 4.9.3.2.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.9.3.0...spotbugs-maven-plugin-4.9.3.2)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-version: 4.9.3.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-30 18:41:59 +00:00
dependabot[bot]
6282cb9f12 Bump org.apache.commons:commons-compress in the apache-commons group
Bumps the apache-commons group with 1 update: [org.apache.commons:commons-compress](https://github.com/apache/commons-compress).


Updates `org.apache.commons:commons-compress` from 1.27.1 to 1.28.0
- [Changelog](https://github.com/apache/commons-compress/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-compress/compare/rel/commons-compress-1.27.1...rel/commons-compress-1.28.0)

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-compress
  dependency-version: 1.28.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-30 18:40:38 +00:00
Tim Donohue
2b2d0b19b6 Ensure DSpace defaults to UTC time zone in all code / tests. This is necessary so that Spring / Hibernate don't auto-switch timezones when reading from database. 2025-07-30 12:08:23 -05:00
Tim Donohue
77f07a735b Merge pull request #11105 from tdonohue/port_11077_to_7x
[Port dspace-7_x] Add basic logging tests to our docker deployment script in GitHub actions
2025-07-29 10:14:54 -05:00
Tim Donohue
613ef1dc62 Merge pull request #11067 from kshepherd/log4j_it
Simple Log4j tests with in-memory log appender
2025-07-29 09:14:59 -05:00
Tim Donohue
5e3463bd8b Add tests for backend logging to docker deployment tests 2025-07-29 09:11:36 -05:00
Tim Donohue
e3c64906de Merge pull request #11088 from DSpace/dependabot/maven/dspace-7_x/org.apache.james-apache-mime4j-core-0.8.13
Bump org.apache.james:apache-mime4j-core from 0.8.12 to 0.8.13
2025-07-28 16:33:12 -05:00
Tim Donohue
8c79201da3 Merge pull request #10976 from DSpace/dependabot/maven/dspace-7_x/google-apis-d482fb5384
Bump the google-apis group with 3 updates
2025-07-28 16:30:14 -05:00
Tim Donohue
c22583e892 Merge pull request #11005 from DSpace/dependabot/maven/dspace-7_x/build-tools-4f2f951df2
Bump the build-tools group across 1 directory with 2 updates
2025-07-28 15:52:14 -05:00
dependabot[bot]
af38697ade Bump the build-tools group across 1 directory with 2 updates
Bumps the build-tools group with 2 updates in the / directory: [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) and [org.codehaus.mojo:license-maven-plugin](https://github.com/mojohaus/license-maven-plugin).


Updates `org.apache.maven.plugins:maven-enforcer-plugin` from 3.5.0 to 3.6.0
- [Release notes](https://github.com/apache/maven-enforcer/releases)
- [Commits](https://github.com/apache/maven-enforcer/compare/enforcer-3.5.0...enforcer-3.6.0)

Updates `org.codehaus.mojo:license-maven-plugin` from 2.5.0 to 2.6.0
- [Release notes](https://github.com/mojohaus/license-maven-plugin/releases)
- [Commits](https://github.com/mojohaus/license-maven-plugin/compare/2.5.0...2.6.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-enforcer-plugin
  dependency-version: 3.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.codehaus.mojo:license-maven-plugin
  dependency-version: 2.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-28 19:43:25 +00:00
Tim Donohue
ccdbc381c5 Merge pull request #11047 from DSpace/dependabot/maven/dspace-7_x/test-tools-68aaeff8ca
Bump the test-tools group across 1 directory with 7 updates
2025-07-28 14:37:51 -05:00
Tim Donohue
584d70db81 Merge pull request #11100 from mwoodiupui/my-11042-7x
Avoid injection vulnerability in controlled vocabulary lookup 7_x
2025-07-28 14:18:43 -05:00
Mark H. Wood
ceab9526c4 Port #11075 to 7_x 2025-07-28 13:42:28 -04:00
Alan Orth
45c37bcf66 Merge pull request #11089 from DSpace/dependabot/maven/dspace-7_x/com.opencsv-opencsv-5.12.0 2025-07-28 09:30:39 -07:00
Tim Donohue
69a83f0bdd Merge pull request #11049 from DSpace/dependabot/maven/dspace-7_x/com.amazonaws-aws-java-sdk-s3-1.12.788
Bump com.amazonaws:aws-java-sdk-s3 from 1.12.785 to 1.12.788
2025-07-28 08:58:22 -05:00
Tim Donohue
18d53743cd Merge pull request #11087 from DSpace/dependabot/maven/dspace-7_x/apache-commons-7e5b090d5c
Bump the apache-commons group across 1 directory with 5 updates
2025-07-28 08:55:42 -05:00
Tim Donohue
f6f2d5e05c Merge pull request #11050 from DSpace/dependabot/maven/dspace-7_x/fasterxml-d1c1cdfb0c
Bump the fasterxml group with 3 updates
2025-07-28 08:50:51 -05:00
dependabot[bot]
dc65c7a304 Bump com.opencsv:opencsv from 5.11.1 to 5.12.0
Bumps com.opencsv:opencsv from 5.11.1 to 5.12.0.

---
updated-dependencies:
- dependency-name: com.opencsv:opencsv
  dependency-version: 5.12.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-28 03:39:24 +00:00
dependabot[bot]
de220d55ac Bump org.apache.james:apache-mime4j-core from 0.8.12 to 0.8.13
Bumps org.apache.james:apache-mime4j-core from 0.8.12 to 0.8.13.

---
updated-dependencies:
- dependency-name: org.apache.james:apache-mime4j-core
  dependency-version: 0.8.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-28 03:37:58 +00:00
dependabot[bot]
ac81a3d36f Bump the apache-commons group across 1 directory with 5 updates
Bumps the apache-commons group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [commons-codec:commons-codec](https://github.com/apache/commons-codec) | `1.18.0` | `1.19.0` |
| [commons-io:commons-io](https://github.com/apache/commons-io) | `2.19.0` | `2.20.0` |
| org.apache.commons:commons-lang3 | `3.17.0` | `3.18.0` |
| [org.apache.commons:commons-text](https://github.com/apache/commons-text) | `1.13.1` | `1.14.0` |
| commons-validator:commons-validator | `1.9.0` | `1.10.0` |



Updates `commons-codec:commons-codec` from 1.18.0 to 1.19.0
- [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-codec/compare/rel/commons-codec-1.18.0...rel/commons-codec-1.19.0)

Updates `commons-io:commons-io` from 2.19.0 to 2.20.0
- [Changelog](https://github.com/apache/commons-io/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-io/compare/rel/commons-io-2.19.0...rel/commons-io-2.20.0)

Updates `org.apache.commons:commons-lang3` from 3.17.0 to 3.18.0

Updates `org.apache.commons:commons-text` from 1.13.1 to 1.14.0
- [Changelog](https://github.com/apache/commons-text/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-text/compare/rel/commons-text-1.13.1...rel/commons-text-1.14.0)

Updates `commons-validator:commons-validator` from 1.9.0 to 1.10.0

---
updated-dependencies:
- dependency-name: commons-codec:commons-codec
  dependency-version: 1.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: commons-io:commons-io
  dependency-version: 2.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-lang3
  dependency-version: 3.18.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-text
  dependency-version: 1.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: commons-validator:commons-validator
  dependency-version: 1.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-28 03:36:02 +00:00
dependabot[bot]
92120211da Bump the test-tools group across 1 directory with 7 updates
---
updated-dependencies:
- dependency-name: org.xmlunit:xmlunit-core
  dependency-version: 2.10.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-buffer
  dependency-version: 4.2.3.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-version: 4.2.3.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-version: 4.2.3.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-version: 4.2.3.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-version: 4.2.3.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-version: 4.2.3.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-28 02:55:44 +00:00
dependabot[bot]
609062befb Bump the google-apis group with 3 updates
Bumps the google-apis group with 3 updates: [com.google.http-client:google-http-client](https://github.com/googleapis/google-http-java-client), [com.google.http-client:google-http-client-jackson2](https://github.com/googleapis/google-http-java-client) and [com.google.http-client:google-http-client-gson](https://github.com/googleapis/google-http-java-client).


Updates `com.google.http-client:google-http-client` from 1.47.0 to 1.47.1
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.47.0...v1.47.1)

Updates `com.google.http-client:google-http-client-jackson2` from 1.47.0 to 1.47.1
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.47.0...v1.47.1)

Updates `com.google.http-client:google-http-client-gson` from 1.47.0 to 1.47.1
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.47.0...v1.47.1)

---
updated-dependencies:
- dependency-name: com.google.http-client:google-http-client
  dependency-version: 1.47.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-jackson2
  dependency-version: 1.47.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-gson
  dependency-version: 1.47.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: google-apis
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-28 02:55:24 +00:00
dependabot[bot]
ffd60bf811 Bump the fasterxml group with 3 updates
Bumps the fasterxml group with 3 updates: [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson), [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) and [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson).


Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.19.1 to 2.19.2
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.19.1 to 2.19.2
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.19.1...jackson-core-2.19.2)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.19.1 to 2.19.2
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.19.1...jackson-core-2.19.2)

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.19.1 to 2.19.2
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-annotations
  dependency-version: 2.19.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-version: 2.19.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-version: 2.19.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-version: 2.19.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-28 02:55:08 +00:00
Tim Donohue
695aa673d3 Merge pull request #11071 from tdonohue/port_10356_to_7x
[Port dspace-7_x] Live Import - PubMed - support optional apiKey config
2025-07-23 15:05:28 -05:00
Marie Verdonck
2f66457abe 109807: Live Import - PubMed - support optional apiKey config 2025-07-23 12:41:25 -05:00
Tim Donohue
c061015ecf [maven-release-plugin] prepare for next development iteration 2025-07-22 15:03:08 -05:00
Tim Donohue
6e8b6cc33a [maven-release-plugin] prepare release dspace-7.6.5 2025-07-22 15:03:04 -05:00
Tim Donohue
479cb76885 Minor updates to LICENSES_THIRD_PARTY for 7.6.5 release 2025-07-22 14:42:47 -05:00
Kim Shepherd
588c4ef4d2 Add simple log4j WebappLoggingIT test 2025-07-22 18:12:05 +02:00
Tim Donohue
5f291400b3 Merge pull request #11066 from tdonohue/port_11063_to_7x
[Port dspace-7_x] Fix several unit/integration test failures that only occur on Windows
2025-07-22 09:34:56 -05:00
kshepherd
1bd4da3899 Merge pull request #11028 from DSpace/dependabot/maven/dspace-7_x/log4j.version-2.25.1
Bump log4j.version from 2.25.0 to 2.25.1
2025-07-22 16:23:59 +02:00
Tim Donohue
15b3f314a3 Force UTF-8 encoding in all tests. This fixes several test failures when running tests from Windows commandline because Windows doesn't default to using UTF-8. 2025-07-22 08:59:50 -05:00
Tim Donohue
28686fc48a Improve logging in AbstractLiveImportIntegrationTest (to make tests easier to debug). Replace obscure StringInputStream (from Ant) with IOUtils.toInputStream 2025-07-22 08:59:44 -05:00
Tim Donohue
d2c120bd8b Fix broken tests on Windows by using Paths to split file path instead of regex. Also switch to in-memory s3mock because Windows cannot cleanup created files successfully. 2025-07-22 08:59:39 -05:00
Tim Donohue
39fb2afba1 Update test to no longer assume 127.0.0.1 will always respond with "localhost" as the hostname. On my machine it does not. 2025-07-22 08:59:34 -05:00
dependabot[bot]
5cd3daa379 Bump com.amazonaws:aws-java-sdk-s3 from 1.12.785 to 1.12.788
Bumps [com.amazonaws:aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.785 to 1.12.788.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.785...1.12.788)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-version: 1.12.788
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-21 02:49:30 +00:00
Tim Donohue
9424ccf4aa [maven-release-plugin] prepare for next development iteration 2025-07-14 12:03:15 -05:00
Tim Donohue
a5f04f9c77 [maven-release-plugin] prepare release dspace-7.6.4 2025-07-14 12:03:12 -05:00
Tim Donohue
f506d18bb1 Merge pull request #11036 from DSpace/backport-11031-to-dspace-7_x
[Port dspace-7_x] Improve SAF manifest path handling
2025-07-14 10:18:06 -05:00
Kim Shepherd
bc17559162 Fix line length in DSBitstore log
(cherry picked from commit dbf524c112)
2025-07-14 14:36:58 +00:00
Kim Shepherd
907b42c2a9 return existing File constructed and validated for bitstream
(cherry picked from commit 31b1c922b2)
2025-07-14 14:36:58 +00:00
Kim Shepherd
b0a4a3400f Enforce bitstream path to be within (fs) bitstore base on get
(cherry picked from commit 6799660a90)
2025-07-14 14:36:58 +00:00
MMilosz
84e308c8f5 fix: prevent path traversal in SAF import
(cherry picked from commit 596d8666f4)
2025-07-14 14:36:58 +00:00
Tim Donohue
91989e5efb Merge pull request #11032 from kshepherd/saf-xml-fix-2_7.x
Improve SAF Import XML handling (7.x)
2025-07-14 09:22:15 -05:00
Kim Shepherd
e9bc74cf6d Fix missing XMLUtils imports 2025-07-14 13:09:43 +02:00
Kim Shepherd
dda6d9ec9d Remove unused imports 2025-07-14 13:07:45 +02:00
Kim Shepherd
45a9f8b530 Re-add file separator to normalized SAF item path 2025-07-14 12:50:32 +02:00
dependabot[bot]
a381611ebd Bump log4j.version from 2.25.0 to 2.25.1
Bumps `log4j.version` from 2.25.0 to 2.25.1.

Updates `org.apache.logging.log4j:log4j-api` from 2.25.0 to 2.25.1

Updates `org.apache.logging.log4j:log4j-core` from 2.25.0 to 2.25.1

Updates `org.apache.logging.log4j:log4j-1.2-api` from 2.25.0 to 2.25.1

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-version: 2.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-version: 2.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.logging.log4j:log4j-1.2-api
  dependency-version: 2.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-07-14 03:45:03 +00:00
Kim Shepherd
259c3ddd37 Enforce path traversal check on import subdir (pre-processing) 2025-07-13 10:08:30 +02:00
Tim Donohue
d48e22aff5 Update LICENSES_THIRD_PARTY to prepare for 7.6.4 release. 2025-07-11 14:01:37 -05:00
Tim Donohue
4fd3112ebf Merge pull request #10690 from atmire/w2p-119612_export-item-limit-dspace-7_x
[Port dspace-7_x] support a configurable limit for exporting items as it can take a up a huge amount of resources
2025-07-10 13:25:38 -05:00
Kim Shepherd
99b2a630a7 Allow trusted XML builder to enforce base path for entities 2025-07-10 17:22:58 +02:00
Tim Donohue
8c80b67b04 EPO and PubMed only need to allow for DOCTYPEs. All other XML security changes can be used. 2025-07-03 12:49:11 +02:00
Kim Shepherd
f7dcbf1b44 Safe and consistent XML entity handling in parsers 2025-07-03 12:48:47 +02:00
Tim Donohue
a9546055f4 Merge pull request #10998 from DSpace/backport-10997-to-dspace-7_x
[Port dspace-7_x] Point directly to HTTPS address for ArXiv
2025-07-02 13:21:17 -05:00
Yury Bondarenko
8f9a7f1f92 Point directly to HTTPS address for ArXiv
(cherry picked from commit cf0d6635f2)
2025-07-02 16:22:49 +00:00
Tim Donohue
042bf15237 Merge pull request #10994 from tdonohue/port_10986_to_7x
[Port dspace-7_x] Update POM to use Sonatype's Central Portal for Maven Releases
2025-07-01 14:25:05 -05:00
Tim Donohue
76c50ac43e Update POM to use central-publishing-maven-plugin and Sonatype's Central Portal 2025-07-01 12:22:58 -05:00
Tim Donohue
2b9b14501c Merge pull request #9966 from atmire/accessibility-settings-7_x
[Port dspace-7_x] Accessibility settings metadata field
2025-06-30 13:22:15 -05:00
Alan Orth
96ce51ae09 Merge pull request #10914 from DSpace/dependabot/maven/dspace-7_x/fasterxml-4343a5c2e7 2025-06-30 07:00:24 +03:00
dependabot[bot]
66a75f522f Bump the fasterxml group with 3 updates
Bumps the fasterxml group with 3 updates: [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson), [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) and [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson).


Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.19.0 to 2.19.1
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.19.0 to 2.19.1
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.19.0...jackson-core-2.19.1)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.19.0 to 2.19.1
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.19.0...jackson-core-2.19.1)

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.19.0 to 2.19.1
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-annotations
  dependency-version: 2.19.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-version: 2.19.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-version: 2.19.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-version: 2.19.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-30 02:37:25 +00:00
Tim Donohue
88a1ac08bf Merge pull request #10970 from DSpace/backport-10961-to-dspace-7_x
[Port dspace-7_x] Fix patching metadata on unknown field clears all DSO metadata
2025-06-27 15:03:33 -05:00
Tim Donohue
aac45284d2 Correct metadata value count for dspace-7_x 2025-06-27 14:06:33 -05:00
abhinav
130442746a move the exception to patchUtils
(cherry picked from commit a2dc6fbdf8)
2025-06-27 16:42:45 +00:00
abhinav
934f73f412 Update PatchMetadataIT
(cherry picked from commit 27d59085db)
2025-06-27 16:42:45 +00:00
abhinav
172783691b fix metadata getting cleared on patch request with invalid field
(cherry picked from commit e559af1841)
2025-06-27 16:42:44 +00:00
Tim Donohue
04f443b589 Merge pull request #10896 from mwoodiupui/9733-7
[Port dspace-7_x] filter-media:  make POI record buffer size adjustable.
2025-06-26 16:58:17 -05:00
Tim Donohue
61277b72d9 Merge pull request #10875 from alanorth/malformed-dates-7x
[Port dspace-7_x] dspace-api: improve date parsing for Solr sort indexes
2025-06-26 16:19:22 -05:00
Mark H. Wood
e2e402f0de Merge branch 'dspace-7_x' of github.com:DSpace/DSpace into 9733-7 2025-06-26 13:17:22 -04:00
Mark H. Wood
d0b5911cf6 Make POI record buffer size adjustable. 2025-06-26 13:16:32 -04:00
Alan Orth
27540b93bf Merge pull request #10865 from DSpace/dependabot/maven/dspace-7_x/jersey.version-2.47 2025-06-26 08:38:25 +02:00
Alan Orth
62512bdec8 Merge pull request #10915 from DSpace/dependabot/maven/dspace-7_x/org.postgresql-postgresql-42.7.7 2025-06-26 08:36:07 +02:00
Alan Orth
cd8c277ae5 Merge pull request #10950 from DSpace/dependabot/maven/dspace-7_x/log4j.version-2.25.0 2025-06-26 08:28:03 +02:00
Tim Donohue
9f9d810bea Merge pull request #10952 from max-nuding/backport-10688-to-dspace-7_x
[Port dspace-7_x] Allow collection admins to add new policies for bitstreams
2025-06-25 17:11:11 -05:00
Tim Donohue
57a1de5ecd Update deploy demo.dspace.org branch to 9.x to ensure older branches never trigger a redeploy. 2025-06-25 16:41:48 -05:00
max.nuding
e3b9179482 remove unnecessary code 2025-06-25 10:36:51 +02:00
dependabot[bot]
312416a716 Bump jersey.version from 2.46 to 2.47
Bumps `jersey.version` from 2.46 to 2.47.

Updates `org.glassfish.jersey.core:jersey-client` from 2.46 to 2.47

Updates `org.glassfish.jersey.inject:jersey-hk2` from 2.46 to 2.47

Updates `org.glassfish.jersey.core:jersey-server` from 2.46 to 2.47

Updates `org.glassfish.jersey.containers:jersey-container-servlet` from 2.46 to 2.47

Updates `org.glassfish.jersey.media:jersey-media-json-jackson` from 2.46 to 2.47

Updates `org.glassfish.jersey.media:jersey-media-jaxb` from 2.46 to 2.47

Updates `org.glassfish.jersey.ext:jersey-spring5` from 2.46 to 2.47

---
updated-dependencies:
- dependency-name: org.glassfish.jersey.core:jersey-client
  dependency-version: '2.47'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.inject:jersey-hk2
  dependency-version: '2.47'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.core:jersey-server
  dependency-version: '2.47'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.containers:jersey-container-servlet
  dependency-version: '2.47'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.media:jersey-media-json-jackson
  dependency-version: '2.47'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.media:jersey-media-jaxb
  dependency-version: '2.47'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.ext:jersey-spring5
  dependency-version: '2.47'
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-24 20:24:13 +00:00
dependabot[bot]
8839eefbe7 Bump org.postgresql:postgresql from 42.7.6 to 42.7.7
Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.7.6 to 42.7.7.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.7.6...REL42.7.7)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-version: 42.7.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-24 20:09:59 +00:00
Alan Orth
b594ebbf9e dspace-api: improve date parsing for Solr sort
Re-use DSpace date parsing from o.d.util.MultiFormatDateParser for
more robust date support when creating of Solr browse/sort indexes.
2025-06-24 22:08:07 +02:00
dependabot[bot]
230bf80b5f Bump log4j.version from 2.24.3 to 2.25.0
Bumps `log4j.version` from 2.24.3 to 2.25.0.

Updates `org.apache.logging.log4j:log4j-api` from 2.24.3 to 2.25.0

Updates `org.apache.logging.log4j:log4j-core` from 2.24.3 to 2.25.0

Updates `org.apache.logging.log4j:log4j-1.2-api` from 2.24.3 to 2.25.0

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-version: 2.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-version: 2.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-1.2-api
  dependency-version: 2.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-24 20:04:48 +00:00
max.nuding
b8923c986f fix imports for checkstyle 2025-06-24 07:01:56 +02:00
Alan Orth
c587d70a09 Merge pull request #10955 from tdonohue/fix_handle_ITs 2025-06-23 23:09:55 +02:00
Tim Donohue
8a84cba371 Fix broken ITs by removing unnecessary registrations and managing context permissions better 2025-06-23 15:33:50 -05:00
Tim Donohue
973c5f9daa Merge pull request #10918 from tuub/backport-10580-to-dspace-7_x
Backport 10580 to dspace 7 x
2025-06-23 11:54:43 -05:00
max.nuding
61c6e59a06 remove jakarta import 2025-06-23 11:44:22 +02:00
max.nuding
e90f792869 add missing imports 2025-06-23 11:36:52 +02:00
max.nuding
1732285d59 add import for Intstant 2025-06-23 10:12:56 +02:00
Mykhaylo Boychuk
03992be08d [DURACOM-318] remove unused import
(cherry picked from commit ed91462ccd7f99f5cf0dc326ed06ab42c13b80e0)
(cherry picked from commit 8df4e35e76)
2025-06-23 10:06:27 +02:00
Mykhaylo Boychuk
2104d605bd [DURACOM-318] improve code
(cherry picked from commit 8e0ca2e6f88b0251edf8a840f65135590c65f088)
(cherry picked from commit 4270170d40)
2025-06-23 10:06:25 +02:00
Adamo
a24340a197 [DURACOM-318] IT fix
(cherry picked from commit accba0738f)
2025-06-23 10:05:48 +02:00
Mykhaylo Boychuk
de5908725a [DURACOM-318] improve sucurity plugin
(cherry picked from commit b1ce88925ea36e84a77e667a94ae5577b5ee05b6)
(cherry picked from commit e9be8435ec)
2025-06-23 10:05:47 +02:00
Mykhaylo Boychuk
f92e376896 [DURACOM-318] update security annotations on ResourcePolicyRepository
(cherry picked from commit fabcc692db68e5232986ff062e849e4ec5c68c8b)
(cherry picked from commit 95836c271c)
2025-06-23 10:04:04 +02:00
Mykhaylo Boychuk
39def52592 [DURACOM-318] add new ITs for ResourcePolicy
(cherry picked from commit d78d4f00d94ef0d4b147031b075b8df1e8896fe4)
(cherry picked from commit 98c2b99421)
2025-06-23 10:04:01 +02:00
Alan Orth
6337f2fa67 Merge pull request #10838 from DSpace/dependabot/maven/dspace-7_x/bouncycastle.version-1.81 2025-06-17 14:38:05 +03:00
Sascha Szott
07e840b675 removal of configuration file sword-client.cfg 2025-06-16 13:38:06 +02:00
Sascha Szott
34134b3c3b remove inclusion of sword-client.cfg 2025-06-16 13:37:49 +02:00
Alan Orth
309e25e8c8 Merge pull request #10591 from alanorth/port-dspace7-10537
[Port dspace-7_x] Optimize count-only Solr queries
2025-06-13 07:13:37 +03:00
Tim Donohue
bc7a681428 Merge pull request #10883 from DSpace/backport-10583-to-dspace-7_x
[Port dspace-7_x] Introduce custom contributor for PubMed's abstract format on metadata import
2025-06-11 10:00:06 -05:00
Alan Orth
9eef166b7e dspace-api: set search fields in Solr query only if we are interested in the actual search results 2025-06-11 17:18:35 +03:00
Alan Orth
bd753005e6 dspace-api: do not request actual search hits in count-only query 2025-06-11 17:18:35 +03:00
Alan Orth
d9cc564ace dspace-api: use static variable RESOURCE_TYPE_FIELD 2025-06-11 17:18:35 +03:00
DSpace Bot
2abbe67ea6 [Port dspace-7_x] improve robustness of search in index field submit (use filter query) (#10890)
* improve robustness of search in index field submit (use filter query)

(cherry picked from commit a65ef008b7)

* fix checkstyle warnings

(cherry picked from commit 183d5ca671)

* fix checkstyle warning

(cherry picked from commit fe251f39e3)

---------

Co-authored-by: Sascha Szott <szott@gmx.de>
2025-06-11 15:26:49 +03:00
DSpace Bot
2c400bf2da [Port dspace-7_x] Optimization of Solr Queries: Transition to Filter Queries (#10887)
* use filter query instead of generic query

(cherry picked from commit f2417feeca)

* use filter query instead of generic query

(cherry picked from commit d83a2525ad)

* use filter query instead of generic query

(cherry picked from commit f3a976107e)

* remove obsolete comment

(cherry picked from commit 3ee2dbcc56)

* use filter query instead of generic query

(cherry picked from commit 318afc769a)

* add static imports

(cherry picked from commit 8ad19c42df)

* move static import to the top of the import block

(cherry picked from commit b85585c34e)

* move static imports to the top of the import block

(cherry picked from commit 4b446e24a0)

---------

Co-authored-by: Sascha Szott <szott@gmx.de>
2025-06-11 15:20:59 +03:00
Alan Orth
4afd54cbbb Merge pull request #10872 from tdonohue/remove_commons-fileupload
[dspace-7_x] Remove `commons-fileupload` as it is no longer used.
2025-06-11 08:58:21 +03:00
Jens Vannerum
1f174f4657 129944: Introduce custom abstract xpath contributor for pubmed to respect their labelled structure - modify IT for it
(cherry picked from commit 28bc4970b7)
2025-06-10 22:01:23 +00:00
Tim Donohue
144d9a25d2 Merge pull request #10864 from DSpace/dependabot/maven/dspace-7_x/net.handle-handle-9.3.2
Bump net.handle:handle from 9.3.1 to 9.3.2
2025-06-09 12:37:44 -05:00
Tim Donohue
a5ae3705e7 Remove commons-fileupload as it is no longer used. 2025-06-09 10:15:00 -05:00
Tim Donohue
d740232199 Merge pull request #10862 from DSpace/dependabot/maven/dspace-7_x/build-tools-0af78e14c7
Bump org.codehaus.mojo:build-helper-maven-plugin from 3.6.0 to 3.6.1 in the build-tools group
2025-06-09 09:23:58 -05:00
Tim Donohue
ec27f96d5f Merge pull request #10861 from DSpace/dependabot/maven/dspace-7_x/test-tools-05bec946dc
Bump the test-tools group with 6 updates
2025-06-09 09:22:38 -05:00
dependabot[bot]
358c00c199 Bump net.handle:handle from 9.3.1 to 9.3.2
Bumps net.handle:handle from 9.3.1 to 9.3.2.

---
updated-dependencies:
- dependency-name: net.handle:handle
  dependency-version: 9.3.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-09 03:09:56 +00:00
dependabot[bot]
a458fbd6ce Bump org.codehaus.mojo:build-helper-maven-plugin
Bumps the build-tools group with 1 update: [org.codehaus.mojo:build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin).


Updates `org.codehaus.mojo:build-helper-maven-plugin` from 3.6.0 to 3.6.1
- [Release notes](https://github.com/mojohaus/build-helper-maven-plugin/releases)
- [Commits](https://github.com/mojohaus/build-helper-maven-plugin/compare/3.6.0...3.6.1)

---
updated-dependencies:
- dependency-name: org.codehaus.mojo:build-helper-maven-plugin
  dependency-version: 3.6.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-09 03:08:40 +00:00
dependabot[bot]
0bc41bfaaf Bump the test-tools group with 6 updates
Bumps the test-tools group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.2.1.Final` | `4.2.2.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.2.1.Final` | `4.2.2.Final` |
| [io.netty:netty-transport-native-unix-common](https://github.com/netty/netty) | `4.2.1.Final` | `4.2.2.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.2.1.Final` | `4.2.2.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.2.1.Final` | `4.2.2.Final` |
| [io.netty:netty-codec](https://github.com/netty/netty) | `4.2.1.Final` | `4.2.2.Final` |


Updates `io.netty:netty-buffer` from 4.2.1.Final to 4.2.2.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.1.Final...netty-4.2.2.Final)

Updates `io.netty:netty-transport` from 4.2.1.Final to 4.2.2.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.1.Final...netty-4.2.2.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.2.1.Final to 4.2.2.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.1.Final...netty-4.2.2.Final)

Updates `io.netty:netty-common` from 4.2.1.Final to 4.2.2.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.1.Final...netty-4.2.2.Final)

Updates `io.netty:netty-handler` from 4.2.1.Final to 4.2.2.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.1.Final...netty-4.2.2.Final)

Updates `io.netty:netty-codec` from 4.2.1.Final to 4.2.2.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.1.Final...netty-4.2.2.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-version: 4.2.2.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-version: 4.2.2.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-version: 4.2.2.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-version: 4.2.2.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-version: 4.2.2.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-version: 4.2.2.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-09 03:07:54 +00:00
Alan Orth
415be6283a Merge pull request #10842 from DSpace/dependabot/maven/dspace-7_x/com.amazonaws-aws-java-sdk-s3-1.12.785
Bump com.amazonaws:aws-java-sdk-s3 from 1.12.783 to 1.12.785
2025-06-05 12:18:31 +03:00
kshepherd
94fe90f9d8 Merge pull request #10850 from DSpace/backport-10786-to-dspace-7_x
[Port dspace-7_x] Add HTTP timeouts in LiveImportClient to improve robustness
2025-06-04 23:06:19 +02:00
Sascha Szott
87ce9fd136 Add HTTP timeouts to improve robustness
(cherry picked from commit cabf5a7a44)
2025-06-04 19:24:16 +00:00
Tim Donohue
f2cbcca4c5 Merge pull request #10811 from DSpace/dependabot/maven/dspace-7_x/build-tools-137e7ca1b5
Bump org.apache.maven.plugins:maven-clean-plugin from 3.4.1 to 3.5.0 in the build-tools group
2025-06-04 14:08:28 -05:00
dependabot[bot]
a6cc912e62 Bump com.amazonaws:aws-java-sdk-s3 from 1.12.783 to 1.12.785
Bumps [com.amazonaws:aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.783 to 1.12.785.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.783...1.12.785)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-version: 1.12.785
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-04 14:25:57 +00:00
dependabot[bot]
21c56aeda7 Bump bouncycastle.version from 1.80 to 1.81
Bumps `bouncycastle.version` from 1.80 to 1.81.

Updates `org.bouncycastle:bcpkix-jdk18on` from 1.80 to 1.81
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

Updates `org.bouncycastle:bcprov-jdk18on` from 1.80 to 1.81
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

Updates `org.bouncycastle:bcutil-jdk18on` from 1.80 to 1.81
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

---
updated-dependencies:
- dependency-name: org.bouncycastle:bcpkix-jdk18on
  dependency-version: '1.81'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.bouncycastle:bcprov-jdk18on
  dependency-version: '1.81'
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.bouncycastle:bcutil-jdk18on
  dependency-version: '1.81'
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-04 14:25:16 +00:00
dependabot[bot]
25ad6039dc Bump org.apache.maven.plugins:maven-clean-plugin
Bumps the build-tools group with 1 update: [org.apache.maven.plugins:maven-clean-plugin](https://github.com/apache/maven-clean-plugin).


Updates `org.apache.maven.plugins:maven-clean-plugin` from 3.4.1 to 3.5.0
- [Release notes](https://github.com/apache/maven-clean-plugin/releases)
- [Commits](https://github.com/apache/maven-clean-plugin/compare/maven-clean-plugin-3.4.1...maven-clean-plugin-3.5.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-clean-plugin
  dependency-version: 3.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-04 14:25:05 +00:00
Alan Orth
de7fd98a34 Merge pull request #10812 from DSpace/dependabot/maven/dspace-7_x/com.opencsv-opencsv-5.11.1
Bump com.opencsv:opencsv from 5.11 to 5.11.1
2025-06-04 12:26:14 +03:00
kshepherd
3396233f2d Merge pull request #10822 from tdonohue/port_10806_to_7x
[Port dspace-7_x] Alphabetize external source importers by service name (on MyDSpace, etc)
2025-06-02 17:16:23 +02:00
Tim Donohue
19e22c10f1 Alphabetize importers by service name 2025-06-02 09:26:24 -05:00
dependabot[bot]
32bd615ba8 Bump com.opencsv:opencsv from 5.11 to 5.11.1
Bumps com.opencsv:opencsv from 5.11 to 5.11.1.

---
updated-dependencies:
- dependency-name: com.opencsv:opencsv
  dependency-version: 5.11.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-06-02 02:30:57 +00:00
Tim Donohue
91d845563a Merge pull request #10796 from DSpace/dependabot/maven/dspace-7_x/io.grpc-grpc-context-1.73.0
Bump io.grpc:grpc-context from 1.72.0 to 1.73.0
2025-05-28 15:47:03 -05:00
Tim Donohue
0ad9699128 Merge pull request #10797 from DSpace/dependabot/maven/dspace-7_x/org.postgresql-postgresql-42.7.6
Bump org.postgresql:postgresql from 42.7.5 to 42.7.6
2025-05-28 15:44:19 -05:00
Tim Donohue
9b1899de48 Merge pull request #10791 from DSpace/dependabot/maven/dspace-7_x/apache-commons-3e71c7e148
Bump commons-beanutils:commons-beanutils from 1.10.1 to 1.11.0 in the apache-commons group
2025-05-28 15:41:30 -05:00
dependabot[bot]
4367eebef2 Bump org.postgresql:postgresql from 42.7.5 to 42.7.6
Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.7.5 to 42.7.6.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.7.5...REL42.7.6)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-version: 42.7.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-28 16:28:25 +00:00
dependabot[bot]
b7960bd42e Bump io.grpc:grpc-context from 1.72.0 to 1.73.0
Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.72.0 to 1.73.0.
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](https://github.com/grpc/grpc-java/compare/v1.72.0...v1.73.0)

---
updated-dependencies:
- dependency-name: io.grpc:grpc-context
  dependency-version: 1.73.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-28 16:26:54 +00:00
dependabot[bot]
3fef856ef0 Bump commons-beanutils:commons-beanutils in the apache-commons group
Bumps the apache-commons group with 1 update: commons-beanutils:commons-beanutils.


Updates `commons-beanutils:commons-beanutils` from 1.10.1 to 1.11.0

---
updated-dependencies:
- dependency-name: commons-beanutils:commons-beanutils
  dependency-version: 1.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-28 16:25:45 +00:00
Tim Donohue
53b819b4b5 Merge pull request #10779 from DSpace/dependabot/maven/dspace-7_x/org.xmlunit-xmlunit-core-2.10.2
Bump org.xmlunit:xmlunit-core from 2.10.0 to 2.10.2
2025-05-28 08:03:47 -05:00
dependabot[bot]
a2a6838390 Bump org.xmlunit:xmlunit-core from 2.10.0 to 2.10.2
Bumps [org.xmlunit:xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.10.0 to 2.10.2.
- [Release notes](https://github.com/xmlunit/xmlunit/releases)
- [Changelog](https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md)
- [Commits](https://github.com/xmlunit/xmlunit/compare/v2.10.0...v2.10.2)

---
updated-dependencies:
- dependency-name: org.xmlunit:xmlunit-core
  dependency-version: 2.10.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-26 22:15:28 +00:00
Tim Donohue
c791ac1460 Merge pull request #10486 from atmire/issue-10484_fix-invalid-cast-in-DOIOrganiser
Fix invalid cast in DOIOrganiser exception handling
2025-05-23 09:43:10 -05:00
Tim Donohue
2330ff37b5 Merge pull request #10760 from tdonohue/port_10758_to_7x
[Port dspace-7_x] Bump XOAI to 3.4.1
2025-05-19 14:40:09 -05:00
Tim Donohue
a1582d9477 Bump XOAI to 3.4.1 2025-05-19 14:07:02 -05:00
Tim Donohue
46440dcc2d Merge pull request #10752 from DSpace/backport-10611-to-dspace-7_x
[Port dspace-7_x] Use application/json as mime type for iiif manifests
2025-05-15 12:07:03 -05:00
Kim Shepherd
8b3618f583 [#10611] Remove json mime test from findOneCanvas
(cherry picked from commit e07e051e67)
2025-05-15 15:42:16 +00:00
Kim Shepherd
878ecdc09d [#10611] Add mime type checks in IIIFControllerIT
(cherry picked from commit 87c82f234c)
2025-05-15 15:42:16 +00:00
Pascal-Nicolas Becker
a46e01d6db Use application/json as mime type for iiif manifests
(cherry picked from commit 643e9984c7)
2025-05-15 15:42:16 +00:00
Tim Donohue
e26fd0d9dc Merge pull request #10748 from DSpace/backport-10745-to-dspace-7_x
[Port dspace-7_x] Improve DSpaceObjectService string comparison tests
2025-05-14 15:53:11 -05:00
Kim Shepherd
a2a0649227 [#10744] Update Javadoc in DSpaceObjectService (Item.ANY usage)
(cherry picked from commit 9aa74b8e68)
2025-05-14 19:53:23 +00:00
Kim Shepherd
359dc609a8 [#10744] Improve String comparison in DSpaceObjectServiceImpl
(cherry picked from commit b089fd6442)
2025-05-14 19:53:23 +00:00
Tim Donohue
e6475dc04f Merge pull request #10746 from DSpace/backport-10184-to-dspace-7_x
[Port dspace-7_x] conditional rendering of metadata section in style.xsl
2025-05-14 14:42:04 -05:00
Sascha Szott
fa603b2a58 add conditional check in metadata card rendering
(cherry picked from commit b681145343)
2025-05-14 18:30:19 +00:00
Sascha Szott
bbfc6874a4 conditional rendering for metadata section in style.xsl
(cherry picked from commit addc26ad19)
2025-05-14 18:30:19 +00:00
Tim Donohue
92a92abe9f Merge pull request #10734 from DSpace/dependabot/maven/dspace-7_x/webjars-36a72e2b67
Bump org.webjars.npm:json-editor__json-editor from 2.15.1 to 2.15.2 in the webjars group
2025-05-13 14:41:06 -05:00
Tim Donohue
66b6ed3f4a Must update version in index.html to complete upgrade 2025-05-13 12:12:50 -05:00
Tim Donohue
02ead6997f Merge pull request #10733 from DSpace/dependabot/maven/dspace-7_x/test-tools-3dcec26f7e
Bump the test-tools group with 6 updates
2025-05-13 12:06:25 -05:00
dependabot[bot]
5765bff79c Bump org.webjars.npm:json-editor__json-editor in the webjars group
Bumps the webjars group with 1 update: [org.webjars.npm:json-editor__json-editor](https://github.com/json-editor/json-editor).


Updates `org.webjars.npm:json-editor__json-editor` from 2.15.1 to 2.15.2
- [Changelog](https://github.com/json-editor/json-editor/blob/master/CHANGELOG.md)
- [Commits](https://github.com/json-editor/json-editor/compare/2.15.1...2.15.2)

---
updated-dependencies:
- dependency-name: org.webjars.npm:json-editor__json-editor
  dependency-version: 2.15.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: webjars
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-12 22:49:31 +00:00
dependabot[bot]
42e979a021 Bump the test-tools group with 6 updates
Bumps the test-tools group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.2.0.Final` | `4.2.1.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.2.0.Final` | `4.2.1.Final` |
| [io.netty:netty-transport-native-unix-common](https://github.com/netty/netty) | `4.2.0.Final` | `4.2.1.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.2.0.Final` | `4.2.1.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.2.0.Final` | `4.2.1.Final` |
| [io.netty:netty-codec](https://github.com/netty/netty) | `4.2.0.Final` | `4.2.1.Final` |


Updates `io.netty:netty-buffer` from 4.2.0.Final to 4.2.1.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.0.Final...netty-4.2.1.Final)

Updates `io.netty:netty-transport` from 4.2.0.Final to 4.2.1.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.0.Final...netty-4.2.1.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.2.0.Final to 4.2.1.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.0.Final...netty-4.2.1.Final)

Updates `io.netty:netty-common` from 4.2.0.Final to 4.2.1.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.0.Final...netty-4.2.1.Final)

Updates `io.netty:netty-handler` from 4.2.0.Final to 4.2.1.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.0.Final...netty-4.2.1.Final)

Updates `io.netty:netty-codec` from 4.2.0.Final to 4.2.1.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.2.0.Final...netty-4.2.1.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-version: 4.2.1.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-version: 4.2.1.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-version: 4.2.1.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-version: 4.2.1.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-version: 4.2.1.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-version: 4.2.1.Final
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-12 22:48:26 +00:00
Tim Donohue
102649b404 Merge pull request #10726 from DSpace/backport-10725-to-dspace-7_x
[Port dspace-7_x] Potential fix for code scanning alert no. 3549: Arbitrary file access during archive extraction ("Zip Slip")
2025-05-09 16:03:49 -05:00
Tim Donohue
086a26d3b4 Potential fix for code scanning alert no. 3549: Arbitrary file access during archive extraction ("Zip Slip")
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
(cherry picked from commit 5fbdfc218f)
2025-05-09 19:15:44 +00:00
Tim Donohue
44d657da1e Merge pull request #10724 from 4Science/task/dspace-7_x/DURACOM-109
[Port dspace-7_x] Proxy Configuration and Connection Leak using HTTP Clients
2025-05-09 12:16:51 -05:00
Stefano Maffei
53e4147910 [DURACOM-109] fix dependency error 2025-05-09 16:12:50 +02:00
Stefano Maffei
2c6f02f74c [DURACOM-109] fix missing dependency 2025-05-09 15:59:50 +02:00
Stefano Maffei
01527712c1 Merge remote-tracking branch 'dspaceCommunity/dspace-7_x' into task/dspace-7_x/DURACOM-109 2025-05-09 15:28:48 +02:00
Tim Donohue
e975ed42b0 Merge pull request #10716 from 4Science/task/dspace-7_x/DURACOM-328
[Port dspace-7_x] FIX Submission patch operation weird recognition check
2025-05-07 09:48:46 -05:00
Elios Buzo
1ade960988 [DURACOM-109] Fixed conflicts 2025-05-07 12:28:43 +02:00
Stefano Maffei
ac20eefe4b [DURACOM-328] fix tests 2025-05-07 10:43:19 +02:00
Stefano Maffei
0ef3b27189 [DURACOM-328] fix test 2025-05-07 09:24:38 +02:00
Stefano Maffei
032252664b [DURACOM-328] fix error in check for Patch request 2025-05-07 09:24:06 +02:00
Tim Donohue
05f96db258 Merge pull request #10706 from DSpace/dependabot/maven/dspace-7_x/com.amazonaws-aws-java-sdk-s3-1.12.783
Bump com.amazonaws:aws-java-sdk-s3 from 1.12.782 to 1.12.783
2025-05-06 12:41:44 -05:00
Tim Donohue
c8fa70073d Merge pull request #10708 from DSpace/dependabot/maven/dspace-7_x/com.opencsv-opencsv-5.11
Bump com.opencsv:opencsv from 5.10 to 5.11
2025-05-06 12:40:26 -05:00
Tim Donohue
5169c48632 Merge pull request #10707 from DSpace/dependabot/maven/dspace-7_x/tika.version-2.9.4
Bump tika.version from 2.9.3 to 2.9.4
2025-05-06 11:58:01 -05:00
Stefano Maffei
409b775d35 [DURACOM-109] fix TruncatedChunkException error 2025-05-06 17:27:21 +02:00
Stefano Maffei
dbcaac4b08 [DURACOM-109] added checkstyle rules to forbid usage of HttpClientBuilder.create() 2025-05-06 17:27:07 +02:00
Stefano Maffei
9d6c482cc4 [DURACOM-109] Orcid connector fix and improvement 2025-05-06 17:26:07 +02:00
Stefano Maffei
0f1679ed72 [DURACOM-109] fix typo and correct logic for ORCID connector 2025-05-06 17:25:34 +02:00
Elios Buzo
7f865ad956 [DURACOM-109] Linter error fix 2025-05-06 17:22:50 +02:00
Elios Buzo
f4390fef52 [DURACOM-109] Continued fixing http connection leaks 2025-05-06 17:22:26 +02:00
Elios Buzo
f9307b617c [DURACOM-109] Minor fix 2025-05-06 17:20:09 +02:00
Elios Buzo
b9352c9149 [DURACOM-109] Fixed http connection leaks 2025-05-06 17:19:29 +02:00
Elios Buzo
32dd1a3dd2 [DURACOM-109] Minor fix 2025-05-06 17:18:38 +02:00
Elios Buzo
a8d33d3ad0 [DURACOM-109] Continued configuring proxy for other classes 2025-05-06 17:17:07 +02:00
Elios Buzo
c2c41e65f8 [DURACOM-109] Configured proxy settings for all clients 2025-05-06 17:10:17 +02:00
Alan Orth
4c7d9223cb Merge pull request #10713 from DSpace/backport-10556-to-dspace-7_x
[Port dspace-7_x] Fix tests failing in TikaTextExtractionFilterTest
2025-05-06 09:56:05 +03:00
abhinav
930565efff 129614: Fixed tests failing in TikaTextExtractionFilterTest when textextractor.use-temp-file is set to true
(cherry picked from commit f9f29f49cb)
2025-05-06 06:20:23 +00:00
dependabot[bot]
8b089be727 Bump com.opencsv:opencsv from 5.10 to 5.11
Bumps com.opencsv:opencsv from 5.10 to 5.11.

---
updated-dependencies:
- dependency-name: com.opencsv:opencsv
  dependency-version: '5.11'
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-05 23:11:48 +00:00
dependabot[bot]
f5e83433c4 Bump tika.version from 2.9.3 to 2.9.4
Bumps `tika.version` from 2.9.3 to 2.9.4.

Updates `org.apache.tika:tika-core` from 2.9.3 to 2.9.4
- [Changelog](https://github.com/apache/tika/blob/2.9.4/CHANGES.txt)
- [Commits](https://github.com/apache/tika/compare/2.9.3...2.9.4)

Updates `org.apache.tika:tika-parsers-standard-package` from 2.9.3 to 2.9.4

---
updated-dependencies:
- dependency-name: org.apache.tika:tika-core
  dependency-version: 2.9.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.tika:tika-parsers-standard-package
  dependency-version: 2.9.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-05 23:02:34 +00:00
dependabot[bot]
a26ef22a46 Bump com.amazonaws:aws-java-sdk-s3 from 1.12.782 to 1.12.783
Bumps [com.amazonaws:aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.782 to 1.12.783.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.782...1.12.783)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-version: 1.12.783
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-05 22:58:31 +00:00
Tim Donohue
1052e6b787 Merge pull request #10705 from tdonohue/port_10693_to_7x
[Port dspace-7_x] ISSN code not imported when using SHERPA import
2025-05-05 13:50:04 -05:00
Adamo
d7948d5f7b [DURACOM-356] Updated tests to use metadata constants 2025-05-05 12:32:26 -05:00
Adamo
5dd4e4248c [DURACOM-356] Updated Sherpa Journal mapping to use creativeworkseries.issn instead of dc.identifier.issn 2025-05-05 12:29:32 -05:00
Adamo
bacbe06b2c [DURACOM-356] Fixed tests 2025-05-05 12:29:24 -05:00
Adamo
a0c2891226 [DURACOM-356] Updated Sherpa mapping to use creativeworkseries.issn instead of dc.identifier.issn 2025-05-05 12:29:17 -05:00
Tim Donohue
663ffcf2b1 Merge pull request #10698 from DSpace/backport-10697-to-dspace-7_x
[Port dspace-7_x] Bulk access control fails to iterate over each item in a collection, producing duplicate policies for some items
2025-05-02 16:46:58 -05:00
Tim Donohue
3f9f5639f6 Must use older Java syntax in DSpace 7 2025-05-02 15:49:00 -05:00
Adamo
605956b073 [DURACOM-311] Ensure stable pagination in bulk access control by adding explicit sort
(cherry picked from commit ced9e9b9f7)
2025-05-02 19:56:23 +00:00
Tim Donohue
fd33cee025 Merge pull request #10695 from DSpace/backport-10692-to-dspace-7_x
[Port dspace-7_x] Error when using WOS import service
2025-05-02 10:42:35 -05:00
Adamo
eb5f09f3f2 [DURACOM-355] Update to avoid NPE during WOS live import when no api key is found
(cherry picked from commit 70f1c83bf0)
2025-05-02 15:08:39 +00:00
Jens Vannerum
fae4130d41 119612: Fix limit not applying on export
(cherry picked from commit bcf48821d9)
2025-05-02 11:14:58 +02:00
Jens Vannerum
5929fdc926 124504: Move configuration to be included in the bulkedit module and apply the configured limit earlier, never obtaining a larger list than actually required
(cherry picked from commit b63ffd2eb4)
2025-05-02 11:14:49 +02:00
Jens Vannerum
c5c8417848 119612: Remove group configuration and expose property to angular
(cherry picked from commit c73c739deb)
2025-05-02 11:14:19 +02:00
Jens Vannerum
4626b06d7f 119612: property should be commented by default and have a normal limit
(cherry picked from commit a8b98bb7b7)
2025-05-02 11:12:49 +02:00
Jens Vannerum
4ec611bf79 119612: configurable limit on exporting items since it can take up a bunch of resources
(cherry picked from commit b634e1e380)
2025-05-02 11:12:46 +02:00
Tim Donohue
bf917357a6 Merge pull request #10687 from tdonohue/port_10685_to_7x
[Port dspace-7_x] Remove `javax.el` dependency & replace `MethodNotFoundException` with `UnsupportedOperationException`
2025-05-01 13:46:54 -05:00
Tim Donohue
d83779022e Remove javax.el dependency 2025-05-01 12:53:41 -05:00
Tim Donohue
b04eb9d725 Replace MethodNotFoundException with more appropriate UnsupportedOperationException 2025-05-01 12:53:13 -05:00
Tim Donohue
4821e75294 Merge pull request #10353 from atmire/cli-speed-improvements-periodically-uncache-entities-when-processing-many_7-x
[Port dspace-7_x] Index discovery speed improvement - periodically uncache entities when processing many items
2025-04-30 11:55:34 -05:00
kshepherd
f4e02b73f2 Merge pull request #10681 from DSpace/backport-10668-to-dspace-7_x
[Port dspace-7_x] Fix Collection Admin cannot see withdrawn item metadata
2025-04-30 14:16:51 +02:00
Stefano Maffei
4a89a68736 [DURACOM-357] improved javadoc
(cherry picked from commit f1cb3c3ad1)
2025-04-30 11:45:56 +00:00
Stefano Maffei
2429a0ba29 [DURACOM-357] improved admin check
(cherry picked from commit bb3935a047)
2025-04-30 11:45:56 +00:00
Stefano Maffei
8ca8bd4543 [DURACOM-357] improved check for authorization on objects in ItemConverter
(cherry picked from commit a70dede20b)
2025-04-30 11:45:56 +00:00
Stefano Maffei
c6098c0232 [DURACOM-357] fix Collection Admin cannot see withdrawn item metadata
(cherry picked from commit 5e2bb4fb92)
2025-04-30 11:45:56 +00:00
kshepherd
b937fa8799 Merge pull request #10677 from DSpace/backport-10675-to-dspace-7_x
[Port dspace-7_x] Resolving XML external entity in user-controlled data in PubMedImport
2025-04-30 13:24:05 +02:00
Tim Donohue
90ea371e0b Cannot disable DTDs with PubMed, so instead disallow external entities & entity expansion
(cherry picked from commit f9614c41a6)
2025-04-30 10:24:14 +00:00
Tim Donohue
6fe9af84bd Potential fix for code scanning alert no. 30: Resolving XML external entity in user-controlled data
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
(cherry picked from commit a0ce50b2a4)
2025-04-30 10:24:14 +00:00
Tim Donohue
1494732989 Merge pull request #10673 from DSpace/backport-10640-to-dspace-7_x
[Port dspace-7_x] Improve CLI RegistryLoader, InitializeEntities, Curation commands
2025-04-29 15:37:28 -05:00
Kim Shepherd
85a9e4b731 Let Curation CLI accept uuid identifiers
(cherry picked from commit 5020689095)
2025-04-29 19:50:29 +00:00
Kim Shepherd
fbb496e1c6 Improve help and docs for RegistryLoader
And a few other small improvements

(cherry picked from commit f1b4e6ef17)
2025-04-29 19:50:29 +00:00
Kim Shepherd
98921724f4 Add help opt and javadoc to InitializeEntities
(cherry picked from commit 5240a02996)
2025-04-29 19:50:29 +00:00
Tim Donohue
f94a4e4b71 Merge pull request #10671 from DSpace/backport-10669-to-dspace-7_x
[Port dspace-7_x] Make DiscoveryConfigurationService "get all facet configs" return UNIQUE set
2025-04-29 14:00:45 -05:00
Kim Shepherd
e94d934a5c Make getAllFacetConfigs unique
Improve performance and debuggability by
refactoring getAllFacetConfigs to
getAllUniqueFacetConfigs. Used only by
ChoiceAuthorityService to generate hierarchical
vocabulary map for the browse menu, etc.

(cherry picked from commit 159bd18529)
2025-04-29 17:23:57 +00:00
Tim Donohue
160a70ed16 Merge pull request #10663 from DSpace/dependabot/maven/dspace-7_x/google-apis-b1f0883f77
Bump the google-apis group with 3 updates
2025-04-29 06:56:21 -05:00
Tim Donohue
d63a088e70 Merge pull request #10661 from DSpace/dependabot/maven/dspace-7_x/apache-commons-f6cb4980f5
Bump the apache-commons group with 2 updates
2025-04-29 06:55:48 -05:00
Tim Donohue
46880b025e Merge pull request #10658 from DSpace/dependabot/maven/dspace-7_x/fasterxml-111bca66b8
Bump the fasterxml group with 3 updates
2025-04-29 06:54:28 -05:00
Alan Orth
23dfcf0af6 Merge pull request #10665 from DSpace/dependabot/maven/dspace-7_x/pdfbox-version-2.0.34
Bump pdfbox-version from 2.0.33 to 2.0.34
2025-04-29 12:52:24 +03:00
dependabot[bot]
19010353c9 Bump pdfbox-version from 2.0.33 to 2.0.34
Bumps `pdfbox-version` from 2.0.33 to 2.0.34.

Updates `org.apache.pdfbox:pdfbox` from 2.0.33 to 2.0.34

Updates `org.apache.pdfbox:fontbox` from 2.0.33 to 2.0.34

---
updated-dependencies:
- dependency-name: org.apache.pdfbox:pdfbox
  dependency-version: 2.0.34
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.pdfbox:fontbox
  dependency-version: 2.0.34
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-29 00:15:34 +00:00
dependabot[bot]
5400e3f8a8 Bump the google-apis group with 3 updates
Bumps the google-apis group with 3 updates: [com.google.http-client:google-http-client](https://github.com/googleapis/google-http-java-client), [com.google.http-client:google-http-client-jackson2](https://github.com/googleapis/google-http-java-client) and [com.google.http-client:google-http-client-gson](https://github.com/googleapis/google-http-java-client).


Updates `com.google.http-client:google-http-client` from 1.46.3 to 1.47.0
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.46.3...v1.47.0)

Updates `com.google.http-client:google-http-client-jackson2` from 1.46.3 to 1.47.0
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.46.3...v1.47.0)

Updates `com.google.http-client:google-http-client-gson` from 1.46.3 to 1.47.0
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.46.3...v1.47.0)

---
updated-dependencies:
- dependency-name: com.google.http-client:google-http-client
  dependency-version: 1.47.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-jackson2
  dependency-version: 1.47.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-gson
  dependency-version: 1.47.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-29 00:02:22 +00:00
dependabot[bot]
ff67241bc9 Bump the apache-commons group with 2 updates
Bumps the apache-commons group with 2 updates: org.apache.commons:commons-collections4 and org.apache.commons:commons-configuration2.


Updates `org.apache.commons:commons-collections4` from 4.4 to 4.5.0

Updates `org.apache.commons:commons-configuration2` from 2.11.0 to 2.12.0

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-collections4
  dependency-version: 4.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-configuration2
  dependency-version: 2.12.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-29 00:01:34 +00:00
dependabot[bot]
b949bdd4c0 Bump the fasterxml group with 3 updates
Bumps the fasterxml group with 3 updates: [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson), [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) and [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson).


Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.18.3 to 2.19.0
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.18.3 to 2.19.0
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.18.3...jackson-core-2.19.0)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.18.3 to 2.19.0
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.18.3...jackson-core-2.19.0)

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.18.3 to 2.19.0
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-annotations
  dependency-version: 2.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-version: 2.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-version: 2.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-version: 2.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-28 23:58:24 +00:00
Tim Donohue
e4d5d7cbcc Merge pull request #10241 from atmire/w2p-124362_VersionedHandleIdentifierProviderWithCanonicalHandles-and-com-col-handles
Fix issue with VersionedHandleIdentifierProviderWithCanonicalHandles and com/col handles
2025-04-28 16:05:21 -05:00
Tim Donohue
1278068eaa Merge pull request #10647 from DSpace/backport-10636-to-dspace-7_x
[Port dspace-7_x] Fix: import public email from ORCID person
2025-04-25 16:35:47 -05:00
Jesiel Viana
106936967e removing duplicated files
(cherry picked from commit c6d1121cbe)
2025-04-25 20:08:08 +00:00
Jesiel Viana
cf9e5c1cd4 fix: Checkstyle violations
(cherry picked from commit 9a831e5393)
2025-04-25 20:08:08 +00:00
Jesiel Viana
ac7dfc562f fix: import public email from ORCID person
(cherry picked from commit 82ca80cd6b)
2025-04-25 20:08:08 +00:00
Tim Donohue
37338424e3 Merge pull request #10645 from tdonohue/port_10549_to_7x
[Port dspace-7_x] restrict maximum value of URL parameter rpp in OpenSearchController to a reasonable default
2025-04-25 08:50:03 -05:00
Sascha Szott
1a619b2833 restrict maximum value of URL parameter rpp 2025-04-24 16:49:59 -05:00
Sascha Szott
ca3b2de1a8 add configuration key websvc.opensearch.max_num_of_items_per_request 2025-04-24 16:48:54 -05:00
Sascha Szott
869d122eac implement method getMaxNumOfItemsPerRequest 2025-04-24 16:48:48 -05:00
Sascha Szott
045a5c0b0e add method getMaxNumOfItemsPerRequest 2025-04-24 16:48:42 -05:00
Tim Donohue
9d1e2d5f9d Merge pull request #10641 from DSpace/backport-10505-to-dspace-7_x
[Port dspace-7_x] Fix incorrect parsing of access-status metadata
2025-04-24 15:15:51 -05:00
Agustina Martinez
440bb64809 Update dim.xsl
Added template to correctly parse elements under "others" metadata element

(cherry picked from commit ac7da6a477)
2025-04-24 19:44:57 +00:00
Tim Donohue
0695b6756c Merge pull request #10623 from DSpace/backport-10599-to-dspace-7_x
[Port dspace-7_x] Fix login endpoints not automatically closing their Context
2025-04-23 11:12:18 -05:00
Tim Donohue
c8a0c94f78 Merge pull request #10630 from DSpace/dependabot/maven/dspace-7_x/io.grpc-grpc-context-1.72.0
Bump io.grpc:grpc-context from 1.71.0 to 1.72.0
2025-04-22 09:41:48 -05:00
dependabot[bot]
5d880bcf2d Bump io.grpc:grpc-context from 1.71.0 to 1.72.0
Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.71.0 to 1.72.0.
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](https://github.com/grpc/grpc-java/compare/v1.71.0...v1.72.0)

---
updated-dependencies:
- dependency-name: io.grpc:grpc-context
  dependency-version: 1.72.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-21 23:03:07 +00:00
Alexandre Vryghem
133c280883 126885: Removed database connection leak on logout
(cherry picked from commit b299a96076)
2025-04-18 19:01:50 +00:00
Alexandre Vryghem
0a79903f30 126885: Removed database connection leak on login
Also:
- Updated EPersonRestAuthenticationProvider to not open an additional DB connection, and reuse the existing one instead
- Normalized the behaviour of OidcLoginFilter by not calling the redirectAfterSuccess instead of doing a chain.doFilter(req, res). This way we don't need to reopen a new Context

(cherry picked from commit 518fb3b1d8)
2025-04-18 19:01:50 +00:00
kshepherd
4ec40054b1 Merge pull request #10617 from DSpace/backport-10519-to-dspace-7_x
[Port dspace-7_x] Fix metadata browsing in descending order using a json.facet to retrieve index values
2025-04-17 15:56:50 +02:00
Toni Prieto
b2f44f57f9 Add test for browse entries pagination
(cherry picked from commit a7bc82084e)
2025-04-17 13:21:02 +00:00
Toni Prieto
d6ff41d9f5 Refactor browse entries facet query to use JSON facet query
(cherry picked from commit 8e88547932)
2025-04-17 13:21:02 +00:00
Tim Donohue
6817d2aa59 Merge pull request #10614 from DSpace/backport-10613-to-dspace-7_x
[Port dspace-7_x] [DURACOM-346] SubscribeServiceImpl : the method "isSubscribed" returns incorrect result
2025-04-16 12:05:37 -05:00
Piaget Bouaka Donfack
3a894e5f5d [DURACOM-346] SubscribeServiceImpl : the method "isSubscribed" returns incorrect result
(cherry picked from commit 23468d4ee3)
2025-04-16 16:28:22 +00:00
Tim Donohue
d74ae7345e Merge pull request #10604 from DSpace/dependabot/maven/dspace-7_x/apache-commons-9d0a8b4b96
Bump the apache-commons group with 2 updates
2025-04-15 09:45:46 -05:00
Alan Orth
3f653411cf Merge pull request #10605 from DSpace/backport-10109-to-dspace-7_x 2025-04-15 10:23:35 +03:00
Toni Prieto
086e54cb31 Modify Solr query to find collections with submit permissions in searches with spaces
(cherry picked from commit 425dc1556e)
2025-04-15 06:32:12 +00:00
dependabot[bot]
dd62a57564 Bump the apache-commons group with 2 updates
Bumps the apache-commons group with 2 updates: commons-io:commons-io and org.apache.commons:commons-text.


Updates `commons-io:commons-io` from 2.18.0 to 2.19.0

Updates `org.apache.commons:commons-text` from 1.13.0 to 1.13.1

---
updated-dependencies:
- dependency-name: commons-io:commons-io
  dependency-version: 2.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-text
  dependency-version: 1.13.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-14 23:11:31 +00:00
Tim Donohue
e8ee694f21 Merge pull request #10588 from atmire/backport-10485-to-dspace-7_x
[Port dspace-7_x] SEOHealthIndicator which verifies all relevant parameters for SEO issues
2025-04-11 09:27:54 -05:00
Jens Vannerum
5b8782509f 127746: Include success result for robots.txt check if other checks fail
(cherry picked from commit 5dc12775fa)
2025-04-11 15:48:48 +02:00
Jens Vannerum
64c5f82209 127746: Add more detailed information messages on how to solve problems
(cherry picked from commit 170dc9a44c)
2025-04-11 15:48:48 +02:00
Jens Vannerum
7a876999f8 127746: Implement different failures for robots file so we can differentiate between a missing file or an invalid file
(cherry picked from commit 32c0484280)
2025-04-11 15:48:48 +02:00
Jens Vannerum
31549bdace Disable new actuator in IT
(cherry picked from commit 20ab43cccc)
2025-04-11 15:48:45 +02:00
Jens Vannerum
e122a90674 Implement a SEOHealthIndicator which verifies all relevant parameters for SEO are ok
(cherry picked from commit 4bd8a24ca7)
2025-04-11 15:46:34 +02:00
Tim Donohue
ac7eee6465 Merge pull request #10472 from DSpace/dependabot/maven/dspace-7_x/fasterxml-560de934c1
Bump the fasterxml group with 3 updates
2025-04-09 10:12:10 -05:00
Tim Donohue
503f78f065 Merge pull request #10571 from DSpace/dependabot/maven/dspace-7_x/build-tools-8be766aa5b
Bump the build-tools group across 1 directory with 5 updates
2025-04-09 10:11:14 -05:00
Tim Donohue
8d79120eec Merge pull request #10469 from DSpace/dependabot/maven/dspace-7_x/google-apis-88ea69a71a
Bump the google-apis group across 1 directory with 4 updates
2025-04-08 13:24:57 -05:00
Tim Donohue
76018e0048 Merge pull request #10482 from DSpace/dependabot/maven/dspace-7_x/io.grpc-grpc-context-1.71.0
Bump io.grpc:grpc-context from 1.70.0 to 1.71.0
2025-04-08 13:24:11 -05:00
Tim Donohue
5fd134d7cf Merge pull request #10544 from DSpace/dependabot/maven/dspace-7_x/joda-time-joda-time-2.14.0
Bump joda-time:joda-time from 2.13.1 to 2.14.0
2025-04-08 13:23:15 -05:00
Tim Donohue
3de7bab453 Merge pull request #10449 from DSpace/dependabot/maven/dspace-7_x/com.amazonaws-aws-java-sdk-s3-1.12.782
Bump com.amazonaws:aws-java-sdk-s3 from 1.12.781 to 1.12.782
2025-04-08 13:21:39 -05:00
dependabot[bot]
16239433f6 Bump io.grpc:grpc-context from 1.70.0 to 1.71.0
Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.70.0 to 1.71.0.
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](https://github.com/grpc/grpc-java/compare/v1.70.0...v1.71.0)

---
updated-dependencies:
- dependency-name: io.grpc:grpc-context
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-08 15:47:34 +00:00
dependabot[bot]
bb2ed04ed3 Bump the build-tools group across 1 directory with 5 updates
Bumps the build-tools group with 5 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [com.github.spotbugs:spotbugs](https://github.com/spotbugs/spotbugs) | `4.9.1` | `4.9.3` |
| [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) | `3.13.0` | `3.14.0` |
| [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) | `4.9.1.0` | `4.9.3.0` |
| [org.apache.maven.plugins:maven-clean-plugin](https://github.com/apache/maven-clean-plugin) | `3.4.0` | `3.4.1` |
| [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) | `0.8.12` | `0.8.13` |



Updates `com.github.spotbugs:spotbugs` from 4.9.1 to 4.9.3
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.9.1...4.9.3)

Updates `org.apache.maven.plugins:maven-compiler-plugin` from 3.13.0 to 3.14.0
- [Release notes](https://github.com/apache/maven-compiler-plugin/releases)
- [Commits](https://github.com/apache/maven-compiler-plugin/compare/maven-compiler-plugin-3.13.0...maven-compiler-plugin-3.14.0)

Updates `com.github.spotbugs:spotbugs-maven-plugin` from 4.9.1.0 to 4.9.3.0
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.9.1.0...spotbugs-maven-plugin-4.9.3.0)

Updates `org.apache.maven.plugins:maven-clean-plugin` from 3.4.0 to 3.4.1
- [Release notes](https://github.com/apache/maven-clean-plugin/releases)
- [Commits](https://github.com/apache/maven-clean-plugin/compare/maven-clean-plugin-3.4.0...maven-clean-plugin-3.4.1)

Updates `org.jacoco:jacoco-maven-plugin` from 0.8.12 to 0.8.13
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](https://github.com/jacoco/jacoco/compare/v0.8.12...v0.8.13)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs
  dependency-version: 4.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-compiler-plugin
  dependency-version: 3.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-version: 4.9.3.0
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-clean-plugin
  dependency-version: 3.4.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: org.jacoco:jacoco-maven-plugin
  dependency-version: 0.8.13
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-08 15:36:26 +00:00
dependabot[bot]
a5806fb518 Bump the google-apis group across 1 directory with 4 updates
Bumps the google-apis group with 4 updates in the / directory: [com.google.http-client:google-http-client](https://github.com/googleapis/google-http-java-client), [com.google.http-client:google-http-client-jackson2](https://github.com/googleapis/google-http-java-client), [com.google.oauth-client:google-oauth-client](https://github.com/googleapis/google-oauth-java-client) and [com.google.http-client:google-http-client-gson](https://github.com/googleapis/google-http-java-client).


Updates `com.google.http-client:google-http-client` from 1.46.1 to 1.46.3
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.46.1...v1.46.3)

Updates `com.google.http-client:google-http-client-jackson2` from 1.46.1 to 1.46.3
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.46.1...v1.46.3)

Updates `com.google.oauth-client:google-oauth-client` from 1.37.0 to 1.38.0
- [Release notes](https://github.com/googleapis/google-oauth-java-client/releases)
- [Changelog](https://github.com/googleapis/google-oauth-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-oauth-java-client/compare/v1.37.0...v1.38.0)

Updates `com.google.http-client:google-http-client-gson` from 1.46.1 to 1.46.3
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.46.1...v1.46.3)

---
updated-dependencies:
- dependency-name: com.google.http-client:google-http-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-jackson2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: google-apis
- dependency-name: com.google.oauth-client:google-oauth-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-gson
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: google-apis
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-08 15:35:52 +00:00
dependabot[bot]
b64b79973d Bump the fasterxml group with 3 updates
Bumps the fasterxml group with 3 updates: [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson), [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) and [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson).


Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.18.2 to 2.18.3
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.18.2 to 2.18.3
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.18.2...jackson-core-2.18.3)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.18.2 to 2.18.3
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.18.2...jackson-core-2.18.3)

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.18.2 to 2.18.3
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-annotations
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: fasterxml
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-08 15:35:47 +00:00
Tim Donohue
7d5db89889 Merge pull request #10470 from DSpace/dependabot/maven/dspace-7_x/test-tools-fd1863f7f0
Bump the test-tools group with 6 updates
2025-04-08 09:26:20 -05:00
dependabot[bot]
c8cc425357 Bump com.amazonaws:aws-java-sdk-s3 from 1.12.781 to 1.12.782
Bumps [com.amazonaws:aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.781 to 1.12.782.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.781...1.12.782)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-08 14:23:43 +00:00
Tim Donohue
5fa01ef63e Merge pull request #10570 from tdonohue/remove_unused_sword_client_7x
[Port dspace-7_x] Remove unused, unmaintained SWORD v1 client code
2025-04-08 06:58:52 -05:00
dependabot[bot]
68cffba5fa Bump the test-tools group with 6 updates
Bumps the test-tools group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.1.118.Final` | `4.1.119.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.1.118.Final` | `4.1.119.Final` |
| [io.netty:netty-transport-native-unix-common](https://github.com/netty/netty) | `4.1.118.Final` | `4.1.119.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.1.118.Final` | `4.1.119.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.1.118.Final` | `4.1.119.Final` |
| [io.netty:netty-codec](https://github.com/netty/netty) | `4.1.118.Final` | `4.1.119.Final` |


Updates `io.netty:netty-buffer` from 4.1.118.Final to 4.1.119.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.118.Final...netty-4.1.119.Final)

Updates `io.netty:netty-transport` from 4.1.118.Final to 4.1.119.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.118.Final...netty-4.1.119.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.1.118.Final to 4.1.119.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.118.Final...netty-4.1.119.Final)

Updates `io.netty:netty-common` from 4.1.118.Final to 4.1.119.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.118.Final...netty-4.1.119.Final)

Updates `io.netty:netty-handler` from 4.1.118.Final to 4.1.119.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.118.Final...netty-4.1.119.Final)

Updates `io.netty:netty-codec` from 4.1.118.Final to 4.1.119.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.118.Final...netty-4.1.119.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-04-07 23:48:45 +00:00
Tim Donohue
bfe7e7871e Remove unused SWORD v1 client code. This is "dead code" which is unmaintained and obsolete 2025-04-07 17:10:43 -05:00
Tim Donohue
a6fcdeab9e Merge pull request #10567 from tdonohue/port_10565_to_7x
[Port dspace-7_x][GitHub Actions] Update Docker scripts to use new Ubuntu ARM64 runner instead of emulation
2025-04-07 12:53:01 -05:00
Tim Donohue
4c73e4b01f Update reusable-docker-build to use Ubuntu ARM64 runner for those images 2025-04-07 11:56:20 -05:00
Tim Donohue
a2a56d416e Merge pull request #10551 from DSpace/backport-9876-to-dspace-7_x
[Port dspace-7_x] Fix DSpace startup failures when ORCID http connections fail
2025-04-02 14:08:35 -05:00
Kim Shepherd
1fe697a19e Fix some ORCID mock / test usage
(cherry picked from commit 038ddeee97)
2025-04-02 18:28:28 +00:00
Kim Shepherd
3fa57d7c0e More robust ORCID accessToken init, REST con. usage
* Ensure that http client / IO exceptions don't cause a
  total DSpace startup failure because of unhandled
  exceptions in Spring service init methods.
* Centralise access token retrieval method in factory utils.
* Check for NULL rest connector since that can now happen
  and handle gracefully, with error logging

(cherry picked from commit b72344ecfb)
2025-04-02 18:28:28 +00:00
dependabot[bot]
d68c5ac8eb Bump joda-time:joda-time from 2.13.1 to 2.14.0
Bumps [joda-time:joda-time](https://github.com/JodaOrg/joda-time) from 2.13.1 to 2.14.0.
- [Release notes](https://github.com/JodaOrg/joda-time/releases)
- [Changelog](https://github.com/JodaOrg/joda-time/blob/main/RELEASE-NOTES.txt)
- [Commits](https://github.com/JodaOrg/joda-time/compare/v2.13.1...v2.14.0)

---
updated-dependencies:
- dependency-name: joda-time:joda-time
  dependency-version: 2.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-03-31 22:52:59 +00:00
DSpace Bot
c797441b86 [Port dspace-7_x] Add null check in SolrServiceFileInfoPlugin for index-discovery (#10517)
* Add null check in SolrServiceFileInfoPlugin for index-discovery

(cherry picked from commit d07f1e0caa)

* Fix starting curly brace.

(cherry picked from commit e11994c0ee)

* Update SolrServiceFileInfoPlugin.java

(cherry picked from commit 18372ae072)

---------

Co-authored-by: jameswsullivan <81947235+jameswsullivan@users.noreply.github.com>
2025-03-24 14:04:03 -05:00
Tim Donohue
56e8322079 Merge pull request #10515 from DSpace/backport-10511-to-dspace-7_x
[Port dspace-7_x] Add bitstream null check to XOAI.java
2025-03-24 10:59:57 -05:00
Tim Donohue
0a3174551f Merge pull request #10513 from DSpace/backport-10509-to-dspace-7_x
[Port dspace-7_x] DiscoverQueryBuilder: add missing whitespace in exception message
2025-03-24 10:58:45 -05:00
jameswsullivan
bdfe2bfe2e Add bitstream null check to XOAI
(cherry picked from commit 54602f47b1)
2025-03-24 14:58:37 +00:00
Sascha Szott
00da667ba5 add missing whitespace
(cherry picked from commit 4ea4958093)
2025-03-24 14:55:00 +00:00
Sascha Szott
fbec7f2e56 add missing whitespace in exception message
(cherry picked from commit 9a904ab4c9)
2025-03-24 14:55:00 +00:00
Zahraa Chreim
238893ce6d Fix invalid cast in DOIOrganiser exception handling 2025-03-11 16:02:03 +02:00
Tim Donohue
4c0bbeffa3 Merge pull request #10474 from DSpace/backport-10460-to-dspace-7_x
[Port dspace-7_x] Refactoring the function to retrieve the number of browse entries (fix errors using Solr 9.x)
2025-03-04 10:11:01 -06:00
Toni Prieto
15dab1e41e Use NestableJsonFacet to process browse entries count response
(cherry picked from commit 7ba09b7a85)
2025-03-04 15:24:29 +00:00
Tim Donohue
1d4117f4ba Merge pull request #9895 from minurmin/DSpace-9665
[Port dspace-7_x] BitstreamRestController etag/content-length calculation fix when coverpages are enabled
2025-02-27 14:25:31 -06:00
Tim Donohue
4972a5d8f9 Merge pull request #10416 from DSpace/dependabot/maven/dspace-7_x/net.minidev-json-smart-2.5.2
Bump net.minidev:json-smart from 2.5.1 to 2.5.2
2025-02-18 12:09:53 -06:00
Tim Donohue
8fd3429c9a Merge pull request #10417 from DSpace/dependabot/maven/dspace-7_x/com.amazonaws-aws-java-sdk-s3-1.12.781
Bump com.amazonaws:aws-java-sdk-s3 from 1.12.780 to 1.12.781
2025-02-18 12:05:10 -06:00
Tim Donohue
f1ddc78729 Merge pull request #10415 from DSpace/dependabot/maven/dspace-7_x/apache-commons-6a14420bb4
Bump commons-beanutils:commons-beanutils from 1.10.0 to 1.10.1 in the apache-commons group
2025-02-18 12:04:01 -06:00
Tim Donohue
0cb3020442 Merge pull request #10414 from DSpace/dependabot/maven/dspace-7_x/build-tools-4f90ff9816
Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.6.6 to 4.9.1.0 in the build-tools group
2025-02-18 12:02:57 -06:00
dependabot[bot]
1d85653ed0 Bump com.amazonaws:aws-java-sdk-s3 from 1.12.780 to 1.12.781
Bumps [com.amazonaws:aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.780 to 1.12.781.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.780...1.12.781)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-17 22:27:07 +00:00
dependabot[bot]
51c766caa3 Bump net.minidev:json-smart from 2.5.1 to 2.5.2
Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/netplex/json-smart-v2/releases)
- [Commits](https://github.com/netplex/json-smart-v2/compare/2.5.1...2.5.2)

---
updated-dependencies:
- dependency-name: net.minidev:json-smart
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-17 22:26:49 +00:00
dependabot[bot]
edbf9ef605 Bump commons-beanutils:commons-beanutils in the apache-commons group
Bumps the apache-commons group with 1 update: commons-beanutils:commons-beanutils.


Updates `commons-beanutils:commons-beanutils` from 1.10.0 to 1.10.1

---
updated-dependencies:
- dependency-name: commons-beanutils:commons-beanutils
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-17 22:25:48 +00:00
dependabot[bot]
b63329b45a Bump com.github.spotbugs:spotbugs-maven-plugin in the build-tools group
Bumps the build-tools group with 1 update: [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin).


Updates `com.github.spotbugs:spotbugs-maven-plugin` from 4.8.6.6 to 4.9.1.0
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.8.6.6...spotbugs-maven-plugin-4.9.1.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-17 22:25:23 +00:00
Tim Donohue
8adbe244bf Merge pull request #10409 from DSpace/backport-10406-to-dspace-7_x
[Port dspace-7_x] Fix #10405 bug in log4j-cli
2025-02-13 12:59:05 -06:00
Martin Walk
268b5fc8b7 Fix #10405 bug in log4j-cli
(cherry picked from commit 4c044adcf3)
2025-02-13 16:40:50 +00:00
Tim Donohue
fedbccae49 Merge pull request #10392 from DSpace/dependabot/maven/dspace-7_x/tika.version-2.9.3
Bump tika.version from 2.9.2 to 2.9.3
2025-02-12 17:11:40 -06:00
Tim Donohue
fcc4dcf5b3 Merge pull request #10174 from atmire/w2p-121973_openaire-compliance-updates-7.x
[Port dspace-7_x] OpenAIRE v4 compliance updates
2025-02-12 12:36:10 -06:00
Paulo Graça
ee762260cf [Port dspace-7_x] Fixing Crossref document type issue with new metadata mapping processor (#9909)
* new metadata mapping processor for crossref document type

* licence and code style fixes

* adjust crossref test to consider mapped dc.type to Article

* correcting english

* remove trailing space
2025-02-12 15:26:27 +03:00
Tim Donohue
63bb639e68 Merge pull request #10346 from DSpace/dependabot/maven/dspace-7_x/io.grpc-grpc-context-1.70.0
Bump io.grpc:grpc-context from 1.69.0 to 1.70.0
2025-02-11 10:52:49 -06:00
Tim Donohue
dfe5628ed9 Merge pull request #10389 from DSpace/dependabot/maven/dspace-7_x/google-apis-4ffec14d6f
Bump the google-apis group across 1 directory with 3 updates
2025-02-11 10:52:11 -06:00
Tim Donohue
fc4a7628ef Merge pull request #10391 from DSpace/dependabot/maven/dspace-7_x/apache-commons-8f079b07b9
Bump commons-logging:commons-logging from 1.3.4 to 1.3.5 in the apache-commons group
2025-02-11 10:42:35 -06:00
Tim Donohue
102c347455 Dependency convergence fix 2025-02-11 10:40:51 -06:00
Tim Donohue
cf7370e2bc Merge pull request #10390 from DSpace/dependabot/maven/dspace-7_x/test-tools-104c99f93b
Bump the test-tools group with 6 updates
2025-02-11 09:51:01 -06:00
Tim Donohue
1c59295693 Merge pull request #10388 from DSpace/dependabot/maven/dspace-7_x/build-tools-2e3c11379d
Bump com.github.spotbugs:spotbugs from 4.9.0 to 4.9.1 in the build-tools group
2025-02-11 09:49:45 -06:00
dependabot[bot]
2c13ee40fe Bump tika.version from 2.9.2 to 2.9.3
Bumps `tika.version` from 2.9.2 to 2.9.3.

Updates `org.apache.tika:tika-core` from 2.9.2 to 2.9.3
- [Changelog](https://github.com/apache/tika/blob/2.9.3/CHANGES.txt)
- [Commits](https://github.com/apache/tika/compare/2.9.2...2.9.3)

Updates `org.apache.tika:tika-parsers-standard-package` from 2.9.2 to 2.9.3

---
updated-dependencies:
- dependency-name: org.apache.tika:tika-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.tika:tika-parsers-standard-package
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-10 22:27:33 +00:00
dependabot[bot]
090001b685 Bump commons-logging:commons-logging in the apache-commons group
Bumps the apache-commons group with 1 update: commons-logging:commons-logging.


Updates `commons-logging:commons-logging` from 1.3.4 to 1.3.5

---
updated-dependencies:
- dependency-name: commons-logging:commons-logging
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-10 22:26:31 +00:00
dependabot[bot]
ba318d9710 Bump the test-tools group with 6 updates
Bumps the test-tools group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.1.117.Final` | `4.1.118.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.1.117.Final` | `4.1.118.Final` |
| [io.netty:netty-transport-native-unix-common](https://github.com/netty/netty) | `4.1.117.Final` | `4.1.118.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.1.117.Final` | `4.1.118.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.1.117.Final` | `4.1.118.Final` |
| [io.netty:netty-codec](https://github.com/netty/netty) | `4.1.117.Final` | `4.1.118.Final` |


Updates `io.netty:netty-buffer` from 4.1.117.Final to 4.1.118.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.117.Final...netty-4.1.118.Final)

Updates `io.netty:netty-transport` from 4.1.117.Final to 4.1.118.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.117.Final...netty-4.1.118.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.1.117.Final to 4.1.118.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.117.Final...netty-4.1.118.Final)

Updates `io.netty:netty-common` from 4.1.117.Final to 4.1.118.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.117.Final...netty-4.1.118.Final)

Updates `io.netty:netty-handler` from 4.1.117.Final to 4.1.118.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.117.Final...netty-4.1.118.Final)

Updates `io.netty:netty-codec` from 4.1.117.Final to 4.1.118.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.117.Final...netty-4.1.118.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-buffer
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-10 22:26:17 +00:00
dependabot[bot]
06a5458205 Bump the google-apis group across 1 directory with 3 updates
Bumps the google-apis group with 3 updates in the / directory: [com.google.http-client:google-http-client](https://github.com/googleapis/google-http-java-client), [com.google.http-client:google-http-client-jackson2](https://github.com/googleapis/google-http-java-client) and [com.google.http-client:google-http-client-gson](https://github.com/googleapis/google-http-java-client).


Updates `com.google.http-client:google-http-client` from 1.45.3 to 1.46.1
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.45.3...v1.46.1)

Updates `com.google.http-client:google-http-client-jackson2` from 1.45.3 to 1.46.1
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.45.3...v1.46.1)

Updates `com.google.http-client:google-http-client-gson` from 1.43.3 to 1.46.1
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/v1.43.3...v1.46.1)

---
updated-dependencies:
- dependency-name: com.google.http-client:google-http-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-jackson2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-gson
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-10 22:25:53 +00:00
dependabot[bot]
8e411ac70c Bump com.github.spotbugs:spotbugs in the build-tools group
Bumps the build-tools group with 1 update: [com.github.spotbugs:spotbugs](https://github.com/spotbugs/spotbugs).


Updates `com.github.spotbugs:spotbugs` from 4.9.0 to 4.9.1
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.9.0...4.9.1)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-10 22:25:47 +00:00
Tim Donohue
ce1dbb6d2c Merge pull request #10372 from DSpace/dependabot/maven/dspace-7_x/joda-time-joda-time-2.13.1
Bump joda-time:joda-time from 2.13.0 to 2.13.1
2025-02-10 14:15:36 -06:00
Tim Donohue
cb4fb777c5 Merge pull request #10347 from DSpace/dependabot/maven/dspace-7_x/dnsjava-dnsjava-3.6.3
Bump dnsjava:dnsjava from 3.6.2 to 3.6.3
2025-02-10 14:11:56 -06:00
Tim Donohue
72cedb7722 Merge pull request #10344 from DSpace/dependabot/maven/dspace-7_x/apache-commons-f9d9c8ba39
Bump the apache-commons group with 2 updates
2025-02-10 14:10:41 -06:00
Tim Donohue
dd6183b9cb Merge pull request #10383 from tdonohue/port_10381_to_7x
[Port dspace-7_x] Remove unused/unnecessary dependencies : `byte-buddy`
2025-02-10 14:03:48 -06:00
Tim Donohue
a2cb8cc838 Remove unused byte-buddy 2025-02-10 11:37:26 -06:00
Tim Donohue
e0aa56ca82 [maven-release-plugin] prepare for next development iteration 2025-02-07 10:57:05 -06:00
Tim Donohue
6181f2723c [maven-release-plugin] prepare release dspace-7.6.3 2025-02-07 10:57:02 -06:00
Tim Donohue
7e4fc1daaf Update LICENSES_THIRD_PARTY for 7.6.3 2025-02-07 10:22:53 -06:00
Tim Donohue
ae0b9a4bdb Merge pull request #10378 from 4Science/task/dspace-7_x/DURACOM-288
[Port dspace-7_x] Provide a setting to use a different REST url during SSR execution
2025-02-07 09:30:59 -06:00
Giuseppe Digilio
7e7a4c9da0 Merge remote-tracking branch 'upstreamdspace/dspace-7_x' into task/dspace-7_x/DURACOM-288
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/AuthorizationRestRepositoryIT.java
2025-02-06 18:08:15 +01:00
Giuseppe Digilio
888edc4597 [DURACOM-288] Fix wrong imports 2025-02-06 18:03:23 +01:00
Giuseppe Digilio
81642ea139 [DURACOM-288] Change logic in order to use dspaceUrl as default fallback 2025-02-06 17:05:56 +01:00
Giuseppe Digilio
e6f565e90f [DURACOM-288] Build endpoint map according to request origin, in order to get internal urls if used 2025-02-06 17:05:38 +01:00
Giuseppe Digilio
648d9f6972 [DURACOM-288] Set dspace.server.ssr.url as dspace.server.url by default 2025-02-06 17:05:18 +01:00
Giuseppe Digilio
c39042095a [DURACOM-288] Code refactoring and test improvements 2025-02-06 17:05:02 +01:00
Giuseppe Digilio
a2e518444c [DURACOM-288] Fix test 2025-02-06 17:04:50 +01:00
Giuseppe Digilio
369bda130a [DURACOM-288] Add dspace.server.ssr.uri in the local.cfg.EXAMPLE 2025-02-06 17:04:39 +01:00
Giuseppe Digilio
ea15a3b965 [DURACOM-288] Add check to allow base object uri containing dspace.server.ssr.uri 2025-02-06 17:04:28 +01:00
Giuseppe Digilio
94ad5744e2 [DURACOM-288] Add DSpace property to specify addition rest url 2025-02-06 17:04:18 +01:00
dependabot[bot]
723ad07ae9 Bump joda-time:joda-time from 2.13.0 to 2.13.1
Bumps [joda-time:joda-time](https://github.com/JodaOrg/joda-time) from 2.13.0 to 2.13.1.
- [Release notes](https://github.com/JodaOrg/joda-time/releases)
- [Changelog](https://github.com/JodaOrg/joda-time/blob/main/RELEASE-NOTES.txt)
- [Commits](https://github.com/JodaOrg/joda-time/compare/v2.13.0...v2.13.1)

---
updated-dependencies:
- dependency-name: joda-time:joda-time
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-03 23:20:40 +00:00
dependabot[bot]
63fbffc963 Bump the apache-commons group with 2 updates
Bumps the apache-commons group with 2 updates: [commons-codec:commons-codec](https://github.com/apache/commons-codec) and org.apache.commons:commons-pool2.


Updates `commons-codec:commons-codec` from 1.17.2 to 1.18.0
- [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-codec/compare/rel/commons-codec-1.17.2...rel/commons-codec-1.18.0)

Updates `org.apache.commons:commons-pool2` from 2.12.0 to 2.12.1

---
updated-dependencies:
- dependency-name: commons-codec:commons-codec
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-pool2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-02-03 23:19:27 +00:00
Tim Donohue
ec32897f50 Merge pull request #10358 from DSpace/backport-10293-to-dspace-7_x
[Port dspace-7_x] Fix ClamAV curation task crashing on exceptions instead of ending gracefully
2025-02-03 09:54:43 -06:00
Jens Vannerum
094af861b3 124579: catch any exceptions during process and end task gracefully
(cherry picked from commit 11a1c9ab06)
2025-02-01 09:53:29 +00:00
Jens Vannerum
6b4c7a773d 124579: If no ORIGINAL bundle exists, end the process gracefully instead of throwing NPE
(cherry picked from commit 046c1b5d05)
2025-02-01 09:53:29 +00:00
Marie Verdonck
bf520782d8 Merge branch 'cli-speed-improvements-periodically-uncache-entities-when-processing-many_7.6' into cli-speed-improvements-periodically-uncache-entities-when-processing-many_7-x
# Conflicts:
#	dspace-api/src/main/java/org/dspace/core/Context.java
#	dspace-api/src/main/java/org/dspace/core/DBConnection.java
#	dspace-api/src/main/java/org/dspace/core/HibernateDBConnection.java
2025-01-29 22:11:03 +01:00
Tim Donohue
6bf4d142a4 Merge pull request #10111 from atmire/issue-10110_w2p-109807_arxiv-author-mapping-fix-7_x
[Port dspace-7_x] ArXiv Live Import - Author mapping fix
2025-01-29 12:08:08 -06:00
Marie Verdonck
e8a54e698c cli speed improvement: periodically uncache entities when processing many 2025-01-29 12:42:25 +01:00
dependabot[bot]
3885966b4d Bump dnsjava:dnsjava from 3.6.2 to 3.6.3
Bumps [dnsjava:dnsjava](https://github.com/dnsjava/dnsjava) from 3.6.2 to 3.6.3.
- [Release notes](https://github.com/dnsjava/dnsjava/releases)
- [Changelog](https://github.com/dnsjava/dnsjava/blob/master/Changelog)
- [Commits](https://github.com/dnsjava/dnsjava/compare/v3.6.2...v3.6.3)

---
updated-dependencies:
- dependency-name: dnsjava:dnsjava
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-27 23:07:21 +00:00
dependabot[bot]
859dd4c69d Bump io.grpc:grpc-context from 1.69.0 to 1.70.0
Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.69.0 to 1.70.0.
- [Release notes](https://github.com/grpc/grpc-java/releases)
- [Commits](https://github.com/grpc/grpc-java/compare/v1.69.0...v1.70.0)

---
updated-dependencies:
- dependency-name: io.grpc:grpc-context
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-27 23:07:18 +00:00
Tim Donohue
c27084724b Merge pull request #10336 from DSpace/backport-10331-to-dspace-7_x
[Port dspace-7_x] Remove unused configuration `csvexport.dir`
2025-01-27 11:15:20 -06:00
Tim Donohue
8cb693ab62 Merge pull request #10334 from DSpace/backport-9835-to-dspace-7_x
[Port dspace-7_x] On error in DOI Organiser bulk operations, continue instead of panic-stopping.
2025-01-27 10:27:19 -06:00
Tim Donohue
338e17d197 Remove unused configuration
(cherry picked from commit 845c706cac)
2025-01-27 16:03:36 +00:00
Mark H. Wood
6d187a08fd Document and handle the actual exceptions returned by register.
(cherry picked from commit 2edea69ca3)
2025-01-27 15:44:58 +00:00
Mark H. Wood
cc3841d212 Reorganize some documentation.
(cherry picked from commit 77425163f2)
2025-01-27 15:44:57 +00:00
Mark H. Wood
f7902bce00 On error in bulk operations, continue instead of panic-stopping.
(cherry picked from commit bfeba1aa7a)
2025-01-27 15:44:57 +00:00
Tim Donohue
a54d61923a Merge pull request #10283 from DSpace/dependabot/maven/dspace-7_x/net.cnri-cnri-servlet-container-3.1.0
Bump net.cnri:cnri-servlet-container from 3.0.0 to 3.1.0
2025-01-24 17:01:08 -06:00
Tim Donohue
125716efeb Merge pull request #10306 from DSpace/dependabot/maven/dspace-7_x/net.minidev-json-smart-2.5.1
Bump net.minidev:json-smart from 2.5.0 to 2.5.1
2025-01-24 16:34:55 -06:00
Tim Donohue
1cc98e6c2d Fix missing dependency errors for javax.el 2025-01-24 16:31:05 -06:00
Tim Donohue
5408f317d7 Merge pull request #10226 from DSpace/dependabot/maven/dspace-7_x/google-apis-05b77a15af
Bump the google-apis group with 4 updates
2025-01-24 15:57:09 -06:00
Tim Donohue
5169a55437 Resolve dependency convergence issue 2025-01-24 15:56:12 -06:00
Tim Donohue
96451f7391 Dependency convergence fixes 2025-01-24 15:06:43 -06:00
Tim Donohue
c7883e0f0a Merge pull request #10302 from DSpace/dependabot/maven/dspace-7_x/org.atteo-evo-inflector-1.3
Bump org.atteo:evo-inflector from 1.2.1 to 1.3
2025-01-24 14:42:36 -06:00
Tim Donohue
6d466ccde9 Merge pull request #10328 from DSpace/dependabot/maven/dspace-7_x/de.digitalcollections.iiif-iiif-apis-0.3.11
Bump de.digitalcollections.iiif:iiif-apis from 0.3.10 to 0.3.11
2025-01-24 11:40:33 -06:00
Tim Donohue
140588de8b Merge pull request #10330 from tdonohue/port_9950_to_7x
[Port dspace-7_x] added expunge request param and enabled workflowitem delete based on it
2025-01-24 10:47:25 -06:00
Oscar Chacón
10b3f06480 added expunge request param and enabled workflowitem delete based on it (#9950)
* added expunge request param and enabled workflowitem delete based on it

* enabled expunge param only in workflowitem delete endpoint and IT

* Remove invalid param from JavaDocs

---------

Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org>
2025-01-24 10:11:23 -06:00
Tim Donohue
6486f61010 Merge pull request #10320 from tdonohue/port_10158_to_7x
[Port dspace-7_x] Processes should only be failed after a Tomcat restart
2025-01-24 08:53:07 -06:00
Tim Donohue
6d9278e6f0 Merge pull request #10325 from DSpace/dependabot/maven/dspace-7_x/com.ibm.icu-icu4j-62.2
Bump com.ibm.icu:icu4j from 62.1 to 62.2
2025-01-24 07:00:45 -06:00
Tim Donohue
f7f2d23399 Merge pull request #10327 from DSpace/dependabot/maven/dspace-7_x/com.opencsv-opencsv-5.10
Bump com.opencsv:opencsv from 5.9 to 5.10
2025-01-24 06:58:52 -06:00
dependabot[bot]
25be075b3c Bump de.digitalcollections.iiif:iiif-apis from 0.3.10 to 0.3.11
Bumps [de.digitalcollections.iiif:iiif-apis](https://github.com/dbmdz/iiif-apis) from 0.3.10 to 0.3.11.
- [Release notes](https://github.com/dbmdz/iiif-apis/releases)
- [Commits](https://github.com/dbmdz/iiif-apis/compare/0.3.10...0.3.11)

---
updated-dependencies:
- dependency-name: de.digitalcollections.iiif:iiif-apis
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-24 00:22:28 +00:00
dependabot[bot]
63081494d8 Bump com.opencsv:opencsv from 5.9 to 5.10
Bumps com.opencsv:opencsv from 5.9 to 5.10.

---
updated-dependencies:
- dependency-name: com.opencsv:opencsv
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-24 00:22:13 +00:00
dependabot[bot]
77efa5ce88 Bump com.ibm.icu:icu4j from 62.1 to 62.2
Bumps [com.ibm.icu:icu4j](https://github.com/unicode-org/icu) from 62.1 to 62.2.
- [Release notes](https://github.com/unicode-org/icu/releases)
- [Commits](https://github.com/unicode-org/icu/commits)

---
updated-dependencies:
- dependency-name: com.ibm.icu:icu4j
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-24 00:21:41 +00:00
dependabot[bot]
62959008f8 Bump the google-apis group with 4 updates
Bumps the google-apis group with 4 updates: [com.google.api-client:google-api-client](https://github.com/googleapis/google-api-java-client), [com.google.http-client:google-http-client](https://github.com/googleapis/google-http-java-client), [com.google.http-client:google-http-client-jackson2](https://github.com/googleapis/google-http-java-client) and [com.google.oauth-client:google-oauth-client](https://github.com/googleapis/google-oauth-java-client).


Updates `com.google.api-client:google-api-client` from 1.23.0 to 1.35.2
- [Release notes](https://github.com/googleapis/google-api-java-client/releases)
- [Changelog](https://github.com/googleapis/google-api-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-api-java-client/compare/1.23.0...v1.35.2)

Updates `com.google.http-client:google-http-client` from 1.23.0 to 1.45.3
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/1.23.0...v1.45.3)

Updates `com.google.http-client:google-http-client-jackson2` from 1.23.0 to 1.45.3
- [Release notes](https://github.com/googleapis/google-http-java-client/releases)
- [Changelog](https://github.com/googleapis/google-http-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-http-java-client/compare/1.23.0...v1.45.3)

Updates `com.google.oauth-client:google-oauth-client` from 1.33.3 to 1.37.0
- [Release notes](https://github.com/googleapis/google-oauth-java-client/releases)
- [Changelog](https://github.com/googleapis/google-oauth-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-oauth-java-client/compare/v1.33.3...v1.37.0)

---
updated-dependencies:
- dependency-name: com.google.api-client:google-api-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.http-client:google-http-client-jackson2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
- dependency-name: com.google.oauth-client:google-oauth-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: google-apis
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-24 00:21:38 +00:00
Tim Donohue
bcd837fab6 Merge pull request #10301 from DSpace/dependabot/maven/dspace-7_x/com.amazonaws-aws-java-sdk-s3-1.12.780
Bump com.amazonaws:aws-java-sdk-s3 from 1.12.261 to 1.12.780
2025-01-23 17:06:00 -06:00
Tim Donohue
06c02192ea Merge pull request #10310 from DSpace/dependabot/maven/dspace-7_x/org.postgresql-postgresql-42.7.5
Bump org.postgresql:postgresql from 42.7.3 to 42.7.5
2025-01-23 17:01:19 -06:00
Tim Donohue
951637f610 Merge pull request #10311 from DSpace/dependabot/maven/dspace-7_x/org.jboss.logging-jboss-logging-3.6.1.Final
Bump org.jboss.logging:jboss-logging from 3.4.3.Final to 3.6.1.Final
2025-01-23 16:55:01 -06:00
Tim Donohue
a7fb760fee Merge pull request #10314 from DSpace/dependabot/maven/dspace-7_x/org.apache.james-apache-mime4j-core-0.8.12
Bump org.apache.james:apache-mime4j-core from 0.8.10 to 0.8.12
2025-01-23 16:52:12 -06:00
Nona Luypaert
0d069354f7 122350: Move failRunningProcesses during tomcat startup to RestRepository 2025-01-23 16:32:55 -06:00
Tim Donohue
ae3cc23025 Merge pull request #10281 from DSpace/dependabot/maven/dspace-7_x/joda-time-joda-time-2.13.0
Bump joda-time:joda-time from 2.12.5 to 2.13.0
2025-01-23 14:12:42 -06:00
dependabot[bot]
75d747e40a Bump org.apache.james:apache-mime4j-core from 0.8.10 to 0.8.12
Bumps org.apache.james:apache-mime4j-core from 0.8.10 to 0.8.12.

---
updated-dependencies:
- dependency-name: org.apache.james:apache-mime4j-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 18:23:46 +00:00
dependabot[bot]
daa29e582a Bump org.jboss.logging:jboss-logging from 3.4.3.Final to 3.6.1.Final
Bumps [org.jboss.logging:jboss-logging](https://github.com/jboss-logging/jboss-logging) from 3.4.3.Final to 3.6.1.Final.
- [Release notes](https://github.com/jboss-logging/jboss-logging/releases)
- [Commits](https://github.com/jboss-logging/jboss-logging/compare/3.4.3.Final...3.6.1.Final)

---
updated-dependencies:
- dependency-name: org.jboss.logging:jboss-logging
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 18:23:43 +00:00
dependabot[bot]
0f3fc0eccb Bump org.postgresql:postgresql from 42.7.3 to 42.7.5
Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.7.3 to 42.7.5.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.7.3...REL42.7.5)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 18:23:37 +00:00
dependabot[bot]
1b850aaf0b Bump net.minidev:json-smart from 2.5.0 to 2.5.1
Bumps [net.minidev:json-smart](https://github.com/netplex/json-smart-v2) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/netplex/json-smart-v2/releases)
- [Commits](https://github.com/netplex/json-smart-v2/compare/2.5.0...2.5.1)

---
updated-dependencies:
- dependency-name: net.minidev:json-smart
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 18:23:27 +00:00
dependabot[bot]
3767093c15 Bump org.atteo:evo-inflector from 1.2.1 to 1.3
Bumps [org.atteo:evo-inflector](https://github.com/atteo/evo-inflector) from 1.2.1 to 1.3.
- [Commits](https://github.com/atteo/evo-inflector/compare/1.2.1...1.3)

---
updated-dependencies:
- dependency-name: org.atteo:evo-inflector
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 18:23:11 +00:00
dependabot[bot]
f451307e6f Bump com.amazonaws:aws-java-sdk-s3 from 1.12.261 to 1.12.780
Bumps [com.amazonaws:aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.261 to 1.12.780.
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.261...1.12.780)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 18:23:01 +00:00
dependabot[bot]
0a55995b7c Remove unused joad-time dependency
Bumps [joda-time:joda-time](https://github.com/JodaOrg/joda-time) from 2.12.5 to 2.13.0.
- [Release notes](https://github.com/JodaOrg/joda-time/releases)
- [Changelog](https://github.com/JodaOrg/joda-time/blob/main/RELEASE-NOTES.txt)
- [Commits](https://github.com/JodaOrg/joda-time/compare/v2.12.5...v2.13.0)

---
updated-dependencies:
- dependency-name: joda-time:joda-time
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-23 17:08:10 +00:00
Tim Donohue
1a9ae38675 Merge pull request #10284 from DSpace/dependabot/maven/dspace-7_x/org.apache.ant-ant-1.10.15
Bump org.apache.ant:ant from 1.10.14 to 1.10.15
2025-01-22 16:50:29 -06:00
Tim Donohue
6e4365757e Merge pull request #10285 from DSpace/dependabot/maven/dspace-7_x/dnsjava-dnsjava-3.6.2
Bump dnsjava:dnsjava from 3.6.0 to 3.6.2
2025-01-22 16:50:03 -06:00
Tim Donohue
e6dcbb8412 Merge pull request #10282 from DSpace/dependabot/maven/dspace-7_x/org.apache.velocity-velocity-engine-core-2.4.1
Bump org.apache.velocity:velocity-engine-core from 2.3 to 2.4.1
2025-01-22 16:48:28 -06:00
Tim Donohue
1dbd23e247 Merge pull request #10277 from DSpace/dependabot/maven/dspace-7_x/net.bytebuddy-byte-buddy-1.16.1
Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.16.1
2025-01-22 16:47:15 -06:00
Tim Donohue
f14b8bfe6c Merge pull request #10275 from DSpace/dependabot/maven/dspace-7_x/bouncycastle.version-1.80
Bump bouncycastle.version from 1.78.1 to 1.80
2025-01-22 16:46:11 -06:00
Tim Donohue
18cf98be4f Merge pull request #10278 from DSpace/dependabot/maven/dspace-7_x/pdfbox-version-2.0.33
Bump pdfbox-version from 2.0.31 to 2.0.33
2025-01-22 15:09:29 -06:00
Tim Donohue
8bcd3980d8 Merge pull request #9722 from 4Science/task/dspace-7_x/CST-14901
[Port dspace-7_x] Handles versioning for ORCID publications.
2025-01-22 14:51:02 -06:00
Tim Donohue
f94bbfca45 Merge pull request #10295 from DSpace/backport-10209-to-dspace-7_x
[Port dspace-7_x] Avoid IllegalArgumentException thrown during creating a new version in special DSpace settings
2025-01-22 14:22:56 -06:00
Tim Donohue
1f53491140 Merge pull request #10254 from DSpace/dependabot/maven/dspace-7_x/org.scala-lang-scala-library-2.13.16
Bump org.scala-lang:scala-library from 2.13.11 to 2.13.16
2025-01-22 10:38:12 -06:00
Eike Martin Löhden
da3584759b Add check to avoid adding empty array of values to an item.
(cherry picked from commit 6e0124fcbb)
2025-01-22 16:19:54 +00:00
dependabot[bot]
cd2fbbf51b Bump dnsjava:dnsjava from 3.6.0 to 3.6.2
Bumps [dnsjava:dnsjava](https://github.com/dnsjava/dnsjava) from 3.6.0 to 3.6.2.
- [Release notes](https://github.com/dnsjava/dnsjava/releases)
- [Changelog](https://github.com/dnsjava/dnsjava/blob/master/Changelog)
- [Commits](https://github.com/dnsjava/dnsjava/compare/v3.6.0...v3.6.2)

---
updated-dependencies:
- dependency-name: dnsjava:dnsjava
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-21 23:28:54 +00:00
dependabot[bot]
9d46a45191 Bump org.apache.ant:ant from 1.10.14 to 1.10.15
Bumps org.apache.ant:ant from 1.10.14 to 1.10.15.

---
updated-dependencies:
- dependency-name: org.apache.ant:ant
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-21 23:28:48 +00:00
dependabot[bot]
9bca0c928b Bump net.cnri:cnri-servlet-container from 3.0.0 to 3.1.0
Bumps [net.cnri:cnri-servlet-container](https://gitlab.com/cnri/cnri-servlet-container) from 3.0.0 to 3.1.0.
- [Commits](https://gitlab.com/cnri/cnri-servlet-container/compare/v3.0.0...v3.1.0)

---
updated-dependencies:
- dependency-name: net.cnri:cnri-servlet-container
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-21 23:28:37 +00:00
dependabot[bot]
e3abd1c129 Bump org.apache.velocity:velocity-engine-core from 2.3 to 2.4.1
Bumps org.apache.velocity:velocity-engine-core from 2.3 to 2.4.1.

---
updated-dependencies:
- dependency-name: org.apache.velocity:velocity-engine-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-21 23:28:34 +00:00
dependabot[bot]
39e2ef2b30 Bump pdfbox-version from 2.0.31 to 2.0.33
Bumps `pdfbox-version` from 2.0.31 to 2.0.33.

Updates `org.apache.pdfbox:pdfbox` from 2.0.31 to 2.0.33

Updates `org.apache.pdfbox:fontbox` from 2.0.31 to 2.0.33

---
updated-dependencies:
- dependency-name: org.apache.pdfbox:pdfbox
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.pdfbox:fontbox
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-21 23:28:19 +00:00
dependabot[bot]
9705c30f8a Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.16.1
Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.11.13 to 1.16.1.
- [Release notes](https://github.com/raphw/byte-buddy/releases)
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md)
- [Commits](https://github.com/raphw/byte-buddy/compare/byte-buddy-1.11.13...byte-buddy-1.16.1)

---
updated-dependencies:
- dependency-name: net.bytebuddy:byte-buddy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-21 23:28:11 +00:00
dependabot[bot]
7d4a5fc311 Bump bouncycastle.version from 1.78.1 to 1.80
Bumps `bouncycastle.version` from 1.78.1 to 1.80.

Updates `org.bouncycastle:bcpkix-jdk18on` from 1.78.1 to 1.80
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

Updates `org.bouncycastle:bcprov-jdk18on` from 1.78.1 to 1.80
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

Updates `org.bouncycastle:bcutil-jdk18on` from 1.78.1 to 1.80
- [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html)
- [Commits](https://github.com/bcgit/bc-java/commits)

---
updated-dependencies:
- dependency-name: org.bouncycastle:bcpkix-jdk18on
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.bouncycastle:bcprov-jdk18on
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.bouncycastle:bcutil-jdk18on
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-21 23:28:06 +00:00
Tim Donohue
4ca723573b Merge pull request #10256 from DSpace/dependabot/maven/dspace-7_x/log4j.version-2.24.3
Bump log4j.version from 2.23.1 to 2.24.3
2025-01-21 16:48:02 -06:00
Tim Donohue
a40620514a Merge pull request #10255 from DSpace/dependabot/maven/dspace-7_x/org.apache.bcel-bcel-6.10.0
Bump org.apache.bcel:bcel from 6.7.0 to 6.10.0
2025-01-21 16:42:50 -06:00
Tim Donohue
6bd6686e57 Merge pull request #10269 from DSpace/dependabot/maven/dspace-7_x/io.swagger-swagger-core-1.6.15
Remove unused swagger:swagger-core
2025-01-21 15:54:53 -06:00
Tim Donohue
b3e1139006 Remove swagger-core as it is unused 2025-01-21 13:41:10 -06:00
Tim Donohue
1c82598c3f Merge pull request #10268 from DSpace/dependabot/maven/dspace-7_x/solr.client.version-8.11.4
Bump solr.client.version from 8.11.3 to 8.11.4
2025-01-21 13:25:48 -06:00
Tim Donohue
3d0006ee73 Merge pull request #10264 from DSpace/dependabot/maven/dspace-7_x/build-tools-907e20f2d5
Bump com.github.spotbugs:spotbugs from 4.8.6 to 4.9.0 in the build-tools group across 1 directory
2025-01-21 13:10:09 -06:00
Tim Donohue
86dd22acab Merge pull request #10220 from DSpace/dependabot/maven/dspace-7_x/test-tools-6cdf6921de
Bump the test-tools group with 8 updates
2025-01-21 13:09:19 -06:00
Tim Donohue
5ff9702254 Merge pull request #10253 from DSpace/dependabot/maven/dspace-7_x/spring-e4edb82a34
Bump the spring group with 4 updates
2025-01-21 13:06:38 -06:00
dependabot[bot]
8076745a09 Bump io.swagger:swagger-core from 1.6.2 to 1.6.15
Bumps [io.swagger:swagger-core](https://github.com/swagger-api/swagger-core) from 1.6.2 to 1.6.15.
- [Release notes](https://github.com/swagger-api/swagger-core/releases)
- [Commits](https://github.com/swagger-api/swagger-core/compare/v1.6.2...v1.6.15)

---
updated-dependencies:
- dependency-name: io.swagger:swagger-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-20 22:43:53 +00:00
dependabot[bot]
bf1aa3da7a Bump solr.client.version from 8.11.3 to 8.11.4
Bumps `solr.client.version` from 8.11.3 to 8.11.4.

Updates `org.apache.solr:solr-solrj` from 8.11.3 to 8.11.4

Updates `org.apache.lucene:lucene-core` from 8.11.3 to 8.11.4

Updates `org.apache.lucene:lucene-analyzers-icu` from 8.11.3 to 8.11.4

Updates `org.apache.lucene:lucene-analyzers-smartcn` from 8.11.3 to 8.11.4

Updates `org.apache.lucene:lucene-analyzers-stempel` from 8.11.3 to 8.11.4

Updates `org.apache.solr:solr-core` from 8.11.3 to 8.11.4

---
updated-dependencies:
- dependency-name: org.apache.solr:solr-solrj
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.lucene:lucene-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.lucene:lucene-analyzers-icu
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.lucene:lucene-analyzers-smartcn
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.lucene:lucene-analyzers-stempel
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.solr:solr-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-20 22:43:50 +00:00
dependabot[bot]
9dcc4e6f7c Bump the spring group with 4 updates
Bumps the spring group with 4 updates: [org.springframework.security:spring-security-test](https://github.com/spring-projects/spring-security), [org.springframework.security:spring-security-core](https://github.com/spring-projects/spring-security), [org.springframework.security:spring-security-web](https://github.com/spring-projects/spring-security) and [org.springframework.security:spring-security-config](https://github.com/spring-projects/spring-security).


Updates `org.springframework.security:spring-security-test` from 5.7.12 to 5.7.14
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.7.12...5.7.14)

Updates `org.springframework.security:spring-security-core` from 5.7.12 to 5.7.14
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.7.12...5.7.14)

Updates `org.springframework.security:spring-security-web` from 5.7.12 to 5.7.14
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.7.12...5.7.14)

Updates `org.springframework.security:spring-security-config` from 5.7.12 to 5.7.14
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.7.12...5.7.14)

Updates `org.springframework.security:spring-security-core` from 5.7.12 to 5.7.14
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.7.12...5.7.14)

Updates `org.springframework.security:spring-security-web` from 5.7.12 to 5.7.14
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.7.12...5.7.14)

Updates `org.springframework.security:spring-security-config` from 5.7.12 to 5.7.14
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.7.12...5.7.14)

---
updated-dependencies:
- dependency-name: org.springframework.security:spring-security-test
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: spring
- dependency-name: org.springframework.security:spring-security-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: spring
- dependency-name: org.springframework.security:spring-security-web
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: spring
- dependency-name: org.springframework.security:spring-security-config
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: spring
- dependency-name: org.springframework.security:spring-security-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: spring
- dependency-name: org.springframework.security:spring-security-web
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: spring
- dependency-name: org.springframework.security:spring-security-config
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: spring
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-20 22:43:38 +00:00
dependabot[bot]
75e291d867 Bump the test-tools group with 8 updates
Bumps the test-tools group with 8 updates:

| Package | From | To |
| --- | --- | --- |
| [com.h2database:h2](https://github.com/h2database/h2database) | `2.2.224` | `2.3.232` |
| [org.mock-server:mockserver-junit-rule](https://github.com/jamesdbloom/mockservice) | `5.11.2` | `5.15.0` |
| [io.netty:netty-buffer](https://github.com/netty/netty) | `4.1.106.Final` | `4.1.117.Final` |
| [io.netty:netty-transport](https://github.com/netty/netty) | `4.1.106.Final` | `4.1.117.Final` |
| [io.netty:netty-transport-native-unix-common](https://github.com/netty/netty) | `4.1.106.Final` | `4.1.117.Final` |
| [io.netty:netty-common](https://github.com/netty/netty) | `4.1.106.Final` | `4.1.117.Final` |
| [io.netty:netty-handler](https://github.com/netty/netty) | `4.1.106.Final` | `4.1.117.Final` |
| [io.netty:netty-codec](https://github.com/netty/netty) | `4.1.106.Final` | `4.1.117.Final` |


Updates `com.h2database:h2` from 2.2.224 to 2.3.232
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](https://github.com/h2database/h2database/compare/version-2.2.224...version-2.3.232)

Updates `org.mock-server:mockserver-junit-rule` from 5.11.2 to 5.15.0
- [Changelog](https://github.com/mock-server/mockserver/blob/master/changelog.md)
- [Commits](https://github.com/jamesdbloom/mockservice/compare/mockserver-5.11.2...mockserver-5.15.0)

Updates `io.netty:netty-buffer` from 4.1.106.Final to 4.1.117.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.106.Final...netty-4.1.117.Final)

Updates `io.netty:netty-transport` from 4.1.106.Final to 4.1.117.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.106.Final...netty-4.1.117.Final)

Updates `io.netty:netty-transport-native-unix-common` from 4.1.106.Final to 4.1.117.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.106.Final...netty-4.1.117.Final)

Updates `io.netty:netty-common` from 4.1.106.Final to 4.1.117.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.106.Final...netty-4.1.117.Final)

Updates `io.netty:netty-handler` from 4.1.106.Final to 4.1.117.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.106.Final...netty-4.1.117.Final)

Updates `io.netty:netty-codec` from 4.1.106.Final to 4.1.117.Final
- [Commits](https://github.com/netty/netty/compare/netty-4.1.106.Final...netty-4.1.117.Final)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: test-tools
- dependency-name: org.mock-server:mockserver-junit-rule
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: test-tools
- dependency-name: io.netty:netty-buffer
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-transport-native-unix-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
- dependency-name: io.netty:netty-codec
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-20 22:43:27 +00:00
Vincenzo Mecca
6c99c25d34 [CST-14901][DSC-1357][#8662] Adds IT for isLatestVersion 2025-01-20 13:30:26 +01:00
dependabot[bot]
6b2e4c185e Bump com.github.spotbugs:spotbugs
Bumps the build-tools group with 1 update in the / directory: [com.github.spotbugs:spotbugs](https://github.com/spotbugs/spotbugs).


Updates `com.github.spotbugs:spotbugs` from 4.8.6 to 4.9.0
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.8.6...4.9.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-18 01:09:25 +00:00
Tim Donohue
100470d4aa Merge pull request #10218 from DSpace/dependabot/maven/dspace-7_x/build-tools-cee8dec2eb
Bump the build-tools group with 21 updates
2025-01-17 17:01:41 -06:00
Tim Donohue
d3014fde19 Merge pull request #10230 from DSpace/dependabot/maven/dspace-7_x/jersey.version-2.46
Bump jersey.version from 2.39.1 to 2.46
2025-01-17 16:29:15 -06:00
Tim Donohue
82a610c71d Merge pull request #10229 from DSpace/dependabot/maven/dspace-7_x/com.google.guava-guava-32.1.3-jre
Bump com.google.guava:guava from 32.0.0-jre to 32.1.3-jre
2025-01-17 16:05:49 -06:00
dependabot[bot]
80e39f7669 Bump log4j.version from 2.23.1 to 2.24.3
Bumps `log4j.version` from 2.23.1 to 2.24.3.

Updates `org.apache.logging.log4j:log4j-api` from 2.23.1 to 2.24.3

Updates `org.apache.logging.log4j:log4j-core` from 2.23.1 to 2.24.3

Updates `org.apache.logging.log4j:log4j-1.2-api` from 2.23.1 to 2.24.3

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.logging.log4j:log4j-1.2-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-17 21:13:06 +00:00
dependabot[bot]
bd16f7a982 Bump org.apache.bcel:bcel from 6.7.0 to 6.10.0
Bumps [org.apache.bcel:bcel](https://github.com/apache/commons-bcel) from 6.7.0 to 6.10.0.
- [Changelog](https://github.com/apache/commons-bcel/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-bcel/compare/rel/commons-bcel-6.7.0...rel/commons-bcel-6.10.0)

---
updated-dependencies:
- dependency-name: org.apache.bcel:bcel
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-17 21:13:00 +00:00
dependabot[bot]
2b5db943b2 Bump org.scala-lang:scala-library from 2.13.11 to 2.13.16
Bumps [org.scala-lang:scala-library](https://github.com/scala/scala) from 2.13.11 to 2.13.16.
- [Release notes](https://github.com/scala/scala/releases)
- [Commits](https://github.com/scala/scala/compare/v2.13.11...v2.13.16)

---
updated-dependencies:
- dependency-name: org.scala-lang:scala-library
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-17 21:12:56 +00:00
Tim Donohue
4c46bc33be Remove unused dependency 2025-01-17 15:07:10 -06:00
Tim Donohue
c657f7770f Sync a few dependency exclusions from dspace-8_x to dspace-7_x to fix convergence issues 2025-01-17 14:12:38 -06:00
Tim Donohue
6b8a17c3e2 Revert to Errorprone 2.31.0, as that's the last version that supports Java 11 2025-01-17 12:45:52 -06:00
Mark H. Wood
95d7a013f9 Fix ErrorProne errors in tests.
Also fix some of the hundreds of warnings.  This uncovered still more
warnings that hadn't been previously reported, probably because there are
simply too many.
2025-01-17 12:26:15 -06:00
Mark H. Wood
b4dce26749 Fix new ErrorProne errors from new EP version, and a few ancient warnings. 2025-01-17 12:26:15 -06:00
Yana De Pauw
507aade92c Merge remote-tracking branch 'upstream/dspace-7_x' into w2p-124362_VersionedHandleIdentifierProviderWithCanonicalHandles-and-com-col-handles 2025-01-17 15:58:07 +01:00
Yana De Pauw
997945d85d 124362: Restore default config and add tests 2025-01-17 13:37:35 +01:00
Tim Donohue
84ea8af092 Merge pull request #10228 from DSpace/dependabot/maven/dspace-7_x/webjars-694cad7f5e
Bump org.webjars.npm:json-editor__json-editor from 2.6.1 to 2.15.1 in the webjars group
2025-01-16 17:10:40 -06:00
Tim Donohue
1581c737e2 Update jsoneditor.js reference in Hal Browser 2025-01-16 16:43:47 -06:00
Tim Donohue
f04e01eacb Merge pull request #10231 from DSpace/dependabot/maven/dspace-7_x/jetty.version-9.4.57.v20241219
Bump jetty.version from 9.4.54.v20240208 to 9.4.57.v20241219
2025-01-16 16:33:50 -06:00
Tim Donohue
709095a91a Merge pull request #10224 from DSpace/dependabot/maven/dspace-7_x/fasterxml-6e3d9a09b6
Bump the fasterxml group with 4 updates
2025-01-16 16:25:13 -06:00
Tim Donohue
69ca399967 Merge pull request #10222 from DSpace/dependabot/maven/dspace-7_x/apache-commons-25c65aad98
Bump the apache-commons group with 11 updates
2025-01-16 16:23:25 -06:00
Yana De Pauw
745e9c468a 124362: Fix issue with the VersionedHandleIdentifierProviderWithCanonicalHandles and creating communities / collections 2025-01-16 12:01:13 +01:00
Tim Donohue
f7ee509423 Fix duplicate code warning from errorprone. This "else if" clause is the same as the "else" and can be removed 2025-01-15 17:01:07 -06:00
Tim Donohue
5d7b42603d Add newly required "should-stop" flag to errorprone config. See https://errorprone.info/docs/installation 2025-01-15 17:00:57 -06:00
Tim Donohue
eee743a72d Minor checkstyle fixes after bump to 8.45.1. All are indentation / spacing fixes which are more strict now. 2025-01-15 17:00:43 -06:00
Tim Donohue
a01983c230 Fix checkstyle.xml syntax for bump to 8.45.1 2025-01-15 16:59:31 -06:00
dependabot[bot]
9d17009cf3 Bump jetty.version from 9.4.54.v20240208 to 9.4.57.v20241219
Bumps `jetty.version` from 9.4.54.v20240208 to 9.4.57.v20241219.

Updates `org.eclipse.jetty:jetty-server` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-alpn-java-server` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-deploy` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-http` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-io` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-servlet` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-servlets` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-util` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-webapp` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty:jetty-xml` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty.http2:http2-common` from 9.4.54.v20240208 to 9.4.57.v20241219

Updates `org.eclipse.jetty.http2:http2-server` from 9.4.54.v20240208 to 9.4.57.v20241219

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-server
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-alpn-java-server
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-deploy
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-http
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-io
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-servlet
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-servlets
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-util
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-webapp
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-xml
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.http2:http2-common
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.http2:http2-server
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 21:04:17 +00:00
dependabot[bot]
d9945b27b9 Bump jersey.version from 2.39.1 to 2.46
Bumps `jersey.version` from 2.39.1 to 2.46.

Updates `org.glassfish.jersey.core:jersey-client` from 2.39.1 to 2.46

Updates `org.glassfish.jersey.inject:jersey-hk2` from 2.39.1 to 2.46

Updates `org.glassfish.jersey.core:jersey-server` from 2.39.1 to 2.46

Updates `org.glassfish.jersey.containers:jersey-container-servlet` from 2.39.1 to 2.46

Updates `org.glassfish.jersey.media:jersey-media-json-jackson` from 2.39.1 to 2.46

Updates `org.glassfish.jersey.media:jersey-media-jaxb` from 2.39.1 to 2.46

Updates `org.glassfish.jersey.ext:jersey-spring5` from 2.39.1 to 2.46

---
updated-dependencies:
- dependency-name: org.glassfish.jersey.core:jersey-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.inject:jersey-hk2
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.core:jersey-server
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.containers:jersey-container-servlet
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.media:jersey-media-json-jackson
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.media:jersey-media-jaxb
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.glassfish.jersey.ext:jersey-spring5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 21:03:55 +00:00
dependabot[bot]
75d740ec86 Bump com.google.guava:guava from 32.0.0-jre to 32.1.3-jre
Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.0.0-jre to 32.1.3-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 21:03:43 +00:00
dependabot[bot]
bec1ee84e5 Bump org.webjars.npm:json-editor__json-editor in the webjars group
Bumps the webjars group with 1 update: [org.webjars.npm:json-editor__json-editor](https://github.com/json-editor/json-editor).


Updates `org.webjars.npm:json-editor__json-editor` from 2.6.1 to 2.15.1
- [Changelog](https://github.com/json-editor/json-editor/blob/master/CHANGELOG.md)
- [Commits](https://github.com/json-editor/json-editor/compare/2.6.1...2.15.1)

---
updated-dependencies:
- dependency-name: org.webjars.npm:json-editor__json-editor
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: webjars
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 21:03:40 +00:00
dependabot[bot]
4a20a4c37f Bump the fasterxml group with 4 updates
Bumps the fasterxml group with 4 updates: [com.fasterxml:classmate](https://github.com/FasterXML/java-classmate), [com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson), [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) and [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson).


Updates `com.fasterxml:classmate` from 1.6.0 to 1.7.0
- [Commits](https://github.com/FasterXML/java-classmate/compare/classmate-1.6.0...classmate-1.7.0)

Updates `com.fasterxml.jackson.core:jackson-annotations` from 2.16.0 to 2.18.2
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.16.0 to 2.18.2
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.16.0...jackson-core-2.18.2)

Updates `com.fasterxml.jackson.core:jackson-core` from 2.16.0 to 2.18.2
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.16.0...jackson-core-2.18.2)

Updates `com.fasterxml.jackson.core:jackson-databind` from 2.16.0 to 2.18.2
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml:classmate
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: fasterxml
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 21:02:28 +00:00
dependabot[bot]
d7b0e26179 Bump the apache-commons group with 11 updates
Bumps the apache-commons group with 11 updates:

| Package | From | To |
| --- | --- | --- |
| commons-beanutils:commons-beanutils | `1.9.4` | `1.10.0` |
| commons-cli:commons-cli | `1.6.0` | `1.9.0` |
| [commons-codec:commons-codec](https://github.com/apache/commons-codec) | `1.16.0` | `1.17.2` |
| org.apache.commons:commons-configuration2 | `2.10.1` | `2.11.0` |
| org.apache.commons:commons-dbcp2 | `2.11.0` | `2.13.0` |
| commons-io:commons-io | `2.15.1` | `2.18.0` |
| org.apache.commons:commons-lang3 | `3.14.0` | `3.17.0` |
| commons-logging:commons-logging | `1.3.0` | `1.3.4` |
| org.apache.commons:commons-compress | `1.26.0` | `1.27.1` |
| org.apache.commons:commons-text | `1.10.0` | `1.13.0` |
| commons-validator:commons-validator | `1.7` | `1.9.0` |


Updates `commons-beanutils:commons-beanutils` from 1.9.4 to 1.10.0

Updates `commons-cli:commons-cli` from 1.6.0 to 1.9.0

Updates `commons-codec:commons-codec` from 1.16.0 to 1.17.2
- [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt)
- [Commits](https://github.com/apache/commons-codec/compare/rel/commons-codec-1.16.0...rel/commons-codec-1.17.2)

Updates `org.apache.commons:commons-configuration2` from 2.10.1 to 2.11.0

Updates `org.apache.commons:commons-dbcp2` from 2.11.0 to 2.13.0

Updates `commons-io:commons-io` from 2.15.1 to 2.18.0

Updates `org.apache.commons:commons-lang3` from 3.14.0 to 3.17.0

Updates `commons-logging:commons-logging` from 1.3.0 to 1.3.4

Updates `org.apache.commons:commons-compress` from 1.26.0 to 1.27.1

Updates `org.apache.commons:commons-text` from 1.10.0 to 1.13.0

Updates `commons-validator:commons-validator` from 1.7 to 1.9.0

---
updated-dependencies:
- dependency-name: commons-beanutils:commons-beanutils
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: commons-cli:commons-cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: commons-codec:commons-codec
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-configuration2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-dbcp2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: commons-io:commons-io
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-lang3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: commons-logging:commons-logging
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-compress
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: org.apache.commons:commons-text
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
- dependency-name: commons-validator:commons-validator
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: apache-commons
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 21:02:16 +00:00
dependabot[bot]
1492ed7f61 Bump the build-tools group with 21 updates
Bumps the build-tools group with 21 updates:

| Package | From | To |
| --- | --- | --- |
| [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) | `2.10.0` | `2.36.0` |
| [com.puppycrawl.tools:checkstyle](https://github.com/checkstyle/checkstyle) | `8.38` | `8.45.1` |
| [com.github.spotbugs:spotbugs](https://github.com/spotbugs/spotbugs) | `4.8.2` | `4.8.6` |
| [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) | `3.0.0-M3` | `3.5.0` |
| [org.apache.maven.plugins:maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) | `3.8.1` | `3.13.0` |
| [org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin) | `3.2.0` | `3.4.2` |
| [org.apache.maven.plugins:maven-war-plugin](https://github.com/apache/maven-war-plugin) | `3.2.3` | `3.4.0` |
| [org.apache.maven.plugins:maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) | `3.3.1` | `3.6.0` |
| [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) | `4.8.2.0` | `4.8.6.6` |
| [org.apache.maven.plugins:maven-clean-plugin](https://github.com/apache/maven-clean-plugin) | `3.1.0` | `3.4.0` |
| [org.apache.maven.plugins:maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) | `3.6.0` | `3.7.1` |
| [org.apache.maven.plugins:maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) | `3.1.2` | `3.8.1` |
| [org.apache.maven.plugins:maven-resources-plugin](https://github.com/apache/maven-resources-plugin) | `3.1.0` | `3.3.1` |
| org.sonatype.plugins:nexus-staging-maven-plugin | `1.6.8` | `1.7.0` |
| [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) | `3.2.0` | `3.11.2` |
| [org.apache.maven.plugins:maven-source-plugin](https://github.com/apache/maven-source-plugin) | `3.2.1` | `3.3.1` |
| [org.jacoco:jacoco-maven-plugin](https://github.com/jacoco/jacoco) | `0.8.5` | `0.8.12` |
| [org.codehaus.mojo:xml-maven-plugin](https://github.com/mojohaus/xml-maven-plugin) | `1.0.2` | `1.1.0` |
| [org.codehaus.mojo:license-maven-plugin](https://github.com/mojohaus/license-maven-plugin) | `2.0.0` | `2.5.0` |
| [org.codehaus.mojo:build-helper-maven-plugin](https://github.com/mojohaus/build-helper-maven-plugin) | `3.4.0` | `3.6.0` |
| [org.codehaus.mojo:buildnumber-maven-plugin](https://github.com/mojohaus/buildnumber-maven-plugin) | `3.2.0` | `3.2.1` |


Updates `com.google.errorprone:error_prone_core` from 2.10.0 to 2.36.0
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](https://github.com/google/error-prone/compare/v2.10.0...v2.36.0)

Updates `com.puppycrawl.tools:checkstyle` from 8.38 to 8.45.1
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](https://github.com/checkstyle/checkstyle/compare/checkstyle-8.38...checkstyle-8.45.1)

Updates `com.github.spotbugs:spotbugs` from 4.8.2 to 4.8.6
- [Release notes](https://github.com/spotbugs/spotbugs/releases)
- [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/spotbugs/spotbugs/compare/4.8.2...4.8.6)

Updates `org.apache.maven.plugins:maven-enforcer-plugin` from 3.0.0-M3 to 3.5.0
- [Release notes](https://github.com/apache/maven-enforcer/releases)
- [Commits](https://github.com/apache/maven-enforcer/compare/enforcer-3.0.0-M3...enforcer-3.5.0)

Updates `org.apache.maven.plugins:maven-compiler-plugin` from 3.8.1 to 3.13.0
- [Release notes](https://github.com/apache/maven-compiler-plugin/releases)
- [Commits](https://github.com/apache/maven-compiler-plugin/compare/maven-compiler-plugin-3.8.1...maven-compiler-plugin-3.13.0)

Updates `org.apache.maven.plugins:maven-jar-plugin` from 3.2.0 to 3.4.2
- [Release notes](https://github.com/apache/maven-jar-plugin/releases)
- [Commits](https://github.com/apache/maven-jar-plugin/compare/maven-jar-plugin-3.2.0...maven-jar-plugin-3.4.2)

Updates `org.apache.maven.plugins:maven-war-plugin` from 3.2.3 to 3.4.0
- [Commits](https://github.com/apache/maven-war-plugin/compare/maven-war-plugin-3.2.3...maven-war-plugin-3.4.0)

Updates `org.apache.maven.plugins:maven-checkstyle-plugin` from 3.3.1 to 3.6.0
- [Commits](https://github.com/apache/maven-checkstyle-plugin/compare/maven-checkstyle-plugin-3.3.1...maven-checkstyle-plugin-3.6.0)

Updates `com.github.spotbugs:spotbugs-maven-plugin` from 4.8.2.0 to 4.8.6.6
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](https://github.com/spotbugs/spotbugs-maven-plugin/compare/spotbugs-maven-plugin-4.8.2.0...spotbugs-maven-plugin-4.8.6.6)

Updates `org.apache.maven.plugins:maven-clean-plugin` from 3.1.0 to 3.4.0
- [Release notes](https://github.com/apache/maven-clean-plugin/releases)
- [Commits](https://github.com/apache/maven-clean-plugin/compare/maven-clean-plugin-3.1.0...maven-clean-plugin-3.4.0)

Updates `org.apache.maven.plugins:maven-assembly-plugin` from 3.6.0 to 3.7.1
- [Release notes](https://github.com/apache/maven-assembly-plugin/releases)
- [Commits](https://github.com/apache/maven-assembly-plugin/compare/maven-assembly-plugin-3.6.0...maven-assembly-plugin-3.7.1)

Updates `org.apache.maven.plugins:maven-dependency-plugin` from 3.1.2 to 3.8.1
- [Release notes](https://github.com/apache/maven-dependency-plugin/releases)
- [Commits](https://github.com/apache/maven-dependency-plugin/compare/maven-dependency-plugin-3.1.2...maven-dependency-plugin-3.8.1)

Updates `org.apache.maven.plugins:maven-resources-plugin` from 3.1.0 to 3.3.1
- [Release notes](https://github.com/apache/maven-resources-plugin/releases)
- [Commits](https://github.com/apache/maven-resources-plugin/compare/maven-resources-plugin-3.1.0...maven-resources-plugin-3.3.1)

Updates `org.sonatype.plugins:nexus-staging-maven-plugin` from 1.6.8 to 1.7.0

Updates `org.apache.maven.plugins:maven-javadoc-plugin` from 3.2.0 to 3.11.2
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.2.0...maven-javadoc-plugin-3.11.2)

Updates `org.apache.maven.plugins:maven-source-plugin` from 3.2.1 to 3.3.1
- [Release notes](https://github.com/apache/maven-source-plugin/releases)
- [Commits](https://github.com/apache/maven-source-plugin/compare/maven-source-plugin-3.2.1...maven-source-plugin-3.3.1)

Updates `org.jacoco:jacoco-maven-plugin` from 0.8.5 to 0.8.12
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](https://github.com/jacoco/jacoco/compare/v0.8.5...v0.8.12)

Updates `org.codehaus.mojo:xml-maven-plugin` from 1.0.2 to 1.1.0
- [Release notes](https://github.com/mojohaus/xml-maven-plugin/releases)
- [Commits](https://github.com/mojohaus/xml-maven-plugin/compare/xml-maven-plugin-1.0.2...1.1.0)

Updates `org.codehaus.mojo:license-maven-plugin` from 2.0.0 to 2.5.0
- [Release notes](https://github.com/mojohaus/license-maven-plugin/releases)
- [Commits](https://github.com/mojohaus/license-maven-plugin/compare/license-maven-plugin-2.0.0...2.5.0)

Updates `org.codehaus.mojo:build-helper-maven-plugin` from 3.4.0 to 3.6.0
- [Release notes](https://github.com/mojohaus/build-helper-maven-plugin/releases)
- [Commits](https://github.com/mojohaus/build-helper-maven-plugin/compare/3.4.0...3.6.0)

Updates `org.codehaus.mojo:buildnumber-maven-plugin` from 3.2.0 to 3.2.1
- [Release notes](https://github.com/mojohaus/buildnumber-maven-plugin/releases)
- [Commits](https://github.com/mojohaus/buildnumber-maven-plugin/compare/3.2.0...3.2.1)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: com.github.spotbugs:spotbugs
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-enforcer-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-compiler-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-jar-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-war-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-clean-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-assembly-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-dependency-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-resources-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.sonatype.plugins:nexus-staging-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.apache.maven.plugins:maven-source-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.jacoco:jacoco-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
- dependency-name: org.codehaus.mojo:xml-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.codehaus.mojo:license-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.codehaus.mojo:build-helper-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: build-tools
- dependency-name: org.codehaus.mojo:buildnumber-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: build-tools
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-01-15 21:01:16 +00:00
Tim Donohue
e46f02550a Merge pull request #10205 from tdonohue/enable_dependabot_on_7x
[Port dspace-7_x] Create `dependabot.yml` to auto-update Maven dependencies
2025-01-14 16:26:16 -06:00
Tim Donohue
a236b8b975 Merge pull request #10206 from DSpace/backport-9832-to-dspace-7_x
[Port dspace-7_x] Separate log file for cli jobs, fixing corruption of main log file
2025-01-14 15:56:57 -06:00
Jens Vannerum
1a6088388f apply fix to windows env and remove duplicate logging for checksum checker
(cherry picked from commit 9f39a3d6a5)
2025-01-14 21:10:10 +00:00
Kevin Van de Velde
04ec6381cb Modifying it so that the cli file content is stored in a file using the date
(cherry picked from commit 529c3a77c1)
2025-01-14 21:10:10 +00:00
Jens Vannerum
0b46a0963c 113811: cli logs should be written to a different file
(cherry picked from commit d30468a09f)
2025-01-14 21:10:10 +00:00
Tim Donohue
fe28962e96 Exclude spring from build-tools group in dependabot.yml 2025-01-14 15:02:18 -06:00
Tim Donohue
e840ca2731 Create dependabot.yml 2025-01-14 15:02:15 -06:00
Tim Donohue
5201d90b19 Merge pull request #10200 from tdonohue/port_9690_to_7x
[Port dspace-7_x] option to exclude the submitter being indexed to solr in archived items
2025-01-13 16:07:08 -06:00
Gantner, Florian Klaus
62596ad863 option to exclude the submitter being indexed to solr in archived items
https://github.com/DSpace/DSpace/issues/9660
2025-01-13 15:01:20 -06:00
Tim Donohue
024f88b1e0 Merge pull request #10196 from DSpace/backport-9687-to-dspace-7_x
[Port dspace-7_x] Scopus metadata import: put DOIs in dc.relation.hasversion
2025-01-10 15:13:39 -06:00
Sascha Szott
d109eac2a0 use dc.relation.hasversion instead of dc.identifier.doi
(cherry picked from commit d61dc8d911)
2025-01-10 19:54:42 +00:00
Sascha Szott
09a722a029 use dc.relation.hasversion for externally generated DOIs
(cherry picked from commit 29067b6572)
2025-01-10 19:54:42 +00:00
Sascha Szott
5d0e9871e9 fix broken test
(cherry picked from commit 2eff833fab)
2025-01-10 19:54:42 +00:00
Sascha Szott
5973c67eff put DOIs in dc.identifier.doi
(cherry picked from commit 3d1bef9d0e)
2025-01-10 19:54:42 +00:00
Tim Donohue
d11bbc9c15 Merge pull request #10194 from DSpace/backport-10193-to-dspace-7_x
[Port dspace-7_x] Refactor AbstractIntegrationTestWithDatabase to use EPersonBuilder for test users
2025-01-10 13:32:00 -06:00
Tim Donohue
49b3deef77 Refactor AbstractIntegrationTestWithDatabase to use Builders to create test EPersons.
(cherry picked from commit 0b8b7be22b)
2025-01-10 17:40:32 +00:00
Tim Donohue
a2a9494859 Merge pull request #9724 from 4Science/task/dspace-7_x/CST-14905
[Port dspace-7_x] Orcid revoke token feature
2025-01-10 11:29:24 -06:00
Tim Donohue
a0fd518cb4 Merge pull request #10191 from DSpace/backport-10189-to-dspace-7_x
[Port dspace-7_x] switch IT search core to MockSolrSearchCore
2025-01-09 10:17:11 -06:00
Gantner, Florian Klaus
97a5439e3a switch IT search core to MockSolrSearchCore
https://github.com/DSpace/DSpace/issues/10188
(cherry picked from commit 6d781e8f83)
2025-01-09 14:24:20 +00:00
Tim Donohue
0a9ecee819 Merge pull request #10186 from DSpace/backport-10185-to-dspace-7_x
[Port dspace-7_x] Fix for flakey IdentifierProvider Integration Tests
2025-01-08 11:28:07 -06:00
Tim Donohue
41207d5dee Update CreateMissingIdentifiers to better identify when CanonicalHandles provider is enabled. Update CreateMissingIdentifiersIT to verify that we are accurately resetting to our default IdentifierProvider
(cherry picked from commit 2385c13f2d)
2025-01-08 15:59:55 +00:00
Tim Donohue
22511a17b6 Refactor identifier ITs to ensure they unregister all utilized IdentifierProviders which are non-default. Cannot use "getApplicationContext().refresh()" as that seems to result in empty test database in Hibernate 6.6.
(cherry picked from commit cfca2adbb1)
2025-01-08 15:59:54 +00:00
Tim Donohue
da4535ddfd Merge pull request #10183 from tdonohue/port_9340_to_7x
[Port dspace-7_x] Bugfix: Enforce unique item id in workspace table (#9340)
2025-01-07 10:45:37 -06:00
Koen Pauwels
6c82e2dba4 Bugfix: Enforce unique item id in workspace table (#9340)
* 106798 Enforce values in item_id column of workspaceitem table to be unique, both at database level and at WorkspaceItemService level

* 106798 Removed Oracle SQL migration

* 106798 workspaceitem table migration: delete duplicate rows before introducing uniqueness constraint

* 106798: update migration for H2

---------

Co-authored-by: Koen Pauwels <koen.pauwels@atmire.com>
Co-authored-by: wout <wout.atmire@gmail.com>
2025-01-07 08:59:13 -06:00
Tim Donohue
09fad6dc7e Merge pull request #10179 from DSpace/backport-10104-to-dspace-7_x
[Port dspace-7_x] style.xsl: fix missing +1 offset in result-count template
2025-01-06 12:12:12 -06:00
Tim Donohue
2780ebab74 Merge pull request #10177 from DSpace/backport-10157-to-dspace-7_x
[Port dspace-7_x] remove deprecated constructor call in org.dspace.curate.Curation
2025-01-06 11:52:16 -06:00
Sascha Szott
214c669e80 fix missing +1 offset
(cherry picked from commit ab00de05b4)
2025-01-06 17:07:29 +00:00
Sascha Szott
964e4bf476 remove usage of deprecated constructor call
(cherry picked from commit 45cdb4d9d4)
2025-01-06 16:46:17 +00:00
Nona Luypaert
82b0944137 Merge remote-tracking branch 'origin/dspace-7_x' into w2p-121973_openaire-compliance-updates-7.x 2024-12-31 16:53:08 +01:00
Alan Orth
78194071b8 Merge pull request #10166 from DSpace/backport-10089-to-dspace-7_x 2024-12-24 12:31:57 +03:00
Toni Prieto
e856ae3291 Uncache all entities during OAI indexing to reduce memory usage
(cherry picked from commit 9af2e2e17c)
2024-12-24 06:59:53 +00:00
Tim Donohue
a36f0e606c Merge pull request #10154 from DSpace/backport-3253-to-dspace-7_x
[Port dspace-7_x] Add Context method to uncache all entities
2024-12-19 14:29:35 -06:00
Chris Wilper
8849212895 Add Context method to uncache all entities
(cherry picked from commit 8ea664adb2)
2024-12-19 18:57:47 +00:00
Tim Donohue
9b651b7ab3 Merge pull request #9893 from bkeese/patch-1
Fix full-text indexing for files over the character limit
2024-12-19 12:28:37 -06:00
Tim Donohue
66281d3a6d Merge pull request #10149 from DSpace/backport-10059-to-dspace-7_x
[Port dspace-7_x] Statistics scope fix
2024-12-19 08:56:17 -06:00
Tim Donohue
3fa86d43f6 Merge pull request #10147 from DSpace/backport-9815-to-dspace-7_x
[Port dspace-7_x] fix for #9311: set default configFile
2024-12-19 08:56:07 -06:00
Kristof De Langhe
51df5c1fe6 119664: Search event scope fix
(cherry picked from commit 48956d90b7)
2024-12-18 22:50:42 +00:00
DSpace Bot
1ce4e08333 [Port dspace-7_x] Fix issue with submission sections visibility (#10140)
* README.md: v8 is the current release, not v7

(cherry picked from commit 2b698eff60)
(cherry picked from commit 83460afb37)

* Update README.md

(cherry picked from commit 671234b08f)
(cherry picked from commit 7a6785b1c3)

* [DURACOM-291] Expose section scope attribute

(cherry picked from commit 4107f937fd)

* README.md: v8 is the current release, not v7

(cherry picked from commit 2b698eff60)
(cherry picked from commit d98499a394)

* Update README.md

(cherry picked from commit 671234b08f)
(cherry picked from commit 6a707548ff)

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Giuseppe Digilio <giuseppe.digilio@4science.com>
2024-12-18 16:45:16 -06:00
Tim Donohue
0d8c5f12a3 Merge pull request #10145 from DSpace/backport-9817-to-dspace-7_x
[Port dspace-7_x] fix for #9312: properly type in field id, adjust use of getProperty and add error handling
2024-12-18 16:05:38 -06:00
Tim Donohue
ad033ef1ba Merge pull request #10143 from DSpace/backport-9913-to-dspace-7_x
[Port dspace-7_x] Submission scope naming for input field validation fixed
2024-12-18 15:56:13 -06:00
igorbaptist4
c86d082d5f fix: set default configFile
(cherry picked from commit a5e8d7aa15)
2024-12-18 21:02:37 +00:00
igorbaptist4
3a223e3fef fix line length checkstyle
(cherry picked from commit 338f3b1d3e)
2024-12-18 20:57:22 +00:00
igorbaptist4
973beee2ce fix: properly type in field id, adjust use of getProperty and add error handling when dbPath is null (when property usage-statistics.dbfile is commented
(cherry picked from commit 412d5751f2)
2024-12-18 20:57:22 +00:00
Jukka Lipka
31faf809d1 fix(submission): Submission scope naming fixed
Corrected wording in related code comment

(cherry picked from commit ec2187ea65)
2024-12-18 20:47:49 +00:00
Jukka Lipka
95742fe4f3 fix(submission): Submission scope naming fixed
According to the documentation, the value for the <visibility> property is 'submission' in the 'submission-forms.xml'. Without this change, an empty input field will never be marked as an error, even if the field is marked as 'required'.

(cherry picked from commit 02f52c7d5c)
2024-12-18 20:47:49 +00:00
Tim Donohue
026a0aa9ab Merge pull request #10138 from DSpace/backport-10057-to-dspace-7_x
[Port dspace-7_x] Add limit, offset, and total facet count to Solr query for the metadata browse index
2024-12-18 12:57:36 -06:00
Toni Prieto
fcc650e1a6 Add limit, offset, and a new parameter to calculate the total entry count in the Solr query used for the metadata navigation index
(cherry picked from commit e71de8a4d0)
2024-12-18 18:05:26 +00:00
Tim Donohue
b4d4588d34 Merge pull request #10136 from DSpace/backport-9834-to-dspace-7_x
[Port dspace-7_x] More information about failed DOI registrations.
2024-12-17 16:01:36 -06:00
Tim Donohue
89b8e92512 Merge pull request #10134 from DSpace/backport-10132-to-dspace-7_x
[Port dspace-7_x] [Docker] Minor Dockerfile enhancements to stabilize & speed up automated builds
2024-12-17 16:01:01 -06:00
Mark H. Wood
e5568157c8 More information about failed DOI registrations.
(cherry picked from commit b8f4ab0eb3)
2024-12-17 21:11:32 +00:00
Tim Donohue
58af9fd224 Significantly speed up build of dspace-dependencies by only copying over POM files
(cherry picked from commit 6d7a3fcb72)
2024-12-17 20:52:35 +00:00
Tim Donohue
aa027aefae Improve Apache Ant download process. Switch to using curl so that we can retry the request if it initially fails.
(cherry picked from commit e236634a4c)
2024-12-17 20:52:35 +00:00
Tim Donohue
4e59693da5 Merge pull request #10131 from tdonohue/port_9760_to_7x
[Port dspace-7_x] Improve Group2GroupCache computation
2024-12-17 12:12:35 -06:00
autavares-dev
05bac14716 Refactor 'var' variables to explicit types 2024-12-17 11:11:37 -06:00
autavares-dev
64cb3bda00 Changes Group2GroupCache computation 2024-12-17 11:11:20 -06:00
Nona Luypaert
ecbb8682a7 Merge remote-tracking branch 'contributions/w2p-121971_openaire-compliance-updates-7.6' into w2p-121973_openaire-compliance-updates-7.x 2024-12-17 11:43:38 +01:00
Tim Donohue
8e6371c9b5 Merge pull request #10122 from DSpace/backport-10120-to-dspace-7_x
[Port dspace-7_x] [GitHub Actions] Refactor Docker build process to use ghcr.io for build, and then copy to docker.io once build completes
2024-12-16 15:14:37 -06:00
Tim Donohue
a27f1ed175 Ensure "docker-deploy" job also uses ghcr.io by default. 2024-12-16 13:57:18 -06:00
Tim Donohue
296c9a12f4 PRs must also login to ghcr.io in order to read private images for the build process 2024-12-16 13:57:11 -06:00
Tim Donohue
2a6c60e139 Refactor Docker build process to use ghcr.io for build, and then copy to docker.io once build completes 2024-12-16 13:56:53 -06:00
Tim Donohue
5869f03b51 Merge pull request #10115 from tdonohue/port_10800_to_7x
[Port dspace-7_x] [Docker] Use fully qualified image names & allow for other registries to be used
2024-12-12 16:49:44 -06:00
Tim Donohue
2ee328ff18 Minor Dockerfile cleanup. Use new syntax for ENV variables 2024-12-12 16:15:10 -06:00
Tim Donohue
a6d2c4897b Add Docker registry to all scripts. Allow it to be configurable for DSpace images (only). Other minor Dockerfile cleanup 2024-12-12 16:15:10 -06:00
Nona Luypaert
e540168594 121971: #9867 - Remove objectType attribute from openaire crosswalk 2024-12-12 09:18:40 +01:00
Nona Luypaert
52e5b35c06 121971: #9664 - Make cclicense step required in openaire submission form 2024-12-12 09:16:21 +01:00
Marie Verdonck
93aaece18f Merge branch 'w2p-109807_external-sources-fixes-7.6' into issue-10110_w2p-109807_arxiv-author-mapping-fix-7_x 2024-12-12 01:28:52 +01:00
Marie Verdonck
e0d67c2bd4 Merge remote-tracking branch 'atmire-gitlab/w2p-109807_external-sources-fixes' into w2p-109807_external-sources-fixes-7.6 2024-12-12 01:27:05 +01:00
Nona Luypaert
31c79500ce 121971: #9716 - Only dc.date.embargo should have date type Available 2024-12-11 21:49:37 +01:00
Nona Luypaert
04953b94d9 121971: #9715 - Only dc.date.issued should have date types Accepted and Issued 2024-12-11 21:46:17 +01:00
Nona Luypaert
c017a662e0 121971: #9669 - Remove unsupported OpenAIRE date types 2024-12-11 21:26:42 +01:00
Tim Donohue
ac9f7c16e6 Merge pull request #10101 from tdonohue/port_10091_to_7x
[Port dspace-7_x] [GitHub Actions] Ensure PRs against main also use "latest" tag when running test Docker deployment
2024-12-10 12:14:12 -06:00
Tim Donohue
b8c88ef284 Ensure PRs against main also use "latest" tag 2024-12-10 11:33:51 -06:00
Tim Donohue
f0bb57a4c2 Merge pull request #10087 from tdonohue/port_github_action_docker_to_7x
[Port dspace-7_x] [GitHub Actions] Port several Docker building improvements
2024-12-09 11:56:32 -06:00
Tim Donohue
78855cdbba Ensure we use the main Docker image, and not the "-test" image. 2024-12-09 10:18:32 -06:00
Tim Donohue
3c0e7158a2 Ensure each image has a separate cache. This allows later builds of that same image to inherit that cache. 2024-12-06 17:16:40 -06:00
Tim Donohue
020fec96d8 Ensure PRs are tagging their images with same tag as the base branch the PR was created against 2024-12-06 17:16:26 -06:00
Tim Donohue
46c169fb79 Refactor to use the same local TAR image build for PRs and non-PRs. These TAR images act as a cache for our current build. 2024-12-06 17:16:19 -06:00
Tim Donohue
0fc0f181fd Enable caching of Docker builds using GitHub Actions cache 2024-12-06 17:16:14 -06:00
Tim Donohue
1f5defe643 Ensure non-PRs run image build twice. First for a DockerHub image, then to export a local tarball. Since these are different image types they cannot be combined 2024-12-06 17:16:06 -06:00
Tim Donohue
8d34f06396 Update Actions to always deploy the locally created image. non-PRs do not need to redownload images from DockerHub. 2024-12-06 17:16:01 -06:00
Tim Donohue
f8bf278f06 Ensure login occurs *before* setup-buildx, as some buildx commands appear to be unauthenticated. 2024-12-06 17:15:54 -06:00
Tim Donohue
f26a732ab8 Merge pull request #10082 from DSpace/backport-9728-to-dspace-7_x
[Port dspace-7_x] Improve observability of running processes + Fail them during startup
2024-12-05 15:43:01 -06:00
Nona Luypaert
8bc100375a 116609: Add try catch to init method in ProcessServiceImpl
(cherry picked from commit 070fe689d7)
2024-12-05 21:00:48 +00:00
Nona Luypaert
3f836ae7a5 116687: Never handle exception with null message
(cherry picked from commit bdf7069cb7)
2024-12-05 21:00:48 +00:00
Nona Luypaert
1ba7ca3bdd 116609: Add tomcat shutdown line to process log
(cherry picked from commit 156ad471b5)
2024-12-05 21:00:48 +00:00
Nona Luypaert
25fb8111f1 116609: Improve running process observability
- keep temp process log files in [dspace]/log/processes/ instead of temp dir
- reformat file names of process logs
- ensure that running and scheduled processes are cleaned up during startup

(cherry picked from commit d80f49e023)
2024-12-05 21:00:48 +00:00
Tim Donohue
a1d2504ab3 Merge pull request #10068 from DSpace/backport-9658-to-dspace-7_x
[Port dspace-7_x] Feature curation link checker customizations
2024-12-03 09:53:43 -06:00
Nathan Buckingham
3ff38ec4b4 115778: Adjust redirect check to only follow a limited amount defined in curate.cfg
(cherry picked from commit ef381aa151)
2024-12-03 15:17:19 +00:00
Marie Verdonck
be905a0887 110719: IT checking redirect links accepted by checklinks curate task
(cherry picked from commit e826660cb0)
2024-12-03 15:17:19 +00:00
Nathan Buckingham
2136dbf690 110719: Port fix to checkLinks that works on redirects
(cherry picked from commit 3dab2a7cea)
2024-12-03 15:17:19 +00:00
Tim Donohue
df4ddc8197 Merge pull request #10061 from DSpace/backport-9941-to-dspace-7_x
[Port dspace-7_x] Fixed dso endpoint returning 500 for unauthorized users
2024-12-02 10:58:09 -06:00
Alexandre Vryghem
38a71cc664 119960: Fixed NPE when retrieving a DSpace object with the api/dso/find endpoint without the required permissions
(cherry picked from commit dd8b1d91cb)
2024-12-02 16:07:46 +00:00
Marie Verdonck
54a1c75cbc 109807: ArXiv mapping fix - author/name to dc.contributor.author
https://info.arxiv.org/help/api/basics.html#using
2024-11-28 13:06:23 +01:00
Tim Donohue
88b5ce81a6 Merge pull request #10041 from DSpace/backport-10040-to-dspace-7_x
[Port dspace-7_x] [GitHub Actions] Ensure all optional modules are enabled in our test Docker deployment
2024-11-22 16:28:05 -06:00
Tim Donohue
cf99694a84 Fix startup errors for SWORDv2. Requires the log4jv1->v2 bridge to be installed. 2024-11-22 16:03:16 -06:00
Tim Donohue
66a9782eee Fix syntax error in #10040. Env variables cannot have dashes or periods 2024-11-22 16:03:16 -06:00
Tim Donohue
f44dba60cb Enable all optional modules/controllers to test their deployment in Spring Boot
(cherry picked from commit 98768d6f4f)
2024-11-22 16:03:15 -06:00
Tim Donohue
bbf9ccf2ab Merge pull request #10034 from tdonohue/port_10032_to_7x
[Port dspace-7_x] Remove unused dependencies from several modules
2024-11-21 11:58:16 -06:00
Tim Donohue
9f8240987b Remove unused dependencies from several modules 2024-11-21 11:24:23 -06:00
Tim Donohue
888332a8d5 Merge pull request #10020 from tdonohue/port_10014_to_7x
[Port dspace-7_x] Dependency cleanup for OAI-PMH and Log4j (removing log4j v1 bridge & settings which used it)
2024-11-18 14:40:16 -06:00
Tim Donohue
f3d15e5c04 Log4j cleanup. Remove last traces of log4j v1 (and remove log4j1 bridge to avoid them coming back). Create log4j2 settings for Handle Plugin. 2024-11-18 14:02:14 -06:00
Tim Donohue
d952fea6a2 Remove parboiled-java and minor cleanup of unused OAI dependencies 2024-11-18 13:39:06 -06:00
Tim Donohue
ca176b77b2 Merge pull request #10017 from DSpace/backport-10016-to-dspace-7_x
[Port dspace-7_x] [GitHub Actions] More fixes to Docker deployment builds
2024-11-15 17:13:00 -06:00
Tim Donohue
f0c92ac96b Ensure only main branch uses "latest". Other branches should use the tag corresponding to the branch name
(cherry picked from commit e0b7241acb)
2024-11-15 22:42:11 +00:00
Tim Donohue
7e18e743ee Merge pull request #10011 from DSpace/backport-10010-to-dspace-7_x
[Port dspace-7_x] [GitHub Actions] Minor bug fix to Docker deployment builds
2024-11-15 10:26:42 -06:00
Tim Donohue
7fa31e2131 Ensure we use "pr-testing" images for PRs, but use "latest" images for other builds (e.g. after PR is merged to a branch).
(cherry picked from commit aa537c4490)
2024-11-15 15:34:38 +00:00
Tim Donohue
90b58833ec Merge pull request #9995 from DSpace/backport-9746-to-dspace-7_x
[Port dspace-7_x] Fix 9734: Check configured workflow.reviewer.file-edit to show item e…
2024-11-14 14:54:50 -06:00
Agustina Martinez
aa71e4840b Fix 9734: Check configured workflow.reviewer.file-edit to show item edit functionality in workflow UI
(cherry picked from commit e8ec0c1b1d)
2024-11-14 20:11:05 +00:00
Tim Donohue
3f1f4cb217 Merge pull request #9993 from tdonohue/port_9973_to_7x
[Port dspace-7_x] [GitHub Actions] Add a job to test Docker deployment with newly built images & test Handle Server
2024-11-13 16:45:25 -06:00
Tim Donohue
5bb65c6b56 Fix error in Handle Server startup caused by having multiple versions of BouncyCastle in our classpath. Exclude the old version brought in by cnri-servlet-container 2024-11-13 15:11:36 -06:00
Tim Donohue
d6d78298b3 Add check for Handle Server error.log 2024-11-13 15:11:30 -06:00
Tim Donohue
a0ed4a40ea Bug fixes. Ensure all steps of docker-deploy use the same environment variables. Ensure Handle Server HTTP port is open 2024-11-13 15:11:12 -06:00
Tim Donohue
faca14ad40 Ensure "host" command is installed in images, so "bin/make-handle-config" will work. 2024-11-13 15:09:47 -06:00
Tim Donohue
9853aa5bb4 Fix error in running Handle Server in GitHub Actions. Must exclude "spring-jcl" from dependencies as it conflicts with "commons-logging" (used by more of our dependencies) 2024-11-13 15:06:41 -06:00
Tim Donohue
c1f168245b Ensure Docker images built from PRs are stored as artifacts. This allows us to use those new images when testing deployment (in docker-deploy) 2024-11-13 15:06:32 -06:00
Tim Donohue
3ce85a2df3 Add a check that the Handle Server can be started & works properly 2024-11-13 15:06:25 -06:00
Tim Donohue
c66dde2aa8 Add a job to test Docker deployment with the built images 2024-11-13 15:06:18 -06:00
Tim Donohue
7017f5ecb1 Merge pull request #9976 from DSpace/backport-9861-to-dspace-7_x
[Port dspace-7_x] performance of claiming workflow task fix
2024-11-11 16:00:36 -06:00
Andrew
fde825265d fix: performance of claiming workflow task
(cherry picked from commit 27dd5a2ec5)
2024-11-11 21:15:41 +00:00
Tim Donohue
426d3abde0 Merge pull request #9974 from DSpace/backport-9890-to-dspace-7_x
[Port dspace-7_x] Status of DOI object should be set to TO_BE_DELETED when the related item is removed
2024-11-11 12:20:45 -06:00
Jens Vannerum
831db33018 118774: status of doi should be set to TO_BE_DELETED when related item is removed permanently
(cherry picked from commit 352f4c2152)
2024-11-11 16:40:56 +00:00
Tim Donohue
a452f035c3 Merge pull request #9969 from DSpace/backport-9968-to-dspace-7_x
[Port dspace-7_x] Improve logging of Unit & Integration Tests.  Ensure all tests log which method they are running.
2024-11-06 15:53:10 -06:00
Tim Donohue
68266cd3c1 Move logging of test methods to Abstract*Test classes in dspace-api. That way they work for **both** dspace-server-webapp and dspace-api tests.
(cherry picked from commit bd20c9262b)
2024-11-06 21:12:01 +00:00
Andreas Awouters
30cd44c196 Merge branch 'accessibility-settings-7.6' into accessibility-settings-7_x 2024-11-06 09:41:36 +01:00
Andreas Awouters
10a95ae92a 119602: Add accessibility settings metadata field 2024-11-06 09:39:33 +01:00
Tim Donohue
68b800f070 Merge pull request #9897 from DSpace/backport-9894-to-dspace-7_x
[Port dspace-7_x] Add Eclipse JDT .factorypath to .gitignore
2024-10-16 10:31:32 -05:00
Kim Shepherd
6018f926d7 Add Eclipse JDT .factorypath to .gitignore
(cherry picked from commit 9ce645e08b)
2024-10-16 15:28:30 +00:00
Miika Nurminen
31d36e7abf Bugfix: BitstreamRestController etag/content-length calculation does not consider cover page
Ported Alphonse Bendt's PR #9666 to DSpace 7 branch (squashed 5 commits).
This PR fixes a bug where the etag/content-length calculation did not respect the potential existence of a coverpage.
The controller now will use the post processed pdf if coverpages are enabled.
2024-10-16 11:48:10 +03:00
Brian Keese
4a4a8bcb22 Fix full-text indexing for files over the character limit
The error handler for files over the limit logged the correct message, but never actually added the full text to the index doc.
2024-10-15 11:38:54 -05:00
Tim Donohue
e9290f4bdc Merge pull request #9888 from tdonohue/update_latest_spring5
Bump `dspace-7_x` to Spring 5.3.39 and Spring Security 5.7.12
2024-10-14 08:42:57 -05:00
Tim Donohue
70dd847759 Revert to Spring Security 5.7.12. Spring Security 5.8.x changes behavior of CSRF tokens 2024-10-11 16:41:40 -05:00
Tim Donohue
1e47fa61d9 Bump to Spring 5.3.39 and Spring Security 5.8.14 2024-10-11 14:38:47 -05:00
Tim Donohue
ce1edc3bd3 Merge pull request #9877 from DSpace/backport-9777-to-dspace-7_x
[Port dspace-7_x] several optimizations in HAL browser login page
2024-10-08 14:11:57 -05:00
Sascha Szott
4669d8f760 applied change suggested by reviewer: use String.prototype.includes
(cherry picked from commit 546afb189e)
2024-10-08 19:11:02 +00:00
Sascha Szott
a721f8c41e fix failed first login attempt in HAL browser
(cherry picked from commit 002e637d4f)
2024-10-08 19:11:02 +00:00
Tim Donohue
5ad4adbddc Merge pull request #9862 from DSpace/backport-9859-to-dspace-7_x
[Port dspace-7_x] minor fix in parameter description in subscriptions_content
2024-09-27 10:47:18 -05:00
Sascha Szott
702ff9cf4c minor fix in parameter description
(cherry picked from commit 5758d9e903)
2024-09-27 15:44:49 +00:00
Tim Donohue
7b98632152 Merge pull request #9857 from DSpace/backport-9678-to-dspace-7_x
[Port dspace-7_x] LDAPAuthentication considers update of eperson's attributes
2024-09-26 16:12:58 -05:00
Sascha Szott
31af49ea72 fix Checkstyle violations
(cherry picked from commit aaa74b88c9)
2024-09-26 18:27:55 +00:00
Sascha Szott
b0370a064b add missing import
(cherry picked from commit c5ad32a9b3)
2024-09-26 18:27:55 +00:00
Sascha Szott
405397b8b0 update eperson's attributes right after successful login
(cherry picked from commit 428489ca52)
2024-09-26 18:27:55 +00:00
kshepherd
43c25c9972 Merge pull request #9838 from DSpace/backport-9581-to-dspace-7_x
[Port dspace-7_x] Add missing wosPublisherContrib key-ref in wos-integration.xml (#9579)
2024-09-19 15:49:16 +02:00
Mikhail Schastlivtsev
a49ee62450 add missing publisher metadatum in test (#9579)
(cherry picked from commit cde892c8c7)
2024-09-19 12:05:06 +00:00
Mikhail Schastlivtsev
9031322e7d add missing wosPublisherContrib key-ref in wos-integration.xml (#9579)
(cherry picked from commit 6a8c76bbe1)
2024-09-19 12:05:06 +00:00
Tim Donohue
b6209e0a95 Merge pull request #9801 from tdonohue/port_9668_to_7x
[Port dspace-7_x] Fix for DSpace#9667: Request-a-copy link generation for base URLs that have sub-paths
2024-09-06 16:40:59 -05:00
Tim Donohue
4ac4c911cf Singular name needed in 7.x 2024-09-06 16:08:49 -05:00
Kim Shepherd
7ec746d005 lint fixes (RequestItemRepository) 2024-09-06 13:54:01 -05:00
Kim Shepherd
ab43b86066 Tidy implementation of link token generation 2024-09-06 13:54:01 -05:00
Kim Shepherd
1914aac18b Improved URI build method as per review 2024-09-06 13:54:01 -05:00
Kim Shepherd
64255ffb05 #9668: Ensure proper handling of non-subpath URLs in link tokens 2024-09-06 13:54:01 -05:00
Kim Shepherd
cdb255feca Make RequestItemRepository#getLinkTokenEmail public, write test 2024-09-06 13:54:01 -05:00
Kim Shepherd
724f821bee Fix request a copy link token generation
Ensure DSpace URLs with extra segments are included
fully in the generated link
2024-09-06 13:54:00 -05:00
Tim Donohue
65232f64d3 Merge pull request #9812 from DSpace/backport-9807-to-dspace-7_x
[Port dspace-7_x] Rewrite DSpace integration tests to consistently use AbstractBuilder<T> builders
2024-09-06 12:21:42 -05:00
Kim Shepherd
123aedde04 #9806: Move cleanup of handle provider to destroy in VersionedHandleIdentifierProviderIT
(cherry picked from commit f6cabe648d)
2024-09-06 16:49:19 +00:00
Kim Shepherd
89796ece6b #9806: Set explicit id provider before VersioningWithRelationshipsIT
(cherry picked from commit 4af6900650)
2024-09-06 16:49:19 +00:00
Kim Shepherd
48c8848fc2 #9806: Use builders for creation in VersioningWithRelationshipsIT
I am a bit uncertain about the createBean() calls here, why do
we not simply *get* the configured beans using the service manager
instead, but will look at that in a separate change

(cherry picked from commit 3521ab6d35)
2024-09-06 16:49:19 +00:00
Kim Shepherd
282d4db36b #9806: Align provider reg in CreateMissingIdentifiersIT with other tests
VersionedHandlerIdentifierProviderIT uses this registerProvider method
which looks more reliable and doesn't do a refresh/reload of
applicationContext after (which I suspected might have an odd interaction
with VersioningWithRelationshipsIT and its createBean() calls?)

(cherry picked from commit 90536e443b)
2024-09-06 16:49:19 +00:00
Kim Shepherd
5fd99d8b14 #9806: Update object cleanup in GroupRestRepositoryIT
(cherry picked from commit 8cfb433c40)
2024-09-06 16:49:19 +00:00
Kim Shepherd
e6a0bb8943 #9806: Builders for comm, coll, group in CommunityAdminGroupRestControllerIT
(cherry picked from commit 2d9988f77c)
2024-09-06 16:49:19 +00:00
Kim Shepherd
968559bbaf #9806: Use builders for comm, coll, group creation in CollectionGroupRestControllerIT
(cherry picked from commit f4629d8351)
2024-09-06 16:49:19 +00:00
Kim Shepherd
b9278cbf33 #9806: Use builders for comm, coll, group creation in SupervisionOrderServiceIT
(cherry picked from commit 6e9181e3f7)
2024-09-06 16:49:19 +00:00
Kim Shepherd
ffc807205f #9806: Refactor WorkspaceItemBuilder to support specific item uuid
(cherry picked from commit b99b1eec29)
2024-09-06 16:49:19 +00:00
Kim Shepherd
8d576f8300 #9806: Use builders for group, comm, coll creation in StructBuilderIT
(cherry picked from commit 2ef69045d1)
2024-09-06 16:49:18 +00:00
Kim Shepherd
67fa262b83 #9806: Use builders for group, comm, coll creation in PackagerIT
(cherry picked from commit 1f475aa731)
2024-09-06 16:49:18 +00:00
Kim Shepherd
690dfa0809 #9806: Tidy imports for GroupRestRepositoryIT
(cherry picked from commit 80328eaca5)
2024-09-06 16:49:18 +00:00
Kim Shepherd
b9b135163f #9806: Use builders for coll, comm, group creation in GroupRestRepositoryIT
(cherry picked from commit 9205773802)
2024-09-06 16:49:18 +00:00
Kim Shepherd
2ff2297b1f #9806: Use builders for coll, comm, group creation in BitstreamRestRepositoryIT
(cherry picked from commit b13abac753)
2024-09-06 16:49:18 +00:00
Kim Shepherd
404039ade6 #9806: Add new create methods to group builder
Now supports admin groups, default read, workflow role

(cherry picked from commit cdb167e55a)
2024-09-06 16:49:18 +00:00
Tim Donohue
730e87536d Merge pull request #9798 from DSpace/backport-9796-to-dspace-7_x
[Port dspace-7_x] Translate underscores to dashes in xml:lang attr for DIM2DataCite.xsl
2024-09-03 13:33:06 -05:00
Kim Shepherd
e15f60abd3 Translate underscores to dashes in xml:lang attr for DIM2DataCite.xsl
Modified the DataCite crosswalk to ensure that the xml:lang attribute translates any underscores in the value of @lang to dashes. This change aligns the attribute formatting with standard language code conventions.

(cherry picked from commit a898afd5ac)
2024-09-03 17:19:12 +00:00
Tim Donohue
2ad5172120 Merge pull request #9790 from DSpace/backport-9775-to-dspace-7_x
[Port dspace-7_x] Make statistics autocommit much more frequently
2024-08-29 16:50:41 -05:00
Mark H. Wood
41312eec6e Make statistics autocommit much more frequent.
(cherry picked from commit 5c9af9764e)
2024-08-29 21:22:50 +00:00
kshepherd
8b3bf176fb Merge pull request #9784 from DSpace/backport-9684-to-dspace-7_x
[Port dspace-7_x] Crossref metadata import: change order of person name parts
2024-08-29 20:40:17 +02:00
Tim Donohue
94fca6fe35 Merge pull request #9789 from tdonohue/port_9497_to_7x
[Port dspace-7_x] In workflow-attached curation, separate task-list building from execution.
2024-08-29 12:11:20 -05:00
Tim Donohue
e570135689 Merge pull request #9786 from DSpace/backport-9765-to-dspace-7_x
[Port dspace-7_x] Fix index-discovery process when using handle
2024-08-29 10:41:47 -05:00
Mark H. Wood
0d74bd9f18 Separate task-list building from execution.
The old code would curate the object once for each task, meaning that all
but one task would be executed N times up to the length of the list.
2024-08-29 10:32:56 -05:00
autavares-dev
ffc99d06a1 Fix index-discovery process when using handle
(cherry picked from commit 077aed38dc)
2024-08-29 15:10:11 +00:00
Sascha Szott
7e87d57672 fix broken unit tests
(cherry picked from commit 1712b9f078)
2024-08-29 15:03:01 +00:00
Sascha Szott
f61c45bdc6 change order of name parts: familyName, givenName
(cherry picked from commit 076f1f233e)
2024-08-29 15:03:01 +00:00
Bram Luyten
8a997abf6a Merge pull request #9771 from DSpace/backport-9671-to-dspace-7_x
[Port dspace-7_x] DataCite DOI error fixes
2024-08-23 14:16:27 +02:00
Kristof De Langhe
c1be5f8e4e 115693: Pass doi metadatafield with xsl parameters
(cherry picked from commit 9e11e1f9ae)
2024-08-23 11:24:58 +00:00
Kristof De Langhe
d240a16b05 115693: DataCiteConnector fallback for blank metadata doi
(cherry picked from commit 021e424347)
2024-08-23 11:24:58 +00:00
Kristof De Langhe
f1dc25195f 115693: data-cite xsl targetting dc.identifier.uri fixes doi registration error
(cherry picked from commit c5d08f037c)
2024-08-23 11:24:58 +00:00
Tim Donohue
d23bf4c3cd Merge pull request #9743 from DSpace/backport-9742-to-dspace-7_x
[Port dspace-7_x] Fix potentially invalid usages of == operator
2024-08-02 11:57:54 -05:00
Sascha Szott
36ff5ca6cb use equals instead of ==
(cherry picked from commit a13cc82d40)
2024-08-02 16:24:13 +00:00
Sascha Szott
6a5236f2f9 use equals instead of ==
(cherry picked from commit d2ef7b01ef)
2024-08-02 16:24:13 +00:00
Sascha Szott
dc09d06ed6 use equals instead of ==
(cherry picked from commit 5e3552ee38)
2024-08-02 16:24:13 +00:00
Sascha Szott
b8f638b3b6 use equals instead of ==
(cherry picked from commit 80de8f6fb5)
2024-08-02 16:24:13 +00:00
Tim Donohue
275b0f89b7 Merge pull request #9740 from DSpace/backport-9737-to-dspace-7_x
[Port dspace-7_x] fix invalid usage of == operator
2024-08-02 11:08:28 -05:00
Sascha Szott
24318e01b8 fix invalid usage of == operator
(cherry picked from commit fa0fb14a18)
2024-08-02 14:49:40 +00:00
Tim Donohue
54bd5dd189 Merge pull request #9710 from atmire/w2p-116319_fix-metadata-import-setting-language-as-any-instead-of-null-upstream-7-x
[Port dspace-7_x] Fix issue where CSV Import / Export can clear metadata if there are metadata values with language "*" (Item.ANY)
2024-07-25 10:22:55 -05:00
Vincenzo Mecca
26905b7d45 [CST-14901][DSC-1357][#8662] Handles versioning for ORCID publications.
feat:
 - ORCID publications waiting to be published are removed whenever a new version is created
 - ORCID publications already published will be updated with the ref to the last item version
 - ORCID consumer will process only latest item versions, ignoring all the other ones
2024-07-25 11:44:37 +02:00
Vincenzo Mecca
affa4b00ff [CST-14905] Orcid revoke token feature 2024-07-24 19:39:21 +02:00
Tim Donohue
f6208bc1ce Merge pull request #9719 from DSpace/backport-9717-to-dspace-7_x
[Port dspace-7_x] Update spider list URLs to satisfy Cloudflare redirects
2024-07-23 14:28:03 -05:00
Kim Shepherd
30b6eddeb6 Update spider list URLs to satisfy cloudflare redirects
Update spider list URLs to satisfy cloudflare redirects

Update spider list URLs to satisfy cloudflare redirects

(cherry picked from commit d22ea117ca)
2024-07-23 18:53:56 +00:00
Tim Donohue
a3b27bdfb6 Merge pull request #9712 from DSpace/backport-9711-to-dspace-7_x
[Port dspace-7_x] Bump dnsjava:dnsjava from 2.1.9 to 3.6.0 in /dspace-api
2024-07-22 14:00:51 -05:00
dependabot[bot]
fff8cc3cb4 Bump dnsjava:dnsjava from 2.1.9 to 3.6.0 in /dspace-api
Bumps [dnsjava:dnsjava](https://github.com/dnsjava/dnsjava) from 2.1.9 to 3.6.0.
- [Release notes](https://github.com/dnsjava/dnsjava/releases)
- [Changelog](https://github.com/dnsjava/dnsjava/blob/master/Changelog)
- [Commits](https://github.com/dnsjava/dnsjava/compare/v2.1.9...v3.6.0)

---
updated-dependencies:
- dependency-name: dnsjava:dnsjava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 1775c88919)
2024-07-22 18:19:36 +00:00
Jens Vannerum
7082e32595 116542: resolve issues after merge with latest 7-x branch 2024-07-22 15:18:44 +02:00
Jens Vannerum
8f049579dc Merge branch 'w2p-116319_fix-metadata-import-setting-language-as-any-instead-of-null' into w2p-116319_fix-metadata-import-setting-language-as-any-instead-of-null-upstream-7-x 2024-07-22 15:14:12 +02:00
Jens Vannerum
03cff072c3 116542: fix issues with CSV importing and the Any language being set on metadata values 2024-07-22 15:08:59 +02:00
Tim Donohue
086655712d Merge pull request #9707 from tdonohue/port_9704_to_7x
[Port dspace-7_x] Docker build: fix FromAsCasing warnings
2024-07-17 12:00:06 -05:00
Sascha Szott
e4209d5d0b fix FromAsCasing warning 2024-07-17 11:26:47 -05:00
Sascha Szott
9b6b7ded97 fix FromAsCasing warning 2024-07-17 11:26:36 -05:00
Sascha Szott
f340dfadbe fix FromAsCasing warning 2024-07-17 11:25:33 -05:00
Sascha Szott
83f3ea4d05 fix FromAsCasing warning 2024-07-17 11:24:15 -05:00
Tim Donohue
9e1ea61a0b Merge pull request #9693 from tdonohue/port_9691_to_7x
[Port dspace-7_x] Fix random test failures in LinksetRestControllerIT and ManageGroupsFeatureIT
2024-07-10 15:49:27 -05:00
Tim Donohue
3bb93be793 Fix random pagination failures in ManageGroupsFeatureIT by using the "feature" param to filter for the feature we are looking for. If this feature appeared on page 2, then the tests would fail. 2024-07-10 15:17:56 -05:00
Tim Donohue
17a46a2fb6 Remove unused services & unnecessary cache cleanup. This can result in random failures if these services are not yet loaded by another test. 2024-07-10 15:15:47 -05:00
Tim Donohue
e4874c9f2f Merge pull request #9683 from TexasDigitalLibrary/port_9682_to_7x
updated creative commons licenses version from 3.0 to 4.0
2024-07-09 15:43:21 -05:00
Tim Donohue
86b28bf927 [maven-release-plugin] prepare for next development iteration 2024-07-09 14:10:05 -05:00
Tim Donohue
08947bc34e [maven-release-plugin] prepare release dspace-7.6.2 2024-07-09 14:10:01 -05:00
Tim Donohue
98c661d8d0 Update redeployment of demo.dspace.org to use dspace-8_x branch. 2024-07-09 13:43:15 -05:00
Tim Donohue
12c3cc5b3e Update LICENSES_THIRD_PARTY (and related configs) for 7.6.2 release 2024-07-09 13:35:16 -05:00
nwoodward
2cb8204d3c updated creative commons licenses version from 3.0 to 4.0 2024-07-08 12:33:07 -05:00
kshepherd
d47c00a24b Merge pull request #9599 from tdonohue/port_new_csrf_endpoint_to_7x
[Port dspace-7_x] Add a GET `/csrf` endpoint to allow for forcing refresh of CSRF token
2024-06-29 14:57:45 +02:00
Tim Donohue
324020ac81 Merge pull request #9651 from DSpace/backport-9638-to-dspace-7_x
[Port dspace-7_x] Update configuration to always download HTML/JS/XML Bitstreams (no inline display)
2024-06-17 09:23:22 -05:00
Tim Donohue
3bcd33d92a To avoid misconfiguration, hardcode HTML, XML, RDF, JS to download only. Add a new wildcard setting to allow sites to force all files to download only.
(cherry picked from commit a091d343b9)
2024-06-17 07:23:16 +00:00
Tim Donohue
c30ff35448 For additional security, ensure "unknown" formats are always downloaded. Update test to prove behavior.
(cherry picked from commit 6da072de9e)
2024-06-17 07:23:16 +00:00
Tim Donohue
7951c8e428 Add a test to prove the default settings are to always download these formats
(cherry picked from commit e6bfb833ee)
2024-06-17 07:23:16 +00:00
Tim Donohue
7ba150f4fc Add XML to the list of formats to always download
(cherry picked from commit 39975e45cf)
2024-06-17 07:23:16 +00:00
Tim Donohue
7143c97248 Fix failing IT by increasing number of formats by one
(cherry picked from commit c61b7033f2)
2024-06-17 07:23:16 +00:00
Tim Donohue
0f74cb22bf Avoid inline display of HTML/JS bitstreams. Add JS to list of known formats so that it can be recognized by DSpace.
(cherry picked from commit 356a028186)
2024-06-17 07:23:16 +00:00
Tim Donohue
0b67aa3070 Merge pull request #9649 from DSpace/backport-9509-to-dspace-7_x
[Port dspace-7_x] Fix bug where empty metadata List can result in "Index 0 out of bounds for length 0" exceptions in several scenarios
2024-06-14 11:53:31 -05:00
Tim Donohue
c890199cfe Add tests to verify behavior of addMetadata() when encountering virtual metadata
(cherry picked from commit 2eb7dbca6b)
2024-06-14 14:58:15 +00:00
Tim Donohue
872af33155 Fix bug in MetadataImport where it could call addMetadata() with empty values. Minor refactors to MetadataImportIT to make findItemByName more efficient.
(cherry picked from commit f8ac8edc49)
2024-06-14 14:58:15 +00:00
Tim Donohue
30dafa09d0 Fix testAddMetadata_5args_2 to no longer be *identical* to testAddMetadata_5args_1. It appears this second test was meant to test a different addMetadata() method which accepts a single Value instead of a List
(cherry picked from commit 25f722ed98)
2024-06-14 14:58:15 +00:00
Tim Donohue
8407c571db Throw IllegalArgumentException if addMetadata() called without values. Add unit tests to prove it works
(cherry picked from commit ed918a8d0c)
2024-06-14 14:58:15 +00:00
Tim Donohue
928dad1c5c Ensure List is not empty before returning first value
(cherry picked from commit 068bcdf3af)
2024-06-14 14:58:15 +00:00
Tim Donohue
370550c06b Merge pull request #9643 from DSpace/backport-9621-to-dspace-7_x
[Port dspace-7_x] Fixed item edit relationships with same type name but different entities all being shown under same label
2024-06-10 09:37:09 -05:00
Tim Donohue
2bf663e5a1 Merge pull request #9642 from DSpace/backport-9594-to-dspace-7_x
[Port dspace-7_x] Metadata Import via Scopus API: improved handling of empty search results
2024-06-07 15:52:26 -05:00
Alexandre Vryghem
7789304ebe 115434: Added test proving that different values for relatedEntityType return different results
(cherry picked from commit bbae1fb0d1)
2024-06-07 20:09:19 +00:00
Alexandre Vryghem
8d82457eb7 115434: Added relatedEntityType parameter to byLabel endpoint to differentiate relationships with same label and different entity types
(cherry picked from commit 8512fab392)
2024-06-07 20:09:19 +00:00
Sascha Szott
8e56fdd95b fixed failed test
(cherry picked from commit 6989cb6f15)
2024-06-07 19:59:21 +00:00
Sascha Szott
2b1270197e improve handling of 0 hits responses of Scopus API
(cherry picked from commit b12bd6ce56)
2024-06-07 19:59:21 +00:00
Sascha Szott
6e5c5089ab Update scopus-empty-resp.xml
(cherry picked from commit 4b2ea66f19)
2024-06-07 19:59:21 +00:00
Sascha Szott
26658b6665 evaluate surname and given-name if authname is not present
(cherry picked from commit 8b5f044537)
2024-06-07 19:59:21 +00:00
Tim Donohue
e8991992fc Merge pull request #9637 from DSpace/backport-9629-to-dspace-7_x
[Port dspace-7_x] Ensure work directory is cleaned up even when Zip export fails
2024-06-06 10:44:27 -05:00
Tim Donohue
95fc68b3ee Ensure work directory is cleaned up whether zip file is created successfully or an error occurs.
(cherry picked from commit b7f764746c)
2024-06-06 14:53:00 +00:00
Tim Donohue
1769f16d7a Merge pull request #9635 from DSpace/backport-9539-to-dspace-7_x
[Port dspace-7_x] Fixed too long classpath bug in test_databaseFixed classpath issue in test_database target
2024-06-05 15:27:53 -05:00
Jean-François Morin
4cd3b75e67 Fixed classpath issue in test_database target
(cherry picked from commit 6937c19973)
2024-06-05 19:14:17 +00:00
Tim Donohue
3ad22bf977 Merge pull request #9634 from tdonohue/port_9625_to_7x
[Port dspace-7_x] updates creativecommons.org links to https
2024-06-05 12:01:26 -05:00
nwoodward
c5d139c9e1 updates creativecommons.org links to https 2024-06-05 11:24:30 -05:00
Tim Donohue
a95ed84b75 Merge pull request #9632 from DSpace/backport-9605-to-dspace-7_x
[Port dspace-7_x] Fix for Bump org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1
2024-06-05 10:35:53 -05:00
Andrea Bollini
7fc74bdc56 DURACOM-267 assure that our custom DSpaceConfigurationPropertySource is used also for the spring context created by the DSpace kernel
(cherry picked from commit 4fcf995b69)
2024-06-05 14:38:44 +00:00
Andrea Bollini
b9e6af6758 DURACOM-267 improve handling of empty configuration property
(cherry picked from commit 0422b8786f)
2024-06-05 14:38:44 +00:00
Andrea Bollini
4b5248fe15 DURACOM-267 update commons-configuration2 fix according to the community feedback
(cherry picked from commit f2d4ffc49c)
2024-06-05 14:38:44 +00:00
Andrea Bollini
0d4d065d45 Create a temporary version of the ConfigurationPlaceholderConfigurer to overcome bu in 2.10
(cherry picked from commit d44d76ea03)
2024-06-05 14:38:44 +00:00
dependabot[bot]
fe76579d04 Bump org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1
Bumps org.apache.commons:commons-configuration2 from 2.9.0 to 2.10.1.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-configuration2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit df7220bd98)
2024-06-05 14:38:44 +00:00
Tim Donohue
6b23e6fac0 Merge pull request #9628 from DSpace/backport-9627-to-dspace-7_x
[Port dspace-7_x] Cleanup doi filters
2024-06-04 11:55:20 -05:00
Pascal-Nicolas Becker
2d150cb86c Cleanup doi filters
We can set filters in identifier-service.xml. Setting them in
modules/identifiers.cfg is just overidding the other one. To keep things
simple, we should avoid having two different filters for the same issue.
The filter configured in spring is working for any new DOI, while the
one we take out here, is just working for items being run through the
install item service.

(cherry picked from commit 59aaf3e57c)
2024-06-04 16:25:51 +00:00
Tim Donohue
1827b89937 Merge pull request #9626 from DSpace/backport-9619-to-dspace-7_x
[Port dspace-7_x] Remove the is-archived_condition from the doi-filter
2024-06-03 17:02:42 -05:00
Pascal-Nicolas Becker
b8a6711140 Remove the is_archived_condition from the doi-filter
In the conversation of #9271 kshepherd states that he had issues to
register DOIs when the doi-filter is usint the is_archived_condition. I
was able to reproduce these issues. This removes the reference to that
condition from the filter. The item is not archived when the
InstallItemService is trying to apply a DOI to it.

(cherry picked from commit 24da6fe769)
2024-06-03 21:24:15 +00:00
Tim Donohue
77827cdfaa Merge pull request #9624 from DSpace/backport-9618-to-dspace-7_x
[Port dspace-7_x] Update comments in identifier-service.xml
2024-06-03 12:04:20 -05:00
Pascal-Nicolas Becker
ac07f08497 Update comments in identifier-service.xml
The DOIIdentifierProvider using a filter was commented out twice. We
should show that it works with and without a filter. Furthermore one
comments looked cut off.

(cherry picked from commit 3dd49f4ac3)
2024-06-03 16:33:25 +00:00
Tim Donohue
0d014e5e9e Merge pull request #9617 from tdonohue/port_9273_to_7x
[Port dspace-7_x] MediaFilter over large repository result in downtime
2024-05-31 16:00:03 -05:00
Andrea Bollini
a09d46d8e4 DURACOM-225 fix lazy initialization traversing comms/colls 2024-05-31 14:30:11 -05:00
Andrea Bollini
88b44e9281 DURACOM-225 porting of the uuid iterator implementation from dspace-cris to retrie just the uuid from the database in the initial query 2024-05-31 14:30:04 -05:00
Andrea Bollini
86286474cc DURACOM-225 commit after each item to release DB resources 2024-05-31 14:29:59 -05:00
Andrea Bollini
96f490a3a0 DURACOM-225 add IT for the media filter script 2024-05-31 14:29:52 -05:00
Tim Donohue
4651ba8797 Merge pull request #9614 from DSpace/backport-9576-to-dspace-7_x
[Port dspace-7_x] Remove old UI references from OpenSearch / RSS feeds
2024-05-29 16:54:10 -05:00
Tim Donohue
fcbf8b80e3 Merge pull request #9609 from tdonohue/port_9583_to_7x
[dspace-7_x] Fix Item Counts (webui.strengths) by refactoring ItemCounter and ItemCountDAO to act like other Spring beans
2024-05-29 16:42:12 -05:00
Tim Donohue
3e831123b7 Add a basic test that refactoring of code results in correct logo URLs. Also enable/fix a test for special characters.
(cherry picked from commit 8c22915adf)
2024-05-29 20:56:51 +00:00
Tim Donohue
3b1cf3e35e Remove references to UI type from OpenSearch / RSS feeds
(cherry picked from commit 47b79bb2cb)
2024-05-29 20:56:51 +00:00
damian
ab0b80e57a Merge remote-tracking branch 'origin/refactor_item_counter' into refactor_item_counter 2024-05-24 16:50:51 -05:00
damian
a5901af564 Level up counting items methods - both now use the same flags from Item model (discoverable, archived, withdrawn) 2024-05-24 16:48:56 -05:00
damian
8ae9f9f251 Check withdrawn flag at item count method 2024-05-24 16:44:05 -05:00
Tim Donohue
be4dfeb140 Refactor ItemCounter and ItemCountDAO to act like other DSpace beans. Also ensure they do not cache a Context object. 2024-05-24 16:43:49 -05:00
Tim Donohue
eb9f63ab95 DSpace 7 requires using jvax not jakarta 2024-05-17 09:17:33 -05:00
Tim Donohue
fabd60db43 Update test to prove CSRF token changes for every GET request to endpoint 2024-05-16 16:46:44 -05:00
Tim Donohue
a6c369686d Add a GET /csrf endpoint to allow for forcing refresh of CSRF token 2024-05-16 16:39:17 -05:00
Tim Donohue
b3a4571d4c Merge pull request #9596 from paulo-graca/bugfixes/issue-7464
Fixing issue #7464 for DSpace 7
2024-05-16 13:13:23 -05:00
Paulo Graça
11062ae869 Fixing issue #7464 for DSpace 7 2024-05-16 17:03:25 +01:00
Tim Donohue
598fb1831f Merge pull request #9484 from 4Science/s3lazy_7x
Porting of Improve S3 Bitstream Storage to Lazy download object from S3 to 7_x
2024-05-16 10:59:23 -05:00
Tim Donohue
94965116ee Merge pull request #9590 from DSpace/backport-9588-to-dspace-7_x
[Port dspace-7_x] I18nUtil: reduce log level error to info or warn
2024-05-16 08:37:13 -05:00
Tim Donohue
c875f1c8e1 Merge pull request #9591 from DSpace/backport-9580-to-dspace-7_x
[Port dspace-7_x] improve interoperability: replace hard-coded slash by File.separator
2024-05-16 08:36:48 -05:00
Sascha Szott
f7a5c7375a replaced slash by File.separator
(cherry picked from commit 3e23fea0b8)
2024-05-15 21:59:43 +00:00
Sascha Szott
caf0671ce2 reduce log level error to info or warn
(cherry picked from commit bc4c6742d3)
2024-05-15 21:51:40 +00:00
Tim Donohue
5f29b52e4e Merge pull request #9586 from DSpace/backport-9582-to-dspace-7_x
[Port dspace-7_x] Add additional DOI prefixes
2024-05-15 13:36:06 -05:00
max.nuding
1d6ab238c0 Add additional DOI prefixes
(cherry picked from commit ba4edeed15)
2024-05-15 17:58:05 +00:00
Tim Donohue
33b6b4ba09 Merge pull request #9578 from DSpace/backport-9577-to-dspace-7_x
[Port dspace-7_x] Fix broken ITs after merger of #9485
2024-05-13 17:27:48 -05:00
Tim Donohue
fd755bf810 Merge pull request #9575 from DSpace/backport-9485-to-dspace-7_x
[Port dspace-7_x] Fix person lookup on project submission #2959
2024-05-13 17:27:18 -05:00
Tim Donohue
ed9ff262d6 Fix broken ITs after merger of #9485
(cherry picked from commit 16343d68bf)
2024-05-13 22:23:38 +00:00
Eike Martin Löhden
b0995cdf6c Set correct metadata field for virtual metadata of persons in projects.
(cherry picked from commit ff7d96b82c)
2024-05-13 19:27:54 +00:00
Eike Martin Löhden
2309496f67 Correct relationship direction for persons in the project submission step.
(cherry picked from commit ee2abfaf88)
2024-05-13 19:27:54 +00:00
Tim Donohue
d99ad4736e Merge pull request #9574 from tdonohue/port_9573_to_7x
[Port dspace-7_x] remove outdated comment as RSS feeds are supported in DS 7.3+
2024-05-13 10:03:35 -05:00
Sascha Szott
1128b0eb10 remove outdated comment as RSS feeds are supported in DS 7.3+ 2024-05-13 10:01:59 -05:00
Tim Donohue
71b8f1d3b2 Merge pull request #9571 from DSpace/backport-9400-to-dspace-7_x
[Port dspace-7_x] fix datacite import recordscount and pagination options
2024-05-10 16:57:09 -05:00
Gantner, Florian Klaus
17c68323db avoid empty data to create phantom records for datacite import
(cherry picked from commit 9667a3374d)
2024-05-10 21:29:16 +00:00
Gantner, Florian Klaus
e35f859e06 datacite api test for no results count
(cherry picked from commit 9cd1a1093d)
2024-05-10 21:29:16 +00:00
Gantner, Florian Klaus
d14f113024 use datacite api response for recordscount and paginated calls. update test file for response as expected from the api.
(cherry picked from commit 65ac01a4a6)
2024-05-10 21:29:16 +00:00
Tim Donohue
132bf49397 Merge pull request #9570 from DSpace/backport-9569-to-dspace-7_x
[Port dspace-7_x] potential array index out of bounds access in SubscriptionDsoMetadataForEmailCompose
2024-05-10 11:53:05 -05:00
Sascha Szott
2976ae3971 bugfix: array index can be out of bound
(cherry picked from commit 4fc6b07466)
2024-05-10 16:21:44 +00:00
Tim Donohue
2481a6f700 Merge pull request #9567 from DSpace/backport-9566-to-dspace-7_x
[Port dspace-7_x] Remove not unique id from inner beans to avoid xml validation issues
2024-05-09 13:02:39 -05:00
Andrea Bollini
ca27ea5fc2 Remove not unique id from inner beans to avoid xml validation issues
(cherry picked from commit 844b73ff49)
2024-05-09 16:31:04 +00:00
Tim Donohue
d71350da4e Merge pull request #9565 from DSpace/backport-9433-to-dspace-7_x
[Port dspace-7_x] Restore batch templates mail
2024-05-09 11:28:21 -05:00
Roy Bruschini
d90cf24a21 Fix typo
(cherry picked from commit 74c15e8d55)
2024-05-09 15:42:55 +00:00
Roy Bruschini
31020d1d4f Create templates mail and renamed name in getEmailFileName
(cherry picked from commit 7a637e6871)
2024-05-09 15:42:55 +00:00
Tim Donohue
ead90b6bbf Merge pull request #9455 from paulo-graca/organisation2organization
Replace organisation->organization
2024-05-09 10:12:15 -05:00
Paulo Graça
2fdc422b24 change IT from organisation to organization 2024-05-09 14:39:51 +01:00
Tim Donohue
2219ca80f0 Merge pull request #9557 from DSpace/backport-9555-to-dspace-7_x
[Port dspace-7_x] Updated CheckStyle to support newer Java features while not changing anything else
2024-05-08 16:49:58 -05:00
Tim Donohue
ebff350216 Merge pull request #9432 from DSpace/bugfix-9425
adding Unicode filtering for sorts
2024-05-08 16:22:21 -05:00
Jean-François Morin
532e21ffb9 Updated CheckStyle so that new Java features such as string blocks are supported, but without requiring to change anything else
(cherry picked from commit ef8c621a0f)
2024-05-08 21:01:06 +00:00
Tim Donohue
44090605b0 Merge pull request #9556 from DSpace/backport-9410-to-dspace-7_x
[Port dspace-7_x] Fix OAIHarvester#extractHandle not handling config properly
2024-05-08 15:17:52 -05:00
Tim Donohue
a4a09209f8 Merge pull request #9554 from DSpace/backport-9551-to-dspace-7_x
[Port dspace-7_x] Ensure Process `user_id` is nullified when referenced EPerson is deleted
2024-05-08 14:45:16 -05:00
Nona Luypaert
1b091a033e Fix OAIHarvester#extractHandle not handling config properly
- defaults for oai.harvester.acceptedHandleServer and oai.harvester.rejectedHandlePrefix are now set
- rejected handles no longer pass if multiple prefixes were configured for oai.harvester.rejectedHandlePrefix

(cherry picked from commit 862a6c5be6)
2024-05-08 19:44:05 +00:00
Tim Donohue
448a69483b Fix NullPointerException. Only return userid if EPerson not null
(cherry picked from commit f34c592352)
2024-05-08 19:07:01 +00:00
Tim Donohue
606b10ccb7 Add migration to set user_id to null if EPerson no longer exists & enforce it for future
(cherry picked from commit ef24645cbf)
2024-05-08 19:07:01 +00:00
Tim Donohue
c0b36a9e9c Merge pull request #9549 from DSpace/backport-9548-to-dspace-7_x
[Port dspace-7_x] Ensure potentially large Solr query uses POST, not GET
2024-05-07 09:36:19 -05:00
Tim Donohue
dbf063dfb9 Ensure potentially large Solr query uses POST, not GET
(cherry picked from commit 0a21a11c9a)
2024-05-07 14:09:09 +00:00
Tim Donohue
28bb6c7e95 Merge pull request #9547 from tdonohue/port_9542_to_7x
Upgrade Tika and bcprov-jdk18on to latest versions
2024-05-06 11:16:04 -05:00
Tim Donohue
03f8a0c56d Merge pull request #9507 from atmire/w2p-105866_Submission-performance-7_x
7.x - Submission performance
2024-05-06 11:11:21 -05:00
Tim Donohue
e22f9a211f Upgrade Tika and bcprov-jdk18on to latest versions. Synced other dependencies with versions used on main (where possible to do so) 2024-05-06 10:09:23 -05:00
Tim Donohue
7a9c8c1ea3 Merge pull request #9538 from DSpace/backport-9453-to-dspace-7_x
[Port dspace-7_x] DS-9452: Updates query to get collections referenced in the subscribers table
2024-05-03 16:12:42 -05:00
Tim Donohue
a2b9bf256f Merge pull request #9482 from dsteelma-umd/opensearch_npe_fix_for_valid_unknown_uuids
Fix OpenSearch NullPointerException for "scope" UUID that is not a community or collection
2024-05-03 15:46:09 -05:00
Tim Donohue
2754549156 Merge pull request #9541 from DSpace/backport-9386-to-dspace-7_x
[Port dspace-7_x] CrossRef metadata import: improve handling of JATS markup in CrossRef JSON response
2024-05-03 15:23:55 -05:00
Tim Donohue
6b3e3cf044 Merge pull request #9540 from DSpace/backport-9385-to-dspace-7_x
[Port dspace-7_x] CrossRef metadata import: trim trailing whitespaces in search query
2024-05-03 14:47:42 -05:00
Sascha Szott
263b45046c sort imports lexicographically
(cherry picked from commit 2867b36ebb)
2024-05-03 19:47:30 +00:00
Sascha Szott
71798f0f74 fix code style violations
(cherry picked from commit 23b8b696a0)
2024-05-03 19:47:30 +00:00
Sascha Szott
6b57079569 add header in class file
(cherry picked from commit b772004397)
2024-05-03 19:47:30 +00:00
Sascha Szott
a000f1430a add CrossRefAbstractProcessor
(cherry picked from commit fa3f10e0b6)
2024-05-03 19:47:29 +00:00
Sascha Szott
1606862aa3 add processor to handle CrossRef abstracts
(cherry picked from commit 498d137970)
2024-05-03 19:47:29 +00:00
Sascha Szott
cef170ad12 extend trimming
(cherry picked from commit 2c6f43d48f)
2024-05-03 19:21:05 +00:00
Sascha Szott
4d54f74ae1 trim trailing whitespaces in search query
(cherry picked from commit 43e2a1d402)
2024-05-03 19:21:05 +00:00
nwoodward
1da7c6b933 make sure collections list is unique
(cherry picked from commit d27331a0b3)
2024-05-03 17:31:19 +00:00
nwoodward
d6f6444f58 updated query to get collections referenced in the subscribers table
(cherry picked from commit c5989c65bb)
2024-05-03 17:31:19 +00:00
Tim Donohue
8205c07586 Merge pull request #9537 from DSpace/backport-9436-to-dspace-7_x
[Port dspace-7_x] Issue-9435
2024-05-03 11:30:30 -05:00
Xiqinger
1920101273 avoid outputStream write after close
(cherry picked from commit 214568d480)
2024-05-03 16:00:42 +00:00
Xiqinger
cbfe0beede Add empty check before call iterator().next()
(cherry picked from commit b2663c810c)
2024-05-03 16:00:42 +00:00
Xiqinger
24f2bca4b3 check path before mkdirs
(cherry picked from commit fda62bc101)
2024-05-03 16:00:41 +00:00
Tim Donohue
5b89effeb9 Merge pull request #9191 from atmire/w2p-106812_enforce-resource-policies-to-have-group-or-eperson
[Port to dspace-7_x] Enforce resource policies to have group or eperson
2024-05-03 10:16:02 -05:00
Kristof De Langhe
ce9129c961 105866: Remove commented code 2024-05-03 14:20:58 +02:00
Yana De Pauw
ce869e55d0 Merge remote-tracking branch 'upstream/dspace-7_x' into w2p-106812_enforce-resource-policies-to-have-group-or-eperson 2024-05-03 14:07:25 +02:00
Tim Donohue
d935ab26d7 Merge pull request #9487 from toniprieto/form-by-entity-type-with-map-v7
[Port dspace-7_x] Refactor SubmissionConfigReader to use a map for the item process configurations based on entityType
2024-05-02 11:01:20 -05:00
Tim Donohue
15fa850bcb Merge pull request #9531 from DSpace/backport-9358-to-dspace-7_x
[Port dspace-7_x] PreloadLevel config vocabulary issue
2024-05-02 08:33:46 -05:00
Tim Donohue
930e63f01a Merge pull request #9532 from DSpace/backport-9429-to-dspace-7_x
[Port dspace-7_x] Fix packager NPE if using the passwords=true option
2024-05-02 08:33:33 -05:00
Agustina Martinez
62b42ff2d1 Update RoleDisseminator.java
Fix NPE if empty password hash string

(cherry picked from commit 04824a2e98)
2024-05-01 21:49:13 +00:00
Marie Verdonck
097d253063 Make sure vocab init is run for vocabulary returned in /api/submission/vocabularies
(cherry picked from commit 42437dd65b)
2024-05-01 21:28:25 +00:00
Tim Donohue
5626fa1adc Merge pull request #9528 from DSpace/backport-9523-to-dspace-7_x
[Port dspace-7_x] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 in /dspace-api
2024-05-01 15:08:00 -05:00
dependabot[bot]
08c46bd0a1 Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 in /dspace-api
Bumps [org.xmlunit:xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/xmlunit/xmlunit/releases)
- [Changelog](https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md)
- [Commits](https://github.com/xmlunit/xmlunit/compare/v2.9.1...v2.10.0)

---
updated-dependencies:
- dependency-name: org.xmlunit:xmlunit-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 1fdc3ce220)
2024-05-01 19:37:54 +00:00
Tim Donohue
25108cb9a1 Merge pull request #9387 from MW3000/fix-9383-email-subject-for-request-a-copy
Fix #9383: Set email subject for request copy form
2024-05-01 14:27:35 -05:00
Tim Donohue
d96916c19b Merge pull request #9526 from DSpace/backport-9522-to-dspace-7_x
[Port dspace-7_x] Remove obsolete "version" tag from Docker Compose files
2024-05-01 14:14:06 -05:00
Tim Donohue
0c7a41e47c Merge pull request #9524 from tdonohue/update_spring
[dspace-7_x] Minor update to latest Spring version
2024-05-01 13:20:24 -05:00
Tim Donohue
c030bcfa5a Merge pull request #9525 from DSpace/backport-9521-to-dspace-7_x
[Port dspace-7_x] Install unzip util in built dspace-cli image
2024-05-01 13:11:03 -05:00
Tim Donohue
e1dc695102 Remove obsolete "version" tag from compose files
(cherry picked from commit 9ca0ad5579)
2024-05-01 17:18:01 +00:00
John Abrahams
735906c429 Install unzip util in final built image
(cherry picked from commit 3eae430bec)
2024-05-01 16:56:22 +00:00
Tim Donohue
a97d72f993 Minor update to latest Spring version 2024-05-01 11:50:22 -05:00
Tim Donohue
6024a42448 Merge pull request #9520 from DSpace/backport-9296-to-dspace-7_x
[Port dspace-7_x] Fix resource policy type not set for bitstreams when importing items
2024-05-01 11:38:21 -05:00
Agustina Martinez
30e3cde30d Update ItemImportServiceImpl.java
expand setPermission to take the rpType string

(cherry picked from commit 679df52bbd)
2024-05-01 14:54:23 +00:00
Tim Donohue
aafc111c98 Merge pull request #9518 from DSpace/backport-9289-to-dspace-7_x
[Port dspace-7_x] Validation of page url in FeedbackRestRepository
2024-04-30 13:42:32 -05:00
Sascha Szott
0cfe4aec73 allow empty feedback page url
(cherry picked from commit c4cc56a429)
2024-04-30 17:40:22 +00:00
Sascha Szott
f9d3efd1e7 added validation of page url
(cherry picked from commit 771f37a1fa)
2024-04-30 17:40:22 +00:00
Tim Donohue
4636410894 Merge pull request #9516 from DSpace/backport-9515-to-dspace-7_x
[Port dspace-7_x] Fix SWORDv2 Deletion for Workflow / Archived Items
2024-04-30 11:27:28 -05:00
Tim Donohue
67d7c0bf3b Fix deletion by only cleaning up wrapper for Workspace/workflow items
(cherry picked from commit 5c13569d0f)
2024-04-30 16:00:25 +00:00
Tim Donohue
07377d12c8 Add ITs which test SWORD deletion for workspace vs workflow items (we already have a test for archived items)
(cherry picked from commit 70b0a28749)
2024-04-30 16:00:25 +00:00
Tim Donohue
0434cd9c92 Merge pull request #9513 from DSpace/backport-9285-to-dspace-7_x
[Port dspace-7_x] Fix deleting workspace items via SWORDv2 endpoint
2024-04-30 10:59:12 -05:00
Yana De Pauw
435988ca00 Swap the delete and constraint db lines 2024-04-30 16:40:47 +02:00
Tim Donohue
74c43d4027 Merge pull request #9512 from DSpace/backport-9229-to-dspace-7_x
[Port dspace-7_x] [DS-3439] Copy collection template item specified metadata during …
2024-04-29 17:09:36 -05:00
Agustina Martinez
849a252fa8 Update ContainerManagerDSpace.java
Remove duplicate item.delete call that causes hibernate errors as item is already deleted

(cherry picked from commit 57032050b9)
2024-04-29 22:02:08 +00:00
haoueclf
2f99646417 [DS-3439] Copy collection template item specified metadata during Sword v2 METS deposit ingestion.
(cherry picked from commit 7ead4ae7f0)
2024-04-29 21:42:21 +00:00
DSpace Bot
75c688daef [Port dspace-7_x] Drop not null for EPerson in Process table (#9510)
* Set EPerson nullable in ProcessTable

(cherry picked from commit 9ed997d2dd)

* chore: Remove nullable = false in EPerson Entity

(cherry picked from commit f1a38c2485)

* chore: Avoid NPE when getEPerson is called

(cherry picked from commit 2f9ad72298)

* test: Add test for insert nullable EPerson in Process' table

(cherry picked from commit 8fe264ee69)

* Revert "Set EPerson nullable in ProcessTable"

This reverts commit aea7b9385b6c6972b0ac27e061d082bb92eaf4a6.

(cherry picked from commit 7de931c7be)

* feat: Drop NOT NULL for user_id in Process table

(cherry picked from commit 3b73786c55)

* chore: add endline

(cherry picked from commit 27ed14c38c)

* fix: add headers file

(cherry picked from commit a3ea7cbaaa)

* Rename file sql

(cherry picked from commit eb22285924)

* Rename sql script to 7.6.x

(cherry picked from commit d2ef87eab6)

* fix: Set fetch lazy in EPerson Process

(cherry picked from commit d6340403ff)

* fix: set the user attached to a process to null if none is found in the DB

(cherry picked from commit afb734df5f)

---------

Co-authored-by: Roy Bruschini <r.bruschini@key2.it>
Co-authored-by: Jens Vannerum <jens.vannerum@atmire.com>
2024-04-29 14:31:20 -05:00
Kristof De Langhe
d139d06c58 105866: test fixes 2024-04-29 12:58:20 +02:00
Yana De Pauw
9d12600d13 [Ticket 2124] Slow response times 2024-04-26 17:09:00 +02:00
Toni Prieto
10aa318919 Add comment to clarify in which use case the consumer submissionconfig is useful 2024-04-26 14:50:30 +02:00
Toni Prieto
1cfa041a31 Remove unused function findAllCollectionsByEntityType of CollectionService 2024-04-26 14:50:17 +02:00
Tim Donohue
9c0281018c Merge pull request #9500 from DSpace/backport-9406-to-dspace-7_x
[Port dspace-7_x] Change from openjdk to eclipse-temurin base images
2024-04-24 14:00:05 -05:00
Thomas Misilo
362c80136b Change from openjdk to eclipse-temurin base images
Since the opendjk image has been deprecated, it was suggested to change to eclipse-temurin

Fixes #9277

(cherry picked from commit 86ca5aabf9)
2024-04-24 18:23:29 +00:00
Yana De Pauw
80a7e48536 Merge remote-tracking branch 'upstream/dspace-7_x' into w2p-106812_enforce-resource-policies-to-have-group-or-eperson 2024-04-24 17:06:14 +02:00
Tim Donohue
13d2a96443 Merge pull request #9494 from DSpace/backport-9492-to-dspace-7_x
[Port dspace-7_x] Remove unnecessary "exit" statements which stop running Postgres container
2024-04-22 15:53:23 -05:00
Tim Donohue
b1fb884aec Remove unnecessary "exit" statements which stop running container
(cherry picked from commit 11158ae525)
2024-04-22 20:03:02 +00:00
Tim Donohue
6755b0e77f Merge pull request #9491 from tdonohue/docker_fixes_7x
Fixes to Docker scripts for DSpace 7.x
2024-04-22 11:24:43 -05:00
Tim Donohue
69f7f85def Minor fixes to DB scripts. Use Postgres 15. Don't error out if pgcrypto already installed. 2024-04-22 10:50:21 -05:00
Tim Donohue
d5e2c71da4 Minor fixes to Entities import. MUST run "ignored" migrations. Also modifying submission configs no longer needed 2024-04-22 10:50:15 -05:00
Toni Prieto
770b38c793 Add test for item process submission forms mapped by entityType 2024-04-19 22:35:55 +02:00
Toni Prieto
1a65dfb15b Remove the consumer submissionconfig from default configuration because it is not needed to reload forms if a collection entitytype is changed 2024-04-19 21:39:19 +02:00
Toni Prieto
cf6008271a Refactor SubmissionConfigReader to use a map for the collections configured through the entityType value 2024-04-19 21:38:31 +02:00
Toni Prieto
15d9d1c042 Port from #9259 the changes to use a collection object to return the item process submission configured 2024-04-19 21:03:45 +02:00
Andrea Bollini
23ee2fd6cd DURACOM-249 fix checkstyle issues, add javadoc 2024-04-19 07:58:01 +02:00
Andrea Bollini
e82b94fa43 Add support for LazyDownload of files from S3 2024-04-19 07:58:01 +02:00
David P. Steelman
9b47b2215c Fix OpenSearch NullPointerException for unknown valid UUIDs in scope
Fixes a NullPointerException when the "scope" parameter provided to
the OpenSearch endpoint is a valid UUID, but is not a UUID associated
with a Community or Collection.

Instead of throwing a NullPointerException, this change modifies the
code to return a null scope (resulting in an "unscoped" OpenSearch
request), which is the same behavior that occurs when the UUID
is invalid, or otherwise not usable.
2024-04-17 13:55:34 -04:00
Tim Donohue
15e246ae88 Merge pull request #9474 from DSpace/backport-9473-to-dspace-7_x
[Port dspace-7_x] Add Space in ePerson's Name in Rejection Emails and Metadata
2024-04-12 16:11:48 -05:00
Tom Misilo
8d45c1f94d Add Space in ePerson's Name for rejection metadata and email
(cherry picked from commit ec3089dc4d)
2024-04-12 21:04:37 +00:00
Tim Donohue
3160e42ff9 Merge pull request #9465 from DSpace/backport-9344-to-dspace-7_x
[Port dspace-7_x] httpd-shibd-foreground.sh needs to be executable
2024-04-10 15:13:44 -05:00
Thomas Misilo
2f7ee4bc76 httpd-shibd-foreground.sh needs to be executable
In order for the shib container to start, the file that is running needs to be executable

(cherry picked from commit 3f9274f23f)
2024-04-10 19:46:21 +00:00
Tim Donohue
68bb3c5583 Merge pull request #9269 from atmire/w2p-90830-104654_issue-8125_pr-8267_Issue-stale-record-cleanup-7.x
7.x - Issue predb status cleanup
2024-04-10 12:57:07 -05:00
Tim Donohue
2afc9b158e Docker build IDs must all be unique to avoid image conflicts. Avoid conflict with "-loadsql" build by appending "-prod" on main build id. 2024-04-10 09:27:46 -05:00
Tim Donohue
7c505e113e Docker build IDs must all be unique to avoid image conflicts. Ensure no builds use a generic name like "dspace". 2024-04-09 15:04:46 -05:00
Tim Donohue
92c71df5a4 Merge pull request #9463 from DSpace/backport-9462-to-dspace-7_x
[Port dspace-7_x] Refactor SubmissionConfigConsumer to avoid reload the submission config multiple times
2024-04-09 14:26:27 -05:00
Toni Prieto
e22bf93a97 Refactor SubmissionConfigConsumer to avoid reload the submission config multiple times during the creation of a collection
(cherry picked from commit 00d0a01e1f)
2024-04-09 19:21:52 +00:00
Tim Donohue
49e54eb34f Ensure build digest name does NOT have slashes by changing arch to use dashes 2024-04-09 12:37:50 -05:00
Tim Donohue
cae7eeaee9 Merge pull request #9461 from DSpace/backport-9460-to-dspace-7_x
[Port dspace-7_x] Fix bug in Docker `amd64` build in GitHub Actions
2024-04-09 11:55:49 -05:00
Tim Donohue
a1d7c47f1e Fix Docker build by ensuring all artifacts are named with architecture (amd64 vs arm64)
(cherry picked from commit f4edf92860)
2024-04-09 16:53:46 +00:00
Tim Donohue
51c43602ef Merge pull request #9459 from tdonohue/port_9454_to_7x
[Port dspace-7_x] Update all GitHub Actions & add token for Codecov.io
2024-04-09 09:54:55 -05:00
Tim Donohue
5aa32dfd5a Update all GitHub Actions. Add newly required CODECOV_TOKEN to codecov action 2024-04-08 17:06:08 -05:00
Paulo Graça
9779c175db Replace organisation->organization 2024-04-08 16:44:43 +01:00
Tim Donohue
a6dd759ee6 Merge pull request #9448 from DSpace/backport-9271-to-dspace-7_x
[Port dspace-7_x] Fix generating versioned identifiers if pre-registration is enabled
2024-04-04 14:42:36 -05:00
Agustina Martinez
acfe272fbc Fix generating versioned identifiers if pre-registration is enabled
(cherry picked from commit 1844fd28a0)
2024-04-04 19:02:43 +00:00
Paulo Graça
48079d70a9 adding Unicode filtering for sorts 2024-03-22 12:19:43 +00:00
Alan Orth
a75717fc08 Merge pull request #9423 from DSpace/backport-9409-to-dspace-7_x
[Port dspace-7_x] Bump org.apache.solr:solr-solrj from 8.11.2 to 8.11.3
2024-03-20 10:27:59 +03:00
dependabot[bot]
3817f3ff9d Bump org.apache.solr:solr-solrj from 8.11.2 to 8.11.3
Bumps org.apache.solr:solr-solrj from 8.11.2 to 8.11.3.

---
updated-dependencies:
- dependency-name: org.apache.solr:solr-solrj
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit e934557966)
2024-03-20 06:59:09 +00:00
Alan Orth
889f3997bd Merge pull request #9422 from saschaszott/patch-30
dependency update: Spring Framework v5.3.32 → v5.3.33
2024-03-20 08:15:33 +03:00
Sascha Szott
78d8e86369 upgrade to Spring Framework v5.3.33 2024-03-19 15:18:28 +01:00
Martin Walk
b36613951b Fix #9383: Set email subject for request copy form 2024-02-29 15:21:15 +01:00
Tim Donohue
f46f49a3cc Merge pull request #9380 from DSpace/backport-9363-to-dspace-7_x
[Port dspace-7_x] Bump org.eclipse.jetty.http2:http2-common from 9.4.53.v20231009 to 9.4.54.v20240208
2024-02-28 13:48:27 -06:00
Tim Donohue
10eb906099 Merge pull request #9379 from DSpace/backport-9350-to-dspace-7_x
[Port dspace-7_x] Bump org.postgresql:postgresql from 42.6.0 to 42.7.2
2024-02-28 13:20:21 -06:00
dependabot[bot]
678aa9bad5 Bump org.eclipse.jetty.http2:http2-common
Bumps org.eclipse.jetty.http2:http2-common from 9.4.53.v20231009 to 9.4.54.v20240208.

---
updated-dependencies:
- dependency-name: org.eclipse.jetty.http2:http2-common
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit a6e3d7a55a)
2024-02-28 18:48:28 +00:00
Tim Donohue
6dc3936acb Merge pull request #9377 from DSpace/backport-9370-to-dspace-7_x
[Port dspace-7_x] Bump org.apache.james:apache-mime4j-core from 0.8.9 to 0.8.10
2024-02-28 12:35:00 -06:00
dependabot[bot]
ae2ee43df8 Bump org.postgresql:postgresql from 42.6.0 to 42.7.2
Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.6.0 to 42.7.2.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/commits)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 0b2b81682a)
2024-02-28 18:34:00 +00:00
Tim Donohue
b17596c7b3 Merge pull request #9376 from DSpace/backport-9371-to-dspace-7_x
[Port dspace-7_x] Update to latest Spring 5
2024-02-28 12:15:08 -06:00
dependabot[bot]
e28a083ef7 Bump org.apache.james:apache-mime4j-core from 0.8.9 to 0.8.10
Bumps org.apache.james:apache-mime4j-core from 0.8.9 to 0.8.10.

---
updated-dependencies:
- dependency-name: org.apache.james:apache-mime4j-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 7f91661f84)
2024-02-28 17:57:52 +00:00
Tim Donohue
26a683f4d5 Update to latest Spring 5
(cherry picked from commit 8252d05ee2)
2024-02-28 17:39:01 +00:00
kshepherd
0ef8094b07 Merge pull request #9367 from DSpace/backport-9266-to-dspace-7_x
[Port dspace-7_x] S3store is always enabled
2024-02-27 17:15:08 +13:00
frabacche
54f816e08c DURACOM-211 s3bitstoreService IT class fix
(cherry picked from commit 2beb604255)
2024-02-27 03:40:14 +00:00
frabacche
44bf7bfdb3 DURACOM-211 S3store enabling checkstyle
(cherry picked from commit 584d178a95)
2024-02-27 03:40:14 +00:00
frabacche
df66f8401d DURACOM-211 S3store enabling according to assetstore.s3.enabled config
(cherry picked from commit 772eaa7666)
2024-02-27 03:40:14 +00:00
kshepherd
e0974b9469 Merge pull request #9366 from DSpace/backport-8986-to-dspace-7_x
[Port dspace-7_x] fix: add default HandleIdentifierProvider for disabled versioning
2024-02-27 16:04:31 +13:00
Mirko Scherf
4e721bfbb0 fix: add default HandleIdentifierProvider for disabled versioning
Setting versioning.enabled = false in versioning.cfg is not enough to
disable versioning. It is also required to replace the bean class
VersionedHandleIdentifierProvider with a HandleIdentifierProvider
in identifier-service.xml. I've added one that is commented out as by
default versioning is enabled.

(cherry picked from commit 92c38de99e)
2024-02-27 02:33:26 +00:00
kshepherd
fb76988909 Merge pull request #9334 from atmire/sword-configuration-old-style-fixes-7.x
Sword configuration old style fixes 7.x
2024-02-27 14:59:37 +13:00
Tim Donohue
b1f2d5f487 Merge pull request #9364 from DSpace/backport-9336-to-dspace-7_x
[Port dspace-7_x] Add more SWORDv2 Integration Tests
2024-02-26 17:15:41 -06:00
Tim Donohue
2c57c68a81 Add more ITs to SWORDv2 to verify basic upload, edit, delete functionality. These all pass prior to any SWORDv2 refactoring
(cherry picked from commit eeee029510)
2024-02-26 22:43:34 +00:00
Tim Donohue
99aec7fffa Merge pull request #9356 from DSpace/backport-9339-to-dspace-7_x
[Port dspace-7_x] Update of DataCite crosswalk to metadata schema 4.5
2024-02-22 11:32:10 -06:00
Pascal-Nicolas Becker
ab56ad09ab Changing a comment on DIM2DataCite.xsl
(cherry picked from commit 1a567827df)
2024-02-22 16:05:55 +00:00
Yannick Paulsen
61053cab8d Update of DataCite crosswalk to metadata schema 4.5
(cherry picked from commit 5db110a19f)
2024-02-22 16:05:55 +00:00
Alan Orth
1716d5a15b Merge pull request #9353 from DSpace/backport-9320-to-dspace-7_x
[Port dspace-7_x] Community/Collection admins can't edit logo for communities/collections
2024-02-22 16:26:19 +03:00
eskander
d172865f52 [DURACOM-232] solved Community/Collection admins can't edit logo for communities/collections
(cherry picked from commit d1812866a6)
2024-02-22 12:57:22 +00:00
Yana De Pauw
dddd500bd1 106812: Add flyway migration to remove faulty rp entries 2024-02-19 10:06:33 +01:00
Tim Donohue
80368e1467 Merge pull request #9347 from DSpace/backport-9346-to-dspace-7_x
[Port dspace-7_x] [DS-9345] Correct the package name of the IIIF search plugin
2024-02-16 11:09:41 -06:00
haoueclf
adec8e2e60 [DS-9345] Correct the package name of the IIIF search plugin
(cherry picked from commit 03fe586681)
2024-02-16 17:08:38 +00:00
Tim Donohue
9d2daafd79 Merge pull request #9337 from DSpace/backport-9263-to-dspace-7_x
[Port dspace-7_x] Repository indexing fails when item tika fulltext processing fails with error
2024-02-15 16:59:57 -06:00
mohamed eskander
14f593e097 [DURACOM-143] Fix license
(cherry picked from commit 324d2e3184)
2024-02-15 22:32:50 +00:00
mohamed eskander
b97b093d6c [DURACOM-143] Fix indexing errors & further improvements
(cherry picked from commit d645939baf)
2024-02-15 22:32:50 +00:00
Marie Verdonck
16d44370f1 Merge remote-tracking branch 'origin/dspace-7_x' into sword-configuration-old-style-fixes-7.x 2024-02-15 18:37:58 +01:00
Marie Verdonck
2cbcf9006d SWORD config fixes: Instances where old style module/fileName, configName params are used from long-deprecated ConfigurationManager instead of configName, defaultValue 2024-02-15 18:36:45 +01:00
Marie Verdonck
124a05b16f Merge remote-tracking branch 'atmire/w2p-111719_sword-embargo-bugfix' into sword-configuration-old-style-fixes-7.6 2024-02-15 18:32:11 +01:00
Yana De Pauw
4942fd272c 106812: Fix compile issue due to new test 2024-02-15 10:31:04 +01:00
Yana De Pauw
24cd78469c Merge remote-tracking branch 'upstream/dspace-7_x' into w2p-106812_enforce-resource-policies-to-have-group-or-eperson 2024-02-15 10:08:39 +01:00
Tim Donohue
b60d66d508 Merge pull request #9325 from DSpace/backport-8896-to-dspace-7_x
[Port dspace-7_x] Fast fail error when creating administrator, if there is no database connection
2024-02-13 09:27:07 -06:00
MajoBerger
09357b133e added failsafe while creating admin when db is not connected
(cherry picked from commit efcf9dba20)
2024-02-12 22:51:11 +00:00
Tim Donohue
6f380ec011 Merge pull request #9310 from DSpace/backport-9309-to-dspace-7_x
[Port dspace-7_x] Improve default identifiers.cfg properties
2024-02-07 11:48:36 -06:00
Kim Shepherd
6624248c7a Improve default identifiers.cfg properties
(Related to dspace-angular#2765)

(cherry picked from commit 40b7427d88)
2024-02-07 16:59:22 +00:00
Tim Donohue
c1f9206c0a Merge pull request #9308 from DSpace/backport-9278-to-dspace-7_x
[Port dspace-7_x] Bump com.jayway.jsonpath:json-path from 2.6.0 to 2.9.0
2024-02-07 08:47:23 -06:00
Koen Pauwels
1dada28c89 111719 Fix bug where old style of retrieving config value was being used 2024-02-07 14:35:46 +01:00
dependabot[bot]
6d5949729d Bump com.jayway.jsonpath:json-path from 2.6.0 to 2.9.0
Bumps [com.jayway.jsonpath:json-path](https://github.com/jayway/JsonPath) from 2.6.0 to 2.9.0.
- [Release notes](https://github.com/jayway/JsonPath/releases)
- [Changelog](https://github.com/json-path/JsonPath/blob/master/changelog.md)
- [Commits](https://github.com/jayway/JsonPath/compare/json-path-2.6.0...json-path-2.9.0)

---
updated-dependencies:
- dependency-name: com.jayway.jsonpath:json-path
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit db56de3887)
2024-02-06 22:49:57 +00:00
Tim Donohue
a9e3a354df Merge pull request #9307 from DSpace/backport-9225-to-dspace-7_x
[Port dspace-7_x] Bump dependencies
2024-02-06 12:23:14 -06:00
Alan Orth
9274a11759 dspace-server-webapp/pom.xml: upgrade zjsonpatch
Upgrade zjsonpatch from v0.4.6 to v0.4.16.

(cherry picked from commit 20fc8e4fb7)
2024-02-06 16:30:00 +00:00
Alan Orth
762c0397fe pom.xml: update commons-dbcp2 and commons-pool2
Update commons-dbcp2 and commons-pool2 to latest stable versions.

(cherry picked from commit bafb1b5657)
2024-02-06 16:30:00 +00:00
Alan Orth
c5398670f9 pom.xml: bump jackson version
Bump jackson-core and jackson-databind to v2.16.0.

(cherry picked from commit b90f043744)
2024-02-06 16:30:00 +00:00
renovate[bot]
bdb19787bb Update dependency org.apache.commons:commons-collections4 to v4.4
(cherry picked from commit 6de85adeb7)
2024-02-06 16:30:00 +00:00
renovate[bot]
1f67a2bffe Update dependency org.apache.commons:commons-configuration2 to v2.9.0
(cherry picked from commit b583029a7d)
2024-02-06 16:30:00 +00:00
renovate[bot]
186453eb3f Update dependency commons-logging:commons-logging to v1.3.0
(cherry picked from commit e76132b4d8)
2024-02-06 16:30:00 +00:00
renovate[bot]
4682db506e Update dependency org.apache.commons:commons-lang3 to v3.14.0
(cherry picked from commit 3f675d9cd5)
2024-02-06 16:30:00 +00:00
renovate[bot]
4dcbe16e24 Update dependency org.webjars.bowergithub.jquery:jquery-dist to v3.7.1
(cherry picked from commit 6d0b5deb8e)
2024-02-06 16:30:00 +00:00
renovate[bot]
9cb4eac802 Update dependency org.webjars.bowergithub.twbs:bootstrap to v4.6.2
(cherry picked from commit 2c1a45bc88)
2024-02-06 16:30:00 +00:00
renovate[bot]
88edfbbfdf Update dependency org.apache.maven.plugins:maven-assembly-plugin to v3.6.0
(cherry picked from commit 275757e6d4)
2024-02-06 16:30:00 +00:00
renovate[bot]
752d94efb4 Update dependency org.apache.maven.plugins:maven-checkstyle-plugin to v3.3.1
(cherry picked from commit ae12f1865f)
2024-02-06 16:30:00 +00:00
Alan Orth
c7c8062f01 Update hamcrest to v2.2
Due to changes in hamcrest packaging we only need the main artifact
now, but we add hamcrest-core (which is an empty pom) so it doesn't
get pulled in by other deps. Last, the hamcrest docs recommend that
we put hamcrest first so that we don't have dependency convergence
issues from junit.

See: https://hamcrest.org/JavaHamcrest/distributables
(cherry picked from commit 710feb798d)
2024-02-06 16:30:00 +00:00
renovate[bot]
b2494c6be2 Update json-path.version to v2.8.0
(cherry picked from commit 8809e98a18)
2024-02-06 16:30:00 +00:00
renovate[bot]
5342d54075 Update dependency org.apache.ant:ant to v1.10.14
(cherry picked from commit 4e071b2428)
2024-02-06 16:30:00 +00:00
Alan Orth
487202e246 pom.xml: update spotbugs and spotbugs-maven-plugin
Update to latest versions:

- spotbugs v4.1.2→v4.8.2
- spotbugs-maven-plugin v4.0.4→v4.8.2.0

These are not run in CI and seem to only run manually when asked,
ie via maven:

    $ mvn spotbugs:spotbugs

(cherry picked from commit fc6a9ca5cb)
2024-02-06 16:30:00 +00:00
Alan Orth
b603776a08 pom.xml: update Spring
We need to keep Spring Framework, Spring Boot, and Spring Security
versions updated together:

- Spring Framework: 5.3.28→5.3.31
- Spring Boot: 2.7.13→2.7.18
- Spring Security: 5.7.9→5.7.11

(cherry picked from commit f42a981d1b)
2024-02-06 16:30:00 +00:00
renovate[bot]
4840b1de83 Update netty monorepo to v4.1.106.Final
(cherry picked from commit 71ea2a7526)
2024-02-06 16:29:59 +00:00
renovate[bot]
a77628bd1e Update dependency com.maxmind.geoip2:geoip2 to v2.17.0
(cherry picked from commit 68caa1dcf8)
2024-02-06 16:29:59 +00:00
renovate[bot]
28d051e88d Update dependency org.xmlunit:xmlunit-core to v2.9.1
(cherry picked from commit 0958a98b1f)
2024-02-06 16:29:59 +00:00
renovate[bot]
8edd8bc09b Update dependency com.fasterxml:classmate to v1.6.0
(cherry picked from commit 07ec54832a)
2024-02-06 16:29:59 +00:00
renovate[bot]
279a315301 Update log4j.version to v2.22.1
(cherry picked from commit a697813720)
2024-02-06 16:29:59 +00:00
renovate[bot]
ed74d3198c Update dependency commons-io:commons-io to v2.15.1
(cherry picked from commit 70646a30de)
2024-02-06 16:29:59 +00:00
renovate[bot]
f7c7abc362 Update dependency com.opencsv:opencsv to v5.9
(cherry picked from commit ab9279cbb8)
2024-02-06 16:29:59 +00:00
renovate[bot]
602e9e854f Update dependency commons-cli:commons-cli to v1.6.0
(cherry picked from commit f67e0f6509)
2024-02-06 16:29:59 +00:00
renovate[bot]
a50534d617 Update pdfbox-version to v2.0.30
(cherry picked from commit fe7800ab5a)
2024-02-06 16:29:59 +00:00
renovate[bot]
7a38f0097d Update dependency org.glassfish.jaxb:jaxb-runtime to v2.3.9
(cherry picked from commit 8d6f6e37b3)
2024-02-06 16:29:59 +00:00
renovate[bot]
0d1dd13c84 Update dependency com.h2database:h2 to v2.2.224
(cherry picked from commit 0d4c1ea63a)
2024-02-06 16:29:59 +00:00
Tim Donohue
d928d8c672 Merge pull request #9305 from tdonohue/port_8884_to_7x
[Port dspace-7_x] Bump dependencies
2024-02-06 09:09:35 -06:00
renovate[bot]
79178e3b62 Update pdfbox-version to v2.0.29 2024-02-05 17:10:57 -06:00
Alan Orth
16b1104b01 pom.xml: bump spring core version to v5.3.28
Minor version bump with some bug fixes.

See: https://github.com/spring-projects/spring-framework/releases/tag/v5.3.28
2024-02-05 17:10:57 -06:00
Alan Orth
ad061c962b pom.xml: update spring boot to v2.7.13
Minor update. Also bump the spring security version to 5.7.9 as is
used by spring boot.

See: https://github.com/spring-projects/spring-boot/releases/tag/v2.7.13
2024-02-05 17:10:57 -06:00
renovate[bot]
972c2d69c8 Update dependency commons-codec:commons-codec to v1.16.0 2024-02-05 17:10:57 -06:00
renovate[bot]
5152e99bda Update dependency org.exparity:hamcrest-date to v2.0.8 2024-02-05 17:10:57 -06:00
renovate[bot]
af29486965 Update dependency commons-io:commons-io to v2.13.0 2024-02-05 17:10:57 -06:00
renovate[bot]
e92e5ee6d8 Update dependency org.scala-lang:scala-library to v2.13.11 2024-02-05 17:10:57 -06:00
renovate[bot]
6b4e5ed9c8 Update dependency org.apache.bcel:bcel to v6.7.0 2024-02-05 17:10:57 -06:00
Alan Orth
096fb3fb74 Bump jaxen:jaxen dependency to 2.0.0
Should be mostly drop-in API compatible with Jaxen 1.1.x, but more
importantly it makes the xom dependency optional so we can remove
the exclusions in our various pom.xml files.

See: http://cafeconleche.org/jaxen/releases.html
2024-02-05 17:10:57 -06:00
Alan Orth
69e1ff98a0 Bump xom:xom dependency
No breaking changes, but some bug fixes, performance improvements,
and compatibility fixes with Java 17+.

See: https://xom.nu/history.html
2024-02-05 17:10:57 -06:00
renovate[bot]
7b0b21f84d Update dependency org.webjars.bowergithub.jquery:jquery-dist to v3.7.0 2024-02-05 17:10:57 -06:00
renovate[bot]
fe8c3ef388 Update dependency com.fasterxml:classmate to v1.5.1 2024-02-05 17:10:57 -06:00
renovate[bot]
36c042bc98 Update dependency org.webjars.bowergithub.medialize:uri.js to v1.19.11 2024-02-05 17:10:57 -06:00
Alan Orth
f9469c9b6f dspace-api/pom.xml: add exclusion for javassist
Add an exclusion for org.javassist:javassist due to a dependency
convergence error caused by eu.openaire:funders-model pulling in a
version conflicting with Jersey's transitive dependency.
2024-02-05 17:10:57 -06:00
Alan Orth
8e66812dbb pom.xml: bump Jersey
Bump jersey due to jersey-media-json-jackson pulling in a conflicting
jakarta.xml.bind-api via transitive dependency in dspace-rest, which
is the legacy DSpace 6 REST API.
2024-02-05 17:10:57 -06:00
renovate[bot]
b5a59c76e8 Update dependency joda-time:joda-time to v2.12.5 2024-02-05 17:10:57 -06:00
renovate[bot]
a9a8021cf6 Update dependency commons-cli:commons-cli to v1.5.0 2024-02-05 17:10:57 -06:00
renovate[bot]
167033d830 Update dependency commons-codec:commons-codec to v1.15 2024-02-05 17:10:57 -06:00
renovate[bot]
8895aca3eb Update dependency commons-validator:commons-validator to v1.7 2024-02-05 17:10:56 -06:00
renovate[bot]
53c4e18159 Update dependency commons-io:commons-io to v2.12.0 2024-02-05 17:10:56 -06:00
renovate[bot]
e14f267229 Update dependency org.apache.james:apache-mime4j-core to v0.8.9 2024-02-05 17:10:56 -06:00
renovate[bot]
ba95c1852f Update dependency org.glassfish.jaxb:jaxb-runtime to v2.3.8 2024-02-05 17:10:56 -06:00
renovate[bot]
91f9d8c4dd Update dependency com.opencsv:opencsv to v5.7.1 2024-02-05 17:10:56 -06:00
renovate[bot]
e2d809ffb4 Update dependency org.flywaydb:flyway-core to v8.5.13 2024-02-05 17:10:56 -06:00
renovate[bot]
bbe05833a9 Update dependency org.ehcache:ehcache to v3.10.8 2024-02-05 17:10:56 -06:00
Alan Orth
95ac7dea42 pom.xml: bump org.apache.httpcomponents
Closes: https://github.com/alanorth/DSpace/pull/21
Closes: https://github.com/alanorth/DSpace/pull/22
Closes: https://github.com/alanorth/DSpace/pull/23
2024-02-05 17:10:56 -06:00
renovate[bot]
969bee4871 Update dependency junit:junit to v4.13.2 2024-02-05 17:10:56 -06:00
renovate[bot]
be7bdcf398 Update dependency org.apache.ant:ant to v1.10.13 2024-02-05 17:10:56 -06:00
renovate[bot]
84452a97d8 Update dependency net.handle:handle to v9.3.1 2024-02-05 17:10:56 -06:00
renovate[bot]
aeb5300c6f Update dependency javax.cache:cache-api to v1.1.1 2024-02-05 17:10:56 -06:00
Alan Orth
bd7214ad1f pom.xml: bump com.google.code.findbugs:jsr305
Closes: https://github.com/alanorth/DSpace/pull/12
2024-02-05 17:10:56 -06:00
renovate[bot]
5893c7768e Update dependency dnsjava:dnsjava to v2.1.9 2024-02-05 17:10:56 -06:00
renovate[bot]
774f3bbcd5 Update dependency de.digitalcollections.iiif:iiif-apis to v0.3.10 2024-02-05 17:09:59 -06:00
renovate[bot]
3bfcf82977 Update dependency com.flipkart.zjsonpatch:zjsonpatch to v0.4.14 2024-02-05 17:09:44 -06:00
Tim Donohue
66a4a036e0 Merge pull request #9304 from tdonohue/port_9303_to_7x
[Port dspace-7_x] Fix Docker image build issues for new versions of Docker (25.0.2) and Docker Compose (2.24.3)
2024-02-02 15:53:17 -06:00
Tim Donohue
414837a12a Fix 'dspacesolr' build issues in GitHub actions by adding 'solrconfig' as an additional_context 2024-02-02 14:47:15 -06:00
Tim Donohue
250e82af9d Fix build issues with dockersolr by using "additional_contexts" to pass solr config path to Dockerfile. 2024-02-02 14:45:55 -06:00
Tim Donohue
a0ba470197 Fix "cannot override networks.dspacenet" by updating all compose files to reference 'dspacenet' network 2024-02-02 14:43:09 -06:00
Tim Donohue
f46742510b Merge pull request #9297 from DSpace/backport-9293-to-dspace-7_x
[Port dspace-7_x] Call cas.init() method in the VocabularyRestRepositoryIT#setup method
2024-01-29 12:19:04 -06:00
milanmajchrak
2549663081 The cas.init() method is called in the VocabularyRestRepositoryIT#setup() method
(cherry picked from commit 85b5e06fb0)
2024-01-29 17:52:28 +00:00
Alan Orth
5f7af6b3fc Merge pull request #9280 from DSpace/backport-9276-to-dspace-7_x
[Port dspace-7_x] Search on the label of an authority, not the value in a submission context
2024-01-23 11:48:44 +03:00
Jens Vannerum
a22a01aa5c search on labels, not values on DCInputs
(cherry picked from commit 5ebe1a9402)
2024-01-23 08:05:25 +00:00
Tim Donohue
c509d495b1 Merge pull request #9270 from DSpace/backport-9261-to-dspace-7_x
[Port dspace-7_x] DS-9142: prevent UUID exception by adding check for -1 value for the id field
2024-01-19 09:43:45 -06:00
nwoodward
dc57aceeaf catch exceptions stemming from invalid id's
(cherry picked from commit 848df25984)
2024-01-19 15:15:26 +00:00
Marie Verdonck
4fc19da34a Merge remote-tracking branch 'origin/dspace-7_x' into w2p-90830-104654_issue-8125_pr-8267_Issue-stale-record-cleanup-7.x 2024-01-18 19:36:57 +01:00
Alan Orth
8a59c12b35 Merge pull request #9264 from DSpace/backport-9252-to-dspace-7_x
[Port dspace-7_x] Skip recording usage events if user is administrator
2024-01-18 10:13:03 +03:00
Agustina Martinez
9a0db2a642 Skip recording usage event if administrator
(cherry picked from commit 73e5c43f7c)
2024-01-18 06:46:35 +00:00
Alan Orth
c86a0cf04e Merge pull request #9256 from DSpace/backport-9248-to-dspace-7_x
[Port dspace-7_x] Return headers for HEAD request
2024-01-11 18:43:12 +03:00
William Welling
ebbae391d7 Add content-length to bitstream
(cherry picked from commit 6be7e4e370)
2024-01-11 15:15:35 +00:00
William Welling
b8d00afd12 Return headers for HEAD request
(cherry picked from commit 64ae49a29f)
2024-01-11 15:15:35 +00:00
Tim Donohue
8b29c04790 Merge pull request #9251 from DSpace/backport-9250-to-dspace-7_x
[Port dspace-7_x] dspace-api: fix typo in AuthorizeServiceImpl log
2024-01-09 14:23:17 -06:00
Alan Orth
37ed65850f dspace-api: fix typo in AuthorizeServiceImpl log
(cherry picked from commit 127b1ae868)
2024-01-09 20:13:56 +00:00
Alan Orth
426a2f9c47 Merge pull request #9246 from DSpace/backport-9239-to-dspace-7_x
[Port dspace-7_x] Correct response of get controlled vocabulary by metadata and collection when NO controlled vocabulary is available for the specified metadata and collection
2024-01-04 10:59:16 +03:00
Toni Prieto
14c6ccce21 Add missing test for byMetadataAndCollection operation of Controlled Vocabularies endpoint
(cherry picked from commit a294f996cf)
2024-01-04 07:32:53 +00:00
Toni Prieto
c7113e5d24 Correct response of byMetadataAndCollection operation of Controlled Vocabularies Endpoint when no controlled vocabulary is available for the specified metadata and collection
(cherry picked from commit eb2e4f1155)
2024-01-04 07:32:53 +00:00
Marie Verdonck
91f53c2287 90830/104654: issue PR#8267 - Only first 10 predb records resynced (default size) - Fix:
- Query with 0 rows to get total number of records to process
- Process them in batches of 100
2023-12-29 05:58:25 +01:00
Marie Verdonck
7536537206 90830/104654: issue PR#8267 - Only first 10 predb records resynced (default size) - IT proving issue 2023-12-29 05:55:48 +01:00
Alan Orth
5606c8b97f Merge pull request #9224 from DSpace/backport-9220-to-dspace-7_x
[Port dspace-7_x] fix: Failure of org.dspace.app.rest.SitemapRestControllerIT when running locally
2023-12-08 11:37:43 +03:00
Shankeerthan Kasilingam
16112a44d8 fix: Failure of org.dspace.app.rest.SitemapRestControllerIT when running locally
(cherry picked from commit 44fc15f74b)
2023-12-08 07:38:07 +00:00
Tim Donohue
7524d169f5 Remove unused env variables from docker.yml build script 2023-11-28 17:01:04 -06:00
Tim Donohue
61d9e75ccd Merge pull request #9214 from DSpace/backport-9213-to-dspace-7_x
[Port dspace-7_x] Add parallel builds for Docker Images in GitHub Actions
2023-11-28 15:59:53 -06:00
Tim Donohue
af1550d415 Ensure dspace-solr redeploys the Solr instances for Demo/Sandbox 2023-11-28 15:13:17 -06:00
Tim Donohue
93fc3ce8d0 Refactor docker.yml to use a separate reusable-docker-build.yml script for each image build.
(cherry picked from commit 0e88bfdae7)
2023-11-28 19:48:25 +00:00
Tim Donohue
68f29c45b6 Minor fixes to Dockerfiles. No longer need 'git'. Use Maven flags to slightly speed up build/install steps.
(cherry picked from commit 538833f8a8)
2023-11-28 19:48:25 +00:00
Tim Donohue
c9c57faa21 Update GitHub action plugin versions. Minor fixes including using built-in Maven caching & fix to CodeCov action
(cherry picked from commit 2aae4cd78d)
2023-11-28 19:48:25 +00:00
Alan Orth
501e657348 Merge pull request #9207 from alanorth/port-9203-dspace-7_x
[Port dspace-7-x] CrossRefImport: ignore empty responses rather than generating empty phantom ImportRecords
2023-11-23 09:13:58 +03:00
Philipp Rumpf
21a7f25118 CrossRefImportMetadataSourceServiceIT: Test empty responses don't result in ... results. 2023-11-23 08:44:34 +03:00
Philipp Rumpf
722ad02757 CrossRefImport: ignore empty responses rather than generating empty phantom ImportRecords
Fixes https://github.com/DSpace/DSpace/issues/9202 .
2023-11-23 08:44:21 +03:00
Tim Donohue
76658e7c96 [maven-release-plugin] prepare for next development iteration 2023-11-15 14:16:40 -06:00
Tim Donohue
8ad5bc1262 [maven-release-plugin] prepare release dspace-7.6.1 2023-11-15 14:16:37 -06:00
DSpace Bot
64d30e6fdf [Port dspace-7_x] subscription email: do not send email if nothing has changed (#9204)
* improved subscriptions email template

(cherry picked from commit 6e7b327959)

* do not send emails without content

(cherry picked from commit 926b242130)

* fixed coding style violations

(cherry picked from commit fdacec08df)

* removed unnecessary isEmpty check as suggested by reviewer

(cherry picked from commit 30a837f854)

* moved null check on indexableObjects in generateBodyMail

(cherry picked from commit b43c340b18)

* fixed unhandled IOException

(cherry picked from commit 9b3f7b698c)

* fixed typo in bodyCommunities

(cherry picked from commit ac3d02eb1c)

* do not use != to compare strings

(cherry picked from commit e460183335)

* fixed improper handling of empty list

(cherry picked from commit ac72aae44b)

---------

Co-authored-by: Sascha Szott <szott@gmx.de>
2023-11-14 14:19:50 -06:00
Tim Donohue
a3501c64af Merge pull request #9200 from DSpace/backport-9162-to-dspace-7_x
[Port dspace-7_x] Fix match theme by handle with cannonical prefix https://hdl.handle.net/ not working
2023-11-13 16:00:10 -06:00
Alexandre Vryghem
a7f106da92 Remove line breaks from default.license because they are being rendered in the frontend
(cherry picked from commit 56aae347c2)
2023-11-13 20:20:23 +00:00
Alexandre Vryghem
e7786f49af 107671: Expose the handle.canonical.prefix to the frontend
(cherry picked from commit 6d86e65b72)
2023-11-13 20:20:23 +00:00
Tim Donohue
a25710a23d Merge pull request #9199 from DSpace/backport-9163-to-dspace-7_x
[Port dspace-7_x] Simplify process of fixing the tests after adding sidebar facets
2023-11-13 13:18:10 -06:00
Tim Donohue
dccd7a04b6 Merge pull request #9198 from DSpace/backport-9184-to-dspace-7_x
[Port dspace-7_x] Updated IIIF Controller IT to text bitstream and bundle exclusions
2023-11-13 11:47:17 -06:00
Alexandre Vryghem
74733ab4b4 Simplified the process of fixing the tests after adding new sidebar facets/search filters and sort options to discover.xml
(cherry picked from commit b40ad0dfc2)
2023-11-13 17:40:51 +00:00
Michael Spalti
6b99584e96 Updated IIIF Controller IT to text bitstream and bundle exclusions
(cherry picked from commit e92b4b7bfd)
2023-11-13 17:09:55 +00:00
Tim Donohue
6edf793023 Merge pull request #9197 from DSpace/backport-9125-to-dspace-7_x
[Port dspace-7_x] Add `isNotMemberOf` searches for Groups and EPersons (for improved performance on Edit Group pages)
2023-11-10 15:14:34 -06:00
Tim Donohue
c2fd617921 Bug fix to EPersonDAOImpl. Correctly determine if excluded group needs to be preceded by AND or WHERE
(cherry picked from commit e5e0eaa999)
2023-11-10 19:02:14 +00:00
Tim Donohue
b65ddc3638 Add /epersons/search/isNotMemberOf endpoint to REST API along with integration tests
(cherry picked from commit 5208a355d6)
2023-11-10 19:02:14 +00:00
Tim Donohue
887c7c486a Implement searchNonMembers for EPersonService. Add tests to prove it works (and tests for search()). Requires minor bug fix to AbstractHibernateDSODAO to allow for additional OR/AND clauses to be appended.
(cherry picked from commit f186dcf4ca)
2023-11-10 19:02:14 +00:00
Tim Donohue
7df4a2b1c6 Add isNotMemberOf for groups, including unit and integration tests
(cherry picked from commit 9d271b24b9)
2023-11-10 19:02:14 +00:00
DSpace Bot
417a270cf3 [Port dspace-7_x] Event consumer for submission config reloading when a collection changes (#9196)
* initialization with refactoring

(cherry picked from commit e93dc1cf45)

* also consider SubmissionConfigReaderException

(cherry picked from commit 8a04b87750)

* rename consumer file

(cherry picked from commit f6c92a4c8b)

* init submission service factory

(cherry picked from commit fcc52390b9)

* set submissionconfig config settings by default

(cherry picked from commit e343d51519)

* renaming SubmissionConfigReaderService

(cherry picked from commit 9ea7c321c3)

* support for SubmissionConfigService

(cherry picked from commit 61389fb787)

* fixing style errors and renaming submissionConfigService

(cherry picked from commit 5f49491b53)

* fixing style errors and unused imports

(cherry picked from commit 31d9251950)

* set default submission event configs

(cherry picked from commit 578198c588)

* adding force indexing action to Consumer

(cherry picked from commit b91236434f)

* stylecheck fixes

(cherry picked from commit 89e89c3d8a)

* undo event.dispatcher.noindex.consumers

(cherry picked from commit ae9dc5f005)

---------

Co-authored-by: Paulo Graça <paulo1978@gmail.com>
2023-11-10 12:58:18 -06:00
Tim Donohue
be52c85e62 Merge pull request #9193 from DSpace/backport-9175-to-dspace-7_x
[Port dspace-7_x] Improve sitemap performance and exclude restricted and undiscoverable content
2023-11-10 09:55:21 -06:00
Andrea Bollini
154d488138 DURACOM-199 fix sitemap generator for restricted content and improve performance
(cherry picked from commit 6d9ca388da)
2023-11-10 15:04:59 +00:00
Andrea Bollini
c9abeac208 DURACOM-199 improved test to show bug related to restricted content
(cherry picked from commit dac4df9c1a)
2023-11-10 15:04:59 +00:00
Yana De Pauw
9b1234fc85 106812: Remove stray settting of group for an rp 2023-11-10 14:05:38 +01:00
Tim Donohue
adde7b7efd Merge pull request #9189 from DSpace/backport-9161-to-dspace-7_x
[Port dspace-7_x] Cache 'Administrator' group to improve performance of Workflow Tasks Page.
2023-11-09 17:18:31 -06:00
Tim Donohue
d301eade48 Merge pull request #9188 from DSpace/backport-9130-to-dspace-7_x
[Port dspace-7_x] Authentication Method related special groups are put in claim set even if a different authentication method is used
2023-11-09 17:18:12 -06:00
Jens Vannerum
fd13ee7cfd 107891: Cache administrator group
(cherry picked from commit 1e82ca7998)
2023-11-09 22:49:20 +00:00
Luca Giamminonni
911a7a394f [DURACOM-192] Added test
(cherry picked from commit fa39251071)
2023-11-09 22:38:12 +00:00
Luca Giamminonni
ec972ea2de [DURACOM-192] Authentication Method related special groups are put in claim set even if a different authentication method is used
(cherry picked from commit 6504d749b9)
2023-11-09 22:38:11 +00:00
Alan Orth
68ab431294 Merge pull request #9187 from DSpace/backport-9181-to-dspace-7_x
[Port dspace-7_x] Fix an issue where the `closed` attribute of vocabularies in the submission forms would be neglected
2023-11-09 22:32:09 +03:00
Alan Orth
a6046e0168 Merge pull request #9186 from DSpace/backport-9179-to-dspace-7_x
[Port dspace-7_x] [DURACOM-200] improvement of checker script
2023-11-09 22:30:11 +03:00
Jens Vannerum
adf644535c 108055: isClosed method should use xml configuration
(cherry picked from commit d800d800d5)
2023-11-09 18:57:23 +00:00
mohamed eskander
4b2957358f [DURACOM-200] improvement of checker script
(cherry picked from commit 5a7c7956cd)
2023-11-09 17:40:27 +00:00
Tim Donohue
5601392e84 Merge pull request #9183 from DSpace/backport-9148-to-dspace-7_x
[Port dspace-7_x] Return both user and operational LDAP attributes
2023-11-08 17:07:32 -06:00
wwuck
0172cf6508 Return both user and operational LDAP attributes
Explicitly request both user and operation attributes
for LDAP group search as the default searching does not
include operational attributes.

This is required to fetch the memberOf attribute when checking
LDAP group membership.

Fixes #9151

(cherry picked from commit 56b7cbf4db)
2023-11-08 22:40:46 +00:00
Tim Donohue
843828dcdf Merge pull request #9182 from tdonohue/port_9076_to_dspace-7_x
[Port dspace-7_x] Fix to prevent workflow tasks configured to be queued from running automatically
2023-11-08 15:52:03 -06:00
Agustina Martinez
c1a48e5512 XmlWorkflowCuratorServiceImpl: add check to queue task if configured; Curation: remove obsolete code preventing curation running on workflow tasks as #3157 is now implemented 2023-11-08 14:58:39 -06:00
Alan Orth
101b3a2f57 Merge pull request #9173 from DSpace/backport-9165-to-dspace-7_x
[Port dspace-7_x] DS-9059: removes options to ping search engines when generating sitemaps
2023-11-06 23:13:19 +03:00
nwoodward
ca624e7ab5 removed options to ping search engines when generating sitemaps
(cherry picked from commit f8f8806040)
2023-11-06 19:36:36 +00:00
Tim Donohue
a5e4233f1d Merge pull request #9170 from DSpace/backport-9157-to-dspace-7_x
[Port dspace-7_x] dspace/config: update spider agent list
2023-11-06 09:54:38 -06:00
Alan Orth
38c81b9f0d dspace/config: update spider agent list
Update list of spider user agents from the COUNTER-Robots project.

See: https://github.com/atmire/COUNTER-Robots
(cherry picked from commit 7566a79d90)
2023-11-03 21:32:53 +00:00
Tim Donohue
194a3e57a3 Merge pull request #9169 from DSpace/backport-8980-to-dspace-7_x
[Port dspace-7_x] Improve performance of discovery consumer when there are many items to index
2023-11-03 12:22:32 -05:00
Toni Prieto
6c211ac19c Change class name to ContextIT and correct a test
(cherry picked from commit a5567992bb)
2023-11-03 15:55:45 +00:00
Toni Prieto
ddbba2d125 Add test to check retrieving of policies after changing mode to READ_ONLY
(cherry picked from commit d19a9599b5)
2023-11-03 15:55:45 +00:00
Toni Prieto
1b0e826bba Flush database changes after switching to READONLY mode
(cherry picked from commit 00a65312cc)
2023-11-03 15:55:45 +00:00
Toni Prieto
b194e9c4dd Add functions to do a manual flush of the db session and call flush before change to READ_ONLY mode to be sure we index the current object
(cherry picked from commit c33d3fa87d)
2023-11-03 15:55:45 +00:00
Toni Prieto
e6fa537512 Change the database mode to READ_ONLY during the indexing by discovery consumer (IndexEventConsumer)
(cherry picked from commit 94822b50af)
2023-11-03 15:55:45 +00:00
Tim Donohue
9624347201 Merge pull request #9168 from DSpace/backport-9136-to-dspace-7_x
[Port dspace-7_x] Verify optional request-a-copy message is not missing or a literal "null" value
2023-11-02 17:20:00 -05:00
Tim Donohue
3ded3acd8f Merge pull request #9084 from TexasDigitalLibrary/DS-4414-7_x
[Port dspace-7_x] DS-4414: adds authorization check for license bitstream in OAI import
2023-11-02 16:55:18 -05:00
Tim Donohue
52e965b06a Merge pull request #9167 from DSpace/backport-9126-to-dspace-7_x
[Port dspace-7_x] Allow users with write permission to see hidden metadata
2023-11-02 16:23:08 -05:00
Tim Donohue
551c84dede Verify optional message is not missing or a literal "null" value
(cherry picked from commit 534ee3a699)
2023-11-02 21:21:10 +00:00
Toni Prieto
42959d5db8 Add test to check that user with read rights can see hidden metadata
(cherry picked from commit 03496c36d4)
2023-11-02 19:58:18 +00:00
Toni Prieto
40bb9491a5 Test modification: allow users with write rights to see hidden metadata
(cherry picked from commit df7f6e9f40)
2023-11-02 19:58:18 +00:00
Toni Prieto
686747bbf8 Allow users with write permission to view hidden metadata
(cherry picked from commit 65a17d4390)
2023-11-02 19:58:18 +00:00
Tim Donohue
f8f54719c9 Merge pull request #9166 from DSpace/backport-9078-to-dspace-7_x
[Port dspace-7_x] Improve performance for Groups with many EPerson members. Fix pagination on endpoints
2023-11-02 14:47:13 -05:00
Tim Donohue
6e63e63039 Address feedback. Initialize HashSet sizes to avoid resizing. Correct comment about indeterminante ordering.
(cherry picked from commit f011a5a5db)
2023-11-02 19:09:16 +00:00
Tim Donohue
f6003164c8 Use join instead of subquery as join seems slightly faster.
(cherry picked from commit 9c0bf08cf4)
2023-11-02 19:09:16 +00:00
Tim Donohue
3caa8b26dc Fix bug in logic for determining whether a workflow group will be left empty. Need to check *both* EPerson and subgroup counts.
(cherry picked from commit 9832259aa0)
2023-11-02 19:09:16 +00:00
Tim Donohue
a723018e9a Replace several usages of allMembers() with count methods to avoid performance issues
(cherry picked from commit 2c9165afb0)
2023-11-02 19:09:16 +00:00
Tim Donohue
8b1a0c1dae Add countAllMembers() with tests. Update tests to use try/catch
(cherry picked from commit 58a15b7297)
2023-11-02 19:09:16 +00:00
Tim Donohue
7aca4df6ef Minor unit test fix. Use isEqualCollection to compare list with Hibernate results
(cherry picked from commit cdb68a6fdc)
2023-11-02 19:09:16 +00:00
Tim Donohue
e48b21637a Add basic unit test for new EpersonService methods
(cherry picked from commit c000e54116)
2023-11-02 19:09:16 +00:00
Tim Donohue
22fb4508ee Add pagination to /groups/[uuid]/subgroups endpoint, along with tests
(cherry picked from commit e7c4b9eba2)
2023-11-02 19:09:16 +00:00
Tim Donohue
a4db6d39d7 Add missing pagination test for /groups/[uuid]/epersons
(cherry picked from commit 457dd9ae44)
2023-11-02 19:09:16 +00:00
Tim Donohue
8b748af944 Bug fix. Only use pageSize and offset if >0
(cherry picked from commit 15de2d0074)
2023-11-02 19:09:16 +00:00
Tim Donohue
8aad365496 Add basic pagination to /groups/[uuid]/epersons endpoint
(cherry picked from commit 74c72354b4)
2023-11-02 19:09:16 +00:00
Alan Orth
1ad9a097ee Merge pull request #9160 from DSpace/backport-9106-to-dspace-7_x
[Port dspace-7_x] Clear primary bistream when it's deleted- Fix issue #9099
2023-10-31 10:37:16 +03:00
Paulo Graça
c601ac3475 typo
(cherry picked from commit 74cce86afc)
2023-10-31 06:55:06 +00:00
Paulo Graça
412d62aa43 make comments more clear to understand
(cherry picked from commit c0bbd9d91f)
2023-10-31 06:55:06 +00:00
Paulo Graça
68e8894169 new testDeleteBitstreamAndUnsetPrimaryBitstreamID remove unnecessary stubs
(cherry picked from commit a3e506c7f4)
2023-10-31 06:55:06 +00:00
Paulo Graça
41640bbb65 new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification
(cherry picked from commit ad0d22a13a)
2023-10-31 06:55:06 +00:00
Paulo Graça
024c47559e new testDeleteBitstreamAndUnsetPrimaryBitstreamID test for primary bitstream verification
(cherry picked from commit e6d108a94e)
2023-10-31 06:55:06 +00:00
Paulo Graça
09d5f6fcc9 fix style errors
(cherry picked from commit 74605f159a)
2023-10-31 06:55:06 +00:00
Paulo Graça
55eba18a47 add missing head style check
(cherry picked from commit caba4bbb96)
2023-10-31 06:55:06 +00:00
Paulo Graça
6b35f9e449 adding missing bundle REMOVE authorization
(cherry picked from commit 4a05600194)
2023-10-31 06:55:06 +00:00
Paulo Graça
7ab1d39671 add bundle remove authorization
(cherry picked from commit 3255e073fa)
2023-10-31 06:55:06 +00:00
Paulo Graça
7ec5f7ec8a adding sql expression to fix deleted primary bitstreams from bundle
(cherry picked from commit 8a531ad0c7)
2023-10-31 06:55:06 +00:00
Paulo Graça
c96558986a unset primary bitstream on bitstream service
(cherry picked from commit 47ca74bc42)
2023-10-31 06:55:06 +00:00
Paulo Graça
08f361a9cb add test and fix
(cherry picked from commit 48b0b71c63)
2023-10-31 06:55:06 +00:00
Tim Donohue
c0f4d1e219 Merge pull request #9158 from DSpace/backport-9045-to-dspace-7_x
[Port dspace-7_x] OAI-PMH use Templates for compiled XSLT instead of Transformer (thread-safe)
2023-10-30 17:15:11 -05:00
Tim Donohue
3553467f21 Merge pull request #9124 from mwoodiupui/dspace-7_x
Give `authority` Solr core a `_version_` field so it can be loaded
2023-10-30 16:59:14 -05:00
Tim Donohue
448387ccfd Update to newly released XOAI 3.4.0
(cherry picked from commit 160ebbd791)
2023-10-30 21:02:52 +00:00
Christian Bethge
5596cc686d 9043 use Templates for compiled XSLT instead of Transformer - use Templates are thread-safe and NOT Transformer
(cherry picked from commit 1160341cb2)
2023-10-30 21:02:52 +00:00
Alan Orth
0ddc05bffb Merge pull request #9156 from DSpace/backport-9152-to-dspace-7_x
[Port dspace-7_x] Add a null check when assigning ldap groups
2023-10-29 21:11:35 +03:00
wwuck
e597c2afc1 Add a null check when assigning ldap groups
Prevent NullReferenceException by checking if the group list is null

Fixes #8920

(cherry picked from commit bb6498ed5e)
2023-10-29 16:57:18 +00:00
Tim Donohue
bd986a06c4 Merge pull request #9153 from DSpace/backport-9069-to-dspace-7_x
[Port dspace-7_x] Fix "Site cannot be indexed" error which appears in ITs and sometimes in logs
2023-10-27 10:46:11 -05:00
Tim Donohue
e649966cb7 Merge pull request #8984 from uofmsean/fix-8558-set-solr-timezone
Set Solr timezone to UTC when converting local date/time to the stored value that assumes Zulu (Z)
2023-10-27 10:44:52 -05:00
Tim Donohue
b5a1a3b4bd Merge pull request #9150 from DSpace/backport-9001-to-dspace-7_x
[Port dspace-7_x] Make workflow curation tasks actually work.
2023-10-27 10:05:05 -05:00
Tim Donohue
1bc6e1ff71 Fix "Site cannot be indexed" error by ignoring ADD/REMOVE events on Site object
(cherry picked from commit ef7f02fe81)
2023-10-27 14:54:51 +00:00
Mark H. Wood
06f6a41cbf Handle missing role.
(cherry picked from commit 2e62fa3fd1)
2023-10-26 21:23:34 +00:00
Mark H. Wood
7a2b018843 Correct some documentation.
(cherry picked from commit be22790aad)
2023-10-26 21:23:34 +00:00
Mark H. Wood
4b62c9b605 Community request: fake EPerson from configuration.
(cherry picked from commit bb9e88d1bb)
2023-10-26 21:23:34 +00:00
Mark H. Wood
7cdc710895 Make workflow curation tasks actually work.
When curation runs, there was no "current user" and no claimed task,
so the code broke when trying to find people to notify about curation
failures.

(cherry picked from commit a76af35a0c)
2023-10-26 21:23:34 +00:00
Tim Donohue
52dca308ad Merge pull request #9149 from DSpace/backport-9113-to-dspace-7_x
[Port dspace-7_x] fix not resolved thumbnail due to filename issues
2023-10-26 12:16:28 -05:00
Gantner, Florian Klaus
9d099dcf3f extract bitstream thumbnail name pattern into own function
(cherry picked from commit c5466c2249)
2023-10-26 16:10:19 +00:00
Gantner, Florian Klaus
af5632c2f2 check null value of bitstream name before quoting name for regex
(cherry picked from commit a9bcc0c223)
2023-10-26 16:10:18 +00:00
Gantner, Florian Klaus
1c7e9ea1f1 quote Pattern for thumbnail resolution constructed from bitstream filename
(cherry picked from commit a124807468)
2023-10-26 16:10:18 +00:00
Tim Donohue
7e36062c2e Merge pull request #9039 from atmire/backport-9019-to-dspace-7_x
[Port to dspace-7_x] Fix inherit policies at item move
2023-10-25 16:38:36 -05:00
Tim Donohue
21ce7d7580 Merge pull request #9138 from tdonohue/port_8966_to_dspace7x
[Port to dspace-7_x] Reading localized license file.
2023-10-20 17:18:50 -05:00
Tim Donohue
fa01fde364 Applying commit 6108c98d82 2023-10-20 16:35:14 -05:00
damian
b21b5e0096 Reading localized license file. 2023-10-20 16:33:51 -05:00
damian
093785e5e2 Reading localized license file. 2023-10-20 16:30:50 -05:00
Tim Donohue
68e80b92f0 Merge pull request #9137 from DSpace/backport-9135-to-dspace-7_x
[Port dspace-7_x] Bump org.json:json from 20230227 to 20231013 in /dspace-api
2023-10-20 15:55:16 -05:00
dependabot[bot]
ad7f506b2b Bump org.json:json from 20230227 to 20231013 in /dspace-api
Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 11a08f1ac0)
2023-10-20 20:16:32 +00:00
Tim Donohue
1e28df7998 Merge pull request #9134 from tdonohue/port_9117
[Port dspace-7_x] Bump org.eclipse.jetty:jetty-http
2023-10-20 09:56:39 -05:00
dependabot[bot]
8028304513 Bump org.eclipse.jetty:jetty-http
Bumps [org.eclipse.jetty:jetty-http](https://github.com/eclipse/jetty.project) from 9.4.52.v20230823 to 9.4.53.v20231009.
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.52.v20230823...jetty-9.4.53.v20231009)

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-http
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-10-19 16:48:08 -05:00
Tim Donohue
fb2162b6a0 Merge pull request #9133 from DSpace/backport-9121-to-dspace-7_x
[Port dspace-7_x] oai_openaire.xsl : change resourceTypeGeneral for thesis
2023-10-19 13:51:55 -05:00
Marie-Hélène Vézina
dd976b693a oai_openaire.xsl : change resourceTypeGeneral for thesis
Thesis are "Literature" resource type (resourceTypeGeneral), not "other research product"

ref:
https://github.com/openaire/guidelines-literature-repositories/issues/43#issuecomment-1318262914
and
https://api.openaire.eu/vocabularies/dnet:result_typologies/publication

(cherry picked from commit 669ff34350)
2023-10-19 17:34:06 +00:00
Koen Pauwels
252941046a Merge remote-tracking branch 'dspace/dspace-7_x' into backport-9019-to-dspace-7_x 2023-10-18 15:44:45 +02:00
Alan Orth
807168b77c Merge pull request #9128 from DSpace/backport-9110-to-dspace-7_x
[Port dspace-7_x] #8585 Add submitter information to provenance metadata
2023-10-17 12:52:11 +03:00
Alan Orth
c032f3a041 dspace-api: fix misaligned comment
(cherry picked from commit 4fba787322)
2023-10-17 09:00:26 +00:00
Adán Román Ruiz
0ddebd926f 8585 - added provenance to metadata-import and itemImport
(cherry picked from commit ea6307dcc6)
2023-10-17 09:00:26 +00:00
Adán Román Ruiz
668b5b24df #8585 Add submitter information to provenance metadata
(cherry picked from commit c15ac0eb4a)
2023-10-17 09:00:26 +00:00
Mark H. Wood
c8e4a0fd90 Define _version_ 2023-10-12 16:45:48 -04:00
kshepherd
4a3b9c1e47 Merge pull request #9111 from DSpace/backport-9101-to-dspace-7_x
[Port dspace-7_x] 8968 - request-a-copy email: non ASCII characters are encoded as HTML…
2023-10-10 13:47:06 +13:00
Adán Román Ruiz
d957dc2007 checkstiye
(cherry picked from commit d12fbe2c34)
2023-10-09 23:50:52 +00:00
Adán Román Ruiz
11dc69ac34 8968 - implementated using HtmlUtils scaping
(cherry picked from commit 090beedb6f)
2023-10-09 23:50:52 +00:00
Adán Román Ruiz
36ad3de11f checkstyle
(cherry picked from commit 2c2b3b18dc)
2023-10-09 23:50:52 +00:00
Adán Román Ruiz
8d4fd1ce6c 8968 - added custom StringEscapper
(cherry picked from commit 103c8ee757)
2023-10-09 23:50:52 +00:00
aroman-arvo
e4d54bba27 unused import
(cherry picked from commit bf6e042085)
2023-10-09 23:50:52 +00:00
aroman-arvo
2b25321362 8968 - request-a-copy email: non ASCII characters are encoded as HTML character entity references
(cherry picked from commit db36d5eeae)
2023-10-09 23:50:52 +00:00
Alan Orth
851123b956 Merge pull request #9098 from kshepherd/bugfix/handleprovider_class_cast_7x
Additional Item class cast fixes in handle providers
2023-10-03 13:08:04 +03:00
Tim Donohue
8160f7ccd6 Merge pull request #9102 from DSpace/backport-9100-to-dspace-7_x
[Port dspace-7_x] Remove Oracle script that accidentally made it in via #8800
2023-10-02 12:40:30 -05:00
Tim Donohue
1c1266b855 Remove Oracle script that accidentally made it in via #8800
(cherry picked from commit 5e04edf41e)
2023-10-02 16:56:27 +00:00
Kim Shepherd
33d2ee961d Additional Item class cast fixes in handle providers
DSOs were not properly checked if they were instanceof Item before
attempting the cast in HandleIdentifierProvider and
VersionedHandleIdentifierProviderWithCanonicalHandles
2023-10-02 17:57:08 +13:00
Yana De Pauw
9880e697b6 106812: Add h2 sql file 2023-09-29 15:36:53 +02:00
Yana De Pauw
1cf13e3bfe 106812: Fix old rest resource policy creations 2023-09-29 11:44:29 +02:00
Yana De Pauw
b923e13726 106812: Fix and add new tests 2023-09-29 10:36:43 +02:00
Yana De Pauw
16159f3761 106812: Refactor resource policies to have either group or eperson 2023-09-28 15:07:14 +02:00
Tim Donohue
d6e5074c5b Merge pull request #9090 from DSpace/backport-8926-to-dspace-7_x
[Port dspace-7_x] OAI: add support to extract embargo from bitstreams
2023-09-22 12:37:32 -05:00
Agustina Martinez
572ebb5b27 DefaultAccessStatusHelper: getEmbargoFromItem return null embargo if status than embargo
(cherry picked from commit e05e73a112)
2023-09-22 16:01:17 +00:00
Agustina Martinez
a211edaeb2 Remove currently unused customisation of ItemUtils
(cherry picked from commit 490a982e80)
2023-09-22 16:01:17 +00:00
Agustina Martinez
db733101b6 DefaultAccessStatusHelper: fix logic to take shortest embargo
(cherry picked from commit d17ef09082)
2023-09-22 16:01:17 +00:00
Agustina Martinez
9a51fb8768 uketd_dc.xsl: also expose access-status if embargo or restricted
(cherry picked from commit 4b40872a6d)
2023-09-22 16:01:17 +00:00
Agustina Martinez
08e82ebf28 ItemUtils.java: refactored addEmbargoField
(cherry picked from commit 291afa765d)
2023-09-22 16:01:17 +00:00
Agustina Martinez
d154936a3d Add null check
(cherry picked from commit 0de4c3945e)
2023-09-22 16:01:17 +00:00
Agustina Martinez
31251183f3 Fix style issues
(cherry picked from commit 6e2c8a4ae0)
2023-09-22 16:01:17 +00:00
Agustina Martinez
beaf40dd9b Fix style issues
(cherry picked from commit 724a4ffb0e)
2023-09-22 16:01:17 +00:00
Agustina Martinez
f330e36528 Remove unused imports
(cherry picked from commit 4bd2cfdf0f)
2023-09-22 16:01:17 +00:00
Agustina Martinez
f88207792a Refactored access-status to include embargo date based on the DefaultAccessStatusHelper logic (look at primary or first bitstream)
(cherry picked from commit 895926f021)
2023-09-22 16:01:17 +00:00
Agustina Martinez
3f5bfe4aa4 ItemUtils.java: improved method to account for multiple embargo policies and select the longest embargo
(cherry picked from commit 538be7f09b)
2023-09-22 16:01:17 +00:00
Agustina Martinez
c5ca59f2e5 ItemUtils.java: added method doc
(cherry picked from commit 51e60fbcf9)
2023-09-22 16:01:17 +00:00
Agustina Martinez
c711d2d944 OAI: add support to extract embargo from bitstreams and expose it in OAI metadata
(cherry picked from commit db81d758a9)
2023-09-22 16:01:17 +00:00
Tim Donohue
dd09fd7a7d Merge pull request #9079 from TexasDigitalLibrary/DS-3994-7_x
[Port dspace-7_x] DS-3994: fix logical bug when checking if field is controlled authority
2023-09-21 10:51:38 -05:00
Alan Orth
57fa641105 Merge pull request #9082 from TexasDigitalLibrary/DS-7936-7_x
[Port dspace-7_x] DS-7936: remove optimize option (-o) from oai import
2023-09-20 08:13:15 +03:00
nwoodward
8027d3b305 added authorization check for license bitstream in OAI import 2023-09-19 16:03:22 -05:00
nwoodward
2667b8d187 remove optimize option from oai import 2023-09-19 15:43:29 -05:00
nwoodward
8271c4d07b fix logical bug when checking if field is controlled authority 2023-09-18 15:34:23 -05:00
Tim Donohue
88f4cdafcf Merge pull request #9077 from DSpace/backport-9067-to-dspace-7_x
[Port dspace-7_x] Remove 'cross join' from count query in `update-handle-prefix` script
2023-09-15 09:56:33 -05:00
Tim Donohue
f23fd92928 Merge pull request #9072 from DSpace/backport-9068-to-dspace-7_x
[Port dspace-7_x] Fix ClassCastException (Collection cannot be cast to Item) in some Handle classes which cause random IT failures
2023-09-15 09:55:01 -05:00
Tim Donohue
e757b9d9f4 Remove 'cross join' from count query. Updates "countHandlesByPrefix" to use a query similar to existing "findByPrefix"
(cherry picked from commit 14223bd712)
2023-09-15 14:38:12 +00:00
Hrafn Malmquist
4dedb3cf41 Merge pull request #9073 from DSpace/backport-9041-to-dspace-7_x
[Port dspace-7_x] Avoid double slashes in sitemap paths.
2023-09-15 12:52:59 +01:00
Mark H. Wood
7b2b8db512 Avoid double slashes in sitemap paths.
(cherry picked from commit eae4463eaa)
2023-09-15 09:22:37 +00:00
Tim Donohue
42e2e4b0c8 Fix checkstyle. Correct grammar of comment while doing so.
(cherry picked from commit ffa2683c63)
2023-09-14 18:01:23 +00:00
Tim Donohue
d965057854 Fix ClassCastException (Collection cannot be cast to Item) in Handle identifier classes
(cherry picked from commit 1271374d37)
2023-09-14 18:01:23 +00:00
Tim Donohue
5a91da6f0e Merge pull request #9065 from DSpace/backport-8828-to-dspace-7_x
[Port dspace-7_x] Add a "container friendly" log4j2 cfg and output compose dspace log to console
2023-09-13 09:34:23 -05:00
Mark Cooper
f036467aa3 Add a "container friendly" log4j2 cfg and output compose dspace log to console
(cherry picked from commit 9eefd56cd7)
2023-09-13 01:33:55 +00:00
Alan Orth
36e9a88d9c Merge pull request #9063 from DSpace/backport-9058-to-dspace-7_x
[Port dspace-7_x] Expose OpenSearch configuration properties in the REST API
2023-09-12 12:11:43 +03:00
Hrafn Malmquist
ba197ef611 Add websvc.opensearch.autolink and websvc.opensearch.shortname to exposed REST configuration properties
(cherry picked from commit 80b35c9650)
2023-09-12 08:08:46 +00:00
Tim Donohue
02d347d72f Merge pull request #8948 from toniprieto/disable-hierarchical-browse-indexes
Add a configuration key to disable hierarchical browse indexes
2023-09-08 14:39:05 -05:00
Tim Donohue
ff393fe72d Add note that rebooting Tomcat required 2023-09-08 14:01:25 -05:00
Tim Donohue
6d005e356c Merge pull request #9055 from DSpace/backport-9051-to-dspace-7_x
[Port dspace-7_x] Bump org.eclipse.jetty:jetty-xml from 9.4.51.v20230217 to 9.4.52.v20230823
2023-09-07 13:11:44 -05:00
dependabot[bot]
732314018d Bump org.eclipse.jetty:jetty-xml
Bumps [org.eclipse.jetty:jetty-xml](https://github.com/eclipse/jetty.project) from 9.4.51.v20230217 to 9.4.52.v20230823.
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.51.v20230217...jetty-9.4.52.v20230823)

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-xml
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit 2bcc0b38a9)
2023-09-07 17:24:22 +00:00
Tim Donohue
4964eee108 Merge pull request #9054 from DSpace/backport-8924-to-dspace-7_x
[Port dspace-7_x] Rename test suites that are really integration testing.
2023-09-07 11:02:16 -05:00
Mark H. Wood
1b769de42a Rename test suites that are really integration testing.
(cherry picked from commit f66ca33b06)
2023-09-07 15:24:13 +00:00
Tim Donohue
f68856b12c Merge pull request #8949 from atmire/w2p-103837_GA4-exclude-non-content-bitstream-views-7.x
Exclude non-content bitstream view events from Google Analytics 4 (dspace-7_x)
2023-09-06 16:53:45 -05:00
Nona Luypaert
066fd53e98 Merge branch 'w2p-103837_GA4-exclude-non-content-bitstream-views-7.4' into w2p-103837_GA4-exclude-non-content-bitstream-views-7.x 2023-09-06 19:50:19 +02:00
Nona Luypaert
997057f8e4 103837: Fix isContentBitstream() in GoogleAsyncEventListener 2023-09-06 19:48:55 +02:00
Koen Pauwels
5fbc988518 Fix failing IT in BulkAccessControlIT 2023-08-24 14:55:43 +02:00
Koen Pauwels
5703dcb033 104878 Adjust ItemServiceTest to expect correct behavior of bundles when item is migrated 2023-08-24 14:55:43 +02:00
Koen Pauwels
54f174da04 104878 Fix error in ItemServiceTest related to inheriting collection policies upon item move 2023-08-24 14:55:43 +02:00
Koen Pauwels
502230b271 103818 Extend ItemServiceTest#testMoveItemToCollectionWithMoreRestrictiveReadPolicy 2023-08-24 14:55:43 +02:00
Koen Pauwels
8f4505207e 103818 Add boolean parameters to ItemServiceImpl methodds to decide whether to override read policies 2023-08-24 14:55:43 +02:00
Koen Pauwels
03961316dd 103818 Add boolean parameter to ItemServiceImpl#inheritCollectionDefaultPolicies to decide whether to override item read policies 2023-08-24 14:55:43 +02:00
Koen Pauwels
5e627b5ac8 103818 ItemServiceImpl#inheritCollectionDefaultPolicies now clears item READ policies if new parent collection has a default READ policy 2023-08-24 14:55:43 +02:00
Alan Orth
d307727b4f Merge pull request #9037 from DSpace/backport-9018-to-dspace-7_x
[Port dspace-7_x] Fix different CLI commands throw an exception on help argument
2023-08-24 11:40:08 +03:00
Alan Orth
1fc8fc637c dspace-api: remove unnecessary trailing whitespace 2023-08-24 10:57:16 +03:00
Tim Donohue
bd1eb00d2d Enable new skip merge commit feature 2023-08-23 17:03:08 -05:00
Christian Bethge
7f1875c945 remove not necessary else
(cherry picked from commit 064e2caa37)
2023-08-23 21:59:17 +00:00
Christian Bethge
8045f6a014 add DSpaceSkipUnknownArgumentsParser as parser to ignore/skip unknown arguments in cli by help, fix not necessary ParseException in help
(cherry picked from commit 86285d78aa)
2023-08-23 21:59:17 +00:00
Christian Bethge
a1f356ab33 ingore unrecognized arguments on help
(cherry picked from commit 82c9b6fc9b)
2023-08-23 21:59:17 +00:00
Christian Bethge
f776cec837 fix stylecheck
(cherry picked from commit b1377ca1ef)
2023-08-23 21:59:17 +00:00
Christian Bethge
ae2c253082 fix MissingOptionException on help
(cherry picked from commit 8ae5ffbf9b)
2023-08-23 21:59:17 +00:00
Alan Orth
c88a25f16c Merge pull request #9034 from DSpace/backport-9025-to-dspace-7_x
[Port dspace-7_x] 3331 - remove the --optimize feature of 'dspace stats-util'
2023-08-23 15:56:02 +03:00
aroman-arvo
79e47837ae 3331 - remove the --optimize feature of 'dspace stats-util'
(cherry picked from commit 08c650921d)
2023-08-23 12:16:35 +00:00
Alan Orth
785d07087a Merge pull request #9008 from MW3000/fix-8963-remove-deletion-constraint-from-groomer-tool
Fix #8963: Remove deletion constraint from Groomer
2023-08-23 12:48:45 +03:00
Tim Donohue
c2402b1a4f Merge pull request #9032 from DSpace/backport-9016-to-dspace-7_x
[Port dspace-7_x] Avoid requiring git as a build dependency
2023-08-22 16:06:41 -05:00
Hrafn Malmquist
c08f762525 Bump up versions of buildnumber-maven-plugin & build-helper-maven-plugin. add configuration for SCM failure
(cherry picked from commit 78ea9e86df)
2023-08-22 20:24:45 +00:00
Tim Donohue
92a1dddecf Merge pull request #9031 from DSpace/backport-9029-to-dspace-7_x
[Port dspace-7_x] README.md: Fix typo
2023-08-22 10:50:02 -05:00
Christian Clauss
e6829c7b42 README.md: Fix typo
(cherry picked from commit ca8abddff1)
2023-08-22 15:42:55 +00:00
Nona Luypaert
681cfeed4d Merge branch 'w2p-103837_GA4-exclude-non-content-bitstream-views-7.4' into w2p-103837_GA4-exclude-non-content-bitstream-views-7.x 2023-08-17 16:59:12 +02:00
Nona Luypaert
22e209322c 103837: Refactor GA config to list bundles 2023-08-17 16:43:21 +02:00
Tim Donohue
4df8b86217 Merge pull request #9023 from DSpace/backport-9021-to-dspace-7_x
[Port dspace-7_x] Remove useless log.info
2023-08-09 14:50:35 -05:00
Tim Donohue
b5f2f67ead Remove useless log.info
(cherry picked from commit 1f3ad993cc)
2023-08-09 15:17:31 +00:00
Tim Donohue
e3186cbbb1 Merge pull request #9020 from DSpace/backport-8991-to-dspace-7_x
[Port dspace-7_x] On media filter failure log the name of the assetstore file and trace causes of exception
2023-08-09 09:24:36 -05:00
Mark H. Wood
65241b7a3e More description on OutOfMemoryError too.
(cherry picked from commit bbe5df3f7d)
2023-08-08 21:41:26 +00:00
Mark H. Wood
8db2f18143 Report Throwable's type too.
(cherry picked from commit d6b612fc5c)
2023-08-08 21:41:26 +00:00
Mark H. Wood
40ced53032 On failure log the name of the assetstore file and trace causes of exception.
(cherry picked from commit 22974e982c)
2023-08-08 21:41:26 +00:00
Tim Donohue
8f65a46736 Merge pull request #8952 from mwoodiupui/8500-7_x
Missing subject in template-based e-mails 7_x
2023-08-04 13:26:12 -05:00
Tim Donohue
0b5e70369a Merge pull request #9013 from tdonohue/port_8940
[Port dspace-7_x] Fix #8933: Only add the base statistic core if it hasn't already been added
2023-08-04 11:23:16 -05:00
Max Nuding
59f14cf67a Remove duplicate code 2023-08-04 10:39:00 -05:00
max.nuding
a3f2bd0bb7 Fix #8933: Only add the base statistic core if it hasn't already been added 2023-08-04 10:38:52 -05:00
Tim Donohue
df04b6ecf6 Merge pull request #9012 from DSpace/backport-9007-to-dspace-7_x
[Port dspace-7_x] 9006 geoip fix referenced configuration
2023-08-04 09:20:24 -05:00
Alan Orth
5fccd6190f Merge pull request #9011 from DSpace/backport-8936-to-dspace-7_x
[Port dspace-7_x] DS-8935. webui.browse.link CrossLinks - Fix for multiple exact matches
2023-08-04 16:54:17 +03:00
Christian Bethge
dd5c810b0c #9006 fix referenced configuration file (Test)
(cherry picked from commit 309b0b355e)
2023-08-03 21:54:31 +00:00
Christian Bethge
066dfbc849 #9006 fix referenced configuration file
(cherry picked from commit 29a88d7e2d)
2023-08-03 21:54:31 +00:00
David P. Steelman
2180b4e535 DS-8935. webui.browse.link CrossLinks - Fix for multiple exact matches
Fixes #8935 when multiple exact match "webui.browse.link" configuration
entries are present that point to different indexes.

Modified the code to return the index associated with the given
metadata (which is used as the key in the hash map), instead of the key
from the keySet (which may not actually be the metadata value being
searched for).

https://github.com/DSpace/DSpace/issues/8935
(cherry picked from commit b846c53baa)
2023-08-03 21:37:19 +00:00
Tim Donohue
409182a067 Merge pull request #9010 from DSpace/backport-8961-to-dspace-7_x
[Port dspace-7_x] 'null' value is passed to sendErrorResponse instead of actual exception
2023-08-03 14:09:39 -05:00
corrado lombardi
81cbb6692c [DURACOM-179] replaced 'null' value with exception actual value in sendErrorResponse method calls having 'null'
(cherry picked from commit aa35a47add)
2023-08-03 17:31:36 +00:00
Tim Donohue
53222a005b Merge pull request #9009 from DSpace/backport-9004-to-dspace-7_x
[Port dspace-7_x] Enable entity type to submission form mapping by default
2023-08-03 12:08:07 -05:00
Tim Donohue
f803a2acf1 Enable entity type to submission form mapping by default
(cherry picked from commit b71eee89c1)
2023-08-03 16:22:28 +00:00
Martin Walk
e07763b021 Fix #8963: Remove deletion constraint from Groomer 2023-08-03 13:39:43 +02:00
Tim Donohue
eb7cdb1d21 Merge pull request #9003 from DSpace/backport-8983-to-dspace-7_x
[Port dspace-7_x] Remove old webui properties from dspace.cfg
2023-08-02 15:55:08 -05:00
Alan Orth
acf27a5d76 dspace.cfg: remove old webui.itemlist.browse.* property
The webui.itemlist.browse.* properties are no longer used in DSpace
7.

(cherry picked from commit 35f72bc9d0)
2023-08-02 20:15:57 +00:00
Alan Orth
6e4490197b dspace.cfg: remove old webui.browse.thumbnail.show property
The webui.browse.thumbnail.show property is no longer used as of
DSpace 7. Also remove subsequent references to adding thumbnails
to item view columns since these are from legacy DSpace.

(cherry picked from commit 213a546486)
2023-08-02 20:15:57 +00:00
Alan Orth
41c992a231 dspace.cfg: remove old webui.itemlist properties
These properties are no longer used in DSpace 7:

    webui.itemlist.widths
    webui.itemlist.*.widths
    webui.itemlist.tablewidth

(cherry picked from commit 16c46c4979)
2023-08-02 20:15:57 +00:00
Tim Donohue
fadfdc6ed2 Merge pull request #8997 from tdonohue/port_8955
[Port dspace-7_x] Prevent NPE during indexing if bitstream is null
2023-07-28 15:09:27 -05:00
Agustina Martinez
e4c639c905 Update ItemUtils.java
Prevent npe if bitstream is null
2023-07-28 13:57:37 -05:00
Agustina Martinez
7b54dde3a6 Update FullTextContentStreams.java
Add additional NPE checks
2023-07-28 13:57:29 -05:00
Agustina Martinez
06b54d5afa Update FullTextContentStreams.java
Fix NPE if bitstream is null
2023-07-28 13:57:22 -05:00
dependabot[bot]
0ad1998ff5 Bump h2 from 2.1.214 to 2.2.220
Bumps [h2](https://github.com/h2database/h2database) from 2.1.214 to 2.2.220.
- [Release notes](https://github.com/h2database/h2database/releases)
- [Commits](https://github.com/h2database/h2database/compare/version-2.1.214...version-2.2.220)

---
updated-dependencies:
- dependency-name: com.h2database:h2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-07-28 13:35:16 -05:00
Tim Donohue
8b34195f31 Merge pull request #8996 from DSpace/backport-8995-to-dspace-7_x
[Port dspace-7_x] Fix typo. Config must be a valid regex
2023-07-28 12:23:18 -05:00
Tim Donohue
867331e3af Fix typo. Config must be a valid regex
(cherry picked from commit 799528963e)
2023-07-28 16:55:08 +00:00
Tim Donohue
d1539efe9a Minor update to label_merge_conflicts to ignore any errors (seem random at this time) 2023-07-28 11:41:37 -05:00
Tim Donohue
0162853bb5 Run PR Port action as 'dspace-bot' to allow new PRs to trigger CI checks 2023-07-28 11:41:28 -05:00
Tim Donohue
e45e4f9831 Merge pull request #8992 from DSpace/backport-8988-to-dspace-7_x
[Port dspace-7_x] Add GitHub action to automatically create a port PR (based on label)
2023-07-28 10:51:08 -05:00
Tim Donohue
657312c8f0 Add action to automatically create a port PR when specified
(cherry picked from commit f6a898c3d1)
2023-07-28 15:13:25 +00:00
Sascha Szott
6fe61b4a8e remove obsolete code fragments 2023-07-27 11:52:38 -05:00
Sean Kalynuk
4c329b4319 Fixes #8558 - set Solr UTC timezone
Set the timezone of the Solr date formatter to UTC
2023-07-26 11:27:32 -05:00
Tim Donohue
db2a6d98d7 Merge pull request #8959 from tdonohue/port_8941
Port recent GitHub Actions changes to `dspace-7_x` branch
2023-07-14 16:15:21 -05:00
Tim Donohue
f9b7f780fc Merge pull request #8958 from tdonohue/port_8953
[PORT to 7.x] Add flag Pattern.UNICODE_CHARACTER_CLASS to pattern compilation to recognize unicode characters
2023-07-14 16:01:19 -05:00
Tim Donohue
dd8bfffedb Ensure 'main' code is tagged as 'latest' in DockerHub 2023-07-14 15:35:58 -05:00
Tim Donohue
211529f97f Split docker image builds into separate jobs to allow them to run in parallel. 2023-07-14 15:35:50 -05:00
Tim Donohue
4471a2dc23 Ensure codescan and label_merge_conflicts run on maintenance branches 2023-07-14 15:35:35 -05:00
Tim Donohue
2ebe1d69e4 Enable Pull Request Opened action to assign PRs to their creator 2023-07-14 15:35:26 -05:00
Toni Prieto
69f4829edb Add flag Pattern.UNICODE_CHARACTER_CLASS to pattern compilation to recognize unicode characters 2023-07-14 15:26:43 -05:00
Mark H. Wood
03f24a3339 Simplify and modernize the code. Store content directly in the template. 2023-07-12 12:55:41 -04:00
Mark H. Wood
d9f4ae7a89 Don't clear the list of accepted embedded message header properties.
Why was this cleared?
2023-07-12 12:55:41 -04:00
Mark H. Wood
334a02c2be More and better(?) documentation. 2023-07-12 12:55:41 -04:00
Nona Luypaert
b69201f147 Merge branch 'dspace-7_x' into w2p-103837_GA4-exclude-non-content-bitstream-views-7.x
Conflicts:
	dspace/config/dspace.cfg
2023-07-11 11:42:39 +02:00
Toni Prieto
e55bc87c1a Add a configuration key to disable hierarchical browse indexes 2023-07-10 12:11:45 +02:00
Nona Luypaert
1b94aecb26 103837: Only send GA4 events for ORIGINAL bitstreams + ITs 2023-07-06 16:48:10 +02:00
Tim Donohue
ea4565bd60 [maven-release-plugin] prepare branch dspace-7_x 2023-06-30 14:37:06 -05:00
Alan Orth
1e680009cf Merge pull request #8931 from toniprieto/ignore-vocabulary-index-without-facet
Fix for NullPointerException when enumerating browses for vocabularies without Discovery indexes
2023-06-30 20:56:45 +03:00
Toni Prieto
af55090245 Ignore vocabulary indexes without discovery facet to avoid NPE 2023-06-30 20:21:59 +03:00
Tim Donohue
43a4a79045 Merge pull request #8910 from DSpace/dependabot/maven/dspace-api/io.netty-netty-handler-4.1.94.Final
Bump netty-handler from 4.1.68.Final to 4.1.94.Final in /dspace-api
2023-06-30 10:02:39 -05:00
Alan Orth
e46681fc20 Merge pull request #8928 from toniprieto/improve-performance-auto-reindex
Improve performance of automatic discovery re-index after database changes
2023-06-29 20:46:21 +03:00
Toni Prieto
2b5c4a5f4a Improve performance of automatic discovery re-index after database changes 2023-06-29 13:00:59 +02:00
Tim Donohue
a533704a27 [maven-release-plugin] prepare for next development iteration 2023-06-23 12:10:56 -05:00
Tim Donohue
5a43e6bcf1 [maven-release-plugin] prepare release dspace-7.6 2023-06-23 12:10:53 -05:00
Tim Donohue
01c761281c Update LICENSES_THIRD_PARTY for 7.6 2023-06-23 11:50:12 -05:00
Tim Donohue
da657dbc67 Merge pull request #8905 from 4Science/DURACOM-156
[DURACOM-156] Signposting: feedback after initial deployment
2023-06-23 11:17:14 -05:00
Nikita Krivonosov
df4cff7dd1 [DURACOM-156] Singposting: feedback after initial deployment 2023-06-23 17:24:42 +02:00
Nikita Krivonosov
890f2a15e5 [DURACOM-156] Singposting: feedback after initial deployment 2023-06-23 11:45:07 +02:00
NikitaKr1vonosov
1fe90a236d Merge branch 'main' into DURACOM-156 2023-06-23 09:47:20 +02:00
Nikita Krivonosov
12fe87fc37 [DURACOM-156] Singposting: feedback after initial deployment 2023-06-23 09:46:46 +02:00
Nikita Krivonosov
55bfd4b2e5 [DURACOM-156] Singposting: feedback after initial deployment 2023-06-23 00:47:09 +02:00
Nikita Krivonosov
907c45a455 [DURACOM-156] Singposting: feedback after initial deployment 2023-06-21 17:27:20 +02:00
Tim Donohue
b52a4fb50d Update all Netty dependencies to 4.1.94.Final
Also had to add netty-transport-native-unix-common so that Solr doesn't throw dependency convergence issues.
2023-06-20 13:23:49 -05:00
dependabot[bot]
cf1257f20e Bump netty-handler from 4.1.68.Final to 4.1.94.Final in /dspace-api
Bumps [netty-handler](https://github.com/netty/netty) from 4.1.68.Final to 4.1.94.Final.
- [Commits](https://github.com/netty/netty/compare/netty-4.1.68.Final...netty-4.1.94.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-handler
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-06-20 16:35:40 +00:00
Tim Donohue
4ea5426d61 Merge pull request #8854 from tdonohue/disable_dtd_parsing_in_sources
Disable DTD parsing in all external source plugins
2023-06-20 09:22:15 -05:00
Tim Donohue
c5ec38551c Merge pull request #8875 from atmire/w2p-102057_refferer-fix-main
The referrer for a statistics view event is almost always wrong
2023-06-20 09:20:35 -05:00
Tim Donohue
4d4899cc3a Merge pull request #8904 from DSpace/dependabot/maven/com.google.guava-guava-32.0.0-jre
Bump guava from 31.0.1-jre to 32.0.0-jre
2023-06-16 15:58:18 -05:00
dependabot[bot]
7dd34ccc50 Bump guava from 31.0.1-jre to 32.0.0-jre
Bumps [guava](https://github.com/google/guava) from 31.0.1-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-06-16 20:23:12 +00:00
Tim Donohue
4c0b60418d Merge pull request #8813 from sistedes/feature-imagemagick-video
New ImageMagick-based media filter to generate video thumbnails
2023-06-16 15:19:14 -05:00
Tim Donohue
eda2c8811c Merge pull request #8901 from kshepherd/default_bundle_permissions
Fix to adjusting bundle and bitstream policies (item install, embargo lift)
2023-06-16 15:04:57 -05:00
Tim Donohue
fff633690c Merge pull request #8903 from alexandrevryghem/remove-publicdomain-from-cclicence-section
Hide publicdomain by default since it's now the same as CC0
2023-06-16 15:03:36 -05:00
Tim Donohue
b661056118 Merge pull request #8908 from mwoodiupui/8907
Request a Copy sends same email regardless of accept or reject
2023-06-16 12:07:37 -05:00
Tim Donohue
3ff5eb61c0 Fix to adjusting bundle and bitstream policies (item install, embargo lift)
Apply DEFAULT_ITEM_READ to bundles, not DEFAULT_BITSTREAM_READ so that
files can be listed if the item / default item is readable
Co-authored-by: kshepherd <kim@shepherd.nz>
Co-authored-by: tdonohue <tim.donohue@lyrasis.org>
2023-06-16 11:14:51 -05:00
Tim Donohue
240bfbfdc9 Fix to adjusting bundle and bitstream policies (item install, embargo lift)
Apply DEFAULT_ITEM_READ to bundles, not DEFAULT_BITSTREAM_READ so that
files can be listed if the item / default item is readable
2023-06-16 11:00:03 -05:00
Tim Donohue
aec3298da0 Merge pull request #8844 from 4Science/duracom-136_CST-9634
Bulk Access Control Script REST implementation
2023-06-16 10:48:18 -05:00
Yana De Pauw
013b95ea2a 102888: Implement feedback 2023-06-16 14:37:19 +02:00
NikitaKr1vonosov
3bba9979c3 Merge branch 'main' into DURACOM-156 2023-06-16 02:04:24 +02:00
Nikita Krivonosov
55c07e90cd [DURACOM-156] Singposting: feedback after initial deployment 2023-06-16 01:53:48 +02:00
Mark H. Wood
8adb16f945 Invent a rejection letter 2023-06-15 17:01:00 -04:00
Tim Donohue
f216f4c7fc Merge pull request #8891 from atmire/w2p-102124_bitstream-formats-download-attachment-main
Configuration for opening bitstream formats as attachment
2023-06-15 13:07:31 -05:00
Tim Donohue
176e93eb01 Merge pull request #8848 from alexandrevryghem/issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-main
Adding/removing relationships in the submission form does not update the view automatically
2023-06-15 11:45:01 -05:00
NikitaKr1vonosov
9137689cdc Merge branch 'main' into DURACOM-156 2023-06-15 09:21:46 +02:00
Nona Luypaert
dd951407a7 Merge branch 'w2p-102124_bitstream-formats-download-attachment-7.2' into w2p-102124_bitstream-formats-download-attachment-main
Conflicts:
	dspace-api/src/test/data/dspaceFolder/config/local.cfg
2023-06-15 00:00:42 +02:00
Alexandre Vryghem
1cb60a9018 Hide publicdomain by default since it's now the same as CC0
More info: https://api.creativecommons.org/docs/readme_15.html#changes-since-1-0
2023-06-14 23:48:27 +02:00
Nona Luypaert
7c7f3e2853 102124: Move content-disposition test config from local.cfg to IT itself 2023-06-14 23:47:36 +02:00
Tim Donohue
bbb75df3a1 Disable DTD parsing in all external source plugins to avoid XXEs 2023-06-14 16:12:45 -05:00
Tim Donohue
43f5eeb9ed Merge pull request #8843 from damian-joz/1787-coll-comm-item-counts
Item counters added to Communities and Collections REST API
2023-06-14 14:07:49 -05:00
Tim Donohue
49882a206c Merge pull request #8833 from mwoodiupui/reqitem-response
Get request-copy response email body from backend templates, as with all other emails
2023-06-14 13:18:21 -05:00
Tim Donohue
252bf8fe41 Merge pull request #8876 from atmire/contract-pr-222-primary-bitstream-on-bundle-support
Primary bitstream support for the REST api - Rework
2023-06-14 11:45:08 -05:00
Mark H. Wood
9caba7044b Remove test for removed content. 2023-06-14 10:53:49 -04:00
Mark H. Wood
411ac4a9a2 Clarify template comments. 2023-06-14 10:21:01 -04:00
Mark H. Wood
4abcfc8bf3 Rework message to make it more useful, more businesslike, not expose author's email by default. 2023-06-14 10:17:20 -04:00
damian
ca7c75987e Items count are now disabled by default. Naming changes. 2023-06-13 19:58:42 +02:00
Nikita Krivonosov
63e1519c6e [DURACOM-156] Singposting: feedback after initial deployment 2023-06-13 15:22:21 +02:00
Tim Donohue
e0631e745b Merge pull request #8889 from atmire/fix-issue-8888
[Issue: #8888] Fixing the hostname parsing for the shibboleth auth
2023-06-12 11:31:28 -05:00
Nona Luypaert
c0239cf174 Merge branch 'w2p-102124_bitstream-formats-download-attachment-7.2' into w2p-102124_bitstream-formats-download-attachment-main 2023-06-12 11:42:49 +02:00
Nona Luypaert
af8cf8671b 102124: Update webui.content_disposition_format comment 2023-06-12 11:41:33 +02:00
Tim Donohue
9c6d2bfaa8 Merge pull request #8831 from 4Science/CST-5728
[CST-5728] LYRASIS [Donated]: DSpace7: Implement signposting pattern …
2023-06-09 16:03:03 -05:00
Nona Luypaert
1d484f4a0b 102052: 403 checks for Admin ITs in PrimaryBitstreamControllerIT 2023-06-09 22:23:00 +02:00
Nona Luypaert
504bc1a61b Merge branch 'main' into w2p-102124_bitstream-formats-download-attachment-main 2023-06-09 20:41:35 +02:00
Tim Donohue
a57bca06a2 Merge pull request #8898 from DSpace/dependabot/maven/dspace-api/org.scala-lang-scala-library-2.13.9
Bump scala-library from 2.13.2 to 2.13.9 in /dspace-api
2023-06-09 11:34:02 -05:00
damian
ff504e35d1 Variable naming change. Javadocs addded. 2023-06-09 16:56:26 +02:00
dependabot[bot]
1ab04518a3 Bump scala-library from 2.13.2 to 2.13.9 in /dspace-api
Bumps [scala-library](https://github.com/scala/scala) from 2.13.2 to 2.13.9.
- [Release notes](https://github.com/scala/scala/releases)
- [Commits](https://github.com/scala/scala/compare/v2.13.2...v2.13.9)

---
updated-dependencies:
- dependency-name: org.scala-lang:scala-library
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-06-09 14:42:46 +00:00
Tim Donohue
056a910f86 Merge pull request #8500 from 4Science/DURACOM-92
Further S3 large file optimization
2023-06-09 09:42:18 -05:00
Yury Bondarenko
1b1830f037 Remove unnecessary DescribeStep change
As far as I can tell this never did anything
  - `relationship.*` is not a valid MDF, so it's unclear what it was supposed to do
  - everything keeps working if I leave this part out
2023-06-09 15:31:50 +02:00
damian
c6cf19d40c Merge branch 'main' into 1787-coll-comm-item-counts
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/CollectionServiceImpl.java
#	dspace-api/src/main/java/org/dspace/content/service/CollectionService.java
2023-06-09 12:18:38 +02:00
Francesco Pio Scognamiglio
8764724159 Merge branch 'main' into DURACOM-92 2023-06-09 09:39:31 +02:00
Nona Luypaert
59caeb5875 Merge branch 'main' into contract-pr-222-primary-bitstream-on-bundle-support 2023-06-08 23:09:52 +02:00
Nona Luypaert
c5028f7f1f 102052: Small improvements 2023-06-08 23:08:48 +02:00
Nona Luypaert
1b06c64454 102052: Remove getPrimaryBitstream from PrimaryBitstreamController 2023-06-08 21:49:13 +02:00
Tim Donohue
f55e21e271 Merge pull request #8855 from paulo-graca/enhancement/addressing-#8633
Default submission forms per Entity type
2023-06-08 14:25:45 -05:00
Nona Luypaert
377e22eb65 Merge branch 'w2p-102124_bitstream-formats-download-attachment-7.2' into w2p-102124_bitstream-formats-download-attachment-main 2023-06-08 20:57:26 +02:00
Nona Luypaert
a00dd83a0c 102124: Avoid null pointer when checking disposition 2023-06-08 20:47:27 +02:00
Andrea Bollini
33929fa6bf Merge branch 'main' of https://github.com/DSpace/DSpace into duracom-136_CST-9634 2023-06-08 19:56:22 +02:00
Tim Donohue
4deab95b14 Merge pull request #8894 from 4Science/DURACOM-153
[DURACOM-153] fix validation to use the retrieved zip file on saf import
2023-06-08 11:27:47 -05:00
Francesco Pio Scognamiglio
6794c80afe Merge branch 'main' into DURACOM-153 2023-06-08 17:44:56 +02:00
Tim Donohue
c2ad791bc9 Merge pull request #8830 from 4Science/duracom-136
Allow script execution by user other than admins - starting from the curate script
2023-06-08 10:35:09 -05:00
Francesco Pio Scognamiglio
7757c4e898 [DURACOM-153] fix validation to use the retrieved zip file on saf import 2023-06-08 13:51:25 +02:00
Nikita Krivonosov
39df261411 [CST-5728] LYRASIS [Donated]: DSpace7: Implement signposting pattern in DSpace (REST) 2023-06-08 11:51:48 +02:00
Kristof De Langhe
3f2e2b819a Merge branch 'main' into w2p-102057_refferer-fix-main 2023-06-08 10:08:09 +02:00
NikitaKr1vonosov
44b948e71c Merge branch 'main' into CST-5728 2023-06-08 00:20:29 +02:00
Nikita Krivonosov
f8e3dad234 [CST-5728] LYRASIS [Donated]: DSpace7: Implement signposting pattern in DSpace (REST) 2023-06-08 00:12:14 +02:00
Tim Donohue
13344aabf9 Merge pull request #8869 from paulo-graca/enhancement/xoai-access-status-plugin
new Access Status XOAI plugin
2023-06-07 16:53:35 -05:00
Tim Donohue
7bbb5f438b Merge pull request #8829 from mspalti/iiif-search-plugin-update
Updated IIIF content search solr query params.
2023-06-07 09:40:09 -05:00
Mohamed Saber Eskander
f7ff85bbd5 solved issue of 'could not initialize proxy - no Session' 2023-06-07 12:53:19 +03:00
Paulo Graça
ce9e9fcc95 Merge branch 'main' into enhancement/addressing-#8633 2023-06-07 08:34:23 +01:00
NikitaKr1vonosov
2a1b24a058 Merge branch 'main' into CST-5728 2023-06-07 09:04:02 +02:00
Nikita Krivonosov
11df3b8d63 [CST-5728] LYRASIS [Donated]: DSpace7: Implement signposting pattern in DSpace (REST) 2023-06-07 08:49:47 +02:00
Nona Luypaert
c7375acf39 Merge branch 'main' into w2p-102124_bitstream-formats-download-attachment-main 2023-06-07 08:46:30 +02:00
Nona Luypaert
da48803d3d Merge branch 'w2p-102124_bitstream-formats-download-attachment-7.2' into w2p-102124_bitstream-formats-download-attachment-main 2023-06-07 08:43:45 +02:00
Nona Luypaert
bca98cd8f4 102124: Don't loop over extensions if mimetype was already found 2023-06-07 08:33:51 +02:00
Tim Donohue
bf8df5b1e8 Merge pull request #8758 from alexandrevryghem/w2p-100553_fix-metadata-registry-bugs_contribute-7.4
Added input validation for new metadata field submissions & fixed some other bugs related to metadata fields
2023-06-06 14:33:38 -05:00
Andrea Bollini
5a8c7a397c DURACOM-136 open endpoints to retrieve files of process to the user that has triggered the process 2023-06-06 20:12:23 +02:00
Andrea Bollini
32cd24b753 DURACOM-136 restrict script endpoints to authenticated users, add test to proof that standard script are reseved to site administrator 2023-06-06 19:45:31 +02:00
Tim Donohue
ea7272ec00 Merge pull request #8874 from mwoodiupui/service-lookup
Make service lookup retry log at DEBUG; radically shorten the trace.
2023-06-06 12:26:36 -05:00
eskander
6848ab20bd Merge remote-tracking branch 'origin/main' into duracom-136_CST-9634
# Conflicts:
#	dspace/config/spring/api/discovery.xml
2023-06-06 17:30:53 +03:00
Mohamed Saber Eskander
f2a63d9636 added new test cases
added JavaDocs
refactoring
2023-06-06 17:21:20 +03:00
Andrea Bollini
2b523ba5ac DURACOM-136 improve handling and testing of invalid mimetype 2023-06-06 16:01:47 +02:00
Andrea Bollini
14bb32036c DURACOM-136 add explaination of the commandLineParameters in the javadoc 2023-06-06 16:01:04 +02:00
Paulo Graça
3e6e795c3d Merge branch 'main' into enhancement/xoai-access-status-plugin 2023-06-06 14:03:59 +01:00
Paulo Graça
8bc8efc64e Merge branch 'main' into enhancement/addressing-#8633 2023-06-06 12:44:24 +01:00
Nona Luypaert
04161a0c4d 102124: Fix BitstreamRestController after merge 2023-06-06 11:24:10 +02:00
Kevin Van de Velde
3945d164e6 [Issue: #8888] Fixing the hostname parsing for the shibboleth auth 2023-06-06 08:35:18 +02:00
Tim Donohue
4b3e271468 Merge pull request #8887 from tdonohue/fix_test
Fix test class compilation
2023-06-05 16:40:11 -05:00
Tim Donohue
a0a1844de7 Fix test class compilation 2023-06-05 16:01:31 -05:00
Tim Donohue
333c7da729 Merge pull request #8623 from atmire/discovery-fixes
Fixes for scope based searching and indexing in Discovery
2023-06-05 15:37:21 -05:00
Tim Donohue
58c71bbeab Merge pull request #8485 from atmire/w2p-94299_Multiple_Bitstream_deletion_endpoint
multiple bitstream deletion endpoint
2023-06-05 15:35:45 -05:00
Tim Donohue
61db65ead5 Merge pull request #8826 from atmire/contract-pr-225-browse-by-support-for-controlled-vocabulary-main
Browse by Controlled Vocabulary (hierarchicalBrowse)
2023-06-05 15:31:37 -05:00
Paulo Graça
5d7c26c3d5 Merge branch 'main' into enhancement/xoai-access-status-plugin 2023-06-05 15:45:24 +01:00
Paulo Graça
5dfb49a5a8 Merge branch 'main' into enhancement/addressing-#8633 2023-06-05 15:45:10 +01:00
Nona Luypaert
826f393e33 Merge branch 'w2p-102124_bitstream-formats-download-attachment-7.2' into w2p-102124_bitstream-formats-download-attachment-main
Conflicts:
	dspace-api/src/test/data/dspaceFolder/config/local.cfg
	dspace-server-webapp/src/test/java/org/dspace/app/rest/BitstreamRestControllerIT.java
2023-06-05 16:29:57 +02:00
Nona Luypaert
9a49998ea0 102124: Add config for opening formats as attachment + IT 2023-06-05 16:02:42 +02:00
Alan Orth
ffe6a63780 Merge pull request #8866 from alanorth/crossref-publisher
dspace: capture publisher from CrossRef live import
2023-06-05 16:30:07 +03:00
Alan Orth
a38ff42169 dspace: capture publisher from CrossRef live import
Publisher is a required field on CrossRef so we can always rely on
capturing this information when doing a live import.

See: https://github.com/CrossRef/rest-api-doc/blob/master/api_format.md
2023-06-05 15:52:30 +03:00
Nona Luypaert
d6d6a3e074 102052: Replace 'DELETE' with 'WRITE' on deletePrimaryBitstream + More auth ITs 2023-06-05 09:45:40 +02:00
Paulo Graça
e6f54a97bf Merge branch 'main' into enhancement/addressing-#8633 2023-06-04 23:01:31 +01:00
Paulo Graça
52bc4844bf Merge branch 'main' into enhancement/xoai-access-status-plugin 2023-06-04 09:33:54 +01:00
Tim Donohue
6013c41184 Merge pull request #8870 from TexasDigitalLibrary/DS-8759
DS-8759: check that zip file exists and has correct MIME type; clean up imports directory on failed import
2023-06-02 16:59:21 -05:00
Tim Donohue
4d5e907617 Merge pull request #8856 from kshepherd/item_delete_unlink_doi
Unlink DOI from item on deletion even if no provider is configured
2023-06-02 16:26:29 -05:00
Tim Donohue
9735020c4a Merge pull request #8857 from buithaihai/DS-8837
Fix: default sort option for discovery
2023-06-02 15:55:21 -05:00
Paulo Graça
39283650d0 Merge branch 'main' into DS-8837 2023-06-02 15:44:46 +01:00
Paulo Graça
cd57a0851f Merge branch 'main' into enhancement/addressing-#8633 2023-06-02 15:06:47 +01:00
Paulo Graça
ab5a040a1d Merge branch 'main' into enhancement/xoai-access-status-plugin 2023-06-02 12:05:57 +01:00
Alan Orth
44d038c2a5 Merge pull request #8878 from 4Science/DURACOM-149
[DURACOM-149] correctly handle dates in pubmed live import; added integration tests
2023-06-02 12:38:20 +03:00
Paulo Graça
fa8b6e0280 Merge branch 'main' into enhancement/xoai-access-status-plugin 2023-06-02 09:47:12 +01:00
Paulo Graça
99f2c7c134 Merge branch 'main' into DS-8837 2023-06-02 09:21:51 +01:00
Francesco Pio Scognamiglio
52b02b5d36 Merge branch 'main' into DURACOM-149 2023-06-02 10:11:21 +02:00
Francesco Pio Scognamiglio
7c85b007c0 [DURACOM-149] remove trailing whitespace 2023-06-02 10:10:45 +02:00
Nona Luypaert
7b45ec0e51 Merge branch 'main' into contract-pr-222-primary-bitstream-on-bundle-support 2023-06-02 09:03:00 +02:00
Nona Luypaert
d565cd3e6b 102052: Return 204 status when primaryBitstream is null 2023-06-02 08:33:59 +02:00
Bui Thai Hai
70a7930f63 Tweaks fo test cases. 2023-06-02 09:45:52 +07:00
Andrea Bollini
b93e27e6ee Merge branch 'main' of https://github.com/DSpace/DSpace into duracom-136_CST-9634 2023-06-01 21:07:07 +02:00
Andrea Bollini
1b7af28dd3 CST-9634 remove unnecessary turn off/on auth system 2023-06-01 21:07:00 +02:00
Andrea Bollini
b78ddf2498 CST-9634 make public the validateResourcePolicy method 2023-06-01 19:38:01 +02:00
Andrea Bollini
b29409e08e Merge branch 'duracom-136_CST-9634' of https://bitbucket.org/4Science/dspace-cris into duracom-136_CST-9634 2023-06-01 19:24:47 +02:00
Andrea Bollini
308bae43c7 Merge branch 'main' of https://github.com/DSpace/DSpace into duracom-136_CST-9634 2023-06-01 19:22:34 +02:00
Tim Donohue
379db2a166 Merge pull request #8860 from 4Science/DURACOM-127
[DURACOM-127] check if versioning is enabled for versioned identifier providers
2023-06-01 12:01:49 -05:00
Andrea Bollini
d76bdc6d47 CST-9634 Assure that REST API assumes all dates to be UTC if not specified 2023-06-01 18:47:52 +02:00
Tim Donohue
5be09e375b Merge pull request #8842 from 4Science/DURACOM-126
Fix validation issue with hidden submission's sections
2023-06-01 11:31:39 -05:00
Giuseppe Digilio
cdac4c4459 Merge branch 'main' into DURACOM-126 2023-06-01 17:53:59 +02:00
Alexandre Vryghem
eb224eb809 100553: Added stricter metadata field & schema validation 2023-06-01 17:11:24 +02:00
Francesco Pio Scognamiglio
4e7107f63c Merge branch 'main' into DURACOM-149 2023-06-01 15:12:08 +02:00
Francesco Pio Scognamiglio
0ec27875bc [DURACOM-149] use right formatter for mapping of dc.date.issued in pubmed live import; added integration tests 2023-06-01 15:10:59 +02:00
Giuseppe Digilio
dae8f166e1 [DURACOM-126] add java doc 2023-06-01 14:48:46 +02:00
Giuseppe Digilio
56c8820d31 [DURACOM-126] Improve test in order to check item can be submitted 2023-06-01 14:41:58 +02:00
Nona Luypaert
b0068e3d4e Merge branch 'main' into contract-pr-222-primary-bitstream-on-bundle-support 2023-06-01 12:22:56 +02:00
Mohamed Saber Eskander
f587989726 edited param name 2023-06-01 11:48:45 +03:00
eskander
00576b7fb6 Merge remote-tracking branch 'origin/main' into duracom-136_CST-9634 2023-06-01 10:34:31 +03:00
Mark H. Wood
b272b1fcab Make service lookup retry log at DEBUG; radically shorten the trace. 2023-05-31 17:37:34 -04:00
Tim Donohue
894bc39e8b Merge pull request #8698 from mwoodiupui/embargo-date
Calculate the correct maximum for access condition start and end dates
2023-05-31 11:53:46 -05:00
Tim Donohue
cac0859cb1 Merge pull request #8850 from alanorth/rework-im-thumbnail-filter
Minor improvements to ImageMagick thumbnail filters
2023-05-31 11:03:40 -05:00
Nona Luypaert
2c43270152 102052: Create PrimaryBitstreamController for primaryBitstream endpoint + ITs 2023-05-31 16:53:45 +02:00
Nona Luypaert
99d4a8447e 102052: Add remaining CRUD methods to BundlePrimaryBitstreamLinkRepository 2023-05-31 16:52:04 +02:00
Jens Vannerum
cfb932547c Merge remote-tracking branch 'atmireGithub/w2p-101481_Referrer-fix' into w2p-refferex-fix-main 2023-05-31 13:57:59 +02:00
damian
e31a223882 Item counts are now managable. 2023-05-31 13:53:09 +02:00
Mohamed Saber Eskander
e6daf49f25 added missed configuration 2023-05-31 13:26:28 +03:00
Mohamed Saber Eskander
bfbf17f577 - refactoring and adding new test cases
- update resource polices of derivative bitstreams also
- check authorization when run script
- added some log information
2023-05-31 12:33:56 +03:00
Giuseppe Digilio
54981b0bd2 Merge branch 'main' into DURACOM-126 2023-05-30 09:11:49 +02:00
NikitaKr1vonosov
3ee18f5a6e Merge branch 'main' into CST-5728 2023-05-29 13:05:46 +02:00
Nikita Krivonosov
3ba6db388b Merge remote-tracking branch 'origin/CST-5728' into CST-5728 2023-05-29 12:42:39 +02:00
Nikita Krivonosov
d0d6776810 [CST-5728] LYRASIS [Donated]: DSpace7: Implement signposting pattern in DSpace (REST) 2023-05-29 09:56:07 +02:00
Paulo Graça
c11679c6de removing tailing semicolon 2023-05-27 09:19:15 +01:00
Paulo Graça
c2a5e2ad80 Merge branch 'main' into enhancement/xoai-access-status-plugin 2023-05-27 09:15:59 +01:00
Paulo Graça
a9eab4a254 also add support for access status at bitstream level 2023-05-27 08:23:46 +01:00
Paulo Graça
43ab705568 fixing code style errors 2023-05-26 22:47:02 +01:00
nwoodward
fdef871e69 fix checkstyle 2023-05-26 15:41:14 -05:00
nwoodward
e889abc623 check that zip file exists and has correct MIME type; also make sure that common temp imports directory is not removed 2023-05-26 15:41:14 -05:00
Paulo Graça
4fa51d03d1 adding support for access status xoai plugin 2023-05-26 17:14:10 +01:00
Paulo Graça
b47fd234e8 Merge branch 'main' into enhancement/addressing-#8633 2023-05-26 12:22:38 +01:00
Francesco Pio Scognamiglio
78f91b096b Merge branch 'main' into DURACOM-127 2023-05-26 09:24:17 +02:00
Mark H. Wood
7b720d6521 Merge pull request #8772 from alexandrevryghem/use-variables-in-email-templates_contribute-main
Use variables in email templates contribute main
2023-05-25 13:57:27 -04:00
Tim Donohue
bdcfb8523d Merge pull request #8796 from atmire/w2p-100414_Missing-search-result-statistics-PR
Missing search results statistics
2023-05-25 08:55:07 -05:00
Giuseppe Digilio
ec3cc2dcf1 Merge branch 'main' into duracom-136_CST-9634 2023-05-25 15:49:41 +02:00
Giuseppe Digilio
e3beefadaa Merge remote-tracking branch 'bitbucket4science/DURACOM-126' into DURACOM-126 2023-05-25 14:49:55 +02:00
Giuseppe Digilio
f750f85b17 Merge remote-tracking branch 'origin/main' into DURACOM-126 2023-05-25 14:48:24 +02:00
Yana De Pauw
f3b939e88f 94299: Add rest.patch.operations.limit to config file 2023-05-25 15:34:05 +03:00
Paulo Graça
111b2e4a6a Merge branch 'main' into enhancement/addressing-#8633 2023-05-25 09:42:31 +01:00
Bui Thai Hai
b3a21ebd5a Minor Tweaks 2023-05-25 14:54:46 +07:00
Bui Thai Hai
eb46a99dff Fix: default sort option (lastModified) for discovery 2023-05-25 10:21:44 +07:00
Mark H. Wood
571df9b38a Add a simple test for new TimeHelpers class. 2023-05-24 15:56:03 -04:00
Tim Donohue
c0446d45dc Merge pull request #8783 from kshepherd/LU-30_bitstream_inheritence
Bitstreams should inherit collection DEFAULT_BITSTREAM_READ, falling back to bundle READ
2023-05-24 11:29:43 -05:00
Alexandre Vryghem
01d5276fd7 Replace occurrences of DSpace with the dspace.name variable 2023-05-24 17:53:58 +02:00
Francesco Pio Scognamiglio
4417eddb85 Merge branch 'main' into DURACOM-127 2023-05-24 15:43:14 +02:00
Paulo Graça
2ca723d687 Merge branch 'main' into enhancement/addressing-#8633 2023-05-24 09:36:16 +01:00
Alan Orth
bd36261b20 Merge pull request #8863 from 4Science/DURACOM-148
[DURACOM-148] add crossref metadata processor to manage the date issued field
2023-05-24 10:03:45 +03:00
Tim Donohue
9e5165e626 Merge pull request #8851 from buithaihai/DS-8832
Fix: Collection's admin cannot edit its template item.
2023-05-23 11:48:52 -05:00
Bui Thai Hai
2f59554a5d ADD: Unit Tests for fix 2023-05-23 15:05:34 +07:00
Paulo Graça
50f808a7d0 removing Person test configuration 2023-05-23 08:51:27 +01:00
Francesco Pio Scognamiglio
8980b07f2b [DURACOM-148] fix typo: remove trailing whitespace 2023-05-23 08:51:07 +02:00
Francesco Pio Scognamiglio
8a0645c628 Merge branch 'main' into DURACOM-148 2023-05-23 08:46:30 +02:00
Bui Thai Hai
9bc7edb733 Fix: Collection's admin cannot edit its template item. 2023-05-23 09:14:10 +07:00
Tim Donohue
e0d2248da3 Merge pull request #8859 from alanorth/bump-tika-dep
pom.xml: bump tika from 2.3.0 to 2.5.0
2023-05-22 16:56:26 -05:00
Alexandre Vryghem
05f1714b05 Replace occurrences of DSpace with the dspace.name variable 2023-05-22 23:15:19 +02:00
Tim Donohue
33545667ef Merge pull request #8862 from tdonohue/update_spring_boot
Update to latest Spring Boot
2023-05-22 12:33:13 -05:00
Alan Orth
5357923d28 dspace-api: avoid generation loss in ImageMagickThumbnailFilter
When filtering PDF bitstreams, the ImageMagickThumbnailFilter first
creates an intermediate JPEG and then a "thumbnail" JPEG. These two
operations are both lossy. The ImageMagick usage guide warns against
doing that:

> JPEG losses (sic) information, degrading images when saved.
> Use some other format for intermediate images during processing.
> Only use JPEG format, for the final image, not for further processing.

As our current filter architecture requires writing a temporary file
we must choose one of the following lossless formats to use for the
intermediate: PNG, TIFF, or MIFF. MIFF is ImageMagick's own internal
format and is much faster to write than PNG.

By eliminating the first lossy conversion we gain 1.1% points on the
ssimulacra2 (v2.1) scoring scale of visual quality.

See: https://imagemagick.org/Usage/formats/#jpg
2023-05-22 18:36:11 +03:00
Alan Orth
7ebb5290fc dspace-api: comment ImageMagick filters
Add some comments to document the functionality of the ImageMagick
thumbnail filters. This will help others understand it later when
we need to re-factor them.
2023-05-22 18:36:11 +03:00
Alan Orth
a4105bdcb0 dspace-api: simplify logic in ImageMagickThumbnailFilter
There is no point passing a page parameter here, with a default of
0 no less, because we will *always* use the first page of the PDF
to generate the thumbnail. No other filters use this function and
the page parameter is not configurable so we should just hard code
it.
2023-05-22 18:36:11 +03:00
Alan Orth
7dbfa9a3c5 dspace-api: minor logging fix in ImageMagickThumbnailFilter
Minor standardization to logging (unneccessary capitalization and
excessive spaces).
2023-05-22 18:36:11 +03:00
Alan Orth
c37622cb3f dspace-api: improve logging in ImageMagickThumbnailFilter
Instead of logging the name of the source bitstream, we should be
logging the name of the actual thumbnail bitstream that is being
considered for replacement. For example, instead of this:

  IM Thumbnail manual.pdf matches pattern and is replaceable.

... the message should read:

  IM Thumbnail manual.pdf.jpg matches pattern and is replaceable.

This message is already confusing enough, but this will help.
2023-05-22 18:36:11 +03:00
Alan Orth
7ab5f3b489 dspace-api: fix typo in ImageMagickThumbnailFilter 2023-05-22 18:36:11 +03:00
Tim Donohue
c3dd1f8489 Update to latest Spring Boot 2023-05-22 09:23:21 -05:00
Francesco Pio Scognamiglio
cbfed3e218 [DURACOM-148] add crossref metadata processor to manage the date issued field 2023-05-22 15:44:52 +02:00
Paulo Graça
fc2589464f checkstyle violations fixing and remove unnecessary max rows limit 2023-05-22 12:57:56 +01:00
Francesco Pio Scognamiglio
8ddf4702af [DURACOM-127] check if versioning is enabled for versioned identifier providers 2023-05-22 11:53:03 +02:00
Alan Orth
6018a2b7be pom.xml: bump tika from 2.3.0 to 2.5.0
A handful of bug fixes, improvements to PDF parsing, and updates
to dependencies. This is the highest we can go right now without
hitting dependency convergence issues related to bouncycastle.

See: https://github.com/apache/tika/blob/2.5.0/CHANGES.txt
2023-05-22 11:50:59 +03:00
Paulo Graça
2b3af3a126 checkstyle violations fixing 2023-05-22 08:42:33 +01:00
Kim Shepherd
208cac08d5 modifying unit tests as per CI feedback, stubbings now unnecessary 2023-05-21 15:43:26 +12:00
Kim Shepherd
2ef268380f Unlink DOI from item on deletion even if no provider is configured 2023-05-21 15:43:26 +12:00
Paulo Graça
6fa9e74d90 checkstyle violations fixing 2023-05-20 11:35:27 +01:00
Paulo Graça
687b6216df checkstyle violations fixing 2023-05-20 10:41:51 +01:00
Paulo Graça
cd73d38be8 Merge branch 'enhancement/addressing-#8633' of github.com:paulo-graca/DSpace into enhancement/addressing-#8633 2023-05-20 08:07:58 +01:00
Paulo Graça
32b2b7dacb Merge branch 'main' of github.com:dspace/dspace into enhancement/addressing-#8633 2023-05-20 08:07:29 +01:00
Paulo Graça
0409373b61 handling exceptions 2023-05-20 08:07:05 +01:00
kshepherd
6fd31622ae Merge pull request #8752 from amgciadev/fix-8732-b
Fix for #8732 and #8750
2023-05-20 10:26:45 +12:00
Paulo Graça
30223d6196 Merge branch 'DSpace:main' into enhancement/addressing-#8633 2023-05-19 22:48:34 +01:00
Paulo Graça
d7d7f7c370 support for entity type for collection at input submissions 2023-05-19 22:44:07 +01:00
Tim Donohue
116871d790 Merge pull request #8853 from alanorth/bump-pom-dependencies
pom.xml: bump a handful of dependencies
2023-05-19 12:35:39 -05:00
Alan Orth
564f9fdcf6 pom.xml: bump a handful of dependencies
All minor and patch versions with no breaking changes:

- pdfbox 2.0.28
  - See: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310760&version=12352284
- log4j 2.20.0
  - See: https://logging.apache.org/log4j/2.x/release-notes/2.20.0.html
- rome 1.19.0
  - See: https://github.com/rometools/rome/releases/tag/1.19.0
- slf4j 1.7.36
  - https://www.slf4j.org/news.html
- solr-client 8.11.2
  - https://lucene.apache.org/core/8_11_2/changes/Changes.html
- hibernate 5.6.15.Final
  - See: https://hibernate.org/orm/releases/5.6/#whats-new
- hibernate-validator 6.2.5.Final
  - See: https://hibernate.org/validator/documentation/migration-guide/#6-2-x
- postgresql JDBC driver 42.6.0
2023-05-19 16:43:05 +03:00
NikitaKr1vonosov
9e2b4a1acf Merge branch 'main' into CST-5728 2023-05-19 13:01:38 +02:00
Tim Donohue
95ad0ba927 Merge pull request #8822 from tdonohue/remove_oracle
Remove Oracle Support
2023-05-18 16:43:38 -05:00
Tim Donohue
c1629ff478 Merge pull request #8712 from tdonohue/update_spring_boot
Update Spring & Spring Boot versions
2023-05-18 11:49:37 -05:00
Mark H. Wood
4c00e13b52 Merge branch 'main' into reqitem-response 2023-05-18 08:29:39 -04:00
Giuseppe Digilio
083eb07251 Merge branch 'main' into DURACOM-126 2023-05-18 11:57:30 +02:00
Tim Donohue
d5ac263743 Merge pull request #8795 from arvoConsultores/DS-8636
#8636 Request a Copy's "helpdesk" strategy requires authentication t…
2023-05-17 16:46:42 -05:00
aroman-arvo
9784c6f50d 8636 - checkstyle 2023-05-17 19:26:50 +02:00
aroman-arvo
567e989202 8636 Request a Copy - integration test increased 2023-05-17 19:11:31 +02:00
Tim Donohue
604bcea759 Merge pull request #8847 from saschaszott/patch-6
remove configuration property eperson.subscription.onlynew
2023-05-17 10:43:53 -05:00
Tim Donohue
d3c03efe61 Merge pull request #8799 from uofmsean/fix-8490-preferred-label-lookup
Fix #8490 preferred label lookup
2023-05-16 16:53:37 -05:00
Tim Donohue
c0e62657f6 Merge pull request #8789 from amtuannguyen/main
properly escape ':' in query to address #8490
2023-05-16 16:51:25 -05:00
aroman-arvo
b1bb430ab2 Merge branch 'DS-8636' of https://github.com/arvoConsultores/DSpace into DS-8636 2023-05-16 13:50:02 +02:00
aroman-arvo
5f58e587f3 Security issue fixed: request item token exposed 2023-05-16 13:49:16 +02:00
aroman-arvo
84ac53c7c2 Security issue fixed: request item token exposed 2023-05-16 13:29:45 +02:00
Alexandre Vryghem
3ab0c812a6 Merge remote-tracking branch 'upstream/main' into issue-1671_fix-relationships-not-updating-view-on-submission-form_contribute-main 2023-05-16 12:09:40 +02:00
Sascha Szott
2f1d52bf3f removed eperson.subscription.onlynew 2023-05-16 09:09:17 +02:00
Agustina Martinez
95af5fff41 VersionedDOIIdentifierProvider: add non-fatal check that dso is of type Item 2023-05-15 08:40:57 +01:00
Agustina Martinez
754c0756c4 Merge branch 'main' into fix-8732-b 2023-05-15 08:40:27 +01:00
Tim Donohue
f67f55cb21 Merge pull request #8839 from DSpace/paulo-graca-dspace-submission-fix
Replace invalid dc.terms.references with a proper dcterms.references
2023-05-12 16:22:20 -05:00
Tim Donohue
0504e10dab Merge pull request #8841 from alexandrevryghem/fix-community-page-sorting_contribute-main
Fixed community's sub-communities and collections sort
2023-05-12 15:00:30 -05:00
Tim Donohue
baf1b94962 Merge pull request #8845 from tdonohue/fix_codecov_settings
Fix Codecov settings to notify after one coverage file upload
2023-05-12 11:43:01 -05:00
Tim Donohue
c6b044222d Remove setting to wait on two codecov builds 2023-05-12 10:53:59 -05:00
samuel
f49b6f24ba 99221: Fix minor issues with Relationships in submission - repair relationship error 2023-05-12 15:25:02 +02:00
samuel
2e69ba7f63 96598: Test feedback pt. 3: submission - repair auto-refresh 2023-05-12 15:24:58 +02:00
eskander
2bdb7be422 Merge remote-tracking branch 'origin/duracom-136_CST-9634' into duracom-136_CST-9634 2023-05-12 15:35:52 +03:00
Mohamed Saber Eskander
07fbe15126 refactoring and added new IT class 2023-05-12 15:35:22 +03:00
Agustina Martinez
f844ca347b Improved fix: override missing register method in VersionedDOIIdentifierProvider 2023-05-12 13:24:28 +01:00
Agustina Martinez
1d355b7ed0 Merge branch 'DSpace:main' into fix-8732-b 2023-05-12 13:06:27 +01:00
Giuseppe Digilio
cf0215b029 [CST-9634] add administrativeBulkAccess discovery configuration 2023-05-12 13:15:48 +02:00
Giuseppe Digilio
3f5406df24 [CST-9634] Fix exception message 2023-05-12 13:13:38 +02:00
damian
1cc6fb2f58 Item counters refactor. Removing unnecessary code. 2023-05-12 12:29:22 +02:00
Jens Vannerum
b24f121c76 94299: checkstyle issue after main merge 2023-05-12 10:11:09 +02:00
eskander
27f874a08b refactoring and adding new test cases 2023-05-12 10:58:17 +03:00
Jens Vannerum
81f1eab2ed Merge remote-tracking branch 'DSpace_github/main' into w2p-94299_Multiple_Bitstream_deletion_endpoint
# Conflicts:
#	dspace-api/src/main/resources/Messages.properties
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/BitstreamRestRepositoryIT.java
2023-05-12 09:41:04 +02:00
eskander
fd388620c0 Merge remote-tracking branch 'origin/duracom-136_CST-9634' into duracom-136_CST-9634
# Conflicts:
#	dspace-api/src/main/java/org/dspace/app/bulkaccesscontrol/BulkAccessControl.java
#	dspace-api/src/test/java/org/dspace/app/bulkaccesscontrol/BulkAccessControlIT.java
2023-05-12 09:18:46 +03:00
eskander
44c066d07a refactoring and adding new test cases 2023-05-12 09:12:05 +03:00
Kim Shepherd
6943399938 #8783 checkstyle fixes 2023-05-12 18:03:02 +12:00
Kim Shepherd
b69517da74 #8783 don't inherit DEFAULT_BITSTREAM_READ if item has current embargo 2023-05-12 17:48:27 +12:00
Kim Shepherd
c2575b05b2 #8783 checkstyle fixes for integration test 2023-05-12 17:48:27 +12:00
Kim Shepherd
4a88573dc1 #8783 Strip out unused generateAutomaticPolicies method from AuthorizeService 2023-05-12 17:48:27 +12:00
Kim Shepherd
019d0319dc #8783 New bitstreams inherit DEFAULT_BITSTREAM_READ from owning collection
Otherwise will keep inherited READ from bundle. Does not affect embargos set during submission or workflow, these will always be applied afterwards.
2023-05-12 17:48:27 +12:00
Kim Shepherd
03c39cf6f1 Bitstreams should inherit DEFAULT_BITSTREAM_READ, then DEFAULT_ITEM_READ
When generating automatic policies, bitstream DSOs have always inherited
from DEFAULT_ITEM_READ, even if the collection's DEFAULT_BITSTREAM_READ
policy differs. This bugfix checks DEFAULT_BITSTREAM_READ first, and
uses DEFAULT_ITEM_READ as a fallback.
2023-05-12 17:48:27 +12:00
Adán Román Ruiz
2cf5b290b6 Fix "Simultaneous deletion of multiple bitstreams from the same bundle often compromises the state of the bundle" (#8778)
* DS-8694

* clean imports

* cleaning code

* DS-8694 - re-deletion of bitstream throw exception

* ds-8694 - clean code
2023-05-11 16:59:38 -05:00
Andrea Bollini
50e816f718 CST-9634 fix issues with date timezone and inheritance of default policies 2023-05-11 23:39:34 +02:00
Jens Vannerum
78fba6b579 94299: checkstyle 2023-05-11 21:24:31 +02:00
damian
0231af5867 Item counters added to Communities and Collections REST API 2023-05-11 20:08:32 +02:00
Giuseppe Digilio
2f96696ba5 Merged main into DURACOM-126 2023-05-11 16:38:54 +00:00
Yana De Pauw
c9c055ed67 Merge branch 'discovery-fixes-7.2' into discovery-fixes 2023-05-11 18:02:05 +02:00
Yana De Pauw
7c7824f913 Implement community feedback 2023-05-11 17:57:45 +02:00
Mark H. Wood
a026a8ced0 Fix test broken by new injection plan. 2023-05-11 11:43:54 -04:00
Jens Vannerum
c670251a68 94299: Fix minor issues 2023-05-11 17:13:13 +02:00
Mohamed Saber Eskander
9e013ef97f refactoring BulkAccessControl 2023-05-11 14:10:34 +03:00
Kristof De Langhe
9941ca2b78 Merge branch 'w2p-100414_Missing-search-result-statistics-7.0' into w2p-100414_Missing-search-result-statistics-PR 2023-05-11 11:37:18 +02:00
Kristof De Langhe
0528b4dd30 100414: Missing search result statistics code cleanup + extra test 2023-05-11 11:16:16 +02:00
Mohamed Saber Eskander
4e64afbe3b bulk access controll 2023-05-11 12:04:20 +03:00
Alexandre Vryghem
b01891cfde Merge remote-tracking branch 'upstream/main' into fix-community-page-sorting_contribute-7.4 2023-05-10 23:41:43 +02:00
Mark H. Wood
034fc3317b Fix unconfigured collaborator by not scanning it into two ApplicationContexts.
Minor tidying.
2023-05-10 17:37:36 -04:00
Paulo Graça
ccf9bc2d98 Update submission-forms.xml 2023-05-09 17:20:44 +01:00
eskander
6b40f2eea6 [CST-9634] refactoring 2023-05-09 14:46:37 +03:00
Mohamed Saber Eskander
9a2a8ef4f5 [CST-9634] created new endpoint for bulkAccessConditionOptions configuration 2023-05-09 13:31:37 +03:00
Tim Donohue
a2256ef8ec Merge pull request #8814 from ubks-mp/DSpace-7.5
LDAP Auth extended for many groups
2023-05-08 16:44:40 -05:00
Mark H. Wood
a86235a06b Simplify dependency injection.
To use autowiring via alias to select a grantor strategy is needlessly
complicated and fragile.  Instead, configure the email sender by
explicit constructor injection.  Other collaborators are internal
matters for the class and continue to be autowired.
2023-05-08 15:35:38 -04:00
Mark H. Wood
f8432ac7d4 Include new email template missed in original commit. 2023-05-08 13:15:29 -04:00
Mark H. Wood
6c8bcb334e Fix nonsense class name. 2023-05-08 12:49:43 -04:00
Tim Donohue
568a733d5e Merge pull request #8816 from TexasDigitalLibrary/DS-2175
DS-2175: send "forgot password" email if user tries to register with an existing email address
2023-05-08 11:17:03 -05:00
Mark H. Wood
896cffda7d Get request-copy response email body from backend templates, as with all other emails.
There is a considerable quantity of other changes here which were made to
facilitate testing by making the affected class a bean and injecting the
desired "strategy" class programmatically in the test.
2023-05-08 11:48:56 -04:00
aroman-arvo
6b10fc3783 Fix Style 2023-05-08 09:15:05 +02:00
aroman-arvo
909003bfac Fix style 2023-05-08 09:01:05 +02:00
aroman-arvo
3c37dd4519 ds-8636 - indentation 2023-05-08 08:44:49 +02:00
aroman-arvo
a2ee96809d Merge branch 'DS-8636' of https://github.com/arvoConsultores/DSpace into DS-8636 2023-05-08 08:42:40 +02:00
aroman-arvo
0783f7ff82 DS-8636 - all files option fixed 2023-05-08 08:37:55 +02:00
Alexandre Vryghem
2dfc373ad1 Fixed communities sub-communities and communities collections sorting 2023-05-07 22:06:01 +02:00
Alexandre Vryghem
bc73e312e0 100553: Added test for create metadata schema & field and created test for sort byFieldName 2023-05-07 17:35:10 +02:00
Nikita Krivonosov
7ba68c40ab [CST-5728] LYRASIS [Donated]: DSpace7: Implement signposting pattern in DSpace (REST) 2023-05-07 16:25:27 +02:00
Andrea Bollini
7971887b9a DURACOM-136 allow script execution by user other than admins 2023-05-07 10:58:41 +02:00
Michael W Spalti
5088447111 Updated solr query params. 2023-05-06 11:30:51 -07:00
Nicholas Woodward
29da9cf9c0 Merge branch 'main' into DS-2175 2023-05-05 14:37:37 -05:00
Tim Donohue
2e6085802f Merge pull request #8807 from hardyoyo/fix-cli-container
Add missing unzip command to CLI container
2023-05-05 14:35:45 -05:00
Tim Donohue
346c3e5cd9 Merge pull request #8710 from 4Science/CST-6402
Add SAF import via remote URL
2023-05-05 10:57:11 -05:00
Nona Luypaert
ab240d7f0e 101549: Fix BrowsesResourceControllerIT 2023-05-05 17:47:24 +02:00
Nona Luypaert
8c7f7475eb Merge branch 'contract-pr-225-browse-by-support-for-controlled-vocabulary-7.4' into contract-pr-225-browse-by-support-for-controlled-vocabulary-main
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/BrowseIndexRestRepository.java
2023-05-05 16:57:36 +02:00
Nona Luypaert
acb700c887 101549: Fix BrowseIndexMatcher and BrowsesResourceControllerIT 2023-05-05 15:55:49 +02:00
Jens Vannerum
999fb46e8d 94299: Add IT 2023-05-05 15:10:12 +02:00
Nona Luypaert
648b27befb 101549: Make BrowseIndexRestRepository#findAll also return hierarchicalBrowses 2023-05-05 14:52:16 +02:00
Jens Vannerum
80706592aa Revert "94299 Multiple Bitstream deletion endpoint"
This reverts commit 51d8874a
2023-05-05 13:07:47 +02:00
Jens Vannerum
09b56c2d99 94299: Configurable limit on amount of patch operations 2023-05-05 13:05:34 +02:00
Jens Vannerum
8be66c935d 94299: Remove bitstreams in bulk via patch 2023-05-05 12:35:40 +02:00
Marie Verdonck
928a46d30f Merge branch 'main' into contract-pr-225-browse-by-support-for-controlled-vocabulary-main
# Conflicts:
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/BrowseIndexRestRepository.java
2023-05-05 10:35:27 +02:00
Marie Verdonck
66eb8a548f Browse-by support for controlled vocabularies
https://github.com/DSpace/RestContract/pull/225
2023-05-04 20:14:44 +02:00
Francesco Pio Scognamiglio
390a6f1b44 Merge branch 'main' into CST-6402 2023-05-04 08:44:21 +02:00
Tim Donohue
dac7ed2f09 Migrate to org.hibernate.type.TextType from our custom LobType 2023-05-03 15:59:01 -05:00
Tim Donohue
7a209d228a Remove oracle specific Java code / comments. 2023-05-03 14:08:05 -05:00
Tim Donohue
140cdc6de0 Remove all oracle-specific migration scripts 2023-05-03 14:08:05 -05:00
Tim Donohue
6fbf97a6b3 Remove oracle mentions from configs / READMEs 2023-05-03 14:08:05 -05:00
Tim Donohue
6b7656f8b8 Remove oracle profiles from POMs 2023-05-03 14:08:05 -05:00
Tim Donohue
53a09a9ba7 Merge pull request #8800 from hutattedonmyarm/8792-fix-long-title-export
Fix #8792, change column type of Process.parameters to TEXT
2023-05-03 14:06:56 -05:00
Nicholas Woodward
980e50b877 Merge branch 'main' into DS-2175 2023-05-03 12:23:17 -05:00
Tim Donohue
22c667e7cd Merge pull request #8766 from Ma-Tador/synced
fix bug: reset password from Admin Panel when Captcha enabled
2023-05-03 10:52:46 -05:00
Ma-Tador
310b7a9b0c Add missing request parameter in RegistrationRestRepositoryIT 2023-05-03 09:01:26 +02:00
Ma-Tador
37e93e278b Merge branch 'DSpace:main' into synced 2023-05-03 08:34:27 +02:00
nwoodward
9cca5ee12a updated tests to reflect that registering with an existing email address no longer throws an unprocessable exception 2023-05-02 15:55:18 -05:00
Kristof De Langhe
12ad2064c4 101481: View events referrer fix 2023-05-02 17:48:32 +02:00
Giuseppe Digilio
ed845cbfa2 Merged main into DURACOM-126 2023-05-02 13:59:46 +00:00
Mohamed Saber Eskander
518cdb7ff0 [DURACOM-126] solved Submission with a validation error on a hidden step can't be submitted 2023-05-02 14:42:33 +03:00
Ma-Tador
603cd9a19b Remove white spaces to comply with DSpace checkstyle 2023-05-02 12:11:44 +02:00
Francesco Pio Scognamiglio
ef138cf76d [CST-6402] fix saf import via remote url: the source param is not used 2023-05-02 09:19:32 +02:00
Francesco Pio Scognamiglio
637003a75e Merge branch 'main' into CST-6402 2023-05-02 08:53:49 +02:00
Tim Donohue
7cebc65a31 Merge pull request #8784 from atmire/w2p-89779_VersionedHandleIdentifierProviderWithCanonicalHandles-fix
Fix for the optional VersionedHandleIdentifierProviderWithCanonicalHandles identifier system
2023-05-01 16:50:22 -05:00
nwoodward
80af0665c1 send "forgot password" email if user tries to register with email address already in eperson table 2023-05-01 15:15:28 -05:00
Tim Donohue
9bbfb8de68 Merge pull request #8776 from CVamsi27/ds-8728
Implement default description for Community/Collection for OpenSearch
2023-05-01 13:22:29 -05:00
Chandaluri Vamsi Krishna
fdf4a4d571 Updated to fetch dynamic default description
Signed-off-by: Chandaluri Vamsi Krishna <cvamsik99@gmail.com>
2023-04-30 22:32:42 +05:30
Chandaluri Vamsi Krishna
da09d4b1f5 Merge branch 'DSpace:main' into ds-8728 2023-04-29 08:51:31 +05:30
Tim Donohue
80cb84433b Merge pull request #8781 from CVamsi27/ds-8671
Removed instances of useProxies
2023-04-28 16:48:50 -05:00
Tim Donohue
05a1a371fa Merge pull request #8745 from alexandrevryghem/w2p-99466_made-import-external-source-date-uniform_contribute-main
Removed timestamp from dc.date.issued when importing from external sources
2023-04-28 16:38:30 -05:00
Tim Donohue
afcc9dc6c5 Merge pull request #8742 from 4Science/duracom-125
MetadataValues' list doesn't respect ordering after been modified
2023-04-28 15:03:22 -05:00
Abel
b656cba343 Merge branch 'dspace-7.5-sistedes' into feature-imagemagick-video 2023-04-28 17:18:01 +02:00
Michael Plate
c919df81fb LDAP Auth extended for many groups 2023-04-28 17:09:55 +02:00
Abel
77f6daf0a3 Change import order 2023-04-28 13:36:20 +02:00
Francesco Pio Scognamiglio
dd1a5188b6 [CST-6402] manage saf import via remote url in CLI mode 2023-04-28 10:28:27 +02:00
Francesco Pio Scognamiglio
1138667f3a [CST-6402] fix saf import via remote url: the url param is a string 2023-04-28 09:51:03 +02:00
Francesco Pio Scognamiglio
80a0e3267a Merge branch 'main' into CST-6402 2023-04-28 08:43:23 +02:00
Abel
f7414f1d58 Add a comment about ImageMagick policies 2023-04-28 04:40:23 +02:00
Abel
413c6f443f Use same defaults than ImageMagickThumbnailFilter 2023-04-28 04:28:38 +02:00
Abel
d256065fc2 Set FRAME_NUMBER using a constant 2023-04-28 04:09:26 +02:00
Abel
43661de74e Add Override annotation 2023-04-28 03:59:00 +02:00
Abel
535edef1b3 Add ImageMagickVideoThumbnailFilter 2023-04-28 03:53:43 +02:00
Tim Donohue
5944c4c1bf Merge pull request #8755 from hutattedonmyarm/main
Change description column in orcid tables to TEXT type
2023-04-27 16:47:33 -05:00
Tim Donohue
42663a3e0e Merge pull request #8762 from atmire/w2p-100302_Pubmed-lookup-too-many-requests-7.5
Fix PubMed lookup too many requests
2023-04-27 14:20:31 -05:00
Tim Donohue
8cd82e5d2e Update to Spring Boot v2.7.11 2023-04-25 17:13:40 -05:00
Tim Donohue
66d7c1bde6 Update to latest spring-boot and spring 2023-04-25 17:13:40 -05:00
Tim Donohue
42f548b17e Remove check for double-encoded param. It is no longer double-encoded after upgrading Spring Boot. 2023-04-25 17:13:40 -05:00
Tim Donohue
a15a41401b Update Spring & Spring Boot versions 2023-04-25 17:13:40 -05:00
Tim Donohue
89c49bf5ae Merge pull request #8793 from tdonohue/update_jetty
Update to latest Jetty v9
2023-04-25 14:48:09 -05:00
Hardy Pottinger
61845da1aa Install unzip in Dockerfile.cli so cli.ingest.yml can work correctly (requires unzip) 2023-04-25 11:17:24 -05:00
Tim Donohue
74e3d10326 Merge pull request #8794 from tdonohue/update_postgres_docker
Update Postgres Docker scripts to build/tag image automatically
2023-04-24 17:14:10 -05:00
Tim Donohue
f1f4fe4cdf Update to Postgres v13 (as v11 images are not being maintained). Add db.restore.yml upgrade script & enhance READMEs 2023-04-21 16:59:47 -05:00
max.nuding
d7c4d35d99 Add H2 and Oracle DB migrations 2023-04-21 11:52:24 +02:00
max.nuding
10d7b352ef Fix #8792, change column type of Process.parameters to TEXT 2023-04-21 07:55:24 +02:00
Sean Kalynuk
98b843668e Fix #8490 preferred label lookup
When the authority key still needs to be generated, skip the lookup for
the preferred label since it does not exist in Solr yet.
2023-04-20 14:08:30 -05:00
Tim Donohue
fea4067464 Merge pull request #8785 from mwoodiupui/event-consumer-doc
Document the need to avoid commit() during event dispatch.
2023-04-20 09:53:42 -05:00
Luca Giamminonni
c4f50c0116 Merge branch 'main' into DURACOM-92 2023-04-20 14:51:35 +02:00
Adán Román Ruiz
daa1a67e8c Merge branch 'main' into DS-8636 2023-04-20 13:30:26 +02:00
aroman-arvo
d9f7e04368 #8636 Request a Copy's "helpdesk" strategy requires authentication to respond 2023-04-20 11:13:28 +02:00
Kristof De Langhe
3154caaae8 Merge branch 'main' into w2p-100414_Missing-search-result-statistics-7.0 2023-04-20 10:21:59 +02:00
Francesco Pio Scognamiglio
9c7012b36b Merge branch 'main' into CST-6402 2023-04-20 09:05:47 +02:00
Tim Donohue
3df54e549f Revert change to alpine linux. Scripts all assume debian. 2023-04-19 15:14:40 -05:00
Tim Donohue
5e013a8a36 Update to latest version of Ant 2023-04-19 14:25:52 -05:00
Tim Donohue
aa7acb5be7 Update Postgres Docker scripts to build/tag images automatically 2023-04-19 14:25:18 -05:00
Tim Donohue
e3fb8bf601 Update to latest Jetty v9 2023-04-19 11:21:13 -05:00
Kristof De Langhe
583b38a2e6 100414: Missing search_result statistics fix 2023-04-19 12:23:26 +02:00
Max Nuding
0dc5a298dc Merge branch 'DSpace:main' into main 2023-04-19 11:32:12 +02:00
Tim Donohue
bcb7142b90 Merge pull request #8779 from DSpace/dependabot/maven/dspace-api/org.json-json-20230227
Bump json from 20180130 to 20230227 in /dspace-api
2023-04-17 16:30:20 -05:00
Tim Donohue
7b4bf36898 Merge pull request #8780 from tdonohue/update_actions
Split Codecov GitHub action to separate job & add retries. Update other actions.
2023-04-17 14:58:33 -05:00
Tuan Nguyen
b48ea37de5 properly escape ':' in query 2023-04-17 15:16:17 -04:00
Mark H. Wood
d5178a7129 Document the need to avoid commit() during event dispatch. 2023-04-17 09:26:49 -04:00
Kevin Van de Velde
090994a378 Merge remote-tracking branch 'upstream/main' into w2p-89779_VersionedHandleIdentifierProviderWithCanonicalHandles-fix 2023-04-17 14:11:25 +02:00
Chandaluri Vamsi Krishna
1ccde8468d Removed useProxies usage
Signed-off-by: Chandaluri Vamsi Krishna <cvamsik99@gmail.com>
2023-04-15 11:42:02 +05:30
Chandaluri Vamsi Krishna
24897cde05 Merge branch 'DSpace:main' into ds-8728 2023-04-15 10:56:10 +05:30
Tim Donohue
9b0f2ed433 Update to latest version of actions 2023-04-14 16:45:52 -05:00
Tim Donohue
e00388995b Split Codecov upload into a separate job. Make it auto-retry up to five times 2023-04-14 16:45:15 -05:00
Tim Donohue
180fb00864 Merge pull request #8717 from amgciadev/fix-1702-b
Fixes "Move item to a different collection is not inheriting policies"
2023-04-14 14:50:21 -05:00
dependabot[bot]
fe5a305264 Bump json from 20180130 to 20230227 in /dspace-api
Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180130 to 20230227.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-04-14 17:40:58 +00:00
Tim Donohue
d180fc5393 Merge pull request #8756 from 4Science/DURACOM-128
[DURACOM-128] Unable to delete a profile
2023-04-14 11:44:26 -05:00
Tim Donohue
cc6c840cc8 Merge pull request #8735 from TexasDigitalLibrary/DS-8668
DS-8668: adds exception handler for when maximum upload size is exceeded
2023-04-14 11:43:14 -05:00
Tim Donohue
1e14974710 Merge pull request #8718 from 4Science/DSC-968_main
Added pagination on bitstream cleanup
2023-04-14 10:30:21 -05:00
corrado lombardi
b2b4dda243 checkstyle fix 2023-04-13 08:35:38 +02:00
Chandaluri Vamsi Krishna
9a345d3e64 Testing of default description
Signed-off-by: Chandaluri Vamsi Krishna <cvamsik99@gmail.com>
2023-04-13 09:52:14 +05:30
Chandaluri Vamsi Krishna
77d552b029 Added logic for default description
Signed-off-by: Chandaluri Vamsi Krishna <cvamsik99@gmail.com>
2023-04-13 09:50:57 +05:30
corrado lombardi
4685c9fc8d updated test expectation 2023-04-12 19:20:40 +02:00
corrado lombardi
3f0ae31573 Merge remote-tracking branch 'origin/DURACOM-92' into DURACOM-92 2023-04-12 18:51:45 +02:00
corrado lombardi
d8357d77aa used utils.copy to copy input stream content in order to prevent oom problems 2023-04-12 18:45:27 +02:00
corrado lombardi
9ef3794090 updated checksum calculation 2023-04-12 15:29:52 +02:00
Vincenzo Mecca
006f4a5ff7 Merge branch 'main' into duracom-125 2023-04-12 09:28:13 +02:00
Tim Donohue
7a8edb6de2 Merge pull request #8771 from tadeubas/main
Typo fix in dspace.cfg
2023-04-11 14:45:26 -05:00
TS
1c41794ddd Fix typo in dspace.cfg
Fixed typo "cummulative" to "cumulative" in dspace/config/dspace.cfg file
2023-04-11 15:02:24 -03:00
TS
d9cb1e51c4 Typo fix in dspace.cfg
Fixed typo "dermine" to "determine" in `dspace/config/dspace.cfg` file
2023-04-11 14:41:17 -03:00
Vincenzo Mecca
dca82017c4 Merge branch 'main' into duracom-125 2023-04-11 09:38:31 +02:00
Tim Donohue
4b1b9791ca Merge pull request #8679 from mark-cooper/dspace-solr
Build, use, publish dspace/dspace-solr imgs
2023-04-07 11:50:30 -05:00
Yana De Pauw
cf831ed7d5 Fix merge issues 2023-04-07 16:26:12 +02:00
Yana De Pauw
e6b7154204 Merge branch 'discovery-fixes-7.2' into discovery-fixes 2023-04-07 16:01:49 +02:00
Yana De Pauw
09f59b0b73 Merge remote-tracking branch 'upstream/main' into discovery-fixes 2023-04-07 16:00:45 +02:00
Yana De Pauw
e433720cd0 Add test-discovery xml 2023-04-07 15:31:46 +02:00
Yana De Pauw
11bc061ff9 97248: Implement feedback 2023-04-07 15:29:57 +02:00
Mark Cooper
b36e6df9bc Build, use, publish dspace/dspace-solr imgs 2023-04-06 16:48:36 -07:00
Ma-Tador
44e7bef9ca fix bug: reset password from Admin Panel #8765 2023-04-06 11:24:30 +02:00
Vincenzo Mecca
0c6ae1fffc Merge branch 'main' into duracom-125 2023-04-06 09:31:15 +02:00
Tim Donohue
5d14b23e05 Merge pull request #8727 from alexandrevryghem/added-vtt-to-default-supported-bitstream-types
Added WebVTT to default supported bitstream formats
2023-04-04 11:50:06 -05:00
Yana De Pauw
d152a49e4f Merge remote-tracking branch 'upstream/main' into w2p-100302_Pubmed-lookup-too-many-requests-7.5 2023-04-04 10:42:08 +02:00
Max Nuding
c54dc03bf2 Merge branch 'DSpace:main' into main 2023-04-04 10:15:59 +02:00
Alexandre Vryghem
0e0962e3bc Added WebVTT to default supported bitstream formats 2023-04-03 23:56:28 +02:00
Tim Donohue
564184496a Merge pull request #8722 from alanorth/update-bitstream-format-registry
Update bitstream format registry
2023-04-03 16:11:09 -05:00
Alexandre Vryghem
a26f6bc80e 100553: Removed possibility to updated schema name, element and qualifier 2023-04-03 14:12:56 +02:00
Alan Orth
e777142502 dspace-api: Add SQL migration for PNG
Add a Flyway SQL migration to update the description of PNG in the
bitstream format registry.
2023-03-31 20:56:54 +03:00
Alan Orth
f384eaaf91 dspace-server-webapp: Update IT for bitstream format registry
Since we added WebP and AVIF we need to increase the expected numb-
er of formats by two.
2023-03-31 20:56:54 +03:00
Alan Orth
3f8970048b dspace: add WebP and AVIF to bitstream format registry
WebP and AVIF are modern image formats that have been around for a
few years and have become increasingly widely supported.
2023-03-31 20:56:54 +03:00
Alan Orth
00313ad925 dspace.cfg: update name of PNG format
We should use the short description, not the mime type, as with all
other image types.
2023-03-31 20:56:54 +03:00
Alan Orth
855ca64c1e dspace: Change description for image/png to "PNG"
"image/png" is the mime type, not the short description.
2023-03-31 20:56:54 +03:00
Luca Giamminonni
d77125ccb9 Merge remote-tracking branch '4Science-bitbucket/main' into DURACOM-92 2023-03-31 11:37:09 +02:00
Vincenzo Mecca
9154374e4e Merge branch 'main' into duracom-125 2023-03-31 11:33:33 +02:00
max.nuding
d5c001463a Add integration tests for orcid bulk push with long titles 2023-03-31 08:49:53 +02:00
max.nuding
714c4c7fbb Add CLOB column annotations 2023-03-31 08:32:12 +02:00
Max Nuding
877b514882 Merge branch 'DSpace:main' into main 2023-03-31 08:13:16 +02:00
Tim Donohue
2d8b2b72ad Merge pull request #8716 from amgciadev/fix-8715-b
Fix #8714 and #8715
2023-03-30 12:34:54 -05:00
Tim Donohue
3b92ccede2 Merge pull request #8733 from mspalti/pagination-test
Performance improvement for pagination
2023-03-30 11:28:11 -05:00
Tim Donohue
516221b537 Merge pull request #8684 from 4Science/media-filter
CST-8792 remove all thumbnails in force mode
2023-03-30 11:03:21 -05:00
Yana De Pauw
de46faf23e 100302: Add debugging logs for pubmed requests 2023-03-30 17:39:07 +02:00
Alexandre Vryghem
96b2437e24 100553: Added backend validation on schema, element and qualifier to check if they contain dots 2023-03-30 17:26:29 +02:00
Yana De Pauw
f456beadba Merge branch 'w2p-100302_Pubmed-lookup-too-many-requests' into w2p-100302_Pubmed-lookup-too-many-requests-7.5 2023-03-30 16:33:40 +02:00
Yana De Pauw
b43a92062f 100302: Add delays between specific Pubmed calls 2023-03-30 16:28:31 +02:00
Alexandre Vryghem
0f8b9707f0 100553: Fixed the pagination for core/metadatafield/byFieldName rest endpoint 2023-03-30 16:01:57 +02:00
Alexandre Vryghem
a11ed8a0d3 100553: Sort the queried metadata fields ASC to always display exact matches on top (this can otherwise lead to angular errors) 2023-03-30 15:43:21 +02:00
Nikita Krivonosov
3738d21e0d [DURACOM-128] Unable to delete a profile 2023-03-30 09:34:25 +02:00
Agustina Martinez
ca66fc7309 Update VersionedDOIIdentifierProvider.java
Include check for DOI.SCHEME before returning DOI
2023-03-29 21:05:07 +01:00
Agustina Martinez
8989d5ad16 Update VersionedDOIIdentifierProvider.java
getBareDOI method already adds doi: SCHEME
2023-03-29 20:44:34 +01:00
Agustina Martinez
aa45a407ba Fix for #8732 and #8750 2023-03-29 17:30:59 +01:00
max.nuding
db3ebe84bd Change description column in orcid tables to TEXT type 2023-03-29 15:12:07 +02:00
Francesco Pio Scognamiglio
1f209f4782 Merge branch 'main' into CST-6402 2023-03-29 10:08:15 +02:00
Alexandre Vryghem
5976c5c970 Merge remote-tracking branch 'upstream/main' into w2p-99466_made-import-external-source-date-uniform_contribute-main 2023-03-29 09:59:18 +02:00
Vincenzo Mecca
0a4644750a Merge remote-tracking branch 'origin/main' into duracom-125 2023-03-29 09:06:48 +02:00
Tim Donohue
bdb88724ac Merge pull request #8705 from mspalti/jp2-test
Added test and format registry entry for JPEG2000 image
2023-03-28 16:50:30 -05:00
Tim Donohue
89143deb5c Merge pull request #8724 from arvoConsultores/DS-8719
fix #8719 update sequences
2023-03-28 16:15:45 -05:00
Francesco Pio Scognamiglio
c26d3d7104 Merge branch 'main' into CST-6402 2023-03-28 22:42:03 +02:00
Tim Donohue
3ac343b413 Merge pull request #8746 from tdonohue/fix_broken_alert_test
Fix SystemWideAlert date tests to use our DateMatcher
2023-03-28 13:35:14 -05:00
Tim Donohue
c1731f11ee Fix date tests to use our DateMatcher 2023-03-28 11:44:12 -05:00
Alexandre Vryghem
0133be8a49 99466: Fixed ArXiv date not being formatted as a date but just being saved as a plain string 2023-03-28 11:16:18 +02:00
Vincenzo Mecca
692c5b5a99 [DURACOM-125][#8736] Check replace operation correctness
feat:
  - Introduced ITs inside RestRepositories to check correctness of multi replacement with indexes.
2023-03-27 17:57:40 +02:00
Alexandre Vryghem
6a29d01496 99466: Fixed pubmed date not being saved like the dateFormatsToAttempt specified in pubmed-integration.xml 2023-03-27 17:35:50 +02:00
Yana De Pauw
48cf8403c3 Merge remote-tracking branch 'upstream/main' into w2p-100302_Pubmed-lookup-too-many-requests-7.5 2023-03-27 17:22:32 +02:00
Yana De Pauw
56aca5c14f 100302: Fix issue with Pubmed too many requests 2023-03-27 16:44:07 +02:00
Luca Giamminonni
5a32771791 [DURACOM-92] Fixed CheckerCommand if no bitstream was found 2023-03-27 13:25:01 +02:00
Luca Giamminonni
76d90e7d53 Merge remote-tracking branch '4Science-github/main' into DURACOM-92 2023-03-27 12:33:09 +02:00
Francesco Pio Scognamiglio
ae3c9642ff Merge branch 'main' into CST-6402 2023-03-27 09:17:13 +02:00
Michael Spalti
3d0b63e15b Remove unused import 2023-03-24 11:28:30 -07:00
Vincenzo Mecca
b1c1edc7f0 [DURACOM-125][#8736] Preserved order of modified MetadataValues
feat:
  - Introduced new Class with static methods usable to order
`MetadataValue` lists;
  - Introduced ITs also for `PatchMetadata` replace operations;
  - Introduced new method `DspaceObject#getMetadataFieldId`.
ref:
  - Replaced old sort method inside `ItemServiceImpl` with the new one
2023-03-24 17:34:02 +01:00
Vincenzo Mecca
882373faa1 [DURACOM-125][#8736] Failing Test ItemServiceTest
bug:
  - MetadataValue list once modified should respect a similar order of
the `@OrderBy` annotation inside the `DSpaceObject#metadata` field.
2023-03-24 17:14:06 +01:00
nwoodward
d3e70c4a07 added exception handler for when maximum upload size is exceeded 2023-03-24 08:34:45 -05:00
Michael Spalti
2b8c1ac604 minor refactoring 2023-03-23 16:11:50 -07:00
Michael Spalti
73a9fac5e9 Modified converter service 2023-03-23 13:01:18 -07:00
Tim Donohue
b68f03b845 Merge pull request #8707 from shorock/iss-8706
Off-by-one in solr-upgrade-statistics-6x #8706
2023-03-23 14:42:33 -05:00
Michael Spalti
ac48b2d1fd Fixed typo in bean definition 2023-03-20 16:04:37 -07:00
Michael Spalti
71ababf728 Updated bitstream format test 2023-03-20 16:04:37 -07:00
Michael Spalti
e0846452e5 Added test and format registry entry
Added jp2 resource
2023-03-20 16:04:37 -07:00
aroman-arvo
5d52a2a512 DS-8719 - added if exist to drop sequence 2023-03-20 17:11:05 +01:00
aroman-arvo
372b7e3394 fix #8719 update sequences 2023-03-17 11:00:02 +01:00
Francesco Pio Scognamiglio
6970158eba Merge branch 'main' into CST-6402 2023-03-15 10:51:47 +01:00
Agustina Martinez
11d2d5a3c7 Fix Checkstyle issues 2023-03-13 15:07:04 +00:00
Agustina Martinez
f82834bd57 ItemOwningCollectionUpdateRestController: add support for inheritPolicies flag whem moving items 2023-03-13 14:36:57 +00:00
Luca Giamminonni
bdf867541d [DSC-968] Adding pagination on bitstream cleanup 2023-03-13 15:12:01 +01:00
Agustina Martinez
4748163eaf Fix #8714 and #8715 2023-03-11 15:49:02 +00:00
Tom Shorock
39e4ed67ab Off-by-one in solr-upgrade-statistics-6x #8706 2023-03-08 14:40:15 -06:00
Tim Donohue
b956bcd389 Merge pull request #8680 from DSpace/dependabot/maven/commons-fileupload-commons-fileupload-1.5
Bump commons-fileupload from 1.3.3 to 1.5
2023-03-08 14:33:53 -06:00
Tim Donohue
164b449c44 Merge pull request #8701 from TexasDigitalLibrary/DS-4493
DS-4493: prevent empty string assignment for language variable
2023-03-08 11:56:19 -06:00
nwoodward
1cbaf628cf prevent empty string assignment for language variable 2023-03-07 13:07:03 -06:00
Mark H. Wood
ecb1f1747c Guard against null dates. How embarassing. 2023-03-06 16:53:26 -05:00
Mark H. Wood
9675a0e9b1 Move DateMathParser from instance variables to locals, so "now" is current time not startup time.
Clamp access condition dates to midnight UTC.
Add a lot of debug logging and a test main().
2023-03-06 11:41:14 -05:00
Kevin Van de Velde
5ee8def49c Fixing an issue where the REST api wouldn't resolve a handle url 2023-03-02 13:41:27 +01:00
Tim Donohue
ab578dc742 Merge pull request #8632 from mwoodiupui/policy
Improve ResourcePolicy documentation.
2023-03-01 16:09:02 -06:00
Mark H. Wood
0548b83598 Remove obsolete paragraph: we no longer have any unused properties.
Minor re-wrapping so it's easier to read when editing.  No effect on output.
2023-03-01 09:34:46 -05:00
Tim Donohue
9f304b5b16 Merge pull request #8672 from TexasDigitalLibrary/DS-8478
DS-8478: restores member variables used in sharding functions
2023-02-28 12:19:20 -06:00
Kristof De Langhe
b604480e31 89779: VersionedHandleIdentifierProviderTest pt2 & VersionedHandleIdentifierProviderWithCanonicalHandles fix 2023-02-28 13:58:08 +01:00
nwoodward
d7749e2438 removed logging statements that were already elsewhere 2023-02-27 16:51:02 -06:00
Tim Donohue
ec22f121bf Merge pull request #8665 from DSpace/issue-8661-xsl-stylesheet-1.1
Downgrade Creative Commons transformation stylesheet version
2023-02-27 12:47:47 -06:00
Kristof De Langhe
f70a0cdf50 89779: VersionedHandleIdentifierProviderTest pt2 2023-02-27 14:21:57 +01:00
Andrea Bollini
b847d3ff72 CST-8792 remove all thumbnails in force mode 2023-02-26 14:50:05 -05:00
Kristof De Langhe
47fab88c17 89779: VersionedHandleIdentifierProviderWithCanonicalHandles fix pt1 2023-02-24 17:30:28 +01:00
Mark H. Wood
1acdc55104 Improve ResourcePolicy documentation. 2023-02-23 11:23:39 -05:00
dependabot[bot]
b0567aa224 Bump commons-fileupload from 1.3.3 to 1.5
Bumps commons-fileupload from 1.3.3 to 1.5.

---
updated-dependencies:
- dependency-name: commons-fileupload:commons-fileupload
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-02-22 06:56:19 +00:00
nwoodward
358e2b5b41 restores member variables used in sharding functions 2023-02-17 10:21:34 -06:00
Tim Donohue
3aa3a945af [maven-release-plugin] prepare for next development iteration 2023-02-17 10:12:27 -06:00
Tim Donohue
654520e1bb [maven-release-plugin] prepare release dspace-7.5 2023-02-17 10:12:23 -06:00
Tim Donohue
055e5a3d09 Updates to LICENSES_THIRD_PARTY for 7.5 2023-02-17 09:42:40 -06:00
Francesco Pio Scognamiglio
191d3700bb [CST-6402] manage saf import via remote url 2023-02-17 12:15:03 +01:00
Tim Donohue
b2d64c52e4 Merge pull request #8669 from 4Science/CST-8936
CST-8936 fix permission for bitstream generated by media-filter
2023-02-15 14:51:37 -06:00
Andrea Bollini
9e8276deba CST-8936 fix permission for bitstream generated by media-filter 2023-02-15 19:12:11 +01:00
Tim Donohue
dbbec3c655 Merge pull request #8660 from atmire/w2p-99200_request-copy-bugfix
Fix for Delete items after copies have been requested
2023-02-14 12:38:09 -06:00
Tim Donohue
0be1464829 Merge pull request #8621 from 4Science/CST-7754
Supervision order REST endpoints
2023-02-14 11:11:40 -06:00
jensvannerum
9bf9ba0775 Merge branch 'main' into w2p-99200_request-copy-bugfix 2023-02-14 14:24:30 +01:00
Raf Ponsaerts
a8a886b242 removed the log info 2023-02-14 11:22:13 +01:00
Tim Donohue
9c5a1976a2 Merge pull request #8663 from 4Science/DURACOM-116
[DURACOM-116] process sorted alphabetically
2023-02-13 10:15:01 -06:00
corrado lombardi
58a010d149 Merge branch 'main' into CST-7754
# Conflicts:
#	dspace-api/src/test/java/org/dspace/builder/AbstractBuilder.java
2023-02-13 17:03:30 +01:00
corrado lombardi
c729fc3b38 Merge branch 'main' into CST-7754 2023-02-13 16:57:49 +01:00
Tim Donohue
bcdf493545 Merge pull request #8620 from 4Science/CST-7756-SubscriptionFeature
Subscription feature rest
2023-02-13 09:51:38 -06:00
corrado lombardi
a37403781e [DURACOM-116] moved sorting to service 2023-02-13 12:53:13 +01:00
Mykhaylo
3b1d930c50 [CST-7756] Non-Discoverable and withdrawn items must be excluded from the notification list 2023-02-13 12:36:27 +01:00
Paulo Graça
37cf25c3f9 Merge branch 'main' into issue-8661-xsl-stylesheet-1.1 2023-02-10 23:04:38 +00:00
Mykhaylo
c34c14f807 Merge branch 'main' into CST-7756-SubscriptionFeature 2023-02-10 21:18:38 +01:00
Tim Donohue
37262101a1 Merge pull request #8629 from atmire/w2p-97414_advanced_workflow_actions-main
Advanced workflow - framework, workflows scoreReview and selectSingleReviewer
2023-02-10 13:40:26 -06:00
Marie Verdonck
f788daa45f Merge branch 'main' into w2p-97414_advanced_workflow_actions-main 2023-02-10 19:37:39 +01:00
Tim Donohue
cc15378fc7 Merge pull request #8664 from amgciadev/fix-8649
Bitstream command line cleanup operation - huge running time and potentially missing a DB commit
2023-02-10 11:07:57 -06:00
Mykhaylo
dd6b03bafc Merge branch 'main' into CST-7756-SubscriptionFeature 2023-02-10 17:29:43 +01:00
Paulo Graça
e4fcfdada6 Downgrade stylesheet version
Due to an warning message reported in:  #8661
2023-02-10 15:43:44 +00:00
Paulo Graça
69d124603b Downgrade stylesheet version
Due to an warning message reported in:  #8661
2023-02-10 15:35:54 +00:00
Agustina Martinez
2208a6bc63 Update BitstreamStorageServiceImpl.java
Amend commit log message
2023-02-10 15:17:40 +00:00
Agustina Martinez
f1a43cdaba Merge branch 'main' into fix-8649 2023-02-10 15:14:51 +00:00
corrado lombardi
e1700797d2 Merge branch 'main' into CST-7754
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/InstallItemServiceImpl.java
2023-02-10 15:21:54 +01:00
Tim Donohue
1a4e203a96 Merge pull request #8423 from the-library-code/TLC-249_identifiers_submission_7x
Show Identifier Step, pre-register identifiers
2023-02-10 06:51:20 -06:00
corrado lombardi
b76df48c0d Merge branch 'main' into CST-7754
# Conflicts:
#	dspace-api/src/test/java/org/dspace/builder/AbstractBuilder.java
2023-02-10 09:54:40 +01:00
Mykhaylo
5c1dbb0fc5 Merge branch 'main' into CST-7756-SubscriptionFeature 2023-02-10 08:33:04 +01:00
Agustina Martinez
86d7902c1a Added missing commit in cleanup method 2023-02-10 05:24:50 +00:00
Tim Donohue
ec514b5aec Merge pull request #8624 from atmire/w2p-97425_System-wide-alerts
System-wide alerts
2023-02-09 17:10:50 -06:00
Pascal-Nicolas Becker
94c5450318 [TLC-249] Ensure property identifiers.item-status.register-doi is set 2023-02-09 21:39:19 +01:00
Pascal-Nicolas Becker
594050070f [TLC-249] Test abandoning of a pending DOI and minting afterwards 2023-02-09 20:57:04 +01:00
Mohamed Saber Eskander
1fcbd6642c [DURACOM-116] process sorted alphabetically 2023-02-09 19:09:14 +01:00
corrado lombardi
2331db335f [CST-7754] supervising user can perform operations on Workspace item only if they have proper permissions 2023-02-09 15:26:30 +01:00
Marie Verdonck
93f328be95 Merge branch 'w2p-97414_advanced_workflow_actions-7.2' into w2p-97414_advanced_workflow_actions-main 2023-02-09 15:00:57 +01:00
Marie Verdonck
d8f5ae91bd Fix for decline when the delete doesn't persist in context before wfi is created again from same item 2023-02-09 14:59:53 +01:00
Marie Verdonck
0bafbb60a4 Alternate way to restart workflow in case of decline 2023-02-09 14:58:01 +01:00
Mykhaylo
27f75e9fb1 [CST-7756] added security check into 'subscription-send' script 2023-02-09 13:07:27 +01:00
Jens Vannerum
c2845e95aa 99200: Delete items after copies have been requested fix 2023-02-09 11:19:47 +01:00
Mykhaylo
9a9dff47fc Merge branch 'main' into CST-7756-SubscriptionFeature 2023-02-09 09:10:47 +01:00
Kim Shepherd
943bdb19e0 [TL-249] Checkstyle fix 2023-02-09 08:21:38 +13:00
Kim Shepherd
c4af5f2bff [TL-249] Javadoc and other small fixes
Including stripping $Revision$ from filter javadoc.
2023-02-09 08:21:38 +13:00
Kim Shepherd
555363e9b7 [TL-249] Javadoc and other small fixes, DOI unit tests 2023-02-09 08:21:38 +13:00
Kim Shepherd
2b957e2bb9 [TL-249] Revert accidental commit to RestResourceController 2023-02-09 08:21:38 +13:00
Kim Shepherd
7efb70a2f8 [TL-249] Fix imports 2023-02-09 08:21:38 +13:00
Kim Shepherd
b156badb68 [TL-249] Add identifiers.cfg and item-filters.xml config to test data 2023-02-09 08:21:38 +13:00
Kim Shepherd
d0c202010d [TL-249] Add always_true_filter to test REST identifier-service.xml config 2023-02-09 08:21:38 +13:00
Kim Shepherd
94cb0c78ec [TL-249] Remove example-doi_filter from config, add singleton attr to TrueFilter 2023-02-09 08:21:38 +13:00
Kim Shepherd
cb3c9b1f20 [TLC-249] Construct canonical handle URL in identifier item link 2023-02-09 08:21:38 +13:00
Kim Shepherd
dd0a7d7a63 [TLC-249] Refactor TrueFilter to get instantiated as singleton 2023-02-09 08:21:38 +13:00
Kim Shepherd
4997954f23 [TLC-249] Update integration tests for IdentifierRestRepository 2023-02-09 08:21:38 +13:00
Kim Shepherd
e63727e39e [TLC-249] Fix category type in IdentifierRest 2023-02-09 08:21:38 +13:00
Kim Shepherd
b13f36148d [TLC-249] return value as id for IdentifierRest 2023-02-09 08:21:38 +13:00
Kim Shepherd
18ea2f864d [TLC-249] Checkstyle fix 2023-02-09 08:21:38 +13:00
Kim Shepherd
b732764dac [TLC-249] Fixes and improvements as per review feedback 2023-02-09 08:21:38 +13:00
Kim Shepherd
c2f0159414 [TLC-249] Throw not implemented for findOne and findAll 2023-02-09 08:21:38 +13:00
Kim Shepherd
074233ce8d [TLC-249] Refactor, include controller 'find DSO' operation 2023-02-09 08:21:38 +13:00
Kim Shepherd
f9ffceb172 [TLC-249] Refactor identifiers create endpoint 2023-02-09 08:21:36 +13:00
Kim Shepherd
0f77f1d3b1 [TLC-249] Update canRegisterDOIFeature to check for cfg enabled 2023-02-09 08:21:09 +13:00
Kim Shepherd
243df364b5 [TLC-249] Fix submission controller IT 2023-02-09 08:21:09 +13:00
Kim Shepherd
7dafb1ec43 [TLC-249] Update integration tests for identifier controller 2023-02-09 08:21:09 +13:00
Kim Shepherd
94f7be0727 [TLC-249] Update identifier section IT 2023-02-09 08:21:09 +13:00
Kim Shepherd
dbcd1b9525 [TLC-249] Remove unused subclass DataIdentifier 2023-02-09 08:21:09 +13:00
Kim Shepherd
9c7729e0ab [TLC-249] Update configuration identifiers.cfg 2023-02-09 08:21:09 +13:00
Kim Shepherd
d376f45e96 [TLC-249] Improve model for identifier step data 2023-02-09 08:21:09 +13:00
Kim Shepherd
6737a218f6 [TLC-249] Lint fixes 2023-02-09 08:21:09 +13:00
Kim Shepherd
e82ff5eeec [TLC-249] Address review feedback
Controller updated to be less DOI-specific in its
registration implementation
item-status.register renamed to registerDOI
display types included in section data, for UI hints
comments / javadoc added
DOI status text sent instead of number in status data

As per tdonohue's revew on 2022-01-18
2023-02-09 08:21:07 +13:00
Kim Shepherd
65952537a0 [TLC-249] Licence header fix 2023-02-09 08:18:15 +13:00
Kim Shepherd
9a956270d3 [TLC-249] Further IT fix for identifiers 2023-02-09 08:18:15 +13:00
Kim Shepherd
03fb419e38 [TLC-249] Fix tests, Refactor things to use a LinkRestRepository for GET, Controller for POST 2023-02-09 08:18:15 +13:00
Kim Shepherd
43c2b20367 [TLC-249] Further checkstyle fixes 2023-02-09 08:18:15 +13:00
Kim Shepherd
abf65cd48c [TLC-249] Licence header fixes 2023-02-09 08:18:15 +13:00
Kim Shepherd
7926021887 [TLC-249] Checkstyle fixes 2023-02-09 08:18:15 +13:00
Kim Shepherd
12dba51b72 [TLC-249] Move GET handling back to ItemIdentifierController 2023-02-09 08:18:15 +13:00
Kim Shepherd
4140470f9d [TLC-249] Integration tests, keep GET handling in controller 2023-02-09 08:18:15 +13:00
Kim Shepherd
3373cf3330 [TLC-249] Better status return for new DOIs, write new integration tests 2023-02-09 08:18:15 +13:00
Kim Shepherd
73406b7ff0 [TLC-249] REST backend for identifier config 2023-02-09 08:18:15 +13:00
Kim Shepherd
dcdbad7d02 [TLC-249] Add and expose config for enabling register DOI 2023-02-09 08:18:14 +13:00
Kim Shepherd
20aeedfdb3 [TLC-249] Refactor to support better filter usage, PENDING and MINTED status 2023-02-09 08:17:47 +13:00
Kim Shepherd
8fcda7f03a [TLC-249] Update section count test in SubmissionDefinitionsControllerIT 2023-02-09 08:17:47 +13:00
Kim Shepherd
ef6af28fb1 [TLC-249] Remove unused import in WorkspaceItemServiceImpl 2023-02-09 08:17:47 +13:00
Kim Shepherd
c93e6e4a9e [TLC-249] Show Identifier Step, pre-register identifiers 2023-02-09 08:17:47 +13:00
Tim Donohue
e7f217210c Merge pull request #8628 from atmire/w2p-94479_issue-1809_restricted-bitstreams
Downloading restricted bitstreams does not work when opening a new tab/window
2023-02-08 13:04:29 -06:00
Marie Verdonck
cef47deddc #8628: Remove GET shortlivedtokens endpoint & related IT 2023-02-08 18:06:24 +01:00
Tim Donohue
1c4a27bcd4 Merge pull request #8619 from atmire/w2p-97298_issue-3281_self-register-issue-main
Self register domains restriction
2023-02-08 10:56:12 -06:00
corrado lombardi
f5dc078d2f Merge branch 'main' into CST-7756-SubscriptionFeature 2023-02-08 13:31:44 +01:00
Mykhaylo
a00295a32d [CST-7756] described beans 2023-02-08 13:22:50 +01:00
Mykhaylo
ae919d6117 [CST-7756] restores security check as was originaly 2023-02-08 12:49:05 +01:00
Tim Donohue
9b0c592fb7 Merge pull request #8653 from toniprieto/remove-status-filter
Fix for "All of DSpace" browse menu has odd behavior for Community/Collection Admins
2023-02-07 16:53:38 -06:00
Marie Verdonck
e1fd7e2876 Merge branch 'w2p-97414_advanced_workflow_actions-7.2' into w2p-97414_advanced_workflow_actions-main 2023-02-07 23:06:46 +01:00
Marie Verdonck
2516460364 Test IT without drop constraint 2023-02-07 23:00:37 +01:00
Marie Verdonck
1e76abdedd Merge branch 'w2p-97414_advanced_workflow_actions-7.2' into w2p-97414_advanced_workflow_actions-main 2023-02-07 22:59:50 +01:00
Marie Verdonck
9aefeebaa3 IT fix: ReviewManagers repository wide group, not collection workflow group 2023-02-07 22:01:41 +01:00
Tim Donohue
b403a01d33 Merge pull request #8589 from the-library-code/TLC-380_browse_link_configuration_PR
Browse links and "by regex" links in item display (REST)
2023-02-07 14:18:27 -06:00
corrado lombardi
6190e337ac [CST-7756] If no crosswalk is defined for the Item's entity type, default generic Item one is applied 2023-02-07 18:52:35 +01:00
corrado lombardi
31bd28e80c [CST-7756] added dissemination for generic DSpace Item 2023-02-07 18:00:26 +01:00
corrado lombardi
3584633516 [CST-7756] added email subject 2023-02-07 18:00:09 +01:00
Mykhaylo
f6967125fb [CST-7756] minor refactoring 2023-02-07 17:16:21 +01:00
Mykhaylo
9286a692c4 [CST-7756] removed 'lastModified_dt' index field 2023-02-07 17:15:37 +01:00
Mykhaylo
4ff1194c88 [CST-7756] updated subscriptions migration scripts 2023-02-07 17:14:10 +01:00
Mykhaylo
951c755943 [CST-7756] renamed a method 2023-02-07 12:12:04 +01:00
Mykhaylo
8e7cf16ccb [CST-7756] added test that proves what happens if an object is access restricted after you have a subscription to it. 2023-02-07 12:10:41 +01:00
Mykhaylo
b4db57ff99 [CST-7756] implemented community feedbacks 2023-02-07 10:41:11 +01:00
Marie Verdonck
da53eba37c Merge branch 'w2p-97414_advanced_workflow_actions-7.2' into w2p-97414_advanced_workflow_actions-main
# Conflicts:
#	dspace-api/src/main/java/org/dspace/xmlworkflow/state/actions/processingaction/SingleUserReviewAction.java
#	dspace/config/dspace.cfg
2023-02-06 17:13:13 +01:00
Marie Verdonck
07bc6d3141 #8629: PR feedback refactor 2023-02-06 16:46:35 +01:00
Marie Verdonck
450956de86 #8629: Make sure temporary worfklow groups of reviewers get deleted 2023-02-06 10:25:41 +01:00
Kim Shepherd
56ed4aadd4 [TLC-380] Remove unused methods, add ITs 2023-02-06 18:09:15 +13:00
Kim Shepherd
18609c0a20 [TLC-380] Fix browse resource byFields IT 2023-02-06 18:09:15 +13:00
Kim Shepherd
1c2a1538fd [TLC-249] Improve 'findByFields' browse refactor 2023-02-06 18:09:15 +13:00
Kim Shepherd
d85de89261 [TLC-380] Refactor browses endpoint for browse link usage 2023-02-06 18:09:15 +13:00
Kim Shepherd
135385816a [TLC-380] Further checkstyle fixes 2023-02-06 18:09:15 +13:00
Kim Shepherd
9f67c6a9f4 [TLC-380] Further checkstyle fixes 2023-02-06 18:09:15 +13:00
Kim Shepherd
14b5f0e343 [TLC-380] Fix checkstyle and duplicate code 2023-02-06 18:09:15 +13:00
Kim Shepherd
3fe4fd192f [TLC-380] Browse links and "by regex" links in item display 2023-02-06 18:09:15 +13:00
corrado lombardi
fc548e6586 Merge branch 'main' into CST-7754 2023-02-03 18:49:57 +01:00
corrado lombardi
a1550f3e5c [CST-7754] moved supervision orders test on workflow items to SupervisionOrderRestRepositoryIT, added test covering the scenario when an admin tries to set a supervision order on a withdrawn item, and when an admin sets a supervision order on a workflow item before sending it back to workspace: supervisor can edit the item only when it goes to workspace status. 2023-02-03 18:41:00 +01:00
corrado lombardi
744748ab66 [CST-7754] withdrawn item should not allow supervision order 2023-02-03 18:38:47 +01:00
corrado lombardi
920b36ec48 [CST-7754] updated comment 2023-02-03 18:38:14 +01:00
corrado lombardi
9558330aea [CST-7754] updated javadoc 2023-02-03 18:37:55 +01:00
Mykhaylo
9fe1953d07 [CST-7756] added missing IT 2023-02-03 17:22:26 +01:00
corrado lombardi
a26790fe4b [CST-7756] removed Items section 2023-02-03 15:10:46 +01:00
corrado lombardi
2c2c037ce0 [CST-7756] code refactoring 2023-02-03 15:10:27 +01:00
corrado lombardi
ad6d514e0e [CST-7756] removed mail template used by previous script 2023-02-03 15:09:45 +01:00
corrado lombardi
dca79c1a20 [CST-7756] renamed test class in order to reflect its actual behavior 2023-02-03 15:09:02 +01:00
corrado lombardi
669442eb03 [CST-7756] code refactoring 2023-02-03 15:08:26 +01:00
Mykhaylo
4fd8eeebb8 [CST-7756] added missing JavaDoc 2023-02-03 12:14:28 +01:00
corrado lombardi
c297e49ed2 Merge remote-tracking branch 'origin/CST-7756-SubscriptionFeature' into CST-7756-SubscriptionFeature
# Conflicts:
#	dspace-api/src/test/java/org/dspace/eperson/SubscribeServiceTest.java
2023-02-03 00:04:58 +01:00
corrado lombardi
611be00481 [CST-7756] extended SubscribeServiceTest in order to use service instance with real (h2) database instead of mocks, so that tests actually store, query and remove subscriptions interacting with database 2023-02-02 23:58:51 +01:00
Mykhaylo
80a7119344 [CST-7756] minor fix 2023-02-02 19:31:13 +01:00
Mykhaylo
00b53923a6 [CST-7756] removed subscriptions for items 2023-02-02 19:23:54 +01:00
Marie Verdonck
98ee5cb44f Reinstate config accidentally deleted, added in 30f923a080 (#8064) - enables RSS/Atom feeds 2023-02-02 19:08:28 +01:00
Alexandre Vryghem
54f6ba9951 99053: Add return_to_pool option to all ProcessingAction except SingleUserReviewAction 2023-02-02 18:57:49 +01:00
corrado lombardi
edcb771ef2 [CST-7756] updated script 2023-02-02 18:04:07 +01:00
corrado lombardi
d3c79bd2cb [CST-7756] extended abstract test 2023-02-02 18:01:24 +01:00
corrado lombardi
0edaba6f3a [CST-7756] after merge checkstyle fix 2023-02-02 17:54:09 +01:00
corrado lombardi
83649f6036 Merge branch 'main' into CST-7756-SubscriptionFeature
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java
2023-02-02 17:52:50 +01:00
corrado lombardi
b4f7ebfb8a [CST-7756] added instructions to migrate subscriptions from previous versions 2023-02-02 17:47:08 +01:00
Tim Donohue
8f1ba7b78d Merge pull request #8607 from atmire/w2p-97183_fix-user-authorization-issues-with-admin-sidebar
Fix user authorization issues with admin sidebar
2023-02-02 10:34:49 -06:00
Yana De Pauw
8077139c67 97425: Fix minor issues 2023-02-02 16:23:20 +01:00
corrado lombardi
6069e32353 [CST-7756] updated license header 2023-02-02 16:04:35 +01:00
corrado lombardi
f0acbb9575 [CST-7756] sub-daily command and its referred class removed, as subscriptions are sent by subscription-send command 2023-02-02 15:51:24 +01:00
corrado lombardi
0d872b543c [CST-7756] added unit tests covering methods with business logic 2023-02-02 15:39:24 +01:00
Mykhaylo
de7d1738fc [CST-7756] monor fix 2023-02-02 12:53:57 +01:00
Toni Prieto
7267e151cf Remove statusFilter added to Solr browse indexes queries to solve an issue with the local administrators navigation 2023-02-01 18:58:09 +01:00
Mohamed Saber Eskander
7197767a31 Merge remote-tracking branch 'origin/main' into CST-7754
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/DiscoveryRestControllerIT.java
2023-02-01 18:52:41 +02:00
Mykhaylo
22ebb04fcd Merge branch 'main' into CST-7756-SubscriptionFeature 2023-02-01 17:16:42 +01:00
Mykhaylo
6a02994c5b [CST-7756] refactoring 2023-02-01 17:13:42 +01:00
Mohamed Saber Eskander
da2815752c [CST-7754] removed old code of supervision orders
added a new migration script sql
tested that supervisors can edit only workspace items
2023-02-01 18:13:26 +02:00
Mykhaylo
de44d9dbe7 [CST-7756] added template for subscription content email 2023-02-01 17:12:46 +01:00
Mykhaylo
7a807f61a8 [CST-7756] added missing index field 2023-02-01 17:12:04 +01:00
Mykhaylo
0944f5956f [CST-7756] minor update 2023-02-01 17:11:24 +01:00
Yana De Pauw
d470c759b0 Merge remote-tracking branch 'upstream/main' into w2p-97425_System-wide-alerts 2023-01-31 13:26:54 +01:00
Yana De Pauw
659382fa8b 97425: Implement feedback 2023-01-31 12:27:39 +01:00
Tim Donohue
8b739d4b30 Merge pull request #8642 from atmire/w2p-98462_Use-discovery-config-in-browse
Use discovery configurations in browse
2023-01-30 14:20:14 -06:00
Tim Donohue
9354244b7c Merge pull request #8578 from tdonohue/update_bcel
Update Apache Commons BCEL and add "test" scope
2023-01-30 09:19:54 -06:00
Mykhaylo
1593e1a867 [CST-7756] refactored CanSubscribeFeatureIT 2023-01-30 13:30:01 +01:00
Mykhaylo
cb4fd99211 [CST-7756] minor fix 2023-01-27 18:09:50 +01:00
Mykhaylo
f5c1690e0b [CST-7756] renamed some methods & class 2023-01-27 14:53:53 +01:00
Mykhaylo
c59438b936 [CST-7756] added validation logic of params 2023-01-27 12:10:16 +01:00
Mykhaylo
d3c5e7debe [CST-7756] added tests to valid subscription parameters 2023-01-27 11:51:31 +01:00
Mykhaylo
20231fd086 [CST-7756] refactoring 2023-01-26 18:32:45 +01:00
Mykhaylo
9ff712c54f Merge branch 'main' into CST-7756-SubscriptionFeature 2023-01-26 14:28:09 +01:00
Mykhaylo
600a194284 [CST-7756] fixed failed tests 2023-01-26 14:25:06 +01:00
Marie Verdonck
871bac5d84 PR #8619: Removed dependency spring-context-support, not needed in main 2023-01-26 12:15:36 +01:00
Mykhaylo
0867a05e79 [CST-7756] minor refactoring according to the rest contract 2023-01-26 11:54:57 +01:00
Mykhaylo
08259ecb3a [CST-7756] removed unused service bean 2023-01-26 11:53:21 +01:00
Mykhaylo
f4ca5958ac [CST-7756] refactoring & added missing JavaDoc 2023-01-25 18:37:01 +01:00
Marie Verdonck
5a2f2eda10 Merge branch 'w2p-97298_issue-3281_self-register-issue-7.2' into w2p-97298_issue-3281_self-register-issue-main
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/RegistrationRestRepositoryIT.java
2023-01-25 16:30:23 +01:00
Marie Verdonck
f1af02c9cc 97061: type request param name change to avoid confusion with rest object type &
error codes endpoint changes + IT:
- missing/wrong query param accountRequestType => 400 bad request
- email not valid domain => 422 unprocessable entity
2023-01-25 15:40:53 +01:00
Yana De Pauw
51424cbb7c 97425: Fix issue with sessions null value 2023-01-23 17:22:32 +01:00
Tim Donohue
536e8cb347 Merge pull request #8613 from atmire/issue-1712_w2p-97080_facet-search-all-words-main
Facet search should search all words, not just the first one
2023-01-20 09:37:06 -06:00
Mykhaylo
1f06e29c25 Implemented community feedbacks 2023-01-20 11:49:29 +01:00
Marie Verdonck
e0e587ce09 Merge branch 'main' into issue-1712_w2p-97080_facet-search-all-words-main 2023-01-20 01:01:21 +01:00
Marie Verdonck
465a15f9a5 Merge branch 'issue-1712_w2p-97080_facet-search-all-words-7.2' into issue-1712_w2p-97080_facet-search-all-words-main 2023-01-20 01:00:30 +01:00
Marie Verdonck
2c155cb8b4 97080: #8613 - Doc for the prefix solr field 2023-01-20 00:53:59 +01:00
Mykhaylo
702ce8128a Merge branch 'main' into CST-7756-SubscriptionFeature 2023-01-19 12:36:45 +01:00
Tim Donohue
3ac5d566a4 Merge pull request #8600 from atmire/issue-815-controlled-vocabulary-hierarchical-facets-7.4
Issue 815 controlled vocabulary hierarchical facets 7.4
2023-01-18 11:48:03 -06:00
Koen Pauwels
9534b7893e 97183 Tests for findItemsWithEdit and countItemsWithEdit methods of ItemServiceImpl 2023-01-17 16:14:42 +01:00
jensvannerum
9d7e9eecc0 Merge branch 'main' into issue-815-controlled-vocabulary-hierarchical-facets-7.4 2023-01-16 14:31:16 +01:00
Tim Donohue
4cd3c3af95 Merge pull request #8319 from mwoodiupui/8304
Enable to answer a request a copy using "helpdesk" strategy
2023-01-13 14:48:25 -06:00
Jens Vannerum
b7626dd884 97538: Alter IT for public vocabulary search method 2023-01-13 13:19:38 +01:00
Jens Vannerum
f83c82e00d 97538: The search rest method should be public 2023-01-13 12:16:35 +01:00
Nona Luypaert
ce9f4ca08b Merge remote-tracking branch 'upstream/main' into issue-1712_w2p-97080_facet-search-all-words-main
Merge remote-tracking branch 'upstream/main' into
issue-1712_w2p-97080_facet-search-all-words-main
2023-01-13 12:10:26 +01:00
jensvannerum
98425b8066 Merge branch 'main' into issue-815-controlled-vocabulary-hierarchical-facets-7.4 2023-01-13 09:58:55 +01:00
Tim Donohue
237cad1f14 Merge pull request #8625 from atmire/Add-Range-CORS-header
Add CORS "Access-Control-Expose-Headers:  Accept-Ranges"  header
2023-01-12 15:09:50 -06:00
Tim Donohue
4e9a6f0800 Merge pull request #8631 from 4Science/DURACOM-113
[DURACOM-113] add jfif extension on bitstream formats
2023-01-12 14:32:56 -06:00
Luca Giamminonni
fc9f692bed [DURACOM-92] Tested and improved S3BitStoreService.about method 2023-01-12 17:22:45 +01:00
Yana De Pauw
d53d3054bd Merge branch 'w2p-98462_Use-discovery-config-in-browse-7.2' into w2p-98462_Use-discovery-config-in-browse 2023-01-12 16:33:42 +01:00
Yana De Pauw
d18120919c 98462: Refactor change and add admin tests 2023-01-12 16:32:51 +01:00
Francesco Pio Scognamiglio
a9c5a2ce31 [DURACOM-113] add jfif extension on bitstream formats 2023-01-12 14:59:52 +01:00
Yana De Pauw
a29b70337e Merge remote-tracking branch 'upstream/main' into w2p-98462_Use-discovery-config-in-browse 2023-01-12 14:07:13 +01:00
Yana De Pauw
902141df36 Merge tag 'dspace-7.4' into w2p-98462_Use-discovery-config-in-browse-7.4
[maven-release-plugin] copy for tag dspace-7.4
2023-01-12 13:52:48 +01:00
Yana De Pauw
3579026694 98462: Use discovery configurations in browse 2023-01-12 13:10:55 +01:00
Mykhaylo
bccd39b3c0 Merge branch 'main' into CST-7756-SubscriptionFeature 2023-01-12 10:26:39 +01:00
Mykhaylo
96ee82af97 [CST-7756] removed unused param 2023-01-12 10:18:21 +01:00
jensvannerum
282d4747e1 Merge branch 'main' into issue-815-controlled-vocabulary-hierarchical-facets-7.4 2023-01-12 10:03:09 +01:00
Luca Giamminonni
1e8c58ef6d Merge branch 'main' into DURACOM-92 2023-01-12 09:59:19 +01:00
Marie Verdonck
d0c507df64 98433: Refactoring SingleUserReviewAction & general refactoring in Actions
- Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser
2023-01-12 03:42:45 +01:00
Marie Verdonck
a24d383ab1 98433: IT fixes now that access rights are now moved to selected reviewers in AutoAssignAction 2023-01-12 02:52:16 +01:00
Marie Verdonck
3756b197ba 98433: Refactoring SingleUserReviewAction & general refactoring in Actions
- Fix in AutoAssignAction that selected reviewer didn't get registered as new InProgressSubmissionUser
2023-01-12 02:01:20 +01:00
Tim Donohue
6cdcfb50fd Merge pull request #8626 from 4Science/CST-7604
Configuration updated to highlight Orgunit and Person
2023-01-11 16:36:54 -06:00
Marie Verdonck
fb4fa0d20e Merge branch 'w2p-97414_advanced_workflow_actions-7.2' into w2p-98433_advanced_workflow_actions_SingleUserReviewAction 2023-01-11 22:32:36 +01:00
Marie Verdonck
217ea10114 Merge branch 'w2p-97414_advanced_workflow_actions-7.2' into w2p-97414_advanced_workflow_actions-main 2023-01-11 21:47:30 +01:00
Marie Verdonck
fa1c48b56c 98434: IT fix 2023-01-11 21:46:33 +01:00
Marie Verdonck
c9cf77d77c Merge branch 'main' into w2p-97414_advanced_workflow_actions-main
# Conflicts:
#	dspace-api/src/main/java/org/dspace/xmlworkflow/state/actions/processingaction/SelectReviewerAction.java
#	dspace/config/dspace.cfg
2023-01-11 21:01:56 +01:00
Marie Verdonck
bfed2b7064 98434: Advanced workflow - refactor scoreReview workflow 2023-01-11 20:53:19 +01:00
Tim Donohue
373234fd30 Merge pull request #8593 from johannastaudinger/issue-8564
DataCite plugin for import
2023-01-11 12:36:46 -06:00
Tim Donohue
c4efe41b23 Merge pull request #8611 from tdonohue/add_database_skip
Add "./dspace database skip" command to optionally skip older migrations
2023-01-11 11:54:39 -06:00
Koen Pauwels
4032828342 98433 Reject button mostly works - still triggers a 404 in console though 2023-01-11 18:07:15 +01:00
jensroets
5297f6a60b 98345 SelectReviewerAction, TaskRestRepositoriesIT and h2 migration 2023-01-11 16:26:15 +01:00
jensroets
75cfaaef80 98345 Advanced workflow actions - Parse select reviewers step 2023-01-09 16:45:22 +01:00
Yana De Pauw
f03d5ff0a6 Fix license issues 2023-01-05 17:17:11 +01:00
Yana De Pauw
8bd4ec3b10 Merge remote-tracking branch 'upstream/main' into Add-Range-CORS-header 2023-01-05 16:34:33 +01:00
Yana De Pauw
1004a7c8c4 97735: Add a accept range cors header 2023-01-05 16:27:23 +01:00
corrado lombardi
d1a7fe9a02 [CST-7604] Configuration updated to highlight Orgunit and Person 2023-01-03 13:07:35 +01:00
jensroets
bb6e089ae5 97414 Advanced workflow actions: fixed SelectReviewerAction NullPointerException 2023-01-03 12:40:09 +01:00
jensroets
51c581ed26 97414 Advanced workflow actions: implemented feedback on SelectReviewerAction + WorkflowActionRestRepositoryIT 2023-01-03 11:02:50 +01:00
Yana De Pauw
faea5a1ed2 Merge remote-tracking branch 'upstream/main' into discovery-fixes 2023-01-02 16:05:08 +01:00
Jens Vannerum
de6bccafa3 97538: Remove readability change in IT 2023-01-02 13:36:11 +01:00
Jens Vannerum
bf084d74a1 97538: Remove readability change 2023-01-02 12:28:54 +01:00
Jens Vannerum
00a11c58cb 97538: Unauthorized tests should now be anonymous 2023-01-02 12:21:00 +01:00
Jens Vannerum
e5552ead40 Merge branch 'main' into issue-815-controlled-vocabulary-hierarchical-facets-7.4 2023-01-02 10:11:16 +01:00
Koen Pauwels
7ee46e0cba 97183 Processing PR review feedback 2023-01-02 09:58:31 +01:00
Mohamed Saber Eskander
7a08fe50fe [CST-7754] test supervision order is deleted if workspaceItem or group is deleted. 2023-01-02 10:58:18 +02:00
corrado lombardi
01634d1414 [CST-7754] otherworkspace discovery configuration shows only supervised workspace items, when a supervision order is deleted grants given to supervision groups on an item are revoked. 2022-12-30 15:55:23 +01:00
corrado lombardi
e9af511f26 Merge branch 'main' into CST-7754 2022-12-30 14:20:36 +01:00
corrado lombardi
343ce405f7 Merge branch 'main' into CST-7756-SubscriptionFeature 2022-12-30 11:29:43 +01:00
corrado lombardi
1fd22ee8a9 Merge remote-tracking branch 'origin/CST-7756-SubscriptionFeature' into CST-7756-SubscriptionFeature 2022-12-30 11:20:10 +01:00
corrado lombardi
bca8d6320a [CST-7756] fixed database scripts version number 2022-12-30 11:17:53 +01:00
Giuseppe Digilio
c52042aad5 [CST-7756] Fix checkstyle 2022-12-30 09:22:45 +01:00
Giuseppe Digilio
d5888a8cfd [CST-7756] Rename type property to subscriptionType in the subscriptionType object 2022-12-29 18:36:15 +01:00
Marie Verdonck
f8037d465a 97298: Self-register - test fixes 2022-12-29 17:30:48 +01:00
Marie Verdonck
1cff907a2f Merge branch 'w2p-97298_issue-3281_self-register-issue-7.2' into w2p-97298_issue-3281_self-register-issue-main 2022-12-29 17:30:14 +01:00
Marie Verdonck
2f196624e0 97298: Self-register - test fixes 2022-12-29 17:08:58 +01:00
Marie Verdonck
6a594cb62b 97298: #3281 Self-register - fix, needs existent user for forgot 2022-12-29 16:57:05 +01:00
Marie Verdonck
cd709c5033 Merge branch 'w2p-97298_issue-3281_self-register-issue-7.2' into w2p-97298_issue-3281_self-register-issue-main 2022-12-29 15:31:04 +01:00
Marie Verdonck
3dc98bae78 97298: #3281 Self-register - type param 2022-12-29 15:17:54 +01:00
corrado lombardi
b54bdd1712 [CST - 7754] refactoring and added support for NONE type 2022-12-28 10:09:54 +01:00
jensroets
25ef93ac7b 97414 Advanced workflow actions: javadocs + moved isAdvanced method 2022-12-23 15:18:02 +01:00
Mohamed Saber Eskander
5330c2dc0f [CST-7754] removed unused fields. 2022-12-23 15:29:13 +02:00
Marie Verdonck
37be809eb0 Merge remote-tracking branch 'origin/main' into w2p-97298_issue-3281_self-register-issue-main 2022-12-23 14:26:41 +01:00
Joost
813eb1ef8a Merge branch 'w2p-97298_issue-3281_self-register-issue-7.2' into w2p-97298_issue-3281_self-register-issue-main 2022-12-23 14:26:03 +01:00
Marie Verdonck
845c58f246 Merge remote-tracking branch 'origin/main' into issue-1712_w2p-97080_facet-search-all-words-main 2022-12-23 14:19:38 +01:00
Yana De Pauw
1cabe8e87c 97425: Update names of sessions enum 2022-12-23 12:00:44 +01:00
Yana De Pauw
45e4748482 97425: Create "System Wide Alerts" feature 2022-12-23 10:35:35 +01:00
Mohamed Saber Eskander
dea4b5e17f [CST-7754] LYRASIS: Supervisor orders (REST). 2022-12-22 17:40:43 +02:00
Philipp Rumpf
26f0a42521 Merge pull request #8
* DataCite: use configuration service to set URL + timeout

* DataCite: configure DataCite url + timeout in external-providers.cfg

* DataCite: add DataCite bean to default configuration
2022-12-22 13:42:23 +01:00
jensroets
3cf0be61ef 97414 Advanced workflow actions: SelectReviewerAction advanced info 2022-12-21 16:00:08 +01:00
jensroets
c21eb479f3 97414 Advanced workflow actions: refactor for updated rest contract 2022-12-21 14:05:34 +01:00
Tim Donohue
ba68535d76 Merge pull request #8605 from atmire/w2p-97294_content_migration_contribution
Huge performance improvement on metadata import
2022-12-20 15:59:23 -06:00
Tim Donohue
d50f669a78 Merge pull request #8612 from toniprieto/browse-by-title-with-spaces
Fix Browse by Title cannot filter by multiple words
2022-12-20 15:15:44 -06:00
Tim Donohue
4047235e69 Merge pull request #8562 from mwoodiupui/8561
Option to skip bitstreams on import, like 'export -x'
2022-12-20 14:11:01 -06:00
Kevin Van de Velde
0567e8df03 Adding a sensible default to the "bulkedit.change.commit.count" retrieval 2022-12-20 17:19:44 +01:00
Kevin Van de Velde
167016084d Renaming the resource policy sql file and adding the same file to the H2 so our tests are in sync 2022-12-20 17:14:51 +01:00
Tim Donohue
83cf9e88d4 Merge pull request #8591 from arvoConsultores/DS-8412
#8412 In Submission Form, list collections alphabetically
2022-12-20 10:00:54 -06:00
Tim Donohue
6363b21c84 Merge pull request #8565 from 4Science/main_8563_DURACOM-101
Common Extendend Regex Parser
2022-12-20 09:39:50 -06:00
Adan Roman
027c79e341 Sorting constant moved and renamed 2022-12-20 10:39:30 +01:00
Joost
507189a828 [task 97298] only check for allowed domains on register 2022-12-20 09:35:59 +01:00
Vincenzo Mecca
72813eebaf [8563][DURACOM-101] Multiflag regex tests 2022-12-19 18:40:06 +01:00
Vincenzo Mecca
14b7ac18b0 [8563][DURACOM-101] Improved Regex Tests 2022-12-19 18:14:40 +01:00
Vincenzo Mecca
496f936a7d [8563][DURACOM-101] Removed unreachable branch 2022-12-19 18:14:15 +01:00
Tim Donohue
a7cba3c57b Merge pull request #8522 from qzhao-ulb/patch-6
Item/Collection admin can't create new version item
2022-12-19 10:54:39 -06:00
Vincenzo Mecca
7efc955460 [8563][DURACOM-101] Updated JavaDoc for computePattern method 2022-12-19 17:40:18 +01:00
Tim Donohue
014e671fd6 Remove unnecessary system.out from IT 2022-12-19 10:09:55 -06:00
jensroets
d0a91347c6 97414 Advanced workflow actions 2022-12-19 16:53:49 +01:00
Mykhaylo
9f456c21d5 [CST-7756] porting of SubscribeFeature 2022-12-19 13:51:06 +01:00
qzhao
44e99772e1 Merge branch 'patch-6' of https://github.com/qzhao-ulb/DSpace into patch-6 2022-12-19 13:36:05 +01:00
qzhao
f523420a9b add test method for bugfix "collectin admin can create new version" pull request: dspace/dspace/#8522 2022-12-19 12:59:45 +01:00
Yury Bondarenko
eb28c639a0 Merge branch 'discovery-fixes-7.2' into discovery-fixes 2022-12-19 12:11:12 +01:00
Yury Bondarenko
1300cdc75b 97248: Cache discovery configurations by UUID 2022-12-19 11:20:53 +01:00
QZhao
3240c1c33f Merge branch 'main' into patch-6 2022-12-19 08:56:51 +01:00
Nona Luypaert
c65314db9d Merge remote-tracking branch 'origin' into issue-1712_w2p-97080_facet-search-all-words-main
97080: Facet search box should search all words
2022-12-16 17:06:13 +01:00
Nona Luypaert
32bafed548 97080: Browse values also get indexed with _prefix field 2022-12-16 16:35:27 +01:00
Nona Luypaert
4ff2e2826d 97080: Fix DiscoveryRestControllerIT 2022-12-16 15:54:31 +01:00
Nona Luypaert
6195127e81 97080: Facet search on all words: authorityKey fix + ITs 2022-12-16 12:49:30 +01:00
Adan Roman
193f0a4750 checkstyle 2022-12-16 10:14:01 +01:00
Adan Roman
003a89c8ed Merge branch 'DS-8412' of https://aroman-arvo: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@github.com/arvoConsultores/DSpace.git into DS-8412 2022-12-16 10:06:23 +01:00
aroman-arvo
bc597b710b Merge branch 'DS-8412' of https://github.com/arvoConsultores/DSpace into
DS-8412
2022-12-16 10:05:56 +01:00
aroman-arvo
b4408e5e8a Merge branch 'DS-8412' of https://github.com/arvoConsultores/DSpace into DS-8412 2022-12-16 09:55:12 +01:00
Arvo Consultores y Tecnología. S.L
3e7599dff6 Merge branch 'DSpace:main' into DS-8412 2022-12-16 09:43:28 +01:00
Adan Roman
bc6066523f #8412 In Submission Form, list collections alphabetically - solr
ordering
2022-12-16 09:38:48 +01:00
Mark H. Wood
ea6876f2fe Add option to GUI as well. 2022-12-15 14:22:59 -05:00
Mark H. Wood
0f38f261c2 Rename option to parallel the exporter. 2022-12-15 14:22:25 -05:00
Nona Luypaert
2f546ffafa Merge remote-tracking branch 'atmire/w2p-95912_facet-capital-letter-bugfix' into issue-1712_w2p-97080_facet-search-all-words-7.2
95912: queries should be case-insensitive
2022-12-15 15:50:47 +01:00
Yana De Pauw
69500ad5d5 Fix discovery test config and make ids for relationship profiles unique 2022-12-15 11:55:05 +01:00
Mykhaylo
57f917ae0e [CST-7756] porting of the script for notification of content subscription 2022-12-14 16:14:48 +01:00
Mykhaylo
25b8ba8ead [CST-7756] added tests 2022-12-14 11:10:36 +01:00
Yana De Pauw
38b30c394c Fix openSearchController issue 2022-12-14 10:32:54 +01:00
Tim Donohue
7c68e09486 Add database skip command. Minor refactor of DatabaseUtils to use switch 2022-12-13 15:13:19 -06:00
Yana De Pauw
14534b4eaf Move context to first argument in getDiscoveryConfigurationByNameOrDso 2022-12-13 17:47:35 +01:00
Yana De Pauw
2f8260ec49 Merge branch 'discovery-fixes-7.2' into discovery-fixes 2022-12-13 17:09:37 +01:00
Yana De Pauw
463edac869 Remove local file 2022-12-13 17:08:02 +01:00
Yana De Pauw
eb50fa03eb Merge branch 'discovery-fixes-7.2' into discovery-fixes 2022-12-13 16:38:56 +01:00
Yana De Pauw
c538b9cbed Add docs and remove unused site configuration 2022-12-13 14:27:29 +01:00
Yana De Pauw
82bc777e45 Fix issue with indexing and add tests 2022-12-13 12:32:15 +01:00
Marie Verdonck
fc6ac8e078 97080: #1712 - Refactoring facet search all words 2022-12-13 12:00:00 +01:00
Joost
2378dbbeec Merge remote-tracking branch 'upstream/main' into w2p-97298_issue-3281_self-register-issue-main 2022-12-13 10:38:30 +01:00
Philipp Rumpf
f0cd84ed77 Tests: configure dc.contributor.author, test it 2022-12-12 14:38:53 +00:00
Johanna Staudinger
607e7458e0 Minor fixes:
remove unused class field
avoid potential NPE on invalid JSON
2022-12-12 14:38:53 +00:00
Philipp Rumpf
360bc85ead Merge pull request #5
* DataCite plugin for import

* start copying Crossref test

* use dataCite original JSON

* snapshot

* adjust DataCite mapping to grab all titles

* simplify DataCiteImportMetadataSourceServiceImpl. Avoid GSON, JsonPat…

* rewrite DataCiteImportMetadataSourceServiceIT based on CrossRef IT.
2022-12-12 14:38:53 +00:00
Johanna Staudinger
a9cee40a15 DataCite plugin for import
Plugin for import of external metadata from DataCite for publications.
Code by @johannastaudinger, @floriangantner and @philipprumpf.
2022-12-12 14:38:53 +00:00
Toni Prieto
d906d9463b Add test for filtering browse by title with spaces 2022-12-12 10:50:19 +01:00
Toni Prieto
b0afb15efa Escape special characters in startsWith filter of browse by title 2022-12-12 10:46:39 +01:00
Tim Donohue
ec483fef5b Update BCEL and add correct scope 2022-12-09 10:37:48 -06:00
Kevin Van de Velde
f2d329dc88 Changing a log info to a handler logInfo call 2022-12-09 09:24:00 +01:00
Kevin Van de Velde
c705e3c92c Fixing tests 2022-12-09 09:21:31 +01:00
Kevin Van de Velde
77be5cdc25 Improve performance for metadata imports 2022-12-09 09:21:19 +01:00
jensvannerum
9752677b70 Merge branch 'main' into issue-815-controlled-vocabulary-hierarchical-facets-7.4 2022-12-08 17:06:10 +01:00
jensroets
1a9b1e3e94 89597 Metadata import (Improve performance): edit comment 2022-12-08 13:57:03 +01:00
jensroets
02cb5243a4 89597 Metadata import (Improve performance) 2022-12-08 13:56:34 +01:00
Koen Pauwels
1252a98240 97183 SolrServiceIndexItemEditorsPlugin: fixed logger type 2022-12-08 10:33:31 +01:00
Tim Donohue
ec0853ddad Merge pull request #8579 from TexasDigitalLibrary/DS-8385
DS-8385: Use discovery configuration to get correct sort field type for given …
2022-12-07 15:13:06 -06:00
Tim Donohue
424d691b98 Merge pull request #8571 from TexasDigitalLibrary/DS-4488
DS-4488: Log views statistics even when MaxMind DatabaseReader isn't fully configured
2022-12-07 14:32:59 -06:00
Tim Donohue
cf21da8ce7 Merge pull request #8594 from DSpace/dependabot/maven/org.postgresql-postgresql-42.4.3
Bump postgresql from 42.4.1 to 42.4.3
2022-12-07 12:06:38 -06:00
dependabot[bot]
e8dc1c9a58 Bump postgresql from 42.4.1 to 42.4.3
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.4.1 to 42.4.3.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.4.1...REL42.4.3)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-07 17:09:19 +00:00
Vincenzo Mecca
c933cd60ef Merge branch 'main' into main_8563_DURACOM-101 2022-12-07 18:05:04 +01:00
Mykhaylo
9901bcfd55 [CST-7756] minor fix 2022-12-07 17:37:30 +01:00
Tim Donohue
b38cbb0ba0 Merge pull request #8550 from alanorth/imagemagick-cropbox
dspace-api: tell ImageMagick about the PDF CropBox
2022-12-07 10:32:33 -06:00
Mykhaylo
bd6334d9b0 [CST-7565] minor refactoring 2022-12-07 16:45:55 +01:00
Joost
a152b551d4 [task 97298] implemented check for allowed domains during registration' 2022-12-07 16:32:08 +01:00
Mykhaylo
fd7016f14e [CST-7756] refactoring 2022-12-07 14:25:35 +01:00
Nona Luypaert
088bbc8053 97080: Fix facet search box should search all parts (WIP) 2022-12-07 14:23:01 +01:00
Alan Orth
e6693f4232 dspace-api: tell ImageMagick about the PDF CropBox
ImageMagick uses the MediaBox by default when rasterizing PDFs be-
cause the PDF specification says that all PDFs *must* contain one.
This page box is the parent for all other boxes that a PDF *may*
contain, for example a CropBox, ArtBox, etc. In many cases these
are the same, but when they are not the CropBox is used to define
the area displayed to a user when they open the PDF on screen (as
opposed to when printing on paper).

If a PDF has a CropBox that is different to its MediaBox then we
should tell ImageMagick to use it.

Fixes: https://github.com/DSpace/DSpace/issues/8549
2022-12-06 14:00:38 -06:00
Tim Donohue
705f87a826 Merge pull request #8402 from mspalti/canvas-dims-mutiple-bundles
Updates the canvas dimension method to use multiple bundles.
2022-12-06 13:59:56 -06:00
Michael W Spalti
34e6ce3b39 Missing javadoc. 2022-12-06 12:41:15 -06:00
Michael W Spalti
b0f809db05 Added mock to dspace-api tests.
Updated bean configs.
2022-12-06 12:41:15 -06:00
Michael W Spalti
83b1b346c9 Updating to address feedback. 2022-12-06 12:41:15 -06:00
Michael W Spalti
37e89c13b1 New mock and test. 2022-12-06 12:41:15 -06:00
Michael Spalti
d4c03764a6 Added check for image format.
Added logging for error.
2022-12-06 12:41:15 -06:00
Michael Spalti
18ce42c388 Updates the canvas dimension method to use multiple bundles. 2022-12-06 12:41:15 -06:00
Tim Donohue
b5b94b2986 Merge pull request #8548 from tdonohue/enable_github_codeql
Update to use GitHub CodeQL for code scanning
2022-12-06 12:09:38 -06:00
Tim Donohue
9cd358f7b2 Update to use GitHub CodeQL for code scanning 2022-12-06 11:25:30 -06:00
Tim Donohue
7f04d496e5 Merge pull request #8602 from tdonohue/more_contributing
Minor fixes to sync CONTRIBUTING with PR template
2022-12-06 11:08:46 -06:00
Tim Donohue
a501d84092 Minor fixes to sync CONTRIBUTING with PR template 2022-12-06 10:48:42 -06:00
Tim Donohue
9764eefd77 Merge pull request #8568 from tdonohue/add_contributing_docs
Add Contributing docs to GitHub
2022-12-06 09:49:48 -06:00
Koen Pauwels
f928ec71f6 97183 Renamed "canEditItem" feature 2022-12-06 16:12:38 +01:00
Yana De Pauw
3e651af760 97248: Find DSO based configurations recursively through parent objects 2022-12-06 12:37:21 +01:00
Yana De Pauw
8e2ada65b1 97248: Fix File info Solr plugin to allow faceting 2022-12-06 12:36:34 +01:00
Koen Pauwels
ebccac79f7 97183 EditItemFeature integration tests 2022-12-06 09:09:39 +01:00
Tim Donohue
35f65ff5b8 Add Contributing docs 2022-12-05 16:13:09 -06:00
Tim Donohue
0b61d7c738 Merge pull request #8597 from tdonohue/fix_broken_IT
Fix broken OrcidQueueConsumerIT & several other flakey tests
2022-12-05 15:57:17 -06:00
Tim Donohue
17d0fe83c4 Fix flakey tests in ExternalSourcesRestControllerIT 2022-12-05 14:24:52 -06:00
Tim Donohue
ab767ca694 Fix flakey test in CreateMissingIdentifiersIT to ensure new curation task loads immediately 2022-12-05 14:24:52 -06:00
Tim Donohue
072ae5f65e Ensure assigned Handles have a fake prefix so they cannot overlap with incremental, autoassigned Handles 2022-12-05 10:56:44 -06:00
Koen Pauwels
ada0b8c4d1 97183 Added EditItemFeature 2022-12-05 16:49:47 +01:00
Koen Pauwels
36e9f0d4f7 97183 SubmitFeatureIT: renamed some tests 2022-12-05 16:42:26 +01:00
Koen Pauwels
3fe6491975 97183 Integration tests and fixes for SubmitFeature 2022-12-05 16:27:51 +01:00
Tim Donohue
a81dd28a46 Ensure ItemBuilder also cleans up WorkspaceItem if it still exists 2022-12-02 14:49:57 -06:00
Tim Donohue
64e5697d47 Ensure @Before and @After override default methods 2022-12-02 14:37:03 -06:00
Mykhaylo
2c11f7c757 [CST-7756] refactoring 2022-12-02 18:19:37 +01:00
Koen Pauwels
6cbb1630e3 97183 ItemService: added methods to search the index for items for which the current user has editing rights 2022-12-02 16:09:26 +01:00
Jens Vannerum
e902ace5c9 Merge branch 'issue-815-controlled-vocabulary-hierarchical-facets-7.2,' into issue-815-controlled-vocabulary-hierarchical-facets-7.4 2022-12-02 14:17:10 +01:00
Koen Pauwels
f99e876327 97183 IndexingUtils: Changed interface to Lists instead of Streams 2022-12-02 10:50:24 +01:00
Koen Pauwels
31cb37b4a5 97183 Minor fixes to IndexingUtils#findDirectlyAuthorizedGroupAndEPersonPrefixedIds 2022-12-02 09:49:06 +01:00
Tim Donohue
c36d0e2278 Merge pull request #8583 from tdonohue/require_javadoc_methods
Require javadocs for all public methods. Fix checkstyle errors.
2022-12-01 14:59:25 -06:00
Mykhaylo
d08b3cb984 [DSC-183] header licence 2022-12-01 18:58:42 +01:00
Mykhaylo
389cb760e2 [DSC-193] tests added, code review fixes, other fixes in pagination and ordering 2022-12-01 18:57:45 +01:00
Mykhaylo
3ac40b9761 [DSC-183] new paramater of type of dso in findall and pagination usage in query 2022-12-01 18:54:35 +01:00
Mykhaylo
141cde9899 [DSC-183] Fix checkstyle and refactor 2022-12-01 18:51:24 +01:00
Mykhaylo
bdb4bd53dc [DSC-183] New endpoint, IT tests changed 2022-12-01 18:43:42 +01:00
Mykhaylo
b036262514 [DSC-183] fixes 2022-12-01 18:32:11 +01:00
Mykhaylo
40c0c9b7db [DSC-183] Created Subscription_Parameter, Changed Subscription and created entry points components for Subscription 2022-12-01 18:29:19 +01:00
Mykhaylo
c535de90f1 [DSC-183] Created Subscription_Parameter, Changed Subscription and created entry points components for Subscription 2022-12-01 18:25:00 +01:00
Jens Vannerum
f7e7f69f2d 97049: Remove client specific test 2022-12-01 17:49:15 +01:00
Koen Pauwels
6621e57ebd 97183: Added SolrServiceIndexItemEditorsPlugin
Analogous to SolrServiceIndexCollectionSubmittersPlugin, but for Items instead
of Collections, and for WRITE rights instead of ADD rights.

Also refactored SolrServiceIndexCollectionSubmittersPlugin to share code with
the new plugin.
2022-12-01 16:37:03 +01:00
Jens Vannerum
2c7c40876d 97049: Remove client structure 2022-12-01 15:36:38 +01:00
Joost
cfbd7785e5 [task 86387] made findone for vocabularies publicly available 2022-12-01 11:25:07 +01:00
Samuel
f065f12fa7 taskid 85816 Rename vocabularies to match the discovery config 2022-12-01 11:25:06 +01:00
Samuel
188d02c822 taskid 85555 Custom DSpaceControlledVocabulary for WB syntax - permissions 2022-12-01 11:22:55 +01:00
Samuel
a6992efd45 taskid 85555 Custom DSpaceControlledVocabulary for WB syntax 2022-12-01 11:22:53 +01:00
Koen Pauwels
4a7952af15 97183 Added SubmitFeature: checks if eperson has ADD rights to any or specific collection 2022-12-01 08:45:57 +01:00
Vincenzo Mecca
fbb1405776 [8563][DURACOM-101] Fixed regex validation
Fixed:
  - Checks for string emptiness while validating input;

Feat:
  - Saved Compiled pattern using ECMAScript standard inside DCInput.
2022-11-28 10:54:54 +01:00
Arvo Consultores y Tecnología. S.L
9e6434d89b Merge branch 'main' into DS-8412 2022-11-23 11:07:02 +01:00
Adan Roman
ffc15ec54a #8412 In Submission Form, list collections alphabetically 2022-11-16 16:22:36 +01:00
Tim Donohue
f2fa6863d2 Fix broken link in PR template 2022-11-15 16:18:35 -06:00
Tim Donohue
59838e6e29 Add link to REST Contract from PR template 2022-11-15 16:17:51 -06:00
Tim Donohue
ee1f9f047e Require javadocs for all public methods. Fix checkstyle errors. 2022-11-11 16:13:08 -06:00
Luca Giamminonni
da778f3306 [DURACOM-92] Fixed dependency convergence error 2022-11-11 17:17:12 +01:00
Luca Giamminonni
4d085503c9 [DURACOM-92] Fixed dependency convergence error 2022-11-11 17:06:37 +01:00
Luca Giamminonni
ba0819782a [DURACOM-92] Improved S3BitStoreService using embedded S3 2022-11-11 16:43:05 +01:00
Luca Giamminonni
934a4b3b6e Merge remote-tracking branch '4science-bitbucket/main' into DURACOM-92 2022-11-11 10:51:54 +01:00
nwoodward
29b1eaa078 added sort tests 2022-11-10 11:49:45 -06:00
Tim Donohue
2d5eafb384 Merge pull request #8556 from the-library-code/TLC-387_s3_bitstore_registration
[TLC-387] When retrieving S3 bitstream, strip -R from internal ID if bitstream is registered
2022-11-10 10:15:31 -06:00
Tim Donohue
fd6450ca55 Merge pull request #8537 from tdonohue/update_commons-text
Require commons-text 1.10.0 in dependencyManagement
2022-11-10 10:07:08 -06:00
nwoodward
99ecf531ea fix checkstyle errors 2022-11-10 08:02:25 -06:00
Kim Shepherd
196926576d [TLC-387] Add basic unit tests for registered ID handling in S3 bitstore 2022-11-10 11:45:40 +13:00
nwoodward
a152f9baef use discovery configuration to get correct sort field type for given sort field 2022-11-09 15:53:00 -06:00
nwoodward
a350090d76 stop requiring Maxmind DatabaseReader to log views statistics 2022-11-07 16:52:46 -06:00
Vincenzo Mecca
57fcfec276 [8563] [DURACOM-101] Changed method name and visibility 2022-11-04 09:34:22 +01:00
Vincenzo Mecca
d1f61b8acd [8563] [DURACOM-101] Checkstyle fix 2022-11-04 09:30:18 +01:00
Tim Donohue
ccd47b0ddd Merge pull request #8566 from tdonohue/update_actions
Update to the latest version of all GitHub actions
2022-11-03 17:26:38 -05:00
Tim Donohue
279b6785fe Update to the latest version of all GitHub actions 2022-11-03 16:05:11 -05:00
Tim Donohue
d3de602f66 Merge pull request #8547 from toniprieto/translate-cc
Use translations of Creative Commons API
2022-11-03 14:59:16 -05:00
Vincenzo Mecca
ff44d3f591 [8563] [DURACOM-101] Unit tests for RegexPatternUtils 2022-11-03 18:50:27 +01:00
Vincenzo Mecca
8c88b4973c [8563][DURACOM-101] Refactored regex usage
Introduced a new dspace-api Regex-Pattern utility class.
2022-11-03 17:48:07 +01:00
Tim Donohue
e5b5aa5e09 Merge pull request #8545 from toniprieto/cc-jurisdiction
Fix for Creative Commons jurisdiction chosen is ignored (REST API)
2022-11-03 11:07:24 -05:00
Mark H. Wood
035d42c194 Option to skip bitstreams like 'export -x' 2022-11-01 17:15:56 -04:00
Tim Donohue
7fdc3c53b5 Merge pull request #8553 from alanorth/imagemagick-pdf-density
dspace-api: allow overriding ImageMagick density
2022-11-01 11:20:38 -05:00
Tim Donohue
6003cc8151 Merge pull request #8541 from TexasDigitalLibrary/DSpace-8450
DS-8450 Fixes the null subject in the request acceptance email
2022-10-31 15:16:55 -05:00
Tim Donohue
8c9a920cb6 Merge pull request #8551 from TexasDigitalLibrary/DSpace-8298
DS-8298: set last harvested time for successful OAI harvest
2022-10-31 14:31:10 -05:00
Tim Donohue
fff620b682 Merge pull request #8535 from 4Science/DURACOM-98_solr-logging
Enable solr slow query logging
2022-10-31 14:08:54 -05:00
Tim Donohue
9dd3887030 Merge pull request #8529 from atmire/w2p-95912_facet-capital-letter-bugfix-main
Facet search endpoint queries should be case-insensitive
2022-10-31 12:46:03 -05:00
Tim Donohue
6c0f4d1b07 Merge pull request #8559 from sashashura/patch-1
GitHub Workflows security hardening
2022-10-31 10:30:30 -05:00
Alex
07f2cc0e33 build: harden label_merge_conflicts.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-10-31 16:55:32 +02:00
Alex
1cf5a5497d build: harden docker.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-10-31 16:45:42 +02:00
Alex
6695396d28 build: harden build.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-10-31 16:45:18 +02:00
Tim Donohue
a0732efa35 Merge pull request #8532 from atmire/w2p-96097_CreateMissingIdentifiersIT-bugfix
CreateMissingIdentifiersIT affecting other tests fix
2022-10-31 09:09:38 -05:00
Alex
bc41e60b70 build: harden issue_opened.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-10-31 15:05:43 +02:00
Kim Shepherd
517daaeea2 [TLC-387] When retrieving S3 bitstream, strip -R from internal ID if bitstream is registered 2022-10-31 12:17:07 +13:00
Tim Donohue
77ea148574 Merge pull request #8523 from J4bbi/ds7-oai-remove-bundles
OAI : Use removeAllBundles, defend against ConcurrentModificationException
2022-10-28 16:16:41 -05:00
Tim Donohue
78cc75e180 Merge pull request #8531 from christian-scheible/refresh_spider_file_bugfix
Fixes #8528, refreshing spider files causes null pointer.
2022-10-28 14:52:54 -05:00
Tim Donohue
0c9ee528f8 Merge pull request #8502 from atmire/Fix-registry-dependent-IT-for-MetadatafieldRestRepository
Fix hardcoded `workflow.score` comparison in MetadatafieldRestRepositoryIT
2022-10-28 14:50:56 -05:00
Tim Donohue
4539c8db60 Merge pull request #8484 from nibou230/copy-request-email-8451
Send email even if copy request is refused
2022-10-28 14:39:07 -05:00
Tim Donohue
616170df7a Ensure label_merge_conflicts never runs on forks 2022-10-28 09:55:53 -05:00
Tim Donohue
7c2aa7f86d Bug fix to label_merge_conflicts GitHub action 2022-10-28 09:43:19 -05:00
Tim Donohue
55334703f3 Merge pull request #8552 from tdonohue/update_merge_conflict_action
Switch GitHub action for labeling merge conflicts
2022-10-28 09:26:20 -05:00
Alan Orth
bf0038182f dspace-api: allow overriding ImageMagick density
Allow users to override ImageMagick's default density of 72 DPI for
creating PDF thumbnails. In this case a density of 144 will perform
a "2x" supersample, which greatly increases the quality of the res-
ulting images at the expense of slightly longer execution time and
higher memory usage.

See: https://imagemagick.org/script/command-line-options.php#density
See: https://stackoverflow.com/questions/49828544/how-to-make-thumbnails-using-imagickresizeimage-appear-sharper-php
Fixes: https://github.com/DSpace/DSpace/issues/8514
2022-10-28 09:28:15 +03:00
Tim Donohue
8aa8518ed8 Switch GitHub action for labeling merge conflicts 2022-10-27 13:35:06 -05:00
nwoodward
e3133460b8 set last harvested time for successful OAI harvest 2022-10-27 13:19:50 -05:00
Toni Prieto
954cf43caf Changes to use the translations of CC API when no default locale is configured and correct language code used for CC metadata 2022-10-26 10:57:29 +02:00
Toni Prieto
fd5dda2f0e Expose configuration key cc.license.jurisdiction and use user-selected jurisdiction if this key is set to none 2022-10-26 09:33:19 +02:00
nwoodward
e49d4c9f54 changed to check that headerValue is not null before setting subject to it 2022-10-24 15:20:31 -05:00
Tim Donohue
5c697c813b Merge pull request #8534 from DSpace/dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.13.4.1
Bump jackson-databind from 2.12.6.1 to 2.13.4.1
2022-10-24 12:18:20 -05:00
Tim Donohue
ad4a13e7ab Update jackson core alongside databind
Also bumped databind to absolute latest
2022-10-24 11:17:17 -05:00
Tim Donohue
a6e4c7daba Merge branch 'main' into dependabot/maven/com.fasterxml.jackson.core-jackson-databind-2.13.4.1 2022-10-24 10:56:40 -05:00
Tim Donohue
b3ad1d5606 Fix comment 2022-10-21 16:50:05 -05:00
Tim Donohue
21aebee319 Update GitHub token for action 2022-10-21 16:37:30 -05:00
Tim Donohue
79d70be6fb Update action to add issues to new triage board 2022-10-21 16:22:26 -05:00
Tim Donohue
d6cc202e6b Require commons-text 1.10.0 in dependencyManagement. Remove unnecessary references to commons-text elsewhere in POMs 2022-10-19 10:27:01 -05:00
corrado lombardi
64d264a660 [DURACOM-98] enable solr slow query logging 2022-10-19 15:30:28 +02:00
dependabot[bot]
c425da2ffb Bump jackson-databind from 2.12.6.1 to 2.13.4.1
Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.12.6.1 to 2.13.4.1.
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-19 05:59:04 +00:00
Tim Donohue
63b1ff825b Merge pull request #8306 from kshepherd/docker-test_remote_debug
Dockerfile.test and docker-compose: expose port 8000, set JDWP java opts
2022-10-18 14:39:08 -05:00
Kristof De Langhe
93e72eff54 96097: CreateMissingIdentifiersIT affecting other tests fix 2022-10-18 11:16:59 +02:00
Christian Scheible
6f02dd502d Fixes #8528, refreshing spider files causes null pointer. 2022-10-18 09:28:59 +02:00
Tim Donohue
2a6b457f5a Merge pull request #8503 from alanorth/update-pdfbox
Update PDFBox dependency to version 2.0.27
2022-10-17 15:28:56 -05:00
Tim Donohue
4789b16511 Merge pull request #8504 from alanorth/update-commons-dbcp2
Update Apache commons-dbcp2 and commons-pool2 dependencies
2022-10-17 15:12:01 -05:00
Jens Vannerum
0ad63f054b Merge branch 'w2p-95912_facet-capital-letter-bufix' 2022-10-17 15:52:26 +02:00
Jens Vannerum
1047dca2fd 95912: queries should be case-insensitive 2022-10-17 15:49:41 +02:00
Hrafn Malmquist
528f1a4ff2 Use removeAllBundles, defend against ConcurrentModificationException 2022-10-15 01:14:30 +01:00
QZhao
d015c4b8e8 Bugfix: item admin can't create new version item 2022-10-14 10:41:43 +02:00
Alan Orth
e65c277779 pom.xml: update DBCP2 dependency
Update commons-dbcp2 and commons-pool2 to latest stable versions.
2022-10-07 10:34:01 +03:00
Alan Orth
75e1c0c27d pom.xml: update pdfbox to 2.0.27
See release notes for versions from the current 2.0.24 until 2.0.27
here:

- 2.0.25: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310760&version=12350196
- 2.0.26: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310760&version=12350925
- 2.0.27: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310760&version=12351648
2022-10-07 10:33:28 +03:00
Tim Donohue
7837fbacd1 [maven-release-plugin] prepare for next development iteration 2022-10-06 12:53:51 -05:00
Tim Donohue
4cdb66267e [maven-release-plugin] prepare release dspace-7.4 2022-10-06 12:53:47 -05:00
Tim Donohue
90bb165eab Minor updates for 7.4 2022-10-06 12:23:54 -05:00
Tim Donohue
70fc220660 Merge pull request #8357 from 4Science/main-duracom-70
Add compatibility for DSpace 7 with the Remote Handle Resolver
2022-10-04 14:48:07 -05:00
Tim Donohue
4067a40f86 Merge pull request #8508 from mwoodiupui/8507
Shorten the classpath in bin/start-handle-server to address inconsistent ClassNotFound
2022-10-04 13:10:01 -05:00
Tim Donohue
bf892262dd Merge pull request #8509 from jeffmorin/main
Fixed start-handle-server.bat (Windows version)
2022-10-04 10:35:29 -05:00
Jean-François Morin
02c2fea8da Cleaned all references to OAI 2022-10-04 10:54:20 -04:00
Tim Donohue
110d577c33 Merge pull request #8482 from 4Science/CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot
New users might be registered in a massive way by a robot
2022-10-04 09:52:56 -05:00
Jean-François Morin
616fe9fb7d Fixed start-handle-server.bat (Windows version) 2022-10-04 10:42:40 -04:00
Mark H. Wood
9c8840f4ce Remove redundant code: 'dspace classpath' already does what we want. 2022-10-04 07:51:18 -04:00
Tim Donohue
dd3a4220ba Merge pull request #8505 from DSpace/dependabot/maven/org.eclipse.jetty.http2-http2-server-9.4.48.v20220622
Bump http2-server from 9.4.44.v20210927 to 9.4.48.v20220622
2022-10-03 16:22:10 -05:00
Mark H. Wood
61f6bd1622 Remove duplication by depending on 'dspace classpath'. 2022-10-03 16:53:01 -04:00
Mark H. Wood
60d41b86f2 Shorten the argument to -classpath by making the JRE enumerate library JARs.
Also fix some incorrect comments and remove insignificant differences
between 'start-handle-server' and 'dspace'.
2022-10-03 16:36:35 -04:00
Mark H. Wood
b8908e533b Ask for (aliased) strategy by name. 2022-10-03 15:58:49 -04:00
Tim Donohue
09d7d12ba1 Fix minor dependency convergence issues 2022-10-03 14:22:21 -05:00
dependabot[bot]
2af9060ceb Bump http2-server from 9.4.44.v20210927 to 9.4.48.v20220622
Bumps http2-server from 9.4.44.v20210927 to 9.4.48.v20220622.

---
updated-dependencies:
- dependency-name: org.eclipse.jetty.http2:http2-server
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-10-03 19:08:31 +00:00
Tim Donohue
e396d318bf Merge pull request #8498 from tdonohue/fix_jetty_issues
Fix Jetty dependency issues in DSpace POMs & broken "start-handle-server"
2022-10-03 14:08:03 -05:00
Mykhaylo
b5aacdf967 [CST-6761] restored deleted accidentally properties 2022-10-03 18:04:58 +02:00
Luca Giamminonni
9bc01e8f05 [DURACOM-92] Fixed S3BitStoreServiceTest tests 2022-10-03 12:05:12 +02:00
Mykhaylo
0063b266d5 Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-10-03 09:37:46 +02:00
Luca Giamminonni
b13dff9e65 Merge remote-tracking branch '4science-bitbucket/main' into DURACOM-92 2022-10-03 09:20:00 +02:00
Andrea Bollini
66c452bcf9 CST-6950 fix report email 2022-10-03 09:17:09 +02:00
Andrea Bollini
75840c70c6 CST-6950 fix checker report query 2022-10-03 09:16:58 +02:00
Andrea Bollini
70b1ee19f3 CST-6950 fix checksum check 2022-10-03 09:16:46 +02:00
Andrea Bollini
5210aedbf3 CST-6950 fix checksum check and history 2022-10-03 09:16:24 +02:00
Tim Donohue
c318704ccf Merge pull request #8318 from 4Science/CST-5699
Add scripts and ITs for SAF (Simple Archive Format) import and export functionalities
2022-09-30 14:07:51 -05:00
Tim Donohue
ea930f9bf4 Merge pull request #8060 from atmire/shared-feature-s3-download
Change S3Bitstore to use TransferManager to allow larger then 5gb files
2022-09-30 09:43:19 -05:00
Vincenzo Mecca
3d538cb185 [#8357][DURACOM-70] Fixed url parsing for listhandles 2022-09-30 16:16:39 +02:00
Luca Giamminonni
d7d2723d65 [DURACOM-92] Use TransferManager to download files from S3 2022-09-30 16:08:36 +02:00
Andrea Bollini
b05d19ed6c Always use md5 checksum for data integrity check. Send it to S3 to exclude corruption during upload 2022-09-30 16:02:42 +02:00
Yury Bondarenko
980fd0f8ad Fix last expected MDF in findAllPaginationTest 2022-09-30 10:26:05 +02:00
Tim Donohue
41bf4e9956 Fix Jetty dependencies issues by forcing a specific version to be used, instead of via exclusions 2022-09-29 15:58:33 -05:00
Nicolas Boulay
d246fc4a14 Make it possible to allow a silent refusal 2022-09-29 15:16:50 -04:00
Nicolas Boulay
e26f583992 Send email even if copy request is refused 2022-09-29 15:16:50 -04:00
Mykhaylo
965afa0393 [CST-6761] fix version checking 2022-09-29 18:47:17 +02:00
Jens Vannerum
3f7ceab235 94474: Update the s3 tests to use the new TransferManager method 2022-09-29 17:46:41 +02:00
Mykhaylo
6227adc67b Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-29 17:08:06 +02:00
Mykhaylo
b0fb918796 [CST-6761] fix failed tests 2022-09-29 17:01:44 +02:00
Tim Donohue
1a4e7a82e6 Merge pull request #8486 from 4Science/CST-6751
Update Google Analytics to version 4
2022-09-29 09:47:42 -05:00
Mykhaylo
fdd4bc7226 Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-29 15:17:27 +02:00
Mykhaylo
c18f5cb7ea [CST-6761] Implemented community feedbacks 2022-09-29 15:14:51 +02:00
Jens Vannerum
0c533c5d1a 94474: Issues after merge 2022-09-29 10:44:56 +02:00
Jens Vannerum
dc6707bc4c Merge branch 'main' into shared-feature-s3-download 2022-09-29 10:41:08 +02:00
Francesco Pio Scognamiglio
a9e23112a3 [CST-5699] clean imports dir; use unique location during import via CLI 2022-09-29 10:29:32 +02:00
Tim Donohue
87cbca439b Merge pull request #8492 from 4Science/CST-6938
Fixed error handling for invalid password during eperson creation
2022-09-28 16:43:47 -05:00
Mykhaylo
f690ac5f43 [CST-6761] fix captcha failed test & added missing java docs 2022-09-28 19:38:07 +02:00
Mykhaylo
0ab2095c3d Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-28 18:22:31 +02:00
Mykhaylo
e84f284b87 [CST-6761] added IT for captcha 2022-09-28 18:19:14 +02:00
Mykhaylo
d019b1fd6d [CST-6761] refactored captcha feature 2022-09-28 18:16:56 +02:00
Tim Donohue
60ef084177 Merge pull request #8488 from atmire/issue-8479-Regular_search_can_contain_private_withdrawn_items
Issue 8479 regular search can contain private withdrawn items
2022-09-28 10:43:29 -05:00
Tim Donohue
ce7a0d40aa Merge pull request #8356 from 4Science/main-duracom-69
Improvement for the S3 support - IAM Role and support for legacy folder structure
2022-09-28 10:00:34 -05:00
Luca Giamminonni
6b385d14e5 [CST-6938] Fixed EPersonRestRepositoryIT tests 2022-09-28 11:50:33 +02:00
Jens Vannerum
3af51f5c6f Merge branch 'main' into shared-feature-s3-download
# Conflicts:
#	dspace-api/src/main/java/org/dspace/storage/bitstore/S3BitStoreService.java
2022-09-28 10:18:20 +02:00
Tim Donohue
41225650ec Merge pull request #8392 from mspalti/iiif-bundle
TOC exclusion bundle(s)
2022-09-27 16:05:10 -05:00
Tim Donohue
18f3ae1202 Merge pull request #8477 from 4Science/CST-6152
Ask current password to user when setting a new password
2022-09-27 13:08:13 -05:00
Tim Donohue
9c701265c5 Merge pull request #8398 from mspalti/uncache-bitstreams
Uncaching bitstreams to improve performance of iiif-canvas-dimensions
2022-09-27 12:29:24 -05:00
Vincenzo Mecca
b89c54e9f5 [#8356][DURACOM-69] Removed wrong secondary store option 2022-09-27 18:07:40 +02:00
Luca Giamminonni
a41b9bea82 [CST-6751] Improved dspace.cfg 2022-09-27 16:38:47 +02:00
Luca Giamminonni
591e361caf [CST-6938] Removed old password verification on eperson creation 2022-09-27 15:43:02 +02:00
Francesco Pio Scognamiglio
5ddc5c1360 [CST-5699] change test option to validate 2022-09-27 15:26:47 +02:00
Francesco Pio Scognamiglio
1b4f1cb49c [CST-5699] fix duplicate separator on working directories 2022-09-27 15:04:49 +02:00
Samuel Cambien
da6d55cfd5 issue #8479 Regular search can contain private & withdrawn items - additional configurations 2022-09-27 14:08:35 +02:00
Vincenzo Mecca
1600cdca28 [#8356][DURACOM-69] Improved Configuration for S3Store
feat:
	- New Properties to configure primary store;
	- New status for stores that indicates their initialization;
	- New enabled status for stores for disabling them;
	- New secondary index, used as backup for temporary configs.
2022-09-27 13:34:39 +02:00
Francesco Pio Scognamiglio
430a0f0eb3 [CST-5699] minor fix on zip export from CLI; add missing ITs to check if the exported zip exists 2022-09-27 13:17:49 +02:00
Francesco Pio Scognamiglio
81fc5d9910 [CST-5699] use work dirs instead of temp one 2022-09-27 09:43:36 +02:00
Vincenzo Mecca
101b9e833d [#8357][DURACOM-70] Completed behavior Remote-Handle-Resolver
fix:
	- Removed duplicated routes;
	- Renamed from `hdlResolver` to `hdlresolver`.

feat:
	- New routes'behavior
		- listhandles: lists all handle with a target prefix;
		- listprefixes: lists all prefixes mapped in configuration.
	- New ITs for the updated routes.
2022-09-26 16:29:17 +02:00
Davide Negretti
6a57149b80 Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-26 15:47:01 +02:00
Davide Negretti
7bdb1dc88a [CST-6761] Missing exposed properties 2022-09-26 14:53:33 +02:00
Davide Negretti
b299551717 [CST-6761] Missing exposed properties 2022-09-26 14:53:13 +02:00
Francesco Pio Scognamiglio
d04e75abde [CST-5699] delete temp dirs after SAF import and export 2022-09-24 10:48:45 +02:00
Francesco Pio Scognamiglio
ebe21f59db [CST-5699] fix export of a collection with at least two items on SAF export 2022-09-23 19:39:30 +02:00
Tim Donohue
e9e6fbd216 Merge pull request #8481 from atmire/w2p-94103_Enable-MetadataExportSearchIT_search-core-missing-bug-in-CI
Enable and fix `MetadataExportSearchIT`
2022-09-23 10:27:16 -05:00
Francesco Pio Scognamiglio
e355f49035 [CST-5699] delete temp files when added to process; use handler for logging 2022-09-23 13:58:40 +02:00
Luca Giamminonni
9d6ab36a3c Merge remote-tracking branch '4science-bitbucket/main' into CST-6152 2022-09-23 12:29:59 +02:00
Mykhaylo
65c0115833 Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-23 10:21:51 +02:00
Tim Donohue
2b4c10b533 Merge pull request #8480 from 4Science/CST-6265
Curation task results are not included in the output file or process output
2022-09-22 16:21:56 -05:00
Francesco Pio Scognamiglio
eb230b10e7 [CST-5699] fix SAF import and export functionality; add ITs for SAF via CLI 2022-09-22 18:34:25 +02:00
Luca Giamminonni
c3a99f6f62 Merge remote-tracking branch '4science-bitbucket/main' into CST-6751 2022-09-22 17:32:34 +02:00
Luca Giamminonni
1e24b50b0b [CST-6751] Improved GoogleAnalyticsClient, dspace.cfg and added tests 2022-09-22 17:31:48 +02:00
Tim Donohue
bf0155f6ce Merge pull request #8404 from 4Science/CST-6108-ValidatePassword
Make password minimum requirements stronger
2022-09-22 08:47:58 -05:00
Michael Spalti
ae1fb9c246 Fixed integration test. 2022-09-21 21:59:08 -07:00
Michael Spalti
574790a087 Minor refactor after merging remote. 2022-09-21 20:27:20 -07:00
Michael Spalti
6a2a0aaf61 Merge branch 'uncache-bitstreams' of https://github.com/mspalti/DSpace into uncache-bitstreams 2022-09-21 20:22:15 -07:00
Michael Spalti
62ef19c548 Merge branch 'main' into uncache-bitstreams 2022-09-21 20:21:03 -07:00
Michael Spalti
4c8a671709 Minor refactor. 2022-09-21 20:17:56 -07:00
Michael Spalti
3e02f855b3 Removed unused constant 2022-09-21 15:05:36 -07:00
Tim Donohue
7b07013e07 Merge pull request #8465 from 4Science/DURACOM-86
DURACOM-86 Add html support to opensearch, fix misconfiguration
2022-09-21 16:32:40 -05:00
Michael Spalti
1e643d0610 Merge branch 'main' into iiif-bundle 2022-09-21 14:00:51 -07:00
Mark H. Wood
4995345387 Merge branch '8304' of github.com:mwoodiupui/DSpace into 8304 2022-09-21 13:04:28 -04:00
Mark H. Wood
24c1d44e94 Autowire by name so alias works. Uncomment all strategies, mark for autowiring and lazy loading.
Also tidy up XML internal documentation.
2022-09-21 13:00:41 -04:00
Tim Donohue
5a27ab74af Merge pull request #8417 from 4Science/DS-4415-main
port #2634 CitationPage curation task mess the bitstream policies to the main branch
2022-09-21 11:19:34 -05:00
Tim Donohue
3ee8470970 Merge pull request #8476 from 4Science/CST-6756
Provide a script to delete old processes
2022-09-21 10:20:40 -05:00
Luca Giamminonni
630fde0f51 [CST-6152] Fixed integration tests 2022-09-21 14:57:32 +02:00
Luca Giamminonni
9938518c66 [DSC-93] Improved dspace.cfg 2022-09-21 11:57:03 +02:00
Andrea Bollini
e28eca8745 Move the citationpage curation task in the right package, add example configuration 2022-09-21 00:01:49 +02:00
Andrea Bollini
228cc31368 Fix checkstyle 2022-09-20 23:54:40 +02:00
Andrea Bollini
46df923c26 Merge branch 'main' of https://github.com/DSpace/DSpace into DS-4415-main 2022-09-20 23:49:09 +02:00
Andrea Bollini
8ccb5918fe DURACOM-86 fix configuration lookup, clenaup configuration and tests 2022-09-20 23:43:37 +02:00
Andrea Bollini
b20caee285 Merge branch 'main' of https://github.com/DSpace/DSpace into DURACOM-86 2022-09-20 22:35:12 +02:00
Mark H. Wood
b4b67c4322 Clean up an unused logger. 2022-09-20 15:40:18 -04:00
Francesco Pio Scognamiglio
c20cab3f6e [CST-5699] minor refactoring 2022-09-20 16:26:43 +02:00
Luca Giamminonni
f2eb9c55b4 [CST-6152] Renamed challenge to currentPassword 2022-09-20 15:29:20 +02:00
Jens Vannerum
74b56d6fe1 94474: Transfer manger should be class wide 2022-09-20 15:19:19 +02:00
Francesco Pio Scognamiglio
b1c9c60cd6 Merge branch 'CST-5699' of github.com:4Science/DSpace into CST-5699 2022-09-20 14:35:47 +02:00
Francesco Pio Scognamiglio
df44b978e0 [CST-5699] refactoring on SAF import and export functionality 2022-09-20 13:50:12 +02:00
Mykhaylo
07934d09f1 minor fix 2022-09-20 11:44:29 +02:00
Francesco Pio Scognamiglio
7c6bf08905 Merge branch 'main' into CST-5699 2022-09-20 09:16:27 +02:00
Francesco Pio Scognamiglio
f606cea1bd Merge branch 'main' into CST-5699 2022-09-20 08:24:15 +02:00
Vincenzo Mecca
97e9379de2 [#8357][DURACOM-70] Added the new property in test configuration 2022-09-19 10:46:06 +02:00
Vincenzo Mecca
ff48afeea4 [#8357][DURACOM-70] Property to disable HdlResolver 2022-09-19 09:42:53 +02:00
Mark H. Wood
b1423de7c1 Noticed in testing: okay not to have a current user. 2022-09-16 14:47:54 -04:00
Mark H. Wood
38946f8de5 Test that unauthenticated session can (dis)approve a request. 2022-09-16 14:47:16 -04:00
Mark H. Wood
fa5aa9c993 Don't test for authNZ failures that can no longer occur. 2022-09-16 11:53:11 -04:00
Mark H. Wood
692fefcbac Don't require authentication to approve/deny a copy request. Possession of the token is sufficient. 2022-09-16 11:08:15 -04:00
Mark H. Wood
a4cb9bd129 Remove more unused code. Caused by removing isAuthorized(). 2022-09-16 10:58:27 -04:00
Samuel Cambien
46bf27748d Merge remote-tracking branch 'DSpace/main' into issue-8479-Regular_search_can_contain_private_withdrawn_items
# Conflicts:
#	dspace/config/spring/api/discovery.xml
2022-09-16 13:42:39 +02:00
Samuel Cambien
7a89c5817c Merge tag 'dspace-7.2' into w2p-94445-Regular_search_can_contain_private_withdrawn_items-7_2
[maven-release-plugin] copy for tag dspace-7.2
2022-09-16 13:39:21 +02:00
Samuel Cambien
1800bf1e7c issue #8479 Regular search can contain private & withdrawn items 2022-09-16 13:27:45 +02:00
Mykhaylo
a31bb4bf61 [CST-6108] implemented community feedbacks 2022-09-16 12:19:06 +02:00
Mykhaylo
2fa27afb6a Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-16 10:12:08 +02:00
Mykhaylo
a0e633f1d4 Merge branch 'main' into CST-6108-ValidatePassword 2022-09-16 10:11:24 +02:00
Mark H. Wood
f6ab8ba1fb Remove unused 'isAuthorized' methods.
This method was always questionable.  The point of Request a Copy is
to bypass DSpace's authorizations.
2022-09-15 14:18:01 -04:00
Mark H. Wood
d9caeed387 Merge branch 'main' into 8304 2022-09-15 12:53:22 -04:00
Luca Giamminonni
a111152ea0 [DSC-93] Added help to ProcessCleaner 2022-09-15 15:48:04 +02:00
Andrea Bollini
3b23ff95db Merge pull request #2115 from mwoodiupui/DS-3951
[DS-3951] Send Request Copy email to multiple recipients, and some new recipient strategies
2022-09-15 15:38:17 +02:00
Vincenzo Mecca
82f6f6f5b7 [DURACOM-70][#8357] Fixed unsatisfied dependency 2022-09-15 13:13:16 +02:00
Luca Giamminonni
ca8a85489a [CST-6751] Minor fixes 2022-09-15 12:56:54 +02:00
Luca Giamminonni
3a1d298156 [CST-6751] Added api-secret to dspace.cfg 2022-09-14 17:56:39 +02:00
Tim Donohue
6b1fae1464 Merge pull request #8461 from philipprumpf/issue-7969
SplitMetadataContributor.java: new class to split metadata values based on a regex
2022-09-14 10:55:21 -05:00
Luca Giamminonni
e06513a512 [CST-6751] Added ip anonymization 2022-09-14 17:45:24 +02:00
Luca Giamminonni
6805f33468 [CST-6751] Added value for google.analytics.crontab on dspace.cfg 2022-09-14 16:54:18 +02:00
jensroets
4644655601 94299 Multiple Bitstream deletion endpoint: rename items to parents 2022-09-14 15:49:03 +02:00
Luca Giamminonni
5130642415 [CST-6751] Renamed GoogleAnalyticsClientRequestBuilder method 2022-09-14 15:30:17 +02:00
Luca Giamminonni
53fd235841 [CST-6751] Added tests for UniversalAnalyticsClientRequestBuilder and GoogleAnalyticsClientRequestBuilder 2022-09-14 13:27:27 +02:00
Mykhaylo
75d9fb76b5 [CST-6108] refactored password validation exception 2022-09-14 13:15:21 +02:00
Mykhaylo
71599352e6 Merge branch 'main' into CST-6108-ValidatePassword 2022-09-14 11:52:07 +02:00
Philipp Rumpf
c2931bc440 Add integration tests for multiple BibTeX authors 2022-09-14 07:43:53 +00:00
Philipp Rumpf
c2771cbb7e Configure BibTeX authors to be split on "\sand\s" 2022-09-14 07:43:53 +00:00
Philipp Rumpf
e5049b01ef SplitMetadataContributor.java: new class to split metadata values based on a regex rather than a single character
Fixes #7969

Needed for BibTeX's convention of separating author names by " and ".
2022-09-14 07:43:53 +00:00
Luca Giamminonni
23c3a6d7f3 [CST-6751] Refactoring of GoogleAnalyticsClientImpl to send many request 2022-09-13 18:33:30 +02:00
Luca Giamminonni
6e8e85c2d6 [CST-6751] Added integration tests for GoogleAsyncEventListener 2022-09-13 17:46:31 +02:00
Tim Donohue
249fe2f1f7 Merge pull request #8281 from 4Science/CST-5340-OpenAIREFundingDataProvider
Make OpenAIRE Funding connector mapping configurable
2022-09-13 09:23:02 -05:00
Luca Giamminonni
a42dc30a9b [CST-6751] Minor improvements 2022-09-13 15:30:05 +02:00
Luca Giamminonni
b50fa3aaed [CST-6751] Refactoring of GoogleAsyncEventListener 2022-09-12 18:27:43 +02:00
Yury Bondarenko
73ede2f4c1 Merge remote-tracking branch 'origin/main' into w2p-94103_Enable-MetadataExportSearchIT_search-core-missing-bug-in-CI 2022-09-09 09:49:56 +02:00
Vincenzo Mecca
87118257ed [CST-6265] JavaDocs 2022-09-08 18:50:34 +02:00
Vincenzo Mecca
33e6339900 [CST-6265] Fixed message formatting
fix:
	- message formatting for logInfo was done twice
feat:
	- message inside logWarn was not formatted when using handler
2022-09-08 18:45:11 +02:00
jensroets
51d8874a8f 94299 Multiple Bitstream deletion endpoint 2022-09-08 16:50:02 +02:00
Mykhaylo
418afe79b7 fix checkstyle & added x-recaptcha-token into headers 2022-09-08 11:52:37 +02:00
Luca Giamminonni
43066240e8 Merge remote-tracking branch '4science-bitbucket/main' into CST-5340-OpenAIREFundingDataProvider 2022-09-08 10:25:00 +02:00
Luca Giamminonni
04deb6d42c [CST-5340] Removed not used metadata fields in external-openaire.xml 2022-09-08 10:23:53 +02:00
Davide Negretti
a727c96d89 Merge remote-tracking branch 'gh4science/CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-07 19:25:59 +02:00
Davide Negretti
6c48a22f40 [CST-6761] Allow header x-recaptcha-token 2022-09-07 19:25:45 +02:00
Tim Donohue
fd4e6116a2 Merge pull request #8473 from 4Science/CST-6739-AIPexports
AIP exports could produce invalid mets.xml file
2022-09-07 12:06:45 -05:00
Mykhaylo
885ff20666 Merge branch 'main' into CST-6761-NewUsersMightBeRegisteredInMassiveWayByRobot 2022-09-07 09:55:17 +02:00
Mykhaylo
0a10e48eba [CST-6761] added missing license 2022-09-07 09:54:56 +02:00
Michael Spalti
dc55f12e64 Moved unchache 2022-09-06 09:39:34 -07:00
Michael Spalti
0481546cc7 Removed unused import. 2022-09-06 09:39:34 -07:00
Michael Spalti
1cf7352166 Using batch edit mode. 2022-09-06 09:39:34 -07:00
Michael Spalti
8a36bdd982 Uncache the item. 2022-09-06 09:39:34 -07:00
Michael Spalti
76314035f9 Uncaching bitstreams to improve performance. 2022-09-06 09:39:34 -07:00
Mykhaylo
a443004547 [CST-6761] added new property google.recaptcha.mode to rest.cfg 2022-09-06 16:38:05 +02:00
Mykhaylo
25438e42fb [CST-6761] added new property google.recaptcha.mode 2022-09-06 16:36:38 +02:00
Mykhaylo
6f8b3e1381 added captcha services 2022-09-06 16:35:03 +02:00
Tim Donohue
5b4a3da0bb Merge pull request #8447 from tdonohue/fix_8351
Update to oclc-harvester2 v1.0.0 and remove Xalan
2022-09-06 09:17:13 -05:00
Mykhaylo
eb7b78d59c [CST-6761] added support for captcha version (v2 and v3). - added new property. 2022-09-06 16:03:18 +02:00
Mykhaylo
1bfec3ab1d [CST-6108] configured param to use angular side 2022-09-05 16:22:04 +02:00
Mykhaylo
c608fd89fb Merge branch 'main' into CST-6108-ValidatePassword 2022-09-05 16:00:39 +02:00
Mykhaylo
9af70628a0 [CST-6108] update tests 2022-09-05 15:58:55 +02:00
eskander
3884007521 [CST-6265] Curation task results are not included in the output file or process output 2022-09-02 15:14:00 +02:00
Tim Donohue
c7692d5517 Merge pull request #8471 from mwoodiupui/upload-autowire
Autowire ConfigurationService in UploadConfiguration instead of requiring explicit configuration
2022-09-01 16:12:17 -05:00
Luca Giamminonni
e96107a6b9 [DSC-93] Added tests for ProcessCleaner 2022-09-01 16:54:44 +02:00
Luca Giamminonni
28bb6f93e0 [CST-6756] Implemented script to delete old processes 2022-09-01 16:24:55 +02:00
Tim Donohue
81a13eed29 Merge pull request #8446 from atmire/w2p-93108_Bitstream-name-missing-on-statistics-page_7.2
W2p 93108 bitstream name missing on statistics page 7.2
2022-08-31 16:37:03 -05:00
Vincenzo Mecca
b9eb369275 [DSpace#8356][DURACOM-69] Change Requests part. 3.1 2022-08-31 16:12:30 +02:00
Vincenzo Mecca
a78d2fa0ab [DSpace#8356][DURACOM-69] Change Requests part. 3 2022-08-31 13:24:47 +02:00
Mark H. Wood
07a464902c [DS-3951] Improve configuration documentation. 2022-08-30 09:29:24 -04:00
Yura Bondarenko
611f610f15 94103: Explicitly clear cached SearchService instance between ITs 2022-08-29 14:16:42 +02:00
Mykhaylo
00f607459d [CST-6739] removed unused imports 2022-08-29 10:16:56 +02:00
Andrea Bollini
5d1f3b6ea1 CST-6739 AIP exports could produce invalid mets.xml file 2022-08-29 10:09:33 +02:00
kshepherd
5254ecf9ff Merge pull request #1857 from mwoodiupui/DS-2670
[DS-2670] Restrospectively create DOIs for all items in archive
2022-08-28 10:01:09 +12:00
Mark H. Wood
91acf0baad [DS-2670] Fail if an incompatible IdentifierProvider is configured.
Added basic integration test to prove the above.
2022-08-26 18:04:34 -04:00
Mark H. Wood
e67e371577 Merge branch 'main' into DS-2670 2022-08-26 14:40:31 -04:00
Mark H. Wood
e4a4737aee [DS-3951] Remove unused import to satisfy Checkstyle. 2022-08-26 12:52:05 -04:00
Mark H. Wood
8f3289e8cd Merge branch 'main' into DS-3951 2022-08-26 11:15:24 -04:00
Mark H. Wood
4f5203b142 Explicit property must be removed from test configuration too.
I changed over from field injection to constructor injection while
diagnosing the failure caused by this problem, and decided to keep
it.  It's a little more verbose, but safer and clearer in the doco.
Really, the *required* properties should also be constructor
parameters.

Also cleaned up some trailing whitespace in the configuration documents.
2022-08-25 16:33:26 -04:00
Mykhaylo
b8136aed8c [CST-6108] fix faled IT 2022-08-25 19:24:12 +02:00
Mykhaylo
906d78b16e [CST-6108] fix failed unit tests 2022-08-25 18:23:50 +02:00
Mykhaylo
3060819a14 Merge branch 'main' into CST-6108-ValidatePassword 2022-08-25 17:11:24 +02:00
Vincenzo Mecca
03ac217a3a [DURACOM-70][DSpace#8357] Applied Second Change Requests 2022-08-25 12:05:57 +02:00
Marie Verdonck
ab3938b34f Issue #8355: enable MetadataExportSearchIT 2022-08-25 12:05:41 +02:00
Vincenzo Mecca
faa1f6284e [DSpace#8356][DURACOM-69] Change Requests part. 2 2022-08-25 10:04:09 +02:00
Tim Donohue
897d9b7d98 Merge pull request #8458 from mwoodiupui/8437
Solr search core initialization is fragile
2022-08-24 12:15:45 -05:00
Mark H. Wood
5e8a4ed397 Document this interface. 2022-08-24 12:32:42 -04:00
Tim Donohue
a40a5a6217 Merge pull request #8456 from philipprumpf/issue-8455
Expose BibTeX document type as PlainMetadataKeyValueItem during import
2022-08-24 11:30:41 -05:00
Mark H. Wood
747a2aeec9 Autowire constant ConfigurationService field instead of making it a parameter. 2022-08-24 12:30:40 -04:00
Tim Donohue
ed96cdcfe2 Merge pull request #8454 from philipprumpf/issue-8453
use org.jbibtex.LaTeXParser to handle BibTeX diacritics
2022-08-24 11:04:13 -05:00
Philipp Rumpf
4c26d2f77c Add integration test for BibTeX type import 2022-08-22 12:57:53 +00:00
Philipp Rumpf
cd65b4483f Configure BibTeX import to provide dc.type (without mapping it) 2022-08-22 12:10:32 +00:00
Philipp Rumpf
2c11d68875 Add integration test for BibTeX/LaTeX diacritics. 2022-08-22 11:11:46 +00:00
Kim Shepherd
13eaaf4ab8 Move JDWP configuration from JAVA_OPTS to CATALINA_OPTS 2022-08-20 10:18:17 +12:00
corrado lombardi
04c8e0d7c4 Merge remote-tracking branch 'bb-cris/CST-6151' into CST-6152 2022-08-19 17:32:04 +02:00
Tim Donohue
0ef8879c15 Merge pull request #8399 from ammanabrolua/main
[DS-3306] bin/dspace create-administrator needs a --help option #6661 #8367
2022-08-18 10:59:32 -05:00
ammanabrolua
15fae257f6 Merge branch 'DSpace:main' into main 2022-08-18 14:10:07 +02:00
Andrea Bollini
ad3ef6046b DURACOM-86 fix checkstyle 2022-08-18 13:11:35 +02:00
Andrea Bollini
d99913cb79 DURACOM-86 Add html support to opensearch, fix misconfiguration 2022-08-18 09:39:02 +02:00
Tim Donohue
62df120b75 Merge pull request #8464 from tdonohue/fix_gendered_lang
Remove/replace gendered language in code comments
2022-08-17 15:00:39 -05:00
Tim Donohue
8aacf54b87 More text replacement 2022-08-17 14:10:25 -05:00
Tim Donohue
9e098f229f Additional replacements of gendered text 2022-08-17 14:03:45 -05:00
Tim Donohue
9a3bd8a188 Fix more gendered language in code comments 2022-08-17 10:59:07 -05:00
Tim Donohue
dfac17e890 Fix descriptions of delegated admin settings in dspace.cfg 2022-08-17 10:41:51 -05:00
Tim Donohue
e6e283a1f2 Replace gendered language in code comments 2022-08-17 10:41:29 -05:00
Vincenzo Mecca
92f43aced3 [#8356][DURACOM-69] Change Requests 2022-08-16 11:37:28 +02:00
Mark H. Wood
ed04558402 Throw a RuntimeException if the Solr server cannot be reached. #8437 2022-08-12 16:17:36 -04:00
Mark H. Wood
80f65ad4ff [DS-2760] Take up a review suggestion. Also replace slf4j with log4j2. 2022-08-12 15:25:30 -04:00
Mark H. Wood
237ffe4af3 [DS-3951] More review comments. 2022-08-12 14:23:45 -04:00
Mark H. Wood
27143d8e56 [DS-3951] Address review comments. 2022-08-12 13:32:10 -04:00
ammanabrolua
6f990a4697 get option values by default 2022-08-11 09:25:33 +02:00
ammanabrolua
f5f0744839 applying deMorgan's Rule 2022-08-11 09:16:42 +02:00
Johanna Staudinger
4d5976b67e Expose BibTeX document type as PlainMetadataKeyValueItem during import 2022-08-10 13:02:26 +00:00
Philipp Rumpf
76467c7cfc use org.jbibtex.LaTeXParser to handle BibTeX diacritics 2022-08-10 09:50:29 +00:00
ammanabrolua
9e0b20fdac Merge branch 'DSpace:main' into main 2022-08-09 20:55:56 +02:00
Tim Donohue
1215992c86 Merge pull request #8452 from philipprumpf/issue-8403
Update jbibtex library to version 1.0.20
2022-08-09 13:53:03 -05:00
Tim Donohue
a74604647b Merge pull request #8435 from toniprieto/strip-diacritics-browse-item
Fix browse by title filter doesn't work with diacritics
2022-08-09 13:17:18 -05:00
Philipp Rumpf
b61aa04f48 Update jbibtex library to version 1.0.20
Fixes #8403
2022-08-09 13:45:10 +00:00
Toni Prieto
9556423e6c Prevent possible NPEs 2022-08-09 14:00:29 +02:00
Mykhaylo
5b6f19c089 Merge branch 'main' into CST-6108-ValidatePassword 2022-08-09 13:10:27 +02:00
Mykhaylo
3eac915dbb [CST-6108] Implemented community feedback 2022-08-09 13:08:14 +02:00
Tim Donohue
f0bcc4e5da Merge pull request #8424 from 4Science/CST-6448_auth_pagination
Pagination support for multiple objects and authorization features endpoint
2022-08-08 15:51:04 -05:00
Tim Donohue
75f7e8463f Merge pull request #8448 from DSpace/dependabot/maven/org.postgresql-postgresql-42.4.1
Bump postgresql from 42.3.3 to 42.4.1
2022-08-08 10:54:26 -05:00
Tim Donohue
1d3506a2c7 Merge pull request #8394 from DSpace/dependabot/maven/org.apache.commons-commons-configuration2-2.8.0
Bump commons-configuration2 from 2.7 to 2.8.0
2022-08-08 10:25:23 -05:00
dependabot[bot]
16b9874097 Bump postgresql from 42.3.3 to 42.4.1
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.3.3 to 42.4.1.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.3.3...REL42.4.1)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-08-06 05:57:35 +00:00
Tim Donohue
ff3c8b6b0b Fix dependency convergence issues via minor upgrades to opencsv and commons-text 2022-08-05 16:52:06 -05:00
Tim Donohue
9afd6ce1da Fix checkstyle violations by correcting order of imports 2022-08-05 16:47:31 -05:00
dependabot[bot]
ca046e5f98 Bump commons-configuration2 from 2.7 to 2.8.0
Bumps commons-configuration2 from 2.7 to 2.8.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-configuration2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-08-05 21:43:46 +00:00
Tim Donohue
0679fb9703 Update to oclc-harvester2 v1.0.0 and remove xalan 2022-08-05 16:20:25 -05:00
Tim Donohue
91131d9966 Merge pull request #8410 from atmire/w2p-92917_Fix-trusted-IP-ranges_Contribute_PR
proxies.trusted.ipranges fixes
2022-08-05 08:16:33 -05:00
Ben Bosman
227597417b simplify to avoid code duplication 2022-08-04 18:13:14 +02:00
ammanabrolua
16b2353b6f Updated code after first review 2022-08-04 15:31:53 +02:00
Tim Donohue
43b441c4c1 Merge pull request #8407 from DSpace/dependabot/maven/dspace-api/com.amazonaws-aws-java-sdk-s3-1.12.261
Bump aws-java-sdk-s3 from 1.12.116 to 1.12.261 in /dspace-api
2022-08-03 16:38:12 -05:00
Luca Giamminonni
3316aefde4 [CST-6152] Minor changes 2022-08-03 17:28:24 +02:00
Luca Giamminonni
bfb0736ab7 [CST-6152] Password add operation refactoring to include challenge in the value 2022-08-03 17:09:09 +02:00
Luca Giamminonni
edfa9145e7 Merge remote-tracking branch '4science-bitbucket/main' into CST-6152 2022-08-03 16:12:17 +02:00
Luca Giamminonni
505544232d [CST-6108] Removed not used javadoc parameter 2022-08-03 16:06:37 +02:00
Luca Giamminonni
e3528dc098 [CST-6108] Refactoring of ValidatePasswordService 2022-08-03 15:18:40 +02:00
Tim Donohue
68d7508c0f Merge pull request #8400 from atmire/w2p-84011_Fix-originalSubmitterAssignAction_7.x
Fix claimed user on `AssignOriginalSubmitterAction`
2022-08-02 12:03:44 -05:00
Tim Donohue
10afbe7100 Merge pull request #8422 from 4Science/main-8419
Workflow's steps doesn't preserve order
2022-08-02 11:31:07 -05:00
Tim Donohue
2f34e93e0d Merge pull request #8321 from mwoodiupui/8320
Address many long-standing LGTM complaints
2022-08-02 11:29:05 -05:00
Mark H. Wood
89acc8b13b Address requested changes. 2022-08-02 10:04:40 -04:00
Mark H. Wood
77d344a8c7 Merge branch 'main' into 8320 2022-08-02 09:48:58 -04:00
Tim Donohue
cc45de7da1 Merge pull request #2468 from mwoodiupui/DS-4289
[DS-4289] SAF exporter does not write the 'collections' file
2022-08-01 13:43:40 -05:00
Mark H. Wood
8613b278e5 Merge pull request #8421 from kshepherd/fix_abstractcondition_services
Ensure Local Filter services are autowired
2022-07-29 10:45:10 -04:00
Kim Shepherd
b48fa9ea8c #8421 - Remove unused import 2022-07-29 12:00:39 +12:00
Kim Shepherd
73276839e1 #8421 - Set services for constructed (unwired) conditions in unit tests 2022-07-29 11:29:48 +12:00
kshepherd
d1e7bd1b21 Merge pull request #8433 from dataquest-dev/maven-build-speed-up
maven build speed
2022-07-29 10:54:10 +12:00
Kim Shepherd
d10a153ad1 #8421 - Remove explicit service instantiation 2022-07-29 10:49:11 +12:00
Tim Donohue
4d4f129523 Merge pull request #2469 from mwoodiupui/DS-4300
[DS-4300] Optionally apply given Handles when importing community/collection structure
2022-07-28 10:02:05 -05:00
MajoBerger
b4f8e7d69d maven build speed 2022-07-28 07:26:45 +02:00
Tim Donohue
13e5809474 Merge pull request #8383 from 4Science/CST-6201
OAI Import errors when indexing without -c option
2022-07-27 14:37:43 -05:00
Vincenzo Mecca
18ae327996 [DURACOM-70] [#8357] Applied Change Requests
fix:
	- Removed typo;
	- Removed method inside `ItemBuilder`;
feat:
	- Added multiple routes to `HdlResolverRestController`:
	    * `/resolve/`;
	    * `/listhandles/`;
	    * `/listprefixes/`;
	- Added ITs for these new routes.
2022-07-26 18:47:39 +02:00
Toni Prieto
30b8dff95e Merge branch 'strip-diacritics-browse-item' of github.com:toniprieto/DSpace into strip-diacritics-browse-item 2022-07-26 14:05:39 +02:00
Toni Prieto
ca483e2435 Correct comments 2022-07-26 14:04:12 +02:00
Toni Prieto
7159563605 Add test for browsing by title with diacritics 2022-07-26 14:00:21 +02:00
Toni Prieto
77e42631e1 Ignore diacritics in browse by title 2022-07-26 12:10:52 +02:00
corrado lombardi
946ffa998d [CST-6448] checkstyle fix 2022-07-26 09:02:22 +02:00
corrado lombardi
d604ad888b [CST-6448] Pagination handling in /objects endpoint response 2022-07-25 19:09:25 +02:00
Vincenzo Mecca
949796b288 [DS-8419] JavaDoc on Matcher 2022-07-25 11:07:07 +02:00
Vincenzo Mecca
060727ba14 [DS-8419] WorkFlow steps preserve order
fix:
	- Replaced HashMap with LinkedHashMap, to preserve order.
feat:
	- New test to assert steps order;
	- New matcher for check step.
2022-07-25 11:06:56 +02:00
Kim Shepherd
e6620dc88f ensure item and collection services are autowired
(previously disabled due to some unit test conflicts?)
2022-07-25 15:51:30 +12:00
Michael Spalti
323867dd56 Removed unused import. 2022-07-22 14:03:49 -07:00
Michael Spalti
d11e3814d4 Using batch edit mode. 2022-07-22 12:16:07 -07:00
Andrea Bollini
ad7d7e2c83 port #2634 to the main 2022-07-21 18:05:41 +02:00
Michael Spalti
d392d93e29 Uncache the item. 2022-07-19 10:36:47 -07:00
dependabot[bot]
c0fa5ac403 Bump aws-java-sdk-s3 from 1.12.116 to 1.12.261 in /dspace-api
Bumps [aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.12.116 to 1.12.261.
- [Release notes](https://github.com/aws/aws-sdk-java/releases)
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.12.116...1.12.261)

---
updated-dependencies:
- dependency-name: com.amazonaws:aws-java-sdk-s3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-07-15 21:06:46 +00:00
Mark H. Wood
953f37d4b2 Test with a community with handle not specified. #2469 2022-07-15 11:12:42 -04:00
Mark H. Wood
f8594abf5f Add spot-check for a Collection handle. #2469 2022-07-15 10:38:20 -04:00
Yura Bondarenko
e2216dcc50 Merge tag 'dspace-7.2' into w2p-93108_Bitstream-name-missing-on-statistics-page_7.2
[maven-release-plugin] copy for tag dspace-7.2
2022-07-15 15:18:52 +02:00
Michael Spalti
44ae8c0464 Minor test modification. 2022-07-14 11:05:56 -07:00
Michael Spalti
d5c9c86b11 Updated config file. 2022-07-14 10:52:56 -07:00
Michael Spalti
f6635c6262 Adds new IIIF config paramenter that excludes bundles from TOC generation. 2022-07-14 10:36:29 -07:00
Michael Spalti
84375b0499 Omit "iiif" bundle from toc ranges. 2022-07-14 10:36:29 -07:00
Mark H. Wood
87144496b2 Remove commented-out code. #2469 2022-07-14 11:49:31 -04:00
Yura Bondarenko
3185578d72 93108: Cover usage report point labels in ITs 2022-07-14 15:26:32 +02:00
Yura Bondarenko
2a2214d4c5 93108: Fix id/label mismatch in Bitstream download usage report points 2022-07-14 14:10:13 +02:00
ammanabrolua
5145c5b64d Merge branch 'DSpace:main' into main 2022-07-14 13:10:50 +02:00
Mykhaylo
fd1eec0aad [CST-6108] updated documentation 2022-07-14 12:48:09 +02:00
ammanabrolua
41ac87d42f resolve LGTM alert 2022-07-14 11:52:17 +02:00
ammanabrolua
449dfe0eb0 fixed logic 2022-07-14 10:30:05 +02:00
Tim Donohue
31f706042f Merge pull request #8366 from atmire/w2p-92174_fix-issues-with-test-OpenUrlServiceImplTest-7.2
92174: Refactor OpenUrlServiceImplTest to avoid making http requests
2022-07-13 16:37:11 -05:00
Tim Donohue
59e8c66243 Merge pull request #8361 from atmire/w2p-92174_issue-8360_replace-new-operator-with-autowire
Replace new operator with autowire
2022-07-13 16:13:06 -05:00
Mark H. Wood
41e1d8506b Clean up more warnings. #8320 2022-07-13 16:49:18 -04:00
Mark H. Wood
e9313acd24 Clean up a bunch of warnings. #8320 2022-07-13 14:03:42 -04:00
Mark H. Wood
023fc6a29c Merge branch 'main' into 8320 2022-07-13 12:17:35 -04:00
Mark H. Wood
b0316b4f74 Clean up all recommendations, plus scads of missing Javascript semicolons. 2022-07-13 12:01:51 -04:00
Mykhaylo
9ef9a26ac2 [CST-6108] tests to Validate password robustness 2022-07-13 17:56:48 +02:00
Mykhaylo
5bd8b68200 [CST-6108] Implementation to validate password strength 2022-07-13 17:55:48 +02:00
ammanabrolua
b0a04ce1d0 removed comments and changed flag expression 2022-07-13 15:00:24 +02:00
ammanabrolua
84e6be5bb3 added --help option and fixed code to reflect review 2022-07-13 14:39:23 +02:00
Yura Bondarenko
188cecc0b4 84011: Fix AssignOriginalSubmitterAction claimed user 2022-07-13 13:24:28 +02:00
ammanabrolua
93912118fd added --help option 2022-07-12 20:56:30 +02:00
Yura Bondarenko
93a1ef4809 Merge remote-tracking branch 'upstream/main' into w2p-92917_Fix-trusted-IP-ranges_Contribute_PR 2022-07-12 09:40:09 +02:00
Michael Spalti
7953110c0b Uncaching bitstreams to improve performance. 2022-07-11 14:16:56 -07:00
Yura Bondarenko
01d5bf4f4a 92917: Support implicit ranges & update unit tests 2022-07-11 14:48:24 +02:00
Yura Bondarenko
36748cd27d 92917: Javadocs & minor fixes 2022-07-11 13:47:43 +02:00
Ben Bosman
f9d6091c2c Refactor IPTable 2022-07-11 11:59:23 +02:00
eskander
b5dfcab7ae [CST-6151] removed unused variable. 2022-07-04 15:28:59 +02:00
eskander
957f13f834 [CST-6151] can change password feature must return false if current user is logged in as another. 2022-07-04 15:27:22 +02:00
Tim Donohue
fb691719a3 Merge pull request #8391 from tdonohue/fix_8387
Enhance comments for dspace.server.url and dspace.ui.url to clarify usage
2022-07-01 14:04:05 -05:00
Tim Donohue
7ee727ee9d Enhance comments for dspace.server.url and dspace.ui.url 2022-07-01 12:14:10 -05:00
eskander
aafa2c7d25 [CST-6152] allow password change only if a challenge is resolved. 2022-07-01 14:04:23 +02:00
Vincenzo Mecca
904a643585 Merge remote-tracking branch 'origin/main' into main-duracom-69 2022-06-30 13:38:38 +02:00
Tim Donohue
f32d1ad0b0 Merge pull request #8382 from DSpace/Docker-README-Rewording
Clarify usage of Docker images
2022-06-28 09:47:30 -05:00
Tim Donohue
c1eb19e497 Update warning in other readme 2022-06-28 09:42:41 -05:00
emanuele
1fa7049b7d [CST-6201] fixed checkstyle violations 2022-06-28 16:42:26 +02:00
Tim Donohue
ecb853cea5 Clarify usage of Docker images 2022-06-28 09:39:25 -05:00
emanuele
d1019740db [CST-6201] implemented solr cursors to avoid IndexOutOfBoundsException 2022-06-28 16:19:18 +02:00
emanuele
115460b94d [CST-6201] added NPE checks in getItemsWithPossibleChangesBefore method 2022-06-28 09:14:18 +02:00
Vincenzo Mecca
3646716607 Merge remote-tracking branch 'bit-bucket/main' into main-duracom-70 2022-06-27 15:08:15 +02:00
Vincenzo Mecca
083ce8586f Merge remote-tracking branch 'bit-bucket/main' into main-duracom-70 2022-06-27 15:03:37 +02:00
Tim Donohue
c532d410a2 [maven-release-plugin] prepare for next development iteration 2022-06-24 12:11:54 -05:00
Tim Donohue
bbdff34806 [maven-release-plugin] prepare release dspace-7.3 2022-06-24 12:11:50 -05:00
Tim Donohue
9efff0bc0f Merge pull request #8374 from kshepherd/dspace7x_file_separator_fix
Use platform file separator in SimpleMapConverterTest instead of '/'
2022-06-24 09:47:30 -05:00
Tim Donohue
b9e4cdb390 Merge pull request #8373 from 4Science/orcid_queue_desc
Improved orcid queue consumer description
2022-06-24 09:44:21 -05:00
Luca Giamminonni
3148ff502b Improved orcid queue consumer description 2022-06-24 11:23:39 +02:00
Kim Shepherd
1ee4205703 Use platform file separator in SimpleMapConverterTest instead of '/' 2022-06-24 18:55:15 +12:00
Tim Donohue
bd171f3220 Update LICENSES_THIRD_PARTY for 7.3 2022-06-23 17:07:57 -05:00
Vincenzo Mecca
6d46995698 Merge remote-tracking branch 'origin/main' into main-duracom-70
Conflicts:
	dspace-api/src/test/java/org/dspace/builder/ItemBuilder.java
2022-06-23 15:54:30 +02:00
Tim Donohue
1111459550 Merge pull request #8370 from tdonohue/docker_builds_no_transfer
Ensure all automated CI / Docker builds use `--no-transfer-progress` maven flag
2022-06-22 16:52:44 -05:00
Tim Donohue
4aab8f0cb7 Ensure all automated builds use --no-transfer-progress maven flag 2022-06-22 15:38:20 -05:00
Tim Donohue
a8f4b080ba Merge pull request #8268 from 4Science/CST-5799
Porting of OrcidPublicationDataProvider
2022-06-22 14:38:18 -05:00
Tim Donohue
bf8bc79590 Merge pull request #8368 from tdonohue/fix_ITs
Fix consistent cleanup failure in CsvSearchExportIT
2022-06-22 14:24:59 -05:00
Tim Donohue
f66d1633ed Minor improvement. Only delete the "metadata-export-search" processes we can find. 2022-06-22 13:35:06 -05:00
Tim Donohue
6f4fa1225b Fix IT by cleaning up all processes not just last one, as the last one may not be the one just created. 2022-06-22 13:25:10 -05:00
Luca Giamminonni
0f488de52a [CST-5799] Handled search with unknown ORCID 2022-06-22 17:06:28 +02:00
Luca Giamminonni
6fc1a0f22f Merge remote-tracking branch '4science-bitbucket/main' into CST-5799 2022-06-22 16:36:43 +02:00
Tim Donohue
0e165d6d3c Merge pull request #8364 from 4Science/fix-relation-versioning-flyway
Rename flyway migration scripts for relation versioning according to our convention
2022-06-22 08:47:23 -05:00
Tim Donohue
c5d7ec001b Merge pull request #8266 from 4Science/CST-5587
Orcid queue and synchronization
2022-06-22 08:33:39 -05:00
Luca Giamminonni
9ceb70a6ad Merge branch 'CST-5587' into CST-5799 2022-06-22 11:53:07 +02:00
Luca Giamminonni
26409809a5 [CST-5799] Minor improvements on map converter files 2022-06-22 11:52:39 +02:00
Luca Giamminonni
655241204f [CST-5587] Disabled orcidqueueconsumer by default 2022-06-21 17:25:31 +02:00
Luca Giamminonni
0133ee4c11 [CST-5587] Improved javadocs and comments 2022-06-21 17:25:15 +02:00
Vincenzo Mecca
0f3114745b Merge remote-tracking branch 'bit-bucket/main-duracom-69' into main-duracom-69 2022-06-21 15:33:21 +02:00
Vincenzo Mecca
687d5ca216 [DURACOM-69] Refacored common methods
ref: Introduced abstract common class with utility methods
2022-06-21 15:11:50 +02:00
Vincenzo Mecca
589ddd1a0d [DURACOM-70] Resolved change requests
JavaDoc description on HdlResolverRestController
Replaced Gson with Jackson
Added exception logging and rethrowing
2022-06-21 11:58:54 +02:00
Bruno Roemers
711e50f3b1 92174: Refactor OpenUrlServiceImplTest to avoid making http requests 2022-06-21 11:58:42 +02:00
Luca Giamminonni
5f8728eef2 Merge branch 'CST-5587' into CST-5799 2022-06-21 11:04:54 +02:00
Luca Giamminonni
e86d98919a [CST-5587] Added default value for Work and Funding type 2022-06-20 19:04:43 +02:00
Luca Giamminonni
d13b966aea [CST-5587] Fixed OrcidQueueConsumerIT tests 2022-06-20 18:11:13 +02:00
Luca Giamminonni
c351ae310f [CST-5587] Fixed submission-forms.xml 2022-06-20 17:52:40 +02:00
Luca Giamminonni
681edb81a3 [CST-5587] Removed OpenAIRE CERIF types 2022-06-20 17:50:15 +02:00
Luca Giamminonni
0936dc6a5f [CST-5587] Removed not used property 2022-06-20 17:06:08 +02:00
Luca Giamminonni
9c99117818 [CST-5587] Removed changes in OpenUrlServiceImplTest 2022-06-20 17:01:58 +02:00
Luca Giamminonni
42b4baeb32 [CST-5587] Improved default message during orcid bulk push 2022-06-20 16:46:59 +02:00
Luca Giamminonni
1865e784be [CST-5587] Added error log if an error occurs during orcid synchronization 2022-06-20 16:43:34 +02:00
Luca Giamminonni
ceab63ce79 [CST-5587] Removed not used methods 2022-06-20 16:43:00 +02:00
Luca Giamminonni
9ffb0b6047 [CST-5587] Fixed compilation error 2022-06-20 16:11:48 +02:00
Luca Giamminonni
680e96fda3 [CST-5587] Moved org.dspace.app.orcid and org.dspace.app.profile into org.dspace.orcid and org.dspace.profile 2022-06-20 16:02:01 +02:00
Luca Giamminonni
3e82a766d7 [CST-5587] Fixed OpenUrlServiceImplTest test 2022-06-20 15:24:45 +02:00
Luca Giamminonni
18573ff054 [CST-5587] Various improvements 2022-06-20 15:00:14 +02:00
Andrea Bollini
0761bc8ccf Rename flyway migration scripts for relation versioning according to our convention 2022-06-20 14:52:10 +02:00
Francesco Pio Scognamiglio
8fb2f09726 [CST-5699] force to use template to populate dspace.entity.type metadata 2022-06-20 13:27:43 +02:00
Bruno Roemers
c1dd080157 92174: Replace new operator with autowire
Fixes issue 8360.
2022-06-20 11:38:33 +02:00
Francesco Pio Scognamiglio
e882ae75b4 [CST-5699] Merge branch 'main' into CST-5699 2022-06-20 09:01:41 +02:00
Luca Giamminonni
318764fcff Merge branch 'CST-5587' into CST-5799 2022-06-17 17:00:57 +02:00
Luca Giamminonni
258c9a1b4d [CST-5587] Disabled orcid synchronization by default 2022-06-17 17:00:22 +02:00
Luca Giamminonni
ef5a9c2b6d [CST-5799] Removed unused param from javadoc 2022-06-17 16:57:01 +02:00
Luca Giamminonni
7471b0bd3d [CST-5799] Fixed ExternalSourcesRestControllerIT test 2022-06-17 15:02:15 +02:00
Luca Giamminonni
77796ea0b7 [CST-5799] Added ORCID id validation in OrcidPublicationDataProvider 2022-06-17 14:00:35 +02:00
Luca Giamminonni
7828190bd8 [CST-5799] Fixed OrcidPublicationDataProviderIT tests 2022-06-17 14:00:18 +02:00
Luca Giamminonni
7b816b6150 Merge branch 'CST-5587' into CST-5799 2022-06-17 13:35:10 +02:00
Luca Giamminonni
9f4cee5dbc [CST-5587] Fixed compilation errors 2022-06-17 13:34:49 +02:00
Luca Giamminonni
c9ce57334b Merge remote-tracking branch '4science-bitbucket/main' into CST-5587 2022-06-17 13:28:31 +02:00
Luca Giamminonni
c8498eb30e Merge remote-tracking branch '4science-bitbucket/main' into CST-5799 2022-06-17 13:27:12 +02:00
Luca Giamminonni
c940fbe743 Merge branch 'CST-5587' into CST-5799 2022-06-17 13:21:07 +02:00
Vincenzo Mecca
b2dca9ff6a Merged main into main-duracom-69 2022-06-17 10:37:05 +00:00
Vincenzo Mecca
b350ef8720 [DURACOM-69] Added UnitTest
feat: Added FunctionalUtils that uses Functional Interfaces and declares some utilities
fix & imp: S3BitStoreService fixed some issues and refactored code
test: Added S3BitStoreServiceTest for missing UnitTest
2022-06-17 12:35:04 +02:00
benbosman
3fa31f5e2a Merge pull request #8265 from atmire/feature-relationship-versioning-contribution
Feature: Entity / relationship versioning
2022-06-17 11:48:05 +02:00
Francesco Pio Scognamiglio
68416def97 [CST-5699] Merge branch 'main' into CST-5699 2022-06-17 11:37:06 +02:00
Bruno Roemers
3404c074d3 Merge branch 'main' into feature-relationship-versioning-contribution 2022-06-17 10:13:21 +02:00
Tim Donohue
6bd3a38538 Merge pull request #8267 from atmire/w2p-90830_issue-8125_Import-items-stale-in-discovery
Prevent imported items to be considered stale in discovery
2022-06-16 15:40:28 -05:00
Tim Donohue
14bf0a71ec Merge pull request #8310 from atmire/w2p-91356_detached-bitstream-moved-to-new-bundle-remains-deleted_upstream-latest
When a bitstream is removed from one bundle and added to another, the bitstream should NOT be marked as deleted
2022-06-16 15:37:46 -05:00
Tim Donohue
b3a3d68f0c Merge pull request #8235 from 4Science/CST-5303-live-import
Migrate extra DSpace-CRIS "Live Import" sources to DSpace (Scopus, WOS, PubMedEurope, CiNii)
2022-06-16 15:36:45 -05:00
Tim Donohue
31323baa41 Merge pull request #8354 from 4Science/CST-5755_sql_version_fix
Updated process2groups Flyway migration file names
2022-06-16 14:03:50 -05:00
Tim Donohue
004ad03d64 Merge pull request #8350 from tdonohue/fix_oai_harvesting
Fix OAI Harvesting by restoring Xalan (required by OCLC OAI Harvester 2 codebase)
2022-06-16 13:42:33 -05:00
benbosman
e50724c95a Export Metadata (CSV) from Search Results (#8037)
* [task 84826] adding a method to get an iterator of items found to the SearchService

* [task 84826] making the command line script for the search export

* [task 84826] test for the rest endpoint for the search csv export script

* [task 84826] test for the case of exporting based on a search query

* [task 84826] attempt at limiting the scope in which the search is happening

* [task 84826] limiting the scope of the search export and implementing more options

* [task 84826] implementing feedback + adding forgotten test file

* [task 85895] improving filters in metadata export search

* [task 86023] made code more readable

* [task 86023] allowing more than 1 filter to be applied

* checkstyle fixes

* 86307: Move DiscoverQueryBuilder to DSpace API

* 86307: Fix spring issue

* removing autowired in dspace-api querybuilder

* using querybuilder to create a query

* creating the querybuilder using servicemanager

* [task 87993] bugfix in MetadataExportSearch

* Revert "removing autowired in dspace-api querybuilder"

This reverts commit 252ef24765.

* checkstyle fixes

* [task 88304] added javadocs

* [task 88304] restoring authentication earlier so tests run authenticated

* implemented feedback

* Remove comment

* [task 90900] extended test suite

* [task 90900] checkstyle fixes

* [task 90900] changed location of file save for MetadataExportSearch

* [task 90900] checkstyle fix

* [task 90900] used jackson databind instead of json

* [task 90900] removed accidentally added spaces

* [wip] [task 90900] adding tests for fail scenarios

* [task 90900] adding tests for fail scenarios

* [task 90900] used jackson databind instead of json

* [task 90900] removed accidentally added spaces

* [wip] [task 90900] adding tests for fail scenarios

* [task 90900] adding tests for fail scenarios

* [task 90900] deleted accidentily added file

* specified file location for export file from cli

* checkstyle fixes

* [task 91781] implemented feedback

* setting export dir differently in tests

* trying another export dir folder

* saving export in a location outside of dspace

* [task 91781] used same export dir as metadataexportit

* [task 91781] added debug printing

* [task 91781] added debug printing

* [task 91781] added debug printing

* [task 91781] changed prints to logs

* [task 91781] more debug info

* [task 91781] more debug info

* [task 91781] more debug info

* TEMP: Assert script success/failure

* TEMP: Handled exception is not a failure

* TEMP: Maybe a workaround for DiscoveryIT failures

* Revert "TEMP: Maybe a workaround for DiscoveryIT failures"

This reverts commit 7b1ebcf13a.

* TEMP: Confirm that MetadataExportSearchIT knocks out DiscoveryIT now

* TEMP: Initialize services in setup() instead of inline

* TEMP: Don't share runnable handler between tests

* TEMP: Use SearchService in test context before script context

* [task 91781] making search service available in the class

* checkstyle fixes

* [task 91781] ignoring MetadataExportSearchIT

* [task 91781] specifying export file name in rest script run

* [task 91781] switching the sort order

Co-authored-by: Joost <joost.fock@atmire.com>
Co-authored-by: Yana De Pauw <yana@atmire.com>
Co-authored-by: Yura Bondarenko <yura.bondarenko@atmire.com>
2022-06-16 13:32:10 -05:00
corrado lombardi
b1ada1b1b6 [CST-5755] renamed sql migration file names with correct version number 2022-06-16 19:44:18 +02:00
Tim Donohue
538f295a45 Merge pull request #8263 from 4Science/CST-5669
Authentication, link and unlink with ORCID
2022-06-16 11:34:23 -05:00
Luca Giamminonni
592cc63985 [CST-5587] Added Orcid country validation 2022-06-16 17:51:57 +02:00
Tim Donohue
f53368011c Merge pull request #8340 from mspalti/iiif-cors-policy
Changed default cors policy for IIIF endpoints.
2022-06-16 08:49:39 -05:00
Luca Giamminonni
5e0121b85b [CST-5587] Fixed OrcidEntityFactoryServiceIT test 2022-06-16 14:26:03 +02:00
Bruno Roemers
7f9404024a Merge branch 'w2p-91356_detached-bitstream-moved-to-new-bundle-remains-deleted_upstream-ds-7.0' into w2p-91356_detached-bitstream-moved-to-new-bundle-remains-deleted_upstream-latest 2022-06-16 13:36:18 +02:00
Bruno Roemers
0159ce0315 91356: Add comment (feedback) 2022-06-16 13:35:22 +02:00
Luca Giamminonni
87eee7892e [CST-5587] Added property to enable/disable orcid synchronization, orcid synchronization configuration refactoring 2022-06-16 13:14:46 +02:00
Mykhaylo
8922acd024 Merge branch 'main' into CST-5303-live-import 2022-06-16 13:08:18 +02:00
Mykhaylo
d01a89ca16 [CST-5303] removed SimpleMapConverter 2022-06-16 13:06:12 +02:00
Luca Giamminonni
791a2441ff Merge branch 'CST-5669' into CST-5587 2022-06-16 12:39:07 +02:00
Luca Giamminonni
8b3ab2427d [DSC-403] Fixed S3 use relative path property name 2022-06-16 11:05:35 +02:00
Mykhaylo
e7e45be3f3 refactored s3bitStore 2022-06-16 11:05:19 +02:00
Mykhaylo
f5f8867a09 added support to use relative path in S3BitStore 2022-06-16 11:04:58 +02:00
Andrea Bollini
4468fccdcd DSC-403 Porting to DSpace-CRIS 7 of the IAM support for S3 2022-06-16 10:58:00 +02:00
Luca Giamminonni
ce6145d800 [CST-5587] Added automatic orcid queue recalculation after settings update 2022-06-15 18:12:30 +02:00
Mykhaylo
54b4092320 [CST-5303] implemented community feedback 2022-06-15 17:19:53 +02:00
Vincenzo Mecca
d4fb343f1e [DSC-611] [DURACOM-70] fix: JavaDoc & Header 2022-06-15 14:47:52 +02:00
Vincenzo Mecca
ed03b107db feature: Added handle in ItemBuilder
Partial porting of [CST-2501] for withHandle method in ItemBuilder
2022-06-15 14:39:13 +02:00
Luca Giamminonni
e88a67d5f1 [CST-5669] Improved linkProfile javadoc 2022-06-15 14:04:51 +02:00
Mykhaylo
ff144bffef [CST-5303] minor fix 2022-06-15 12:46:45 +02:00
Mykhaylo
3f05c142d3 [CST-5303] refactoring CiNii 2022-06-15 12:36:37 +02:00
Mykhaylo
e40a464561 [CST-5303] refactored PubmedEurope 2022-06-15 12:36:00 +02:00
Luca Giamminonni
566ec1ac07 [CST-5669] Fixed OrcidLoginFilterIT test 2022-06-15 11:55:39 +02:00
Luca Giamminonni
4129d3850d [CST-5669] Minor improvements 2022-06-15 11:48:49 +02:00
Vincenzo Mecca
e12a626192 [DSC-611] [DURACOM-70] feature: Handle resolver
New REST service for handle resolver
2022-06-15 11:24:14 +02:00
Vincenzo Mecca
135a24df83 feature: DSC-611 - First Integration Test Class 2022-06-15 11:23:42 +02:00
Vincenzo Mecca
7f626577b6 Merged main into main-duracom-70 2022-06-15 09:16:54 +00:00
Tim Donohue
5bb55ebb5e Merge pull request #8297 from 4Science/CST-5755_save_special_groups_in_process
Save special groups in process
2022-06-14 15:43:10 -05:00
Luca Giamminonni
0720e5b68d [CST-5669] Disconnect profile from ORCID during profile's soft deletion 2022-06-14 17:48:06 +02:00
Luca Giamminonni
11b896424c [CST-5669] Returns 422 in case of invalid authorization code during ORCID connection 2022-06-14 16:41:30 +02:00
Luca Giamminonni
fc323830a0 [CST-5669] Minor OrcidClientException refactoring 2022-06-14 16:11:21 +02:00
Luca Giamminonni
990d05903f [CST-5669] Added link profile test case when the user has not a profile 2022-06-14 15:48:49 +02:00
Luca Giamminonni
c76aa8da66 [CST-5669] Improved ResearcherProfileAddOrcidOperation javadoc 2022-06-14 15:05:53 +02:00
Luca Giamminonni
28eca550fc [CST-5669] Fixed checkstyle warning 2022-06-14 14:48:23 +02:00
Luca Giamminonni
03cb9e3cf1 [CST-5669] Addressed community feedbacks 2022-06-14 13:42:00 +02:00
Mykhaylo
0ef2d4e626 [CST-5303] refactored tests of WOS 2022-06-14 13:41:26 +02:00
Mykhaylo
53a881806c [CST-5303] fix WOS 2022-06-14 13:31:44 +02:00
Luca Giamminonni
1adeca5b4c [CST-5669] Improved Orcid link with already existing profile 2022-06-14 12:59:31 +02:00
Tim Donohue
5d5c150936 Merge pull request #8341 from DSpace/dependabot/maven/com.google.oauth-client-google-oauth-client-1.33.3
Bump google-oauth-client from 1.32.1 to 1.33.3
2022-06-13 16:55:29 -05:00
Tim Donohue
385fbe98a8 Xalan is required by OCLC OAI Harvester 2 codebase 2022-06-13 11:55:49 -05:00
Kristof De Langhe
39524c76ed Merge branch 'w2p-90830_issue-8125_Import-items-stale-in-discovery_7.0' into w2p-90830_issue-8125_Import-items-stale-in-discovery 2022-06-13 13:28:04 +02:00
Kristof De Langhe
7362f9f2fb 92188: Atomically update database_status instead of reindexing entire document 2022-06-13 13:24:40 +02:00
Mykhaylo
a3ca2badf4 Merge branch 'main' into CST-5303-live-import 2022-06-13 09:39:37 +02:00
Tim Donohue
86596dc2cb Add exclusion to fix dependency convergence issues 2022-06-10 16:45:31 -05:00
Tim Donohue
74001e1dd8 Merge pull request #8335 from 4Science/CST-5997-LiveImportFrom-Pubmed-NotWorking
Pubmed query not working
2022-06-10 16:28:51 -05:00
Luca Giamminonni
8f1aa722c5 [CST-5799] Changes after community feedbacks 2022-06-10 18:23:36 +02:00
Luca Giamminonni
b0bca4a055 [CST-5799] Fixed compilation errors 2022-06-10 17:51:53 +02:00
Luca Giamminonni
bec50786de Merge branch 'CST-5587' into CST-5799 2022-06-10 17:09:51 +02:00
Luca Giamminonni
755505cd9a [CST-5587] Added tests for SimpleMapConverter 2022-06-10 16:30:06 +02:00
Tim Donohue
589babe6f4 Merge pull request #8334 from atmire/w2p-88835_try-catch-IndexFactoryImpl
Catch exception when writing document to solr core and log it
2022-06-10 08:53:09 -05:00
Bruno Roemers
c1e99b1b7a Merge branch 'main' into feature-relationship-versioning-contribution 2022-06-10 13:25:00 +02:00
Luca Giamminonni
c77350c253 [CST-5587] Fixed LGTM alerts 2022-06-10 12:55:43 +02:00
Luca Giamminonni
bc7d6a8a70 [CST-5587] Removed affiliation's validation (not migrated on dspace) 2022-06-10 12:49:29 +02:00
Luca Giamminonni
a1c9e7e9f9 Merge remote-tracking branch '4science-bitbucket/main' into CST-5587 2022-06-10 12:31:59 +02:00
Luca Giamminonni
577e96180a [CST-5669] Improved orcid.disconnection.allowed-users comment 2022-06-10 12:26:15 +02:00
Mykhaylo
4b59b12cd7 [CST-5997] updated exception message 2022-06-10 12:14:42 +02:00
Bruno Roemers
f62279efa4 Merge branch 'feature-relationship-versioning_discover-7.2' into feature-relationship-versioning-contribution 2022-06-10 12:06:11 +02:00
Luca Giamminonni
3660ec2cfa [CST-5669] Added OrcidAuthentication configuration on local.cfg.EXAMPLE 2022-06-10 11:59:06 +02:00
Bruno Roemers
b535020c15 92097: Update scope notes for relation.* and relation.*.latestForDiscovery metadata fields 2022-06-10 11:27:33 +02:00
Mykhaylo
f114cfbdd0 [CST-5303] fix failed tests 2022-06-10 09:35:14 +02:00
dependabot[bot]
35ebce1548 Bump google-oauth-client from 1.32.1 to 1.33.3
Bumps [google-oauth-client](https://github.com/googleapis/google-oauth-java-client) from 1.32.1 to 1.33.3.
- [Release notes](https://github.com/googleapis/google-oauth-java-client/releases)
- [Changelog](https://github.com/googleapis/google-oauth-java-client/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-oauth-java-client/compare/v1.32.1...v1.33.3)

---
updated-dependencies:
- dependency-name: com.google.oauth-client:google-oauth-client
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-10 00:42:16 +00:00
Mykhaylo
97933131e2 [CST-5303] update scopus 2022-06-09 23:32:05 +02:00
Tim Donohue
bdc299e1b2 Merge pull request #8324 from 4Science/CST-5855
Cst-5855 custom resource policies are duplicated if multiple upload configuration share the same access conditions
2022-06-09 15:31:31 -05:00
Michael Spalti
d441a6c836 Changed default cors policy for IIIF endpoints. 2022-06-09 10:40:49 -07:00
Luca Giamminonni
23fd0bb920 [CST-5669] Reverted context.turnOffAuthorisationSystem() removal 2022-06-09 18:29:43 +02:00
Luca Giamminonni
f193701cff [CST-5669] Removed check on first name and last name during ORCID authentication 2022-06-09 18:14:43 +02:00
Luca Giamminonni
003321df4f [CST-5669] Removed context.turnOffAuthorisationSystem in OrcidSynchronizationServiceImpl 2022-06-09 17:58:41 +02:00
Luca Giamminonni
dc5ef4844b Merge remote-tracking branch '4science-bitbucket/main' into CST-5669 2022-06-09 17:45:28 +02:00
Tim Donohue
f9a38cab41 Merge pull request #8232 from 4Science/CST-5306
Researcher profile REST repository
2022-06-09 10:07:08 -05:00
Jens Vannerum
24a43dee8c 88835: Removed unnecessary brackets 2022-06-09 16:18:30 +02:00
Mykhaylo
8c7e049802 [CST-5303] minor update 2022-06-09 15:48:20 +02:00
Mykhaylo
b16780d816 [CST-5303] refactoring WOS 2022-06-09 15:09:18 +02:00
Mykhaylo
3f57305529 Merge branch 'main' into CST-5303-live-import 2022-06-09 10:06:24 +02:00
Jens Vannerum
66b976bd5f 88835: Improved logging message 2022-06-09 10:05:46 +02:00
Mykhaylo
f7f15df8d5 Merge branch 'main' into CST-5997-LiveImportFrom-Pubmed-NotWorking 2022-06-09 09:32:38 +02:00
Toni Prieto
f20d2ca300 Ignore diacritics in browse by title 2022-06-08 23:48:29 +02:00
Tim Donohue
b66a806235 Merge pull request #8316 from tdonohue/minor_spring_update
Minor update to latest Spring / Spring Boot / Spring Security.
2022-06-08 15:27:16 -05:00
Tim Donohue
196a5bfeb2 Merge pull request #8238 from 4Science/CST-5303-live-import-4PR
Migrate extra DSpace-CRIS "Live Import" sources to DSpace (EPO & ADS)
2022-06-08 12:24:34 -05:00
Mykhaylo
d8ffa6cdb9 move the buildLink method to ExternalSourceEntryHalLinkFactory 2022-06-08 18:10:55 +02:00
emanuele
139640606a [CST-5855] added missing annotation 2022-06-08 18:01:57 +02:00
ballarinie
83b641c1c5 Merge branch 'main' into CST-5855 2022-06-08 17:51:09 +02:00
emanuele
1c9b684395 [CST-5855] minor fixes 2022-06-08 17:41:02 +02:00
Mykhaylo
89de1fdb41 [CST-5997] fix misspelled 2022-06-08 17:38:49 +02:00
Mykhaylo
8ffb4dd6c6 [CST-5303] refactored scopus live import integration 2022-06-08 17:29:51 +02:00
Giuseppe Digilio
a3ed88fa8f Merge branch 'main' into CST-5306 2022-06-08 16:59:33 +02:00
Tim Donohue
e108f11379 Merge pull request #8271 from 4Science/CST-5269-Sherpa-Romeo
Sherpa-Romeo Integration
2022-06-08 09:17:55 -05:00
Tim Donohue
be71908b2c Merge pull request #8166 from 4Science/CST-5288
Introduced Spring boot actuators
2022-06-08 09:10:52 -05:00
Jens Vannerum
d09b0c60a1 88835: Feedback 2022-06-08 15:38:15 +02:00
Mykhaylo
e1c6146162 [CST-5997] minor fix 2022-06-08 14:32:52 +02:00
Mykhaylo
1de78d5e66 Merge branch 'main' into CST-5997-LiveImportFrom-Pubmed-NotWorking 2022-06-08 13:16:16 +02:00
Mykhaylo
99875b307d [CST-5997] removed unused mock bean 2022-06-08 12:48:24 +02:00
Mykhaylo
cbd468ea0e [CST-5997] added possibility to re-try request to PubMed if responce is 500 2022-06-08 11:02:25 +02:00
Tim Donohue
0e461d546a Merge pull request #8314 from 4Science/CST-5756_relationship_type_embedding
[CST-5756] Embedding of RelationshipType in Relationship resource
2022-06-07 16:58:51 -05:00
Tim Donohue
eae165e928 Merge pull request #8309 from 4Science/CST-5680
Fixed bitstream content download error when using special groups
2022-06-07 15:59:59 -05:00
Mykhaylo
84a51fac2a [CST-5303] added 'none' to supported entity types 2022-06-07 17:30:15 +02:00
Luca Giamminonni
8712a48a6c [CST-5587] Added project and orgunit relation in submission form 2022-06-07 14:47:29 +02:00
Luca Giamminonni
9f6ff8f33b Merge remote-tracking branch '4science-bitbucket/main' into CST-5587 2022-06-07 14:37:42 +02:00
Mykhaylo
5f5c3fe2a3 Merge branch 'main' into CST-5303-live-import-4PR 2022-06-07 13:14:10 +02:00
Mykhaylo
b6a54d75b3 [CST-5303] Implemented community feedbacks 2022-06-07 12:42:59 +02:00
Luca Giamminonni
eb8b2546ce [CST-5669] Fixed LGTM warnings 2022-06-07 12:35:00 +02:00
Mykhaylo
11767f5d37 [CST-5303] fixed link builder of external sources 2022-06-07 00:05:30 +02:00
Andrea Bollini
4954358c53 Improve javadoc for SherpaCacheLogging 2022-06-06 14:58:33 -06:00
Mykhaylo
2aff1f610c [CST-5269] added comment to explene exclusion in pom.xml 2022-06-06 21:41:13 +02:00
Luca Giamminonni
ab0fbcc9fe [CST-5669] Added redirect on ORCID login error 2022-06-06 18:07:35 +02:00
Mykhaylo
dc0aeb847a [CST-5997] refactored pubmed live import service 2022-06-06 16:26:50 +02:00
Luca Giamminonni
00031a0dd6 Merge remote-tracking branch '4science-bitbucket/main' into CST-5669 2022-06-06 15:28:10 +02:00
Luca Giamminonni
b801c0c69f [CST-5306] Added email and write policy on created researcher profile 2022-06-06 15:14:40 +02:00
Tim Donohue
16e364615c Merge pull request #8303 from atmire/fix-getname-issues-main
Overwrite getName usage in applicable services & missing log statements
2022-06-03 16:53:49 -05:00
Tim Donohue
f5eac46ede Merge pull request #8323 from 4Science/CST-5675
Fix OAI page unstyled when '/' is missing at the end of the URL
2022-06-03 15:56:43 -05:00
Ben Bosman
cdac9db9d7 Merge remote-tracking branch 'origin/feature-relationship-versioning_discover-7.2' into feature-relationship-versioning-contribution 2022-06-02 14:29:04 +02:00
Mykhaylo
0935581836 minor update 2022-06-01 16:40:16 +02:00
Bruno Roemers
c21ac4bde0 91354: Exclude workspace and workflow items from being indexed during index rebuild 2022-06-01 16:37:17 +02:00
Mykhaylo
d3b467cdb2 [CST-5269] refactored embargo data model 2022-06-01 15:54:39 +02:00
Bruno Roemers
0f268d0ebd 91354: Prove ItemDAOImpl#findAllRegularItems needs changes 2022-06-01 15:08:53 +02:00
Bruno Roemers
acc968f1ce 91354: Fix test_forceReindexAfterNewVersionInWorkspace
Re-enable commit d549e6e58a
2022-05-31 17:44:40 +02:00
Mykhaylo
805cd7ae6b [CST-5303] refactored tests 2022-05-31 17:43:27 +02:00
Bruno Roemers
60c8faf234 91354: Prove that changes in commit d549e6e58a were necessary 2022-05-31 17:41:37 +02:00
Bruno Roemers
8d9304a6f7 91354: Complete test_rebuildIndexAllVersionsShouldStillBePresentInSolrCore 2022-05-31 16:26:45 +02:00
Francesco Pio Scognamiglio
f9d01b96f8 [CST-5699] add integration tests on zip with bitstream and zip with relationships file 2022-05-31 16:20:01 +02:00
Mykhaylo
3a1dfa69e3 [CST-5303] removed duplicate services 2022-05-31 15:37:51 +02:00
Jurgen Mamani
be353c5301 [CST-5755] Added changes 2022-05-31 15:09:37 +02:00
Jurgen Mamani
c09a8d097d [CST-5755] Revert back List to Set change 2022-05-31 15:09:33 +02:00
Jurgen Mamani
efe3e1d36d [CST-5755] Refactoring based on feedback from PR 2022-05-31 15:09:30 +02:00
Mykhaylo
32e178418c [CST-5303] refactoring 2022-05-31 14:25:53 +02:00
Bruno Roemers
b0482bcdd8 91354: WIP: basic fix for reindexing older versions of items 2022-05-31 14:10:51 +02:00
Bruno Roemers
ea8b4f4896 91354: Prove that index rebuild is broken 2022-05-31 14:08:57 +02:00
Mykhaylo
64f1b7e30b [cst-5303] fix failed tests 2022-05-31 11:50:07 +02:00
Mykhaylo
d8aec0ce67 Merge branch 'main' into CST-5303-live-import 2022-05-31 00:23:24 +02:00
Mykhaylo
8e794fdc33 [CST-5303] fix double encode 2022-05-30 17:01:11 +02:00
Luca Giamminonni
e3ac2f90da [CST-5306] Improved claim tests 2022-05-30 12:37:58 +02:00
Mykhaylo
4a19246a5d [cst-5303] update tests 2022-05-30 12:11:07 +02:00
emanuele
53ecb9bf06 CST-5855 adjusted javadoc and removed unnecessary comments 2022-05-30 11:59:42 +02:00
Mykhaylo
b8e269a477 [CST-5303] Implement community feedbacks 2022-05-30 11:38:54 +02:00
Stefano Maffei
b5ee25030e [CST-5675] fixes in OAI Integration Tests 2022-05-30 10:48:20 +02:00
Francesco Pio Scognamiglio
a5c4031cfe [CST-5699] minor fix on spurious javadoc params 2022-05-30 09:10:15 +02:00
Mark H. Wood
c7c174ccf6 Merge branch 'main' into LGTM 2022-05-27 14:13:57 -04:00
Mark H. Wood
a956472684 Satisfy checkstyle. #8304 2022-05-27 12:59:44 -04:00
Mark H. Wood
8fb948d6a8 Devolve authorization to the strategy classes. Add tests. #8304 2022-05-27 12:24:49 -04:00
Stefano Maffei
d014b07d8f [CST-5675] Fixes oai page unstylized when '/' is missing at the end of the URL 2022-05-27 18:24:13 +02:00
Tim Donohue
60f7bf0559 Merge pull request #8315 from tdonohue/disable_multiarch_for_prs
Docker Fixes: Ensure multiple architecture build is disabled for PRs
2022-05-27 09:05:00 -05:00
emanuele
6fd1f0e3a4 CST-5855 fixed bitstream access conditions duplication error and added ITs 2022-05-27 16:01:42 +02:00
Francesco Pio Scognamiglio
36ab086721 Merge branch 'main' into CST-5699 2022-05-27 14:44:46 +02:00
Francesco Pio Scognamiglio
e1e599a047 [CST-5699] fix to manage relationships by metadata_relation file on SAF import; clean integration tests 2022-05-27 14:11:13 +02:00
Tim Donohue
c589462983 Minor update to latest Spring / Spring Boot / Spring Security. Other minor POM dependency cleanup 2022-05-26 17:12:05 -05:00
Tim Donohue
3699125f94 Only build PRs in AMD64, as a simple sanity check 2022-05-26 16:46:31 -05:00
Mykhaylo
e5f39723bf fix failed tests 2022-05-26 18:56:34 +02:00
Mykhaylo
f607571837 [cst-5303] fix metadata 2022-05-26 18:16:50 +02:00
corrado lombardi
aabcf78db3 [CST-5756] updated documentation 2022-05-26 17:54:57 +02:00
Mykhaylo
ed07cece6b Merge branch 'main' into CST-5303-live-import-4PR 2022-05-26 17:10:20 +02:00
Luca Giamminonni
1a6ba75369 Merge remote-tracking branch '4science-bitbucket/main' into CST-5587 2022-05-26 15:59:04 +02:00
Luca Giamminonni
4574a72fb3 [CST-5587] Minor improvements 2022-05-26 15:58:19 +02:00
corrado lombardi
5218a25523 [CST-5756] Embedding of RelationshipType in Relationship resource 2022-05-26 13:46:21 +02:00
Luca Giamminonni
d6675c1060 Merge remote-tracking branch '4science-bitbucket/main' into CST-5306 2022-05-26 10:15:43 +02:00
Luca Giamminonni
72d25917eb [CST-5306] Added automatic claim test 2022-05-26 10:14:46 +02:00
Tim Donohue
e5f316c9ad Merge pull request #8296 from the-library-code/TLC-254_type-bind-fixes
Fix type bind validation to support fields configured more than once
2022-05-25 17:09:22 -05:00
Tim Donohue
dbaa20f345 Merge pull request #8285 from 4Science/CST-5673
Cst-5673 implement patch operations for action and policyType attributes
2022-05-25 14:32:10 -05:00
Tim Donohue
a671838e50 Merge pull request #8236 from 4Science/CST-5303-LiveImport-3PR
Migrate extra DSpace-CRIS "Live Import" sources to DSpace (SciELO)
2022-05-25 13:43:06 -05:00
Francesco Pio Scognamiglio
75e9604a6e [CST-5699] add integration test for relationships functionality 2022-05-25 19:45:35 +02:00
Ben Bosman
e91593abdb Merge remote-tracking branch 'origin/feature-relationship-versioning_discover-7.2' into feature-relationship-versioning-contribution 2022-05-25 17:53:09 +02:00
Tim Donohue
aff0e199bc Merge pull request #8300 from tdonohue/deprecate_oracle
Add deprecation notice for Oracle Support to 7.3
2022-05-25 10:48:17 -05:00
Francesco Pio Scognamiglio
4a96d9fc1c [CST-5699] minor fix to manage collections and relationships files when the contents file is missing 2022-05-25 17:06:59 +02:00
Bruno Roemers
6257b386b3 91680: Fix NPE 2022-05-25 16:57:30 +02:00
Mykhaylo
f445309d07 Merge branch 'main' into CST-5269-Sherpa-Romeo 2022-05-25 16:30:25 +02:00
Mykhaylo
680beae1b5 Merge branch 'main' into CST-5303-LiveImport-3PR 2022-05-25 16:24:57 +02:00
Mykhaylo
56d010e0d1 [CST-5303] inject missing field 2022-05-25 16:22:52 +02:00
Tim Donohue
074aa7c3d7 Merge pull request #8305 from atmire/test-multiplatform-docker-build
Add support for linux/arm64 platform to docker build
2022-05-25 08:29:05 -05:00
Bruno Roemers
dd843c4646 91680: Verify unrelated metadata does not affect item metadata place changes 2022-05-25 15:14:51 +02:00
ballarinie
79c4a4c847 Merge branch 'main' into CST-5673 2022-05-25 14:24:26 +02:00
Bruno Roemers
30e17894d6 91680: Verify that relationship place changes don't affect other relationships 2022-05-25 13:58:32 +02:00
Ben Bosman
ef010fcc91 Merge branch 'feature-relationship-versioning_discover-7.2' into feature-relationship-versioning-contribution 2022-05-25 13:25:56 +02:00
Luca Giamminonni
1c563e6b20 [CST-5680] Improved BitstreamRestControllerIT.restrictedSpecialGroupBitstreamTest test 2022-05-25 13:01:54 +02:00
Luca Giamminonni
da14dca46c [CST-5680] Fixed bitstream content download error using special groups 2022-05-25 12:46:38 +02:00
emanuele
9be74166dd CST-5673 tests now use the predefined eperson object 2022-05-25 12:41:56 +02:00
Bruno Roemers
0edfbc9fae 91680: Remove versioning.block.entity property
Versioning of DSpace entities is now properly supported,
so from now on it is possible to create/edit versions of any item,
regardless of whether it's an entity or not.
2022-05-25 12:15:12 +02:00
Bruno Roemers
3a5766a5d2 91680: Refactor: move entity type getters to itemService 2022-05-25 12:13:50 +02:00
Bruno Roemers
a028b4130f 91680: Rename RelationshipVersioningUtils to RelationshipVersioningTestUtils 2022-05-25 12:07:39 +02:00
Bruno Roemers
79a55fa1e4 91680: Add scope notes to relation.* and relation.*.latestForDiscovery metadata values 2022-05-25 12:05:42 +02:00
Bruno Roemers
15eff6f7d7 91680: Remove ItemBuilder#withEntityType 2022-05-25 12:04:18 +02:00
Bruno Roemers
92214cdfcf 91680: Inherit entity type from collection in ItemServiceTest 2022-05-25 12:01:36 +02:00
Bruno Roemers
7de999a389 91680: Add clarifying comments to RelationshipServiceImplPlaceTest 2022-05-25 12:00:27 +02:00
Bruno Roemers
9ece4d363f 91680: Remove duplicate comment 2022-05-25 11:58:32 +02:00
Bruno Roemers
63afa07e27 91680: Use log4j2 placeholders where possible 2022-05-25 11:58:29 +02:00
Bruno Roemers
f9b0274ead 88675: Finish test VersioningWithRelationshipsTest#test_virtualMetadataPreserved 2022-05-25 11:58:25 +02:00
emanuele
ae6cc69c38 CST-5855 changed findApplyResourcePolicy method to accept a single UploadConfiguration) 2022-05-25 09:59:55 +02:00
Francesco Pio Scognamiglio
504f7fecf3 [CST-5699] add integration tests for import and export via SAF 2022-05-25 09:34:13 +02:00
Francesco Pio Scognamiglio
3443bd5d48 [CST-5699] add scripts for import and export via SAF 2022-05-25 09:33:38 +02:00
Kim Shepherd
e0534a5d96 [TLC-254] Moved shared code to DCInputSet, new Unit Test for sub config 2022-05-25 12:24:47 +12:00
Kim Shepherd
e08fa2ec31 Dockerfile.test and docker-compose: expose port 8000, set JDWP java opts
This allows a remote JVM debugger to be connected to port 8000 on the
dspace docker container (test environment).
This may need a documentation note to warn against running the supplied
docker-compose / Dockerfile.test config in production -- already a good
warning but made more important now that the JVM can be exposed to a
debugger for reading memory...
2022-05-25 10:40:18 +12:00
Tim Donohue
f062abdcb2 Merge pull request #8287 from 4Science/CST-5673-AllowToDoGroupAndEpersonPatchingOfResourcepolicy
Allow to do group/eperson patching of a resourcepolicy
2022-05-24 17:20:55 -05:00
Tim Donohue
df93b79d13 Merge pull request #8286 from atmire/w2p-90948_More-informative-error-for-Workflow-group-delete
Add custom exception for deleting Group with pending tasks
2022-05-24 16:45:58 -05:00
Art Lowel
0d4d2a85cb remove linux/arm/v7 as that isn't supported by maven:3-openjdk-11-slim 2022-05-24 17:59:35 +02:00
Art Lowel
2d0078c64e add support for multiple platforms to docker build 2022-05-24 17:54:01 +02:00
Jens Vannerum
177d4424db Overwrite getName usage in applicable services
- Added two useful log statements
2022-05-24 14:36:26 +02:00
emanuele
7371854cb1 Merge branch 'CST-5673' of https://bitbucket.org/4Science/dspace-cris into CST-5673 2022-05-24 10:36:30 +02:00
emanuele
749030d739 CST-5673 fixed ClassCastException and failing tests 2022-05-24 10:34:37 +02:00
Yura Bondarenko
738cdeca3d 90948: Make Spring include error messages in error responses 2022-05-23 14:49:52 +02:00
Bruno Roemers
06ad077a1e Merge branch 'main' into w2p-91356_detached-bitstream-moved-to-new-bundle-remains-deleted_upstream-latest 2022-05-23 14:49:23 +02:00
Bruno Roemers
bc2b53b9c5 91356: Fix tests 2022-05-23 14:46:52 +02:00
Bruno Roemers
3916d58222 91356: Prove that bitstream is still marked as deleted after adding to bundle 2022-05-23 14:31:13 +02:00
emanuele
a20baecc71 CST-5855 added IT to prove bug existance 2022-05-23 14:26:14 +02:00
Mykhaylo
7072e235ad Merge branch 'main' into CST-5673-AllowToDoGroupAndEpersonPatchingOfResourcepolicy 2022-05-23 10:55:56 +02:00
Mykhaylo
4befdc5509 Merge branch 'main' into CST-5303-LiveImport-3PR 2022-05-23 09:48:41 +02:00
Kim Shepherd
8f70299f0c [TLC-254] update submission ITs to reflect new elements/pages in cfg 2022-05-23 15:16:36 +12:00
Tim Donohue
358ddc98ed Add deprecation notice for Oracle to logs, dspace database info, READMEs and configs. 2022-05-20 15:09:27 -05:00
Luca Giamminonni
7780bf3bd8 Merge branch 'main' into CST-5669 2022-05-20 16:04:08 +02:00
Luca Giamminonni
3fca001cc7 Merge branch 'main' into CST-5587 2022-05-20 15:55:33 +02:00
Luca Giamminonni
126736fed4 [CST-5587] Minor improvements 2022-05-20 15:40:22 +02:00
Ben Bosman
bcb5918edc Merge branch 'feature-relationship-versioning__discovery' into feature-relationship-versioning-contribution 2022-05-20 09:35:52 +02:00
Kim Shepherd
886e5e8beb [TLC-254] revert accidental change introduced to test sub forms 2022-05-20 15:17:35 +12:00
Kim Shepherd
e7c18f8b98 [TLC-254] type bind qualdrop fixes 2022-05-20 14:29:41 +12:00
Kim Shepherd
28f7f5855f [TLC-254] Small checkstyle fix 2022-05-20 11:40:39 +12:00
Mykhaylo
055aff7158 [CST-5673] added missing tests with eperson&anonymous users 2022-05-19 22:58:43 +02:00
Tim Donohue
4e04dfd8d5 Merge pull request #8276 from 4Science/CST-5736
Include special groups in the authn status endpoint
2022-05-19 15:24:12 -05:00
Tim Donohue
0674403bc3 Merge pull request #8237 from 4Science/CST-5303-LiveImport-2PR
Migrate extra DSpace-CRIS "Live Import" sources to DSpace (CrossRef & VuFind)
2022-05-19 14:58:35 -05:00
Luca Giamminonni
c53dd7f79e [CST-5306] Added email check on ResearcherProfileService claim 2022-05-19 18:19:57 +02:00
Luca Giamminonni
30b35ac33a [CST-5669] Fixed tests 2022-05-19 15:49:18 +02:00
corrado lombardi
13b2aa0936 [CST-5755] removed commented code 2022-05-19 15:26:19 +02:00
corrado lombardi
7de7ba26ce [CST-5755] removed Gson usage and small code refactoring 2022-05-19 15:26:17 +02:00
corrado lombardi
cb0a6651f7 Merge branch 'main' into CST-5755_save_special_groups_in_process 2022-05-19 15:13:35 +02:00
Luca Giamminonni
8e01245fd1 [CST-5669] Configured ORCID sandbox 2022-05-19 15:12:43 +02:00
Luca Giamminonni
f71a3f067f [CST-5306] Allow claim only if email matches 2022-05-19 13:33:41 +02:00
Kim Shepherd
771d70049a [TLC-254] Better fix for 'required' conflict, ITs added
There were some logic issues with required vs non-required
for multiple inputs, and with qualdrop fields.
Simplified some of the qualdrop handling in MetadataValidation.

Added an Integration test to test a form that specifically
configures two dc.identifier.isbn inputs bound to two types
and has one required, one not.
2022-05-19 17:11:53 +12:00
Andrea Bollini
b76917eb45 Remove commented out code 2022-05-19 00:34:01 +02:00
Andrea Bollini
86df96ff57 Revert useless null check 2022-05-19 00:33:42 +02:00
Luca Giamminonni
18c8b91a55 [CST-5587] Code improvements 2022-05-18 17:52:03 +02:00
Kristof De Langhe
02632f79aa 90830: PR feedback 2 - comment fixes 2022-05-18 14:55:20 +02:00
Kristof De Langhe
de0e14e3a0 90830: PR feedback 2 - comment fixes 2022-05-18 14:53:45 +02:00
Luca Giamminonni
f131fd4865 [CST-5669] Fixed OrcidTokenBuilder 2022-05-18 12:25:10 +02:00
Luca Giamminonni
798e7bc63a [CST-5587] Refactoring after OrcidToken entity introduction 2022-05-18 12:24:02 +02:00
Yura Bondarenko
a4a7130f96 90948: Add IT for delete workflow group 422 error 2022-05-18 11:13:48 +02:00
Luca Giamminonni
db691b7e52 Merge branch 'CST-5669' into CST-5587 2022-05-18 11:07:07 +02:00
Luca Giamminonni
093524bcfd [CST-5288] Improved health status comment 2022-05-18 10:07:24 +02:00
Kim Shepherd
0066417b69 [TLC-254] fix issue where vals stripped fields are cfg'd more than once
If a field like dc.title.subtitle is configured multiple times in one
form with different rules for different type binding, when the validation
encounters the input config that is *not* bound for the doc type, it will
strip all metadata values even though the same field is allowed for this
type elsewhere in the form. This commit should fix this by constructing
a lookup map first, though it does not have a way to rigorously enforce
specific rule conflicts like repeatable=true and repeatable=false for
the same type, and so on.
2022-05-18 13:44:47 +12:00
Bruno Roemers
d549e6e58a 91354: Skip items in workspace/workflow when determining latest version while indexing 2022-05-17 18:50:34 +02:00
Bruno Roemers
226662a9dd 91354: Add extra checks to DiscoveryVersioningIT 2022-05-17 18:46:14 +02:00
Ben Bosman
19564a9e23 Merge remote-tracking branch 'origin/feature-relationship-versioning__discovery' into feature-relationship-versioning-contribution 2022-05-17 17:41:44 +02:00
Luca Giamminonni
d4f2dbb3e6 [CST-5288] Set 200 as http status for down and out_of_service health status 2022-05-17 15:21:25 +02:00
Bruno Roemers
43dcc3bc15 91390: Fix tests (3) 2022-05-17 14:29:31 +02:00
Bruno Roemers
54f5a14e7a 91390: Fix tests (2) 2022-05-17 11:47:01 +02:00
Luca Giamminonni
ad4f1d8b0d Merge branch 'CST-5306' into CST-5669 2022-05-17 10:32:09 +02:00
Luca Giamminonni
fd7e8a202d [CST-5306] Removed getFullName from ResearcherProfile 2022-05-17 10:20:35 +02:00
Mykhaylo
d43d3e2ee7 [CST-5673] request to update group/eperson must be in PUT 2022-05-17 09:28:35 +02:00
Mykhaylo
b5aec58549 Merge branch 'main' into CST-5269-Sherpa-Romeo 2022-05-16 23:17:17 +02:00
Mykhaylo
dc100eb5b8 [CST-5269] added missing JavaDoc 2022-05-16 23:15:39 +02:00
Bruno Roemers
27f796dee5 91390: Fix tests 2022-05-16 20:55:28 +02:00
Bruno Roemers
52a6920e13 91390: Revert changes to interface RelationshipMetadataService 2022-05-16 18:48:40 +02:00
Luca Giamminonni
f90359411f [CST-5669] Added OrcidToken entity to store orcid access token 2022-05-16 18:42:17 +02:00
Bruno Roemers
71cc97aa39 91390: Move class ItemUuidAndRelationshipId to separate file 2022-05-16 18:39:05 +02:00
Bruno Roemers
3fe4ae4a33 91390: Add support for tilted relationships to relation.*.latestForDiscovery 2022-05-16 18:32:59 +02:00
Luca Giamminonni
d82c6f9ee8 Revert "[CST-5669] Set orcid access token as hardcoded hidden metadata fields"
This reverts commit 4afa62a4c0.
2022-05-16 15:44:28 +02:00
Luca Giamminonni
3031dce00c Merge branch 'CST-5306' into CST-5669 2022-05-16 15:38:53 +02:00
Luca Giamminonni
d532829e73 [CST-5306] Added security check in EPersonAuthority 2022-05-16 15:30:17 +02:00
Mykhaylo
9a539bc9cc Merge branch 'main' into CST-5303-LiveImport-2PR 2022-05-16 14:49:18 +02:00
Mykhaylo
63179395ff [CST-5303] added unit tests for DoiCheck utility class 2022-05-16 14:47:28 +02:00
Luca Giamminonni
5a0b9ea456 [CST-5306] Improved CanClaimItemFeatureIT tests 2022-05-16 13:41:50 +02:00
Luca Giamminonni
2c80e1ee47 [CST-5306] Improved ResearcherProfileServiceImpl and ResearcherProfileRestRepositoryIT tests 2022-05-16 13:29:51 +02:00
Luca Giamminonni
493810c1d2 Merge remote-tracking branch '4science-bitbucket/main' into CST-5306 2022-05-16 12:54:01 +02:00
Mykhaylo
cff9ff9f30 [CST-5303] fix metadata field 2022-05-16 10:56:22 +02:00
Nathan Buckingham
30f923a080 OpenSearch RSS more robust handles Com/Coll as well as more search params (#8064)
* w2p-85140 Add sort and scope to opensearch to allow it to give proper results for rss feed

* w2p-86403 Removed legacy Config and changed default sort also revert community and collection in rss feeds

* remove unecessary dspace.cfg lines

* opensearch configuration needed

* w2p-86403 Fix discovery query grabbing non items in search result for opensearch

* w2p-86403 Change sort direction

* Change date accessioned_dt and discoveryConfig

* revert defaulting on rest side allow angular to handle defaulting

Co-authored-by: Nathan Buckingham <nathan.buckingham@atmire.com>
2022-05-13 14:25:01 -05:00
Bruno Roemers
b82814c088 88675: Add relation.*.latestForDiscovery metadata values to items 2022-05-13 19:14:32 +02:00
Bruno Roemers
bc740d299e 88675: Modify test for relation.*.latestForDiscovery metadata 2022-05-13 18:14:58 +02:00
Luca Giamminonni
e22e53cc25 [CST-5669] Improved OrcidLoginFilter 2022-05-13 16:52:40 +02:00
Kristof De Langhe
7e3ebd02df Merge branch 'w2p-90830_issue-8125_Import-items-stale-in-discovery_7.0' into w2p-90830_issue-8125_Import-items-stale-in-discovery 2022-05-13 12:50:37 +02:00
Kristof De Langhe
2649bea614 90830: Feedback + cron scheduler 2022-05-13 12:48:09 +02:00
Mykhaylo
38ef693a5b [CST-5303] fix bug with decoded doi 2022-05-13 00:46:21 +02:00
Mykhaylo
2813bb1eb1 Merge branch 'main' into CST-5673-AllowToDoGroupAndEpersonPatchingOfResourcepolicy 2022-05-12 17:16:54 +02:00
Mykhaylo
b947e2cfc2 [CST-5673] added missing tests 2022-05-12 17:14:37 +02:00
Bruno Roemers
b4087889f9 90946: Trigger reindex in VersioningConsumer when latest status is updated 2022-05-12 16:32:27 +02:00
Mykhaylo
0c377fd08a fix NullPointerException 2022-05-12 16:10:13 +02:00
Luca Giamminonni
4afa62a4c0 [CST-5669] Set orcid access token as hardcoded hidden metadata fields 2022-05-12 15:39:09 +02:00
Bruno Roemers
32fc45f515 90946: Remove force reindex from test 2022-05-12 15:11:55 +02:00
Bruno Roemers
86ab1ed9fd 90946: Finish test to confirm that items are reindexed in VersioningConsumer 2022-05-12 15:05:11 +02:00
Luca Giamminonni
21da1b4292 [CST-5669] Minor improvements 2022-05-12 13:54:31 +02:00
Mykhaylo
4ab106628a [CST-5303] fix bug null JsonNode 2022-05-12 13:46:11 +02:00
Mykhaylo
ce78d5fc1a [CST-5303] "none" entityType is also supported 2022-05-12 12:51:27 +02:00
Mykhaylo
b4e17f8d65 [CST-5303] fix problem in log with empty JsonNode 2022-05-12 12:48:42 +02:00
Ben Bosman
4243007c77 Merge branch 'feature-relationship-versioning__discovery' into feature-relationship-versioning-contribution 2022-05-12 11:37:13 +02:00
Author Name
421a907dac added some missing tests 2022-05-12 10:17:43 +02:00
corrado lombardi
309c710ca7 [CST-5755] used POJO with proper setter for groups, updated javadoc of ProcessService.create method, refactoring of test code 2022-05-12 08:47:08 +02:00
Mykhaylo
4dccad858a minor fix 2022-05-11 19:20:35 +02:00
Bruno Roemers
d634002ad8 90946: WIP: Write test to confirm that items are reindexed in VersioningConsumer 2022-05-11 19:08:11 +02:00
Mykhaylo
73e4cd1d29 [CST-5303] refactored SimpleMapConverter 2022-05-11 18:17:43 +02:00
Mykhaylo
d69f85ce6e fix javaDoc 2022-05-11 18:16:25 +02:00
Mykhaylo
510209eae6 [CST-5303] removed PLACEHOLDER_PARENT_METADATA_VALUE 2022-05-11 17:10:01 +02:00
Bruno Roemers
5ebfa5fa5a 90946: Move test utils to separate class for use in multiple test classes 2022-05-11 17:06:35 +02:00
Luca Giamminonni
4bfe3f58f9 [CST-5669] Improved javadoc 2022-05-11 16:27:57 +02:00
Mykhaylo
de4ffdf67b Merge branch 'main' into CST-5303-live-import 2022-05-11 16:27:49 +02:00
Mykhaylo
a436639ca7 [CST-5303] added missing JavaDoc 2022-05-11 16:23:22 +02:00
Mykhaylo
9c2c9132bb [CST-5303] refactoring of ADS & EPO services 2022-05-11 13:33:06 +02:00
Luca Giamminonni
a71ee59bba [CST-5288] Removed version check on InfoEndpointIT 2022-05-11 12:04:25 +02:00
Luca Giamminonni
223ba1b440 Merge branch 'CST-5587' into CST-5799 2022-05-11 11:04:02 +02:00
Luca Giamminonni
bb60c7d200 Merge branch 'CST-5669' into CST-5587 2022-05-11 11:02:32 +02:00
Luca Giamminonni
d6f34bcf90 Merge branch 'CST-5306' into CST-5669 2022-05-11 11:00:32 +02:00
Luca Giamminonni
6a10980f51 Merge remote-tracking branch '4science-bitbucket/main' into CST-5288 2022-05-11 10:55:42 +02:00
Luca Giamminonni
332a4ae3bd Merge remote-tracking branch '4science-bitbucket/main' into CST-5306 2022-05-11 10:53:46 +02:00
Mykhaylo
5101173abd Merge branch 'main' into CST-5303-live-import-4PR 2022-05-11 09:42:11 +02:00
Mykhaylo
102a4a51b8 Merge branch 'main' into CST-5303-LiveImport-3PR 2022-05-10 18:50:39 +02:00
Mykhaylo
851ba184f7 [CST-5303] Implement community feedbacks for Scielo provider 2022-05-10 18:46:44 +02:00
Bruno Roemers
97fdc3477c Merge branch 'feature-relationship-versioning__discovery__bug-in-workspaceItemService' into feature-relationship-versioning__discovery 2022-05-10 17:42:48 +02:00
Tim Donohue
f6ea75b4c3 Merge pull request #8175 from the-library-code/TLC-254_type_bind_d72
Type-bind for submission input (port from DSpace-CRIS 7)
2022-05-10 10:05:01 -05:00
Tim Donohue
f676f951fe Merge pull request #8247 from nibou230/access-status
Basic implementation for the access status badges
2022-05-10 10:00:34 -05:00
Mykhaylo
3f01c4bc1c Merge branch 'main' into CST-5303-LiveImport-3PR 2022-05-10 16:24:45 +02:00
Mykhaylo
149393b06d [CST-5303] refactored tests 2022-05-10 16:16:16 +02:00
Luca Giamminonni
d669ecba6b [CST-5669] Fix tests 2022-05-10 12:59:52 +02:00
Mykhaylo
78a36136e2 fix failed test 2022-05-10 12:33:27 +02:00
Mykhaylo
c490f28c4d [CST-5303] refactored crossref & vufind json processors 2022-05-10 10:50:59 +02:00
Bruno Roemers
09872a7491 Merge branch 'feature-relationship-versioning__discovery__bug-in-workspaceItemService' into feature-relationship-versioning__discovery 2022-05-09 18:08:47 +02:00
Bruno Roemers
bbaf433c78 90945: Test all *-relationships discovery configs 2022-05-09 17:59:20 +02:00
Bruno Roemers
3b30bec14f 90945: Add tests for *-relationships discovery configs
Copy-pasted the existing tests as baseline
2022-05-09 17:26:25 +02:00
Bruno Roemers
ea712fa175 90945: Remove latestVersion:true from *-relationships discovery configs 2022-05-09 17:18:44 +02:00
Bruno Roemers
f24671dd59 90945: Add *-relationships discovery configs
Copy-pasted the existing discovery configs as baseline
2022-05-09 17:11:32 +02:00
Bruno Roemers
f36d0377ce 90945: Fix MetadataImportIT 2022-05-09 16:45:04 +02:00
Luca Giamminonni
7b49fbe661 [CST-5288] Info endpoint improvements 2022-05-09 16:22:39 +02:00
Bruno Roemers
e2e31446f4 90945: Attempt to fix tests 2022-05-09 15:47:03 +02:00
Luca Giamminonni
fe181398d0 Merge remote-tracking branch '4science-bitbucket/main' into CST-5288 2022-05-09 15:17:40 +02:00
Luca Giamminonni
a19d31da67 [CST-5669] Minor changes 2022-05-09 13:41:03 +02:00
Bruno Roemers
e072ab2920 90945: Prevent (re)adding collection entity type during new version creation 2022-05-09 12:14:53 +02:00
Bruno Roemers
6b925723ad 90945: Prove collection entity type is (re)added during new version creation 2022-05-09 12:13:03 +02:00
Bruno Roemers
8448fcf062 90945: Fix dspace.entity.type = <blank> on new items 2022-05-09 11:39:28 +02:00
Bruno Roemers
d39f4ae83f 90945: Prove that empty dspace.entity.type is stored on new items
I observed that whenever a collection is created via the GUI in DSpace,
it has dspace.entity.type = <blank> as metadata value.
That metadata value is copied to all new items in the collection.
An empty dspace.entity.type metadata value on an item does not make sense.
2022-05-09 11:34:17 +02:00
Mykhaylo
160a726505 refactoring of crossref & vufind json contributors 2022-05-06 18:50:14 +02:00
Mykhaylo
7e5c706748 removed json-smart dependency 2022-05-06 18:47:52 +02:00
Tim Donohue
8f515c7b1f Merge pull request #8284 from alanorth/port-DS-4271-to-7x
DS-4271: Replace brackets with double quotes in SolrServiceImpl
2022-05-06 11:45:16 -05:00
Tim Donohue
60f3de0a00 Merge pull request #8283 from mwoodiupui/8278
Add documentation to request_item.author email template; remove unused templates
2022-05-06 11:21:49 -05:00
Luca Giamminonni
92e8a2fb25 [CST-5669] Fixed orcid page 2022-05-06 16:50:44 +02:00
Bruno Roemers
fde932a853 90945: Index latestVersion as boolean (solr) 2022-05-06 16:22:57 +02:00
Luca Giamminonni
d3146da1a3 [CST-5587] Fixed tests 2022-05-06 15:56:58 +02:00
Bruno Roemers
75f426b6e6 90945: Index older versions of items 2022-05-06 14:48:31 +02:00
Bruno Roemers
5e3523fc77 90945: Fix tests 2022-05-06 13:27:34 +02:00
Luca Giamminonni
69bb9501b6 [CST-5587] Improved orcid queue consumer 2022-05-06 12:36:43 +02:00
Luca Giamminonni
c8dceefaea [CST-5306] Disable researcher profile by default 2022-05-06 11:17:52 +02:00
Kim Shepherd
1abf906db8 [TLC-254] Make type bind config dynamic, fix test comments 2022-05-06 15:43:15 +12:00
nibou230
e9b61f327c Renamed the access status Builder to Helper 2022-05-05 15:05:38 -04:00
nibou230
34350dd468 Add the PreAuthorize attribute to getAccessStatus 2022-05-05 14:00:45 -04:00
Luca Giamminonni
3228c6a3c2 [CST-5306] Removed ShowClaimItemFeature, added EPersonAuthorityIT tests, improved researcher profile's collection search 2022-05-05 17:47:37 +02:00
Yura Bondarenko
78c57a110d Fix exception message i18n key mismatch 2022-05-05 16:48:30 +02:00
Mark H. Wood
2fdc8d66ab Merge branch 'main' into DS-4300 to correct merge conflicts. 2022-05-05 09:54:38 -04:00
Mykhaylo
333b41cc0e Merge branch 'main' into CST-5303-LiveImport-2PR 2022-05-05 12:46:37 +02:00
Mykhaylo
8027d6e8a5 Merge branch 'main' into CST-5303-live-import 2022-05-05 11:54:25 +02:00
emanuele
971977c668 CST-5673 checkstyle fix 2022-05-05 11:37:26 +02:00
Bruno Roemers
55b38656bb 90945: WIP: Prove that old versions don't appear in solr (before changes) and don't appear in discovery 2022-05-05 11:34:22 +02:00
Alan Orth
a585b16b1a dspace-api: Replace brackets with double quotes in SolrServiceImpl
Port of GitHub PR #2543 from DSpace 6.x to DSpace 7.x, originally
by @jonas-atmire.

Resolves DS-4271 (GitHub Issue #7611).
2022-05-05 10:06:14 +03:00
Mark H. Wood
e724ea2602 Add documentation to request_item.author email template; remove unused templates. 2022-05-04 13:07:38 -04:00
emanuele
101e854fee CST-5673 implemented patch operation and ITs for action and policyType attributes 2022-05-04 17:27:17 +02:00
Mykhaylo
9de1ecd058 [CST-5673] implemented controller to allow patching of eperson/group on resourcepolicy 2022-05-04 15:51:17 +02:00
Mykhaylo
630c53e8f3 [CST-5673] added tests for eperson/group replace of resourcepolicy 2022-05-04 15:48:50 +02:00
Bruno Roemers
d119d842f8 Merge branch 'main' into feature-relationship-versioning-contribution 2022-05-04 11:46:28 +02:00
Kim Shepherd
78e187e6a8 [TLC-254] Expose type bind field config with REST 2022-05-04 15:26:32 +12:00
Luca Giamminonni
3b64e1761f [CST-5306] Improvements 2022-05-03 16:33:38 +02:00
benbosman
9e654f7635 Merge pull request #195 from atmire/feature-relationship-versioning
Feature relationship versioning
2022-05-03 12:37:04 +02:00
Bruno Roemers
57ff9639f3 90902: Finish test_placeRecalculationAfterDelete_complex 2022-05-03 12:00:15 +02:00
Luca Giamminonni
ba6fab1f88 [CST-5288] Added admin security check on info endpoint 2022-05-02 19:01:36 +02:00
Luca Giamminonni
3ce8838e00 [CST-5288] Fix actuators issues 2022-05-02 18:38:34 +02:00
Bruno Roemers
312eddbfdc 90902: WIP: Write test test_placeRecalculationAfterDelete_complex 2022-05-02 18:13:48 +02:00
Mykhaylo
7d3b646110 [CST-5303] refactored and added JavaDoc to CrossRef and VuFind services 2022-05-02 17:03:47 +02:00
Bruno Roemers
786ca5d617 90902: Bump Apache Commons Lang3 from version 3.7 to 3.12.0
This makes available new interfaces such as FailableConsumer, etc.
2022-05-02 16:18:15 +02:00
Kristof De Langhe
ffaa7ded6f Merge branch 'w2p-90830_issue-8125_Import-items-stale-in-discovery_7.0' into w2p-90830_issue-8125_Import-items-stale-in-discovery 2022-05-02 15:54:53 +02:00
Kristof De Langhe
36d6087860 90830: test scripts config fix 2022-05-02 14:36:31 +02:00
Kristof De Langhe
5c82443930 Merge branch 'w2p-90830_issue-8125_Import-items-stale-in-discovery_7.0' into w2p-90830_issue-8125_Import-items-stale-in-discovery 2022-05-02 13:56:15 +02:00
Kristof De Langhe
baf715aa1c 90830: predb solr status test cases 2022-05-02 13:55:48 +02:00
Giuseppe Digilio
9841c576c8 [CST-5288] Fix issue after alignment with main branch 2022-05-02 12:06:36 +02:00
Giuseppe Digilio
c27df5320b Merge branch 'main' into CST-5288 2022-05-02 11:50:51 +02:00
Andrea Bollini
3724c2c341 Fix ContextTest as special groups are now unordered set 2022-04-29 22:13:33 +02:00
Tim Donohue
a235551fab Merge pull request #8259 from tdonohue/update_outdated_dependencies
Remove Google Gson, replacing with Jackson Databind.  Upgrade Jackson Databind
2022-04-29 14:09:42 -05:00
Andrea Bollini
3e33fa6b22 Fix checkstyle, double list of some special groups 2022-04-29 20:07:51 +02:00
Tim Donohue
a1b6bcc427 More null safety checks to avoid any NPEs 2022-04-29 12:34:34 -05:00
Tim Donohue
d49f69d28c Merge pull request #8245 from 4Science/CST-5718
IIIF manifest and canvas cache eviction is asynchronous and could led to unexpected responses
2022-04-29 12:03:34 -05:00
Tim Donohue
dcec76eff0 Merge pull request #8260 from toniprieto/cc-section-not-loading
Fix Creative Commons step not loading
2022-04-29 11:39:06 -05:00
Andrea Bollini
ebc7304a53 Fix special groups link implementation 2022-04-29 18:21:44 +02:00
Tim Donohue
4b2c259f5d Merge pull request #8269 from tdonohue/use_saxon
Revert changes to OAI-PMH TransformerFactory initialization. It MUST use Saxon
2022-04-29 11:08:30 -05:00
Bruno Roemers
d17fd6456a 90902: Found and fixed bug in test_placeRecalculationAfterDelete 2022-04-29 16:03:16 +02:00
Mykhaylo
681b56f30c [CST-5269] move iiif cache loggers into dspace-api progect 2022-04-29 12:35:59 +02:00
Luca Giamminonni
adff85732a [CST-5799] Fixed ExternalSourcesRestControllerIT test 2022-04-29 12:04:09 +02:00
Luca Giamminonni
54bb303ed3 Merge branch 'CST-5587' into CST-5799 2022-04-29 12:03:04 +02:00
Luca Giamminonni
c292361d58 [CST-5587] Fixed SubmissionFormsControllerIT tests 2022-04-29 12:02:38 +02:00
Mykhaylo
8c60342ad9 [CST-5269] put together sherpa and iiif cache config 2022-04-29 11:47:03 +02:00
Luca Giamminonni
a7a49c81c6 [CST-5669] Fixed ResearcherProfileRestRepositoryIT tests 2022-04-29 11:15:21 +02:00
Mykhaylo
154eaed262 [CST-5269] fix checkstyle 2022-04-29 10:39:02 +02:00
Jurgen Mamani
7dc4aaa0d4 [CST-5755] Refactoring 2022-04-29 10:30:19 +02:00
Yura Bondarenko
c00cdd4d0d 90948: Add custom exception for deleting Group with pending tasks 2022-04-29 10:00:56 +02:00
Andrea Bollini
3777bfc14b Add some javadoc 2022-04-29 09:47:07 +02:00
Andrea Bollini
77e4306938 Remove unnecessary changes 2022-04-29 09:46:21 +02:00
Andrea Bollini
42f86a7b3e Cleanup logging dependencies 2022-04-29 09:31:44 +02:00
Andrea Bollini
53105792b0 Merge branch 'main' of https://github.com/DSpace/DSpace into CST-5269-Sherpa-Romeo 2022-04-29 09:04:11 +02:00
Jurgen Mamani
9b14fe59bd [CST-5755] Renamed db scripts 2022-04-29 08:59:28 +02:00
Tim Donohue
93bba45f80 Revert changes to OAI-PMH TransformerFactory initialization. MUST use Saxon 2022-04-28 16:30:26 -05:00
Tim Donohue
6dbb2e7690 Add null checks to avoid any NPEs 2022-04-28 14:05:05 -05:00
Tim Donohue
9edccd8abf Merge pull request #8258 from tdonohue/xml_parsing_cleanup
Remove Xalan & Xerces as direct dependencies of dspace-api
2022-04-28 13:46:29 -05:00
emanuele
f83fbc4921 CST-5736 LinkRepository bugfix 2022-04-28 19:02:56 +02:00
Mykhaylo
a1117bbbf1 [CST-5269] added tests for sherpa policy submission section 2022-04-28 18:13:54 +02:00
Tim Donohue
a5627b7ba9 Merge pull request #8264 from kshepherd/version-builder-log4j
log4j v1 -> v2 for VersionBuilder
2022-04-28 11:10:42 -05:00
Luca Giamminonni
58694eaed8 [CST-5669] Fixed compilation issue 2022-04-28 17:24:38 +02:00
emanuele
72c1248be6 CST-5736 removed comments 2022-04-28 16:12:11 +02:00
emanuele
c947a689ac CST-5736 AuthenticationRestController refactoring 2022-04-28 16:09:11 +02:00
Luca Giamminonni
424bdf8348 [CST-5799] Porting of OrcidPublicationDataProvider 2022-04-28 15:57:13 +02:00
Jurgen Mamani
416c2dd56a [CST-5755] Ported tests for process 2022-04-28 15:15:46 +02:00
Jurgen Mamani
e4a4b913b9 [CST-5755] Ported process special group tracking 2022-04-28 14:17:15 +02:00
Mykhaylo
f51cf97f8b [CST-5269] fix failed tests 2022-04-28 13:41:33 +02:00
Luca Giamminonni
d6b66c95f0 [CST-5587] Fixed orcid tests 2022-04-28 12:26:12 +02:00
Marie Verdonck
5d8aa354ea 90830: issue 8125 - fixes after merge main 2022-04-28 12:10:04 +02:00
Marie Verdonck
bdc59583fa Merge branch 'main' into w2p-90830_issue-8125_Import-items-stale-in-discovery
# Conflicts:
#	dspace/config/spring/api/scripts.xml
2022-04-28 12:09:08 +02:00
Marie Verdonck
77fee75304 90830: issue 8125 - add status to all newly added items 2022-04-28 12:06:30 +02:00
Mykhaylo
5743ebaf84 [CST-5269] refactored sherpa policy step 2022-04-28 10:46:01 +02:00
Kim Shepherd
eca7d1e08d log4j v1 -> v2 for VersionBuilder 2022-04-28 08:24:44 +12:00
Luca Giamminonni
535b36be97 [CST-5587] Fixed orcid queue tests 2022-04-27 18:43:14 +02:00
Luca Giamminonni
50274d31c9 [CST-5587] Fixed PlainMetadataSignatureGeneratorIT tests 2022-04-27 17:23:01 +02:00
Luca Giamminonni
5b4130fbc7 [CST-5587] Orcid queue and history migration 2022-04-27 16:55:46 +02:00
Bruno Roemers
e9596cfff8 90881: Fix test test_placeRecalculationNoUseForPlace 2022-04-27 14:32:23 +02:00
emanuele
467d372b9e CST-5736 added /status/specialGroups method and test 2022-04-27 13:11:49 +02:00
Luca Giamminonni
e726cc459f Merge branch 'CST-5669' into CST-5588 2022-04-27 11:48:52 +02:00
Luca Giamminonni
949dd0d0d8 Merge branch 'CST-5306' into CST-5669 2022-04-27 11:38:37 +02:00
Kim Shepherd
de9455f6d8 [TLC-254] Obtain context properly in MetadataValidation 2022-04-27 19:15:26 +12:00
Kim Shepherd
53b4415408 [TLC-254] Update type bind ITs to reflect validation changes 2022-04-27 16:20:55 +12:00
Kim Shepherd
06e119c974 [TLC-254] Use of context for just narrow type bind cases 2022-04-27 16:20:26 +12:00
Kim Shepherd
892464971a [TLC-254] fix accidental codestyle violation in new import 2022-04-27 14:49:09 +12:00
Kim Shepherd
0adf10751c [TLC-254] fix accidental codestyle violation in new import 2022-04-27 14:33:35 +12:00
Kim Shepherd
655524301e [TLC-254] Remove old type-bound values from workspace items at deposit
This is also done at DescrbeStep getData() but if an item was saved
while it had a valid type for the given field, the validation method
also needs to remove it from the workspace item.
2022-04-27 14:11:35 +12:00
Tim Donohue
ba8af538b8 Address feedback in WordHighlightSolrSearch 2022-04-26 16:07:47 -05:00
Kim Shepherd
0adcd94ea9 [TLC-254] Add ITs to ensure values for non-bound types don't persist 2022-04-26 14:13:29 +12:00
Kim Shepherd
0572f94d77 [TLC-254] Simplify validation test skip 2022-04-26 11:18:04 +12:00
Kim Shepherd
1cb03c0063 [TLC-254] If type bind doesn't allow a field, remove from data 2022-04-26 11:17:40 +12:00
Kim Shepherd
0d43fb4a8d [TLC-254] Fix typeBind JSON path test and add opposite test 2022-04-26 11:16:55 +12:00
Kim Shepherd
fd535c34f4 [TLC-254] Fix typeBind JSON path test 2022-04-25 16:54:37 +12:00
Kim Shepherd
160c3c072c [TLC-254] Rebase main (merges to MetadataValidation) 2022-04-25 15:41:01 +12:00
Kim Shepherd
9d0b5cde14 [TLC-254] Rebase main (merges to MetadataValidation) 2022-04-25 15:40:12 +12:00
Kim Shepherd
71b7fa19f4 [TLC-254] Integration test (including changing matcher methods) for type bind 2022-04-25 15:40:12 +12:00
Kim Shepherd
5de4e803e1 [TLC-254] Make item type field configurable for type bind (default dc.type) 2022-04-25 15:40:12 +12:00
Kim Shepherd
ac4bf5d618 [TLC-254] Rebase to main (merge metadatavalidation) 2022-04-25 15:39:52 +12:00
Mykhaylo
a4b07a9f0a [CST-5303] added JavaDocs 2022-04-22 18:28:13 +02:00
Luca Giamminonni
effc9547f1 [CST-5306] Fixed eperson_claims discovery configuration 2022-04-22 16:04:04 +02:00
Luca Giamminonni
3cd3cd9a70 [CST-5306] Added eperson_claims discovery configuration to find all claimable profiles 2022-04-22 15:53:54 +02:00
Luca Giamminonni
131455f757 [CST-5306] Expose researcher-profile.entity-type 2022-04-22 15:29:21 +02:00
Mykhaylo
347561afeb [CST-5269] refactored sherpaPolicy step 2022-04-22 14:47:34 +02:00
Luca Giamminonni
ee6cf3d60c [CST-5306] Improvements on ResearcherProfileRestRepository 2022-04-22 14:32:20 +02:00
Mykhaylo
31bd3861d2 [CST-5269] fix failed test 2022-04-22 12:47:38 +02:00
Luca Giamminonni
626775347b Merge remote-tracking branch '4science-bitbucket/main' into CST-5306 2022-04-22 10:10:09 +02:00
Luca Giamminonni
cb4152566e Merge branch 'main' into CST-5306 2022-04-22 10:06:54 +02:00
Tim Donohue
365827ce92 Merge pull request #8257 from 4Science/CST-5760
License validator enabled
2022-04-21 16:39:56 -05:00
Mykhaylo
a1d619979e [CST-5269] configured sherpa service in submission 2022-04-21 22:24:46 +02:00
Mykhaylo
2dedb4014b [CST-5303] added JavaDoc and minor refactoring 2022-04-21 22:02:54 +02:00
nibou230
845a552911 Fix for calls from the administration (workflow) 2022-04-21 14:45:14 -04:00
nibou230
3de5886ba9 Fix in case the group can't be retrieved 2022-04-21 14:45:13 -04:00
nibou230
0fd11c0e51 Fixes integration tests 2022-04-21 14:45:13 -04:00
nibou230
daa0617384 Moved the status endpoint to a LinkRepository 2022-04-21 14:45:13 -04:00
nibou230
8bb23ab9ef Fixes the LGTM alerts. 2022-04-21 14:45:13 -04:00
nibou230
785a4d6ed8 Basic implementation for the access status badges 2022-04-21 14:45:13 -04:00
Bruno Roemers
5e5e99b446 88599: Add extra javadocs 2022-04-21 15:40:26 +02:00
Tim Donohue
3253e6dd7b Stop forcing specific TransformerFactory implementation. 2022-04-20 13:21:35 -05:00
Tim Donohue
db1f8061d7 Remove Xalan direct dependency. Migrate code to Javax.xml.xpath parsing tools 2022-04-20 12:34:29 -05:00
Corrado Lombardi
fd99c86430 [CST-5760] updated test items with license granted 2022-04-20 16:55:10 +02:00
Toni Prieto
b2a3ef60cf Fix test for CCLicense operations. The cclicense section should exist but with all properties set to null 2022-04-20 16:21:53 +02:00
Toni Prieto
22ac0d9950 Fix nullpointerexception converting CC RDF bitstream 2022-04-20 16:20:45 +02:00
Tim Donohue
a9edca7f55 Merge pull request #8240 from tdonohue/fix_8239
Fix PATCH of resource policy end date when start date is null
2022-04-20 09:05:10 -05:00
Corrado Lombardi
b5b7206288 [CST-5760] typo fix 2022-04-20 15:28:57 +02:00
Corrado Lombardi
9843b72a86 [CST-5760] LicenseValidation bean instrumented so that license is validated during submission, tests expectations updated accordingly 2022-04-20 15:09:27 +02:00
Corrado Lombardi
50bb8456ea [CST-5760] validate method instance returns its own list of errors, having them in a field might lead to pre-populated lists returning wrong information 2022-04-20 15:06:55 +02:00
Kristof De Langhe
238aead2bd 90830: Checkstyle fixes 2022-04-20 13:50:38 +02:00
Kristof De Langhe
80158aadfe 90830: Issue 8125: Import items stale in discovery 2022-04-20 13:21:35 +02:00
Tim Donohue
564cc25a8b Merge pull request #8252 from atmire/w2p-90263_issue-8205_no-embargoed-files-on-google-scholar-meta-tag
IT demonstrating REST doesn't include Google Scholar Meta Tag citation_pdf_url for embargoed files
2022-04-19 17:12:25 -05:00
Tim Donohue
21c855882a Upgrade Jackson and Jackson-Databind 2022-04-19 16:30:36 -05:00
Marie Verdonck
9abb132271 Merge branch 'main' into w2p-90263_issue-8205_no-embargoed-files-on-google-scholar-meta-tag 2022-04-19 23:02:52 +02:00
Tim Donohue
11faeefe95 Remove Gson, replacing with Jackson. Remove unused DataTermsFacet & unused code in WordHighlightSolrSearch 2022-04-19 16:00:01 -05:00
Tim Donohue
248c175063 Merge pull request #2631 from mwoodiupui/DS-4410
[DS-4410] New email template sent to a newly-registered user.
2022-04-19 13:06:30 -05:00
Kristof De Langhe
0ae13fe0fb 90830: Issue 8125: Import items stale in discovery - intermediate commit 2022-04-19 17:45:59 +02:00
Ben Bosman
6308f5b488 Creating test_placeRecalculationNoUseForPlace (has bug in code) 2022-04-19 16:37:02 +02:00
Ben Bosman
dfa036ff8c Adding support for max cardinality
Fixing test_placeRecalculationAfterDelete
Creating test_placeRecalculationNoUseForPlace (WIP)
2022-04-19 15:12:10 +02:00
Ben Bosman
753350958c Adding support for max cardinality
Fixing test_placeRecalculationAfterDelete (WIP)
2022-04-19 14:34:23 +02:00
Ben Bosman
40b8f63ca7 Disabling incorrect test until it's determined what it should actually do 2022-04-19 12:21:45 +02:00
Tim Donohue
3a96e64d17 Merge pull request #8207 from atmire/w2p-88141_scripts-and-processes-bug-7992
Fix Scripts and Processes bug #7992
2022-04-13 11:18:57 -05:00
Tim Donohue
f8f31cb73a Merge pull request #8194 from atmire/issue-8140_create-citation-page-once_main
IT for file download so IS is closed & refactor file download with citation/cover page
2022-04-13 11:18:11 -05:00
eskander
1c5e89d4a4 [CST-5588] ORCID settings (REST) . 2022-04-13 13:30:07 +02:00
Bruno Roemers
4ec934f4ce 88675: WIP: Test relation.isAuthorOfPublication 2022-04-12 18:50:48 +02:00
Corrado Lombardi
fbf0b33076 [DSC-557] evictAllValues invalidates cache 2022-04-12 17:30:36 +02:00
Corrado Lombardi
1a4c0428e1 used evictIfPresent to guarantee immediate cache eviction effect 2022-04-12 17:29:24 +02:00
Bruno Roemers
c4bb77d1e4 88675: Fix NPE 2022-04-12 15:36:49 +02:00
Bruno Roemers
a9025d68bf 88675: Fix checkstyle issues 2022-04-12 14:40:26 +02:00
eskander
035940018f [CST-5669] ORCID Authorizations (REST) . 2022-04-12 11:06:59 +02:00
Marie Verdonck
2408aa9fc4 90263: Issue 8205: Test to check GoogleMetadata contains no citation_pdf_url for embargoed files 2022-04-11 17:07:27 +02:00
Mykhaylo
da0a23519d Merge branch 'main' into CST-5340-OpenAIREFundingDataProvider 2022-04-11 14:58:28 +02:00
Mykhaylo
13b147a691 [CST-5340] refactored OpenAIREFundingData provider 2022-04-11 14:53:35 +02:00
Bruno Roemers
91aca5dc25 88675: Finish test test_virtualMetadataPreserved 2022-04-08 19:27:45 +02:00
Tim Donohue
527f5eea2a Add test for replace EndDate. Fix typos in other test method names 2022-04-08 12:15:32 -05:00
Luca Giamminonni
afa86658c9 [CST-5669] Migrated OrcidRestController 2022-04-08 18:27:00 +02:00
Luca Giamminonni
3b153db00c [CST-5308] Migrate OrcidAuthenticationBean 2022-04-08 18:23:23 +02:00
Bruno Roemers
611f5a8fa3 88675: Use static imports for LatestVersionStatus 2022-04-08 17:43:25 +02:00
Tim Donohue
d17141442d Merge pull request #8215 from tdonohue/update_spring_dependencies
Upgrade Spring Dependences & HAL Browser
2022-04-08 10:38:17 -05:00
Bruno Roemers
fea034d4c9 88599: Set virtual metadata "useForPlace = true" for test_placeRecalculationAfterDelete 2022-04-08 17:12:15 +02:00
Bruno Roemers
44a491993d 88599: WIP: Write test_placeRecalculationAfterDelete 2022-04-08 16:30:13 +02:00
Yana De Pauw
aa62178f95 Fix checkstyle issue 2022-04-08 15:10:31 +03:00
Yana De Pauw
6c1c2915c3 88141: Fix issue with the mock script test 2022-04-08 14:24:01 +03:00
Yana De Pauw
e7cc945f92 88141: Update script converter comment and clean up setType(boolean) 2022-04-08 11:46:07 +03:00
Bruno Roemers
ef87d0cbf5 88599: BUGFIX: Opposite side needs to be latest in order to set own side to non-latest
Otherwise an error occurs
2022-04-08 01:12:11 +02:00
Bruno Roemers
b9c1f90ab8 88599: BUGFIX: Compare relationship types by id 2022-04-08 00:40:39 +02:00
Bruno Roemers
f0a2c37011 88599: Move utils to RelationshipVersioningUtils class 2022-04-08 00:25:26 +02:00
Luca Giamminonni
55106c2351 [CST-5288] Added Order to the VersionInfoContributor 2022-04-07 19:13:26 +02:00
Luca Giamminonni
89f2a61f5a [CST-5288] Moved all spring boot actuator configurations in actuator.cfg 2022-04-07 19:05:15 +02:00
Ben Bosman
2f56bca9b9 Verifying failing test 2022-04-07 11:17:33 +02:00
Tim Donohue
6a37400c97 Fix typo. Should check if StartDate not null 2022-04-06 13:58:53 -05:00
Tim Donohue
7d8ec90c42 Merge pull request #8210 from atmire/browse-by-prefix-filter
Items browse prefix filter
2022-04-06 12:15:52 -05:00
Ben Bosman
805394ee85 Extra docs
Test with multiple relationships
2022-04-06 18:46:51 +02:00
Mykhaylo
b5af1177a2 [CST-5303] fix failed tests 2022-04-06 12:44:33 +02:00
Mykhaylo
ee5078f93e [CST-5303] refactoring of wos live import 2022-04-06 12:22:27 +02:00
Antoine Snyers
67c3ca20bc Remove commented code 2022-04-06 10:51:52 +02:00
Mykhaylo
7b7f3a0d30 [CST-5303] fix logging for Epo 2022-04-06 10:50:25 +02:00
Mykhaylo
1ceae4f389 [CST-5303] added dependency to extract metadata from Json response 2022-04-06 10:40:07 +02:00
Mykhaylo
97b8a4c727 [CST-5303] fix logging 2022-04-06 10:36:27 +02:00
Mykhaylo
76d2703720 [CST-5303] added dependency to extract metadata from Json response 2022-04-06 10:35:50 +02:00
Mykhaylo
1a40d1f460 Merge branch 'main' into CST-5303-LiveImport-2PR 2022-04-06 10:03:47 +02:00
Mykhaylo
e2fac38146 [CST-5303] added tests for vuFind live import service 2022-04-06 10:00:06 +02:00
Mykhaylo
61287b9e83 [CST-5303] fix access url 2022-04-06 09:59:09 +02:00
Mykhaylo
491ed1c3a4 [CST-5303] fix logging 2022-04-06 02:38:04 +02:00
Mykhaylo
3a91f035f6 Merge branch 'main' into CST-5303-live-import-4PR 2022-04-06 02:35:52 +02:00
Mykhaylo
3456138e85 [CST-5303] fix logging 2022-04-06 02:33:41 +02:00
Mykhaylo
988a8c9335 [CST-5303] fix logging 2022-04-06 02:23:48 +02:00
Mykhaylo
761831403f Merge branch 'main' into CST-5303-LiveImport-3PR 2022-04-06 02:03:44 +02:00
Mykhaylo
8bc4997bf5 Merge branch 'main' into CST-5303-live-import 2022-04-06 02:00:38 +02:00
Mykhaylo
c40339e113 [CST-5303] added tests for epo and ads live import services 2022-04-06 01:49:22 +02:00
Mykhaylo
cee8601c86 [CST-5303] porting of ads and epo live import services 2022-04-06 01:48:24 +02:00
Bruno Roemers
5755ebc3e2 88599: WIP: Write test test_placeRecalculationAfterDelete 2022-04-05 20:20:39 +02:00
Antoine Snyers
3ee7ff139d Remove commented code 2022-04-05 10:56:05 +02:00
Tim Donohue
af168718c6 Cleanup depedencies in dspace-rest after rebase to fix deprecated REST API issues 2022-04-04 17:18:26 -05:00
Tim Donohue
5663698ef1 Minor cleanup after rebase 2022-04-04 17:18:17 -05:00
Tim Donohue
4dc1767074 Update to latest version of Spring & Spring Boot 2022-04-04 17:18:17 -05:00
Tim Donohue
0ac74f2e1d Pull in jsoneditor.js via WebJars as well. Remove from codebase 2022-04-04 17:18:17 -05:00
Tim Donohue
2ac1f982d2 Upgrade Hal Browser dependencies / vendor libraries to latest versions 2022-04-04 17:18:17 -05:00
Tim Donohue
cfa9f01a47 Upgrade Hal Browser to Bootstrap 4 based on https://github.com/mikekelly/hal-browser/pull/102 . Also add CustomPostForm script from Spring Data REST v3.3.x 2022-04-04 17:18:17 -05:00
Tim Donohue
92687252ce Remove unnecessary config / annotation after Spring upgrades 2022-04-04 17:18:17 -05:00
Tim Donohue
7a11d0d605 Replace Spring Data REST HAL Browser with HAL Browser from WebJars 2022-04-04 17:18:17 -05:00
Tim Donohue
54f2c5c661 Minor updates to Spring dependencies 2022-04-04 17:18:17 -05:00
Tim Donohue
88cea74e43 Fix test by ensuring InputStream is closed immediately after usage. Refactor try/finally to support that. 2022-04-04 17:18:17 -05:00
Tim Donohue
51591047d2 All multipart/form-data ITs should use multipart(), not post() or fileUpload() 2022-04-04 11:32:09 -05:00
Tim Donohue
0311aeb45c Ensure files are not required for scripts endpoint. Tests already prove they are not required, but not set that way in controller. 2022-04-04 11:32:09 -05:00
Tim Donohue
9e25e1d43e Remove duplicative slash "/" in RequestMapping which caused test failures 2022-04-04 11:32:09 -05:00
Tim Donohue
5ea14a8637 Add missing UTF-8 charset to tests 2022-04-04 11:32:09 -05:00
Tim Donohue
7d396434c2 Fix UTF-8 encoding issues in Spring Boot by updating config names 2022-04-04 11:32:09 -05:00
Tim Donohue
24f674d92b Minor fix to test. ContentType now includes charset. 2022-04-04 11:32:09 -05:00
Tim Donohue
d8e4a569d6 Fix circular reference errors in beans. Use @Lazy annotation for beans which must be loaded later / on first use. 2022-04-04 11:32:09 -05:00
Tim Donohue
3a01dbe0a2 Upgrade to latest Spring Boot, Solr & Postgres. Minor code fixes/dependency updates to get everything to compile 2022-04-04 11:32:04 -05:00
Tim Donohue
9fbde47cf6 Merge pull request #8227 from tdonohue/use_tika
Migrate from POI to Tika for Text Extraction. Remove unused Solr-Cell
2022-04-04 11:09:13 -05:00
Tim Donohue
b5876852d9 Resolve feedback. Ensure errors are re-thrown & fix comment. 2022-04-04 10:28:04 -05:00
Tim Donohue
9ef561a5d0 Switch to System.err.format & correct spacing in error messages. 2022-04-04 10:19:35 -05:00
Tim Donohue
476fe7220d Minor fix to BitstreamFormatRestRepositoryIT after adding new format (CSV) 2022-04-04 10:19:35 -05:00
Tim Donohue
f02d8ab04a Add test files for major text-based formats & test to verify all are indexable. Also add CSV to list of formats & include it. 2022-04-04 10:19:35 -05:00
Tim Donohue
e9e4cdbaac Fix dependencies in overlay modules so that example ITs pass 2022-04-04 10:19:35 -05:00
Tim Donohue
b86adf35e2 Remove duplicative dependency. This was in POM twice. 2022-04-04 10:19:35 -05:00
Tim Donohue
508883bec8 Replace format specific POI filters with TikaTextExtractionFilter 2022-04-04 10:19:35 -05:00
Tim Donohue
a0438e51ad Remove old version of XMLBeans. We don't use it directly and Tika brings in a new version 2022-04-04 10:19:35 -05:00
Tim Donohue
e49a1d86af Fix compilation issues. Old log4j v1 update to v2 2022-04-04 10:19:35 -05:00
Tim Donohue
b894071c16 Switch to SolrJ & Solr-Core. We don't actually use Solr-Cell. Upgrade Tika dependencies 2022-04-04 10:19:35 -05:00
Tim Donohue
84ffe9db9e Upgrade Apache POI 2022-04-04 10:19:35 -05:00
Tim Donohue
c7a8e1b3b5 Update to latest Solr to prove it doesn't break SWORDv2 2022-04-04 10:19:34 -05:00
Tim Donohue
cde5101e53 Merge pull request #8195 from tdonohue/upgrade_h2
Upgrade H2, Hibernate and Flyway
2022-04-04 09:38:36 -05:00
Mykhaylo
f5a1f2f9d8 [CST-5303] added tests for cinii live import service 2022-04-04 16:20:06 +02:00
Mykhaylo
6cecbbcdb9 [CST-5303] porting of cinii live import service 2022-04-04 16:19:56 +02:00
Mykhaylo
a829cb9fec [CST-5303] fix failed test 2022-04-04 16:19:47 +02:00
Mykhaylo
9cde585afc [CST-5303] porting of wos 2022-04-04 16:19:35 +02:00
Mykhaylo
d2f62939f8 [CST-5303] added test for pubmedeurope 2022-04-04 16:18:47 +02:00
Mykhaylo
55faacb168 [CST-5303] porting pubmed live import 2022-04-04 16:18:39 +02:00
Mykhaylo
bebe3d7bfe [CST-5303] fix tests 2022-04-04 16:18:28 +02:00
Mykhaylo
9bca9e21e1 [CST-5303] added tests for scopus live import service 2022-04-04 16:18:13 +02:00
Mykhaylo
d60567617b [CST-5303] porting of scopus live import services 2022-04-04 16:11:20 +02:00
Mykhaylo
2bb9883b88 [CST-5303] implemented http live import client 2022-04-04 16:09:17 +02:00
eskander
fb31905ed5 [CST-5534] canSynchronizeWithORCID Authorization feature. 2022-04-04 15:58:06 +02:00
Mykhaylo
dea0564201 [CST-5303] added tests for Scielo live import service 2022-04-04 15:03:35 +02:00
Mykhaylo
e0913ccc5c [CST-5303] porting of Scielo live import service 2022-04-04 15:02:29 +02:00
Luca Giamminonni
06b4b21921 [CST-5306] Minor improvements in ResearcherProfileServiceImpl 2022-04-04 12:04:51 +02:00
Luca Giamminonni
a8ab3b4ad4 Merge remote-tracking branch '4science-bitbucket/main' into CST-5306 2022-04-04 11:28:48 +02:00
Mykhaylo
cb44a8cf15 [CST-5303] porting of VuFind live import service 2022-04-04 09:56:15 +02:00
Mykhaylo
181bdd04d1 [CST-5303] porting of CrossRef live import service 2022-04-02 13:13:38 +02:00
Mykhaylo
5d0bf51d5a [CST-5303] added tests for CrossRef live import service 2022-04-02 13:12:25 +02:00
Mykhaylo
1050d02a97 refactored live import client and some utils class 2022-04-02 13:11:11 +02:00
Tim Donohue
8ee4d9f9ab [maven-release-plugin] prepare for next development iteration 2022-04-01 09:21:58 -05:00
Tim Donohue
e8b92088f1 [maven-release-plugin] prepare release dspace-7.2.1 2022-04-01 09:21:54 -05:00
Tim Donohue
fe9d22a4f6 Change to snapshot version 2022-04-01 09:07:33 -05:00
Tim Donohue
f863866183 Update to Spring v5.2.20. Requires also explicitly specifying version of spring-context-support to avoid dependency convergence issues. 2022-03-31 13:20:28 -05:00
eskander
f8e8866f75 [CST-5306] Migrate Researcher Profile (REST).
- added new four test functions for claim profile.
- formatting the code.
- removed unused classes.
2022-03-31 18:19:32 +02:00
Tim Donohue
efb3869817 Merge pull request #8178 from tdonohue/default_auth_server
Enable default value for `solr.authority.server`
2022-03-31 09:59:25 -05:00
Mark H. Wood
33e501086a Merge branch 'main' into DS-4300 2022-03-31 08:08:46 -04:00
Tim Donohue
b4915868dd Entity Types now come back in a different order. Updating pagination tests based on new ordering 2022-03-30 14:26:39 -05:00
Tim Donohue
967e36af7a Fix Item & Bundle tests which check order of results. H2 2.x + Hibernate 5.x returns results ordered by UUID when unspecified. 2022-03-30 14:26:39 -05:00
Tim Donohue
62c0e28f54 Remove custom Postgres Dialect. Replace with DatabaseAwareLobType 2022-03-30 14:26:39 -05:00
Tim Donohue
57b19fa71a Bug fix, ensure Solr container is *shutdown* when destroyed 2022-03-30 14:26:39 -05:00
Tim Donohue
c4ad834a8a Cleanup IT logs by loading beans by name. Add note to application.properties on how to enable debug logs 2022-03-30 14:26:39 -05:00
Tim Donohue
0595eeddbb Tiny stability fix to test (fails on Windows). Remove newline from string comparison 2022-03-30 14:26:39 -05:00
Tim Donohue
531fc8acda Upgrade to Flyway 8.4.4 2022-03-30 14:26:38 -05:00
Tim Donohue
5a046dca13 Fix incorrect StringUtils import 2022-03-30 14:26:38 -05:00
Tim Donohue
a35a6d4a28 Upgrade to Flyway 8.2.x to support h2 v2 2022-03-30 14:26:38 -05:00
Tim Donohue
70f85edf9e Upgrade to h2 v2.x. Requires also updating to Hibernate 5.6.x 2022-03-30 14:26:34 -05:00
eskander
d4f95a31bd [CST-5306] Migrate Researcher Profile (REST).
added ClaimItemFeature.
2022-03-30 17:02:28 +02:00
Luca Giamminonni
95ba7d805b [CST-5288] Fixed CORS configuration for actuator endpoints 2022-03-30 16:29:52 +02:00
Tim Donohue
c15de2a01e Merge pull request #8222 from tdonohue/jdom_update
Update to JDOM2. Remove Axiom from dspace-api (replace with JDOM2)
2022-03-30 09:08:17 -05:00
Luca Giamminonni
3210d9ce38 [CST-5288] Add CorsMapping for actuator endpoint 2022-03-30 13:19:07 +02:00
Luca Giamminonni
c25bdd1222 [CST-5306] Migrate Researcher Profile (REST) . 2022-03-30 12:49:53 +02:00
Luca Giamminonni
6a1cdd6e2d [CST-5306] Migrate Researcher Profile (REST) 2022-03-30 12:48:54 +02:00
Bruno Roemers
c4c8a4bc07 88599: Update expected places 2022-03-30 02:15:32 +02:00
Mark H. Wood
0e98044e95 [DS-4300] Test with specified handles enabled. 2022-03-29 16:06:22 -04:00
Mark H. Wood
2f437b7018 [DS-4300] Refactor for testability. 2022-03-29 16:05:48 -04:00
Mark H. Wood
b29fbbc7f8 Merge remote-tracking branch 'upstream/main' into DS-4300 2022-03-29 14:28:20 -04:00
Mark H. Wood
2312724f5e [DS-3951] Add tests for new strategy classes. 2022-03-28 13:51:38 -04:00
Mark H. Wood
bd80b0e4c7 [DS-3951] Fix another missed usage. 2022-03-28 10:56:37 -04:00
Mark H. Wood
758b02f65c [DS-3951] A new class needs to understand multiple recipients. 2022-03-25 17:00:04 -04:00
Mark H. Wood
f04e26374d Merge branch 'main' into DS-3951 2022-03-25 16:35:29 -04:00
Tim Donohue
036bcac702 Merge pull request #8224 from mwoodiupui/8192
Update deprecated Velocity configuration keys
2022-03-25 14:55:26 -05:00
Tim Donohue
1d39af6a01 Merge pull request #8221 from atmire/w2p-88773-Issue_8023_Bitstream_download_filename_lose_non-latin_characters
Bitstream download filename lose non-latin characters
2022-03-25 14:21:58 -05:00
Bruno Roemers
97a9c70579 88599: WIP: Fix place algorithm 2022-03-25 19:43:53 +01:00
Mykhaylo
af21d54f97 [CST-5303] implemented http live import client 2022-03-25 17:09:06 +01:00
Mykhaylo
7ab43a5596 Merge remote-tracking branch 'tdonohue/jdom_update' into CST-5303-LiveImport 2022-03-25 16:56:20 +01:00
Luca Giamminonni
bf7ef19322 [CST-5288] Disabled solr oai core health indicator during tests 2022-03-25 13:10:41 +01:00
Luca Giamminonni
a24f75cc08 [CST-5288] Fixed GeoIpHealthIndicatorTest 2022-03-25 11:44:24 +01:00
Luca Giamminonni
ba7750a8a0 [CST-5288] Improved info actuator 2022-03-25 11:24:31 +01:00
Tim Donohue
4a719a88dc Merge pull request #8217 from mwoodiupui/8213
Rename Hibernate caches as suggested by Hibernate.
2022-03-24 16:56:19 -05:00
Mark H. Wood
6f78c0b8ba Update to Velocity 2.3. #8192 2022-03-24 12:58:14 -04:00
Mark H. Wood
488fffce56 Update deprecated Velocity configuration keys. #8192 2022-03-24 12:10:50 -04:00
Tim Donohue
5f66bda96e Merge pull request #3312 from mwoodiupui/DS-4478-7x
[DS-4478] Optionally list all values of an array property
2022-03-24 09:24:52 -05:00
Luca Giamminonni
cc23600fe9 [CST-5288] Improved health actuator 2022-03-24 14:00:32 +01:00
Luca Giamminonni
ca917cb70a Merge remote-tracking branch '4science-bitbucket/main' into CST-5288 2022-03-24 12:56:26 +01:00
Bruno Roemers
aa77b0a3bb 88675: WIP: Test virtual metadata on new version 2022-03-23 23:20:22 +01:00
Bruno Roemers
aeac1ee1ea 88675: Fix place of opposite item 2022-03-23 22:37:00 +01:00
Tim Donohue
f5516ecc10 Merge pull request #8170 from tdonohue/update_test_data
Update Docker compose scripts to point at new Entities data
2022-03-23 09:37:43 -05:00
Tim Donohue
8ed314f608 Remove Axiom from dspace-api, replacing it with JDOM2 2022-03-22 17:24:59 -05:00
Tim Donohue
27fdab0dfb Upgrade Rome to avoid pulling in old version of JDOM 2022-03-22 14:03:47 -05:00
Tim Donohue
d6df493080 Fix broken tests by replacing JDOMXPath with XPathFactory 2022-03-22 14:03:47 -05:00
Tim Donohue
ae25c67064 Update to JDOM2. Also replaced deprecated XPath with new XPathFactory 2022-03-22 14:03:47 -05:00
Bruno Roemers
d55935c197 88629: Fix ItemServiceImpl#rawDelete 2022-03-22 11:25:15 +01:00
Bruno Roemers
0d148abf11 88629: Prove that ItemServiceImpl#rawDelete is broken 2022-03-22 11:24:41 +01:00
Samuel
85bbcf3dc8 taskid 88773 #8023 Bitstream download filename lose non-latin characters 2022-03-22 10:42:48 +01:00
Tim Donohue
2e4489e4bb Merge pull request #8212 from tdonohue/fix_8211
Fix GoogleBitstreamComparator to return 0 when equal
2022-03-21 09:30:30 -05:00
Mark H. Wood
bdf83c73a6 Add tests for use of '--first'. #3312 2022-03-21 09:54:07 -04:00
Bruno Roemers
46d9ba91bc 88599: Test metadata and relationship place when creating new version of item 2022-03-21 10:30:37 +01:00
Bruno Roemers
1fcff89007 88595: Set versioning.block.entity = false 2022-03-18 01:32:56 +01:00
Tim Donohue
87eb2b890d Merge pull request #8146 from mwoodiupui/8099
Converge all use of EHcache to v3
2022-03-16 16:06:36 -05:00
Bruno Roemers
f3ff9af3e2 88061: Clarify VersioningConsumer with extra comments 2022-03-16 17:58:59 +01:00
Mark H. Wood
c0aee566a0 Oops, fix the tests to understand the new options. #3312 2022-03-16 12:08:10 -04:00
Mark H. Wood
7e0becf666 Replace --all with opposite --first, default off, as requested. [DS-4478] #3312 2022-03-16 11:50:22 -04:00
Bruno Roemers
9288a18c4f 88061: Verify modified relationships on new version of item before item install 2022-03-16 15:21:14 +01:00
Mark H. Wood
77b00cea7e Rename Hibernate caches as suggested by Hibernate. #8213 2022-03-16 09:17:07 -04:00
Tim Donohue
df5ed298af Merge pull request #2474 from mwoodiupui/DS-4118
[DS-4118] change_password and register emails have hardcoded sample addresses
2022-03-15 13:22:41 -05:00
Mark H. Wood
b316cb1cec Remove all traces of disk cache to eliminate cache directory collisions. #8099 2022-03-15 14:03:51 -04:00
Mark H. Wood
585f7c67a9 Move helpdesk email settings up with other emails, as requested. [DS-4118] #2474 2022-03-15 13:39:38 -04:00
Tim Donohue
3fc4131cb2 Fix compare by returning 0 when bitstreams are "equal" in size & priority 2022-03-15 11:03:43 -05:00
Bruno Roemers
135c6e6ec0 88196: Modify tests to verify that place recalculation does NOT matter 2022-03-14 18:16:31 +01:00
Antoine Snyers
ca17ebf338 Update code 2022-03-14 16:04:02 +01:00
Antoine Snyers
23d537f5d9 Update code 2022-03-14 12:30:00 +01:00
Antoine Snyers
30c6271d3a Merge remote-tracking branch 'remotes/upstream/main' into browse-by-prefix-filter 2022-03-14 12:22:59 +01:00
Bruno Roemers
efd5b8e9a0 Merge remote-tracking branch 'worldbank-7/w2p-86592_Fix-relationship-place-issues_Community-contrib' into feature-relationship-versioning 2022-03-11 16:35:28 +01:00
Bruno Roemers
df07d1abf1 88196: Avoid SQL constraint violation in test 2022-03-11 16:27:08 +01:00
Bruno Roemers
d31f6834c8 88196: WIP: Test place of metadata in new version (implementation needs fix) 2022-03-11 15:10:26 +01:00
Bruno Roemers
938f1bab52 88196: BUGFIX: Auto-assign place in RelationshipBuilder 2022-03-11 11:24:04 +01:00
Bruno Roemers
f6b72787de 88196: WIP: Test order of plain and virtual metadata (after relationship versioning) 2022-03-10 20:00:22 +01:00
Bruno Roemers
f75d680ce3 88061: Test relationship support of VersioningConsumer 2022-03-10 19:26:35 +01:00
Tim Donohue
c78435f8b1 Merge pull request #8149 from mwoodiupui/8148
DSpaceApiExceptionControllerAdvice should always log the exception message and location
2022-03-10 10:10:22 -06:00
Antoine Snyers
87e3fdef98 Adjust tests to expect filtering instead of jumping 2022-03-10 10:05:40 +01:00
Bruno Roemers
0b9b16a14a 88061: Implement relationship latest version status change (untested) 2022-03-09 19:37:10 +01:00
Antoine Snyers
4d8a81d3bd Filter browse-by-item lists instead of jumping to prefix 2022-03-09 14:35:00 +01:00
Bruno Roemers
020ebbd3d1 88061: Refactor VersioningConsumer 2022-03-09 10:55:09 +01:00
Yana De Pauw
2d7a52dc00 88141: Scripts and processes bug #7992 2022-03-08 13:24:53 +01:00
Bruno Roemers
204d9f0047 88146: Fix tests 2022-03-08 11:57:07 +01:00
Tim Donohue
2e4f920d24 Move "solr.authority.server" to solrauthority.cfg 2022-03-07 15:03:18 -06:00
Bruno Roemers
b142601c62 88056: Filter relationship metadata by class instance instead of authority key 2022-03-07 14:17:26 +01:00
Marie Verdonck
5dc382e88e Merge remote-tracking branch 'dspace-origin/main' into issue-8140_create-citation-page-once_main 2022-03-07 12:54:44 +01:00
Marie Verdonck
696fcae777 87994: Refactor reset file after retrieved & only put in byteArray if with coverpage 2022-03-07 12:54:18 +01:00
Bruno Roemers
85b2752565 88146: Bugfix: Add excludeTilted to RelationshipDAO#countByItem, add note to docs 2022-03-04 17:31:04 +01:00
Bruno Roemers
272fd35535 88056: Copy relationships when creating new version of item 2022-03-04 16:13:49 +01:00
Bruno Roemers
b912769580 88056: Bugfix: do not copy virtual metadata to new version of items 2022-03-04 16:10:42 +01:00
Bruno Roemers
e783576476 88051: Fix unnecessary stubbing exception 2022-03-03 14:35:04 +01:00
Bruno Roemers
fb4eb05e5d 88051: Fix tests 2022-03-03 10:29:32 +01:00
Tim Donohue
e24431413c Merge pull request #8180 from atmire/w2p-87624_Issue-rp_patches
Fix for resource policy end date add patch not working
2022-03-02 15:56:09 -06:00
Tim Donohue
18e4fed9ed Enable default value for solr.authority.server 2022-03-02 14:15:58 -06:00
Bruno Roemers
0b31955f83 88051: Write tests for excludeNonLatest flag 2022-03-02 16:44:59 +01:00
Bruno Roemers
85d05e6ea8 88051: Fix tests 2022-03-02 13:48:50 +01:00
Bruno Roemers
a5f0c03a27 88051: Support filtering non-latest relationships 2022-03-02 00:58:32 +01:00
Bruno Roemers
d0aab90ffc 88049: Add latest_version_status column to relationship table 2022-03-01 02:30:41 +01:00
Antoine Snyers
3f9506e623 Prevent creating the citation page twice 2022-02-28 09:54:03 +01:00
Antoine Snyers
87d91c75bb Add ITs to verify all streams from retrieve() are closed 2022-02-25 15:44:29 +01:00
Tim Donohue
2d8ca5c64d Merge pull request #8137 from DSpace/dependabot/maven/xerces-xercesImpl-2.12.2
Bump xercesImpl from 2.12.0 to 2.12.2
2022-02-24 15:15:27 -06:00
Tim Donohue
f12f223fd4 Merge pull request #8172 from DSpace/dependabot/maven/org.postgresql-postgresql-42.3.3
Bump postgresql from 42.2.25 to 42.3.3
2022-02-24 15:12:29 -06:00
dependabot[bot]
85a3dd6ff1 Bump xercesImpl from 2.12.0 to 2.12.2
Bumps xercesImpl from 2.12.0 to 2.12.2.

---
updated-dependencies:
- dependency-name: xerces:xercesImpl
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-24 20:46:43 +00:00
Tim Donohue
fa40d42791 Merge pull request #8147 from mwoodiupui/8129
Prefix Solr core names to facilitate multiple DSpace instances on a single Solr instance
2022-02-24 12:42:04 -06:00
Mark H. Wood
e261e1ce43 Add core prefix property to local.cfg.EXAMPLE #8129 2022-02-21 09:59:14 -05:00
Mark H. Wood
73b927d663 Document that more than one HTTP status can be configured for tracing. #8148 2022-02-21 09:52:19 -05:00
Marie Verdonck
6790ee157e 87624: Fix issue with ADD patch on RP.endDate 2022-02-18 11:29:07 +01:00
Marie Verdonck
6bea8e83b4 87624: IT demonstrating issue with ADD patch on RP.endDate 2022-02-18 11:29:07 +01:00
Tim Donohue
f9b438dfc8 Merge pull request #8165 from atmire/w2p-87384_Fix-null-metadata-values-being-added
Fix Null metadata values being added
2022-02-17 14:47:58 -06:00
Tim Donohue
912677327f Merge pull request #3354 from mwoodiupui/3287
Make DOI resolver URL stem configurable
2022-02-17 12:21:50 -06:00
Tim Donohue
0f586fdead Merge pull request #8174 from tuub/dspace-dspace-#8167
Fix DSpace/DSpace#8167 XSD for controlled vocabulary
2022-02-17 11:19:15 -06:00
Martin Walk
42233cbfe0 Fix DSpace/DSpace#8167 XSD for controlled vocabulary
Require attribute id for nodes.
2022-02-16 16:48:33 +01:00
dependabot[bot]
8debe3cb60 Bump postgresql from 42.2.25 to 42.3.3
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.25 to 42.3.3.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.25...REL42.3.3)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-16 01:19:23 +00:00
Mark H. Wood
c4a6fcbf19 Remove outdated exclusion. #8099
Also add some missing direct dependencies.  I thought these were
causing a problem, which in fact came from an old version of httpcore,
but we need these anyway.
2022-02-15 13:25:36 -05:00
Tim Donohue
09a51c664a Merge pull request #8163 from hzafar/8055_dspace6_item_moves
Adds check for whether source and target collections are the same
2022-02-15 09:44:47 -06:00
Tim Donohue
a95faed6d4 Merge pull request #8162 from 4Science/CST-5251
Improved builder's cleanup to avoid consumers executions
2022-02-14 16:38:12 -06:00
Tim Donohue
c5786a0b0f Merge pull request #8160 from mspalti/shib_auth_modification
Removes ShibAuthentication session dependency for special groups.
2022-02-14 16:30:38 -06:00
Huma Zafar
8c44a95c7b Adds check for whether source and target collections are the same when moving an item. (#8055) 2022-02-14 14:19:09 -05:00
Mark H. Wood
8ca0a1f2f7 Move configuration from Spring to 'dspace.cfg'. #8148 2022-02-14 14:09:33 -05:00
Tim Donohue
f058d123cf Update Docker compose scripts to point at new Entities data & do a full reindex after loading assetstore. 2022-02-14 12:49:32 -06:00
Tim Donohue
baea61e1b6 Merge pull request #8156 from toniprieto/change-group-name
Changing the name of a group should not recalculate group2groupcache table
2022-02-14 12:47:26 -06:00
Luca Giamminonni
a6fa1f17f7 [CST-5288] Made the actuator security configuration dynamic 2022-02-14 16:35:54 +01:00
Luca Giamminonni
980359a0a9 [CST-5288] Added custom health indicator to check GeoIP configuration status 2022-02-14 13:44:45 +01:00
Luca Giamminonni
e4857c0b1d [CST-5288] Introduced spring boot actuators 2022-02-11 18:34:25 +01:00
Luca Giamminonni
56896c3bb6 [CST-5251] Improved missing builder's cleanup 2022-02-11 16:34:02 +01:00
Yana De Pauw
eaac8a6324 87384: Fix Null metadata values being added #2 2022-02-11 10:43:56 +01:00
Michael Spalti
1c2200aacd Added required request attribute. 2022-02-10 14:41:33 -08:00
Michael Spalti
6671d67894 Removes session dependency when accessing special groups. 2022-02-10 12:06:05 -08:00
Luca Giamminonni
35179b535e [CST-5251] Improved builder's cleanup to avoid consumers executions 2022-02-10 16:11:07 +01:00
Toni Prieto
f05c6ac140 Add call to setMetadataModified() when the name of group is changed to trigger MODIFY_METADATA event 2022-02-09 14:09:32 +01:00
Mark H. Wood
ab9133fb7a Make the list of ERROR HTTP status codes configurable. #8148 2022-02-08 14:46:01 -05:00
Tim Donohue
579d926e95 Merge pull request #8153 from the-library-code/DS-8152
Remove unneccessary second Context in RDFConsumer
2022-02-08 09:47:26 -06:00
Pascal-Nicolas Becker
dcd434ded0 Remove unneccessary second Context in RDFConsumer
fixes #8152
2022-02-07 23:36:02 +01:00
Mark H. Wood
dde3bad906 Defend against null exception. #8148 2022-02-07 15:18:45 -05:00
Tim Donohue
18c524170a [maven-release-plugin] prepare for next development iteration 2022-02-03 13:14:11 -06:00
Tim Donohue
122924af82 [maven-release-plugin] prepare release dspace-7.2 2022-02-03 13:14:08 -06:00
Tim Donohue
8470899fd6 Update LICENSES_THIRD_PARTY for 7.2 release 2022-02-03 12:04:00 -06:00
Mark H. Wood
ef0adf5f9b First cut at better exception logging. #8148 2022-02-03 11:25:57 -05:00
Mark H. Wood
f36ce778fb Invent 'solr.multicorePrefix' to distinguish multiple DSpace instances running against a single Solr instance. #8129 2022-02-03 08:48:33 -05:00
Mark H. Wood
c0d98d30bc Merge remote-tracking branch 'upstream/main' into 8099 2022-02-02 12:25:31 -05:00
Mark H. Wood
09591dc6ff Rewrite Hibernate Ehcache configuration for v3. #8099
Also fix incorrectly-used Spring-style <property> elements in hibernate.cfg.xml
2022-02-02 12:09:24 -05:00
Mark H. Wood
5c5025cd6d Rip out the unused CachingService. $8099 2022-02-02 12:08:11 -05:00
Tim Donohue
41a21043f1 Merge pull request #8145 from DSpace/dependabot/maven/org.postgresql-postgresql-42.2.25
Bump postgresql from 42.2.24 to 42.2.25
2022-02-02 08:40:39 -06:00
dependabot[bot]
cf107087ec Bump postgresql from 42.2.24 to 42.2.25
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.24 to 42.2.25.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.2.24...REL42.2.25)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-02 00:05:47 +00:00
Tim Donohue
1be54376ac Merge pull request #8047 from mspalti/dynamic-default-dims
Dynamic IIIF canvas dimensions
2022-02-01 09:58:14 -06:00
Yura Bondarenko
9664296af6 86201: Fix RelationshipService place handling
Correctly take into account the place of other Relationships and/or MDVs when creating/modifying/deleting Relationships
Simplify RelationshipService public API to avoid having to call updatePlaceInRelationship explicitly
Additional tests to cover issues with the previous implementation
2022-02-01 14:53:18 +01:00
Tim Donohue
1c92e54ddb Merge pull request #8104 from tdonohue/jdk_17
Add support for Java / JDK 17 (latest LTS release)
2022-01-31 14:17:46 -06:00
Michael Spalti
c58a8b9537 Updated iiif config. 2022-01-31 12:15:24 -08:00
Tim Donohue
96326dfde5 Update Dockerfiles to support either JDK11 or JDK17 (default is JDK11). Instructions in README 2022-01-31 11:15:18 -06:00
Tim Donohue
6bb2261d70 Revert to only running tests for JDK 11 2022-01-31 11:15:18 -06:00
Tim Donohue
c6404c860d Add nicer name for each build in matrix 2022-01-31 11:15:18 -06:00
Tim Donohue
0c448c732d Update CI build process to include both JDK 11 and 17 2022-01-31 11:15:18 -06:00
Tim Donohue
d928f84779 Fix bugs reported by errorprone after it was upgraded 2022-01-31 11:15:18 -06:00
Tim Donohue
c15d9307f9 Update errorprone and mockito-inline to support Java 17 2022-01-31 11:15:18 -06:00
Tim Donohue
adbcbb9b0d Merge pull request #8091 from 4Science/CST-4505-EmbargoItemMetadata
Embargo Item Metadata
2022-01-31 11:13:26 -06:00
Tim Donohue
0881d3a7dc Merge pull request #8088 from hardyoyo/port-oidc-auth-plugin-from-dspace-cris
Port OIDC (OpenID Connect) auth plugin from DSpace-CRIS
2022-01-31 08:50:06 -06:00
Toni Prieto
dab8b2b9f8 Changing the name of a group should not recalculate group2groupcache table 2022-01-30 16:45:05 +01:00
Michael Spalti
1724a09213 Merge branch 'main' into dynamic-default-dims 2022-01-29 10:46:40 -08:00
Tim Donohue
c671850784 Merge pull request #8142 from hardyoyo/8138-fix-sql-in-itemDAOImpl.java
8138 Fix SQL/HQL in itemDAOImpl.java
2022-01-28 14:20:32 -06:00
Tim Donohue
4c28d5f32b Merge pull request #8015 from mspalti/iiif-item-import
IIIF Options for item import (SAF)
2022-01-28 14:18:20 -06:00
Mykhaylo
69fa1f9480 removed duplication check 2022-01-28 20:27:38 +01:00
Mykhaylo
294045d760 refactored AccessConditionConfigurationService 2022-01-28 20:17:24 +01:00
Hardy Pottinger
372ee07b2f 8138 Fix SQL/HQL in itemDAOImpl.java 2022-01-28 13:00:32 -06:00
Tim Donohue
b9eb825669 Merge pull request #8141 from hardyoyo/8134-fix-requestitem-helpdesk-strategy-example
8134 - Fix the example requestiem helpdesk strategy example
2022-01-28 12:59:26 -06:00
Hardy Pottinger
e593e90dfb 8134 - Fix the example requestiem helpdesk strategy example
- Add autowire-candidate='true' to the example in requestitem config, as
per suggestion from @bbranan.

fixes #8134
2022-01-28 12:20:13 -06:00
Hardy Pottinger
14a961b386 Fix example OIDC line in local.cfg.EXAMPLE, wrong case! 2022-01-28 11:24:47 -06:00
Mykhaylo
d74b85e901 added java doc 2022-01-28 18:15:34 +01:00
Mark H. Wood
1599aea886 Begin moving CachingService to Ehcache v3 # 8099 2022-01-28 09:48:57 -05:00
Mark H. Wood
530d69bad8 Switch Hibernate to JCache #8099 2022-01-28 09:47:02 -05:00
Michael Spalti
19aa7ca53e Added REMOVED event to canvas cache logger config. 2022-01-27 20:35:15 -08:00
Tim Donohue
2e3c4f033d Merge pull request #8113 from atmire/bitstream-download-inputstream-leak
File downloads don't close inputstreams when cached fix
2022-01-27 16:37:38 -06:00
Tim Donohue
e8b4fdf337 Merge pull request #8090 from 4Science/CST-4874-Feedback
Feedback form - rest part
2022-01-27 15:12:43 -06:00
Hardy Pottinger
ddbaabcbb5 Requested changes
- only warn about failure to find a matching ePerson if canSelfRegister
is false
- tell LGTMbot everything is fine with the redirect
- remove comments about nonexistent ORCID login code
2022-01-27 10:57:54 -06:00
Michael Spalti
ecf24b54f1 Fixed dimension cache. 2022-01-26 14:35:08 -08:00
Mykhaylo
87a338b0fd added test to verify correct inheritance of access condition 2022-01-26 17:27:07 +01:00
Kevin Van de Velde
42cae867db Move the citation generation in a single method again 2022-01-26 16:02:49 +01:00
Hardy Pottinger
b0ce61d3fe Rename OidcAuthenticationFilter to OidcLoginFilter, as per request 2022-01-25 17:00:50 -06:00
Michael Spalti
0579b7d99c Added config for updating default dimension for all images w/o metadata. 2022-01-25 13:25:11 -08:00
Michael Spalti
fbe1b55edd Updated cache logging. 2022-01-25 10:33:58 -08:00
Michael Spalti
346d041f7e Bitstream cache. 2022-01-25 09:46:24 -08:00
Michael Spalti
abf198037a Shared image server query service 2022-01-25 09:20:19 -08:00
Mykhaylo
34d9dbadd2 minor fix 2022-01-25 18:15:09 +01:00
Mykhaylo
b83291748a fix inherit of policies in submission 2022-01-25 17:48:49 +01:00
Michael Spalti
3ef96ba30c Merge branch 'main' into dynamic-default-dims 2022-01-24 17:18:45 -08:00
Michael Spalti
6ede71866a Using updated constants in shared utils. 2022-01-24 16:54:14 -08:00
Michael Spalti
7abdf17e06 Merge branch 'main' into iiif-item-import 2022-01-24 15:42:37 -08:00
Tim Donohue
750426988b Merge pull request #8022 from astrowq/dev/new-date-format
fix an error when harvesting arXiv OAI-PMH
2022-01-24 14:15:21 -06:00
Hardy Pottinger
23e93ff285 Fix checkstyle error introduced by VScode's 'organize imports' suggestion 2022-01-24 13:19:22 -06:00
Hardy Pottinger
0c1c2defcf Add validation to OIDC redirect, based on suggestion from LGTMbot, code copied from Shibboleth, at the suggestion of @tdonohue 2022-01-24 13:17:14 -06:00
Hardy Pottinger
e504597ee2 Fix checkstyle errors 2022-01-24 12:35:44 -06:00
Tim Donohue
170209723c Merge pull request #8074 from mspalti/image-dimension-task
IIIF canvas dimension task
2022-01-24 12:01:46 -06:00
Hardy Pottinger
7c944d5eb5 Requested change: Add logging for no such user and canSelfRegister=false 2022-01-21 17:17:17 -06:00
Hardy Pottinger
3a04b92c80 Requested changes
- Add sane fall-back defaults for OIDC, where possible.
- Improve error logging for missing properties
- Include authentication-oidc.cfg in dspace.cfg
- Add configuration examples for OIDC to local.cfg-EXAMPLE
- Improve authentication-oidc.cfg with sane defaults and more comments
2022-01-21 16:57:47 -06:00
Hardy Pottinger
e6012b0ef7 Add missing isUsed override to OidcAuthentication code. 2022-01-21 13:45:08 -06:00
Hardy Pottinger
e8aa946963 Iron out some checkstyle wrinkles 2022-01-21 13:45:08 -06:00
Hardy Pottinger
3c03a67c75 Revise call to create new DSpaceAuthentication
- Borrow the invocation of DSpaceAuthentication from the Shib plugin
- Also borrow the comment explaining it from the Shib plugin
2022-01-21 13:45:08 -06:00
Hardy Pottinger
b2a24301b9 Disable DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES
- Makes OIDC authentication sturdier: implementations can and do differ
slightly, an unknown property should not prevent authentication
2022-01-21 13:45:08 -06:00
Hardy Pottinger
99c8ad991f Remove unusued DSpace-CRIS services in core-services.xml 2022-01-21 13:45:08 -06:00
Hardy Pottinger
2987fc2f9a Suggested changes from Luca Giamminonni: remove ORCID AuthN 2022-01-21 13:45:08 -06:00
Hardy Pottinger
d2a13527ff Add OrcidAuthenticationFiler 2022-01-21 13:45:07 -06:00
Hardy Pottinger
61d65d1e74 Ignoring jenv .java-version files 2022-01-21 13:45:07 -06:00
Hardy Pottinger
2d05ff392c Add missing util: ThrowingSupplier 2022-01-21 13:45:07 -06:00
Luca Giamminonni
1d89538cb1 [DSC-196] Fix tests 2022-01-21 13:45:07 -06:00
Luca Giamminonni
6521564d71 [DSC-196] Porting of OpenID authentication provider 2022-01-21 13:45:07 -06:00
Michael W Spalti
46f4d37d73 Merge branch 'main' into image-dimension-task 2022-01-20 18:18:36 -08:00
Michael W Spalti
53cb1505f4 Modified CLI and renamed packages. 2022-01-20 17:50:24 -08:00
Tim Donohue
79c7ab77b1 Merge pull request #8122 from atmire/Index-InProgressSubmission-depending-on-type
Workspace/Workflow only discovery configuration isn't working
2022-01-20 16:16:33 -06:00
Tim Donohue
903ccc5136 Merge pull request #8127 from tdonohue/fix_docker_compose
Docker-Compose Environment variables must be strings or numbers, not booleans
2022-01-20 15:55:30 -06:00
Tim Donohue
17ba8f5621 Environment variables must be strings or numbers, not booleans 2022-01-20 14:13:11 -06:00
Tim Donohue
169055f62a Merge pull request #8117 from atmire/w2p-85525_pr-fix-qdccrosswalk-test
Refactor QDCCrosswalkTest to avoid config errors
2022-01-20 11:00:26 -06:00
Tim Donohue
c89c43e3da Merge pull request #8124 from atmire/javax-mail-update
Javax mail update
2022-01-20 10:44:00 -06:00
Kevin Van de Velde
a15478178d Removing duplicate Null check 2022-01-20 16:56:06 +01:00
Kevin Van de Velde
f6d94f199b Merge branch 'main' into javax-mail-update 2022-01-20 14:10:37 +01:00
Kevin Van de Velde
5396216aa8 Logging exception when sending emails fails in the workflow 2022-01-20 14:09:29 +01:00
Kevin Van de Velde
f6a0fcb64b [Ticket: 918] Email issues fix 2022-01-20 13:58:58 +01:00
Tim Donohue
d49721a41b Merge pull request #8076 from atmire/w2p-85542_filtermedia-process
Filtermedia process
2022-01-19 13:10:30 -06:00
Kevin Van de Velde
441c62239a Fix inputstream connection leak when downloading files: Bugfix for cover pages so that the correct file size is used 2022-01-19 13:23:02 +01:00
Mykhaylo
5bbe4430bf removed flush method 2022-01-19 10:26:49 +01:00
Michael Spalti
618db16b31 Multiple updates. 2022-01-18 16:59:37 -08:00
Tim Donohue
bdd521a9b0 Merge pull request #8118 from atmire/w2p-85525_pr-use-lenient-stubbing-in-MockSolrLoggerServiceImpl
Use lenient stubbing in MockSolrLoggerServiceImpl
2022-01-18 11:36:51 -06:00
Tim Donohue
964b132dd1 Merge pull request #8116 from mspalti/iiif-dispatcher-fix
Minor dispatcher fix for bitstreams that have no parent
2022-01-18 11:35:57 -06:00
Tim Donohue
da8ddca1bc Merge pull request #8093 from 4Science/CST-4981-Statistics
fix statistics rest permission evaluator to allow only administrators when access is restricted to this role
2022-01-18 11:01:43 -06:00
Yana De Pauw
0c8ee5da3c 85542: Tweak to error logging 2022-01-18 14:55:28 +01:00
Yana De Pauw
8f7fc0d5ca 85542: Add more logging for rest process call 2022-01-18 13:54:59 +01:00
Mykhaylo
e380a98a33 fix test and add new one 2022-01-18 12:53:21 +01:00
Mykhaylo
7048406534 fix failed tests 2022-01-18 11:05:40 +01:00
Mykhaylo
dc31ae3358 Implement community feedbacks 2022-01-18 09:27:07 +01:00
Mykhaylo
9ab2d7ab07 Implement community feedbacks 2022-01-17 17:31:25 +01:00
Bruno Roemers
7974ea1bfa 85525: fix tests: use lenient stubbing in MockSolrLoggerServiceImpl 2022-01-17 11:50:03 +01:00
Bruno Roemers
fa937acbae 85525: Fix tests (faulty QDCCrosswalk) 2022-01-17 11:46:52 +01:00
Michael Spalti
7a8f538dcd Check for bundles. 2022-01-14 16:27:42 -08:00
Michael Spalti
ac01b4b0b3 Update manifestService after rebase. 2022-01-14 16:00:59 -08:00
Michael Spalti
192494fa57 Fixed IT. 2022-01-14 15:05:34 -08:00
Michael Spalti
299015529c Added javadocs. 2022-01-14 15:05:34 -08:00
Michael Spalti
b749df9868 Update default height and width values using the iiif image server. 2022-01-14 15:03:36 -08:00
Michael Spalti
fb0d37b35e Refactored util package 2022-01-14 11:35:32 -08:00
Michael Spalti
b74dce1170 Import shared constants into IIIFUtils. 2022-01-14 10:57:29 -08:00
Kevin Van de Velde
82cdf48987 Fix inputstream connection leak when downloading files 2022-01-14 13:10:10 +01:00
Michael Spalti
206d98e54d Multiple updates. 2022-01-13 16:14:42 -08:00
Kristof De Langhe
8cab68763b Index InProgressSubmission depending on type 2022-01-13 17:12:46 +01:00
Tim Donohue
5064352ddf Merge pull request #8049 from mspalti/toc-update
Corrects viewingHint omission and refactors services.
2022-01-13 09:46:23 -06:00
Tim Donohue
0a368e27e0 Merge pull request #8110 from tdonohue/fix_oai_cli
Fix OAI cli commands by replacing autowired with servicefactory call
2022-01-13 08:24:20 -06:00
Tim Donohue
62f4f44125 Fix OAI cli commands by replacing autowired with servicefactory call 2022-01-12 17:02:59 -06:00
Tim Donohue
93265465d9 Merge pull request #8107 from DSpace/dependabot/maven/dspace-api/io.netty-netty-codec-4.1.68.Final
Bump netty-codec from 4.1.53.Final to 4.1.68.Final in /dspace-api
2022-01-12 11:22:18 -06:00
Tim Donohue
19c4d75cd2 Sync up other io.netty dependencies to 4.1.68.Final 2022-01-12 10:24:24 -06:00
Tim Donohue
d0bc89fef4 Merge pull request #8108 from tdonohue/dont_swallow_exceptions
Ensure SubmissionService doesn't swallow root exceptions
2022-01-12 09:41:26 -06:00
Tim Donohue
947552fc34 Add missing space 2022-01-12 09:00:24 -06:00
Corrado Lombardi
a6a74463b0 updated messages in exceptions thrown when feedback recipient is disabled and when mandatory fields are missing 2022-01-12 13:09:29 +01:00
Corrado Lombardi
189d9a60b9 improved documentation and used x-correlation-id instead of session id 2022-01-12 13:08:41 +01:00
Tim Donohue
a1c6754c54 Ensure SubmissionService doesn't swallow caused by exceptions 2022-01-11 16:56:22 -06:00
dependabot[bot]
57a3541e90 Bump netty-codec from 4.1.53.Final to 4.1.68.Final in /dspace-api
Bumps [netty-codec](https://github.com/netty/netty) from 4.1.53.Final to 4.1.68.Final.
- [Release notes](https://github.com/netty/netty/releases)
- [Commits](https://github.com/netty/netty/compare/netty-4.1.53.Final...netty-4.1.68.Final)

---
updated-dependencies:
- dependency-name: io.netty:netty-codec
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-11 22:17:11 +00:00
Tim Donohue
611b015e45 Merge pull request #7987 from mwoodiupui/7986
Use a connection pool for communication with Solr
2022-01-11 16:16:42 -06:00
Tim Donohue
c6b6ca6c0f Merge pull request #2172 from KingKrimmson/DS-3981_Improve_IndexClient_Usage_master
DS-3981 Improve IndexClient usage & options
2022-01-11 15:11:00 -06:00
Tim Donohue
95295bfec3 Merge pull request #8028 from jvribell/main
Oracle migration error
2022-01-11 10:52:13 -06:00
Tim Donohue
7f8fa23a47 Merge pull request #8101 from tdonohue/fix_log4j_configs
Log4j v2 : switch to %X{var} syntax instead of $${ctx:var}
2022-01-10 10:11:58 -06:00
Mykhaylo
2bc035db4a Merge branch 'main' into CST-4505-EmbargoItemMetadata 2022-01-10 17:09:14 +01:00
Tim Donohue
3ab421c41e Merge pull request #8100 from tdonohue/expose_versioning_property
Expose 'versioning.item.history.include.submitter' via configuration endpoint
2022-01-10 10:02:15 -06:00
Tim Donohue
fa5a97e375 Merge pull request #8054 from pongtawat/fix-log-rollover
Fix sample log rollover config
2022-01-06 14:16:34 -06:00
Mark H. Wood
edba8a2811 More documentation. Note that DSpace restart is required for configuration changes. 2022-01-06 11:33:38 -05:00
Mark H. Wood
8358e300c4 Correct the names of configuration properties set by tests. #7986 2022-01-06 11:32:38 -05:00
Tim Donohue
ea8eb01a25 Merge pull request #8102 from tdonohue/speed_up_IPMatcherTest
Speed up IPMatcherTest (by testing fewer IPs) & enable rerun flakey tests in CI
2022-01-06 08:37:46 -06:00
Tim Donohue
e6bf1100fc Enable rerunning flakey tests in CI environment. 2022-01-05 17:03:18 -06:00
Tim Donohue
0c6c07e9cf Increase increment to drastically speed test (and test fewer IPs) 2022-01-05 16:29:26 -06:00
Tim Donohue
316864bb53 Switch to %X{var} syntax instead of $${ctx:var} 2022-01-05 14:41:14 -06:00
Tim Donohue
fcc9f045a2 Merge pull request #8077 from atmire/w2p-85840_qualdrop-values-mandatory-flag
Qualdrop values not play well with mandatory flag
2022-01-05 14:05:12 -06:00
Tim Donohue
fa4acf0e84 Merge pull request #8097 from tdonohue/increase_test_timeout
Increase test timeout for MetadataFieldPerformanceTest.testManyMetadataAdds()
2022-01-05 13:29:23 -06:00
Tim Donohue
9b1b4c1f76 Correct description based on UI implementation 2022-01-05 12:21:13 -06:00
Tim Donohue
7b4287aa6d Expose submitter versioning setting for #1385 2022-01-05 12:12:57 -06:00
Corrado Lombardi
24355b7a1a [CST-4981] statistics usage restricted to admin via configuration 2022-01-05 15:14:54 +01:00
Tim Donohue
db32b48784 Merge pull request #8075 from atmire/w2p-86897_Issue-8042_If-workflow-user-rejects-own-submitted-item-becomes-uneditable
If a workflow user rejects an item that they submitted, the item becomes uneditable
2022-01-04 16:25:33 -06:00
Tim Donohue
d14b5ceb2d Merge pull request #8098 from tdonohue/identifier_logs_cleanup
Make IdentifierService code less "noisy" in the logs
2022-01-04 16:04:23 -06:00
Tim Donohue
102f285f6a Fix overactive logging when lookup(context, dso) method is called 2022-01-04 13:58:26 -06:00
Tim Donohue
99fe85b608 Remove noisy/duplicative debug logging about identifiers (clutters our test environment logs) 2022-01-04 13:58:20 -06:00
Tim Donohue
c214e6c041 Log adding of a new metadatavalue (we already log updates & deletes, but not adds) 2022-01-04 13:57:23 -06:00
Tim Donohue
ee7b1df187 Increase test's max duration per call by 0.1 ms 2022-01-04 13:57:10 -06:00
Corrado Lombardi
7618a1e0db [CST-4981] default statistics visibility to users with READ permissions, to preserve current default behavior 2022-01-04 18:19:56 +01:00
Tim Donohue
e9204416db Merge pull request #8050 from atmire/w2p-85276_Store-and-retrieve-the-Authentication-method-in-the-JWT
Ensure Shibboleth user cannot change their password
2022-01-04 10:08:45 -06:00
Tim Donohue
6aaabb2dd3 Merge pull request #8092 from tdonohue/docker_runtime_configs
Update docker-compose scripts to use environment variables (to align with runtime configs)
2022-01-04 09:34:28 -06:00
Tim Donohue
252e9c24ae Merge pull request #8096 from DSpace/log4j-update-2.17.1
Fixes New Log4j Remote Code Execution Bug
2022-01-04 09:21:04 -06:00
Kevin Van de Velde
e3dbf3832a XmlWorkflowServiceIT adding a "restoreAuthSystemState()" to reinstate the authentication system prior to performing the tests 2022-01-04 11:36:25 +01:00
Paulo Graça
746413dea1 Fixes New Remote Code Execution Bug
«Apache has released another Log4j version, 2.17.1 fixing a newly discovered remote code execution (RCE) vulnerability in 2.17.0, tracked as CVE-2021-44832. Prior to today, 2.17.0 was the most recent version of Log4j and deemed the safest release to upgrade to, but that advice has now evolved.»
https://www.bleepingcomputer.com/news/security/log4j-2171-out-now-fixes-new-remote-code-execution-bug/
https://checkmarx.com/blog/cve-2021-44832-apache-log4j-2-17-0-arbitrary-code-execution-via-jdbcappender-datasource-element/
2022-01-03 12:13:12 +00:00
Mykhaylo
d97f58d96c fix bug 2021-12-27 19:13:46 +01:00
Mykhaylo
5d59373ff4 Merge branch 'CST-4505-EmbargoItemMetadata' of https://github.com/4Science/DSpace into CST-4505-EmbargoItemMetadata 2021-12-27 19:00:31 +01:00
Mykhaylo
1995300e1d Merge branch 'main' into CST-4505-EmbargoItemMetadata 2021-12-27 18:58:35 +01:00
Mykhaylo
819de05373 added tests to prove the bug 2021-12-27 18:52:49 +01:00
Ben Bosman
af0ead1a70 Removing session dependency 2021-12-24 11:49:02 +01:00
Tim Donohue
82a8ae80ad Minor correction to README 2021-12-23 13:57:22 -06:00
Tim Donohue
618aed6cde Remove Docker-specific local.cfg files. Instead mount [src]/dspace/config/ to Docker containers 2021-12-23 13:29:30 -06:00
Tim Donohue
2f467d1e5e Cleanup Dockerfiles and remove references to Docker-specific local.cfg 2021-12-23 12:50:51 -06:00
Giuseppe Digilio
ae4cbe6278 [CST-4505] Add access condition step definition to item-submission.xml 2021-12-23 19:21:31 +01:00
Tim Donohue
18515b1c9a Update docker-compose scripts to use env variables (align with runtime configs for UI) 2021-12-23 11:44:02 -06:00
jose vicente ribelles aguilar
8c1dcb2072 Update V7.0_2019.07.31__Retrieval_of_name_variant.sql
fix oracle slq sintax
2021-12-23 13:53:30 +01:00
Yana De Pauw
19371747aa 86163: Feedback on Shibboleth changes 2021-12-22 17:44:54 +01:00
Tim Donohue
75b6d67a47 Merge pull request #8089 from J4bbi/google-deprecated
Tag GoogleRecorderEventListener as deprecated
2021-12-22 09:40:02 -06:00
Tim Donohue
16e7758b82 Add comment on what to use instead 2021-12-22 09:05:21 -06:00
Tim Donohue
b0885612e4 Merge pull request #8046 from 4Science/context_improvements
Fixed context's mode handling to improve performances
2021-12-22 08:32:56 -06:00
Hrafn Malmquist
e0ff0d1032 Tag GoogleRecorderEventListener as deprecated 2021-12-22 00:31:30 +00:00
Tim Donohue
6dfcb62eb6 Merge pull request #8068 from atmire/dspace-angular-issue-852-BrowseBy_list_are_statically_configured
dspace-angular issue 852 BrowseBy list are statically configured
2021-12-21 14:13:18 -06:00
Corrado Lombardi
76827e46c4 removed TODO 2021-12-21 15:17:25 +01:00
Mykhaylo
38cce09590 added tests with statistics visible to all 2021-12-21 12:32:47 +01:00
Mykhaylo
ce125148bb refactored security plugin 2021-12-21 12:31:10 +01:00
Tim Donohue
f3e2c28021 Merge pull request #8084 from tdonohue/rename_LICENSE.header
Rename LICENSE_HEADER to LICENSE.header and update all references
2021-12-20 14:19:54 -06:00
Tim Donohue
d5caa24b50 Rename LICENSE_HEADER to LICENSE.header and update all references 2021-12-20 12:19:24 -06:00
Tim Donohue
b0a704b962 Merge pull request #8082 from atmire/w2p-84277_test-case-install-item-expects-wrong-exception
test case in InstallItemTest expects wrong Exception to be thrown
2021-12-20 11:18:22 -06:00
Mykhaylo
d426f449ac fix bug with array access conditions in add patch operation 2021-12-20 18:18:09 +01:00
Mykhaylo
166f84f16d added test to prove bug with array access conditions 2021-12-20 18:17:17 +01:00
Mykhaylo
4dd22eb5f6 fix failed tests 2021-12-20 15:06:49 +01:00
Mykhaylo
f75bdc4818 refactored statistics UsageRepor security plugin 2021-12-20 15:06:28 +01:00
Mykhaylo
f7d02da935 rename feature 2021-12-20 14:59:22 +01:00
Andrea Bollini
dbede2b246 Bumps log4j dependency from 2.16.0 to 2.17.0 2021-12-18 12:16:18 +01:00
Tim Donohue
7ff8592c39 Merge pull request #8067 from CICBA/fix_starts_with_in_findSubmitAuthorized
Fix findSubmitAuthorized endpoint to support queries by starts with
2021-12-17 10:14:15 -06:00
April Herron
b8a81ac824 DS-3981 Improve IndexClient usage & options 2021-12-16 15:08:24 -05:00
Mykhaylo
665c4942b1 changed discoverable property to make it more readable 2021-12-16 18:36:58 +01:00
Kevin Van de Velde
b24f97ac49 Merge branch 'DSpace:main' into w2p-85840_qualdrop-values-mandatory-flag 2021-12-16 15:04:34 +01:00
Kevin Van de Velde
27283a1eb2 Making default qualdrop non mandatory again 2021-12-16 15:04:10 +01:00
Yana De Pauw
fedda887f9 Merge remote-tracking branch 'upstream/main' into w2p-85542_filtermedia-process 2021-12-16 14:45:10 +01:00
Mykhaylo
7f42095f19 added config hal link to SubmissionAccessOption rest object and refactored converter 2021-12-16 13:28:10 +01:00
Kevin Van de Velde
bb05a7948a Merge branch 'DSpace:main' into w2p-86897_Issue-8042_If-workflow-user-rejects-own-submitted-item-becomes-uneditable 2021-12-16 12:06:25 +01:00
Michael Spalti
455429ce6a Multiple updates to configs, processing classes and shared utils. 2021-12-15 18:55:54 -08:00
Tim Donohue
ff8e002bbc Merge pull request #8057 from atmire/w2p-82428_irus-patch-performance
IRUS patch performance improvements by adding a timeout
2021-12-15 16:10:42 -06:00
Nathan Buckingham
5ae5398b99 Change to use constant instead of string md5 2021-12-15 14:19:24 -05:00
Tim Donohue
ff329fe907 Merge pull request #8051 from mwoodiupui/8018
Rely on https handle.net urls instead of http ones
2021-12-15 12:23:08 -06:00
Michael Spalti
980a8a4115 Merge branch 'image-dimension-task' of https://github.com/mspalti/DSpace into image-dimension-task 2021-12-15 09:24:11 -08:00
Mykhaylo
a617ef8bc0 refactoring 2021-12-15 16:15:56 +01:00
Marie Verdonck
012b215827 85897: Issue#8042: Fix for if workflow user rejects an item they submitted, they can bow edit the item that was rejected again 2021-12-15 14:53:55 +01:00
Marie Verdonck
c5743c9bae 85897: Issue#8042: IT demonstrating that if workflow user rejects an item they submitted, they can't edit the item that was rejected anymore 2021-12-15 14:53:01 +01:00
Mykhaylo
881dd059cc changed category of endpoint from core to tools 2021-12-15 11:41:31 +01:00
Mykhaylo
4a095695fb Merge branch 'main' into CST-4874-Feedback 2021-12-15 11:18:20 +01:00
Andrea Bollini
bedcccc42f Merge pull request #8070 from DSpace/dependabot/maven/org.apache.logging.log4j-log4j-api-2.16.0
Bump log4j2 from 2.15.0 to 2.16.0
2021-12-15 10:05:10 +01:00
Michael W Spalti
aa0840668a IT update. 2021-12-14 16:39:47 -08:00
Michael W Spalti
0407751fc2 Moved commit to CLI class. 2021-12-14 16:39:08 -08:00
Michael W Spalti
e459ab2e34 Refactored to use dspace-api utility class shared with CLI tool. 2021-12-14 16:03:53 -08:00
Michael W Spalti
3d9a9a19d6 Various updates plus IT. 2021-12-14 16:03:17 -08:00
Mykhaylo
8fdcb294fa refactoring 2021-12-14 23:20:53 +01:00
dependabot[bot]
2a2b24387a Bump log4j-api from 2.15.0 to 2.16.0
Bumps log4j-api from 2.15.0 to 2.16.0.

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-12-14 20:36:04 +00:00
Mykhaylo
003aea5252 add default configuration for access condition section 2021-12-14 18:45:37 +01:00
Mykhaylo
2d06ee892e Merge branch 'main' into CST-4505-EmbargoItemMetadata 2021-12-14 18:20:13 +01:00
Mykhaylo
293a9a0083 added tests for replace operations 2021-12-14 18:14:58 +01:00
Mykhaylo
24a2f8c2e4 implemented replace operation for access condition in submission 2021-12-14 18:14:28 +01:00
Michael Spalti
e07f562469 Added added service for image formats not supported by ImageIO (jp2) 2021-12-14 08:54:23 -08:00
Michael Spalti
a009a24474 Added more options. 2021-12-14 08:54:23 -08:00
Michael Spalti
0695d4f449 Initial work on bitstream IIIF processor. 2021-12-14 08:54:23 -08:00
Michael Spalti
f13bb90a07 Added collection metadata check for iiif enabled. 2021-12-14 08:54:23 -08:00
Tim Donohue
6c00689fb8 Merge pull request #8044 from 4Science/CST-4882
[CST-4882] The search loads indefinitely if the written query is invalid
2021-12-14 10:38:53 -06:00
Tim Donohue
5b04c1e118 Merge pull request #8069 from tdonohue/update_docker_deps
Update dependencies in Dockerfiles
2021-12-14 09:46:48 -06:00
Joost
3ce83c0087 adapted submissionDefinitionsControllerIT to expect the qualdroptest submission definition 2021-12-14 16:01:51 +01:00
Nathan Buckingham
b7fa187589 fix up white space and unsused import 2021-12-14 09:28:42 -05:00
Mykhaylo
e76e1a23e6 fix failed tests 2021-12-14 15:19:39 +01:00
Mykhaylo
f8626ca541 added tests 2021-12-14 13:42:51 +01:00
Mykhaylo
a85f4e69b9 implemented patch operations for AccessConditions in submission 2021-12-14 13:42:15 +01:00
Joost
0db4fadbfa adapted submissionFormsControllerIT to be aware of the extra form for qualdrop tests 2021-12-14 13:40:16 +01:00
Joost
f7efc8ec41 [task 85840] implementation of different requirement check for qualdrops in input forms 2021-12-14 12:00:17 +01:00
Joost
e0af26180f [task 85840] test for required qualdrops 2021-12-14 10:51:24 +01:00
Mykhaylo
420f661a5b refactoring 2021-12-14 09:14:25 +01:00
Mykhaylo
f919986bdb implemented remove patch operation for workspaceitem-data-access endpoint 2021-12-13 23:54:15 +01:00
Tim Donohue
85c7252ab9 Update dependencies in Docker. 2021-12-13 16:35:40 -06:00
Nathan Buckingham
2992660267 Add comment explaining ETag 2021-12-13 16:35:40 -05:00
Mykhaylo
c4bbd2e6e0 added tests for SubmissionAccessOptions endpoint 2021-12-13 22:34:55 +01:00
Mykhaylo
aaffe5ca80 implemented SubmissionAccessOptions endpoint 2021-12-13 22:32:58 +01:00
Nathan Buckingham
6c5e568543 S3 calculated md5 and store bitstream md5 on Multipart upload 2021-12-13 16:18:16 -05:00
Tim Donohue
be07bd7b37 Update Sonatype settings. Increase timeout to 10mins. Disable autoclose 2021-12-13 15:05:17 -06:00
Joost
28f6b310cc [task 85840] trying to link a test to a required input field 2021-12-13 21:52:51 +01:00
Yana De Pauw
8fef43a782 85542: Fixes to script repository ITs 2021-12-13 14:46:03 +01:00
Yana De Pauw
2b671158be 85542: Add filter-media to test scripts 2021-12-13 13:34:05 +01:00
Michael Spalti
34a200b8c8 Added added service for image formats not supported by ImageIO (jp2) 2021-12-10 17:14:17 -08:00
Mark H. Wood
f7335716a6 Merge branch 'main' into 7986 2021-12-10 15:09:45 -05:00
Mark H. Wood
171245a144 Autowire with 'id' not <qualifier>: @Named doesn't find qualifiers. #7986 2021-12-10 14:36:22 -05:00
Mark H. Wood
e27a109789 Generalize HttpConnectionPoolService for multiple instances with separate configuration.
This removes Solr-specific configuration property names from the otherwise
general service implementation by adding a bean property to specify a
configuration property prefix.
2021-12-10 11:50:28 -05:00
Mark H. Wood
fc5d3bcd17 Clarify the need to manage dependencies for mockserver. #7986 2021-12-10 11:48:57 -05:00
Davide Negretti
6381644eee [CST-4882] Error handling improved 2021-12-10 17:29:14 +01:00
Tim Donohue
9ba2402023 Merge pull request #8065 from DSpace/dependabot/maven/org.apache.logging.log4j-log4j-core-2.15.0
Bump log4j-core from 2.13.3 to 2.15.0
2021-12-10 09:04:28 -06:00
Santiago Tettamanti
f837bee878 Fix findSubmitAuthorized endpoint to support queries by starts with 2021-12-10 11:24:28 -03:00
dependabot[bot]
98b79d436e Bump log4j-core from 2.13.3 to 2.15.0
Bumps log4j-core from 2.13.3 to 2.15.0.

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-12-10 01:03:33 +00:00
Michael Spalti
bdbba6d323 Added more options. 2021-12-09 13:05:17 -08:00
Tim Donohue
396525a5f3 Merge pull request #8025 from atmire/MDV_starting_index_migration
Add migration to fix metadatavalue.place
2021-12-09 15:04:08 -06:00
Michael Spalti
c405195680 Initial work on bitstream IIIF processor. 2021-12-09 12:52:55 -08:00
Tim Donohue
1dea1adf1e Merge pull request #8045 from atmire/Avoid-incorrect-sort-entities
Avoid incorrect sort
2021-12-09 12:14:06 -06:00
Davide Negretti
cc15f414b3 [CST-4882] System.out.println() removed 2021-12-09 15:39:31 +01:00
Tim Donohue
fd57b235db Merge pull request #8061 from tdonohue/license_cleanup
Cleanup our LICENSE file so GitHub can detect our BSD license
2021-12-08 16:43:37 -06:00
Tim Donohue
300bcaa1da Add to README 2021-12-08 16:42:19 -06:00
Tim Donohue
0a04bc739d Minor license formatting cleanup to allow GitHub to recognize our BSD 3-Clause License. Move third-party licenses notice to NOTICE file. 2021-12-08 16:33:20 -06:00
Nathan Buckingham
0b95376e5d w2p-85808 S3Bitstore uses TransferManager to allow large file transfer 2021-12-08 16:47:41 -05:00
Tim Donohue
3e4b8d8a32 Merge pull request #8059 from tdonohue/disable_docker_action_on_forks
Disable Docker image build action on forked repos & on non-maintenance branches
2021-12-08 15:13:52 -06:00
Tim Donohue
4875e2c4d6 Limit branches/tags to ones starting with "dspace-", as that's our standard release/maintenance branch format 2021-12-08 14:37:42 -06:00
Tim Donohue
adb41116db Disable docker action on forked repos. Only run for 'dspace/dspace' 2021-12-08 14:22:15 -06:00
Tim Donohue
312b9d88de Merge pull request #8058 from tdonohue/docker_github_action
Add GitHub action to build Docker images and push to DockerHub
2021-12-08 12:38:29 -06:00
Samuel
a17e340059 dspace-angular issue 852 BrowseBy list are statically configured 2021-12-08 17:55:42 +01:00
Tim Donohue
d74c347808 Cleanup. Turn off 'latest' tag. Ensure -test image suffixes all tags with -test. 2021-12-08 09:38:25 -06:00
Yana De Pauw
03b3470166 85542: Turn filter-media into a scripts and processes script 2021-12-08 13:14:51 +01:00
Tim Donohue
6f92ff4d34 Remove unnecessary Java steps 2021-12-07 16:38:03 -06:00
Tim Donohue
588829c6de Update to latest version of codecov-action 2021-12-07 16:34:20 -06:00
Tim Donohue
7db5826070 Minor updates to Docker README 2021-12-07 16:25:27 -06:00
Tim Donohue
2a040a35ad Create GitHub action to build all DSpace Docker images 2021-12-07 15:11:36 -06:00
Tim Donohue
0af0361660 Minor updates to build action 2021-12-07 15:11:36 -06:00
Joost
22e9512384 checkstyle fixes 2021-12-06 17:05:37 +01:00
Pongtawat C
9c988c3653 Fix sample log rollover config 2021-12-06 21:30:50 +07:00
Joost
99ed35ceed added javadoc and made getRequestConfig protected 2021-12-06 11:51:07 +01:00
Yana De Pauw
78013143ef Merge remote-tracking branch 'upstream/main' into w2p-85276_Store-and-retrieve-the-Authentication-method-in-the-JWT 2021-12-06 10:07:14 +01:00
Mark H. Wood
160f0221e7 Fixed default, configured Handle URL stem to use https: #8018
Also tidied logging and commentary.
2021-12-03 16:07:57 -05:00
Tim Donohue
c1d8303041 Merge pull request #8030 from tdonohue/fix_it_logging
Fix Integration Test logging so that it works and uses log4j2
2021-12-03 11:40:02 -06:00
Yana De Pauw
c74e769d24 85427: Blocking change password if the method is not password 2021-12-03 17:20:13 +01:00
Mykhaylo
3a600e930a refactoring tests 2021-12-03 17:05:27 +01:00
Mykhaylo
96b66fe7ff refactoring FeedbackRestRepository 2021-12-03 17:05:08 +01:00
Joost
0f162d803c [task 82428] added a test to verify whether a timeout is being set 2021-12-03 14:06:01 +01:00
Mykhaylo
b4da463479 added tests for canSendFeedback feature 2021-12-03 13:33:23 +01:00
Mykhaylo
8a5df44104 implemented canSendFeedback feature 2021-12-03 13:32:54 +01:00
Mykhaylo
61bbf3840d added tests 2021-12-03 13:32:12 +01:00
Mykhaylo
6e5b9634a3 implemented feedback endpoint 2021-12-03 13:31:53 +01:00
Michael Spalti
3559be50c4 Added collection metadata check for iiif enabled. 2021-12-02 16:30:04 -08:00
Tim Donohue
b27e167fab Merge pull request #7967 from DSpace/dependabot/maven/com.google.oauth-client-google-oauth-client-1.32.1
Bump google-oauth-client from 1.23.0 to 1.32.1
2021-12-02 16:27:19 -06:00
dependabot[bot]
ec9d81b218 Bump google-oauth-client from 1.23.0 to 1.32.1
Bumps [google-oauth-client](https://github.com/googleapis/google-oauth-java-client) from 1.23.0 to 1.32.1.
- [Release notes](https://github.com/googleapis/google-oauth-java-client/releases)
- [Changelog](https://github.com/googleapis/google-oauth-java-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/googleapis/google-oauth-java-client/compare/1.23.0...v1.32.1)

---
updated-dependencies:
- dependency-name: com.google.oauth-client:google-oauth-client
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-12-02 21:04:45 +00:00
Tim Donohue
8f06ba0de0 Merge pull request #8034 from PabloDeAlbu/fix_metadavalidation_if_isAuthorityControlled
Fix condition for metadata validation if is Authority Controlled
2021-12-02 15:03:24 -06:00
Tim Donohue
db1a520e3d Add sample debug logging for REST API 2021-12-02 14:45:07 -06:00
Tim Donohue
1c31a3a7c5 Add debug logging to auth process 2021-12-02 14:45:03 -06:00
Tim Donohue
84bdb8bc20 Fix incorrect comments 2021-12-02 12:31:12 -06:00
Tim Donohue
4c87bded7d Fix test logging so that it also uses Log4j2 & sends logs to failsafe, etc 2021-12-02 12:31:12 -06:00
Tim Donohue
c61d47e6d7 Merge pull request #8031 from tdonohue/fix_unstable_its
Fix unstable / randomly failing IT methods in AuthenticationRestControllerIT
2021-12-02 11:37:45 -06:00
Tim Donohue
1146d6ec14 Fix unstable tests by checking for JWT equality claim by claim, since a one second difference in expiration date can change entire JWT. 2021-12-02 10:49:13 -06:00
Tim Donohue
b4249dbc0d Ensure "Bearer " prefix always removed from Authorization header 2021-12-02 10:47:39 -06:00
Tim Donohue
083539754b Merge pull request #8032 from tdonohue/fix_ShibAuth_behavior
Fix issue where Shibboleth Authentication was creating two temporary Auth Cookies
2021-12-02 10:28:35 -06:00
Yana De Pauw
d2eee535f0 85149: Fix Sword password login 2021-12-02 13:16:05 +01:00
Yana De Pauw
b430db3790 85276: Fix checkstyle issues85276: Fix checkstyle issues85276: Fix checkstyle issues85276: Fix checkstyle issues85276: Fix checkstyle issues85276: Fix checkstyle issues85276: Fix checkstyle issues85276: Fix checkstyle issues 2021-12-02 12:46:00 +01:00
Yana De Pauw
3e0bfcc0e6 85277: "Feature" to determine whether you can edit your password 2021-12-02 11:59:39 +01:00
Michael Spalti
a39b509773 Minor changes to comments. 2021-12-01 16:46:55 -08:00
Michael Spalti
e02b13ab19 Updated processOptions for iiif.
Updated processContentsFile.

Style check fix.
2021-12-01 16:46:55 -08:00
Michael Spalti
83cf4299bf Updated ITs to check viewing hint. 2021-12-01 13:00:46 -08:00
Michael Spalti
17adfa0a80 Minor updates. 2021-12-01 13:00:26 -08:00
Michael Spalti
543317f54c More refactoring. 2021-12-01 12:15:17 -08:00
Michael Spalti
7ba9894d8e Fixed bundle ranges. 2021-12-01 12:15:17 -08:00
Michael Spalti
6b5ae6f528 Updates to range processing including view hint. 2021-12-01 12:15:17 -08:00
Yana De Pauw
16e704a285 85276: Store and retrieve the Authentication method in the JWT 2021-12-01 15:33:13 +01:00
Luca Giamminonni
651ecbf458 Fixed tests context mode 2021-11-29 18:52:03 +01:00
Luca Giamminonni
33a07d2f14 Fix tests 2021-11-29 18:06:45 +01:00
Luca Giamminonni
c2494db11a Fixed context's mode handling to improve performances 2021-11-29 17:13:31 +01:00
Yura Bondarenko
e37fd1df8f 85137: Add H2 migration 2021-11-26 14:20:05 +01:00
Yura Bondarenko
2939ae0a16 85137: Add Oracle migration 2021-11-26 14:20:05 +01:00
Yura Bondarenko
9df531299b Add migration to fix MDV place 2021-11-26 14:20:05 +01:00
Ben Bosman
f179436284 Avoid incorrect sort 2021-11-26 12:12:24 +01:00
Davide Negretti
831dc21c94 [CST-4882] Code cleanup 2021-11-25 19:40:38 +01:00
Davide Negretti
800eeff984 [CST-4882] Return 422 instead of 500 when solr query is not valid 2021-11-25 19:22:47 +01:00
Joost
8e62c0496c [task 82428] setting a timeout on calls to IRUS 2021-11-25 15:33:23 +01:00
Tim Donohue
dcfa74a2c3 Merge pull request #8040 from clairtonluz/patch-1
Upgrade aws-java-sdk-s3 version to avoid exception on start "Socket n…
2021-11-24 08:43:00 -06:00
Clairton Luz
7fca858260 Upgrade aws-java-sdk-s3 version to avoid exception on start "Socket not created by this factory"
Current docker imagem `dspace/dspace:dspace-7.1` when enable s3Store into bitstore.xml throw exception  when start application beacause of the current version of `aws-java-sdk-s3` is incompatible with java 11. So I upgrade version to resolve the problem.
2021-11-24 08:55:42 -03:00
Mark H. Wood
c462415a64 Add unit test. #7986 2021-11-23 14:44:10 -05:00
Mark H. Wood
23b0ae1c4d Make connection maximum lifetime configurable. #7986 2021-11-23 14:42:59 -05:00
Mark H. Wood
de9d1a8cd8 Initialize correctly. More generous pool defaults. 2021-11-23 14:42:59 -05:00
Mark H. Wood
5855850cd1 Make pool service injectable. 2021-11-23 14:42:59 -05:00
Mark H. Wood
bb8d3d853a Define pool configuration properties 2021-11-23 14:42:59 -05:00
Mark H. Wood
070b611814 First attempt at a single pool of HTTP connections for Solr. 2021-11-23 14:42:59 -05:00
William Welling
1db8e382d5 chown app directory during dependency images build (#8035) 2021-11-23 11:04:51 -06:00
pablo
b7f07da8a2 Fix condition for metadata validation if is Authority Controlled 2021-11-23 09:00:37 -03:00
Tim Donohue
5fe021d28d Merge pull request #8038 from 4Science/fix-entity-type-test
Fixed InitializeEntitiesIT destroy method to not delete none entity type
2021-11-22 12:40:47 -06:00
Luca Giamminonni
d2430193b1 Improved InitializeEntitiesIT destroy method to not delete none entity type 2021-11-22 18:02:47 +01:00
Tim Donohue
7fda074543 Merge pull request #7994 from mwoodiupui/7988
Ensure that a mapped Item is exported only once.
2021-11-11 16:16:24 -06:00
Tim Donohue
e01ec94881 Remove ShibbolethRestController and move code into ShibbolethLoginFilter. 2021-11-11 13:51:28 -06:00
Tim Donohue
21549d0198 Rename ShibbolethAuthenticationFilter to ShibbolethLoginFilter 2021-11-11 13:51:28 -06:00
Tim Donohue
a4eda30103 Remove unused parameters from several auth related methods. 2021-11-11 13:51:28 -06:00
Tim Donohue
a4a00a8949 Refactor DSpaceAuthentication object to make it clearer when user is authenticated and when they are not. Fix a few usages in code 2021-11-11 13:45:08 -06:00
jose vicente ribelles aguilar
e3ea3626cb Update V7.0_2019.11.13__relationship_type_copy_left_right.sql
Error Message:
ORA-00984: column not allowed here.

No BOOLEAN type in ORACLE.
2021-11-09 11:35:41 +01:00
jose vicente ribelles aguilar
0361ed59fe Update V7.0_2018.04.16__dspace-entities.sql
shorten identifiers to less than 30 characters
2021-11-09 10:32:36 +01:00
jose vicente ribelles aguilar
e0fc4fe345 Update V7.0_2018.04.16__dspace-entities.sql
no type uuid. Change uuid for raw(16)
2021-11-09 10:26:50 +01:00
jose vicente ribelles aguilar
d61e98cf32 Update V7.0_2019.07.31__Retrieval_of_name_variant.sql
Specify length. Use VARCHAR2 instead of VARCHAR
2021-11-09 10:22:14 +01:00
astrowq
13eb4a4587 simple code refactoring 2021-11-05 19:08:00 +01:00
astrowq
b1b08b21c6 fix the date parsing error with the format "yyyy-mm-dd" 2021-11-05 19:08:00 +01:00
Tim Donohue
ae6f795f20 Merge pull request #8026 from DSpace/fix_8016
Fix two ITs for stability (PackagerIT.destroy() and RelationshipTypeRestControllerIT.findAllEntityTypes)
2021-11-05 12:44:48 -05:00
Tim Donohue
4c23431d40 Add missing @Override 2021-11-05 11:07:49 -05:00
Tim Donohue
b990d75d9e Fix a recently broken IT by including "none" entity type 2021-11-05 10:19:25 -05:00
Tim Donohue
b242d20055 Fix IT by ensuring it calls super.destroy() 2021-11-04 16:45:30 -05:00
Tim Donohue
e297d98095 [maven-release-plugin] prepare for next development iteration 2021-10-28 13:49:02 -05:00
Tim Donohue
c2e31d08ef [maven-release-plugin] prepare release dspace-7.1 2021-10-28 13:48:56 -05:00
Tim Donohue
f025e81713 Update LICENSES_THIRD_PARTY for v7.1 2021-10-28 10:26:53 -05:00
Tim Donohue
97d0a1f128 Merge pull request #8013 from 4Science/improve-handing-of-default-bitstream-read-policies
Improve handing of default bitstream read policies
2021-10-26 12:11:22 -05:00
Tim Donohue
c3bea16ab9 Merge pull request from GHSA-cf2j-vf36-c6w8
Default groups issue
2021-10-26 11:31:42 -05:00
Tim Donohue
f21b16c255 Merge pull request #8014 from 4Science/re-enableITtest
Re-enable IT test EntityTypeRestRepositoryIT#findAllByAuthorizedExternalSource
2021-10-25 17:17:32 -05:00
Mykhaylo
d3ba3b6c71 fix failed test 2021-10-25 21:30:39 +02:00
Andrea Bollini
16cf19bed0 IT to proof that DSpace/DSpace#7928 is solved 2021-10-25 19:03:57 +02:00
Andrea Bollini
277b499a5c Fix for GHSA-cf2j-vf36-c6w8 2021-10-25 19:01:36 +02:00
Tim Donohue
70ffeaac30 Merge pull request #7941 from 4Science/CST-4503-AddingNewRelationshipsInEditItem
Adding new Relationships in Edit Item is difficult for entities with many relationships - REST
2021-10-25 10:09:05 -05:00
Andrea Bollini
0de9680781 Add tests against permission escalation 2021-10-25 16:55:24 +02:00
Mykhaylo
7c10aeccbf minor fix 2021-10-25 16:19:27 +02:00
Mykhaylo
4b21327a8e Merge branch 'main' into improve-handing-of-default-bitstream-read-policies 2021-10-25 16:18:13 +02:00
Mykhaylo
c3eb1cfed6 refactoring 2021-10-25 16:13:01 +02:00
Tim Donohue
c9e36c8659 Merge pull request #8000 from tdonohue/iiif_docker
Add docker-compose script for IIIF server
2021-10-22 12:18:12 -05:00
Tim Donohue
dbb8ce726d Merge pull request #3210 from mspalti/iiif-endpoint
IIIF REST API
2021-10-22 12:16:58 -05:00
Mykhaylo
ee857f9412 add support to enable/disable append-mode of DefaultReadGroups via conf 2021-10-22 18:40:45 +02:00
Tim Donohue
b4ff0dcf06 Update docker-compose README with details of dspace-iiif 2021-10-22 11:28:08 -05:00
Tim Donohue
6c4aa01267 Merge pull request #2248 from KingKrimmson/DS-2904_Asynchronous_Google_Analytics
DS-2904 Asynchronous & Batch Google Analytics Reporting
2021-10-22 10:13:30 -05:00
Tim Donohue
b7f15ca20d Merge pull request #8001 from paulo-graca/openaire-funding-support-abstractexternaldataprovider
Openaire funding support abstractexternaldataprovider
2021-10-22 09:47:23 -05:00
Paulo Graça
0191bf1431 make adjustments to findExternalSourcesByEntityTypeTest 2021-10-22 11:41:58 +01:00
Paulo Graça
4022099bf9 Merge branch 'main' of https://github.com/DSpace/DSpace into openaire-funding-support-abstractexternaldataprovider 2021-10-22 08:53:22 +01:00
Michael W Spalti
0d9e2d317d Minor comment change. 2021-10-21 15:35:09 -07:00
Michael W Spalti
99230934a0 Removed unused property. 2021-10-21 14:30:06 -07:00
Michael W Spalti
c6565da35c Merge branch 'main' into iiif-endpoint 2021-10-21 14:07:47 -07:00
Tim Donohue
5eacdd169e Merge pull request #8009 from tdonohue/fix_compilation_errors
Fix main branch IT compilation errors after merging #7962
2021-10-21 15:58:43 -05:00
Tim Donohue
b6ec08746e Disable broken test temporarily 2021-10-21 15:00:53 -05:00
Tim Donohue
3e05832a38 Fix two fragile tests which broke whenever configs changed 2021-10-21 13:24:22 -05:00
Michael W Spalti
ddba1cc4e8 Merge branch 'main' into iiif-endpoint 2021-10-21 10:30:41 -07:00
Michael W Spalti
c4e5725bdd Unused import. 2021-10-21 10:08:45 -07:00
Tim Donohue
96c41ff022 Fix main branch IT compilation errors after merging #7962 2021-10-21 10:24:23 -05:00
Tim Donohue
0976f05f29 Merge pull request #7962 from 4Science/CST-4509-assignAnEntityTypeToCollection
Assign an entity type to collection
2021-10-21 10:05:29 -05:00
Michael W Spalti
0198efce69 Updated classes to call ContextUtil.obtainContext with HttpServletRequest objects. 2021-10-20 16:08:53 -07:00
Michael W Spalti
79c0a9662b Merge branch 'main' into iiif-endpoint 2021-10-20 15:55:27 -07:00
Michael W Spalti
33966cc4cb Unused import in test. 2021-10-20 15:38:55 -07:00
Michael W Spalti
c7c04db576 Optional iiif configuration and javadoc. 2021-10-20 15:06:47 -07:00
Tim Donohue
4e98a91c4b Merge pull request #3371 from 4Science/CST-4469-ItemVersioning
Item Versioning
2021-10-20 11:17:48 -05:00
Paulo Graça
736d1dbeaa change to extend openaire lookup from AbstractExternalDataProvider 2021-10-19 21:57:40 +01:00
Paulo Graça
0a0cf18c36 Merge branch 'CST-4509-assignAnEntityTypeToCollection' of https://github.com/4Science/DSpace into feature-issue2816-openaire-funding-external-lookup 2021-10-19 21:52:53 +01:00
Mykhaylo
fb2288e8a2 Merge branch 'main' into CST-4469-ItemVersioning 2021-10-19 18:45:49 +02:00
Tim Donohue
3573ebd505 Merge pull request #3365 from paulo-graca/feature-issue2816-openaire-funding-external-lookup
OpenAIRE funding external source feature
2021-10-19 09:13:47 -05:00
Tim Donohue
3fc06ef400 Merge pull request #2129 from mwoodiupui/DS-3952
[DS-3952] Expose Request Copy
2021-10-19 09:09:27 -05:00
Tim Donohue
84fdc9567c Add docker-compose script for IIIF server 2021-10-18 17:06:17 -05:00
Michael W Spalti
00cd727e0f Updated to a method signature. 2021-10-18 14:08:55 -07:00
April Herron
7764ccb00f DS-2904 GA Code cleanup 2021-10-18 14:13:51 -04:00
Mykhaylo
534a16254c minor update 2021-10-18 15:42:37 +02:00
Andrea Bollini
dfead9f29e Add attributions to the main iiif classes 2021-10-16 22:02:25 +02:00
Andrea Bollini
ca82a297c5 Fix consumer to avoid early initialization of the iiif cache evict service 2021-10-16 21:52:35 +02:00
Tim Donohue
6059a57aef Merge pull request #7999 from tdonohue/docker-solr-config-update
[Docker] Ensure any updated Solr configs are copied over to existing cores
2021-10-15 16:33:45 -05:00
Tim Donohue
7226e2d7c0 Merge pull request #7990 from paulo-graca/openaire-oai-bugfix-language
Openaire 4: oai bugfixes for language and publisher
2021-10-15 15:37:57 -05:00
Tim Donohue
e6b690a5f6 Merge pull request #7973 from abollini/performance-improvements
Performance improvements
2021-10-15 14:36:19 -05:00
Tim Donohue
08de317095 Merge pull request #7996 from atmire/find_all_top_communities_performance
Find all top communities performance improvements
2021-10-15 14:35:42 -05:00
Mykhaylo
e6cfdf7df6 Implement community feedbacks 2021-10-15 17:37:19 +02:00
Tim Donohue
9f1704f91f Ensure any updated Solr configs are copied over to running cores 2021-10-15 09:57:24 -05:00
Joost
8f23351758 [task 84277] ensuring the right exception is expected when multiple items with the same handle get installed 2021-10-15 15:56:03 +02:00
Michael Spalti
c30721b55a Adding rendering to manifest instead of sequence. 2021-10-14 13:58:28 -07:00
Michael Spalti
f19d01cb5c Added iiif consumer to default dispatcher. 2021-10-14 12:54:13 -07:00
Michael Spalti
138ae70a32 Docs update. 2021-10-14 12:53:39 -07:00
Michael Spalti
9a8ba86b5e Using dspace-api ContextUtil with iiif controller. 2021-10-14 12:52:10 -07:00
Tim Donohue
2255e91af1 Merge pull request #7955 from 4Science/CST-4507_multiple_authorizations
endpoint to find with a single call many authorizations for multiple objects and features
2021-10-14 10:19:48 -05:00
Paulo Graça
c4ffbe10be remove openaire API token placeholders 2021-10-14 12:52:02 +01:00
Marie Verdonck
a0e92a5f18 84100: Admin only files rights issue IT 2021-10-14 13:22:08 +02:00
Marie Verdonck
d6a9bca578 84100: Admin only files rights issue 2021-10-14 13:22:04 +02:00
Corrado Lombardi
3d3608cf48 [CST-4507] removed commented code 2021-10-14 12:59:57 +02:00
Paulo Graça
dec8e765b3 Merge branch 'feature-issue2816-openaire-funding-external-lookup' of github.com:paulo-graca/DSpace into feature-issue2816-openaire-funding-external-lookup 2021-10-14 11:54:47 +01:00
Paulo Graça
69f5b03073 Merge branch 'main' of https://github.com/DSpace/DSpace into feature-issue2816-openaire-funding-external-lookup 2021-10-14 11:06:28 +01:00
Mykhaylo
67ed399c7b added test to verify IllegalStateException 2021-10-14 11:39:28 +02:00
Ben Bosman
47a97b2b21 find all top communities performance 2021-10-14 10:40:00 +02:00
Michael Spalti
70de1bc61c Moved iiif to separate module. 2021-10-13 18:35:33 -07:00
Mark H. Wood
6bedbf09a4 Ensure that a mapped Item is exported only once. #7988 2021-10-13 14:26:52 -04:00
Michael W Spalti
3870e362c3 Javadoc for iiif interfaces. 2021-10-13 10:22:21 -07:00
Michael W Spalti
2f74887c8f Updated iiif configuation. 2021-10-13 10:05:00 -07:00
Mykhaylo
8e408adc5d Merge branch 'main' into CST-4469-ItemVersioning 2021-10-13 12:01:25 +02:00
Mykhaylo
81b5c294dc Merge branch 'main' into CST-4503-AddingNewRelationshipsInEditItem 2021-10-13 11:58:23 +02:00
Mykhaylo
b9b6f40c8b Merge branch 'main' into CST-4509-assignAnEntityTypeToCollection 2021-10-13 11:49:38 +02:00
Tim Donohue
d9d24427af Merge pull request #7952 from atmire/w2p-83661_Port-harvest-to-scripts-and-processes
Port harvest to scripts and processes
2021-10-12 16:18:24 -05:00
Tim Donohue
c224e9435d Merge pull request #7983 from 4Science/CST-4636-RelationshipTypeEmbeddingNotWorking
RelationshipType embedding not working
2021-10-12 09:29:18 -05:00
Mykhaylo
cbdebd3e97 fix LGTM notes 2021-10-11 16:08:06 +02:00
Yana De Pauw
61025c1c95 83707: Fix parameter types of harvest script config 2021-10-11 15:57:12 +02:00
Mykhaylo
980ac528a2 Implement community feedbacks 2021-10-11 15:07:08 +02:00
Paulo Graça
a1f8c34035 Merge branch 'main' of https://github.com/DSpace/DSpace into openaire-oai-bugfix-language 2021-10-11 13:19:39 +01:00
Paulo Graça
95b3b2816d fix issue 3102 2021-10-11 13:14:55 +01:00
Michael Spalti
40e3291988 Work on test for iiif cache consumer. 2021-10-08 12:38:14 -07:00
Tim Donohue
3259b134be Merge pull request #7976 from 4Science/ImpossibleToDeleteWrkflowGroupsMigratedFromApreviousDSpaceVersion
Impossible to delete workflow groups migrated from a previous DSpace version using the old legacy workflow
2021-10-08 14:32:55 -05:00
Mykhaylo
62917409a4 add JavaDoc 2021-10-08 15:06:21 +02:00
Joost
724ea77ef7 implementing feedback 2021-10-08 12:28:30 +02:00
Mykhaylo
df7231e6b6 restore the original tests 2021-10-08 11:45:10 +02:00
Mykhaylo
f0b60cf8ce fix failed test 2021-10-08 10:13:26 +02:00
Michael Spalti
5ecca8d905 Added iiif to default consumers. 2021-10-07 12:14:16 -07:00
Michael Spalti
f15a18254e Added component annotations.
Added comment.

Fixed import.
2021-10-07 12:13:27 -07:00
Michael Spalti
f92592846d Added "org.dspace.iiif" to component scan in ApplicationConfig. 2021-10-07 11:52:10 -07:00
Michael Spalti
cca91707b9 Updated event consumer. 2021-10-07 10:49:45 -07:00
Mykhaylo
df5976f51a Merge branch 'main' into CST-4509-assignAnEntityTypeToCollection 2021-10-07 19:19:02 +02:00
Mykhaylo
bc89365621 Implement community feedbacks 2021-10-07 19:09:20 +02:00
Tim Donohue
5da7853fc0 Merge pull request #7963 from tdonohue/fix_7196
REST API items resource returns items in non-deterministic order (main port)
2021-10-07 11:15:08 -05:00
Tim Donohue
78dd106182 Merge pull request #7979 from 4Science/CST-4659
Hint fixed for dc.type
2021-10-07 11:14:37 -05:00
Tim Donohue
5d91ff2564 Merge pull request #3329 from atmire/w2p-80200_Retain_UUIDs
Fix #3330: Retain UUIDs on packager restore
2021-10-07 11:12:08 -05:00
Tim Donohue
028df96e0d Merge pull request #3322 from tysonlt/import_relationships
Import relationships via SAF (Simple Archive Format)
2021-10-06 15:00:17 -05:00
Michael Spalti
cde623c344 Moved iiif event consumer to dspace-api. 2021-10-06 12:48:22 -07:00
Mark H. Wood
db72b43f0f [DS-3952] Don't allow accept/reject of a completed request. 2021-10-06 13:19:52 -04:00
Mark H. Wood
55beed65ba [DS-3952] Don't create a RequestItem until #build() is called. 2021-10-06 13:18:57 -04:00
Mykhaylo
47712ecde3 minor fix 2021-10-06 18:36:37 +02:00
Mykhaylo
0dfee17944 added tests 2021-10-06 17:45:43 +02:00
Mykhaylo
65dc9cbb14 converted RelationshipTypeRestController in link repository 2021-10-06 17:45:07 +02:00
Mark H. Wood
1dc4f629f2 [DS-3952] Identify OA request with approver, not requester. Document OA request template. 2021-10-06 11:31:21 -04:00
Davide Negretti
c516f9c856 [CST-4659] hint fixed for dc.type 2021-10-06 17:08:53 +02:00
tysonlt
486a509050 Merge branch 'DSpace:main' into import_relationships 2021-10-05 12:36:39 +11:00
Tyson Lloyd Thwaites
11bea56988 fixed checkstyle violation 2021-10-05 12:15:37 +11:00
Mykhaylo
8bdd1138eb implemented flyway script to delete deprecated columns 2021-10-04 16:24:42 +02:00
Tyson Lloyd Thwaites
00740cc021 don't attempt to create relationships in test mode 2021-10-04 14:40:29 +11:00
Tyson Lloyd Thwaites
c01f4c1ca0 Fix broken command-line collection arg 2021-10-04 14:04:24 +11:00
Tyson Lloyd Thwaites
93bdf9add6 Removed relationships flag 2021-10-04 14:03:29 +11:00
Michael Spalti
597cf4efb5 Configuration update. 2021-10-02 13:28:16 -07:00
Michael Spalti
7905e8cc25 Updated consumer. 2021-10-02 13:27:52 -07:00
Mykhaylo
6385df9779 minor fix 2021-10-02 12:33:47 +02:00
Michael Spalti
67012de266 Added comment to dspace.cfg. 2021-10-01 15:47:50 -07:00
Michael Spalti
26456121aa Completed consumer used to manage iiif cache. 2021-10-01 15:33:25 -07:00
Michael Spalti
efc9327cae Cache add. 2021-10-01 15:03:59 -07:00
Mark H. Wood
092cfc364c [DS-3952] Enable sending admin. request to open access to requested item. 2021-10-01 14:19:37 -04:00
Mark H. Wood
7e6326619d [DS-3952] Log Velocity errors. 2021-10-01 14:17:51 -04:00
Mark H. Wood
8cbdc100df [DS-3952] Use correct template for OA request. 2021-10-01 14:16:47 -04:00
Mark H. Wood
64f900fd95 Implement Open Access request message to admin.s for Item Request. 2021-10-01 10:43:20 -04:00
Tim Donohue
ff4b1b3675 Merge pull request #7948 from tdonohue/upgrade_postgres_flyway
Upgrade to latest PostgreSQL driver 42.2.x and Flyway 6.x
2021-10-01 09:40:57 -05:00
Tim Donohue
c91c7caf1a Update to Postgres JDBC driver 42.2.24 2021-09-30 16:49:23 -05:00
Andrea Bollini
969a29f89e Avoid to search current user by email 2021-09-30 21:13:12 +02:00
Andrea Bollini
3131c50e92 Reorder authz check to prioritize the cheaper ones 2021-09-30 21:10:40 +02:00
Mark H. Wood
5787be3dae [DS-3952] Proper test for wrong authenticated user. 2021-09-30 14:42:51 -04:00
Michael Spalti
71cbf70865 Excluding OtherContent bundle from bundles that can contain iiif image resources. 2021-09-30 11:07:45 -07:00
Michael Spalti
d1c31735f4 Fixed identifiers for range canvas references. 2021-09-30 11:06:29 -07:00
Mark H. Wood
af20f0b8d8 [DS-3952] Test successful PUT more thoroughly, add tests for bad PUTs. 2021-09-30 13:42:54 -04:00
Tim Donohue
9c5c21f66a Merge pull request #7947 from atmire/w2p-81832_Solr-Search-core-fix-index-Authority-Mdv-without-vocabulary-or-pairs-type
W2p 81832 solr search core fix index authority mdv without vocabulary or pairs type
2021-09-30 10:11:12 -05:00
Mark H. Wood
f715667f36 Merge branch 'DS-3952' of github.com:mwoodiupui/DSpace into DS-3952 2021-09-30 08:40:56 -04:00
Mark H. Wood
aa9880f0f5 [DS-3952] Adopt agreed-upon URL pattern for linking back from request email. 2021-09-30 08:39:36 -04:00
Corrado Lombardi
d88e4f4b6f [CST-4507] checkstyle fix 2021-09-30 12:44:44 +02:00
Mykhaylo
16d0059bcd add support to enable/disable the versioning features via conf 2021-09-30 12:40:33 +02:00
Corrado Lombardi
5e92a5374a [CST-4507] added mandatory parameters and some little improvements in tests readability 2021-09-30 12:16:01 +02:00
Corrado Lombardi
1cd0cc3c2a [CST-4507] little code refactoring and updated test behaviour 2021-09-30 09:54:10 +02:00
Mark H. Wood
1f15e032fb [DS-3952] Item request tokens should match 32 base-16 digits, not base-36. 2021-09-29 16:32:23 -04:00
Mark H. Wood
fb7fd3b279 [DS-3952] Make PUT return codes conform to contract. 2021-09-29 13:21:04 -04:00
Mykhaylo
61a9edfe05 restore latest test and fix the bug 2021-09-29 16:34:15 +02:00
Yana De Pauw
9148fc37d8 83795: Harvest script fixes 2021-09-29 15:57:34 +02:00
Mark H. Wood
d4da4eac1d Merge branch 'main' into DS-3952 2021-09-29 07:51:58 -04:00
Mykhaylo
3fe4e2d170 fix duplicate method 2021-09-29 13:36:45 +02:00
Mykhaylo
d6d2f27483 added javaDoc 2021-09-29 13:34:46 +02:00
Mykhaylo
330e3f5838 fix pagination bug and add the JavaDocs 2021-09-29 12:03:28 +02:00
Mykhaylo
9f237b1188 added test to prove pagination bug 2021-09-29 12:00:48 +02:00
Mykhaylo
bdbafee72c fix failed tests 2021-09-29 11:42:13 +02:00
Andrea Bollini
cb55947592 Merge branch 'iiif-endpoint' of https://github.com/mspalti/DSpace into iiif-endpoint 2021-09-29 10:06:13 +02:00
Michael Spalti
aa8c64f8ab Added todo notice to cache configuration class. 2021-09-28 16:09:30 -07:00
Michael Spalti
0c48606ebe Added null check in canvas service to prevent exception in iiif metadata model. 2021-09-28 16:00:03 -07:00
Andrea Bollini
ea61bc3b83 Add test to proof behavior with restricted items 2021-09-28 23:30:17 +02:00
Andrea Bollini
a41574dbdb fix locale setting in the obtainContext method 2021-09-28 23:12:58 +02:00
Tim Donohue
e5e4bbed5f Merge pull request #7954 from atmire/w2p-83695_Issue-3291_Scripts&processes-error-handling
Scripts & processes error handling
2021-09-28 13:37:31 -05:00
Tim Donohue
fb3e610a24 Merge pull request #7950 from mwoodiupui/7935
Replace now-ignored test log4j.properties files with log4j2-test.xml
2021-09-28 12:12:24 -05:00
Mykhaylo
f6e23f2061 Implement community feedbacks 2021-09-28 19:02:51 +02:00
Paulo Graça
267f24ecf0 fix indentation - 2nd try 2021-09-28 10:49:11 +01:00
Michael Spalti
327f800c5f Fixed lgtm alerts. 2021-09-27 16:22:59 -07:00
Michael Spalti
71eb1429e0 Merge branch 'main' into iiif-endpoint 2021-09-27 15:03:22 -07:00
Michael Spalti
a4a27f0795 More updates after merging PR#1. 2021-09-27 14:11:12 -07:00
Michael Spalti
9a5a5d636f Merge branch '4Science-pr' into iiif-endpoint 2021-09-27 11:49:30 -07:00
Michael Spalti
e42b9dff99 Minor iiif.cfg updates. 2021-09-27 11:07:02 -07:00
Michael Spalti
42d82cf322 Updated imports for style check. 2021-09-27 10:26:26 -07:00
Michael Spalti
fc3e68edba Search service update. 2021-09-27 10:26:07 -07:00
Michael Spalti
da4c5774e8 Added not implemented exception for search service. 2021-09-27 10:24:59 -07:00
Paulo Graça
7c9fb86c18 Merge branch 'main' of https://github.com/DSpace/DSpace into feature-issue2816-openaire-funding-external-lookup 2021-09-27 17:29:55 +01:00
Tim Donohue
b692b9e9dd Ensure ItemDAOImpl queries are all ordered by UUID 2021-09-27 11:00:08 -05:00
Mykhaylo
bc0805017f Merge branch 'main' into CST-4509-assignAnEntityTypeToCollection 2021-09-27 16:41:30 +02:00
Andrea Bollini
5aeead4fa4 Merge pull request #7949 from tdonohue/it_cleanup
Integration Test Cleanup
2021-09-27 16:15:05 +02:00
Andrea Bollini
21032f66a5 Finalize configuration via metadata refactoring and hierarchical range support 2021-09-26 22:59:38 +02:00
Michael Spalti
84ef661cfb Updated experimentatal search plugin support to use full package name. 2021-09-26 13:07:50 -07:00
Michael Spalti
a22fe26d2f Additional documentation in iiif.cfg file. 2021-09-26 13:07:04 -07:00
Michael Spalti
3252b541f8 Updated javadocs and changed generator interface. 2021-09-26 12:46:45 -07:00
Mykhaylo
cc1e031863 Merge branch 'main' into CST-4509-assignAnEntityTypeToCollection 2021-09-26 10:47:03 +02:00
April Herron
54af86d52a DS-2904 Asynchronous Google Analytics Reporting 2021-09-24 16:56:27 -04:00
Mark H. Wood
5bd3806753 Email tests must be unauthenticated.
Authenticated creation uses session user and ignores corresponding request
parameters.
2021-09-24 14:09:48 -04:00
Mark H. Wood
59befb62aa [DS-3952] Bitstream is optional if allfiles:true. Implement and test. 2021-09-24 13:18:59 -04:00
Andrea Bollini
5916f610b3 Fix range generation and improve basic structure test 2021-09-24 19:18:45 +02:00
Mykhaylo
d498882d6f fix failed tests 2021-09-24 18:22:42 +02:00
Mykhaylo
b750e1d250 fix failed tests 2021-09-24 17:39:06 +02:00
Paulo Graça
b250134c85 xml identation fixes 2021-09-24 16:27:12 +01:00
Mykhaylo
302370db72 update flyway script 2021-09-24 16:21:30 +02:00
Mykhaylo
d02dd47bb1 implemented flyway script to add new entity type 'unset' 2021-09-24 15:13:06 +02:00
Mykhaylo
7140d4ca5c fix failed tests 2021-09-24 13:08:55 +02:00
Mykhaylo
b2996ab784 fix failed tests 2021-09-24 12:47:51 +02:00
Mykhaylo
4a5546fa34 added supported entity types for external providers 2021-09-24 12:28:45 +02:00
Mykhaylo
23ad982a6e fix failed tests 2021-09-24 11:23:47 +02:00
Mark H. Wood
7ce6333ea4 Merge remote-tracking branch 'upstream/main' into DS-3952 2021-09-23 13:53:48 -04:00
Mark H. Wood
8531e22fd4 [DS-3952] Require authenticated PUT, authenticate PUT test, authorize test PUT. 2021-09-23 13:45:51 -04:00
Mark H. Wood
2b61176255 [DS-3952] New request mapping for 32-hex-digit item request tokens, so
requests are dispatchable.

Also remove some voluminous debugging output.
2021-09-23 13:42:36 -04:00
Mykhaylo
5c52a6926f Merge branch 'main' into CST-4469-ItemVersioning 2021-09-23 12:52:13 +02:00
Mykhaylo
dee324762b minor fix 2021-09-23 12:33:11 +02:00
Mark H. Wood
c484bec18f [DS-3952] Implement PUT to accept/deny item requests. Fix errors in IT. 2021-09-22 16:27:10 -04:00
Tim Donohue
4856acde2c RelationshipTypeBuilder is cleaning up more than it should. Place it after ItemBuilder cleanup so that Items are removed prior to RelationshipTypes 2021-09-22 14:39:12 -05:00
Tim Donohue
851161cfd9 General minor code cleanup in ITs 2021-09-22 14:37:15 -05:00
Tim Donohue
6ce49eb332 Fix AuthorizationFeatureServiceIT to extend AbstractControllerIntegrationTest 2021-09-22 14:37:14 -05:00
Tim Donohue
e6fce0778c Ensure CSVMetadataImportReferenceIT cleans up Items that it creates 2021-09-22 14:37:14 -05:00
Tim Donohue
e2a95c49c5 Merge pull request #3063 from mwoodiupui/3061
Fix many warnings from errorprone
2021-09-22 14:26:08 -05:00
Paulo Graça
ecd6510e21 changing mock usage externalservice 2021-09-22 20:16:11 +01:00
Nathan Buckingham
1f552683a7 Remove unecessary deletion 2021-09-22 14:57:24 -04:00
Paulo Graça
26068b0f20 adding openaire funding unit tests 2021-09-22 19:24:54 +01:00
Mykhaylo
84315b93a0 assigne collection entity type to item during submission proccess 2021-09-22 18:09:39 +02:00
Mykhaylo
82ff056681 implemented endpoint that is able to retrieve supported entity types provided an external provider and tests 2021-09-22 18:07:23 +02:00
Andrea Bollini
d25c74f001 Intermediate commit - refactoring to rely on metadata for feature activation and configuration 2021-09-22 18:00:29 +02:00
Corrado Lombardi
c7c7c37a2b [CST-4507] endpoint to find with a single call many authorizations for multiple objects and multiple features 2021-09-22 16:27:50 +02:00
Yura
cb40adaf43 83695: End REST process execution after handling exceptions 2021-09-22 14:33:09 +02:00
Paulo Graça
5366e433bd missing escaping query from getNumberOfResults 2021-09-22 11:30:57 +01:00
Paulo Graça
74e47841f4 add DSpace license 2021-09-22 11:30:05 +01:00
Paulo Graça
77048cbe1d checkstyle fixes 2021-09-22 10:12:54 +01:00
Paulo Graça
6b4261c469 checkstyle fixes 2021-09-22 10:06:56 +01:00
Mykhaylo
a3a1019db7 implemented entityType and externalSources end points and tests 2021-09-21 18:56:39 +02:00
Paulo Graça
812cf1fad5 Merge branch 'main' of https://github.com/DSpace/DSpace into feature-issue2816-openaire-funding-external-lookup 2021-09-21 16:40:59 +01:00
Paulo Graça
ded4f334ec adding integration tests 2021-09-21 16:37:59 +01:00
Mykhaylo
6433df2d9e implemented findSubmitAuthorizedByCommunityAndEntityType end point 2021-09-21 17:33:45 +02:00
Yana De Pauw
189ea97ffb 83661: Fix license issues 2021-09-21 14:47:33 +02:00
Yana De Pauw
ed29084ccb 83661: Port harvest script to scripts and processes 2021-09-21 13:14:14 +02:00
Tyson Lloyd Thwaites
ebd2b89272 Removed processRelationships property 2021-09-21 09:44:42 +10:00
Michael Spalti
09d8981227 Updated javadoc. 2021-09-20 13:59:29 -07:00
Mark H. Wood
e5b23db673 Replace now-ignored test log4j.properties files with log4j2-test.xml. [7935] 2021-09-20 10:54:29 -04:00
Mykhaylo
496bb35eea Implement community feedbacks 2021-09-20 16:37:43 +02:00
Andrea Bollini
276fe2297f Refactor the IIIFRestRepository to avoid inheritance from DSpaceRestRepository 2021-09-20 15:01:28 +02:00
Mark H. Wood
1b366f8b74 Address review comments: missed some isEmpty fixes. [#3061] 2021-09-20 08:55:11 -04:00
Mykhaylo
25cfa7c750 implemented findByEntityType collection end point 2021-09-20 10:00:30 +02:00
Mykhaylo
ef07aabbe1 added tests for findByEntity collection end point 2021-09-20 09:54:47 +02:00
Tim Donohue
ce0c211b57 Merge pull request #7945 from tdonohue/database_force_migrate
Add 'dspace database migrate force' to manually trigger Flyway Callbacks
2021-09-17 12:44:56 -05:00
Michael Spalti
bd6fea1318 Correction to iiif cors configuration. 2021-09-16 14:50:42 -07:00
Michael Spalti
facadf47df Moved default iiif configuration to iiif.cfg. 2021-09-16 14:28:43 -07:00
Tim Donohue
6f27b82aa6 Upgrade to latest PostgreSQL driver 42.2.x and Flyway 6.x 2021-09-16 16:19:38 -05:00
Michael Spalti
5ff3bed4e2 Fixed the canvas identifier in search annotions. 2021-09-16 14:06:14 -07:00
Mark H. Wood
9f463239d2 Address new LGTM alert for removed parameter. (#3061) 2021-09-16 13:23:48 -04:00
Tim Donohue
7ce2a95f6d Merge pull request #7934 from atmire/w2p-83338_Fix-MetadataValue-Move-Patch-operation-bugs
Fix metadata value move patch operation bugs
2021-09-16 11:19:12 -05:00
Mykhaylo
87040d154f fix canDeleteVersion feature bug and removed unused dependency 2021-09-16 17:04:18 +02:00
Mykhaylo
f80ad97d95 added test to show bug in canDeleteVersion feature 2021-09-16 17:01:28 +02:00
Nathan Buckingham
6696cb7c9c Make handle something that could never be ran into 2021-09-16 10:12:46 -04:00
Nathan Buckingham
a5103dbd39 Create setup and destory to cleanup items from test file 2021-09-16 10:00:36 -04:00
Mark H. Wood
106d37404b Fix incorrect merge. (#3061) 2021-09-16 08:41:42 -04:00
Mykhaylo
30e1b076f0 implemented management of entity type in item versioning 2021-09-16 12:35:19 +02:00
Mykhaylo
39bd3aceb5 added test to verify the correct functioning of versioning items with entity type 2021-09-16 12:15:19 +02:00
Michael Spalti
0affa79216 Removed remaining use of generator bean factories. 2021-09-15 16:30:42 -07:00
Michael Spalti
2539800955 Made the search service a configurable plugin. 2021-09-15 16:29:30 -07:00
Mark H. Wood
6013062a08 Merge remote-tracking branch 'upstream/main' into 3061 2021-09-15 16:18:18 -04:00
Tim Donohue
372b9e2ce6 Add 'dspace database migrate force' to manually trigger Flyway Callbacks 2021-09-15 14:33:25 -05:00
Mark H. Wood
66e6e50cab [DS-3952] Catch up with other development. 2021-09-15 15:08:37 -04:00
Mark H. Wood
49485d7667 Merge remote-tracking branch 'upstream/main' into DS-3952 2021-09-15 15:02:24 -04:00
Mark H. Wood
99036178f4 [DS-3952] Check user input for valid email, escape the rest to avoid XSS. 2021-09-15 14:33:01 -04:00
Paulo Graça
b254c8eeea change entry id to a base64 value. A workaround solution for issue #7944 2021-09-15 17:23:14 +01:00
Paulo Graça
db22657e74 Merge branch 'main' of https://github.com/DSpace/DSpace into feature-issue2816-openaire-funding-external-lookup 2021-09-15 16:40:59 +01:00
Nathan Buckingham
2fd4625a7e Rebased main 2021-09-14 14:13:38 -04:00
Mykhaylo
96db8d2afc added javaDocs 2021-09-14 18:29:14 +02:00
Davide Negretti
1a5b7475f4 fixed NPE on item retrieving 2021-09-14 16:21:33 +02:00
Nathan Buckingham
ad148b529e w2p-80200 Added auth comment also run tests again 2021-09-14 10:15:06 -04:00
Nathan Buckingham
fcf077c685 w2p-80200 Remove unecessary comment 2021-09-14 10:15:06 -04:00
Nathan Buckingham
829fc7d112 w2p-80200 Tests for no force export and fix to spy on authorize service 2021-09-14 10:15:04 -04:00
Nathan Buckingham
85cbd4b31f w2p-80200 submodule accidentally pushed 2021-09-14 10:12:43 -04:00
Nathan Buckingham
e1f798fd82 w2p-80200 Add new tests for each dspace object, cleaned up java docs and authrorization inside of create 2021-09-14 10:12:43 -04:00
Nathan Buckingham
cdeb22ed7b Make tests more concise and remove catch blocks 2021-09-14 10:12:43 -04:00
Nathan Buckingham
b24da56ca2 remove left over comment 2021-09-14 10:12:43 -04:00
Nathan Buckingham
22c9b76950 move to dspace-api 2021-09-14 10:12:43 -04:00
Nathan Buckingham
cc63bbe02d quick fix for Item not being initialized 2021-09-14 10:12:43 -04:00
Nathan Buckingham
f0ae18645d Test file for export and import of packager 2021-09-14 10:12:43 -04:00
Chris Wilper
80211961c0 w2p-80200 Begin IT for packager export/import with UUID support 2021-09-14 10:12:43 -04:00
Nathan Buckingham
72fab65012 w2p-80200 Retain UUIDs of DSpace objects when using packager 2021-09-14 10:12:34 -04:00
Mykhaylo
75b6acc9f3 fix pagination bug 2021-09-14 15:21:41 +02:00
Mykhaylo
341c0ae640 added test to verify correct pagination after deleting of version 2021-09-14 15:20:01 +02:00
Mykhaylo
8e50f17248 implemented CanEditVersion feature and tests to to verify proper functioning 2021-09-14 13:24:55 +02:00
Mykhaylo
5aa5485a9c implemented CanDeleteVersion feature and tests to to verify proper functioning 2021-09-14 13:14:30 +02:00
Tim Donohue
d04b8d3881 Merge pull request #7924 from bbranan/registration-email-logging
When sending a user registration email fails, allow the log statement to include full error details
2021-09-13 14:31:34 -05:00
Tim Donohue
4ecc7a1a9a Merge pull request #3357 from mwoodiupui/DS-4548
[DS-4548] Rename DSpace's LogManager to LogHelper.
2021-09-13 14:25:49 -05:00
Mykhaylo
cc62552481 minor fix 2021-09-13 19:11:03 +02:00
Mykhaylo
0b91b40f54 refactored canCreateVersion feature 2021-09-13 17:48:15 +02:00
Mykhaylo
cd053ab9ed added test to verify proper functioning of canCreateVersion feature 2021-09-13 17:47:38 +02:00
Mykhaylo
7cc4b1db77 fix javaDoc 2021-09-13 17:44:02 +02:00
Mykhaylo
4cc3693867 added security on item version link end point 2021-09-13 14:39:35 +02:00
Mykhaylo
c3274d1704 renamed service methods 2021-09-12 14:22:23 +02:00
Mykhaylo
7b3db9da4f added ORDER BY id to sql query 2021-09-11 15:15:00 +02:00
Mykhaylo
25377a639b fix pagination 2021-09-11 13:32:02 +02:00
Mykhaylo
bb020e623a added other tests 2021-09-11 12:51:06 +02:00
Tim Donohue
3150b3c954 Merge pull request #7938 from TexasDigitalLibrary/DS-3919-7x
DS-3919: rename identifier-service-test.xml to identifier-service.xml (7.x)
2021-09-10 16:55:45 -05:00
Mark H. Wood
edd310f536 Address Error Prone complaints about tests. (#3061) 2021-09-10 12:51:24 -04:00
Mark H. Wood
384d46348a Another batch of Error Prone fixes. (#3061) 2021-09-10 11:32:58 -04:00
Mykhaylo
03ad1684cc fix test 2021-09-10 13:21:29 +02:00
Mykhaylo
3e7892df88 refactored version history end point 2021-09-10 13:10:51 +02:00
Mykhaylo
bea710aac6 removed itemVersionHistory link 2021-09-10 12:54:14 +02:00
Mykhaylo
f843cfd26a refactored VersionBuilder 2021-09-10 12:49:51 +02:00
Tim Donohue
1358c9cb3d Merge pull request #7939 from TexasDigitalLibrary/DS-4562-7x
DS-4562: Change maxwait default to 10 seconds (7.x)
2021-09-09 16:04:35 -05:00
nwoodward
2000cdd56b Change maxwait default to 10 seconds 2021-09-09 12:40:32 -05:00
nwoodward
806572c86d rename identifier-service-test.xml to identifier-service.xml 2021-09-09 11:13:18 -05:00
Mark H. Wood
4b96106ea3 Merge remote-tracking branch 'upstream/main' into 3061 2021-09-08 15:52:33 -04:00
Mark H. Wood
948014646a Mention bitstream ID in exception for better debugging. (3061) 2021-09-08 15:40:44 -04:00
Mark H. Wood
20816f945e Log and continue instead of throwing exception when caller stack is empty. 2021-09-08 13:40:53 -04:00
Mark H. Wood
35e280019f Collections.EMPTY_LIST is immutable, possibly causing addBitstream to throw exception. 2021-09-08 13:35:46 -04:00
Mykhaylo
527f7e3658 removed deprecated tests of VersionHistory end point 2021-09-08 18:11:22 +02:00
Mykhaylo
e6c9652883 refactored VersionHistory end point 2021-09-08 18:09:12 +02:00
Tim Donohue
e3ca5b9234 Merge pull request #7933 from tdonohue/IT_fixes
Attempt to fix random ConcurrentModificationExceptions in ITs
2021-09-08 10:48:13 -05:00
Tim Donohue
a3e6ff1b1b Merge pull request #3352 from DSpace/dependabot/maven/org.apache.ant-ant-1.10.11
Bump ant from 1.10.9 to 1.10.11
2021-09-08 09:21:57 -05:00
Mykhaylo
80e34e5349 refactored tests of version end point 2021-09-08 15:36:39 +02:00
Mykhaylo
52bfcafca1 refactored versions end point 2021-09-08 15:35:48 +02:00
Tim Donohue
7e969e1669 Delete groups and people after Collections/Communities, as Comm/Coll groups must be cleaned up first. 2021-09-07 13:48:33 -05:00
Mark H. Wood
f3175d56d5 Merge branch 'main' into 3061 2021-09-07 14:30:20 -04:00
Tim Donohue
4644b1f18c Fix order of Builder cleanup. Ensure all Items are deleted *before* Collections or Communities. 2021-09-07 12:57:29 -05:00
Tim Donohue
77f59cba80 Merge pull request #7926 from 4Science/CST-4482-updateCollectionMetadataOrRemovingTheAdministratorGroupWillNotProduceSolrReindex
update collection metadata or removing the administrator group will not produce solr reindex
2021-09-07 12:56:30 -05:00
Tim Donohue
4f9e9bce7a Merge pull request #2698 from toniprieto/DS-4034-strip-diacritics-master
DS-4034 - The "first few letters" search doesn't work with diacritics (master port)
2021-09-07 12:52:07 -05:00
Tim Donohue
209f25e17c Merge pull request #7931 from alanorth/update-spider-agents
DS-4587: Update spider agents
2021-09-07 11:42:46 -05:00
Tim Donohue
93f4f0935f Merge pull request #3370 from mwoodiupui/3369
o.d.core.AbstractHibernateDAO#uniqueResult has useless pagination arguments
2021-09-07 11:39:42 -05:00
Yura Bondarenko
f0079d7555 83338: Fix moveMetadata index caching issue 2021-09-07 13:51:32 +02:00
Yura Bondarenko
4b23d89727 83338: Add ITs for DSO metadata move operations
This commit should confirm that there's an issue with multi-op metadata move PATCH requests: DSpaceObjectServiceImpl.moveMetadata doesn't keep track of the changed order & messes up subsequent moves
2021-09-07 13:27:17 +02:00
Mykhaylo
4d913ecf36 fix test 2021-09-07 12:34:56 +02:00
Paulo Graça
cb7e51d687 add support for funding source at openaire project form 2021-09-07 11:05:06 +01:00
Mykhaylo
eadadc05d7 fix test 2021-09-07 11:56:27 +02:00
Paulo Graça
70f7c8b5ab renaming properties and improve file documentation 2021-09-07 09:22:20 +01:00
Mykhaylo
e068e94f6d implemented search 'byItemsAndType' end point for RelationshipRest repository 2021-09-06 22:13:50 +02:00
Mykhaylo
5ac2c0325d added tests for search 'byItemsAndType' end point in RelationshipRest repository 2021-09-06 22:12:08 +02:00
Mykhaylo
ab7df25d0c implemented 'byEntityType' end point in RelationshipTypeRestRepository 2021-09-06 21:40:05 +02:00
Mykhaylo
5bb9fce3b6 added tests for RelationshipType 'byEntityType' end point 2021-09-06 21:38:37 +02:00
Paulo Graça
08857aecd2 renaming properties and improve file documentation 2021-09-06 18:11:10 +01:00
Paulo Graça
d8b7c97d86 Merge branch 'main' of https://github.com/DSpace/DSpace into feature-issue2816-openaire-funding-external-lookup 2021-09-06 18:09:22 +01:00
Paulo Graça
0f60fe85ec support openaire4 types registries by default 2021-09-06 18:07:18 +01:00
Paulo Graça
dc1fb643bd remove comment 2021-09-06 18:02:36 +01:00
Mark H. Wood
5fc0f595e6 Increase test coverage. (#2129) 2021-09-06 10:40:05 -04:00
Mark H. Wood
d61539eead Remove unused helper class. (#2129) 2021-09-06 10:38:48 -04:00
Michael Spalti
05ce413ab5 Removed unused import. 2021-09-05 13:41:18 -07:00
Michael Spalti
7f22c91dbc Minor fix in sequence and an implementation comment in the manifest service. 2021-09-05 13:38:50 -07:00
Michael Spalti
813f81b3bc Javadoc updates. 2021-09-04 21:03:06 -07:00
Michael Spalti
5b75e87c7d Fixed runaway sequence. 2021-09-04 18:14:00 -07:00
Michael Spalti
39298006fb Reverted manifest thumbnail image. 2021-09-04 17:34:12 -07:00
Michael Spalti
015f1f2ac9 Fixed IT. 2021-09-04 17:10:46 -07:00
Michael Spalti
618d72b4b9 Updated range and image services. 2021-09-04 17:10:00 -07:00
Michael Spalti
4e8c8769df Service boundary and model updates. 2021-09-04 16:12:09 -07:00
Alan Orth
930d1c8f53 DS-4588: fix case-insensitive spiderdetector test
We should not use the string "FirefOx" to test the validity of our
spider user agent patterns because it is not a valid user agent in
the first place. The Mozilla Firefox browser uses patterns such as
this:

Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

The test currently matches the following regular expression:

^firefox$

In this case, if a client *did* connect with a single-word string
such as "Firefox" or "firefox" it would definitely be a non-human
user and we should not log a statistics hit.

If the goal of the test is to check *valid* human user agents aga-
inst case-insensitive regular expression matching, then we should
use the following:

mozilla/5.0 (x11; linux x86_64; rv:91.0) gecko/20100101 firefox/91.0

Ported from #3336 to main for DSpace 7.x.
2021-09-04 22:03:43 +03:00
Alan Orth
abad6116cb DS-4587: Update the spider user agent file
This updates the included spider user agent file to the latest from
the COUNTER-Robots project. DSpace's own copy is over five years old
and is missing a bunch of new patterns, which greatly decreases the
accuracy of the Solr usage statistics.

Port of #3333 to main for DSpace 7.x.

See: https://jira.lyrasis.org/browse/DS-4587
See: https://github.com/atmire/COUNTER-Robots/releases/tag/2021-07-05
2021-09-04 21:24:16 +03:00
Andrea Bollini
9dcf2344b4 Merge pull request #2789 from the-library-code/DS-4522_Logical_item_filtering
[DS-4522] Logical item filtering (with DOI implementation)
2021-09-04 08:35:45 +02:00
Michael Spalti
6931b3ef31 Minor comment update. 2021-09-03 14:11:08 -07:00
Mark H. Wood
9dd3026c05 Missing commit broke tests. Tighten up code, #2129 2021-09-03 16:58:06 -04:00
Michael Spalti
7f4f91e979 Updated IT. 2021-09-03 13:44:32 -07:00
Michael Spalti
08ea61f654 Code cleanup with comments and missing license header. 2021-09-03 13:43:16 -07:00
Michael Spalti
e431f1687a Merge branch 'main' into iiif-endpoint 2021-09-03 12:25:40 -07:00
Michael Spalti
3edc34c451 Mostly code improvements with one functional change in how the iiif bundle is chosen. 2021-09-03 12:22:00 -07:00
Tim Donohue
0c75cb1ce9 Merge pull request #7929 from TexasDigitalLibrary/DS-3643-7x
DS-3643: Use correct license on ingest (7.x)
2021-09-03 10:19:12 -05:00
nwoodward
4511b5e9e8 use correct license when one is not supplied 2021-09-03 09:06:33 -05:00
Yura Bondarenko
8e955a75a6 83338: Fix from/to indices 2021-09-03 15:40:12 +02:00
Tyson Lloyd Thwaites
ad0c19230d Abstract relationship lookup into RelationshipUtils 2021-09-03 17:11:47 +10:00
Tyson Lloyd Thwaites
db3d4ed374 always process relationships, less noisy output 2021-09-03 17:10:53 +10:00
Tyson Lloyd Thwaites
0fa5ef914f remove relationships option (always enabled) 2021-09-03 17:07:27 +10:00
Tyson Lloyd Thwaites
3512318ce1 fix checkstyle violations 2021-09-03 17:06:31 +10:00
Michael Spalti
28b4a5fcb3 Modified search service. 2021-09-02 14:21:47 -07:00
Tim Donohue
1123e0b700 Merge pull request #3364 from mwoodiupui/3363
Allow changing an EPerson's password through the CLI
2021-09-02 15:02:02 -05:00
Tim Donohue
f92669c704 Merge pull request #7925 from atmire/Fix-configuration-dependent-ITs
Fix configuration-dependent ITs
2021-09-02 14:59:46 -05:00
Mark H. Wood
76ea271ead Address feedback. #2129 2021-09-02 11:21:47 -04:00
Mykhaylo
981e224fea added event that allow to update solr document of collection and community 2021-09-02 09:55:28 +02:00
Tim Donohue
f7ad55af4c Merge pull request #2438 from the-library-code/DS-4260-dspace7
DS-4260: Remove non-existing command from oai harvester's help
2021-09-01 15:08:11 -05:00
Yura Bondarenko
653a2e7402 Make no assumptions about metadata registry in ITs 2021-09-01 16:10:08 +02:00
Yura Bondarenko
c9e4bb8106 Make no assumptions about configured scripts in ITs 2021-09-01 16:09:39 +02:00
Mykhaylo
16d8e3372b added tests to prove bug of updating collection metadata will not produce a solr reindex 2021-08-31 12:41:47 +02:00
Mark H. Wood
90a23a000a Fix mismatched getter, setter synchronization. 2021-08-30 16:56:09 -04:00
Mark H. Wood
674c3e2607 Remove unnecessary boxing, unread variables. 2021-08-30 16:54:48 -04:00
Bill Branan
c72a289cc8 Updates log statement to include full error details when attempt to send registration email fails
Also fixes a couple typos
2021-08-30 14:24:24 -04:00
Michael Spalti
4491837d54 Moved the iiif cors configuration to separate iiif.cfg config file. 2021-08-26 15:44:40 -07:00
Michael Spalti
cbd37eb722 Updated ITs to work with the new iiif endpoint. 2021-08-26 15:36:37 -07:00
Michael Spalti
0a8cdd5b59 Added logo url to iiif dspace configuration. 2021-08-25 16:07:24 -07:00
Michael Spalti
eff7e11daa Adding configurable log to manifest. 2021-08-25 15:52:26 -07:00
Mark H. Wood
134873c98a Replace array with Queue to avoid index-out-of-bounds, make neater. 2021-08-25 15:26:39 -04:00
Mark H. Wood
48d409d87d Formalize more option parsing. 2021-08-25 14:09:37 -04:00
Michael Spalti
f25b51ae65 Updated java docs. 2021-08-25 10:42:17 -07:00
Mark H. Wood
702a72ffab Replace handmade option parsing with Commons CLI to address LGTM array bounds complaints. 2021-08-25 12:58:27 -04:00
Mark H. Wood
81a7235432 Take up many IDE suggestions. 2021-08-25 10:33:50 -04:00
Mark H. Wood
5bc4d16175 [DS-3952] Add requested CORS, CSRF tests. Fix license header. 2021-08-25 10:10:50 -04:00
Mark H. Wood
6ca754ec6c [DS-3952] Check for required request attributes. 2021-08-25 07:48:15 -04:00
tysonlt
127e427bbe Changes requested in PR 3322 2021-08-25 11:45:20 +10:00
Michael W Spalti
7e02dbb882 Adding IIIF cors configuration. 2021-08-24 16:46:50 -07:00
Tim Donohue
7cb25c6121 Merge pull request #3335 from atmire/DS-3334
Update SWORD and SWORDv2 URL configuration construction
2021-08-24 11:49:36 -05:00
Mark H. Wood
d3c5f0473a Remove un-necessary IllegalArgumentException. #3363 2021-08-24 12:08:22 -04:00
Mark H. Wood
3ce4b592fc Add test for mismatch between password and confirmation. #3363 2021-08-24 11:45:06 -04:00
Mark H. Wood
8bed933d90 Clearer prompts, reject empty password, test for empty password. #3363 2021-08-24 09:40:09 -04:00
Mykhaylo
0816473c41 added check to avoide creating same versioning 2021-08-24 15:20:46 +02:00
Andrew Wood
cc1b1c314a Merge branch 'main' into DS-3334 2021-08-23 11:00:50 -04:00
Andrew Wood
032ffa6b41 DS-3335 Simplify sword url construction 2021-08-23 10:51:30 -04:00
Paulo Graça
16e621928a adding openAIREFunding valitation to IT 2021-08-23 12:05:45 +01:00
Paulo Graça
98015e469b adding openAIREFunding valitation to IT 2021-08-23 11:17:27 +01:00
Mark H. Wood
4da733baa7 Remove useless pagination arguments. #3369 2021-08-20 14:59:00 -04:00
Mykhaylo
fe4332e2ea fix failed tests 2021-08-19 17:55:55 +02:00
Mykhaylo
69e36e7037 implemented linked entities for versionhistory end point 2021-08-19 15:55:31 +02:00
Mykhaylo
bf80dc02f5 [CST-4469] extended versioning end point 2021-08-18 19:10:36 +02:00
Mark H. Wood
6f82111d75 [DS-3952] Address Checkstyle and NetBeans warnings. 2021-08-17 12:44:37 -04:00
Mark H. Wood
ab8499d17b [DS-3952] Don't require authorization. Test this properly. 2021-08-17 12:29:11 -04:00
Mark H. Wood
b59790a156 Add integration test for this feature only. #3363 2021-08-17 11:25:24 -04:00
Paulo Graça
653be5db00 new openaire funding external source feature 2021-08-17 11:44:04 +01:00
Mark H. Wood
dd40f5ff3c Add option to change user's password. #3363 2021-08-13 15:57:52 -04:00
Mark H. Wood
3f06c7e79c Document that EPerson's password, salt and algorithm setters are related. #3363 2021-08-13 15:56:26 -04:00
Mark H. Wood
f58519329e [DS-3952] Improve confusing debug log message. 2021-08-10 17:14:36 -04:00
Yura Bondarenko
6280b76355 81832: Surround getLabel/getVariant calls with try/catch 2021-08-10 09:54:20 +02:00
Yura Bondarenko
816ca59e4c 81832: Don't ignore author fields in discovery authority IT 2021-08-10 09:24:35 +02:00
Mark H. Wood
6926b49fab [DS-3952] Match ISO time zone properly. More informative message on failure. 2021-08-09 09:47:11 -04:00
Mark H. Wood
f435f933ad [DS-3952] Add auth token to request, and replace some deprecated matchers. 2021-08-09 09:27:21 -04:00
Mark H. Wood
8c7ba93913 [DS-3952] Fix incorrect request parameter names that I missed. 2021-08-09 09:26:19 -04:00
Mark H. Wood
c427a2e83f [DS-3952] Fix a broken test. Various cleanups. 2021-08-08 19:12:49 -04:00
Mark H. Wood
596df53d0a [DS-3952] Satisfy checkstyle and license plugins. 2021-08-08 14:51:22 -04:00
Mark H. Wood
8a3d23f2dd [DS-3952] More thorough Matcher, and new date matching. 2021-08-08 14:35:48 -04:00
Mark H. Wood
546efa1c8b [DS-3952] Move test back to integration, tidy, remove commented tests.
Making this one quick test into a unit test would take a lot of
stubbing and just isn't worth the effort.
2021-08-08 14:33:40 -04:00
Mark H. Wood
5f5bc3641e [DS-3952] Align property names with contract; implement POST rather than PUT. 2021-08-08 14:32:15 -04:00
Mark H. Wood
670e453286 [DS-3952] Move some tests from integration to unit testing. 2021-08-08 14:11:03 -04:00
Mark H. Wood
1e194db05b [DS-3952] Correct builder cleanup priority; remove remnant of old priority system. 2021-08-08 14:07:32 -04:00
Mark H. Wood
2fae54bfac [DS-3952] More SLF4J -> Log4Jv2 catch-up. 2021-08-08 14:06:42 -04:00
Mark H. Wood
ad4610d49f [DS-3952] Add RequestItemBuilder to the clean-up sequence. 2021-08-08 14:00:52 -04:00
Mark H. Wood
0ccfba6a1a [DS-3952] Catch up with switch to Log4J v2 -- replace SLF4J. 2021-08-08 13:58:42 -04:00
Mark H. Wood
f80546b6d7 [DS-3952] Remove unused setup/teardown; more documentation; correct assertion. 2021-08-08 13:58:38 -04:00
Mark H. Wood
09b066ca91 [DS-3952] Move request deletion from test to main. 2021-08-08 13:56:15 -04:00
Mark H. Wood
6fa5bf6548 [DS-3952] Drop dangling references that caused unfortunate coupling
with following test classes.
2021-08-08 13:54:54 -04:00
Mark H. Wood
c063434e01 [DS-3952] Fix what the tests say was broken. 2021-08-08 13:53:19 -04:00
Mark H. Wood
10dde35631 [DS-3952] Work around NPE problem in RequestItem: ensure that accept_request is set. 2021-08-08 13:40:18 -04:00
Mark H. Wood
a37c658931 [DS-3952] Debug the integration tests (unfinished). 2021-08-08 13:40:13 -04:00
Mark H. Wood
e1986ad678 [DS-3952] Switch to Spring proprietary annotations, and other cleanup. 2021-08-08 11:41:10 -04:00
Mark H. Wood
1b98d735df [DS-3952] Run test with full privileges. 2021-08-08 11:38:53 -04:00
Mark H. Wood
797e998739 [DS-3952] Use service from superclass, tighten code. 2021-08-08 11:38:53 -04:00
Mark H. Wood
fae1c5622d [DS-3952] AbstractBuilder should know about RequestItem since there is a builder for it now. 2021-08-08 11:38:46 -04:00
Mark H. Wood
1590e72f0f [DS-3952] Begin building integration tests. 2021-08-08 11:31:43 -04:00
Mark H. Wood
619e6d4eac [DS-3952] Throw a somewhat specific exception if we cannot store a request. 2021-08-08 11:10:00 -04:00
Mark H. Wood
7751b5c75f [DS-3952] Satisfy checkstyle again.
I think I have my IDE configured properly for this now.
2021-08-08 11:09:54 -04:00
Mark H. Wood
7e1bf53b40 [DS-3952] Replace standard @Inject with Spring-proprietary @Autowired for consistency. 2021-08-08 11:07:07 -04:00
Mark H. Wood
0a1babdb54 [DS-3952] First try at writability, untested. 2021-08-08 11:04:15 -04:00
Mark H. Wood
5048105cf6 [DS-3952] Conform better to established endpoint naming conventions. 2021-08-08 11:04:14 -04:00
Mark H. Wood
48dd36f165 [DS-3952] Conform to endpoint naming requirements. 2021-08-08 11:04:10 -04:00
Mark H. Wood
b3a40c198c [DS-3952] Use injected converters instead of creating ephemeral instances; rename methods for consistency with other REST code. 2021-08-08 11:02:41 -04:00
Mark H. Wood
de358067b8 [DS-3952] Fix style errors. 2021-08-08 10:55:05 -04:00
Mark H. Wood
16031a5637 [DS-3952] Better, fuller annotations; better documentation. 2021-08-08 10:52:46 -04:00
Mark H. Wood
8febfa479d [DS-3952] First attempt. It compiles. 2021-08-08 10:46:52 -04:00
Tim Donohue
d9a04c26fd Merge pull request #3360 from tdonohue/licenses_third_party_updates
Updates to LICENSES_THIRD_PARTY file after 7.0 release
2021-08-06 11:51:45 -05:00
Tim Donohue
9cf5687ceb More minor LICENSES_THIRD_PARTY cleanup 2021-08-06 11:11:11 -05:00
Tim Donohue
f68fb37530 Cleanup of LICENSES_THIRD_PARTY by improving grouping of licenses 2021-08-06 11:03:45 -05:00
Mark H. Wood
9d1f526a5a Fix other case of calling Pattern.matcher() twice. #3287 2021-08-05 13:55:21 -04:00
Mark H. Wood
ee82706708 [DS-4548] More Checkstyle fixes. 2021-08-04 15:13:51 -04:00
Mark H. Wood
453b0b2cdf [DS-4548] Fix test failure: break circular dependency between DSpacePermissionEvaluator and ConverterService.
Also fix missing versions in deprecated dspace-rest POM.
2021-08-04 14:59:56 -04:00
Mark H. Wood
7c42e17883 [DS-4548] Fix forgotten disabled dspace-rest subproject. 2021-08-04 13:06:05 -04:00
Mark H. Wood
f4b1e4b2ff [DS-4548] Satisfy Checkstyle. 2021-08-04 12:02:21 -04:00
Mark H. Wood
b43e5dfdd8 [DS-4548] Rename DSpace's LogManager to LogHelper. 2021-08-04 11:41:18 -04:00
Tim Donohue
68f38fcdff Merge pull request #3355 from tdonohue/minor_code_cleanup
Minor code cleanup: Remove references to BTE, XMLUI and JSPUI
2021-08-03 10:13:58 -05:00
Mark H. Wood
a8de4b3976 Satisfy checkstyle. #3287 2021-08-03 10:45:20 -04:00
Mark H. Wood
aa77a4277b Add commented default value to DSpace configuration. #3278
Tidy javadoc, make configuration default easier to find.
2021-08-03 10:21:18 -04:00
Mark H. Wood
83371b4483 Make the canonical DOI URL schema+authority configurable. #3287 2021-08-02 18:16:30 -04:00
Tim Donohue
377542697c Cleanup a few more instances of JSPUI/XMLUI 2021-08-02 16:56:33 -05:00
Tim Donohue
e6898ddf77 Minor code cleanup. Remove any references to BTE, XMLUI and JSPUI from 7.x codebase 2021-08-02 16:48:54 -05:00
Mark H. Wood
f41b91d9de Finish documenting DOIService. 2021-08-02 16:33:59 -04:00
dependabot[bot]
7e7bee02d2 Bump ant from 1.10.9 to 1.10.11
Bumps ant from 1.10.9 to 1.10.11.

---
updated-dependencies:
- dependency-name: org.apache.ant:ant
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-02 16:57:14 +00:00
Michael Spalti
03df905290 Removed unused import. 2021-08-01 17:10:41 -07:00
Michael Spalti
0f9686f756 Added missing license header. 2021-08-01 12:23:59 -07:00
Michael Spalti
8acbab766d Added 3rd party licenses. 2021-08-01 12:23:38 -07:00
Michael Spalti
faa34e4b42 Merge branch 'main' into iiif-endpoint 2021-07-30 14:41:29 -07:00
Tim Donohue
3d9df39231 [maven-release-plugin] prepare for next development iteration 2021-07-29 14:09:30 -05:00
Tim Donohue
69345ff3fc [maven-release-plugin] prepare release dspace-7.0 2021-07-29 14:09:20 -05:00
Tim Donohue
af6ce04ba7 Update LICENSE files. Update POM for latest dspace-api-lang 2021-07-29 12:05:06 -05:00
Tim Donohue
70fa6aea84 Updates to README for 7.0 2021-07-29 11:31:26 -05:00
Andrew Wood
fc8f12f198 DS-3334 Update SWORD and SWORDv2 URL configuration construction 2021-07-22 14:04:33 -04:00
Tim Donohue
5e4743779a Merge pull request #3311 from DSpace/dependabot/maven/org.eclipse.jetty-jetty-server-9.4.41.v20210516
Bump jetty-server from 9.4.38.v20210224 to 9.4.41.v20210516
2021-07-21 10:23:50 -05:00
Tim Donohue
61303cdd2c Merge pull request #3316 from DSpace/dependabot/maven/dspace-rest/org.springframework.security-spring-security-core-5.3.10.RELEASE
Bump spring-security-core from 5.3.9.RELEASE to 5.3.10.RELEASE in /dspace-rest
2021-07-21 09:56:40 -05:00
dependabot[bot]
3d0af1d6cb Bump jetty-server from 9.4.38.v20210224 to 9.4.41.v20210516
Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 9.4.38.v20210224 to 9.4.41.v20210516.
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.38.v20210224...jetty-9.4.41.v20210516)

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-server
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-21 14:13:23 +00:00
dependabot[bot]
685539ee76 Bump spring-security-core in /dspace-rest
Bumps [spring-security-core](https://github.com/spring-projects/spring-security) from 5.3.9.RELEASE to 5.3.10.RELEASE.
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.3.9.RELEASE...5.3.10.RELEASE)

---
updated-dependencies:
- dependency-name: org.springframework.security:spring-security-core
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-21 14:12:43 +00:00
Tim Donohue
dad5e0855f Merge pull request #3294 from atmire/w2p-79734_Search-endpoint-to-find-bitsreams-of-item
Search endpoint to find bitstreams with item handle and bitstream name or sequence
2021-07-21 09:09:56 -05:00
Tim Donohue
960dca862b Merge pull request #3303 from 4Science/issue-3244
Improve logging of REST request adding MDC
2021-07-20 09:48:49 -05:00
Tim Donohue
94e18cbf12 Merge pull request #3321 from tdonohue/fix_pagination_count
Fix `/api/core/items` endpoint's `totalElements` count to avoid empty pages at end
2021-07-16 13:34:24 -05:00
Tim Donohue
065514b5f3 Add tests to prove Workflow Items and Template Items are also not counted/listed 2021-07-16 12:15:20 -05:00
Tim Donohue
5030ccd38f Merge pull request #3318 from 4Science/CST-4385-CanManageMappingsFeaturesometimesDoesNotRespondAsExpected
CanManageMappingsFeature sometimes does not respond as expected
2021-07-15 15:14:02 -05:00
Tim Donohue
6f82c79d2c Merge pull request #3293 from atmire/w2p-79618_bugfix-access-control-section-is-visible-to-non-admin-users-1124
New authorization feature - canManageGroup
2021-07-15 13:18:34 -05:00
tysonlt
16ffffc3a7 fix checkstyle violations 2021-07-15 11:32:13 +10:00
Marie Verdonck
a4dabade79 PR#3293: Check if group com/col admin can access starts with COLLECTION_ or COMMUNITY_ 2021-07-14 19:49:03 +02:00
Marie Verdonck
1d97bdeae8 PR#3293: Comment pointing to #3323 & special group check altered to use group name instead of requiring DB query to retrieve group 2021-07-14 17:49:49 +02:00
Luca Giamminonni
813dd05b75 Added missing escape in log4j2.xml and added logging.server.include-after-request property 2021-07-14 11:51:02 +02:00
tysonlt
a81a6005c0 Merge branch 'import_relationships' of https://github.com/tysonlt/DSpace into import_relationships 2021-07-14 15:14:36 +10:00
tysonlt
a9f339724c tweak comments and progress message 2021-07-14 15:14:21 +10:00
tysonlt
c01eb80f12 Merge branch 'DSpace:main' into import_relationships 2021-07-14 13:36:41 +10:00
tysonlt
e53ed6151a lookup relationship by type, allow entity lookup by meta 2021-07-14 13:01:03 +10:00
Tim Donohue
29eb77d511 Merge pull request #3320 from DSpace/issue3319-openaire-orgunit-relation
replacing relation with isFundingAgencyOfProject
2021-07-13 14:56:34 -05:00
Marie Verdonck
a3b2f69c56 PR#3294: Stop search after first matching bitstream found 2021-07-13 21:49:07 +02:00
Marie Verdonck
88b13f2935 PR#3294: Unused services removed 2021-07-13 21:01:43 +02:00
Marie Verdonck
d22b1e7a1a PR#3294: Return first bitstream at /bitstreams/search/byItemHandle regardless on whether or not permission to view + IT adjusted 2021-07-13 20:49:34 +02:00
Luca Giamminonni
a18dfed6c4 Logs improvements 2021-07-13 16:32:39 +02:00
tysonlt
4972ee3f98 populate item map with skipped items 2021-07-13 14:54:48 +10:00
tysonlt
2455171a58 support multiple relationships of the same type 2021-07-13 14:06:47 +10:00
tysonlt
c35fba249a allow item lookup by uuid, handle, or import folder name 2021-07-13 13:33:18 +10:00
tysonlt
a1a77b5492 added support for 'relationships' manifest 2021-07-13 13:03:34 +10:00
Tim Donohue
025c7a8c78 Fix total to only include archived items. 2021-07-12 16:00:02 -05:00
Tim Donohue
b60b76d29e Add test to prove pagination total is incorrect when WorkspaceItem(s) exist. 2021-07-12 15:35:57 -05:00
Tim Donohue
bdbbb999b7 Merge pull request #3314 from tdonohue/minor_it_fixes
Minor improvements to AuthenticationRestControllerIT for integration test stability
2021-07-12 09:40:01 -05:00
Tim Donohue
0237d4a5b1 Merge pull request #3265 from 4Science/CST-4121-MakeDiscoveryMoreResilientToStaleObjects
Make discovery more resilient to stale objects
2021-07-12 08:46:46 -05:00
Kim Shepherd
75c93601f8 [DS-4522] Clean up unused import 2021-07-12 13:38:18 +12:00
Kim Shepherd
4d33fb706c [DS-4522] Add a metadata match test to test for field that item doesn't contain 2021-07-12 13:19:15 +12:00
Kim Shepherd
2e6552c0c9 [DS-4522] Refactor skipFilter Boolean -> boolean (primitive) as per review 2021-07-12 13:05:19 +12:00
Kim Shepherd
713469cd80 [DS-4522] Removed operator test null item references and comments as per review 2021-07-12 12:44:10 +12:00
Michael Spalti
851bca30e3 Merge branch 'main' into iiif-endpoint 2021-07-11 06:55:13 -07:00
Michael Spalti
44de2ec5a3 Added IIIF bundle to solr stats. 2021-07-11 06:54:03 -07:00
Michael Spalti
a203d942ee Updated info models. 2021-07-11 06:53:00 -07:00
Michael Spalti
cbcf8c305e Updated cache path. 2021-07-11 06:52:16 -07:00
Michael Spalti
0a01826c4e Updated cache config and renamed classes. 2021-07-11 06:50:17 -07:00
Paulo Graça
3f69a4452c replace funder name with the proper schema 2021-07-09 10:58:02 +01:00
Paulo Graça
1981f672a5 replacing relation with isFundingAgencyOfProject 2021-07-09 10:46:02 +01:00
Mykhaylo
d239e862a7 fix CanManageMappingsFeature 2021-07-06 12:32:09 +02:00
Mykhaylo
7ac940bb38 added test that prove wrong functionality of CanManageMappingsFeature 2021-07-06 12:19:09 +02:00
Bruno Roemers
a19464d395 79618: Add license header 2021-07-05 12:50:16 +02:00
Bruno Roemers
646378cf6f 79618: Implement ManageGroupFeature 2021-07-05 12:50:16 +02:00
Bruno Roemers
a1019e02d8 79618: Create ManageGroupFeatureIT 2021-07-05 12:50:16 +02:00
Bruno Roemers
2ac78607e9 79618: Add generics 2021-07-05 12:50:16 +02:00
Yana De Pauw
e0f4484bbe Add comment 2021-07-02 13:39:41 +02:00
Yana De Pauw
2907b6c11a Merge remote-tracking branch 'upstream/main' into w2p-79734_Search-endpoint-to-find-bitsreams-of-item 2021-07-02 13:22:41 +02:00
Tim Donohue
87bb9e44f0 Merge pull request #3309 from atmire/w2p-80217_Link-to-item-thumbnail
Add endpoints for Item/Bitstream thumbnails
2021-06-30 13:56:31 -05:00
Andrea Bollini
25b4a19272 Merge branch 'main' of https://github.com/DSpace/DSpace into issue-3244 2021-06-26 17:27:26 +02:00
Tim Donohue
0297874d7d Minor IT improvements for stability. Ensure each test which logs in also logs out at the end. 2021-06-25 11:53:15 -05:00
Tim Donohue
cbed1b4768 Merge pull request #3313 from tdonohue/fix_jaxb_error
Fix JAXB build errors by disabling package annotations.
2021-06-25 11:52:23 -05:00
Tim Donohue
a4ac12e616 Fix JAXB build errors by disabling package annotations. Also make sure these classes are annotated as @Generated 2021-06-25 11:15:34 -05:00
Mykhaylo
32223c3c2c Merge branch 'main' into CST-4121-MakeDiscoveryMoreResilientToStaleObjects 2021-06-25 13:22:32 +02:00
Yura Bondarenko
c8b98f4061 Remove stray comment 2021-06-25 08:12:03 +02:00
Yura Bondarenko
fc4f64982a 80218: Expand thumbnail endpoint ITs 2021-06-25 08:12:03 +02:00
Yura Bondarenko
ef070612fa 80218: Fix leftover 'item's in BitstreamThumbnailLinkRepository 2021-06-25 08:12:03 +02:00
Yura Bondarenko
2ab5f6edb7 80218: Add ITs for bitstream thumbnail endpoint 2021-06-25 08:12:03 +02:00
Yura Bondarenko
47536c007d 80218: Implement bitstream thumbnail endpoint 2021-06-25 08:12:03 +02:00
Yura Bondarenko
b5f49f87bf 80218: Add BitstreamService#getThumbnail 2021-06-25 08:12:03 +02:00
Yura Bondarenko
bb797f7822 80217: Add ITs for item thumbnail endpoint 2021-06-25 08:12:03 +02:00
Yura Bondarenko
b3abbb525d 80217: Implement item thumbnail endpoint 2021-06-25 08:12:03 +02:00
Tim Donohue
02f84b4727 Merge pull request #3308 from atmire/w2p-80239_PDFBoxThumbnail-fix
W2p 80239 pdf box thumbnail fix
2021-06-24 16:59:01 -05:00
Mark H. Wood
d02827019b [DS-4478] Ported from 6_x to main. 2021-06-24 13:46:01 -04:00
Mark H. Wood
c36a901170 Merge remote-tracking branch 'upstream/main' into DS-4118
Catch up with changes to Github checks.
2021-06-24 11:33:18 -04:00
Tim Donohue
b6c7c75711 Merge pull request #3301 from tdonohue/upload-test-logs
Update our GitHub CI settings to upload all test output to a downloadable artifact whenever a test failure occurs.
2021-06-24 10:32:09 -05:00
Mark H. Wood
d4dd979326 Merge remote-tracking branch 'upstream/main' into DS-4118 2021-06-24 11:31:32 -04:00
Tim Donohue
4d65a2bff2 Merge pull request #3157 from mwoodiupui/DS-2058-7x
Implement curation tasks for Configurable Workflow
2021-06-24 10:26:30 -05:00
Tim Donohue
508c231f65 Merge pull request #3307 from tdonohue/remove_cacheprovider
Remove unimplemented interface CacheProvider and all references to it
2021-06-23 16:39:02 -05:00
Mykhaylo
44a7d9bd95 Implement community feedbacks 2021-06-23 17:59:21 +02:00
Tim Donohue
b6c43ae295 Add warning for production 2021-06-23 10:54:37 -05:00
Tim Donohue
5e640d2bb8 Add warning about production 2021-06-23 10:53:47 -05:00
Mark H. Wood
d83c7b7151 [DS-2058] A little more documentation touch-up. 2021-06-23 11:16:17 -04:00
Mark H. Wood
53738acf0b [DS-2058] Improve documentation as requested. 2021-06-23 10:58:49 -04:00
Tim Donohue
0cfe4d0686 Merge pull request #3304 from tdonohue/search_scope_null
Searches without a scope can trigger "Invalid UUID" error from ScopeResolver
2021-06-23 09:43:36 -05:00
Tim Donohue
62d3b850d8 Remove unimplemented interface CacheProvider and all references to it 2021-06-22 17:02:40 -05:00
Tim Donohue
418911e890 Merge pull request #3295 from DSpace/dependabot/maven/org.apache.httpcomponents-httpclient-4.5.13
Bump httpclient from 4.5.1 to 4.5.13
2021-06-22 15:41:47 -05:00
Tim Donohue
9ecfe40f41 Properly handle a null scope 2021-06-22 08:52:56 -05:00
Yura Bondarenko
a0a4ff148f Merge branch 'main' into w2p-80239_PDFBoxThumbnail-fix 2021-06-22 10:41:31 +02:00
Andrea Bollini
69c0d9cfd2 Improve logging of REST request adding MDC 2021-06-21 22:52:48 +02:00
Tim Donohue
73c809aeaa Merge pull request #3264 from 4Science/CST-4122-ExposewWithdrawnItemsToAnonymousUsersFilteringOutTheMetadata
Need a way to identify withdrawn items via REST API
2021-06-21 14:43:10 -05:00
Tim Donohue
36aa148764 Merge pull request #3297 from tdonohue/make_thumbnails_larger
Increase default thumbnail size to match with UI display settings
2021-06-21 11:04:43 -05:00
Andrea Bollini
5714a5eeff Cleanup code and add IT for the case discovery.removestale.attempts = 0 2021-06-21 17:03:52 +02:00
Tim Donohue
863282f296 Merge pull request #3300 from atmire/w2p-78245_Bugfix-to-UsageReportRestPermissionEvaluatorPlugin
Bugfix to usage report rest permission evaluator plugin
2021-06-17 15:08:33 -05:00
Tim Donohue
36853f8bc2 Only create Artifacts if a test fails 2021-06-17 12:16:15 -05:00
Tim Donohue
2d0757679e Upload test reports to workflow artifact for easier debugging of issues. 2021-06-17 11:49:56 -05:00
Mykhaylo
ca9d6c4a0a added description about new permission type STATUS 2021-06-17 14:59:54 +02:00
Mykhaylo
c2d8e9c328 Merge branch 'main' into CST-4122-ExposewWithdrawnItemsToAnonymousUsersFilteringOutTheMetadata 2021-06-17 14:52:21 +02:00
Tim Donohue
77296d4848 Merge pull request #3271 from DSpace/dependabot/maven/dspace-rest/org.springframework.security-spring-security-web-5.3.9.RELEASE
Bump spring-security-web from 5.3.3.RELEASE to 5.3.9.RELEASE in /dspace-rest
2021-06-16 15:48:58 -05:00
Tim Donohue
a1816e2054 Merge pull request #3298 from DSpace/dependabot/maven/org.apache.pdfbox-pdfbox-2.0.24
Bump pdfbox from 2.0.15 to 2.0.24
2021-06-16 15:32:56 -05:00
Tim Donohue
ab0bfb54e5 Create a SECURITY.md to document security policies 2021-06-16 12:02:34 -05:00
Tim Donohue
a250efd99c Merge pull request #3288 from 4Science/DSC-74-CanNotSaveMoreThanOneBitstreamAccessConditionsDuringSubmission
Can't save more than one bitstream's access conditions during submission
2021-06-15 14:28:54 -05:00
dependabot[bot]
06653a2db5 Bump pdfbox from 2.0.15 to 2.0.24
Bumps pdfbox from 2.0.15 to 2.0.24.

---
updated-dependencies:
- dependency-name: org.apache.pdfbox:pdfbox
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-15 15:55:35 +00:00
Tim Donohue
9140161954 Increase default thumbnail size to match with UI settings 2021-06-14 15:12:11 -05:00
Tim Donohue
128ef676b4 Merge pull request #3277 from atmire/w2p-79369_fix-error-when-permanently-deleting-item-as-collection-admin
Delete item as collection admin & related issues
2021-06-11 15:40:12 -05:00
Tim Donohue
d72029a07c Merge pull request #2756 from 4Science/DS-4149_7-x
[DS-4149] porting XOAI additional indexer
2021-06-11 14:30:18 -05:00
Mark H. Wood
13787c3a48 [DS-2058] Tidy up for Checkstyle. 2021-06-08 19:36:43 -04:00
Mark H. Wood
34bdf090f1 [DS-2058] Test with the first non-default workflow as stated, not the last. 2021-06-08 16:31:18 -04:00
Mark H. Wood
cbabb94887 [DS-2058] Document the CollectionBuilder. 2021-06-08 16:30:14 -04:00
Mark H. Wood
bda2a992fa [DS-2058] Remove now-unused injected attribute. 2021-06-08 13:56:25 -04:00
Mark H. Wood
2eb9f5d865 [DS-2058] Remove a missed added attribute, once again unused.
Some harmless cleanups remain, contrary to previous commit's comment.
2021-06-08 13:52:54 -04:00
Mark H. Wood
771368c4e0 [DS-2058] Avoid index out of bounds when no tasks match.
Also remove incorrect unit test.
2021-06-08 13:22:03 -04:00
Mark H. Wood
9c22e707a4 [DS-2058] workflow-curation has a declared namespace now. 2021-06-08 12:42:33 -04:00
Mark H. Wood
79e5aa10d5 [DS-2058] Fix misbehavior that was found in testing. 2021-06-08 09:07:48 -04:00
Mark H. Wood
aacb052856 [DS-2058] Curator should not NPE if someone forgot to set a Reporter. 2021-06-08 09:06:15 -04:00
Mark H. Wood
b980585557 [DS-2058] Finish removing workflow curation test from dspace-server-webapp.
This should completely revert the changes made to this artifact for workflow
curation.
2021-06-08 09:04:23 -04:00
Mark H. Wood
2eea17c63b [DS-2058] Move workflow curation testing to dspace-api since it has no essential connection with REST.
This patch duplicates the Spring/JUnit initializer classes from
dspace-server-webapp.  We should share a single set.  Possibly they should
live in dspace-services where the fundamental Spring support is found.
2021-06-08 09:00:30 -04:00
Mark H. Wood
7cc969829d [DS-2058] MarkerTask should be in a curation tasks directory. 2021-06-07 13:52:01 -04:00
Mark H. Wood
d43d686f01 [DS-2058] Extend and improve documentation. 2021-06-04 14:23:13 -04:00
dependabot[bot]
5eb2c519f4 Bump httpclient from 4.5.1 to 4.5.13
Bumps httpclient from 4.5.1 to 4.5.13.

---
updated-dependencies:
- dependency-name: org.apache.httpcomponents:httpclient
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-03 23:55:36 +00:00
Tim Donohue
71fb39edc9 Merge pull request #3280 from atmire/DS-3230_Browse-by-author-broken-if-author-name-has-special-character
Values escaped in browse and discover links
2021-06-03 10:28:12 -05:00
Tim Donohue
c8d38799cc Merge pull request #3285 from DSpace/fix-license-bitstream-format-description
Update license Bitstream format description
2021-06-03 10:26:11 -05:00
Marie Verdonck
30ef02d14b 79734: IT fix publicItem-embargoBitstream & refactor to avoid reusing metadata_read access on bitstream check code 2021-06-03 09:39:06 +02:00
Yana De Pauw
6feb960881 79734: Search endpoint to find bitstreams of item with item handle and sequenceID or fileName - Issue #1147 2021-05-31 17:09:18 +02:00
Mykhaylo
4953b2d56f fix bug with multi accessCondition# 2021-05-28 13:42:55 +02:00
Mykhaylo
b0e0b21bba added test to prove bug with multi accessCondition 2021-05-28 13:41:16 +02:00
benbosman
ef0723b9cf Merge branch 'DSpace:main' into w2p-78245_Bugfix-to-UsageReportRestPermissionEvaluatorPlugin 2021-05-28 12:20:23 +02:00
Samuel
d38c2e01dc DS-3230 Browse by author broken if author name has special character - use generic test names 2021-05-28 11:21:20 +02:00
Tim Donohue
ebd54fffd0 Merge pull request #3273 from tdonohue/proxy_config
Add better support for http proxying to Spring Boot
2021-05-27 08:38:31 -05:00
yura bondarenko
68ca8e380d Update license Bitstream format description 2021-05-27 15:32:01 +02:00
Andrea Bollini
0ad13bdf5f Fix plugins retrieval and bitstreams url link (issue - 3284) 2021-05-27 00:08:09 +02:00
Andrea Bollini
abe4e6996a cleanup the generation of the oaire:licenseCondition element 2021-05-26 19:25:35 +02:00
Andrea Bollini
2d2a4a77b2 Merge branch 'main' of https://github.com/DSpace/DSpace into DS-4149_7-x 2021-05-26 18:19:49 +02:00
Tim Donohue
367a8ab621 Merge pull request #3283 from mwoodiupui/3282
UI/REST linkage configuration is too sensitive to details that should be insignificant.  #3282
2021-05-26 10:25:43 -05:00
Mark H. Wood
b217d85125 Warn not to put trailing slashes on service URI stems. #3282 2021-05-26 10:47:49 -04:00
Mark H. Wood
63883e4123 [DS-2058] WIP: new test for workflow curation. 2021-05-26 09:53:16 -04:00
Mark H. Wood
b45612cadc [DS-2058] Attempt to curate workflow tasks in *all* the right places.
Workflow curation should happen at entry to a step, *before* looking for
manual tasks to send to reviewers.

Previous refactoring has split the old code into two pieces, so duplicate
the curation code to cover entry to the workflow as well as advancement
between steps.
2021-05-26 09:49:29 -04:00
Mykhaylo
2a66d68a1a added READ permission 2021-05-26 00:07:19 +02:00
Mykhaylo
64a3cc4276 Merge branch 'main' into CST-4122-ExposewWithdrawnItemsToAnonymousUsersFilteringOutTheMetadata 2021-05-25 17:45:34 +02:00
Mykhaylo
ceab663828 refactored tests 2021-05-25 16:55:35 +02:00
Mykhaylo
f549e74917 added new DSpaceRestPermission value STATUS to manage withdrawn items 2021-05-25 16:53:44 +02:00
Tim Donohue
0f927d71e0 Merge pull request #3278 from atmire/w2p-79535_bugfix-add-index-discovery-command-to-help
Add commands from script service to CLI help
2021-05-24 16:41:40 -05:00
Mark H. Wood
6d387abcb2 [DS-2058] Write, improve documentation of workflow classes in hope of understanding them better.
I suspect that in org.dspace.xmlworkflow.state.Step the word "valid" means
"conditions for transition to a different step are satisfied" or, more
concisely, "completed".
2021-05-24 12:31:33 -04:00
Tim Donohue
6f8ec029ec Merge pull request #3276 from atmire/w2p-79371_Cannot-export-metadata-csv-from-collection
Export metadata script (-i) param accepts UUID
2021-05-24 11:22:33 -05:00
Mykhaylo
f089a5258c minor refactoring 2021-05-20 16:23:39 +02:00
Samuel
a1906e83b3 DS-3230 Browse by author broken if author name has special character - repair broken tests 2021-05-20 15:52:02 +02:00
Samuel
a47f8d9476 DS-3230 Browse by author broken if author name has special character - fix 2021-05-20 13:01:55 +02:00
Samuel
8795a568e6 DS-3230 Browse by author broken if author name has special character - add tests 2021-05-20 13:01:43 +02:00
Mykhaylo
10a420605f added test to prove functionality of new parameter that disables Solr to remove stale objects 2021-05-20 11:00:52 +02:00
Mykhaylo
b42576bc89 Implement community feedbacks 2021-05-20 10:55:17 +02:00
Bruno Roemers
8a00082fec 79535: Add commands from script service to CLI help 2021-05-19 12:53:03 +02:00
Mykhaylo
b37e113249 Merge branch 'main' into CST-4121-MakeDiscoveryMoreResilientToStaleObjects 2021-05-19 11:33:05 +02:00
Bruno Roemers
01f0eb8c74 79369: Revert to 404
Are the 401 and 403 with non-admin tokens expected?
2021-05-18 19:20:23 +02:00
Bruno Roemers
a44894b733 79369: Fix test that failed because commit a105b4a7e5
It seems that the original behavior of BundleServiceImpl#delete was buggy,
because the bitstreams were being deleted despite the ORIGINAL bundle of
the item still holding a reference to it.
2021-05-18 19:02:41 +02:00
Bruno Roemers
8bee98dc97 79369: Add deleteOneArchivedTestAsOtherCollectionAdmin
Also fixed a typo that was present in the upstream code.
TODO: check if the resulting status change is expected.
2021-05-17 17:26:27 +02:00
Bruno Roemers
b349c303f8 79369: Fix RelationshipDeleteRestRepositoryIT
Also added two new tests to check the abilities of collection admins.
2021-05-17 16:41:27 +02:00
Michael Spalti
0fad27535a Merge branch 'main' into iiif-endpoint 2021-05-16 16:33:15 -07:00
Michael Spalti
77bed7571c Added trackPages parameter to solr query that was introduced in solr-ocrhighlighing v 0.6.0.
This version was released 5 days ago and is not yet available via Maven.
2021-05-16 10:28:15 -07:00
Mark H. Wood
ff4689e777 [DS-2058] Create a namespace for workflow-curation so my IDE can validate curation configurations. 2021-05-16 13:01:48 -04:00
Mark H. Wood
785cd007b4 [DS-2058] Less restrictive, more nearly correct Handle regex for workflow configuration. 2021-05-15 07:23:24 -04:00
Mark H. Wood
80158fc875 [DS-2058] More documentation, small cleanups. 2021-05-15 07:19:29 -04:00
Mark H. Wood
1585bcb268 [DS-2058] Merge curation test workflow into main workflow test configuration. 2021-05-15 07:16:51 -04:00
Tim Donohue
d6b66dbaaa Enable server.forward-headers-strategy by default and move to application.properties 2021-05-13 14:27:18 -05:00
Mark H. Wood
0e0ce0479c [DS-2058] Rename message to match the class that uses it.
Also create a new message and stop using Workflow message in DSO classes.
2021-05-13 11:53:43 -04:00
Mark H. Wood
1ca945b6c6 [DS-2058] Javadoc fixes. 2021-05-13 11:51:34 -04:00
Mark H. Wood
b688bd0145 [DS-2058] Move test scaffolding from main to test resources. 2021-05-13 11:48:51 -04:00
Tim Donohue
3c1b90d603 Merge pull request #3266 from 4Science/CST-4123-RespondWith401InSteadThan403toInvalidOrExpiredJWT
If logged in through multiple devices, a logout results should result in a 401 on other devices.
2021-05-13 10:28:03 -05:00
Andrea Bollini
28ffbea276 Merge pull request #3268 from tdonohue/small_fix_to_hal_browser_login
HAL Browser fix: Ensure we check for CSRF changes after login failure.
2021-05-13 15:14:22 +02:00
Mykhaylo
92c22926ca Merge branch 'main' into CST-4123-RespondWith401InSteadThan403toInvalidOrExpiredJWT 2021-05-13 15:08:55 +02:00
Mykhaylo
46a5bc2cab fix comments 2021-05-13 12:50:22 +02:00
Marie Verdonck
a105b4a7e5 79369: Fix for collection admin item delete with bitstream 2021-05-12 23:50:37 +02:00
Tim Donohue
678a0daa29 Merge pull request #3267 from atmire/private-and-withdrawn-filters-in-administrative-search
Private and withdrawn filters in administrative search
2021-05-12 16:27:22 -05:00
Tim Donohue
2935c2acf1 Merge pull request #3270 from atmire/issue-3269_servicemanager-beanexception-logging
Fix #3269 by logging detail when Service Manager can't find a bean
2021-05-12 16:23:47 -05:00
Marie Verdonck
7ab5cefd8e 79371: log message fix & ITs for non-valid -i params 2021-05-12 23:12:20 +02:00
Peter Nijs
23e389432c 79371: Cannot export Metadata (CSV) from Collection #1132 2021-05-12 21:56:12 +02:00
Peter Nijs
845c938329 79371: Cannot export Metadata (CSV) from Collection #1132 2021-05-12 20:35:28 +02:00
Chris Wilper
0de72692a6 #3269 Log exception details 2021-05-12 13:03:47 -04:00
dependabot[bot]
45525dcd61 Bump spring-security-web in /dspace-rest
Bumps [spring-security-web](https://github.com/spring-projects/spring-security) from 5.3.3.RELEASE to 5.3.9.RELEASE.
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Changelog](https://github.com/spring-projects/spring-security/blob/main/RELEASE.adoc)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.3.3.RELEASE...5.3.9.RELEASE)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-12 00:18:38 +00:00
Mark H. Wood
dffe025a35 [DS-2058] Add missing license to new package-info file. 2021-05-11 17:59:32 -04:00
Mark H. Wood
37668dccc8 [DS-2058] Clarify doc commentary. 2021-05-11 17:48:52 -04:00
Bruno Roemers
db17c16dc5 79369: WIP: Test item delete by collection admin
issue: the collection admin is not yet able to delete any associated bitstreams.
2021-05-11 18:12:42 +02:00
Bruno Roemers
c375e13f52 79369: Allow collection admins to delete item 2021-05-11 17:21:10 +02:00
Chris Wilper
9435f70a79 #3269 Log detail when Service Manager can't find bean 2021-05-10 20:01:23 -04:00
Tim Donohue
3a3cdb0f61 Ensure we check for CSRF changes after login failure. 2021-05-10 10:10:51 -05:00
Marie Verdonck
9436f1c426 javadoc for new param -> nullable 2021-05-07 16:02:03 +02:00
Antoine Snyers
3ad67676c5 Fix LineLength errors 2021-05-07 13:31:11 +02:00
Antoine Snyers
f33bf28dd4 Handle null value for config 2021-05-07 13:04:18 +02:00
Antoine Snyers
edf4214e44 Filter on standard fields without appending _keyword
Related to https://github.com/DSpace/dspace-angular/issues/1115
2021-05-07 11:49:31 +02:00
Antoine Snyers
1719024796 Add test for Private/Withdrawn "equals" filters in Administrative Search
Related to https://github.com/DSpace/dspace-angular/issues/1115
2021-05-07 10:57:25 +02:00
Mykhaylo
752eee2a57 Merge branch 'main' into CST-4121-MakeDiscoveryMoreResilientToStaleObjects 2021-05-06 18:28:29 +02:00
Tim Donohue
0b3c52d4ee Merge pull request #3241 from 4Science/CST-4060-SortOptionsAreNotReportedInTheProperOrder
Sort options are not reported in the proper order
2021-05-05 10:46:31 -05:00
Mykhaylo
7c32468425 added a fix that able to delete stale objects 2021-05-05 12:58:26 +02:00
Mykhaylo
7435ba9480 added tests to verify stale objects 2021-05-05 12:51:10 +02:00
Michael Spalti
e226ba954b Correction to annotationlist generator. 2021-05-04 19:30:31 -07:00
Michael Spalti
62a815b92b Changed incorrect inheritance. 2021-05-04 16:48:52 -07:00
Tim Donohue
78a3b4bf7f Merge pull request #3252 from 4Science/CST-4088-EmbeddedListsDontHavePaginationOptionsInTheirSelfLink
Embedded lists don't have pagination options in their self link
2021-05-04 16:03:29 -05:00
Michael Spalti
4658b97ede Merge branch 'main' into iiif-endpoint 2021-05-04 10:15:11 -07:00
Mykhaylo
d99fb55df1 user that is not admin can not see metadata of withdrawn items 2021-05-04 19:01:13 +02:00
Tim Donohue
cd79605290 Merge pull request #3240 from 4Science/CST-4059-featuresForTheEditItemPage
Features endpoint - features for the edit item page
2021-05-04 09:24:08 -05:00
Mykhaylo
0f38a8d0c8 added implementation that allows to see withdrawn items to anonynous groups 2021-05-04 11:36:11 +02:00
Mykhaylo
c1710cd95d added tests for withdrawn item 2021-05-04 11:32:47 +02:00
Tim Donohue
92d9c14415 Merge pull request #3260 from 4Science/issue-3259
Mention the Safari issue with external IdP in the local.cfg.EXAMPLE
2021-05-03 09:27:14 -05:00
Mykhaylo
fc066d9c13 fix tests 2021-05-03 11:56:15 +02:00
Mykhaylo
011eed4072 respond with 401 instead than 403 to invalid or expired JWT tokens 2021-05-03 10:43:54 +02:00
Andrea Bollini
296381b0f0 Mention the Safari issue with external IdP in the local.cfg.EXAMPLE 2021-05-01 11:34:53 +02:00
Tim Donohue
338418b3c3 Merge pull request #3180 from DSpace/dependabot/maven/org.eclipse.jetty-jetty-server-9.4.38.v20210224
Bump jetty-server from 9.4.35.v20201120 to 9.4.38.v20210224
2021-04-30 12:15:18 -05:00
Tim Donohue
ed887e8041 Merge pull request #3254 from DSpace/dependabot/maven/jackson.version-2.12.3
Bump jackson.version from 2.10.2 to 2.12.3
2021-04-29 17:17:31 -05:00
Tim Donohue
e15ca48b93 Merge pull request #3255 from DSpace/fix-readme-installation-url
Update DS7 installation url
2021-04-29 14:09:15 -05:00
Paulo Graça
1adb3be2dc Update DS7 installation url 2021-04-29 16:29:04 +01:00
Tim Donohue
f16b9428d5 Merge pull request #3242 from tdonohue/fix_shibboleth_auth
Fix broken Shibboleth Authentication & enhance tests & comments
2021-04-29 10:14:04 -05:00
Mykhaylo
5a0e068094 removed duplicate value from sortFields list in personOrOrgunit bean and fix test 2021-04-29 17:05:37 +02:00
Tim Donohue
3d9bf88a84 Merge pull request #3251 from DSpace/dependabot/maven/commons-io-commons-io-2.7
Bump commons-io from 2.6 to 2.7
2021-04-28 17:02:53 -05:00
dependabot[bot]
8ce86d2b7b Bump jetty-server from 9.4.35.v20201120 to 9.4.38.v20210224
Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 9.4.35.v20201120 to 9.4.38.v20210224.
- [Release notes](https://github.com/eclipse/jetty.project/releases)
- [Commits](https://github.com/eclipse/jetty.project/compare/jetty-9.4.35.v20201120...jetty-9.4.38.v20210224)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-28 21:42:08 +00:00
dependabot[bot]
1596d7c841 Bump jackson.version from 2.10.2 to 2.12.3
Bumps `jackson.version` from 2.10.2 to 2.12.3.

Updates `jackson-annotations` from 2.10.2 to 2.12.3
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `jackson-core` from 2.10.2 to 2.12.3
- [Release notes](https://github.com/FasterXML/jackson-core/releases)
- [Commits](https://github.com/FasterXML/jackson-core/compare/jackson-core-2.10.2...jackson-core-2.12.3)

Updates `jackson-databind` from 2.10.2 to 2.12.3
- [Release notes](https://github.com/FasterXML/jackson/releases)
- [Commits](https://github.com/FasterXML/jackson/commits)

Updates `jackson-jaxrs-base` from 2.10.2 to 2.12.3
- [Release notes](https://github.com/FasterXML/jackson-jaxrs-providers/releases)
- [Commits](https://github.com/FasterXML/jackson-jaxrs-providers/compare/jackson-jaxrs-providers-2.10.2...jackson-jaxrs-providers-2.12.3)

Updates `jackson-jaxrs-json-provider` from 2.10.2 to 2.12.3

Updates `jackson-module-jaxb-annotations` from 2.10.2 to 2.12.3
- [Release notes](https://github.com/FasterXML/jackson-modules-base/releases)
- [Commits](https://github.com/FasterXML/jackson-modules-base/compare/jackson-modules-base-2.10.2...jackson-modules-base-2.12.3)

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-28 21:37:48 +00:00
Tim Donohue
bd000cc674 Merge pull request #2713 from atmire/DS-4457_Default-mail-credentials-fix
DS-4457 Avoid smtp authentication by default
2021-04-28 15:13:45 -05:00
Tim Donohue
c3cbdd15fe Merge pull request #3239 from mspalti/working_dir
Fixed itemimport working dir configuration. #3163
2021-04-27 15:05:58 -05:00
Tim Donohue
db0297d5c4 Make ITs model exact behavior of UI/Hal Browser. This pointed out a flaw in codebase logic which is fixed in this commit. 2021-04-27 12:00:39 -05:00
Mykhaylo
7c7a6e26cb fix test 2021-04-27 12:43:16 +02:00
dependabot[bot]
d0455eb579 Bump commons-io from 2.6 to 2.7
Bumps commons-io from 2.6 to 2.7.

Signed-off-by: dependabot[bot] <support@github.com>
2021-04-26 16:28:09 +00:00
Mykhaylo
ba8ada13e3 fixed self link of embedded pagination 2021-04-26 17:35:08 +02:00
Mykhaylo
cb2012caf1 added test to verify that embedded lists have pagination options in their self-link 2021-04-26 17:31:09 +02:00
Tim Donohue
ea7df3b3a6 Test fix. Verify Authorization Cookie cleared after one usage. 2021-04-23 17:04:37 -05:00
Tim Donohue
f93d1ec004 Refactor HAL Browser login logic to work more like Angular UI & also ensure there's always at least one GET so that CSRF works properly 2021-04-23 15:21:33 -05:00
Tim Donohue
e5c7e0029c Minor code refactoring. Ensure auth cookie invalidation resets CSRF token & that it happens immediately on first usage of cookie 2021-04-23 15:16:44 -05:00
Tim Donohue
015e4ff609 Fix bug and add a ton of code comments to better describe how Shibboleth auth works 2021-04-21 14:27:41 -05:00
Tim Donohue
11d32b4953 Enhance Shibboleth tests to be more accurate. Add (failing) tests to prove that CSRF Token is NOT being reset after Auth via Cookie 2021-04-21 14:10:16 -05:00
Mykhaylo
d4493b24d0 minor fix 2021-04-20 11:33:11 +02:00
Mykhaylo
4acdc4fb9f implemented canManageMappingsFeature/canManageRelationshipsFeature and tests 2021-04-20 10:11:33 +02:00
Mykhaylo
3d16fca646 added tests for CanManageBitstreamBundlesFeature 2021-04-19 15:21:50 +02:00
Michael Spalti
3c5a3668fb Fixed itemimport working dir configuration. #3163 2021-04-17 15:32:04 -07:00
Michael Spalti
e4a828a39c Trial implementation of manifest caching.
Fixed style errors.
2021-04-17 15:05:42 -07:00
Mykhaylo
6e536abfb2 implemented CanManageBitstreamBundlesFeature 2021-04-16 19:11:39 +02:00
Mykhaylo
601e4020d2 Merge branch 'main' into CST-4059-featuresForTheEditItemPage 2021-04-16 10:46:44 +02:00
Mykhaylo
7cba6b17ec fix test 2021-04-16 09:32:16 +02:00
Tim Donohue
16e7fc9127 [maven-release-plugin] prepare for next development iteration 2021-04-15 16:44:11 -05:00
Tim Donohue
02a301b530 [maven-release-plugin] prepare release dspace-7.0-beta5 2021-04-15 16:44:04 -05:00
Tim Donohue
12550d1d96 Merge pull request #3238 from tdonohue/remove_cardinalities
Update Entity relationship types to remove non-zero cardinalities
2021-04-15 16:18:39 -05:00
Tim Donohue
01a31b27b5 Remove any non-zero cardinalities from relationship types until they are handled properly 2021-04-15 14:50:06 -05:00
Michael Spalti
9372c677b6 Updated logger. 2021-04-15 12:07:39 -07:00
Michael Spalti
fb1f0678cc Merge branch 'main' into iiif-endpoint 2021-04-15 11:31:18 -07:00
Tim Donohue
065c6cab8a Merge pull request #3236 from 4Science/issue-3234
Exclude swagger-jersey-jaxrs as it would include old v1 jersey depenies
2021-04-15 13:21:44 -05:00
Tim Donohue
6b08e7004c Merge pull request #3237 from tdonohue/correct_update_sequences
Remove sequences which no longer exist from 'updatesequences' command
2021-04-15 13:20:16 -05:00
Michael Spalti
9f93443cdf Merge branch 'main' into iiif-endpoint 2021-04-15 10:56:54 -07:00
Tim Donohue
a84b859704 Remove sequences which no longer exist 2021-04-15 12:07:10 -05:00
Mykhaylo
fa9a851917 added tests 2021-04-15 18:58:24 +02:00
Mykhaylo
d1026cdca9 implemented CanCreateVersionFeature and CanManageVersionsFeature 2021-04-15 18:56:41 +02:00
Mykhaylo
470268429d minor fix in test 2021-04-15 18:54:20 +02:00
Mykhaylo
2655996f02 rename ViewVersionsFeature to CanSeeVersionsFeature 2021-04-15 18:52:08 +02:00
Andrea Bollini
0148e4ffd2 Exclude swagger-jersey-jaxrs as it would include old v1 jersey dependencies 2021-04-15 18:47:20 +02:00
Tim Donohue
bd8276b7db Merge pull request #3225 from tdonohue/update_test_data
Update links to Entities test data
2021-04-14 17:04:13 -05:00
Tim Donohue
fb35aee7f0 Update Entities DB link. Add code to auto-update item-submission.xml for Entities dataset. 2021-04-14 16:00:30 -05:00
Tim Donohue
8a872745b7 Update links to Entities test data 2021-04-14 15:08:13 -05:00
Tim Donohue
f013ba257d Merge pull request #3235 from tdonohue/docker_enable_rest_to_trust_host
Ensure a REST API running in Docker always trusts requests from the host machine
2021-04-14 11:47:05 -05:00
Tim Donohue
e606ea7b23 Define a specific Docker network subnet and trust it in the local.cfg 2021-04-14 09:21:34 -05:00
Mykhaylo
d54907f3dc fix test 2021-04-14 14:44:38 +02:00
Mykhaylo
980f284302 added InvalidSearchRequestException to handle the case with an invalid sort field 2021-04-14 13:22:41 +02:00
Mykhaylo
f598a44a51 Merge branch 'main' into CST-4060-SortOptionsAreNotReportedInTheProperOrder 2021-04-13 14:43:51 +02:00
Mykhaylo
faecd9ac4a fix test 2021-04-13 13:20:11 +02:00
Mykhaylo
5d81dfe301 added tests 2021-04-13 12:55:13 +02:00
Mykhaylo
3ec9839b65 fix unit tests 2021-04-13 12:54:15 +02:00
Mykhaylo
be19c2b09e refactored the structure of sort options 2021-04-13 12:49:29 +02:00
Tim Donohue
32668b534e Merge pull request #3224 from 4Science/CST-4039
Patch Add entire array with virtual values does not work
2021-04-12 15:34:25 -05:00
Tim Donohue
56ba18ddb1 Merge pull request #3232 from tdonohue/default_submission_configs
Update/Correct default Submission Configurations for Testathon & Final release
2021-04-12 12:00:48 -05:00
Tim Donohue
2f4e177544 Update default submission configs to disable Entities by default, but add examples for our demo Entities dataset 2021-04-09 11:56:42 -05:00
Yana De Pauw
7125b958c7 78245: Bugfix to UsageReportRestPermissionEvaluatorPlugin 2021-04-09 14:40:11 +02:00
Tim Donohue
10bfce5585 Merge pull request #3192 from mwoodiupui/3190
Replace new uses of Log4J v1 with v2.  Ban v1 artifacts.  #3190.
2021-04-08 14:49:49 -05:00
Tim Donohue
b40fb1164e Merge pull request #3212 from atmire/GH-3211_tika-parsers-dependency
Fix #3211 by depending directly on tika-parsers
2021-04-08 12:25:50 -05:00
Tim Donohue
abcf52c30a Merge pull request #3223 from atmire/w2p-78174_CSRF-short-lived-token-get-endpoint
CSRF short lived token GET endpoint
2021-04-08 12:22:15 -05:00
Tim Donohue
b3a8b6e199 Merge pull request #3222 from atmire/w2p-78021_index-collection-location-on-submission-items
Collection location is not indexed for in submission items
2021-04-07 17:05:22 -05:00
Tim Donohue
ba2d6002b1 Merge pull request #3134 from atmire/tilted_rels
Designate "tilted" relationships to improve performance
2021-04-07 16:43:02 -05:00
Mark H. Wood
c2c7567836 Add Log4J 1.2 shim to 2.x in dspace-server because XOAI needs it. #3190 2021-04-07 16:38:52 -04:00
Alessandro Martelli
047c2850ce Merge branch 'main' into CST-4039
# Conflicts:
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/submit/factory/impl/ItemMetadataValueAddPatchOperation.java
2021-04-07 18:26:57 +02:00
Alessandro Martelli
5b90afab4e [CST-4039] Patch Add entire array with virtual values does not work 2021-04-07 18:21:31 +02:00
Alessandro Martelli
4d68fa4ad3 [CST-4039] Patch Add entire array with virtual values does not work 2021-04-07 16:47:27 +02:00
Tim Donohue
8f691a0af0 Merge pull request #3219 from tdonohue/lock_down_scripts
Restrict /api/system/scripts endpoint to admin-only
2021-04-07 09:34:11 -05:00
Mark H. Wood
e1e71855ea Merge branch 'main' into 3190 2021-04-07 10:12:28 -04:00
Mark H. Wood
88966a34e2 Merge remote-tracking branch 'upstream/main' into DS-2058-7x 2021-04-07 09:48:57 -04:00
Kevin Van de Velde
0ca07b1a9b Short lived token ip validation: Retrieve proper id for validation 2021-04-07 15:41:26 +02:00
Tim Donohue
997823c1dc Merge pull request #3189 from 4Science/removeBTE
Remove (deprecated) BTE Framework from 7.x codebase
2021-04-07 08:37:56 -05:00
Bruno Roemers
ee4e794298 78180: Rename ItemBuilder#withRelationshipType to withEntityType
Adapting to the changes in the latest upstream main branch.
2021-04-07 15:02:05 +02:00
Bruno Roemers
9a0ace4ce4 Merge branch 'main' into tilted_rels 2021-04-07 14:54:11 +02:00
Bruno Roemers
3393d6cc16 78206: Only allow access from trusted IPs 2021-04-07 14:37:17 +02:00
Bruno Roemers
9088eb0e78 78206: Make isRequestFromTrustedProxy public and add to interface 2021-04-07 11:42:44 +02:00
Bruno Roemers
cae3971459 Merge branch 'main' into w2p-78174_CSRF-short-lived-token-get-endpoint 2021-04-07 10:38:33 +02:00
Bruno Roemers
8785e5d56b 78180: Fix right tilted testIsOrgUnitOfPersonRelationshipMetadataViaREST 2021-04-07 10:30:38 +02:00
Bruno Roemers
c4e96713f0 78180: Create testIsOrgUnitOfPersonRelationshipMetadataViaREST 2021-04-07 10:28:38 +02:00
Bruno Roemers
b30a086361 78180: Rename to testIsAuthorOfPublicationRelationshipMetadataViaREST 2021-04-07 10:12:08 +02:00
Andrea Bollini
683cba643e Improve logging of date parsing issues 2021-04-07 10:02:52 +02:00
Andrea Bollini
101d4010fe Merge remote-tracking branch 'origin/main' into removeBTE 2021-04-07 10:02:22 +02:00
Bruno Roemers
a123acfea9 78021: Test that the owning collection is indexed on in-progress submissions 2021-04-06 19:04:44 +02:00
Bruno Roemers
08b80e7421 78180: WIP: Create RightTiltedRelationshipRestRepositoryIT 2021-04-06 18:54:09 +02:00
Bruno Roemers
7bcdfd8ae4 78180: Fix right tilted testGetJournalRelationshipMetadata 2021-04-06 18:43:17 +02:00
Tim Donohue
206f6bdc63 Merge pull request #3195 from 4Science/CST-3978
Added script to delete all metadata values
2021-04-06 11:38:05 -05:00
Bruno Roemers
1dcdf7e948 78180: Create RightTiltedRelationshipMetadataServiceIT and copy relevant methods for override 2021-04-06 18:29:22 +02:00
Alessandro Martelli
58d9f27b97 [CST-4039] Patch Add entire array with virtual values does not work
Created integration test
2021-04-06 18:18:30 +02:00
Bruno Roemers
44afde13ee 78180: Change signature of initJournalVolumeIssue 2021-04-06 18:16:01 +02:00
Bruno Roemers
0c118223d4 78180: Rename to LeftTiltedRelationship 2021-04-06 18:00:45 +02:00
Tim Donohue
cdc06a30dd Merge pull request #3171 from tdonohue/remove_ip_checks
Update IP-based security configurations to more sane defaults (now that CORS + CSRF are enabled)
2021-04-06 09:10:32 -05:00
Tim Donohue
5d9842762a Merge pull request #3186 from 4Science/issue-2891
Restoring sherpa and orcid support as authorities
2021-04-06 09:08:37 -05:00
Bruno Roemers
5433065c8e 78174: Move code from shortLivedToken() => shortLivedTokenResponse()
> If we ever make changes to the shortLivedToken() method itself this would affect the “shortLivedTokenViaGet()” method as well (which isn’t clear directly).
2021-04-06 11:49:25 +02:00
Bruno Roemers
5fd1c749c8 78021: Add collection to location list of in-progress submission solr document 2021-04-06 11:34:57 +02:00
Luca Giamminonni
7ba8b5900a Move bulkedit.allow-bulk-deletion property from dspace.cfg to bulkedit.cfg 2021-04-06 09:55:24 +02:00
Mark H. Wood
92548a0bfc [DS-2058] Satisfy Checkstyle 2021-04-05 19:47:02 -04:00
Mark H. Wood
80a6e2ced4 [DS-2058] Remove impossible tests of Curator state -- Curator is reset by service. 2021-04-05 16:55:47 -04:00
Michael Spalti
a82727b552 Removed unused import. 2021-04-05 10:16:09 -07:00
Michael Spalti
348a7d263e Corrected multi-word solr queries. 2021-04-04 11:53:09 -07:00
Mark H. Wood
7f94b91648 [DS-2058] Scrap integration test, make it a unit test, fake claimed tasks. 2021-04-04 10:38:26 -04:00
Michael Spalti
0efb145b8f Corrected dspace.entity.type metadata field name in utils. 2021-04-02 18:49:07 -07:00
Michael Spalti
8c3673e27e Added caching for manifests. 2021-04-02 15:20:52 -07:00
Michael Spalti
14ef8ab75b Using dspace.entity.type for iiif bundle lookup. 2021-04-02 15:12:28 -07:00
Michael Spalti
20a9c0a686 Updated IT for revised ItemBuilder. 2021-04-02 14:32:04 -07:00
Tim Donohue
eff51a5364 Merge pull request #3218 from mwoodiupui/3217
Proper Bean-like initialization of SherpaService
2021-04-02 14:14:19 -05:00
Mark H. Wood
9af1c06d11 [DS-2058] Failing attempt at an integration test. 2021-04-02 15:08:54 -04:00
Tim Donohue
f33a502c2f Ensure trim() happens before verifying IP address & correct test (this test correction fails without the code change) 2021-04-02 13:57:49 -05:00
Tim Donohue
ecfb338cbc Enhance tests of IPTable to prove it doesn't allow duplicates 2021-04-02 13:57:49 -05:00
Michael Spalti
136f0fcb5b Merge branch 'main' into iiif-endpoint 2021-04-02 10:12:59 -07:00
Michael Spalti
239de60178 Removed uncessary encoding of solr query. 2021-04-02 10:11:29 -07:00
Tim Donohue
f38d62d621 Restrict scripts endpoint to ADMIN for now as all scripts are currently Admin-only 2021-04-02 11:28:51 -05:00
Bruno Roemers
5596d4f48f 78174: Add endpoint GET /api/authn/shortlivedtokens 2021-04-02 18:26:56 +02:00
Mark H. Wood
3555cf2ef7 [DS-2058] Code cleanup, documentation. 2021-04-02 11:25:55 -04:00
Tim Donohue
7b0ed1bba8 Merge pull request #3183 from tdonohue/entity_type_storage
Rename / move 'relationship.type' metadata field to 'dspace.entity.type'
2021-04-02 09:22:17 -05:00
Mark H. Wood
e80937d625 [DS-2058] findTaskSet should *always* return a TaskSet. 2021-04-02 10:20:18 -04:00
Mark H. Wood
8a57cb0e4b [DS-2058] Catch up with removal of traditional workflow in main. 2021-04-02 10:17:44 -04:00
Mark H. Wood
d82f66b380 [DS-2058] Correct path to workflow curation configuration.
Also clean up an annoying typo in a comment.
2021-04-02 10:15:05 -04:00
Mark H. Wood
6e4b07f746 Proper initialization of SherpaService Bean. #3217 2021-04-01 16:57:38 -04:00
Tim Donohue
7b55ed8e2c Merge pull request #3148 from atmire/w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST
Getting 401 when Community or Collection Administrator tries to edit Collection Authorization Group
2021-04-01 13:47:03 -05:00
Raf Ponsaerts
6a66463f44 fix duplicate id 2021-04-01 16:28:37 +02:00
Raf Ponsaerts
4457bceace Merge remote-tracking branch 'dspace/main' into w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST 2021-04-01 16:28:09 +02:00
Mark H. Wood
774582ede1 Merge remote-tracking branch 'upstream/main' into DS-2058-7x 2021-04-01 09:59:36 -04:00
Raf Ponsaerts
e2564fbbfc Merge branch 'w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST' of https://github.com/atmire/DSpace into w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST 2021-04-01 15:57:11 +02:00
Mark H. Wood
9abfdcf097 [DS-2058] Supply more missing Javadoc 2021-04-01 09:49:34 -04:00
Raf Ponsaerts
2ac1a22515 fix tests 2021-04-01 15:21:57 +02:00
Andrea Bollini
ffcca497a8 Merge pull request #3160 from atmire/metadata-field-caching-hibernate-3-performance-test
Metadata field caching hibernate performance
2021-04-01 14:29:22 +02:00
Andrea Bollini
738bd7752d Merge pull request #3200 from atmire/w2p-77817_Index-mapped-items
Mapped Items not visible in Collection browse
2021-04-01 14:08:29 +02:00
Bruno Roemers
c498220296 78138: BUGFIX: Set tilted before virtual metadata is cached 2021-04-01 10:55:08 +02:00
Bruno Roemers
4648373cce Merge branch 'main' into tilted_rels 2021-04-01 10:20:07 +02:00
Bruno Roemers
c34aeb51d3 Revert "78138: Turn off test line that fails in multiple PRs"
This reverts commit 38bcd1da77.
2021-04-01 10:19:41 +02:00
Yura Bondarenko
e23f2980e0 77817: Add subject null check 2021-04-01 09:48:41 +02:00
Yura Bondarenko
9b748790c8 77817: Update mapped/unmapped Items in IndexEventConsumer 2021-04-01 09:44:39 +02:00
Yura Bondarenko
20dc0f6fbe Revert "77817: Mark item as modified when adding to/removing from collection"
This reverts commit d80d26db
2021-04-01 09:44:39 +02:00
Yura Bondarenko
5cd9cc7802 77817: Add integration tests 2021-04-01 09:44:39 +02:00
Yura Bondarenko
0597779b63 77817: Mark item as modified when adding to/removing from collection 2021-04-01 09:44:39 +02:00
Michael Spalti
a2929fa17b Removed word_highlighting solr core. 2021-03-31 18:54:50 -07:00
Tim Donohue
e7ce2f4383 Fix checkstyle 2021-03-31 18:12:52 -05:00
Tim Donohue
b3088fc0d3 Response to feedback. Add new proxies.trusted.include_ui_ip setting to determine whether UI IP lookup is done. More tests to prove it works 2021-03-31 17:32:02 -05:00
Tim Donohue
85062471d4 Fix bug by ensuring we only return IPv4 addresses at this time. Enhance tests in AnonymousAdditionalAuthorizationFilterIT to show it works with proxies on or off. 2021-03-31 15:36:39 -05:00
Tim Donohue
d9eea7abaa Enhance logging & comments regarding proxy settings 2021-03-31 15:36:38 -05:00
Tim Donohue
4016280c9e If trusted proxies are not configured, default to trusting UI's IP address 2021-03-31 15:36:38 -05:00
Tim Donohue
f2f7d127aa Upgrade Mockito & use "mockito-inline" to allow for mocking static methods 2021-03-31 15:36:38 -05:00
Tim Donohue
5ff6c04989 Copy CORS settings to local.cfg by default. Add test to prove CORS blocks authentication from untrusted origins 2021-03-31 15:36:33 -05:00
Tim Donohue
4efe92e23d Remove options to add IP address in JWT auth token. Fixes #2938 2021-03-31 15:34:39 -05:00
Tim Donohue
2af69dd077 Add Flyway migrations to move from relationship.type to dspace.entity.type 2021-03-31 15:07:03 -05:00
Tim Donohue
ee33a4935d Fixes to newly merged Google Scholar entity code in #3150 2021-03-31 15:07:02 -05:00
Tim Donohue
cdb59db8f5 Fix incorrect/failing test. Entity Type passed in CSV update MUST match entity type of the Item being updated. 2021-03-31 15:07:02 -05:00
Tim Donohue
9bf9c3037f Refactor tests, especially CsvImportIT to locate bug. No core logic is changed, just renaming methods/variables & adding a few more tests. 2021-03-31 15:06:58 -05:00
Tim Donohue
e88db03c51 Additional replacements where schema, element & qualifier were separate 2021-03-31 15:04:46 -05:00
Tim Donohue
4c0a38fb40 Rename / move 'relationship.type' metadata field to 'dspace.entity.type' 2021-03-31 15:01:45 -05:00
Tim Donohue
05b80bd941 Merge pull request #3213 from tdonohue/fix_failing_test
Refactor existing Metadata Schema & Field pagination tests to determine pagination dynamically
2021-03-31 14:47:48 -05:00
Tim Donohue
6c37c552c8 Merge pull request #3170 from atmire/w2p-77244_ItemMetadata-caching-bugfixes
Caching the item metadata for entities
2021-03-31 14:32:33 -05:00
Tim Donohue
5de643ba04 Merge pull request #3196 from 4Science/CST-3962
Item not indexed due to authority value not being in a controlled vocabulary
2021-03-31 14:24:55 -05:00
Tim Donohue
7b4f0c7f44 Determine metadata field count & pagination dynamically as well 2021-03-31 13:47:28 -05:00
Michael Spalti
2548eef9ae Removed unused import. 2021-03-31 11:38:15 -07:00
Michael Spalti
8fd05b1b16 Minor updates. 2021-03-31 11:01:07 -07:00
Tim Donohue
765a928fcd Merge pull request #3188 from 4Science/CST-3960-SearchLinksInFacetValuesDontContainTheConfiguration
Search links in facet values dont contain the configuration
2021-03-31 12:45:43 -05:00
Tim Donohue
b85b15f876 Fix test to determine number of schema in DB prior to checking pagination 2021-03-31 12:18:56 -05:00
Bruno Roemers
38bcd1da77 78138: Turn off test line that fails in multiple PRs 2021-03-31 15:05:02 +02:00
Bruno Roemers
4041635135 Merge branch 'main' into w2p-78138_update-tests-for-tilted-relationships 2021-03-31 14:19:36 +02:00
Bruno Roemers
0d3009d322 78138: Write test case testRelationshipMetadataViaREST 2021-03-31 13:57:41 +02:00
Raf Ponsaerts
63d21cd4f0 Partial refactor, still issues with infinite loops 2021-03-31 13:28:04 +02:00
Samuel
1b3ace654b taskid 78099 ItemMetadata caching test - feedback 2021-03-31 12:38:46 +02:00
Chris Wilper
f84b0dc9e0 #3211 Exclude tika-parsers dependencies we already use, but with different versions 2021-03-30 23:45:56 -04:00
Chris Wilper
ef62e22aa1 #3211 Change tika-core dependency to tika-parsers 2021-03-30 23:35:34 -04:00
Michael Spalti
4c9b029489 Merge branch 'iiif-endpoint' of https://github.com/mspalti/DSpace into iiif-endpoint 2021-03-30 17:43:25 -07:00
Michael Spalti
38f68abddb Minor updates to iiif services. 2021-03-30 17:36:44 -07:00
Michael Spalti
031cef8b45 Updated dspace.cfg to support iiif ITs 2021-03-30 17:35:46 -07:00
Michael Spalti
8d8e2172d0 Added word_highlighing solr core. 2021-03-30 08:07:52 -07:00
Michael Spalti
bf1451cfe0 Updated search service to use solr client libraries. 2021-03-30 08:07:52 -07:00
Michael Spalti
ec94740a9a Added exception to search service query. 2021-03-30 08:07:52 -07:00
Michael Spalti
82171dfa6a Updated dspace.cfg comment. 2021-03-30 08:07:52 -07:00
Michael Spalti
cb81aff432 Updated the image service thumbnail path. 2021-03-30 08:07:52 -07:00
Michael Spalti
952c3b603b Minor refactor manifest generator 2021-03-30 08:07:52 -07:00
Michael Spalti
4fcd6c1e41 Added sample iiif config to dspace.cfg 2021-03-30 08:07:52 -07:00
Michael Spalti
675e3c0b64 Added new method to the test BitstreamBuilder and moved iiif test package. 2021-03-30 08:07:52 -07:00
Michael Spalti
79bb86a5db Added integration tests. 2021-03-30 08:07:52 -07:00
Michael Spalti
6ed7bedaa9 Added iiif controller. 2021-03-30 08:07:52 -07:00
Michael Spalti
eaee79831b Added iiif repository. 2021-03-30 08:07:52 -07:00
Michael Spalti
ffdf6de26f Added iiif service and utility classes. 2021-03-30 08:07:52 -07:00
Michael Spalti
86bf766db1 Added classes for parsing the info.json object. 2021-03-30 08:07:52 -07:00
Michael Spalti
c746a9b43b Added factory for objectmapper. 2021-03-30 08:07:52 -07:00
Michael Spalti
8dea0807b7 Added iiif model generator classes. 2021-03-30 08:07:52 -07:00
Michael Spalti
0ea5f13498 Adding iiif-apis dependency 2021-03-30 08:07:52 -07:00
Peter Nijs
b663fb20ac 76284: Use primitive longs 2021-03-30 16:54:20 +02:00
Tim Donohue
34c1e82275 Merge pull request #3194 from atmire/w2p-77582_Issue-3113_Fix-item-handle-redirect
handle redirect for items not working - REST Implementation
2021-03-30 09:49:57 -05:00
Tim Donohue
a58257512e Merge pull request #3205 from atmire/1067-blank-qualifier
fix #1067 metadatafield with blank qualifier
2021-03-30 09:23:51 -05:00
Samuel
5d9ad392df taskid 78006 Test metadata field caching branch - PR 3160 - feedback 2021-03-30 15:06:59 +02:00
Andrea Bollini
a39e33b4c3 Add more information about the extraction step 2021-03-30 13:53:10 +02:00
Andrea Bollini
6c121659af Little javadoc cleanups 2021-03-30 13:46:36 +02:00
Andrea Bollini
18fb0ca50c Remove obsolete warnings and use of label on the server side (it is responsability of the UI) 2021-03-30 13:24:14 +02:00
Andrea Bollini
44be7c7a50 Rename Orcidv3 in a more meaningful way 2021-03-30 13:23:20 +02:00
Samuel
535f90e147 taskid 78099 ItemMetadata caching test 2021-03-30 10:42:16 +02:00
Samuel
c53c1f6909 taskid 78006 Test metadata field caching branch - PR 3160 2021-03-30 09:57:00 +02:00
Michael Spalti
8e1f0ca85b Updated search service to use solr client libraries. 2021-03-29 16:21:21 -07:00
Tim Donohue
d2386bc4ab Merge pull request #3208 from tubhh/LDAP_bugfix_groups
Corrects reading of configuration options in LDAPAuthentication
2021-03-29 11:29:27 -05:00
Raf Ponsaerts
46ea777250 Changed to primitive long for count methods in authorizeService 2021-03-29 10:21:53 +02:00
Yura Bondarenko
ec90374ff6 77582: Fix imports 2021-03-29 09:02:13 +02:00
Michael Spalti
47e835db0d Added exception to search service query. 2021-03-28 17:06:49 -07:00
Michael Spalti
b31d3ec98f Updated dspace.cfg comment. 2021-03-28 10:25:24 -07:00
yura bondarenko
01d47fb639 Add license header 2021-03-27 18:08:41 +01:00
Michael Spalti
256f89bbbe Updated the image service thumbnail path. 2021-03-26 17:45:40 -07:00
Michael Spalti
c39bd6c7c2 Minor refactor manifest generator 2021-03-26 16:37:45 -07:00
Michael Spalti
78c66f3fed Added sample iiif config to dspace.cfg 2021-03-26 16:36:54 -07:00
Tim Donohue
3560a74b34 Merge pull request #3209 from tdonohue/pin_postgres_in_Docker
Pin to Postgres 11 in Dockerfiles
2021-03-26 16:44:51 -05:00
Tim Donohue
9afe043fb7 Pin to Postgres 11 in Dockerfiles 2021-03-26 15:19:04 -05:00
Peter Nijs
dee67dcb2f 76284: non site admin edit collection authorization group REST feedback
- Merge AuthorizeSolrService into AuthorizeService
- PreAuthorize findAdminAuthorized methods
2021-03-26 17:39:38 +01:00
Yura Bondarenko
174225923a 77582: Add unit tests for HandleServiceImpl#parseHandle 2021-03-26 16:20:34 +01:00
Yura Bondarenko
a43e07f89a 77582: Rename formatHandle to parseHandle & add @Override 2021-03-26 16:20:11 +01:00
Luca Giamminonni
3f8c76dc3c Fix MetadataDeletionIT test 2021-03-26 15:46:13 +01:00
Luca Giamminonni
d421ac1b63 Added allow-bulk-deletion property to specify erasable fields via bulk deletion 2021-03-26 15:37:49 +01:00
Michael Spalti
a3a809ea6b Added new method to the test BitstreamBuilder and moved iiif test package. 2021-03-25 16:04:45 -07:00
Michael Spalti
fb72c2a4b5 Added integration tests. 2021-03-25 15:56:55 -07:00
Michael Spalti
1b6c770d23 Added iiif controller. 2021-03-25 15:54:34 -07:00
Michael Spalti
988b221e0d Added iiif repository. 2021-03-25 15:53:28 -07:00
Michael Spalti
1a6d3d4ee3 Added iiif service and utility classes. 2021-03-25 15:52:21 -07:00
Michael Spalti
1a353d4bd5 Added classes for parsing the info.json object. 2021-03-25 15:48:31 -07:00
Michael Spalti
dae544ac97 Added factory for objectmapper. 2021-03-25 15:47:15 -07:00
Michael Spalti
5ac85abc67 Added iiif model generator classes. 2021-03-25 15:44:02 -07:00
Michael Spalti
5c47af0578 Adding iiif-apis dependency 2021-03-25 15:20:06 -07:00
Tim Donohue
13d8ce6312 Merge pull request #3203 from tubhh/LDAP_bugfix
LDAP Authentication: use generic exception instead of special SQLException
2021-03-25 14:42:13 -05:00
Mykhaylo
1979a4d4fb Merge branch 'main' into CST-3960-SearchLinksInFacetValuesDontContainTheConfiguration 2021-03-25 17:05:20 +01:00
Mykhaylo
deec143f35 added tests 2021-03-25 16:51:37 +01:00
Tim Donohue
8f5c826781 Merge pull request #3198 from 4Science/CST-3980-WorkflowDiscoveryConfigurationQueryWithQueryParameterSetWithFreeTextReturnsNoResults
Workflow discovery configuration query with query parameter set with free text returns no results
2021-03-25 09:33:30 -05:00
Tim Donohue
c2108141ec Merge pull request #3206 from atmire/w2p-77810_Issue-3139_Log-REST-API-exceptions
Exceptions in DSpace 7 REST API producing log entries in DSpace log files
2021-03-25 09:26:01 -05:00
April Herron
258d0f66bd Comment fixes for tilted relationships 2021-03-25 09:38:18 -04:00
Mykhaylo
be44791006 Implement community feedbacks 2021-03-25 13:25:59 +01:00
Mykhaylo
92988b409e Merge branch 'main' into CST-3962 2021-03-25 13:20:51 +01:00
Andrea Bollini
d01ec35e69 Merge pull request #3126 from tdonohue/cleanup_solr_configs
Cleanup DSpace Solr Configs for v8 & update to Solr 8.8.1
2021-03-25 12:50:21 +01:00
Oliver Goldschmidt
2d069b019a fixes #3207: corrects reading of configuration options 2021-03-25 12:37:22 +01:00
Mykhaylo
a31383ce6f Implement community feedbacks 2021-03-25 11:47:25 +01:00
Oliver Goldschmidt
68d311ddd0 fixes style issue 2021-03-25 11:22:17 +01:00
Andrea Bollini
3b8677b994 Merge pull request #3176 from atmire/w2p-77228_Issue-2798-Missing-ITs-for-browse-by-authority-values
Missing ITs for browse by authority values fix
2021-03-25 11:14:43 +01:00
Oliver Goldschmidt
e4349db70c return to SQLException catch and testing for Nullpointers manually 2021-03-25 10:55:54 +01:00
Andrea Bollini
3b61bb1ed5 Community feedback 2021-03-24 21:28:17 +01:00
Andrea Bollini
37289b01c4 Code cleanup: remove unused submit code from dspace-api 2021-03-24 21:01:28 +01:00
Andrea Bollini
b11afd16f3 Mock the publication import service for testing 2021-03-24 20:57:42 +01:00
Andrea Bollini
e8ee8e5afb Fix misleading properties names for the CharacterSeparated provider 2021-03-24 17:16:33 +01:00
Samuel
01ff437b74 fix #1067 metadatafield with blank qualifier 2021-03-24 16:35:47 +01:00
Oliver Goldschmidt
ede3f11073 use generic exception instead of special SQLException 2021-03-24 14:24:48 +01:00
Andrea Bollini
ca70f69fb9 Make a common ancestor for the Listener and processing steps 2021-03-24 13:37:47 +01:00
Andrea Bollini
c62d06374e Cleanup submission code
Moved shared code among workspace and workflow repository to the submission service
introduced a base RestProcessingStep interface to be specialized among ListenerStep and AbstractRestProcessingStep (data processing)
removed retrieval of the Request from the service passing directly the http request that was available
added test to check the special case of steps that should be not exposed as panel (extract step)
2021-03-24 12:31:24 +01:00
Andrea Bollini
ee2f35b76e Fix type of the extract panel in the configuration 2021-03-24 11:54:00 +01:00
Andrea Bollini
847e104bb4 Switch to opencvs in the com.opencsv groupId 2021-03-24 11:52:54 +01:00
Kim Shepherd
713d91eaa2 [DS-4522] Clean up unused imports 2021-03-24 13:28:10 +13:00
Tim Donohue
e1478f6fdd Merge pull request #3191 from 4Science/CST-3961-CannotClaimPoolTasksCreatedBeforeYouWereAddedToAworkflowApprovalGroup
Cannot claim PoolTasks created before you were added to a workflow approval group
2021-03-23 08:59:56 -05:00
Kim Shepherd
3d609faf07 [DS-4522] Use more generic IdentifierNotApplicableException where applicable 2021-03-23 16:17:47 +13:00
Kim Shepherd
cc1f67734e [DS-4522] Refactor LogicalStatement.getResult() type to primitive boolean 2021-03-23 14:34:58 +13:00
Kim Shepherd
a3beda1a05 [DS-4522] Remove unused imports 2021-03-23 14:34:45 +13:00
Kim Shepherd
b51a894361 [DS-4522] Add unit tests for remaining conditions, fix service instantiation for tests 2021-03-23 13:52:02 +13:00
Tim Donohue
f4b5e9c26b Merge pull request #3168 from tdonohue/reduce_csrf_token_refreshing
Reduce frequency of CSRF Tokens being refreshed/reset
2021-03-22 10:07:04 -05:00
Tim Donohue
6b352ea45d Merge pull request #3166 from UoEMainLibrary/DS-4575-7
[DS-4575]  v.7 - Exposed more parameters for DBCP2
2021-03-22 09:12:41 -05:00
Tim Donohue
6653a5bdd7 Merge pull request #3164 from UoEMainLibrary/DS4574-7
[DS-4574] v. 7 - Upgrade DBCP2 dependency
2021-03-22 09:09:29 -05:00
Mykhaylo
0c6c1adc99 Merge branch 'main' into CST-3961-CannotClaimPoolTasksCreatedBeforeYouWereAddedToAworkflowApprovalGroup 2021-03-22 11:30:56 +01:00
Yura Bondarenko
03c8079be8 77810 - Log 5xx/4xx REST exceptions 2021-03-19 15:36:18 +01:00
Raf Ponsaerts
af226189e0 changed cleanup from general tests to after specific test 2021-03-19 10:57:00 +01:00
Tim Donohue
404b8281ee Enhance expectations in test. Document in comments why we send 2 cookies when CSRF token changes. 2021-03-18 16:05:25 -05:00
Tim Donohue
158d088fec Enhance/add JavaDocs to RestAuthenticationService 2021-03-18 16:05:25 -05:00
Tim Donohue
e0b9a488b5 Modify behavior to match tests. CSRF token only refreshes on login, logout or when sent via param. 2021-03-18 16:05:25 -05:00
Tim Donohue
e100063abc Add tests for expected behavior. CSRF token only refreshes on login, logout or when passed as a param. 2021-03-18 16:05:25 -05:00
Tim Donohue
2c4e7118e6 Merge pull request #3179 from Micheleboychuk/CST-3937-TheHALlinksForSearchEndpointsAreBrokenAndNamedInAninconsistentWay
The HAL links for search endpoints are broken and named in an inconsistent way
2021-03-18 15:48:31 -05:00
Mykhaylo
bc703129aa Revert "added item metadata in solr documets of pooltask/claimedkask"
This reverts commit 8a6fd61c99.
2021-03-18 18:40:25 +01:00
Mykhaylo
aed7ac23c6 Merge branch 'w2p-77593_workflow-items-item-metadata-indexing-issue' of https://github.com/atmire/DSpace into CST-3980-WorkflowDiscoveryConfigurationQueryWithQueryParameterSetWithFreeTextReturnsNoResults 2021-03-18 18:40:06 +01:00
Mykhaylo
8a6fd61c99 added item metadata in solr documets of pooltask/claimedkask 2021-03-18 16:47:18 +01:00
Mykhaylo
8e5c28572f added test that proves bug in discovery search with configuration = workflow 2021-03-18 16:40:04 +01:00
Raf Ponsaerts
17dd108381 changed test matching to reflect ordering 2021-03-18 13:48:20 +01:00
Mykhaylo
22457403b9 added javaDoc 2021-03-18 11:56:07 +01:00
Mykhaylo
4bf75e5a05 added fix where Item can't indexed due to authority value not being in a controlled vocabulary 2021-03-18 11:14:28 +01:00
Mykhaylo
b31cd04f52 added test that proves a bug where Item not indexed due to authority value not being in a controlled vocabulary 2021-03-18 11:11:59 +01:00
Luca Giamminonni
233202dbe4 MetadataDeletion script improvements 2021-03-17 15:22:14 +01:00
Luca Giamminonni
f6f501d37c Script to delete all the values of a specified metadata field 2021-03-17 14:51:33 +01:00
Raf Ponsaerts
7bacbe73d4 Fixed authorityKey in facet endpoint response and constructed a test for this 2021-03-17 12:42:47 +01:00
Mark H. Wood
dc487fd29d Replace new uses of Log4J v1 with v2. Ban v1 artifacts. #3190. 2021-03-17 06:04:49 -04:00
Mykhaylo
025864a149 added test that proves right functionality of workflow 2021-03-17 10:44:28 +01:00
Andrea Bollini
1cb6a2ffa0 Align test to the configuration 2021-03-17 09:32:08 +01:00
Andrea Bollini
d1f126b287 Fix dependencies for dspace-rest (legacy) 2021-03-16 22:30:02 +01:00
Andrea Bollini
49728a097e Fix checkstyle issue 2021-03-16 21:32:47 +01:00
Andrea Bollini
2eed442e06 Remove BTE and implement the metadata extraction step using the Live Import 2021-03-16 21:31:24 +01:00
Mykhaylo
3d37e1cb9b added a fix that able to add configuration in search links of facet values 2021-03-16 16:14:40 +01:00
Mykhaylo
3961503fbf added tests that prove search links in facet values don't contain the configuration 2021-03-16 16:09:28 +01:00
Raf Ponsaerts
dcaadba772 cleanup 2021-03-16 14:53:45 +01:00
Yura Bondarenko
315e29d2b1 77582: Add HandleService#formatHandle to strip prefixes from handle 2021-03-16 13:21:43 +01:00
Yura Bondarenko
f52cc59dde TEST PoolTask/ClaimedTask indexing 2021-03-16 11:26:25 +01:00
Andrea Bollini
96693199ca Remove Useless null check reported by LGTM 2021-03-16 10:29:39 +01:00
Andrea Bollini
2b31e5db8e Adapt findAll test to the new configuration 2021-03-16 10:09:49 +01:00
Kim Shepherd
0abee65424 [DS-4522] Add unit tests for Bitstream, InCollection, InCommunity, IsWithdrawn conds 2021-03-16 15:54:21 +13:00
Kim Shepherd
5a85309220 [DS-4522] Apply parameter, item, context checks as per PR review 2021-03-16 15:53:38 +13:00
Kim Shepherd
da844bc03d [DS-4522] Apply 'owning collection' fix to InCommunityCondition collection iteration 2021-03-16 15:53:07 +13:00
Kim Shepherd
a770e7996e [DS-4522] Apply bugfix to InCollectionCondition - better 'owning collection' check 2021-03-16 14:32:11 +13:00
Kim Shepherd
f74f4e3b18 [DS-4522] Remove fetchccdata.cfg include (accidentally kept during rebase vs main) 2021-03-16 13:50:06 +13:00
Kim Shepherd
692dbe7fad [DS-4522] Make LogicalStatementException unchecked as per PR review 2021-03-16 13:40:52 +13:00
Kim Shepherd
5096c66437 [DS-4522] Expand debug log message to explain what happens when filter service is null 2021-03-16 13:39:46 +13:00
Kim Shepherd
1bb5e35f04 [DS-4522] Refactor boolean canMint() to void checkMintable() as per PR review 2021-03-16 13:32:09 +13:00
Pascal-Nicolas Becker
6fbc4dbd6f DS-4522: Add missing license header 2021-03-16 13:25:30 +13:00
Kim Shepherd
4e70bce553 [DS-4522](main) Fix default configuration for curation task 2021-03-16 13:25:30 +13:00
Kim Shepherd
677623a1b7 [DS-4522](main) Unit tests for filters and DOI provider 2021-03-16 13:25:30 +13:00
Kim Shepherd
b049e65110 [DS-4522](main) Configuration (spring), providers and filters 2021-03-16 13:22:33 +13:00
Kim Shepherd
11d7b5b063 [DS-4522](main) RegisterDOI curation task (as CLI and UI control) 2021-03-16 13:19:09 +13:00
Kim Shepherd
d27dc96cbe [DS-4522](main) Item logical filters and DOI filtered provider 2021-03-16 13:19:09 +13:00
Andrea Bollini
3b3d9b9c47 Fix obvious mistake in the sherpa publisher query 2021-03-15 15:17:25 +01:00
Andrea Bollini
eb98243000 Fix sherpa response parsing issues 2021-03-15 15:17:25 +01:00
Andrea Bollini
85ea680140 Rename staff according to the current ORCID version 2021-03-15 15:17:05 +01:00
Andrea Bollini
070776557d Adapt orcid and sherpa authorities to the new APIs 2021-03-14 22:48:47 +01:00
Mark H. Wood
8541d3b05e Merge remote-tracking branch 'upstream/main' into DS-4300 2021-03-14 11:31:57 -04:00
Mark H. Wood
ea8ecdeff2 Merge remote-tracking branch 'upstream/main' into DS-4289 2021-03-14 11:16:38 -04:00
Mark H. Wood
5c6cd3eca3 [DS-3951] Update a newer test to cope with lists of recipients. 2021-03-13 20:22:05 -05:00
Andrea Bollini
78ea63ea91 Restoring Sherpa and ORCID authority classes and configuration 2021-03-13 22:51:03 +01:00
Mark H. Wood
80975dfd25 Merge remote-tracking branch 'upstream/main' into DS-3951 2021-03-13 14:53:16 -05:00
Mark H. Wood
80f2b7750d Merge remote-tracking branch 'upstream/main' into DS-4410 2021-03-13 08:30:59 -05:00
Tim Donohue
2b4f22be65 Merge pull request #3181 from 4Science/CST-3946-SearchPageResultNumberBug
Search page result number bug
2021-03-12 17:05:18 -06:00
Tim Donohue
55fafe75e0 Merge pull request #3178 from Micheleboychuk/CST-3544-CollectionResourceEndPointsDontIncludePaginationInformation
Collection resource end points dont include pagination information
2021-03-12 16:04:09 -06:00
Tim Donohue
c84a349039 Merge pull request #3150 from atmire/w2p-75924_Entitytypes-in-sitemaps
DS-4283: (Google Scholar) Provide Entity Type Label/Name as part of URL path
2021-03-12 12:19:30 -06:00
Hrafn Malmquist
75e3369d39 Clarify removeAbandoned, add reference to core-hibernate.xml 2021-03-12 09:59:45 +00:00
Mykhaylo
52a3df1243 Merge branch 'main' into CST-3937-TheHALlinksForSearchEndpointsAreBrokenAndNamedInAninconsistentWay 2021-03-11 11:32:41 +01:00
j4bbi
a49ebf4f38 Update Commons Pool2 dep to 2.9.0 2021-03-11 10:28:52 +00:00
Mykhaylo
66a8b1c7df added fix that able to delete solr record 2021-03-11 10:47:35 +01:00
Mykhaylo
6b87011377 added test that proves delete of solr record 2021-03-11 10:28:47 +01:00
Tim Donohue
1ddd052a40 Merge pull request #3054 from Micheleboychuk/CST-3539
Update claimedtasks and pooltasks to support reloading of workflow actions on individual WorkflowItems
2021-03-10 09:11:02 -06:00
Mykhaylo
559b267ca2 changed single name to plural name on search methods of HAL links 2021-03-10 10:44:01 +01:00
Mykhaylo
e6576e07cd added tests to prove right functionalicy of root search end points 2021-03-09 17:33:18 +01:00
Mykhaylo
65c84f0554 added check to model plural name for search methods 2021-03-09 16:30:04 +01:00
Mykhaylo
b153194348 fixed bug that hided pagination information in the self link 2021-03-09 13:16:44 +01:00
Mykhaylo
afef66b1b8 added tests that prove the correct links during the request with pagination information 2021-03-09 13:10:19 +01:00
Yura Bondarenko
ece20cf1d4 77228: Fix browse/facet authority IT cleanup 2021-03-09 09:44:54 +01:00
Tim Donohue
5956609b81 Merge pull request #3161 from tdonohue/cleanup_config_and_messages
Cleanup unused/unnecessary Configurations and messages for 7.0
2021-03-08 08:57:10 -06:00
Mykhaylo
5fc63dc140 Merge branch 'main' into CST-3539_rebased 2021-03-08 10:15:51 +01:00
Mark H. Wood
8912d9c9ea Add much missing javadoc. Elaborate or clarify quite a bit too. [DS-2058] 2021-03-05 17:12:04 -05:00
Tim Donohue
0cd1e1b636 Remove unused JSON request handlers 2021-03-05 15:28:25 -06:00
Tim Donohue
b3fbaa4b1d Rename to RegistryUpdater so that it comes alphabetically *after* GroupServiceInitializer as Flyway runs callbacks alphabetically 2021-03-05 16:12:49 -05:00
Tim Donohue
2f33245f57 Remove unused log.init.config 2021-03-05 15:02:35 -06:00
Tim Donohue
a8d99bba15 Address feedback. Restore a few settings which are still used 2021-03-05 14:57:39 -06:00
Yura Bondarenko
379dd2d8a7 77228: Fix line length 2021-03-05 16:55:41 +01:00
j4bbi
7fc96dc148 Exposed more parameters for DBCP2 2021-03-05 13:39:34 +00:00
Yura Bondarenko
0df65bfa9b 77228: Fix authority browse/facet IT side effects 2021-03-05 12:03:45 +01:00
Bruno Roemers
52e1aa9dce 77489: Fix test TiltedRelationshipMetadataServiceIT#testGetAuthorRelationshipMetadata 2021-03-05 11:32:20 +01:00
Bruno Roemers
6f7181de4c 77489: Copy #testGetAuthorRelationshipMetadata for override 2021-03-05 11:29:27 +01:00
Yura Bondarenko
fea0a3a896 77228: Fix line length 2021-03-05 10:19:38 +01:00
Yura Bondarenko
990ae7750b 77228: Implement authority vocabulary fix for facet IT 2021-03-05 08:59:58 +01:00
Bruno Roemers
bfcaa94c76 77489: Update RelationshipMetadataServiceIT#testGetAuthorRelationshipMetadata 2021-03-04 18:36:12 +01:00
Bruno Roemers
f7f8121aeb 77489: Create TiltedRelationshipMetadataServiceIT and override #initPublicationAuthor 2021-03-04 18:11:48 +01:00
Bruno Roemers
46266f894c 77489: Create TiltedRelationshipRestRepositoryIT 2021-03-04 17:55:13 +01:00
Bruno Roemers
62e41a4d1a Merge branch 'main' into w2p-77489_tilted-relationships-tests 2021-03-04 17:22:42 +01:00
Raf Ponsaerts
5f6ae856cd Fixed browse tests 2021-03-04 15:28:38 +01:00
Samuel
3fe194ae09 taskid 77244 ItemMetadata caching bugfixes 2021-03-02 18:27:22 +01:00
Peter Nijs
f2527d9f21 77318: Google Scholar for entities: feedback 2021-03-02 14:53:09 +01:00
Yura Bondarenko
a7db90c13a 77228: Add IT for subject facet with authority value
Doesn't pass ~ no Solr results @ DiscoveryRestController#getFacetValues
2021-03-01 17:48:51 +01:00
Yura Bondarenko
52f17c3f12 77228: Match facet value by subject 2021-03-01 17:48:51 +01:00
Yura Bondarenko
c5916b136c 77228: Add IT for browse by subject with authority values
Doesn't pass ~ no Solr results @ BroweEntryLinkRepository#listBrowseEntries
2021-03-01 17:48:51 +01:00
Yura Bondarenko
b089b179b7 77228: BrowseEntryResourceMatcher#matchBrowseEntry with authority value 2021-03-01 17:43:33 +01:00
Yura Bondarenko
b41ebf9c60 77228: Overload withSubject: authority & confidence parameters 2021-03-01 17:42:20 +01:00
Yura Bondarenko
7186d07e2b 77228: Implement MetadataAuthorityService#clearCache 2021-03-01 17:40:43 +01:00
Hrafn Malmquist
fc26de9dc4 Merge branch 'main' into DS4574-7 2021-02-28 01:09:26 +00:00
j4bbi
215d3c0325 Get rid of Java7, upgrade DBCP2 dependency 2021-02-28 00:59:56 +00:00
Tim Donohue
7b9e3d70bb Upgrade to Solr 8.8.1 (from 8.7) 2021-02-26 12:29:52 -06:00
Tim Donohue
575994fab1 Apply prior feedback on further config cleanup 2021-02-26 10:03:32 -06:00
Tim Donohue
3588be22aa Remove obsolete/default Solr configs. Add some inline comments 2021-02-26 09:56:37 -06:00
Tim Donohue
76e5b50564 Remove old perl script 2021-02-25 16:55:59 -06:00
Tim Donohue
bd6c6446fc Fix broken test by adding a default key in Messages.properties 2021-02-25 16:55:05 -06:00
Tim Donohue
04d6c4484f Remove ununsed messages from Messages.properties 2021-02-25 16:55:05 -06:00
Tim Donohue
4ce58631c4 Remove unused JSPUI classes. Cleanup comments to remove mentions of XMLUI or JSPUI or removed configs 2021-02-25 16:55:05 -06:00
Tim Donohue
a55acc2379 Cleanup ununsed configurations 2021-02-25 16:55:04 -06:00
Tim Donohue
2292d89a6a Merge pull request #3107 from paulo-graca/dspace-issue-3099
OAI OpenAIRE4: changes to related identifiers and alternative identifiers
2021-02-25 11:55:30 -06:00
Tim Donohue
5d8285dc61 Merge pull request #3020 from tdonohue/upgrade_guava
Upgrade to latest Guava (v30) and Solr (v8) to resolve security alerts
2021-02-25 11:52:00 -06:00
Tim Donohue
4394d4bcca Ensure InputStream is closed 2021-02-25 10:36:04 -06:00
Tim Donohue
781456fadb Upgrade Jetty to avoid security warnings from Snyk. Also fixes GitHub security alert 2021-02-25 10:36:04 -06:00
Tim Donohue
e33b323135 Remove our custom Docker container for Solr. It's unreliable with Solr v8, and all the examples show to use docker-compose directly with official image. 2021-02-25 10:36:04 -06:00
Tim Donohue
90050c18fa Minor refactors based on feedback 2021-02-25 10:36:04 -06:00
Tim Donohue
891544a49b Docker bug fix. Ensure new Solr v8 data directories are kept between Docker restarts. 2021-02-25 10:36:03 -06:00
Tim Donohue
ea0d139c73 Add explicit dependency on Apache Tika to avoid UnsatisfiedDependencyException warnings from Spring Boot during startup 2021-02-25 10:36:03 -06:00
Tim Donohue
ffb17f0664 Fix/Workaround for https://issues.apache.org/jira/browse/SOLR-12798 . Use Tika directly for parsing instead of ContentStreamUpdateRequest (which results in "URI is too large >8192" errors in Solr v8) 2021-02-25 10:36:03 -06:00
Tim Donohue
ee46611419 Update solrconfig.xml files for Solr v8 (also minor alignment correction) 2021-02-25 10:36:03 -06:00
Tim Donohue
44aa1025ba Update Docker for Solr v8 2021-02-25 10:36:03 -06:00
Tim Donohue
022b79cb5e Upgrade to Solr 8.7.0. Fix dependency convergence issues. Minor fix to MockSolrServer for Solr 8 compatibility 2021-02-25 10:36:03 -06:00
Tim Donohue
25b00647b9 Workaround https://issues.apache.org/jira/browse/SOLR-12858 by ensuring EmbeddedSolrServer always uses GET instead of POST 2021-02-25 10:36:02 -06:00
Tim Donohue
7cabcbabbc Rename to RegistryUpdater so that it comes alphabetically *after* GroupServiceInitializer as Flyway runs callbacks alphabetically 2021-02-25 10:36:02 -06:00
Tim Donohue
d22a70611c Minor cleanup. Comment correction. Remove commented out code 2021-02-25 10:36:02 -06:00
Tim Donohue
635d341469 Upgrade to latest guava. Remove/replace outdated Lyncode builders & test-support which used old guava version. 2021-02-25 10:36:02 -06:00
Peter Nijs
28567c8daa 77250: Revert code style changes 2021-02-25 12:16:02 +01:00
Tim Donohue
b0b2cd9a6e Merge pull request #3136 from atmire/w2p-74236-access-condition
Submission embargo fix by removing group select
2021-02-24 16:29:32 -06:00
Tim Donohue
cb0a9fe663 Merge pull request #3144 from atmire/w2p-76191_Remove-Traditional-Basic-Workflow-from-codebase-and-database
Remove Traditional/Basic Workflow from codebase and database
2021-02-24 16:20:08 -06:00
Samuel
b779b91e54 Remove Traditional/Basic Workflow from codebase and database - restore in-between layer 2021-02-24 15:31:29 +01:00
Samuel
a752f7638e Remove Traditional/Basic Workflow from codebase and database - fix checkstyle issues 2021-02-23 21:36:35 +01:00
Samuel
8306d30341 Remove Traditional/Basic Workflow from codebase and database - add TODO comment to Curation 2021-02-23 20:34:16 +01:00
Samuel
1dc0a815f2 Remove Traditional/Basic Workflow from codebase and database - rename Workflow to XmlWorkflow 2021-02-23 20:31:27 +01:00
Ben Bosman
f5043f15c3 The relationship metadata is created
Also add checks based on plain metadata only
2021-02-23 13:19:03 +01:00
Ben Bosman
ceec8433c8 Checkstyle 2021-02-23 12:45:38 +01:00
Ben Bosman
5715d7d377 Marking metadata as updated after changing the relationship place 2021-02-23 12:18:40 +01:00
Ben Bosman
79830641e2 Marking metadata as updated after adding a metadata value 2021-02-23 12:11:37 +01:00
Peter Nijs
b6e223553a 76284: Add graphical community/collection structure 2021-02-22 17:55:12 +01:00
Raf Ponsaerts
4daa15d1fe Refactored ManageGroupFeature functionality 2021-02-22 12:41:28 +01:00
Peter Nijs
941da71713 77166: Manual master merge fixes 2021-02-22 10:09:04 +01:00
Peter Nijs
ccd1ea6c8d Merge remote-tracking branch 'community/main' into w2p-75924_Entitytypes-in-sitemaps 2021-02-22 10:08:06 +01:00
Bruno Roemers
c88f67ea1d Merge branch 'main' into w2p-74236-access-condition
Resolve merge conflict for https://github.com/DSpace/DSpace/pull/3136
2021-02-22 08:55:34 +01:00
Tim Donohue
4c78fce9d7 Merge pull request #3151 from atmire/w2p-76715_Bitstream-format-read-rights
Bitstream format retrieval for restricted files
2021-02-19 14:43:28 -06:00
Ben Bosman
b44fdd2de4 JavaDocs 2021-02-19 17:48:01 +01:00
Ben Bosman
73f22a00f7 Testing metadata field performance 2021-02-19 17:05:18 +01:00
Tim Donohue
2e7a933f51 Merge pull request #3106 from paulo-graca/dspace-issue-3097
OAI OpenAIRE: addressing issue 3097 with access rights
2021-02-19 09:37:50 -06:00
Ben Bosman
11efc35cae Testing metadata field performance 2021-02-19 13:08:10 +01:00
Ben Bosman
392d817ea9 Merge branch 'metadata-field-caching-hibernate-3' into metadata-field-caching-hibernate-3-performance-test 2021-02-19 12:31:32 +01:00
Ben Bosman
ef58d629b0 Testing metadata field performance 2021-02-19 12:30:55 +01:00
Andrea Bollini
23bf97f0c8 Merge pull request #3153 from tdonohue/fix_partial_db_migrations
Fix ability to run partial migrations (i.e. ./dspace database migrate [version]) during PR testing
2021-02-19 09:55:10 +01:00
Tim Donohue
80c3f98447 Merge pull request #2773 from the-library-code/DS-3940_SHERPA_v2_API_master
DS-3940 SHERPA v2 API (main port)
2021-02-18 13:30:21 -06:00
Tim Donohue
fab51daada Merge pull request #3003 from atmire/w2p-71502_deleting-items-with-min-relationship
Deleting items with min relationship
2021-02-18 09:51:03 -06:00
Mark H. Wood
37d7e69e7b [DS-2058] Make <mapping taskset='none'/> valid by defining empty dummy taskset. 2021-02-17 12:50:53 -05:00
Mark H. Wood
0e64959f6f [DS-2058] Enable autowiring and point to the configuration document. 2021-02-17 12:49:18 -05:00
Mark H. Wood
6856899467 [DS-2058] Satisfy checkstyle. 2021-02-17 12:45:08 -05:00
Mark H. Wood
f1c1ac5cf1 Merge branch 'main' into DS-2058-7x 2021-02-16 15:33:56 -05:00
Mark H. Wood
4a1148130b [DS-2058] Port to 7x. Formalize parser. Add tests. 2021-02-16 14:33:56 -05:00
Tim Donohue
b2a5853f80 Merge pull request #3154 from tdonohue/hal_browser_csrf_fixes
Ensure HAL Browser is checking for CSRF token changes during error responses
2021-02-16 09:18:43 -06:00
Marie Verdonck
aca41ea8cc Merge branch 'dspace-origin-master' into w2p-71502_deleting-items-with-min-relationship
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/ItemRestRepositoryIT.java
2021-02-15 21:39:02 +01:00
Raf Ponsaerts
825488071d Merge remote-tracking branch 'dspace/main' into w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST
Conflicts:
	dspace-server-webapp/src/test/java/org/dspace/app/rest/CollectionRestRepositoryIT.java
2021-02-15 15:18:46 +01:00
Paulo Graça
66cdc01349 deal with dc:identifier.* having multiple languages 2021-02-12 22:44:39 +00:00
Paulo Graça
0997b9645b comments improvement and fix dc.right processing 2021-02-12 19:49:23 +00:00
Tim Donohue
a58a1554d9 Merge pull request #3149 from 4Science/issue-3130
Deeper membership don't work due to group2groupcache be out of sync
2021-02-12 09:52:10 -06:00
Tim Donohue
9401902a14 Merge pull request #3105 from atmire/w2p-75404_self-links-contain-embeds
Self links contain embed params
2021-02-12 09:48:12 -06:00
Mark H. Wood
0a3851267f [DS-2058] Replace unwarranted assumptions about XML attribute order with named attributes 2021-02-12 10:31:38 -05:00
Mark H. Wood
a5dc6d1c34 [DS-2058] First cut at adding curation to Configurable Workflow 2021-02-12 10:31:33 -05:00
Tim Donohue
6850b8c023 Fix LGTM issue (unused variable) 2021-02-12 09:29:08 -06:00
Tim Donohue
0a54bf55cd Ensure HAL Browser is checking for CSRF token changes during error responses 2021-02-11 16:59:48 -06:00
Mark H. Wood
5cb853d92b Clean up some commentary 2021-02-11 16:42:02 -05:00
Tim Donohue
80f76b4e0a Fix ability to run partial migrations by disabling callbacks and reindex 2021-02-11 14:56:11 -06:00
Tim Donohue
7138d32eed Merge pull request #3114 from atmire/w2p-75465_change-to-embed-size
REST API changes to embed size
2021-02-11 12:57:02 -06:00
Tim Donohue
1a9df9c795 Merge pull request #3147 from tdonohue/fix_version_tag
Ensure REST API version is prepended with "DSpace"
2021-02-11 12:51:16 -06:00
Tim Donohue
1c85bed04c Merge pull request #3095 from mwoodiupui/3094
Improve IPv6 support
2021-02-11 08:44:33 -06:00
Ben Bosman
c592b6b4e4 Feedback on the PR 2021-02-11 11:15:31 +01:00
Ben Bosman
7d419b5efa Feedback on the PR 2021-02-11 11:03:39 +01:00
Andrea Bollini
bbea5d5488 #3130 fix group2groupcache issue in adding/removing subgroups via REST 2021-02-10 18:57:45 +01:00
Andrea Bollini
e310334dd4 #3130 Cleanup test and add check to proof the issue with the group2groupcache table 2021-02-10 18:56:27 +01:00
Tim Donohue
5f468770ff Merge pull request #3076 from atmire/feature-submission-forms-migration
Submission forms migration script
2021-02-10 11:19:22 -06:00
Ben Bosman
4f821ca417 Test hibernate level 1 cache 2021-02-10 15:22:33 +01:00
April Herron
06c39ad750 Implement tilted relationships to help improve performance 2021-02-10 09:20:15 -05:00
Yana De Pauw
5024f983f0 75465: Add support for multilevel embeds 2021-02-10 14:57:39 +01:00
Marie Verdonck
c03578321b PR #3076: item-submission.xml changes from #3081 in xsl transformation 2021-02-10 11:18:10 +01:00
Marie Verdonck
1e686495b2 74720: relative to absolute paths; comments & output files .migrated 2021-02-10 10:55:45 +01:00
Raf Ponsaerts
28b0f8f6cc Fixed checkstyle issues on SubmissionFormsMigration 2021-02-10 10:55:45 +01:00
Marie Verdonck
d9d68ab5e6 74720: Refactor temp file creation/deletion 2021-02-10 10:55:45 +01:00
Marie Verdonck
f3d38f7f26 74720: No more submission-forms-migrate script access via REST 2021-02-10 10:55:45 +01:00
Marie Verdonck
3ef0795ba3 74720: Create dummy DTD files for validation if not present in input dirs 2021-02-10 10:55:45 +01:00
Raf Ponsaerts
5117b63617 Minor change in order of steps in submission-process in submission-definitions 2021-02-10 10:55:45 +01:00
Marie Verdonck
0bbfc1ded5 74720: onebox => twobox in submission-forms (twobox no longer present in dspace7) 2021-02-10 10:55:45 +01:00
Marie Verdonck
f7c6bcfe9f 74720: submission-map (mapping collection-submissionProcess) from old input-forms.xml instead of item-submission.xml 2021-02-10 10:55:45 +01:00
Marie Verdonck
b0be29845d 74720: Add static steps license and upload &
add a step per form page from input-forms (static type submission-form; class DescribeStep)
2021-02-10 10:55:45 +01:00
Marie Verdonck
150c8452fd 74720: Migrate submission-process information 2021-02-10 10:55:45 +01:00
Raf Ponsaerts
ccdb4bf503 removed super from handler log calls in SubmissionFormsMigration 2021-02-10 10:55:44 +01:00
Marie Verdonck
b63643808d 74491: Feedback 2020-11-17 applied 2021-02-10 10:55:44 +01:00
Marie Verdonck
abc333bf9c 74491: Java script for transforming the xml files 2021-02-10 10:55:44 +01:00
Marie Verdonck
d239c95170 74490: item-submissions.xmml migration XSL; WIP 2021-02-10 10:55:44 +01:00
Yana De Pauw
529e8ac011 73214: Submission forms migrations #1 2021-02-10 10:55:44 +01:00
Yana De Pauw
055f68dadf 76682: Add more embed param support to self link exlusion 2021-02-10 09:04:02 +01:00
Yana De Pauw
efccc2a3f8 Merge branch 'w2p-75465_change-to-embed-size' into w2p-75404_self-links-contain-embeds 2021-02-10 08:24:05 +01:00
Mark H. Wood
c2a1287771 Restore Locale lost while merging with 'main'. #3094 2021-02-08 16:03:14 -05:00
Mark H. Wood
b00181016f Merge branch 'main' into 3094 2021-02-08 16:00:43 -05:00
Tim Donohue
d4c6bd7847 Merge pull request #3103 from tdonohue/reenable_csrf_protection
Enable Customized CSRF Protection in Spring Security for Server Webapp
2021-02-08 11:44:33 -06:00
Raf Ponsaerts
1f684b80e5 Merge branch 'w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST' of https://github.com/atmire/DSpace into w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST 2021-02-08 12:54:01 +01:00
Raf Ponsaerts
2055901867 Merge remote-tracking branch 'dspace/main' into w2p-76284_issue-927---non-site-admin-edit-collection-authorization-group-REST
Conflicts:
	dspace-api/src/main/java/org/dspace/discovery/SolrServiceResourceRestrictionPlugin.java
2021-02-08 12:53:38 +01:00
Peter Nijs
510ee70807 75924: Fixed style issues in GenerateSitemaps 2021-02-08 12:41:56 +01:00
Peter Nijs
c2bbdfcfb2 76284: Feedback 2021-02-05 17:28:37 +01:00
Peter Nijs
6fcaf1fcdd 76715: Bitstream format cannot be retrieved if you don't have read rights on the file 2021-02-05 12:50:29 +01:00
Tim Donohue
0b00229f49 Merge pull request #3146 from atmire/security-issue-discovery
[3116] Security issue in discovery
2021-02-04 15:19:33 -06:00
Tim Donohue
f39673b1cc Ensure version is prepended with "DSpace" so it can be used in UI as generator 2021-02-04 10:29:38 -06:00
Tim Donohue
7e3b1afef1 Merge pull request #2692 from atmire/DS-4440_GDPR_anonymize-statistics-feature
DS-4440 GDPR - Anonymize statistics feature
2021-02-04 10:11:35 -06:00
Tim Donohue
a1cbc3df02 Merge pull request #3142 from tdonohue/fix_journal_config
Fix bugs in default Journal Hierarchy submission configuration
2021-02-04 08:57:47 -06:00
Ben Bosman
994062b691 #3116 Security issue in discovery
Fix in discovery indexing
2021-02-04 13:57:51 +01:00
Ben Bosman
7515fb2075 #3116 Security issue in discovery
Fix in PreAuthorize (making sure it's not ignored)
2021-02-04 13:04:54 +01:00
Raf Ponsaerts
ed26f7494c Small refactor 2021-02-04 11:10:34 +01:00
Tim Donohue
ca0786a067 Merge pull request #3145 from DSpace/dependabot/maven/org.apache.ant-ant-1.10.9
Bump ant from 1.9.15 to 1.10.9
2021-02-03 14:52:27 -06:00
dependabot[bot]
d343fe7de9 Bump ant from 1.9.15 to 1.10.9
Bumps ant from 1.9.15 to 1.10.9.

Signed-off-by: dependabot[bot] <support@github.com>
2021-02-03 19:21:38 +00:00
Kevin Van de Velde
adc98563d7 Fixing issues with the latest main merge 2021-02-03 13:10:36 +01:00
Kevin Van de Velde
6e4a641ea5 Fixing issues with the latest main merge 2021-02-03 13:07:21 +01:00
Kevin Van de Velde
dbc0281771 Merge remote-tracking branch 'upstream/main' into w2p-76191_Remove-Traditional-Basic-Workflow-from-codebase-and-database 2021-02-03 13:04:46 +01:00
Tim Donohue
412794325a Fix bugs in default configuration 2021-02-02 14:06:39 -06:00
Samuel
ce196d33be DS-4440 GDPR - Anonymize statistics feature - move tests to dspace-api 2021-02-02 10:43:02 +01:00
Peter Nijs
d0aec95b28 76284: Issue 927: 401 Community or Collection Administrator editing Collection Authorization Group REST Implementation
- implement Community and Collection admin search
- implement the CollectionAdminFeature and CommunityAdminFeature Authorization feature
2021-02-02 10:27:05 +01:00
Tim Donohue
2943a78eea Merge pull request #3137 from 4Science/issue-3055-some-renaming
Issue 3055 some renaming
2021-02-01 11:43:01 -06:00
Yana De Pauw
389030a45d Add javadocs 2021-02-01 15:31:10 +01:00
benbosman
0e8cd8fa58 Merge pull request #59 from atmire/w2p-76575_IT-for-deleting-items-and-populating-virtual-md
W2p 76575 it for deleting items and populating virtual md
2021-02-01 15:03:22 +01:00
Tim Donohue
e2ce888b14 Merge pull request #3111 from mwoodiupui/3110
Fix puzzling incorrect failure to match dspace.server.url
2021-01-29 15:46:59 -06:00
Tim Donohue
d52f23860f Merge pull request #3132 from atmire/w2p-75451_improve-REST-error-messages
Improve REST Error message for specific errors
2021-01-29 15:18:03 -06:00
Andrea Bollini
d0e059f12b Rename unit test according to the name convention 2021-01-29 22:02:57 +01:00
Andrea Bollini
c938020226 Rename ITs according to the naming convention 2021-01-29 22:02:57 +01:00
Tim Donohue
3dd393e435 Merge pull request #3133 from 4Science/DS-4443_improvements
[DS-4443] delete solr record on workspaceitem deletion (updated PR)
2021-01-29 14:21:13 -06:00
Mark H. Wood
75aa37dfb6 Move exception case to a separate test method. #3094
This now properly shows that querying an IPv6 address does not raise an exception.
2021-01-29 13:54:37 -05:00
Marie Verdonck
e32fd1fc4c 76575: ITs for deleting items and populating virtual metadata 2021-01-29 17:23:49 +01:00
Tim Donohue
70253bc1bf Resolve feedback - Ensure DSpaceAccessDeniedHandler passes exception response handling to DSpaceApiExceptionControllerAdvice dynamically. 2021-01-29 10:02:21 -06:00
Andrea Bollini
f349e7f4ce Attempt to mitigate the issue 3055 2021-01-29 16:50:38 +01:00
Mark H. Wood
945ee9af76 Satisfy checkstyle. #3094 2021-01-29 10:37:14 -05:00
Marie Verdonck
be48c56cae Merge branch 'dspace-origin-master' into w2p-76575_IT-for-deleting-items-and-populating-virtual-md
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/RelationshipServiceImpl.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/RelationshipRestRepositoryIT.java
2021-01-29 11:09:18 +01:00
Mark H. Wood
654412eb88 Add tests. #3094 2021-01-28 16:58:46 -05:00
Mark H. Wood
8d6318d3e9 Correct misleading method javadoc. #3110 2021-01-28 15:38:16 -05:00
Mark H. Wood
f9a527fd5c Address reviews. Fix reversed parameters. Compare path elements, not whole paths. #3110 2021-01-28 15:25:08 -05:00
Tim Donohue
8b3fc1f95f Merge pull request #3131 from atmire/entities-performance-improvement-relationshipservice
Entities performance improvement in RelationshipServiceImpl
2021-01-28 14:17:06 -06:00
Tim Donohue
a1639d5982 Merge pull request #3115 from tdonohue/author_as_onebox
Switch Author field to "onebox" to allow first/last name in single entry box.
2021-01-28 14:04:30 -06:00
Tim Donohue
ab4eec8119 Merge pull request #3098 from atmire/w2p-75361_Enforce-facet-filter-operator-is-valid-value
Enforce that facet "filter-operator" is a valid value
2021-01-28 14:02:19 -06:00
Ben Bosman
a58905d8ed Test metadata value cache 2021-01-28 15:10:10 +01:00
Ben Bosman
5524021089 Test metadata value cache 2021-01-28 14:41:09 +01:00
Ben Bosman
ad2bf1f66a Note that this was never implemented 2021-01-28 09:52:51 +01:00
Bruno Roemers
2cb50b7f42 74236: Update ITs 2021-01-27 17:12:32 +01:00
Bruno Roemers
b64711253a 74236: Remove obsolete bean and IT test 2021-01-27 16:58:45 +01:00
Bruno Roemers
2109a5878d 74236: BUGFIX: StartDateLimit and EndDateLimit are both maximum dates
They do not represent a range but are independent of each other.

Also removed obsolete field selectGroupName.
2021-01-27 16:58:23 +01:00
Andrea Bollini
f5aac1eefa Fix zombie workspaceitem in the solr index, improve ITs to cover all the scenarios 2021-01-27 16:43:44 +01:00
Raf Ponsaerts
a4d114670f Small refactor to comment and made a method private 2021-01-27 12:49:06 +01:00
Marie Verdonck
8fcec01d5d 76244: Feedback PR #3093 - Exceptions to match RestContract 2021-01-27 11:01:32 +01:00
Samuel
16ae96b4c3 taskid 76191 Remove Traditional/Basic Workflow from codebase and database 2021-01-27 06:41:16 +01:00
Andrea Bollini
0978aa6ca0 Merge remote-tracking branch 'atmire/DS-4443_delete-solr-record-on-workspaceitem-deletion' into DS-4443_improvements 2021-01-26 23:19:16 +01:00
Ben Bosman
fa90057203 Entities performance improvement in RelationshipServiceImpl
If there's no max on the relationships, don't bother trying to verify whether the max would be exceeded
Don't get virtual metadata for retrieving the relationship type
2021-01-26 15:04:15 +01:00
Bruno Roemers
8f7a67e1a5 74236: WIP: Write tests 2021-01-25 23:24:56 +01:00
Bruno Roemers
5f68a227da 74236: Implement boundary checks 2021-01-25 21:35:01 +01:00
Bruno Roemers
4a2152c482 76179: Move DateMathParser to dspace-api module
DateMathParser will be needed in AccessConditionOption, so this
change is needed to avoid a circular dependency
(dspace-api -> dspace-server-webapp).
2021-01-25 16:22:32 +01:00
Kim Shepherd
1d9b9c6c41 [DS-3940] Correct typo in ExternalSourcesRestControllerIT 2021-01-22 19:02:55 +13:00
Kim Shepherd
aa16ef7179 [DS-3940] Update ExternalSourcesRestControllerIT to count for new external sources 2021-01-22 16:57:09 +13:00
Kim Shepherd
8fc804a836 [DS-3940] Remove unused import in SHERPAv2JournalDataProvider 2021-01-22 16:10:16 +13:00
Kim Shepherd
fdabd643f0 [DS-3940] Additional javadoc, integration and unit tests, service refactor 2021-01-22 15:44:05 +13:00
Kim Shepherd
7b01dcf822 [DS-3940](main) Remove version label, getter, setter from PermittedVersion 2021-01-22 15:39:54 +13:00
Kim Shepherd
0f25bd96da [DS-3940](main) Log response body in HTTP errors, err msg in submit service 2021-01-22 15:39:54 +13:00
Kim Shepherd
038500b772 [DS-3940](main) Remove versionLabel from permittedVersion - just store key 2021-01-22 15:39:54 +13:00
Kim Shepherd
50612a8334 [DS-3940](main) Rethrow IOExceptions that are caught within main try block 2021-01-22 15:39:54 +13:00
Kim Shepherd
6bed089459 [DS-3940](main) Sanitise query string (bugfix for bad method name in Pub) 2021-01-22 15:39:54 +13:00
Kim Shepherd
b53d14eeae [DS-3940](main) Sanitise query strings for SHERPA v2 API calls 2021-01-22 15:39:54 +13:00
Kim Shepherd
43d7c20fd2 [DS-3940](main) Shift spring config to DSpace config service for providers 2021-01-22 15:39:54 +13:00
Kim Shepherd
a8bdc5f09a [DS-3940](main) Add basic javadoc for new SHERPA data classes 2021-01-22 15:39:54 +13:00
Kim Shepherd
1b40dff96a [DS-3940](main) Replace '200' with HttpStatus.SC_OK in data providers 2021-01-22 15:39:54 +13:00
Kim Shepherd
e2f38fb257 [DS-3940](master) Fixes for Checkstyle failures in unit tests
(imports, whitespace after catch)
2021-01-22 15:39:54 +13:00
Kim Shepherd
7fffe96a6a [DS-3940](master) Add license headers to unit test classes 2021-01-22 15:39:54 +13:00
Kim Shepherd
54ec03d0a1 [DS-3940](master) Ensure sherpa.romeo.apikey placeholder always exists
Spring bean configuration (external-sources.xml) requires the placeholder,
even if it is null, so this change reverts the commented out api key
introduced with other v2 refactor work
2021-01-22 15:39:54 +13:00
Kim Shepherd
0b10f1971b [DS-3940](master) Better handling of empty / null results in providers 2021-01-22 15:39:54 +13:00
Kim Shepherd
c2b2545f88 [DS-3940](master) Removal of legacy v1 SHERPA classes and data providers 2021-01-22 15:39:54 +13:00
Kim Shepherd
d14699b0da [DS-3940](master) Configuration changes for new API key, URL, external svcs 2021-01-22 15:38:30 +13:00
Kim Shepherd
6abb1d96f7 [DS-3940](master) Unit tests for SHERPAResponse, SHERPAPublisherResponse 2021-01-22 15:38:30 +13:00
Kim Shepherd
dcca10c91a [DS-3940](master) Refactor external providers for journals, publishers 2021-01-22 15:38:30 +13:00
Kim Shepherd
dd10104661 [DS-3940](master) Port base SHERPA v2 changes from 6.x version 2021-01-22 15:38:30 +13:00
Tim Donohue
12ffc78452 Merge pull request #3117 from atmire/w2p-76002_change-default-discovery-config
Correct use of Default Discovery configuration
2021-01-21 11:50:50 -06:00
Tim Donohue
b0a5b55ca1 Switch author field to onebox. Update DTD to allow regex in relation-field. Other minor changes 2021-01-21 11:41:55 -06:00
Bruno Roemers
890315d312 75451: Make user exposed error messages translatable 2021-01-21 15:16:40 +01:00
Marie Verdonck
9ffef90ced 76244: Feedback PR #3093 - Exceptions 2021-01-20 16:25:14 +01:00
Tim Donohue
5c2deae4d9 Merge pull request #3004 from atmire/entities-update-item-metadata-outside-rest
Entities update item metadata outside rest
2021-01-20 08:44:27 -06:00
Tim Donohue
5a3f68e87c Merge pull request #3109 from atmire/w2p-75240_Issue-943-External-sources-limited-based-on-metadata-field
Limit externalSources per metadata field
2021-01-20 08:42:31 -06:00
Raf Ponsaerts
9804110b04 Removed testing config remnant 2021-01-19 14:41:00 +01:00
Ben Bosman
2dee4bd87d w2p-74236 Disable group selection for bitstream resource policies during submission 2021-01-19 09:07:00 +01:00
Ben Bosman
ca2c537d01 w2p-74236 Disable group selection for bitstream resource policies during submission 2021-01-18 17:00:16 +01:00
Peter Nijs
a56c442b1f 75924: Sitemaps performance and lowercase entityTypes 2021-01-18 16:18:48 +01:00
Mykhaylo
cfa8b0348b added tests 2021-01-18 15:14:07 +01:00
Ben Bosman
567a9f0567 Verify the relationship is deleted
Status 404 is needed for a relationship which doesn't exist
2021-01-15 13:24:25 +01:00
Ben Bosman
564140b0c8 Merge remote-tracking branch 'community/main' into w2p-71502_deleting-items-with-min-relationship 2021-01-15 11:39:07 +01:00
Tim Donohue
7c8de66954 Merge pull request #3066 from atmire/74271-External-sources-query-param-issue
Removal of automatically added 'query' parameter for entries subpath
2021-01-14 08:43:44 -06:00
Kevin Van de Velde
31fc4cb023 Fixing the tests & the style issues 2021-01-14 13:35:05 +01:00
Bruno Roemers
ff5d1f6808 76002: Replace "site" with "default" in DiscoveryConfigurationService 2021-01-14 11:43:30 +01:00
Yana De Pauw
a9fe4ae1d1 75409: Delete solr record on workspaceitem deletion: Test feedback V2 2021-01-13 15:24:32 +01:00
Mark H. Wood
60a453a2c1 Merge branch '3110' of github.com:mwoodiupui/DSpace into 3110 2021-01-12 16:49:11 -05:00
Mark H. Wood
0b1789ad09 Extract paths from URLs to arrays before trimming leading elements. #3110
Let exception report its constructor arguments in its message.
More comment cleanup.
2021-01-12 16:40:56 -05:00
Marie Verdonck
b77b9949ee 75922: Feedback PR #3004 2021-01-12 17:22:18 +01:00
Raf Ponsaerts
d79b27f3a2 Added docs 2021-01-12 13:30:08 +01:00
Raf Ponsaerts
8ee63b4afc Small refactor 2021-01-12 13:27:41 +01:00
Tim Donohue
909d8caeee Merge pull request #3112 from kshepherd/DS-4452_bulkedit_ignore_v7
[DS-4452] Porting correct instantiation of default ignore fields (CSV…
2021-01-11 09:16:02 -06:00
Kim Shepherd
caee3862d9 [DS-4452] Porting correct instantiation of default ignore fields (CSV) from pr/2661 2021-01-11 13:06:53 +13:00
Tim Donohue
6747bbea92 Bug Fix: CSRF token should be reset after InvalidCsrfTokenException to allow for resyncing between client & server 2021-01-08 15:56:54 -06:00
Mark H. Wood
a5a84e1758 Merge branch 'main' into 3110 2021-01-08 15:52:21 -05:00
Mark H. Wood
751d7d5fdb Compare URLs in a way that recognizes URL structure, not as simple strings. #3110
Also improve readability of some commentary.
2021-01-08 15:37:36 -05:00
Bruno Roemers
e31491e00d 75451: TEST: verify last eperson in workflow group cannot be deleted 2021-01-08 12:57:37 +01:00
Bruno Roemers
1a1557079d 75451: TEST: verify EPersonNameNotProvidedException error message in response 2021-01-08 11:10:28 +01:00
Bruno Roemers
856b2c393b 75451: Update GroupRestRepositoryIT 2021-01-08 11:10:20 +01:00
Yana De Pauw
8d78b9ca09 75465: REST API Changes to embed size 2021-01-08 09:17:24 +01:00
Bruno Roemers
ea613aa72f 75451: Make error messages public
The messages can then be used in the integration tests,
instead of hardcoding the expected response.
2021-01-08 08:46:17 +01:00
Paulo Graça
1db63c9262 fix resolveFieldType for identifier element by forcing the first element 2021-01-07 15:33:12 +00:00
benbosman
54a844e033 Merge pull request #52 from atmire/w2p-75473-Test-to-verify-implicit-virtual-metadata-is-updated
W2p 75473 test to verify implicit virtual metadata is updated
2021-01-07 13:49:03 +01:00
Paulo Graça
43893124e5 also add support for oaire:file @accessRightsURI 2021-01-07 10:41:43 +00:00
Bruno Roemers
e5bc76af04 75451: Add JavaDoc and make error message private 2021-01-07 09:57:27 +01:00
Tim Donohue
b35a3f71be Update HAL browser to use DSPACE-XSRF-TOKEN header and store token in custom MyHalBrowserCsrfToken Cookie. Minor comment fixes to TokenRepo 2021-01-06 10:24:14 -06:00
Tim Donohue
acaa1dbc64 Require POST for logout. Update CSRFTokenRepository to no longer allow server token to be read by Javascript 2021-01-06 10:24:14 -06:00
Tim Donohue
126775c665 Update dspace-shibboleth docker settings to no longer overwrite Access-Control-Expose-Headers. Instead we'll use the ones from Tomcat. 2021-01-06 10:24:13 -06:00
Tim Donohue
d084358e70 Customize CsrfTokenRepository and CsrfAuthenticationStrategy to support cross domain CSRF protection. 2021-01-06 10:24:13 -06:00
Tim Donohue
30451676ab Ensure allowed origins never end in a slash. Otherwise, you can get CORS errors even if the URL is correct. 2021-01-06 10:24:12 -06:00
Tim Donohue
f6c095f296 Add comments to dspace.cfg describing Spring Boot proxy settings which may be applicable to sites using a proxy. I found this useful when testing SameSite cookies behind a HTTPS proxy. 2021-01-06 10:24:11 -06:00
Tim Donohue
d15e603d43 Add (custom) CSRF support to HAL Browser 2021-01-06 10:24:11 -06:00
Tim Donohue
901cf6e285 Fix possible XSS issue in Hal Browser. See https://github.com/mikekelly/hal-browser/pull/97 2021-01-06 10:24:11 -06:00
Tim Donohue
b6bf9a2fb3 Add in missing Builders to enable automated cleanup for these builders 2021-01-06 10:24:10 -06:00
Tim Donohue
55c47194f4 Cleanup WebSecurityConfiguration via reorg, adding comments & removing duplicative or unneeded default configs. 2021-01-06 10:24:10 -06:00
Tim Donohue
de58a6ca03 Reenable CSRF projection with recommended Angular settings 2021-01-06 10:24:10 -06:00
Marie Verdonck
4cab1633e8 75473: Test to verify implicit virtual metadata is updated +
fix for entity type match
2021-01-06 15:02:50 +01:00
Paulo Graça
4b13a11376 support for related identifiers and alternative identifiers 2021-01-06 13:10:53 +00:00
Bruno Roemers
679f2d64ed 75451: Add EPersonNameNotProvidedException and GroupNameNotProvidedException 2021-01-06 10:39:17 +01:00
Bruno Roemers
8cd6ddf0d8 75451: BUGFIX: Add missing license header 2021-01-06 08:56:25 +01:00
Bruno Roemers
c878293b99 75451: Show custom error message when removing last user from workflow group 2021-01-05 14:48:36 +01:00
Peter Nijs
1642a5598b 75469: entityType property in ItemRest is read only 2021-01-05 14:43:32 +01:00
Paulo Graça
42a6c2ae79 addressing issue 3097 2021-01-04 15:11:14 +00:00
Yana De Pauw
01bf6caf1e 75404: [Issue 3062] Self links contain embed params 2021-01-04 11:33:46 +01:00
Peter Nijs
a0a7226a43 75470: The sitemaps use a different URI dependent on the entity type 2020-12-30 13:52:39 +01:00
Peter Nijs
088bcb64ce 75469: The REST API should return the entitytype property 2020-12-29 13:26:19 +01:00
Ben Bosman
eb47a84e01 Docs indirect relationship discovery updates 2020-12-24 10:33:45 +01:00
Raf Ponsaerts
0927a3c6ba removed unused import 2020-12-23 15:10:29 +01:00
Kristof De Langhe
74d1561357 75240: ExternalSource for collection submit 2020-12-21 14:33:39 +01:00
Raf Ponsaerts
be5e2a8479 update config 2020-12-21 14:30:22 +01:00
Raf Ponsaerts
c2527e4909 Added config for a collection submit 2020-12-21 14:30:14 +01:00
Yana De Pauw
9d487e36c1 Merge remote-tracking branch 'upstream/main' into DS-4443_delete-solr-record-on-workspaceitem-deletion 2020-12-21 10:46:10 +01:00
Tim Donohue
250c87dc16 Merge pull request #3091 from tdonohue/shib_via_docker
Create Shibboleth Docker Scripts using samltest.id for easier development
2020-12-18 16:02:54 -06:00
Tim Donohue
4ecfa4454a Merge pull request #3084 from atmire/w2p-75135_ClassCastException-fix
Discovery event consumer throwing ClassCastException on WorkspaceItem creation fix
2020-12-17 10:39:42 -06:00
Tim Donohue
d9b5d4ed1f Merge pull request #3081 from atmire/w2p-74939_2786-fix-item-submission-xml-DTD
item-submission refactor to have different step xml tags
2020-12-17 08:52:31 -06:00
Ben Bosman
7b346e7584 Bugfix indirect relationship discovery updates 2020-12-17 15:46:38 +01:00
Ben Bosman
c4d4b18150 Bugfix indirect relationship discovery updates 2020-12-17 15:04:12 +01:00
Ben Bosman
b0efee2a49 Bugfix indirect relationship discovery updates 2020-12-17 14:44:23 +01:00
Ben Bosman
fbfc352768 Bugfix indirect relationship discovery updates 2020-12-17 13:24:12 +01:00
Ben Bosman
47888e7975 Bugfix indirect relationship discovery updates 2020-12-17 13:06:21 +01:00
Marie Verdonck
11ad719730 75361: Enforce that facet "filter-operator" is a valid value + IT 2020-12-17 12:45:09 +01:00
Ben Bosman
71cfab142c Bugfix indirect relationship discovery updates 2020-12-17 12:33:55 +01:00
Ben Bosman
ea24d6168c Bugfix indirect relationship discovery updates 2020-12-17 12:23:00 +01:00
Ben Bosman
1eaf75e1bd Merge remote-tracking branch 'community/main' into entities-update-item-metadata-outside-rest-v2 2020-12-17 12:05:27 +01:00
Ben Bosman
97feeecd95 Bugfix indirect relationship discovery updates 2020-12-17 11:41:02 +01:00
Ben Bosman
098b273a85 Bugfix indirect relationship discovery updates 2020-12-17 11:24:22 +01:00
Yana De Pauw
8cd404b6a7 75323: Delete solr record on workspaceitem deletion: Test feedback 2020-12-17 10:46:47 +01:00
Ben Bosman
e3b15bfa92 Bugfix indirect relationship discovery updates 2020-12-16 14:36:28 +01:00
Kristof De Langhe
0b06620210 75240: External sources for realtion-fields in submission 2020-12-16 11:46:55 +01:00
Mark H. Wood
dcd9d2e9a5 Work-around: treat IPv6 address as non-match, not format error. #3094
Also improve documentation.
This class should be reworked to properly support IPv6.
2020-12-15 13:50:11 -05:00
Mark H. Wood
12376df5e3 Better support IPv6 by using standard JRE lookup methods. #3094
Also avoid NPE when there is no current user.
2020-12-15 13:46:23 -05:00
Mykhaylo
3b5130c5a4 added new tests and fixed old 2020-12-15 11:39:39 +01:00
Mykhaylo
fd44faa3fc Implement community feedbacks 2020-12-15 11:37:18 +01:00
Tim Donohue
65be3a5eb6 Add instructions for using dspace-angular with Shibboleth as well 2020-12-14 11:27:11 -06:00
Tim Donohue
81ae880009 Add missing license headers & ignore .conf for license header check 2020-12-14 11:27:11 -06:00
Tim Donohue
33b7f064e1 Enhance docs and minor config corrections 2020-12-14 11:27:11 -06:00
Tim Donohue
4ee7caa168 Add attribute-map.xml for samltest.id and write more detailed instructions 2020-12-14 11:27:11 -06:00
Tim Donohue
29bece98db Update to allow Apache/Shibboleth Server Name to be passed via env variable 2020-12-14 11:27:11 -06:00
Tim Donohue
f91a48c1f6 Add AJP connector to both Apache and Tomcat. Add new docker compose for shib 2020-12-14 11:27:11 -06:00
Tim Donohue
600114536f Add Apache VHost with Shib settings 2020-12-14 11:27:10 -06:00
Tim Donohue
e9cf8697df Initial framework for dspace-shibboleth docker container 2020-12-14 11:27:10 -06:00
Tim Donohue
c1e97188f9 Merge pull request #3079 from atmire/3078-EntityTypeLabelRestController-GetByLabelImprove
3078 Change EntityTypeLabelRestController get by label to return REST…
2020-12-11 13:56:28 -06:00
Tim Donohue
ab39c6482f Merge pull request #3068 from atmire/74329-Internal-server-errors-for-external-sources
Fixing internal server errors for external sources
2020-12-11 12:48:44 -06:00
Tim Donohue
8cb504f88b Merge pull request #3086 from DSpace/paulo-graca-iso-openaire-bugfix
Addressing issue #3074
2020-12-10 16:39:54 -06:00
Paulo Graça
b00e472e38 Addressing issue #3074 2020-12-10 15:49:05 +00:00
Samuel
b8b6aa0f68 DS-4440 GDPR - Anonymize statistics feature - feedback 2020-12-10 14:12:53 +01:00
Samuel
6b84d20714 DS-4440 GDPR - Anonymize statistics feature - test feedback 2020-12-10 14:12:53 +01:00
Samuel
af32b8b56d DS-4440 GDPR - Anonymize statistics feature - fix test 2020-12-10 14:12:52 +01:00
Samuel
feb6ba6d18 DS-4440 GDPR - Anonymize statistics feature - remove shard support 2020-12-10 14:12:52 +01:00
Samuel
c287062090 DS-4440 GDPR - Anonymize statistics feature - add test 2020-12-10 14:12:52 +01:00
Samuel
b581d473ff Add SolrStatisticsCore and MockSolrStatisticsCore beans 2020-12-10 14:12:52 +01:00
Samuel
ebcd1fc6cf DS-4440 GDPR - Anonymize statistics feature - add typedocs 2020-12-10 14:12:24 +01:00
Samuel
fd0051091f DS-4440 GDPR - Anonymize statistics feature - fix checkstyle issue 2020-12-10 14:12:24 +01:00
Samuel
1f73d136f2 DS-4440 GDPR - Anonymize statistics feature - feedback: default configuration 2020-12-10 14:12:24 +01:00
Samuel
5e56e82656 DS-4440 GDPR - Anonymize statistics feature - feedback: default configuration & spelling tris 2020-12-10 14:12:24 +01:00
Samuel
b80b18466d DS-4440 GDPR - Anonymize statistics feature - feedback: default configuration & spelling bis 2020-12-10 14:12:24 +01:00
Samuel
d71472fcc3 DS-4440 GDPR - Anonymize statistics feature - feedback: default configuration & spelling 2020-12-10 14:12:24 +01:00
Samuel
10f38d3fe5 DS-4440 GDPR - Anonymize statistics feature - feedback 2020-12-10 14:12:24 +01:00
Samuel
810b9c3bbc DS-4440 GDPR - Anonymize statistics feature 2020-12-10 14:12:24 +01:00
Tim Donohue
a5fba06861 Merge pull request #3085 from tdonohue/fix_oai_bean_issues
Fix issues with OAI accidentally loading the wrong ConfigurationService
2020-12-09 16:16:32 -06:00
Tim Donohue
81ab838543 Fix issues with OAI accidentally loading the wrong ConfigurationService using Autowired 2020-12-09 15:48:43 -06:00
Tim Donohue
b3083a0e02 Merge pull request #3083 from tdonohue/fix_clean_index_bug
Fix bug in cleanIndex() where not all Solr fields were returned.
2020-12-08 16:49:29 -06:00
Tim Donohue
6bf55ec9ae Fix bug in cleanIndex where not all Solr fields were returned. Make countQuery separate 2020-12-08 16:06:50 -06:00
Kristof De Langhe
83f1daa735 75135: ClassCastException fix 2020-12-08 16:57:23 +01:00
Yana De Pauw
148af699f1 Merge remote-tracking branch 'upstream/main' into 74329-Internal-server-errors-for-external-sources 2020-12-08 14:29:22 +01:00
Mark H. Wood
c2c08b3109 Restore thread-safety to see if it is needed. #3061 2020-12-08 08:07:54 -05:00
Andrew Wood
7d1e86c693 3078 Change EntityTypeLabelRestController get by label to return REST resource 2020-12-07 16:28:09 -05:00
Mark H. Wood
ac29b3ec50 Merge branch 'main' into 3061 2020-12-07 10:50:58 -05:00
Tim Donohue
6e5605453e Merge pull request #2957 from mwoodiupui/#2956
Address many deprecation warnings
2020-12-07 08:54:55 -06:00
Raf Ponsaerts
487fc1f499 Used StringUtils instead of equals 2020-12-07 13:42:51 +01:00
Peter Nijs
efbc0c63c1 74939 2786: fix item-submission.xml DTD 2020-12-07 09:50:11 +01:00
Mykhaylo
87e454a815 Implement community feedbacks 2020-12-06 12:21:04 +01:00
Mykhaylo
40ec8d7076 changed type, from Integer to int 2020-12-06 12:17:26 +01:00
Mykhaylo
c8f5ca2789 refactored test, removing the double check 2020-12-06 12:17:03 +01:00
Mykhaylo
d9299e0039 added missing test 2020-12-06 12:16:38 +01:00
Mykhaylo
10ac8c91cb fixed search method of ClaimedTask endpoint 2020-12-06 12:16:20 +01:00
Mykhaylo
da9efdff6c fixed search method of Pooltask endpoint 2020-12-06 12:15:32 +01:00
Mykhaylo
f6e0712c49 added ITs to prove the functionality of search methods 2020-12-06 12:15:05 +01:00
Mykhaylo
170ea73144 fix failed test 2020-12-06 12:14:33 +01:00
Mykhaylo
86a6819dd8 fixed tests 2020-12-06 12:12:55 +01:00
Mykhaylo
ff436491fb implemented new methods as createAndReturn for claimedTask and search methods for ClaimedTask and PoolTask 2020-12-06 12:11:09 +01:00
Andrea Bollini
755f0732ae Merge pull request #3058 from tdonohue/site_initializer_bug
Fix obvious bug in SiteServiceInitializer
2020-12-04 22:45:12 +01:00
Tim Donohue
1f551dda36 Merge pull request #2746 from atmire/circular-entities
Entities related to Entities of the same type
2020-12-04 11:36:41 -06:00
Marie Verdonck
d70e121e93 74947: Adjusting HandleDAOImplTest suffixes since this fails in CI tests:
because of an existing Collection with the same handle already existing in test DB
(problem does not occur running all tests locally)
2020-12-04 13:21:21 +01:00
Marie Verdonck
c47bd37be3 74947: Missing cleanup after post relationship creation 2020-12-04 11:13:12 +01:00
Marie Verdonck
aa09fb1074 Merge branch 'master' into circular-entities 2020-12-04 10:23:30 +01:00
Andrea Bollini
0b8675202a Merge pull request #3067 from atmire/w2p-74727_Nullpointer-workflow-item-after-submitter-delete
NullPointerException occurs when accessing WorkflowItem after deleting the Submitter
2020-12-03 17:13:57 +01:00
Mark H. Wood
6c22807619 Merge branch 'main' into #2956 2020-12-02 08:30:47 -05:00
Tim Donohue
f9258e5f20 Merge pull request #3071 from atmire/w2p-74599_Remove-LCNameDataProvider
Remove LCNameDataProvider and config from DSpace 7 REST API
2020-12-01 16:26:48 -06:00
Tim Donohue
fa68780349 Fix obvious bug in SiteServiceInitializer 2020-12-01 15:56:02 -06:00
Mark H. Wood
bf4f5c5b5d Merge remote-tracking branch 'upstream/main' into #2956 2020-12-01 16:25:24 -05:00
Mark H. Wood
33907082e2 Address one more review comment. New unit test class to test it. 2020-12-01 16:19:25 -05:00
Tim Donohue
0c5e68c5e3 Merge pull request #3034 from 4Science/CSTPER-233
Community admin should also be considered a Collection admin
2020-12-01 14:18:03 -06:00
Tim Donohue
adff448a66 Merge pull request #3002 from atmire/w2p-72348_Support-itemService-getMetadata-with-virtual-md
Support itemService.getMetadata with virtual md field
2020-12-01 12:56:17 -06:00
Mark H. Wood
83bf65a407 Satisfy checkstyle. #2956 2020-11-30 19:50:13 -05:00
Mark H. Wood
8a38b7d51c Address review comments. #2956 2020-11-30 17:26:50 -05:00
Mark H. Wood
3e16c7ed9e Merge remote-tracking branch 'upstream/main' into #2956 2020-11-30 17:24:48 -05:00
Mark H. Wood
a036b99f1c Catch correct error for replaced class, to fix test errors. Satisfy checkstyle. #3061 2020-11-30 16:21:01 -05:00
Tim Donohue
e367e76958 Merge pull request #3073 from tdonohue/fix_dependency_issues
Fix dependency convergence issues (for javassist) on main branch
2020-11-30 13:30:04 -06:00
Tim Donohue
7ce144156e Fix dependency convergence issues & fix alignment (convert tabs to spaces) 2020-11-30 12:46:33 -06:00
Tim Donohue
e7a2cbc2c9 Merge pull request #2780 from 4Science/D4CRIS-952-orcidV3
Upgrade to the ORCID v3 API
2020-11-30 11:10:08 -06:00
Tim Donohue
1e979dc44b Merge pull request #3072 from DSpace/tdonohue-correct_build
Update build.yml to not limit by branch
2020-11-30 10:15:45 -06:00
Tim Donohue
9f8d848bf2 Update build.yml to not limit by branch 2020-11-30 09:45:40 -06:00
Raf Ponsaerts
7ce7e0a52d cleaned up the lcname.url property 2020-11-30 14:39:35 +01:00
Luca Giamminonni
79ee010a7a Added tests cleanup 2020-11-26 16:36:36 +01:00
Kristof De Langhe
bd765db12c 74599: Remove LCNameDataProvider 2020-11-26 11:35:05 +01:00
Ben Bosman
d1d7ef4bb9 Merge remote-tracking branch 'community/main' into w2p-74727_Nullpointer-workflow-item-after-submitter-delete 2020-11-26 10:03:11 +01:00
Tim Donohue
a77f908949 Update build status badge & link to builds 2020-11-25 17:04:49 -06:00
Mark H. Wood
ce4ca33346 Merge branch 'main' of github.com:mwoodiupui/DSpace into 3061 2020-11-25 16:55:08 -05:00
Tim Donohue
0e7daab59c Merge pull request #3060 from tdonohue/github_ci
Add CI to GitHub via Actions (based on Travis CI config)
2020-11-25 10:18:29 -06:00
Tim Donohue
463c473c2b Rename job to "tests". Space out steps for easier readability 2020-11-25 09:16:11 -06:00
Tim Donohue
c7d8a9b259 Revert to checkout@v1 per https://community.codecov.io/t/codecov-status-stuck-at-waiting-for-status-to-be-reported-on-github/341/40 2020-11-25 07:54:41 -06:00
Mark H. Wood
f6112babc3 More errorprone warnings. #3061 2020-11-24 20:22:06 -05:00
Tim Donohue
088c77bd1f Switch to using codecov bash script (more stable) 2020-11-24 17:06:43 -06:00
Tim Donohue
d58a69cb3f Delete Travis CI configuration 2020-11-24 13:39:56 -06:00
Tim Donohue
ac73d148f9 Rename ci.yml to build.yml. Tweak Codecov configs to wait for 2 builds to complete before sending back coverage notifications. 2020-11-24 13:39:56 -06:00
Tim Donohue
97a14fb5a0 Send coverage reports to Codecov. Move comments above each step. 2020-11-24 13:39:56 -06:00
Tim Donohue
fcb15583d9 Add CI to GitHub 2020-11-24 13:39:55 -06:00
Marie Verdonck
5654dc3668 Rename after refactor RelationshipMetadataServiceTest => RelationshipMetadataServiceIT since it now inherits from AbstractIT class 2020-11-24 19:15:25 +01:00
Mark H. Wood
ea15ca58fe Address review comments. #2956 2020-11-24 11:58:10 -05:00
Mark H. Wood
51f9e78fd2 Merge remote-tracking branch 'upstream/main' into #2956 2020-11-24 11:56:18 -05:00
Mark H. Wood
65f04fcec9 First batch of errorprone fixes. #3061 2020-11-24 10:55:08 -05:00
Yana De Pauw
e54928f512 74727: NullPointerException occurs when accessing WorkflowItem after deleting the Submitter 2020-11-24 14:24:57 +01:00
Andrea Bollini
a5faac1d61 Merge pull request #3048 from tdonohue/disable_stacktrace
Disable stacktrace in error responses by default. Document how to enable for development
2020-11-23 18:55:42 +01:00
Tim Donohue
e5d587428a Merge pull request #3018 from tdonohue/update_oai_bootstrap
Upgrade OAI-PMH to Bootstrap 4 (via WebJars)
2020-11-23 11:50:19 -06:00
Andrea Bollini
2a6834b6ab Merge pull request #3029 from tdonohue/dependency_cleanup
Cleanup unused POM dependencies & minor security updates
2020-11-23 17:21:26 +01:00
Tim Donohue
6b7b5ad8d8 Merge pull request #3046 from 4Science/CSTPER-221
Metadata identifier for Communities and Collections
2020-11-23 09:21:24 -06:00
Alessandro Martelli
639b63635b [CSTPER-221] Script Flyway to populate handle metadata
Sql placeholders replacement.
2020-11-23 09:52:59 +01:00
Tim Donohue
d166d97f7c Merge pull request #3009 from atmire/w2p-72494_export-script-output-travis-test
Refactor/remove custom MultipartFileSender to use Spring Boot Range requests
2020-11-20 15:10:04 -06:00
Tim Donohue
7f323265be Merge pull request #3041 from atmire/w2p-74274_Issue-2988_Cannot-reset-pw-eperson-created-in-admin-ui
Issue 2988: EPerson Password Replacement/addition with ADD Patch Operation instead of REPLACE
2020-11-20 14:31:06 -06:00
Tim Donohue
8eeafcf866 Merge pull request #3050 from Micheleboychuk/CST-3543
Fix pagination issue in a couple of search endpoints
2020-11-20 12:31:13 -06:00
Marie Verdonck
924b178dcf 74274: Refactor check success/failed authentication 2020-11-20 17:00:45 +01:00
Marie Verdonck
8e2e564b6d 74685: Refactor RelationshipMetadataServiceTest to use Builders 2020-11-20 14:52:02 +01:00
Tim Donohue
1c86aef51a Switch patch checks to informational only
Copied over from https://github.com/DSpace/dspace-angular/pull/953
2020-11-19 16:26:25 -06:00
Andrea Bollini
dfc5723723 Merge pull request #3051 from atmire/issue-3049_root-endpoint-self-link
Added self link to root endpoint
2020-11-19 18:17:41 +01:00
Tim Donohue
4b49095ff9 Merge pull request #3036 from atmire/w2p-71780_support-csv-import-person-schema
support CSV import to schema "person"
2020-11-19 08:50:16 -06:00
Yana De Pauw
c4ed63c7a4 Fix checkstyle issue 2020-11-19 15:39:08 +01:00
Yana De Pauw
a94b2e0f3b 74329: Add max starting index to ORCID 2020-11-19 15:23:11 +01:00
Raf Ponsaerts
03c21de0eb simplified itemservice.delete in MetadataImportIT 2020-11-19 09:44:45 +01:00
Raf Ponsaerts
c442545fc1 Merge remote-tracking branch 'dspace/main' into w2p-71780_support-csv-import-person-schema
Conflicts:
	dspace-api/src/test/java/org/dspace/app/bulkedit/MetadataImportIT.java
2020-11-19 09:44:19 +01:00
Yana De Pauw
1310d84e25 74329: [Issue 2981] Internal server errors when retrieving entries for externalsources 2020-11-19 09:41:57 +01:00
jonas-atmire
50703a0771 Reverting previous commit + clarification comment 2020-11-19 08:01:42 +01:00
Mark H. Wood
96742fe558 Satisfy Checkstyle. Small tidy-ups. #2956 2020-11-18 18:02:05 -05:00
Mark H. Wood
87cfac01d4 Replace deprecated JUnit and Mockito statics. #2956 2020-11-18 16:12:41 -05:00
Tim Donohue
496f18d4dd Merge pull request #3039 from atmire/w2p-74186_CSV-import-error-with-virtual-metadata-bugfix
CSV Import error with Virtual Metadata fix
2020-11-18 14:35:17 -06:00
Tim Donohue
b83b06f977 Merge pull request #3037 from atmire/csv-import-empty-value-support
Supporting CSV import removing values
2020-11-18 14:32:08 -06:00
Mark H. Wood
7d64bb6f71 Replace Class.getInstance(). #2956 2020-11-18 13:39:50 -05:00
Yana De Pauw
ac8ee7a8e6 74271: [Issue 2954] External Sources "entries" subpath should not include "query" parameter by default 2020-11-18 14:51:42 +01:00
Raf Ponsaerts
86d39a92f7 Re-added personMetadataImportTest in MetadataImportIT and deleted unused test params 2020-11-18 13:54:56 +01:00
Raf Ponsaerts
81c518cdeb Re-added the metadataImportRemovingValueTest in MetadataImportIT 2020-11-18 13:38:47 +01:00
Alessandro Martelli
65b69a2b29 [CSTPER-221] Script Flyway to populate handle metadata
Moved to sql files.
2020-11-18 10:52:27 +01:00
jonas-atmire
6dd048c68e Re-enabling of response.reset() method -> https://github.com/DSpace/DSpace/pull/3009#discussion_r525254104 2020-11-18 10:08:12 +01:00
Mark H. Wood
6d0c57fa3e Replace deprecated icu4j Normalizer with Normalizer2. #2956 2020-11-17 17:03:28 -05:00
Mark H. Wood
4afc33daef Satisfy checkstyle. 2020-11-17 16:22:33 -05:00
Mark H. Wood
e94911ba19 Replace deprecated setMetadata() that uses removed field names. #2956
Once upon a time, DSOs had dedicated fields for some metadata.  These were
moved into the Metadatavalue table long ago, but there were still methods
which used the old field names instead of proper MetadataField triplets.
2020-11-17 15:37:53 -05:00
Mark H. Wood
3e7ac5d935 Replace miscellaneous rarely-used deprecateds. [#2956] 2020-11-17 15:05:55 -05:00
Mark H. Wood
d77f6eef25 Replace deprecated org.apache.http.impl.client.DefaultHttpClient [#2956] 2020-11-17 15:05:55 -05:00
Mark H. Wood
7f53ab6bef Found a few more deprecated PosixParser, GnuParser, OptionBuilder. #2956 2020-11-17 15:05:51 -05:00
Mark H. Wood
6569089228 Remove deprecated setMetadata of CommunityService, CollectionService #2956
This introduces a new class:  a holder for metadata field names.
2020-11-17 13:53:49 -05:00
Mark H. Wood
f8221f54ce I missed one LocationUtils call. 2020-11-17 13:53:49 -05:00
Mark H. Wood
e08341faed Fix LGTM alert: pointless boxing. 2020-11-17 13:53:49 -05:00
Mark H. Wood
5838cfd9c7 Remove long-deprecated un-localized methods from LocationUtils. [#2956] 2020-11-17 13:53:49 -05:00
Mark H. Wood
22dcbf5481 Replace various deprecated PDFBox methods. [#2956] 2020-11-17 13:53:49 -05:00
Mark H. Wood
259bd4bcdd Fix anything that is documented @deprecated but not annotated @Deprecated. [#2956] 2020-11-17 13:53:49 -05:00
Mark H. Wood
0ade9e9978 Replace deprecated Class.newInstance(). [#2956] 2020-11-17 13:53:49 -05:00
Mark H. Wood
d5d3b55457 Replace deprecated constructors of boxed primitive types. [#2956] 2020-11-17 13:53:49 -05:00
Mark H. Wood
ff02474423 Fix broken test by catching an unexpected exception.
There must be an unchecked exception bubbling up through SolrServiceImpl#search.  Catching Exception (as before this PR) fixes the test failure.
2020-11-17 13:53:49 -05:00
Mark H. Wood
a5c1b780f6 Missed one more PosixParser. 2020-11-17 13:53:49 -05:00
Mark H. Wood
079bdb0e0d I missed a lot of deprecated PosixParser and OptionBuilder in the clutter of warnings (see?). 2020-11-17 13:53:49 -05:00
Mark H. Wood
47d32b72cd Better fix for configuration issue in c463b632dd24e0c017d88b36b2b6fa0f13d95fb1
Other code now depends on the 'id' of the curation script configuration bean,
so it can't be renamed.  Instead, remove the bean post processing code that
pokes 'dspace.cfg' properties into a bean which are prefixed with the bean's
'id', since nobody can remember why we do that and it causes subtle magical
problems.  It may be for Guice, which is no longer an option for DSpace.
2020-11-17 13:53:27 -05:00
Mark H. Wood
7ab6aed276 Remove deprecated getMetadata(Context, String) from CommunityService, CollectionService. 2020-11-17 13:46:10 -05:00
Mark H. Wood
8ee14c3abc Replace deprecated lang3.CharEncoding with nio.StandardCharsets. 2020-11-17 13:46:10 -05:00
Mark H. Wood
230cca287e Replace deprecated Xerces XML serializer with one from org.w3c.dom. 2020-11-17 13:46:10 -05:00
Mark H. Wood
00d9364f87 Replace deprecated Commons CLI PosixParser and OptionBuilder. 2020-11-17 13:46:10 -05:00
Mark H. Wood
34de00b47a Replace deprecated Commons Collections MultivalueMap. 2020-11-17 13:46:10 -05:00
Mark H. Wood
7395c5be8f Replace deprecated Spring @Required with @Autowired(required=true) 2020-11-17 13:46:06 -05:00
Mark H. Wood
95d0a2bf57 Remove long-deprecated ConfigurationManager. 2020-11-17 13:30:00 -05:00
Raf Ponsaerts
991ffa44a5 Altered root self link test to equals the exact url 2020-11-17 08:56:53 +01:00
Raf Ponsaerts
e51d15ebf5 Added self link to root endpoint 2020-11-13 16:24:26 +01:00
Mykhaylo
ec025828ff minor update of tests 2020-11-13 11:09:43 +01:00
Mykhaylo
a0af4b9e46 update tests 2020-11-12 11:14:07 +01:00
Raf Ponsaerts
ca653ea0b5 Merge remote-tracking branch 'dspace/main' into w2p-71780_support-csv-import-person-schema
Conflicts:
	dspace-api/src/test/java/org/dspace/app/bulkedit/MetadataImportTest.java
2020-11-12 11:11:23 +01:00
Raf Ponsaerts
be5836a707 Merge remote-tracking branch 'dspace/main' into csv-import-empty-value-support
Conflicts:
	dspace-api/src/test/java/org/dspace/app/bulkedit/MetadataImportTest.java
2020-11-12 11:11:00 +01:00
Raf Ponsaerts
70ff9eb718 Merge remote-tracking branch 'dspace/main' into csv-import-empty-value-support 2020-11-12 11:08:11 +01:00
Raf Ponsaerts
6c8eb146a6 Merge remote-tracking branch 'dspace/main' into w2p-71780_support-csv-import-person-schema 2020-11-12 11:07:40 +01:00
Mykhaylo
0f3186ce41 fixed wrong pagination of the search methods of ResourcePolicyRest endpoint 2020-11-11 17:01:31 +01:00
Mykhaylo
9746b5ea14 added tests that prove the wrong pagination of the search methods of ResourcePolicyRest endpoint 2020-11-11 17:00:18 +01:00
Mykhaylo
aeb6f941d3 fixed wrong pagination of the search method byMetadata of EPersonRest endpoint 2020-11-11 12:57:41 +01:00
Mykhaylo
b99f136aa3 added test that proves the wrong pagination of the search method byMetadata of EPersonRest endpoint 2020-11-11 12:55:43 +01:00
Mykhaylo
35b98db7a8 fixed wrong pagination of a search method byMetadata of GroupRest endpoint 2020-11-11 12:29:25 +01:00
Andrea Bollini
e2e13ebd06 Remove unnecessary changes and add more javadoc 2020-11-11 12:27:51 +01:00
Mykhaylo
50464dc216 added test that proves the wrong pagination of a search method of GroupRest endpoint 2020-11-11 12:26:18 +01:00
Mykhaylo
3960e57a1c fixed wrong pagination of collections 2020-11-11 11:52:25 +01:00
Mykhaylo
6f611e6868 added ITs that prove the wrong pagination of collections 2020-11-11 11:49:37 +01:00
Alessandro Martelli
e279cb3e05 [CSTPER-221] Script Flyway to populate handle metadata
Fixed Javadoc.
2020-11-11 09:28:47 +01:00
Tim Donohue
6ac06c8a23 Merge pull request #3038 from atmire/importing-new-csv-with-relationships
Importing new csv with relationships
2020-11-10 11:38:21 -06:00
Tim Donohue
4a8785b61e Disable stacktrace in error responses by default. Document how to enable. Cleanup of unused "server" settings 2020-11-10 11:01:03 -06:00
Raf Ponsaerts
a1cc44ebac Renamed MetadataImportTest to MetadataImportIT to better reflect that it is an Integration Test class 2020-11-10 14:43:53 +01:00
Alessandro Martelli
a0b5cf9075 [CSTPER-221] Fixed Unit tests 2020-11-09 17:13:22 +01:00
Alessandro Martelli
c84608e81f [CSTPER-221] Collection handle generation after creation 2020-11-09 17:06:29 +01:00
Alessandro Martelli
572a74afba [CSTPER-221] Script Flyway to populate handle metadata
For existing Collection/Community
2020-11-09 11:52:10 +01:00
Alessandro Martelli
dc08f36a94 [CSTPER-221] Fixed Authorization denied during subCommunity creation
We need to persist the newCommunity before adding the handle metadata
value. The failing test was
* CommunityRestRepositoryIT.createSubCommunityAuthorizedTest
2020-11-09 11:48:22 +01:00
Marie Verdonck
2c21703b5e Test for null value patch added back in 2020-11-09 11:39:31 +01:00
Tim Donohue
08163019fa Merge pull request #3026 from 4Science/CSTPER-212
Submission from external source rejected with 403
2020-11-06 12:29:00 -06:00
Tim Donohue
243c7b6387 Merge pull request #3042 from atmire/issue-irus-config-in-build-xml
IRUS property in build.xml when updating spiders
2020-11-06 09:53:35 -06:00
Raf Ponsaerts
c4fe9e6674 [Task 73179] added javadocs and cleaned up where necessary 2020-11-06 16:39:31 +01:00
Alessandro Martelli
ed01db6392 [CSTPER-221] MetadataConverter fixed 2020-11-06 15:55:10 +01:00
Alessandro Martelli
544828ae95 [CSTPER-212] Submission from external source rejected with 403
Test efficiency improvements.
2020-11-06 12:02:58 +01:00
Andrea Bollini
72f5ea3383 Merge pull request #3030 from atmire/Issue_2919_URI-Parameters-not-added-for-self-link
Uri parameters not added for self link
2020-11-06 08:50:05 +01:00
Andrea Bollini
9d52f01270 Solve dependencies convergence issues 2020-11-05 22:49:59 +01:00
Andrea Bollini
9d938a6282 Switch to the official orcid model maven artifact 2020-11-05 22:13:02 +01:00
Andrea Bollini
a8aab9d88b Improve ORCID testing via mock response 2020-11-05 22:10:29 +01:00
Andrea Bollini
e6000f6e5e Merge branch 'main' of https://github.com/DSpace/DSpace into D4CRIS-952-orcidV3 2020-11-05 15:49:41 +01:00
Raf Ponsaerts
2bec15c76c Made sure that IRUS properties can be read into build.xml when updating spiders 2020-11-05 13:43:39 +01:00
Tim Donohue
fb39eb49ce Merge pull request #3031 from atmire/w2p-74190_Bugfix-IRUS-Integration-Entities
Bugfix IRUS Integration with Entities
2020-11-04 13:09:59 -06:00
Jonas Van Goolen
0e296528de Update RestResourceControllerIT.java 2020-11-04 15:03:24 +01:00
Andrea Bollini
c0c2433a22 Merge pull request #3015 from tdonohue/more_lgtm_fixes
More fixes based on LGTM.com feedback
2020-11-04 12:50:38 +01:00
Raf Ponsaerts
2466731028 Rewrote the test class using builders 2020-11-03 16:38:30 +01:00
Alessandro Martelli
b878b0a7e0 [CSTPER-221] Minor changes and cleanup 2020-10-30 18:41:04 +01:00
Raf Ponsaerts
9d4151c22f deleting unused files 2020-10-30 11:13:26 +01:00
Raf Ponsaerts
eaa53c53b1 Rewrote MetadataImportTest with builders 2020-10-30 11:12:40 +01:00
Raf Ponsaerts
e33cc4735d Fixed imports for MetadataImportTest 2020-10-30 10:06:42 +01:00
Raf Ponsaerts
3df1ff5f70 [Task 71782] added test to the MetadataImport tests
Conflicts:
	dspace-api/src/test/java/org/dspace/app/bulkedit/MetadataImportTest.java
2020-10-30 10:06:04 +01:00
Raf Ponsaerts
27a6173360 [Task 71782] created support to check relationship.type metadata from the csv instead of the item which won't yet exist
Conflicts:
	dspace-api/src/test/java/org/dspace/app/bulkedit/MetadataImportTest.java
	dspace-api/src/test/resources/test-config.properties
2020-10-30 10:05:24 +01:00
Tim Donohue
cf5d52d60b Merge pull request #3013 from atmire/w2p-73986_Features-Endpoint---Usage-Statistics-Permissions-in-REST
Features Endpoint: Permissions to view stats, map items, see versions
2020-10-29 16:33:53 -05:00
Tim Donohue
481d69619c Merge pull request #3005 from atmire/w2p-73167_Edit-collection-permissions-in-REST-feature
Features endpoint: Edit Collection Permissions
2020-10-29 16:33:34 -05:00
Tim Donohue
ff9f59a14a Merge pull request #2993 from atmire/w2p-73207_Download-permission-features
Features endpoint: Download/RequestACopy features
2020-10-29 16:33:14 -05:00
Tim Donohue
5f74e7c434 Merge pull request #3021 from tdonohue/upgrade_commons_config
Upgrade to latest commons configuration & opencsv
2020-10-29 15:27:25 -05:00
Alessandro Martelli
28273ce292 [CSTPER-221] EZIDIdentifierProvider exclusions 2020-10-29 18:57:42 +01:00
Alessandro Martelli
ebab983618 [CSTPER-221] Validation check and MetadataConverter merge facility 2020-10-29 18:51:45 +01:00
Alessandro Martelli
b33cd12ddf [CSTPER-221] EZIDIdentifierProvider exclusions 2020-10-29 17:29:05 +01:00
Alessandro Martelli
d3c3d30c6c [CSTPER-221] Versioned handle populate metadata cleanup 2020-10-29 17:28:40 +01:00
Alessandro Martelli
e959d70cc7 [CSTPER-221] Reverted modifications to the register method 2020-10-29 16:50:44 +01:00
Alessandro Martelli
5968c9ce2a [CSTPER-221] Tests refined 2020-10-29 16:44:37 +01:00
Luca Giamminonni
d8d3aca995 Community admin should also be considered a Collection admin 2020-10-29 16:20:23 +01:00
Yana De Pauw
111a7d9148 Fix LGTM issue 2020-10-29 15:19:19 +01:00
jonas-atmire
8637378a89 Issue 2919 -> Checkstyle fix 2020-10-29 07:46:14 +01:00
jonas-atmire
dcfe58f104 Merge branch 'main' into Issue_2919_URI-Parameters-not-added-for-self-link 2020-10-28 20:33:23 +01:00
jonas-atmire
74f14540d1 Issue 2919 -> URI parameters not properly added for self-links 2020-10-28 20:32:17 +01:00
Marie Verdonck
ccb18daeb0 Git merge https://github.com/atmire/DSpace.git / master
* Conflict file: RelationshipRestRepositoryIT
2020-10-28 18:06:17 +01:00
Yana De Pauw
38e54ea21f 74190: Bugfix IRUS Integration Entities 2020-10-28 17:21:08 +01:00
Marie Verdonck
cd5be5b84f 74274: [Issue 2988]: EPersonPasswordReplaceOperation => AddOperation; eperson password can be added&replaced with this patch operation + test changes 2020-10-28 16:07:40 +01:00
Yana De Pauw
ea7d5d5b79 74186: CSV import error with virtual metadata bugfix 2020-10-28 12:29:31 +01:00
Tim Donohue
e5fec0ddf8 Minor updates to Jetty and log4j to solve security issues 2020-10-27 16:42:53 -05:00
Tim Donohue
1910c9e9ba Remove unused dependencies. Minor updates for dependency alignment 2020-10-27 16:42:34 -05:00
Alessandro Martelli
d8b7a78578 [CSTPER-221] RestMetadata applied without deleting existing ones. 2020-10-27 16:58:29 +01:00
Alessandro Martelli
2daad0b98c [CSTPER-221] DOI Collection/Community exclusion 2020-10-27 16:47:05 +01:00
Alessandro Martelli
b27d2ba322 [CSTPER-221] Handle Providers enhanced for Communities and Collections 2020-10-27 16:39:26 +01:00
Alessandro Martelli
36e6a44000 [CSTPER-221] CommunityRestRepository common code refactoring 2020-10-27 16:31:15 +01:00
Alessandro Martelli
1e54484ef5 [CSTPER-221] Integration Test
The creation of communities (toplevel and subcommunities) and the
creation of collections implies population of dc.identifier.uri
metatada.
We also prove that the logic doesn't affect the creation of other types
of entities (eperson).
2020-10-27 16:26:43 +01:00
Raf Ponsaerts
f90384dbbc Removed unnecessary config in test local.cfg 2020-10-27 13:12:22 +01:00
Raf Ponsaerts
6cdab6effd Rewrote MetadataImportTest and added a test for empty value support 2020-10-26 14:38:36 +01:00
Raf Ponsaerts
3905601e20 Merge remote-tracking branch 'dspace/main' into csv-import-empty-value-support 2020-10-26 13:28:54 +01:00
Raf Ponsaerts
2cbbbf95b3 Rewriting MetadataImportTest with builders 2020-10-26 13:27:47 +01:00
Raf Ponsaerts
86ddfc205c Merge remote-tracking branch 'dspace/main' into w2p-71780_support-csv-import-person-schema 2020-10-26 11:37:45 +01:00
Tim Donohue
ae02b261fc Merge pull request #2999 from atmire/cleanup-builder-cache-after-test
Cleaning up the cache of Builders after each test
2020-10-23 16:40:30 -05:00
Tim Donohue
86c2edcbb1 Merge pull request #3024 from atmire/w2p-74193_DSpace-version-in-root-endpoint
ROOT endpoint (/server) returns the version of DSpace
2020-10-23 16:35:53 -05:00
Alessandro Martelli
57417884ac [CSTPER-212] Submission from external source rejected with 403 2020-10-22 09:42:21 -04:00
Raf Ponsaerts
2a358bfd6f [Task 74193] altered the test for the DSpace Version on the root endpoint 2020-10-22 12:25:52 +02:00
Kristof De Langhe
e42acb9dde 74193: DSpace version in root endpoint 2020-10-22 11:18:29 +02:00
Tim Donohue
678f949350 Merge pull request #2966 from DSpace/dependabot/maven/org.apache.ant-ant-1.9.15
Bump ant from 1.9.1 to 1.9.15
2020-10-21 16:32:44 -05:00
Tim Donohue
22bcdf210c Upgrade to latest commons configuration & opencsv 2020-10-21 14:48:18 -05:00
Kevin Van de Velde
cc644e7c3f Removing unused imports 2020-10-21 15:50:44 +02:00
Kevin Van de Velde
a70e9ebf5b Enabling discovery consumer in the unit tests for the api 2020-10-21 14:02:00 +02:00
Tim Donohue
6c6b977d74 Upgrade to Bootstrap 4 (via WebJars). Cleanup unnecessary Bootstrap 3 cached files 2020-10-20 16:13:03 -05:00
Tim Donohue
89571fb289 Merge pull request #3000 from DSpace/dependabot/maven/junit-junit-4.13.1
Bump junit from 4.12 to 4.13.1
2020-10-20 10:44:32 -05:00
Tim Donohue
84c74590b8 Minor fix. Only call entry.getName() once. Store it after verifying it's valid. 2020-10-20 09:45:53 -05:00
Tim Donohue
967273fad2 Fix cross site scripting (XSS) issue by not returning "user" value 2020-10-19 16:45:58 -05:00
Tim Donohue
f973874143 Ignore two XXE warnings which are false positives. Notes inline to describe why 2020-10-19 16:43:38 -05:00
Tim Donohue
f4780dc35f Fix error where wrong variable was used. "info" was always null. 2020-10-19 16:17:32 -05:00
Tim Donohue
28f270afa4 Replace error message as doiRow was always null at this line of code 2020-10-19 16:17:22 -05:00
Tim Donohue
24054276a1 Add missing hashCode method (as equals exists) 2020-10-19 16:17:02 -05:00
Tim Donohue
786de19c5b Fix inconsistent synchronization of getter and setter in two places 2020-10-19 16:15:01 -05:00
Tim Donohue
b2c2c8e190 Fix information exposure through stack trace issue. Log error instead. 2020-10-19 16:14:49 -05:00
Tim Donohue
b6705da008 Refactor ItemImportServiceImpl to check for Zip entry location once around all code that uses it 2020-10-19 16:14:38 -05:00
Raf Ponsaerts
1ed4aaf87d fixed checkstyle 2020-10-16 12:57:50 +02:00
Raf Ponsaerts
4a2e41c5a0 Added additional tests to the FeatureITs 2020-10-16 11:04:20 +02:00
Tim Donohue
793ae8c0d5 Correct syntax for referencing related issues 2020-10-15 15:43:47 -05:00
Raf Ponsaerts
867aec4cd1 Refactor/remove custom MultipartFileSender to use Spring Boot Range requests 2020-10-15 18:31:04 +02:00
Peter Nijs
242ea65443 74062: Features Endpoint - Version Permissions in REST implementation 2020-10-15 17:13:43 +02:00
Peter Nijs
380ece2f2c 74059: Features Endpoint - Manage Mapped Item Permissions in REST implementation 2020-10-15 16:34:04 +02:00
Peter Nijs
cecb4846dc 74057: Features Endpoint - Search Statistics Permissions in REST 2020-10-15 15:30:50 +02:00
Peter Nijs
c6e50aef51 74055: Features Endpoint - Workflow Statistics Permissions in REST 2020-10-15 15:06:53 +02:00
Peter Nijs
c9463e2850 73986: Features Endpoint - Usage Statistics Permissions in REST 2020-10-14 15:39:03 +02:00
Peter Nijs
bddd4c4f9c 73178: Edit Collection Permissions in REST Feature Integration Tests - feedback 2020-10-14 15:35:26 +02:00
Ben Bosman
9895049a99 Merge remote-tracking branch 'community/main' into entities-update-item-metadata-outside-rest 2020-10-14 14:45:43 +02:00
Ben Bosman
f71a6ee5d5 Merge remote-tracking branch 'community/main' into w2p-71780_support-csv-import-person-schema
# Conflicts:
#	dspace-api/src/test/java/org/dspace/app/bulkedit/MetadataImportTest.java
2020-10-14 14:21:51 +02:00
Ben Bosman
9a8f81db44 Merge conflicts 2020-10-14 13:51:46 +02:00
Ben Bosman
cca43baea4 Merge remote-tracking branch 'community/main' into w2p-71502_deleting-items-with-min-relationship
# Conflicts:
#	dspace-api/src/test/java/org/dspace/builder/WorkspaceItemBuilder.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/ItemRestRepositoryIT.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/WorkspaceItemRestRepositoryIT.java
2020-10-14 13:47:08 +02:00
Ben Bosman
894ec569f1 Merge remote-tracking branch 'community/main' into w2p-72348_Support-itemService-getMetadata-with-virtual-md 2020-10-14 12:53:33 +02:00
Peter Nijs
04f4e1e234 73986: Features Endpoint - Usage Statistics Permissions in REST 2020-10-13 11:51:07 +02:00
dependabot[bot]
f3dbe75c15 Bump junit from 4.12 to 4.13.1
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
- [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md)
- [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-10-12 19:59:25 +00:00
Raf Ponsaerts
e41b70cfe3 Added javadoc 2020-10-12 15:32:48 +02:00
Raf Ponsaerts
ce04f78703 Cleaning up the cache of Builders after each test has ran 2020-10-12 15:21:38 +02:00
Peter Nijs
d1ee2556f3 73178: Edit Collection Permissions in REST Feature Integration Tests
- add ManageWorkflowGroupFeature, ManageSubmitterGroupFeature, ManageAdminGroupFeature
2020-10-12 13:48:23 +02:00
Raf Ponsaerts
6295540e47 Small cleanup 2020-10-12 10:51:08 +02:00
Tim Donohue
01e61aedff Ensure 'rest' overlay module is released when -Drelease specified 2020-10-10 13:44:36 -05:00
Tim Donohue
c9b4c6b773 [maven-release-plugin] prepare for next development iteration 2020-10-10 12:09:24 -05:00
Tim Donohue
5be0009a3c [maven-release-plugin] prepare release dspace-7.0-beta4.1 2020-10-10 12:09:15 -05:00
Tim Donohue
7ac94a127c Revert "Always skip Javadoc generation for assembly & overlay modules"
This reverts commit 268cd585bc.
2020-10-10 11:59:20 -05:00
Tim Donohue
99c8d12dd9 [maven-release-plugin] prepare for next development iteration 2020-10-10 11:46:38 -05:00
Tim Donohue
63d1775eaa [maven-release-plugin] prepare release dspace-7.0-beta4.1 2020-10-10 11:46:29 -05:00
Tim Donohue
268cd585bc Always skip Javadoc generation for assembly & overlay modules 2020-10-10 11:30:46 -05:00
Tim Donohue
b9e1ec1081 Additional POM corrections 2020-10-10 10:38:29 -05:00
Tim Donohue
d23dab6917 One last POM needing version correction (see previous commit) 2020-10-10 10:30:39 -05:00
Tim Donohue
4e75b821df Correct versions in POMs under [src]/dspace/ after release. Make sure [src]/dspace/ is included in release as POMs MUST be updated 2020-10-10 10:26:53 -05:00
Tim Donohue
041a714d0e [maven-release-plugin] prepare for next development iteration 2020-10-09 16:48:00 -05:00
Tim Donohue
c03a858d3a [maven-release-plugin] prepare release dspace-7.0-beta4 2020-10-09 16:47:52 -05:00
Tim Donohue
fdabb94833 Add a new -Drelease property to enable/disable modules for release. 2020-10-09 16:26:49 -05:00
Tim Donohue
095acc8777 Rollback beta4 again. One more try coming up 2020-10-09 14:26:43 -05:00
Tim Donohue
14701733eb [maven-release-plugin] prepare for next development iteration 2020-10-09 11:23:00 -05:00
Tim Donohue
63ff4c9463 [maven-release-plugin] prepare release dspace-7.0-beta4 2020-10-09 11:22:48 -05:00
Tim Donohue
dd0852425f Merge pull request #2998 from tdonohue/POM-fixes
Fixes to Parent POM to resolve release issues with Beta 4
2020-10-09 11:09:52 -05:00
Tim Donohue
95b7cd6bd9 Fixes to POM to fix release issues 2020-10-09 10:25:48 -05:00
Tim Donohue
1312f47414 rollback the release of dspace-7.0-beta4 2020-10-09 10:09:17 -05:00
Tim Donohue
d5b2fc9ea8 [maven-release-plugin] rollback the release of dspace-7.0-beta4 2020-10-09 10:02:39 -05:00
Peter Nijs
45fe8eec07 73168: Edit Collection Permissions in REST Feature Integration Tests - feedback 2020-10-09 16:58:38 +02:00
Tim Donohue
2ea30353fe [maven-release-plugin] prepare for next development iteration 2020-10-09 09:22:20 -05:00
Tim Donohue
b66159c3e4 [maven-release-plugin] prepare release dspace-7.0-beta4 2020-10-09 09:22:09 -05:00
Kevin Van de Velde
53685eb101 Merge branch 'master' into DS-4443_delete-solr-record-on-workspaceitem-deletion 2020-10-09 09:02:21 +02:00
Tim Donohue
bcfa6e873c Merge branch 'main' of https://github.com/DSpace/DSpace into main 2020-10-08 16:25:00 -05:00
Tim Donohue
a211d4e0ce Ensure Maven Central is checked first (before other repos) 2020-10-08 16:23:34 -05:00
Tim Donohue
f4e225e018 Rollback Beta 4 as it hit errors in release 2020-10-08 16:20:49 -05:00
Tim Donohue
35e0ca4751 [maven-release-plugin] prepare for next development iteration 2020-10-08 15:39:17 -05:00
Tim Donohue
100d261555 [maven-release-plugin] prepare release dspace-7.0-beta4 2020-10-08 15:39:07 -05:00
Tim Donohue
d645ec30e6 Merge pull request #2928 from atmire/w2p-72472_Delete-eperson
[DS-4036] Delete EPersons even if they are referenced
2020-10-08 12:06:46 -05:00
Ben Bosman
9ae42397bf add TODO message 2020-10-07 09:52:21 +02:00
Yana De Pauw
4103b016ec 73977: Delete eperson: community feedback part 3 2020-10-06 17:16:38 +02:00
Peter Nijs
3e8eb3b3ec 73168: Edit Collection Permissions in REST Feature Integration Tests 2020-10-05 13:52:59 +02:00
Ben Bosman
01cc856067 checkstyle 2020-10-05 10:35:23 +02:00
Ben Bosman
d6046dc7ff updated JavaDocs to explain the goal of the tests in more detail 2020-10-05 09:51:22 +02:00
Yana De Pauw
cd5c89dd68 73914: Implement feedback 2020-10-05 09:34:27 +02:00
Tim Donohue
737d3e677e Merge pull request #2978 from atmire/w2p-73047_Edit-community-permissions-REST-Feature
Features endpoint: Community / collection creation
2020-10-02 10:30:24 -05:00
Tim Donohue
6cb4b7e74a Merge pull request #2949 from tdonohue/upgrade_flyway
Upgrade to Flyway v6.5.5. Update code based on Flyway API changes
2020-10-02 09:17:07 -05:00
Yana De Pauw
6ace62112f 73914: Features Endpoint - Download Permissions in REST - Feedback 2020-10-02 10:43:18 +02:00
Tim Donohue
541903bdb0 Merge pull request #2979 from atmire/bugfix-file-mandatory
Submission bugfix for file upload mandatory
2020-10-01 14:22:11 -05:00
Peter Nijs
367ce35b4a 73173: Edit Collection Permissions in REST Feature Implementation 2020-10-01 18:54:03 +02:00
Ben Bosman
8f824c0642 for loop is not applicable 2020-10-01 16:17:26 +02:00
Yana De Pauw
d5e28e8a7c Merge remote-tracking branch 'upstream/main' into w2p-72472_Delete-eperson 2020-10-01 10:49:10 +02:00
Yana De Pauw
9b169afd35 73783: Delete eperson: community feedback part 2 2020-10-01 10:48:46 +02:00
Tim Donohue
8d57d71cb2 Merge pull request #2664 from atmire/DS-626
DS-626 : Exchange usage data with IRUS
2020-09-30 16:00:50 -05:00
Tim Donohue
05ca185f22 Remove /api per https://github.com/DSpace/dspace-angular/pull/877 2020-09-30 11:39:10 -05:00
Tim Donohue
62a4b32fe8 Update Codecov settings
This makes patch checks slightly more lenient, as they are not required.
2020-09-30 09:13:20 -05:00
Mykhaylo
850d93546a update test and OrcidRestConnector 2020-09-28 18:33:58 +02:00
Yana De Pauw
3b563e4906 73422: Delete eperson: community feedback 2020-09-28 17:31:00 +02:00
Peter Nijs
4fb4c129a9 73167: Edit Collection Permissions in REST Feature Implementation 2020-09-28 13:55:53 +02:00
Mykhaylo
3a47781193 added pooling http cliente connection manager to send to ORCID 2020-09-28 10:30:32 +02:00
Yana De Pauw
61494f4291 73210: Finish Its for RequestCopyFeature and DownloadFeature 2020-09-28 10:14:16 +02:00
Yana De Pauw
c53e211ba5 173207: Implement tests for RequestCopyFeature part 1 2020-09-25 15:18:20 +02:00
Yana De Pauw
f8e32554e6 73207: Download Permissions in REST Feature Implementation 2020-09-25 11:44:50 +02:00
Yana De Pauw
1db90a596f 73207: Download Permissions in REST Feature Implementation 2020-09-25 11:19:01 +02:00
Mykhaylo
ba4d1c20f1 fix test 2020-09-25 10:47:25 +02:00
Mykhaylo
007c8f035d added missing bean 2020-09-25 10:45:31 +02:00
Tim Donohue
bd0e20cb18 Merge pull request #2950 from tdonohue/ordered_processes
Ensure processes are ordered by ID by default.
2020-09-24 14:36:38 -05:00
Tim Donohue
2276d2ccfb Fix README instructions on running one IT class 2020-09-24 14:10:00 -05:00
Tim Donohue
569169a852 Per feedback, refactor MigrationUtils.resourceToString into getResourceAsString. Remove usage of ClassPathResource 2020-09-24 13:31:33 -05:00
Tim Donohue
71bdd8341b Ensure Flyway database table also checked by main() method. Removed some invalid comments too 2020-09-24 12:23:54 -05:00
Tim Donohue
b36849d110 Ignore license header in new Flyway upgrade scripts 2020-09-24 12:23:53 -05:00
Tim Donohue
6379c06461 Minor change to Context. Add synchronized to ensure database upgrade only triggered once 2020-09-24 12:23:53 -05:00
Tim Donohue
d137ce179f Add support for upgrading database directly from DSpace 5.x to 7.x 2020-09-24 12:23:53 -05:00
Tim Donohue
ae7ef8577b Minor fixes. Flyway migration paths now prefer slashes to dots. Add Flyway version to 'info' command. 2020-09-24 12:23:53 -05:00
Tim Donohue
a2cfa09c01 Upgrade to Flyway v6.5.5. Update code based on Flyway API changes 2020-09-24 12:23:53 -05:00
Mykhaylo
2ae8f0e9fa added mockito test to prove functionality of OrcidExternalSources 2020-09-24 18:55:37 +02:00
Tim Donohue
afb78e1e03 Merge pull request #2940 from atmire/w2p-72492_authorization-feature-for-edit-item-in-REST
Features endpoint - Edit item permissions in REST
2020-09-23 16:40:50 -05:00
Tim Donohue
88a63e7c77 Customize Codecov settings 2020-09-23 13:33:10 -05:00
Mykhaylo
50efbd29bb added dependensy to use official artifact of orcid 2020-09-23 17:52:59 +02:00
Mykhaylo
fe41f58c51 Merge branch 'main' into D4CRIS-952-orcidV3-merge 2020-09-23 16:57:14 +02:00
Tim Donohue
1272782bab Merge pull request #2971 from mwoodiupui/2970
Replace FindBugs with SpotBugs.
2020-09-22 15:06:24 -05:00
Tim Donohue
daeb6d5b31 Merge pull request #2968 from mwoodiupui/#2967
Scrap DSpaceBeanPostProcessor, InitializedService, ShutdownService.
2020-09-22 14:53:21 -05:00
Tim Donohue
8c5f1a12ca Merge pull request #2980 from tdonohue/travis_parallel_codecov
(CodeCov.io Alternative) Update Travis/Maven configs to run Unit & Integration Tests in parallel
2020-09-22 14:19:32 -05:00
Tim Donohue
21700f7eed Merge pull request #2960 from atmire/duplicate-discovery-bugfix
Bugfix to avoid duplicates in discovery consumer
2020-09-22 12:18:45 -05:00
Tim Donohue
8fa0d80589 Replace Coveralls by CodeCov.io 2020-09-21 16:18:28 -05:00
Tim Donohue
c40b60c8b9 Update testing commands in README based on changes 2020-09-21 16:18:27 -05:00
Tim Donohue
4aa71ca221 Fix Coveralls coverage reports. Cleanup and reorg of travis.yml to support 2020-09-21 16:18:27 -05:00
Tim Donohue
84e0164312 Refactor Travis configs to run unit and integration tests separately 2020-09-21 16:18:26 -05:00
Tim Donohue
9908de3979 Replace skipTests with skipUnitTests and skipIntegrationTests 2020-09-21 16:18:26 -05:00
Kristof De Langhe
87cec195ca 73161: Feature ITs JavaDocs 2020-09-21 14:39:52 +02:00
Ben Bosman
88e073d8f2 bugfix to verify whether a file is mandatory 2020-09-21 12:13:35 +02:00
Yana De Pauw
6f2c34050a Merge remote-tracking branch 'upstream/main' into DS-626 2020-09-18 15:06:16 +02:00
Yana De Pauw
9945ab1bc3 70906: Process IRUS DSpace 7 PR feedback 2020-09-18 11:52:19 +02:00
Tim Donohue
e7348159b7 Fix test to check for exact ordering of Processes 2020-09-17 11:41:55 -05:00
Tim Donohue
6a3ec14d26 Ensure processes are ordered by ID by default. 2020-09-17 11:40:14 -05:00
Tim Donohue
2e5efda2fa Merge pull request #2972 from 4Science/fix-shib-redirect
Fix shibboleth redirect to work with all allowed origins
2020-09-17 11:31:12 -05:00
Tim Donohue
74f88197c2 Merge pull request #2930 from atmire/w2p-72503_default-anonymous-access-site-object
Default Anonymous READ rights for the site object
2020-09-17 11:28:37 -05:00
Tim Donohue
1e7781e195 Merge pull request #2931 from atmire/w2p-72498_scripts-and-processes-search
Scripts and processes search
2020-09-17 08:43:16 -05:00
Yana De Pauw
f71202c8c3 Fix to tests post merge 2020-09-17 14:03:50 +02:00
Yana De Pauw
3977fe72c8 Merge remote-tracking branch 'upstream/main' into w2p-72472_Delete-eperson 2020-09-17 14:03:44 +02:00
Giuseppe Digilio
debf437ae7 Fix shibboleth redirect to work with all allowed origins 2020-09-17 10:49:55 +02:00
Mark H. Wood
88413f50d6 Replace FindBugs with SpotBugs. 2020-09-16 17:35:09 -04:00
benbosman
81f58b473f Merge pull request #32 from atmire/w2p-72774_Delete-eperson-workspace
72774: Delete eperson: workspace
2020-09-16 12:44:15 +02:00
Mark H. Wood
bcf2158f54 Remove useless null checks spotted by LGTM. 2020-09-15 14:10:12 -04:00
Peter Nijs
ad9913986c 73011: Edit item permissions community feedback 2020-09-15 17:45:08 +02:00
Mark H. Wood
a7023eff0b Scrap DSpaceBeanPostProcessor, InitializedService, ShutdownService.
These duplicate the standard @PostConstruct and @PreDestroy methods.
2020-09-15 10:56:02 -04:00
Kristof De Langhe
ff504bc66c 73161: CanCreateCollectionsIT and CanCreateCommunitiesIT 2020-09-15 13:58:42 +02:00
Kristof De Langhe
975e3baaf5 73161: Checkstyle fixes 2020-09-15 10:58:01 +02:00
dependabot[bot]
ea823190fd Bump ant from 1.9.1 to 1.9.15
Bumps ant from 1.9.1 to 1.9.15.

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-14 18:18:24 +00:00
Raf Ponsaerts
0a1aa90cda [Task 71757] added mock configuration service to the test class 2020-09-14 15:39:03 +02:00
Raf Ponsaerts
6f3719258c Merge remote-tracking branch 'dspace/main' into w2p-72498_scripts-and-processes-search
Conflicts:
	dspace-api/src/main/java/org/dspace/scripts/ProcessServiceImpl.java
	dspace-api/src/main/java/org/dspace/scripts/service/ProcessService.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/ProcessRestRepositoryIT.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/ScriptRestRepositoryIT.java
2020-09-14 14:48:02 +02:00
Tim Donohue
e24f924654 Merge pull request #2934 from atmire/w2p-72494_Export-script-output
Scripts and processes - Script output
2020-09-11 12:57:17 -05:00
Tim Donohue
0385352151 Merge pull request #2782 from atmire/w2p-71214_Usage-reports
DSpace (Solr) Statistics - Usage Reports
2020-09-11 12:40:20 -05:00
Tim Donohue
4340b50293 Merge pull request #2792 from 4Science/draft_vocabulary
Refactoring authority framework, value pairs and controlled vocabulary
2020-09-11 09:41:49 -05:00
Raf Ponsaerts
370d15a78e [Task 73139] added javadocs to the AbstractIndexableObject 2020-09-11 11:51:25 +02:00
Raf Ponsaerts
3cd3587917 [Task 73139] added equals and hashcode methods to IndexableObjects 2020-09-11 10:41:08 +02:00
Tim Donohue
de62b50142 Merge pull request #2963 from DSpace/tdonohue-bean-name-fix
Bug fix: Bean capitalization fix
2020-09-10 16:27:29 -05:00
Tim Donohue
7c69c2ef43 Bean capitalization fix 2020-09-10 13:50:38 -05:00
Tim Donohue
5b363f43ab Merge pull request #2961 from atmire/bugfix-PR-2760
Bugfix pr 2760
2020-09-10 10:41:40 -05:00
Tim Donohue
99a0501fa5 Merge pull request #2914 from 4Science/D4CRIS-960
DS-4514 Additional Providers - Start new submission by uploading a Bibliographic File (using Live Import)
2020-09-10 10:28:19 -05:00
Pasquale Cavallo
12d06bb597 Merge branch 'main' into D4CRIS-960 2020-09-10 16:24:16 +02:00
Ben Bosman
245af53f43 Merge remote-tracking branch 'origin/master' into entities-update-item-metadata-outside-rest 2020-09-10 15:47:25 +02:00
Ben Bosman
8a73c8e555 Fix a bug introduced in https://github.com/DSpace/DSpace/pull/2760 2020-09-10 14:38:25 +02:00
Ben Bosman
6493287ca0 Fix a bug introduced in https://github.com/DSpace/DSpace/pull/2760 2020-09-10 14:10:45 +02:00
Ben Bosman
359ea40f1e Bugfix to avoid duplicates in discovery consumer 2020-09-09 12:42:51 +02:00
Kristof De Langhe
a2f3b6e86d 73047: CreateCommunityFeature and CreateCollectionFeature 2020-09-09 11:37:25 +02:00
Tim Donohue
9a0866e267 Merge pull request #2955 from tdonohue/minor_test_fix
Minor Test fix: Ensure prior data is cleaned. Fix ordering of params in assert
2020-09-08 13:57:02 -05:00
Tim Donohue
69db5b0f91 Merge pull request #2932 from atmire/w2p-72546_full-projection-tests
[DS-4485] Assure that test with full projection exists for all endpoints
2020-09-08 12:44:14 -05:00
Tim Donohue
280a4dc238 Ensure prior data is cleaned. Fix ordering of params in assert 2020-09-08 11:59:56 -05:00
Raf Ponsaerts
13b59f9522 [Task 73021] applied feedback to the scripts&processes search endpoint 2020-09-08 11:13:39 +02:00
Raf Ponsaerts
7484e47694 Merge remote-tracking branch 'dspace/main' into w2p-72494_Export-script-output 2020-09-08 09:29:52 +02:00
Raf Ponsaerts
f537eadcc3 [Task 73019] applied feedback to the export script output 2020-09-08 09:13:57 +02:00
Marie Verdonck
346ff69bcd 73025: Fix self link 2020-09-07 10:58:37 +02:00
Tim Donohue
4c8c1496b5 Merge pull request #2824 from 4Science/DS-4515_submit-external-source
DS-4515 - Start new submission via Search or ID Lookup (using Live Import)
2020-09-04 09:47:50 -05:00
Marie Verdonck
65da1216fd Valid DSO UUID check 2020-09-04 13:58:32 +02:00
Marie Verdonck
64cf386b25 72788: Feedback processed: Removed unneeded extends 2020-09-04 12:29:38 +02:00
Marie Verdonck
88fbb77aa5 72788: Feedback processed: Javadoc, moved service > util, config comment 2020-09-04 12:26:18 +02:00
Pasquale Cavallo
1b4988d9d6 remove wrong comment 2020-09-03 17:25:02 +02:00
Tim Donohue
bb6413af10 Merge pull request #2933 from atmire/w2p-72455_Cookie-Preferences-per-account
Cookie preferences & End User Agreement per account - initial registries update
2020-09-03 10:06:43 -05:00
Tim Donohue
f2f38872fc Merge pull request #2947 from atmire/w2p-72387-Workflow-minor-fixes
Workflow minor fixes
2020-09-02 16:37:52 -05:00
Tim Donohue
acf1d16f08 Merge pull request #2952 from mwoodiupui/#2951
Use getters instead of direct references that may have been uninitialized. #2951
2020-09-02 16:33:42 -05:00
Mark H. Wood
daeb55fa0c Use getters instead of direct reference that may throw NPE. #2951 2020-09-02 16:19:37 -04:00
Tim Donohue
0523167625 Merge pull request #2926 from atmire/w2p-72232_curation-task-email-parameter
Curation task email parameter changes
2020-09-02 11:14:26 -05:00
Tim Donohue
0746caf00d Update action to ignore errors 2020-09-01 09:09:20 -05:00
Yana De Pauw
548e0355ef 72774: Delete eperson: workspace 2020-09-01 11:41:17 +02:00
Tim Donohue
debecc287a Merge pull request #2899 from atmire/w2p-71752_Metadata-field-search
Metadata field search
2020-08-31 16:28:50 -05:00
Marie Verdonck
c88b6ef2e7 72788: explicit solr.commit allowed config added for Statistics tests 2020-08-31 16:30:24 +02:00
Yana De Pauw
959109a6a1 Merge remote-tracking branch 'upstream/main' into w2p-72494_Export-script-output 2020-08-28 17:03:23 +02:00
Samuel
8adc7e5c31 taskid 72455 Cookie Preferences per account - add scope notes and more realistic test value 2020-08-28 15:26:22 +02:00
Yana De Pauw
80d64e73ec 72494: Fix issue with task executor being used in tests 2020-08-28 13:07:26 +02:00
jonas-atmire
ef57561993 Merge branch 'main' into w2p-72232_curation-task-email-parameter 2020-08-28 08:55:04 +02:00
Tim Donohue
af2726831f Merge pull request #2925 from atmire/AdministratorOfFeature-fixes
72450: AdministratorOfFeature: fixes
2020-08-27 16:39:41 -05:00
Tim Donohue
c5e3b70d85 Merge pull request #2924 from atmire/w2p-72430_metadataexport-file-parameter
[Issue: 2821] Metadata export script file parameter removed from REST
2020-08-27 15:26:30 -05:00
Pasquale Cavallo
397bc1efcb Merge branch 'DS-4515_submit-external-source' of https://github.com/4Science/DSpace into DS-4515_submit-external-source 2020-08-27 16:23:13 +02:00
Pasquale Cavallo
7422dafef5 Change javadoc on ArXivIdMetadataContributor.parseValue 2020-08-27 16:22:29 +02:00
Pasquale Cavallo
46193ff16e Enable missing tests 2020-08-27 16:08:21 +02:00
Pasquale Cavallo
42d5236393 Add MultipleMetadataContributor to support multiple MetadataContributor
for each MetadataFieldConfig
2020-08-27 15:49:33 +02:00
Yana De Pauw
5718d78ab5 72751: Remove log.info line from builder 2020-08-27 15:09:44 +02:00
Yana De Pauw
e25cea2bb0 72750: Finalize Delete eperson: workflow 2020-08-27 15:00:11 +02:00
Tim Donohue
44fc6922c3 Add action to auto-label PRs with merge conflicts 2020-08-26 12:16:40 -05:00
Tim Donohue
344ec6e0e0 Merge pull request #2858 from atmire/w2p-71734_sitemaps
DS-4061 expose sitemaps and schedule automatic updates
2020-08-26 10:16:49 -05:00
Marie Verdonck
4d3fd87722 72505: Url sitemaps change - test fix 2020-08-26 15:05:18 +02:00
Pasquale Cavallo
fdc0cda30b Update pom.xml
Add comment
2020-08-26 14:27:56 +02:00
Marie Verdonck
4b86f331d4 72505: Url sitemaps fix 2020-08-26 13:52:59 +02:00
Peter Nijs
fae212d281 72517: ITs for authorization features for edit item in REST
- Fix for getItemObject() in ItemServiceImpl and CommunityServiceImpl for DELETE actions
2020-08-25 17:39:50 +02:00
Tim Donohue
58f3ae5037 Merge pull request #2691 from atmire/w2p-68820_Moving-relationships-ITs
Metadata PATCH when mixing plain text and relationship
2020-08-24 10:50:23 -05:00
Peter Nijs
d83f43f017 72516: ITs for authorization features for edit item in REST 2020-08-24 10:12:49 +02:00
Tim Donohue
c7c0c5f4bd Add CLI examples and how to change configs 2020-08-21 10:34:29 -05:00
Marie Verdonck
2f26cf7def 71752: Refactored metadatafield indexing via event > consumer 2020-08-21 16:07:07 +02:00
jonas-atmire
d32c32e4ab Additional checkstyle fixes + part of LGTM fix 2020-08-21 10:34:59 +02:00
Tim Donohue
0cfd4855ac Merge pull request #2915 from atmire/w2p-72215_metadataimport-email-parameter
[Issue: 2822] Metadata import email parameter changes
2020-08-20 16:37:55 -05:00
Yana De Pauw
7d793ec2d9 70906: Implement community feedback 2020-08-20 17:23:56 +02:00
jonas-atmire
1773b40acb Checkstyle fix 2020-08-20 14:53:31 +02:00
jonas-atmire
899f04c5ed Additional metadatafield related to the cookie preferences 2020-08-20 13:06:02 +02:00
Tim Donohue
aea90046b4 Merge pull request #2929 from ferthalangur/handle-server
Update start-handle-server
2020-08-19 12:02:59 -05:00
Samuel
5eaee53c6b taskid 72455 Cookie Preferences per account - feedback 2020-08-19 15:16:59 +02:00
jonas-atmire
1947b48a4b Fixing checkstyle warnings 2020-08-19 09:09:26 +02:00
Peter Nijs
1e19c9e1ab 72492: Implement authorization features for edit item in REST 2020-08-18 18:24:48 +02:00
Yana De Pauw
3f4015e291 72494: Scripts and processes: Export script output 2020-08-18 15:53:36 +02:00
Yana De Pauw
f995007511 Revert "managed context"
This reverts commit fd22cfe7da.
2020-08-18 15:51:56 +02:00
Yana De Pauw
7c8270f1c3 Revert "[Task 72494] added Context.Mode.MANAGED to all contexts in the RestDSpaceRunnableHandler"
This reverts commit eb79a859e0.
2020-08-18 15:46:55 +02:00
Raf Ponsaerts
4389fa33c6 [Task 72498] added javadocs 2020-08-18 11:57:15 +02:00
Raf Ponsaerts
df252c40f8 [Task 72546] bugfix on the author entries test 2020-08-18 10:50:02 +02:00
Raf Ponsaerts
40e3ae4887 [Task 72546] created tests that involve the fullprojection for various endpoints 2020-08-17 14:39:13 +02:00
Marie Verdonck
3164be125e 72505: sitemaps config feedback applied & changed base url of sitemap_index files to ui.url 2020-08-17 11:28:39 +02:00
Kevin Van de Velde
b3413b1e2b Attempt to get the tests to work for the deletion of workspaceitems 2020-08-14 16:45:47 +02:00
Kevin Van de Velde
ccca5ded9f Merge remote-tracking branch 'upstream/main' into DS-4443_delete-solr-record-on-workspaceitem-deletion 2020-08-14 16:14:26 +02:00
Raf Ponsaerts
67d04b2254 [Task 72498] implemented the Sort option for the Process Search and added tests 2020-08-14 15:26:04 +02:00
Yana De Pauw
df06b330fd 72494: Scripts and processes: Export script output 2020-08-14 13:54:10 +02:00
Raf Ponsaerts
63ca007dc2 [Task 72503] added the default Anon READ policy for the site object 2020-08-14 13:15:51 +02:00
Rob Jenson
c7ecfdbc7b Update start-handle-server
start-handle-server will not start if handle-server terminated abnormally (including system restart). Case error in the line to remove stale lock file.
2020-08-14 06:05:17 -04:00
Pasquale Cavallo
55901fe1b9 Use unicode in char separated files import 2020-08-14 11:20:15 +02:00
Raf Ponsaerts
eb79a859e0 [Task 72494] added Context.Mode.MANAGED to all contexts in the RestDSpaceRunnableHandler 2020-08-14 11:11:38 +02:00
Yana De Pauw
fd22cfe7da managed context 2020-08-14 10:58:30 +02:00
Yana De Pauw
26935f9d23 intermittent commit 2020-08-14 10:15:06 +02:00
Samuel
e1fb87773c taskid 72455 Cookie Preferences per account 2020-08-13 20:11:32 +02:00
Peter Nijs
fa2d28bb26 72492: Implement authorization features for edit item in REST 2020-08-13 17:02:17 +02:00
Pasquale Cavallo
fe6f51d246 Improve Java on ArXivImportMetadataSourceServiceImpl 2020-08-13 17:01:25 +02:00
Pasquale Cavallo
2ef44b1587 lof exception in SimpleXPathMetadataContributor 2020-08-13 16:35:21 +02:00
Pasquale Cavallo
21a31a910b Update tests 2020-08-13 16:30:43 +02:00
Pasquale Cavallo
5a8311189b add comments in endnote 2020-08-13 15:30:47 +02:00
Pasquale Cavallo
9051b54259 add exception to logger 2020-08-13 15:23:04 +02:00
Pasquale Cavallo
01dac23829 Javadoc and minor changes 2020-08-13 15:19:18 +02:00
Raf Ponsaerts
4c605cfff3 [Task 72498] rewrote ProcessQueryParameterContainer logic to have a map instead of set variables 2020-08-13 12:19:11 +02:00
Yana De Pauw
705b2b544f Delete eperson when in workflow 2020-08-13 10:25:06 +02:00
Raf Ponsaerts
68389c1863 [Task 72498] added the searchByProperty endpoint on the Process endpoints 2020-08-13 09:15:26 +02:00
Pasquale Cavallo
052e775bc5 Fix conflict on live import 2020-08-12 16:48:38 +02:00
Pasquale Cavallo
c733576f50 Fix conflict 2020-08-12 15:37:51 +02:00
Pasquale Cavallo
6db52f37fd Add javadoc and comment 2020-08-12 15:15:49 +02:00
Marie Verdonck
735c3bc791 71752: disallow combination exactName and any of query/schema/element/qualifier query params in /byFieldName search endpoint 2020-08-12 13:47:33 +02:00
Marie Verdonck
75ebc887cc 71752: /metadatafield/<exactMdString> replace with byfieldName?exactName endpoint + tests 2020-08-12 13:47:33 +02:00
Marie Verdonck
9dae6a9579 71752: Reindex metadatafields on create/update/delete + tests 2020-08-12 13:47:33 +02:00
Marie Verdonck
c046a1c8f3 71752: tests for MetadataFieldIndexFactoryImpl 2020-08-12 13:47:33 +02:00
Marie Verdonck
fdef69b6da 71752: constants for field names; code cleanup 2020-08-12 13:47:33 +02:00
Marie Verdonck
1aacdd2538 71752: endpoint metadatafield/name/{metadata-field-full-name} + tests added &
fix for search byFieldName in mdFields with query param starting with element or qualifier
2020-08-12 13:47:33 +02:00
Marie Verdonck
036e31c38d 71752: ITs for /metadatafields/search/byFieldName endpoint &
indexed MetadataFields now accessible to anon group & checkstyle
2020-08-12 13:46:54 +02:00
Marie Verdonck
3629454ec0 71752: Metadafield search byFieldName (by solr indexing mdFields) 2020-08-12 13:46:54 +02:00
Raf Ponsaerts
ec76371456 [Task 72430] applied feedback on the filename for MetadataExport 2020-08-12 10:31:16 +02:00
Pasquale Cavallo
57ae7ee7f0 Merge branch 'main' into D4CRIS-960 2020-08-11 18:13:33 +02:00
Raf Ponsaerts
cdc1d3b071 [Task 72232] added javadoc 2020-08-11 16:04:03 +02:00
Raf Ponsaerts
41b862cdd5 [Task 72487] addressed feedback regarding builders in CSVMetadataImportReferenceIT and cleared up CsvImportIT to be more descriptive 2020-08-11 15:53:39 +02:00
Pasquale Cavallo
1f1bd9ee81 Merge branch 'main' into DS-4515_submit-external-source 2020-08-11 15:16:44 +02:00
Raf Ponsaerts
5ee989c692 Merge remote-tracking branch 'dspace/main' into w2p-72215_metadataimport-email-parameter 2020-08-11 13:57:56 +02:00
jonas-atmire
40ec84d440 Remove the ignore annotation from the CurationTest 2020-08-11 11:21:50 +02:00
Yana De Pauw
435235abe4 Merge remote-tracking branch 'upstream/main' into w2p-72472_Delete-eperson 2020-08-11 10:30:04 +02:00
Raf Ponsaerts
240b327bb3 [Task 72232] altered email param usage for curation scripts when being called from cli or rest 2020-08-11 09:42:07 +02:00
Yana De Pauw
9fa1b78e2e 72450: AdministratorOfFeature: fixes 2020-08-10 15:51:04 +02:00
Yana De Pauw
0d5f5174c0 fix build issue 2020-08-10 10:51:47 +02:00
Yana De Pauw
d61f278167 Merge remote-tracking branch 'upstream/main' into feedback-processing 2020-08-10 09:31:56 +02:00
Yana De Pauw
0f90b8a871 fix typo in javadocs 2020-08-10 09:31:37 +02:00
Marie Verdonck
b4e64e5bf3 71738: Sitemap scheduler with annotations 2020-08-07 17:10:32 +02:00
Yana De Pauw
14f44386f7 72428: Update java docs 2020-08-07 16:52:22 +02:00
Kevin Van de Velde
483ec64ce0 [Issue: 2821] Metadata-export adding file name extension 2020-08-07 13:47:20 +02:00
Marie Verdonck
24534f943e Builders moved fixes 2020-08-07 12:36:12 +02:00
Yana De Pauw
0e5263e06f Fix to tests 2020-08-07 11:16:24 +02:00
Marie Verdonck
f0644f5b6b Id fix most popular items site wide 2020-08-07 10:30:54 +02:00
Marie Verdonck
fbba2302b6 Null check for dso handle 2020-08-07 10:30:54 +02:00
Marie Verdonck
94e3d3df68 Null checks for inconsistent stat data points 2020-08-07 10:30:54 +02:00
Marie Verdonck
485800a79e 71424: Label always on UsageReportPoint for UI &
Tests fixed by adding null check on targetId in EvaluatorPlugins
2020-08-07 10:30:54 +02:00
Marie Verdonck
5c7541a283 71214: self link for /statistics/usagereport endpoint 2020-08-07 10:30:54 +02:00
Marie Verdonck
9694858018 71424: permission check back to EvaluatorPlugin, exception message fix 2020-08-07 10:30:54 +02:00
Marie Verdonck
f66064f023 71424: endpoint methods moved to StatisticsRestRepository 2020-08-07 10:30:54 +02:00
Marie Verdonck
9c16b743f8 71214: checkstyle 2020-08-07 10:30:54 +02:00
Marie Verdonck
af16704b89 71214: Usage report search tests & Config for non-sharded stat solr 2020-08-07 10:30:54 +02:00
Marie Verdonck
6c68d58c90 71214: Search Usage reports endpoint & global site usage report &
exception changes, todo: search usage report endpoint tests
2020-08-07 10:30:54 +02:00
Marie Verdonck
e2d2681816 71214: Usage reports authorization + tests (need read access on dso) 2020-08-07 10:30:54 +02:00
Marie Verdonck
1bf46bca89 71214: TopCities & TopCountries usage report tests 2020-08-07 10:30:54 +02:00
Marie Verdonck
2b0a3664ca 71214: checkstyle & javadoc 2020-08-07 10:30:21 +02:00
Marie Verdonck
16df8f38f9 71214: checkstyle & Tests for TotalDownloads usage report 2020-08-07 10:30:21 +02:00
Marie Verdonck
619d4de3ad 71214: Test Fix & Usage Reports First set of Tests (TotalVisits & TotalVisitsPerMonth) 2020-08-07 10:30:21 +02:00
Marie Verdonck
d603ddf407 71214: - Usage Reports TotalVisitPerMonth fixed (facet works with range not date any more)
- settable facetMinCount to get month points with no views
- TotalDownloads added
2020-08-07 10:30:21 +02:00
Marie Verdonck
161fb9b518 71214: Usage Reports WIP:
- TotalVisits, TopCountries & TopCities done
 - TotalVisitsPerMonth Wip
 - TODO: TotalDownloads & IT
2020-08-07 10:30:21 +02:00
Tim Donohue
d1ee942bd4 Merge pull request #2911 from atmire/issue-2800-workflowgroup-collection-links
[Issue 2800] workflowgroup collection links
2020-08-06 15:52:12 -05:00
Yana De Pauw
eef3f07b92 Fix LGTM issues 2020-08-06 18:41:24 +02:00
Yana De Pauw
21e3d65ff5 Merge remote-tracking branch 'upstream/main' into DS-626 2020-08-06 17:25:07 +02:00
Yana De Pauw
b7a24fc261 72428: Metadata PATCH: feedback processing 2020-08-06 17:16:22 +02:00
Marie Verdonck
a1c9bc9061 Collection and Community Builder moved fix 2020-08-06 16:10:07 +02:00
Raf Ponsaerts
69b722a97f [Task 72430] removed the metadata export file parameter for the REST api 2020-08-06 15:56:12 +02:00
Tim Donohue
fe9a7e6a96 Merge pull request #2791 from 4Science/CST-3091
DS-4514 Start new submission by uploading a Bibliographic File (using Live Import)
2020-08-06 08:45:38 -05:00
Marie Verdonck
cff1d0a69a poolsize fix 2020-08-06 14:22:26 +02:00
Marie Verdonck
5aa01787a7 Merge branch 'dspace-origin-master' into w2p-71734_sitemaps 2020-08-06 14:20:33 +02:00
Marie Verdonck
00166862ea Revert whitespace changes 2020-08-06 14:03:48 +02:00
Marie Verdonck
3d087aa184 72426: Sitemap cron schedule configurable in dspace.cfg 2020-08-06 13:52:43 +02:00
Raf Ponsaerts
61d44087fd [Task 72222] simplified the for loop in halResource to use java8 stream 2020-08-06 12:25:11 +02:00
Raf Ponsaerts
9de632d659 Merge remote-tracking branch 'dspace/main' into issue-2800-workflowgroup-collection-links 2020-08-06 11:22:25 +02:00
Raf Ponsaerts
362064f76f [Task 72215] fixing issues after merge 2020-08-06 11:10:00 +02:00
Raf Ponsaerts
9f3c8f6519 Merge remote-tracking branch 'dspace/main' into w2p-72215_metadataimport-email-parameter
Conflicts:
	dspace-api/src/test/java/org/dspace/app/bulkedit/MetadataImportTest.java
	dspace-api/src/test/java/org/dspace/app/csv/CSVMetadataImportReferenceIT.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/csv/CsvImportIT.java
2020-08-06 11:09:48 +02:00
Danilo Di Nuzzo
70c861a9e9 fix builder import 2020-08-06 10:33:43 +02:00
ddinuzzo
5e30cbe0eb Merge branch 'main' into draft_vocabulary 2020-08-06 10:20:30 +02:00
Marie Verdonck
4e48ff8de1 72387: Workflow minor fixes 2020-08-06 10:12:28 +02:00
Tim Donohue
2027b03a8d Merge pull request #2909 from atmire/w2p-71899_Support-multiple-dsoType-values
Support multiple dsoType values in discovery
2020-08-05 09:45:24 -05:00
Marie Verdonck
7677bd92e1 checkstyle 2020-08-05 16:03:59 +02:00
Marie Verdonck
0f069cc14c 72348: Fixes so getMetadata returns implicit virtual metadata 2020-08-05 15:16:54 +02:00
Marie Verdonck
1a818b304c 72348: Test getMetadata implicit virtual metadata 2020-08-05 15:12:19 +02:00
Samuel
94394d8e59 taskid 71899 Support multiple dsoType values - add typedocs 2020-08-05 12:25:05 +02:00
Mark H. Wood
d21b019c71 [DS-2670] Fix concompliance with new format rules. 2020-08-04 15:21:27 -04:00
Mark H. Wood
d84795b54f Merge branch 'main' into DS-2670 2020-08-04 15:17:11 -04:00
Tim Donohue
5eacfc07f3 Merge pull request #2897 from mwoodiupui/#2893
#2893 Move builders from dspace-server-webapp to dspace-api.
2020-08-04 13:43:07 -05:00
Mark H. Wood
e1ad520c86 Merge remote-tracking branch 'upstream/main' into #2893 2020-08-04 13:08:45 -04:00
Tim Donohue
91fd47648b Merge pull request #2910 from atmire/w2p-71855_The--authz-authorizations-search-object-endpoint-sometimes-ignores-the-feature-param
The /authz/authorizations/search/object endpoint sometimes ignores the feature param
2020-08-04 11:51:36 -05:00
Mark H. Wood
2a9eb2048b [DS-4110] New email template sent to a newly-registered user. 2020-08-04 12:42:01 -04:00
Pasquale Cavallo
bdcf064660 return 400 on arxiv in no record were found 2020-08-03 15:21:30 +02:00
Pasquale Cavallo
9ee5762c34 return 400 in external source if no record were found 2020-08-03 15:20:50 +02:00
Pasquale Cavallo
774e3893f9 Add fix from DS-4530 2020-08-03 14:22:48 +02:00
Mark H. Wood
87843a0edc Merge remote-tracking branch 'upstream/main' into #2893 2020-07-31 18:12:23 -04:00
Tim Donohue
c67da0b077 Merge pull request #2913 from tdonohue/fix_master_tests
(Integration Tests) Fix response checks to no longer expect specific error messages
2020-07-31 16:57:12 -05:00
Mark H. Wood
dc198bae00 #2893 Fix new class that used old package for Builders. 2020-07-31 16:52:59 -04:00
Mark H. Wood
ea995d66aa Merge remote-tracking branch 'upstream/main' into #2893 2020-07-31 16:50:27 -04:00
Tim Donohue
9138dfea0e Fix response checks to no longer check for specific error messages 2020-07-31 15:38:25 -05:00
Mark H. Wood
442f563fcc #2893 Move several explicit dependency versions up to dependencyManagement in parent. 2020-07-31 16:30:02 -04:00
Tim Donohue
1301e43cee Merge pull request #2820 from atmire/w2p-71513_Curation-tasks-scripts-and-processes
Curation tasks using the scripts and processes functionality
2020-07-31 14:14:13 -05:00
Tim Donohue
c44613a3df Merge pull request #2908 from tdonohue/shibboleth_redirect_trusted_url
Ensure ShibbolethRestController only redirects to trusted URLs after authentication
2020-07-31 10:57:36 -05:00
Pasquale Cavallo
e35084cf23 rollback dspace.cfg changes 2020-07-31 17:13:18 +02:00
Pasquale Cavallo
1406a4c2e6 Update pom.xml, ArXivService.java, and PubmedService.java 2020-07-31 17:08:23 +02:00
Tim Donohue
f06c532662 Merge pull request #2745 from atmire/w2p-70333_remove-relationshiptypeid-from-relationship-endpoints
Removed the RelationshipTypeId from Relationship endpoints
2020-07-31 10:05:36 -05:00
Tim Donohue
1758cac23a Merge pull request #2667 from atmire/configure-missing-search-configurations
Entities Configure search configurations matching name
2020-07-31 10:03:24 -05:00
Tim Donohue
cf2f50dfe5 Add a SuppressWarnings annotation for LGTM as it doesn't detect that we fixed this. 2020-07-31 10:00:08 -05:00
Tim Donohue
58c86e2c9e Merge pull request #2728 from TexasDigitalLibrary/DS-4211
DS-4211: Set Item iterator to emptyIterator() so that it's never null (7.x)
2020-07-31 09:20:10 -05:00
Raf Ponsaerts
7ea3935709 [Task 72215] minor cleanup 2020-07-31 11:42:45 +02:00
Raf Ponsaerts
fd63d6216e [Task 72215] moved CSVMetadataImportreferenceIT to the dspace-api module and fixed tests 2020-07-31 11:39:22 +02:00
Andrea Bollini
ed58d44329 Use a more meaningful variable name 2020-07-30 18:02:53 +02:00
Andrea Bollini
bd6982bb15 Describe the structure of the map fields 2020-07-30 17:53:39 +02:00
Raf Ponsaerts
8f384deca7 [Task 72215] made sure that the script rest calls in tests are single threaded and fixed CsvImportIT tests 2020-07-30 15:58:54 +02:00
Ben Bosman
95b5cabae2 trailing whitespace 2020-07-30 09:06:53 +02:00
Mark H. Wood
a27355f79a #2893 dspace/modules/additions also needs new dependencies, updates. 2020-07-29 17:21:55 -04:00
Mark H. Wood
8ee4b7ab9d Address questions about dummy methods. This breaks tests. #2893
Merge more from dspace-server-webapp to make tests work again.
Tidy up XML layout.  Improve alignment of declared to actual dependencies.
2020-07-29 12:48:31 -04:00
Mark H. Wood
ecd8a88633 #2893 More proper use of Builders in demo test suite. 2020-07-29 12:44:09 -04:00
Mark H. Wood
e3bc495198 #2893 Tabs to spaces. 2020-07-29 12:41:16 -04:00
Ben Bosman
55bcecc21b Merge remote-tracking branch 'community/main' into w2p-68820_Moving-relationships-ITs
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/builder/WorkspaceItemBuilder.java
2020-07-29 18:03:03 +02:00
Marie Verdonck
1ba6a74887 72351: sitemaps path to config + in tests &
script extension to delete sitemaps dir > called at end of tests &
test for malicious file traversal
2020-07-29 17:56:48 +02:00
Tim Donohue
fa3e7147c4 Merge pull request #2907 from ilittle-cnri/main
Bump Handle to version 9.3.0 final.
2020-07-29 10:30:58 -05:00
Pasquale Cavallo
4c1e4432d1 Merge remote-tracking branch 'refs/remotes/origin/main'
Conflicts:
	dspace-api/src/main/java/org/dspace/submit/lookup/ArXivService.java
	dspace-api/src/main/java/org/dspace/submit/lookup/PubmedService.java
2020-07-29 15:14:07 +02:00
Pasquale Cavallo
d2e969ffee Merge remote-tracking branch 'refs/remotes/origin/main' 2020-07-29 15:06:17 +02:00
Samuel
e37600d64a taskid 71855 The /authz/authorizations/search/object endpoint sometimes ignores the feature param - feedback 2020-07-29 14:47:23 +02:00
Samuel
76d441b53f taskid 71855 The /authz/authorizations/search/object endpoint sometimes ignores the feature param 2020-07-29 13:49:20 +02:00
Raf Ponsaerts
338764b046 [Task 72222] fixed a bug with the links after the implementation of the array dynamic workflowgroup links 2020-07-29 13:00:16 +02:00
Pasquale Cavallo
107c70a6ee Add extensions supported by FileSource in Live Import 2020-07-29 12:22:22 +02:00
Samuel
88e1ecc0a9 taskid 71899 Support multiple dsoType values 2020-07-29 10:24:54 +02:00
Raf Ponsaerts
8df7e572b5 [Task 72215] small bugfix in MetadataImport scripts 2020-07-29 09:05:13 +02:00
kshepherd
202368c759 Merge pull request #2903 from tdonohue/lgtm_fixes
Add error logging & fix "Information exposure through a stack trace" error reported by LGTM
2020-07-29 12:09:04 +12:00
kshepherd
1925d0ccc3 Merge pull request #2904 from tdonohue/lgtm_fixes_2
Fixes for several LGTM reported severe bugs
2020-07-29 12:06:24 +12:00
Pasquale Cavallo
afd6436c5c Clean code 2020-07-29 01:44:25 +02:00
Pasquale Cavallo
25bed852d3 Add comment, rewrite ArxivIdMetadataContributor 2020-07-29 01:19:20 +02:00
Tim Donohue
441043587b Ensure ShibbolethRestController only redirects to trusted URLs 2020-07-28 12:55:54 -05:00
Ian Little
ddb7057973 Bump Handle to version 9.3.0 final. 2020-07-28 13:51:09 -04:00
Raf Ponsaerts
bbdc47fbbf [Task 72215] removed the eperson flag from the REST metadata import script whilst leaving cli unaltered 2020-07-28 16:16:05 +02:00
Tim Donohue
78f837c052 Use equals() for object equality checks 2020-07-27 17:09:49 -05:00
Tim Donohue
645a1800bb Fix potentially unsafe external link 2020-07-27 17:09:48 -05:00
Tim Donohue
93903de1c5 Fix possible int overflow by converting to long before multiplication 2020-07-27 17:09:48 -05:00
Tim Donohue
79e4e3b497 Escape special chars in filename which includes user input 2020-07-27 17:09:25 -05:00
Tim Donohue
c323b989d2 Escape any HTML in user provided param. 2020-07-27 14:42:56 -05:00
Tim Donohue
53df081422 Fix possible XXE attacks by disabling DTD parsing for external service requests. 2020-07-27 13:13:25 -05:00
Tim Donohue
b006b84039 Use object's reported handle instead of user provided handle 2020-07-27 12:08:47 -05:00
Tim Donohue
294bb02193 Fix HTTP Response splitting by validating URL 2020-07-27 12:00:06 -05:00
Tim Donohue
cf7daef431 Set invalidation cookie to "secure" just to avoid LGTM warning 2020-07-27 11:12:18 -05:00
Tim Donohue
dcc651945d Throw errors when possible "zip slip" detected. 2020-07-27 11:09:26 -05:00
Tim Donohue
667a362b25 Add keyword "fixes" as a reminder. Remove JIRA 2020-07-27 10:44:07 -05:00
Tim Donohue
9ae124bef0 Revert changes to StatelessAuthenticationFilter. It is supposed to be a 401 error! 2020-07-24 17:09:41 -05:00
Tim Donohue
5c54554cd9 Fix improper AuthorizeException & more info exposure errors 2020-07-24 16:33:07 -05:00
Tim Donohue
c3c683e23b Fix two other info exposure through stack trace errors 2020-07-24 16:32:31 -05:00
Mark H. Wood
7f0a6771bc #2893 Rework a dspace-api IT to use Builders as a demo. 2020-07-24 17:13:01 -04:00
Tim Donohue
eb8f937595 Limit the errors we log 2020-07-24 15:27:01 -05:00
Tim Donohue
0382f8f1e1 Merge pull request #2867 from atmire/w2p-71853_Authorizations-endpoint-should-also-recognize-Authorization-and-X-On-Behalf-Of-headers
DS-4527: Authorizations endpoint and X-On-Behalf-Of headers
2020-07-24 11:39:26 -05:00
Mark H. Wood
f6a0d76094 #2893 Discard un-needed custom LGTM build script. 2020-07-24 11:19:02 -04:00
Mark H. Wood
20a3d94a1b #2893 Re-enable test running in Travis; document changes to how-to-test. 2020-07-24 10:53:34 -04:00
Mark H. Wood
bc4663b783 #2893 try LGTM with default command again 2020-07-24 10:39:23 -04:00
Mark H. Wood
f2ad45d25d Merge branch 'main' into #2893 2020-07-24 10:38:06 -04:00
Mark H. Wood
46dc547db8 #2893 Reconfigure test building on LGTM 2020-07-24 10:33:26 -04:00
Mark H. Wood
1ec7c38675 Use skipTests not maven.test.skip so tests always built; fix dependencies. #2983 2020-07-23 21:15:25 -04:00
Tim Donohue
9a9253e091 Merge pull request #2830 from atmire/w2p-71701_Missing-parents-link-bitstream-bundle-item
Parent links for bitstream->bundle->item
2020-07-23 12:53:41 -05:00
Mark H. Wood
ca31be2859 #2983 More Checkstyle errors 2020-07-23 13:30:51 -04:00
Mark H. Wood
0076e6b37b Clean up a lot of ErrorProne and Checkstyle warnings. #2983
So I can see what else is wrong.
2020-07-23 13:00:36 -04:00
Mark H. Wood
b14f52313e Set JAVA_HOME trying to make LGTM work as UNdocumented. 2020-07-23 10:32:10 -04:00
jonas-atmire
7a269f3460 Curate.cfg properties cleanup based on PR feedback - https://github.com/DSpace/DSpace/pull/2820 2020-07-23 10:00:51 +02:00
jonas-atmire
836876508f Addition of explanation to tests + Small comment update 2020-07-23 08:59:10 +02:00
Mark H. Wood
c1139ff0a3 Trim lgtm build command some more 2020-07-22 15:42:13 -04:00
Mark H. Wood
453e1c9c91 Yet another attempt to understand undocumented LGTM build command(s) 2020-07-22 15:28:12 -04:00
Mark H. Wood
ef353a5f44 Try again to make LGTM run custom command 2020-07-22 15:22:05 -04:00
Mark H. Wood
daed71b91b Add shebang to lgtm-build in attempt to make it work. 2020-07-22 15:07:25 -04:00
Mark H. Wood
459dc2163b Fix bad LGTM default that suppresses test JARs. 2020-07-22 12:02:15 -04:00
Yana De Pauw
e36e477be4 Fixes due to merge 2020-07-22 16:35:18 +02:00
Yana De Pauw
b1672af5c3 Merge remote-tracking branch 'upstream/main' into DS-626 2020-07-22 16:35:11 +02:00
Mark H. Wood
9d6c8891ec #2893 Rebase on current main, patch recently-added class, tidy documentation. 2020-07-22 09:58:23 -04:00
Mark H. Wood
dd9c0b9999 #2893 Move builders from dspace-server-webapp to dspace-api. 2020-07-22 08:50:20 -04:00
KevinVdV
239bc5271d [Issue: 2800] Put dynamic workflowgroup links on Collections in an array 2020-07-22 11:31:51 +02:00
Tim Donohue
15d2e16ff4 Merge pull request #2828 from ilittle-cnri/master
[DS-4205] Bump Handle to version 9.3.0-SNAPSHOT
2020-07-21 17:10:43 -05:00
Tim Donohue
216bd1603a Added some inline comments to POM 2020-07-21 17:06:24 -05:00
Mykhaylo
76d2e06710 added Logger 2020-07-20 17:53:07 +02:00
Mykhaylo
575ce02077 update comments 2020-07-20 15:32:32 +02:00
Mykhaylo
5cdc55163a Implement community feedbacks 2020-07-20 13:06:46 +02:00
Andrea Bollini
b232def06e Keep the message rethrowing the exception 2020-07-18 18:26:43 +02:00
Andrea Bollini
769dd064d0 Add support and test for locales on vocabularies 2020-07-18 17:30:20 +02:00
Andrea Bollini
9863b1c6d5 Add link to the vocabularyEntryDetails search methods from the root 2020-07-18 16:07:04 +02:00
Andrea Bollini
07ffb5fbad Merge branch 'main' of https://github.com/DSpace/DSpace into draft_vocabulary 2020-07-17 19:39:18 +02:00
Andrea Bollini
8fd328855a code cleanup and fix for project in vocabulary entry details 2020-07-17 17:07:20 +02:00
Tim Donohue
6b3bd4d4b2 Merge pull request #2862 from bme-omikk/DS-4534_7x
DS-4534 fix for Anonymous as a sub-group.
2020-07-17 09:45:17 -05:00
Tim Donohue
fb9633826c Merge pull request #2386 from AlexanderS/ds4200
[DS-4200] IPMatcher: Fix netmask conversion
2020-07-17 09:40:29 -05:00
Tim Donohue
f26cfb6fcc Merge pull request #2831 from atmire/w2p-71690_ip-authentication-basics
beta4 - IP Authentication Support
2020-07-16 17:18:18 -05:00
Tim Donohue
70e550e999 Update and rename .github/workflows/pull_request_opened.yml to .github/disabled-workflows/pull_request_opened.yml 2020-07-16 14:19:15 -05:00
Istvan Vig
314fa76641 DS-4534 fix for Anonymous as a sub-group. 2020-07-16 14:50:08 +02:00
Tim Donohue
8f700cf5ce Update issue templates 2020-07-15 15:03:28 -05:00
Tim Donohue
d260f5e126 Correct comment 2020-07-15 14:57:57 -05:00
Tim Donohue
2271bb7a4e Merge pull request #2857 from DSpace/tdonohue-new-PR-action
Auto Assign new Pull Requests to "main" branch to the PR creator
2020-07-15 14:51:58 -05:00
Tim Donohue
7a3d0a4db0 Merge pull request #2861 from DSpace/tdonohue-issue-action
Automatically add new Issues to "DSpace Backlog" project board
2020-07-15 14:51:36 -05:00
Tim Donohue
626215af42 Create issue_opened.yml 2020-07-15 14:42:20 -05:00
Tim Donohue
16c47e7e9e Rename new_pull_request.yml to pull_request_opened.yml 2020-07-15 14:41:18 -05:00
Tim Donohue
afda65db72 Update configuration slightly 2020-07-15 14:40:20 -05:00
Samuel
109e75de40 taskid 71853 Authorizations endpoint should also recognize Authorization and X-On-Behalf-Of headers 2020-07-15 18:28:52 +02:00
Marie Verdonck
d64d39f536 Merge branch 'dspace-origin-master' into w2p-71734_sitemaps
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/RootRestResourceControllerIT.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/ShibbolethRestControllerIT.java
2020-07-15 15:53:21 +02:00
Marie Verdonck
c911a0f79a 71859: Endpoint path sitemaps changed 2020-07-15 13:27:55 +02:00
Tim Donohue
6f416d2256 Create new_pull_request.yml 2020-07-14 17:07:03 -05:00
Tim Donohue
2ed6d40bde Create initial issue templates
Starting with just a bug & feature request template
2020-07-14 16:41:29 -05:00
Tim Donohue
463d6fb5d4 Merge pull request #2823 from DSpace/dependabot/maven/commons-beanutils-commons-beanutils-1.9.4
Bump commons-beanutils from 1.9.3 to 1.9.4
2020-07-14 12:21:18 -05:00
Tim Donohue
34db84f472 Merge pull request #2854 from tdonohue/rename_master_to_main
Replace all references to `master` with `main`
2020-07-14 10:52:05 -05:00
Tim Donohue
6d6630a665 Fix another link. Replace link to issue tracker 2020-07-14 09:49:51 -05:00
Tim Donohue
61bed89a0c Rename master to main. Rename whitelist to allow list. 2020-07-14 09:44:14 -05:00
Tim Donohue
88fbf33a8b Merge pull request #2784 from 4Science/DS-4466_new
DS-4466 REST API should obtain language settings from Client
2020-07-13 11:38:26 -05:00
Raf Ponsaerts
f492415bcc [Task 71780] added support for the person schema in the csv import and added a test for it 2020-07-13 11:48:21 +02:00
Raf Ponsaerts
b65ed11bdc [Task 71757] added configurable max amount on items and reverted testing change 2020-07-10 09:12:13 +02:00
Raf Ponsaerts
048381ef87 [Task 71757] added the virtual metadata looping and item updating in the uodateItemsInRelationship method 2020-07-09 16:01:22 +02:00
Andrea Bollini
e0f1991200 Merge pull request #157 from 4Science/vocabulary_withoutparams
Refactor the ChoiceAuthority to remove the unnecessary dependency from the field and collection
2020-07-09 13:28:14 +02:00
Marie Verdonck
d0a7104e9f 71738: Automatic cron job for sitemaps 2020-07-09 10:52:05 +02:00
Marie Verdonck
0480b65219 71737: Sitemap REST IT 2020-07-08 19:10:39 +02:00
Marie Verdonck
894738a682 71736: Changes to sitemap contents 2020-07-08 15:44:58 +02:00
Marie Verdonck
56be1bbe74 71734: Sitemap REST controller 2020-07-08 14:19:54 +02:00
Raf Ponsaerts
62cfd2d5bd [Task 71761] applied feedback to the AnonymousAdditionalAuthorizationFilter and IT 2020-07-08 13:40:47 +02:00
Kristof De Langhe
3e33a866c6 71701: Checkstyle fixes 2020-07-08 12:59:36 +02:00
Kristof De Langhe
3243f19127 71701: Additional parent link tests for Bitstream and Bundle + JavaDocs 2020-07-08 12:59:36 +02:00
Kristof De Langhe
dfe33d273e 71701: item link on BundleRest + embedded parent tests for bundle and bitstream 2020-07-08 12:59:36 +02:00
Raf Ponsaerts
9184189bb0 [Task 71690] added javadoc for the tests and config 2020-07-08 10:32:53 +02:00
Raf Ponsaerts
4e129cf841 [Task 71753] implemented feedback and added tests for the ip authentication functionality 2020-07-08 10:23:08 +02:00
Pasquale Cavallo
493ab0f496 Add license header 2020-07-08 01:49:08 +02:00
Pasquale Cavallo
3f8e680557 Add comments 2020-07-08 01:09:40 +02:00
Pasquale Cavallo
dc958c9d67 Add support for multiple authors in *sv, complete implementation for RIS
and Endnote, complete IT
2020-07-08 00:06:49 +02:00
Ian Little
f34f44d7e0 Bump Handle to version 9.3.0-SNAPSHOT, now coming form CNRI maven repository. Requires bumping Jetty version also. 2020-07-07 09:52:38 -04:00
Raf Ponsaerts
e52e880045 [Task 71690] implemented the IPAuthenticationFilter 2020-07-07 14:39:40 +02:00
Pasquale Cavallo
b7949a14d7 Add endnote support and (partial) test 2020-07-06 16:35:48 +02:00
Pasquale Cavallo
af38c36bdb add JavaDoc to LiveImportDataProvider public method 2020-07-06 11:33:52 +02:00
Pasquale Cavallo
3c349cb70c RIS, CSV and TSV live import implementation 2020-07-06 11:16:08 +02:00
Tim Donohue
41dbbfedd4 Fix bugs and failed test 2020-07-03 15:16:45 -05:00
Tim Donohue
fcdee50334 Fixes to error handling
Log all errors & provide generic messages in response
2020-07-03 10:55:52 -05:00
dependabot[bot]
b524c36a53 Bump commons-beanutils from 1.9.3 to 1.9.4
Bumps commons-beanutils from 1.9.3 to 1.9.4.

Signed-off-by: dependabot[bot] <support@github.com>
2020-07-02 19:22:27 +00:00
Tim Donohue
cc7a6c30fd [maven-release-plugin] prepare for next development iteration 2020-07-02 14:22:06 -05:00
Tim Donohue
dc2151209a [maven-release-plugin] prepare release dspace-7.0-beta3 2020-07-02 14:21:56 -05:00
Andrea Bollini
675c975d29 Use a more explicit name for the storeAuthorityInMetadata method 2020-07-02 21:11:56 +02:00
Mykhaylo
861170a179 added test and fix getLocale 2020-07-02 19:55:53 +02:00
Andrea Bollini
18bc3e1fcb Refactor the ChoiceAuthority to remove the unnecessary dependency from the field and collection 2020-07-02 19:54:37 +02:00
Tim Donohue
8fd2710cdb Merge pull request #2812 from 4Science/DS-3679
DS-3679 E-Mail Configuration not valid if mail.server.username is not specified
2020-07-02 09:50:31 -05:00
Pasquale Cavallo
dbde82478b remove unused code 2020-07-02 16:22:36 +02:00
Marie Verdonck
fec04568ff 71629: checkstyle & removed unused annotations 2020-07-02 15:49:18 +02:00
Pasquale Cavallo
02953eb087 Update comment and minor fix 2020-07-02 14:45:04 +02:00
Pasquale Cavallo
03ac31dc10 Exception handling 2020-07-02 12:05:50 +02:00
Pasquale Cavallo
f71866b5e3 Add comment 2020-07-02 10:30:49 +02:00
Pasquale Cavallo
b15fa7c5b0 show ids and links in response 2020-07-02 02:32:11 +02:00
Andrea Bollini
5a0844429a Add missing javadocs 2020-07-01 23:12:34 +02:00
Tim Donohue
338bb2296f Merge pull request #2783 from atmire/w2p-71342_Authorization-for-Downloads-of-restricted-Bitstreams-1
Authorization for Downloads of restricted Bitstreams: Short lived token endpoint
2020-07-01 15:39:21 -05:00
Giuseppe Digilio
e4c98b4742 Fixed issue with DSpaceControlledVocabulary getBestMatch 2020-07-01 21:34:09 +02:00
Marie Verdonck
e7b33c5fb5 71629: fix testCurate_NoOpTask 2020-07-01 17:53:06 +02:00
Pasquale Cavallo
238317bc8d Arxiv Live import integration 2020-07-01 16:50:45 +02:00
Marie Verdonck
a437cf41c3 missing license 2020-07-01 16:20:12 +02:00
Marie Verdonck
9ef83bf185 71513: -i valid dso or all check + test &
fix so that -t plugin-key instead of entire config &
Added test voor noop curate output
2020-07-01 16:20:12 +02:00
Marie Verdonck
85e31825cc 71513: test fix from adding curate script to test script definitions 2020-07-01 16:20:12 +02:00
Marie Verdonck
79c317154e 71513: ITs for curate script 2020-07-01 16:20:12 +02:00
Marie Verdonck
351363b79e 71513: spelling 2020-07-01 16:20:12 +02:00
Marie Verdonck
107a19e909 71513: small fix and script call name change 2020-07-01 16:20:12 +02:00
Marie Verdonck
a2de3c682e 71513: curation script to DSpaceRunnable 2020-07-01 16:20:12 +02:00
Andrea Bollini
fe05166252 DS-3679 fix check for blank username 2020-07-01 12:34:09 +02:00
Andrea Bollini
8c35f6d8a3 DS-3679 improved test to show the bug with auth session 2020-07-01 12:32:32 +02:00
Peter Nijs
9044daf50e 71672: Authorization for Downloads of restricted Bitstreams
- Fix checkstyle
2020-07-01 11:50:57 +02:00
Pasquale Cavallo
eb4abb7d51 Merge branch 'CST-3091' of https://github.com/4Science/DSpace into CST-3091 2020-07-01 11:00:31 +02:00
Peter Nijs
be89cc8159 71672: Authorization for Downloads of restricted Bitstreams
- Rename url parameter "token" to "authentication-token"
2020-07-01 10:59:18 +02:00
Pasquale Cavallo
cfc53c98d2 Live import minor changes + LGTM alert fix 2020-07-01 10:52:49 +02:00
Pasquale Cavallo
808c4633f1 submit external suorce partial implementation 2020-07-01 10:36:43 +02:00
Peter Nijs
f9257dad12 Merge branch 'w2p-71342_Authorization-for-Downloads-of-restricted-Bitstreams-1' into w2p-71672_Rename-token-parameter 2020-07-01 10:35:41 +02:00
Andrea Bollini
6333fdc499 Add test to check links in the vocabulary entry details and relative fix 2020-06-30 21:43:57 +02:00
Peter Nijs
d364ac6383 71654: Authorization for Downloads of restricted Bitstreams
- Short lived tokens can't be used to login, or generate other tokens
2020-06-30 18:20:06 +02:00
nwoodward
e3351c3900 set result to empty iterator 2020-06-30 10:39:39 -05:00
Tim Donohue
cc362d8449 Merge pull request #2763 from atmire/w2p-70273_create-new-registration
DS-4027: New user registration & forgot password
2020-06-30 10:26:23 -05:00
Raf Ponsaerts
2a6731297c Fixed LGTM issue with an error String 2020-06-30 10:27:47 +02:00
Raf Ponsaerts
0555644c9a [Task 71627] addressed feedback on the new registration functionaliity 2020-06-30 08:30:01 +02:00
Andrea Bollini
2271237bc6 Add javadoc for the reload method 2020-06-29 23:48:37 +02:00
Andrea Bollini
97b018e509 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4466_new 2020-06-29 23:42:32 +02:00
Andrea Bollini
a3a95a81f0 Merge branch 'master' of https://github.com/DSpace/DSpace into CST-3091 2020-06-29 23:38:16 +02:00
Tim Donohue
000b5c7d0d Merge pull request #2427 from xuejiangtao/master
remove the condition that is always 'true'
2020-06-29 15:42:06 -05:00
Tim Donohue
1e14ebbacf Merge pull request #2730 from TexasDigitalLibrary/DS-4342-7x
DS-4342 improve performance when retrieving items from a collection (7.x)
2020-06-29 15:26:56 -05:00
Andrea Bollini
cfe8954a6b Merge branch 'master' of https://github.com/DSpace/DSpace into draft_vocabulary 2020-06-29 16:18:16 +02:00
Andrea Bollini
ff1b40d859 remove unused attributes 2020-06-29 16:18:05 +02:00
Tim Donohue
b5c9c7ae87 Merge pull request #2794 from tdonohue/configure_lgtm
Configure LGTM for automated code reviews
2020-06-26 10:39:15 -05:00
Tim Donohue
22678a7ef5 Configure LGTM 2020-06-26 09:41:50 -05:00
Peter Nijs
27e733c1e8 71410: Authorization for Downloads of restricted Bitstreams
- Add test that the ePerson session salt isn't updated when requesting a short lived token
2020-06-26 14:20:06 +02:00
Raf Ponsaerts
0f433ed2ae [Task 71502] moved workspaceItemTest to the workspaceItemRestRepository 2020-06-26 11:17:40 +02:00
Raf Ponsaerts
2a63f0ff22 [Task 71502] added forceDelete method to the RelationshipService that won't check the cardinality of the relationships. Used this in the ItemService delete and added tests 2020-06-26 10:54:34 +02:00
Raf Ponsaerts
645f6b66c9 [Task 71502] implemented tests that prove that deleting an item with a relationship of min cardinality greater than 1 fails 2020-06-26 09:32:50 +02:00
Tim Donohue
a8c3965c0c Merge pull request #2760 from Micheleboychuk/DS-4042_ITs_WrongPatchRequest
DS-4042 Fix implementation and add integration test for wrong patch request to the submission endpoint
2020-06-25 13:23:10 -05:00
Andrea Bollini
322b56b422 Expose the vocabularyName to the submission form definition 2020-06-25 20:14:01 +02:00
Andrea Bollini
ba150b1ec7 Fix cleanup testenv 2020-06-25 19:26:52 +02:00
Andrea Bollini
a8234f2004 Fix vocabulary related links test in the root endpoint 2020-06-25 19:25:27 +02:00
Mykhaylo
21e96f937c added missing parameter 2020-06-25 19:09:25 +02:00
Mykhaylo
361610c73a Merge branch 'master' into DS-4042_ITs_WrongPatchRequest 2020-06-25 18:46:59 +02:00
Ben Bosman
612acbdc36 Entities features: update the item metadata on relationship create/delete also when not using REST
on update this is causing problems with the place changes
2020-06-25 18:10:16 +02:00
Andrea Bollini
42dd930060 Rename authority in controlledVocabulary, add related IT 2020-06-25 17:47:17 +02:00
Andrea Bollini
76181a6829 Restore test for authority as was before - no authorities for value pairs 2020-06-25 17:37:24 +02:00
Tim Donohue
b3ec83d3a5 Merge pull request #2764 from atmire/w2p-70213_CC-license
CC License support
2020-06-25 10:36:46 -05:00
Ben Bosman
b39facf1d1 Entities features: update the item metadata on relationship create/update/delete also when not using REST 2020-06-25 17:27:52 +02:00
Raf Ponsaerts
32a03eed36 [Task 71604] moved RegistrationRestControllerIT tests to RegistrationRestRepositoryIT and added extra cleanup 2020-06-25 16:17:36 +02:00
Ben Bosman
5ad45fe7b6 Entities features: update the item metadata on relationship create/update/delete also when not using REST 2020-06-25 15:37:02 +02:00
Pasquale Cavallo
014c623256 Manage empty or invalid files in multiple submission 2020-06-25 14:15:20 +02:00
Andrea Bollini
06f9eb521c Fix checkstyle issue 2020-06-25 14:02:00 +02:00
Pasquale Cavallo
c0b92196f3 Fix multifile import 2020-06-25 13:43:26 +02:00
Andrea Bollini
82aae2395f Remove unnecessary change in the MetadataAuthorityService 2020-06-25 13:33:06 +02:00
Andrea Bollini
1e49e5877e Fix injection to avoid issue with docker/double references 2020-06-25 12:33:37 +02:00
Pasquale Cavallo
9208879abf Update test 2020-06-25 11:57:05 +02:00
Kevin Van de Velde
8cadd10546 [CC License] Fixing checkstyle issues 2020-06-25 10:56:20 +02:00
Peter Nijs
46e760791a Merge remote-tracking branch 'community/master' into w2p-71342_Authorization-for-Downloads-of-restricted-Bitstreams-1 2020-06-25 10:16:57 +02:00
Kevin Van de Velde
8ca6064c88 [CC License] Adding search link to HAL output 2020-06-25 10:16:46 +02:00
Andrea Bollini
6b923e0cb5 Fix test - DSpaceControlledVocabulary now honor the pagination 2020-06-25 09:23:34 +02:00
Peter Nijs
9f77864cea 71410: Authorization for Downloads of restricted Bitstreams
- Add test that the ePerson session salt isn't updated when requesting a short lived token
2020-06-25 09:15:30 +02:00
Andrea Bollini
c69168b27d Fix test and final cleanup 2020-06-25 00:06:00 +02:00
Mykhaylo
f3844e63a4 Merge branch 'master' into DS-4515_submit-external-source 2020-06-24 17:01:03 +02:00
Pasquale Cavallo
ecefb1a302 Comment and minor improvements 2020-06-24 14:52:33 +02:00
Mykhaylo
f39ce1cf54 Added ITs 2020-06-24 12:37:09 +02:00
Mykhaylo
13727fb49a Added management of the parametr exact 2020-06-24 12:36:34 +02:00
Raf Ponsaerts
2b6f19f6be [Task 71440] added javadocs to SubmissionCCLicenseUrl 2020-06-24 11:14:40 +02:00
Mykhaylo
8c5dc56193 updated tests of VocabularyEntryDetails 2020-06-23 22:50:55 +02:00
Mykhaylo
b940e3d41a implemented search method top 2020-06-23 22:48:54 +02:00
Mykhaylo
ed5ea81241 added implementations for link child and parent repositories 2020-06-23 22:45:54 +02:00
Peter Nijs
6a88ef51b3 71410: Authorization for Downloads of restricted Bitstreams
- Don't update ePerson session salt when requesting a short lived token
2020-06-23 18:08:39 +02:00
Pasquale Cavallo
530a9d5fac Tests and minor fix 2020-06-23 17:11:56 +02:00
Raf Ponsaerts
9f9fe26549 [Task 71440] fixed checkstyle and added preAuthorize to the SubmissionCCLicenseUrlRepository 2020-06-23 15:09:45 +02:00
Mykhaylo
0c4985e1cf added implementations for getChoicesByParent and getTopChoices 2020-06-23 14:59:15 +02:00
Andrea Bollini
52797df90d Merge pull request #2781 from atmire/w2p-71356_private-bitstreams-md-accessible
Private Bitstreams should still return name, content link
2020-06-23 14:30:52 +02:00
Raf Ponsaerts
3f9a690f5f Merge remote-tracking branch 'dspace/master' into w2p-70213_CC-license 2020-06-23 14:23:59 +02:00
Raf Ponsaerts
95110d2b5a [Task 71440] changed the ModelObject for SubmissionCCLicenseUrlRest from String to SubmissionCCLicenseUrl 2020-06-23 14:23:50 +02:00
Danilo Di Nuzzo
8407a2f688 [CST-2877] fix 2020-06-23 11:54:48 +02:00
Pasquale Cavallo
3c4a463771 pubmed test data 2020-06-23 01:58:42 +02:00
Pasquale Cavallo
8ad4b0ed39 Implement FileSource in PubmedImportMetadataSourceServiceImpl 2020-06-23 01:51:59 +02:00
Tim Donohue
52ee4ec4fb Missing import in IT 2020-06-22 13:57:35 -05:00
Tim Donohue
88215a1581 Merge pull request #2648 from atmire/w2p-64428_scripts-prototype-importing-and-exporting
Scripts & processes: importing and exporting csv's
2020-06-22 12:37:26 -05:00
Danilo Di Nuzzo
2016805623 Merge branch 'DS-4466_new' of https://github.com/4science/DSpace into DS-4466_new 2020-06-22 18:29:49 +02:00
Danilo Di Nuzzo
ffad77b43b [CST-2877] fix submission multi-lang 2020-06-22 17:20:22 +02:00
Pasquale Cavallo
aef91df802 Use metadataField as unnamed bean 2020-06-22 15:43:48 +02:00
Mykhaylo
64a29b1b60 update tests 2020-06-22 14:45:44 +02:00
Mykhaylo
de8def4418 refactoring 2020-06-22 14:44:41 +02:00
Andrea Bollini
6c2ed0c0d9 Merge branch 'draft_vocabulary' of https://github.com/4Science/DSpace into draft_vocabulary 2020-06-22 12:15:35 +02:00
Andrea Bollini
73e0bd8759 Avoid to expose the authority where not needed 2020-06-22 12:15:00 +02:00
Mykhaylo
efb4f6a1be renamed embedded link in tests 2020-06-22 12:00:49 +02:00
Pasquale Cavallo
64046093d2 Bibtex file import 2020-06-22 11:46:53 +02:00
Andrea Bollini
bd2cf94376 DS-4529 External authorities endpoint doesn't support the pagination 2020-06-20 18:52:45 +02:00
Andrea Bollini
38c5667233 DS-4515 enable live import provider as external authority 2020-06-20 18:52:23 +02:00
Andrea Bollini
f50d0d6648 Add dependency needed by the pubmed live import provider 2020-06-20 18:50:36 +02:00
Andrea Bollini
5c8ff2c743 DS-4530 enforce the use of the latest override of the findOne when checking permission for embedding 2020-06-20 18:49:56 +02:00
Mykhaylo
e473f1170b added test 2020-06-19 18:47:04 +02:00
Mykhaylo
de49227b07 fix tests 2020-06-19 18:46:22 +02:00
Mykhaylo
f9f0067294 fix bug 2020-06-19 18:45:37 +02:00
Tim Donohue
69df9b0ec2 Merge pull request #2771 from Micheleboychuk/DS-4504_UpdatePerformanceFindingCollections
DS-4504 Performance issues with finding Collections a user can submit to
2020-06-19 11:09:32 -05:00
Mykhaylo
056a0fbdae VocabularyEntryRest must implement RestModel 2020-06-19 16:44:26 +02:00
Mykhaylo
cd842fd806 refactored RestResourceController 2020-06-19 16:42:10 +02:00
Mykhaylo
52dfbfd958 added VocabularyEntryResource 2020-06-19 16:40:35 +02:00
Mykhaylo
fa2769036a refactored search method byMetadataAndCollection 2020-06-19 16:36:43 +02:00
Raf Ponsaerts
891ab3f3e2 [Task 71442] fixed the tests without the additional cleanup required 2020-06-19 14:47:53 +02:00
Yana De Pauw
08abaf8b03 71440: Implement feedback 2020-06-19 14:05:14 +02:00
Kevin Van de Velde
6c91e5acf0 Authorization for file downloads: Small comment changes 2020-06-19 12:03:42 +02:00
Peter Nijs
b4b56750fd 71410: Authorization for Downloads of restricted Bitstreams
- Internal feedback
2020-06-19 10:25:17 +02:00
Raf Ponsaerts
de6bc7d8d0 [Task 71442] fixed compile error after merge 2020-06-19 10:18:28 +02:00
Raf Ponsaerts
e73686e05b Merge remote-tracking branch 'dspace/master' into w2p-70273_create-new-registration
Conflicts:
	dspace-api/src/main/java/org/dspace/app/util/AuthorizeUtil.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/security/EPersonRestPermissionEvaluatorPlugin.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/EPersonRestRepositoryIT.java
2020-06-19 10:17:57 +02:00
Raf Ponsaerts
d212a84a4e [Task 71442] applied feedback to the new registration endpoint 2020-06-19 09:56:34 +02:00
Andrea Bollini
c23a5b64de Improve error handling and test env clenaup 2020-06-19 09:35:40 +02:00
Mykhaylo
ea9d5da764 implemented search method byMetadataAndCollection 2020-06-19 09:35:24 +02:00
Andrea Bollini
e4d61191e6 Disable test failing due to bug in the Mock library 2020-06-18 23:52:49 +02:00
Andrea Bollini
9b24517546 Fix obviously wrong implementation 2020-06-18 23:49:25 +02:00
Mykhaylo
1114903645 refactored tests 2020-06-18 22:07:43 +02:00
Mykhaylo
5376539480 missing filling list of metadata 2020-06-18 22:07:04 +02:00
Andrea Bollini
ea31ebef05 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4466_new 2020-06-18 19:38:00 +02:00
benbosman
124117c169 Merge pull request #2778 from atmire/w2p-71143_preAuthorize-annotations
Pre authorize annotations for subresources
Merging since we have 2 approvals
2020-06-18 18:14:29 +02:00
Andrea Bollini
f093db181d Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4466_new 2020-06-18 18:00:27 +02:00
benbosman
559001cf43 Removing unused import 2020-06-18 17:16:56 +02:00
benbosman
8172dd5fb0 Re-enable findByObjectAndFeatureTest
The findByObjectAndFeatureTest can be used again thanks to https://github.com/DSpace/DSpace/pull/2778/files#diff-311a7e07c257d9c869f4de1347f5f761R51
2020-06-18 17:05:31 +02:00
Andrea Bollini
e9abbc505b Add initial implementation for VocabularyEntryDetails repository 2020-06-18 12:59:02 +02:00
Andrea Bollini
61c346089e Cleanup authority service implementation 2020-06-18 12:58:28 +02:00
Raf Ponsaerts
57d63c211e [Task 71441] added javadoc and minor cleanup 2020-06-18 12:58:23 +02:00
Andrea Bollini
d38dfdb31f Add support for : in string identifier 2020-06-18 12:56:44 +02:00
Andrea Bollini
f44b28a8f5 Implement check for mandatory parameters 2020-06-18 12:56:23 +02:00
Andrea Bollini
ae60714f7d Align test with the contract 2020-06-18 12:55:58 +02:00
Andrea Bollini
94581761b9 Fix typos 2020-06-18 12:55:40 +02:00
Raf Ponsaerts
de357b581c [Task 71441] altered the processFiles endpoint and added the process filetypes endpoint with tests 2020-06-18 12:49:43 +02:00
Andrea Bollini
ec3df2e523 Fix test setup, update response code according to the contract 2020-06-18 12:42:59 +02:00
Andrea Bollini
be6f7f3bfd Update default to reflect the rest contract
the visualization is now responsability of the angular UI so it is better by default present a clean label as the hierarchy is still visible in the otherInformation
2020-06-18 12:38:12 +02:00
Andrea Bollini
3e8b2f87b6 Remove invalid test, cleanup 2020-06-18 12:28:48 +02:00
Mykhaylo
d7ce794eab fix creation of the internal maps of authorities 2020-06-18 10:14:56 +02:00
Mykhaylo
4784d34066 renamed classes 2020-06-17 18:22:13 +02:00
Peter Nijs
e7ef7d3c5e 71343: Authorization for Downloads of restricted Bitstreams #2 2020-06-17 16:23:54 +02:00
Mykhaylo
9849d6c41e fix checkstyle 2020-06-17 14:19:54 +02:00
Mykhaylo
dc2f68655f Merge branch 'CST-3088' into draft_vocabulary 2020-06-17 11:47:50 +02:00
Andrea Bollini
17c3833645 Refactoring for vocabularies, second part (Draft) 2020-06-17 10:45:34 +02:00
Tim Donohue
1896d739d0 Merge pull request #2774 from Micheleboychuk/DS-4486
DS-4486 Add support/tests for Collection/Community role-based groups for Community/Collection Admins
2020-06-16 16:41:50 -05:00
Andrea Bollini
8afa698e04 Initial refactoring for vocabularies (Draft) 2020-06-16 18:35:04 +02:00
Mykhaylo
d794c1cdf0 update tests of Vocabulary 2020-06-16 18:22:56 +02:00
Andrea Bollini
e2f79861e3 Fix wrong name 2020-06-16 17:14:44 +02:00
Marie Verdonck
c4df4f2ed7 71362: permissions for bitstream metadata READ + tests 2020-06-16 16:37:02 +02:00
Mykhaylo
d77c505a66 added ITs for ORCID 2020-06-16 16:27:27 +02:00
Andrea Bollini
2ffde8ec2c Minor cleanup 2020-06-16 11:35:48 +02:00
Pasquale Cavallo
ec348a63f1 Update ORCID to V3 2020-06-16 11:35:48 +02:00
Mykhaylo
eef6868a2f renamed methods 2020-06-16 11:09:32 +02:00
Raf Ponsaerts
31c87c2ba1 [Task 71405] fixed the Process Files endpoints and added two tests for them 2020-06-16 09:46:01 +02:00
Mykhaylo
60240b19ca added ITs for check Content-Language header 2020-06-15 16:01:04 +02:00
Mykhaylo
e2cf32dea3 added license 2020-06-15 16:00:38 +02:00
Mykhaylo
efcefef914 added ITs for language support 2020-06-15 16:00:19 +02:00
Mykhaylo
0a37c5906a refactoring 2020-06-15 16:00:03 +02:00
Mykhaylo
ec59b7d45e added Filter for set Content-Language Header of the response 2020-06-15 15:58:21 +02:00
Mykhaylo
36ef4224cd added configurations and submissions forms in italian and 2020-06-15 15:56:49 +02:00
Mykhaylo
908f4c761a added initial implementantions for languages support 2020-06-15 15:52:44 +02:00
Raf Ponsaerts
b32c461006 [Task 71405] applied community feedback to the Scripts and Processes endpoints 2020-06-15 14:58:11 +02:00
Marie Verdonck
344f664521 license added 2020-06-15 14:01:36 +02:00
Marie Verdonck
a15570b5fb 71356: Private bitstreams their metadata still accessible 2020-06-15 12:59:03 +02:00
Mykhaylo
1765d2a161 added tests 2020-06-15 11:53:50 +02:00
Mykhaylo
04d0775b21 Merge branch 'master' into DS-4486 2020-06-12 14:26:27 +02:00
Peter Nijs
48a8639902 71342: Authorization for Downloads of restricted Bitstreams #1 2020-06-12 13:56:38 +02:00
Mykhaylo
25adabe0a4 cleanup tests 2020-06-12 11:18:52 +02:00
Mykhaylo
381fe08ad0 added missing annotations 2020-06-12 11:15:56 +02:00
Mykhaylo
c3d043f2a3 renamed variable 2020-06-12 11:13:59 +02:00
Mykhaylo
4ff01ae963 added test 2020-06-12 01:07:08 +02:00
Mykhaylo
d9d698dcd1 Implement community feedbacks 2020-06-11 19:19:02 +02:00
Raf Ponsaerts
3aba1b7545 Added a way to ignore write only properties in REST objects for tests and rewrote EPersonRestRepositoryIT tests to use this 2020-06-11 15:08:03 +02:00
Mykhaylo
f5b7d5854b Implement community feedbacks 2020-06-11 11:20:48 +02:00
Mykhaylo
aa15d65817 Implement community feedbacks 2020-06-11 10:47:37 +02:00
Raf Ponsaerts
80f7bad494 [Task 71348] fixed the patch replace password for eperson with a token to now be available to anonymous calls 2020-06-11 10:23:50 +02:00
Mykhaylo
5f6775a122 added ITs for Vocabulary Entries 2020-06-10 21:30:10 +02:00
Tim Donohue
81b1e57d79 Merge pull request #2762 from atmire/w2p-70471_request-configuration-properties-in-rest
Configuration property retrieval Rest endpoint
2020-06-10 13:18:46 -05:00
Mykhaylo
e39c2a8582 added ITs for Controlled Vocabularies 2020-06-10 17:00:43 +02:00
Raf Ponsaerts
5f44fe11f7 Undo findall preauthorize annotation change on AuthorizationFeatureRestRepository 2020-06-10 13:50:17 +02:00
Raf Ponsaerts
56629fd34e [Task 71335] removed wrongly added preAuthorize on bitstreamFormatRestRepository#findAll 2020-06-10 11:53:24 +02:00
Raf Ponsaerts
faef05258a [Task 71335] removed unneeded PermissionEvaluatorPlugins and changed PreAuthorize annotations where necessary 2020-06-10 11:51:44 +02:00
Raf Ponsaerts
e464ec0f8c [Task 71272] minor cleanup to the Scripts and Processes functionality 2020-06-09 15:06:39 +02:00
Raf Ponsaerts
5d7524970c [Task 71272] applied feedback to the Scripts and Processes functionality 2020-06-09 15:04:51 +02:00
Raf Ponsaerts
4a40b8d102 [Task 71308] applied feedback to the PreAuthorize parsing in converterService feature 2020-06-09 09:25:06 +02:00
Tim Donohue
e03a3f47b3 Link to the external, new Code Testing Guide 2020-06-08 15:53:32 -05:00
Tim Donohue
e993812675 Merge pull request #2777 from DSpace/dependabot/maven/dspace-rest/spring-security.version-5.3.3.RELEASE
Bump spring-security.version from 5.3.1.RELEASE to 5.3.3.RELEASE in /dspace-rest
2020-06-08 10:08:26 -05:00
Tim Donohue
1fb4462b0a Merge pull request #2776 from tdonohue/rename_root_properties
Rename root properties in REST API v7 to match dspace.cfg configuration
2020-06-08 09:53:30 -05:00
Raf Ponsaerts
fdaddd934f [Task 71271] applied fixes after merge and applied community feedback to the new registration endpoints 2020-06-08 16:24:19 +02:00
Raf Ponsaerts
9ccdff521c Merge remote-tracking branch 'dspace/master' into w2p-70273_create-new-registration
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/EPersonRestRepository.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/EPersonRestRepositoryIT.java
2020-06-08 15:21:09 +02:00
Raf Ponsaerts
7be0928139 [Task 71143] fixed checkstyle 2020-06-08 15:12:40 +02:00
Raf Ponsaerts
49d40598f0 [Task 71143] implemented the PreAuthorize check in ConverterService for the findOne of a BaseObjectRest when the toRest method is called 2020-06-08 13:04:59 +02:00
dependabot[bot]
3839079f73 Bump spring-security.version in /dspace-rest
Bumps `spring-security.version` from 5.3.1.RELEASE to 5.3.3.RELEASE.

Updates `spring-security-core` from 5.3.1.RELEASE to 5.3.3.RELEASE
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.3.1.RELEASE...5.3.3.RELEASE)

Updates `spring-security-web` from 5.3.1.RELEASE to 5.3.3.RELEASE
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.3.1.RELEASE...5.3.3.RELEASE)

Updates `spring-security-config` from 5.3.1.RELEASE to 5.3.3.RELEASE
- [Release notes](https://github.com/spring-projects/spring-security/releases)
- [Commits](https://github.com/spring-projects/spring-security/compare/5.3.1.RELEASE...5.3.3.RELEASE)

Signed-off-by: dependabot[bot] <support@github.com>
2020-06-06 05:34:27 +00:00
Mykhaylo
41ca123ae4 Merge branch 'master' into DS-4486 2020-06-05 17:48:03 +02:00
Peter Nijs
a7aeb102d4 71220: Configuration properties endpoint - PR feedback
- fixes after merging with latest master
2020-06-05 17:28:24 +02:00
Mykhaylo
26f6a7d0d8 Implement community feedbacks 2020-06-05 17:13:37 +02:00
Raf Ponsaerts
397a156186 [Task 71143] Intermediate work on PreAuthorize annotation parsing 2020-06-05 13:56:39 +02:00
Tim Donohue
3a1522c2b7 Merge pull request #2766 from Micheleboychuk/DS-4495_HAL_link
DS-4495 Restricted endpoints are sometimes the only HAL link path to public endpoints
2020-06-04 10:33:26 -05:00
Tim Donohue
3fc20eb2db Merge pull request #2769 from tdonohue/update_hal_browser_dependencies
Update HAL Browser Dependencies with latest JQuery, Toastr
2020-06-04 10:29:43 -05:00
Yana De Pauw
099caaf86f 71266: Community feedback #1 2020-06-04 16:38:37 +02:00
Peter Nijs
24ede371ca Merge remote-tracking branch 'community/master' into w2p-70471_request-configuration-properties-in-rest 2020-06-04 15:36:02 +02:00
Yana De Pauw
ad316f0d5e Merge remote-tracking branch 'upstream/master' into w2p-70213_CC-license 2020-06-04 14:36:45 +02:00
Peter Nijs
4e61be497e 71220: Configuration properties endpoint - PR feedback 2020-06-04 14:04:41 +02:00
Mykhaylo
746fa4fd27 splitted links in their owner repository 2020-06-03 21:41:21 +02:00
Mykhaylo
a338526583 Implement community feedbacks 2020-06-03 15:39:42 +02:00
Raf Ponsaerts
4ea4f91129 [Task 71213] applied feedback to the new registration creation functionality 2020-06-03 14:42:40 +02:00
Tim Donohue
bf790e072b Rename root properties in REST API to match dspace.cfg configuration names 2020-06-02 17:01:48 -05:00
Raf Ponsaerts
6c0ee98fa6 SPEL parsing of the preAuthorize annotation in converterService work 2020-06-02 14:56:00 +02:00
Tim Donohue
c6c490622c Merge pull request #2772 from tdonohue/correct_ui_default_port
Fixes to Docker and default "dspace.ui.url" per Angular CLI update
2020-06-01 10:52:16 -05:00
Tim Donohue
46ffa51f71 Fix typo 2020-06-01 09:40:28 -05:00
Tim Donohue
8989b5a9cc Bug fixes to Docker configuration 2020-05-29 16:50:19 -05:00
Raf Ponsaerts
47b75f313e Fixed checkstyle 2020-05-29 15:52:09 +02:00
Kevin Van de Velde
3610867105 Add missing test from https://github.com/DSpace/DSpace/pull/2770 2020-05-29 13:19:49 +02:00
Yana De Pauw
72ac350250 Remove unused import 2020-05-29 13:19:20 +02:00
Yana De Pauw
614ad3d054 71199: Fix PR issues 2020-05-29 11:51:26 +02:00
Tim Donohue
fcdbc1727a Fix/update license header checking configuration in Maven 2020-05-28 16:21:04 -05:00
Mykhaylo
34b61f3b98 added ITs to prove that admins of community/collection can manage their own groups 2020-05-28 19:07:50 +02:00
Yana De Pauw
1c921d316f Merge remote-tracking branch 'upstream/master' into w2p-70213_CC-license 2020-05-28 17:02:49 +02:00
Raf Ponsaerts
8652e95686 [Task 70911] added required parameter e check in the MetadataImport setup and cleanup 2020-05-28 15:48:03 +02:00
Raf Ponsaerts
f19bf96bd2 [Task 70911] applied feedback to the MetadataExport and MetadataImport scripts as well as general Process functionality feedback 2020-05-28 15:30:52 +02:00
Raf Ponsaerts
ce9ba1263b Added more descriptive log to the ProcessRestRepository#delete method 2020-05-28 11:40:01 +02:00
Raf Ponsaerts
8045194cc3 [Task 70911] applied feedback on the Process endpoints 2020-05-28 10:29:09 +02:00
Raf Ponsaerts
bc7cf1484c Fixes after master merge 2020-05-28 09:41:58 +02:00
Raf Ponsaerts
2a554cbd14 Merge remote-tracking branch 'dspace/master' into w2p-64428_scripts-prototype-importing-and-exporting
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/ScriptProcessesController.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/ScriptRestRepository.java
2020-05-28 09:23:19 +02:00
Tim Donohue
43f0d30bd2 Updates to Docker configuration for Angular CLI and port 4000 2020-05-27 16:43:00 -05:00
Tim Donohue
a7c8c2dbd6 Correct default port of dspace.ui.url to be 4000 2020-05-27 16:32:39 -05:00
Mykhaylo
6df58917b4 added ITs to prove that admins of community/collection can manage submitters 2020-05-27 18:56:51 +02:00
Kevin Van de Velde
df01297539 Submission CC license: Adding overrides & removing unused class 2020-05-27 17:11:52 +02:00
Yana De Pauw
9ef1f5f8eb Update bitstream link 2020-05-27 16:42:22 +02:00
Yana De Pauw
ffce2e4299 70815: Angular feedback - add self link 2020-05-27 13:25:56 +02:00
Mykhaylo
141284e7fa added ITs for search method byMetadata by community admin and by collection admin 2020-05-27 11:25:01 +02:00
Mykhaylo
9493834f59 added implementations for support for Collection/Community role-based groups for Community/Collection Admins 2020-05-27 11:21:08 +02:00
Raf Ponsaerts
e068abb87f undo unnecessary changes 2020-05-27 10:43:31 +02:00
Raf Ponsaerts
ee120b415f [Task 71143] initial implementation of the preauthorize annotations in the converterservice 2020-05-27 10:41:28 +02:00
Mykhaylo
41b91ea5b1 Merge branch 'master' into DS-4504_UpdatePerformanceFindingCollections 2020-05-25 16:21:34 +02:00
Mykhaylo
22a34ff368 added ITs for methods findAuthorizedByCommunity and findAuthorized 2020-05-25 14:36:04 +02:00
Mykhaylo
5139bb881d updated findAuthorizedByCommunity and findAuthorized with Solr query 2020-05-22 22:41:56 +02:00
Mykhaylo
66992cfe19 added solr plugin to index collection submitters 2020-05-22 22:29:54 +02:00
benbosman
19ba3ddaeb Merge pull request #2726 from atmire/w2p-69976_subresource-permissions
Subresources should obey access restrictions
2020-05-22 18:10:47 +02:00
Mykhaylo
bda1fb815b Merge branch 'master' into DS-4042_ITs_WrongPatchRequest 2020-05-22 14:56:25 +02:00
Tim Donohue
4bfc78283c Correct code alignment in client.js 2020-05-21 16:35:39 -05:00
Tim Donohue
4872bc9636 Switch to pulling in toastr via WebJars instead of via CDN 2020-05-21 16:06:07 -05:00
Tim Donohue
4a54aadf99 Switch to using WebJARs to dynamically pull in JQuery 3.5.1 2020-05-21 15:52:10 -05:00
Tim Donohue
cb1b975df1 Fix bug in login form after upgrade to JQuery 3.5.1 2020-05-21 15:05:29 -05:00
Tim Donohue
7aadfec5b0 Upgrade to JQuery v3.5.1 2020-05-21 15:05:29 -05:00
Tim Donohue
7e0a0793a2 Fix headers in files borrowed from HAL Browser. These should retain original licensing 2020-05-21 15:05:23 -05:00
Tim Donohue
1376563b37 Merge pull request #2765 from tdonohue/authentication_test_cleanup
Add JavaDocs to JWTTokenHolder, cleanup and enhance related Tests
2020-05-21 10:06:44 -05:00
Mykhaylo
6f5d6625b4 added the class that has responsible to add to the root endpoint the links to standard nested endpoint, plus IT 2020-05-21 13:12:03 +02:00
Tim Donohue
ed3c2e39c7 Add unit test for token invalidation 2020-05-20 11:21:32 -05:00
Tim Donohue
e5f136b569 Test cleanup & minor enhancement 2020-05-20 11:21:04 -05:00
Tim Donohue
6bb3f340d8 Add Javadocs and comments 2020-05-20 11:20:41 -05:00
Tim Donohue
9dd0e697de Merge pull request #2735 from tdonohue/DS-4473
DS-4473: Configurable whitelist for Access-Control-Allow-Origin, add support for Access-Control-Allow-Credentials
2020-05-20 10:39:56 -05:00
Tim Donohue
03de94ecb2 Merge pull request #2759 from Micheleboychuk/DS-4499-CleanupTestEnviroment
DS-4499 Fix cleanup of test environment in earlier Integration Test
2020-05-20 10:30:27 -05:00
Mykhaylo
76ff785b07 added implementation for delete section 2020-05-20 16:02:32 +02:00
Mykhaylo
ccfbbfce99 added IT patchDeleteSection 2020-05-20 15:55:13 +02:00
Mykhaylo
9404e24c4e fix: wrong calling toString 2020-05-20 15:51:12 +02:00
Mykhaylo
ab0aec4698 move bean to the right file 2020-05-20 15:30:53 +02:00
Mykhaylo
98f2447cbb Implement community feedbacks 2020-05-20 13:13:36 +02:00
Kevin Van de Velde
bfa83b7599 Disabling the CC License step in the default configuration 2020-05-20 13:09:33 +02:00
Mykhaylo
212985bed6 refactoring doPatchProcessing of UploadStep 2020-05-20 13:02:08 +02:00
Mykhaylo
f33bfac195 added ITs for upload patch request 2020-05-20 12:54:08 +02:00
Tim Donohue
ef7b76abe7 Add support for configurable Access-Control-Allow-Credentials header 2020-05-19 11:01:57 -05:00
Raf Ponsaerts
68b91aa8f0 Applied feedback to the subresource permissions functionality 2020-05-19 15:56:07 +02:00
Raf Ponsaerts
2a0971d8fb [Task 70937] fixes after merge 2020-05-19 14:27:40 +02:00
Raf Ponsaerts
d75c9d3cae Merge remote-tracking branch 'dspace/master' into w2p-70273_create-new-registration
Conflicts:
	dspace-api/src/main/java/org/dspace/app/util/AuthorizeUtil.java
2020-05-19 14:27:24 +02:00
Raf Ponsaerts
d3cc506b26 [Task 70937] removed the canLogin parameter from the AuthorizeUtil#authorizeUpdatePassword method 2020-05-19 13:42:24 +02:00
Yana De Pauw
60c4a0777f Implement feedback 2020-05-18 17:50:01 +02:00
Raf Ponsaerts
34bf7dd76b [Task 70927] applied feedback on the subresources permissions functionality 2020-05-18 15:54:38 +02:00
Raf Ponsaerts
5b0bf29fd4 Cleanup comment 2020-05-18 14:52:13 +02:00
Raf Ponsaerts
fa741eb188 [Task 70911] applied feedback to the Scripts and Processes functionality 2020-05-18 14:48:39 +02:00
Mykhaylo
3a1982656a this method should also check metadata with qualdrop_value 2020-05-14 10:48:15 +02:00
Mykhaylo
7b7e7cd14e added IT for patch request on metadata with qualdrop_value 2020-05-14 10:44:14 +02:00
Mykhaylo
d462aa7676 Implement community feedbacks 2020-05-13 19:10:17 +02:00
Mykhaylo
4ab860578d Implement community feedbacks 2020-05-13 18:36:42 +02:00
Raf Ponsaerts
262d81a33f [Task 70871] implemented default preauthorize setting 2020-05-13 14:50:42 +02:00
Raf Ponsaerts
ea538d619b [Task 70871] fixed tests after master merge 2020-05-13 13:13:54 +02:00
Raf Ponsaerts
adfce8e9f3 Fixed issues after master merge 2020-05-13 09:40:01 +02:00
Raf Ponsaerts
50c340a8b3 Merge remote-tracking branch 'dspace/master' into w2p-69976_subresource-permissions
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/RestResourceController.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/WorkflowDefinitionCollectionsLinkRepository.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/WorkflowDefinitionStepsLinkRepository.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/WorkflowStepActionsLinkRepository.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/converter/ConverterService.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/VersionsLinkRepository.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/CollectionRestRepositoryIT.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/converter/ConverterServiceIT.java
2020-05-13 09:39:42 +02:00
Tim Donohue
1f07d465a2 Correct the default allowed-origins in rest.cfg. Enhance comments in rest.cfg & Application 2020-05-12 15:32:54 -05:00
Tim Donohue
d3d4ff9094 Allow multiple comma-separated values via Apache Commons Config (which treats them as an array) 2020-05-12 15:32:54 -05:00
Raf Ponsaerts
2a8fe67858 Trying Travis Tests 2020-05-12 13:24:56 +02:00
Mykhaylo
02a9a3f514 Merge master into DS-4499-CleanupTestEnviroment 2020-05-12 10:31:29 +02:00
Mykhaylo
8c5ff93bd9 removed a note 2020-05-12 10:04:43 +02:00
Tim Donohue
aaa5f09a68 Merge pull request #2740 from atmire/w2p-70131_login-as-eperson
Assume login feature
2020-05-11 09:39:35 -05:00
Mykhaylo
6fbc15486d dc.source metadata is not present in the upload section, so we con not apply patch remove request 2020-05-11 14:52:02 +02:00
Peter Nijs
7fcb782230 70824: Configuration properties endpoint feedback 2020-05-11 12:56:27 +02:00
Mykhaylo
f0ec92dafb refactoring of the cleanup method in Builder classes 2020-05-11 12:53:05 +02:00
Raf Ponsaerts
8ff77a9e6d [Task 70808] added javadoc 2020-05-11 11:51:38 +02:00
Raf Ponsaerts
ea47ef0c92 [Task 70808] applied feedback to the registration implementation 2020-05-11 11:49:57 +02:00
Raf Ponsaerts
b18b52a621 [Task 70808] added javadocs 2020-05-11 08:59:47 +02:00
Raf Ponsaerts
d7cbe8c90a Updated javadoc on StatelessAuthenticationFilter#getAuthentication 2020-05-11 08:33:39 +02:00
Andrea Bollini
ea746e2aeb Merge pull request #2747 from atmire/w2p-70402_Manage-account-profile
Account profile management
2020-05-10 13:52:06 +02:00
Raf Ponsaerts
2ff63a9a59 Testing Travis execution to find errors 2020-05-08 15:53:01 +02:00
Raf Ponsaerts
3dc9f511d4 [Task 70808] changed the link the mail to include the token in the url instead of as a parameter 2020-05-08 15:43:18 +02:00
Yana De Pauw
b5bbc72ece 70815: Angular feedback 2020-05-08 12:57:07 +02:00
Mykhaylo
7fc6f6cc32 refactoring of some builder classes 2020-05-08 11:48:37 +02:00
Marie Verdonck
36914e1d85 Revert format changes - EPersonRestRepository 2020-05-08 10:27:31 +02:00
Raf Ponsaerts
ece341e7ba Removed unused AuthorizationFeature variable 2020-05-08 10:21:31 +02:00
Marie Verdonck
b93145d2d3 Revert format changes 2020-05-08 10:17:09 +02:00
Mykhaylo
6c24ff84ad added deleteAdminGroup method for cleanup in CommunityBuilder 2020-05-07 23:16:18 +02:00
Mykhaylo
47411d8614 cleanup of CollectionGroupRestControllerIT and CommunityAdminGroupRestControllerIT 2020-05-07 19:48:19 +02:00
Mykhaylo
95d089a306 cleanup of CollectionRestRepositoryIT and ItemRestRepositoryIT 2020-05-07 13:26:45 +02:00
Raf Ponsaerts
e2347e3971 Fixed the solr tests in dspace-api 2020-05-07 12:03:34 +02:00
Mykhaylo
a2e617521a cleanup of test environment in WorkspaceItemRestRepositoryIT and WorkflowItemRestRepositoryIT 2020-05-07 11:03:50 +02:00
Raf Ponsaerts
cb6c5ccccc [Task 70763] applied community feedback to the LoginOnBehalfOf feature 2020-05-07 09:31:17 +02:00
Mykhaylo
f91724dbff cleanup of test environment 2020-05-07 09:23:04 +02:00
Mykhaylo
3b22efd05d refactored RelationshipRestRepositoryIT 2020-05-06 17:20:34 +02:00
Raf Ponsaerts
026c2308ec [Task 70750] made the Bitstream findAll endpoint not implemented 2020-05-06 16:38:27 +02:00
Mykhaylo
a975daa1db removed unused dipendensies 2020-05-06 15:35:50 +02:00
Mykhaylo
8c9e809f8f added context.restoreAuthSystemState() and delete static methods 2020-05-06 15:34:25 +02:00
Mykhaylo
c21ef22290 fixed error 2020-05-06 14:23:35 +02:00
Mykhaylo
1c4a43c36e added context.restoreAuthSystemState(), where was missing 2020-05-06 13:43:23 +02:00
Marie Verdonck
92cc64c30a 70701: Process PR feedback 2020-05-06 11:54:26 +02:00
Raf Ponsaerts
5e212192af [Task 70050] fixes after master merge 2020-05-06 11:49:39 +02:00
Raf Ponsaerts
9e6a746404 Merge remote-tracking branch 'dspace/master' into w2p-64428_scripts-prototype-importing-and-exporting
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/ScriptProcessesController.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/model/ParameterRest.java
2020-05-06 11:49:23 +02:00
Raf Ponsaerts
861cdfb2b8 [Task 70080] applied feedback to the scripts prototype 2020-05-06 11:02:47 +02:00
Luigi Andrea Pascarelli
5dd25b1c0b [DS-4149] resolve checkstyle violations 2020-05-05 13:36:02 +02:00
Luigi Andrea Pascarelli
5238b4a5a1 [DS-4149] added licenseCondition element 2020-05-05 12:55:59 +02:00
Raf Ponsaerts
fc91b0b858 Fixed checkstyle in the EPersonRestRepositoryIT class 2020-05-05 11:59:05 +02:00
Mykhaylo
741357ece7 Merge branch 'master' into DS-4042_ITs_WrongPatchRequest 2020-05-05 09:47:03 +02:00
Ben Bosman
14a91bfb38 support empty values in the CSV deleting the data 2020-05-05 09:42:59 +02:00
Peter Nijs
f85a5b3c4d 70603: Make the configuration properties endpoint conform to the contract 2020-05-04 17:56:14 +02:00
Tim Donohue
793473663f Merge pull request #2751 from tdonohue/fix_bug_running_individual_tests
Fix bug running individual tests on `master`
2020-05-04 10:26:21 -05:00
Peter Nijs
d8bda5c721 70471: Add configuration properties endpoint 2020-05-04 11:19:27 +02:00
Mykhaylo
6ef11e4919 added the missing parameter 2020-05-04 09:18:22 +02:00
Tim Donohue
e4ab84e29b Merge pull request #2727 from atmire/workflow-item-read-rights
Administer Workflow (Abort WorkflowItem, Delete WorkflowItem)
2020-05-01 09:48:53 -05:00
Tim Donohue
2cff30e59b Merge pull request #2720 from tdonohue/fix_security_alerts_for_spring
Upgrade backend to Spring Boot v2.2.6, Spring v5.2.5, Spring HATEOAS v1.0.3
2020-04-30 16:23:30 -05:00
Mykhaylo
676648568d fix return http status for wrong patch request to the submission 2020-04-30 18:58:52 +02:00
Mykhaylo
91d70d85ce added ITs to prove that patch request with wrong path or metadata must return 422 2020-04-30 17:40:29 +02:00
Raf Ponsaerts
247b965dd4 Reorder structure of DiscoveryIT#init method 2020-04-29 14:46:59 +02:00
Raf Ponsaerts
b59aeecf0e Added extra cleanup to the EPersonRestRepositoryIT and optimized test in RegistrationRestControllerIT 2020-04-29 14:03:03 +02:00
Yana De Pauw
8e0b22ad6c 70415: jurisdiction 2020-04-29 11:17:17 +02:00
Yana De Pauw
b271ae6621 70338: Cleanup CC license code 2020-04-28 17:17:48 +02:00
Antoine Snyers
bf54ae6af0 Add JavaDocs 2020-04-28 11:47:03 +02:00
Tim Donohue
a2ff1375b1 Update README test instructions. Were outdated 2020-04-27 10:35:50 -05:00
Tim Donohue
9575b23949 Fix bug with testing. dspace-rest should only be used when enabled. Remove it from coverage reports. 2020-04-27 10:35:16 -05:00
Raf Ponsaerts
94d9f62358 [Task 70399] added context authorizations modifications for eperson post with token and added its to verify functionality 2020-04-27 14:52:00 +02:00
Raf Ponsaerts
4913c5a9e9 [DS-4443] changed asserts to equals and fixed test run 2020-04-27 10:33:46 +02:00
Kevin Van de Velde
36264cca50 Submission CreativeCommons license rest evaluator plugin addition so that it plays nicely with the access restrictions 2020-04-23 14:57:54 +02:00
Yana De Pauw
a27b64c88f 70506: CC license (REST): Patch submission (Remove) 2020-04-22 18:00:43 +02:00
Tim Donohue
e89b8d3943 Checkstyle fixes to previous updates 2020-04-22 10:32:32 -05:00
Tim Donohue
eb9ae8e14d Upgrade to latest version of Spring dependencies (as new versions have been released) 2020-04-22 10:25:13 -05:00
Tim Donohue
75d65b0f70 Spring HATEOAS updates for new code (after rebase on master) 2020-04-22 09:45:20 -05:00
Tim Donohue
ee0d6f03bd Rename DSpaceRelProvider to DSpaceLinkRelationProvider to match HATEOAS classes 2020-04-22 09:44:40 -05:00
Tim Donohue
edcefe1885 Fix dependency convergence issue between dspace-rest and dspace-oai 2020-04-22 09:11:08 -05:00
Tim Donohue
9219657ede Fix dependencies in /dspace/modules/server. Minor dependency reordering 2020-04-22 09:11:07 -05:00
Tim Donohue
88855a8fe1 Minor update to recent code based on update to Spring Boot 2020-04-22 09:11:07 -05:00
Tim Donohue
c571e0927a Fix broken/incorrect mock statement 2020-04-22 09:11:07 -05:00
Tim Donohue
3804b35854 Checkstyle fixes 2020-04-22 09:11:07 -05:00
Tim Donohue
967b9debd0 Replacement for Identifiable interface, which was removed in Spring HATEOAS v1. Ensure any BaseObjectRest is referenced by identifier like previously. 2020-04-22 09:11:07 -05:00
Tim Donohue
5feeb89d13 Remove jsonpath from Parent POM dependencies. It strangely causes JSONPath NoClassDefFoundErrors in Spring HATEOAS during runtime. Removing from Parent POM (but leaving in dspace-server-webapp) resolves those errors. 2020-04-22 09:11:07 -05:00
Tim Donohue
48c5e6953f Cleanup: Reorder/organize POM properties 2020-04-22 09:11:07 -05:00
Tim Donohue
32f5d62963 Ensure getRel() always uses value() to obtain String value 2020-04-22 09:11:06 -05:00
Tim Donohue
95e25f2fcc Pin version of Jetty to same version used in Solr. Update IT settings 2020-04-22 09:11:06 -05:00
Tim Donohue
7967871033 Correct Spring Security version for REST API. Realign related dependencies 2020-04-22 09:11:06 -05:00
Tim Donohue
4503cf800b Fix compilation errors in Tests 2020-04-22 09:11:06 -05:00
Tim Donohue
5420408c82 Updating code to Spring HATEOAS v1.0 compatibility 2020-04-22 09:11:06 -05:00
Tim Donohue
3d4eb91efb Upgrade Spring v5.2.4, Spring Boot v2.2.5, HAL Browser v3.2.5, Mockito 3.1.0 2020-04-22 09:11:05 -05:00
Yana De Pauw
09c0f62561 70505: Patch submission (Add): Bugfixing & tests 2020-04-22 14:39:53 +02:00
Luigi Andrea Pascarelli
541eae4d37 [DS-4149] porting additional indexer OAI 2020-04-22 13:08:45 +02:00
Raf Ponsaerts
3c28c65501 [Task 70478] applied feedback to the login as feature 2020-04-22 12:56:42 +02:00
Raf Ponsaerts
cf61ae987e [Task 70478] applied feedback to the login as eperson functionality and tests 2020-04-22 09:11:28 +02:00
Tim Donohue
42e5c0a862 [maven-release-plugin] prepare for next development iteration 2020-04-21 10:19:34 -05:00
Tim Donohue
7567824e97 [maven-release-plugin] prepare release dspace-7.0-beta2.1 2020-04-21 10:19:24 -05:00
Tim Donohue
84d49a219c Merge pull request #2750 from Micheleboychuk/DS-4487
This is an alternative PR for DS-4487 that also include test to proof the issue and solution
2020-04-21 10:01:17 -05:00
Tim Donohue
73eaf508fd Add in missing context.restoreAuthSystemState(); 2020-04-21 09:03:56 -05:00
Mykhaylo
b3823d4c38 avoid concurrent modification exception 2020-04-21 14:16:03 +02:00
Mykhaylo
f2a761b85c test to show the bug DS-4487 2020-04-21 14:13:39 +02:00
Tim Donohue
b36565361e [maven-release-plugin] prepare for next development iteration 2020-04-20 11:28:42 -05:00
Tim Donohue
9ef0cbaab8 [maven-release-plugin] prepare release dspace-7.0-beta2 2020-04-20 11:28:32 -05:00
Raf Ponsaerts
c7f6a46296 [Task 70419] fixed a bug where the RelationshipService creation did not check the max cardinality properly 2020-04-20 17:18:27 +02:00
Tim Donohue
854ef8abee Merge pull request #2748 from tdonohue/fix_broken_pagination
[HIGH PRIORITY] Fix broken pagination in Browse endpoints
2020-04-20 09:29:30 -05:00
Yana De Pauw
0920de7b21 70404: CC license (REST): Patch submission (Add) 2020-04-20 12:57:49 +02:00
Raf Ponsaerts
cb8b5c8efc [Task 70399] created the POST EPerson endpoint with token and added tests 2020-04-20 11:31:34 +02:00
Tim Donohue
fbd8757a77 Fix pagination bug by replacing params if they already exist 2020-04-17 16:18:02 -05:00
Tim Donohue
c4ab6e77f5 Create EmbeddedPageHeaderTest to prove pagination bug exists in getLinks() method 2020-04-17 16:01:58 -05:00
Raf Ponsaerts
fee24e3f96 [Task 70398] implementing change password with token patch and added ITs for the functionality 2020-04-17 14:14:25 +02:00
Yana De Pauw
5800bef325 70403: Add javadocs, undo line adjustments, LicenseMetadataValue changes 2020-04-17 13:13:40 +02:00
benbosman
6c91e98f48 Merge pull request #19 from atmire/w2p-70401_count-queries-circular-entities
W2p 70401 count queries circular entities
2020-04-17 12:02:31 +02:00
Antoine Snyers
3263d7f137 Return workflow items for the workflowAdmin configuration 2020-04-17 10:24:03 +02:00
Tim Donohue
f9822a728e Merge pull request #2722 from atmire/w2p-69349_edit-community-assign-roles
Edit Community/Collection - Assign Roles/Groups
2020-04-16 11:36:09 -05:00
Yana De Pauw
b30f9d9338 70403: CC license (REST): New submission section 2020-04-16 16:51:02 +02:00
Raf Ponsaerts
802e641a3b Fix test issues after master merge 2020-04-16 13:43:45 +02:00
Raf Ponsaerts
dd00ab2bd3 Merge remote-tracking branch 'dspace/master' into w2p-69349_edit-community-assign-roles 2020-04-16 11:12:15 +02:00
Raf Ponsaerts
5bff87e4ee [Task 70401] fixed the RelationshipService#countByItemAndRelationshipType to keep the isLeft parameter into account 2020-04-16 09:42:04 +02:00
Raf Ponsaerts
85e3bd0c52 [Task 70401] adding failing IT to prove that count is wrong with parent and child OrgUnits in the findByLabel 2020-04-16 08:49:06 +02:00
Marie Verdonck
bb1d5bd47a 70402: Tests for replace /metadata PATCH of own metadata at /eperson/epersons/<id> 2020-04-15 13:12:51 +02:00
Marie Verdonck
5727d090a9 70402: authorization logic via pre-authorize, in EPersonRestPermissionEvaluatorPlugin 2020-04-15 13:11:15 +02:00
Raf Ponsaerts
7da7ff0378 [Task 70397] added EPersonRegistrationFeature and added ITs 2020-04-15 12:57:51 +02:00
Marie Verdonck
738b8c4329 70402: authorization logic in EPersonRestRepository#Patch 2020-04-15 12:42:13 +02:00
Raf Ponsaerts
f07c382441 [Task 70382] added the search findByToken method for Registrations and added ITs 2020-04-15 10:31:29 +02:00
Yana De Pauw
794ee9fb9f 70337: Search CC License 2020-04-14 15:59:21 +02:00
Raf Ponsaerts
153786cac5 [Task 70131] added X-On-Behalf-Of to allowedHeaders 2020-04-14 14:41:54 +02:00
Raf Ponsaerts
f14097c9db [Task 70387] applied feedback to the IT in CollectionGroupRestControllerIT 2020-04-14 13:02:07 +02:00
Raf Ponsaerts
44d3d2bcc3 [Task 70273] added POST endpoint for new registration creation and IT 2020-04-14 11:58:50 +02:00
Kevin Van de Velde
5638c631d7 Undoing some changes that aren't needed 2020-04-10 15:50:59 +02:00
Yana De Pauw
f51a12d010 70334: CC license (REST): Initial fineOne endpoint 2020-04-10 10:27:32 +02:00
Tim Donohue
8ad01b2ddf Merge pull request #2736 from Micheleboychuk/DS-4412-ITs_toProveThatUsersInAdministratorsGroupGetFullAdminRights
DS-4412 Create Integration Tests to prove that users in the Administrators group get full Admin Rights
2020-04-09 16:14:05 -05:00
Mykhaylo
ffdd4a8474 renamed AdministratorOf in AdministratorOfFeature 2020-04-09 19:45:56 +02:00
Tim Donohue
c529d18880 Merge pull request #2719 from atmire/w2p-69741_Refactoring-Rest-Converters
REST API should respect "metadata.hide" configurations
2020-04-09 11:29:53 -05:00
Raf Ponsaerts
63c14b3ccb [Task 70333] removed the RelationshipTypeId from Relationship endpoints 2020-04-09 16:15:12 +02:00
Raf Ponsaerts
b0baab079a undo typo 2020-04-09 15:28:44 +02:00
Raf Ponsaerts
a74f11e11a Fixed checkstyle 2020-04-09 15:28:01 +02:00
Raf Ponsaerts
16675e405f Merge remote-tracking branch 'dspace/master' into w2p-69349_edit-community-assign-roles
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/GroupRestController.java
2020-04-09 15:04:34 +02:00
Raf Ponsaerts
5afb016bee [Task 70353] applied feedback to the community and collection groups 2020-04-09 15:02:37 +02:00
Yana De Pauw
18c8efd951 70332: Implement feedback 2020-04-09 14:26:39 +02:00
Kevin Van de Velde
3667ce4b40 Removing some outdated comments & added a missing override 2020-04-09 14:12:35 +02:00
Raf Ponsaerts
c88af9f2ce [Task 70231] Added orgUnit x orgUnit relationshiptype and test to prove the labels in a circular relationship 2020-04-09 14:08:59 +02:00
Raf Ponsaerts
7de471ddaf [Task 70232] moved createReadGroup to the collectionService and used this in both the Repository class and the IT class 2020-04-09 10:10:18 +02:00
Yana De Pauw
109be79edd 70236: Update log messages 2020-04-09 09:38:58 +02:00
Tim Donohue
1470406183 Merge pull request #2723 from atmire/Manage-groups-2
Group/EPerson management: Delete, retrieve parent object & patch support
2020-04-08 14:37:14 -05:00
Yana De Pauw
6e0396e6ad 70213: Initial findAll endpoint & backend 2020-04-08 15:14:18 +02:00
Antoine Snyers
d231304355 Rewrite authorization and remove try-finally blocks 2020-04-08 14:02:55 +02:00
Raf Ponsaerts
14a8b720bc [Task 70232] applied feedback with regards to the collection and community groups 2020-04-08 13:18:13 +02:00
Kevin Van de Velde
fb1a90b7dc Removing enter in a file that we didn't need to modify 2020-04-07 11:18:31 +02:00
Tim Donohue
1c514b8c4f Merge pull request #2737 from tdonohue/DS-4476
Upgrade version of m-enforcer-plugin to fix DS-4476
2020-04-06 10:12:20 -05:00
Antoine Snyers
e62d912b11 Replace GroupService by GroupBuilder in a couple tests 2020-04-06 15:51:44 +02:00
Ben Bosman
10b3b20292 Support for a relationship from type A to type A (parent/child of same type) 2020-04-06 14:00:44 +02:00
Antoine Snyers
b49c86ac49 Whitespace fix 2020-04-06 11:14:58 +02:00
Raf Ponsaerts
4031e41a5d [Task 70080] applied feedback to the scripts and processes functionality 2020-04-06 10:41:51 +02:00
Antoine Snyers
1f3e7f732b Allow the parent object link for members of the group 2020-04-06 10:12:02 +02:00
Mykhaylo
4522618531 renamed class AdministratorFeature to AdministratorOf and added description 2020-04-06 09:40:22 +02:00
Raf Ponsaerts
935a2df27e [DS-4443] moved test to dspace-api. Succeeds in a single run, fails in full test run 2020-04-06 09:09:59 +02:00
Tim Donohue
20ab631541 Upgrade version of m-enforcer-plugin to fix DS-4476 2020-04-03 14:57:31 -05:00
Mykhaylo
a4a9126620 added IT for Administrator feature 2020-04-03 17:31:34 +02:00
Mykhaylo
09b2f0e17a added javadoc 2020-04-03 17:28:53 +02:00
Antoine Snyers
fd573bc094 Checkstyle fix 2020-04-03 16:57:20 +02:00
Antoine Snyers
37abae898a Add license 2020-04-03 16:14:17 +02:00
Mykhaylo
bd0055d563 added ITs for Administrator feature 2020-04-03 14:59:41 +02:00
Antoine Snyers
5d37956b7a Remove ResourceNotFoundException from GroupParentObjectLinkRepository
This caused 404 responses in endpoints that used this link.
2020-04-03 14:47:52 +02:00
Antoine Snyers
d411ef0b40 Merge remote-tracking branch 'upstream/master' into Manage-groups-2 2020-04-03 14:06:04 +02:00
Antoine Snyers
17daf34c47 Update tests, imports, fields and javadoc 2020-04-03 13:59:40 +02:00
Raf Ponsaerts
3389a2c857 [Task 70178] applied feedback to the LoginAs feature 2020-04-03 12:59:32 +02:00
Raf Ponsaerts
d5d1edffb4 [DS-4443] fixed the solr record deletion after workspaceitem removal and added a test for it 2020-04-03 11:11:58 +02:00
Tim Donohue
c2421d136c Merge pull request #2732 from tdonohue/config_override_spring_properties
Allow DSpace's ConfigurationService to override Spring Boot properties
2020-04-02 14:32:18 -05:00
Mykhaylo
1d6f6ef02b added IT to prove that an eperson has same rights when is part of admin group 2020-04-02 18:39:18 +02:00
Mykhaylo
ce2f965b9c implemented Administrator feature 2020-04-02 18:33:27 +02:00
Raf Ponsaerts
563d3f1241 [Task 70148] processed community feedback on Subresource permissions 2020-04-02 16:25:24 +02:00
Raf Ponsaerts
1f6e1e067b [Task 70140] implemented loginOnBehalfOfFeature and tests, cleaned up unneeded code in StatelessAuthenticationFilter 2020-04-02 15:31:13 +02:00
Antoine Snyers
3dc413c366 Make a separate bean for workflowAdmin and clarify the comments in the ITs 2020-04-02 14:29:29 +02:00
Raf Ponsaerts
f11707b83a [Task 69975] applied further feedback to the Collection Groups 2020-04-02 11:35:37 +02:00
Raf Ponsaerts
f3ff763e48 [Task 70144] applied further feedback on the CollectionBuilder 2020-04-02 09:44:14 +02:00
Antoine Snyers
af523ea822 Rearrange imports 2020-04-02 09:19:37 +02:00
Tim Donohue
b40ba0c0e5 Update default configs / comments to document how to use local.cfg to override Spring Boot 2020-04-01 15:22:31 -05:00
Tim Donohue
55fe1a2705 Allow DSpace's ConfigurationService to override Spring Boot properties 2020-04-01 15:22:00 -05:00
Tim Donohue
a80fe4ec13 Merge pull request #2729 from atmire/max-file-size
refactoring max file size
2020-04-01 13:12:34 -05:00
Ben Bosman
bbb3af2a36 Merge remote-tracking branch 'community/master' into w2p-68820_Moving-relationships-ITs 2020-04-01 16:58:29 +02:00
nicholas
5d714a174e include limit and offset when retrieving items for a collection 2020-04-01 09:22:29 -05:00
Raf Ponsaerts
91242285bc [Task 70131] cleanup and futher implement login as feature 2020-04-01 16:20:26 +02:00
Raf Ponsaerts
0f981d2c2b [Task 70144] applied feedback with regards to the collectionGroups and added workflowgroup/workflowRole links to the collections 2020-04-01 15:47:11 +02:00
Antoine Snyers
03427d1cdd Update javadoc 2020-04-01 15:35:36 +02:00
Antoine Snyers
c9b9c7adf3 Let metadata patches for permanent groups work & adjust tests 2020-04-01 15:31:26 +02:00
Raf Ponsaerts
c12d83fb76 [Task 70131] intermediate fixes error handling 2020-04-01 13:37:55 +02:00
Antoine Snyers
d33732ce28 Merge remote-tracking branch 'upstream/master' into Manage-groups-2 2020-04-01 12:58:11 +02:00
Antoine Snyers
eff40c4f82 Update javadoc 2020-04-01 12:40:04 +02:00
Ben Bosman
a74eacefda refactorign max file size: https://docs.spring.io/spring-boot/docs/current/api/org/springframework/boot/autoconfigure/web/servlet/MultipartProperties.html 2020-04-01 12:14:17 +02:00
Antoine Snyers
102a2e8d6a Merge remote-tracking branch 'upstream/master' into workflow-item-read-rights 2020-04-01 11:53:46 +02:00
Raf Ponsaerts
4698ebcdbc [Task 70131] added support for the login as feature and added simple test 2020-03-31 15:55:36 +02:00
Antoine Snyers
40fd23aee9 Update imports 2020-03-31 13:33:45 +02:00
Yana De Pauw
7de0baab8f Fix checkstyle issue 2020-03-31 12:58:36 +02:00
Yana De Pauw
ae4125054e Merge remote-tracking branch 'upstream/master' into w2p-69741_Refactoring-Rest-Converters
Conflicts:
	dspace-server-webapp/src/test/java/org/dspace/app/rest/CollectionRestRepositoryIT.java
2020-03-31 12:58:23 +02:00
Raf Ponsaerts
ca1918ddae [Task 69975] fixed checkstyle 2020-03-31 11:57:23 +02:00
Raf Ponsaerts
17d1b20086 Merge remote-tracking branch 'dspace/master' into w2p-69349_edit-community-assign-roles
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CollectionRestRepository.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CommunityRestRepository.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/CommunityRestRepositoryIT.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/CollectionMatcher.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/CommunityMatcher.java
2020-03-31 11:57:04 +02:00
Yana De Pauw
3c86e46b81 Remove test config for metadata hide 2020-03-31 11:37:26 +02:00
Antoine Snyers
db1ce66b9a Add license to new java file 2020-03-31 11:20:32 +02:00
Raf Ponsaerts
34d8bd33bc [Task 70087] fixed checkstyle after master merge 2020-03-31 10:13:04 +02:00
Raf Ponsaerts
1abdf556bd Merge remote-tracking branch 'dspace/master' into w2p-69976_subresource-permissions
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CommunityCollectionLinkRepository.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CommunityRestRepository.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CommunitySubcommunityLinkRepository.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/CollectionRestRepositoryIT.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/CommunityRestRepositoryIT.java
2020-03-31 10:12:38 +02:00
Tim Donohue
2334a87e3a Merge pull request #2707 from Micheleboychuk/DS-4122_comcol_permissions
DS-4122 Create Integration Tests to prove access restricted Communities/Collections cannot be accessed anonymously
2020-03-30 09:31:03 -05:00
Raf Ponsaerts
c8ea153eb0 [Task 69975] deleting all default read groups after collection deletion in tests 2020-03-30 16:26:51 +02:00
Ben Bosman
165e392910 layout changes 2020-03-30 15:39:03 +02:00
Raf Ponsaerts
5656e35674 [Task 70087] added ITs for the subresource permissions 2020-03-30 14:37:00 +02:00
Raf Ponsaerts
95f1124de5 [Task 70080] implemented generics and DSpaceRunnableClass definition on Spring level and fixed ITs 2020-03-30 11:36:42 +02:00
Tim Donohue
8bcbfd692d Merge pull request #2724 from tdonohue/licensing_updates
Update to LICENSE and NOTICE per LYRASIS merger
2020-03-27 12:15:06 -05:00
Tim Donohue
16ea2b123e Update to LICENSE and NOTICE per LYRASIS merger 2020-03-27 11:11:04 -05:00
Tim Donohue
b6b2e6c800 Merge pull request #2651 from 4Science/dspace-7-shibboleth
Dspace 7 shibboleth (REST)
2020-03-27 09:52:11 -05:00
Raf Ponsaerts
0232916dc5 [Task 70080] applying feedback to scripts and processes splitting config and runnable 2020-03-27 15:03:05 +01:00
Raf Ponsaerts
3492b6d8bc [Task 70058] fixed the tests and checkstyle 2020-03-27 10:05:13 +01:00
Raf Ponsaerts
7e5db83464 [Task 70058] fixed the majority of the tests 2020-03-27 09:10:09 +01:00
Tim Donohue
bfa007cd5d Merge pull request #2721 from DSpace/pull_request_template
Create an initial PR template for DSpace 7
2020-03-26 12:10:32 -05:00
Tim Donohue
77001f9bd4 Merge pull request #2716 from Micheleboychuk/DS-4411-newlyCreatedUsersHaveNoSpecialRights
DS-4411 Create Integration Tests to prove newly created users have no special rights
2020-03-26 12:06:47 -05:00
Raf Ponsaerts
e79caf9970 [Task 70058] start fixing tests + refactor toRestPage methods in utils to properly handle and skip null values 2020-03-26 13:05:03 +01:00
Antoine Snyers
63bacbde32 Add an integration test for the workflowAdmin configuration 2020-03-26 09:52:06 +01:00
Raf Ponsaerts
d36fffa348 [Task 70058] added permisson evaluators for several BaseObjectRest objects 2020-03-26 08:19:09 +01:00
Tim Donohue
df7e523456 Formatting changes & grammar correction 2020-03-25 10:22:30 -05:00
Tim Donohue
c122e9bb5c Fix misspelling 2020-03-25 10:16:22 -05:00
Tim Donohue
807297d00a Reorganize changes/suggestions. Simplify language 2020-03-25 10:03:26 -05:00
Raf Ponsaerts
8099fce15a Merge remote-tracking branch 'dspace/master' into w2p-69349_edit-community-assign-roles 2020-03-25 14:59:43 +01:00
Andrea Bollini
61680db9f9 Add mention about PR size in the checklist 2020-03-25 14:54:50 +01:00
Andrea Bollini
f97834d035 Add extra check and more layout for our template 2020-03-25 14:52:09 +01:00
Antoine Snyers
224d252f1a Add comments to discovery.xml config and move constants to plugin class 2020-03-25 14:13:03 +01:00
Raf Ponsaerts
e4a6331699 [Task 69976] start fixing tests and permission checks 2020-03-25 14:01:51 +01:00
Giuseppe Digilio
671faf3569 Fixed checkstyle violations 2020-03-25 10:28:40 +01:00
Raf Ponsaerts
984de8434d [Task 69976] moved uppercase instance to RestObjectPermissionEvaluatorPlugin and hid null values from the paged list 2020-03-25 09:30:21 +01:00
Tim Donohue
29910ee6c9 Create an initial PR template for DSpace 7 2020-03-24 15:28:20 -05:00
Giuseppe Digilio
0d7ba9b841 Merge remote-tracking branch 'origin/master' into dspace-7-shibboleth 2020-03-24 21:25:50 +01:00
Tim Donohue
15aacd0234 Merge pull request #2715 from atmire/w2p-69710_port-longname-mandatory
[Scripts & processes] Adding mandatory / longname options to rest output
2020-03-24 14:30:03 -05:00
Raf Ponsaerts
60afa23106 [Task 69975] fixed tests 2020-03-24 16:27:47 +01:00
Raf Ponsaerts
f5ccb432f2 [Task 69976] initial implementation of extra permission check for subresources 2020-03-24 14:44:34 +01:00
Antoine Snyers
516c7b39a9 Make patch completely unprocessable for specific groups 2020-03-24 13:51:29 +01:00
Andrea Bollini
94706cfcc2 Fix checkstyle issue after update to 8.30, move comments closer to the relevant code 2020-03-24 12:21:29 +01:00
Andrea Bollini
ef4a33b584 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4122_comcol_permissions 2020-03-24 12:18:16 +01:00
Mykhaylo
db7f9c5c08 fix checkstyle issue 2020-03-24 12:16:36 +01:00
Raf Ponsaerts
6a7f998385 Intermediate Commit 2020-03-24 12:06:29 +01:00
Raf Ponsaerts
e6c8c3d45c Merge remote-tracking branch 'dspace/master' into w2p-69349_edit-community-assign-roles 2020-03-24 11:00:45 +01:00
Mykhaylo
2e8fef4d71 added a comment 2020-03-24 10:41:37 +01:00
Yana De Pauw
9df42b3dea Merge remote-tracking branch 'upstream/master' into w2p-69741_Refactoring-Rest-Converters
Conflicts:
	dspace-server-webapp/src/test/java/org/dspace/app/rest/ItemRestRepositoryIT.java
2020-03-23 16:10:53 +01:00
Raf Ponsaerts
25ca31f8cf [Task 69724] Scripts&Processes: cleanup and javadoc 2020-03-23 14:44:55 +01:00
Raf Ponsaerts
e9d56e7c41 [Task 69724] Scripts&Processes: split configuration and runnable 2020-03-23 14:13:11 +01:00
Tim Donohue
0039b309d1 Merge pull request #2663 from 4Science/DS-4413_authz
Initial implementation of the authorizations endpoints
2020-03-23 07:37:41 -05:00
Raf Ponsaerts
c5285109e9 Merge remote-tracking branch 'dspace/master' into w2p-64428_scripts-prototype-importing-and-exporting
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/link/process/ProcessResourceHalLinkFactory.java
2020-03-23 11:32:01 +01:00
Andrea Bollini
c9bca71bbf Add extra check to verify that the returned feature is the expected one 2020-03-23 11:30:58 +01:00
Antoine Snyers
7e5a2f3698 Make delete unprocessable for specific groups 2020-03-23 11:29:35 +01:00
Antoine Snyers
e47ad74e35 Implement the GroupNameReplaceOperation 2020-03-23 10:23:54 +01:00
Yana De Pauw
9a03eb8d6d 69944: ITs for metadata.hide 2020-03-23 10:06:41 +01:00
Andrea Bollini
95504b4121 Fix checkstyle issues 2020-03-20 21:46:48 +01:00
Andrea Bollini
5e2fc68fbd Code cleanup - removed unused special group lists 2020-03-20 19:04:09 +01:00
Andrea Bollini
8cced80df3 Merge branch 'master' of https://github.com/DSpace/DSpace into authz 2020-03-20 18:35:42 +01:00
Andrea Bollini
59b7716725 Add expected embedded in the search test 2020-03-20 18:28:30 +01:00
Raf Ponsaerts
f5fb694e85 [Task 69689] added and fixed tests for the Collection Groups 2020-03-20 16:52:11 +01:00
Tim Donohue
eeb12583d5 Merge pull request #2680 from atmire/w2p-68732_list-version-history
Read only versioning endpoints
2020-03-20 10:37:20 -05:00
Tim Donohue
01067fa941 Merge pull request #2718 from 4Science/fix_checkstyle830
Fix checkstyle issues after merge 8.30
2020-03-20 07:28:10 -05:00
Raf Ponsaerts
0541a25d2f Fixed various tests 2020-03-20 13:08:27 +01:00
Andrea Bollini
efacb481c1 Fix checkstyle issues after merge 8.30 2020-03-20 12:24:14 +01:00
Antoine Snyers
227317bbe0 Test for Unprocessable status for permanent group names 2020-03-20 11:37:36 +01:00
Raf Ponsaerts
27d09d1f66 Intermediate Commit 2020-03-20 11:29:16 +01:00
Raf Ponsaerts
541a9d7ce4 checkstyle fixes 2020-03-20 11:00:07 +01:00
Raf Ponsaerts
1d4781a772 Merge remote-tracking branch 'dspace/master' into w2p-68732_list-version-history
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/WorkflowItemRestRepository.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/WorkspaceItemRestRepository.java
2020-03-20 10:59:55 +01:00
Antoine Snyers
c2ea8a0eeb Test for Unprocessable status and adjust code style 2020-03-20 10:04:13 +01:00
Raf Ponsaerts
a73e4cbd37 [Task 69916] submitter name exposure change 2020-03-20 09:44:56 +01:00
Raf Ponsaerts
2d048d7df8 Intermediate Commit 2020-03-20 08:25:13 +01:00
Andrea Bollini
8c234d1a5c Merge pull request #2711 from tdonohue/upgrade_checkstyle
Upgrade to Checkstyle v8.30
2020-03-19 14:24:37 +01:00
Yana De Pauw
1b5761f2b9 69741: Restrict metadata exposure acccording to hidden metadata configuration 2020-03-19 13:40:24 +01:00
Antoine Snyers
cc471c4f50 Add the SolrServiceWorkspaceWorkflowRestrictionPlugin and the workflowAdmin bean
This moves some workspace and workflow specific code from SolrServiceImpl to
the new SolrServiceWorkspaceWorkflowRestrictionPlugin. This also updates the
SolrServiceResourceRestrictionPlugin to restrict those records based on read
rights as well.
2020-03-18 15:54:49 +01:00
Tim Donohue
084d307575 Merge pull request #2717 from 4Science/DS-4462-7_x
[DS-4462] fix CREATEDATE format using the correct specifiers
2020-03-18 09:52:52 -05:00
Raf Ponsaerts
b5c8afefee [Task 69689] fixed the workflow groups endpoints 2020-03-18 15:17:34 +01:00
Mykhaylo Boychuk
9ce5c58626 Implement community feedback 2020-03-17 17:46:04 +01:00
Ben Bosman
932664650c Using token since workspace security is now in place 2020-03-17 17:24:11 +01:00
Ben Bosman
d4cc5f4587 Using token since workspace security is now in place 2020-03-17 16:41:10 +01:00
Raf Ponsaerts
2f741081d0 [Task 69689] added various endpoints for Group management 2020-03-17 16:28:30 +01:00
Ben Bosman
9dc0c1ad3d Merge remote-tracking branch 'community/master' into w2p-68820_Moving-relationships-ITs 2020-03-17 15:50:59 +01:00
Tim Donohue
6b418d6abc Merge pull request #2675 from Micheleboychuk/revisitSecurityLayerOfSubmission-DS-4043
DS-4043 Revisit security layer of submission
2020-03-17 09:08:54 -05:00
Mykhaylo
56a5a0369e newly created account hasn't groups 2020-03-17 10:26:05 +01:00
Luigi Andrea Pascarelli
26d4e569ec [DS-4462] fix CREATEDATE format using the correct specifiers 2020-03-16 18:46:12 +01:00
Andrea Bollini
f0210c5a46 encapsulate the logic to switch current user in the context class 2020-03-16 18:36:38 +01:00
Mykhaylo
3d668d7134 added IT in ItemOwningCollectionUpdateRestControllerIT 2020-03-16 18:26:22 +01:00
Mykhaylo
a7ea0f6e16 normal user must be able to check the configuration 2020-03-16 18:19:21 +01:00
Mykhaylo Boychuk
5698cfd4bd Merge branch 'master' into DS-4411-newlyCreatedUsersHaveNoSpecialRights 2020-03-16 18:06:02 +01:00
Mykhaylo
e1b4712e73 Merge branch 'master' into DS-4411-newlyCreatedUsersHaveNoSpecialRights 2020-03-16 18:00:16 +01:00
Mykhaylo
8a6246038b fix typo, use the normal user token 2020-03-16 15:59:47 +01:00
Antoine Snyers
65a1a2d15e GET /api/eperson/groups/<:uuid>/object 2020-03-16 10:55:27 +01:00
Mykhaylo
8bdd0a3dae Merge branch 'master' into revisitSecurityLayerOfSubmission-DS-4043 2020-03-14 00:45:35 +01:00
Mykhaylo
676558ad89 fixed output message of RuntimeException 2020-03-13 23:05:05 +01:00
Giuseppe Digilio
0951d0ae07 Added comments for authentication-shibboleth.lazysession.loginurl in authentication-shibboleth.cfg 2020-03-13 19:40:43 +01:00
Giuseppe Digilio
1a3bce8eab Added methods to test shibboleth url using port 2020-03-13 19:33:13 +01:00
Giuseppe Digilio
2044d33908 Use configurationService to set default authentication-shibboleth.lazysession.loginurl in getShibURL method 2020-03-13 19:31:50 +01:00
Giuseppe Digilio
d665125788 Added port to getBaseUrl 2020-03-13 19:30:45 +01:00
Raf Ponsaerts
4ebb94e520 [Task 69710] added longname and mandatory to parametermatcher 2020-03-13 15:57:34 +01:00
Antoine Snyers
de79405b74 DELETE /api/eperson/groups/<:uuid> 2020-03-13 15:38:49 +01:00
Raf Ponsaerts
4c959d407b [Task 69710] implemented mandatory and longname for parameterRest objects 2020-03-13 15:35:59 +01:00
Raf Ponsaerts
ff63e6b464 [Task 69684] added javadoc and fixed that dc.title can't be set for AdminGroup 2020-03-13 14:38:43 +01:00
Raf Ponsaerts
b19c4022ac Javadocs 2020-03-13 13:43:54 +01:00
Raf Ponsaerts
32d48ecff7 [Task 69638] removed the VersionController, made it into the LinkRepository plus added framework to disallow linksto be created 2020-03-13 13:38:51 +01:00
Giuseppe Digilio
3989987a41 Merge remote-tracking branch 'origin/master' into dspace-7-shibboleth 2020-03-13 12:52:19 +01:00
Mykhaylo
5d98bcd911 Implement community feedback 2020-03-12 22:21:17 +01:00
Tim Donohue
380bc34e5a Merge pull request #2686 from atmire/Manage-groups
Manage groups and EPeople
2020-03-12 14:07:12 -05:00
Tim Donohue
390264894c Merge pull request #2706 from atmire/w2p-69316_Add-2-facets--withdrawn-and-discoverable
Discovery index for private and withdrawn items
2020-03-12 13:47:02 -05:00
Ben Bosman
c5bf6ec80d Renaming discoverableAndUndiscoverableItems to administrativeView 2020-03-12 17:50:23 +01:00
Mykhaylo
46e532218c Merge branch 'master' into revisitSecurityLayerOfSubmission-DS-4043 2020-03-12 17:45:50 +01:00
Ben Bosman
82df51f06e JavaDocs fix 2020-03-12 17:35:43 +01:00
Tim Donohue
33b33c0b52 Merge pull request #2689 from Micheleboychuk/DS-4278
DS-4278 Submitters can edit all metadata
2020-03-12 11:23:49 -05:00
Chris Wilper
c0cb7a5f48 DS-4457 Avoid smtp authentication by default 2020-03-12 11:54:17 -04:00
Raf Ponsaerts
d072654ae6 [Task 69638] made the controller check the property, added tests, added extra check on the resource link addition 2020-03-12 16:19:23 +01:00
Tim Donohue
4ab134b632 Merge pull request #2685 from atmire/w2p-68726_Workflow-IT-in-rest
Workflow step definitions: action validation
2020-03-12 09:47:30 -05:00
Tim Donohue
a0a2c9950a Explain why submitter cannot use PATCH on in progress item 2020-03-12 09:37:42 -05:00
Yana De Pauw
e7702b14e0 69673: rename /groups to /subgroups 2020-03-12 15:32:02 +01:00
Raf Ponsaerts
c98bd13129 Merge remote-tracking branch 'dspace/master' into w2p-68732_list-version-history
Conflicts:
	dspace-server-webapp/src/test/java/org/dspace/app/rest/WorkflowItemRestRepositoryIT.java
	dspace-server-webapp/src/test/java/org/dspace/app/rest/WorkspaceItemRestRepositoryIT.java
2020-03-12 13:44:21 +01:00
Mykhaylo
9bf24e7ffa added attribute param in IT and added check that allow READ request 2020-03-12 12:03:58 +01:00
Samuel
f3aef56149 Discovery index for private and withdrawn items - feedback 2020-03-12 11:50:23 +01:00
Yana De Pauw
dc42d3e9b4 69609: Process IRUS DSpace 7 PR feedback 2020-03-12 11:37:03 +01:00
Marie Verdonck
65943dc0d6 Process feedback: Exception messages, renamed method & comment fix restored 2020-03-12 10:52:05 +01:00
Tim Donohue
4b54c6fc3c Fix new checkstyle failures for "CustomImportOrder: Extra separation in import group before.." 2020-03-11 15:34:48 -05:00
Mykhaylo
e22bb5d94d removed attribute param("projection","full") from IT 2020-03-11 16:58:40 +01:00
Tim Donohue
8a1e97d5f7 Upgrade to checkstyle v8.30, and minor changes to checkstyle.xml to support that version 2020-03-11 10:51:11 -05:00
Mykhaylo
37d5b13dd5 Merge branch 'revisitSecurityLayerOfSubmission-DS-4043' of https://github.com/Micheleboychuk/DSpace into revisitSecurityLayerOfSubmission-DS-4043 2020-03-11 14:46:28 +01:00
Mykhaylo
3017333024 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4278
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/WorkspaceItemRestRepositoryIT.java
2020-03-11 14:39:47 +01:00
Mykhaylo
0c4cfd997a added one IT to BitstreamControllerIT 2020-03-11 12:28:47 +01:00
Yana De Pauw
886d2fe4de Merge remote-tracking branch 'upstream/master' into DS-626 2020-03-11 11:51:23 +01:00
Mykhaylo
488e8369b1 fixed checkstyle errors 2020-03-11 11:17:02 +01:00
Tim Donohue
ddfb4f832d Merge pull request #2708 from anis-moubarik/mets-xslt-upgrade
[DS-4404] Explicitly initialize TransformerFactory with the Saxon transformer in OAI
2020-03-10 15:25:10 -05:00
Yana De Pauw
7f5a178036 69409: Implement community feedback 2020-03-10 18:13:09 +01:00
Andrea Bollini
2e7a12e166 Fix unnoted merge conflict by git 2020-03-10 18:00:52 +01:00
Tim Donohue
323990a3fc Merge pull request #2701 from atmire/w2p-69114_workflow-action-expose-from-claimed-pooled-task
Expose the action and step as an embed on workflow related objects
2020-03-10 11:17:11 -05:00
Raf Ponsaerts
37d32d5863 Added javadoc to the StepLinkRepositories 2020-03-10 15:03:38 +01:00
Raf Ponsaerts
8f78381ae9 [Task 69349] changed communityAdmin check and added tests 2020-03-10 14:26:35 +01:00
Yana De Pauw
542a40ac1c 69428: workflow groups getCollection fix 2020-03-10 13:57:23 +01:00
Mykhaylo
87bc6a24ea Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4122_comcol_permissions
# Conflicts:
#	dspace-api/src/test/data/dspaceFolder/config/spring/api/workflow.xml
#	dspace-api/src/test/java/org/dspace/xmlworkflow/XmlWorkflowFactoryTest.java
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CollectionRestRepository.java
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CommunityRestRepository.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/ItemOwningCollectionUpdateRestControllerIT.java
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/builder/CommunityBuilder.java
2020-03-10 13:18:51 +01:00
Raf Ponsaerts
02cb339bb8 [Task 69349] fixed community and collection tests with new embed parameter instead of full projection 2020-03-10 11:49:13 +01:00
Anis
06daae307c Update the test as well 2020-03-10 12:44:35 +02:00
Anis
ab265f6c63 Explicitly initialize TransofmerFactory with the Saxon transformer in OAI 2020-03-10 12:13:05 +02:00
Mykhaylo
524fcf212a added ITs to prove newly created users have no special rights 2020-03-10 10:02:32 +01:00
Andrea Bollini
82d4908d62 Merge branch 'master' of https://github.com/DSpace/DSpace into authz 2020-03-10 09:58:20 +01:00
Raf Ponsaerts
b5bfbce1ea Merge remote-tracking branch 'dspace/master' into w2p-69349_edit-community-assign-roles 2020-03-10 09:31:44 +01:00
Raf Ponsaerts
7c15049da1 [Task 69349] working implementation adminGroups get, post, delete. Tests unfinished 2020-03-09 16:43:38 +01:00
Tim Donohue
2adb3143ce Merge pull request #2670 from atmire/DS-4433_Specify-embeds
DS-4433 Specify embeds
2020-03-09 10:04:00 -05:00
Tim Donohue
1bc6e97286 Merge pull request #2705 from tdonohue/keep_line_endings_sh_bat
Ensure *.sh and *.bat files keep line endings by default
2020-03-09 08:48:34 -05:00
Ben Bosman
0ac969b751 taskid 69316 Add 2 facets: withdrawn and discoverable 2020-03-09 11:40:32 +01:00
Andrea Bollini
4192b09d10 Add test for null object in isAuthorized 2020-03-08 19:21:27 +01:00
Andrea Bollini
616323a887 Add test for the AuthorizationFeatureService 2020-03-08 19:11:43 +01:00
Andrea Bollini
ace118a722 Fix special groups scenario 2020-03-08 17:43:28 +01:00
Andrea Bollini
db2257e6bf Add test related to the specialGroups 2020-03-08 17:41:52 +01:00
Andrea Bollini
d63493905b Javadoc cleanup, force projection in test that need it 2020-03-08 16:42:01 +01:00
Tim Donohue
66d5834429 Ensure *.sh and *.bat files keep line endings by default 2020-03-06 15:50:13 -06:00
Samuel
bdc6cb9026 taskid 69316 Add 2 facets: withdrawn and discoverable - fix checkstyle 2020-03-06 17:16:20 +01:00
Samuel
8a3e2573ec taskid 69316 Add 2 facets: withdrawn and discoverable tris 2020-03-06 16:19:24 +01:00
Samuel
cb38cb9141 taskid 69316 Add 2 facets: withdrawn and discoverable bis 2020-03-06 14:51:35 +01:00
Samuel
82069b3f52 taskid 69316 Add 2 facets: withdrawn and discoverable 2020-03-06 14:46:47 +01:00
Raf Ponsaerts
ef386fb5cb [Task 69343] added comments to the properties in rest.cfg 2020-03-06 14:30:27 +01:00
Yana De Pauw
3802095643 Merge remote-tracking branch 'upstream/master' into Manage-groups 2020-03-06 11:45:58 +01:00
Raf Ponsaerts
e0577e7322 [Task 69343] applied the feedback with regards to the specific embed functionality 2020-03-06 11:16:59 +01:00
Marie Verdonck
222d769d37 reinstated indents of master 2020-03-06 10:55:56 +01:00
Marie Verdonck
f0863a0505 only do step of workflow whose action is being tested 2020-03-06 10:40:10 +01:00
Mykhaylo
1f9f8510b4 added check for IndexableDSpaceObject & fix minor bugs 2020-03-05 22:29:35 +01:00
Yana De Pauw
5c6be96c9b Change FindByEmail no parameter test to BadRequest 2020-03-05 18:32:27 +01:00
Yana De Pauw
73798fe0b6 Merge branch 'master' into Manage-groups 2020-03-05 17:31:40 +01:00
Andrea Bollini
8e975bc228 Rename FindableObjectRepository in ReloadableEntityObjectRepository 2020-03-05 17:31:27 +01:00
Yana De Pauw
8e6ce081d6 Merge branch 'w2p-68781_Manage-groups-READ-only' into Manage-groups 2020-03-05 17:31:17 +01:00
Yana De Pauw
183a92c413 68781: Change eperson/uuid/groups to only return direct groups 2020-03-05 16:06:58 +01:00
Mykhaylo
b838ce4a6e DS-4043 Revisit security layer of submission 2020-03-05 11:18:58 +01:00
Yana De Pauw
3b1ef6ef0a 68781: Re-add findByEmail 2020-03-05 11:16:36 +01:00
Mykhaylo
1fdb728672 Merge branch 'master' of https://github.com/DSpace/DSpace into revisitSecurityLayerOfSubmission-DS-4043 2020-03-05 10:52:23 +01:00
benbosman
50847855b2 Merge pull request #18 from atmire/w2p-69256_workflow-steps-expose-from-claimed-and-pooled-tasks
[Task 69256] made the Step into a link/embed on ClaimedTasks, PoolTas…
2020-03-05 10:31:56 +01:00
Mykhaylo
0d8f494863 added IT that prove newly created account has no groups 2020-03-05 09:42:05 +01:00
Tim Donohue
7382afb85a Merge pull request #2627 from anis-moubarik/mets-xslt-upgrade
[DS-4404] Upgrade Mets crosswalk for oai to xslt 2.0
2020-03-04 14:21:59 -06:00
Tim Donohue
b0f9900c4b Merge pull request #2665 from Micheleboychuk/resourcepolicy-DS-4418
DS-4418 remove uuid from resource policy rest
2020-03-04 12:58:32 -06:00
Tim Donohue
d0ced1d94f Merge pull request #2688 from Micheleboychuk/ITforBitstream-DS-4124
DS-4124: Add ITs to prove access restricted Bitstreams cannot be accessed anonymously
2020-03-04 12:52:17 -06:00
Tim Donohue
315baa1b1e Merge pull request #2687 from Micheleboychuk/ITtoProveAccessRestrictedItem-DS-4123
DS-4123: ITs to prove access restricted Items cannot be accessed anonymously
2020-03-04 12:46:21 -06:00
Raf Ponsaerts
d7e91e8e4c [Task 69256] made the Step into a link/embed on ClaimedTasks, PoolTasks and WorkflowItems 2020-03-04 17:01:14 +01:00
benbosman
3c01cc2a80 Merge pull request #17 from atmire/w2p-69133_refactoring-and-its-specific-embeds-refactor
W2p 69133 refactoring and its specific embeds refactor
2020-03-04 13:06:23 +01:00
Raf Ponsaerts
20fa413ad8 [Task 69284] fully refactored the SpecificLevelProjection and tests 2020-03-04 12:01:06 +01:00
kshepherd
08e6d247b1 Merge pull request #2454 from tdonohue/DS-4073
DS-4073 fix. FindByValue should pass in value, not qualifier.
2020-03-04 10:22:10 +13:00
Tim Donohue
8fb5d1e90e [maven-release-plugin] prepare for next development iteration 2020-03-03 12:08:09 -06:00
Tim Donohue
80cd821f20 [maven-release-plugin] prepare release dspace-7.0-beta1 2020-03-03 12:07:57 -06:00
Raf Ponsaerts
767274b98b [Task 69271] fixes after master merge 2020-03-03 14:26:39 +01:00
Raf Ponsaerts
0829cf5b51 Merge remote-tracking branch 'dspace/master' into w2p-68732_list-version-history 2020-03-03 13:17:00 +01:00
Raf Ponsaerts
fe664b3f6c Example of different implementation for specificLevelEmbed 2020-03-03 13:06:07 +01:00
Raf Ponsaerts
39c792caf0 [Task 69270] applied the feedback with regards to the projections.xml, spring-dspace-core-services.xml and test comments 2020-03-03 11:27:11 +01:00
Tim Donohue
3e3356d785 Merge pull request #2697 from tdonohue/disable_old_rest
DS-4303: Disable "dspace-rest" from default build. Add more deprecation warnings
2020-03-02 15:21:09 -06:00
Toni Prieto
8fb214c061 change import order 2020-03-02 18:46:55 +01:00
Mykhaylo
2b13edb143 fix typo in solr field name 2020-03-02 18:44:32 +01:00
Toni Prieto
c2df412e94 Remove unused import 2020-03-02 18:02:50 +01:00
Toni Prieto
db09fac216 Add StripDiacritics to OrderFormat classes for author and text and normalize the starts_with param text submitted 2020-03-02 17:09:06 +01:00
Mykhaylo
e42382b4ab Merge branch 'revisitSecurityLayerOfSubmission-DS-4043' of https://github.com/Micheleboychuk/DSpace into revisitSecurityLayerOfSubmission-DS-4043
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/WorkspaceItemRestRepositoryIT.java
2020-03-02 17:00:51 +01:00
Mykhaylo
a19f24beba Merge branch 'resourcepolicy-DS-4418' of https://github.com/Micheleboychuk/DSpace into revisitSecurityLayerOfSubmission-DS-4043
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/WorkspaceItemRestRepositoryIT.java
2020-03-02 16:43:10 +01:00
Mykhaylo
5ac981f877 Merge branch 'ITtoProveAccessRestrictedItem-DS-4123' of https://github.com/Micheleboychuk/DSpace into ITforBitstream-DS-4124 2020-03-02 15:00:41 +01:00
Mykhaylo
f7a9d9262e code cleanup - community feedback 2020-03-02 14:59:18 +01:00
Raf Ponsaerts
53149bb65b [Task 69114] exposed the action as an embed on claimedtasks 2020-03-02 13:32:09 +01:00
Mykhaylo
1639ac749c Merge branch 'ITtoProveAccessRestrictedItem-DS-4123' of https://github.com/Micheleboychuk/DSpace into DS-4278 2020-03-02 11:39:16 +01:00
Raf Ponsaerts
e659c199d8 [Task 69133] added tests for Projections level and specific embed; applied small refactors to beans 2020-03-02 11:06:14 +01:00
Mykhaylo
ac61bd0cac Merge branch 'master' of https://github.com/DSpace/DSpace into ITtoProveAccessRestrictedItem-DS-4123
# Conflicts:
#	dspace-server-webapp/src/test/java/org/dspace/app/rest/builder/CommunityBuilder.java
2020-03-02 10:08:18 +01:00
Mykhaylo
be3d51cd82 Merge branch 'master' of https://github.com/DSpace/DSpace into resourcepolicy-DS-4418 2020-03-02 09:44:50 +01:00
Tim Donohue
a7954aa697 Ensure Travis CI always builds/tests dspace-rest 2020-02-28 13:06:08 -06:00
Tim Donohue
501233f4ed Additional deprecation warnings in key places of dspace-rest 2020-02-28 12:23:54 -06:00
Tim Donohue
e02883afe2 Update Dockerfiles per disabled dspace-rest module 2020-02-28 12:23:29 -06:00
Tim Donohue
d14d6ecaae Disable dspace-rest by default 2020-02-28 12:23:10 -06:00
Mykhaylo Boychuk
90688555b8 code cleanup - community feedback 2020-02-28 18:03:18 +01:00
Tim Donohue
880ed67732 Merge pull request #2673 from atmire/w2p-68607_add-link-to-parent-community
[DS-3532] Breadcrumbs in header
2020-02-28 10:36:02 -06:00
Mykhaylo Boychuk
353b12034c code cleanup - community feedback 2020-02-28 16:50:01 +01:00
Mykhaylo Boychuk
bece88f977 implemented plugin for indexing parent object of Community/Collection/Item 2020-02-28 16:19:34 +01:00
Mykhaylo Boychuk
f7a12ab3d3 added indexing for ADMIN policies 2020-02-28 16:16:18 +01:00
Mykhaylo Boychuk
b15001b54e added Solr query inside findAll() for Community/Collection Repositories 2020-02-28 16:12:58 +01:00
Mykhaylo Boychuk
67a48dbd71 implemented Solr query for CommunityCollectionLinkRepository 2020-02-28 16:07:27 +01:00
Mykhaylo Boychuk
38b89d85ae implemented Solr query for SubCommunityLinkRepository 2020-02-28 16:05:54 +01:00
Mykhaylo Boychuk
3bbe68cc73 added ITs to prove access restricted Communities/Collections cannot be accessed anonymously 2020-02-28 16:01:26 +01:00
Raf Ponsaerts
af5abeb524 Merge remote-tracking branch 'origin/w2p-68607_add-link-to-parent-community' into w2p-69133_refactoring-and-its-specific-embeds 2020-02-28 15:36:03 +01:00
Raf Ponsaerts
ba76270bea Merge remote-tracking branch 'origin/DS-4433_Specify-embeds-Continued-2' into w2p-69133_refactoring-and-its-specific-embeds 2020-02-28 15:35:08 +01:00
Raf Ponsaerts
ccf8aa905c Merge remote-tracking branch 'dspace/master' into w2p-68607_add-link-to-parent-community
Conflicts:
	dspace-server-webapp/src/test/java/org/dspace/app/rest/WorkspaceItemRestRepositoryIT.java
2020-02-28 15:12:04 +01:00
Raf Ponsaerts
2a54bfab40 [Task 69156] applied feedback to the breadcrumbs tests 2020-02-28 14:34:32 +01:00
Tim Donohue
9f0ba4914a Merge pull request #2684 from atmire/DS-4438_ProjectionsForPOSTRequests
DS-4438 Respect client-provided projections for non-GETs
2020-02-27 11:40:47 -06:00
Andrea Bollini
0403f45dc1 improve the comments clarifying the null scenario 2020-02-27 15:40:14 +01:00
Andrea Bollini
9e08df614a add description to the features 2020-02-27 15:39:50 +01:00
Andrea Bollini
cb83c4c161 Clarify the reason of the sleep time 2020-02-27 15:31:10 +01:00
Andrea Bollini
be410e2cb8 improve comments about all the managed scenarios 2020-02-27 15:19:34 +01:00
Raf Ponsaerts
abf82a3f46 [Task 69130] applied feedback to the breadcrumbs functionality 2020-02-27 15:01:21 +01:00
Kevin Van de Velde
d33115fde9 Merge branch 'master' into w2p-68726_Workflow-IT-in-rest 2020-02-26 16:29:40 +01:00
Mykhaylo Boychuk
61e927ed94 refactored tests 2020-02-26 11:23:53 +01:00
Mykhaylo Boychuk
00fe4b6bcb added check to prove that community/collection are public 2020-02-25 18:32:32 +01:00
Mykhaylo Boychuk
3bc6346a5b added ITs to prove access restricted for /api/core/communities/<:uuid>/collections 2020-02-25 18:28:17 +01:00
Mykhaylo Boychuk
ee3d379176 added matcher for Collection 2020-02-25 18:26:53 +01:00
Yana De Pauw
9b442743b6 69108: Fix comments 2020-02-25 13:32:28 +01:00
Mykhaylo Boychuk
1b0e21496a added ITs to prove access restricted for /api/core/communities/<:uuid>/subcommunities 2020-02-25 12:23:06 +01:00
benbosman
373e8e1603 Merge pull request #2646 from atmire/workflow-step-definitions
Workflow step definitions
We're at +2 and Tim's feedback has been processed
2020-02-25 11:55:53 +01:00
Raf Ponsaerts
06f5199ec7 Re-adding javadoc to the CollectionParentCommunityLinkRepository 2020-02-25 11:38:16 +01:00
Yana De Pauw
af2f1ee15b 68919: Add replace tests 2020-02-25 11:30:43 +01:00
Raf Ponsaerts
b963622191 Merge remote-tracking branch 'dspace/master' into w2p-68607_add-link-to-parent-community 2020-02-25 11:19:25 +01:00
Raf Ponsaerts
c1d7edafbe [Task 68945] processed feedback on breadcrumbs ITs 2020-02-25 11:18:08 +01:00
Marie Verdonck
ba6792a43c is(HttpStatus.SC_BAD_REQUEST) to isBadRequest() 2020-02-25 10:40:16 +01:00
Marie Verdonck
3f43e3e807 is(HttpStatus.SC_BAD_REQUEST) to isBadRequest() 2020-02-25 10:38:28 +01:00
Mykhaylo Boychuk
da48afa6b5 added ITs to prove access restricted for /api/core/communities/<:uuid> 2020-02-25 09:13:43 +01:00
Tim Donohue
9910d89caa Merge pull request #2690 from tdonohue/update_oai
DS-4380:  Update XOAI (OAI-PMH) for full JDK11 compatibility
2020-02-24 11:24:06 -06:00
Yana De Pauw
f940a9facb Fix broken tests and checkstyles 2020-02-24 17:43:54 +01:00
Tim Donohue
d78f3c393b Minor refactor to make it easier to debug OAI Solr connection problems. Update to new config format 2020-02-24 10:35:14 -06:00
Tim Donohue
8cceea8f06 Upgrade to XOAI 3.3.0 for JDK11 compatibility. 2020-02-24 10:35:05 -06:00
Marie Verdonck
928987b393 Merge branch 'workflow-step-definitions' into w2p-68726_Workflow-IT-in-rest 2020-02-24 15:52:48 +01:00
Marie Verdonck
8a83d344f5 checkstyle 2020-02-24 15:52:37 +01:00
Samuel
abb88985d0 taskid 68861-68862 Manage groups (REST) - Create groups and manage group2group - Manage group2eperson and EPerson 2020-02-24 15:43:17 +01:00
Yana De Pauw
e53bc8af28 68781: Update groups and epersons GETS based on REST contract 2020-02-24 15:43:17 +01:00
Yana De Pauw
0691330d84 68851: Add test to Remove metadata through PATCH 2020-02-24 15:23:53 +01:00
Marie Verdonck
de10769595 Merge branch 'workflow-step-definitions' into w2p-68726_Workflow-IT-in-rest 2020-02-24 15:11:05 +01:00
Marie Verdonck
c4548d3c61 missing licenses 2020-02-24 15:10:46 +01:00
Marie Verdonck
d3680b1a36 Merge branch 'workflow-step-definitions' into w2p-68726_Workflow-IT-in-rest 2020-02-24 14:33:43 +01:00
Marie Verdonck
ffc1505f01 LinkRepositories so that subresources paths work without projection=full (for workflowdefinitions/defaultWorkflow/steps and /workflowsteps/editstep/actions) 2020-02-24 14:29:04 +01:00
Marie Verdonck
e0acfbc6e4 constant for expected http status 2020-02-24 13:27:08 +01:00
Marie Verdonck
d395be6a3e test fix after master merge 2020-02-24 13:24:07 +01:00
Marie Verdonck
ff30538dad Merge remote-tracking branch 'dspace-origin/master' into workflow-step-definitions
# Conflicts:
#	dspace-api/src/test/java/org/dspace/xmlworkflow/XmlWorkflowFactoryTest.java
2020-02-24 12:55:58 +01:00
Yana De Pauw
6748d63bba 68850: Add tests for adding authors on different places on workspace item 2020-02-24 12:52:07 +01:00
Giuseppe Digilio
a49bf4b343 Replace ConfigurationManager with ConfigurationService 2020-02-24 10:15:50 +01:00
Giuseppe Digilio
0fee734a2a Fixed default value of authentication-shibboleth.lazysession.loginurl 2020-02-24 10:15:11 +01:00
Giuseppe Digilio
8cbe3e1f30 Added getBaseUrl to Utils 2020-02-24 10:02:49 +01:00
Mykhaylo Boychuk
2209d76dfd added check for prevent access to item, if it in workspace 2020-02-23 19:20:40 +01:00
Mykhaylo Boychuk
5d9b600e08 added ITs to prove restricted access for submitter to editing metadata fields from the submission forms, if he use the /api/core/items endpoint 2020-02-23 19:15:00 +01:00
Andrea Bollini
22a2b12aa8 DS-4418 extra javadoc and clarified the name of the path operations over bitstream's policies 2020-02-22 22:35:22 +01:00
Andrea Bollini
adfe2b6959 Move the getBaseObjectRestFromUri method to the Utils class and add javadoc 2020-02-22 17:26:46 +01:00
Andrea Bollini
61cd471079 remove unused field 2020-02-22 17:04:29 +01:00
Andrea Bollini
81b9a18e81 Enable additional test for bad request 2020-02-22 17:02:53 +01:00
Andrea Bollini
2726bc6277 Merge branch 'master' of https://github.com/DSpace/DSpace into authz 2020-02-22 16:52:13 +01:00
Andrea Bollini
d797ab0407 track the reset of the local.cfg file 2020-02-22 16:40:47 +01:00
Andrea Bollini
6acfd30d15 Code cleanup and improved documentation 2020-02-22 16:40:08 +01:00
Andrea Bollini
de8e3ec93b Add IT to proof that the AuthorizeConfiguration support the config reload 2020-02-22 15:39:20 +01:00
Kristof De Langhe
a66b5225ad 68820: PatchMetadataIT JavaDocs + header 2020-02-21 17:27:25 +01:00
Andrew Wood
738365d94f DS-4438 Update ITs check for projections from POST request 2020-02-21 11:26:18 -05:00
Kristof De Langhe
42e0f2fb23 68820: Moving relationships in workspace items ITs 2020-02-21 14:18:54 +01:00
Mykhaylo Boychuk
04df6f9d89 Merge branch 'master' of https://github.com/DSpace/DSpace into resourcepolicy-DS-4418 2020-02-21 09:52:50 +01:00
Raf Ponsaerts
d79deb6e1e [DS-3532] added javadoc to the linkRestRepositories for ParentCommunity Linking 2020-02-21 08:58:38 +01:00
Tim Donohue
d2c6582899 Minor spelling corrections 2020-02-20 15:19:06 -06:00
Chris Wilper
b0510dc486 drop unnecessary test object 2020-02-20 14:38:52 -05:00
Andrea Bollini
d64609df22 DS-4418 improve javadoc, cleanup dependencies 2020-02-20 19:48:38 +01:00
Andrew Wood
13daed22ab DS-4438 Update projections refrence and ITs 2020-02-20 13:13:12 -05:00
Mykhaylo Boychuk
edf5e57233 Fix double check in IT the findBySubmitter must be used 2020-02-20 18:51:52 +01:00
Tim Donohue
057cd30936 Merge pull request #2668 from Micheleboychuk/missingParameterException-DS-4428
DS-4428 missing parameter exception
2020-02-20 10:38:24 -06:00
Tim Donohue
453c69132b Merge pull request #2669 from tdonohue/DS-4380_errorprone_fixes
DS-4380 : Fix errorprone test warnings after JDK11 upgrade
2020-02-20 10:36:56 -06:00
Tim Donohue
81ae8b1738 Merge pull request #2674 from tdonohue/DS-4434_fix_context_behavior
[DS-4434] Fix Context.commit() and Context.isValid() behavior. Add more tests
2020-02-20 10:28:10 -06:00
Kristof De Langhe
6514183f45 Merge branch 'master' into w2p-68820_Moving-relationships-ITs
Conflicts:
	dspace-api/src/main/java/org/dspace/content/DSpaceObjectServiceImpl.java
2020-02-20 17:23:42 +01:00
Mykhaylo Boychuk
1daa462741 IT to prove access restricted Bitstreams cannot be accessed anonymously 2020-02-20 17:15:57 +01:00
Mykhaylo Boychuk
9a0a5078de refactor tests 2020-02-20 16:01:22 +01:00
Giuseppe Digilio
a28cb7551c Merge remote-tracking branch 'origin/master' into dspace-7-shibboleth 2020-02-20 14:40:41 +01:00
Kevin Van de Velde
c434124a38 Merge branch 'workflow-step-definitions' into w2p-68726_Workflow-IT-in-rest 2020-02-20 12:17:46 +01:00
Ben Bosman
9534a0b3aa Fix imports 2020-02-20 09:56:15 +01:00
Ben Bosman
533570538a Add docs, Change max embeds 2020-02-20 09:53:55 +01:00
Ben Bosman
48c6bcb88b Add previously processed links 2020-02-20 09:53:32 +01:00
Tim Donohue
808316599e Minor test correction. Use example.com for test emails as its guarranteed undeliverable 2020-02-19 16:56:32 -06:00
Tim Donohue
280ccac20c Fix Objects.toString() calls to return empty string if null 2020-02-19 16:51:28 -06:00
Andrea Bollini
4ce509133d Merge remote-tracking branch 'origin/master' into revisitSecurityLayerOfSubmission-DS-4043 2020-02-19 22:18:30 +01:00
Andrea Bollini
dbf5012298 Merge remote-tracking branch 'origin/master' into missingParameterException-DS-4428 2020-02-19 22:10:53 +01:00
Andrea Bollini
91db234849 Merge remote-tracking branch 'origin/master' into missingParameterException-DS-4428 2020-02-19 19:11:58 +01:00
Chris Wilper
95ee328862 DS-4438 Respect client-provided projection when creating item in workspace 2020-02-19 13:01:41 -05:00
Tim Donohue
b33e5834a9 Merge pull request #2682 from atmire/DefaultFullProjectionForNewSubmissions
Default to full projection for workspace item POSTs
2020-02-19 11:13:36 -06:00
Chris Wilper
fa4678c745 Default to full projection for workspace item POSTs (workaround; angular currently expects embeds here) 2020-02-19 10:04:20 -05:00
Marie Verdonck
570f77d1a6 68860: test fixes after merging latest dspace-origin/master 2020-02-19 15:28:35 +01:00
Marie Verdonck
701144b105 68860: test fixes after merging latest dspace-origin/master 2020-02-19 15:14:29 +01:00
Ben Bosman
71c5cc678f When moving metadata, make sure virtual metadata is handled correctly 2020-02-19 14:50:26 +01:00
Ben Bosman
c6e3758a40 Cast to RestAddressableModel 2020-02-19 14:32:50 +01:00
Yana De Pauw
148f9b2365 68781: Update groups and epersons GETS based on REST contract 2020-02-19 14:00:13 +01:00
benbosman
e0282d1fb3 Merge pull request #2591 from atmire/DS-4389-improving-patch-system-framework
Ds 4389 improving patch system framework Part 1
2020-02-19 11:56:42 +01:00
Mykhaylo Boychuk
40ee6e54f7 turn on check to verify admin of collection/community 2020-02-19 11:33:45 +01:00
Mykhaylo Boychuk
fad08adcb8 added IT to prove access restricted Items cannot be accessed anonymously 2020-02-19 11:29:02 +01:00
Raf Ponsaerts
5a96aab872 [Task 68857] added javadoc to the Version functionality classes 2020-02-19 11:06:36 +01:00
Marie Verdonck
50daac5937 Merge remote-tracking branch 'dspace-origin/master' into w2p-68726_Workflow-IT-in-rest 2020-02-19 10:51:43 +01:00
Marie Verdonck
15abc3aeb5 68860: latest changes from workflow-step-definitions &
some exceptions restored except generic exception in upload so UnprocessableEntityException can be thrown in WorkflowItemRestRepository &
checkIfEditMetadataAllowedInCurrentStep works with xmlWorkflowItem instead of id
2020-02-19 10:49:20 +01:00
Kevin Van de Velde
c498838e39 Merge remote-tracking branch 'upstream/master' into workflow-step-definitions 2020-02-19 09:39:21 +01:00
Marie Verdonck
4a12c658f6 68825: checkstyle 2020-02-18 18:42:39 +01:00
Marie Verdonck
64900a8791 68825: only allow patch/upload in workflow if claimed task w edit_metadata option 2020-02-18 16:54:43 +01:00
Raf Ponsaerts
2686403985 [Task 68810] added search by ItemUUID to workspace and workflowitem endpoints as well as added tests for them 2020-02-18 15:59:36 +01:00
Ben Bosman
cc2534ddd3 When moving metadata, make sure virtual metadata is handled correctly 2020-02-18 14:41:48 +01:00
Ben Bosman
243b0c077f When moving metadata, make sure virtual metadata is handled correctly 2020-02-18 13:29:31 +01:00
Ben Bosman
b8bca78e50 When moving metadata, make sure virtual metadata is handled correctly 2020-02-18 12:50:55 +01:00
Raf Ponsaerts
284507dd07 [Task 68810] added tests to the versioning ITs 2020-02-18 11:42:19 +01:00
Marie Verdonck
743d35f098 68821: check if submit button is in valid options for current action in workflow + previously @ignore tests now work as expected 2020-02-18 11:33:48 +01:00
Andrea Bollini
1d64d8932b DS-4413 exclude uniqueType from the json output 2020-02-18 08:17:42 +01:00
Andrea Bollini
3524f10ccc DS-4413 fix checkstyle and ITs after projection and IndexableObject refactoring 2020-02-17 23:10:38 +01:00
Marie Verdonck
8845c02145 68726: checkstyle 2020-02-17 18:32:14 +01:00
Marie Verdonck
347606b6f1 68726: Workflow action options tests 2020-02-17 16:03:18 +01:00
Kevin Van de Velde
4512ed5024 Removing obsolete "extends Object" from ResourcePatch 2020-02-17 14:17:33 +01:00
Raf Ponsaerts
d069889fc3 Fixes to versioning functionality after master merge 2020-02-17 13:34:12 +01:00
Raf Ponsaerts
97b69a1582 Merge remote-tracking branch 'dspace/master' into w2p-68732_list-version-history
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/model/ItemRest.java
2020-02-17 13:33:49 +01:00
Marie Verdonck
1c489fbf85 DS-4389: checkstyle 2020-02-17 13:30:20 +01:00
Marie Verdonck
a6e3298d19 DS-4389: ResourceNotFoundException if ResourcePolicy can't be retrieved 2020-02-17 12:14:22 +01:00
Mykhaylo Boychuk
8ed4f6d54c fixed unit test, should return 400 BADREQUEST 2020-02-17 12:02:35 +01:00
Marie Verdonck
e94168e099 DS-4389: Changes after merging latest master 2020-02-17 11:32:26 +01:00
Mykhaylo Boychuk
427d96af07 fixed QueryMethodParameterConversion should return 400 2020-02-17 11:07:59 +01:00
Marie Verdonck
e75d17f6a4 Merge remote-tracking branch 'dspace-origin/master' into DS-4389-improving-patch-system-framework
# Conflicts:
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/CollectionRestRepository.java
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/ItemRestRepository.java
2020-02-17 10:07:38 +01:00
Mykhaylo Boychuk
67b564af7e fixed exception for upload method 2020-02-17 09:43:50 +01:00
Mykhaylo Boychuk
00c9bcea90 implemented permissionEvaluatorPlugin for workspaceitem 2020-02-17 09:39:41 +01:00
Raf Ponsaerts
ee280019b9 Applied feedback to the versions functionality 2020-02-17 09:38:58 +01:00
Mykhaylo Boychuk
5a5ae6d401 added unit tests for the security layer of the submission 2020-02-17 09:29:44 +01:00
Andrea Bollini
9a7f9e7ada Merge branch 'master' of https://github.com/DSpace/DSpace into authz 2020-02-17 00:53:52 +01:00
Andrea Bollini
4f20954e9d DS-4413 fix checkstyle and add ITs for the withdraw, reinstate and cclicense feature 2020-02-16 16:59:29 +01:00
Andrea Bollini
214d7dfc9b DS-4413 complete implementation of the authz infrastructure and ITs 2020-02-16 00:38:58 +01:00
Marie Verdonck
1bee20c732 [DS-4389] Refactored new ResourcePolicy Patch system to work like the improved patch system (ResourcePolicy from DS-4398) 2020-02-14 18:56:01 +01:00
Tim Donohue
a5fe08c158 Minor spelling/grammar fixes 2020-02-14 09:39:04 -06:00
Tim Donohue
5e953f8bde Merge pull request #2656 from atmire/w2p-65257_Collection-item-template-crud
Collection item template updates
2020-02-14 09:24:11 -06:00
Tim Donohue
73f8dc100e Do not reuse global Context for cleanup actions...it may already be closed 2020-02-14 08:57:36 -06:00
Tim Donohue
7f879a2086 Add tests for HibernateDBConnection. Fix failing ContexTest methods. Bug fixes found via Tests 2020-02-14 08:57:36 -06:00
Tim Donohue
6a14699bd1 Add more Tests for Context. Bug fixes based on that. Enhance javadocs in HibernateDBConnection 2020-02-14 08:57:35 -06:00
Raf Ponsaerts
b4992cad3e Fixed checkstyle in ItemTemplateRestController 2020-02-14 15:33:07 +01:00
Raf Ponsaerts
cbd6870d72 [Task 68537] implemented feedback with regards to javadoc and annotations for the TemplateItem functionality 2020-02-14 14:16:56 +01:00
Raf Ponsaerts
580f6d7ad8 [Task 68537] fixed the templateItemOf link 2020-02-14 14:16:56 +01:00
Raf Ponsaerts
3e736e130a [Task 68537] applied feedback and fixes to the itemtemplate endpoints 2020-02-14 14:16:56 +01:00
Raf Ponsaerts
7322d983c4 Fixed tests on the ItemTemplate endpoints after rebasing on master 2020-02-14 14:16:56 +01:00
Raf Ponsaerts
36f2f0aa97 [Task 68059] removed superfluous information and links from templateItem endpoints and added/fixed tests 2020-02-14 14:16:55 +01:00
Peter Nijs
5e7da85197 67526: CRUD on Collection Item template
- Make the output of /core/collections/{id}/itemtemplate equal to /core/items/{id}
2020-02-14 14:13:38 +01:00
Raf Ponsaerts
f853db306b [Task 68732] implemented Versioning and added tests 2020-02-14 14:05:01 +01:00
Ben Bosman
aaca3a35d1 Also fixing relation field config 2020-02-14 10:07:10 +01:00
Kevin Van de Velde
7c7422e4cf Fixing the dspace.url references in the new patch classes 2020-02-14 09:57:04 +01:00
Raf Ponsaerts
6447176f02 Fixed headers and checkstyle for parentCommunity link functionality 2020-02-14 09:27:21 +01:00
Kevin Van de Velde
ffc1d37f8e Merge branch 'master' into DS-4389-improving-patch-system-framework 2020-02-14 09:14:20 +01:00
Tim Donohue
fb8ef5044b Fix checkstyle errors 2020-02-13 15:31:47 -06:00
Tim Donohue
4f9fb7d339 Minor fix to test cleanup 2020-02-13 15:31:47 -06:00
Tim Donohue
e69a63c5a7 Fix a number of errorprone warnings in tests. 2020-02-13 15:31:47 -06:00
Tim Donohue
db09a70d8f Fix deprecation of ObjectUtils.toString 2020-02-13 15:31:46 -06:00
Tim Donohue
3ae9009dbd Fixes to various errorprone warnings in tests 2020-02-13 15:31:46 -06:00
Tim Donohue
14586eb594 Fix errorprone warnings (UnusedVariable, out of order params) 2020-02-13 15:31:46 -06:00
Tim Donohue
82c90ca15c Fix errorprone warning https://errorprone.info/bugpattern/StringSplitter 2020-02-13 15:31:45 -06:00
Tim Donohue
f73b2b5fea Fix deprecation warnings 2020-02-13 15:31:45 -06:00
Tim Donohue
408acc2b90 Fix deprecation warning 2020-02-13 15:31:45 -06:00
Tim Donohue
1b40e6d6e9 Minor test class refactors to remove errorprone warnings. 2020-02-13 15:31:45 -06:00
Tim Donohue
f50156d320 Refactor to remove deprecation warning for ObjectUtils.equals 2020-02-13 15:31:45 -06:00
Tim Donohue
657319b02c Rename IntegrationTest to end in IT. 2020-02-13 15:31:45 -06:00
Tim Donohue
820722d2e6 Merge pull request #2657 from tdonohue/DS-4257_url_config_cleanup
[DS-4257] dspace.url and dspace.baseUrl config cleanup
2020-02-13 14:52:14 -06:00
Tim Donohue
19f1e60b67 Merge pull request #2654 from tdonohue/DS-4380_jdk11
DS-4380 : Upgrading 7.x to JDK11.  Remove JMockit (replace with Mockito)
2020-02-13 14:37:28 -06:00
Tim Donohue
7fe454d1a5 Upgrade Hibernate for full JDK11 compatibility. See https://hibernate.org/orm/releases/5.4/ 2020-02-13 13:43:50 -06:00
Tim Donohue
33bae06be6 Fix illegal reflective access from old version of Axiom. Also fix Geronimo warnings in builds. 2020-02-13 13:43:50 -06:00
Tim Donohue
b6b70b2c9c Fix build warning about "patterns were never triggered in this artifact exclusion filter" 2020-02-13 13:43:50 -06:00
Tim Donohue
29e5dcc5a9 Upgrade Dockerfiles and docker-compose files to all use JDK11. Remove JDK from names (JDK8 no longer supported) 2020-02-13 13:43:50 -06:00
Tim Donohue
7c335c8170 Updates to all maven plugin versions. General POM cleanup. 2020-02-13 13:43:50 -06:00
Tim Donohue
2d6b207b4f Comment out restlet <repository>. Old URL works again. Seems to have been only temporarily unavailable. 2020-02-13 13:43:50 -06:00
Tim Donohue
3894b9c7fc Move xml-maven-plugin to parent POM. It is already accessing XMLs outside of dspace-api. 2020-02-13 13:43:50 -06:00
Tim Donohue
447b7722f0 Test fixes after rebase. Remove unnecessary new code. 2020-02-13 13:43:49 -06:00
Tim Donohue
576f699e08 Minor code cleanup / import fixes 2020-02-13 13:43:49 -06:00
Tim Donohue
ecdba21a71 Workaround for trautonen/coveralls-maven-plugin#112 2020-02-13 13:43:49 -06:00
Tim Donohue
4537897e17 Final removal of JMockit. Move last tests to Mockito. Cleanup unused tests & resources 2020-02-13 13:43:49 -06:00
Tim Donohue
eb8c0cc605 Move context.complete() call to avoid closing passed in context 2020-02-13 13:43:49 -06:00
Tim Donohue
ebfc5dfb1f Refactor to no longer use JMockit mocks. 2020-02-13 13:43:49 -06:00
Tim Donohue
40f053751b Refactor AuthorizeUtil to NOT cache services (in static final variables). This allows authorization to be more easily mocked/overridden in tests. 2020-02-13 13:43:49 -06:00
Tim Donohue
50be2508ab Move JMockit init for Maven 2020-02-13 13:43:49 -06:00
Tim Donohue
b53be1f471 Refactor MockSolrLoggerServiceImpl to use Mockito. Remove FakeDatabaseReader 2020-02-13 13:43:49 -06:00
Tim Donohue
9b990f1834 Refactor to use Mockito (or no mocks) 2020-02-13 13:43:49 -06:00
Tim Donohue
7deed9040f Update to use Mockito. Other minor changes 2020-02-13 13:43:49 -06:00
Tim Donohue
33a2e94d44 Refactor to use Mockito (mostly) 2020-02-13 13:43:48 -06:00
Tim Donohue
0118c2bbd3 Refactor to use Mockito 2020-02-13 13:43:48 -06:00
Tim Donohue
6248867de7 Refactor tests to use Mockito instead of JMockit 2020-02-13 13:43:48 -06:00
Tim Donohue
eb53950660 Correct location of MockitoJUnitRunner (new package) 2020-02-13 13:43:48 -06:00
Tim Donohue
93c39cf318 Refactor (most) tests to use Mockito instead of JMockit 2020-02-13 13:43:48 -06:00
Tim Donohue
3ab37aafb9 Refactor tests to use Mockito instead of JMockit 2020-02-13 13:43:48 -06:00
Tim Donohue
e97218616d Implement destroy properly & fix an incorrect test 2020-02-13 13:43:48 -06:00
Tim Donohue
8c7127ed8c Refactor tests to use Mockito 2020-02-13 13:43:48 -06:00
Tim Donohue
412c8a1ec8 Refactor tests to use Mockito instead of JMockit 2020-02-13 13:43:48 -06:00
Tim Donohue
d6a4bf21b9 Remove stubs that Mockito says are not used. Then remove duplicative tests. 2020-02-13 13:43:48 -06:00
Tim Donohue
cfde3e905b Switch CommunityTest to mostly using Mockito (exceptions for Util classes) 2020-02-13 13:43:48 -06:00
Tim Donohue
db18ddfb5a Update dependencies. Fixes Maven issues with initializing dspace.dir 2020-02-13 13:43:48 -06:00
Tim Donohue
78fb4cfe82 Remove MockUtil and replace with handling NPE that can occur when running Util in test mode. 2020-02-13 13:43:47 -06:00
Tim Donohue
7700d6a3b5 Replace jmockit with mockito in dspace-services. Correct tests 2020-02-13 13:43:47 -06:00
Tim Donohue
6a8516e957 Enable Mockito to mock/spy final classes & methods 2020-02-13 13:43:47 -06:00
Tim Donohue
f9709c0d8e Fix test to no longer overwrite test configs. 2020-02-13 13:43:47 -06:00
Tim Donohue
3e4937a2ba Ensure "dspace.dir" is explicitly set for tests. Implicit no longer works. 2020-02-13 13:43:47 -06:00
Tim Donohue
27e275e237 Reinitialize jmockit for all tests 2020-02-13 13:43:47 -06:00
Tim Donohue
1982ceb076 Fix errors reported by latest version of ErrorProne 2020-02-13 13:43:47 -06:00
Tim Donohue
f3e4bfa29a Reenable ErrorProne on JDK11 2020-02-13 13:43:47 -06:00
Tim Donohue
da19d7c360 Update Travis CI to use JDK11. Minor comment changes 2020-02-13 13:43:47 -06:00
Tim Donohue
ef6e32f435 Base dependency updates for JDK11, based on cwilper's PR#2611 2020-02-13 13:43:47 -06:00
Tim Donohue
3c43dbdcdd Replace dspace.url with dspace.server.url in recent code comments 2020-02-13 13:42:36 -06:00
Tim Donohue
b116c55714 Refactor code to remove the need for a "hostname" configuration. 2020-02-13 13:40:35 -06:00
Tim Donohue
d455d7df87 Fix minor test & checkstyle failures 2020-02-13 13:40:34 -06:00
Tim Donohue
c55f29de6a Replace dspace.hostname with dspace.ui.hostname. Enhance descriptions of how/where configs are used 2020-02-13 13:40:34 -06:00
Tim Donohue
e8180f11cb Replace all usages of dspace.url with either dspace.ui.url or dspace.server.url (depending on use case) 2020-02-13 13:40:33 -06:00
Tim Donohue
5e3e9b8f9d Replace all usages of dspace.baseUrl with either dspace.server.url or dspace.ui.url (depending on use case) 2020-02-13 13:40:23 -06:00
Tim Donohue
f64553e31c Remove final references to old dspace.restUrl config 2020-02-13 13:36:00 -06:00
Ben Bosman
3107a1dee1 Also renaming personOrOrganization to personOrOrgunit 2020-02-13 18:31:58 +01:00
Chris Wilper
45b45d39aa DS-4433 Add support to request specific embeds 2020-02-13 12:03:09 -05:00
Tim Donohue
9de65efa8c Merge pull request #2625 from atmire/DS-3533_Projections-Continued
DS-3533 Projections continued
2020-02-13 10:41:01 -06:00
Raf Ponsaerts
61400e1145 Added parentCommunity to test matchers for collections and communities 2020-02-13 16:17:22 +01:00
Raf Ponsaerts
fc1744c322 Merge branch 'DS-3533_Projections-Continued' into w2p-68607_add-link-to-parent-community 2020-02-13 15:42:28 +01:00
Raf Ponsaerts
0d95937c9b intermediate 2020-02-13 15:41:43 +01:00
Chris Wilper
fe8e069aa7 DS-3533 Address PR feedback 2020-02-13 09:17:05 -05:00
Chris Wilper
7206456f30 Merge branch 'master' into DS-3533_Projections-Continued
Manually resolved conflicts, including removing CollectionDefaultAccessConditionsLinkRepository
because that subresource is no longer expected to be on collections.
2020-02-12 16:48:32 -05:00
Mykhaylo Boychuk
10fbf2eae7 restore upload as mandatory as by dspace default configuration 2020-02-12 22:08:25 +01:00
Marie Verdonck
207f745512 [DS-2646]: test and checkstyle fixes 2020-02-12 18:29:08 +01:00
Mykhaylo Boychuk
7664c2da94 removed attributes groupUuid/epersonUuid from resourcePolicyRest 2020-02-12 18:01:13 +01:00
Mykhaylo Boychuk
c5bf2b2346 added unit test for addAccessCondition and removeAccessCondition 2020-02-12 18:01:13 +01:00
Mykhaylo Boychuk
5adb1ce549 fix unit test from 422 to 400 2020-02-12 17:30:37 +01:00
Mykhaylo Boychuk
496b88093d fixed handle missing servlet request parameter 2020-02-12 17:30:37 +01:00
Mykhaylo Boychuk
cbe07eb15a fix javadoc 2020-02-12 17:30:36 +01:00
Mykhaylo Boychuk
4e080150cb fixed unit tests: missing parameters should return 400 BAD REQUEST 2020-02-12 17:30:36 +01:00
Mykhaylo Boychuk
0a9d4cd4c1 DS-4428 fix bad request 2020-02-12 17:30:36 +01:00
Mykhaylo Boychuk
c71c52bb46 DS-4428 enable tests for bad request 2020-02-12 17:30:36 +01:00
Marie Verdonck
0c9e50ca72 [DS-2646]: /workflowdefintions/<:name>/steps fixed + new tests &
endpoint result names changed to without Resource
2020-02-12 16:46:14 +01:00
Tim Donohue
14445d599c Merge pull request #2604 from Micheleboychuk/resourcepolicies
DS-4398 initial implementation of the resource policies endpoint
2020-02-12 09:39:39 -06:00
Chris Wilper
0c73f333d7 DS-4427 Update tests based on new embed expectations 2020-02-12 09:37:42 -05:00
Chris Wilper
1acd62ed96 DS-3533 Add javadoc for new method 2020-02-12 08:41:18 -05:00
Chris Wilper
c9d6797396 DS-4427 Re-enable embedding for link repositories in favor of embed level limiting 2020-02-12 08:36:45 -05:00
Chris Wilper
b4e8851b12 DS-3533 Fix test issue and imports 2020-02-12 07:10:32 -05:00
Chris Wilper
dd55ad3609 DS-3533 Increase max embed level to 3 and fix tests 2020-02-11 13:25:08 -05:00
Andrew Wood
08ee6e5c76 DS-3533 Refactor projection embeds ITs to match new style 2020-02-11 10:16:31 -05:00
Raf Ponsaerts
2241b591f7 [Task 68608] added ITs for the parent communities and owning collections 2020-02-11 16:10:42 +01:00
Marie Verdonck
2e8042e97d 68726: Integration tests of Workflow in rest api - WIP,
some unexpected results in edit and final edit step, @ignore tests for now
2020-02-11 13:08:12 +01:00
Yana De Pauw
7e099a9b29 Fix tests for upgraded mockito version 2020-02-11 13:03:37 +01:00
Raf Ponsaerts
fa07bc27d0 Merge branch 'DS-3533_Projections-Continued' into w2p-68607_add-link-to-parent-community 2020-02-11 12:44:37 +01:00
Raf Ponsaerts
90073abfb7 [Task 68534] applied feedback to the metadata import and export script and wrote tests for them 2020-02-11 12:41:48 +01:00
Ben Bosman
b70c660b65 Configure missing search configurations 2020-02-11 10:15:21 +01:00
Chris Wilper
e6e5da191d DS-4427 Only embed up to one level 2020-02-10 16:36:00 -05:00
Chris Wilper
8e7646f5f5 DS-3533 Fix incorrect comment noted by Tim 2020-02-10 11:25:53 -05:00
Marie Verdonck
c1193c6890 [DS-2646]: test fix 2020-02-10 16:25:26 +01:00
Chris Wilper
414d4dc248 DS-3533 Begin consolidating embedded/link tests per dso type 2020-02-10 10:15:52 -05:00
Marie Verdonck
1f8e440793 [DS-2646]: checkstyle 2020-02-10 15:18:58 +01:00
Raf Ponsaerts
ea509448a9 [Task 68608] test setup for parent community IT 2020-02-10 14:32:16 +01:00
Marie Verdonck
e35e5a6b3a [DS-2646]: /workflowdefinitions/<:name>/collections via @LinkRest (Controller to LinkRepository)
and /steps set embedOptional to true
> /workflowdefinitions/<:name> has links of subresources, but no embeds
2020-02-10 14:27:49 +01:00
Philip Vissenaekens
0615c5dec9 Merge remote-tracking branch 'upstream/master' into DS-626
# Conflicts:
#	dspace/config/spring/api/core-factory-services.xml
#	dspace/config/spring/api/core-services.xml
#	dspace/src/main/config/build.xml
2020-02-10 13:44:54 +01:00
Philip Vissenaekens
f3003fbf84 68214: cleaned up stats.cfg 2020-02-10 13:41:50 +01:00
Yana De Pauw
25362cb704 68716: fix typo in script class name 2020-02-10 11:58:12 +01:00
Yana De Pauw
c665ecf2c6 68716: Implement feedback 2020-02-10 11:53:40 +01:00
Marie Verdonck
2fd967744c [DS-2646]: Workflow Endpoints now need authenticated access + tests:
WorkflowDefinition, WorkflowActions & WorkflowSteps Endpoints
2020-02-10 11:05:52 +01:00
Andrea Bollini
0201ef1055 Initial implementation of the authorizations endpoints 2020-02-09 15:56:42 +01:00
Andrew Wood
b77b4f0336 DS-3533 Create test for embeds and links against DSO REST ITs 2020-02-07 15:37:05 -05:00
Chris Wilper
b1e7e9f2aa DS-3533 Disable embedding of authority entryValues as a direct subresource 2020-02-07 15:36:13 -05:00
Chris Wilper
4a5cbb3678 DS-3533 Make authority entries subresource embeddable 2020-02-07 15:32:40 -05:00
Raf Ponsaerts
0faeaabdef [Task 68607] added links to the parentCommunity for collections and communities on their respective endpoints 2020-02-07 15:38:25 +01:00
Giuseppe Digilio
c65bb086ef Fixed checkstyle violations 2020-02-07 14:49:43 +01:00
Chris Wilper
afdefcbeed DS-3533 Drop unused import 2020-02-06 14:56:01 -05:00
Mykhaylo Boychuk
b4798511b4 update test to access single resource policy owned by Anonymous group
resource policy endpoints are now restricted to authenticated people according to the reviewed contract
2020-02-06 17:14:52 +01:00
Mykhaylo Boychuk
dc06efbb83 added unit test to retrieve a resource policy attached to the Anonymous group with/without using authentication 2020-02-06 15:52:58 +01:00
Giuseppe Digilio
cc439d3471 Fixed the default value of authentication-shibboleth.lazysession.loginurl param 2020-02-06 15:20:51 +01:00
Giuseppe Digilio
82f2f60fc9 Added integration test fo ShibbolethRestController 2020-02-06 15:15:54 +01:00
Giuseppe Digilio
7b3db78e4b Added more integration test for shibboleth authentication 2020-02-06 15:15:36 +01:00
Chris Wilper
b1d54273de DS-3533 Adjust javadocs 2020-02-06 09:12:03 -05:00
Chris Wilper
241289a2f9 DS-3533 Fix formatting 2020-02-06 08:52:12 -05:00
Chris Wilper
d2d03bca9e DS-3533 Run test with admin perms since permission is now checked 2020-02-06 08:52:12 -05:00
Andrew Wood
58ad460e74 DS-3533 Fix BrowsesResourceControllerIT test 2020-02-06 08:52:12 -05:00
Chris Wilper
e0f0483b5d DS-3533 Fix expectation browseEntries -> entries 2020-02-06 08:52:12 -05:00
Andrew Wood
7f45d1defc DS-3533 Rest IT fixes 2020-02-06 08:52:12 -05:00
Chris Wilper
c84939e57d DS-3533 Fix ConverterService tests based on new expectations 2020-02-06 08:52:12 -05:00
Chris Wilper
e6e0360e8f DS-3533 Drop extends; not a link repository 2020-02-06 08:52:12 -05:00
Chris Wilper
6ef0e165dc DS-3533 Drop linkClass; unused 2020-02-06 08:52:12 -05:00
Chris Wilper
7d3885f939 DS-3533 Drop embed/linkOptional properties from LinkRest 2020-02-06 08:52:12 -05:00
Andrew Wood
169cd502a2 DS-3533 Consistency: Use same json for paged subresources
This ensures that when a subresource is a paged collection,
the json is constructed in the same way, whether it is embedded
in its parent, or requested separately.
2020-02-06 08:49:35 -05:00
Chris Wilper
c71090a04f DS-3533 Request embeds for relevant ITs 2020-02-06 08:49:27 -05:00
Mykhaylo Boychuk
3e0db7a7a1 Forbid anonymous users to search by gorup 2020-02-06 10:40:26 +01:00
Mykhaylo Boychuk
434774f1f6 Add test to verify that anonymous users cannot search by group 2020-02-06 10:37:12 +01:00
Chris Wilper
0fded8de83 DS-3533 Permit embedding group in eperson 2020-02-05 13:19:23 -05:00
Chris Wilper
2019e095db DS-3533 Avoid embedding subresources that may nest (groups in groups, communities in communities) 2020-02-05 13:19:23 -05:00
Chris Wilper
d4c0bbde52 DS-3533 Consistency: Use link repo to GET bitstream bundle subresource 2020-02-05 13:19:23 -05:00
Chris Wilper
d67aeb41d9 DS-3533 Fix collection license subresource authorization 2020-02-05 13:19:23 -05:00
Chris Wilper
fc9512a495 DS-3533 Make group subresource embeds optional 2020-02-05 13:19:23 -05:00
Chris Wilper
876a1fad1d DS-3533 Consistency: Use link repo for eperson groups 2020-02-05 13:19:23 -05:00
Chris Wilper
8c2953c66d DS-3533 Consistency: Use link repo for mapped items 2020-02-05 13:19:23 -05:00
Chris Wilper
10dcd35880 DS-3533 Consistency: Return NOT FOUND when resource not found for subresource request 2020-02-05 13:19:23 -05:00
Chris Wilper
17180337d7 DS-3533 Consistency: Use link repo for mapped collections 2020-02-05 13:19:23 -05:00
Chris Wilper
3a56f002e5 DS-3533 Make community subresource embeds optional 2020-02-05 13:19:23 -05:00
Chris Wilper
3cdb947098 DS-3533 Get optional pageable from one place 2020-02-05 13:19:23 -05:00
Chris Wilper
20a00db673 DS-3533 Make collection subresource embeds optional 2020-02-05 13:19:23 -05:00
Chris Wilper
2865ff9171 DS-3533 Rename for consistency among link repos 2020-02-05 13:19:23 -05:00
Chris Wilper
de71486e6b DS-3533 Consistency: Return NO CONTENT when link repo returns null 2020-02-05 13:19:23 -05:00
Chris Wilper
460ada4098 DS-3533 Require read access to get subresources 2020-02-05 13:19:22 -05:00
Chris Wilper
f98e011738 DS-3533 Make bitstream subresource embeds optional 2020-02-05 13:19:22 -05:00
Chris Wilper
2884a80958 DS-3533 Make bundle subresource embeds optional 2020-02-05 13:19:22 -05:00
Chris Wilper
2f018c6f89 DS-3533 Make item subresource embeds optional 2020-02-05 13:19:22 -05:00
Chris Wilper
fb36d4bd7b DS-3533 Fix test to match new expectation 2020-02-05 13:19:22 -05:00
Chris Wilper
e331d5557e DS-3533 Include optional links by default 2020-02-05 13:19:22 -05:00
Chris Wilper
7637857505 DS-3533 Drop "list" projection; no longer relevant 2020-02-05 13:19:22 -05:00
Chris Wilper
37692eb120 DS-3533 Correct javadocs 2020-02-05 13:19:22 -05:00
Raf Ponsaerts
e0c1e14330 DS-3533 Update javadocs 2020-02-05 13:19:22 -05:00
Raf Ponsaerts
f8eb5843f2 DS-3533 Disable embeds by default 2020-02-05 13:19:22 -05:00
Andrea Bollini
03238bcbb5 Community feedback: improved javadoc and naming 2020-02-05 19:02:42 +01:00
Mark H. Wood
d1d3f4f73d [DS-4118] Make new helpdesk phone property optional and give it a better name. 2020-02-05 10:40:53 -05:00
Yana De Pauw
21621ae6d2 Merge branch 'w2p-67668_Porting-IRUS-patch-to-DSpace-7' of https://github.com/atmire/DSpace into w2p-67668_Porting-IRUS-patch-to-DSpace-7 2020-02-05 12:01:37 +01:00
Yana De Pauw
7a37080c98 Fixing RetryOpenUrl and tests due to scriptservice change 2020-02-05 12:01:17 +01:00
Giuseppe Digilio
6230a88b8a Added inline comment 2020-02-05 11:50:18 +01:00
Giuseppe Digilio
0336e83124 Added setSecure option to authetication cookie 2020-02-05 11:49:59 +01:00
Yana De Pauw
b473cc1b40 Update to the script service to ensure scripts are reloaded every time 2020-02-05 10:21:24 +01:00
Mykhaylo Boychuk
325f992936 uniform naming and code cleanup 2020-02-04 15:24:43 +01:00
Mykhaylo Boychuk
6248acd8fa fix findByResourceUuid query 2020-02-04 15:22:23 +01:00
Mykhaylo Boychuk
8c3f572c0b remove references to default bitstream policies to avoid infinite loop 2020-02-04 15:18:00 +01:00
Julius Gruber
707168dd1e Dspace bat file (#2544)
* First test

* Minor changes to bat file

* Removed files not to part of  the PR

* Added config files

* Removed buildpath.bat

* Changed bat file

* Enabled shibooleth in config

* Removed unnecessary comment from bat file

* Linux dspace script made similar to dspace bat file

* Removed authentication.cfg from this PR

* Now really removed authentication.cfg from this PR

* Remove OAI from classpath

Co-authored-by: Tim Donohue <tim.donohue@lyrasis.org>
2020-02-03 11:18:57 -06:00
Tim Donohue
9dbda4e2e1 Merge pull request #2650 from atmire/default-webui.submit.upload.required
Default webui.submit.upload.required
2020-02-03 10:55:44 -06:00
Kevin Van de Velde
f732577425 Merge branch 'master' into workflow-step-definitions 2020-02-03 13:15:57 +01:00
Kevin Van de Velde
bda2e51041 Fixing configuration in the workflow-actions.xml test file 2020-02-03 13:15:30 +01:00
Philip Vissenaekens
2365ef521d 68214: cleaned up stats.cfg, provided configuration for the COUNTER robots list and disabled the IRUS integration by default 2020-01-31 17:44:02 +01:00
Tim Donohue
205cb103dc Merge pull request #2658 from atmire/w2p-68458_Indexing-Performance-is-very-slow-since-refactor--ITs-take-twice-as-long
[DS-4425] Indexing Performance is very slow since refactor. ITs take twice as long
2020-01-31 09:26:03 -06:00
Marie Verdonck
6680d233e2 [DS-2646]: checkstyle fix 2020-01-31 16:03:36 +01:00
Samuel
274ca1fcb2 taskid 68458 optimize performance - IndexEventConsumer change 2020-01-31 13:14:44 +01:00
Marie Verdonck
1820659a80 [DS-2646]: api/config/workflowdefinitions/defaultWorkflow/collections :
returns all non-mapped collections & all collections specifically mapped to defaultWorkflow
& Exception comment
2020-01-31 13:11:40 +01:00
Marie Verdonck
aaa9d5ed29 [DS-2646]: javadoc & SUBMIT_EDIT_METADATA to ProcessingAction 2020-01-31 13:10:42 +01:00
Yana De Pauw
0ee7ec9bef 67668: Refactoring code, adding tests and typedocs 2020-01-31 12:16:07 +01:00
Marie Verdonck
8b51ba692d Merge remote-tracking branch 'dspace-origin/master' into workflow-step-definitions 2020-01-31 11:55:48 +01:00
Kevin Van de Velde
d9acb5ba8a Enabling the patchItemMetadataAuthorized() test 2020-01-30 11:56:58 +01:00
Kevin Van de Velde
a9c8a3b49e Merge branch 'master' into DS-4389-improving-patch-system-framework 2020-01-30 10:46:58 +01:00
benbosman
48cf744040 Merge pull request #2420 from KevinVdV/DS-4239-migrate-workflow-xml-to-spring
[DS-4239] Migrate the workflow.xml to spring
Merging since there are 2 approvals and it's a dependency for https://github.com/DSpace/DSpace/pull/2646
2020-01-29 09:19:00 +01:00
Tim Donohue
75ea08f077 Merge pull request #2632 from mwoodiupui/DS-4409
[DS-4409] Remove GeoIP download Ant target, reconfigure for external provision
2020-01-23 11:23:09 -06:00
Mykhaylo Boychuk
f6d6d14add added some checks in resourcePolicyMatcher 2020-01-23 17:54:37 +01:00
Tim Donohue
61a685f792 Merge pull request #2496 from mwoodiupui/DS-2378
[DS-2378] Remove support for multiple ServiceManagers
2020-01-23 10:20:39 -06:00
Tim Donohue
07370e7f08 Merge pull request #2644 from paulo-graca/patch-5
Fix for DS-4422
2020-01-23 09:46:46 -06:00
Mykhaylo Boychuk
ed14f0c33b added unit test for method findByResource 2020-01-23 16:00:45 +01:00
Giuseppe Digilio
c63b88141c Merge remote-tracking branch 'origin/master' into dspace-7-shibboleth 2020-01-23 14:15:00 +01:00
Tim Donohue
1db367f437 Merge pull request #2641 from atmire/w2p-67817_RelationshipTypeRestController-minor-change
relationship type rest controller bug fix
2020-01-22 09:39:16 -06:00
Marie Verdonck
f8ab7def82 68373: test fix by setting webui.submit.upload.required=false &
extra tests for file upload when upload.required = true
2020-01-22 15:23:31 +01:00
Kevin Van de Velde
5265ebd382 Removing commented out code 2020-01-22 14:53:42 +01:00
Raf Ponsaerts
130db9531d [Task 68380] added files and file endpoints to the Process endpoints 2020-01-22 14:14:01 +01:00
Tim Donohue
60d9f15aec Merge pull request #2640 from paulo-graca/patch-4
Fix for DS-4420 OpenAIREv4 XSLT Warning in Spring Boot
2020-01-21 09:37:18 -06:00
Kevin Van de Velde
20d9b330d0 Fixing merge issue in the workflow-actions.xml file 2020-01-21 12:49:29 +01:00
Giuseppe Digilio
4bb4b539d6 use invalidateAuthenticationCookie method 2020-01-21 11:17:36 +01:00
Kevin Van de Velde
25dd5162b0 Merge branch 'DS-4239-migrate-workflow-xml-to-spring' into workflow-step-definitions 2020-01-21 09:30:07 +01:00
Giuseppe Digilio
4dba383606 replace Boolean type with primitive type 2020-01-20 17:22:36 +01:00
Kevin Van de Velde
5ba7a16e5a [DS-4239] Migrate the workflow.xml to spring: Aligning the workflow.xml from the test to the one in default config 2020-01-20 13:57:41 +01:00
Raf Ponsaerts
2d9e688d95 [Task 68281] applied feedback to the metadata-import and metadata-export scripts 2020-01-20 11:43:14 +01:00
Tim Donohue
903ff57994 Merge pull request #2643 from tdonohue/fix_solr_dockerfile
[Docker] Fix Solr Dockerfile. Pull DSpace Solr configs from 'dspace' image
2020-01-17 16:37:57 -06:00
Tim Donohue
d39027f9d6 Update comment to note why we are pinning to Solr 7 2020-01-17 15:33:14 -06:00
Tim Donohue
54dd0496b3 Make sure DSpace Solr schemas/configs are owned by solr user 2020-01-17 15:17:20 -06:00
Paulo Graça
f34562bb19 Fix for https://jira.lyrasis.org/browse/DS-4422 2020-01-17 14:55:20 +00:00
Ben Bosman
bcd89e9145 JavaDoc for new params 2020-01-17 15:26:36 +01:00
Yana De Pauw
74274ccafc 68273: Making types for which IRUS events should be sent configurable 2020-01-17 13:33:34 +01:00
Giuseppe Digilio
8531f43266 Merge remote-tracking branch 'origin/master' into dspace-7-shibboleth 2020-01-17 12:21:48 +01:00
Kevin Van de Velde
5b2f50060d [DS-4239] Migrate the workflow.xml to spring: Bugfixes to the optional select reviewer workflow 2020-01-17 10:07:56 +01:00
Giuseppe Digilio
0910916903 Revert "use authorization cookie only to check" 2020-01-17 09:14:33 +01:00
Tim Donohue
7f918a5986 Update/enhance README 2020-01-16 16:46:28 -06:00
Tim Donohue
7babc754cf Fix Solr Dockerfile by pulling Solr configs from main dspace image 2020-01-16 16:46:28 -06:00
Tim Donohue
6c864d678c Merge pull request #2642 from tdonohue/fix_broken_build
[HIGH PRIORITY] Fix Maven build where restlet dependency not found for solr-cell
2020-01-16 16:45:27 -06:00
Tim Donohue
31b960d4e1 Merge pull request #2612 from atmire/DS-4287-indexableobject-refactor
[DS 4287] Refactoring the IndexableObject & SolrServiceImpl
2020-01-16 16:21:57 -06:00
Tim Donohue
ad7d22cba7 Update repository to use HTTPS 2020-01-16 16:12:21 -06:00
Tim Donohue
6424b5d12d Fix Maven build where restlet dependency not found for solr-cell 2020-01-16 16:01:17 -06:00
Paulo Graça
81a5204e74 Fix for DS-4420 [Received] OpenAIREv4 XSLT Warning in Spring Boot 2020-01-16 16:05:37 +00:00
Ben Bosman
b7d407fe40 Merge remote-tracking branch 'community/master' into w2p-67817_RelationshipTypeRestController-minor-change 2020-01-16 16:30:23 +01:00
Giuseppe Digilio
1e919f9934 Added WWW-Authenticate header to authn/status response 2020-01-16 15:02:02 +01:00
Marie Verdonck
c171140371 68274: /workflowdefinitions/<:definition-name>/steps endpoint as embedded resource and collections link 2020-01-16 14:19:11 +01:00
Tim Donohue
c6641f5d1b Merge pull request #2638 from atmire/w2p-68148_bug-in-viewevents
Bug in ViewEvents
2020-01-15 10:24:58 -06:00
Tim Donohue
6e9d459e00 Merge pull request #2637 from tdonohue/version_updates
Minor dependency updates to resolve GitHub security alerts
2020-01-15 10:22:44 -06:00
Mykhaylo Boychuk
5c93722d67 Implement community feedbacks 2020-01-15 15:34:13 +01:00
Mykhaylo Boychuk
8fce3d109a added javadoc and rename some methods 2020-01-15 15:31:31 +01:00
Raf Ponsaerts
182a8f01f3 Applied feedback to the MetadataExport and MetadataImport scripts 2020-01-15 13:49:31 +01:00
Marie Verdonck
b76933e7c1 68274: /api/config/workflowdefinitions/<:definition-name>/steps endpoint and link 2020-01-14 13:06:27 +01:00
Mykhaylo Boychuk
dc9fe87987 Implemented unit test 2020-01-13 16:30:56 +01:00
Mykhaylo Boychuk
7d5ed97676 added javadoc 2020-01-13 16:27:36 +01:00
Kevin Van de Velde
5236534847 [DS-4287] Refactoring the IndexableObject & SolrServiceImpl: Fixing some tests 2020-01-13 13:09:18 +01:00
Marie Verdonck
2c5acf0cfb 68253: GET /api/config/workflowsteps/<:step-name> IT 2020-01-13 12:45:54 +01:00
Mykhaylo Boychuk
74cfc838d6 Merge branch 'master' of https://github.com/DSpace/DSpace into resourcepolicies 2020-01-13 09:36:20 +01:00
Mykhaylo Boychuk
92f632d08f Implement community feedbacks 2020-01-11 11:49:32 +01:00
Mykhaylo Boychuk
8d66d7f534 added javadoc 2020-01-11 11:41:21 +01:00
Mykhaylo Boychuk
7808834e9c renamed the class and add javadoc 2020-01-11 11:33:07 +01:00
Mark H. Wood
aa4f2898c6 [DS-4409] Leave GeoLite database location unconfigured by default. 2020-01-10 11:46:08 -05:00
Marie Verdonck
766d021a1a 68253: GET /api/config/workflowsteps/<:step-name> endpoint 2020-01-10 17:01:33 +01:00
Giuseppe Digilio
e884cc3d8c fix attemptAuthentication method on ShibbolethAuthenticationFilter 2020-01-10 14:53:03 +01:00
Giuseppe Digilio
50cf9b742f add attemptAuthentication method to ShibbolethAuthenticationFilter 2020-01-10 14:39:54 +01:00
Giuseppe Digilio
ba9d2095dc Revert "Check session salt in shib auth"
This reverts commit 462f20a338.
2020-01-10 14:33:05 +01:00
Kevin Van de Velde
f112d93cd5 Merge branch 'master' into DS-4287-indexableobject-refactor 2020-01-10 10:48:55 +01:00
Kevin Van de Velde
2c5ed44f81 [DS-4287] Refactoring the IndexableObject & SolrServiceImpl: Additional comments, some more narrowing of generics, additional error catching & cleaner way to resolve permissions 2020-01-10 10:33:56 +01:00
Giuseppe Digilio
462f20a338 Check session salt in shib auth 2020-01-10 10:25:58 +01:00
Giuseppe Digilio
a32d11eb85 Revert check 2020-01-10 10:20:21 +01:00
Giuseppe Digilio
15d6b18ebf fix check user and password blank 2020-01-10 10:09:19 +01:00
Giuseppe Digilio
5530e7b7a3 Add checck to user and password blank 2020-01-10 09:49:55 +01:00
Mark H. Wood
ad03a97660 [DS04409] There is another set of mock/fake classes for dspace-server-webapp. Activate them. 2020-01-09 16:13:38 -05:00
Giuseppe Digilio
beb975281d Invalidate authentication cookie once used 2020-01-09 19:02:31 +01:00
Giuseppe Digilio
4210605503 fix use authorization cookie only to check 2020-01-09 18:36:41 +01:00
Giuseppe Digilio
15087db2b6 use authorization cookie only to check 2020-01-09 18:25:10 +01:00
Tim Donohue
053eb1be3c Merge pull request #2635 from tdonohue/docker_wait_on_db
[Docker] Ensure dspace container waits until db is accepting connections before starting Tomcat
2020-01-09 11:23:53 -06:00
Giuseppe Digilio
2a1cb37bbd Revert "add context commit after invalidating token"
This reverts commit 64bc25f7c9.
2020-01-09 18:19:06 +01:00
Giuseppe Digilio
64bc25f7c9 add context commit after invalidating token 2020-01-09 18:04:42 +01:00
Giuseppe Digilio
bf1e9780d4 Invalidate authorization cookie on logout 2020-01-09 16:29:55 +01:00
Giuseppe Digilio
bbfc373bdc Fixed checkstyle violations 2020-01-09 15:58:17 +01:00
Giuseppe Digilio
44210f92ed Fixed AuthenticationRestControllerIT 2020-01-09 15:20:34 +01:00
Raf Ponsaerts
24f5cf0896 Fixed tests in CSVMetadataImportReferenceTest and script bean issues 2020-01-09 15:03:42 +01:00
Marie Verdonck
22b1f6231d 68155: xmlWorkflowFactory autowired where possible & WorkflowAction.name > id 2020-01-09 14:24:37 +01:00
Yana De Pauw
a1009276c3 67668: psql fix 2020-01-09 13:58:31 +01:00
Yana De Pauw
c6ce9aaf10 67668: Fix to the postgres sql file 2020-01-09 13:45:47 +01:00
Giuseppe Digilio
1e1de3c2e9 Add authorization cookie only in ShibbolethAuthenticationFilter 2020-01-09 13:41:43 +01:00
Yana De Pauw
46a3407642 67688: Add IRUS patch to DSpace 7 2020-01-09 13:19:43 +01:00
Giuseppe Digilio
e5074004f4 Revert "Retrieve token from cookie only when checking an authenticated eperson"
This reverts commit 10bbf8079b.
2020-01-09 13:11:22 +01:00
Giuseppe Digilio
10bbf8079b Retrieve token from cookie only when checking an authenticated eperson 2020-01-09 12:08:55 +01:00
Tim Donohue
6a1c170fe6 Minor updates to Spring configs for Spring Security v5 2020-01-08 16:10:12 -06:00
Tim Donohue
676fbb1450 Fix CVE-2019-0201 and CVE-2019-17531 2020-01-08 14:30:31 -06:00
Tim Donohue
9bb75570b0 Fix CVE-2019-17195 2020-01-08 14:29:58 -06:00
Tim Donohue
899b697e5f Fix warning about missing <version> tag 2020-01-08 14:29:18 -06:00
Tim Donohue
33d3b67f98 Fix CVE-2016-5007 2020-01-08 14:28:35 -06:00
Tim Donohue
2839fef6d4 Fix warning about new groupId for hibernate-validator-cdi 2020-01-08 14:27:43 -06:00
Giuseppe Digilio
4ce3c8cbda Fixed checkstyle violations 2020-01-08 18:38:41 +01:00
Tim Donohue
a0ca6e2fad Merge pull request #2619 from atmire/DS-4351-upgrade-dependencies
DS-4351 upgrade dependencies
2020-01-08 10:18:46 -06:00
Peter Nijs
516a1e298a 68148: Bug in ViewEvents
- Remove 'id' field from the ViewEventRest
2020-01-08 14:53:07 +01:00
Marie Verdonck
4f0b48b4ff 68155: SUBMIT_CANCEL option removed from SelectReviewerAction 2020-01-08 14:13:40 +01:00
Kevin Van de Velde
34b7663c89 [DS-4351] upgrade dependencies: Excluding byte-buddy instead of pinning on a version & removing some duplicate dependencies 2020-01-08 14:11:05 +01:00
Marie Verdonck
50eb5be31c 68150: resolve collection handles to collection in XmlWorkflowFactory & forgotten exception 2020-01-08 11:55:19 +01:00
Mark H. Wood
692bbd9449 [DS-4409] Don't use live GeoLite database for testing -- there might not be one. 2020-01-07 16:23:17 -05:00
Tim Donohue
da3a48ed04 Minor fix. Discard any output of TCP connection command, so we don't see initial connection errors. 2020-01-07 14:44:20 -06:00
Tim Donohue
d84cde2cc3 Ensure dspace container waits until db is accepting connections 2020-01-07 12:20:06 -06:00
Mykhaylo Boychuk
32c775445f added patchOperations for name and description 2020-01-07 11:44:53 +01:00
Mykhaylo Boychuk
64a2caed73 added patchOperatins for startDate and endDate 2020-01-07 11:36:46 +01:00
Mykhaylo Boychuk
d2ed1925c3 added unit tests for patch 2020-01-07 11:25:04 +01:00
Mykhaylo Boychuk
6be3b6a95e added methods withEndDate(), withDescriptions, withName for ResourcePolicyBuilder 2020-01-07 11:14:14 +01:00
Marie Verdonck
2c6c51752e 68155: /api/config/workflowactions/<:action-name> endpoint + tests 2020-01-06 16:50:02 +01:00
Kevin Van de Velde
977b3f409d [DS-4351] upgrade dependencies: Fixing a display issue in HAl & resolving a warning with slf4j on tomcat startup 2020-01-06 15:52:21 +01:00
Raf Ponsaerts
a208058d38 Working on fixes test issues 2020-01-06 14:12:08 +01:00
Raf Ponsaerts
248e67f9a3 Merge remote-tracking branch 'dspace/master' into w2p-64428_scripts-prototype-importing-and-exporting
Conflicts:
	dspace-api/src/main/java/org/dspace/app/launcher/ScriptLauncher.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/ScriptProcessesController.java
	dspace-server-webapp/src/main/java/org/dspace/app/rest/scripts/handler/impl/RestDSpaceRunnableHandler.java
	dspace-server-webapp/src/test/java/org/dspace/app/scripts/handler/impl/TestDSpaceRunnableHandler.java
2020-01-06 14:11:55 +01:00
Marie Verdonck
a254ae31e2 68150: /workflowdefinitions/defaultWorkflow/collections now returns all non-mapped collections and now returns paginated result + tests 2020-01-06 12:50:52 +01:00
Mykhaylo Boychuk
20f0ac3d22 Added permission evaluator plagin for patch in ResourcePolicy 2020-01-05 19:58:03 +01:00
Mark H. Wood
e018386175 [DS-4409] Remove GeoIP download Ant target, reconfigure for external provision. 2020-01-03 16:31:27 -05:00
Peter Nijs
87515d6deb 68007: Refactoring the IndexableObject & SolrServiceImpl 2020-01-03 17:54:25 +01:00
Marie Verdonck
7ed292e754 68150: fix and tests for pagination for api/config/workflowdefinitions 2020-01-03 17:11:26 +01:00
Ben Bosman
575e672fba webui.submit.upload.required should default to true 2020-01-03 13:57:25 +01:00
Marie Verdonck
d8dc4f113c 67998: non-numbered handle config so can't accidentally be created 2020-01-03 12:39:06 +01:00
Ben Bosman
1bb451db41 webui.submit.upload.required should default to true 2020-01-03 12:10:12 +01:00
Ben Bosman
f935faade1 webui.submit.upload.required should default to true 2020-01-03 10:59:11 +01:00
Ben Bosman
a962c35a81 webui.submit.upload.required should default to true 2020-01-03 09:40:37 +01:00
Giuseppe Digilio
787e2bbc97 Merge remote-tracking branch 'origin/master' into dspace-7-shibboleth 2020-01-02 18:28:30 +01:00
Ben Bosman
d2876e29dc webui.submit.upload.required should default to true 2020-01-02 18:28:22 +01:00
Marie Verdonck
9dd433412a 67998: tested config handle moved, since other non-collection dso already create at that handle 2020-01-02 17:40:18 +01:00
Marie Verdonck
414b82f9cb 67998: feedback exceptions 2020-01-02 17:05:19 +01:00
Kevin Van de Velde
b96138e3da Merge remote-tracking branch 'upstream/master' into DS-4351-upgrade-dependencies 2020-01-02 15:20:14 +01:00
Kevin Van de Velde
169f3d7e8e [DS-4239] Migrate the workflow.xml to spring: Fixing import issue 2020-01-02 10:41:04 +01:00
Kevin Van de Velde
a6eb614332 [DS-4239] Migrate the workflow.xml to spring: Adding some additional tests 2020-01-02 10:25:16 +01:00
Andrea Bollini
03623259dc Implement add, replace, delete operations for startDate 2019-12-30 18:06:30 +01:00
Mykhaylo Boychuk
b9f0f877bb Add ITs for patch operations, fix cast errors 2019-12-30 16:44:16 +01:00
Mykhaylo Boychuk
0604cf415a Merge branch 'resourcepolicies' of https://github.com/abollini/dspace into resourcepolicy_auth
merge resourcepolicy with resourcepolicy_auth
2019-12-24 11:47:08 +01:00
Andrea Bollini
a4fab8db03 Draft patch operations for ResourcePolicies 2019-12-24 11:11:06 +01:00
Andrea Bollini
613ceb8e5c Merge branch 'resourcepolicy_auth' into resourcepolicies 2019-12-24 08:42:06 +01:00
Mykhaylo Boychuk
d5313ca12e add property @PreAuthorize for methods createAndReturn and delete 2019-12-23 17:59:28 +01:00
Mykhaylo Boychuk
e88f6f9d8e Implemented unit tests for methods create and delete 2019-12-23 17:58:08 +01:00
Mykhaylo Boychuk
8ac971a63b Merge branch 'master' of https://github.com/DSpace/DSpace into resourcepolicies 2019-12-23 12:30:46 +01:00
Marie Verdonck
2521fa5107 67998: Merged in w2p-67996, altered XmlWorkflowFactoryTest to destroy created comcol 2019-12-23 12:09:02 +01:00
Mykhaylo Boychuk
d56b3b8013 Implement community feedbacks 2019-12-23 11:23:42 +01:00
Tim Donohue
c8bbe99e37 Merge pull request #2592 from paulo-graca/rcaap-openaire4-oai_openaire-support
OpenAIRE4 oai_openaire metadata format support
2019-12-20 14:33:31 -06:00
Tim Donohue
acb94e20f1 Merge pull request #2607 from atmire/w2p-67450_Discovery-clean-index-fix_7
[DS-4393] Discovery clean index fix
2019-12-20 13:58:28 -06:00
Tim Donohue
611258c0c8 Merge pull request #2580 from mspalti/discoveryAdmin
[DS-3906] REST endpoint for discovering withdrawn and private items.
2019-12-20 13:54:45 -06:00
Tim Donohue
0227b89a2c Merge pull request #2597 from atmire/DS-4391_fix_nonincoming_bitstream_gets
DS-4391 Get modified date from the right store
2019-12-20 13:52:25 -06:00
Kevin Van de Velde
a5ca3813b7 DS-4351 Upgrade spring (boot) & hibernate to newer versions: Removing unused mock 2019-12-20 17:03:45 +01:00
Kevin Van de Velde
0d41de5bf7 DS-4351 Upgrade spring (boot) & hibernate to newer versions: Removing unused mock 2019-12-20 16:38:52 +01:00
Kevin Van de Velde
98c483f7ca Merge branch 'master' into DS-4351-upgrade-dependencies 2019-12-20 11:48:47 +01:00
Marie Verdonck
59ef4ef065 Merge branch 'w2p-67996-workflow-junit-tests' into workflow-step-definitions 2019-12-20 11:22:59 +01:00
Marie Verdonck
7ef537507f - Merged with KevinVdV/DSpace/DS-4239-migrate-workflow-xml-to-spring
- Changed all implementations of XmlWorkflowFactoryImpl to work with new mapping
- Moved their java doc to XmlWorkflowFactory
- Removed/Changed exceptions
- Altered tests in WorkflowDefinitionRestRepositoryIT to work with changes

Merge remote-tracking branch 'github-kevin/DS-4239-migrate-workflow-xml-to-spring' into workflow-step-definitions

# Conflicts:
#	dspace-api/src/main/java/org/dspace/xmlworkflow/XmlWorkflowFactoryImpl.java
#	dspace-api/src/main/java/org/dspace/xmlworkflow/factory/XmlWorkflowFactory.java
2019-12-20 11:21:17 +01:00
Paulo Graça
d08fe3e4f5 remove openaire4 unused beans 2019-12-19 16:38:14 +00:00
Marie Verdonck
500fe6641d 67993: Tests for changes in workflow config 2019-12-19 16:26:25 +01:00
Kevin Van de Velde
96c084c4c2 Removing wrongly added @Ignore annotations 2019-12-19 14:44:14 +01:00
Marie Verdonck
39c727a803 67694: forgot to log error stack itself 2019-12-19 10:50:02 +01:00
Paulo Graça
c5e8cdac96 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-18 17:03:02 +00:00
Paulo Graça
817b8b1f45 changing the relation type to fetch the required funding sub fields 2019-12-18 16:53:41 +00:00
Paulo Graça
7814a9a1df adding comments for each template 2019-12-18 16:52:19 +00:00
Tim Donohue
ded7243a76 Merge pull request #2629 from paulo-graca/rcaap-openaire4-relationships
OpenAIRE4 missing relationships on registries
2019-12-18 09:39:53 -06:00
Paulo Graça
859eebf624 openaire4 transformer configuration 2019-12-18 14:23:03 +00:00
Paulo Graça
6970f4278a adding comments 2019-12-18 14:22:25 +00:00
Paulo Graça
1f07232d2b adding required openaire4 relationships 2019-12-18 11:44:55 +00:00
Paulo Graça
754d02378e fixing missing funder relationship 2019-12-18 11:38:15 +00:00
Paulo Graça
5aa76ce908 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-17 18:07:40 +00:00
Tim Donohue
124bc38a2c Merge pull request #2621 from paulo-graca/rcaap-openaire4-miscfixes
OpenAIRE4 adding missing field person.identifier
2019-12-17 11:50:32 -06:00
Tim Donohue
7bdb5a28d8 Merge pull request #2608 from paulo-graca/rcaap-openaire4-submissionform
OpenAIRE 4 submission forms
2019-12-17 11:47:15 -06:00
Paulo Graça
e3ac9a7874 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-miscfixes 2019-12-17 17:19:51 +00:00
Paulo Graça
f42f1c2a64 removing extra Turkish entry 2019-12-17 16:01:07 +00:00
Paulo Graça
c28b576975 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-submissionform 2019-12-17 15:58:47 +00:00
Paulo Graça
b892e883ed support for subjects and publihsers 2019-12-17 15:55:11 +00:00
Paulo Graça
784ef4b3ae Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-17 15:53:57 +00:00
Marie Verdonck
943b3f1356 67694: isDefault fix, workflowdefinitions IT, exception handling 2019-12-17 16:31:31 +01:00
Tim Donohue
e205009feb Merge pull request #2628 from atmire/w2p-67824_Entity-type-request-by-label
EntityType by label endpoint and integration tests
2019-12-17 09:21:00 -06:00
Paulo Graça
5fa561cf89 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-miscfixes 2019-12-17 14:26:56 +00:00
Paulo Graça
93ed485c7a changing comment 2019-12-17 10:24:29 +00:00
Paulo Graça
822d1bb02d Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-17 10:21:10 +00:00
Paulo Graça
ff61bb1521 replacing openAIRECreator with personOrOrganization 2019-12-17 10:18:51 +00:00
Paulo Graça
8ef8ff378f Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-submissionform 2019-12-17 10:15:29 +00:00
Marie Verdonck
8a3479e753 67694: Exception handling improvements and /search moved to repository 2019-12-17 11:08:17 +01:00
Tim Donohue
b610dd53c7 Merge pull request #2622 from atmire/default-entity-relationship-types
Default Entities relationship types used for the demos
2019-12-16 13:33:44 -06:00
Tim Donohue
023b143b95 Merge pull request #2618 from atmire/entities-submission-config
Entities submission config
2019-12-16 13:31:30 -06:00
Tim Donohue
da8488c7de Merge pull request #2614 from atmire/feature-external-sources-entities-post-workspace-item
Creating a workspace item from an external source
2019-12-16 13:28:44 -06:00
Paulo Graça
129a411a25 remove oai_openaire metadata format from the default context 2019-12-16 17:06:51 +00:00
Paulo Graça
f3673b132d removing trailling whitespaces 2019-12-16 15:34:44 +00:00
Paulo Graça
0d427faa20 adding a specific filter for openaire4 2019-12-16 15:32:14 +00:00
Paulo Graça
a696d6ec43 removing 'configuration' word from openaire configuration naming and fixing wrong element and qualifier names 2019-12-16 12:06:59 +00:00
Kevin Van de Velde
f4304673ed Merge branch 'master' into DS-4239-migrate-workflow-xml-to-spring 2019-12-16 13:00:54 +01:00
Paulo Graça
dbf9054182 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-submissionform 2019-12-16 11:56:02 +00:00
Marie Verdonck
5831f4cbde 67824: EntityType by label endpoint and integration tests 2019-12-16 12:48:34 +01:00
Paulo Graça
a502b190f5 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-16 11:27:20 +00:00
Paulo Graça
1e0743c251 fixing errors with earlier transformation/normalization 2019-12-16 11:27:03 +00:00
benbosman
fd8e8fc76e Merge pull request #2615 from atmire/get-entity-type-performance
Get entity type performance improvement
2019-12-16 11:25:43 +01:00
benbosman
5edae495f4 Merge pull request #2617 from atmire/DS-4401
DS-4401 Enforce relational place ordering when place direction is known
2019-12-16 11:24:29 +01:00
Mykhaylo Boychuk
63701ce239 implemented method delete() 2019-12-16 10:01:08 +01:00
Mykhaylo Boychuk
5f2235e434 implemented unit test deleteOne 2019-12-16 09:59:01 +01:00
Mykhaylo Boychuk
8e8b1762e2 add Jackson(Access.OnlyRead) property to method getType, and fix method createAndReturn 2019-12-16 09:57:55 +01:00
Mykhaylo Boychuk
edb7a0f2e3 added method createAndReturn 2019-12-14 19:28:13 +01:00
Mykhaylo Boychuk
2810a815e4 added static method delete by id in ResourcePolicyBuilder 2019-12-14 18:58:04 +01:00
Mykhaylo Boychuk
bf05290b0c Implemented unit test for method createAndReturn 2019-12-14 18:42:20 +01:00
Paulo Graça
dcaad7584b modifying default values and add more openaire4 support 2019-12-13 16:31:22 +00:00
Raf Ponsaerts
525a586e53 Applied feedback to the external sources entities post workspace item feature 2019-12-13 16:23:02 +01:00
Anis
29432d80f4 forgot doc namespace 2019-12-13 14:57:13 +02:00
Anis
8f10cf534c upgrade mets xslt version to 2.0 2019-12-13 14:23:54 +02:00
Paulo Graça
4fc7ce6072 adding support for entities and other elements like: creator, contributors, fundingReference, dates 2019-12-12 16:00:27 +00:00
Paulo Graça
bd5efcd4e9 removing unsed filter 2019-12-12 15:58:26 +00:00
Paulo Graça
ea2e3e2a02 Changing XOAI dependency to version that solves an existing bug 2019-12-12 15:57:25 +00:00
Paulo Graça
255a77c4a6 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-12 13:28:46 +00:00
Paulo Graça
51cda8668e adding a new dspace url as a field element 2019-12-12 13:28:37 +00:00
Marie Verdonck
6084fae357 67694: checkstyle and licenses 2019-12-12 10:42:04 +01:00
Andrew Wood
c76994a3a0 DS-4401 apply place ordering in findByLabel for RelationshipRestRepository 2019-12-11 14:48:32 -05:00
Tim Donohue
884e1f8d73 Merge pull request #2623 from tdonohue/update_entities_sample_data
[Docker] Update DSpace 7 Entities sample data SQL and assetstore
2019-12-11 10:17:24 -06:00
Tim Donohue
f1ba87474f Update Entities sample data SQL and assetstore 2019-12-11 09:43:55 -06:00
Raf Ponsaerts
2f870cbe78 [Task 67817] cleaned up code 2019-12-11 16:07:38 +01:00
Raf Ponsaerts
35e9e3ed5d [Task 67817] first fix for the relationshiptypes for entitytype endpoint 2019-12-11 15:23:17 +01:00
Ben Bosman
ea914a42ae Default Entities relationship types used for the demos 2019-12-11 14:52:15 +01:00
Marie Verdonck
58870b079d 67694: new /api/config/workflowsdefintions endpoints:
/api/config/workflowdefinitions/<:definition-name>
/api/config/workflowdefinitions
/api/config/workflowdefinitions/search/findByCollection?uuid=<:collection-uuid>
/api/config/workflowdefinitions/<:definition-name>/collections

Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
2019-12-11 13:58:24 +01:00
Marie Verdonck
76853f8dd6 Merge remote-tracking branch 'dspace-origin/master' into DS-4389-improving-patch-system-framework
# Conflicts:
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/ItemRestRepository.java
2019-12-11 09:55:07 +01:00
Kevin Van de Velde
2dd5512286 Merge pull request #2600 from atmire/DS-4317_bundles-in-REST-continued
Ds 4317 bundles in rest continued
2019-12-11 09:53:09 +01:00
Paulo Graça
992d65df4f Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-10 18:22:42 +00:00
Paulo Graça
351c3debac adding a catch all person.identifier field 2019-12-10 17:55:08 +00:00
Paulo Graça
cbfc5c826d moving openAIRE submission steps to just before the sample item 2019-12-10 17:46:04 +00:00
Ben Bosman
35d743601a Entities submission configuration 2019-12-10 18:39:03 +01:00
Paulo Graça
713f0caa89 removing form-value-pairs for language iso 3 and replacing with the default also adding portuguese to the default languages list 2019-12-10 17:35:59 +00:00
Paulo Graça
d687ff3390 enhancing comments and rename bean from openAIREAuthor to a more generic personOrOrganization 2019-12-10 17:34:44 +00:00
Paulo Graça
12700203a8 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-submissionform 2019-12-10 17:12:43 +00:00
Marie Verdonck
ce2662c58d DS-4389 improving patch system framework - Minor feedback changes PR 2591 2019-12-10 17:40:15 +01:00
Raf Ponsaerts
e295a76c70 [Task 66428] Applied feedback to the MetadataImport and Export scripts and framework 2019-12-10 16:13:54 +01:00
Kevin Van de Velde
1c6d262c03 DS-4351 Upgrade spring (boot) & hibernate to newer versions: Fixing issues with the latest master merge 2019-12-10 15:58:11 +01:00
Ben Bosman
eda9a8fcaa Entities submission configuration 2019-12-10 15:47:46 +01:00
Ben Bosman
7130e5d3d2 Entities submission configuration 2019-12-10 15:05:44 +01:00
Ben Bosman
f26d0475ac Entities submission configuration 2019-12-10 14:55:48 +01:00
Kevin Van de Velde
5bf433f71b DS-4351 Upgrade spring (boot) & hibernate to newer versions: Fixing issues with the latest master merge & fixing the tests 2019-12-10 14:16:54 +01:00
benbosman
40128ab632 Merge pull request #2599 from atmire/w2p-66086_delete-relationships-relationshiptype-copyleft-copyright-variables
Delete item with relationships: configure defaults
2019-12-10 13:27:09 +01:00
Mykhaylo Boychuk
b917a479e9 Implement community feedbacks 2019-12-10 12:59:15 +01:00
Andrew Wood
f6d17aa0ba DS-4401 Enforce relational place ordering when place direction is known 2019-12-09 16:04:55 -05:00
Paulo Graça
fa5882fc7d Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-09 17:26:02 +00:00
Paulo Graça
0505ed9aa8 virtual metadata default settings and oai_openaire4 default transformation 2019-12-09 17:25:52 +00:00
Mykhaylo Boychuk
0178c6b490 created:
Class:
		- DSpaceObjectRestPermissionEvaluatorPlugin
		- DSpaceObjectUtils - this class contain the method that permit to find some DSpaceObject by UUID
2019-12-09 16:30:07 +01:00
Kevin Van de Velde
3e74b20d8e Merge branch 'master' into DS-4351-upgrade-dependencies 2019-12-09 15:32:26 +01:00
Kevin Van de Velde
8d4ebac101 DS-4351 Upgrade spring (boot) & hibernate to newer versions: Restore datasource 2019-12-09 14:25:04 +01:00
Tim Donohue
1b533d5d0c Merge pull request #2613 from atmire/avoid-lang-ANY-virtual-metadata
Avoid setting the virtual metadata language to ANY (*)
2019-12-06 09:43:12 -06:00
Raf Ponsaerts
3b8b3db22c Fixed Travis failure on EntityServiceImplTest 2019-12-06 14:17:27 +01:00
Paulo Graça
a0edc14bcc Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-06 11:41:08 +00:00
Paulo Graça
4c914c147b reverting virtual metadata 2019-12-06 11:32:16 +00:00
Paulo Graça
b7847c0268 reverting errors 2019-12-06 11:30:04 +00:00
Paulo Graça
9f647bb6ca Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-submissionform 2019-12-06 11:26:30 +00:00
Paulo Graça
7ec0733de0 reverting virtual metadata changes (they will be moved to oai_openaire PR) 2019-12-06 11:26:17 +00:00
Paulo Graça
929262e9a6 Indentation fix and allowing openAIRE specific discovery search configurations 2019-12-06 11:25:11 +00:00
Paulo Graça
e348cf031a setting name variants parameter 2019-12-06 11:21:26 +00:00
Raf Ponsaerts
78c1773fac Merge remote-tracking branch 'dspace/master' into feature-external-sources-entities-post-workspace-item 2019-12-06 10:36:23 +01:00
Raf Ponsaerts
5585d27991 Refactored the UriListHandler and its implementations and supported the workspace item creation from ExternalDataObjects 2019-12-06 10:36:12 +01:00
Ben Bosman
533b0b9838 Avoid setting the virtual metadata language to ANY (*) 2019-12-06 09:48:12 +01:00
Tim Donohue
dd0ab630e0 Merge pull request #2590 from atmire/feature-external-sources-entities-post
Feature: Creating an archived item from an external source
2019-12-05 14:52:42 -06:00
Kevin Van de Velde
84775128b1 Adding missing MetadataExportServiceImpl to the core-services.xml file 2019-12-05 15:59:52 +01:00
Ben Bosman
bd14a517f2 Avoid setting the virtual metadata language to ANY (*) 2019-12-05 15:06:17 +01:00
Raf Ponsaerts
30eb596224 Removed redundant admin check in ExternalSourceEntryUriListHandler 2019-12-05 14:49:00 +01:00
Raf Ponsaerts
43f9e9c545 Applied feedback to the ExternalSourceEntryUriListHandler 2019-12-05 13:50:49 +01:00
Raf Ponsaerts
b0cdb3907d Renamed copyLeft and copyRight, added defaults for them in the test Relationship-types file and added a test for the place check after deleting a relationship and keeping the virtual metadata 2019-12-05 11:03:11 +01:00
Michael W Spalti
7b36453c58 Minor update in discovery.xml 2019-12-04 12:46:36 -08:00
Michael W Spalti
00ac347361 Merge remote-tracking branch 'upstream/master' into discoveryAdmin 2019-12-04 12:25:48 -08:00
Michael W Spalti
4b64105962 Added check for commuity/collection admins to solr plugin for private items. 2019-12-04 11:54:55 -08:00
Michael W Spalti
9c5f1c1e11 Renamed discovery configuration and added error message. 2019-12-04 10:31:50 -08:00
Paulo Graça
dd570ead94 new filter 2019-12-04 17:35:34 +00:00
Paulo Graça
da216d12bf field descriptions 2019-12-04 17:34:58 +00:00
Paulo Graça
a138dff22f Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-submissionform 2019-12-04 09:53:38 +00:00
Paulo Graça
58c48d1190 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-04 09:52:16 +00:00
Michael W Spalti
50794b6015 Fixed style check error. 2019-12-03 18:06:24 -08:00
Michael W Spalti
9e320da6b1 Removes browse for private and withdrawn items, removes the includeUnDiscoverable boolean from SearchService methods, adds solr plugin to prevent non-admin discovery of private items. 2019-12-03 17:19:50 -08:00
Tim Donohue
cb5e71cb18 Merge pull request #2610 from atmire/w2p-67600_bug-update-relationships
Updating Relationships through JSON put causes place alterations to be broken
2019-12-03 15:30:14 -06:00
Tim Donohue
f9098ae126 Merge pull request #2576 from paulo-graca/rcaap-openaire4-fields
OpenAIRE 4 required fields
2019-12-03 15:26:05 -06:00
Paulo Graça
dd27fe758f Removing relationships loading for each item - leaving the refactored code 2019-12-03 17:55:22 +00:00
Paulo Graça
019a6c42a3 Removing relationships loading for each item - leaving the refactored code 2019-12-03 17:54:48 +00:00
Paulo Graça
e24921502d Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-12-03 17:50:25 +00:00
Paulo Graça
d4a59d8214 initial virtual metadata 2019-12-03 15:50:52 +00:00
Paulo Graça
5e163f3beb new openaire discovery search filters 2019-12-03 15:21:51 +00:00
Paulo Graça
4ceed51567 OpenAIRE default discovery settings 2019-12-03 15:09:16 +00:00
Paulo Graça
db1408b796 OpenAIRE default discovery settings 2019-12-03 15:07:37 +00:00
Paulo Graça
73fb573742 address submission forms changes 2019-12-03 12:06:31 +00:00
Mykhaylo Boychuk
fbdee987c9 added the following unit test:
- findOneAccessGrantToAdminTest()
        - findOneAccessGrantToSomeOneUserTest()
2019-12-03 12:53:43 +01:00
Raf Ponsaerts
bf3796874d Fixed the bug in the PUT endpoint for Relationships 2019-12-03 10:20:23 +01:00
Raf Ponsaerts
3c917619f3 Made a test to prove that the PUT on Relationships with JSON fails 2019-12-03 09:50:57 +01:00
Mykhaylo Boychuk
27735d7126 created:
class:
        - resourcePolicyRestPermissionEvaluatorPlugin
    method:
       - boolean hasDSpasePermission(Authentication authentication, Serializable targetId, String targetType, DSpaceRestPermission permission)
       - boolean isMyResoursePolicy(Context context, EPerson eperson, Integer id)  - this one checks if the resourcePolicy, that I'm searching, is of the authenticated person
       - ResourcePolicy findOneById (DAO)
2019-12-02 16:15:32 +01:00
Raf Ponsaerts
daeab74815 Added proper authorization handling for the ExternalSources item create endpoint 2019-12-02 12:07:49 +01:00
Raf Ponsaerts
5b16e21980 Merge branch 'feature-external-sources-entities-post' of https://github.com/atmire/DSpace into feature-external-sources-entities-post 2019-12-02 11:27:25 +01:00
Raf Ponsaerts
664c970da9 Fixed minor bug in the UriList parsing and added IT tests 2019-12-02 11:27:12 +01:00
Mykhaylo Boychuk
5eff3c6295 I added the following unit tests:
- findOneForbiddenTest()
- searchResoucesPolicyByEPersonUuidForbiddenTest()
- searchResoucesPoliciesByResourceUuidForbiddenTest()
- searchResoucesPolicyByGroupUuidForbiddenTest()
2019-12-01 11:49:27 +01:00
Marie Verdonck
b781ae5560 [DS-4389] (Improving patch system framework) Rename of package since there are no more factories 2019-11-29 15:47:58 +01:00
Kevin Van de Velde
4c9a30bb14 [DS 4287] Refactoring the IndexableObject & SolrServiceImpl to become more expandable 2019-11-29 14:26:50 +01:00
Paulo Graça
dbfbc853bf changing case for identifiers 2019-11-29 10:55:44 +00:00
Mykhaylo Boychuk
3c7d59a8a4 DS-4398 fix checkstyle issues 2019-11-29 11:44:03 +01:00
Paulo Graça
3afd0d8d02 changing form names and adding references into item-submission and indentation 2019-11-29 10:40:54 +00:00
Paulo Graça
90b0862453 initial openaire on default item submission forms 2019-11-28 17:31:09 +00:00
Mykhaylo Boychuk
b236b8e487 Merge branch 'master' of https://github.com/DSpace/DSpace into resourcepolicies
# Conflicts:
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/ResourcePolicyRestRepository.java
2019-11-28 17:33:18 +01:00
Paulo Graça
3c8d906539 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-fields 2019-11-28 16:05:26 +00:00
Paulo Graça
a8bf0f7efa comments 2019-11-28 16:04:51 +00:00
Paulo Graça
9c53334088 Initial openaire submission forms 2019-11-28 15:45:29 +00:00
Ben Bosman
4fda5c1354 improving performance of the getType function, it's not a virtual field 2019-11-28 14:16:04 +01:00
Mykhaylo Boychuk
f0eb9cb3d9 DS-4398 initial implementation of the resource policies endpoint
DONE
- sync implementation of findAll with the contract
- add ITs for implemented methods

TODO
- enforce security in access resource policy details
- method to create a resource policy
- method to patch a resource policy
2019-11-28 13:20:43 +01:00
Paulo Graça
e24fa61c8e indentation fix 2019-11-28 10:39:30 +00:00
Kevin Van de Velde
a5cd7b8fb4 Merge remote-tracking branch 'upstream/master' into DS-4317_bundles-in-REST-continued 2019-11-28 10:44:58 +01:00
Kevin Van de Velde
219b086979 Merge branch 'master' into DS-4317_bundles-in-REST-continued 2019-11-28 10:39:25 +01:00
Kevin Van de Velde
2bcd6013eb [DS 4389] Improving patch system framework: Fixing merge issues with master 2019-11-28 10:33:32 +01:00
Tim Donohue
9c17f1706b Merge pull request #2575 from paulo-graca/rcaap-openaire4-relationships
OpenAIRE 4 Entities and Relationships
2019-11-27 09:04:16 -06:00
Paulo Graça
b0016fc245 remove trailing whitespaces 2019-11-27 14:37:13 +00:00
Paulo Graça
12b468a366 remove trailing whitespaces 2019-11-27 13:56:53 +00:00
Kevin Van de Velde
62461febe1 Merge branch 'master' into DS-4389-improving-patch-system-framework 2019-11-27 14:55:16 +01:00
Paulo Graça
fdd6caf9ab Removing types of publication ids from schema and change the generic authorid to scopus-author-id 2019-11-27 13:50:38 +00:00
Paulo Graça
d5854256d3 reset dublin-core-types file 2019-11-27 13:15:55 +00:00
Paulo Graça
e4661ebb54 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-fields 2019-11-27 12:04:47 +00:00
Paulo Graça
a5d999dbd8 remove trailing whitespaces 2019-11-27 12:03:30 +00:00
Paulo Graça
dacc74c0a3 comments 2019-11-27 11:58:51 +00:00
Kevin Van de Velde
5133266cad Fixing a merge issue 2019-11-27 12:45:34 +01:00
Kevin Van de Velde
75b508d4ea Merge branch 'master' into feature-external-sources-entities-post 2019-11-27 11:46:47 +01:00
Kristof De Langhe
a4006cd17e 67450: Discovery clean index fix 2019-11-27 11:43:19 +01:00
Paulo Graça
28deccf57e Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-11-27 10:01:04 +00:00
Paulo Graça
f1baeb5ad1 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-relationships 2019-11-26 17:32:24 +00:00
Paulo Graça
08262593b7 openaire entities and relationships 2019-11-26 17:32:14 +00:00
Paulo Graça
4c160a4725 Moving relationships into /config/entities folder 2019-11-26 17:27:09 +00:00
Tim Donohue
b2657cdc4e Merge pull request #2577 from atmire/w2p-65267_delete-in-relationshipservice
Delete item with relationships
2019-11-26 11:06:00 -06:00
Tim Donohue
60eb7aa7b2 Merge pull request #2598 from atmire/w2p-66436_projects-discovery-configuration
Entities: Projects discovery configuration
2019-11-26 11:02:27 -06:00
Tim Donohue
f4d51cc905 Merge pull request #2560 from atmire/feature-external-sources
Feature: external sources
2019-11-26 10:51:58 -06:00
Peter Nijs
0fd4831466 Merge branch 'w2p-65267_delete-in-relationshipservice' into w2p-66086_delete-relationships-relationshiptype-copyleft-copyright-variables 2019-11-26 17:33:40 +01:00
Peter Nijs
d12f999c49 Merge remote-tracking branch 'dspace/master' into w2p-65267_delete-in-relationshipservice manual fix 2019-11-26 17:28:52 +01:00
Peter Nijs
736d30f48a Merge remote-tracking branch 'dspace/master' into w2p-65267_delete-in-relationshipservice 2019-11-26 17:28:22 +01:00
Kevin Van de Velde
cba7b3dc3a Merge pull request #2579 from atmire/w2p-65257_Collection-item-template-crud
CRUD for collection item template
2019-11-26 16:39:40 +01:00
Kevin Van de Velde
9102945aae Restoring the original capitalization of the "sherpa.romeo.apiKey" configuration value 2019-11-26 16:33:56 +01:00
jonas-atmire
4c011a7918 Removal of unused variable 2019-11-26 15:56:54 +01:00
Raf Ponsaerts
3471498018 Small improvements to the external sources feature 2019-11-26 14:03:28 +01:00
Raf Ponsaerts
967b598b99 Fixed import in ExternalDataServiceImpl 2019-11-26 13:53:35 +01:00
Raf Ponsaerts
92e8f98216 Merge branch 'feature-external-sources' into feature-external-sources-entities-post 2019-11-26 13:30:47 +01:00
Raf Ponsaerts
3596913505 Fixed checkstyle and removed unused variables in ExternalSourceRestRepository 2019-11-26 13:29:46 +01:00
Raf Ponsaerts
3dac3e8911 Merge branch 'feature-external-sources' into feature-external-sources-entities-post 2019-11-26 13:27:03 +01:00
Raf Ponsaerts
031ceffeaa Refactored javadoc on MetadataValue, refactored package, altered property in external-services.xml 2019-11-26 13:26:35 +01:00
Raf Ponsaerts
196894e46e Refactored Mockmetadata to MetadataValueDTO and fixed checkstyle 2019-11-26 13:20:36 +01:00
Raf Ponsaerts
c85f88d737 Merge branch 'feature-external-sources' into feature-external-sources-entities-post
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/ItemRestRepository.java
2019-11-26 13:20:03 +01:00
Paulo Graça
9f7438394d Replacing Organization with OrgUnit 2019-11-26 11:49:03 +00:00
benbosman
295ee3fd0b removing line breaks 2019-11-26 11:07:05 +01:00
Raf Ponsaerts
7a935f4f8b Integrating projections into feature-external-sources 2019-11-26 10:48:14 +01:00
Peter Nijs
076e3c17d3 Merge remote-tracking branch 'dspace/master' into w2p-65257_Collection-item-template-crud manual fixes 2019-11-26 10:16:12 +01:00
Peter Nijs
ef3d3a4158 Merge remote-tracking branch 'dspace/master' into w2p-65257_Collection-item-template-crud 2019-11-26 10:14:52 +01:00
Raf Ponsaerts
070480418b Merge remote-tracking branch 'dspace/master' into feature-external-sources 2019-11-26 09:29:07 +01:00
Raf Ponsaerts
57894bb8b6 [Task 66453] applied feedback to the variable naming and properties for external sources feature 2019-11-26 09:27:03 +01:00
Paulo Graça
192cd265b6 Merge branch 'rcaap-openaire4-fields' of https://github.com/paulo-graca/DSpace into rcaap-openaire4-fields 2019-11-25 17:01:38 +00:00
Paulo Graça
b1e16c71fa revert test parameters 2019-11-25 16:08:44 +00:00
Paulo Graça
f7e1bf6896 moving DC fields and identifiers into proper Schemas 2019-11-25 16:05:40 +00:00
Paulo Graça
7bbc2c57ad Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-fields 2019-11-25 14:14:13 +00:00
Paulo Graça
e6e4ccb942 Changing Relationships to Entities node element 2019-11-25 14:13:52 +00:00
Paulo Graça
532d8434c8 Initial oai_openaire metadata format support with entities 2019-11-25 13:31:04 +00:00
Paulo Graça
e1d13f074f Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-11-25 12:01:55 +00:00
Paulo Graça
46d4f5e30a Initial oai_openaire metadata format support with entities 2019-11-25 12:01:40 +00:00
benbosman
012d88db17 Merge pull request #2547 from atmire/DS-3533_Projections
DS-3533 projections support
2019-11-25 11:37:02 +01:00
Raf Ponsaerts
7c7aedfed4 Refactored the findOne and findAll methods to work through the RestResourceController instead of a custom one 2019-11-25 11:34:26 +01:00
Chris Wilper
ff3930a734 Merge branch 'master' into DS-3533_Projections 2019-11-24 12:51:33 -05:00
Chris Wilper
ccf047cd63 DS-4391 Get modified date from the right store
This also tightens up the contract and improves javadocs a bit,
so callers know what to expect.
2019-11-23 07:18:39 -05:00
Giuseppe Digilio
ccb0efd2ea use X-Requested-With header if Referer is empty 2019-11-22 17:07:41 +01:00
Giuseppe Digilio
8ce9c2d98f Chack if authentication cookie is present in Authentication Data 2019-11-22 17:07:36 +01:00
Giuseppe Digilio
85e253bb9f Added shibboleth authentication filter 2019-11-22 17:07:29 +01:00
Giuseppe Digilio
705c887998 Added login filter to /api/authn/shibboleth 2019-11-22 17:07:23 +01:00
Giuseppe Digilio
abbf3f7361 Handle redirect to client after shibboleth authentication succeded 2019-11-22 17:07:13 +01:00
Giuseppe Digilio
13482c2eb7 Added a cookie with JWT to response 2019-11-22 17:07:00 +01:00
Tim Donohue
3b578c6766 Merge pull request #2596 from atmire/DS-4390_scripts-bug-scriptlauncher
[DS-4390] rewrote ScriptLauncher to include scripts from other config…
2019-11-22 09:31:23 -06:00
Raf Ponsaerts
9ceb8cd10e [Task 66437] added project discovery config 2019-11-22 15:42:24 +01:00
Raf Ponsaerts
64180c6041 [Task 66436] added Project discovery configuration to the discovery.xml 2019-11-22 14:31:58 +01:00
Raf Ponsaerts
e87dd5a8b7 [DS-4390] fixed test failure and cleaned up ScriptRestRepository from DSpaceRunnable logic, moved to ScriptService instead 2019-11-22 14:15:26 +01:00
Raf Ponsaerts
02d98b2760 [DS-4390] undid MultipartFileException 2019-11-22 13:35:33 +01:00
Raf Ponsaerts
959dacad6a [DS-4390] cleaned up Integer in scriptlauncher 2019-11-22 13:27:15 +01:00
Peter Nijs
76347b0cf0 66458: Use shared UUID regex instead of object's own one 2019-11-22 13:27:01 +01:00
Raf Ponsaerts
9be226e6d3 [DS-4390] cleanup retrieval of DSpaceRunnable by name and cleanup in ScriptLauncher.java 2019-11-22 13:24:46 +01:00
Raf Ponsaerts
71b1360cbf [DS-4390] rewrote ScriptLauncher to include scripts from other config to be checked as well as fixing tests 2019-11-22 11:06:12 +01:00
Raf Ponsaerts
4e0b97fb88 Processing feedback on external sources PR 2019-11-22 09:44:46 +01:00
Peter Nijs
4cc7cec563 Merge remote-tracking branch 'dspace/master' into w2p-65257_Collection-item-template-crud 2019-11-22 09:43:35 +01:00
Tim Donohue
4240ade8ca Merge pull request #2594 from atmire/w2p-66396_bug-in-get-collections
Bug in GET collections
2019-11-21 15:16:53 -06:00
Tim Donohue
abf6a36fe3 Merge pull request #2529 from atmire/w2p-64334_scripts-prototype
Scripts and processes endpoint
2019-11-21 15:06:35 -06:00
Tim Donohue
ecfdc2b627 Merge pull request #2548 from atmire/DS-4317_bundles-in-REST
Ds 4317 bundles in rest
2019-11-21 14:51:56 -06:00
Raf Ponsaerts
9733bd3441 Merged master into this branch and fixed tests/issues with metadata-import 2019-11-21 15:19:05 +01:00
Raf Ponsaerts
08c7da4446 Implementing file import and export scripts 2019-11-21 13:22:09 +01:00
Marie Verdonck
6f822dbb98 DS-4317 - bundles in REST: Redefined RequestMapping to use constants defined in Rest classes 2019-11-21 12:10:15 +01:00
Marie Verdonck
7148f7cd0b DS-4317 - bundles in REST: Redefining RequestMapping of Controllers to be unique and to use constants defined in Rest classes 2019-11-21 11:43:11 +01:00
Raf Ponsaerts
bc9fc2f066 Fixed the CollectionDAOImpl#findAll method to only return one entry per Collection even if it has multiple language values for the dc.title metadata field 2019-11-21 11:07:51 +01:00
Raf Ponsaerts
9e6fe1c9a2 [Task 66396] added a test that proves that the collection endpoint returns the same collection multiple times if it has different language fields for dc.title 2019-11-21 10:12:33 +01:00
Peter Nijs
ebd6ee73fb 65257: fix typo in error message 2019-11-21 09:56:28 +01:00
Raf Ponsaerts
0ea677914f Refactored the naming and the request mapping of the Scripts Controller to be less ambiguous and less confusing 2019-11-21 09:26:24 +01:00
Paulo Graça
67c467ade4 Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-oai_openaire-support 2019-11-20 15:49:15 +00:00
Paulo Graça
646651a6d9 Filtering Entities on the default context 2019-11-20 15:48:50 +00:00
Tim Donohue
d99ccc6bfc Merge pull request #2551 from atmire/w2p-65568_bugs-place-management-creating-relationships
Entities bug-fixes in place management
2019-11-20 09:07:31 -06:00
Kevin Van de Velde
78da4b53fc Merge remote-tracking branch 'upstream/master' into DS-4389-improving-patch-system-framework 2019-11-20 16:02:12 +01:00
Raf Ponsaerts
623451dd3e [Task 66408] applied community feedback to the Relationship Delete methods 2019-11-20 14:19:54 +01:00
Kevin Van de Velde
6daad55762 Patch refactor: The supports method now accepts an object instead of a DSpaceObject, else other objects aren't supported for these patches. Also adding missing @Override annotations 2019-11-20 14:16:03 +01:00
Raf Ponsaerts
bb4eef94f2 [Task 65568] added a testGetNextLeftPlace test in the RelationshipMetadataServiceTest 2019-11-20 13:28:49 +01:00
Tim Donohue
41fa29e5b0 Merge pull request #2585 from atmire/DS-4386_nullpointer-exception-item-put-endpoint-authenticated-user
[DS-4386] fixed the nullpointer issue when an authenticated non-admin…
2019-11-19 15:59:28 -06:00
Tim Donohue
09646aabde Merge pull request #2589 from atmire/search-relationships-total-fix
Entities: Search relationships total fix
2019-11-19 15:54:32 -06:00
Chris Wilper
0a36fc13f1 DS-3533 Make MetadataConverter a DSpaceCoverter, supporting projections 2019-11-19 12:45:09 -05:00
Tim Donohue
7b90332049 Merge pull request #2568 from atmire/DS-4379_Omit-metadatvalue-rels
DS-4379 Stop adding relations as metadata for new items
2019-11-19 09:24:35 -06:00
Tim Donohue
64702f5745 Merge pull request #2561 from atmire/w2p-65570_Configuring-whether-name-variants-should-be-used
Entities: configuring whether name variants should be used
2019-11-19 09:23:14 -06:00
Paulo Graça
3eff84a4bd Separate citation elements into qualifiers 2019-11-19 12:03:45 +00:00
Ben Bosman
d225489cab Travis trigger 2019-11-19 13:01:58 +01:00
Ben Bosman
864ea1d591 fixing total calculation 2019-11-19 11:31:57 +01:00
Ben Bosman
4415ea2237 whitespace 2019-11-19 10:56:16 +01:00
Ben Bosman
7109a357ed IT for fixing total calculation 2019-11-19 09:55:39 +01:00
Ben Bosman
02df6154e4 fixing total calculation 2019-11-19 09:47:56 +01:00
Raf Ponsaerts
3dfa695dbf [DS-4386] added a context.restoreAuthSystemState to the update test 2019-11-19 09:41:23 +01:00
Marie Verdonck
1deb82f0e3 66183: feedback processed:
- Split DSOMetadataOperation in separate operation classed
- supports() also checks operation.getOp()
- ResourcePatchOperation removed
- removed some unneeded null checks
- DspaceObjectMetadataOperation.performPatchOperation() exceptions thrown without changes
- All services autowired, not via factories
2019-11-18 14:05:27 +01:00
Paulo Graça
ec7b037a6f Merge branch 'master' of github.com:DSpace/DSpace into rcaap-openaire4-fields 2019-11-18 12:15:22 +00:00
kshepherd
6add401f81 Merge pull request #2587 from tdonohue/Docker_one_path_for_server_webapp
[Docker Fix] Ensure the "server" webapp runs on ONLY one path in Docker
2019-11-17 12:15:19 +13:00
Tim Donohue
238232bbfd Ensure the "server" webapp runs on one path in Docker 2019-11-15 15:08:42 -06:00
Tim Donohue
ad325a0679 Merge pull request #2586 from tdonohue/fix_script_line_endings
[Docker Build Fix]: Ensure bin scripts ALWAYS have correct line endings
2019-11-15 12:48:32 -06:00
Tim Donohue
a8cb5359d6 Ensure bin scripts ALWAYS have correct line endings 2019-11-15 11:43:18 -06:00
Raf Ponsaerts
2b97950b4c [DS-4386] fixed the nullpointer issue when an authenticated non-admin user tries to update an item using the Item PUT endpoint 2019-11-15 11:35:17 +01:00
Tim Donohue
dea19f8412 Merge pull request #2582 from mwoodiupui/DS-4385
[DS-4385] Replace <prerequisites> with enforcer rules in POM
2019-11-14 13:00:01 -06:00
Marie Verdonck
454745b91a Merge branch 'master' into DS-4317_bundles-in-REST
# Conflicts:
#	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/BitstreamRestRepository.java
2019-11-14 18:37:30 +01:00
Mark H. Wood
84ab9252b4 [DS-4385] Move Maven minimum version to enforcer plugin. 2019-11-14 11:46:23 -05:00
Chris Wilper
18ea0a2434 DS-3533 Add projection-related tests, resolve minor functional issues, and improve javadocs 2019-11-14 09:32:40 -05:00
Peter Nijs
6e56c8bad1 65956: Cleanup and preauthorize fix for CRUD on Collection Item template 2019-11-14 15:25:34 +01:00
Marie Verdonck
69327477a7 Bundles in REST: Feedback implemented:
- Renaming: BundleController > BundleUploadBitstreamController, ItemController > ItemAddBundleController
 - Moved: BitstreamRestController#getBundle() & #move() to new BitstreamBundleController class
 - Javadocs added to all three
 - Correction @RequestMapping of BundleUploadBitstreamController
2019-11-14 15:24:52 +01:00
Raf Ponsaerts
fcd6429ec0 [Task 66086] implemented a configuration on the RelationshipType object to determine whether metadata should be copied left or right or not at all when deleting a relationship 2019-11-14 11:18:47 +01:00
Michael W Spalti
9d45a1d89f Formatting corrections. 2019-11-13 17:49:53 -08:00
Michael W Spalti
b6849e51a6 Fixing tests for travis (currently unable to test on local machine) 2019-11-13 17:33:25 -08:00
Michael W Spalti
2113317946 [DS-3906] REST endpoint for discovering withdrawn and private items. 2019-11-13 16:35:49 -08:00
Marie Verdonck
ac57139d10 66075: Improvements from feedback:
- DspaceObjectMetadataOperation.performPatchOperation()
  > Logic split into seperate methods
- DspaceObjectMetadataOperation.replace()
  > Split into method per case
2019-11-13 19:01:18 +01:00
Paulo Graça
d0047c8d65 adjust MetadatafieldRestRepositoryIT.findall test to cover more metadatafield results 2019-11-13 14:50:40 +00:00
Paulo Graça
a1d4123352 adjust MetadatafieldRestRepositoryIT.findall test to cover more metadatafield results 2019-11-13 14:12:50 +00:00
Raf Ponsaerts
4c1f4e422c [Task 66031] wrote javadocs or ProcessRestPermissionEvaluatorPlugin, cleaned up ProcessRestRepository 2019-11-13 14:13:42 +01:00
Marie Verdonck
57c23f3e82 66075: added back existingValue checks to non-boolean replace operations,
the set functionality should be in an ADDoperation (not yet implemented)
- EPersonCertificateReplaceOperation, EPersonLoginReplaceOperation, ItemDiscoverableReplaceOperation, ItemWithdrawReplaceOperation
    > Check for existing not required since boolean type value
- EPersonEmailReplaceOperation
    > added back null-check in checkModelForExistingValue
- EPersonPasswordReplaceOperation
    > added checkModelForExistingValue which checks if ePersonService has non-null pw hash, because getPassword is protected

- Test added for password replace with no existing pw
2019-11-13 12:40:51 +01:00
Marie Verdonck
505daf5bbb 66075: Feedback improvements 2:
DspaceObjectMetadataOperation
 - JsonPatchConverter removed
 - SQL exceptions thrown as is, others to DSpaceBadRequestException
 - DspaceObjectMetadataOperation.remove()
    > UnprocessableEntityException with exceptionalities
    > Already parsed value used in second parse

PatchOperation
 - M no longer extends DSO
 - supports in child classes with R objectToMatch

ItemWithdrawReplaceOperation
 - one try-catch block with relevant exception handling
2019-11-13 11:15:00 +01:00
Peter Nijs
37e7bda2d5 65956: add link to itemtemplate on collections 2019-11-12 16:13:36 +01:00
Paulo Graça
607859ec3e fixing wrong element 2019-11-12 14:14:01 +00:00
Peter Nijs
5e409ae0be Merge remote-tracking branch 'dspace/master' into w2p-65267_delete-in-relationshipservice manual fixes 2019-11-12 14:12:49 +01:00
Peter Nijs
61da3d13ab Merge remote-tracking branch 'dspace/master' into w2p-65267_delete-in-relationshipservice 2019-11-12 14:12:03 +01:00
Paulo Graça
077ee4edab Indentation 2019-11-12 11:44:02 +00:00
Paulo Graça
182606d67e Indentation 2019-11-12 11:38:44 +00:00
Paulo Graça
4f33932cb4 New identifiers for Persons, Organizations and Publications 2019-11-12 11:35:41 +00:00
Raf Ponsaerts
1f2549c1e1 Added ProcessRestPermissionEvaluatorPlugin and changed authorization to be checked with the annotation on the ProcessRestRepository#findOne method 2019-11-12 11:41:59 +01:00
Ben Bosman
082dd94aef docs 2019-11-12 10:58:33 +01:00
Paulo Graça
ca84156658 OpenAIRE 4 fields 2019-11-12 09:37:33 +00:00
Paulo Graça
f26cff1bd7 OpenAIRE 4 Entities and Relationships 2019-11-12 09:30:50 +00:00
Raf Ponsaerts
a3381be1bf Fixed issue in findNextRightPlaceByRightItem and added a test for it. Also wrote additional docs 2019-11-12 10:08:49 +01:00
Peter Nijs
0683cdae3c 65956: CRUD on Collection Item template feedback
- manual changes after rebase
- javadoc clarification
2019-11-12 09:51:18 +01:00
Ben Bosman
cd938c9f35 explaining tests 2019-11-12 09:39:16 +01:00
Ben Bosman
9900c3c196 explaining tests 2019-11-12 09:09:20 +01:00
Chris Wilper
1ca24c1eba DS-3533 Begin projection/converter tests 2019-11-10 23:49:57 -05:00
Chris Wilper
5e4ddcdeb9 DS-3533 Fix typo 2019-11-10 08:45:33 -05:00
Chris Wilper
d0661d144e DS-3533 Cache method link annotation info to improve performance 2019-11-09 23:17:27 -05:00
Chris Wilper
f7d9175728 Merge branch 'master' into DS-3533_Projections 2019-11-09 21:36:06 -05:00
Chris Wilper
66108a7532 DS-3533 Fix failure to link when embedding from link repo 2019-11-09 10:39:50 -05:00
Chris Wilper
c556c379f5 DS-3533 Fix incorrect embedded page details when provided by link repo 2019-11-09 09:57:18 -05:00
Ben Bosman
fed1828912 explaining tests 2019-11-08 18:30:13 +01:00
Ben Bosman
7d2eb90af6 fixes for incorrect virtual metadata 2019-11-08 18:06:16 +01:00
Ben Bosman
7f0ffa8586 JavaDocs 2019-11-08 17:49:42 +01:00
Ben Bosman
b030397ba9 fixes for incorrect virtual metadata 2019-11-08 17:27:16 +01:00
Peter Nijs
0919bad5be 65956: CRUD on Collection Item template feedback
- rename classes
2019-11-08 16:50:28 +01:00
Peter Nijs
46efec9ee4 65543: CRUD on Collection Item template
- add javadocs
2019-11-08 16:50:28 +01:00
Peter Nijs
499f718ae2 65543: CRUD on Collection Item template
- implement contract changes
- correct permission
- add javadocs
2019-11-08 16:50:28 +01:00
Peter Nijs
dab2022629 65543: Collection item template
- Moved corresponding repository endpoints
2019-11-08 16:41:48 +01:00
Peter Nijs
99522b2e96 65543: Collection item template
- Moved endpoints
2019-11-08 16:41:48 +01:00
Peter Nijs
3f552078b9 65257: update and delete for collection template items 2019-11-08 16:41:48 +01:00
Peter Nijs
f20687ad36 65257: create and read for collection template items 2019-11-08 16:36:22 +01:00
Tim Donohue
c7d3c3e18c Merge pull request #2562 from atmire/w2p-65247_Create-Read-on-Collection-and-Community-logo
CRUD on Collection & Community logo
2019-11-08 09:16:38 -06:00
Peter Nijs
dcf99fc15b 65996: Feedback collection and community logo
- Return Rest objects from Repositories
- Made controller name more specific
2019-11-08 14:37:34 +01:00
Marie Verdonck
7a847db62b Feedback on PR 2561 2019-11-08 09:02:39 +01:00
Andrea Bollini
ed947ae169 Merge pull request #2573 from 4Science/fix-missing-spring-expression
Fix build - spring-expression is required at runtime
2019-11-08 00:29:44 +01:00
Andrea Bollini
32d94fa31d Fix build - spring-expression is required at runtime 2019-11-08 00:25:29 +01:00
Tim Donohue
fa7489222a Merge pull request #2572 from tdonohue/another_master_fix
(HIGH PRIORITY) Ensure test-jar is only a dependency if tests are enabled
2019-11-07 16:30:51 -06:00
Tim Donohue
3fbdd70a4f Ensure test-jar is only a dependency if tests are enabled 2019-11-07 15:51:32 -06:00
Tim Donohue
cc440791ae Merge pull request #2571 from tdonohue/fix_broken_master
(HIGH PRIORITY) Fix broken master builds
2019-11-07 15:31:04 -06:00
Tim Donohue
9d770718c4 Remove unused dspace-xmlui-lang dependency 2019-11-07 14:56:27 -06:00
Tim Donohue
4b0870bc9e Fix broken master build. Only include server test-jar when running tests 2019-11-07 14:55:38 -06:00
Marie Verdonck
c56216e46b 65985: bundle delete improvements (from feedback) 2019-11-07 17:24:15 +01:00
Tim Donohue
caef38c241 Merge pull request #2553 from atmire/DS-4358-tests-in-modules
DS-4358 tests in modules
2019-11-07 10:02:27 -06:00
Chris Wilper
1d914b74c7 DS-3533 Simplify and normalize code 2019-11-07 10:52:32 -05:00
Peter Nijs
dca93b5228 65571: REST changes to delete of an item
- fix RelationshipDeleteRestRepositoryIT test failures
    - fix issue with deleting a collection with ResourcePolicies
- remove a redundant itemService from ItemRestRepository
- implement input validation on the copyVirtualMetadata parameter
    - add test for this
- use Object.deepEquals() for array comparison
- documented deleteMultipleRelationshipsCopyVirtualMetadata()
2019-11-07 14:43:11 +01:00
Marie Verdonck
f93da1fb0c 65997: checkstyle 2019-11-07 12:37:49 +01:00
Marie Verdonck
efe178a351 65997: COPY metadata patch functionality 2019-11-07 11:50:44 +01:00
Chris Wilper
7eb1508387 DS-3533 Apply projections uniformly 2019-11-07 05:30:17 -05:00
Marie Verdonck
c54903006d 65997: Fix metadata patch replace case 4 (replace attribute of single md)
TODO: implement COPY metadata patch
2019-11-07 10:26:54 +01:00
Marie Verdonck
8af15603ef 65997: ReplacePatchOperation function moved to subclasses &
EPersonOperationFactory removed, no longer useful
TODO: fix failing tests of replace in two operations
2019-11-06 20:12:49 +01:00
Raf Ponsaerts
28b1e4b121 Inprogress evaluating feedback with regards to comments in RelationshipServiceImpl and the place tests 2019-11-06 16:06:41 +01:00
Raf Ponsaerts
f1adf4f375 Removed the ProcessRestController class and instead refactored the ProcessRestRepository, ProcessRest and ProcessResource to now be compliant with the RestResourceController's framework 2019-11-06 15:18:55 +01:00
Peter Nijs
ca37eee3fe 65571: REST changes to delete of an item
- Copy relationship data on item delete
2019-11-06 14:44:08 +01:00
jonas-atmire
d379552e2c Updating returned object for 'setLogo' to its 'Rest' version to be inline with other RestRepository methods 2019-11-06 12:49:17 +01:00
Samuel
f372176dd0 [DS-4358] Tests in modules: feedback - fix build 2019-11-06 12:06:24 +01:00
Samuel
fad5a0247c [DS-4358] Tests in modules: feedback - modules/server pom 2019-11-06 11:34:32 +01:00
Marie Verdonck
e8fe89581f 65997: ReplacePatchOperation function moved to subclasses &
EPersonOperationFactory removed, no longer useful
2019-11-06 11:00:26 +01:00
Kevin Van de Velde
727f97aa44 [DS-4317] Bundles in rest: Moving BitstreamBundleController to the existing BitstreamRestController 2019-11-06 10:47:44 +01:00
Kevin Van de Velde
5c3dd61382 [DS-4317] Bundles in rest: Fixing style issue & renaming the "BitstreamController" to the "BitstreamBundleController" as the RequestMapping maps to /api/content/bitstreams/uuid/bundle and not /api/content/bitstream/uuid 2019-11-06 10:29:18 +01:00
Samuel
8ccd816b9e [DS-4358] Tests in modules: feedback 2019-11-05 17:36:34 +01:00
Chris Wilper
adbc730a36 DS-4379 Stop adding relations as metadata for new items 2019-11-05 10:55:19 -05:00
Kevin Van de Velde
cca64996be [DS-4317] Bundles in rest: Renaming method that moves bitstreams in a bundle 2019-11-05 13:58:03 +01:00
Marie Verdonck
40a08746d9 65997: Overrides added, javadocs, unused classes removed 2019-11-05 09:59:33 +01:00
Marie Verdonck
f8529f3200 [w2p-65997] Patch framework improvements: Internal feedback #1 2019-11-04 18:11:48 +01:00
Marie Verdonck
840106ba63 [DS-4317] DELETE /api/core/bundles/<:uuid> endpoint functionality
> deletes bundle with given uuid and all its bitstreams

> with IT cases and javadoc
2019-11-04 15:47:51 +01:00
Marie Verdonck
b0738b576d Code for moving bitstreams to a different bundle moved to BundleService 2019-11-04 13:21:29 +01:00
Chris Wilper
640c9071ef DS-3533 Add javadocs for new classes 2019-11-01 14:23:23 -04:00
Chris Wilper
71c81d28cf DS-3533 Fix checkstyle issues 2019-10-31 14:52:06 -04:00
Chris Wilper
b67a67c2b8 DS-3533 Use list projection for ItemRestRepository.findALl 2019-10-31 10:31:30 -04:00
Chris Wilper
f4737bb74b DS-3533 Provide item relationships via link repository 2019-10-31 10:31:30 -04:00
Chris Wilper
32098c4ffb DS-3533 Use list projection when embedding a page from a link repository 2019-10-31 10:30:56 -04:00
Chris Wilper
6f5f4da745 DS-3533 Add projections 2019-10-31 10:30:51 -04:00
Marie Verdonck
64ee1d72b6 65944: Patch framework refactoring finished, all tests ok 2019-10-31 13:34:48 +01:00
Marie Verdonck
032ae2ad94 65944: Patch framework refactoring; TODO fix /metadata PATCH handling 2019-10-30 17:40:52 +01:00
Samuel
52661fed8c DS-4351 Upgrade spring (boot) & hibernate to newer versions - taskid 65955 internal questions - fix Q6 2019-10-30 15:53:49 +01:00
Samuel
930951445f DS-4351 Upgrade spring (boot) & hibernate to newer versions - taskid 65955 internal questions - fix Q2 2019-10-30 15:53:49 +01:00
Raf Ponsaerts
a1ed84d072 Applied feedback to the external sources entity post feature in ExternalDataService and ExternalSourceEntryUriListHandler 2019-10-30 09:17:18 +01:00
Marie Verdonck
e56e71a903 65942: Test fix since implementation changed as well 2019-10-29 13:21:26 +01:00
Marie Verdonck
68342ae10c 65942: Merge branch 'master' into w2p-65568_bugs-place-management-creating-relationships
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/dao/RelationshipDAO.java
2019-10-29 12:37:02 +01:00
Alexander Sulfrian
57df5a3f98 DS-4275: Fix case of resourcepolicies endpoint
The endpoint is specified in lowercase in the REST contract.
2019-10-29 11:24:40 +01:00
Kevin Van de Velde
d056d8df53 [DS-4317] Bundles in rest: Merging lasted master style fixes 2019-10-29 10:56:27 +01:00
Kevin Van de Velde
1087de26bf Merge branch 'master' into DS-4317_bundles-in-REST 2019-10-29 10:25:35 +01:00
Raf Ponsaerts
f3efe500b1 [Task 65902] implemented functionality to create an archived item from the urilist call to the items endpoint with an ExternalSourceEntry in the uriList 2019-10-29 10:12:20 +01:00
Raf Ponsaerts
c90e52f429 Fixed checkstyle issue in MockMetadataConverter 2019-10-28 09:21:50 +01:00
Samuel
e2c353d75e DS-4351 Upgrade spring (boot) & hibernate to newer versions 2019-10-25 18:21:49 +02:00
Raf Ponsaerts
d66c3da752 Fixed MockMetadataConverter issue where multiple metadatavalues for a single metadatafield would get lost due to sorting issues 2019-10-25 16:40:02 +02:00
Peter Nijs
822b6b7361 65788: CRUD on Collection & Community logo feedback 2019-10-25 14:03:46 +02:00
Peter Nijs
f84624fb59 Merge remote-tracking branch 'dspace/master' into w2p-65247_Create-Read-on-Collection-and-Community-logo 2019-10-25 13:45:32 +02:00
Peter Nijs
a31dc75c3e 65268: changes to delete of a relationship 2019-10-25 11:51:43 +02:00
Andrea Bollini
0fbe314890 Merge pull request #2503 from atmire/DS-4337-bitstream-bitstreamformat-relation-endpoints
DS-4337 implement bitstream-bitstreamformat relation endpoints
2019-10-24 17:05:49 +02:00
jonas-atmire
0ab96d5c58 Removal of superfluous method. Handled by allowing a null file to be sent, and sending back an error if that is the case 2019-10-24 14:04:14 +02:00
Tim Donohue
9dbfe5d32b Merge pull request #2535 from atmire/DS-4224-paginated-methods-for-relationships
Ds 4224 paginated methods for relationships
2019-10-23 13:49:29 -05:00
Kevin Van de Velde
4cb2f83432 [DS-4358] Tests in modules: Fixing an issue where the server webapp wouldn't start anymore 2019-10-22 13:15:57 +02:00
Raf Ponsaerts
4f351aa28f Added DSpaceCommandLineParameterTest class 2019-10-22 12:03:06 +02:00
Kevin Van de Velde
1dc8cf7f32 [DS-4337] Bitstream format PUT endpoint javadoc update 2019-10-22 11:19:37 +02:00
Kevin Van de Velde
11745fe69f External sources: Cleaning up some unused variables / comments 2019-10-22 10:02:05 +02:00
Raf Ponsaerts
bdb8f2603c [Task 65768] added proper implementation for getNumerOfResults for test DataProvider and fixed checkstyle 2019-10-22 09:49:37 +02:00
Raf Ponsaerts
e2cc3a9391 Evaluated feedback on scripts and processes endpoints and model classes. Added javadoc, fixed tests and made improvements to various parts of the Scripts and processes feature 2019-10-21 16:31:04 +02:00
Raf Ponsaerts
e51b06a4b7 [Task 65768] implemented the getNumberOfResults method on the ExternalDataService and used this in the ExternalDataRestRepositories for an accurate pagination on the search methods 2019-10-21 11:53:49 +02:00
Tim Donohue
827311cb66 Merge pull request #2554 from 4Science/DS-4367
DS-4367 remove unnecessary dspace.restUrl and fix default configuration
2019-10-18 10:04:06 -05:00
Andrea Bollini
d38baea57d DS-4367 add IT for root endpoint properties 2019-10-18 12:41:03 +02:00
benbosman
810634f2a5 Travis build trigger 2019-10-18 11:12:03 +02:00
Andrea Bollini
fbd5f444df DS-4367 fix property used in test initialization 2019-10-18 11:06:28 +02:00
benbosman
30ad7676ef Merge pull request #2528 from atmire/authority-control-bugfixes
Authority control bugfixes
2019-10-18 11:03:24 +02:00
Raf Ponsaerts
91e763d7a1 Removed the config setting in the destroy method of the AuthorityRestRepositoryIT class 2019-10-18 10:28:55 +02:00
Andrea Bollini
7648e099ae DS-4367 fix comments about baseUrl 2019-10-17 17:58:39 +02:00
Andrea Bollini
b26222f278 DS-4367 remove unnecessary dspace.restUrl and fix default configuration 2019-10-17 17:51:24 +02:00
Raf Ponsaerts
9bb2e7e526 Implemented the External Sources feature 2019-10-17 14:50:17 +02:00
Peter Nijs
8640337224 65542: CRUD on Collection & Community logo: Feedback 2019-10-17 12:36:23 +02:00
Andrew Wood
4882a7914d DS-4224 Comply with community master 2019-10-16 15:54:27 -04:00
Andrew Wood
a4c0b62b52 DS-4224 Improve paging impl for Entities 2019-10-16 15:54:27 -04:00
Andrew Wood
d82fb48878 DS-4224 Improve code style consistency 2019-10-16 15:54:27 -04:00
Andrew Wood
c2aa03d9f5 DS-4224 Catch up with master 2019-10-16 15:54:27 -04:00
Andrew Wood
a15ceb71e8 DS-4224 Adjust stylings and improve jdocs 2019-10-16 15:54:27 -04:00
Andrew Wood
9bc63b7eed DS-4224 Relationship paging refactor 2019-10-16 15:54:26 -04:00
Andrew Wood
83ba0936c7 DS-4224 Improve related test and add additional test 2019-10-16 15:54:26 -04:00
Raf Ponsaerts
febe98f43f Implemented the Relationship logic in the submissionforms endpoint 2019-10-16 15:54:26 -04:00
Raf Ponsaerts
3aa75eaeeb Implemented feedback and testing on item bitstreams post endpoint 2019-10-16 15:54:26 -04:00
Andrew Wood
58e986d08d DS-4224 Update unit test to comply with refactoring 2019-10-16 15:54:26 -04:00
Samuel
6da844941d DS-4096 paginated methods for relationships 2019-10-16 15:54:26 -04:00
Raf Ponsaerts
72e2b87226 Fix after merge 2019-10-16 14:40:50 +02:00
Raf Ponsaerts
901b6aecec Merge remote-tracking branch 'dspace/master' into w2p-65568_bugs-place-management-creating-relationships
Conflicts:
	dspace-api/src/main/java/org/dspace/app/bulkedit/MetadataImport.java
2019-10-16 14:38:30 +02:00
Raf Ponsaerts
4d4535d3a2 [Task 65681] updated RelationshipSeviceImplTes 2019-10-16 14:18:42 +02:00
Samuel
aa3100583f taskid 65539 Testing for non source modules: cleanup - added documentation 2019-10-15 18:46:08 +02:00
benbosman
f8e42eb5e5 Merge pull request #2527 from atmire/w2p-64809_Updating-indexing-method
Discovery indexing: Ensuring discovery configuration is used during indexing
2019-10-15 18:05:03 +02:00
Ben Bosman
01aac84699 JavaDoc 2019-10-15 16:44:54 +02:00
benbosman
f7d9e0c1cd Merge pull request #2522 from atmire/DS-4226-CSV_Import_Entities_Improvments
DS-4226 Improvements to Entity validation first pass
2019-10-15 16:26:50 +02:00
Samuel
b60cb236a3 DS-4337 implement bitstream-bitstreamformat relation endpoints - feedback bis 2019-10-15 15:58:18 +02:00
Peter Nijs
a64fb7a29d 65491: Journal JUnit tests for Changes to delete in RelationshipService 2019-10-15 15:11:31 +02:00
Raf Ponsaerts
b0b886d16f [Task 65568] updated javadoc and comments 2019-10-15 13:48:44 +02:00
Raf Ponsaerts
6c762d52fe Fixes after master merge 2019-10-15 13:15:15 +02:00
Raf Ponsaerts
31a28e0ffa Merge remote-tracking branch 'dspace/master' into w2p-65568_bugs-place-management-creating-relationships
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/RelationshipRestRepository.java
2019-10-15 12:03:07 +02:00
Raf Ponsaerts
27d5853d8e [Task 65568] implemented tests and fixed checkstyle 2019-10-15 08:48:52 +02:00
Marie Verdonck
df7ee6410c w2p-65570 - Tests modified for name variants configuration check 2019-10-14 13:51:02 +02:00
Marie Verdonck
9994dd8d7c w2p-65570 - Configuring whether name variants should be used 2019-10-14 13:49:55 +02:00
Raf Ponsaerts
15555a1afe [Task 65568] initial fixes and test fixes 2019-10-14 13:35:17 +02:00
Samuel
99fbbe1749 DS-4337 implement bitstream-bitstreamformat relation endpoints - feedback 2019-10-11 18:13:14 +02:00
Samuel
661d9c41c9 added license headers 2019-10-11 17:19:16 +02:00
Raf Ponsaerts
4e87687b47 applied naming feedback and comments on ChoiceAuthorityService and AuthorityRestRepositoryIT 2019-10-11 16:13:08 +02:00
Kevin Van de Velde
86b7989efe [DS-4317] Bundles in rest: Processing feedback 2019-10-11 11:21:13 +02:00
Tim Donohue
a5d4924cc2 Merge pull request #2489 from mspalti/DS-4153_createandreturn
[DS-4153] Added repository createAndReturn that accepts parent id
2019-10-10 10:37:27 -05:00
Samuel
cd1e6ba278 DS-4337 implement bitstream-bitstreamformat relation endpoints - feedback 2019-10-10 17:30:22 +02:00
benbosman
ad29df9756 Merge pull request #2546 from atmire/DS-4360_statistics-endpoint-searchevents-link-fix
[DS-4360] fixed construction of the SearchEvents link on the statistics endpoint
2019-10-10 17:15:08 +02:00
benbosman
96490e5570 Merge pull request #2545 from atmire/DS-4359_issue-entity-type-null
[DS-4359] added nullcheck in EntityServiceImpl#getAllRelationshipTypes
2019-10-10 17:13:15 +02:00
Andrea Bollini
e922227f29 Merge pull request #2486 from atmire/w2p-62967_multiple-title-community-endpoint-issue
Issue when community has multiple dc.title values
2019-10-10 16:51:44 +02:00
Peter Nijs
3b2e9e30d3 65487: tests for changes to delete in RelationshipService 2019-10-10 16:27:44 +02:00
Raf Ponsaerts
f63b81b440 [DS-4360] fixed construction of the SearchEvents link on the /statistics endpoint 2019-10-10 14:22:36 +02:00
Raf Ponsaerts
15a4202472 [DS-4359] added nullcheck in EntityServiceImpl#getAllRelationshipTypes 2019-10-10 14:08:30 +02:00
Michael W Spalti
2d6b97b539 Fixed checkstyle error for unused import. 2019-10-09 17:09:25 -07:00
Michael W Spalti
573b2a514c Added optional RequestParam and updated internal post method to accept parent parameter. 2019-10-09 16:36:54 -07:00
Tim Donohue
6986b211e1 Merge pull request #2491 from atmire/oai-harvesting-setup
Oai harvesting setup
2019-10-09 15:44:13 -05:00
Andrew Wood
0773f79d5c DS-4226 Add validation for multi typeName reference case improve test improve languaged used 2019-10-09 11:18:33 -04:00
Andrew Wood
a5af5c130a DS-4226 Conform with changes from community master 2019-10-09 11:18:33 -04:00
Andrew Wood
51555e4f28 DS-4226 Fix ambigious bug 2019-10-09 11:18:33 -04:00
Andrew Wood
3739b718eb DS-4226 Improvements to Entity validation first pass 2019-10-09 11:18:33 -04:00
Samuel
b6150874f6 taskid 65494 Testing for non source modules: Additions tests 2019-10-08 15:20:58 +02:00
Samuel
bf9c1c0e18 taskid 65493 Testing for non source modules: Internal test 2019-10-08 14:49:20 +02:00
Tim Donohue
74ec72add1 Merge pull request #2541 from Georgetown-University-Libraries/ds4356
[DS-4356] Document Dockerfile Manual Build Steps (README change)
2019-10-07 10:36:17 -05:00
Raf Ponsaerts
2202195cfc Altered wrongly defined URL in CollectionHarvesterSettingsControllerIT 2019-10-07 16:07:23 +02:00
Peter Nijs
60489c2c02 65251: replace and delete a logo for collections and communities 2019-10-07 13:26:16 +02:00
Raf Ponsaerts
0e05a79db7 [Task 65267] implemented the RelationshipService delete endpoint changes 2019-10-07 12:53:03 +02:00
Kristof De Langhe
64ac844e9e 64640: Message fix + Missing JavaDocs 2019-10-07 11:07:32 +02:00
Terry Brady
8f4b34b071 Merge branch 'ds4356' of https://github.com/Georgetown-University-Libraries/DSpace into ds4356 2019-10-04 15:23:08 -07:00
Terry Brady
8fbc4e0034 clarify cd instructions 2019-10-04 15:22:10 -07:00
Terry Brady
6a5ca55579 document docker build instructions 2019-10-04 15:09:57 -07:00
Terry Brady
e7933ee7b5 document docker build instructions 2019-10-04 15:09:23 -07:00
Tim Donohue
6cbe99bddf Merge pull request #2539 from Georgetown-University-Libraries/ds4355r7
[DS-4355] 7x: Re-scope .dockerignore file
2019-10-04 22:35:53 +02:00
Tim Donohue
f40ddceecc Merge pull request #2538 from tdonohue/docker-db-before-tomcat
Docker bug fix: Ensure database is initialized before starting Tomcat
2019-10-04 22:26:41 +02:00
Terry Brady
29c5a1f264 additional exclude 2019-10-04 13:23:17 -07:00
Terry Brady
62401e673a fix .dockerigore 2019-10-04 13:12:04 -07:00
Tim Donohue
e547af0cbc Ensure database is initialized before starting Tomcat 2019-10-04 14:43:28 -05:00
Tim Donohue
0c172efbc3 Merge pull request #2533 from terrywbrady/ds4349m
[DS-4349] 7x: Migrate Postgres Dockerfiles into code base
2019-10-04 21:06:00 +02:00
Terry Brady
b53906fbc2 Merge branch 'master' into ds4349m 2019-10-04 10:58:40 -07:00
Tim Donohue
dc0e23653a Merge pull request #2530 from terrywbrady/ds4346mV2
[DS-4346] 7x: V2: Add default docker-compose file to code base
2019-10-04 19:12:02 +02:00
Raf Ponsaerts
f28acee6bf Added tests for Community endpoint pagination 2019-10-04 15:14:25 +02:00
Peter Nijs
918839fdea 65247: tests for uploading a logo for collections and communities 2019-10-04 13:36:56 +02:00
Tim Donohue
4f76f7f683 Merge pull request #2536 from paulo-graca/patch-2
Fixing exception error when using UUID on Harvesting
2019-10-03 19:20:03 +02:00
Peter Nijs
51d86d420b 65247: add support for uploading a logo for collections and communities 2019-10-03 15:46:08 +02:00
Peter Nijs
23c10854b2 65247: add support for uploading a logo for collections and communities 2019-10-03 15:44:46 +02:00
Paulo Graça
5d86c10717 Replacing Collection ID references with UUIDs 2019-10-03 13:54:22 +01:00
Ben Bosman
bc38bcdc86 JavaDocs 2019-10-03 13:12:52 +02:00
Kevin Van de Velde
4b92af8239 [DS-4351] Upgrade spring (boot) & hibernate to newer versions 2019-10-03 09:41:51 +02:00
Samuel
dd5dfd6d77 taskid 65007 Get SolrServiceIndexPlugin to work - dependencies 2019-10-02 17:55:57 +02:00
Tim Donohue
e638c47622 Merge pull request #2488 from atmire/feature-name-variants
Rename properties and support for name variants
2019-10-02 16:57:45 +02:00
Samuel
d360232b2f taskid 65253 Testing for non source modules - add test profiles 2019-10-02 12:22:46 +02:00
Ben Bosman
53ff1afea5 comments 2019-10-02 10:37:33 +02:00
Raf Ponsaerts
85b88b05a6 Applied feedback 2019-10-02 09:34:27 +02:00
Terry Brady
02043d41e9 update README for angular compose 2019-10-01 23:52:30 -07:00
Terry Brady
086bd36dc9 update README 2019-10-01 18:20:13 -07:00
Terry Brady
7da196cbbc refine angular compose and readme 2019-10-01 16:31:49 -07:00
Terry Brady
417104629a Clarify pull/build in README 2019-10-01 15:33:23 -07:00
Terry Brady
32ae484a50 Add docker-compose README 2019-10-01 10:52:41 -07:00
Samuel
48daaed59f taskid 65253 Testing for non source modules 2019-10-01 17:10:06 +02:00
Yana De Pauw
5c8f6bb805 65188: Add typedocs 2019-10-01 11:54:06 +02:00
Terry Brady
af878788ef add docker-compose README files 2019-09-30 22:40:20 -07:00
Terry Brady
851a39cf61 add solr readme 2019-09-30 22:21:17 -07:00
Terry Brady
81242ab7f7 add license to script files 2019-09-30 13:44:04 -07:00
Terry Brady
120a873a2d add license to dockerfiles 2019-09-30 13:27:34 -07:00
Terry Brady
577ec17634 add .dockerignore 2019-09-30 13:15:11 -07:00
Terry Brady
61f13807c0 add postgres dockerfiles 2019-09-30 13:13:44 -07:00
Terry Brady
a8f25fec49 fix license header 2019-09-30 12:53:37 -07:00
Terry Brady
cd6d849c17 Add angular option 2019-09-30 11:45:04 -07:00
Yana De Pauw
0b97fe9293 65188: Implement feedback 2019-09-30 13:48:32 +02:00
Raf Ponsaerts
b06bd5e786 Added comments and added pagination test for community findall 2019-09-30 09:49:42 +02:00
Terry Brady
3e97876cb9 rm angular container 2019-09-29 10:50:04 -07:00
Raf Ponsaerts
56fc8d5741 Applied feedback 2019-09-27 16:13:42 +02:00
Raf Ponsaerts
2b014833c5 Added javadoc 2019-09-27 11:26:52 +02:00
Raf Ponsaerts
fa023db4ee Added tests and various fixes 2019-09-27 10:09:43 +02:00
Raf Ponsaerts
eaf91b6af7 added another clear 2019-09-26 12:48:20 +02:00
Raf Ponsaerts
017ba13710 Added a method to clear controller in cas 2019-09-26 10:54:10 +02:00
Raf Ponsaerts
1392b62d83 Added method to clear config 2019-09-26 09:31:19 +02:00
benbosman
f65c8523a8 Merge pull request #2502 from atmire/w2p-64649_endpoints-to-collect-statistics
Endpoints to collect Statistics
2019-09-25 15:55:40 +02:00
Kristof De Langhe
09039d1f20 64640: BundleRestRepository IT, JavaDocs and CheckStyle fixes 2019-09-25 15:24:20 +02:00
Raf Ponsaerts
04d14efe5f Applied feedback 2019-09-25 15:10:19 +02:00
Kristof De Langhe
04a7a31797 64640: Move PATCH request for bitstreams in bundles 2019-09-25 12:36:06 +02:00
Raf Ponsaerts
82e6cef95b Fixed the duplication of communities if muliple dc title fields with different languages 2019-09-24 14:06:22 +02:00
kshepherd
c44fd4c5ce Merge pull request #2524 from Georgetown-University-Libraries/ds4347
[DS-4347] remove solr from ant step in docker build
2019-09-24 09:24:17 +12:00
Terry Brady
3d8c6cfb3d remove solr from ant step in docker build 2019-09-23 13:42:46 -07:00
Terry Brady
6b6cda3eaa remove solr from ant step in docker build 2019-09-23 13:34:37 -07:00
Terry Brady
69de77790c fix tag name 2019-09-23 13:31:56 -07:00
Terry Brady
cd3dc07958 correct license headers 2019-09-23 13:09:12 -07:00
Terry Brady
1985cb11d9 Create docker compose files in the code base 2019-09-23 13:05:24 -07:00
Yana De Pauw
6c807f8a62 65105: Implement feedback 2019-09-23 11:45:31 +02:00
Raf Ponsaerts
3df6f84387 Applied feedback 2019-09-20 15:25:24 +02:00
Raf Ponsaerts
6797ae0b9c [Task 64894] fixed the self link 2019-09-20 14:18:33 +02:00
Raf Ponsaerts
17a2eaa0a3 [Task 64807] fixed SolrAuthorAuthority in the IT 2019-09-20 14:05:43 +02:00
Raf Ponsaerts
cbc3768ca5 Added authorization check on the ScriptRestRepository.findOne method 2019-09-19 16:26:25 +02:00
Michael W Spalti
48697d32dc Restoring the authorization system in integration tests for community and collection repositories. 2019-09-18 12:38:24 -07:00
Raf Ponsaerts
97c5292f3a [Task 65095] fixed typo in link 2019-09-18 16:24:23 +02:00
Raf Ponsaerts
a6c5046045 Re-enabled test 2019-09-18 16:04:12 +02:00
Raf Ponsaerts
73b42de798 [Task 64808] returning null instead of empty choice 2019-09-18 12:54:56 +02:00
Raf Ponsaerts
be2624b666 [Task 64993] applied feedback 2019-09-18 10:37:26 +02:00
kshepherd
c7ddf85f4f Merge pull request #2508 from mwoodiupui/DS-4338
[DS-4338] Remove final smidgeon of Solr source code.
2019-09-18 09:47:50 +12:00
Ben Bosman
bdb16b2543 IT fixes 2019-09-17 14:55:35 +02:00
Raf Ponsaerts
9a026956d7 Applied feedback 2019-09-17 13:51:12 +02:00
Raf Ponsaerts
2de90e0f54 [Task 64911] added RelationshipMetadataService test 2019-09-17 11:49:20 +02:00
Michael W Spalti
8c492e128e Updated several integration tests to turn on auth system. 2019-09-16 14:40:28 -07:00
Tim Donohue
33b0e04d09 Merge pull request #2393 from mwoodiupui/DS-3695-upgrade
[DS-3695] Solr 7 fixes for upgrading to DSpace 7
2019-09-16 22:08:53 +02:00
Yana De Pauw
6462ab15af 64638: Retrieving and updating bundle of a bitstream 2019-09-16 17:54:19 +02:00
Raf Ponsaerts
b6a6f11a8a [Task 64926] applied feedback and change request to response code and id on scripts 2019-09-16 13:16:45 +02:00
Raf Ponsaerts
0279155af7 Adding javadoc and log cleanup 2019-09-16 11:47:59 +02:00
Raf Ponsaerts
9675df2d68 [Task 64926] applied the feedback 2019-09-16 09:01:41 +02:00
benbosman
3c833ed1ad Merge pull request #2498 from atmire/w2p-64721_Rename-discovery-config-for-Entities
[DS-4325]: Rename Discovery configuration for Entities
2019-09-13 17:58:48 +02:00
benbosman
336a6b177b Merge pull request #2499 from atmire/w2p-64645_Removal-of-filtered-discovery-page
Removal of filtered-discovery-page in REST
2019-09-13 09:35:58 +02:00
Mark H. Wood
7ad2aacd49 [DS-3695] Repair merge conflict. 2019-09-12 15:56:37 -04:00
Mark H. Wood
44b3375983 Merge remote-tracking branch 'upstream/master' into DS-3695-upgrade 2019-09-12 15:12:45 -04:00
Mark H. Wood
bf7a813618 Merge pull request #2495 from mwoodiupui/DS-3695-simple
[D-3695] Upgrade to Solr 7:  support sharded statistics simply
2019-09-12 10:54:45 -04:00
Raf Ponsaerts
28c8129811 [Task 64894] fixed the link and AccessDeniedException mistake through reflection call for findRel 2019-09-12 14:15:04 +02:00
Raf Ponsaerts
52aac9df70 [Task 64808] fixed certain tests 2019-09-12 11:42:41 +02:00
Raf Ponsaerts
31184a8670 Added ignores back to authority tests 2019-09-11 15:28:13 +02:00
Raf Ponsaerts
61b584b8f3 [Task 64893] added self link to entries endpoint 2019-09-11 15:24:39 +02:00
Raf Ponsaerts
bf33dbf5c8 [Task 64807] enabled MockAuthoritySolrService in the REST IT 2019-09-11 12:40:28 +02:00
Yana De Pauw
bf68914a19 64499: Add bundle link to bitstream 2019-09-10 11:34:43 +02:00
Michael W Spalti
830351af11 Updated error messages and added new integration tests for collection repository. 2019-09-09 15:22:53 -07:00
Kristof De Langhe
b1f31cef9c 64809: Checkstyle fixes 2019-09-09 17:39:59 +02:00
Ben Bosman
46e86326b8 Change method names to make them easier to understand 2019-09-09 14:44:43 +02:00
Kristof De Langhe
ba39f6e4fb 64809: Update discovery configuration indexing 2019-09-09 14:40:48 +02:00
benbosman
cb7db98fcf Merge pull request #2471 from atmire/w2p-63043_CSV-placeholder-support
DS-4316: Indirect entity refs during csv import
2019-09-09 14:35:09 +02:00
kshepherd
8786f415a1 Merge pull request #2480 from terrywbrady/dspace-cli7
[DS-4321] master: docker image dspace/dspace-cli:dspace-7_x
2019-09-07 11:47:20 +12:00
Terry Brady
341a3fb2b2 simplify package exclusions 2019-09-06 16:06:37 -07:00
Terry Brady
c3640959a6 update ant archive 2019-09-06 14:58:10 -07:00
Terry Brady
8d0c3c291c Merge pull request #2509 from J4bbi/master
[DS-4336] Point Ant to archived, stable URL
2019-09-06 12:25:11 -07:00
j4bbi
991fe4f5b6 Point Ant to archived, stable URL 2019-09-06 19:51:55 +01:00
Tim Donohue
84df078380 Merge pull request #2504 from Georgetown-University-Libraries/ds4336r7
[DS-4336] Update ant version in Docker Build (master)
2019-09-06 18:06:27 +02:00
Mark H. Wood
2268abd83b [DS-4338] Remove final smidgeon of Solr source code. 2019-09-05 16:24:25 -04:00
Andrew Wood
42d6183828 w2p-63043 Populate row map in case of pre existing reference 2019-09-05 14:42:03 -04:00
Terry Brady
ad600a431c DS-4336 2019-09-05 11:04:21 -07:00
Terry Brady
e94da8fadb Update ant version 2019-09-05 10:38:24 -07:00
Andrew Wood
591df53e7a w2p-63043 Minor tweeks to testing enviorment and edge case correction 2019-09-05 11:30:50 -04:00
Raf Ponsaerts
97e322a21d Applied feedback with regards to view and searchevents 2019-09-05 13:49:07 +02:00
Raf Ponsaerts
14a72b5c39 Implemented separate controller for Statistics 2019-09-05 12:52:10 +02:00
Ben Bosman
e8662d7e2a Change method names to make them easier to understand
Add javadocs to complex private methods
2019-09-05 09:59:11 +02:00
Ben Bosman
0e45859336 Change method names to make them easier to understand
Add javadocs to complex private methods
2019-09-05 09:28:06 +02:00
Ben Bosman
a9217c8ca0 mock authority control solr 2019-09-04 15:17:43 +02:00
Ben Bosman
1d08e15254 solr authority 2019-09-04 13:22:56 +02:00
Ben Bosman
2665cc2c72 disabling features which don't work 2019-09-04 13:11:46 +02:00
Ben Bosman
b44ed7085d expanding the ITs 2019-09-04 12:12:05 +02:00
Ben Bosman
262e14fc74 exact amount expectations 2019-09-04 11:49:06 +02:00
Raf Ponsaerts
53a4043e03 [Task 64789] added nullcheck for metadata configs 2019-09-04 10:16:51 +02:00
Raf Ponsaerts
821e917ace [Task 64789] fixed empty response from update on harvest collections and refactored code 2019-09-04 10:04:57 +02:00
Raf Ponsaerts
e26d5fe113 Merge remote-tracking branch 'dspace/master' into oai-harvesting-setup
Conflicts:
	dspace-server-webapp/src/main/java/org/dspace/app/rest/model/hateoas/CollectionResource.java
2019-09-04 09:45:04 +02:00
Raf Ponsaerts
a73ba83db0 Created basic IT 2019-09-04 09:23:47 +02:00
Terry Brady
17fb867a62 update mvn build calls 2019-09-03 10:46:31 -07:00
Raf Ponsaerts
a0e18d57f0 Merge remote-tracking branch 'dspace/master' into feature-name-variants
Conflicts:
	dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java
2019-09-03 14:23:38 +02:00
Raf Ponsaerts
2c02568475 Added the harvester link to the CollectionResource 2019-09-03 11:50:00 +02:00
Terry Brady
50bfa62091 scope maven build 2019-09-02 18:54:41 -07:00
Terry Brady
d4df7b3c07 update comment 2019-09-02 18:42:59 -07:00
Yana De Pauw
e9154e9bf9 64639: Support creation of new bitstreams in bundles 2019-09-02 16:22:35 +02:00
Raf Ponsaerts
ebd63b1283 Created endpoints to collect View and Search statistics 2019-09-02 13:39:11 +02:00
Raf Ponsaerts
ec3b07e500 Changes type to typeName to avoid confusing, fixed checkstyle 2019-09-02 12:43:32 +02:00
Yana De Pauw
d4343eafb1 Merge branch 'master' into DS-4317_bundles-in-REST 2019-09-02 10:34:14 +02:00
Andrew Wood
c4626c1a49 w2p-63043 Improve error reporting when resolving references during metadata import 2019-08-30 15:35:40 -04:00
Yana De Pauw
509acb22a9 64645: Removal of filtered-discovery-page in REST 2019-08-30 18:03:46 +02:00
Ben Bosman
5864b53555 authority control bigfixes 2019-08-30 17:59:06 +02:00
Kristof De Langhe
d8a7852388 64721: Entity configuration changes 2019-08-30 13:11:35 +02:00
Tim Donohue
41a6f86dcc Merge pull request #2497 from atmire/DS-4251_test-csv-file-fix
[DS-4251] made sure that the test.csv file gets deleted
2019-08-28 17:28:41 +02:00
Tim Donohue
d2e224591c Use filename also in run command 2019-08-28 10:04:02 -05:00
Andrew Wood
e3cf391448 w2p-63043 Add additional IT for metadataImport 2019-08-28 09:54:15 -04:00
Raf Ponsaerts
598c28c6d6 [DS-4251] made sure that the test.csv file gets deleted and doesn't stay in the project structure after running tests 2019-08-28 08:34:32 +02:00
Tim Donohue
3139104997 Merge pull request #2472 from atmire/w2p-63533_changes-to-dtd-and-api-relationship-submission
support for defining relationship lookups in the submission forms
2019-08-27 23:27:17 +02:00
Andrew Wood
d67afa957e w2p-63043 Improve java docs for metadataImport 2019-08-27 12:19:57 -04:00
Andrew Wood
02559516d7 w2p-63043 remove stale spring rest webapp 2019-08-27 11:23:25 -04:00
Andrew Wood
28e2c7e13c Merge remote-tracking branch 'community/master' into w2p-63043_CSV-placeholder-support 2019-08-27 11:22:15 -04:00
Andrew Wood
17d977205f w2p-63043 Correct line reprocessing bug when value is empty 2019-08-27 11:11:08 -04:00
Yana De Pauw
6acddef596 64498: Add test to retrieve bistreams from bundle 2019-08-27 13:17:19 +02:00
Mark H. Wood
84803770c0 [DS-2378] Copy a blob of test code from deleted TestSpringServiceManager. 2019-08-26 16:17:00 -04:00
Mark H. Wood
21235b45c4 Merge remote-tracking branch 'upstream/master' into DS-3695-simple 2019-08-26 15:04:09 -04:00
Mark H. Wood
f4d7c35108 [DS-3695] Add statistics shard configset, fix various errors, improve logging. 2019-08-26 13:54:44 -04:00
Yana De Pauw
b52f7be3de 64495: Add unit tests for bundle + fix issues 2019-08-26 17:02:12 +02:00
Tim Donohue
30b2ea01a8 Merge pull request #2455 from tdonohue/fix_OAI_date_test
Another attempt at fixing Date test in `OAIpmhIT` integration test
2019-08-26 16:21:11 +02:00
Tim Donohue
4760d579d4 Correct return value to be nowToNearestSecond. 2019-08-26 08:55:09 -05:00
Tim Donohue
cd07247112 Fix occasional date mismatches by rounding to nearest second. 2019-08-26 08:55:07 -05:00
Mark H. Wood
de3c46bd5f [DS-2378] Pass 2: fold SpringServiceManager into DSpaceServiceManager and simplify. 2019-08-25 14:51:00 -04:00
Mark H. Wood
7811bb8966 [DS-2378] First pass: collapse loops to single SpringServiceManager.
Also tidy the code, make better use of logger.
2019-08-24 07:06:29 -04:00
Andrea Bollini
fe77a0a200 Merge pull request #2492 from tdonohue/clarify_sequence_id
Clarify purpose of Bitstream's Sequence ID
2019-08-23 17:15:41 +02:00
Jelle Pelgrims
54cec441c9 Add endpoint to add bundle to item 2019-08-23 12:42:16 +02:00
Jelle Pelgrims
601ed8a5f4 Fix tests for recent item changes
The item matcher didn't match anymore because it was still looking
for the bitstream link, which isn't there anymore because the item
only holds bundles now (see commit 48ea95bc). The tests were changed
to look for a bundle link.

Other than that a few tests were also specifically looking for a
bitstream link to see if a bitstream was correctly created. These
links were changed to bundle links, since a new bitstream should
be added to a new bundle by default (if there are no bundles yet)
during creation.
2019-08-23 08:44:23 +02:00
Tim Donohue
16117bf132 Clarify purpose of Sequence ID 2019-08-22 16:48:07 -05:00
Tim Donohue
018b18e214 Merge pull request #2473 from atmire/w2p-63475_implement-upload-bitstream-to-archived-item
implement upload bitstream to archived item
2019-08-22 18:39:12 +02:00
Ben Bosman
f264cff0ec unused import 2019-08-22 17:58:22 +02:00
Ben Bosman
a325221a7e Making the sequence ID read-only 2019-08-22 17:30:30 +02:00
Jelle Pelgrims
466e42d0f9 Add utility class for URL mapping Regexes
Added a utility class so that the URL mapping regexes (mostly used
in RestResourceController) can be reused in other controllers.
2019-08-22 16:51:54 +02:00
Jelle Pelgrims
5daf5be97d Add integration tests for bundle GET endpoint 2019-08-22 11:43:09 +02:00
Jelle Pelgrims
8c60fbb3e2 Fix CollectionharvestSettingsController permissions 2019-08-21 11:19:21 +02:00
Jelle Pelgrims
f5561a2dfc Add small changes 2019-08-21 11:11:16 +02:00
Jelle Pelgrims
0f4ea91834 Clean up code added in previous commits 2019-08-21 10:35:23 +02:00
Jelle Pelgrims
591f32bfe3 Finish GET endpoints 2019-08-20 16:21:20 +02:00
Jelle Pelgrims
712b4a4abf Rename code matching '[mM]apping[a-zA-Z]*' to '[mM]apped[a-zA-Z]*'
Rename 'mappingCollection' and similar code to 'mappedCollection', in order
to resolve Tim Donohue's feedback on the pull request.
2019-08-20 10:10:47 -04:00
Marie Verdonck
668b6551b0 Undo HALResource change, all tests run locally 2019-08-20 10:10:47 -04:00
Marie Verdonck
f6bf8b09fd Non-code changes, just whitelines 2019-08-20 10:10:47 -04:00
Marie Verdonck
1bd0f96a1a Error & Status for non-successful POST/DELETE mappedCollections requests
- POST /api/core/items/<:uuid>/mappedCollections
 > 405: item is a template item
 > 422: specified collection not found or is owningCollection of item
- DELETE /api/core/items/<:uuid>/mappedCollections/<:collection_uuid>
 > 405: item is a template item
 > 422: specified collection not found or is owningCollection of item
2019-08-20 10:10:47 -04:00
Samuel
f555692126 DS-4097 name change from mappingCollections to mappedCollections + data change to uri-list 2019-08-20 10:10:47 -04:00
Raf Ponsaerts
b42dafe166 Implemented the Item Mapper functionality 2019-08-20 10:10:46 -04:00
Andrew Wood
e5ec0164f7 w2p-63043 Improve documentation 2019-08-20 10:09:40 -04:00
Andrew Wood
55cc060b13 w2p-63043 Improve related query performance and improve affiliated test 2019-08-20 10:09:40 -04:00
Andrew Wood
e40a209113 DS-4316 Add tests for indirect entity refs during csv import 2019-08-20 10:09:40 -04:00
Andrew Wood
7220cecfa6 DS-4316 Support indirect entity refs during csv import 2019-08-20 10:09:40 -04:00
Andrew Wood
f9886529f5 DS-4316 Support querying MetadataValues by field and value 2019-08-20 10:09:40 -04:00
Jelle Pelgrims
48ea95bc15 Replace bitstreams in ItemRest with bundles
The list of bitstreams in ItemRest is now replaced with a list of
bundles. The bitstreams can now be accessed through the bundles.
2019-08-20 11:13:24 +02:00
Jelle Pelgrims
21116ec7eb Add initial class structure for bundles endpoint 2019-08-20 10:29:47 +02:00
Jelle Pelgrims
3b7eca366e Add comments explaining changes 2019-08-19 09:01:44 +02:00
Ben Bosman
68fc698f4b JavaDocs 2019-08-16 11:32:54 +02:00
Raf Ponsaerts
6e95aae040 Fixed issue with spaces in parameters causing UUIDs to not get recognized 2019-08-16 10:35:52 +02:00
Raf Ponsaerts
62596b1eaa Fixed feedback 2019-08-16 10:10:49 +02:00
Michael W Spalti
0ee78acba3 [DS-4153] Added repository create method that takes a parameter for the parent object.
Implementions are added to the collection and community repository classes.
2019-08-15 13:18:54 -07:00
Mark H. Wood
0eef0b0859 [DS-3695] Add missing libraries reported by Michael Spalti, Chris Wilper. 2019-08-15 11:30:58 -04:00
Mark H. Wood
e103a9305d [DS-3695] Merge damage: method was split, making local variable inaccessible. 2019-08-15 10:51:28 -04:00
Mark H. Wood
9046ecfcb4 Merge branch 'master' into DS-3695-upgrade 2019-08-15 10:23:53 -04:00
Mark H. Wood
8878b3a313 [DS-3695] Ask Solr what cores it has, instead of assuming that we know where they are in the filesystem.
(Solr might not even be installed on the same host.)
2019-08-15 10:16:10 -04:00
Raf Ponsaerts
c7327b6a14 Added javadoc 2019-08-14 13:34:04 +02:00
Jelle Pelgrims
ed17587170 Rename leftwardLabel and rightwardLabel
Renamed the leftwardLabel and rightwardlabel for Relationship to
leftwardValue and rightwardValue. Renamed the same values for
RelationshipType to leftwardType and rightwardType.
2019-08-13 15:30:49 +02:00
Ben Bosman
fcac5ecb56 Exception handling 2019-08-13 13:53:59 +02:00
Jelle Pelgrims
1831c4f92d Fix small issues 2019-08-13 13:06:51 +02:00
Jelle Pelgrims
d2470286a6 Add endpoint to retrieve collection harvest settings 2019-08-13 12:48:14 +02:00
Raf Ponsaerts
c890570b12 [Task 64334] implemented the scripts prototype 2019-08-13 12:33:35 +02:00
Jelle Pelgrims
d401af5f99 Update javadoc author tag email 2019-08-09 09:36:02 +02:00
Jelle Pelgrims
38679befd8 Implement fixes/tweaks and add javadocs 2019-08-09 09:19:00 +02:00
Tim Donohue
fc31a0cbe3 Merge pull request #2485 from mwoodiupui/DS-3422
[DS-3422] Remove XMLUI and JSPUI from the official distribution
2019-08-08 22:40:31 +02:00
Mark H. Wood
1dceb56b44 [DS-3422] Remove obsolete XMLUI configuration. 2019-08-08 15:10:46 -04:00
Jelle Pelgrims
8265964ebd Fix duplicate community issue for findAllNoParent function 2019-08-08 13:09:40 +02:00
Jelle Pelgrims
e46551e84c Add integration test for collection endpoint ordering 2019-08-08 12:46:32 +02:00
Ben Bosman
718340e3d3 wording fixes 2019-08-08 10:41:58 +02:00
Jelle Pelgrims
5b175bb62f Merge branch 'master' into w2p-62967_multiple-title-community-endpoint-issue 2019-08-08 09:52:10 +02:00
Jelle Pelgrims
234ef08eac Add integration test for harvester metadata format endpoint 2019-08-08 09:25:00 +02:00
Mark H. Wood
4dfa7a370a [DS-3695] Remove Solr core updating targets from Ant configuration. 2019-08-07 16:23:00 -04:00
Raf Ponsaerts
7eeb9f944b Fixed tests 2019-08-07 15:56:36 +02:00
Jelle Pelgrims
99bc1b7e0f Add endpoint for harvesting configurations 2019-08-07 14:12:37 +02:00
Jelle Pelgrims
e8fd1e0e37 Revert previous commit 2019-08-07 11:30:23 +02:00
Jelle Pelgrims
6bf6336f11 Fix issue causing tests to fail 2019-08-07 11:24:23 +02:00
Jelle Pelgrims
07a8e33ab5 Add integration test for harvest settings verification 2019-08-07 10:34:28 +02:00
Jelle Pelgrims
361f48bea1 Add settings verification to harvest settings endpoint 2019-08-07 09:58:50 +02:00
Jelle Pelgrims
c2cd25d6d0 Merge branch 'feature-name-variants' of https://github.com/atmire/DSpace into feature-name-variants
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java
#	dspace-api/src/main/java/org/dspace/content/RelationshipMetadataServiceImpl.java
2019-08-07 09:52:42 +02:00
Tim Donohue
a4b4045d2e Merge pull request #2479 from mwoodiupui/DS-4110_7x
[DS-4110] fix issue in legacy id cleanup of stats records
2019-08-06 21:55:48 +02:00
Terry Brady
6da64a2f60 dspace-cli dockerfile 2019-08-06 11:34:05 -07:00
Terry Brady
6b93dfb89d dspace-cli dockerfile 2019-08-06 11:27:23 -07:00
Mark H. Wood
589aa0f576 [DS-4110] Port #2292 to master (v7) 2019-08-06 14:19:48 -04:00
Terry Brady
bd0b1b7abf dspace-cli dockerfile 2019-08-06 11:19:48 -07:00
Ben Bosman
afc9e5bd89 checkstyle 2019-08-06 18:42:25 +02:00
Ben Bosman
664dc0077c wording fixes 2019-08-06 17:37:46 +02:00
Ben Bosman
8f7c7da569 leftwards label vs left item 2019-08-06 17:29:56 +02:00
Ben Bosman
744dae41aa checkstyle 2019-08-06 16:54:09 +02:00
Ben Bosman
42eccd32c3 Process PR feedback 2019-08-06 16:24:36 +02:00
Ben Bosman
f6e5687385 Process PR feedback 2019-08-06 15:59:12 +02:00
Ben Bosman
cafb26bcb7 Ensure mandatory fields are present 2019-08-06 15:42:41 +02:00
Ben Bosman
af6eac966d Ensure mandatory fields are present 2019-08-06 15:34:54 +02:00
Jelle Pelgrims
3c31fdf648 Rename relationship type left and right labels
Renamed the columns 'left_label' and 'right_label' in the table
'relationship_type' to 'leftward_label' and 'rightward_label'.
Also renamed all instances of [l|L]eftLabel and [r|R]ightLabel
to [l|L]eftwardLabel and [r|R]ightwardLabel, respectively.
2019-08-06 13:59:58 +02:00
Raf Ponsaerts
d7a1015f70 Finished IT for name variants 2019-08-06 13:45:25 +02:00
Jelle Pelgrims
251d264378 Implemented changes 2019-08-06 11:56:31 +02:00
Jelle Pelgrims
db24de2ef0 Merge branch 'feature-name-variants' of https://github.com/atmire/DSpace into feature-name-variants 2019-08-06 09:07:57 +02:00
Jelle Pelgrims
535847d12f Rename database column names for leftward/rightwardLabel 2019-08-06 09:03:46 +02:00
Jelle Pelgrims
0c6f53758d Fix checkstyle errors 2019-08-06 08:48:54 +02:00
Raf Ponsaerts
f17fcc2f42 intermediary commit 2019-08-06 08:41:27 +02:00
Jelle Pelgrims
0bb2135a8e Add Integration tests for harvest settings endpoint 2019-08-06 08:41:11 +02:00
Tim Donohue
7eb73b9072 Merge pull request #2477 from AlexanderS/travis-trusty
Travis CI: Continue to use Ubuntu Trusty 14.04
2019-08-05 19:07:12 +02:00
Tim Donohue
cb50d88980 Merge pull request #2282 from atmire/DS-4097_item-mapper-squashed-final
Implemented the Item Mapper functionality
2019-08-05 18:56:08 +02:00
Alexander Sulfrian
e1b7a88225 Travis CI: Continue to use Ubuntu Trusty 14.04
Ubuntu Xenial 16.04 does not support OracleJDK8 anymore.
2019-08-05 17:14:45 +02:00
Jelle Pelgrims
73865a904b Refactor harvest settings endpoint after manual testing 2019-08-05 14:32:58 +02:00
Jelle Pelgrims
ad59842dd0 Add endpoint to update collection harvest settings 2019-08-05 13:41:39 +02:00
Raf Ponsaerts
1866ed2a96 Moved RelationshipMetadata logic to a new service 2019-08-05 10:40:27 +02:00
Ben Bosman
969158783f process feedback + PR 69
Adding JavaDoc
Processing https://github.com/DSpace/Rest7Contract/pull/69
2019-08-05 10:02:44 +02:00
Raf Ponsaerts
9b3d9e1fa0 Implemented feedback 2019-08-02 14:09:42 +02:00
Jelle Pelgrims
763d9ce8e6 Rename code matching '[mM]apping[a-zA-Z]*' to '[mM]apped[a-zA-Z]*'
Rename 'mappingCollection' and similar code to 'mappedCollection', in order
to resolve Tim Donohue's feedback on the pull request.
2019-08-02 13:13:48 +02:00
Jelle Pelgrims
e51aebf09d Merge branch 'master' into DS-4097_item-mapper-squashed-final 2019-08-02 11:27:46 +02:00
Jelle Pelgrims
be7f13316e Refactor RelationshipRestRepository Integration tests
Refactor the integration tests for the RelationshipRestRepository
to reduce the amount of code duplication. Many tests contained code
to create a number of variables to be used in the test, this code
was pretty much the same for every test. I refactored the integration
test class so that all variables used in multiple tests are now declared
at the top and are initialized in an @Before function. Test-specific
variables are unchanged.
2019-08-02 11:07:37 +02:00
Jelle Pelgrims
0377e0a605 Refactor PUT endpoint json parsing to make use of objectmapper 2019-08-01 15:30:04 +02:00
Jelle Pelgrims
c40dabf9c6 Fix two small issues 2019-08-01 14:36:10 +02:00
Jelle Pelgrims
bb85c4f3ad Add tests for relationship name variant 2019-08-01 13:57:16 +02:00
Jelle Pelgrims
bbb6dca621 Update PUT & POST endpoints for relationships to support name variants 2019-08-01 10:35:32 +02:00
Jelle Pelgrims
172e5ec863 Add leftWard/rightWard-Label to Relationship
Modified the Relationship so that it also has a leftWardLabel and a
rightWardLabel for storing alternative labels (name variants). Also
created an sql migration to add two columns for these labels to the
relationship table.
2019-07-31 11:57:09 +02:00
Raf Ponsaerts
db1a885604 Merged DSpace/master into w2p-63475_implement-upload-bitstream-to-archived-item 2019-07-31 11:36:55 +02:00
Raf Ponsaerts
f622ef1d2a Merge remote-tracking branch 'dspace/master' into w2p-63475_implement-upload-bitstream-to-archived-item 2019-07-31 11:17:32 +02:00
Raf Ponsaerts
5e8f355536 Merged DSpace/master into w2p-63533_changes-to-dtd-and-api-relationship-submission 2019-07-31 10:00:14 +02:00
Raf Ponsaerts
e678977f27 Merge remote-tracking branch 'dspace/master' into w2p-63533_changes-to-dtd-and-api-relationship-submission 2019-07-31 09:32:24 +02:00
Mark H. Wood
3441a0c9e2 [DS-4118] Don't require editing email templates at every site. 2019-07-26 11:50:22 -04:00
Mark H. Wood
a3f8503e9b [DS-4118] Use the correct leading character for a "set" directive 2019-07-26 11:27:37 -04:00
Tim Donohue
d896fed7a7 Merge pull request #2394 from ilittle-cnri/DS-1477-update-handle-server
[DS-4205] Upgrade to Handle Server v9
2019-07-25 22:12:54 +02:00
Ian Little
65e1d2c7dc Merge branch 'master' into DS-1477-update-handle-server
# Conflicts:
#	dspace-api/pom.xml
#	pom.xml
2019-07-25 14:03:29 -04:00
Tim Donohue
a11d4423b6 Merge pull request #2459 from tdonohue/rename_spring_rest
[DS-4257] (One Webapp Phase 2) Rename "dspace-spring-rest" to "dspace-server-webapp"
2019-07-25 17:05:55 +02:00
Ben Bosman
c97a48339c selectableRelationships should only be included if they are present 2019-07-25 15:08:03 +02:00
Ben Bosman
a1e47b8bda Merge remote-tracking branch 'community/master' into w2p-63533_changes-to-dtd-and-api-relationship-submission 2019-07-25 14:16:00 +02:00
Raf Ponsaerts
c70c1d3030 [Task 63947] applied feedback on SubmissionForm matcher 2019-07-25 12:57:41 +02:00
Raf Ponsaerts
2c4d7e656e [Task 63946] applied the feedback 2019-07-25 10:53:48 +02:00
Raf Ponsaerts
a1f653bdd6 [Task 63747] added IT for the relationship config 2019-07-24 14:25:43 +02:00
Raf Ponsaerts
2966bc919d Added the setting of name when no properties are present in the item bitstream upload 2019-07-24 09:59:21 +02:00
Raf Ponsaerts
22de7a80d9 [Task 63822] applied feedback where possible 2019-07-24 09:53:13 +02:00
Raf Ponsaerts
17a51e985b [Task 63533] Made sure that the relationship section in the submission forms is only shown in the response when it's a relationship field 2019-07-24 08:38:28 +02:00
Tim Donohue
8dc1d27598 Correct sample URLs in tests 2019-07-19 16:35:53 -05:00
Tim Donohue
739ff181cc Rename "dspace-spring-rest" to "dspace-server-webapp" 2019-07-19 16:35:53 -05:00
Tim Donohue
4155108745 Merge pull request #1992 from mwoodiupui/DS-3872
[DS-3872] More powerful email template language, and a richer set of substituents
2019-07-19 22:28:07 +02:00
Mark H. Wood
86b90dc490 [DS-3872] From review: fix quoting in template, handle 0 arguments. 2019-07-18 16:11:36 -04:00
Andrea Bollini
c17c15ff22 Merge pull request #2442 from atmire/DS-4266-bitstream-format-crud
[DS-4266] bitstream format crud
2019-07-18 16:14:00 +02:00
Jelle Pelgrims
d92aab0597 Add tests for multiple community title issue, along with temporary solution 2019-07-17 14:38:43 +02:00
Kevin Van de Velde
5297c88292 Test that supportLevel is not changed 2019-07-17 11:36:37 +02:00
Raf Ponsaerts
e557f01360 Refined the SelectableMetadata representation 2019-07-16 11:07:43 +02:00
Raf Ponsaerts
f166e8981f Implemented the Relationship logic in the submissionforms endpoint 2019-07-16 09:33:19 +02:00
Mark H. Wood
e02d91122f [DS-4300] Add option to use provided Handles if any. 2019-07-15 12:41:13 -04:00
Raf Ponsaerts
d8beea83bd Changed endpoint mapping and fixed tests accordingly 2019-07-15 11:45:06 +02:00
Raf Ponsaerts
4d3e2a6fbf [DS-4097] added javadocs to the requested classes 2019-07-15 11:45:06 +02:00
Marie Verdonck
3dc50a1277 Undo HALResource change, all tests run locally 2019-07-15 11:45:06 +02:00
Marie Verdonck
35316f6d2f Non-code changes, just whitelines 2019-07-15 11:45:06 +02:00
Marie Verdonck
a7e2a79774 restored auth system everywhere and size check for items in MappedItems call ($._embedded.mappingItems) 2019-07-15 11:45:06 +02:00
Marie Verdonck
c727471309 - Unit tests for findByCollectionMapping (incl Pagination) & countByCollectionMapping 2019-07-15 11:45:06 +02:00
Marie Verdonck
59b0ce470a Tests for new expected exceptions in MappingCollection endpoint
POST/DELETE:
 405: item is a template item
 422: specified collection not found or owningCollection of the item
2019-07-15 11:45:06 +02:00
Marie Verdonck
3fd522bf2b POST mappedCollections does not work now if given collection is owningCollection of item
> Throws exception, error status 405
2019-07-15 11:45:06 +02:00
Marie Verdonck
5be2b9628f Error & Status for non-successful POST/DELETE mappedCollections requests
- POST /api/core/items/<:uuid>/mappedCollections
 > 405: item is a template item
 > 422: specified collection not found or is owningCollection of item
- DELETE /api/core/items/<:uuid>/mappedCollections/<:collection_uuid>
 > 405: item is a template item
 > 422: specified collection not found or is owningCollection of item
2019-07-15 11:45:05 +02:00
Samuel
e420c71098 DS-4097 name change from mappingCollections to mappedCollections + data change to uri-list 2019-07-15 11:44:13 +02:00
Raf Ponsaerts
4215e91964 Implemented the Item Mapper functionality 2019-07-15 11:44:12 +02:00
Tim Donohue
1812099674 Merge pull request #2443 from atmire/w2p-62610_metadata-schema-registries-for-entity-types-squashed-2
DS-4223 Metadata Schemas for configurable entities
2019-07-12 19:21:21 +02:00
Raf Ponsaerts
3ff164c0fe Implemented feedback and testing on item bitstreams post endpoint 2019-07-12 11:39:09 +02:00
Tim Donohue
d7bdfa92c0 Merge pull request #2467 from atmire/DS-4298_upload-endpoint-uuid-broken
[DS-4298] changed the PathVariable for the upload method with uuid to…
2019-07-11 23:17:57 +02:00
Mark H. Wood
87d2f071e2 Merge branch 'master' into DS-3872 2019-07-11 11:54:35 -04:00
Tim Donohue
e2ea244eb3 Merge pull request #2283 from atmire/DS-4096-updating-owning-collections2
DS-4096: updating owning collections
2019-07-10 23:39:42 +02:00
Tim Donohue
30494e0fc5 Merge pull request #2429 from 4Science/DS-4210
DS-4210 Deposit on collection without workflow seems to fail (405 but succeed)
2019-07-10 23:20:45 +02:00
Tim Donohue
f4cd6997d9 Merge pull request #2446 from atmire/DS-4244_Entities-unit-tests
DS-4244 Add configurable entities unit tests
2019-07-10 23:13:20 +02:00
Raf Ponsaerts
70b394b57f Implemented the upload of a bitstream to an archived item 2019-07-10 14:43:20 +02:00
Raf Ponsaerts
41c7003d43 [DS-4298] changed the PathVariable for the upload method with uuid to be called 'uuid' 2019-07-10 08:55:39 +02:00
Tim Donohue
1dece5ead3 Merge pull request #2457 from atmire/delete-relationship-it-squashed
Delete relationship Integration Test
2019-07-09 23:55:07 +02:00
Yana De Pauw
705cc80a91 63419: Bitstream format registry feedback 2019-07-09 18:05:28 +02:00
Raf Ponsaerts
c1288daf19 Reinstated a sanity check 2019-07-09 12:45:12 +02:00
Raf Ponsaerts
5a810644e1 [Task 63533] applied feedback 2019-07-09 10:42:39 +02:00
benbosman
e2c1ab5a17 Merge pull request #2456 from atmire/DS-4084_remove-leftid-rightid-relationship
[DS-4084] - Relationships should link to Items via REST API
2019-07-09 09:15:07 +02:00
Raf Ponsaerts
d8970ff9c4 Merged master into DS-4084_remove-leftid-rightid-relationship 2019-07-09 07:43:13 +02:00
Tim Donohue
74299e87a3 Merge pull request #2397 from mwoodiupui/DS-3823
[DS-3823] Our extensive EHCache configuration is ignored
2019-07-08 21:01:16 +02:00
Raf Ponsaerts
a846d2dc10 [Task 63533] made a working implementation for the submission-forms.xml 2019-07-08 15:15:12 +02:00
Yana De Pauw
bf0bc5b732 Add javadocs 2019-07-08 14:14:39 +02:00
benbosman
f6e16f9156 Merge pull request #2450 from atmire/w2p-62955_change-endpoint-to-search-relationships-by-label-update
Relationship search by label
2019-07-08 10:55:20 +02:00
Raf Ponsaerts
112078e858 Added javadoc 2019-07-04 15:00:17 +02:00
Mark H. Wood
eee406bccf Merge pull request #2466 from mwoodiupui/DS-1443-again
[DS-1443] Export Community/Collection structure with structure-builder
2019-07-03 13:51:55 -04:00
Mark H. Wood
5c02705a81 [DS-1443] Somebody replaced DC_SCHEMA with DC.getName(). 2019-07-03 12:59:29 -04:00
Mark H. Wood
180ce285aa Merge pull request #2421 from mwoodiupui/DS-1443-again
[DS-1443] Export structure with structure-builder
Since this is essentially the same as a PR already having two approvals, and has been reviewed again in its present form, I'm merging it.
2019-07-03 11:41:28 -04:00
Mark H. Wood
d28c15dae3 [DS-4289] use a new method to write the 'contents' file. 2019-07-02 14:51:25 -04:00
Andrew Wood
c7aded19a8 DS-4244 Improve comments for relationship concept unit test 2019-07-01 15:28:19 -04:00
Raf Ponsaerts
0555186e82 Added inline comments to the RelationshipRestRepositoryIT#findRelationshipByLabelTest 2019-07-01 13:32:11 +02:00
Kevin Van de Velde
4f5e051c2d Merge branch 'master' into DS-4096-updating-owning-collections2 2019-06-28 13:00:28 +02:00
Tim Donohue
4d8777c24e Merge pull request #2448 from AlexanderS/minor-code-cleanup
Some minor code cleanup in the tests
2019-06-27 18:30:51 +02:00
Tim Donohue
4f2519d36d Merge pull request #2458 from tdonohue/lost_commit
DS-2376: Catch exception from encrypted PDF instead of expecting to test for it. (Bug fix follow-up)
2019-06-27 17:27:23 +02:00
Mark H. Wood
998c3109d0 Catch exception from encrypted PDF instead of expecting to test for it. 2019-06-27 09:52:33 -05:00
Tim Donohue
f29f2fe2b6 Merge pull request #2425 from tdonohue/security_updates
Minor dependency updates for `master` (pre-7.0)
2019-06-27 16:44:43 +02:00
Andrea Bollini
705c6e95d5 Remove unnecessary debugging sysout 2019-06-27 16:05:49 +02:00
Ben Bosman
dc38da9ef5 Squashed commit of the following:
commit fc632442c0f0fabf6738b515d629997644a40096
Author: Ben Bosman <ben@atmire.com>
Date:   Thu Jun 27 09:20:03 2019 +0200

    IT on delete, counting relationships per item
2019-06-27 11:07:35 +02:00
Ben Bosman
ee8d40cef2 IT on delete, counting relationships per item 2019-06-27 09:15:36 +02:00
Ben Bosman
e945a3e560 merge with master 2019-06-25 14:17:53 +02:00
Ben Bosman
8392429c89 merge with master 2019-06-25 13:48:07 +02:00
Ben Bosman
c51e28ed0f Merge remote-tracking branch 'community/master' into DS-4084_remove-leftid-rightid-relationship 2019-06-25 13:47:11 +02:00
Ben Bosman
0b4aef01b5 Travis trigger 2019-06-25 13:23:33 +02:00
Ben Bosman
488b0f9e6b Merge remote-tracking branch 'community/master' into w2p-62955_change-endpoint-to-search-relationships-by-label-update 2019-06-25 11:22:00 +02:00
Mark H. Wood
590d563197 [DS-3872] Finish removing autoconfigure from Application. 2019-06-24 17:23:18 -04:00
Mark H. Wood
5724b21149 [DS-3872] Remove outdated, redundant Commons Lang3 dependency. 2019-06-24 17:17:42 -04:00
Mark H. Wood
dd84ef0ce6 [DS-3872] More thorough documentation of header control. 2019-06-24 17:16:52 -04:00
Mark H. Wood
03377c24bd [DS-3872] Move exlcusion of Spring's Velocity autoconfig to where the others are. 2019-06-24 17:15:41 -04:00
Tim Donohue
05b721584d Merge pull request #2432 from 4Science/DS-4252
DS-4252 Discovery re-index doesn't work without -b
2019-06-24 19:50:59 +02:00
Tim Donohue
0b0931d96d Upgrade Spring per security notice 2019-06-24 12:15:10 -05:00
Tim Donohue
59f55180d3 Upgrade PDFBox per security notice. Remove BouncyCastle optional dependency (DSpace doesn't support encrypted PDFs) 2019-06-24 12:13:50 -05:00
Tim Donohue
b75c4e1a02 Security update for checkstyle 2019-06-24 12:13:50 -05:00
Tim Donohue
9d6b75466b Security update for jackson-databind 2019-06-24 12:13:50 -05:00
Tim Donohue
7680a3dd49 DS-4073 fix. FindByValue should pass in value, not qualifier. 2019-06-24 10:10:49 -05:00
Kevin Van de Velde
46a3b5d20d Merge branch 'master' into DS-4266-bitstream-format-crud 2019-06-24 15:58:09 +02:00
Tim Donohue
b56b47629a Merge pull request #2440 from atmire/w2p-62574_PUT-relationships-modify-left-or-right-item-squashed
DS-4230 - PUT contract in relationships
2019-06-21 18:53:25 +02:00
Tim Donohue
f02c44c655 Merge pull request #2403 from atmire/DS-4217_PatchBadRequestException-name-refactor-and-fix-BadRequestException-errors
[DS-4217] applied the name refactor and rewrote BadRequestException t…
2019-06-21 18:13:31 +02:00
Raf Ponsaerts
0afb8d3203 Fixed tests 2019-06-21 14:17:42 +02:00
Andrea Bollini
971b28448f Merge pull request #2444 from 4Science/DS-4269
DS-4269 Incorrect hal pagination links in the browses endpoint
2019-06-20 17:06:46 +02:00
Andrea Bollini
f8a66833d7 revert unnecessary change 2019-06-20 16:37:33 +02:00
Andrea Bollini
4cd9d6ce6e Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4210 2019-06-20 16:09:03 +02:00
Raf Ponsaerts
a15213bf6e Merged w2p-62955_change-endpoint-to-search-relationships-by-label-update into w2p-63107_merge-branches 2019-06-20 09:54:48 +02:00
Raf Ponsaerts
95ae7c0cbb Merge branch 'w2p-62574_PUT-relationships-modify-left-or-right-item-squashed' into w2p-63107_merge-branches 2019-06-20 09:29:56 +02:00
kshepherd
01ea800143 Merge pull request #2224 from mwoodiupui/DS-4032
[DS-4032] RequestItem.isAccept_request() can NPE if setAccept_request() was never called.
2019-06-19 22:41:04 +02:00
Raf Ponsaerts
f57d5113fe Fixed tests and checkstyle 2019-06-19 09:32:58 +02:00
Raf Ponsaerts
f0e4701c18 Added support for not passing a DSO parameter to the search endpoint 2019-06-19 08:04:01 +02:00
Raf Ponsaerts
a1995347fe Implemented the search method on the relationships endpoint
Conflicts:
	dspace-spring-rest/src/main/java/org/dspace/app/rest/model/RelationshipRestWrapper.java
	dspace-spring-rest/src/main/java/org/dspace/app/rest/repository/RelationshipRestRepository.java
	dspace-spring-rest/src/test/java/org/dspace/app/rest/RelationshipTypeRestControllerIT.java
2019-06-19 08:03:35 +02:00
Alexander Sulfrian
7dcc9fcf29 Inner class can be static
Inner classes, that does not reference the enclosing class, can be static.
2019-06-18 21:36:45 +02:00
Alexander Sulfrian
b007793ea0 IOUtil.copy without Charset is deprecated 2019-06-18 21:36:45 +02:00
Alexander Sulfrian
8ea6b21a73 Replace createSQLQuery with createNativeQuery
Since hibernate 5.2 createSQLQuery is deprecated in favor of createNativeQuery.
2019-06-18 19:54:18 +02:00
Alexander Sulfrian
1a4dae950c Remove shadowing variables
authorizeService and context are already defined in the AbstractUnitTest.
2019-06-18 19:54:17 +02:00
Alexander Sulfrian
63803e8314 Replace commons-io Charsets with StandardCharsets
org.apache.commons.io.Charsets is deprecated in favor of
java.nio.charset.StandardCharsets.
2019-06-18 19:54:17 +02:00
Alexander Sulfrian
324c8c8d44 Add missing @Override 2019-06-18 19:54:17 +02:00
Alexander Sulfrian
0679801945 Fix order of arguments of assertEquals 2019-06-18 19:54:04 +02:00
Andrew Wood
2a32c7ec02 DS-4244 Add entity and relationship unit tests 2019-06-17 09:20:45 -04:00
Raf Ponsaerts
99bba2ab63 DS-4244 Add RelationshipTypeTest
Refactored the RelationshipTypeTest to be more compliant with the JUnit tests
2019-06-17 09:20:31 -04:00
Raf Ponsaerts
cf2e443037 Removed the leftid and rightid properties from the Relationship response 2019-06-17 10:09:23 +02:00
Ben Bosman
65c3039c1d Support for requesting a specification configuration using e.g. /rest/api/discover/search/objects?configuration=publicationConfiguration 2019-06-13 15:49:40 +02:00
Ben Bosman
bb97672020 Discovery configuration specific to Publication 2019-06-13 15:04:03 +02:00
Raf Ponsaerts
bef7afae8c [DS-4266] fixed the lazy loading issue on bitstreamFormat 2019-06-12 13:04:23 +02:00
Tim Donohue
62de82fee0 Merge pull request #2437 from AlexanderS/fix-hal-login-form
[DS-4259] HAL login form does not support special characters
2019-06-11 20:44:00 +02:00
Andrea Bollini
e2f4eafd0f DS-4270 fix typo 2019-06-11 03:05:31 +02:00
Andrea Bollini
22cd4cf090 DS-4269 fix links issue when there were not parameters 2019-06-11 03:04:44 +02:00
Andrea Bollini
cd1ed182f0 DS-4269 improve IT for pagination links issue 2019-06-11 02:44:20 +02:00
Andrea Bollini
4b9b020669 DS-4269 IT to reproduce the bug in pagination links 2019-06-11 02:16:16 +02:00
Andrea Bollini
aa7c206e0b DS-4210 improve cleanup of workspace and workflow items 2019-06-11 01:25:52 +02:00
Andrea Bollini
8f1092e895 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4210 2019-06-10 21:50:26 +02:00
Raf Ponsaerts
7fbf902de0 [DS-4217] changed all invalidrequest to DSpaceBadRequestExceptions 2019-06-07 12:36:32 +02:00
Raf Ponsaerts
99eae45db0 [DS-4217] added comment to test method 2019-06-07 11:11:28 +02:00
Ben Bosman
91651acc7a updated for schema.org metadata 2019-06-06 11:46:14 +02:00
Ben Bosman
8ae365724d updated for schema.org metadata 2019-06-06 10:57:06 +02:00
Ben Bosman
3290c49f48 Squashed commit of the following:
commit 182b9db8784b7c98f629d04ae91ca19abdd2cc71
Author: Ben Bosman <ben@atmire.com>
Date:   Wed Jun 5 17:35:15 2019 +0200

    whitespace fixes

commit ffce348b698b96c47995d962a5892566cd317e1e
Author: Ben Bosman <ben@atmire.com>
Date:   Wed Jun 5 17:31:14 2019 +0200

    whitespace fixes

commit a1aeb273ff598305609013f82afd7126e2286f07
Author: Ben Bosman <ben@atmire.com>
Date:   Wed Jun 5 16:58:33 2019 +0200

    merging https://github.com/DSpace/DSpace/pull/2116

commit e89ace0c3cdb5c28c3d59bab6334c514513667d5
Merge: 568aa0d5c a7a8545cd
Author: Ben Bosman <ben@atmire.com>
Date:   Wed Jun 5 16:56:35 2019 +0200

    Merge remote-tracking branch 'community/master' into w2p-62610_metadata-schema-registries-for-entity-types-squashed

    # Conflicts:
    #	dspace-api/src/main/java/org/dspace/storage/rdbms/DatabaseRegistryUpdater.java

commit 568aa0d5c9ea86cb31bf825f330a5e4c044a1653
Author: Ben Bosman <ben@atmire.com>
Date:   Wed Jun 5 14:57:20 2019 +0200

    configuring dates as date facets

commit 6390487d45a8e83e02d1e312ced319ed59525377
Author: Ben Bosman <ben@atmire.com>
Date:   Wed Jun 5 12:08:45 2019 +0200

    updated for schema.org metadata - removed collection mapping

commit 171ee9b201eabfa74d2375ef1e0fdba2ea85c404
Author: Ben Bosman <ben@atmire.com>
Date:   Wed Jun 5 12:03:54 2019 +0200

    Squashed commit of the following:

    commit 25fac292281741afe3eb8c7fad5cfff91965461d
    Author: Ben Bosman <ben@atmire.com>
    Date:   Tue Jun 4 13:34:58 2019 +0200

        updated for schema.org metadata

    commit c62fcb75e7ac21f3dc41aa34bed597a4d701e932
    Author: Raf Ponsaerts <raf.ponsaerts@atmire.com>
    Date:   Tue Jun 4 11:46:51 2019 +0200

        [Task 62732] updated the virtual-metadata config

    commit 9ade3f90c011a04e6eb79d91d0f82cc305f941dd
    Author: Ben Bosman <ben@atmire.com>
    Date:   Tue Jun 4 11:35:46 2019 +0200

        discovery config update

    commit eef08d7617be5ead9626829b0320bcb610d8cb40
    Author: Ben Bosman <ben@atmire.com>
    Date:   Mon Jun 3 15:12:59 2019 +0200

        new types for entities

    commit 434722b809cab29ff8e3b95eb04ed644008afc38
    Author: Ben Bosman <ben@atmire.com>
    Date:   Mon Jun 3 14:55:05 2019 +0200

        restored eperson types

    commit ef97353de6a9c07e91d4680cb9b1e5fb539b94d7
    Author: Marie Verdonck <maria.verdonck@atmire.com>
    Date:   Wed May 29 16:28:12 2019 +0200

        Discovery config for entities Organization; PublicationIssue;
           PublicationVolume; Periodical

        Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>

    commit 2c02d863c66174917bcf4309f370e5c2d56f4260
    Author: Ben Bosman <ben@atmire.com>
    Date:   Tue May 28 18:52:46 2019 +0200

        journal volume name

    commit ceb5a2d34fed3647f92997b6a0b1f06b34cdfa7c
    Author: Ben Bosman <ben@atmire.com>
    Date:   Tue May 28 18:10:20 2019 +0200

        sort by date accessioned

    commit 62751138875b130d3c512453199e0ba5b4a9451f
    Author: Marie Verdonck <maria.verdonck@atmire.com>
    Date:   Tue May 28 15:40:22 2019 +0200

        Discovery configuration for Person Entity

    commit 62622ccbc66bbebc4a297b216507461f3a1f37de
    Author: Marie Verdonck <maria.verdonck@atmire.com>
    Date:   Tue May 28 14:25:18 2019 +0200

        Submission-forms changed for new metadata mapping
        - Not yet mapped with replacement fields commented

    commit 2f6338d1e85352097f398281685e7800e00a5e87
    Author: Ben Bosman <ben@atmire.com>
    Date:   Tue May 28 11:07:48 2019 +0200

        fixes to submission forms

    commit 9aeebf61a8e180e3ee6b90001385eae3d7921f35
    Author: Ben Bosman <ben@atmire.com>
    Date:   Tue May 28 11:02:54 2019 +0200

        fixes to submission forms

    commit 9055ae6d8ed4b686c879853ea8ca761950d27f87
    Author: Marie Verdonck <maria.verdonck@atmire.com>
    Date:   Tue May 28 10:47:31 2019 +0200

        Equivalents found in dublin-core-types, list so far:
        * person-types.xml & eperson-types.xml > schema-person-types.xml
            * eperson.firstname > person.givenName
            * eperson.lastname > person.familyName
            * eperson.phone > persone.telephone
            * eperson.language > person.knowsLanguage
            * person.identifier.email > person.email
            * person.identifier.orcid > NOT FOUND
            * person.identifier.birthdate > person.birthDate
            * person.identifier.staffid > NOT FOUND
            * person.identifier.jobtitle > person.jobTitle
            * person.contributor.other > NOT FOUND
        * journalVolume-types.xml > schema-publicationVolume-types.xml
            * journalvolume.issuedate > creativework.datePublished
            * journalvolume.identifier.volume > publicationVolume.volumeNumber
            * journalvolume.identifier.name > NOT FOUND
            * journalvolume.identifier.description > dc.description
        * orgunit-types.xml > schema-organization-types.xml
            * orgunit.identifier.name > organization.legalName
            * orgunit.identifier.id > NOT FOUND
            * orgunit.identifier.dateestablished >organisation.foundingDate
            * orgunit.identifier.city > organisation.address.addressLocality
            * orgunit.identifier.country > organisation.address.addressCountry
            * orgunit.identifier.description > dc.description
        * project-types.xml > schema-project-types.xml

        ‘Project’ is still in ‘Pending’ https://pending.schema.org/
            * project.identifier.name > dc.title
            * project.identifier.id > dc.identifier
            * project.identifier.status > NOT FOUND
            * project.identifier.startdate > NOT FOUND
            * project.identifier.expectedcompletion > NOT FOUND
            * project.identifier.keyword > dc.subject
            * project.identifier.description > dc.description
            * project.contributor.other > dc.contributor.other
            * project.contributor.author > dc.contributor.author
        * journalissue-types.xml > schema-publicationIssue-types.xml
            * journalissue.issuedate > creativework.datePublished
            * journalissue.identifier.number > publicationissue.issueNumber
            * journalissue.identifier.name > dc.title
            * journalissue.identifier.description > dc.description
            * journalissue.identifier.keyword > creativework.keywords
        * journal-types > schema-periodical-types.xml
            * journal.contributor.editor > creativework.editor
            * journal.publisher > creativework.publisher
            * journal.identifier.issn > creativeworkseries.issn
            * journal.identifier.name > dc.title
            * journal.identifier.description > dc.description
            * journal.title > NOT FOUND

    commit 1578da3a76fa29567a63e64b587898a24004dbf4
    Author: Marie Verdonck <maria.verdonck@atmire.com>
    Date:   Mon May 27 15:38:54 2019 +0200

        Metadata registries for entity types (partially) mapped and replaced by schema.org values
        Non-mapped values logged in new files
        - person-types.xml & eperson-types.xml > schema-person-types.xml
        - journalVolume-types.xml > schema-publicationVolume-types.xml
        - orgunit-types.xml > schema-organization-types.xml
        - project-types.xml > schema-project-types.xml
        - journalissue-types.xml > schema-publicationIssue-types.xml
        - journal-types > schema-periodical-types.xmlnon-direct parent thing.name)
2019-06-05 17:45:08 +02:00
benbosman
a7a8545cd5 Merge pull request #2116 from mwoodiupui/DS-3953
[DS-3953] Externalize hard-coded list of metadata registry files in updater
2019-06-05 16:52:24 +02:00
Kevin Van de Velde
8d97f23375 [DS-4266] CRUD support for bitstream formats: Code style cleanup 2019-06-05 11:46:00 +02:00
Marie Verdonck
6a65cd2ad3 Error handling and cleanup:
- setAllValuesOfRest() SQLException now meaningful message
- metadataConverter never used, so removed
- id comparison check flipped so no NullPointer when no id in json in body,
but meaningful message
2019-06-04 13:15:20 +02:00
Marie Verdonck
f3cfe49a97 Removing non-code changes (indentation) 2019-06-04 10:35:55 +02:00
Mark H. Wood
55dbcb96cd [DS=3953] Configuration comment to explain how these properties are used. 2019-06-02 08:25:25 -04:00
Mark H. Wood
b6eb0b7d85 Merge branch 'DS-3953' of github.com:mwoodiupui/DSpace into DS-3953 2019-06-02 08:19:40 -04:00
Marie Verdonck
1f40ae51ad 400 - DSpaceBadRequestException when nonvalid supportLevel in rest call for
POST /api/core/bitstreamformats
PUT /api/core/bitstreamformats/<:id>

Implementation & Tests for create/update
2019-05-31 15:32:16 +02:00
Raf Ponsaerts
db8f203f01 [DS-4217] fixed compilation failure after rebase and wrote tests for the DSpaceBadRequestException
Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
2019-05-31 15:00:43 +02:00
Raf Ponsaerts
d6b5abd694 [DS-4217] applied the name refactor and rewrote BadRequestException to use this class instead
Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
2019-05-31 15:00:19 +02:00
Marie Verdonck
15f6f9e9b8 Tests for full CRUD functionality on bitstreamformat registry endpoint:
POST /api/core/bitstreamformats
PUT /api/core/bitstreamformats/<:id>
DELETE /api/core/bitstreamformats/<:id>

Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
2019-05-31 14:50:52 +02:00
Marie Verdonck
44f8a8ef9f Thown sql exception with message & checkstyle 2019-05-31 14:49:59 +02:00
Marie Verdonck
c79006dca1 unused import, checkstyle violation 2019-05-31 14:49:12 +02:00
Marie Verdonck
e4f1ed698a comments removed & if supportlevel is -1 (not given), set to UNKNOWN 2019-05-31 14:48:29 +02:00
Marie Verdonck
198b97de6d getSupportLevelString removed and usage replaced with getSupportLevelText 2019-05-31 14:47:05 +02:00
Marie Verdonck
47ece82445 Codechanges ignoring whitespaces and empty lines of following commits:
Squashed commit of the following:

commit d65609c
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 11:18:46 2019 +0200

    travis build fixes

commit 62aeb94
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 10:53:48 2019 +0200

    license broken

commit 1d2e2ed
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 10:33:54 2019 +0200

    update comments

commit 552005f
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 10:22:31 2019 +0200

    removed unnecessary method

commit af149e7
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Wed May 29 17:47:27 2019 +0200

    Reduced complexity in relationship rest controller & tests (PUT)
    - No need for id integer check, pathvariable expects only integers
    - Tests added for exception cases:
       > Invalid relationship id (non-existent) > 404 - Not found
       > Invalid item id in body > 422 - Unprocesseable
    - Test verification andExpect() more efficient

commit 3c37d20
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Wed May 29 10:43:19 2019 +0200

    Tests for the endpoints: PUT /api/core/relationships/:id/leftItem
                             PUT /api/core/relationships/:id/rightItem

commit a58c611
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Tue May 28 10:18:19 2019 +0200

    Back to original isAllowedToModify method; regex for relationship id in mapping &
    - No need to check for leftItem=rightItem, is allowed
    - No need to check if relationship already exists, DB will prevent duplicates

commit 2424c5c
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Mon May 27 13:53:50 2019 +0200

    Changes in the PUT on relationships, new endpoints:
    - PUT /api/core/relationships/:id/leftItem
    - PUT /api/core/relationships/:id/rightItem

    > 403 Forbidden  - if not enough write rights (see below)
    > 422 Unprocesseable Entity -  if relationship id NaN or invalid item in body
    > 404 Resource Not Found if - relationship with given id not found

    Needed permissions:
    Replace left: right.WRITE OR (left.WRITE AND old-left.WRITE)
    Replace right: left.WRITE OR (right.WRITE AND old-right.WRITE)
2019-05-31 10:14:24 +02:00
Andrea Bollini
eef6055ead Fix wrong cleanup query 2019-05-30 14:55:46 +02:00
Andrea Bollini
b9b0fcd45f Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4252 2019-05-30 14:47:16 +02:00
Ben Bosman
38f1468f42 Squashed commit of the following:
commit d65609c66e4dd54c5a8af2fc18d952c958c0f69b
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 11:18:46 2019 +0200

    travis build fixes

commit 62aeb9463d9c74070540ad1eb247bb539dae8cf9
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 10:53:48 2019 +0200

    license broken

commit 1d2e2edb085433f79aa2abe58cdc4d4065dbfc81
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 10:33:54 2019 +0200

    update comments

commit 552005fc2f1c912220d0f62e94c3045e9f772be2
Author: Ben Bosman <ben@atmire.com>
Date:   Thu May 30 10:22:31 2019 +0200

    removed unnecessary method

commit af149e7871f30e4bc17f7eeccf8655fe9d80cdf7
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Wed May 29 17:47:27 2019 +0200

    Reduced complexity in relationship rest controller & tests (PUT)
    - No need for id integer check, pathvariable expects only integers
    - Tests added for exception cases:
       > Invalid relationship id (non-existent) > 404 - Not found
       > Invalid item id in body > 422 - Unprocesseable
    - Test verification andExpect() more efficient

commit 3c37d208cbe609f5182470ce8302ec25de00939f
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Wed May 29 10:43:19 2019 +0200

    Tests for the endpoints: PUT /api/core/relationships/:id/leftItem
                             PUT /api/core/relationships/:id/rightItem

commit a58c611ad7a648b28933fb39840866def42384e6
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Tue May 28 10:18:19 2019 +0200

    Back to original isAllowedToModify method; regex for relationship id in mapping &
    - No need to check for leftItem=rightItem, is allowed
    - No need to check if relationship already exists, DB will prevent duplicates

commit 2424c5c71b63122263aec08e110cf7bb4b19cc5d
Author: Marie Verdonck <maria.verdonck@atmire.com>
Date:   Mon May 27 13:53:50 2019 +0200

    Changes in the PUT on relationships, new endpoints:
    - PUT /api/core/relationships/:id/leftItem
    - PUT /api/core/relationships/:id/rightItem

    > 403 Forbidden  - if not enough write rights (see below)
    > 422 Unprocesseable Entity -  if relationship id NaN or invalid item in body
    > 404 Resource Not Found if - relationship with given id not found

    Needed permissions:
    Replace left: right.WRITE OR (left.WRITE AND old-left.WRITE)
    Replace right: left.WRITE OR (right.WRITE AND old-right.WRITE)

    Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
2019-05-30 11:48:20 +02:00
Marie Verdonck
e3ac8f98b1 Full CRUD on bitstreamformat registry endpoint; added:
POST /api/core/bitstreamformats
PUT /api/core/bitstreamformats/<:id>
DELETE /api/core/bitstreamformats/<:id>

Signed-off-by: Marie Verdonck <maria.verdonck@atmire.com>
2019-05-29 14:36:21 +02:00
Andrea Bollini
970955d722 DS-4210 Fix response code for created object via URI-LIST without further details 2019-05-28 10:55:03 +02:00
Andrea Bollini
ae671d27ab Merge branch 'master' of https://github.com/DSpace/DSpace into DS-4210 2019-05-28 10:52:10 +02:00
Pascal-Nicolas Becker
36e04fba95 DS-4260: Remove non-existing command from oai harvester's help 2019-05-25 11:53:02 +02:00
Alexander Sulfrian
812b459cf5 HAL: Use submit button in login form
This enables some automatic features of the browsers, f.e. the form will be
submitted when you press the return key in the username or password field.
2019-05-24 18:53:10 +02:00
Alexander Sulfrian
2111d03ffb HAL: Encode username and password in login form 2019-05-24 18:52:57 +02:00
Mark H. Wood
ce03072495 [DS-3823] Explain the existence and use of CacheSnooper. 2019-05-24 08:44:25 -04:00
Mark H. Wood
17daf04f21 [DS-3872] Re-remove factored-out code that was un-removed by a botched rebase. 2019-05-22 13:45:16 -04:00
Mark H. Wood
62acad25a3 [DS-3872] Add many inexplicably missing imports after rebase. 2019-05-22 12:10:14 -04:00
Mark H. Wood
ff5962cfa6 [DS-3872] Make config visible to introspector; enable testing arbitrary templates; remove more MessageFormat. 2019-05-22 11:18:16 -04:00
Mark H. Wood
db8a5effb3 [DS-3872] Avoid collision with other Velocity users by making resources local to the engine instance.
Also misc. clarifications and cleanups, drop unused new method.
2019-05-22 11:18:16 -04:00
Mark H. Wood
a579f8fe92 [DS-3872] Spring Boot looks for Velocity and tries to initialize it as v1. Suppress this. 2019-05-22 11:18:16 -04:00
Mark H. Wood
cb3edadf1f [DS-3872] Load template file into string resource repository, let Velocity figure out how to parse it. 2019-05-22 11:08:05 -04:00
Mark H. Wood
9f7b3e53df [DS-3872] Align commons-lang3 transitive dependencies. 2019-05-22 11:08:05 -04:00
Mark H. Wood
60f72fb90a [DS-3872] Checkstyle fixes lost in rebasing. 2019-05-22 11:08:05 -04:00
Mark H. Wood
d94264bc79 [DS-3872] Support 'charset' header; remove old code I had missed. 2019-05-22 11:08:04 -04:00
Mark H. Wood
66191be2aa [DS-3872] Restore ability to set Subject: from template text. 2019-05-22 11:08:04 -04:00
Mark H. Wood
b75c5e1bab [DS-3872] Convert MessageFormat email templates to VTL. 2019-05-22 11:08:04 -04:00
Mark H. Wood
3bea69ae82 [DS-3872] Upgrade to Velocity v2. 2019-05-22 11:08:04 -04:00
Mark H. Wood
5bfe44f93f Begin patching in Velocity 2019-05-22 11:08:04 -04:00
Tim Donohue
68a068db37 Merge pull request #2435 from tdonohue/fix_broken_IT
Fix race condition in IT on "master"
2019-05-21 12:49:50 -05:00
Tim Donohue
81040975ed Convert Mock into a Spy of currently loaded bean 2019-05-21 12:15:37 -05:00
Tim Donohue
73c2e9d2d6 Merge pull request #2265 from tdonohue/one_webapp_backend_redux
DS-4257: DSpace 7 backend as one webapp (RESTv7, SWORD, SWORDv2, OAI, RDF)
2019-05-21 11:02:58 -05:00
xuejiangtao
9766fe131d remove the last if statement to avoid the dead code 2019-05-21 21:52:36 +08:00
Kevin Van de Velde
e3199d76a7 [DS-4096] Updating owning collections: Additional checks to prevent moving to an items current owning collection and making sure that an item is archived or withdrawn 2019-05-21 09:55:44 +02:00
Raf Ponsaerts
15de4f2901 [DS-4217] fixed compilation failure after rebase and wrote tests for the DSpaceBadRequestException 2019-05-21 09:44:29 +02:00
Raf Ponsaerts
bd63a69d09 [DS-4217] applied the name refactor and rewrote BadRequestException to use this class instead 2019-05-21 09:44:24 +02:00
xuejiangtao
6ad6186375 add default return statement 2019-05-20 22:54:45 +08:00
Marie Verdonck
af13e51d0e Max length of line rule 2019-05-20 12:04:37 +02:00
Marie Verdonck
3aea69f9a7 Reason behind context.commit in RestController 2019-05-20 12:04:01 +02:00
Marie Verdonck
69a392a5cd Better exception/error handling for invalid collection uri in PUT /api/core/items/<:uuid>/owningCollection 2019-05-20 10:47:44 +02:00
Andrea Bollini
4194443185 DS-4252 Discovery re-index doesn't work without -b 2019-05-19 22:45:12 +02:00
Tim Donohue
aebd0f9ce6 [maven-release-plugin] prepare for next development iteration 2019-05-17 15:34:13 -05:00
Tim Donohue
44e7b3aca6 [maven-release-plugin] prepare release dspace-7.0-preview-1 2019-05-17 15:34:04 -05:00
Tim Donohue
2b9d726214 Merge pull request #2430 from atmire/DS-4253-discovery-oom-fix
DS-4253 Avoid oom during discovery reindex
2019-05-17 10:05:32 -05:00
Samuel
f7e1489bf3 DS-4096 change data to uri-list 2019-05-17 10:08:06 +02:00
Chris Wilper
7238f42cf4 DS-4253 Avoid oom during discovery reindex 2019-05-16 16:35:30 -04:00
Samuel
e403afbd52 Merge branch 'master' into DS-4096-updating-owning-collections2 2019-05-16 18:15:19 +02:00
Mark H. Wood
d89186a192 Merge pull request #2392 from mwoodiupui/DS-3658
[DS-3658] Configure ReindexerThread disable reindex
2019-05-15 13:04:03 -04:00
Mark H. Wood
d48aae5baa [DS-3658] Remove JSPUI comment mistakenly reintroduced by comment fix. 2019-05-15 11:41:22 -04:00
xuejiangtao
ee2db20185 Merge pull request #1 from xuejiangtao/xuejiangtao-patch-1
remove the condition that is always 'true'
2019-05-15 23:27:16 +08:00
xuejiangtao
003daf0a05 remove the condition that is always 'true' 2019-05-15 23:26:02 +08:00
Mark H. Wood
8afb630fcc Merge branch 'master' into DS-3658 2019-05-15 11:15:17 -04:00
Mark H. Wood
43444c84b7 [DS-3658] Accept abollini's fix to configuration comments, with minor adjustments. 2019-05-15 11:10:09 -04:00
Raf Ponsaerts
d0dcfe2699 [DS-4217] fixed compilation failure after rebase and wrote tests for the DSpaceBadRequestException 2019-05-14 09:01:12 +02:00
Raf Ponsaerts
50db4b8fc7 [DS-4217] applied the name refactor and rewrote BadRequestException to use this class instead 2019-05-13 14:56:15 +02:00
Tim Donohue
4d35e0fe28 Exclude old version of Jena from SWORDv2 to resolve conflicts with RDF. Add note about upgrading Jena for future. 2019-05-10 15:25:08 -05:00
Tim Donohue
11842b5485 Restore dependency that was accidentally removed 2019-05-10 15:25:08 -05:00
Terry Brady
7bf2d45d14 simplify dockerfile overrides 2019-05-10 15:25:08 -05:00
Terry Brady
4b94208676 fix ROOT 2019-05-10 15:25:08 -05:00
Terry Brady
10b25af158 handle root 2019-05-10 15:25:08 -05:00
Terry Brady
07029b9caf fix ROOT ref 2019-05-10 15:25:07 -05:00
Terry Brady
efea77fb7d simplify dockerfile for onewebapp 2019-05-10 15:25:07 -05:00
Tim Donohue
f89eebc714 Dependency bug fix. Avoid pulling in Spring Boot logging & other unnecessary dependencies 2019-05-10 15:25:07 -05:00
Tim Donohue
4938eb7f42 Configuration fixes. Add missing oai.cfg properties. Default dspace.baseUrl to single webapp path. 2019-05-10 15:25:07 -05:00
Tim Donohue
4fd0044ff8 Bug Fix. Ensure proper "baseUrl" is reported from each OAI context. Add IT to prove it works 2019-05-10 15:25:07 -05:00
Tim Donohue
ea4e05d8b8 Embed RDF into Boot webapp. Add basic ITs to prove it works. 2019-05-10 15:25:07 -05:00
Tim Donohue
20e4da56d3 Remove OAI Integration Tests, framework & stubs. These ITs were moved to Spring Boot in previous commit. 2019-05-10 15:25:07 -05:00
Tim Donohue
8c05914c04 Fix CommunityRestRepositoryIT tests that were not cleaning up after themselves 2019-05-10 15:25:07 -05:00
Tim Donohue
379968d12c Migrate existing OAI IntegrationTests to OAIpmhIT class in Spring Boot. Disable existing ITs (will be removed) 2019-05-10 15:01:48 -05:00
Tim Donohue
805e35743b Enhance inline comments in application.properties 2019-05-10 15:01:48 -05:00
Tim Donohue
f782a1ca3e OAI fixes: Update JTwig for compatibility with Spring Boot. Ensure static files are loaded properly 2019-05-10 15:01:48 -05:00
Tim Donohue
7c83a58a20 Minor bug fix to OAI-PMH found via ITs in previous commit 2019-05-10 15:01:48 -05:00
Tim Donohue
89400609aa Embed OAI-PMH into Boot webapp. Add basic ITs to prove it works. 2019-05-10 15:01:48 -05:00
Tim Donohue
cb86effb38 Correct comments to be more accurate 2019-05-10 15:01:48 -05:00
Tim Donohue
27512ad382 Correct location of SWORD ITs 2019-05-10 15:01:48 -05:00
Tim Donohue
06f8a2a6e2 More ITs for SWORDv2. Ensure all SWORDv2 endpoints have a sanity test. 2019-05-10 15:01:48 -05:00
Tim Donohue
ca5ac68e2d Embed SWORDv2 into Boot webapp. Add basic IT to prove it works. 2019-05-10 15:01:48 -05:00
Tim Donohue
46a50aeded Add basic validation tests for all SWORDv1 endpoints 2019-05-10 15:01:47 -05:00
Tim Donohue
6f51195e6c Ensure SWORD integration tests only run if SWORDWebConfig is loaded 2019-05-10 15:01:47 -05:00
Tim Donohue
56f7cb11bc Remove maven-war-plugin from SWORD POM. It's not needed anymore 2019-05-10 15:01:47 -05:00
Tim Donohue
8e3d12a34d Add basic Integration Tests for SWORDv1 endpoint using new AbstractWebClientIntegrationTest 2019-05-10 15:01:47 -05:00
Tim Donohue
adf68447e1 Make SWORD module configurable via sword-server.cfg. Remove obsolete web.xml 2019-05-10 15:01:47 -05:00
Tim Donohue
fa61b737db Refactor Application startup to load DSpace configs early in boot process. Also fixes DS-3492 2019-05-10 15:01:47 -05:00
Tim Donohue
7f3877c7bc Create SWORDWebConfig to replace SWORD's web.xml. Fix compilation error in servlet 2019-05-10 15:01:47 -05:00
Tim Donohue
1b143aa5cd Change SWORDv1 to a JAR dependency. Add as RESTv7 dependency 2019-05-10 15:01:47 -05:00
Tim Donohue
af16e6e780 Remove SWORD overlay folders/files 2019-05-10 15:01:47 -05:00
Tim Donohue
5eb338d9b7 Update RESTv7 to ComponentScan for webapp configs under org.dspace.app.configuration 2019-05-10 15:01:47 -05:00
Tim Donohue
f1073f0af0 Update RESTv7 to only use Spring Security on /api path 2019-05-10 15:01:47 -05:00
Mark H. Wood
27d811f5e5 [DS-3953] Add new data for configurable entities. 2019-05-10 11:55:19 -04:00
Mark H. Wood
b72c4218f4 [DS-3953] Expose list of metadata namespace files as configuration. 2019-05-10 11:55:19 -04:00
Tim Donohue
8f472d9197 Merge pull request #2376 from DSpace/configurable_entities
Adding Configurable "Entities" to DSpace 7 (Part 1: Architecture, Configuration, Search, Display)
2019-05-09 15:56:41 -05:00
Tim Donohue
ba267ce72b Merge pull request #2422 from atmire/entities-feedback-2019-05-07
Entities feedback 2019 05 07
2019-05-09 12:54:03 -05:00
Tim Donohue
be4c2f9ad5 Merge branch 'configurable_entities' into entities-feedback-2019-05-07 2019-05-09 12:09:42 -05:00
Tim Donohue
8097589db5 Merge pull request #2418 from atmire/entities-feedback-2019-04
Configurable entities feedback
2019-05-09 12:01:37 -05:00
Ben Bosman
858bf72fa9 Merge remote-tracking branch 'origin/w2p-62187_IT-changes' into entities-feedback-2019-05-07
# Conflicts:
#	dspace-spring-rest/src/test/java/org/dspace/app/rest/RelationshipRestRepositoryIT.java
2019-05-08 16:47:16 +02:00
Raf Ponsaerts
b76aacc626 Added the expect status code in test 2019-05-08 16:23:01 +02:00
Raf Ponsaerts
5c035fe6a6 Refacted the RelationshipRestRepositoryIT to now use a builder instead of the EPersonService when creating a user 2019-05-08 13:12:14 +02:00
Ben Bosman
be9d80c410 Temporarily disabled for https://github.com/DSpace/Rest7Contract/pull/57#discussion_r272605397 2019-05-07 19:54:20 +02:00
Ben Bosman
3f42590fb2 Temporarily disabled for https://github.com/DSpace/Rest7Contract/pull/57#discussion_r272605397 2019-05-07 18:52:58 +02:00
Ben Bosman
5895f08337 Temporarily disabled for https://github.com/DSpace/Rest7Contract/pull/57#discussion_r272605397 2019-05-07 18:27:51 +02:00
Ben Bosman
b5e29a36b8 reordered tests to first verify the normal import, and hereafter verify updating (for logic while reading the IT) 2019-05-07 17:48:38 +02:00
Ben Bosman
bee7313f8a Merge remote-tracking branch 'origin/w2p-62146_initialize-entities-it-changes' into entities-feedback-2019-05-07 2019-05-07 17:47:04 +02:00
Mark H. Wood
1458d8f1b2 [DS-1443] Define required "options" as required; ensure that usage output is flushed. 2019-05-07 11:00:58 -04:00
Raf Ponsaerts
b98943ff64 Fixed checkstyle 2019-05-07 10:32:35 +02:00
Raf Ponsaerts
71cd11b558 Implemented the InitializeEntitiesIT changes 2019-05-07 09:59:32 +02:00
Raf Ponsaerts
aac6b12de9 Additional pagination tests 2019-05-07 09:19:48 +02:00
Mark H. Wood
2a914e1499 [DS-1443] Recreate this patch atop current (7x) master. 2019-05-06 16:18:53 -04:00
Raf Ponsaerts
a3334bd10e Added inline comments to the RelatinshipRestRepositoryIT 2019-05-06 15:48:38 +02:00
Kevin Van de Velde
5006653277 [DS-4239] Migrate the workflow.xml to spring 2019-05-03 12:10:06 +02:00
benbosman
4ccf73ebb6 Merge pull request #2414 from atmire/entities-feedback-2019-04-29
feedback on configurable entities
2019-05-02 17:10:46 +02:00
benbosman
cd8226cc97 Merge pull request #2419 from atmire/w2p-62057_configurable-entities-feedback
configurable entities feedback
2019-05-02 17:10:03 +02:00
Andrea Bollini
8556441f43 DS-4210 fix the bug (still problems on the test) 2019-05-02 16:03:42 +02:00
Raf Ponsaerts
6e21bcdad1 Implemented feedback 2019-05-02 15:08:08 +02:00
Andrea Bollini
eedd6ed36d DS-4210 demonstate the bug: Deposit on collection without workflow seems to fail (405 but succeed) 2019-05-02 14:27:51 +02:00
Raf Ponsaerts
4c6e939e57 Implemented feedback 2019-05-02 13:26:30 +02:00
Raf Ponsaerts
7dfd34036c Implemented feedback 2019-04-30 15:51:28 +02:00
Andrea Bollini
fc05d2dab0 Merge pull request #2411 from atmire/refactoring-instanceof
Small improvements to configurable entities
2019-04-30 09:59:40 +02:00
Ben Bosman
62ca358f33 support for displaying an org unit as author of a publication 2019-04-29 18:15:14 +02:00
Ben Bosman
9a40fd817c store place in relation virtual metadata 2019-04-29 17:59:38 +02:00
Ben Bosman
ccbf681f96 feedback on configurable entities 2019-04-29 15:42:57 +02:00
Ben Bosman
20705e1da1 feedback on configurable entities 2019-04-29 11:54:29 +02:00
Ben Bosman
6707dfb2e6 feedback on configurable entities 2019-04-29 11:50:45 +02:00
benbosman
0bb9880d2c Merge pull request #2413 from atmire/override
override
2019-04-29 11:44:19 +02:00
Ben Bosman
70e34edfef override 2019-04-29 11:13:55 +02:00
Mark H. Wood
3789b36ff5 [DS-3695] Add a tool to correct statistics core exports by supplying missing 'uid' values. 2019-04-26 15:03:38 -04:00
Tim Donohue
51aa22cdb9 Merge pull request #2409 from atmire/rename-VirtualBean-VirtualMetadataPopularConfiguration
Rename virtual bean virtual metadata configuration
2019-04-26 10:44:16 -05:00
Ben Bosman
8f56970c33 order of imports 2019-04-26 09:34:37 +02:00
Ben Bosman
09c9d851a5 JavaDoc 2019-04-26 09:32:29 +02:00
Ben Bosman
b331b26f80 Avoid creating a new context 2019-04-25 17:01:23 +02:00
Ben Bosman
b2d28fcf83 Avoid creating a new context 2019-04-25 16:44:16 +02:00
Ben Bosman
7b9f08e7ad JavaDoc 2019-04-25 15:52:57 +02:00
Ben Bosman
658708832a Missing @Override 2019-04-25 15:48:30 +02:00
Ben Bosman
dcf9240f42 Refactoring instanceof 2019-04-25 15:45:24 +02:00
benbosman
d1cd9c4a9b Merge pull request #2408 from atmire/Missing-override
Missing @Override
2019-04-25 15:35:23 +02:00
Ben Bosman
ec8109a67e Missing @Override 2019-04-25 15:34:44 +02:00
Ben Bosman
5a69301212 Rename VirtualBean to VirtualMetadataPopularConfiguration 2019-04-25 15:15:39 +02:00
Ben Bosman
72afed29b8 Rename VirtualBean to VirtualMetadataPopularConfiguration 2019-04-25 15:01:11 +02:00
Ben Bosman
07ce7da613 Merge remote-tracking branch 'community/configurable_entities' into configurable_entities 2019-04-25 14:37:23 +02:00
Ben Bosman
0898e33319 An additional use case in the comments 2019-04-25 14:36:53 +02:00
benbosman
bba8feff5b Merge pull request #2407 from atmire/w2p-62018_update-configurable_entities-with-master
update configurable entities with master
2019-04-25 14:06:34 +02:00
Raf Ponsaerts
d97ea343e4 Merged dspace/master into dspace/configurable_entities 2019-04-25 13:30:25 +02:00
Tim Donohue
afc6682bfb Merge pull request #2391 from 4Science/DS-4166_mydspace
DS-4166 Index workspace, workflow and tasks in SOLR
2019-04-24 10:03:35 -05:00
Tim Donohue
1bf1131237 Merge pull request #2404 from atmire/w2p-61912_initialize-entities-update
DS-4218 - Support for second "initialize-entities"
2019-04-24 10:02:27 -05:00
Ben Bosman
c83ae49e7f Feedback on PR-2404
Missing context complete, this was lost in the previous commit from this PR
2019-04-24 09:50:11 +02:00
Tim Donohue
b30e1cc6f9 Merge pull request #2216 from tomdesair/DS-4006_EPerson-Group-Relation-and-Embeds
DS-4006: Embed membership groups on EPerson REST object
2019-04-23 16:23:53 -05:00
benbosman
fe0a67ca43 Merge pull request #15 from AlexanderS/w2p-61912_initialize-entities-update
Small indentation fix
2019-04-18 12:54:41 +02:00
Alexander Sulfrian
f8b0eac67a Fix indentation 2019-04-18 12:15:17 +02:00
Raf Ponsaerts
22b297b207 Added IT for the updated InitializeEntities script 2019-04-18 08:47:33 +02:00
Raf Ponsaerts
cfd4e0b435 Updated the InitializeEntities implementation and added a unique constraint to RelationshipType table based on types and labels 2019-04-17 13:41:24 +02:00
Andrea Bollini
5338a88892 DS-4166 community feedback: postpone support for highlighting over authority controlled metadata 2019-04-16 22:37:02 +02:00
Tim Donohue
fada353a06 Checkstyle fix 2019-04-16 13:00:39 -05:00
Tim Donohue
0065bd4950 Update version of Handle dependency 2019-04-16 12:10:49 -05:00
Tim Donohue
b0bff18b53 Merge pull request #2257 from mspalti/eperson_update
[DS-4062] Endpoint to allow logged in EPerson to change password or other profile information.
2019-04-15 16:08:21 -05:00
Michael W Spalti
4fe26b914e [DS-4062] Updated task and workflow plugins to implement the new permission method. 2019-04-12 17:15:20 -07:00
Michael W Spalti
ca02d36933 [DS-4062] Added support for eperson updates by the currently logged in user.
Removed misplaced factory call.

Removed misplaced factory call.

Added exception and updated signature for the eperson repository patch method.

Removed patch endpoint from the authentication controller and modifed eperson repository to use Spring PreAuthorize annotation and the eperson permission evaluator plugin.

[DS-4062] Removed unused autowired bean from DSpaceRestRepository.

No longer needed after the previous refactor to remove endpoint.

[DS-4062] Removed unused import.

[DS-4062] The EPersonRestRepository updated to hasPermission annontation only.

Also limiting (experimentally) some eperson patch operations to administrators.

Added adminstartor restriction for netid patch operation.

Removed support for patching eperson profile metadata.

Removed support for patching eperson profile metadata.

Added eperson email patch operation.

Updated permission plugins to support patch requests per suggestion by @tomdesair.

Updated eperson authentication plugin and added unit test.

Added the new PreAuthorize annotations for patch.

Added the missing header reported by checkstyle.

Changed order of static imports in unit test to pass checkstyle.

Added integration test to verify that a non-admin user cannot update another eperson password.
2019-04-12 16:25:37 -07:00
benbosman
489ed8350b Merge pull request #2401 from atmire/entities-feedback
Entities feedback
2019-04-09 17:25:32 +02:00
Ben Bosman
62c0f0714d Feedback on PR-2376 2019-04-09 16:01:56 +02:00
Mark H. Wood
9a1124809c [DS-3823] Simple CLI tool to display cache layout and some settings. 2019-04-09 09:40:29 -04:00
Ben Bosman
a23a8821e6 Feedback on PR-2376 2019-04-09 15:16:17 +02:00
benbosman
2ed91c616c Merge pull request #2400 from atmire/w2p-61605_move-virtual-metadata-to-separate-spring-file
Moved the virtual metadata populator xml logic to a separate file
2019-04-09 15:04:13 +02:00
Raf Ponsaerts
750bdecbc0 Moved the virtual metadata populator xml logic to a separate file 2019-04-09 14:16:37 +02:00
Andrea Bollini
84eabcbf91 DS-4166 community feedback: renamed FindableObjectService in IndexableObjectService 2019-04-09 11:50:02 +02:00
benbosman
b0c6b912b3 Merge pull request #2399 from atmire/w2p-61536_update-configurable-entities-with-latest-master
update configurable entities with latest master
2019-04-08 17:12:27 +02:00
Raf Ponsaerts
92cb9730fb Changed the URI parsing to better fit a generic approach on Repository level 2019-04-08 16:16:13 +02:00
Raf Ponsaerts
4f3885738a Fixed tests and refactored the way priorities work in the builders 2019-04-08 14:56:23 +02:00
Mark H. Wood
b9ca1deb42 [DS-3823] Give distinct names to the services and Hibernate cache managers. 2019-04-05 16:55:28 -04:00
Raf Ponsaerts
4fc6ebc28c Intermediary Commit 2019-04-05 15:46:18 +02:00
Raf Ponsaerts
211e8f72a1 Merged dspace/master into configurable_entities 2019-04-05 13:45:01 +02:00
Andrea Bollini
f8cedefa29 DS-4166 community feedback: improved javadocs and comments 2019-04-05 13:30:36 +02:00
Andrea Bollini
20a0e42098 DS-4166 fix configuration of the submitter facet 2019-04-05 08:46:15 +02:00
Andrea Bollini
d23ebd66c0 DS-4166 fix configuration of the namedresourcetype facet 2019-04-04 15:53:18 +02:00
Andrea Bollini
504cb3c5cf DS-4166 community feedback: merge -i and -item_uuid options 2019-04-04 13:09:02 +02:00
Andrea Bollini
6fd5a76837 DS-4166 community feedback: code cleanup 2019-04-04 12:56:55 +02:00
Tim Donohue
e17e8eea08 Merge pull request #2388 from atmire/configurable_entities
DS-4121: Refactor Entities ITs
2019-04-02 10:23:05 -05:00
Ian Little
12e7178220 Merge branch 'master' into DS-1477-update-handle-server 2019-04-02 11:15:15 -04:00
Mark H. Wood
4a5ea2913d [DS-3695] Another OAI date field needs formatting. 2019-04-01 15:11:39 -04:00
Mark H. Wood
57e076e781 [DS-3695] Remove unused dynamicField definitions. 2019-04-01 14:24:29 -04:00
Mark H. Wood
be8fe275fd [DS-3695] Fields indexed as dates need formatting as Solr expects. 2019-04-01 13:58:24 -04:00
Alexander Sulfrian
8b1a75d309 IPMatcher: Add test to verify parsing of netmask 2019-04-01 18:49:27 +02:00
Tim Donohue
1e6497f1d6 Merge pull request #2379 from AndrewZWood/DS-4194
DS-4194 Use lazy fetching iterator for long query results
2019-03-29 15:08:25 -05:00
Ian Little
d2f8db798f Fix hostip issue in make-handle-config script. 2019-03-29 14:48:21 -04:00
Ian Little
f845e5fbcd Include optional handle dependency that is needed for running the server. 2019-03-29 14:47:54 -04:00
Ian Little
d17a9072d4 Update Handle server version. 2019-03-29 10:42:38 -04:00
Tim Donohue
77928c2560 Add info about how/when auto-reindexing takes place 2019-03-28 12:57:02 -04:00
Andrew Wood
0324787e35 DS-3658 Document new property reflect default behavior in value 2019-03-28 12:57:02 -04:00
Andrew Wood
2dd14a06ba DS-3658 Configure ReindexerThread disable reindex 2019-03-28 12:57:02 -04:00
Andrea Bollini
5e3164bd06 DS-4166 community feedback: use a more appropriate exception 2019-03-28 15:38:39 +01:00
Andrea Bollini
8de7a50f5b DS-4166 community feedback: report about not existing uuid 2019-03-28 15:20:49 +01:00
Andrea Bollini
a8190fe27a DS-3851 add test and fix for invalid task claiming 2019-03-28 14:42:03 +01:00
Andrea Bollini
30899b0e55 DS-4166 move IndexableObject to the discovery package 2019-03-28 13:20:47 +01:00
Andrea Bollini
eba97f4080 Merge branch 'master' of https://github.com/DSpace/DSpace into mydspace_clean 2019-03-28 13:15:21 +01:00
Alexander Sulfrian
d8ca94d304 IPMatcher: Fix netmask conversion 2019-03-28 12:16:25 +01:00
Andrea Bollini
689ac4e3bd DS-4166 community feedback: implement the IndexableObject interface only where really needed 2019-03-28 12:06:22 +01:00
Yana De Pauw
b71b6e9f1b Fix check style issues in RelationShipTypeBuilder 2019-03-28 11:13:35 +01:00
Andrea Bollini
1252075ac9 DS-4166 community feedback: remove multithreads indexing support 2019-03-28 09:02:58 +01:00
Andrea Bollini
cc11f49556 DS-4166 community feedback: remove unused methods and configurations 2019-03-28 09:02:16 +01:00
Andrea Bollini
272f21a8dd DS-4166 community feedback: improve documentation 2019-03-28 00:22:43 +01:00
Andrea Bollini
006b938c4a DS-4166 community feedback: use dedicated fields for workspace/workflow searches 2019-03-28 00:09:13 +01:00
Andrea Bollini
d25463fedb Merge pull request #2312 from 4Science/DS-3851_workflow_new
DS-3851 Endpoint to interact with the workflow
2019-03-28 00:05:08 +01:00
Andrea Bollini
15f6ced31a DS-3851 community feedback: typo 2019-03-27 22:43:30 +01:00
Andrea Bollini
b98d8f4d21 DS-4166 community feedback: rename resultObject to indexableObject in the discover REST result 2019-03-27 20:51:01 +01:00
Andrea Bollini
4b85bf4c56 DS-4166 community feedback: rename BrowsableObject to IndexableObject 2019-03-27 20:31:22 +01:00
Yana De Pauw
13ce03c8c7 Refactor Entity ITs to not use the xml file but builders 2019-03-27 13:19:28 +01:00
benbosman
85480b9ec7 Merge pull request #2383 from atmire/Feedback-PR-2376
Feedback on PR-2376
2019-03-26 13:00:18 +01:00
Andrea Bollini
8c28d5136e DS-3851 community feedback: deal properly with wrong requests 2019-03-26 12:56:48 +01:00
Ben Bosman
b828e56bb8 Squashed feedback on PR-2376 2019-03-25 14:10:28 +01:00
Tim Donohue
7f2e696949 Merge remote-tracking branch 'upstream/master' into configurable_entities 2019-03-22 19:54:03 +00:00
Terry Brady
0cc2226b25 Merge pull request #2373 from the-library-code/DS-4189
DS-4189 Enhance configuration by environment variables
2019-03-22 15:48:10 -04:00
Tim Donohue
f56996634b Merge branch 'master' into configurable_entities 2019-03-22 19:12:19 +00:00
Terry Brady
aa2a5f8b6e Update config-definition.xml 2019-03-22 15:12:14 -04:00
Tim Donohue
a857932393 Merge pull request #2058 from mwoodiupui/DS-3695
[DS-3695] Upgrade Solr to 7.3.1.
2019-03-22 10:47:43 -05:00
Mark H. Wood
62928cedb6 [DS-3695] Remove unused 'solr.server.version' POM property. 2019-03-22 11:20:47 -04:00
Terry Brady
808f04852b Update DSpaceEnvironmentConfiguration.java 2019-03-21 14:34:35 -04:00
Terry Brady
a39495bef5 Add replacement for dash and dot 2019-03-21 14:13:32 -04:00
Andrew Wood
51cd8fa46a DS-4194 Use lazy fetching iterator for long query results 2019-03-20 16:29:22 -04:00
Pascal-Nicolas Becker
1cfc53db5c DS-4189 Enhance configuration by environment variables 2019-03-18 02:22:23 +01:00
Andrea Bollini
5d997e6cde DS-3851 manually solve unnoted merge conflict 2019-03-15 22:21:45 +01:00
Andrea Bollini
1df2d35c1f Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3851_workflow_new 2019-03-15 22:05:53 +01:00
Tim Donohue
b4e7d62725 Merge pull request #2375 from atmire/w2p-61144_place-in-metadata
Configurable Entities - Item metadata place
2019-03-15 11:48:10 -05:00
Tim Donohue
828861a871 Merge pull request #2331 from atmire/w2p-58898_place-column-calculation-error
Mixing entities and plain-text values
2019-03-15 10:58:34 -05:00
Raf Ponsaerts
00a4863178 Removed the jsonIgnore from place attribute in MetadataValueRest and fixed IT 2019-03-15 14:34:29 +01:00
benbosman
02d8e5f750 Merge pull request #13 from atmire/w2p-58898_place-column-calculation-error-prepare-merge
W2p 58898 place column calculation error prepare merge
2019-03-15 13:56:39 +01:00
Raf Ponsaerts
9678dbf573 Merged configurable_entities into w2p-58898_place-column-calculation-error-prepare-merge 2019-03-15 13:27:24 +01:00
Andrea Bollini
eee2929e51 DS-3851 remove unused import 2019-03-15 00:42:16 +01:00
Andrea Bollini
b481fbae17 DS-3851 community feedback: remove unused variable 2019-03-14 23:57:25 +01:00
Andrea Bollini
19606943b1 DS-3851 community feedback: code cleanup 2019-03-14 23:49:35 +01:00
Raf Ponsaerts
13f9c8e1e5 Merged dspace/master into w2p-58898_place-column-calculation-error-prepare-merge 2019-03-14 15:08:42 +01:00
Tim Donohue
7e4e22d472 Merge pull request #2367 from tdonohue/coveralls-refactor
Refactor Coveralls.io plugin to only run after successful build/test in Travis CI
2019-03-13 16:19:48 -05:00
Tim Donohue
b891f3190d Merge pull request #2208 from atmire/DS-4014_CORS-headers-missing-when-generic-exception-is-thrown
[DS-4014] added a catch in the DSpaceApiExceptionControllerAdvice for…
2019-03-13 14:38:14 -05:00
Tim Donohue
c87cd80ac3 Merge pull request #2372 from atmire/configurable_entities-prepare-for-merge
Configurable entities prepare for merge
2019-03-13 10:23:50 -05:00
Raf Ponsaerts
65fb4674a0 Merged master into configurable_entities-prepare-for-merge 2019-03-13 14:34:13 +01:00
Raf Ponsaerts
970b66edb2 Applied feedback; implemented context authorisation logic in tests 2019-03-13 13:10:49 +01:00
Andrea Bollini
3e22142aa7 DS-3851 cleanup the BrowsableObject interface 2019-03-12 23:31:17 +01:00
Andrea Bollini
e883c95de8 DS-3851 cleanup the BrowsableObject interface 2019-03-12 22:17:22 +01:00
Tim Donohue
e48fef5f62 Merge pull request #2332 from atmire/w2p-57159_permission-to-create-relations
Relationship CRUD
2019-03-12 08:17:13 -05:00
Tim Donohue
39e04c2223 Refactor Coveralls plugin to only run after successful build/test. Build can be limited to one step, too. 2019-03-11 19:09:13 +00:00
Tim Donohue
efbffe4ea5 Merge pull request #2313 from atmire/DS-3908_Metadata_patch_support
DS-3908 Metadata patch support
2019-03-08 11:38:08 -06:00
Chris Wilper
337daef738 DS-3908 Restore authz state as early as possible in tests 2019-03-07 12:32:23 -05:00
Chris Wilper
2171b7ff83 DS-3908 Address minor checkstyle issues 2019-03-07 10:35:17 -05:00
Chris Wilper
21fe803b53 DS-3908 Restore auth system state where appropriate 2019-03-07 09:59:19 -05:00
Chris Wilper
96d544d075 DS-3908 Improve javadocs 2019-03-07 09:54:24 -05:00
Andrea Bollini
000c47e7a3 DS-3851 demostrate that admins cannot manipulate tasks 2019-03-07 15:28:55 +01:00
Chris Wilper
229b9f1039 Merge branch 'master' into DS-3908_Metadata_patch_support 2019-03-07 08:32:57 -05:00
Andrea Bollini
cae9a6baa8 DS-4166 fix converter for authority based filter 2019-03-07 09:17:44 +01:00
Andrea Bollini
499fdcd61c DS-4166 renamed BrowsableDSpaceObject in BrowsableObject 2019-03-07 01:11:14 +01:00
Andrea Bollini
6a5838461a Merge branch 'DS-3851_workflow_new' of https://github.com/4Science/DSpace into DS-4166_mydspace 2019-03-07 00:49:46 +01:00
Andrea Bollini
0a54d4cf1e DS-3851 Add ITs for unauthorized approve/reject and improve error handling 2019-03-06 23:54:40 +01:00
Andrea Bollini
1c0e29bc64 DS-3851 raise events in the service layer 2019-03-06 22:44:25 +01:00
Andrea Bollini
a596a5cabf DS-3851 use MediaTypes constant from spring 2019-03-06 22:42:44 +01:00
Andrea Bollini
23bbf45048 DS-3851 remove unused methods 2019-03-06 22:13:26 +01:00
Andrea Bollini
d751d5dc59 DS-3851 add fixme to remember the need to remove getWorkflow group methods 2019-03-06 22:13:09 +01:00
Andrea Bollini
65d3495e18 DS-3851 raise events in the service layer 2019-03-06 19:36:24 +01:00
Andrea Bollini
15c4a33d77 DS-3851 add fixme notice for future refactoring of the uri-list processing 2019-03-06 19:35:36 +01:00
Andrea Bollini
ef10d47156 DS-3851 Add native support for pagination in the findBySubmitter 2019-03-06 18:00:30 +01:00
Andrea Bollini
434c0fa748 DS-3851 add IT to pass through a whole workflow 2019-03-06 17:04:25 +01:00
Andrea Bollini
4475eca5b2 DS-3851 code cleanup: community feedback 2019-03-06 15:51:00 +01:00
Raf Ponsaerts
6056bf94e0 Added the comment to the context.turnOffAuthorizationSystem 2019-03-06 14:54:01 +01:00
Raf Ponsaerts
e3fc9a52a7 Merge branch 'w2p-57159_permission-to-create-relations' into w2p-58898_place-column-calculation-error 2019-03-06 14:46:40 +01:00
Tom Desair
aa0a2a3b05 Remove unused import 2019-03-06 08:17:49 +01:00
Tom Desair
10fc1afaa3 Fix ignored delete EPerson test 2019-03-05 23:36:44 +01:00
Tom Desair
bfc91292d2 DS-4014: Correct status code for AccessDeniedException with authorized users 2019-03-05 23:35:49 +01:00
Raf Ponsaerts
15faacc70c [DS-4014] changed the exception handling to now look for the ResponseStatus on the Exception Class, if it doesn't exist we simply return a 500. AccessDeniedException does not have a ResponseStatus annotation but it has to be handled correctly, therefor a specific catch clause is required 2019-03-05 23:13:14 +01:00
Raf Ponsaerts
df1e464939 [DS-4014] fixed tests and added more exception catches 2019-03-05 23:13:14 +01:00
Raf Ponsaerts
7c122e55aa [DS-4014] added a catch in the DSpaceApiExceptionControllerAdvice for a generic exception and throws a 500 with cors headers available 2019-03-05 23:13:14 +01:00
Tom Desair
0961c5040d DS-4006: Added explicit check for "groups" link in Group Rest object 2019-03-05 22:36:13 +01:00
Tom Desair
aef31c8d37 DS-4006: Embed membership groups on EPerson REST object 2019-03-05 22:11:46 +01:00
Terry Brady
d7ec9e537a Merge pull request #2348 from Georgetown-University-Libraries/ds4167
[DS-4167] Migrate update-sequences.sql to `database` command
2019-03-05 10:56:44 -08:00
Raf Ponsaerts
033790e1b2 Added missing context.restoreAuthSystemState 2019-03-05 14:17:08 +01:00
Andrea Bollini
7f94383719 DS-4166 Fix SearchMatcher to be more strict 2019-03-03 22:12:49 +01:00
Andrea Bollini
e929c39fb2 DS-4166 add ITs for workspace/workflow discover configuration 2019-03-03 19:51:57 +01:00
Giuseppe
d5b4963e26 Update submission-forms.xml
Replaced twobox field with tag field
2019-02-28 17:31:09 +01:00
Andrea Bollini
b3423770dd DS-4166 restore official name to the configuration parameter 2019-02-28 15:56:45 +01:00
Mark H. Wood
999e912909 Merge pull request #2180 from mwoodiupui/DS-3989
[DS-3989] Always capture curation task output.
2019-02-27 16:12:07 -05:00
Andrea Bollini
9d378143a1 DS-4166 restore code removed by incident rebasing the PR 2019-02-26 14:47:51 +01:00
Chris Wilper
185766d8d2 DS-3908 Add DSO metadata PATCH tests 2019-02-25 19:26:40 -05:00
Chris Wilper
1ad0c88c3c DS-3908 Add PATCH support for DSO metadata 2019-02-25 19:26:40 -05:00
Terry Brady
4b6611353f Merge pull request #2354 from Georgetown-University-Libraries/ds4173
[DS-4173] Docker build - set build dir owner to dspace
2019-02-25 14:35:08 -08:00
Terry Brady
644970eba4 set build dir owner to dspace 2019-02-25 08:38:18 -08:00
Andrea Bollini
ff298b393f DS-4166 fix existing discover tests 2019-02-25 10:03:15 +01:00
Andrea Bollini
c56e41aec2 DS-4166 Index workspace, workflow and tasks in SOLR 2019-02-25 10:03:15 +01:00
Andrea Bollini
1e3e37d11e DS-3851 code cleanup: community feedback 2019-02-24 21:06:52 +01:00
Andrea Bollini
b0f8f828b7 Fix issue with the Builder comparator and cleanup of workflowgroups 2019-02-24 19:36:40 +01:00
Andrea Bollini
b7b3a74f85 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3851_workflow_new 2019-02-24 16:41:52 +01:00
Andrea Bollini
5b98f05e70 DS-3851 fix priority of Metadata Schema and MetadataField builder 2019-02-24 15:37:14 +01:00
Andrea Bollini
7ad47ad705 DS-3851 code cleanup: community feedback 2019-02-24 15:29:23 +01:00
Andrea Bollini
4858aa75d2 DS-3851 fix bugs discovered by ITs 2019-02-24 14:22:10 +01:00
Andrea Bollini
dbddc2f06a DS-3851 add ITs for the task repositories endpoints 2019-02-24 14:21:16 +01:00
Andrea Bollini
ea2ce38677 max upload must be set in the application.properties 2019-02-23 22:33:00 +01:00
Tim Donohue
cc21394276 Merge pull request #2287 from atmire/DS-4107_Metadata_as_map
DS-4107 Represent DSO metadata as a map in REST
2019-02-21 14:17:30 -06:00
Andrea Bollini
8c0a94e689 DS-3851 add ITs for the workflowitems endpoint 2019-02-21 15:52:10 +01:00
Andrea Bollini
3c8186e7c0 typo in the comment 2019-02-21 15:11:06 +01:00
Andrea Bollini
3c9626a5ef DS-3851 force a predictable order to simplify testing 2019-02-21 15:10:23 +01:00
Andrea Bollini
9f44be85a3 Allow to configure max upload 2019-02-21 15:07:54 +01:00
Raf Ponsaerts
800f254677 Merge branch 'w2p-57159_permission-to-create-relations' of https://github.com/atmire/DSpace into w2p-57159_permission-to-create-relations 2019-02-21 09:21:52 +01:00
Raf Ponsaerts
65a94cdda7 Implemented an IT for the text/uri-list parsing 2019-02-21 09:21:11 +01:00
Andrea Bollini
70091e59b8 DS-3851 partially remove legacy workflow to simplify testing
First tests for the workflow endpoint
2019-02-20 23:11:04 +01:00
Terry Brady
ac83a4edef Merge pull request #2344 from terrywbrady/ds4126m
[DS-4126] master: Optimize docker builds
2019-02-20 13:16:01 -08:00
Chris Wilper
0609a6f0b7 DS-4107 Improve javadocs 2019-02-20 14:48:24 -05:00
Chris Wilper
60ea589296 DS-4107 Represent DSO metadata as a map in REST 2019-02-20 14:48:20 -05:00
Terry Brady
35ca48e17a Merge pull request #15 from mwoodiupui/DS-4167
[DS-4167] Fix various problems with Oracle script.
2019-02-20 09:02:11 -08:00
Terry Brady
653bfceac8 Merge branch 'ds4167' into DS-4167 2019-02-20 09:02:00 -08:00
Terry Brady
35e98f0d4b v1 oracle sql 2019-02-20 08:40:34 -08:00
Ben Bosman
1989cd9ff4 JavaDoc 2019-02-20 17:26:43 +01:00
Mark H. Wood
3302835650 [DS-4167] Fix various problems with Oracle script. 2019-02-20 11:23:21 -05:00
Raf Ponsaerts
91caed0cf6 Refactored tests 2019-02-20 14:39:32 +01:00
Raf Ponsaerts
a0ebd616f2 Processed feedback 2019-02-20 13:11:39 +01:00
Raf Ponsaerts
7f194dfa95 Applied feedback 2019-02-20 11:28:34 +01:00
Raf Ponsaerts
53580fa228 Merged w2p-57159_permission-to-create-relations into w2p-58898_place-column-calculation-error 2019-02-20 09:31:40 +01:00
Terry Brady
7773b46aca update sql 2019-02-19 10:16:21 -08:00
Terry Brady
89c1cc7729 remove /org 2019-02-19 07:34:56 -08:00
Terry Brady
f829b7df5a remove dspace/etc from build steps 2019-02-19 07:11:23 -08:00
Terry Brady
4ac06271c8 attempt to fix headers 2019-02-19 06:53:30 -08:00
Terry Brady
22cc5469a2 simplify string extract from stream 2019-02-19 06:30:25 -08:00
Terry Brady
5f47771e4e remove /etc directory 2019-02-19 06:26:28 -08:00
Terry Brady
e421a7c7c7 apply review feedback 2019-02-19 06:26:12 -08:00
Andrea Bollini
d3d3b57133 DS-3802 switch to the local LateObjectEvaluator 2019-02-19 08:48:39 +01:00
Andrea Bollini
c7c204091f Revert "Rely on Spring LateObjectEvaluator instead than our custom porting"
This reverts commit 821d106439.
2019-02-19 08:24:17 +01:00
Raf Ponsaerts
37c3ab9e17 Applied feedback 2019-02-18 09:23:39 +01:00
Terry Brady
b6f73682a3 Migrate postgres update-sequences.sql 2019-02-15 15:33:39 -08:00
Mark H. Wood
59bf702500 [DS-3695] Record string value of object ID in usage statistics. 2019-02-15 14:08:18 -05:00
Mark H. Wood
501ea5b6a6 Revert "[DS-3695] Add missing query defaults in a method I overlooked."
This reverts commit 6ecc3b2351.
2019-02-15 12:04:15 -05:00
Mark H. Wood
4b59ef27fc Revert "[DS-3695] Replace removed default schema settings with query parameters."
This reverts commit 69fcb0ebce.
2019-02-15 12:01:05 -05:00
Mark H. Wood
0194f557c0 [DS-3695] Re-introduce configured default match operator, since I found to where they moved it. Default search field was already configured. 2019-02-15 11:59:08 -05:00
Mark H. Wood
caf95d5acb Merge pull request #2347 from mwoodiupui/DS-4163-7
[DS-4163] OAI exception on empty list
2019-02-14 13:49:37 -05:00
ssolim
0b12168218 XOAI.java skip empty list and dont add it to solr 2019-02-14 13:24:46 -05:00
Tim Donohue
44a3111e41 Merge pull request #2291 from atmire/manage_metadata_registry
Manage metadata registry
2019-02-14 11:19:05 -06:00
Andrea Bollini
6dd560bd92 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3851_workflow_new 2019-02-14 15:00:07 +01:00
Mark H. Wood
dd8a7c1fea [DS-3695] Remove commented elements and comments not about DSpace from solrconfig.xml. 2019-02-14 08:57:27 -05:00
Terry Brady
e6860e3724 Set solr.server to maatch docker config 2019-02-13 12:29:22 -08:00
Mark H. Wood
01b9707347 [DS-3695] Placate the style checker, and simplify a try block. 2019-02-13 14:39:11 -05:00
Mark H. Wood
8c971d9acd [DS-3695] Solr UUID field wants a *String* value. 2019-02-13 13:56:37 -05:00
Mark H. Wood
6ecc3b2351 [DS-3695] Add missing query defaults in a method I overlooked. 2019-02-13 13:54:53 -05:00
Mark H. Wood
cd2e6a7878 [DS-3695] Add license boilerplate to new Docker configuration 2019-02-13 12:41:12 -05:00
Mark H. Wood
589b719895 Merge pull request #14 from Georgetown-University-Libraries/mwoodiupui-DS-3695
Dockerfile support for external solr
2019-02-13 11:47:43 -05:00
Mark H. Wood
c1800427bd Merge branch 'DS-3695' into mwoodiupui-DS-3695 2019-02-13 11:39:03 -05:00
Terry Brady
cb3276b02e remove core.properties names 2019-02-13 08:28:33 -08:00
Mark H. Wood
69fcb0ebce [DS-3695] Replace removed default schema settings with query parameters. 2019-02-13 11:27:09 -05:00
Mark H. Wood
732bc7d92f [DS-3695] Tell developers where to find the example schema, for
comments and examples of what you can do here.
2019-02-13 11:27:09 -05:00
Mark H. Wood
e9296ac8a8 [DS-3695] All tests should start with an empty Solr. 2019-02-13 11:27:09 -05:00
Mark H. Wood
cd5911a68f [DS-3695] Add docValues to all *PointField by default to support faceting.
Some of these may be unnecessary, but I don't know on which we facet.
2019-02-13 11:27:09 -05:00
Mark H. Wood
ad50b73fd9 [DS-3695] Give the Solr admin. a clue about the purpose of each core. 2019-02-13 11:27:09 -05:00
Mark H. Wood
70b5d6bf4f [DS-3695] Reintroduce "ignored" fieldType, even though the field is
probably not used.
2019-02-13 11:27:09 -05:00
Mark H. Wood
0fa69a7f09 [DS-3695] Whoops, missed a few Trie*Field references. 2019-02-13 11:27:09 -05:00
Mark H. Wood
3bcb2edd1c [DS-3695] Remove redundant types, irrelevant attributes; tidy layout. 2019-02-13 11:27:09 -05:00
Mark H. Wood
094db7217a [DS-3695] Remove unused "fieldType"s, dusty old comments from stock
sample schema.  Tidy indentation, break very long elements into
multiple lines.
2019-02-13 11:27:09 -05:00
Mark H. Wood
687f04e269 [DS-3695] Rip out big handfuls of unused fieldtypes, commentary about
Solr not DSpace.  Break loooong tags into attribute-per-line format.
2019-02-13 11:27:09 -05:00
Mark H. Wood
0f83c7fe8b [DS-3695] We no longer control Solr's logging. 2019-02-13 11:27:09 -05:00
Mark H. Wood
17ffe721da [DS-3695] See bf4ead40575f0b180fd6840373ef17d98a6e778e. We *do* configure Solr for testing. 2019-02-13 11:27:09 -05:00
Mark H. Wood
bb350ca420 [DS-3695] Upgrade indexes all the way to 7_x. 2019-02-13 11:27:09 -05:00
Mark H. Wood
919ce45338 [DS-3695] We no longer configure Solr itself. 2019-02-13 11:27:09 -05:00
Mark H. Wood
da9d5c7452 [DS-3695] Remaining minimal changes to make all cores load in Solr 7. 2019-02-13 11:27:09 -05:00
Mark H. Wood
bce42a47f6 [DS-3695] Cure failing IT: the test was wrong. 2019-02-13 11:27:09 -05:00
Mark H. Wood
5db8a6a889 [DS-3695] Make 'search' core load in stock Solr 7.2.1.
This should work without altering Solr, across Solr releases, as long
as Solr ships the necessary additional analyzers in /contrib.
2019-02-13 11:27:09 -05:00
Mark H. Wood
38a88d8afb [DS-3695] Start ripping out Solr server. 2019-02-13 11:27:09 -05:00
Mark H. Wood
975ebb0b5b [DS-3695] Document what I puzzled out ot MockSolrServer, and small cleanups. 2019-02-13 11:27:09 -05:00
Tim Donohue
e928b94d07 Fix Solr startup errors by downgrading to 7.3.1 2019-02-13 11:27:09 -05:00
Mark H. Wood
63c43eab15 [DS-3695] Exclude Jetty from solr-core and solr-cell: Solr and Spring
Boot are fighting over versions.
2019-02-13 11:27:09 -05:00
Mark H. Wood
070c21a113 [DS-3695] Switch new class from SolrServer to SolrClient. 2019-02-13 11:27:09 -05:00
Mark H. Wood
e210e3ca35 [DS-3695] Complete botched conflict fixup. 2019-02-13 11:27:09 -05:00
Tim Donohue
0c7f3c0e90 Update to Solr 7.5. Sync dependencies and cleanup spring-rest POM 2019-02-13 11:27:09 -05:00
Tim Donohue
8323ccd051 Disable Solr autoconfiguration in Spring Boot. Minor config cleanup 2019-02-13 11:27:09 -05:00
Tim Donohue
205db5c6f8 Revert Spring Boot updates until DS-3802 is solved. Solr core only for testing. 2019-02-13 11:27:09 -05:00
Tim Donohue
174a77cde0 Fix minor compilation errors in OAI 2019-02-13 11:27:09 -05:00
Mark H. Wood
85c09cbb55 [DS-3695] Start work on dspace-spring-rest 2019-02-13 11:27:09 -05:00
Mark H. Wood
f09287c56b [DS-3695] Rip out lots of Solr config. that is no longer defined in v7. 2019-02-13 11:27:09 -05:00
Mark H. Wood
8a76b77e66 [DS-3695] Upgrade Solr *client* to 7.3.0. 2019-02-13 11:27:09 -05:00
Tim Donohue
db707750fe Merge pull request #2333 from kshepherd/DS-4136_oai_import_master
[DS-4136] Master port: Improve OAI import performance for a large install
2019-02-13 09:15:32 -06:00
Raf Ponsaerts
d450b59899 Applied feedback and added tests 2019-02-13 13:08:30 +01:00
Terry Brady
7115173d61 Support Docker testing of externalized solr 2019-02-12 18:46:02 -08:00
Kim Shepherd
7cde38d229 [DS-4136] Tidy up comments, only display per-1k msg if batch size !1000 2019-02-13 13:03:37 +13:00
Terry Brady
ed41d852b1 Merge branch 'DS-3695' of https://github.com/mwoodiupui/DSpace into mwoodiupui-DS-3695 2019-02-12 14:50:33 -08:00
Mark H. Wood
8c222b9826 [DS-3695] All tests should start with an empty Solr. 2019-02-11 10:59:07 -05:00
Mark H. Wood
6254cedd21 [DS-3695] Add docValues to all *PointField by default to support faceting.
Some of these may be unnecessary, but I don't know on which we facet.
2019-02-08 14:01:16 -05:00
Mark H. Wood
0fc979a2ad [DS-3695] Give the Solr admin. a clue about the purpose of each core. 2019-02-08 11:09:09 -05:00
Raf Ponsaerts
93d982dfc8 Applied feedback and fixed test cases 2019-02-08 09:37:03 +01:00
Tim Donohue
e517ba49a5 English grammar corrections 2019-02-08 09:36:29 +01:00
Tim Donohue
d7c5e224e1 More minor corrections to English 2019-02-08 09:36:29 +01:00
Tim Donohue
d0db6e533a Minor improvements to English in error messages. 2019-02-08 09:36:29 +01:00
Samuel
34127e4e0f Added support for the CRUD operations on the MetadataField and MetadataSchema REST endpoints - feedback 2019-02-08 09:36:29 +01:00
Samuel
0a7a8aab8e Added support for the CRUD operations on the MetadataField and MetadataSchema REST endpoints - feedback 2019-02-08 09:36:28 +01:00
Samuel
42942978a8 Added support for the CRUD operations on the MetadataField and MetadataSchema REST endpoints 2019-02-08 09:36:02 +01:00
Mark H. Wood
be453a0e55 [DS-3695] Reintroduce "ignored" fieldType, even though the field is
probably not used.
2019-02-07 16:23:27 -05:00
Mark H. Wood
77328c388d [DS-3695] Whoops, missed a few Trie*Field references. 2019-02-07 15:44:34 -05:00
Mark H. Wood
13c0b9b227 [DS-3695] Remove redundant types, irrelevant attributes; tidy layout. 2019-02-07 15:33:29 -05:00
Tim Donohue
211545a9d0 Merge pull request #2290 from atmire/rest_item_crud
Added support for the CRUD operations on the Item rest endpoint
2019-02-07 13:43:44 -06:00
Tim Donohue
2b1b10100a Merge pull request #2343 from atmire/DS-4164_error-handling-bug-in-open-search-controller
[DS-4164] fixed the bug in the error handling
2019-02-07 12:03:27 -06:00
Mark H. Wood
416732921c [DS-3695] Remove unused "fieldType"s, dusty old comments from stock
sample schema.  Tidy indentation, break very long elements into
multiple lines.
2019-02-07 09:48:08 -05:00
Raf Ponsaerts
aa4125c9e9 Removed the name check from the DspaceObjectRestEqualityUtils 2019-02-07 15:39:15 +01:00
Ben Bosman
15eb85eb08 Check for null values
Use typed Maps
2019-02-07 12:55:02 +01:00
Terry Brady
d90e60a92b Sync docker solr web.xml with web.xml 2019-02-06 15:28:53 -08:00
Terry Brady
d489636641 Migrate PR2307 2019-02-06 10:24:35 -08:00
Raf Ponsaerts
78f7066c94 [DS-4164] fixed the bug in the error handling 2019-02-06 16:19:10 +01:00
Ben Bosman
f2b3f7027c Support relationships using a uri-list: merge 2019-02-06 16:12:47 +01:00
Mark H. Wood
8fb1ac5bd6 [DS-3695] Rip out big handfuls of unused fieldtypes, commentary about
Solr not DSpace.  Break loooong tags into attribute-per-line format.
2019-02-06 09:45:14 -05:00
Ben Bosman
fb2e0d556e Merge branch 'w2p-57159_permission-to-create-relations' into w2p-58898_place-column-calculation-error
# Conflicts:
#	dspace-spring-rest/src/main/java/org/dspace/app/rest/repository/DSpaceRestRepository.java
#	dspace-spring-rest/src/main/java/org/dspace/app/rest/repository/RelationshipRestRepository.java
#	dspace-spring-rest/src/test/java/org/dspace/app/rest/RelationshipRestRepositoryIT.java
2019-02-06 14:47:19 +01:00
Kevin Van de Velde
05cb949655 Small changes in how exceptions are handled in the ItemRestRepository, DSpaceRestRepository classes 2019-02-06 14:21:37 +01:00
Raf Ponsaerts
47d7021350 Added owningCollection as parameter to the POST Item endpoint and removed this from ItemRest. Also added documentation for several public methods. 2019-02-06 14:21:36 +01:00
Kevin Van de Velde
02ff91259f [DS-4108] Rest api item CRUD: Updating item metadata 2019-02-06 14:20:21 +01:00
Ben Bosman
864f6f1237 Support relationnships using a uri-list 2019-02-06 14:19:12 +01:00
Raf Ponsaerts
db8f6f1bb8 Fixed the 500 internal server error when calling item delete endpoint with invalid UUID 2019-02-06 14:19:10 +01:00
Raf Ponsaerts
2e446bf9a3 Added admin access to item delete and wrote tests 2019-02-06 14:19:10 +01:00
Raf Ponsaerts
ac283df61d Implemented the create method in the ItemRestRepository 2019-02-06 14:19:10 +01:00
Mark H. Wood
241fdbb538 [DS-3695] We no longer control Solr's logging. 2019-02-04 15:15:48 -05:00
Mark H. Wood
cb17cb1b7f [DS-3695] See bf4ead40575f0b180fd6840373ef17d98a6e778e. We *do* configure Solr for testing. 2019-02-04 14:58:43 -05:00
Mark H. Wood
8c26a9a78e [DS-3695] Upgrade indexes all the way to 7_x. 2019-02-04 14:58:43 -05:00
Mark H. Wood
ba0edff464 [DS-3695] We no longer configure Solr itself. 2019-02-04 14:58:43 -05:00
Mark H. Wood
f2cfab2d8d [DS-3695] Remaining minimal changes to make all cores load in Solr 7. 2019-02-04 14:58:43 -05:00
Mark H. Wood
fa9cc7c958 [DS-3695] Cure failing IT: the test was wrong. 2019-02-04 14:58:43 -05:00
Mark H. Wood
c375fe1762 [DS-3695] Make 'search' core load in stock Solr 7.2.1.
This should work without altering Solr, across Solr releases, as long
as Solr ships the necessary additional analyzers in /contrib.
2019-02-04 14:58:43 -05:00
Mark H. Wood
0792ba77ed [DS-3695] Start ripping out Solr server. 2019-02-04 14:58:43 -05:00
Mark H. Wood
3e8e1aa60f [DS-3695] Document what I puzzled out ot MockSolrServer, and small cleanups. 2019-02-04 14:58:43 -05:00
Tim Donohue
cc38ec872a Fix Solr startup errors by downgrading to 7.3.1 2019-02-04 14:58:43 -05:00
Mark H. Wood
9d0483c146 [DS-3695] Exclude Jetty from solr-core and solr-cell: Solr and Spring
Boot are fighting over versions.
2019-02-04 14:58:43 -05:00
Mark H. Wood
8d5de13987 [DS-3695] Switch new class from SolrServer to SolrClient. 2019-02-04 14:58:43 -05:00
Mark H. Wood
ee3b60c45e [DS-3695] Complete botched conflict fixup. 2019-02-04 14:58:43 -05:00
Tim Donohue
3504397031 Update to Solr 7.5. Sync dependencies and cleanup spring-rest POM 2019-02-04 14:58:43 -05:00
Tim Donohue
5e78f408f3 Disable Solr autoconfiguration in Spring Boot. Minor config cleanup 2019-02-04 14:58:43 -05:00
Tim Donohue
ece64480a0 Revert Spring Boot updates until DS-3802 is solved. Solr core only for testing. 2019-02-04 14:58:43 -05:00
Tim Donohue
01b80025b7 Fix minor compilation errors in OAI 2019-02-04 14:58:43 -05:00
Mark H. Wood
32a3c74164 [DS-3695] Start work on dspace-spring-rest 2019-02-04 14:58:43 -05:00
Mark H. Wood
3aa6b89487 [DS-3695] Rip out lots of Solr config. that is no longer defined in v7. 2019-02-04 14:58:43 -05:00
Mark H. Wood
7b9bd509a2 [DS-3695] Upgrade Solr *client* to 7.3.0. 2019-02-04 14:58:43 -05:00
Tim Donohue
3e5c9426aa Merge pull request #2277 from atmire/rest_comm_coll_management
Added support for the CRUD operations on the Collection and Community…
2019-02-04 09:13:03 -06:00
Raf Ponsaerts
2db2b70e82 Altered permissions on the Collection and Community Repositories and added ITs 2019-02-04 10:11:52 +01:00
Andrea Bollini
8c35296cdf Merge pull request #2337 from Georgetown-University-Libraries/ds4150
[DS-4150] Ensure dspace.restUrl is supported out of the box for DSpace 7 Docker
2019-01-31 16:57:50 +01:00
kshepherd
ed4f63c0b4 Merge pull request #2338 from DSpace/README-running-tests
Add Notes on running Tests to README
2019-01-31 11:00:42 +13:00
Tim Donohue
1957f36988 Notes on running tests 2019-01-30 15:24:37 -06:00
Ben Bosman
855b3f9556 getValues should not return null values 2019-01-29 16:22:26 +01:00
Ben Bosman
e99252c16f Merge branch 'w2p-57159_permission-to-create-relations' into w2p-58898_place-column-calculation-error 2019-01-29 14:52:05 +01:00
Ben Bosman
0a91360061 Merge remote-tracking branch 'community/configurable_entities' into w2p-57159_permission-to-create-relations
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/service/RelationshipService.java
2019-01-29 14:31:15 +01:00
benbosman
c72d731f93 Merge pull request #2302 from atmire/w2p-57441_modified-behavior-retrieving-relations
Retrieving relations per relationship type
2019-01-29 14:25:35 +01:00
benbosman
a663f05ad5 Merge pull request #2324 from atmire/discovery-config-relations
Discovery config relations
2019-01-29 14:20:53 +01:00
Ben Bosman
e01e133765 wording 2019-01-29 13:07:49 +01:00
Ben Bosman
887a0999bd wording 2019-01-29 12:20:49 +01:00
Ben Bosman
2dc03adc58 better readable code 2019-01-29 11:11:48 +01:00
Ben Bosman
96f08e4414 Merge branch 'w2p-59343_support-ordered-metadata' into w2p-58898_place-column-calculation-error
# Conflicts:
#	dspace-spring-rest/src/main/java/org/dspace/app/rest/repository/DSpaceRestRepository.java
2019-01-29 10:41:05 +01:00
Ben Bosman
765e14b007 Verify order of virtual and real metadata 2019-01-29 10:39:55 +01:00
Ben Bosman
f8497ff392 JavaDoc 2019-01-29 10:26:25 +01:00
Ben Bosman
7abc5b01e2 Merge remote-tracking branch 'origin/w2p-57159_permission-to-create-relations' into w2p-58898_place-column-calculation-error
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/RelationshipServiceImpl.java
#	dspace-api/src/main/java/org/dspace/content/service/RelationshipService.java
2019-01-29 09:58:22 +01:00
Terry Brady
da1346ef53 Match dspace.restUrl to module name 2019-01-28 10:05:48 -08:00
Raf Ponsaerts
7dc59a03a2 Fixed nullpointer issue in th comparator 2019-01-28 15:35:56 +01:00
Raf Ponsaerts
a62a66ec41 removed the ItemService from the DspaceObjectService 2019-01-28 14:10:36 +01:00
Raf Ponsaerts
b908df263c [Task 59343] sorted the list of metadatavalues and forced the itemconverter to use the itemservice 2019-01-28 13:24:35 +01:00
Raf Ponsaerts
7d961db6ce Applied feedback 2019-01-28 11:49:19 +01:00
benbosman
54a626892a indentation 2019-01-25 09:10:19 +01:00
Ben Bosman
e768866292 Merge branch 'w2p-58898_place-column-calculation-error' into w2p-59343_support-ordered-metadata 2019-01-24 15:22:13 +01:00
Ben Bosman
d7610ccf6e Resolving merge conflict 2019-01-24 14:19:09 +01:00
Ben Bosman
1311c40cb7 Merge remote-tracking branch 'origin/w2p-57159_permission-to-create-relations' into w2p-58898_place-column-calculation-error
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/ItemServiceImpl.java
#	dspace-api/src/main/java/org/dspace/content/RelationshipServiceImpl.java
#	dspace-api/src/main/java/org/dspace/content/service/ItemService.java
#	dspace-api/src/main/java/org/dspace/content/virtual/Collected.java
#	dspace-api/src/main/java/org/dspace/content/virtual/UUIDValue.java
#	dspace-spring-rest/src/test/java/org/dspace/app/rest/RelationshipRestRepositoryIT.java
#	dspace/config/spring/api/core-services.xml
2019-01-24 13:59:36 +01:00
Ben Bosman
257b14bc54 Merge branch 'w2p-58898_place-column-calculation-error' into w2p-59343_support-ordered-metadata 2019-01-24 13:51:52 +01:00
Ben Bosman
dac5ca467c Merge branch 'configurable_entities_temp_2' into w2p-58898_place-column-calculation-error 2019-01-24 13:48:33 +01:00
Ben Bosman
816c7d0772 Merge branch 'configurable_entities_comm' into w2p-58898_place-column-calculation-error 2019-01-24 13:34:16 +01:00
Ben Bosman
391c5b4dc6 Sort metadata values part 1 2019-01-24 13:33:13 +01:00
Ben Bosman
51de4cd87c JavaDocs and boolean name update 2019-01-24 13:26:35 +01:00
Raf Ponsaerts
1ed01310b0 Implemented the additional getMetadata function with the boolean 2019-01-24 10:06:42 +01:00
Ben Bosman
8557f44673 Merge branch 'configurable_entities_temp_2' into w2p-57159_permission-to-create-relations 2019-01-23 12:03:54 +01:00
Ben Bosman
025c77ee70 authorization for updating the place of both items 2019-01-23 12:01:50 +01:00
Ben Bosman
1ac514d4fb Merge branch 'configurable_entities_temp_2' into discovery-config-relations 2019-01-23 09:04:32 +01:00
benbosman
ccaca1aaaa indentation fix 2019-01-22 17:32:31 +01:00
Ben Bosman
a52b850080 temp disable ITs 2019-01-22 16:24:29 +01:00
Raf Ponsaerts
4847620a4c Fixed issues and wrote IT tests 2019-01-22 14:58:43 +01:00
Raf Ponsaerts
7e14562139 Merged configurable_entities into w2p-57159_permission-to-create-relations 2019-01-22 12:50:44 +01:00
Ben Bosman
461b5ee21a typing error 2019-01-22 11:15:28 +01:00
Raf Ponsaerts
86f3f9e9c3 Fixed tests and place calculation 2019-01-22 09:53:52 +01:00
Tim Donohue
f387ab18c0 Merge remote-tracking branch 'upstream/master' into configurable_entities 2019-01-21 20:02:17 +00:00
Yana De Pauw
e34b4e5448 Update item move rest contract and update tests 2019-01-21 12:47:28 +01:00
Raf Ponsaerts
f2c2b768f7 Fixed test failure 2019-01-21 10:14:09 +01:00
Raf Ponsaerts
bfc1b39ea2 Merged configurable_entities into w2p-58898_place-column-calculation-error 2019-01-21 09:19:01 +01:00
Kim Shepherd
929312d7e8 [DS-4136] tidy up commented out (old) configurationService instantiation in main() 2019-01-19 10:40:21 +13:00
Kim Shepherd
6d40a57df7 [DS-4136] Apply same changes as dspace 6.x version (PR #2320); replace xoai services configurationservice with proper DSpace configuration service; and replace all instances of legacy configuration manager with proper DSpace configuration service 2019-01-19 10:33:00 +13:00
Kim Shepherd
e7f39c23b2 WIP commit for oai master port 2019-01-18 07:30:47 +13:00
Giuseppe Digilio
48d90660ab Fixes after check on angular app 2019-01-17 17:15:04 +01:00
Raf Ponsaerts
0f6148db77 Fixed RunTimeException messages and addressed nullpointer error 2019-01-16 09:39:14 +01:00
Raf Ponsaerts
ae96aeafd4 Applied community feedback, javadocs 2019-01-15 15:49:42 +01:00
Ben Bosman
269fdd2852 additional filters in default configuration 2019-01-15 12:44:29 +01:00
Raf Ponsaerts
a757a6661e Fixed the relationship place ordering and MetadataValue place ordering 2019-01-15 11:51:48 +01:00
Ben Bosman
6ee687a4ae metadata attributes place, authority, confidence in rest 2019-01-15 08:50:52 +01:00
kshepherd
07d6846234 Merge pull request #2327 from J4bbi/ds4142_master
[DS-4142] master: update maven jdks for docker
2019-01-15 09:54:23 +13:00
Hrafn Malmquist
9b6e97fd24 update maven jdks for docker 2019-01-14 17:28:32 +00:00
Raf Ponsaerts
865b4256b9 Made sure that the itemService.update is called so that the metadata and relationship places get updated upon creation/deletion of a relationship 2019-01-14 15:53:24 +01:00
Raf Ponsaerts
7f225f1ad5 Fixed the place attribute not being set to the virtual metadata 2019-01-14 15:29:54 +01:00
Ben Bosman
6d40600dbb Merge branch 'configurable_entities' into discovery-config-relations
# Conflicts:
#	dspace/config/spring/api/discovery.xml
2019-01-14 14:23:34 +01:00
kshepherd
04d11924a5 Merge pull request #2323 from kshepherd/DS-4104_google_scholar_date_crosswalk_master
[DS-4104] Apply Google Scholar date crosswalk fix to master
2019-01-14 11:33:53 +13:00
Kim Shepherd
74fc3e97bb [DS-4104] Apply Google Scholar date crosswalk fix to master, porting from PR#2294 dspace 6 version 2019-01-14 09:20:43 +13:00
kshepherd
51550079c4 Merge pull request #2311 from mwoodiupui/DS-4087
[DS-4087] 'dspace structure-builder' errors are too hard to interpret
2019-01-13 13:22:13 +13:00
Raf Ponsaerts
3d011c5411 Applied fixes to catch clauses and added more docs 2019-01-11 15:01:59 +01:00
Raf Ponsaerts
b96cf91ef8 Applied community feedback and fixed tests 2019-01-11 09:38:21 +01:00
Raf Ponsaerts
612c8e315c Made the PUT and POST relationship endpoints now use relationshipType parameter instead of the relationshipType in the body 2019-01-07 10:54:17 +01:00
Terry Brady
6e02e145f0 Merge pull request #2314 from tdonohue/DS-4129
DS-4129: Remove unnecessary HarvestConsumer
2019-01-03 16:04:17 -08:00
Tim Donohue
33eedeaba8 DS-4129: Remove unnecessary HarvestConsumer 2019-01-03 16:13:05 +00:00
kshepherd
cd5d1b038d Merge pull request #2298 from kshepherd/DS-4113_clean_plugin
[DS-4113] Configure clean plugin in parent pom to also clean sub-modules
2019-01-03 18:09:55 +13:00
Andrea Bollini
67602275bd Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3851_workflow 2019-01-02 13:57:26 +01:00
Andrea Bollini
821d106439 Rely on Spring LateObjectEvaluator instead than our custom porting 2019-01-02 13:57:14 +01:00
Andrea Bollini
bf0139d5e9 Disable IT for basic workflow 2019-01-02 12:24:34 +01:00
Andrea Bollini
8a2ae7e891 Add javadocs: community feedback from https://github.com/4Science/DSpace/pull/37 2019-01-02 12:13:56 +01:00
Andrea Bollini
b3b1c8786e Fix H2 sql for xml workflow 2019-01-01 18:04:35 +01:00
Andrea Bollini
f84e951106 Add support for xmlworkflow in H2 database (Oracle sql as is) 2019-01-01 17:09:04 +01:00
Andrea Bollini
69f7c7588d Enable configuration workflow by default 2019-01-01 17:08:17 +01:00
Andrea Bollini
c8e11e6700 Merge remote-tracking branch 'origin/master' into DS-3851_workflow 2019-01-01 13:00:11 +01:00
Mark H. Wood
7b2b923390 [DS-4087] Small improvements to message texts. 2018-12-31 09:31:07 -05:00
Mark H. Wood
f255521c8e [DS-4087] First pass at better error reporting. 2018-12-30 18:37:00 -05:00
Andrea Bollini
1a7b22a784 Merge pull request #2293 from tdonohue/REST-IT-refactor
Super Speedy REST API v7 Integration Tests
2018-12-25 16:48:18 +01:00
benbosman
0692701f7a Merge pull request #2270 from atmire/virtual-metadata-update
Entities Virtual metadata update
2018-12-21 12:49:05 +01:00
Ben Bosman
c9bbbfde1f merge conflict 2018-12-20 11:26:05 +01:00
Ben Bosman
37fc3ee409 Merge remote-tracking branch 'community/configurable_entities' into w2p-57441_modified-behavior-retrieving-relations
# Conflicts:
#	dspace-api/src/main/java/org/dspace/content/RelationshipServiceImpl.java
#	dspace-api/src/main/java/org/dspace/content/dao/RelationshipTypeDAO.java
#	dspace-api/src/main/java/org/dspace/content/dao/impl/RelationshipTypeDAOImpl.java
#	dspace-api/src/main/java/org/dspace/content/service/RelationshipService.java
#	dspace-api/src/main/java/org/dspace/content/service/RelationshipTypeService.java
2018-12-20 11:10:06 +01:00
Tim Donohue
f3f784c6ec Merge pull request #2269 from atmire/w2p-57712_merging-csv-functionality
Entities csv import fixes for creating relations
2018-12-19 14:05:56 -06:00
Samuel
fb1a8b8c33 Added support for the CRUD operations on the Collection and Community REST endpoints - remove owningCommunity field from CommunityRest and CollectionRest 2018-12-19 14:05:22 +01:00
Tim Donohue
035832cfdd Merge pull request #2288 from atmire/w2p-57718_relationships-link-to-items
[DS-4084] - Relationships should link to Items via REST API
2018-12-18 14:18:35 -06:00
Samuel
e283f43467 Added support for the CRUD operations on the Collection and Community REST endpoints - send parentCommunity as request parameter 2018-12-18 11:09:12 +01:00
Ben Bosman
32c9585ede checkstyle 2018-12-18 10:55:22 +01:00
Ben Bosman
0d678aca58 JavaDoc 2018-12-18 10:35:30 +01:00
Ben Bosman
fe437ad88d checkstyle 2018-12-18 10:29:47 +01:00
Ben Bosman
dc6bd487e0 checkstyle 2018-12-18 10:29:04 +01:00
Ben Bosman
b050db1cae JavaDoc updates 2018-12-18 10:17:12 +01:00
Ben Bosman
efd579f054 typing error 2018-12-18 09:58:57 +01:00
Ben Bosman
1b0f00df18 Comment on relationship.type 2018-12-18 09:42:48 +01:00
Tim Donohue
dfd3ba4e38 Ensure BitstreamContent tests start with an empty Solr Statistics core 2018-12-17 21:04:56 +00:00
Tim Donohue
78e3e00e7f Rename OpenSearch tests to end in "IT" since they are Integration Tests. 2018-12-17 21:04:15 +00:00
Tim Donohue
7fe7da4813 Fix OpenSearch test issues by ensure OpenSearchServiceImpl doesn't cache configs & that Tests specify the config setting they expect. 2018-12-17 20:40:46 +00:00
Tim Donohue
74aa295787 Refactor MockSolrLoggerServiceImpl to initialize FakeDatabaseReader before every method 2018-12-17 18:44:27 +00:00
Tim Donohue
e0175bd198 Improve logging messages of SolrLogger service/listener. Debugging is otherwise impossible 2018-12-17 18:44:27 +00:00
Tim Donohue
f0ff442959 Stop using MockSolrServer directly and use the Solr Statistics Service 2018-12-17 18:44:27 +00:00
Tim Donohue
b05eec3b92 Cache default EPersons (for reuse). Fix EPersonRestRepository tests to not rely on default EPersons as heavily. 2018-12-17 18:44:27 +00:00
Tim Donohue
c305879b51 Remove @DirtiesContext and allow reuse of Spring ApplicationContext & DSpace Kernel 2018-12-17 18:44:27 +00:00
Tim Donohue
c2803a7f69 Ensure full stacktrace is logged for Integration Tests 2018-12-17 18:44:27 +00:00
Tim Donohue
ff1f46aedb Externalize DSpaceKernelInitializer so that it can be used by Integration Tests to start Kernel 2018-12-17 18:44:27 +00:00
Tim Donohue
942f2e7b92 Remove unnecessary (default) annotations. Comment what each annotation does. 2018-12-17 18:44:27 +00:00
Ben Bosman
39bf016eb8 Merging configurable_entities branch 2018-12-17 13:45:04 +01:00
Ben Bosman
1776f892e0 Merge remote-tracking branch 'community/configurable_entities' into w2p-57441_modified-behavior-retrieving-relations 2018-12-17 12:18:43 +01:00
Ben Bosman
10c610bf73 Merge branch 'w2p-57712_merging-csv-functionality' into virtual-metadata-update 2018-12-17 10:08:25 +01:00
Ben Bosman
6fca857429 Merge remote-tracking branch 'community/configurable_entities' into w2p-57712_merging-csv-functionality 2018-12-17 09:55:59 +01:00
Ben Bosman
feaa5d1adb Merge remote-tracking branch 'community/configurable_entities' into w2p-57718_relationships-link-to-items 2018-12-17 09:39:52 +01:00
Tim Donohue
21fe950593 Merge pull request #2299 from tdonohue/remove_xmlui_spring_configs
Remove obsolete XMLUI spring configs (from master)
2018-12-14 10:41:35 -06:00
Raf Ponsaerts
4e51fd0c86 Added support for the leftItem and rightItem through the parameters 2018-12-14 17:20:45 +01:00
Tim Donohue
33268e8980 Remove obsolete XMLUI spring configs 2018-12-14 16:09:19 +00:00
Tim Donohue
c3f2fa7f47 Increase memory available to Unit/Integration Tests 2018-12-14 15:29:04 +00:00
Tim Donohue
04475e42eb Merge pull request #2286 from tdonohue/temp_memory_issue_fix
[Configurable Entities] Temporary fix for Integration Test memory issues
2018-12-14 09:27:24 -06:00
Raf Ponsaerts
240636e978 Created new IT and fixed checkstyle 2018-12-14 14:53:11 +01:00
Raf Ponsaerts
2f0fb32c8c Fixed typo 2018-12-14 13:27:29 +01:00
Raf Ponsaerts
e932075d03 Added documentation and @Override where applicable 2018-12-14 13:26:16 +01:00
Raf Ponsaerts
3123c1dd61 Wrote documentation for the spring beans 2018-12-14 09:54:26 +01:00
Andrea Bollini
43bfdbb3ff Merge pull request #2253 from tantz001/DS-4050
DS-4050 Search method returns 204 NoContent or 200 for empty page if no result.
2018-12-13 22:54:01 +01:00
Andrea Bollini
c4ab55f6f5 Merge pull request #2128 from tubhh/dspace7_opensearch
DSpace7 opensearch
2018-12-13 22:48:35 +01:00
Kim Shepherd
20904f897d [DS-4113] Configure clean plugin in parent pom to also clean sub-modules 2018-12-14 10:17:11 +13:00
Raf Ponsaerts
d95c378edc Implemented the feedback 2018-12-13 15:45:15 +01:00
Oliver Goldschmidt
67046598c1 fixes typo 2018-12-13 09:34:40 +01:00
Oliver Goldschmidt
8ccb41a205 Merge branch 'master' of https://github.com/DSpace/DSpace into dspace7_opensearch 2018-12-13 09:33:46 +01:00
Andrea Bollini
7ccd99c97c Merge pull request #2173 from ppmdo/DS-3904
DS-3904 - Add support for startsWith parameters in the browse endpoint
2018-12-12 22:52:44 +01:00
Raf Ponsaerts
314e96a6ac Merged the merging-csv-functionality branch into virtual-metadata-update 2018-12-12 10:54:16 +01:00
Tim Donohue
1b2cc563d7 Increase memory available to Unit/Integration Tests 2018-12-11 15:32:11 +00:00
Raf Ponsaerts
4171729f84 Wrote IT test for CSV import and fixed a small error 2018-12-11 09:30:13 +01:00
Raf Ponsaerts
8024242fd1 Added @Override to applicable methods 2018-12-10 09:56:43 +01:00
Tim Donohue
0feb1748a0 Merge pull request #2284 from AlexanderS/ds3914-master
DS-3914: Fix community defiliation (master)
2018-12-07 09:37:06 -06:00
Raf Ponsaerts
6e16a3ed62 Applied community feedback 2018-12-07 16:09:29 +01:00
Alexander Sulfrian
e02174bad8 CommunityFiliator: Some cleanup
This removes the loops for checking if a community is contained in a list of
communities. Community.equals() does the same check, so we simply can use
contains().
2018-12-07 11:22:01 +01:00
Alexander Sulfrian
5ecc473311 DS-3914: Fix community defiliation
This fixes in issue in the defiliate method of the community filiator. The
child and parent relations should be managed using the provided methods of the
Community.

This changes the visibility of Community.removeSubCommunity() to public, but
Community.removeParentCommunity() was public before already.
2018-12-07 11:19:06 +01:00
Raf Ponsaerts
7d07a1e6f9 Merged branch configurable_entities into w2p-57712_merging-csv-functionality 2018-12-07 10:38:19 +01:00
Tim Donohue
09faec3f17 Update Entities code to use log4j2 and commons-lang v3 (per master merge) 2018-12-06 17:43:15 +00:00
Tim Donohue
ceed829800 Merge branch 'master' into configurable_entities 2018-12-06 17:05:31 +00:00
Kevin Van de Velde
783ec4bffe [DS-4096] Alter the moving item between collections to use PUT instead of POST 2018-12-06 11:02:00 +01:00
Yana De Pauw
a55a5fd795 [DS-4096] Add new endpoint to update the owning collection of an item and adding ITs to test the behaviour 2018-12-06 11:01:57 +01:00
Mark H. Wood
8df33db457 [DS-3989] Fix code from DS-3990 that was (expectedly) broken by DS-3989. 2018-12-05 16:13:24 -05:00
Mark H. Wood
844ef85583 [DS-3989] Placate Checkstyle. 2018-12-05 15:41:37 -05:00
Mark H. Wood
1d3a58958e [DS-3989] Update new method for Commons Configuration v2. 2018-12-05 15:41:37 -05:00
Mark H. Wood
1e5bcd47ce [DS-3989] Clarify help for --reporter option. 2018-12-05 15:41:37 -05:00
Mark H. Wood
c795c8b4b4 [DS-3989] Clarify submission task configuration. 2018-12-05 15:41:37 -05:00
Mark H. Wood
85db4fe2bb [DS-3989] Commit testing task. 2018-12-05 15:41:37 -05:00
Mark H. Wood
6084f892b2 [DS-3989] Remove unworkable task-id logging; ensure closure of Reporter. 2018-12-05 15:41:37 -05:00
Mark H. Wood
ff8a5fac97 [DS-3989] Add configuration for the Reporter plugin. 2018-12-05 15:41:37 -05:00
Mark H. Wood
dbcb1f291c [DS-3989] Fix invalid date format. 2018-12-05 15:41:37 -05:00
Mark H. Wood
d9c80d8afc [DS-3989] Fix checkstyle issues. 2018-12-05 15:41:37 -05:00
Mark H. Wood
9f64b9aa95 [DS-3989] Fix license blocks for new classes. 2018-12-05 15:41:37 -05:00
Mark H. Wood
de33ece1c9 [DS-3989] Pull report writing out through a pluggable interface, provide log and file plugins 2018-12-05 15:41:37 -05:00
Mark H. Wood
ab224b2508 [DS-3989] Integration test for Curator's reporting. 2018-12-05 15:41:37 -05:00
Mark H. Wood
1478ab36fa [DS-3989] Let tests set multiple values on a configuration property. 2018-12-05 15:41:37 -05:00
Mark H. Wood
d6d0e67017 [DS-3989] Placate Checkstyle: unused import. 2018-12-05 15:41:37 -05:00
Mark H. Wood
f23fef032f [DS-3989] Fix the date format. 2018-12-05 15:41:37 -05:00
Mark H. Wood
94ed795d00 [DS-3989] Accumulate reports; implement arbitrary output paths, not just standard output. 2018-12-05 15:41:37 -05:00
Mark H. Wood
301f804d44 Merge pull request #2279 from mwoodiupui/DS-4094
[DS-4094] DiscoveryRestController and DiscoveryRestRepository log as ScopeResolver
2018-12-05 15:23:58 -05:00
Mark H. Wood
90a9df75ef [DS-4094] Use correct logging categories; fix incorrect argument in a couple of messages. 2018-12-04 16:11:44 -05:00
Ivan Masár
6bbcc08e59 fix checkstyle broken by previous commit (sorry) 2018-12-03 22:44:36 +01:00
Santiago Tettamanti
733ef18184 DS-4019 Added a check for null when the group of a policy is obtained in getMostRecentModificationDate() and willChangeStatus() methods from XOAI.java class 2018-12-03 22:03:50 +01:00
Raf Ponsaerts
d77dd7fa4f Added support for the CRUD operations on the Collection and Community REST endpoints 2018-12-03 15:40:42 +01:00
Mark H. Wood
495ccdee21 Merge pull request #2168 from mwoodiupui/DS-3980
[DS-3980] Defend against bad MIME type in Email.addAttachment
2018-11-30 11:53:25 -05:00
Pascal-Nicolas Becker
3890c11bf7 [DS-4036] Resolving merge conflicts. 2018-11-30 13:05:03 +01:00
Pascal-Nicolas Becker
a3d37c3b5b [DS-4036] Resolving changes requested enduring review. 2018-11-30 13:04:50 +01:00
marsa
9a41e6fece [DS-4036] Delete EPersons even if they are referenced
DSpace references EPersons in different database tables like the
submitter of an item or like the EPerson that gets special rights
granted in the resourcepolicy table. This PR changes DSpace so it can
handle references that are set null instead of referencing an actual
EPerson. This is important to be able to delete EPersons which is
demanded by several data protection laws like GDPR in the European
Union.
2018-11-30 11:43:08 +01:00
Raf Ponsaerts
4c1fdfc49c Added a license header 2018-11-29 15:45:32 +01:00
Raf Ponsaerts
dcf21c04cf [Task 57718] added the leftItem and rightItem links to the relationship endpoint return 2018-11-29 15:25:48 +01:00
Raf Ponsaerts
699fb42683 [Task 57441] fixed the label vs id conflicting issue 2018-11-29 13:56:38 +01:00
Mark H. Wood
769398d6fb Merge pull request #2181 from mwoodiupui/DS-3990
[DS-3990] Curation task runs need per-run parameters.
2018-11-28 11:52:33 -05:00
Raf Ponsaerts
8f81f28607 [Task 57160] implemented CRUD methods on relationship endpoint 2018-11-28 14:17:11 +01:00
Tim Donohue
9bc1f1ce69 Merge pull request #2274 from DSpace/elasticsearch_cleanup
DS-3455: Delete elasticsearch-statistics-mapping.json (ElasticSearch was removed)
2018-11-27 07:58:57 -08:00
Raf Ponsaerts
13fea6312e Cleaned up and fix license headers 2018-11-27 09:37:17 +01:00
Raf Ponsaerts
41ff37de1b [Task 57441] fixed pagination on the /label endpoint 2018-11-27 08:33:10 +01:00
Tim Donohue
58c01c500c Delete elasticsearch-statistics-mapping.json 2018-11-26 16:30:46 -06:00
Tim Donohue
1d9a4edcc0 Merge pull request #2266 from mwoodiupui/DS-4077
[DS-4077] filter-media error on WordFilter -- remove old, failing WordFilter
2018-11-26 09:24:48 -08:00
Tim Donohue
b44cf37d9d Merge pull request #2267 from atmire/w2p-57442_relation-enum-metadataschema
DS-4083 Move all Schema constants to a new MetadataSchemaEnum class
2018-11-26 09:03:21 -08:00
Raf Ponsaerts
c6dfae90de intermediary commit 2018-11-26 09:02:30 +01:00
Raf Ponsaerts
925b83bc02 [Task 57441] Implemented the requested endpoints, except for one todo 2018-11-22 16:05:27 +01:00
Raf Ponsaerts
fc8e3744b6 Merged w2p-56183_additional-relationshiptype-endpoints into w2p-57441_modified-behavior-retrieving-relations and fixed checkstyle, license headers 2018-11-22 13:41:06 +01:00
Raf Ponsaerts
0b4dc28dfa Merge branch 'w2p-56182_additional-endpoint-relations' into w2p-57441_modified-behavior-retrieving-relations 2018-11-22 13:10:27 +01:00
Raf Ponsaerts
e7b6aded69 Fixed tests and added license headers 2018-11-22 10:41:45 +01:00
Pablo Prieto
30f8b61ad0 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3904 2018-11-21 21:24:39 -06:00
Pablo Prieto
6600839fa4 Fixed ITs 2018-11-21 21:23:00 -06:00
Pablo Prieto
8ebb6a1a41 Added handling of empty querystring. Added startsWithandPage test. 2018-11-21 18:58:09 -06:00
Mark H. Wood
7613a204ed [DS-3990] Trim parameter name, value; remove unused test code. 2018-11-21 11:10:42 -05:00
Raf Ponsaerts
912a1f0be6 Merged entities-PR2 into virtual-metadata-update 2018-11-21 15:47:08 +01:00
Raf Ponsaerts
38250f94ad Fixed checkstyle 2018-11-21 11:37:14 +01:00
Raf Ponsaerts
34a2b92754 Merged entities-PR2 into w2p-57712_merging-csv-functionality 2018-11-21 11:02:28 +01:00
Raf Ponsaerts
b905f69d63 Refactored the usages of MetadataSchema.DC to use the enum instead 2018-11-21 09:35:11 +01:00
Mark H. Wood
aeee597101 [DS-4077] Remove traces of tm-extractors. 2018-11-20 19:55:02 -05:00
Mark H. Wood
5114f21da8 [DS-4077] Remove old, failing WordFilter; use PoiWordFilter instead. 2018-11-20 18:58:41 -05:00
Tim Donohue
52f1cf1fdc Merge pull request #2246 from atmire/entities-PR2
Initial entities PR
2018-11-20 16:05:34 -06:00
Raf Ponsaerts
b8d6fa2fba [Task 57442] Added the MetadataSchemaEnum with DC and RELATION, rewrote methods using relation String 2018-11-20 15:51:41 +01:00
Raf Ponsaerts
cfeabe349c [Task 57188] added the logic for the advanced place column calculation. Enforced that all virtual metadata are valid metadatafields 2018-11-20 14:32:12 +01:00
Raf Ponsaerts
0ba6d75a30 Constructed a RelationshipMetadataValue object and refactored the getRelationshipMetadata methods in the ItemServiceImpl to use this object instead of it's parent MetadataValue 2018-11-19 16:14:51 +01:00
benbosman
ad7bd23038 Additional search filter 2018-11-16 17:39:36 +01:00
Raf Ponsaerts
3a972ba5b9 Added config for virtual metadata fields on the journalIssue and Publication item pages 2018-11-16 15:17:23 +01:00
Raf Ponsaerts
a755f296bf Added relation.isJournalOfPublication metadata field on the publication with config and addition of a new uuidvalue bean 2018-11-16 11:14:28 +01:00
Raf Ponsaerts
255de21271 [Task 57187] added the relationship ID after the virtual:: in the metadata field authority 2018-11-16 10:10:02 +01:00
Tim Donohue
76470f4eec Merge pull request #2262 from tdonohue/DS-4078
DS-4078: Bitstreams should keep their formats when being versioned. (Master port)
2018-11-15 11:35:55 -06:00
Tim Donohue
f3245e7c88 DS-4078: Bitstreams should keep their formats when being versioned. 2018-11-15 16:28:14 +00:00
Tim Donohue
5eeb40e530 Merge pull request #2258 from atmire/w2p-57063_http-vs-https-request-url
Make the REST URL configurable instead of relying on the request.getUrl
2018-11-15 10:20:48 -06:00
Raf Ponsaerts
8e8bb65f75 Removed a problematic context.close() 2018-11-15 15:13:16 +01:00
Raf Ponsaerts
01c1c0cddf [Task 57265] added the request search filters 2018-11-15 12:50:01 +01:00
Raf Ponsaerts
7b2233a9b7 [Task 57186] added useForPlace property to the beans and added setters and getters to the interface. defaulting to false. Added this property to the isAuthorOfPublication config 2018-11-15 10:45:45 +01:00
Raf Ponsaerts
86cd0c7025 [Task 57103] added javadoc 2018-11-15 09:27:56 +01:00
Raf Ponsaerts
353d4c9d60 [Task 57103] implemented the support for related beans and added the option for config to supply virtual metadata throughout many nested relations 2018-11-14 16:06:33 +01:00
Pablo Prieto
7d5e12a793 Added QueryString null handling. 2018-11-13 18:40:28 -06:00
Mark H. Wood
d6a8002a7c [DS-3951] Change request-copy recipient to a List; add strategies to list collection administrators and to combine other strategies. 2018-11-12 10:41:44 -05:00
Raf Ponsaerts
37ffda5d21 Made sure that the delete and create functions in relationshipservice update the place attributes accordingly. Fixed checkstyle and added license header. Changed cacheable functions to false in relationshipDAO 2018-11-12 15:56:28 +01:00
Raf Ponsaerts
5de574d65a Merged w2p-57104_csv-import-delete-functionality into w2p-57107_mixing-entities-and-plaintest-values 2018-11-12 13:14:40 +01:00
Raf Ponsaerts
b226666113 Added loops to set places on left and right places for relationships on create and delete 2018-11-12 13:11:43 +01:00
Raf Ponsaerts
b3a4a196d8 [Task 57107] changed the functionality of the VirtualMetadataPopulator to now support a bean 2018-11-12 12:43:10 +01:00
Ben Bosman
45afa91d0e Removed setter since it's no longer used 2018-11-12 09:32:40 +01:00
Ben Bosman
c30e548533 use only one extraction of the UUID 2018-11-12 09:26:18 +01:00
Tim Donohue
94aeb7c18a Merge pull request #2241 from mwoodiupui/DS-3135-again
[DS-3135] Replace log4j 1.2, which is EOL
2018-11-09 10:34:10 -06:00
Oliver Goldschmidt
e53af97a31 fixes checkstyle issue 2018-11-09 16:39:17 +01:00
Mark H. Wood
9e1c16990f [DS-3135] Remove leftover comment (and surrounding empty niladic constructor). 2018-11-09 09:02:59 -05:00
Mark H. Wood
18868370de [DS-3135] Remove commented-out attempt by logged code to tell logging framework its configuration path. 2018-11-09 09:02:59 -05:00
Mark H. Wood
468725346f Remove system property pointing to logging config. Instead just let
framework do its default search, which should find the config. on the
classpath.
2018-11-09 09:02:59 -05:00
Mark H. Wood
3929a5d7ac [DS-3135] Remove questionable loglevel fiddling; conform to webapp descriptor schema. 2018-11-09 09:02:59 -05:00
Mark H. Wood
e671680ae4 [DS-3135] Let Spring configure Log4J; correct logging config in Ant script. 2018-11-09 09:02:59 -05:00
Mark H. Wood
eff018aace [DS-3135] Squash another unused import for Checkstyle. 2018-11-09 09:02:59 -05:00
Mark H. Wood
38e1d0a8d4 [DS-3135] Set the log4jConfiguration context parameter properly. 2018-11-09 09:02:59 -05:00
Mark H. Wood
5b66fdf5db [DS-3135] Clean out temporary exclusions; tidy indentation. 2018-11-09 09:02:59 -05:00
Mark H. Wood
2925a3a3bf [DS-3135] Finish converting log4j2 configuration; make it work for Solr; tweak Ant usage. 2018-11-09 09:02:59 -05:00
Mark H. Wood
b668860a2b [DS-3135] Don't configure Solr with ConfigureLog4jListener which no longer exists. 2018-11-09 09:02:59 -05:00
Mark H. Wood
9133d289ed [DS-3135] Satisfy Checkstyle by removing unused includes; tighten up the code a little. 2018-11-09 09:02:59 -05:00
Mark H. Wood
959b5122b7 [DS-3135] Squash one more log4j1 dependency. 2018-11-09 09:02:59 -05:00
Mark H. Wood
f3505ed22b [DS-3135] Still more dependency cleanup. 2018-11-09 09:02:59 -05:00
Mark H. Wood
3f904dc4ec [DS-3135] Tell Log4J where to find its configuration. 2018-11-09 09:02:59 -05:00
Mark H. Wood
5cbe4fefb5 [DS-3135] Correct Log4J configuration file name. 2018-11-09 09:02:58 -05:00
Mark H. Wood
bb10bfe01a [DS-3135] More dependency cleanup 2018-11-09 09:02:58 -05:00
Mark H. Wood
9be54714d3 [DS-3135] More dependency fixes. 2018-11-09 09:02:58 -05:00
Mark H. Wood
f5d325b36b [DS-3135] Fix new class that uses old log4j. 2018-11-09 09:02:58 -05:00
Mark H. Wood
f48d005e2c [DS-3135] log4j 2 needs new configuration -- start with the command line tools 2018-11-09 09:02:58 -05:00
Patrick Trottier
538b0046e5 Change to version 2.6.2 of log4j
To ensure compatibility with Spring Boot v1.4.4
2018-11-09 09:02:58 -05:00
Patrick Trottier
8eb074b11f Fix dependency convergence 2018-11-09 09:02:58 -05:00
Patrick Trottier
a3db6f727c Fix import statement 2018-11-09 09:02:58 -05:00
Patrick Trottier
7996283d3c Fix files not conforming to code style 2018-11-09 09:02:58 -05:00
Patrick Trottier
56dd50d283 Additional refactoring for log4jv2 2018-11-09 09:02:58 -05:00
Patrick Trottier
7bd47362b6 Refactor additional loggers for log4jv2 2018-11-09 09:02:58 -05:00
Patrick Trottier
bb2dde22b1 Convert getLogger() and Log4J imports for Log4J 2 2018-11-09 09:01:25 -05:00
Patrick Trottier
a49486310a Update POMs to version 2.10.0 2018-11-09 08:58:56 -05:00
Patrick Trottier
a5a00816cc Additional refactoring for log4jv2 2018-11-09 08:58:56 -05:00
Patrick Trottier
00088c9739 Fix dependency convergence and use POM property for log4j version 2018-11-09 08:56:44 -05:00
Patrick Trottier
3b10caef0d Fix reference to log4jv2 2018-11-09 08:56:44 -05:00
Patrick Trottier
bda4fa0ba7 Refactor additional loggers for log4jv2 2018-11-09 08:56:44 -05:00
Patrick Trottier
35b5c6c321 Remove bean declaration for log4v1 service 2018-11-09 08:53:12 -05:00
Patrick Trottier
7f589a5ad6 Refactor import statements 2018-11-09 08:53:12 -05:00
Patrick Trottier
1eed2698ae Remove trailing whitespace in EventListenerExample 2018-11-09 08:51:47 -05:00
Patrick Trottier
b72fff4a25 Remove code related to log4j1 2018-11-09 08:51:47 -05:00
Patrick Trottier
1e3231967f Add Log4J LogManager to EventListenerExample 2018-11-09 08:41:42 -05:00
Patrick Trottier
7f4b4e9f8a Convert getLogger() and Log4J imports for Log4J 2 2018-11-09 08:41:42 -05:00
Patrick Trottier
fb4e7ae9cb Update POMs to version 2.10.0 2018-11-08 16:03:30 -05:00
Tim Donohue
195213d528 Merge pull request #2244 from tdonohue/commons_config_v2
DS-4056: Upgrade to Commons Configuration v2 (and Commons Lang v3)
2018-11-08 15:00:03 -06:00
Tim Donohue
34edf302b7 Remove unnecessary PropertyPlaceholderConfigurer 2018-11-08 20:35:58 +00:00
Tim Donohue
4d882bec60 Remove unnecessary exclusion 2018-11-08 20:35:58 +00:00
Tim Donohue
200cede397 Upgrade to commons-lang3 to avoid dependency conv issues. 2018-11-08 20:35:57 +00:00
Tim Donohue
b4eac9e5ff Update config-definition.xml to be v2 compatible 2018-11-08 20:35:57 +00:00
Tim Donohue
3ec449f3df Update dspace-api code to Commons Config v2 2018-11-08 20:35:54 +00:00
Tim Donohue
79d027776e Add Spring PropertySource integration + tests to prove it works 2018-11-08 20:33:28 +00:00
Tim Donohue
673d4b9d36 Replace DSpaceConfigurationFactoryBean with ConfigurationPropertiesFactoryBean 2018-11-08 20:33:28 +00:00
Tim Donohue
c810efccb3 Add / enhance unit tests to prove functionality unchanged after upgrade 2018-11-08 20:33:28 +00:00
Tim Donohue
cb913fd24f Initial upgrade of dspace-services to Commons Config v2 2018-11-08 20:33:28 +00:00
Tim Donohue
d364f351e6 Merge pull request #2259 from Georgetown-University-Libraries/ds4075
[DS-4075] correct command line usage for solr-upgrade-statistics-6x
2018-11-08 13:52:57 -06:00
Raf Ponsaerts
b37d0e2167 Applied community feedback 2018-11-08 14:28:58 +01:00
Terry Brady
68dca061b0 correct usage 2018-11-07 15:20:36 -08:00
Tim Donohue
af305d154a Merge pull request #1810 from Georgetown-University-Libraries/ds3602m
[DS-3602] Incremental Update of Legacy Id fields in Solr Statistics
2018-11-07 16:07:41 -06:00
Raf Ponsaerts
445e42ccc2 Merge branch 'w2p-57104_csv-import-error' into w2p-57104_csv-import-delete-functionality 2018-11-06 15:30:20 +01:00
Raf Ponsaerts
bfd0bd7362 [Task 57104] adding delete functionality for the csv import 2018-11-06 15:30:13 +01:00
Raf Ponsaerts
d8ced6aa7d Made sure that the relation.X name is always added to the item for every relationship that it has 2018-11-06 11:34:50 +01:00
Raf Ponsaerts
d90f4e63f5 [Task 56183] added the additional relationshiptype endpoint on the entitytype 2018-11-05 14:02:44 +01:00
Raf Ponsaerts
b81593c41c [Task 57104] added support for multiple relation import 2018-11-05 11:43:46 +01:00
Raf Ponsaerts
75358b2bdd Reverted the changes to the DSpaceCSVTest, bulkedit.cfg and thumbnail size in dspace.cfg 2018-11-05 10:51:08 +01:00
Raf Ponsaerts
0ee618385b [Task 56182] Added the endpoint to search across an items relationships by a label of the relationshiptype 2018-11-05 09:25:56 +01:00
Oliver Goldschmidt
53e548e4a9 remove OpenSearch path from config as its not configurable any more 2018-11-02 16:09:31 +01:00
Terry Brady
91f779aa8c handle shard corrupt multivals 2018-11-01 17:34:30 -07:00
Tim Donohue
218fdcbaf0 Merge pull request #2207 from tomdesair/Authentication_X-Forwarded-For
DS-4074: Only use X-Forwarded-For value from known proxies
2018-11-01 14:55:51 -05:00
Terry Brady
defa4671d8 more checkstyle fix 2018-11-01 10:39:40 -07:00
Bill Tantzen
8ec4780625 DS-4050 Search method returns 204 NoContent or 200 with an empty page if no result. 2018-11-01 12:31:16 -05:00
Terry Brady
a6276da8b0 checkstyle fixes 2018-11-01 10:13:20 -07:00
Terry Brady
ed94b9ce9e Update dspace/config/launcher.xml
upgrade launcher labels
2018-11-01 09:04:18 -07:00
Terry Brady
fa00fec49f Merge pull request #14 from Georgetown-University-Libraries/ds3602m1
Add string "-unmigrated" to ids that cannot be mapped
2018-10-31 16:20:22 -07:00
Terry Brady
fed22f30bf add unmigrated 2018-10-31 16:10:53 -07:00
Terry Brady
30c522f896 Merge pull request #13 from Georgetown-University-Libraries/ds3602m1
Remove DSpace Mig from Query, clarify command name
2018-10-31 15:50:19 -07:00
Terry Brady
b9b383bb05 rem comment 2018-10-31 15:47:14 -07:00
Terry Brady
3255206212 simplify not queries 2018-10-31 15:09:17 -07:00
Terry Brady
6c989433e1 try new query 2018-10-31 15:03:51 -07:00
Tim Donohue
74149ba247 Fix checkstyle failure (after rebase) 2018-10-31 15:29:34 -05:00
Terry Brady
9d5b59b46f Merge branch 'master' into ds3602m 2018-10-31 13:05:39 -07:00
Tim Donohue
9fee00445e Merge branch 'master' into Authentication_X-Forwarded-For 2018-10-31 14:55:53 -05:00
Tim Donohue
1f15bb874e Merge pull request #2206 from atmire/DS-4010_query-parameter-on-discover-endpoint-bug
[DS-4010] Removed the escaping on the query parameter for the discove…
2018-10-31 14:13:45 -05:00
Raf Ponsaerts
9e99c911c6 Added information into the exception message 2018-10-31 15:28:33 +01:00
Raf Ponsaerts
b5c3af6aa5 CSV Import fixes 2018-10-31 13:41:36 +01:00
Raf Ponsaerts
3c10296d0c [Task 57063] made the REST URL configurable instead of relying on the request.getUrl method to return the correct information 2018-10-31 10:17:48 +01:00
Tom Desair
b622781f5d DS-3542: Added unit tests for ClientInfoServiceImpl 2018-10-29 23:02:34 +01:00
Tim Donohue
f984cd17c1 Merge pull request #2249 from tdonohue/statistics_schema_uuid
Fix DS-4066 by update all IDs to string type in Solr Statistics schema
2018-10-29 16:31:29 -05:00
Tim Donohue
b283d5d9e4 Fix DS-4066 by update all IDs to string type in schema 2018-10-29 17:07:54 +00:00
Oliver Goldschmidt
0a9f5efcdc adds some tests 2018-10-29 13:53:51 +01:00
Oliver Goldschmidt
c08fb4af1d removes wrong line from comment 2018-10-29 13:53:20 +01:00
Oliver Goldschmidt
110f6c2a8d ignore test instead of having it commented out 2018-10-29 09:31:33 +01:00
Mark H. Wood
003831f4f6 Merge pull request #2247 from mwoodiupui/DS-3433
[DS-3433] Don't scare the admin. when an email Session is not found in JNDI
2018-10-26 12:08:07 -04:00
Raf Ponsaerts
eb0ea9a6bf Added relevant JavaDocs to public methods in altered classes 2018-10-26 08:48:33 +02:00
Tim Donohue
0c6c9afbd4 Merge pull request #2235 from tdonohue/dependency-cleanup
DS-4041: Update to Servlet Spec version 3.1.0 in all dependencies
2018-10-25 15:02:51 -05:00
Mark H. Wood
9c242087a7 [DS-3433] Silence exceptions when named Session not found or there is no JNDI initial context. 2018-10-25 15:34:21 -04:00
Tim Donohue
d5e22ec1af Merge pull request #2167 from mwoodiupui/DS-3970
[DS-3970] Unused, nonexistent configuration property referenced in confusing startup message
2018-10-25 12:18:58 -05:00
Raf Ponsaerts
af94859404 Added JavaDoc to public methods in new classes where necessary 2018-10-25 14:55:21 +02:00
Raf Ponsaerts
031642ddc1 Made relation.* searchable again 2018-10-24 15:24:03 +02:00
Raf Ponsaerts
b0216cb918 Test fixes and checkstyle fixes 2018-10-24 14:12:23 +02:00
Raf Ponsaerts
f223f1c067 DSpace 7 Entities 2018-10-24 10:24:09 +02:00
Tim Donohue
bd9bd233b7 Merge pull request #2239 from 4Science/inputform-rows
DS-3937 Add support for styling and rows in the submission-forms.xml
2018-10-23 11:49:33 -05:00
Tim Donohue
cb1a35a524 Merge pull request #2243 from mwoodiupui/DS-4031-7x
[DS-4031] Updated link to DRIVER guidelines -- 7_x.
2018-10-18 11:43:59 -05:00
Mark H. Wood
992c775058 [DS-4031] Updated link to DRIVER guidelines. 2018-10-18 09:41:13 -04:00
Andrea Bollini
e92852faca Merge pull request #2215 from mspalti/repositorypatch
DS-4021: Updated patch operations for Item repository and added patch endpoints for EPerson.
2018-10-18 11:28:31 +02:00
Pablo Prieto
819a42b69e Fixed Integration Tests 2018-10-17 23:32:39 -05:00
Terry Brady
826babb48e Merge pull request #2214 from terrywbrady/ds4012
[DS-4012] Support Multiple Dockerfiles in one branch
2018-10-17 11:29:57 -07:00
Andrea Bollini
d55189a4f2 Add javadoc to the matcher class 2018-10-17 16:58:04 +02:00
Tim Donohue
499f496d62 Merge branch 'dependency-cleanup' of github.com:tdonohue/DSpace into dependency-cleanup 2018-10-17 09:54:56 -05:00
Tim Donohue
6dc6102325 Update all web.xml files to use Servlet 3.1. Requires minor reorg in older webapps. 2018-10-17 09:53:46 -05:00
Andrea Bollini
8b0db601b0 Improved javadoc about new submission conf concepts 2018-10-17 16:50:41 +02:00
Michael W Spalti
f9861ec5ca [DS-4021] Corrected minor typo in integration test. 2018-10-15 13:22:43 -07:00
Michael W Spalti
f890f1705c [DS-4021] Updated integration tests.
Merge branch 'repositorypatch' of https://github.com/mspalti/DSpace into repositorypatch
2018-10-15 12:43:11 -07:00
Oliver Goldschmidt
b702582fb2 removes unnecessary import 2018-10-15 17:04:27 +02:00
Oliver Goldschmidt
fa3af00e4d removes unnecessary init method 2018-10-12 16:55:00 +02:00
Tim Donohue
0d59219ead Merge pull request #2232 from antzsch/ds4032-create-eperson-group
Add the ability to create EPerson Group via REST.
2018-10-12 09:47:59 -05:00
Oliver Goldschmidt
d421942321 fixes style issue 2018-10-12 10:10:13 +02:00
Oliver Goldschmidt
c7cde57c3a removing unnecessary settings in test configuration 2018-10-12 09:38:57 +02:00
Oliver Goldschmidt
0c6690aa82 cleaning up 2018-10-12 09:36:15 +02:00
Andrea Bollini
5b43bebf17 Merge pull request #2238 from tantz001/DS-3916
/api/config/submissiondefinitions/traditional/collections should return empty list rather than 204 [was#2189]
2018-10-12 00:34:05 +02:00
Michael W Spalti
837814b596 [DS-4021] Added a bit of IOC that helps to assure consistent checks before applying patch replace operations. 2018-10-11 14:54:29 -07:00
Andrea Bollini
3c0c4565df Merge pull request #2228 from ppmdo/DS-4024
Create top level community via REST [DS-4024]
2018-10-11 23:22:55 +02:00
Bill Tantzen
e2608f79bf return null/204 when endpoints return null (or empty list) and a single item is requested; return empty list/200 when endpoints return null (or empty list) and an array of items is requested. 2018-10-11 11:05:35 -05:00
Tim Donohue
d6d7a620c2 Merge pull request #2187 from 4Science/DS-3580_workspaceitem
DS-3850 Create new submissions from files or identifiers
2018-10-11 08:59:27 -05:00
Bill Tantzen
e64101a5e9 modified two additional ITs reflecting the changes to RestResourceController 2018-10-11 07:41:56 -05:00
Oliver Goldschmidt
ac788aacee fixes style issues in tests 2018-10-11 09:57:54 +02:00
Tim Donohue
4652bb8cab Dependency fixes for OAI-PMH using Servlet API 3.1 2018-10-10 18:32:18 +00:00
Michael W Spalti
ed8f245e7d [DS-4021] Replace patch operations on a non-existent value now result in a PatchBadRequestException.
Added missing license headers.

Added FIXME.
2018-10-10 10:38:01 -07:00
Andrea Bollini
d794c20385 DS-3937 remove unused methods, improve javadoc and testing 2018-10-10 19:29:40 +02:00
Bill Tantzen
77f4b9db6e minor format changes 2018-10-10 11:18:03 -05:00
Bill Tantzen
2f1f45f8a8 /api/config/submissiondefinitions/traditional/collections should return empty list rather than 204 #2189 2018-10-10 11:09:28 -05:00
Terry Brady
4c5b82c95a review comments 2018-10-10 08:28:02 -07:00
Oliver Goldschmidt
50490370d9 introduces tests for OpenSearchController 2018-10-10 16:38:43 +02:00
Andrea Bollini
e58870eb8f Merge branch 'DS-3580_workspaceitem' of https://github.com/4Science/DSpace into inputform-rows 2018-10-10 11:45:02 +02:00
Andrea Bollini
b6a35ebaf7 DS-3580 simplify the interface retrieving the filename from the multipartfile upload
Add additional Javadoc
Better align the interface with the Angular implementation
2018-10-10 11:35:36 +02:00
Michael W Spalti
7e4194b3a4 [DS-4021] Replace patch operations on a non-existent value now result in a PatchBadRequestException.
Added missing license headers.
2018-10-09 15:18:23 -07:00
Michael W Spalti
a9bf1d869d [DS-4021] Patch processing now operates on the rest model and commits changes after successful completion of all patch operations.
Also added new integration tests.

Minor changes to error handling and comments.

[DS-4021] Updated tests and javadocs.

Also updated the string comparison in EPersonRestRespository that triggers the update of the netid after a patch operation is complete.
2018-10-09 11:04:34 -07:00
Stefan
0f0066b0c0 Spilt the createAndRunTest() method in several methods in dependcy of the context what they test and code cleanup. 2018-10-09 19:04:58 +02:00
Andrea Bollini
dc51e4c059 Merge branch 'DS-3580_workspaceitem' of https://github.com/4Science/DSpace into inputform-rows 2018-10-09 19:02:27 +02:00
Pablo Prieto
a2e7069d1c Fixed missing @Test on ITs
Modified CommunityMatcher to use the generic CommunityMetadataMatcher
2018-10-08 23:19:53 -05:00
Pablo Prieto
486b1fb41d Added POST method on Communities endpoint to create a Top-Level Community
Wrote integration tests for admin, anonymous and normal eperson use cases
2018-10-08 23:09:04 -05:00
Andrea Bollini
e4874ae356 Merge branch 'master' of https://github.com/DSpace/DSpace into workspace-IT 2018-10-08 23:20:38 +02:00
Andrea Bollini
2458b5d621 DS-3850 ITs for metadata update, file upload, file update 2018-10-08 22:30:22 +02:00
Andrea Bollini
89ebd2c154 Make LicenseOperation more client friendly 2018-10-08 22:29:31 +02:00
Tim Donohue
3fd7cc903d Fix dependency convergence errors with OAI and SWORDv2 2018-10-08 20:07:44 +00:00
Tim Donohue
d3ee089d2e Update our DummyHttpServletRequest to Servlet Spec 3.1.0 2018-10-08 12:40:07 -05:00
Tim Donohue
447bea2921 Update to using Servlet API spec 3.1.0 in all modules 2018-10-08 17:11:37 +00:00
Tim Donohue
754915b8aa Remove duplicate dependency in dspace-api 2018-10-08 17:01:55 +00:00
Andrea Bollini
4a0b636b3d DS-3850 add ITs for create, bulkcreate, metadata patch 2018-10-07 22:23:40 +02:00
Andrea Bollini
2d2afd886c Set the status when the errors information are available 2018-10-07 22:21:17 +02:00
Andrea Bollini
951d039830 Fix bulk creation via file upload 2018-10-07 22:20:45 +02:00
Andrea Bollini
1bb1fd44a4 Fix javadoc misunderstanding 2018-10-06 21:02:53 +02:00
Andrea Bollini
a8863fd6a0 Add missing method to support bulk creation of objects via file upload 2018-10-06 13:08:58 +02:00
Andrea Bollini
9e85421ab4 Add javadocs 2018-10-06 13:06:47 +02:00
Andrea Bollini
c466d10c6a DS-3850 Integration Test for workspaceitem endpoint (find and delete methods)
Add predictable order to the workflowitem find query (by workspaceItemId instead than item uuid)
2018-10-05 22:36:50 +02:00
Stefan
79b950c8e4 Restrict the endpoint with an @PreAuthorize annotation 2018-10-05 18:28:29 +02:00
Stefan
f432568b31 Cleaning up the code and implement more test cases for the group creation. 2018-10-05 15:29:16 +02:00
Stefan
cc7bcf6007 Add the ability to create EPerson Group via REST. 2018-10-05 12:30:19 +02:00
Pablo Prieto
40ca9f6150 Added URL parameter parsing for Browse Endpoint 2018-10-05 00:21:49 -05:00
Pablo Prieto
267677a023 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3904 2018-10-03 21:01:34 -05:00
Mark H. Wood
8db86e12f8 [DS-4032] Replace 'Boolean' with 'boolean' to avoid NPE. 2018-10-02 14:20:29 -04:00
Michael W Spalti
ef8b0c642d [DS-4021] This commit includes code formatting and comment changes.
Also a few minor modifications to patch operations.

Minor code format changes.

Final code formatting changes for EPersonRestRepositoryIT.
2018-10-02 11:02:51 -07:00
Tim Donohue
a3437d4217 Merge pull request #2188 from atmire/DS-3991_HAL-browser-download
[DS-3991] made sure that the halbrowser now correctly downloads files
2018-10-02 10:04:57 -05:00
Michael W Spalti
1f091bd6bd DS-4021 Reintroduce abstract and implementation classes for patch operations.
Prior to this commit, the factory implementations used only path and value, ignoring the operation name. This commit reintroduces default implementations operations (add, move, remove, replace) and working implementations for eperson and item replace operations. The factory methods are now designed to be used specifically for replace operations. As needed, new factory methods can be added.
2018-10-01 23:16:05 -07:00
Raf Ponsaerts
aacb7b0ee3 [DS-3991] changed the default name of a downloaded file to content in the client.js 2018-10-02 08:09:02 +02:00
Michael W Spalti
ca697e8064 [DS-4021] Added patch method for EPerson.
Implements patch operations for password, canLogin, requireCertificate and netid. Includes integration tests.
2018-10-01 14:04:59 -07:00
Oliver Goldschmidt
f9bfd5ed6d Merge branch 'master' of https://github.com/DSpace/DSpace into dspace7_opensearch 2018-10-01 15:37:29 +02:00
Raf Ponsaerts
7e1ca49bcf [DS-4010] fixed test case 2018-10-01 15:15:31 +02:00
Raf Ponsaerts
06b4e5d12a [DS-4010] added IT tests for the query functionality on the discover endpoint 2018-10-01 13:59:29 +02:00
Michael W Spalti
d51493a1a3 Rolling back indentation changes in ItemRestRepositoryIT.
Reverting indentation changes in ItemRestRepositoryIT.

More updates to indentation.

Corrected line length errors in ItemRestRepositoryIT.

Final formatting updates for ItemRestRepositoryIT.
2018-09-27 18:40:59 -07:00
Michael W Spalti
65c7bbb6f6 Updated respository patch classes and ItemRestRepository. 2018-09-27 13:01:23 -07:00
Terry Brady
0b991a4d13 Create default and test image variants 2018-09-27 07:15:14 -07:00
Terry Brady
e0d10d7eec support mult dockerfiles per branch 2018-09-26 14:34:53 -07:00
Tom Desair
bd464e03f5 DS-3542: Only trust X-Forwared-For headers from trusted proxies 2018-09-26 22:13:03 +02:00
Raf Ponsaerts
47dc9482c6 [DS-4010] added IT test for the discoverQuery with a query parameter containing dc.date.issued 2018-09-25 14:14:51 +02:00
Raf Ponsaerts
df5816dff9 Revert "Revert "[DS-4010] added a catch for the search error and throw illegalarguement instead so that the exception handling picks it up easily and returns a proper error response with headers included""
This reverts commit ea42765849.
2018-09-21 15:25:24 +02:00
Raf Ponsaerts
ea42765849 Revert "[DS-4010] added a catch for the search error and throw illegalarguement instead so that the exception handling picks it up easily and returns a proper error response with headers included"
This reverts commit b192552888.
2018-09-21 14:38:55 +02:00
Raf Ponsaerts
b192552888 [DS-4010] added a catch for the search error and throw illegalarguement instead so that the exception handling picks it up easily and returns a proper error response with headers included 2018-09-21 14:07:01 +02:00
Raf Ponsaerts
aa4f3bb60b [Task 55655] set the status to Bad Request if the query entered wasn't valid and the searchservice threw an exception 2018-09-21 13:20:02 +02:00
Raf Ponsaerts
26a55312b3 [DS-4010] Fixed the tests 2018-09-18 08:49:38 +02:00
Raf Ponsaerts
a73b980955 [DS-4010] removed the comments that don't represent the code anymore 2018-09-17 16:50:01 +02:00
Tim Donohue
b0e076ddb1 Merge pull request #2205 from AlexanderS/DS-3664-master
[DS-3664] ImageMagick: Only execute "identify" on first page
2018-09-17 09:40:29 -05:00
Raf Ponsaerts
b3abd7743c [DS-4010] Removed the escaping on the query parameter for the discover endpoint 2018-09-17 15:58:11 +02:00
Alexander Sulfrian
4f53075317 ImageMagick: Only execute "identify" on first page
The Info object used to get the color format runs "identify" on the supplied
input file. If the file has many pages, this process might require some time.
"identify" supports the same syntax for the input file like the other
ImageMagick tools and we can simply restrict the pages by changing the input
file name.

This fixes DS-3664.
2018-09-17 15:10:33 +02:00
Andrea Bollini
7aed10c1b1 DS-3937 Add support for styling and rows in the submission-forms.xml 2018-09-11 20:45:08 +02:00
Mark H. Wood
0340cd73ad [DS-3990] Add simple unit test. 2018-09-09 17:19:39 -04:00
Mark H. Wood
43d01f283f [DS-3990] Dummy task to test properties and parameters. 2018-09-09 12:40:49 -04:00
Tim Donohue
705e0fabbd Merge pull request #2111 from atmire/DS-3741-hibernate-deprecation-fix-applied-feedback
DS-3741 hibernate deprecation fix applied feedback
2018-09-06 14:28:40 -05:00
Terry Brady
d4dbd3894a fix exist/doesn't exist 2018-09-06 11:23:56 -07:00
Raf Ponsaerts
0c58803a44 [DS-3741] restored the findByMetadataQuery method in a slightly altered version 2018-09-06 14:46:22 +02:00
Mark H. Wood
2c47e9b149 [DS-3990] Satisfy Checkstyle (tested this time)-: 2018-09-06 08:44:06 -04:00
Mark H. Wood
af27fde95b [DS-3990] Satisfy Checkstyle. 2018-09-06 08:42:13 -04:00
Mark H. Wood
e980811d4e [DS-3990] CLI access to task run parameters. 2018-09-06 07:01:46 -04:00
Raf Ponsaerts
349eebb834 [DS-3991] removed the xmlui content disposition threshold property 2018-08-30 07:55:59 +02:00
Raf Ponsaerts
287dce21fc [DS-3991] altered the disposition rules in the BitstreamContentRestController and MultiPartFileSender 2018-08-30 07:55:59 +02:00
Raf Ponsaerts
c56c1d38ef [DS-3991] made sure that the halbrowser now correctly downloads files through the bitstreamcontent repository 2018-08-30 07:55:10 +02:00
Mark H. Wood
173b7f4fce [DS-3990] Invent curation run parameters. 2018-08-28 10:46:00 -04:00
Luigi Andrea Pascarelli
25e3a69b8f DS-3851 Configurable Workflow endpoints 2018-08-27 20:20:24 +02:00
Luigi Andrea Pascarelli
c0066d2a2f DS-3850 Create new submissions from files or identifiers 2018-08-26 10:42:14 +02:00
Tim Donohue
66b89a786d Merge pull request #1976 from atmire/DS-3542_Spring-permission-evaluator
DS-3542 Spring security authorizations 2
2018-08-23 14:26:30 -05:00
Tim Donohue
d43aba5131 Merge pull request #2179 from 4Science/DS-3905_2
DS-3905 Implement a generic uuid lookup endpoint (DSpaceObjectService based)
2018-08-23 12:29:45 -05:00
Raf Ponsaerts
928ae19d1d Applied the feedback 2018-08-23 14:41:54 +02:00
Raf Ponsaerts
02fb1f4077 [DS-3741] removed unecessary import in comments and removed unused parameter of method 2018-08-23 14:41:54 +02:00
Raf Ponsaerts
154177db49 [DS-3741] fixed limit-offset switch in method call 2018-08-23 14:41:54 +02:00
Raf Ponsaerts
d0889f858c [DS-3741] fixed checkstyle 2018-08-23 14:41:54 +02:00
Raf Ponsaerts
ae53acfcb7 [DS-3741] Fixed findByMetadataQuery in ItemDAOImpl 2018-08-23 14:41:54 +02:00
Raf Ponsaerts
07a76d394b [DS-3741] added documentation to the AbstractHibernateDAO class 2018-08-23 14:41:53 +02:00
Raf Ponsaerts
b95a55d3d0 Applied the community feedback regarding the PR 2018-08-23 14:41:53 +02:00
Raf Ponsaerts
a12c22a767 Removed a bunch of unnecessary code in comments 2018-08-23 14:41:53 +02:00
Raf Ponsaerts
a33f5de0df [DS 3741] fixed checkstyle in DAOImpl classes 2018-08-23 14:41:53 +02:00
Tom Desair
db0a898c42 DS-3741: Added dspace-api/target/generated-sources/annotations to Coveralls source directories 2018-08-23 14:41:12 +02:00
Raf Ponsaerts
0491247c6d [DS-3741] fixes after cherry-picking 2018-08-23 14:41:12 +02:00
Raf Ponsaerts
1745640bbc [DS-3741] fixed wrong and/or usage and wrote the last query" 2018-08-23 14:40:32 +02:00
Raf Ponsaerts
877b84fda6 [DS-3741] fixed the two resultTransformer queries 2018-08-23 14:40:09 +02:00
Raf Ponsaerts
6f5b9cddc6 [DS-3741] cleaned up code in comments 2018-08-23 14:40:08 +02:00
Raf Ponsaerts
7385ce5b04 [DS-3741] All DSpace test cases succeed, 3 DAO functions left unwritten 2018-08-23 14:39:24 +02:00
Tom Desair
e69ebcfe82 DS-3741: Changed setTimestamp to setParameter + added subquery example 2018-08-23 14:38:58 +02:00
Raf Ponsaerts
e16857ce9e [DS-3741] fixes after cherry-pick 2018-08-23 14:38:58 +02:00
Andrea Bollini
ccb81d5091 Use the RestModel getTypePlural convenient method 2018-08-22 22:23:33 +02:00
Andrea Bollini
7c691d8086 Add addition test to cover the residual DSpaceObject types 2018-08-22 21:26:18 +02:00
Andrea Bollini
23f4ebc6c2 Move to a DSpaceService lookup strategy (DBMS) 2018-08-22 21:25:55 +02:00
Tom Desair
cad1b5a10e DS-3542: Fixes after rebase 2018-08-22 15:49:33 +02:00
Tom Desair
798264c001 DS-3542: Restore DSpaceRestRepository methods with authorizations checking 2018-08-22 14:34:44 +02:00
Tom Desair
5d257f4423 DS-3542: Correct DSO Admin level check 2018-08-22 14:34:44 +02:00
Tom Desair
93bac51ead DS-3542: Added custom DSpace AuthenticationEntryPoint in order to return 401 status 2018-08-22 14:34:43 +02:00
Tom Desair
44a0f9b2de DS-3542: Renamed EPERSON Spring security grant to AUTHENTICATED 2018-08-22 14:34:43 +02:00
Tom Desair
0dede9eacb DS-3542: Spring Authorization - @Preauthorization 2018-08-22 14:34:33 +02:00
Yana De Pauw
302c877d21 DS-3542: Spring Authorization - @Preauthorization 2018-08-22 14:32:40 +02:00
frederic
295d6d6ba1 DS-3542: Spring permission evaluator for REST API 2018-08-22 14:03:26 +02:00
Tim Donohue
238ede5f9d Merge pull request #2010 from mohideen/patch-1
DS-3885. Minor fix on CommunityServiceImpl.java
2018-08-21 15:57:25 -05:00
Pablo Prieto
c0f31e889f CheckStyle Fixes 2018-08-17 16:01:49 -05:00
Pablo Prieto
cd94bbd0ee Checkstyle errors fixed
Added ITs for startsWith + Scope
2018-08-17 12:15:42 -05:00
Andrea Bollini
14338cc183 DS-3905 Implement a generic uuid lookup endpoint
Refactor common code from the IdentifierRestController in a generic DSpaceObject converter
Added ITs
Add handling of standard Spring Bind exception to conform with REST return code (422) usage
2018-08-17 12:20:34 +02:00
Pablo Prieto
c02a5aa778 Wrote Integration Tests 2018-08-16 18:55:50 -05:00
Pablo Prieto
de29b6af46 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3904 2018-08-16 15:17:19 -05:00
Tim Donohue
3f7e2363c7 Merge pull request #2126 from 4Science/DS-3735
DS-3735 DS-3924 DS-3737 Implement CREATE, DELETE and some search methods for the EPersons endpoint
2018-08-16 15:07:25 -05:00
Pablo Prieto
322460827c Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3904 2018-08-16 00:40:29 -05:00
Pablo Prieto
e25a732e6b Implemented startsWith for Items 2018-08-16 00:35:19 -05:00
Pablo Prieto
cbaad2e714 Implemented method for Browser Entries 2018-08-13 16:52:04 -05:00
Mark H. Wood
7bb8a8e9c4 [DS-3980] Conform to coding standard. 2018-08-13 15:23:18 -04:00
Mark H. Wood
81b41a2b78 [DS-3980] Replace absurd MIME types with 'application/octet-stream'. 2018-08-13 14:42:56 -04:00
Mark H. Wood
07c7fee64f [DS-3970] Remove confusing log message. 2018-08-13 12:55:13 -04:00
Andrea Bollini
0361ed77a5 Use better variable name and remove not thrown exception declaration 2018-08-11 10:08:58 +02:00
Tim Donohue
e65f94da0c Merge pull request #2135 from terrywbradyC9/dockerMaster
[DS-3967] 7x - Migrate Dockerfile to DSpace/DSpace
2018-08-10 09:51:50 -05:00
Tim Donohue
cb3b4d20cd Merge pull request #2163 from atmire/DS-3489_Search-REST-endpoint-Angular-alignment-rebased-on-master
DS-3489: search rest endpoint angular alignment rebased on master
2018-08-09 16:09:35 -05:00
Tim Donohue
063219add8 Merge pull request #2108 from ppmdo/DS-3910
DS-3910 Delete method on item endpoint
2018-08-09 11:03:39 -05:00
Raf Ponsaerts
6dbe089861 [DS-3489] fixed tests and travis failure 2018-08-09 10:22:26 +02:00
Raf Ponsaerts
587a807bec Removed facetLimit checks in the facetEntryMatcher since this is configurable and should never be hardcoded in tests 2018-08-09 10:22:26 +02:00
Raf Ponsaerts
a979392150 [DS-3489] editted the facet limit to be better handable for Angular 2018-08-09 10:22:26 +02:00
Raf Ponsaerts
db6c9faf83 Fixed rebase conflits 2018-08-09 10:22:06 +02:00
Pablo Prieto
84c123a547 Changed createTemplateItem to collection.withTemplateItem() to keep code coherency.
Applied changes to ItemRestRepositoryIT to work using withTemplateItem
2018-08-07 18:21:42 -05:00
Pablo Prieto
a25a046ffa Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3910 2018-08-07 17:46:10 -05:00
Tim Donohue
544536ccef Merge pull request #2158 from Georgetown-University-Libraries/ds3795m
[DS-3795] Manage versions of some buggy transitive dependencies. (for master)
2018-08-07 12:48:43 -05:00
Tim Donohue
ac1ea060ef Merge duplicate dependencies up in Parent POM 2018-08-07 16:48:32 +00:00
Tim Donohue
d5b0b8b43a Merge pull request #2159 from tdonohue/ds3993-master
DS-3933 Updated Pubmed endpoints from http:// to https:// (for master)
2018-08-07 11:35:24 -05:00
Hendrik Geßner
dac12e1233 DS-3933 Updated Pubmed endpoints from http:// to https://. 2018-08-07 15:32:29 +00:00
Tim Donohue
500b2648a1 Merge pull request #2156 from Georgetown-University-Libraries/ds3700m
DS-3700: MediaFilterServiceImpl forgot to close an input stream (for master)
2018-08-07 10:25:12 -05:00
Tim Donohue
99aa4e0cfb Fix dependency convergence issues in new REST API. Add in a few missing changes. 2018-08-07 15:18:23 +00:00
Terry Brady
97a1180f6b fix ver override 2018-08-06 15:45:55 -07:00
Terry Brady
4a604488a7 fix migration/copy errs 2018-08-06 15:35:14 -07:00
Terry Brady
cc6bf1a343 Merge branch 'master' into ds3795m 2018-08-06 15:02:21 -07:00
Terry Brady
19172012b4 port pr2082 2018-08-06 15:00:02 -07:00
Tim Donohue
b159aa901a Merge pull request #2157 from Georgetown-University-Libraries/ds3629m
Ds 3629 listing of all groups misses pagination - XMLUI (for master)
2018-08-06 16:44:48 -05:00
Tim Donohue
a85228bd24 Merge pull request #2059 from MW3000/DS-3693-port-to-master-add-plugin-to-index-filenames-and-file-descriptions-for-files-in-ORIGINAL-bundle
[DS-3693] Port pull request #1838 to master
2018-08-06 16:42:35 -05:00
Tim Donohue
90d0bbccee Merge pull request #2144 from Georgetown-University-Libraries/ds3377m
[DS-3377] Solr queries too long (change search GET requests to POST) (for master)
2018-08-06 16:36:45 -05:00
Tim Donohue
2760c95099 Merge pull request #2155 from Georgetown-University-Libraries/ds3768m
DS-3768 Fixes the harvest solr parse error by (for master)
2018-08-06 16:24:44 -05:00
Tim Donohue
643f0fcde7 Merge pull request #2154 from Georgetown-University-Libraries/ds3310m
[DS-3310] Fix authentication problem in SwordV2 implementation (for master)
2018-08-06 16:19:34 -05:00
Tim Donohue
950c97bf6e Merge pull request #2153 from Georgetown-University-Libraries/ds3856m
DS-3856 - foreignkey-constraint community2community_child_comm_id_fkey (for master)
2018-08-06 16:15:09 -05:00
Tim Donohue
c038d76ced Merge pull request #2151 from Georgetown-University-Libraries/ds3822m
[DS-3822] Don't guess XML structure during ingest (for master)
2018-08-06 16:12:09 -05:00
Tim Donohue
ea9efd7fa3 Merge pull request #2152 from Georgetown-University-Libraries/ds3707m
DS-3707, DS-3715: Fixes to item level embargo/privacy in OAI-PMH (for master)
2018-08-06 16:09:45 -05:00
Tim Donohue
cbd5980368 Merge pull request #2150 from Georgetown-University-Libraries/ds3769m
DS-3769 Set the right hibernate property of … (for master)
2018-08-06 15:48:56 -05:00
Tim Donohue
3c4d5042fb Add in a single missing METHOD.POST 2018-08-06 20:46:20 +00:00
Tim Donohue
74f47de1e2 Add in missing javadocs. Revert small, accidental change. 2018-08-06 20:43:41 +00:00
Terry Brady
1b68a02dd7 Merge branch 'master' into DS-3693-port-to-master-add-plugin-to-index-filenames-and-file-descriptions-for-files-in-ORIGINAL-bundle 2018-08-06 13:23:52 -07:00
Terry Brady
79709ef76a port PR1864 2018-08-06 13:13:23 -07:00
Tim Donohue
21b628a792 Merge pull request #2149 from Georgetown-University-Libraries/ds3702m
DS-3702 & DS-3703: Rebuild the old behavior of bitstreams during vers… (for master)
2018-08-06 15:13:07 -05:00
Terry Brady
c4cf5b3c8d Merge pull request #2054 from tdonohue/DS-3447-ORCID-v2-master-port
DS-3447: ORCID v2 integration (port to master from PR#2039)
2018-08-06 13:08:31 -07:00
Tim Donohue
49947808a2 Merge pull request #2148 from Georgetown-University-Libraries/ds3680m
DS-3681: Refactoring of DSpaceAuthorityIndexer (for master)
2018-08-06 15:00:56 -05:00
Tim Donohue
8bf8a9fa69 Merge pull request #2147 from Georgetown-University-Libraries/ds3616m
DS-3616] Fix nested vocabulary search (master)
2018-08-06 14:51:28 -05:00
Tim Donohue
527dd1f64a Merge pull request #2146 from Georgetown-University-Libraries/ds3522m
DS-3522: Ensure Submission Policies are removed in XMLWorkflow (for master)
2018-08-06 14:46:16 -05:00
Tim Donohue
794dbfd550 Merge pull request #2145 from Georgetown-University-Libraries/ds3498m
DS-3498 quick fix. Disable full text snippets in search results & add warning (for master)
2018-08-06 14:43:12 -05:00
Tim Donohue
64493d24ca Merge pull request #2143 from Georgetown-University-Libraries/ds3332m
[DS-3332] Handle resolver is hardcoded in org.dspace.handle.UpdateHandlePrefix (for master)
2018-08-06 14:23:23 -05:00
Tim Donohue
c65755653b Merge pull request #2142 from Georgetown-University-Libraries/ds2675m
DS-2675: Bugfixing: Jump to value general errors with order (for master)
2018-08-06 14:14:27 -05:00
Terry Brady
f159c70d1c modify method signature 2018-08-06 12:09:56 -07:00
Terry Brady
1ab41bb4d1 checkstyle fix 2018-08-06 12:06:01 -07:00
Terry Brady
b9a7204420 port 1848 to master 2018-08-06 12:02:05 -07:00
Terry Brady
5437f7f8b9 port pr1890 minus jspui 2018-08-06 11:43:45 -07:00
Terry Brady
d396cf3490 checkstyle fix 2018-08-06 11:37:25 -07:00
Terry Brady
0b33907f5e port pr 1910 2018-08-06 11:33:49 -07:00
Terry Brady
0ced11c0af port pr1973 2018-08-06 11:25:22 -07:00
Terry Brady
33edc9530e checkstyle fix 2018-08-06 11:07:58 -07:00
Terry Brady
06ca8809e1 port PR 1867 2018-08-06 10:17:52 -07:00
Terry Brady
15d100050c port 1941 2018-08-03 23:28:33 -07:00
Terry Brady
ebb738e3e2 port pr1891 2018-08-03 23:24:06 -07:00
Terry Brady
9747d051a5 fix checkstyle 2018-08-03 23:18:18 -07:00
Terry Brady
7af1958d7e port pr1883 2018-08-03 23:12:38 -07:00
Terry Brady
fe648a678e port pr1835 2018-08-03 22:57:27 -07:00
Terry Brady
dfd0250ac1 port pr1770 2018-08-03 22:27:32 -07:00
Terry Brady
32399ac00b port pr 1779 2018-08-03 22:23:07 -07:00
Terry Brady
9bcaa07bce checkstyle fix 2018-08-03 22:16:53 -07:00
Terry Brady
c1590ce15e port pr2069 2018-08-03 17:53:03 -07:00
Terry Brady
220c8a5a48 checkstyle fix 2018-08-03 17:47:31 -07:00
Terry Brady
58855cd632 port pr2045 2018-08-03 17:40:56 -07:00
Terry Brady
77d67537f7 port pr1839 minus xmlui 2018-08-03 17:15:23 -07:00
Terry Brady
3eaaa5bb96 port pr1730 minus xmlui 2018-08-03 16:50:22 -07:00
Pablo Prieto
cb7c2519a3 Merge branch 'DS-3910' of https://github.com/ppmdo/DSpace into DS-3910 2018-08-03 16:56:06 -05:00
Pablo Prieto
ef67916563 Added JavaDoc for createTemplateItem 2018-08-03 16:54:56 -05:00
Tim Donohue
3eb16056c6 Merge pull request #2109 from atmire/DS-3489_Search-REST-query-filter-operator-and-facet-prefix
DS-3489: Search API query filter operator and facet prefix
2018-08-03 15:20:52 -05:00
Pablo
c076c99686 Merge branch 'master' into DS-3910 2018-08-02 11:15:11 -05:00
Terry Brady
5ba8bdd42b usage comment for docker local.cfg 2018-08-01 19:03:09 -07:00
Terry Brady
8f61b926bc move Dockerfile 2018-08-01 15:59:31 -07:00
Oliver Goldschmidt
b00bae2c23 improves error display for disabled opensearch and invalid format 2018-08-01 11:13:13 +02:00
Raf Ponsaerts
5b717bfa35 [DS-3489] added and finalized javadocs 2018-07-27 13:11:16 +02:00
Terry Brady
308dbe95e2 add usage 2018-07-25 17:58:15 -07:00
Terry Brady
27545eb088 DSpace 7 Docker migrate 2018-07-25 16:49:06 -07:00
Mark H. Wood
628c1250c2 Merge pull request #2031 from mwoodiupui/DS-3895
[DS-3895] Bitstream size can't be referenced in HQL queries
2018-07-25 11:54:08 -04:00
Oliver Goldschmidt
f3bdbe43cf support enable/disable of OpenSearch module from config file 2018-07-23 10:53:50 +02:00
Oliver Goldschmidt
d903daadce turn on opensearch in local.cfg, adopts new URL path in default configuration 2018-07-23 10:17:18 +02:00
Oliver Goldschmidt
be02e510e2 Merge branch 'master' of https://github.com/DSpace/DSpace into dspace7_opensearch 2018-07-20 19:35:41 +02:00
Oliver Goldschmidt
38f094caa8 adds rpp and start parameter 2018-07-20 19:28:46 +02:00
Raf Ponsaerts
bfac8d1d4b [DS-3489] adding javadocs and addressed a few issues 2018-07-19 15:50:40 +02:00
Oliver Goldschmidt
26d6ca9bac adds first draft of OpenSearchContoller 2018-07-19 12:05:19 +02:00
Andrea Bollini
92845557ff Provide javadoc for public and reusable methods 2018-07-19 12:01:05 +02:00
Andrea Bollini
9214ffa732 Create EPerson (draft) 2018-07-19 11:16:58 +02:00
Andrea Bollini
38a6e7ad9b Implement the delete eperson method 2018-07-19 11:16:58 +02:00
Andrea Bollini
9f2ca2633f IT for delete eperson 2018-07-19 11:16:58 +02:00
Andrea Bollini
ac342b4819 Implement the search methods 2018-07-19 11:16:58 +02:00
Andrea Bollini
a2569fe905 Declare eperson search methods mandatory parameters 2018-07-19 11:16:58 +02:00
Andrea Bollini
e248893e2f Add eperson search methods 2018-07-19 11:16:58 +02:00
Andrea Bollini
353eed6f60 Add IT for eperson search methods 2018-07-19 11:16:58 +02:00
Andrea Bollini
f807cc38a3 Fix authz issue on epersons endpoint 2018-07-19 11:16:58 +02:00
Andrea Bollini
516d6af6f4 Highlight authz issue on epersons endpoint 2018-07-19 11:16:50 +02:00
Pablo Prieto
e55846b212 Minor changes based on review. 2018-07-18 11:41:03 -05:00
Tim Donohue
8fb56be144 Merge pull request #1931 from atmire/DS-3782_upgrade-commons-collections-to-version-4
DS-3782 upgrade commons collections to version 4
2018-07-18 11:01:18 -05:00
Tim Donohue
2ede483e2b Add comment to POM about v3 dependency 2018-07-18 10:34:14 -05:00
Tom Desair
5a9edd1b70 DS-3782: Compilation error 2018-07-18 17:12:04 +02:00
Tom Desair
de33709364 DS-3782: Restore lines that should not be modified 2018-07-18 16:44:41 +02:00
Raf Ponsaerts
8ffbec58ca [DS-3782] Upgrade Commons Collections to version 4 2018-07-18 15:53:11 +02:00
Oliver Goldschmidt
eefb535214 setting DSpace classes to debug mode by default 2018-07-18 10:30:16 +02:00
Andrea Bollini
eb2b4184ef Merge pull request #2064 from mspalti/DS-3909
DS-3909: Adding withdraw, reinstate, and isDiscoverable support to item repository.
2018-07-18 00:01:05 +02:00
Chris Herron
b7b7ef3f81 DS-3873 Limit the usage of PDFBoxThumbnail to PDFs 2018-07-17 14:02:31 -04:00
Andrea Bollini
c8a08e4bb9 Code clean & include test about authz issues 2018-07-17 19:33:57 +02:00
Andrea Bollini
6b78459b68 Avoid to hide the internal exceptions 2018-07-17 19:32:44 +02:00
Andrea Bollini
7328d49962 Introduce support for withdrawn in ItemBuilder 2018-07-17 19:31:41 +02:00
Andrea Bollini
bf9d63c363 Merge branch 'master' of https://github.com/DSpace/DSpace into DS-3909 2018-07-17 17:29:55 +02:00
Mark H. Wood
ee71a93a53 [DS-3953] Expose list of metadata namespace files as configuration. 2018-07-13 12:42:44 -04:00
Pablo Prieto
23c2f1a7ca Style corrections 2018-07-12 15:50:22 -05:00
Pablo Prieto
6eb2829b4a Amend 2018-07-12 13:28:20 -05:00
Pablo Prieto
005535fcbf Revert "Removed local configurations"
This reverts commit 71347a3faf.
2018-07-12 13:13:52 -05:00
Pablo Prieto
b38aa1723c Merge branch 'DS-3910' of https://github.com/ppmdo/DSpace into DS-3910 2018-07-12 12:55:36 -05:00
Pablo Prieto
71347a3faf Removed local configurations 2018-07-12 12:54:29 -05:00
Pablo Prieto
7b6ce941df Moved createTemplateItem method to CollectionBuilder class.
Correction: WorkspaceItemBuilder extends AbstractBuiilder
2018-07-12 12:46:46 -05:00
Tim Donohue
25a83f3b3f Merge pull request #2025 from 4Science/DS-3892
DS-3892 add the findBySchema name method
2018-07-12 08:58:10 -05:00
Tim Donohue
82de7bb125 Merge pull request #2107 from KingKrimmson/DS-3939-master
DS-3939 OAI-Harvester, skip item and continue if handle is missing
2018-07-09 09:56:21 -05:00
Tom Desair
91218ed36c DS-3489: Fixing tests after rebase part 2 2018-07-04 14:22:09 +02:00
Pablo Prieto
9ab8904bf2 WorskspaceItemBuilder amend 2018-07-02 16:25:36 -05:00
Chris Herron
ddbe928cd3 DS-3939 OAI-Harvester, skip item and continue if handle is missing 2018-07-02 12:45:57 -04:00
Tom Desair
ad1a3310f0 DS-3489: Fixing tests after rebase part 1 2018-07-02 17:31:02 +02:00
Pablo Prieto
fe2030d024 Working Implementation
Wrote additional integration tests
Created WorkspaceItemBuilder
2018-06-29 16:51:11 -05:00
Tom Desair
3dc2024265 DS-3489: Fix test 2018-06-29 17:18:31 +02:00
Tom Desair
4acde3df79 DS-3489: Integration test for facet prefix 2018-06-29 17:01:26 +02:00
Raf Ponsaerts
db0a3cd756 [DS-3489] finished implementing the search query filter operator. Also fixed a not equals issue in standard dspace 2018-06-29 16:42:52 +02:00
Tom Desair
4d0382766c DS-3489: Add support for facet prefix 2018-06-29 16:35:03 +02:00
Raf Ponsaerts
b805baddf5 [DS-3489] currently have most of the functionality, need to export the enum to xml still 2018-06-29 16:34:17 +02:00
Raf Ponsaerts
e98af34e21 [DS-3489] currently have most of the functionality, need to export the enum to xml still 2018-06-29 16:31:22 +02:00
Pablo Prieto
a487fb7d58 Working method to DELETE on /api/core/items
Wrote integration tests
2018-06-28 19:12:24 -05:00
Terry Brady
06ed982031 Merge pull request #1974 from atmire/DS-3819_Return-303-when-Shibboleth-redirect-is-needed
DS-3819: Return HTTP redirect when login URL is supported
2018-06-28 09:57:42 -06:00
Tom Desair
a921a86422 DS-3819: Test fixes 2018-06-28 14:46:02 +02:00
Yana De Pauw
5a1202222f DS-3819: Add button for authentication method with location parameter when multiple authentication methods are present 2018-06-28 13:21:58 +02:00
Tom Desair
55f5571e1d [DS-3819] Revert back to 401 status and move login URL to WWW-Authenticate header 2018-06-28 13:21:57 +02:00
Tom Desair
93549cab24 DS-3819: Correct response code and added Shibboleth Special Groups test 2018-06-28 13:21:54 +02:00
Tom Desair
ecce5fe9b2 DS-3819: Return HTTP redirect when login URL is supported 2018-06-28 13:21:09 +02:00
Pablo Prieto
3a51c7a962 Added method 2018-06-27 19:03:25 -05:00
Andrea Bollini
7d03da0fea DS-3892 refactor common code and align IT class name with our convention 2018-06-22 09:52:04 +02:00
Andrea Bollini
43eda56269 Merge pull request #2077 from 4Science/DS-3838
DS-3838 return 204 for successful logout
2018-06-21 16:56:17 +02:00
Andrea Bollini
f00d31e370 Align comment with the actual code/expectation 2018-06-21 16:05:36 +02:00
Andrea Bollini
b15a0027b7 Merge pull request #2073 from 4Science/minor-fixes
DS-3923 manage null return in Search Methods
2018-06-21 15:51:43 +02:00
Michael W Spalti
52401d0719 [DS-3909] Implements ItemRepository patch method for withdrawal and discoverable (using a proposed helper class).
[DS-3909] Added base class and item implementation for patch requests.

[DS-3090] Added new Spring component for the ItemPatch implementation and autowired it into ItemRestRepository.

[DS-3909] Added new exception for item operation path and corrected a few exception messages.

[DS-3909] Modified integration tests and test builders.

[DS-3909] Integration tests for withdraw and reinstate would not complete without adding REMOVE, ADD, and WRITE permissions to the collection and item mocks.  New builder methods added to set permissions.

[DS-3909] Some cleanup in integration test builder methods.

[DS-3090] Removed unused imports.

[DS-3909] Corrections to patch operation paths and values.

[DS-3909] Updates to exceptions and code documentation.

[DS-3090] Added test for missing value in withdrawal request.

[D-3909] Added exception for missing boolean value in discoverable operations.

[DS-3909] Corrected formatting error.

[DS-3909] Changed default error response for operation processing in AbstractResourcePatch to PatchBadRequestException.

[DS-3909] Code comments and javadoc.

[DS-3909] Minor changes to method visibility and documentation.

[DS-3909] Added copy operation to mirror JsonPatchConverter and change visibility of the sub-class replace method.

[DS-3909] Updating PR change requests.

[DS-3909] Minor corrections to ItemPatch.

[3909] Javadoc updates.

[DS-3909] Removed test code that is not necessary when tests are ran as admin user.

Also added ResourceNotFoundException to controller patch method.

[DS-3909] Minor formating correction.

[DS-3909] Removed unused field from ItemBuilder.
2018-06-16 14:43:51 -07:00
Andrea Bollini
40fc109c7c DS-3838 return 204 for successful logout 2018-06-09 21:29:22 +02:00
Andrea Bollini
d5d2fe0e68 Complete ITs and implementation 2018-06-09 18:06:04 +02:00
Andrea Bollini
18046604a7 Improve support for Parameter in search methods 2018-06-09 18:05:04 +02:00
Andrea Bollini
bc2d9e0706 Fix findBySchema implementation for undefined schema 2018-06-09 16:34:24 +02:00
Andrea Bollini
7f68244c4e Add test for search methods 2018-06-09 16:34:24 +02:00
Andrea Bollini
6b74ef5544 Add priority to force cleanup in a specfic order 2018-06-09 16:34:24 +02:00
Andrea Bollini
a87baf6edb Fix checkstyle issues 2018-06-09 16:34:24 +02:00
Andrea Bollini
7e6d1a58ec DS-3892 add the findBySchema name method 2018-06-09 16:34:23 +02:00
Andrea Bollini
6af5349e74 DS-3923 manage null return in Search Methods 2018-06-01 07:13:08 +02:00
Andrea Bollini
af758212f7 Cleanup license header 2018-06-01 07:13:08 +02:00
Andrea Bollini
a6c1113165 Exclude rebel.xml configuration from license:check 2018-05-31 21:11:51 +02:00
Andrea Bollini
27ee3a13f0 Fix NPE when a valid JWT related to a deleted eperson is presented 2018-05-31 21:11:51 +02:00
Andrea Bollini
7157c43bc1 Fix admin eperson in test 2018-05-31 21:11:36 +02:00
Michael W Spalti
416fc80010 [DS-3909] Corrects UUID bug in RestResourceController. 2018-05-30 13:35:41 -07:00
Raf Ponsaerts
d1f8c56be5 Fixed a bug which caused the query OR without quotes to crash 2018-05-18 11:56:11 +02:00
Martin Walk
388858de14 Adapt integration tests to added search filters 2018-05-15 10:43:06 +02:00
Tim Donohue
e6d5254eff Temporary POM exclusion to avoid dependency conflict 2018-05-14 16:39:15 -05:00
Raf Ponsaerts
5c7e5ee4e2 Added the tests for the facet min/max values on the search/xx endpoint 2018-05-14 16:18:55 +02:00
Martin Walk
e29b72d228 Trigger Travis build 2018-05-14 15:06:07 +02:00
Martin Walk
5970b3ccfa Please the Checkstyle plugin 2018-05-14 14:41:58 +02:00
Martin Walk
5f52704ce5 Try to please the Checkstyle plugin :) 2018-05-14 14:18:21 +02:00
Raf Ponsaerts
7acaa69c95 Implemented the expose min-max on the facets in the search/xx endpoints 2018-05-14 13:50:15 +02:00
Martin Walk
3b62f4de86 Port pull request #1838 to master 2018-05-14 13:48:17 +02:00
Raf Ponsaerts
6b57003e34 Working on the min-max facet implementation 2018-05-14 08:29:52 +02:00
Tim Donohue
032a76ddb8 DS-3447: ORCID v2 integration (port to master from PR#2039) 2018-05-10 16:38:10 -05:00
Tom Desair
e62d63f343 DS-3489: Fix bugs to address test failures 2018-04-30 11:53:51 +02:00
Tom Desair
f2e2d01560 DS-3489: Improvements on /search/discover/facets 2018-04-30 11:53:36 +02:00
Tom Desair
b0e7994520 DS-3489: Fix search result object pagination links 2018-04-30 11:53:36 +02:00
Raf Ponsaerts
bc581e64e0 [DS-3489] updated the /api/discover/search endpoint to be more compatible with angular's expectations 2018-04-30 11:53:27 +02:00
Raf Ponsaerts
519f0a812c [DS-3489] added the facetLimit property to the buildFacetQueries for dates, reversed the order of the returned list to show the oldest pair first 2018-04-30 11:48:00 +02:00
Raf Ponsaerts
e36ded0244 [DS-3489] updated the /api/discover/search endpoint to be more compatible with angular's expectations 2018-04-30 11:47:59 +02:00
Mark H. Wood
24575d8ba1 [DS-3895] Rename Bitstream.getSize() to getSizeBytes(). 2018-04-23 13:29:31 -04:00
Mohamed Mohideen Abdul Rasheed
6d1b695ca5 Minor fix on CommunityServiceImpl.java
Update methods should call clearModified.
2018-03-29 15:46:02 -04:00
Mark H. Wood
d585b3a9f1 [DS-2670] First attempt 2017-10-11 11:43:16 -04:00
Terry W Brady
287cc56476 Port 6x to 7x 2017-07-14 09:46:23 -07:00
3748 changed files with 389712 additions and 114265 deletions

28
.codecov.yml Normal file
View File

@@ -0,0 +1,28 @@
# DSpace configuration for Codecov.io coverage reports
# These override the default YAML settings at
# https://docs.codecov.io/docs/codecov-yaml#section-default-yaml
# Can be validated via instructions at:
# https://docs.codecov.io/docs/codecov-yaml#validate-your-repository-yaml
# Settings related to code coverage analysis
coverage:
status:
# Configuration for project-level checks. This checks how the PR changes overall coverage.
project:
default:
# For each PR, auto compare coverage to previous commit.
# Require that overall (project) coverage does NOT drop more than 0.5%
target: auto
threshold: 0.5%
# Configuration for patch-level checks. This checks the relative coverage of the new PR code ONLY.
patch:
default:
# Enable informational mode, which just provides info to reviewers & always passes
# https://docs.codecov.io/docs/commit-status#section-informational
informational: true
# Turn PR comments "off". This feature adds the code coverage summary as a
# comment on each PR. See https://docs.codecov.io/docs/pull-request-comments
# However, this same info is available from the Codecov checks in the PR's
# "Checks" tab in GitHub. So, the comment is unnecessary.
comment: false

10
.dockerignore Normal file
View File

@@ -0,0 +1,10 @@
.git/
.idea/
.settings/
*/target/
dspace/modules/*/target/
Dockerfile.*
dspace/src/main/docker/dspace-postgres-pgcrypto
dspace/src/main/docker/dspace-postgres-pgcrypto-curl
dspace/src/main/docker/README.md
dspace/src/main/docker-compose/

6
.gitattributes vendored
View File

@@ -1,6 +1,12 @@
# Auto detect text files and perform LF normalization
* text=auto
# Ensure Unix files always keep Unix line endings
*.sh text eol=lf
# Ensure Windows files always keep Windows line endings
*.bat text eol=crlf
# Standard to msysgit
*.doc diff=astextplain
*.DOC diff=astextplain

22
.github/ISSUE_TEMPLATE/bug_report.md vendored Normal file
View File

@@ -0,0 +1,22 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug, needs triage
assignees: ''
---
**Describe the bug**
A clear and concise description of what the bug is. Include the version(s) of DSpace where you've seen this problem. Link to examples if they are public.
**To Reproduce**
Steps to reproduce the behavior:
1. Do this
2. Then this...
**Expected behavior**
A clear and concise description of what you expected to happen.
**Related work**
Link to any related tickets or PRs here.

View File

@@ -0,0 +1,20 @@
---
name: Feature request
about: Suggest a new feature for this project
title: ''
labels: new feature, needs triage
assignees: ''
---
**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives or workarounds you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
Add any other context or screenshots about the feature request here.

118
.github/dependabot.yml vendored Normal file
View File

@@ -0,0 +1,118 @@
#-------------------
# DSpace's dependabot rules. Enables maven updates for all dependencies on a weekly basis
# for main and any maintenance branches. Security updates only apply to main.
#-------------------
version: 2
updates:
- package-ecosystem: "maven"
directory: "/"
schedule:
interval: "weekly"
# Allow up to 10 open PRs for dependencies
open-pull-requests-limit: 10
# Group together some upgrades in a single PR
groups:
# Group together all Build Tools in a single PR
build-tools:
applies-to: version-updates
patterns:
- "org.apache.maven.plugins:*"
- "*:*-maven-plugin"
- "*:maven-*-plugin"
- "com.github.spotbugs:spotbugs"
- "com.google.code.findbugs:*"
- "com.google.errorprone:*"
- "com.puppycrawl.tools:checkstyle"
- "org.sonatype.plugins:*"
exclude-patterns:
# Exclude anything from Spring, as that is in a separate group
- "org.springframework.*:*"
update-types:
- "minor"
- "patch"
test-tools:
applies-to: version-updates
patterns:
- "junit:*"
- "com.github.stefanbirker:system-rules"
- "com.h2database:*"
- "io.findify:s3mock*"
- "io.netty:*"
- "org.hamcrest:*"
- "org.mock-server:*"
- "org.mockito:*"
update-types:
- "minor"
- "patch"
# Group together all Apache Commons deps in a single PR
apache-commons:
applies-to: version-updates
patterns:
- "org.apache.commons:*"
- "commons-*:commons-*"
update-types:
- "minor"
- "patch"
# Group together all fasterxml deps in a single PR
fasterxml:
applies-to: version-updates
patterns:
- "com.fasterxml:*"
- "com.fasterxml.*:*"
update-types:
- "minor"
- "patch"
# Group together all Hibernate deps in a single PR
hibernate:
applies-to: version-updates
patterns:
- "org.hibernate.*:*"
update-types:
- "minor"
- "patch"
# Group together all Jakarta deps in a single PR
jakarta:
applies-to: version-updates
patterns:
- "jakarta.*:*"
- "org.eclipse.angus:jakarta.mail"
- "org.glassfish.jaxb:jaxb-runtime"
update-types:
- "minor"
- "patch"
# Group together all Google deps in a single PR
google-apis:
applies-to: version-updates
patterns:
- "com.google.apis:*"
- "com.google.api-client:*"
- "com.google.http-client:*"
- "com.google.oauth-client:*"
update-types:
- "minor"
- "patch"
# Group together all Spring deps in a single PR
spring:
applies-to: version-updates
patterns:
- "org.springframework:*"
- "org.springframework.*:*"
update-types:
- "minor"
- "patch"
# Group together all WebJARs deps in a single PR
webjars:
applies-to: version-updates
patterns:
- "org.webjars:*"
- "org.webjars.*:*"
update-types:
- "minor"
- "patch"
ignore:
# Don't try to auto-update any DSpace dependencies
- dependency-name: "org.dspace:*"
- dependency-name: "org.dspace.*:*"
# Ignore all major version updates for all dependencies. We'll only automate minor/patch updates.
- dependency-name: "*"
update-types: ["version-update:semver-major"]

28
.github/pull_request_template.md vendored Normal file
View File

@@ -0,0 +1,28 @@
## References
_Add references/links to any related issues or PRs. These may include:_
* Fixes #`issue-number` (if this fixes an issue ticket)
* Related to DSpace/RestContract#`pr-number` (if a corresponding REST Contract PR exists)
## Description
Short summary of changes (1-2 sentences).
## Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
* First, ...
* Second, ...
**Include guidance for how to test or review your PR.** This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
## Checklist
_This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!_
- [ ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
- [ ] My PR passes Checkstyle validation based on the [Code Style Guide](https://wiki.lyrasis.org/display/DSPACE/Code+Style+Guide).
- [ ] My PR includes Javadoc for _all new (or modified) public methods and classes_. It also includes Javadoc for large or complex private methods.
- [ ] My PR passes all tests and includes new/updated Unit or Integration Tests based on the [Code Testing Guide](https://wiki.lyrasis.org/display/DSPACE/Code+Testing+Guide).
- [ ] If my PR includes new libraries/dependencies (in any `pom.xml`), I've made sure their licenses align with the [DSpace BSD License](https://github.com/DSpace/DSpace/blob/main/LICENSE) based on the [Licensing of Contributions](https://wiki.lyrasis.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-LicensingofContributions) documentation.
- [ ] If my PR modifies REST API endpoints, I've opened a separate [REST Contract](https://github.com/DSpace/RestContract/blob/main/README.md) PR related to this change.
- [ ] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
- [ ] If my PR fixes an issue ticket, I've [linked them together](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).

112
.github/workflows/build.yml vendored Normal file
View File

@@ -0,0 +1,112 @@
# DSpace Continuous Integration/Build via GitHub Actions
# Concepts borrowed from
# https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-java-with-maven
name: Build
# Run this Build for all pushes / PRs to current branch
on: [push, pull_request]
permissions:
contents: read # to fetch code (actions/checkout)
jobs:
tests:
runs-on: ubuntu-latest
env:
# Give Maven 1GB of memory to work with
MAVEN_OPTS: "-Xmx1024M"
strategy:
# Create a matrix of two separate configurations for Unit vs Integration Tests
# This will ensure those tasks are run in parallel
# Also specify version of Java to use (this can allow us to optionally run tests on multiple JDKs in future)
matrix:
include:
# NOTE: Unit Tests include deprecated REST API v6 (as it has unit tests)
# - surefire.rerunFailingTestsCount => try again for flakey tests, and keep track of/report on number of retries
- type: "Unit Tests"
java: 11
mvnflags: "-DskipUnitTests=false -Pdspace-rest -Dsurefire.rerunFailingTestsCount=2"
resultsdir: "**/target/surefire-reports/**"
# NOTE: ITs skip all code validation checks, as they are already done by Unit Test job.
# - enforcer.skip => Skip maven-enforcer-plugin rules
# - checkstyle.skip => Skip all checkstyle checks by maven-checkstyle-plugin
# - license.skip => Skip all license header checks by license-maven-plugin
# - xml.skip => Skip all XML/XSLT validation by xml-maven-plugin
# - failsafe.rerunFailingTestsCount => try again for flakey tests, and keep track of/report on number of retries
- type: "Integration Tests"
java: 11
mvnflags: "-DskipIntegrationTests=false -Denforcer.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -Dxml.skip=true -Dfailsafe.rerunFailingTestsCount=2"
resultsdir: "**/target/failsafe-reports/**"
# Do NOT exit immediately if one matrix job fails
# This ensures ITs continue running even if Unit Tests fail, or visa versa
fail-fast: false
name: Run ${{ matrix.type }}
# These are the actual CI steps to perform per job
steps:
# https://github.com/actions/checkout
- name: Checkout codebase
uses: actions/checkout@v4
# https://github.com/actions/setup-java
- name: Install JDK ${{ matrix.java }}
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}
distribution: 'temurin'
cache: 'maven'
# Run parallel Maven builds based on the above 'strategy.matrix'
- name: Run Maven ${{ matrix.type }}
env:
TEST_FLAGS: ${{ matrix.mvnflags }}
run: mvn --no-transfer-progress -V install -P-assembly -Pcoverage-report $TEST_FLAGS
# If previous step failed, save results of tests to downloadable artifact for this job
# (This artifact is downloadable at the bottom of any job's summary page)
- name: Upload Results of ${{ matrix.type }} to Artifact
if: ${{ failure() }}
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.type }} results
path: ${{ matrix.resultsdir }}
# Upload code coverage report to artifact, so that it can be shared with the 'codecov' job (see below)
- name: Upload code coverage report to Artifact
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.type }} coverage report
path: 'dspace/target/site/jacoco-aggregate/jacoco.xml'
retention-days: 14
# Codecov upload is a separate job in order to allow us to restart this separate from the entire build/test
# job above. This is necessary because Codecov uploads seem to randomly fail at times.
# See https://community.codecov.com/t/upload-issues-unable-to-locate-build-via-github-actions-api/3954
codecov:
# Must run after 'tests' job above
needs: tests
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
# Download artifacts from previous 'tests' job
- name: Download coverage artifacts
uses: actions/download-artifact@v4
# Now attempt upload to Codecov using its action.
# NOTE: We use a retry action to retry the Codecov upload if it fails the first time.
#
# Retry action: https://github.com/marketplace/actions/retry-action
# Codecov action: https://github.com/codecov/codecov-action
- name: Upload coverage to Codecov.io
uses: Wandalen/wretry.action@v1.3.0
with:
action: codecov/codecov-action@v4
# Ensure codecov-action throws an error when it fails to upload
with: |
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}
# Try re-running action 5 times max
attempt_limit: 5
# Run again in 30 seconds
attempt_delay: 30000

63
.github/workflows/codescan.yml vendored Normal file
View File

@@ -0,0 +1,63 @@
# DSpace CodeQL code scanning configuration for GitHub
# https://docs.github.com/en/code-security/code-scanning
#
# NOTE: Code scanning must be run separate from our default build.yml
# because CodeQL requires a fresh build with all tests *disabled*.
name: "Code Scanning"
# Run this code scan for all pushes / PRs to main or maintenance branches. Also run once a week.
on:
push:
branches:
- main
- 'dspace-**'
pull_request:
branches:
- main
- 'dspace-**'
# Don't run if PR is only updating static documentation
paths-ignore:
- '**/*.md'
- '**/*.txt'
schedule:
- cron: "37 0 * * 1"
jobs:
analyze:
name: Analyze Code
runs-on: ubuntu-latest
# Limit permissions of this GitHub action. Can only write to security-events
permissions:
actions: read
contents: read
security-events: write
steps:
# https://github.com/actions/checkout
- name: Checkout repository
uses: actions/checkout@v4
# https://github.com/actions/setup-java
- name: Install JDK
uses: actions/setup-java@v4
with:
java-version: 11
distribution: 'temurin'
# Initializes the CodeQL tools for scanning.
# https://github.com/github/codeql-action
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
# Codescan Javascript as well since a few JS files exist in REST API's interface
languages: java, javascript
# Autobuild attempts to build any compiled languages
# NOTE: Based on testing, this autobuild process works well for DSpace. A custom
# DSpace build w/caching (like in build.yml) was about the same speed as autobuild.
- name: Autobuild
uses: github/codeql-action/autobuild@v3
# Perform GitHub Code Scanning.
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3

261
.github/workflows/docker.yml vendored Normal file
View File

@@ -0,0 +1,261 @@
# DSpace Docker image build for hub.docker.com
name: Docker images
# Run this Build for all pushes to 'main' or maintenance branches, or tagged releases.
# Also run for PRs to ensure PR doesn't break Docker build process
# NOTE: uses "reusable-docker-build.yml" to actually build each of the Docker images.
on:
push:
branches:
- main
- 'dspace-**'
tags:
- 'dspace-**'
pull_request:
permissions:
contents: read # to fetch code (actions/checkout)
packages: write # to write images to GitHub Container Registry (GHCR)
jobs:
####################################################
# Build/Push the 'dspace/dspace-dependencies' image.
# This image is used by all other DSpace build jobs.
####################################################
dspace-dependencies:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
uses: ./.github/workflows/reusable-docker-build.yml
with:
build_id: dspace-dependencies
image_name: dspace/dspace-dependencies
dockerfile_path: ./Dockerfile.dependencies
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
#######################################
# Build/Push the 'dspace/dspace' image
#######################################
dspace:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
# Must run after 'dspace-dependencies' job above
needs: dspace-dependencies
uses: ./.github/workflows/reusable-docker-build.yml
with:
build_id: dspace-prod
image_name: dspace/dspace
dockerfile_path: ./Dockerfile
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
# Enable redeploy of sandbox & demo if the branch for this image matches the deployment branch of
# these sites as specified in reusable-docker-build.xml
REDEPLOY_SANDBOX_URL: ${{ secrets.REDEPLOY_SANDBOX_URL }}
REDEPLOY_DEMO_URL: ${{ secrets.REDEPLOY_DEMO_URL }}
#############################################################
# Build/Push the 'dspace/dspace' image ('-test' tag)
#############################################################
dspace-test:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
# Must run after 'dspace-dependencies' job above
needs: dspace-dependencies
uses: ./.github/workflows/reusable-docker-build.yml
with:
build_id: dspace-test
image_name: dspace/dspace
dockerfile_path: ./Dockerfile.test
# As this is a test/development image, its tags are all suffixed with "-test". Otherwise, it uses the same
# tagging logic as the primary 'dspace/dspace' image above.
tags_flavor: suffix=-test
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
###########################################
# Build/Push the 'dspace/dspace-cli' image
###########################################
dspace-cli:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
# Must run after 'dspace-dependencies' job above
needs: dspace-dependencies
uses: ./.github/workflows/reusable-docker-build.yml
with:
build_id: dspace-cli
image_name: dspace/dspace-cli
dockerfile_path: ./Dockerfile.cli
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
###########################################
# Build/Push the 'dspace/dspace-solr' image
###########################################
dspace-solr:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
uses: ./.github/workflows/reusable-docker-build.yml
with:
build_id: dspace-solr
image_name: dspace/dspace-solr
dockerfile_path: ./dspace/src/main/docker/dspace-solr/Dockerfile
# Must pass solrconfigs to the Dockerfile so that it can find the required Solr config files
dockerfile_additional_contexts: 'solrconfigs=./dspace/solr/'
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
# Enable redeploy of sandbox & demo SOLR instance whenever dspace-solr image changes for deployed branch.
# These URLs MUST use different secrets than 'dspace/dspace' image build above as they are deployed separately.
REDEPLOY_SANDBOX_URL: ${{ secrets.REDEPLOY_SANDBOX_SOLR_URL }}
REDEPLOY_DEMO_URL: ${{ secrets.REDEPLOY_DEMO_SOLR_URL }}
###########################################################
# Build/Push the 'dspace/dspace-postgres-pgcrypto' image
###########################################################
dspace-postgres-pgcrypto:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
uses: ./.github/workflows/reusable-docker-build.yml
with:
build_id: dspace-postgres-pgcrypto-prod
image_name: dspace/dspace-postgres-pgcrypto
# Must build out of subdirectory to have access to install script for pgcrypto.
# NOTE: this context will build the image based on the Dockerfile in the specified directory
dockerfile_context: ./dspace/src/main/docker/dspace-postgres-pgcrypto/
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
########################################################################
# Build/Push the 'dspace/dspace-postgres-pgcrypto' image (-loadsql tag)
########################################################################
dspace-postgres-pgcrypto-loadsql:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
uses: ./.github/workflows/reusable-docker-build.yml
with:
build_id: dspace-postgres-pgcrypto-loadsql
image_name: dspace/dspace-postgres-pgcrypto
# Must build out of subdirectory to have access to install script for pgcrypto.
# NOTE: this context will build the image based on the Dockerfile in the specified directory
dockerfile_context: ./dspace/src/main/docker/dspace-postgres-pgcrypto-curl/
# Suffix all tags with "-loadsql". Otherwise, it uses the same
# tagging logic as the primary 'dspace/dspace-postgres-pgcrypto' image above.
tags_flavor: suffix=-loadsql
secrets:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_ACCESS_TOKEN: ${{ secrets.DOCKER_ACCESS_TOKEN }}
#################################################################################
# Test Deployment via Docker to ensure newly built images are working properly
#################################################################################
docker-deploy:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
runs-on: ubuntu-latest
# Must run after all major images are built
needs: [dspace, dspace-test, dspace-cli, dspace-postgres-pgcrypto, dspace-solr]
env:
# Override defaults dspace.server.url because backend starts at http://127.0.0.1:8080
dspace__P__server__P__url: http://127.0.0.1:8080/server
# Enable all optional modules / controllers for this test deployment.
# This helps check for errors in deploying these modules via Spring Boot
iiif__P__enabled: true
oai__P__enabled: true
rdf__P__enabled: true
signposting__P__enabled: true
sword__D__server__P__enabled: true
swordv2__D__server__P__enabled: true
# If this is a PR against main (default branch), use "latest".
# Else if this is a PR against a different branch, used the base branch name.
# Else if this is a commit on main (default branch), use the "latest" tag.
# Else, just use the branch name.
# NOTE: DSPACE_VER is used because our docker compose scripts default to using the "-test" image.
DSPACE_VER: ${{ (github.event_name == 'pull_request' && github.event.pull_request.base.ref == github.event.repository.default_branch && 'latest') || (github.event_name == 'pull_request' && github.event.pull_request.base.ref) || (github.ref_name == github.event.repository.default_branch && 'latest') || github.ref_name }}
# Docker Registry to use for Docker compose scripts below.
# We use GitHub's Container Registry to avoid aggressive rate limits at DockerHub.
DOCKER_REGISTRY: ghcr.io
steps:
# Checkout our codebase (to get access to Docker Compose scripts)
- name: Checkout codebase
uses: actions/checkout@v4
# Download Docker image artifacts (which were just built by reusable-docker-build.yml)
- name: Download Docker image artifacts
uses: actions/download-artifact@v4
with:
# Download all amd64 Docker images (TAR files) into the /tmp/docker directory
pattern: docker-image-*-linux-amd64
path: /tmp/docker
merge-multiple: true
# Load each of the images into Docker by calling "docker image load" for each.
# This ensures we are using the images just built & not any prior versions on DockerHub
- name: Load all downloaded Docker images
run: |
find /tmp/docker -type f -name "*.tar" -exec docker image load --input "{}" \;
docker image ls -a
# Start backend using our compose script in the codebase.
- name: Start backend in Docker
run: |
docker compose -f docker-compose.yml up -d
sleep 10
docker container ls
# Create a test admin account. Load test data from a simple set of AIPs as defined in cli.ingest.yml
- name: Load test data into Backend
run: |
docker compose -f docker-compose-cli.yml run --rm dspace-cli create-administrator -e test@test.edu -f admin -l user -p admin -c en
docker compose -f docker-compose-cli.yml -f dspace/src/main/docker-compose/cli.ingest.yml run --rm dspace-cli
# Verify backend started successfully.
# 1. Make sure root endpoint is responding (check for dspace.name defined in docker-compose.yml)
# 2. Also check /collections endpoint to ensure the test data loaded properly (check for a collection name in AIPs)
- name: Verify backend is responding properly
run: |
result=$(wget -O- -q http://127.0.0.1:8080/server/api)
echo "$result"
echo "$result" | grep -oE "\"DSpace Started with Docker Compose\","
result=$(wget -O- -q http://127.0.0.1:8080/server/api/core/collections)
echo "$result"
echo "$result" | grep -oE "\"Dog in Yard\","
# Verify basic backend logging is working.
# 1. Access the top communities list. Verify that the "Before request" INFO statement is logged
# 2. Access an invalid endpoint (and ignore 404 response). Verify that a "status:404" WARN statement is logged
- name: Verify backend is logging properly
run: |
wget -O/dev/null -q http://127.0.0.1:8080/server/api/core/communities/search/top
logs=$(docker compose -f docker-compose.yml logs -n 5 dspace)
echo "$logs"
echo "$logs" | grep -o "Before request \[GET /server/api/core/communities/search/top\]"
wget -O/dev/null -q http://127.0.0.1:8080/server/api/does/not/exist || true
logs=$(docker compose -f docker-compose.yml logs -n 5 dspace)
echo "$logs"
echo "$logs" | grep -o "status:404 exception: The repository type does.not was not found"
# Verify Handle Server can be stared and is working properly
# 1. First generate the "[dspace]/handle-server" folder with the sitebndl.zip
# 2. Start the Handle Server (and wait 20 seconds to let it start up)
# 3. Verify logs do NOT include "Exception" in the text (as that means an error occurred)
# 4. Check that Handle Proxy HTML page is responding on default port (8000)
- name: Verify Handle Server is working properly
run: |
docker exec -i dspace /dspace/bin/make-handle-config
echo "Starting Handle Server..."
docker exec -i dspace /dspace/bin/start-handle-server
sleep 20
echo "Checking for errors in error.log"
result=$(docker exec -i dspace sh -c "cat /dspace/handle-server/logs/error.log* || echo ''")
echo "$result"
echo "$result" | grep -vqz "Exception"
echo "Checking for errors in handle-server.log..."
result=$(docker exec -i dspace cat /dspace/log/handle-server.log)
echo "$result"
echo "$result" | grep -vqz "Exception"
echo "Checking to see if Handle Proxy webpage is available..."
result=$(wget -O- -q http://127.0.0.1:8000/)
echo "$result"
echo "$result" | grep -oE "Handle Proxy"
# Shutdown our containers
- name: Shutdown Docker containers
run: |
docker compose -f docker-compose.yml down

26
.github/workflows/issue_opened.yml vendored Normal file
View File

@@ -0,0 +1,26 @@
# This workflow runs whenever a new issue is created
name: Issue opened
on:
issues:
types: [opened]
permissions: {}
jobs:
automation:
runs-on: ubuntu-latest
steps:
# Add the new issue to a project board, if it needs triage
# See https://github.com/actions/add-to-project
- name: Add issue to triage board
# Only add to project board if issue is flagged as "needs triage" or has no labels
# NOTE: By default we flag new issues as "needs triage" in our issue template
if: (contains(github.event.issue.labels.*.name, 'needs triage') || join(github.event.issue.labels.*.name) == '')
uses: actions/add-to-project@v1.0.0
# Note, the authentication token below is an ORG level Secret.
# It must be created/recreated manually via a personal access token with admin:org, project, public_repo permissions
# See: https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token#permissions-for-the-github_token
# This is necessary because the "DSpace Backlog" project is an org level project (i.e. not repo specific)
with:
github-token: ${{ secrets.TRIAGE_PROJECT_TOKEN }}
project-url: https://github.com/orgs/DSpace/projects/24

View File

@@ -0,0 +1,39 @@
# This workflow checks open PRs for merge conflicts and labels them when conflicts are found
name: Check for merge conflicts
# Run this for all pushes (i.e. merges) to 'main' or maintenance branches
on:
push:
branches:
- main
- 'dspace-**'
# So that the `conflict_label_name` is removed if conflicts are resolved,
# we allow this to run for `pull_request_target` so that github secrets are available.
pull_request_target:
types: [ synchronize ]
permissions: {}
jobs:
triage:
# Ensure this job never runs on forked repos. It's only executed for 'dspace/dspace'
if: github.repository == 'dspace/dspace'
runs-on: ubuntu-latest
permissions:
pull-requests: write
steps:
# See: https://github.com/prince-chrismc/label-merge-conflicts-action
- name: Auto-label PRs with merge conflicts
uses: prince-chrismc/label-merge-conflicts-action@v3
# Ignore any failures -- may occur (randomly?) for older, outdated PRs.
continue-on-error: true
# Add "merge conflict" label if a merge conflict is detected. Remove it when resolved.
# Note, the authentication token is created automatically
# See: https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token
with:
conflict_label_name: 'merge conflict'
github_token: ${{ secrets.GITHUB_TOKEN }}
conflict_comment: |
Hi @${author},
Conflicts have been detected against the base branch.
Please [resolve these conflicts](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/about-merge-conflicts) as soon as you can. Thanks!

View File

@@ -0,0 +1,46 @@
# This workflow will attempt to port a merged pull request to
# the branch specified in a "port to" label (if exists)
name: Port merged Pull Request
# Only run for merged PRs against the "main" or maintenance branches
# We allow this to run for `pull_request_target` so that github secrets are available
# (This is required when the PR comes from a forked repo)
on:
pull_request_target:
types: [ closed ]
branches:
- main
- 'dspace-**'
permissions:
contents: write # so action can add comments
pull-requests: write # so action can create pull requests
jobs:
port_pr:
runs-on: ubuntu-latest
# Don't run on closed *unmerged* pull requests
if: github.event.pull_request.merged
steps:
# Checkout code
- uses: actions/checkout@v4
# Port PR to other branch (ONLY if labeled with "port to")
# See https://github.com/korthout/backport-action
- name: Create backport pull requests
uses: korthout/backport-action@v2
with:
# Trigger based on a "port to [branch]" label on PR
# (This label must specify the branch name to port to)
label_pattern: '^port to ([^ ]+)$'
# Title to add to the (newly created) port PR
pull_title: '[Port ${target_branch}] ${pull_title}'
# Description to add to the (newly created) port PR
pull_description: 'Port of #${pull_number} by @${pull_author} to `${target_branch}`.'
# Copy all labels from original PR to (newly created) port PR
# NOTE: The labels matching 'label_pattern' are automatically excluded
copy_labels_pattern: '.*'
# Skip any merge commits in the ported PR. This means only non-merge commits are cherry-picked to the new PR
merge_commits: 'skip'
# Use a personal access token (PAT) to create PR as 'dspace-bot' user.
# A PAT is required in order for the new PR to trigger its own actions (for CI checks)
github_token: ${{ secrets.PR_PORT_TOKEN }}

View File

@@ -0,0 +1,24 @@
# This workflow runs whenever a new pull request is created
name: Pull Request opened
# Only run for newly opened PRs against the "main" or maintenance branches
# We allow this to run for `pull_request_target` so that github secrets are available
# (This is required to assign a PR back to the creator when the PR comes from a forked repo)
on:
pull_request_target:
types: [ opened ]
branches:
- main
- 'dspace-**'
permissions:
pull-requests: write
jobs:
automation:
runs-on: ubuntu-latest
steps:
# Assign the PR to whomever created it. This is useful for visualizing assignments on project boards
# See https://github.com/toshimaru/auto-author-assign
- name: Assign PR to creator
uses: toshimaru/auto-author-assign@v2.1.0

View File

@@ -0,0 +1,354 @@
#
# DSpace's reusable Docker build/push workflow.
#
# This is used by docker.yml for all Docker image builds
name: Reusable DSpace Docker Build
on:
workflow_call:
# Possible Inputs to this reusable job
inputs:
# Build name/id for this Docker build. Used for digest storage to avoid digest overlap between builds.
build_id:
required: true
type: string
# Requires the image name to build (e.g dspace/dspace-test)
image_name:
required: true
type: string
# Optionally the path to the Dockerfile to use for the build. (Default is [dockerfile_context]/Dockerfile)
dockerfile_path:
required: false
type: string
# Optionally the context directory to build the Dockerfile within. Defaults to "." (current directory)
dockerfile_context:
required: false
type: string
default: '.'
# Optionally a list of "additional_contexts" to pass to Dockerfile. Defaults to empty
dockerfile_additional_contexts:
required: false
type: string
default: ''
# If Docker image should have additional tag flavor details (e.g. a suffix), it may be passed in.
tags_flavor:
required: false
type: string
secrets:
# Requires that Docker login info be passed in as secrets.
DOCKER_USERNAME:
required: true
DOCKER_ACCESS_TOKEN:
required: true
# These URL secrets are optional. When specified & branch checks match, the redeployment code below will trigger.
# Therefore builds which need to trigger redeployment MUST specify these URLs. All others should leave them empty.
REDEPLOY_SANDBOX_URL:
required: false
REDEPLOY_DEMO_URL:
required: false
# Define shared default settings as environment variables
env:
IMAGE_NAME: ${{ inputs.image_name }}
# Define tags to use for Docker images based on Git tags/branches (for docker/metadata-action)
# For a new commit on default branch (main), use the literal tag 'latest' on Docker image.
# For a new commit on other branches, use the branch name as the tag for Docker image.
# For a new tag, copy that tag name as the tag for Docker image.
# For a pull request, use the name of the base branch that the PR was created against or "latest" (for main).
# e.g. PR against 'main' will use "latest". a PR against 'dspace-7_x' will use 'dspace-7_x'.
IMAGE_TAGS: |
type=raw,value=latest,enable=${{ github.ref_name == github.event.repository.default_branch }}
type=ref,event=branch,enable=${{ github.ref_name != github.event.repository.default_branch }}
type=ref,event=tag
type=raw,value=${{ (github.event.pull_request.base.ref == github.event.repository.default_branch && 'latest') || github.event.pull_request.base.ref }},enable=${{ github.event_name == 'pull_request' }}
# Define default tag "flavor" for docker/metadata-action per
# https://github.com/docker/metadata-action#flavor-input
# We manage the 'latest' tag ourselves to the 'main' branch (see settings above)
TAGS_FLAVOR: |
latest=false
${{ inputs.tags_flavor }}
# When these URL variables are specified & required branch matches, then the sandbox or demo site will be redeployed.
# See "Redeploy" steps below for more details.
REDEPLOY_SANDBOX_URL: ${{ secrets.REDEPLOY_SANDBOX_URL }}
REDEPLOY_DEMO_URL: ${{ secrets.REDEPLOY_DEMO_URL }}
# Current DSpace maintenance branch (and architecture) which is deployed to demo.dspace.org / sandbox.dspace.org
# (NOTE: No deployment branch specified for sandbox.dspace.org as it uses the default_branch)
DEPLOY_DEMO_BRANCH: 'dspace-9_x'
DEPLOY_SANDBOX_BRANCH: 'main'
DEPLOY_ARCH: 'linux/amd64'
# Registry used during building of Docker images. (All images are later copied to docker.io registry)
# We use GitHub's Container Registry to avoid aggressive rate limits at DockerHub.
DOCKER_BUILD_REGISTRY: ghcr.io
jobs:
docker-build:
strategy:
matrix:
# Architectures / Platforms for which we will build Docker images
arch: [ 'linux/amd64', 'linux/arm64' ]
isPr:
- ${{ github.event_name == 'pull_request' }}
# If this is a PR, we ONLY build for AMD64. For PRs we only do a sanity check test to ensure Docker builds work.
# The below exclude therefore ensures we do NOT build ARM64 for PRs.
exclude:
- isPr: true
arch: linux/arm64
# If ARM64, then use the Ubuntu ARM64 runner. Otherwise, use the Ubuntu AMD64 runner
runs-on: ${{ matrix.arch == 'linux/arm64' && 'ubuntu-24.04-arm' || 'ubuntu-latest' }}
steps:
# This step converts the slashes in the "arch" matrix values above into dashes & saves to env.ARCH_NAME
# E.g. "linux/amd64" becomes "linux-amd64"
# This is necessary because all upload artifacts CANNOT have special chars (like slashes)
# NOTE: The regex-like syntax below is Bash Parameter Substitution
- name: Prepare
run: |
platform=${{ matrix.arch }}
echo "ARCH_NAME=${platform//\//-}" >> $GITHUB_ENV
# https://github.com/actions/checkout
- name: Checkout codebase
uses: actions/checkout@v4
# https://github.com/docker/login-action
# NOTE: This login occurs for BOTH non-PRs or PRs. PRs *must* also login to access private images from GHCR
# during the build process
- name: Login to ${{ env.DOCKER_BUILD_REGISTRY }}
uses: docker/login-action@v3
with:
registry: ${{ env.DOCKER_BUILD_REGISTRY }}
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
# https://github.com/docker/setup-buildx-action
- name: Setup Docker Buildx
uses: docker/setup-buildx-action@v3
# https://github.com/docker/metadata-action
# Extract metadata used for Docker images in all build steps below
- name: Extract metadata (tags, labels) from GitHub for Docker image
id: meta_build
uses: docker/metadata-action@v5
with:
images: ${{ env.DOCKER_BUILD_REGISTRY }}/${{ env.IMAGE_NAME }}
tags: ${{ env.IMAGE_TAGS }}
flavor: ${{ env.TAGS_FLAVOR }}
#--------------------------------------------------------------------
# First, for all branch commits (non-PRs) we build the image & upload
# to GitHub Container Registry (GHCR). After uploading the image
# to GHCR, we store the image digest in an artifact, so we can
# create a merged manifest later (see 'docker-build_manifest' job).
#
# NOTE: We use GHCR in order to avoid aggressive rate limits at DockerHub.
#--------------------------------------------------------------------
# https://github.com/docker/build-push-action
- name: Build and push image to ${{ env.DOCKER_BUILD_REGISTRY }}
if: ${{ ! matrix.isPr }}
id: docker_build
uses: docker/build-push-action@v5
with:
build-contexts: |
${{ inputs.dockerfile_additional_contexts }}
context: ${{ inputs.dockerfile_context }}
file: ${{ inputs.dockerfile_path }}
# Tell DSpace's Docker files to use the build registry instead of DockerHub
build-args:
DOCKER_REGISTRY=${{ env.DOCKER_BUILD_REGISTRY }}
platforms: ${{ matrix.arch }}
push: true
# Use tags / labels provided by 'docker/metadata-action' above
tags: ${{ steps.meta_build.outputs.tags }}
labels: ${{ steps.meta_build.outputs.labels }}
# Use GitHub cache to load cached Docker images and cache the results of this build
# This decreases the number of images we need to fetch from DockerHub
cache-from: type=gha,scope=${{ inputs.build_id }}
cache-to: type=gha,scope=${{ inputs.build_id }},mode=min
# Export the digest of Docker build locally
- name: Export Docker build digest
if: ${{ ! matrix.isPr }}
run: |
mkdir -p /tmp/digests
digest="${{ steps.docker_build.outputs.digest }}"
touch "/tmp/digests/${digest#sha256:}"
# Upload digest to an artifact, so that it can be used in combined manifest below
# (The purpose of the combined manifest is to list both amd64 and arm64 builds under same tag)
- name: Upload Docker build digest to artifact
if: ${{ ! matrix.isPr }}
uses: actions/upload-artifact@v4
with:
name: digests-${{ inputs.build_id }}-${{ env.ARCH_NAME }}
path: /tmp/digests/*
if-no-files-found: error
retention-days: 1
#------------------------------------------------------------------------------
# Second, we build the image again in order to store it in a local TAR file.
# This TAR of the image is cached/saved as an artifact, so that it can be used
# by later jobs to install the brand-new images for automated testing.
# This TAR build is performed BOTH for PRs and for branch commits (non-PRs).
#
# (This approach has the advantage of avoiding having to download the newly built
# image from DockerHub or GHCR during automated testing.)
#
# See the 'docker-deploy' job in docker.yml as an example of where this TAR is used.
#-------------------------------------------------------------------------------
# Build local image (again) and store in a TAR file in /tmp directory
# This step is only done for AMD64, as that's the only image we use in our automated testing (at this time).
# NOTE: This step cannot be combined with the build above as it's a different type of output.
- name: Build and push image to local TAR file
if: ${{ matrix.arch == 'linux/amd64'}}
uses: docker/build-push-action@v5
with:
build-contexts: |
${{ inputs.dockerfile_additional_contexts }}
context: ${{ inputs.dockerfile_context }}
file: ${{ inputs.dockerfile_path }}
# Tell DSpace's Docker files to use the build registry instead of DockerHub
build-args:
DOCKER_REGISTRY=${{ env.DOCKER_BUILD_REGISTRY }}
platforms: ${{ matrix.arch }}
tags: ${{ steps.meta_build.outputs.tags }}
labels: ${{ steps.meta_build.outputs.labels }}
# Use GitHub cache to load cached Docker images and cache the results of this build
# This decreases the number of images we need to fetch from DockerHub
cache-from: type=gha,scope=${{ inputs.build_id }}
cache-to: type=gha,scope=${{ inputs.build_id }},mode=min
# Export image to a local TAR file
outputs: type=docker,dest=/tmp/${{ inputs.build_id }}.tar
# Upload the local docker image (in TAR file) to a build Artifact
# This step is only done for AMD64, as that's the only image we use in our automated testing (at this time).
- name: Upload local image TAR to artifact
if: ${{ matrix.arch == 'linux/amd64'}}
uses: actions/upload-artifact@v4
with:
name: docker-image-${{ inputs.build_id }}-${{ env.ARCH_NAME }}
path: /tmp/${{ inputs.build_id }}.tar
if-no-files-found: error
retention-days: 1
##########################################################################################
# Merge Docker digests (from various architectures) into a single manifest.
# This runs after all Docker builds complete above. The purpose is to include all builds
# under a single manifest for this tag.
# (e.g. both linux/amd64 and linux/arm64 should be listed under the same tagged Docker image)
##########################################################################################
docker-build_manifest:
# Only run if this is NOT a PR
if: ${{ github.event_name != 'pull_request' }}
runs-on: ubuntu-latest
needs:
- docker-build
steps:
- name: Download Docker build digests
uses: actions/download-artifact@v4
with:
path: /tmp/digests
# Download digests for both AMD64 and ARM64 into same directory
pattern: digests-${{ inputs.build_id }}-*
merge-multiple: true
- name: Login to ${{ env.DOCKER_BUILD_REGISTRY }}
uses: docker/login-action@v3
with:
registry: ${{ env.DOCKER_BUILD_REGISTRY }}
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Add Docker metadata for image
id: meta
uses: docker/metadata-action@v5
with:
images: ${{ env.DOCKER_BUILD_REGISTRY }}/${{ env.IMAGE_NAME }}
tags: ${{ env.IMAGE_TAGS }}
flavor: ${{ env.TAGS_FLAVOR }}
- name: Create manifest list from digests and push to ${{ env.DOCKER_BUILD_REGISTRY }}
working-directory: /tmp/digests
run: |
docker buildx imagetools create $(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
$(printf '${{ env.DOCKER_BUILD_REGISTRY }}/${{ env.IMAGE_NAME }}@sha256:%s ' *)
- name: Inspect manifest in ${{ env.DOCKER_BUILD_REGISTRY }}
run: |
docker buildx imagetools inspect ${{ env.DOCKER_BUILD_REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.meta.outputs.version }}
##########################################################################################
# Copy images / manifest to DockerHub.
# This MUST run after *both* images (AMD64 and ARM64) are built and uploaded to GitHub
# Container Registry (GHCR). Attempting to run this in parallel to GHCR builds can result
# in a race condition...i.e. the copy to DockerHub may fail if GHCR image has been updated
# at the moment when the copy occurs.
##########################################################################################
docker-copy_to_dockerhub:
# Only run if this is NOT a PR
if: ${{ github.event_name != 'pull_request' }}
runs-on: ubuntu-latest
needs:
- docker-build_manifest
steps:
# 'regctl' is used to more easily copy the image to DockerHub and obtain the digest from DockerHub
# See https://github.com/regclient/regclient/blob/main/docs/regctl.md
- name: Install regctl for Docker registry tools
uses: regclient/actions/regctl-installer@main
with:
release: 'v0.8.0'
# This recreates Docker tags for DockerHub
- name: Add Docker metadata for image
id: meta_dockerhub
uses: docker/metadata-action@v5
with:
images: ${{ env.IMAGE_NAME }}
tags: ${{ env.IMAGE_TAGS }}
flavor: ${{ env.TAGS_FLAVOR }}
# Login to source registry first, as this is where we are copying *from*
- name: Login to ${{ env.DOCKER_BUILD_REGISTRY }}
uses: docker/login-action@v3
with:
registry: ${{ env.DOCKER_BUILD_REGISTRY }}
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
# Login to DockerHub, since this is where we are copying *to*
- name: Login to DockerHub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_ACCESS_TOKEN }}
# Copy the image from source to DockerHub
- name: Copy image from ${{ env.DOCKER_BUILD_REGISTRY }} to docker.io
run: |
regctl image copy ${{ env.DOCKER_BUILD_REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.meta_dockerhub.outputs.version }} docker.io/${{ env.IMAGE_NAME }}:${{ steps.meta_dockerhub.outputs.version }}
#--------------------------------------------------------------------
# Finally, check whether demo.dspace.org or sandbox.dspace.org need
# to be redeployed based on these new DockerHub images.
#--------------------------------------------------------------------
# If this build is for the branch that Sandbox uses and passed in a REDEPLOY_SANDBOX_URL secret,
# Then redeploy https://sandbox.dspace.org
- name: Redeploy sandbox.dspace.org (based on main branch)
if: |
env.REDEPLOY_SANDBOX_URL != '' &&
github.ref_name == env.DEPLOY_SANDBOX_BRANCH
run: |
curl -X POST $REDEPLOY_SANDBOX_URL
# If this build is for the branch that Demo uses and passed in a REDEPLOY_DEMO_URL secret,
# Then redeploy https://demo.dspace.org
- name: Redeploy demo.dspace.org (based on maintenance branch)
if: |
env.REDEPLOY_DEMO_URL != '' &&
github.ref_name == env.DEPLOY_DEMO_BRANCH
run: |
curl -X POST $REDEPLOY_DEMO_URL

7
.gitignore vendored
View File

@@ -10,6 +10,7 @@ tags
.project
.classpath
.checkstyle
.factorypath
## Ignore project files created by IntelliJ IDEA
*.iml
@@ -19,7 +20,7 @@ tags
overlays/
## Ignore project files created by NetBeans
nbproject/private/
nbproject/
build/
nbbuild/
dist/
@@ -42,3 +43,7 @@ nb-configuration.xml
##Ignore JRebel project configuration
rebel.xml
## Ignore jenv configuration
.java-version

9
.lgtm.yml Normal file
View File

@@ -0,0 +1,9 @@
# LGTM Settings (https://lgtm.com/)
# For reference, see https://lgtm.com/help/lgtm/lgtm.yml-configuration-file
# or template at https://lgtm.com/static/downloads/lgtm.template.yml
extraction:
java:
index:
# Specify the Java version required to build the project
java_version: 11

View File

@@ -1,44 +0,0 @@
language: java
sudo: false
env:
# Give Maven 1GB of memory to work with
- MAVEN_OPTS=-Xmx1024M
jdk:
# DS-3384 Oracle JDK 8 has DocLint enabled by default.
# Let's use this to catch any newly introduced DocLint issues.
- oraclejdk8
## Should we run into any problems with oraclejdk8 on Travis, we may try the following workaround.
## https://docs.travis-ci.com/user/languages/java#Testing-Against-Multiple-JDKs
## https://github.com/travis-ci/travis-ci/issues/3259#issuecomment-130860338
#addons:
# apt:
# packages:
# - oracle-java8-installer
# Install prerequisites for building Mirage2 more rapidly
before_install:
# Remove outdated settings.xml from Travis builds. Workaround for https://github.com/travis-ci/travis-ci/issues/4629
- rm ~/.m2/settings.xml
# Skip install stage, as we'll do it below
install: "echo 'Skipping install stage, dependencies will be downloaded during build and test stages.'"
# Two stage Build and Test
# 1. Install & Unit Test APIs
# 2. Assemble DSpace
script:
# 1. [Install & Unit Test] Check source code licenses and run source code Unit Tests
# license:check => Validate all source code license headers
# -Dmaven.test.skip=false => Enable DSpace Unit Tests
# -DskipITs=false => Enable DSpace Integration Tests
# -P !assembly => Skip normal assembly (as it can be memory intensive)
# -B => Maven batch/non-interactive mode (recommended for CI)
# -V => Display Maven version info before build
# -Dsurefire.rerunFailingTestsCount=2 => try again for flakey tests, and keep track of/report on number of retries
- "mvn clean install license:check -Dmaven.test.skip=false -DskipITs=false -P !assembly -B -V -Dsurefire.rerunFailingTestsCount=2"
# 2. [Assemble DSpace] Ensure overlay & assembly process works (from [src]/dspace/)
# -P !assembly => SKIP the actual building of [src]/dspace/dspace-installer (as it can be memory intensive)
- "cd dspace && mvn package -P !assembly -B -V -Dsurefire.rerunFailingTestsCount=2"

45
CONTRIBUTING.md Normal file
View File

@@ -0,0 +1,45 @@
# How to Contribute
DSpace is a community built and supported project. We do not have a centralized development or support team, but have a dedicated group of volunteers who help us improve the software, documentation, resources, etc.
* [Contribute new code via a Pull Request](#contribute-new-code-via-a-pull-request)
* [Contribute documentation](#contribute-documentation)
* [Help others on mailing lists or Slack](#help-others-on-mailing-lists-or-slack)
* [Join a working or interest group](#join-a-working-or-interest-group)
## Contribute new code via a Pull Request
We accept [GitHub Pull Requests (PRs)](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) at any time from anyone.
Contributors to each release are recognized in our [Release Notes](https://wiki.lyrasis.org/display/DSDOC7x/Release+Notes).
Code Contribution Checklist
- [ ] PRs _should_ be smaller in size (ideally less than 1,000 lines of code, not including comments & tests)
- [ ] PRs **must** pass Checkstyle validation based on our [Code Style Guide](https://wiki.lyrasis.org/display/DSPACE/Code+Style+Guide).
- [ ] PRs **must** include Javadoc for _all new/modified public methods and classes_. Larger private methods should also have Javadoc
- [ ] PRs **must** pass all automated tests and include new/updated Unit or Integration tests based on our [Code Testing Guide](https://wiki.lyrasis.org/display/DSPACE/Code+Testing+Guide).
- [ ] If a PR includes new libraries/dependencies (in any `pom.xml`), then their software licenses **must** align with the [DSpace BSD License](https://github.com/DSpace/DSpace/blob/main/LICENSE) based on the [Licensing of Contributions](https://wiki.lyrasis.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-LicensingofContributions) documentation.
- [ ] Basic technical documentation _should_ be provided for any new features or changes to the REST API. REST API changes should be documented in our [Rest Contract](https://github.com/DSpace/RestContract).
- [ ] If a PR fixes an issue ticket, please [link them together](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).
Additional details on the code contribution process can be found in our [Code Contribution Guidelines](https://wiki.lyrasis.org/display/DSPACE/Code+Contribution+Guidelines)
## Contribute documentation
DSpace Documentation is a collaborative effort in a shared Wiki. The latest documentation is at https://wiki.lyrasis.org/display/DSDOC7x
If you find areas of the DSpace Documentation which you wish to improve, please request a Wiki account by emailing wikihelp@lyrasis.org.
Once you have an account setup, contact @tdonohue (via [Slack](https://wiki.lyrasis.org/display/DSPACE/Slack) or email) for access to edit our Documentation.
## Help others on mailing lists or Slack
DSpace has our own [Slack](https://wiki.lyrasis.org/display/DSPACE/Slack) community and [Mailing Lists](https://wiki.lyrasis.org/display/DSPACE/Mailing+Lists) where discussions take place and questions are answered.
Anyone is welcome to join and help others. We just ask you to follow our [Code of Conduct](https://www.lyrasis.org/about/Pages/Code-of-Conduct.aspx) (adopted via LYRASIS).
## Join a working or interest group
Most of the work in building/improving DSpace comes via [Working Groups](https://wiki.lyrasis.org/display/DSPACE/DSpace+Working+Groups) or [Interest Groups](https://wiki.lyrasis.org/display/DSPACE/DSpace+Interest+Groups).
All working/interest groups are open to anyone to join and participate. A few key groups to be aware of include:
* [DSpace 7 Working Group](https://wiki.lyrasis.org/display/DSPACE/DSpace+7+Working+Group) - This is the main (mostly volunteer) development team. We meet weekly to review our current development [project board](https://github.com/orgs/DSpace/projects), assigning tickets and/or PRs.
* [DSpace Community Advisory Team (DCAT)](https://wiki.lyrasis.org/display/cmtygp/DSpace+Community+Advisory+Team) - This is an interest group for repository managers/administrators. We meet monthly to discuss DSpace, share tips & provide feedback back to developers.

78
Dockerfile Normal file
View File

@@ -0,0 +1,78 @@
# This image will be published as dspace/dspace
# See https://github.com/DSpace/DSpace/tree/main/dspace/src/main/docker for usage details
#
# - note: default tag for branch: dspace/dspace: dspace/dspace:dspace-7_x
# This Dockerfile uses JDK11 by default, but has also been tested with JDK17.
# To build with JDK17, use "--build-arg JDK_VERSION=17"
ARG JDK_VERSION=11
# The Docker version tag to build from
ARG DSPACE_VERSION=dspace-7_x
# The Docker registry to use for DSpace images. Defaults to "docker.io"
# NOTE: non-DSpace images are hardcoded to use "docker.io" and are not impacted by this build argument
ARG DOCKER_REGISTRY=docker.io
# Step 1 - Run Maven Build
FROM ${DOCKER_REGISTRY}/dspace/dspace-dependencies:${DSPACE_VERSION} AS build
ARG TARGET_DIR=dspace-installer
WORKDIR /app
# The dspace-installer directory will be written to /install
RUN mkdir /install \
&& chown -Rv dspace: /install \
&& chown -Rv dspace: /app
USER dspace
# Copy the DSpace source code (from local machine) into the workdir (excluding .dockerignore contents)
ADD --chown=dspace . /app/
# Build DSpace (note: this build doesn't include the optional, deprecated "dspace-rest" webapp)
# Copy the dspace-installer directory to /install. Clean up the build to keep the docker image small
# Maven flags here ensure that we skip building test environment and skip all code verification checks.
# These flags speed up this compilation as much as reasonably possible.
ENV MAVEN_FLAGS="-P-test-environment -Denforcer.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -Dxml.skip=true"
RUN mvn --no-transfer-progress package ${MAVEN_FLAGS} && \
mv /app/dspace/target/${TARGET_DIR}/* /install && \
mvn clean
# Step 2 - Run Ant Deploy
FROM docker.io/eclipse-temurin:${JDK_VERSION} AS ant_build
ARG TARGET_DIR=dspace-installer
# COPY the /install directory from 'build' container to /dspace-src in this container
COPY --from=build /install /dspace-src
WORKDIR /dspace-src
# Create the initial install deployment using ANT
ENV ANT_VERSION=1.10.13
ENV ANT_HOME=/tmp/ant-$ANT_VERSION
ENV PATH=$ANT_HOME/bin:$PATH
# Download and install 'ant'
RUN mkdir $ANT_HOME && \
curl --silent --show-error --location --fail --retry 5 --output /tmp/apache-ant.tar.gz \
https://archive.apache.org/dist/ant/binaries/apache-ant-${ANT_VERSION}-bin.tar.gz && \
tar -zx --strip-components=1 -f /tmp/apache-ant.tar.gz -C $ANT_HOME && \
rm /tmp/apache-ant.tar.gz
# Run necessary 'ant' deploy scripts
RUN ant init_installation update_configs update_code update_webapps
# Step 3 - Run tomcat
# Create a new tomcat image that does not retain the the build directory contents
FROM docker.io/tomcat:9-jdk${JDK_VERSION}
# NOTE: DSPACE_INSTALL must align with the "dspace.dir" default configuration.
ENV DSPACE_INSTALL=/dspace
# Copy the /dspace directory from 'ant_build' container to /dspace in this container
COPY --from=ant_build /dspace $DSPACE_INSTALL
# Need host command for "[dspace]/bin/make-handle-config"
RUN apt-get update \
&& apt-get install -y --no-install-recommends host \
&& apt-get purge -y --auto-remove \
&& rm -rf /var/lib/apt/lists/*
# Expose Tomcat port (8080) and AJP port (8009) and Handle Server HTTP port (8000)
EXPOSE 8080 8009 8000
# Give java extra memory (2GB)
ENV JAVA_OPTS=-Xmx2000m
# Link the DSpace 'server' webapp into Tomcat's webapps directory.
# This ensures that when we start Tomcat, it runs from /server path (e.g. http://localhost:8080/server/)
RUN ln -s $DSPACE_INSTALL/webapps/server /usr/local/tomcat/webapps/server
# If you wish to run "server" webapp off the ROOT path, then comment out the above RUN, and uncomment the below RUN.
# You also MUST update the 'dspace.server.url' configuration to match.
# Please note that server webapp should only run on one path at a time.
#RUN mv /usr/local/tomcat/webapps/ROOT /usr/local/tomcat/webapps/ROOT.bk && \
# ln -s $DSPACE_INSTALL/webapps/server /usr/local/tomcat/webapps/ROOT

62
Dockerfile.cli Normal file
View File

@@ -0,0 +1,62 @@
# This image will be published as dspace/dspace-cli
# See https://github.com/DSpace/DSpace/tree/main/dspace/src/main/docker for usage details
#
# - note: default tag for branch: dspace/dspace-cli: dspace/dspace-cli:dspace-7_x
# This Dockerfile uses JDK11 by default, but has also been tested with JDK17.
# To build with JDK17, use "--build-arg JDK_VERSION=17"
ARG JDK_VERSION=11
# The Docker version tag to build from
ARG DSPACE_VERSION=dspace-7_x
# The Docker registry to use for DSpace images. Defaults to "docker.io"
# NOTE: non-DSpace images are hardcoded to use "docker.io" and are not impacted by this build argument
ARG DOCKER_REGISTRY=docker.io
# Step 1 - Run Maven Build
FROM ${DOCKER_REGISTRY}/dspace/dspace-dependencies:${DSPACE_VERSION} AS build
ARG TARGET_DIR=dspace-installer
WORKDIR /app
# The dspace-installer directory will be written to /install
RUN mkdir /install \
&& chown -Rv dspace: /install \
&& chown -Rv dspace: /app
USER dspace
# Copy the DSpace source code (from local machine) into the workdir (excluding .dockerignore contents)
ADD --chown=dspace . /app/
# Build DSpace. Copy the dspace-installer directory to /install. Clean up the build to keep the docker image small
RUN mvn --no-transfer-progress package && \
mv /app/dspace/target/${TARGET_DIR}/* /install && \
mvn clean
# Step 2 - Run Ant Deploy
FROM docker.io/eclipse-temurin:${JDK_VERSION} AS ant_build
ARG TARGET_DIR=dspace-installer
# COPY the /install directory from 'build' container to /dspace-src in this container
COPY --from=build /install /dspace-src
WORKDIR /dspace-src
# Create the initial install deployment using ANT
ENV ANT_VERSION=1.10.13
ENV ANT_HOME=/tmp/ant-$ANT_VERSION
ENV PATH=$ANT_HOME/bin:$PATH
# Download and install 'ant'
RUN mkdir $ANT_HOME && \
curl --silent --show-error --location --fail --retry 5 --output /tmp/apache-ant.tar.gz \
https://archive.apache.org/dist/ant/binaries/apache-ant-${ANT_VERSION}-bin.tar.gz && \
tar -zx --strip-components=1 -f /tmp/apache-ant.tar.gz -C $ANT_HOME && \
rm /tmp/apache-ant.tar.gz
# Run necessary 'ant' deploy scripts
RUN ant init_installation update_configs update_code
# Step 3 - Run jdk
FROM docker.io/eclipse-temurin:${JDK_VERSION}
# NOTE: DSPACE_INSTALL must align with the "dspace.dir" default configuration.
ENV DSPACE_INSTALL=/dspace
# Copy the /dspace directory from 'ant_build' container to /dspace in this container
COPY --from=ant_build /dspace $DSPACE_INSTALL
# Give java extra memory (1GB)
ENV JAVA_OPTS=-Xmx1000m
# Install unzip for AIPs
RUN apt-get update \
&& apt-get install -y --no-install-recommends unzip \
&& apt-get purge -y --auto-remove \
&& rm -rf /var/lib/apt/lists/*

78
Dockerfile.dependencies Normal file
View File

@@ -0,0 +1,78 @@
# This image will be published as dspace/dspace-dependencies
# The purpose of this image is to make the build for dspace/dspace run faster
#
# This Dockerfile uses JDK11 by default, but has also been tested with JDK17.
# To build with JDK17, use "--build-arg JDK_VERSION=17"
ARG JDK_VERSION=11
# Step 1 - Download all Dependencies
FROM docker.io/maven:3-eclipse-temurin-${JDK_VERSION} AS build
ARG TARGET_DIR=dspace-installer
WORKDIR /app
# Create the 'dspace' user account & home directory
RUN useradd dspace \
&& mkdir -p /home/dspace \
&& chown -Rv dspace: /home/dspace
RUN chown -Rv dspace: /app
# Switch to dspace user & run below commands as that user
USER dspace
# This next part may look odd, but it speeds up the build of this image *significantly*.
# Copy ONLY the POMs to this image (from local machine). This will allow us to download all dependencies *without*
# performing any code compilation steps.
# Parent POM
ADD --chown=dspace pom.xml /app/
RUN mkdir -p /app/dspace
# 'dspace' module POM. Includes 'additions' ONLY, as it's the only submodule that is required to exist.
ADD --chown=dspace dspace/pom.xml /app/dspace/
RUN mkdir -p /app/dspace/modules/
ADD --chown=dspace dspace/modules/pom.xml /app/dspace/modules/
RUN mkdir -p /app/dspace/modules/additions
ADD --chown=dspace dspace/modules/additions/pom.xml /app/dspace/modules/additions/
# 'dspace-api' module POM
RUN mkdir -p /app/dspace-api
ADD --chown=dspace dspace-api/pom.xml /app/dspace-api/
# 'dspace-iiif' module POM
RUN mkdir -p /app/dspace-iiif
ADD --chown=dspace dspace-iiif/pom.xml /app/dspace-iiif/
# 'dspace-oai' module POM
RUN mkdir -p /app/dspace-oai
ADD --chown=dspace dspace-oai/pom.xml /app/dspace-oai/
# 'dspace-rdf' module POM
RUN mkdir -p /app/dspace-rdf
ADD --chown=dspace dspace-rdf/pom.xml /app/dspace-rdf/
# 'dspace-server-webapp' module POM
RUN mkdir -p /app/dspace-server-webapp
ADD --chown=dspace dspace-server-webapp/pom.xml /app/dspace-server-webapp/
# 'dspace-services' module POM
RUN mkdir -p /app/dspace-services
ADD --chown=dspace dspace-services/pom.xml /app/dspace-services/
# 'dspace-sword' module POM
RUN mkdir -p /app/dspace-sword
ADD --chown=dspace dspace-sword/pom.xml /app/dspace-sword/
# 'dspace-swordv2' module POM
RUN mkdir -p /app/dspace-swordv2
ADD --chown=dspace dspace-swordv2/pom.xml /app/dspace-swordv2/
# Trigger the installation of all maven dependencies (hide download progress messages)
# Maven flags here ensure that we skip final assembly, skip building test environment and skip all code verification checks.
# These flags speed up this installation and skip tasks we cannot perform as we don't have the full source code.
ENV MAVEN_FLAGS="-P-assembly -P-test-environment -Denforcer.skip=true -Dcheckstyle.skip=true -Dlicense.skip=true -Dxjc.skip=true -Dxml.skip=true"
RUN mvn --no-transfer-progress verify ${MAVEN_FLAGS}
# Clear the contents of the /app directory (including all maven target folders), so no artifacts remain.
# This ensures when dspace:dspace is built, it will use the Maven local cache (~/.m2) for dependencies
USER root
RUN rm -rf /app/*

90
Dockerfile.test Normal file
View File

@@ -0,0 +1,90 @@
# This image will be published as dspace/dspace
# See https://github.com/DSpace/DSpace/tree/main/dspace/src/main/docker for usage details
#
# - note: default tag for branch: dspace/dspace: dspace/dspace:dspace-7_x-test
#
# This image is meant for TESTING/DEVELOPMENT ONLY as it deploys the old v6 REST API under HTTP (not HTTPS)
# This Dockerfile uses JDK11 by default, but has also been tested with JDK17.
# To build with JDK17, use "--build-arg JDK_VERSION=17"
ARG JDK_VERSION=11
# The Docker version tag to build from
ARG DSPACE_VERSION=dspace-7_x
# The Docker registry to use for DSpace images. Defaults to "docker.io"
# NOTE: non-DSpace images are hardcoded to use "docker.io" and are not impacted by this build argument
ARG DOCKER_REGISTRY=docker.io
# Step 1 - Run Maven Build
FROM ${DOCKER_REGISTRY}/dspace/dspace-dependencies:${DSPACE_VERSION} AS build
ARG TARGET_DIR=dspace-installer
WORKDIR /app
# The dspace-installer directory will be written to /install
RUN mkdir /install \
&& chown -Rv dspace: /install \
&& chown -Rv dspace: /app
USER dspace
# Copy the DSpace source code (from local machine) into the workdir (excluding .dockerignore contents)
ADD --chown=dspace . /app/
# Build DSpace (INCLUDING the optional, deprecated "dspace-rest" webapp)
# Copy the dspace-installer directory to /install. Clean up the build to keep the docker image small
RUN mvn --no-transfer-progress package -Pdspace-rest && \
mv /app/dspace/target/${TARGET_DIR}/* /install && \
mvn clean
# Step 2 - Run Ant Deploy
FROM docker.io/eclipse-temurin:${JDK_VERSION} AS ant_build
ARG TARGET_DIR=dspace-installer
# COPY the /install directory from 'build' container to /dspace-src in this container
COPY --from=build /install /dspace-src
WORKDIR /dspace-src
# Create the initial install deployment using ANT
ENV ANT_VERSION=1.10.12
ENV ANT_HOME=/tmp/ant-$ANT_VERSION
ENV PATH=$ANT_HOME/bin:$PATH
# Download and install 'ant'
RUN mkdir $ANT_HOME && \
curl --silent --show-error --location --fail --retry 5 --output /tmp/apache-ant.tar.gz \
https://archive.apache.org/dist/ant/binaries/apache-ant-${ANT_VERSION}-bin.tar.gz && \
tar -zx --strip-components=1 -f /tmp/apache-ant.tar.gz -C $ANT_HOME && \
rm /tmp/apache-ant.tar.gz
# Run necessary 'ant' deploy scripts
RUN ant init_installation update_configs update_code update_webapps
# Step 3 - Run tomcat
# Create a new tomcat image that does not retain the the build directory contents
FROM docker.io/tomcat:9-jdk${JDK_VERSION}
ENV DSPACE_INSTALL=/dspace
ENV TOMCAT_INSTALL=/usr/local/tomcat
# Copy the /dspace directory from 'ant_build' containger to /dspace in this container
COPY --from=ant_build /dspace $DSPACE_INSTALL
# Need host command for "[dspace]/bin/make-handle-config"
RUN apt-get update \
&& apt-get install -y --no-install-recommends host \
&& apt-get purge -y --auto-remove \
&& rm -rf /var/lib/apt/lists/*
# Enable the AJP connector in Tomcat's server.xml
# NOTE: secretRequired="false" should only be used when AJP is NOT accessible from an external network. But, secretRequired="true" isn't supported by mod_proxy_ajp until Apache 2.5
RUN sed -i '/Service name="Catalina".*/a \\n <Connector protocol="AJP/1.3" port="8009" address="0.0.0.0" redirectPort="8443" URIEncoding="UTF-8" secretRequired="false" />' $TOMCAT_INSTALL/conf/server.xml
# Expose Tomcat port and AJP port
EXPOSE 8080 8009 8000
# Give java extra memory (2GB)
ENV JAVA_OPTS=-Xmx2000m
# Set up debugging
ENV CATALINA_OPTS=-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=*:8000
# Link the DSpace 'server' webapp into Tomcat's webapps directory.
# This ensures that when we start Tomcat, it runs from /server path (e.g. http://localhost:8080/server/)
# Also link the v6.x (deprecated) REST API off the "/rest" path
RUN ln -s $DSPACE_INSTALL/webapps/server /usr/local/tomcat/webapps/server && \
ln -s $DSPACE_INSTALL/webapps/rest /usr/local/tomcat/webapps/rest
# If you wish to run "server" webapp off the ROOT path, then comment out the above RUN, and uncomment the below RUN.
# You also MUST update the 'dspace.server.url' configuration to match.
# Please note that server webapp should only run on one path at a time.
#RUN mv /usr/local/tomcat/webapps/ROOT /usr/local/tomcat/webapps/ROOT.bk && \
# ln -s $DSPACE_INSTALL/webapps/server /usr/local/tomcat/webapps/ROOT && \
# ln -s $DSPACE_INSTALL/webapps/rest /usr/local/tomcat/webapps/rest
# Overwrite the v6.x (deprecated) REST API's web.xml, so that we can run it on HTTP (defaults to requiring HTTPS)
# WARNING: THIS IS OBVIOUSLY INSECURE. NEVER DO THIS IN PRODUCTION.
COPY dspace/src/main/docker/test/rest_web.xml $DSPACE_INSTALL/webapps/rest/WEB-INF/web.xml
RUN sed -i -e "s|\${dspace.dir}|$DSPACE_INSTALL|" $DSPACE_INSTALL/webapps/rest/WEB-INF/web.xml

23
LICENSE
View File

@@ -1,7 +1,6 @@
DSpace source code license:
BSD 3-Clause License
Copyright (c) 2002-2016, DuraSpace. All rights reserved.
Copyright (c) 2002-2021, LYRASIS. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
@@ -14,13 +13,12 @@ notice, this list of conditions and the following disclaimer.
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
- Neither the name DuraSpace nor the name of the DSpace Foundation
nor the names of its contributors may be used to endorse or promote
products derived from this software without specific prior written
permission.
- Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
@@ -30,11 +28,4 @@ OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
DAMAGE.
DSpace uses third-party libraries which may be distributed under
different licenses to the above. Information about these licenses
is detailed in the LICENSES_THIRD_PARTY file at the root of the source
tree. You must agree to the terms of these licenses, in addition to
the above DSpace source code license, in order to use this software.
DAMAGE.

File diff suppressed because it is too large Load Diff

31
NOTICE
View File

@@ -1,15 +1,28 @@
Licenses of Third-Party Libraries
=================================
Licensing Notice
DSpace uses third-party libraries which may be distributed under
different licenses than specified in our LICENSE file. Information
about these licenses is detailed in the LICENSES_THIRD_PARTY file at
the root of the source tree. You must agree to the terms of these
licenses, in addition to the DSpace source code license, in order to
use this software.
Fedora Commons joined with the DSpace Foundation and began operating under
Licensing Notices
=================
[July 2019] DuraSpace joined with LYRASIS (another 501(c)3 organization) in July 2019.
LYRASIS holds the copyrights of DuraSpace.
[July 2009] Fedora Commons joined with the DSpace Foundation and began operating under
the new name DuraSpace in July 2009. DuraSpace holds the copyrights of
the DSpace Foundation, Inc.
The DSpace Foundation, Inc. is a 501(c)3 corporation established in July 2007
with a mission to promote and advance the dspace platform enabling management,
access and preservation of digital works. The Foundation was able to transfer
the legal copyright from Hewlett-Packard Company (HP) and Massachusetts
Institute of Technology (MIT) to the DSpace Foundation in October 2007. Many
of the files in the source code may contain a copyright statement stating HP
and MIT possess the copyright, in these instances please note that the copy
[July 2007] The DSpace Foundation, Inc. is a 501(c)3 corporation established in July 2007
with a mission to promote and advance the dspace platform enabling management,
access and preservation of digital works. The Foundation was able to transfer
the legal copyright from Hewlett-Packard Company (HP) and Massachusetts
Institute of Technology (MIT) to the DSpace Foundation in October 2007. Many
of the files in the source code may contain a copyright statement stating HP
and MIT possess the copyright, in these instances please note that the copy
right has transferred to the DSpace foundation, and subsequently to DuraSpace.

127
README.md
View File

@@ -1,62 +1,54 @@
# DSpace
## NOTE: The rest-tutorial branch has been created to support the [DSpace 7 REST documentation](https://dspace-labs.github.io/DSpace7RestTutorial/walkthrough/intro)
- This branch provides stable, referencable line numbers in code
[![Build Status](https://github.com/DSpace/DSpace/workflows/Build/badge.svg)](https://github.com/DSpace/DSpace/actions?query=workflow%3ABuild)
[![Build Status](https://travis-ci.org/DSpace/DSpace.png?branch=master)](https://travis-ci.org/DSpace/DSpace)
[DSpace Documentation](https://wiki.duraspace.org/display/DSDOC/) |
[DSpace Documentation](https://wiki.lyrasis.org/display/DSDOC/) |
[DSpace Releases](https://github.com/DSpace/DSpace/releases) |
[DSpace Wiki](https://wiki.duraspace.org/display/DSPACE/Home) |
[Support](https://wiki.duraspace.org/display/DSPACE/Support)
[DSpace Wiki](https://wiki.lyrasis.org/display/DSPACE/Home) |
[Support](https://wiki.lyrasis.org/display/DSPACE/Support)
DSpace open source software is a turnkey repository application used by more than
## Overview
DSpace open source software is a turnkey repository application used by more than
2,000 organizations and institutions worldwide to provide durable access to digital resources.
For more information, visit http://www.dspace.org/
***
:warning: **Work on DSpace 7 has begun on our `master` branch.** This means that there is temporarily NO user interface on this `master` branch. DSpace 7 will feature a new, unified [Angular](https://angular.io/) user interface, along with an enhanced, rebuilt REST API. The latest status of this work can be found on the [DSpace 7 UI Working Group](https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group) page. Additionally, the codebases can be found in the following places:
* DSpace 7 REST API work is occurring on the [`master` branch](https://github.com/DSpace/DSpace/tree/master/dspace-spring-rest) of this repository.
* The REST Contract is being documented at https://github.com/DSpace/Rest7Contract
* DSpace 7 Angular UI work is occurring at https://github.com/DSpace/dspace-angular
**If you would like to get involved in our DSpace 7 development effort, we welcome new contributors.** Just join one of our meetings or get in touch via Slack. See the [DSpace 7 UI Working Group](https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group) wiki page for more info.
DSpace consists of both a Java-based backend and an Angular-based frontend.
**If you are looking for the ongoing maintenance work for DSpace 6 (or prior releases)**, you can find that work on the corresponding maintenance branch (e.g. [`dspace-6_x`](https://github.com/DSpace/DSpace/tree/dspace-6_x)) in this repository.
***
* Backend (this codebase) provides a REST API, along with other machine-based interfaces (e.g. OAI-PMH, SWORD, etc)
* The REST Contract is at https://github.com/DSpace/RestContract
* Frontend (https://github.com/DSpace/dspace-angular/) is the User Interface built on the REST API
Prior versions of DSpace (v6.x and below) used two different UIs (XMLUI and JSPUI). Those UIs are no longer supported in v7 (and above).
* A maintenance branch for older versions is still available, see `dspace-6_x` for 6.x maintenance.
## Downloads
The latest release of DSpace can be downloaded from the [DSpace website](http://www.dspace.org/latest-release/) or from [GitHub](https://github.com/DSpace/DSpace/releases).
Past releases are all available via GitHub at https://github.com/DSpace/DSpace/releases
* Backend (REST API): https://github.com/DSpace/DSpace/releases
* Frontend (User Interface): https://github.com/DSpace/dspace-angular/releases
## Documentation / Installation
Documentation for each release may be viewed online or downloaded via our [Documentation Wiki](https://wiki.duraspace.org/display/DSDOC/).
Documentation for each release may be viewed online or downloaded via our [Documentation Wiki](https://wiki.lyrasis.org/display/DSDOC/).
The latest DSpace Installation instructions are available at:
https://wiki.duraspace.org/display/DSDOC6x/Installing+DSpace
https://wiki.lyrasis.org/display/DSDOC7x/Installing+DSpace
Please be aware that, as a Java web application, DSpace requires a database (PostgreSQL or Oracle)
Please be aware that, as a Java web application, DSpace requires a database (PostgreSQL)
and a servlet container (usually Tomcat) in order to function.
More information about these and all other prerequisites can be found in the Installation instructions above.
## Running DSpace 7 in Docker
NOTE: At this time, we do not have production-ready Docker images for DSpace.
That said, we do have quick-start Docker Compose scripts for development or testing purposes.
See [Running DSpace 7 with Docker Compose](dspace/src/main/docker-compose/README.md)
## Contributing
DSpace is a community built and supported project. We do not have a centralized development or support team,
but have a dedicated group of volunteers who help us improve the software, documentation, resources, etc.
We welcome contributions of any type. Here's a few basic guides that provide suggestions for contributing to DSpace:
* [How to Contribute to DSpace](https://wiki.duraspace.org/display/DSPACE/How+to+Contribute+to+DSpace): How to contribute in general (via code, documentation, bug reports, expertise, etc)
* [Code Contribution Guidelines](https://wiki.duraspace.org/display/DSPACE/Code+Contribution+Guidelines): How to give back code or contribute features, bug fixes, etc.
* [DSpace Community Advisory Team (DCAT)](https://wiki.duraspace.org/display/cmtygp/DSpace+Community+Advisory+Team): If you are not a developer, we also have an interest group specifically for repository managers. The DCAT group meets virtually, once a month, and sends open invitations to join their meetings via the [DCAT mailing list](https://groups.google.com/d/forum/DSpaceCommunityAdvisoryTeam).
We also encourage GitHub Pull Requests (PRs) at any time. Please see our [Development with Git](https://wiki.duraspace.org/display/DSPACE/Development+with+Git) guide for more info.
In addition, a listing of all known contributors to DSpace software can be
found online at: https://wiki.duraspace.org/display/DSPACE/DSpaceContributors
See [Contributing documentation](CONTRIBUTING.md)
## Getting Help
@@ -64,22 +56,75 @@ DSpace provides public mailing lists where you can post questions or raise topic
We welcome everyone to participate in these lists:
* [dspace-community@googlegroups.com](https://groups.google.com/d/forum/dspace-community) : General discussion about DSpace platform, announcements, sharing of best practices
* [dspace-tech@googlegroups.com](https://groups.google.com/d/forum/dspace-tech) : Technical support mailing list. See also our guide for [How to troubleshoot an error](https://wiki.duraspace.org/display/DSPACE/Troubleshoot+an+error).
* [dspace-tech@googlegroups.com](https://groups.google.com/d/forum/dspace-tech) : Technical support mailing list. See also our guide for [How to troubleshoot an error](https://wiki.lyrasis.org/display/DSPACE/Troubleshoot+an+error).
* [dspace-devel@googlegroups.com](https://groups.google.com/d/forum/dspace-devel) : Developers / Development mailing list
Great Q&A is also available under the [DSpace tag on Stackoverflow](http://stackoverflow.com/questions/tagged/dspace)
Additional support options are listed at https://wiki.duraspace.org/display/DSPACE/Support
Additional support options are at https://wiki.lyrasis.org/display/DSPACE/Support
DSpace also has an active service provider network. If you'd rather hire a service provider to
install, upgrade, customize or host DSpace, then we recommend getting in touch with one of our
DSpace also has an active service provider network. If you'd rather hire a service provider to
install, upgrade, customize or host DSpace, then we recommend getting in touch with one of our
[Registered Service Providers](http://www.dspace.org/service-providers).
## Issue Tracker
The DSpace Issue Tracker can be found at: https://jira.duraspace.org/projects/DS/summary
DSpace uses GitHub to track issues:
* Backend (REST API) issues: https://github.com/DSpace/DSpace/issues
* Frontend (User Interface) issues: https://github.com/DSpace/dspace-angular/issues
## Testing
### Running Tests
By default, in DSpace, Unit Tests and Integration Tests are disabled. However, they are
run automatically by [GitHub Actions](https://github.com/DSpace/DSpace/actions?query=workflow%3ABuild) for all Pull Requests and code commits.
* How to run both Unit Tests (via `maven-surefire-plugin`) and Integration Tests (via `maven-failsafe-plugin`):
```
mvn install -DskipUnitTests=false -DskipIntegrationTests=false
```
* How to run _only_ Unit Tests:
```
mvn test -DskipUnitTests=false
```
* How to run a *single* Unit Test
```
# Run all tests in a specific test class
# NOTE: failIfNoTests=false is required to skip tests in other modules
mvn test -DskipUnitTests=false -Dtest=[full.package.testClassName] -DfailIfNoTests=false
# Run one test method in a specific test class
mvn test -DskipUnitTests=false -Dtest=[full.package.testClassName]#[testMethodName] -DfailIfNoTests=false
```
* How to run _only_ Integration Tests
```
mvn install -DskipIntegrationTests=false
```
* How to run a *single* Integration Test
```
# Run all integration tests in a specific test class
# NOTE: failIfNoTests=false is required to skip tests in other modules
mvn install -DskipIntegrationTests=false -Dit.test=[full.package.testClassName] -DfailIfNoTests=false
# Run one test method in a specific test class
mvn install -DskipIntegrationTests=false -Dit.test=[full.package.testClassName]#[testMethodName] -DfailIfNoTests=false
```
* How to run only tests of a specific DSpace module
```
# Before you can run only one module's tests, other modules may need installing into your ~/.m2
cd [dspace-src]
mvn clean install
# Then, move into a module subdirectory, and run the test command
cd [dspace-src]/dspace-server-webapp
# Choose your test command from the lists above
```
## License
DSpace source code is freely available under a standard [BSD 3-Clause license](https://opensource.org/licenses/BSD-3-Clause).
The full license is available at http://www.dspace.org/license/
The full license is available in the [LICENSE](LICENSE) file or online at http://www.dspace.org/license/
DSpace uses third-party libraries which may be distributed under different licenses. Those licenses are listed
in the [LICENSES_THIRD_PARTY](LICENSES_THIRD_PARTY) file.

15
SECURITY.md Normal file
View File

@@ -0,0 +1,15 @@
# Security Policy
## Supported Versions
For information regarding which versions of DSpace are currently under support, please see our DSpace Software Support Policy:
https://wiki.lyrasis.org/display/DSPACE/DSpace+Software+Support+Policy
## Reporting a Vulnerability
If you believe you have found a security vulnerability in a supported version of DSpace, we encourage you to let us know right away.
We will investigate all legitimate reports and do our best to quickly fix the problem. Please see our DSpace Software Support Policy
for information on privately reporting vulnerabilities:
https://wiki.lyrasis.org/display/DSPACE/DSpace+Software+Support+Policy

View File

@@ -7,4 +7,5 @@
<!-- TODO: We should have these turned on. But, currently there's a known bug with indentation checks
on JMockIt Expectations blocks and similar. See https://github.com/checkstyle/checkstyle/issues/3739 -->
<suppress checks="Indentation" files="src[/\\]test[/\\]java"/>
<suppress checks="Regexp" files="DSpaceHttpClientFactory\.java"/>
</suppressions>

View File

@@ -44,15 +44,16 @@ For more information on CheckStyle configurations below, see: http://checkstyle.
with @SuppressWarnings. See also SuppressWarningsHolder below -->
<module name="SuppressWarningsFilter" />
<!-- Maximum line length is 120 characters -->
<module name="LineLength">
<property name="fileExtensions" value="java"/>
<property name="max" value="120"/>
<!-- Only exceptions for packages, imports, URLs, and JavaDoc {@link} tags -->
<property name="ignorePattern" value="^package.*|^import.*|http://|https://|@link"/>
</module>
<!-- Check individual Java source files for specific rules -->
<module name="TreeWalker">
<!-- Maximum line length is 120 characters -->
<module name="LineLength">
<property name="max" value="120"/>
<!-- Only exceptions for packages, imports, URLs, and JavaDoc {@link} tags -->
<property name="ignorePattern" value="^package.*|^import.*|http://|https://|@link"/>
</module>
<!-- Highlight any TODO or FIXME comments in info messages -->
<module name="TodoComment">
<property name="severity" value="info"/>
@@ -91,14 +92,9 @@ For more information on CheckStyle configurations below, see: http://checkstyle.
<!-- Requirements for Javadocs for methods -->
<module name="JavadocMethod">
<!-- All public methods MUST HAVE Javadocs -->
<!-- <property name="scope" value="public"/> -->
<!-- TODO: Above rule has been disabled because of large amount of missing public method Javadocs -->
<property name="scope" value="nothing"/>
<!-- Allow RuntimeExceptions to be undeclared -->
<property name="allowUndeclaredRTE" value="true"/>
<property name="accessModifiers" value="public"/>
<!-- Allow params, throws and return tags to be optional -->
<property name="allowMissingParamTags" value="true"/>
<property name="allowMissingThrowsTags" value="true"/>
<property name="allowMissingReturnTag" value="true"/>
</module>
@@ -140,5 +136,22 @@ For more information on CheckStyle configurations below, see: http://checkstyle.
<module name="OneStatementPerLine"/>
<!-- Require that "catch" statements are not empty (must at least contain a comment) -->
<module name="EmptyCatchBlock"/>
<!-- Require to use DSpaceHttpClientFactory.getClient() statement instead of creating directly the client -->
<module name="Regexp">
<property name="format" value="HttpClientBuilder\.create\s*\(\s*\)" />
<property name="message" value="Use DSpaceHttpClientFactory.getClient() instead of HttpClientBuilder.create()" />
<property name="illegalPattern" value="true"/>
<property name="ignoreComments" value="true"/>
</module>
<!-- Require to use DSpaceHttpClientFactory.getClient() statement instead of creating directly the client -->
<module name="Regexp">
<property name="format" value="HttpClients\.createDefault\s*\(\s*\)" />
<property name="message" value="Use DSpaceHttpClientFactory.getClient() instead of HttpClients.createDefault()" />
<property name="illegalPattern" value="true"/>
<property name="ignoreComments" value="true"/>
</module>
</module>
</module>

37
docker-compose-cli.yml Normal file
View File

@@ -0,0 +1,37 @@
networks:
# Default to using network named 'dspacenet' from docker-compose.yml.
# Its full name will be prepended with the project name (e.g. "-p d7" means it will be named "d7_dspacenet")
default:
name: ${COMPOSE_PROJECT_NAME}_dspacenet
external: true
services:
dspace-cli:
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-cli:${DSPACE_VER:-dspace-7_x}"
container_name: dspace-cli
build:
context: .
dockerfile: Dockerfile.cli
environment:
# Below syntax may look odd, but it is how to override dspace.cfg settings via env variables.
# See https://github.com/DSpace/DSpace/blob/main/dspace/config/config-definition.xml
# __P__ => "." (e.g. dspace__P__dir => dspace.dir)
# __D__ => "-" (e.g. google__D__metadata => google-metadata)
# dspace.dir: Must match with Dockerfile's DSPACE_INSTALL directory.
dspace__P__dir: /dspace
# db.url: Ensure we are using the 'dspacedb' image for our database
db__P__url: 'jdbc:postgresql://dspacedb:5432/dspace'
# solr.server: Ensure we are using the 'dspacesolr' image for Solr
solr__P__server: http://dspacesolr:8983/solr
volumes:
# Keep DSpace assetstore directory between reboots
- assetstore:/dspace/assetstore
# Mount local [src]/dspace/config/ to container. This syncs your local configs with container
# NOTE: Environment variables specified above will OVERRIDE any configs in local.cfg or dspace.cfg
- ./dspace/config:/dspace/config
entrypoint: /dspace/bin/dspace
command: help
tty: true
stdin_open: true
volumes:
assetstore:

129
docker-compose.yml Normal file
View File

@@ -0,0 +1,129 @@
networks:
dspacenet:
ipam:
config:
# Define a custom subnet for our DSpace network, so that we can easily trust requests from host to container.
# If you customize this value, be sure to customize the 'proxies.trusted.ipranges' env variable below.
- subnet: 172.23.0.0/16
services:
# DSpace (backend) webapp container
dspace:
container_name: dspace
environment:
# Below syntax may look odd, but it is how to override dspace.cfg settings via env variables.
# See https://github.com/DSpace/DSpace/blob/main/dspace/config/config-definition.xml
# __P__ => "." (e.g. dspace__P__dir => dspace.dir)
# __D__ => "-" (e.g. google__D__metadata => google-metadata)
# dspace.dir: Must match with Dockerfile's DSPACE_INSTALL directory.
dspace__P__dir: /dspace
# Uncomment to set a non-default value for dspace.server.url or dspace.ui.url
# dspace__P__server__P__url: http://localhost:8080/server
# dspace__P__ui__P__url: http://localhost:4000
dspace__P__name: 'DSpace Started with Docker Compose'
# db.url: Ensure we are using the 'dspacedb' image for our database
db__P__url: 'jdbc:postgresql://dspacedb:5432/dspace'
# solr.server: Ensure we are using the 'dspacesolr' image for Solr
solr__P__server: http://dspacesolr:8983/solr
# proxies.trusted.ipranges: This setting is required for a REST API running in Docker to trust requests
# from the host machine. This IP range MUST correspond to the 'dspacenet' subnet defined above.
proxies__P__trusted__P__ipranges: '172.23.0'
LOGGING_CONFIG: /dspace/config/log4j2-container.xml
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace:${DSPACE_VER:-dspace-7_x-test}"
build:
context: .
dockerfile: Dockerfile.test
depends_on:
- dspacedb
networks:
- dspacenet
ports:
- published: 8080
target: 8080
- published: 8009
target: 8009
- published: 8000
target: 8000
stdin_open: true
tty: true
volumes:
# Keep DSpace assetstore directory between reboots
- assetstore:/dspace/assetstore
# Mount local [src]/dspace/config/ to container. This syncs your local configs with container
# NOTE: Environment variables specified above will OVERRIDE any configs in local.cfg or dspace.cfg
- ./dspace/config:/dspace/config
# Ensure that the database is ready BEFORE starting tomcat
# 1. While a TCP connection to dspacedb port 5432 is not available, continue to sleep
# 2. Then, run database migration to init database tables
# 3. Finally, start Tomcat
entrypoint:
- /bin/bash
- '-c'
- |
while (!</dev/tcp/dspacedb/5432) > /dev/null 2>&1; do sleep 1; done;
/dspace/bin/dspace database migrate
catalina.sh run
# DSpace PostgreSQL database container
dspacedb:
container_name: dspacedb
# Uses a custom Postgres image with pgcrypto installed
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-postgres-pgcrypto:${DSPACE_VER:-dspace-7_x}"
build:
# Must build out of subdirectory to have access to install script for pgcrypto
context: ./dspace/src/main/docker/dspace-postgres-pgcrypto/
environment:
PGDATA: /pgdata
POSTGRES_PASSWORD: dspace
networks:
dspacenet:
ports:
- published: 5432
target: 5432
stdin_open: true
tty: true
volumes:
# Keep Postgres data directory between reboots
- pgdata:/pgdata
# DSpace Solr container
dspacesolr:
container_name: dspacesolr
image: "${DOCKER_REGISTRY:-docker.io}/${DOCKER_OWNER:-dspace}/dspace-solr:${DSPACE_VER:-dspace-7_x}"
build:
context: ./dspace/src/main/docker/dspace-solr/
# Provide path to Solr configs necessary to build Docker image
additional_contexts:
solrconfigs: ./dspace/solr/
args:
SOLR_VERSION: "${SOLR_VER:-8.11}"
networks:
dspacenet:
ports:
- published: 8983
target: 8983
stdin_open: true
tty: true
working_dir: /var/solr/data
volumes:
# Keep Solr data directory between reboots
- solr_data:/var/solr/data
# Initialize all DSpace Solr cores then start Solr:
# * First, run precreate-core to create the core (if it doesn't yet exist). If exists already, this is a no-op
# * Second, copy configsets to this core:
# Updates to Solr configs require the container to be rebuilt/restarted: `docker compose -p d7 up -d --build dspacesolr`
entrypoint:
- /bin/bash
- '-c'
- |
init-var-solr
precreate-core authority /opt/solr/server/solr/configsets/authority
cp -r /opt/solr/server/solr/configsets/authority/* authority
precreate-core oai /opt/solr/server/solr/configsets/oai
cp -r /opt/solr/server/solr/configsets/oai/* oai
precreate-core search /opt/solr/server/solr/configsets/search
cp -r /opt/solr/server/solr/configsets/search/* search
precreate-core statistics /opt/solr/server/solr/configsets/statistics
cp -r /opt/solr/server/solr/configsets/statistics/* statistics
exec solr -f
volumes:
assetstore:
pgdata:
solr_data:

File diff suppressed because it is too large Load Diff

View File

@@ -1,163 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.solr.handler.extraction;
/**
* The various Solr Parameters names to use when extracting content.
**/
public interface ExtractingParams {
/**
* Map all generated attribute names to field names with lowercase and underscores.
*/
public static final String LOWERNAMES = "lowernames";
/**
* if true, ignore TikaException (give up to extract text but index meta data)
*/
public static final String IGNORE_TIKA_EXCEPTION = "ignoreTikaException";
/**
* The param prefix for mapping Tika metadata to Solr fields.
* <p>
* To map a field, add a name like:
* <pre>fmap.title=solr.title</pre>
*
* In this example, the tika "title" metadata value will be added to a Solr field named "solr.title"
*/
public static final String MAP_PREFIX = "fmap.";
/**
* The boost value for the name of the field. The boost can be specified by a name mapping.
* <p>
* For example
* <pre>
* map.title=solr.title
* boost.solr.title=2.5
* </pre>
* will boost the solr.title field for this document by 2.5
*/
public static final String BOOST_PREFIX = "boost.";
/**
* Pass in literal values to be added to the document, as in
* <pre>
* literal.myField=Foo
* </pre>
*/
public static final String LITERALS_PREFIX = "literal.";
/**
* Restrict the extracted parts of a document to be indexed
* by passing in an XPath expression. All content that satisfies the XPath expr.
* will be passed to the {@link org.apache.solr.handler.extraction.SolrContentHandler}.
* <p>
* See Tika's docs for what the extracted document looks like.
*
* @see #CAPTURE_ELEMENTS
*/
public static final String XPATH_EXPRESSION = "xpath";
/**
* Only extract and return the content, do not index it.
*/
public static final String EXTRACT_ONLY = "extractOnly";
/**
* Content output format if extractOnly is true. Default is "xml", alternative is "text".
*/
public static final String EXTRACT_FORMAT = "extractFormat";
/**
* Capture attributes separately according to the name of the element, instead of just adding them to the string
* buffer
*/
public static final String CAPTURE_ATTRIBUTES = "captureAttr";
/**
* Literal field values will by default override other values such as metadata and content. Set this to false to
* revert to pre-4.0 behaviour
*/
public static final String LITERALS_OVERRIDE = "literalsOverride";
/**
* Capture the specified fields (and everything included below it that isn't capture by some other capture field)
* separately from the default. This is different
* then the case of passing in an XPath expression.
* <p>
* The Capture field is based on the localName returned to the
* {@link org.apache.solr.handler.extraction.SolrContentHandler}
* by Tika, not to be confused by the mapped field. The field name can then
* be mapped into the index schema.
* <p>
* For instance, a Tika document may look like:
* <pre>
* &lt;html&gt;
* ...
* &lt;body&gt;
* &lt;p&gt;some text here. &lt;div&gt;more text&lt;/div&gt;&lt;/p&gt;
* Some more text
* &lt;/body&gt;
* </pre>
* By passing in the p tag, you could capture all P tags separately from the rest of the t
* Thus, in the example, the capture of the P tag would be: "some text here. more text"
*/
public static final String CAPTURE_ELEMENTS = "capture";
/**
* The type of the stream. If not specified, Tika will use mime type detection.
*/
public static final String STREAM_TYPE = "stream.type";
/**
* Optional. The file name. If specified, Tika can take this into account while
* guessing the MIME type.
*/
public static final String RESOURCE_NAME = "resource.name";
/**
* Optional. The password for this resource. Will be used instead of the rule based password lookup mechanisms
*/
public static final String RESOURCE_PASSWORD = "resource.password";
/**
* Optional. If specified, the prefix will be prepended to all Metadata, such that it would be possible
* to setup a dynamic field to automatically capture it
*/
public static final String UNKNOWN_FIELD_PREFIX = "uprefix";
/**
* Optional. If specified and the name of a potential field cannot be determined, the default Field specified
* will be used instead.
*/
public static final String DEFAULT_FIELD = "defaultField";
/**
* Optional. If specified, loads the file as a source for password lookups for Tika encrypted documents.
* <p>
* File format is Java properties format with one key=value per line.
* The key is evaluated as a regex against the file name, and the value is the password
* The rules are evaluated top-bottom, i.e. the first match will be used
* If you want a fallback password to be always used, supply a .*=&lt;defaultmypassword&gt; at the end
*/
public static final String PASSWORD_MAP_FILE = "passwordsFile";
}

View File

@@ -0,0 +1,42 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.access.status;
import java.sql.SQLException;
import java.util.Date;
import org.dspace.content.Item;
import org.dspace.core.Context;
/**
* Plugin interface for the access status calculation.
*/
public interface AccessStatusHelper {
/**
* Calculate the access status for the item.
*
* @param context the DSpace context
* @param item the item
* @param threshold the embargo threshold date
* @return an access status value
* @throws SQLException An exception that provides information on a database access error or other errors.
*/
public String getAccessStatusFromItem(Context context, Item item, Date threshold)
throws SQLException;
/**
* Retrieve embargo information for the item
*
* @param context the DSpace context
* @param item the item to check for embargo information
* @param threshold the embargo threshold date
* @return an embargo date
* @throws SQLException An exception that provides information on a database access error or other errors.
*/
public String getEmbargoFromItem(Context context, Item item, Date threshold) throws SQLException;
}

View File

@@ -0,0 +1,71 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.access.status;
import java.sql.SQLException;
import java.util.Date;
import org.dspace.access.status.service.AccessStatusService;
import org.dspace.content.Item;
import org.dspace.core.Context;
import org.dspace.core.service.PluginService;
import org.dspace.services.ConfigurationService;
import org.joda.time.LocalDate;
import org.springframework.beans.factory.annotation.Autowired;
/**
* Implementation for the access status calculation service.
*/
public class AccessStatusServiceImpl implements AccessStatusService {
// Plugin implementation, set from the DSpace configuration by init().
protected AccessStatusHelper helper = null;
protected Date forever_date = null;
@Autowired(required = true)
protected ConfigurationService configurationService;
@Autowired(required = true)
protected PluginService pluginService;
/**
* Initialize the bean (after dependency injection has already taken place).
* Ensures the configurationService is injected, so that we can get the plugin
* and the forever embargo date threshold from the configuration.
* Called by "init-method" in Spring configuration.
*
* @throws Exception on generic exception
*/
public void init() throws Exception {
if (helper == null) {
helper = (AccessStatusHelper) pluginService.getSinglePlugin(AccessStatusHelper.class);
if (helper == null) {
throw new IllegalStateException("The AccessStatusHelper plugin was not defined in "
+ "DSpace configuration.");
}
// Defines the embargo forever date threshold for the access status.
// Look at EmbargoService.FOREVER for some improvements?
int year = configurationService.getIntProperty("access.status.embargo.forever.year");
int month = configurationService.getIntProperty("access.status.embargo.forever.month");
int day = configurationService.getIntProperty("access.status.embargo.forever.day");
forever_date = new LocalDate(year, month, day).toDate();
}
}
@Override
public String getAccessStatus(Context context, Item item) throws SQLException {
return helper.getAccessStatusFromItem(context, item, forever_date);
}
@Override
public String getEmbargoFromItem(Context context, Item item) throws SQLException {
return helper.getEmbargoFromItem(context, item, forever_date);
}
}

View File

@@ -0,0 +1,248 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.access.status;
import java.sql.SQLException;
import java.util.Date;
import java.util.List;
import java.util.Objects;
import org.apache.commons.lang3.StringUtils;
import org.dspace.authorize.ResourcePolicy;
import org.dspace.authorize.factory.AuthorizeServiceFactory;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.authorize.service.ResourcePolicyService;
import org.dspace.content.Bitstream;
import org.dspace.content.Bundle;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.ItemService;
import org.dspace.core.Constants;
import org.dspace.core.Context;
import org.dspace.eperson.Group;
import org.joda.time.LocalDate;
/**
* Default plugin implementation of the access status helper.
* The getAccessStatusFromItem method provides a simple logic to
* calculate the access status of an item based on the policies of
* the primary or the first bitstream in the original bundle.
* Users can override this method for enhanced functionality.
*
* The getEmbargoInformationFromItem method provides a simple logic to
* * retrieve embargo information of bitstreams from an item based on the policies of
* * the primary or the first bitstream in the original bundle.
* * Users can override this method for enhanced functionality.
*/
public class DefaultAccessStatusHelper implements AccessStatusHelper {
public static final String EMBARGO = "embargo";
public static final String METADATA_ONLY = "metadata.only";
public static final String OPEN_ACCESS = "open.access";
public static final String RESTRICTED = "restricted";
public static final String UNKNOWN = "unknown";
protected ItemService itemService =
ContentServiceFactory.getInstance().getItemService();
protected ResourcePolicyService resourcePolicyService =
AuthorizeServiceFactory.getInstance().getResourcePolicyService();
protected AuthorizeService authorizeService =
AuthorizeServiceFactory.getInstance().getAuthorizeService();
public DefaultAccessStatusHelper() {
super();
}
/**
* Look at the item's policies to determine an access status value.
* It is also considering a date threshold for embargoes and restrictions.
*
* If the item is null, simply returns the "unknown" value.
*
* @param context the DSpace context
* @param item the item to check for embargoes
* @param threshold the embargo threshold date
* @return an access status value
*/
@Override
public String getAccessStatusFromItem(Context context, Item item, Date threshold)
throws SQLException {
if (item == null) {
return UNKNOWN;
}
// Consider only the original bundles.
List<Bundle> bundles = item.getBundles(Constants.DEFAULT_BUNDLE_NAME);
// Check for primary bitstreams first.
Bitstream bitstream = bundles.stream()
.map(bundle -> bundle.getPrimaryBitstream())
.filter(Objects::nonNull)
.findFirst()
.orElse(null);
if (bitstream == null) {
// If there is no primary bitstream,
// take the first bitstream in the bundles.
bitstream = bundles.stream()
.map(bundle -> bundle.getBitstreams())
.flatMap(List::stream)
.findFirst()
.orElse(null);
}
return calculateAccessStatusForDso(context, bitstream, threshold);
}
/**
* Look at the DSpace object's policies to determine an access status value.
*
* If the object is null, returns the "metadata.only" value.
* If any policy attached to the object is valid for the anonymous group,
* returns the "open.access" value.
* Otherwise, if the policy start date is before the embargo threshold date,
* returns the "embargo" value.
* Every other cases return the "restricted" value.
*
* @param context the DSpace context
* @param dso the DSpace object
* @param threshold the embargo threshold date
* @return an access status value
*/
private String calculateAccessStatusForDso(Context context, DSpaceObject dso, Date threshold)
throws SQLException {
if (dso == null) {
return METADATA_ONLY;
}
// Only consider read policies.
List<ResourcePolicy> policies = authorizeService
.getPoliciesActionFilter(context, dso, Constants.READ);
int openAccessCount = 0;
int embargoCount = 0;
int restrictedCount = 0;
int unknownCount = 0;
// Looks at all read policies.
for (ResourcePolicy policy : policies) {
boolean isValid = resourcePolicyService.isDateValid(policy);
Group group = policy.getGroup();
// The group must not be null here. However,
// if it is, consider this as an unexpected case.
if (group == null) {
unknownCount++;
} else if (StringUtils.equals(group.getName(), Group.ANONYMOUS)) {
// Only calculate the status for the anonymous group.
if (isValid) {
// If the policy is valid, the anonymous group have access
// to the bitstream.
openAccessCount++;
} else {
Date startDate = policy.getStartDate();
if (startDate != null && !startDate.before(threshold)) {
// If the policy start date have a value and if this value
// is equal or superior to the configured forever date, the
// access status is also restricted.
restrictedCount++;
} else {
// If the current date is not between the policy start date
// and end date, the access status is embargo.
embargoCount++;
}
}
}
}
if (openAccessCount > 0) {
return OPEN_ACCESS;
}
if (embargoCount > 0 && restrictedCount == 0) {
return EMBARGO;
}
if (unknownCount > 0) {
return UNKNOWN;
}
return RESTRICTED;
}
/**
* Look at the policies of the primary (or first) bitstream of the item to retrieve its embargo.
*
* If the item is null, simply returns an empty map with no embargo information.
*
* @param context the DSpace context
* @param item the item to embargo
* @return an access status value
*/
@Override
public String getEmbargoFromItem(Context context, Item item, Date threshold)
throws SQLException {
Date embargoDate;
// If Item status is not "embargo" then return a null embargo date.
String accessStatus = getAccessStatusFromItem(context, item, threshold);
if (item == null || !accessStatus.equals(EMBARGO)) {
return null;
}
// Consider only the original bundles.
List<Bundle> bundles = item.getBundles(Constants.DEFAULT_BUNDLE_NAME);
// Check for primary bitstreams first.
Bitstream bitstream = bundles.stream()
.map(bundle -> bundle.getPrimaryBitstream())
.filter(Objects::nonNull)
.findFirst()
.orElse(null);
if (bitstream == null) {
// If there is no primary bitstream,
// take the first bitstream in the bundles.
bitstream = bundles.stream()
.map(bundle -> bundle.getBitstreams())
.flatMap(List::stream)
.findFirst()
.orElse(null);
}
if (bitstream == null) {
return null;
}
embargoDate = this.retrieveShortestEmbargo(context, bitstream);
return embargoDate != null ? embargoDate.toString() : null;
}
/**
*
*/
private Date retrieveShortestEmbargo(Context context, Bitstream bitstream) throws SQLException {
Date embargoDate = null;
// Only consider read policies.
List<ResourcePolicy> policies = authorizeService
.getPoliciesActionFilter(context, bitstream, Constants.READ);
// Looks at all read policies.
for (ResourcePolicy policy : policies) {
boolean isValid = resourcePolicyService.isDateValid(policy);
Group group = policy.getGroup();
if (group != null && StringUtils.equals(group.getName(), Group.ANONYMOUS)) {
// Only calculate the status for the anonymous group.
if (!isValid) {
// If the policy is not valid there is an active embargo
Date startDate = policy.getStartDate();
if (startDate != null && !startDate.before(LocalDate.now().toDate())) {
// There is an active embargo: aim to take the shortest embargo (account for rare cases where
// more than one resource policy exists)
if (embargoDate == null) {
embargoDate = startDate;
} else {
embargoDate = startDate.before(embargoDate) ? startDate : embargoDate;
}
}
}
}
}
return embargoDate;
}
}

View File

@@ -0,0 +1,25 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.access.status.factory;
import org.dspace.access.status.service.AccessStatusService;
import org.dspace.services.factory.DSpaceServicesFactory;
/**
* Abstract factory to get services for the access status package,
* use AccessStatusServiceFactory.getInstance() to retrieve an implementation.
*/
public abstract class AccessStatusServiceFactory {
public abstract AccessStatusService getAccessStatusService();
public static AccessStatusServiceFactory getInstance() {
return DSpaceServicesFactory.getInstance().getServiceManager()
.getServiceByName("accessStatusServiceFactory", AccessStatusServiceFactory.class);
}
}

View File

@@ -0,0 +1,26 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.access.status.factory;
import org.dspace.access.status.service.AccessStatusService;
import org.springframework.beans.factory.annotation.Autowired;
/**
* Factory implementation to get services for the access status package,
* use AccessStatusServiceFactory.getInstance() to retrieve an implementation.
*/
public class AccessStatusServiceFactoryImpl extends AccessStatusServiceFactory {
@Autowired(required = true)
private AccessStatusService accessStatusService;
@Override
public AccessStatusService getAccessStatusService() {
return accessStatusService;
}
}

View File

@@ -0,0 +1,30 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
/**
* <p>
* Access status allows the users to view the bitstreams availability before
* browsing into the item itself.
* </p>
* <p>
* The access status is calculated through a pluggable class:
* {@link org.dspace.access.status.AccessStatusHelper}.
* The {@link org.dspace.access.status.AccessStatusServiceImpl}
* must be configured to specify this class, as well as a forever embargo date
* threshold year, month and day.
* </p>
* <p>
* See {@link org.dspace.access.status.DefaultAccessStatusHelper} for a simple calculation
* based on the primary or the first bitstream of the original bundle. You can
* supply your own class to implement more complex access statuses.
* </p>
* <p>
* For now, the access status is calculated when the item is shown in a list.
* </p>
*/
package org.dspace.access.status;

View File

@@ -0,0 +1,57 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.access.status.service;
import java.sql.SQLException;
import org.dspace.content.Item;
import org.dspace.core.Context;
/**
* Public interface to the access status subsystem.
* <p>
* Configuration properties: (with examples)
* {@code
* # values for the forever embargo date threshold
* # This threshold date is used in the default access status helper to dermine if an item is
* # restricted or embargoed based on the start date of the primary (or first) file policies.
* # In this case, if the policy start date is inferior to the threshold date, the status will
* # be embargo, else it will be restricted.
* # You might want to change this threshold based on your needs. For example: some databases
* # doesn't accept a date superior to 31 december 9999.
* access.status.embargo.forever.year = 10000
* access.status.embargo.forever.month = 1
* access.status.embargo.forever.day = 1
* # implementation of access status helper plugin - replace with local implementation if applicable
* # This default access status helper provides an item status based on the policies of the primary
* # bitstream (or first bitstream in the original bundles if no primary file is specified).
* plugin.single.org.dspace.access.status.AccessStatusHelper = org.dspace.access.status.DefaultAccessStatusHelper
* }
*/
public interface AccessStatusService {
/**
* Calculate the access status for an Item while considering the forever embargo date threshold.
*
* @param context the DSpace context
* @param item the item
* @return an access status value
* @throws SQLException An exception that provides information on a database access error or other errors.
*/
public String getAccessStatus(Context context, Item item) throws SQLException;
/**
* Retrieve embargo information for the item
*
* @param context the DSpace context
* @param item the item to check for embargo information
* @return an embargo date
* @throws SQLException An exception that provides information on a database access error or other errors.
*/
public String getEmbargoFromItem(Context context, Item item) throws SQLException;
}

View File

@@ -14,10 +14,10 @@ import java.util.UUID;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.PosixParser;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.collections4.CollectionUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Community;
import org.dspace.content.factory.ContentServiceFactory;
@@ -51,7 +51,7 @@ public class CommunityFiliator {
*/
public static void main(String[] argv) throws Exception {
// create an options object and populate it
CommandLineParser parser = new PosixParser();
CommandLineParser parser = new DefaultParser();
Options options = new Options();
@@ -180,13 +180,9 @@ public class CommunityFiliator {
// second test - circularity: parent's parents can't include proposed
// child
List<Community> parentDads = parent.getParentCommunities();
for (int i = 0; i < parentDads.size(); i++) {
if (parentDads.get(i).getID().equals(child.getID())) {
System.out
.println("Error, circular parentage - child is parent of parent");
System.exit(1);
}
if (parentDads.contains(child)) {
System.out.println("Error, circular parentage - child is parent of parent");
System.exit(1);
}
// everthing's OK
@@ -210,26 +206,15 @@ public class CommunityFiliator {
throws SQLException, AuthorizeException, IOException {
// verify that child is indeed a child of parent
List<Community> parentKids = parent.getSubcommunities();
boolean isChild = false;
for (int i = 0; i < parentKids.size(); i++) {
if (parentKids.get(i).getID().equals(child.getID())) {
isChild = true;
break;
}
}
if (!isChild) {
System.out
.println("Error, child community not a child of parent community");
if (!parentKids.contains(child)) {
System.out.println("Error, child community not a child of parent community");
System.exit(1);
}
// OK remove the mappings - but leave the community, which will become
// top-level
child.getParentCommunities().remove(parent);
parent.getSubcommunities().remove(child);
child.removeParentCommunity(parent);
parent.removeSubCommunity(child);
communityService.update(c, child);
communityService.update(c, parent);

View File

@@ -13,10 +13,10 @@ import java.util.Locale;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.PosixParser;
import org.apache.commons.lang.StringUtils;
import org.dspace.core.ConfigurationManager;
import org.apache.commons.lang3.StringUtils;
import org.dspace.core.Context;
import org.dspace.core.I18nUtil;
import org.dspace.eperson.EPerson;
@@ -24,6 +24,8 @@ import org.dspace.eperson.Group;
import org.dspace.eperson.factory.EPersonServiceFactory;
import org.dspace.eperson.service.EPersonService;
import org.dspace.eperson.service.GroupService;
import org.dspace.services.ConfigurationService;
import org.dspace.services.factory.DSpaceServicesFactory;
/**
* A command-line tool for creating an initial administrator for setting up a
@@ -53,34 +55,56 @@ public final class CreateAdministrator {
protected GroupService groupService;
/**
* For invoking via the command line. If called with no command line arguments,
* For invoking via the command line. If called with no command line arguments,
* it will negotiate with the user for the administrator details
*
* @param argv the command line arguments given
* @throws Exception if error
*/
public static void main(String[] argv)
throws Exception {
CommandLineParser parser = new PosixParser();
throws Exception {
CommandLineParser parser = new DefaultParser();
Options options = new Options();
CreateAdministrator ca = new CreateAdministrator();
options.addOption("e", "email", true, "administrator email address");
options.addOption("f", "first", true, "administrator first name");
options.addOption("h", "help", false, "explain create-administrator options");
options.addOption("l", "last", true, "administrator last name");
options.addOption("c", "language", true, "administrator language");
options.addOption("p", "password", true, "administrator password");
CommandLine line = parser.parse(options, argv);
CommandLine line = null;
try {
line = parser.parse(options, argv);
} catch (Exception e) {
System.out.println(e.getMessage() + "\nTry \"dspace create-administrator -h\" to print help information.");
System.exit(1);
}
if (line.hasOption("e") && line.hasOption("f") && line.hasOption("l") &&
line.hasOption("c") && line.hasOption("p")) {
line.hasOption("c") && line.hasOption("p")) {
ca.createAdministrator(line.getOptionValue("e"),
line.getOptionValue("f"), line.getOptionValue("l"),
line.getOptionValue("c"), line.getOptionValue("p"));
line.getOptionValue("f"), line.getOptionValue("l"),
line.getOptionValue("c"), line.getOptionValue("p"));
} else if (line.hasOption("h")) {
String header = "\nA command-line tool for creating an initial administrator for setting up a" +
" DSpace site. Unless all the required parameters are passed it will" +
" prompt for an e-mail address, last name, first name and password from" +
" standard input.. An administrator group is then created and the data passed" +
" in used to create an e-person in that group.\n\n";
String footer = "\n";
HelpFormatter formatter = new HelpFormatter();
formatter.printHelp("dspace create-administrator", header, options, footer, true);
return;
} else {
ca.negotiateAdministratorDetails();
ca.negotiateAdministratorDetails(line);
}
}
@@ -90,8 +114,19 @@ public final class CreateAdministrator {
* @throws Exception if error
*/
protected CreateAdministrator()
throws Exception {
throws Exception {
context = new Context();
try {
context.getDBConfig();
} catch (NullPointerException npr) {
// if database is null, there is no point in continuing. Prior to this exception and catch,
// NullPointerException was thrown, that wasn't very helpful.
throw new IllegalStateException("Problem connecting to database. This " +
"indicates issue with either network or version (or possibly some other). " +
"If you are running this in docker-compose, please make sure dspace-cli was " +
"built from the same sources as running dspace container AND that they are in " +
"the same project/network.");
}
groupService = EPersonServiceFactory.getInstance().getGroupService();
ePersonService = EPersonServiceFactory.getInstance().getEPersonService();
}
@@ -102,20 +137,20 @@ public final class CreateAdministrator {
*
* @throws Exception if error
*/
protected void negotiateAdministratorDetails()
throws Exception {
protected void negotiateAdministratorDetails(CommandLine line)
throws Exception {
Console console = System.console();
System.out.println("Creating an initial administrator account");
boolean dataOK = false;
String email = null;
String firstName = null;
String lastName = null;
char[] password1 = null;
char[] password2 = null;
String language = I18nUtil.DEFAULTLOCALE.getLanguage();
String email = line.getOptionValue('e');
String firstName = line.getOptionValue('f');
String lastName = line.getOptionValue('l');
String language = I18nUtil.getDefaultLocale().getLanguage();
ConfigurationService cfg = DSpaceServicesFactory.getInstance().getConfigurationService();
boolean flag = line.hasOption('p');
char[] password = null;
boolean dataOK = line.hasOption('f') && line.hasOption('e') && line.hasOption('l');
while (!dataOK) {
System.out.print("E-mail address: ");
@@ -146,10 +181,9 @@ public final class CreateAdministrator {
if (lastName != null) {
lastName = lastName.trim();
}
if (ConfigurationManager.getProperty("webui.supported.locales") != null) {
System.out.println("Select one of the following languages: " + ConfigurationManager
.getProperty("webui.supported.locales"));
if (cfg.hasProperty("webui.supported.locales")) {
System.out.println("Select one of the following languages: "
+ cfg.getProperty("webui.supported.locales"));
System.out.print("Language: ");
System.out.flush();
@@ -161,46 +195,59 @@ public final class CreateAdministrator {
}
}
System.out.println("Password will not display on screen.");
System.out.print("Password: ");
System.out.print("Is the above data correct? (y or n): ");
System.out.flush();
password1 = console.readPassword();
String s = console.readLine();
System.out.print("Again to confirm: ");
System.out.flush();
password2 = console.readPassword();
//TODO real password validation
if (password1.length > 1 && Arrays.equals(password1, password2)) {
// password OK
System.out.print("Is the above data correct? (y or n): ");
System.out.flush();
String s = console.readLine();
if (s != null) {
s = s.trim();
if (s.toLowerCase().startsWith("y")) {
dataOK = true;
}
if (s != null) {
s = s.trim();
if (s.toLowerCase().startsWith("y")) {
dataOK = true;
}
} else {
System.out.println("Passwords don't match");
}
}
if (!flag) {
password = getPassword(console);
if (password == null) {
return;
}
} else {
password = line.getOptionValue("p").toCharArray();
}
// if we make it to here, we are ready to create an administrator
createAdministrator(email, firstName, lastName, language, String.valueOf(password1));
createAdministrator(email, firstName, lastName, language, String.valueOf(password));
//Cleaning arrays that held password
Arrays.fill(password1, ' ');
Arrays.fill(password2, ' ');
}
private char[] getPassword(Console console) {
char[] password1 = null;
char[] password2 = null;
System.out.println("Password will not display on screen.");
System.out.print("Password: ");
System.out.flush();
password1 = console.readPassword();
System.out.print("Again to confirm: ");
System.out.flush();
password2 = console.readPassword();
// TODO real password validation
if (password1.length > 1 && Arrays.equals(password1, password2)) {
// password OK
Arrays.fill(password2, ' ');
return password1;
} else {
System.out.println("Passwords don't match");
return null;
}
}
/**
* Create the administrator with the given details. If the user
* Create the administrator with the given details. If the user
* already exists then they are simply upped to administrator status
*
* @param email the email for the user
@@ -211,8 +258,8 @@ public final class CreateAdministrator {
* @throws Exception if error
*/
protected void createAdministrator(String email, String first, String last,
String language, String pw)
throws Exception {
String language, String pw)
throws Exception {
// Of course we aren't an administrator yet so we need to
// circumvent authorisation
context.turnOffAuthorisationSystem();

View File

@@ -10,6 +10,7 @@ package org.dspace.administer;
import java.io.BufferedWriter;
import java.io.FileWriter;
import java.io.IOException;
import java.io.Writer;
import java.sql.SQLException;
import java.util.HashMap;
import java.util.List;
@@ -17,25 +18,28 @@ import java.util.Map;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
import org.apache.commons.cli.PosixParser;
import org.apache.xml.serialize.Method;
import org.apache.xml.serialize.OutputFormat;
import org.apache.xml.serialize.XMLSerializer;
import org.dspace.content.MetadataField;
import org.dspace.content.MetadataSchema;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.MetadataFieldService;
import org.dspace.content.service.MetadataSchemaService;
import org.dspace.core.Context;
import org.xml.sax.SAXException;
import org.w3c.dom.DOMConfiguration;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
import org.w3c.dom.bootstrap.DOMImplementationRegistry;
import org.w3c.dom.ls.DOMImplementationLS;
import org.w3c.dom.ls.LSOutput;
import org.w3c.dom.ls.LSSerializer;
/**
* @author Graham Triggs
*
* This class creates an xml document as passed in the arguments and
* This class creates an XML document as passed in the arguments and
* from the metadata schemas for the repository.
*
* The form of the XML is as follows
@@ -61,17 +65,20 @@ public class MetadataExporter {
private MetadataExporter() { }
/**
* @param args commandline arguments
* @param args command line arguments
* @throws ParseException if parser error
* @throws SAXException if XML parse error
* @throws IOException if IO error
* @throws SQLException if database error
* @throws RegistryExportException if export error
* @throws ClassNotFoundException if no suitable DOM implementation
* @throws InstantiationException if no suitable DOM implementation
* @throws IllegalAccessException if no suitable DOM implementation
*/
public static void main(String[] args)
throws ParseException, SQLException, IOException, SAXException, RegistryExportException {
throws ParseException, SQLException, IOException, RegistryExportException,
ClassNotFoundException, InstantiationException, IllegalAccessException {
// create an options object and populate it
CommandLineParser parser = new PosixParser();
CommandLineParser parser = new DefaultParser();
Options options = new Options();
options.addOption("f", "file", true, "output xml file for registry");
options.addOption("s", "schema", true, "the name of the schema to export");
@@ -95,32 +102,31 @@ public class MetadataExporter {
}
/**
* Save a registry to a filepath
* Save a registry to a file path
*
* @param file filepath
* @param file file path
* @param schema schema definition to save
* @throws SQLException if database error
* @throws IOException if IO error
* @throws SAXException if XML error
* @throws RegistryExportException if export error
* @throws ClassNotFoundException if no suitable DOM implementation
* @throws InstantiationException if no suitable DOM implementation
* @throws IllegalAccessException if no suitable DOM implementation
*/
public static void saveRegistry(String file, String schema)
throws SQLException, IOException, SAXException, RegistryExportException {
throws SQLException, IOException, RegistryExportException,
ClassNotFoundException, InstantiationException, IllegalAccessException {
// create a context
Context context = new Context();
context.turnOffAuthorisationSystem();
OutputFormat xmlFormat = new OutputFormat(Method.XML, "UTF-8", true);
xmlFormat.setLineWidth(120);
xmlFormat.setIndent(4);
XMLSerializer xmlSerializer = new XMLSerializer(new BufferedWriter(new FileWriter(file)), xmlFormat);
// XMLSerializer xmlSerializer = new XMLSerializer(System.out, xmlFormat);
xmlSerializer.startDocument();
xmlSerializer.startElement("dspace-dc-types", null);
// Initialize an XML document.
Document document = DOMImplementationRegistry.newInstance()
.getDOMImplementation("XML 3.0")
.createDocument(null, "dspace-dc-types", null);
// Save the schema definition(s)
saveSchema(context, xmlSerializer, schema);
saveSchema(context, document, schema);
List<MetadataField> mdFields = null;
@@ -139,55 +145,64 @@ public class MetadataExporter {
mdFields = metadataFieldService.findAll(context);
}
// Output the metadata fields
// Compose the metadata fields
for (MetadataField mdField : mdFields) {
saveType(context, xmlSerializer, mdField);
saveType(context, document, mdField);
}
xmlSerializer.endElement("dspace-dc-types");
xmlSerializer.endDocument();
// Serialize the completed document to the output file.
try (Writer writer = new BufferedWriter(new FileWriter(file))) {
DOMImplementationLS lsImplementation
= (DOMImplementationLS) DOMImplementationRegistry.newInstance()
.getDOMImplementation("LS");
LSSerializer serializer = lsImplementation.createLSSerializer();
DOMConfiguration configuration = serializer.getDomConfig();
configuration.setParameter("format-pretty-print", true);
LSOutput lsOutput = lsImplementation.createLSOutput();
lsOutput.setEncoding("UTF-8");
lsOutput.setCharacterStream(writer);
serializer.write(document, lsOutput);
}
// abort the context, as we shouldn't have changed it!!
context.abort();
}
/**
* Serialize the schema registry. If the parameter 'schema' is null or empty, save all schemas
* Compose the schema registry. If the parameter 'schema' is null or empty, save all schemas.
*
* @param context DSpace Context
* @param xmlSerializer XML serializer
* @param document the document being built
* @param schema schema (may be null to save all)
* @throws SQLException if database error
* @throws SAXException if XML error
* @throws RegistryExportException if export error
*/
public static void saveSchema(Context context, XMLSerializer xmlSerializer, String schema)
throws SQLException, SAXException, RegistryExportException {
public static void saveSchema(Context context, Document document, String schema)
throws SQLException, RegistryExportException {
if (schema != null && !"".equals(schema)) {
// Find a single named schema
MetadataSchema mdSchema = metadataSchemaService.find(context, schema);
saveSchema(xmlSerializer, mdSchema);
saveSchema(document, mdSchema);
} else {
// Find all schemas
List<MetadataSchema> mdSchemas = metadataSchemaService.findAll(context);
for (MetadataSchema mdSchema : mdSchemas) {
saveSchema(xmlSerializer, mdSchema);
saveSchema(document, mdSchema);
}
}
}
/**
* Serialize a single schema (namespace) registry entry
* Compose a single schema (namespace) registry entry
*
* @param xmlSerializer XML serializer
* @param mdSchema DSpace metadata schema
* @throws SAXException if XML error
* @param document the output document being built.
* @param mdSchema DSpace metadata schema
* @throws RegistryExportException if export error
*/
private static void saveSchema(XMLSerializer xmlSerializer, MetadataSchema mdSchema)
throws SAXException, RegistryExportException {
private static void saveSchema(Document document, MetadataSchema mdSchema)
throws RegistryExportException {
// If we haven't got a schema, it's an error
if (mdSchema == null) {
throw new RegistryExportException("no schema to export");
@@ -206,35 +221,34 @@ public class MetadataExporter {
return;
}
// Output the parent tag
xmlSerializer.startElement("dc-schema", null);
Element document_element = document.getDocumentElement();
// Output the schema name
xmlSerializer.startElement("name", null);
xmlSerializer.characters(name.toCharArray(), 0, name.length());
xmlSerializer.endElement("name");
// Compose the parent tag
Element schema_element = document.createElement("dc-schema");
document_element.appendChild(schema_element);
// Output the schema namespace
xmlSerializer.startElement("namespace", null);
xmlSerializer.characters(namespace.toCharArray(), 0, namespace.length());
xmlSerializer.endElement("namespace");
// Compose the schema name
Element name_element = document.createElement("name");
schema_element.appendChild(name_element);
name_element.setTextContent(name);
xmlSerializer.endElement("dc-schema");
// Compose the schema namespace
Element namespace_element = document.createElement("namespace");
schema_element.appendChild(namespace_element);
namespace_element.setTextContent(namespace);
}
/**
* Serialize a single metadata field registry entry to xml
* Compose a single metadata field registry entry to XML.
*
* @param context DSpace context
* @param xmlSerializer xml serializer
* @param document the output document being built.
* @param mdField DSpace metadata field
* @throws SAXException if XML error
* @throws RegistryExportException if export error
* @throws SQLException if database error
* @throws IOException if IO error
*/
private static void saveType(Context context, XMLSerializer xmlSerializer, MetadataField mdField)
throws SAXException, RegistryExportException, SQLException, IOException {
private static void saveType(Context context, Document document, MetadataField mdField)
throws RegistryExportException, SQLException {
// If we haven't been given a field, it's an error
if (mdField == null) {
throw new RegistryExportException("no field to export");
@@ -251,38 +265,39 @@ public class MetadataExporter {
throw new RegistryExportException("incomplete field information");
}
// Output the parent tag
xmlSerializer.startElement("dc-type", null);
Element document_element = document.getDocumentElement();
// Output the schema name
xmlSerializer.startElement("schema", null);
xmlSerializer.characters(schemaName.toCharArray(), 0, schemaName.length());
xmlSerializer.endElement("schema");
// Compose the parent tag
Element dc_type = document.createElement("dc-type");
document_element.appendChild(dc_type);
// Output the element
xmlSerializer.startElement("element", null);
xmlSerializer.characters(element.toCharArray(), 0, element.length());
xmlSerializer.endElement("element");
// Compose the schema name
Element schema_element = document.createElement("schema");
dc_type.appendChild(schema_element);
schema_element.setTextContent(schemaName);
// Output the qualifier, if present
// Compose the element
Element element_element = document.createElement("element");
dc_type.appendChild(element_element);
element_element.setTextContent(element);
// Compose the qualifier, if present
if (qualifier != null) {
xmlSerializer.startElement("qualifier", null);
xmlSerializer.characters(qualifier.toCharArray(), 0, qualifier.length());
xmlSerializer.endElement("qualifier");
Element qualifier_element = document.createElement("qualifier");
dc_type.appendChild(qualifier_element);
qualifier_element.setTextContent(qualifier);
} else {
xmlSerializer.comment("unqualified");
dc_type.appendChild(document.createComment("unqualified"));
}
// Output the scope note, if present
// Compose the scope note, if present
if (scopeNote != null) {
xmlSerializer.startElement("scope_note", null);
xmlSerializer.characters(scopeNote.toCharArray(), 0, scopeNote.length());
xmlSerializer.endElement("scope_note");
Element scope_element = document.createElement("scope_note");
dc_type.appendChild(scope_element);
scope_element.setTextContent(scopeNote);
} else {
xmlSerializer.comment("no scope note");
dc_type.appendChild(document.createComment("no scope note"));
}
xmlSerializer.endElement("dc-type");
}
static Map<Integer, String> schemaMap = new HashMap<Integer, String>();
@@ -317,7 +332,7 @@ public class MetadataExporter {
}
/**
* Print the usage message to stdout
* Print the usage message to standard output
*/
public static void usage() {
String usage = "Use this class with the following options:\n" +

View File

@@ -11,16 +11,20 @@ import java.io.IOException;
import java.sql.SQLException;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.transform.TransformerException;
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathExpressionException;
import javax.xml.xpath.XPathFactory;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
import org.apache.commons.cli.PosixParser;
import org.apache.xpath.XPathAPI;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.MetadataField;
import org.dspace.content.MetadataSchema;
import org.dspace.content.MetadataSchemaEnum;
import org.dspace.content.NonUniqueMetadataException;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.MetadataFieldService;
@@ -80,7 +84,7 @@ public class MetadataImporter {
* @throws SQLException if database error
* @throws IOException if IO error
* @throws TransformerException if transformer error
* @throws ParserConfigurationException if config error
* @throws ParserConfigurationException if configuration error
* @throws AuthorizeException if authorization error
* @throws SAXException if parser error
* @throws NonUniqueMetadataException if duplicate metadata
@@ -89,26 +93,23 @@ public class MetadataImporter {
public static void main(String[] args)
throws ParseException, SQLException, IOException, TransformerException,
ParserConfigurationException, AuthorizeException, SAXException,
NonUniqueMetadataException, RegistryImportException {
boolean forceUpdate = false;
NonUniqueMetadataException, RegistryImportException, XPathExpressionException {
// create an options object and populate it
CommandLineParser parser = new PosixParser();
CommandLineParser parser = new DefaultParser();
Options options = new Options();
options.addOption("f", "file", true, "source xml file for DC fields");
options.addOption("u", "update", false, "update an existing schema");
CommandLine line = parser.parse(options, args);
String file = null;
if (line.hasOption('f')) {
file = line.getOptionValue('f');
String file = line.getOptionValue('f');
boolean forceUpdate = line.hasOption('u');
loadRegistry(file, forceUpdate);
} else {
usage();
System.exit(0);
System.exit(1);
}
forceUpdate = line.hasOption('u');
loadRegistry(file, forceUpdate);
}
/**
@@ -119,15 +120,15 @@ public class MetadataImporter {
* @throws SQLException if database error
* @throws IOException if IO error
* @throws TransformerException if transformer error
* @throws ParserConfigurationException if config error
* @throws ParserConfigurationException if configuration error
* @throws AuthorizeException if authorization error
* @throws SAXException if parser error
* @throws NonUniqueMetadataException if duplicate metadata
* @throws RegistryImportException if import fails
*/
public static void loadRegistry(String file, boolean forceUpdate)
throws SQLException, IOException, TransformerException, ParserConfigurationException,
AuthorizeException, SAXException, NonUniqueMetadataException, RegistryImportException {
throws SQLException, IOException, TransformerException, ParserConfigurationException, AuthorizeException,
SAXException, NonUniqueMetadataException, RegistryImportException, XPathExpressionException {
Context context = null;
try {
@@ -139,7 +140,9 @@ public class MetadataImporter {
Document document = RegistryImporter.loadXML(file);
// Get the nodes corresponding to types
NodeList schemaNodes = XPathAPI.selectNodeList(document, "/dspace-dc-types/dc-schema");
XPath xPath = XPathFactory.newInstance().newXPath();
NodeList schemaNodes = (NodeList) xPath.compile("/dspace-dc-types/dc-schema")
.evaluate(document, XPathConstants.NODESET);
// Add each one as a new format to the registry
for (int i = 0; i < schemaNodes.getLength(); i++) {
@@ -148,7 +151,8 @@ public class MetadataImporter {
}
// Get the nodes corresponding to types
NodeList typeNodes = XPathAPI.selectNodeList(document, "/dspace-dc-types/dc-type");
NodeList typeNodes = (NodeList) xPath.compile("/dspace-dc-types/dc-type")
.evaluate(document, XPathConstants.NODESET);
// Add each one as a new format to the registry
for (int i = 0; i < typeNodes.getLength(); i++) {
@@ -180,8 +184,8 @@ public class MetadataImporter {
* @throws RegistryImportException if import fails
*/
private static void loadSchema(Context context, Node node, boolean updateExisting)
throws SQLException, IOException, TransformerException,
AuthorizeException, NonUniqueMetadataException, RegistryImportException {
throws SQLException, AuthorizeException, NonUniqueMetadataException, RegistryImportException,
XPathExpressionException {
// Get the values
String name = RegistryImporter.getElementData(node, "name");
String namespace = RegistryImporter.getElementData(node, "namespace");
@@ -226,7 +230,7 @@ public class MetadataImporter {
/**
* Process a node in the metadata registry XML file. The node must
* be a "dc-type" node. If the type already exists, then it
* will not be reimported
* will not be re-imported.
*
* @param context DSpace context object
* @param node the node in the DOM tree
@@ -238,8 +242,8 @@ public class MetadataImporter {
* @throws RegistryImportException if import fails
*/
private static void loadType(Context context, Node node)
throws SQLException, IOException, TransformerException,
AuthorizeException, NonUniqueMetadataException, RegistryImportException {
throws SQLException, IOException, AuthorizeException, NonUniqueMetadataException, RegistryImportException,
XPathExpressionException {
// Get the values
String schema = RegistryImporter.getElementData(node, "schema");
String element = RegistryImporter.getElementData(node, "element");
@@ -248,7 +252,7 @@ public class MetadataImporter {
// If the schema is not provided default to DC
if (schema == null) {
schema = MetadataSchema.DC_SCHEMA;
schema = MetadataSchemaEnum.DC.getName();
}

View File

@@ -0,0 +1,140 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.administer;
import java.io.IOException;
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
import org.apache.commons.cli.ParseException;
import org.apache.commons.lang.time.DateUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.ProcessStatus;
import org.dspace.core.Context;
import org.dspace.scripts.DSpaceRunnable;
import org.dspace.scripts.Process;
import org.dspace.scripts.factory.ScriptServiceFactory;
import org.dspace.scripts.service.ProcessService;
import org.dspace.services.ConfigurationService;
import org.dspace.services.factory.DSpaceServicesFactory;
import org.dspace.utils.DSpace;
/**
* Script to cleanup the old processes in the specified state.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class ProcessCleaner extends DSpaceRunnable<ProcessCleanerConfiguration<ProcessCleaner>> {
private ConfigurationService configurationService;
private ProcessService processService;
private boolean cleanCompleted = false;
private boolean cleanFailed = false;
private boolean cleanRunning = false;
private boolean help = false;
private Integer days;
@Override
public void setup() throws ParseException {
this.configurationService = DSpaceServicesFactory.getInstance().getConfigurationService();
this.processService = ScriptServiceFactory.getInstance().getProcessService();
this.help = commandLine.hasOption('h');
this.cleanFailed = commandLine.hasOption('f');
this.cleanRunning = commandLine.hasOption('r');
this.cleanCompleted = commandLine.hasOption('c') || (!cleanFailed && !cleanRunning);
this.days = configurationService.getIntProperty("process-cleaner.days", 14);
if (this.days <= 0) {
throw new IllegalStateException("The number of days must be a positive integer.");
}
}
@Override
public void internalRun() throws Exception {
if (help) {
printHelp();
return;
}
Context context = new Context();
try {
context.turnOffAuthorisationSystem();
performDeletion(context);
} finally {
context.restoreAuthSystemState();
context.complete();
}
}
/**
* Delete the processes based on the specified statuses and the configured days
* from their creation.
*/
private void performDeletion(Context context) throws SQLException, IOException, AuthorizeException {
List<ProcessStatus> statuses = getProcessToDeleteStatuses();
Date creationDate = calculateCreationDate();
handler.logInfo("Searching for processes with status: " + statuses);
List<Process> processes = processService.findByStatusAndCreationTimeOlderThan(context, statuses, creationDate);
handler.logInfo("Found " + processes.size() + " processes to be deleted");
for (Process process : processes) {
processService.delete(context, process);
}
handler.logInfo("Process cleanup completed");
}
/**
* Returns the list of Process statuses do be deleted.
*/
private List<ProcessStatus> getProcessToDeleteStatuses() {
List<ProcessStatus> statuses = new ArrayList<ProcessStatus>();
if (cleanCompleted) {
statuses.add(ProcessStatus.COMPLETED);
}
if (cleanFailed) {
statuses.add(ProcessStatus.FAILED);
}
if (cleanRunning) {
statuses.add(ProcessStatus.RUNNING);
}
return statuses;
}
private Date calculateCreationDate() {
return DateUtils.addDays(new Date(), -days);
}
@Override
@SuppressWarnings("unchecked")
public ProcessCleanerConfiguration<ProcessCleaner> getScriptConfiguration() {
return new DSpace().getServiceManager()
.getServiceByName("process-cleaner", ProcessCleanerConfiguration.class);
}
}

View File

@@ -0,0 +1,18 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.administer;
/**
* The {@link ProcessCleaner} for CLI.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class ProcessCleanerCli extends ProcessCleaner {
}

View File

@@ -0,0 +1,18 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.administer;
/**
* The {@link ProcessCleanerConfiguration} for CLI.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class ProcessCleanerCliConfiguration extends ProcessCleanerConfiguration<ProcessCleanerCli> {
}

View File

@@ -0,0 +1,53 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.administer;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
/**
* The {@link ScriptConfiguration} for the {@link ProcessCleaner} script.
*/
public class ProcessCleanerConfiguration<T extends ProcessCleaner> extends ScriptConfiguration<T> {
private Class<T> dspaceRunnableClass;
@Override
public Options getOptions() {
if (options == null) {
Options options = new Options();
options.addOption("h", "help", false, "help");
options.addOption("r", "running", false, "delete the process with RUNNING status");
options.getOption("r").setType(boolean.class);
options.addOption("f", "failed", false, "delete the process with FAILED status");
options.getOption("f").setType(boolean.class);
options.addOption("c", "completed", false,
"delete the process with COMPLETED status (default if no statuses are specified)");
options.getOption("c").setType(boolean.class);
super.options = options;
}
return options;
}
@Override
public Class<T> getDspaceRunnableClass() {
return dspaceRunnableClass;
}
@Override
public void setDspaceRunnableClass(Class<T> dspaceRunnableClass) {
this.dspaceRunnableClass = dspaceRunnableClass;
}
}

View File

@@ -10,11 +10,14 @@ package org.dspace.administer;
import java.io.File;
import java.io.IOException;
import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.transform.TransformerException;
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathExpressionException;
import javax.xml.xpath.XPathFactory;
import org.apache.xpath.XPathAPI;
import org.dspace.app.util.XMLUtils;
import org.w3c.dom.Document;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
@@ -46,8 +49,9 @@ public class RegistryImporter {
*/
public static Document loadXML(String filename)
throws IOException, ParserConfigurationException, SAXException {
DocumentBuilder builder = DocumentBuilderFactory.newInstance()
.newDocumentBuilder();
// This XML builder will *not* disable external entities as XML
// registries are considered trusted content
DocumentBuilder builder = XMLUtils.getTrustedDocumentBuilder();
Document document = builder.parse(new File(filename));
@@ -72,9 +76,10 @@ public class RegistryImporter {
* @throws TransformerException if error
*/
public static String getElementData(Node parentElement, String childName)
throws TransformerException {
throws XPathExpressionException {
// Grab the child node
Node childNode = XPathAPI.selectSingleNode(parentElement, childName);
XPath xPath = XPathFactory.newInstance().newXPath();
Node childNode = (Node) xPath.compile(childName).evaluate(parentElement, XPathConstants.NODE);
if (childNode == null) {
// No child node, so no values
@@ -115,9 +120,10 @@ public class RegistryImporter {
* @throws TransformerException if error
*/
public static String[] getRepeatedElementData(Node parentElement,
String childName) throws TransformerException {
String childName) throws XPathExpressionException {
// Grab the child node
NodeList childNodes = XPathAPI.selectNodeList(parentElement, childName);
XPath xPath = XPathFactory.newInstance().newXPath();
NodeList childNodes = (NodeList) xPath.compile(childName).evaluate(parentElement, XPathConstants.NODESET);
String[] data = new String[childNodes.getLength()];

View File

@@ -13,18 +13,28 @@ import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Arrays;
import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.transform.TransformerException;
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathExpressionException;
import javax.xml.xpath.XPathFactory;
import org.apache.log4j.Logger;
import org.apache.xpath.XPathAPI;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
import org.apache.commons.lang3.StringUtils;
import org.apache.logging.log4j.Logger;
import org.dspace.app.util.XMLUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.BitstreamFormat;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.BitstreamFormatService;
import org.dspace.core.Context;
import org.dspace.core.LogManager;
import org.dspace.core.LogHelper;
import org.w3c.dom.Document;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
@@ -38,7 +48,7 @@ import org.xml.sax.SAXException;
* <P>
* <code>RegistryLoader -bitstream bitstream-formats.xml</code>
* <P>
* <code>RegistryLoader -dc dc-types.xml</code>
* <code>RegistryLoader -metadata dc-types.xml</code>
*
* @author Robert Tansley
* @version $Revision$
@@ -47,7 +57,7 @@ public class RegistryLoader {
/**
* log4j category
*/
private static Logger log = Logger.getLogger(RegistryLoader.class);
private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(RegistryLoader.class);
protected static BitstreamFormatService bitstreamFormatService = ContentServiceFactory.getInstance()
.getBitstreamFormatService();
@@ -64,50 +74,99 @@ public class RegistryLoader {
* @throws Exception if error
*/
public static void main(String[] argv) throws Exception {
String usage = "Usage: " + RegistryLoader.class.getName()
+ " (-bitstream | -metadata) registry-file.xml";
Context context = null;
// Set up command-line options and parse arguments
CommandLineParser parser = new DefaultParser();
Options options = createCommandLineOptions();
try {
context = new Context();
CommandLine line = parser.parse(options, argv);
// Check if help option was entered or no options provided
if (line.hasOption('h') || line.getOptions().length == 0) {
printHelp(options);
System.exit(0);
}
Context context = new Context();
// Can't update registries anonymously, so we need to turn off
// authorisation
context.turnOffAuthorisationSystem();
// Work out what we're loading
if (argv[0].equalsIgnoreCase("-bitstream")) {
RegistryLoader.loadBitstreamFormats(context, argv[1]);
} else if (argv[0].equalsIgnoreCase("-metadata")) {
// Call MetadataImporter, as it handles Metadata schema updates
MetadataImporter.loadRegistry(argv[1], true);
} else {
System.err.println(usage);
try {
// Work out what we're loading
if (line.hasOption('b')) {
String filename = line.getOptionValue('b');
if (StringUtils.isEmpty(filename)) {
System.err.println("No file path provided for bitstream format registry");
printHelp(options);
System.exit(1);
}
RegistryLoader.loadBitstreamFormats(context, filename);
} else if (line.hasOption('m')) {
String filename = line.getOptionValue('m');
if (StringUtils.isEmpty(filename)) {
System.err.println("No file path provided for metadata registry");
printHelp(options);
System.exit(1);
}
// Call MetadataImporter, as it handles Metadata schema updates
MetadataImporter.loadRegistry(filename, true);
} else {
System.err.println("No registry type specified");
printHelp(options);
System.exit(1);
}
// Commit changes and close Context
context.complete();
System.exit(0);
} catch (Exception e) {
log.fatal(LogHelper.getHeader(context, "error_loading_registries", ""), e);
System.err.println("Error: \n - " + e.getMessage());
System.exit(1);
} finally {
// Clean up our context, if it still exists & it was never completed
if (context != null && context.isValid()) {
context.abort();
}
}
// Commit changes and close Context
context.complete();
System.exit(0);
} catch (ArrayIndexOutOfBoundsException ae) {
System.err.println(usage);
} catch (ParseException e) {
System.err.println("Error parsing command-line arguments: " + e.getMessage());
printHelp(options);
System.exit(1);
} catch (Exception e) {
log.fatal(LogManager.getHeader(context, "error_loading_registries",
""), e);
System.err.println("Error: \n - " + e.getMessage());
System.exit(1);
} finally {
// Clean up our context, if it still exists & it was never completed
if (context != null && context.isValid()) {
context.abort();
}
}
}
/**
* Create the command-line options
* @return the command-line options
*/
private static Options createCommandLineOptions() {
Options options = new Options();
options.addOption("b", "bitstream", true, "load bitstream format registry from specified file");
options.addOption("m", "metadata", true, "load metadata registry from specified file");
options.addOption("h", "help", false, "print this help message");
return options;
}
/**
* Print the help message
* @param options the command-line options
*/
private static void printHelp(Options options) {
HelpFormatter formatter = new HelpFormatter();
formatter.printHelp("RegistryLoader",
"Load bitstream format or metadata registries into the database\n",
options,
"\nExamples:\n" +
" RegistryLoader -b bitstream-formats.xml\n" +
" RegistryLoader -m dc-types.xml",
true);
}
/**
* Load Bitstream Format metadata
*
@@ -122,12 +181,13 @@ public class RegistryLoader {
*/
public static void loadBitstreamFormats(Context context, String filename)
throws SQLException, IOException, ParserConfigurationException,
SAXException, TransformerException, AuthorizeException {
SAXException, TransformerException, AuthorizeException, XPathExpressionException {
Document document = loadXML(filename);
// Get the nodes corresponding to formats
NodeList typeNodes = XPathAPI.selectNodeList(document,
"dspace-bitstream-types/bitstream-type");
XPath xPath = XPathFactory.newInstance().newXPath();
NodeList typeNodes = (NodeList) xPath.compile("dspace-bitstream-types/bitstream-type")
.evaluate(document, XPathConstants.NODESET);
// Add each one as a new format to the registry
for (int i = 0; i < typeNodes.getLength(); i++) {
@@ -135,7 +195,7 @@ public class RegistryLoader {
loadFormat(context, n);
}
log.info(LogManager.getHeader(context, "load_bitstream_formats",
log.info(LogHelper.getHeader(context, "load_bitstream_formats",
"number_loaded=" + typeNodes.getLength()));
}
@@ -151,8 +211,7 @@ public class RegistryLoader {
* @throws AuthorizeException if authorization error
*/
private static void loadFormat(Context context, Node node)
throws SQLException, IOException, TransformerException,
AuthorizeException {
throws SQLException, AuthorizeException, XPathExpressionException {
// Get the values
String mimeType = getElementData(node, "mimetype");
String shortDesc = getElementData(node, "short_description");
@@ -207,8 +266,9 @@ public class RegistryLoader {
*/
private static Document loadXML(String filename) throws IOException,
ParserConfigurationException, SAXException {
DocumentBuilder builder = DocumentBuilderFactory.newInstance()
.newDocumentBuilder();
// This XML builder will *not* disable external entities as XML
// registries are considered trusted content
DocumentBuilder builder = XMLUtils.getTrustedDocumentBuilder();
return builder.parse(new File(filename));
}
@@ -218,7 +278,7 @@ public class RegistryLoader {
* contains:
* <P>
* <code>
* &lt;foo&gt;&lt;mimetype&gt;application/pdf&lt;/mimetype&gt;&lt;/foo&gt;
* <foo><mimetype>application/pdf</mimetype></foo>
* </code>
* passing this the <code>foo</code> node and <code>mimetype</code> will
* return <code>application/pdf</code>.
@@ -231,9 +291,10 @@ public class RegistryLoader {
* @throws TransformerException if transformer error
*/
private static String getElementData(Node parentElement, String childName)
throws TransformerException {
throws XPathExpressionException {
// Grab the child node
Node childNode = XPathAPI.selectSingleNode(parentElement, childName);
XPath xPath = XPathFactory.newInstance().newXPath();
Node childNode = (Node) xPath.compile(childName).evaluate(parentElement, XPathConstants.NODE);
if (childNode == null) {
// No child node, so no values
@@ -258,10 +319,10 @@ public class RegistryLoader {
* document contains:
* <P>
* <code>
* &lt;foo&gt;
* &lt;bar&gt;val1&lt;/bar&gt;
* &lt;bar&gt;val2&lt;/bar&gt;
* &lt;/foo&gt;
* <foo>
* <bar>val1</bar>
* <bar>val2</bar>
* </foo>
* </code>
* passing this the <code>foo</code> node and <code>bar</code> will
* return <code>val1</code> and <code>val2</code>.
@@ -274,9 +335,10 @@ public class RegistryLoader {
* @throws TransformerException if transformer error
*/
private static String[] getRepeatedElementData(Node parentElement,
String childName) throws TransformerException {
String childName) throws XPathExpressionException {
// Grab the child node
NodeList childNodes = XPathAPI.selectNodeList(parentElement, childName);
XPath xPath = XPathFactory.newInstance().newXPath();
NodeList childNodes = (NodeList) xPath.compile(childName).evaluate(parentElement, XPathConstants.NODESET);
String[] data = new String[childNodes.getLength()];

View File

@@ -7,34 +7,60 @@
*/
package org.dspace.administer;
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
import static org.dspace.content.service.DSpaceObjectService.MD_COPYRIGHT_TEXT;
import static org.dspace.content.service.DSpaceObjectService.MD_INTRODUCTORY_TEXT;
import static org.dspace.content.service.DSpaceObjectService.MD_LICENSE;
import static org.dspace.content.service.DSpaceObjectService.MD_NAME;
import static org.dspace.content.service.DSpaceObjectService.MD_PROVENANCE_DESCRIPTION;
import static org.dspace.content.service.DSpaceObjectService.MD_SHORT_DESCRIPTION;
import static org.dspace.content.service.DSpaceObjectService.MD_SIDEBAR_TEXT;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.io.PrintWriter;
import java.sql.SQLException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
import javax.xml.transform.TransformerException;
import javax.xml.xpath.XPath;
import javax.xml.xpath.XPathConstants;
import javax.xml.xpath.XPathExpressionException;
import javax.xml.xpath.XPathFactory;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Option;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.PosixParser;
import org.apache.xpath.XPathAPI;
import org.apache.commons.cli.ParseException;
import org.apache.commons.lang3.StringUtils;
import org.dspace.app.util.XMLUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Collection;
import org.dspace.content.Community;
import org.dspace.content.Item;
import org.dspace.content.MetadataFieldName;
import org.dspace.content.MetadataSchemaEnum;
import org.dspace.content.MetadataValue;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.CollectionService;
import org.dspace.content.service.CommunityService;
import org.dspace.core.Context;
import org.dspace.eperson.factory.EPersonServiceFactory;
import org.dspace.eperson.service.EPersonService;
import org.jdom.Element;
import org.jdom.output.XMLOutputter;
import org.dspace.handle.factory.HandleServiceFactory;
import org.dspace.handle.service.HandleService;
import org.jdom2.Element;
import org.jdom2.output.Format;
import org.jdom2.output.XMLOutputter;
import org.w3c.dom.Document;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
@@ -45,44 +71,54 @@ import org.xml.sax.SAXException;
* an XML file.
*
* The XML file structure needs to be:
* {@code
* <pre>{@code
* <import_structure>
* <community>
* <name>....</name>
* <community>...</community>
* <collection>
* <name>....</name>
* </collection>
* </community>
* <community>
* <name>....</name>
* <community>...</community>
* <collection>
* <name>....</name>
* </collection>
* </community>
* </import_structure>
* }
* it can be arbitrarily deep, and supports all the metadata elements
* }</pre>
*
* <p>
* It can be arbitrarily deep, and supports all the metadata elements
* that make up the community and collection metadata. See the system
* documentation for more details
* documentation for more details.
*
* @author Richard Jones
*/
public class StructBuilder {
/**
* the output xml document which will contain updated information about the
* imported structure
/** Name of the root element for the document to be imported. */
static final String INPUT_ROOT = "import_structure";
/*
* Name of the root element for the document produced by importing.
* Community and collection elements are annotated with their identifiers.
*/
private static org.jdom.Document xmlOutput = new org.jdom.Document(new Element("imported_structure"));
static final String RESULT_ROOT = "imported_structure";
/**
* a hashtable to hold metadata for the collection being worked on
* A table to hold metadata for the collection being worked on.
*/
private static Map<String, String> collectionMap = new HashMap<String, String>();
private static final Map<String, MetadataFieldName> collectionMap = new HashMap<>();
/**
* a hashtable to hold metadata for the community being worked on
* A table to hold metadata for the community being worked on.
*/
private static Map<String, String> communityMap = new HashMap<String, String>();
private static final Map<String, MetadataFieldName> communityMap = new HashMap<>();
protected static CommunityService communityService = ContentServiceFactory.getInstance().getCommunityService();
protected static CollectionService collectionService = ContentServiceFactory.getInstance().getCollectionService();
protected static EPersonService ePersonService = EPersonServiceFactory.getInstance().getEPersonService();
protected static final CommunityService communityService
= ContentServiceFactory.getInstance().getCommunityService();
protected static final CollectionService collectionService
= ContentServiceFactory.getInstance().getCollectionService();
protected static final EPersonService ePersonService
= EPersonServiceFactory.getInstance().getEPersonService();
protected static final HandleService handleService
= HandleServiceFactory.getInstance().getHandleService();
/**
* Default constructor
@@ -91,135 +127,384 @@ public class StructBuilder {
/**
* Main method to be run from the command line to import a structure into
* DSpace
* DSpacee or export existing structure to a file.The command is of the form:
*
* This is of the form:
* <p>{@code StructBuilder -f [XML source] -e [administrator email] -o [output file]}
*
* {@code StructBuilder -f [xml source] -e [administrator email] -o [output file]}
* <p>to import, or
*
* The output file will contain exactly the same as the source xml document, but
* with the handle for each imported item added as an attribute.
* <p>{@code StructBuilder -x -e [administrator email] -o [output file]}</p>
*
* @param argv the command line arguments given
* @throws Exception if an error occurs
* <p>to export. The output will contain exactly the same as the source XML
* document, but with the Handle for each imported item added as an attribute.
*
*
* @param argv command line arguments.
* @throws ParserConfigurationException passed through.
* @throws SQLException passed through.
* @throws FileNotFoundException if input or output could not be opened.
* @throws TransformerException if the input document is invalid.
* @throws XPathExpressionException passed through.
*/
public static void main(String[] argv)
throws Exception {
CommandLineParser parser = new PosixParser();
throws ParserConfigurationException, SQLException,
IOException, TransformerException, XPathExpressionException {
// Define command line options.
Options options = new Options();
options.addOption("f", "file", true, "file");
options.addOption("e", "eperson", true, "eperson");
options.addOption("o", "output", true, "output");
options.addOption("h", "help", false, "Print this help message.");
options.addOption("?", "help");
options.addOption("x", "export", false, "Export the current structure as XML.");
options.addOption("k", "keep-handles", false, "Apply Handles from input document.");
CommandLine line = parser.parse(options, argv);
options.addOption(Option.builder("e").longOpt("eperson")
.desc("User who is manipulating the repository's structure.")
.hasArg().argName("eperson").required().build());
String file = null;
String eperson = null;
String output = null;
options.addOption(Option.builder("f").longOpt("file")
.desc("File of new structure information.")
.hasArg().argName("input").build());
if (line.hasOption('f')) {
file = line.getOptionValue('f');
options.addOption(Option.builder("o").longOpt("output")
.desc("File to receive the structure map ('-' for standard out).")
.hasArg().argName("output").required().build());
// Parse the command line.
CommandLineParser parser = new DefaultParser();
CommandLine line = null;
try {
line = parser.parse(options, argv);
} catch (ParseException ex) {
System.err.println(ex.getMessage());
usage(options);
System.exit(1);
}
if (line.hasOption('e')) {
eperson = line.getOptionValue('e');
}
if (line.hasOption('o')) {
output = line.getOptionValue('o');
}
if (output == null || eperson == null || file == null) {
usage();
// If the user asked for help, give it and exit.
if (line.hasOption('h') || line.hasOption('?')) {
giveHelp(options);
System.exit(0);
}
// Otherwise, analyze the command.
// Must be import or export.
if (!(line.hasOption('f') || line.hasOption('x'))) {
giveHelp(options);
System.exit(1);
}
// Open the output stream.
String output = line.getOptionValue('o');
OutputStream outputStream;
if ("-".equals(output)) {
outputStream = System.out;
} else {
outputStream = new FileOutputStream(output);
}
// create a context
Context context = new Context();
// set the context
context.setCurrentUser(ePersonService.findByEmail(context, eperson));
// set the context.
String eperson = line.getOptionValue('e');
try {
context.setCurrentUser(ePersonService.findByEmail(context, eperson));
} catch (SQLException ex) {
System.err.format("That user could not be found: %s%n", ex.getMessage());
System.exit(1);
}
// Export? Import?
if (line.hasOption('x')) { // export
exportStructure(context, outputStream);
outputStream.close();
} else { // Must be import
String input = line.getOptionValue('f');
if (null == input) {
usage(options);
System.exit(1);
}
InputStream inputStream;
if ("-".equals(input)) {
inputStream = System.in;
} else {
inputStream = new FileInputStream(input);
}
boolean keepHandles = options.hasOption("k");
importStructure(context, inputStream, outputStream, keepHandles);
inputStream.close();
outputStream.close();
// save changes from import
context.complete();
}
System.exit(0);
}
/**
* Import new Community/Collection structure.
*
* @param context
* @param input XML which describes the new communities and collections.
* @param output input, annotated with the new objects' identifiers.
* @param keepHandles true if Handles should be set from input.
* @throws IOException
* @throws ParserConfigurationException
* @throws SAXException
* @throws TransformerException
* @throws SQLException
*/
static void importStructure(Context context, InputStream input,
OutputStream output, boolean keepHandles)
throws IOException, ParserConfigurationException, SQLException,
TransformerException, XPathExpressionException {
// load the XML
Document document = loadXML(file);
Document document = null;
try {
document = loadXML(input);
} catch (IOException ex) {
System.err.format("The input document could not be read: %s%n", ex.getMessage());
System.exit(1);
} catch (SAXException ex) {
System.err.format("The input document could not be parsed: %s%n", ex.getMessage());
System.exit(1);
}
// run the preliminary validation, to be sure that the the XML document
// is properly structured
validate(document);
// is properly structured.
try {
validate(document);
} catch (XPathExpressionException ex) {
System.err.format("The input document is invalid: %s%n", ex.getMessage());
System.exit(1);
}
// Check for 'identifier' attributes -- possibly output by this class.
XPath xPath = XPathFactory.newInstance().newXPath();
NodeList identifierNodes = (NodeList) xPath.compile("//*[@identifier]")
.evaluate(document, XPathConstants.NODESET);
if (identifierNodes.getLength() > 0) {
if (!keepHandles) {
System.err.println("The input document has 'identifier' attributes, which will be ignored.");
} else {
for (int i = 0; i < identifierNodes.getLength() ; i++) {
String identifier = identifierNodes.item(i).getAttributes().item(0).getTextContent();
if (handleService.resolveToURL(context, identifier) != null) {
System.err.printf("The input document contains handle %s,"
+ " which is in use already. Aborting...%n",
identifier);
System.exit(1);
}
}
}
}
// load the mappings into the member variable hashmaps
communityMap.put("name", "name");
communityMap.put("description", "short_description");
communityMap.put("intro", "introductory_text");
communityMap.put("copyright", "copyright_text");
communityMap.put("sidebar", "side_bar_text");
communityMap.put("name", MD_NAME);
communityMap.put("description", MD_SHORT_DESCRIPTION);
communityMap.put("intro", MD_INTRODUCTORY_TEXT);
communityMap.put("copyright", MD_COPYRIGHT_TEXT);
communityMap.put("sidebar", MD_SIDEBAR_TEXT);
collectionMap.put("name", "name");
collectionMap.put("description", "short_description");
collectionMap.put("intro", "introductory_text");
collectionMap.put("copyright", "copyright_text");
collectionMap.put("sidebar", "side_bar_text");
collectionMap.put("license", "license");
collectionMap.put("provenance", "provenance_description");
collectionMap.put("name", MD_NAME);
collectionMap.put("description", MD_SHORT_DESCRIPTION);
collectionMap.put("intro", MD_INTRODUCTORY_TEXT);
collectionMap.put("copyright", MD_COPYRIGHT_TEXT);
collectionMap.put("sidebar", MD_SIDEBAR_TEXT);
collectionMap.put("license", MD_LICENSE);
collectionMap.put("provenance", MD_PROVENANCE_DESCRIPTION);
// get the top level community list
NodeList first = XPathAPI.selectNodeList(document, "/import_structure/community");
Element[] elements = new Element[]{};
try {
// get the top level community list
NodeList first = (NodeList) xPath.compile("/import_structure/community")
.evaluate(document, XPathConstants.NODESET);
// run the import starting with the top level communities
Element[] elements = handleCommunities(context, first, null);
// run the import starting with the top level communities
elements = handleCommunities(context, first, null, keepHandles);
} catch (TransformerException ex) {
System.err.format("Input content not understood: %s%n", ex.getMessage());
System.exit(1);
} catch (AuthorizeException ex) {
System.err.format("Not authorized: %s%n", ex.getMessage());
System.exit(1);
}
// generate the output
Element root = xmlOutput.getRootElement();
for (int i = 0; i < elements.length; i++) {
root.addContent(elements[i]);
final Element root = new Element(RESULT_ROOT);
for (Element element : elements) {
root.addContent(element);
}
// finally write the string into the output file
// finally write the string into the output file.
final org.jdom2.Document xmlOutput = new org.jdom2.Document(root);
try {
BufferedWriter out = new BufferedWriter(new FileWriter(output));
out.write(new XMLOutputter().outputString(xmlOutput));
out.close();
new XMLOutputter().output(xmlOutput, output);
} catch (IOException e) {
System.out.println("Unable to write to output file " + output);
System.exit(0);
System.out.printf("Unable to write to output file %s: %s%n",
output, e.getMessage());
System.exit(1);
}
}
/**
* Add a single community, and its children, to the Document.
*
* @param community
* @return a fragment representing this Community.
*/
private static Element exportACommunity(Community community) {
// Export this Community.
Element element = new Element("community");
element.setAttribute("identifier", community.getHandle());
element.addContent(new Element("name").setText(community.getName()));
element.addContent(new Element("description")
.setText(communityService.getMetadataFirstValue(community,
MetadataSchemaEnum.DC.getName(), "description", "abstract", Item.ANY)));
element.addContent(new Element("intro")
.setText(communityService.getMetadataFirstValue(community,
MetadataSchemaEnum.DC.getName(), "description", null, Item.ANY)));
element.addContent(new Element("copyright")
.setText(communityService.getMetadataFirstValue(community,
MetadataSchemaEnum.DC.getName(), "rights", null, Item.ANY)));
element.addContent(new Element("sidebar")
.setText(communityService.getMetadataFirstValue(community,
MetadataSchemaEnum.DC.getName(), "description", "tableofcontents", Item.ANY)));
// Export this Community's Community children.
for (Community subCommunity : community.getSubcommunities()) {
element.addContent(exportACommunity(subCommunity));
}
context.complete();
// Export this Community's Collection children.
for (Collection collection : community.getCollections()) {
element.addContent(exportACollection(collection));
}
return element;
}
/**
* Output the usage information
* Add a single Collection to the Document.
*
* @param collection
* @return a fragment representing this Collection.
*/
private static void usage() {
System.out.println("Usage: java StructBuilder -f <source XML file> -o <output file> -e <eperson email>");
System.out.println(
"Communities will be created from the top level, and a map of communities to handles will be returned in " +
"the output file");
return;
private static Element exportACollection(Collection collection) {
// Export this Collection.
Element element = new Element("collection");
element.setAttribute("identifier", collection.getHandle());
element.addContent(new Element("name").setText(collection.getName()));
element.addContent(new Element("description")
.setText(collectionService.getMetadataFirstValue(collection,
MetadataSchemaEnum.DC.getName(), "description", "abstract", Item.ANY)));
element.addContent(new Element("intro")
.setText(collectionService.getMetadataFirstValue(collection,
MetadataSchemaEnum.DC.getName(), "description", null, Item.ANY)));
element.addContent(new Element("copyright")
.setText(collectionService.getMetadataFirstValue(collection,
MetadataSchemaEnum.DC.getName(), "rights", null, Item.ANY)));
element.addContent(new Element("sidebar")
.setText(collectionService.getMetadataFirstValue(collection,
MetadataSchemaEnum.DC.getName(), "description", "tableofcontents", Item.ANY)));
element.addContent(new Element("license")
.setText(collectionService.getMetadataFirstValue(collection,
MetadataSchemaEnum.DC.getName(), "rights", "license", Item.ANY)));
// Provenance is special: multivalued
for (MetadataValue value : collectionService.getMetadata(collection,
MetadataSchemaEnum.DC.getName(), "provenance", null, Item.ANY)) {
element.addContent(new Element("provenance")
.setText(value.getValue()));
}
return element;
}
/**
* Validate the XML document. This method does not return, but if validation
* fails it generates an error and ceases execution
* Write out the existing Community/Collection structure.
*/
static void exportStructure(Context context, OutputStream output) {
// Build a document from the Community/Collection hierarchy.
Element rootElement = new Element(INPUT_ROOT); // To be read by importStructure, perhaps
List<Community> communities = null;
try {
communities = communityService.findAllTop(context);
} catch (SQLException ex) {
System.out.printf("Unable to get the list of top-level communities: %s%n",
ex.getMessage());
System.exit(1);
}
for (Community community : communities) {
rootElement.addContent(exportACommunity(community));
}
// Now write the structure out.
org.jdom2.Document xmlOutput = new org.jdom2.Document(rootElement);
try {
XMLOutputter outputter = new XMLOutputter(Format.getPrettyFormat());
outputter.output(xmlOutput, output);
} catch (IOException e) {
System.out.printf("Unable to write to output file %s: %s%n",
output, e.getMessage());
System.exit(1);
}
}
/**
* Output the usage information.
*/
private static void usage(Options options) {
HelpFormatter helper = new HelpFormatter();
try (PrintWriter writer = new PrintWriter(System.out);) {
helper.printUsage(writer, 80/* FIXME Magic */,
"structure-builder", options);
}
}
/**
* Help the user more.
*/
private static void giveHelp(Options options) {
HelpFormatter formatter = new HelpFormatter();
formatter.printHelp("struct-builder",
"Import or export Community/Collection structure.",
options,
"When importing (-f), communities will be created from the "
+ "top level, and a map of communities to handles will "
+ "be returned in the output file. When exporting (-x),"
+ "the current structure will be written to the map file.",
true);
}
/**
* Validate the XML document. This method returns if the document is valid.
* If validation fails it generates an error and ceases execution.
*
* @param document the XML document object
* @throws TransformerException if transformer error
*/
private static void validate(org.w3c.dom.Document document)
throws TransformerException {
StringBuffer err = new StringBuffer();
throws XPathExpressionException {
StringBuilder err = new StringBuilder();
boolean trip = false;
err.append("The following errors were encountered parsing the source XML\n");
err.append("No changes have been made to the DSpace instance\n\n");
err.append("The following errors were encountered parsing the source XML.\n");
err.append("No changes have been made to the DSpace instance.\n\n");
NodeList first = XPathAPI.selectNodeList(document, "/import_structure/community");
XPath xPath = XPathFactory.newInstance().newXPath();
NodeList first = (NodeList) xPath.compile("/import_structure/community")
.evaluate(document, XPathConstants.NODESET);
if (first.getLength() == 0) {
err.append("-There are no top level communities in the source document");
err.append("-There are no top level communities in the source document.");
System.out.println(err.toString());
System.exit(0);
System.exit(1);
}
String errs = validateCommunities(first, 1);
@@ -230,13 +515,13 @@ public class StructBuilder {
if (trip) {
System.out.println(err.toString());
System.exit(0);
System.exit(1);
}
}
/**
* Validate the communities section of the XML document. This returns a string
* containing any errors encountered, or null if there were no errors
* containing any errors encountered, or null if there were no errors.
*
* @param communities the NodeList of communities to validate
* @param level the level in the XML document that we are at, for the purposes
@@ -245,23 +530,25 @@ public class StructBuilder {
* no errors.
*/
private static String validateCommunities(NodeList communities, int level)
throws TransformerException {
StringBuffer err = new StringBuffer();
throws XPathExpressionException {
StringBuilder err = new StringBuilder();
boolean trip = false;
String errs = null;
XPath xPath = XPathFactory.newInstance().newXPath();
for (int i = 0; i < communities.getLength(); i++) {
Node n = communities.item(i);
NodeList name = XPathAPI.selectNodeList(n, "name");
NodeList name = (NodeList) xPath.compile("name").evaluate(n, XPathConstants.NODESET);
if (name.getLength() != 1) {
String pos = Integer.toString(i + 1);
err.append("-The level " + level + " community in position " + pos);
err.append(" does not contain exactly one name field\n");
err.append("-The level ").append(level)
.append(" community in position ").append(pos)
.append(" does not contain exactly one name field.\n");
trip = true;
}
// validate sub communities
NodeList subCommunities = XPathAPI.selectNodeList(n, "community");
NodeList subCommunities = (NodeList) xPath.compile("community").evaluate(n, XPathConstants.NODESET);
String comErrs = validateCommunities(subCommunities, level + 1);
if (comErrs != null) {
err.append(comErrs);
@@ -269,7 +556,7 @@ public class StructBuilder {
}
// validate collections
NodeList collections = XPathAPI.selectNodeList(n, "collection");
NodeList collections = (NodeList) xPath.compile("collection").evaluate(n, XPathConstants.NODESET);
String colErrs = validateCollections(collections, level + 1);
if (colErrs != null) {
err.append(colErrs);
@@ -286,25 +573,27 @@ public class StructBuilder {
/**
* validate the collection section of the XML document. This generates a
* string containing any errors encountered, or returns null if no errors
* string containing any errors encountered, or returns null if no errors.
*
* @param collections a NodeList of collections to validate
* @param level the level in the XML document for the purposes of error reporting
* @return the errors to be generated by the calling method, or null if none
*/
private static String validateCollections(NodeList collections, int level)
throws TransformerException {
StringBuffer err = new StringBuffer();
throws XPathExpressionException {
StringBuilder err = new StringBuilder();
boolean trip = false;
String errs = null;
XPath xPath = XPathFactory.newInstance().newXPath();
for (int i = 0; i < collections.getLength(); i++) {
Node n = collections.item(i);
NodeList name = XPathAPI.selectNodeList(n, "name");
NodeList name = (NodeList) xPath.compile("name").evaluate(n, XPathConstants.NODESET);
if (name.getLength() != 1) {
String pos = Integer.toString(i + 1);
err.append("-The level " + level + " collection in position " + pos);
err.append(" does not contain exactly one name field\n");
err.append("-The level ").append(level)
.append(" collection in position ").append(pos)
.append(" does not contain exactly one name field.\n");
trip = true;
}
}
@@ -317,17 +606,17 @@ public class StructBuilder {
}
/**
* Load in the XML from file.
* Load the XML document from input.
*
* @param filename the filename to load from
* @return the DOM representation of the XML file
* @param input the filename to load from.
* @return the DOM representation of the XML input.
*/
private static org.w3c.dom.Document loadXML(String filename)
private static org.w3c.dom.Document loadXML(InputStream input)
throws IOException, ParserConfigurationException, SAXException {
DocumentBuilder builder = DocumentBuilderFactory.newInstance()
.newDocumentBuilder();
// This builder factory does not disable external DTD, entities, etc.
DocumentBuilder builder = XMLUtils.getTrustedDocumentBuilder();
org.w3c.dom.Document document = builder.parse(new File(filename));
org.w3c.dom.Document document = builder.parse(input);
return document;
}
@@ -338,7 +627,7 @@ public class StructBuilder {
* @param node the node from which we want to extract the string value
* @return the string value of the node
*/
public static String getStringValue(Node node) {
private static String getStringValue(Node node) {
String value = node.getNodeValue();
if (node.hasChildNodes()) {
@@ -359,43 +648,49 @@ public class StructBuilder {
* @param context the context of the request
* @param communities a nodelist of communities to create along with their sub-structures
* @param parent the parent community of the nodelist of communities to create
* @param keepHandles use Handles from input.
* @return an element array containing additional information regarding the
* created communities (e.g. the handles they have been assigned)
*/
private static Element[] handleCommunities(Context context, NodeList communities, Community parent)
throws TransformerException, SQLException, Exception {
private static Element[] handleCommunities(Context context, NodeList communities,
Community parent, boolean keepHandles)
throws TransformerException, SQLException, AuthorizeException,
XPathExpressionException {
Element[] elements = new Element[communities.getLength()];
XPath xPath = XPathFactory.newInstance().newXPath();
for (int i = 0; i < communities.getLength(); i++) {
Community community;
Element element = new Element("community");
Node tn = communities.item(i);
Node identifier = tn.getAttributes().getNamedItem("identifier");
// create the community or sub community
if (parent != null) {
Community community;
if (null == identifier
|| StringUtils.isBlank(identifier.getNodeValue())
|| !keepHandles) {
community = communityService.create(parent, context);
} else {
community = communityService.create(null, context);
community = communityService.create(parent, context, identifier.getNodeValue());
}
// default the short description to be an empty string
communityService.setMetadata(context, community, "short_description", " ");
communityService.setMetadataSingleValue(context, community,
MD_SHORT_DESCRIPTION, null, " ");
// now update the metadata
Node tn = communities.item(i);
for (Map.Entry<String, String> entry : communityMap.entrySet()) {
NodeList nl = XPathAPI.selectNodeList(tn, entry.getKey());
for (Map.Entry<String, MetadataFieldName> entry : communityMap.entrySet()) {
NodeList nl = (NodeList) xPath.compile(entry.getKey()).evaluate(tn, XPathConstants.NODESET);
if (nl.getLength() == 1) {
communityService.setMetadata(context, community, entry.getValue(), getStringValue(nl.item(0)));
communityService.setMetadataSingleValue(context, community,
entry.getValue(), null, getStringValue(nl.item(0)));
}
}
// FIXME: at the moment, if the community already exists by name
// then this will throw a PSQLException on a duplicate key
// violation
// Ideally we'd skip this row and continue to create sub
// communities
// and so forth where they don't exist, but it's proving
// difficult
// then this will throw an SQLException on a duplicate key
// violation.
// Ideally we'd skip this row and continue to create sub communities
// and so forth where they don't exist, but it's proving difficult
// to isolate the community that already exists without hitting
// the database directly.
communityService.update(context, community);
@@ -408,43 +703,59 @@ public class StructBuilder {
// but it's here to keep it separate from the create process in
// case
// we want to move it or make it switchable later
Element element = new Element("community");
element.setAttribute("identifier", community.getHandle());
Element nameElement = new Element("name");
nameElement.setText(communityService.getMetadata(community, "name"));
nameElement.setText(communityService.getMetadataFirstValue(
community, CommunityService.MD_NAME, Item.ANY));
element.addContent(nameElement);
if (communityService.getMetadata(community, "short_description") != null) {
String fieldValue;
fieldValue = communityService.getMetadataFirstValue(community,
CommunityService.MD_SHORT_DESCRIPTION, Item.ANY);
if (fieldValue != null) {
Element descriptionElement = new Element("description");
descriptionElement.setText(communityService.getMetadata(community, "short_description"));
descriptionElement.setText(fieldValue);
element.addContent(descriptionElement);
}
if (communityService.getMetadata(community, "introductory_text") != null) {
fieldValue = communityService.getMetadataFirstValue(community,
CommunityService.MD_INTRODUCTORY_TEXT, Item.ANY);
if (fieldValue != null) {
Element introElement = new Element("intro");
introElement.setText(communityService.getMetadata(community, "introductory_text"));
introElement.setText(fieldValue);
element.addContent(introElement);
}
if (communityService.getMetadata(community, "copyright_text") != null) {
fieldValue = communityService.getMetadataFirstValue(community,
CommunityService.MD_COPYRIGHT_TEXT, Item.ANY);
if (fieldValue != null) {
Element copyrightElement = new Element("copyright");
copyrightElement.setText(communityService.getMetadata(community, "copyright_text"));
copyrightElement.setText(fieldValue);
element.addContent(copyrightElement);
}
if (communityService.getMetadata(community, "side_bar_text") != null) {
fieldValue = communityService.getMetadataFirstValue(community,
CommunityService.MD_SIDEBAR_TEXT, Item.ANY);
if (fieldValue != null) {
Element sidebarElement = new Element("sidebar");
sidebarElement.setText(communityService.getMetadata(community, "side_bar_text"));
sidebarElement.setText(fieldValue);
element.addContent(sidebarElement);
}
// handle sub communities
NodeList subCommunities = XPathAPI.selectNodeList(tn, "community");
Element[] subCommunityElements = handleCommunities(context, subCommunities, community);
NodeList subCommunities = (NodeList) xPath.compile("community")
.evaluate(tn, XPathConstants.NODESET);
Element[] subCommunityElements = handleCommunities(context,
subCommunities, community, keepHandles);
// handle collections
NodeList collections = XPathAPI.selectNodeList(tn, "collection");
Element[] collectionElements = handleCollections(context, collections, community);
NodeList collections = (NodeList) xPath.compile("collection")
.evaluate(tn, XPathConstants.NODESET);
Element[] collectionElements = handleCollections(context,
collections, community, keepHandles);
int j;
for (j = 0; j < subCommunityElements.length; j++) {
@@ -469,67 +780,96 @@ public class StructBuilder {
* @return an Element array containing additional information about the
* created collections (e.g. the handle)
*/
private static Element[] handleCollections(Context context, NodeList collections, Community parent)
throws TransformerException, SQLException, AuthorizeException, IOException, Exception {
private static Element[] handleCollections(Context context,
NodeList collections, Community parent, boolean keepHandles)
throws SQLException, AuthorizeException, XPathExpressionException {
Element[] elements = new Element[collections.getLength()];
XPath xPath = XPathFactory.newInstance().newXPath();
for (int i = 0; i < collections.getLength(); i++) {
Element element = new Element("collection");
Collection collection = collectionService.create(context, parent);
Node tn = collections.item(i);
Node identifier = tn.getAttributes().getNamedItem("identifier");
// Create the Collection.
Collection collection;
if (null == identifier
|| StringUtils.isBlank(identifier.getNodeValue())
|| !keepHandles) {
collection = collectionService.create(context, parent);
} else {
collection = collectionService.create(context, parent, identifier.getNodeValue());
}
// default the short description to the empty string
collectionService.setMetadata(context, collection, "short_description", " ");
collectionService.setMetadataSingleValue(context, collection,
MD_SHORT_DESCRIPTION, null, " ");
// import the rest of the metadata
Node tn = collections.item(i);
for (Map.Entry<String, String> entry : collectionMap.entrySet()) {
NodeList nl = XPathAPI.selectNodeList(tn, entry.getKey());
for (Map.Entry<String, MetadataFieldName> entry : collectionMap.entrySet()) {
NodeList nl = (NodeList) xPath.compile(entry.getKey()).evaluate(tn, XPathConstants.NODESET);
if (nl.getLength() == 1) {
collectionService.setMetadata(context, collection, entry.getValue(), getStringValue(nl.item(0)));
collectionService.setMetadataSingleValue(context, collection,
entry.getValue(), null, getStringValue(nl.item(0)));
}
}
collectionService.update(context, collection);
Element element = new Element("collection");
element.setAttribute("identifier", collection.getHandle());
Element nameElement = new Element("name");
nameElement.setText(collectionService.getMetadata(collection, "name"));
nameElement.setText(collectionService.getMetadataFirstValue(collection,
CollectionService.MD_NAME, Item.ANY));
element.addContent(nameElement);
if (collectionService.getMetadata(collection, "short_description") != null) {
String fieldValue;
fieldValue = collectionService.getMetadataFirstValue(collection,
CollectionService.MD_SHORT_DESCRIPTION, Item.ANY);
if (fieldValue != null) {
Element descriptionElement = new Element("description");
descriptionElement.setText(collectionService.getMetadata(collection, "short_description"));
descriptionElement.setText(fieldValue);
element.addContent(descriptionElement);
}
if (collectionService.getMetadata(collection, "introductory_text") != null) {
fieldValue = collectionService.getMetadataFirstValue(collection,
CollectionService.MD_INTRODUCTORY_TEXT, Item.ANY);
if (fieldValue != null) {
Element introElement = new Element("intro");
introElement.setText(collectionService.getMetadata(collection, "introductory_text"));
introElement.setText(fieldValue);
element.addContent(introElement);
}
if (collectionService.getMetadata(collection, "copyright_text") != null) {
fieldValue = collectionService.getMetadataFirstValue(collection,
CollectionService.MD_COPYRIGHT_TEXT, Item.ANY);
if (fieldValue != null) {
Element copyrightElement = new Element("copyright");
copyrightElement.setText(collectionService.getMetadata(collection, "copyright_text"));
copyrightElement.setText(fieldValue);
element.addContent(copyrightElement);
}
if (collectionService.getMetadata(collection, "side_bar_text") != null) {
fieldValue = collectionService.getMetadataFirstValue(collection,
CollectionService.MD_SIDEBAR_TEXT, Item.ANY);
if (fieldValue != null) {
Element sidebarElement = new Element("sidebar");
sidebarElement.setText(collectionService.getMetadata(collection, "side_bar_text"));
sidebarElement.setText(fieldValue);
element.addContent(sidebarElement);
}
if (collectionService.getMetadata(collection, "license") != null) {
fieldValue = collectionService.getMetadataFirstValue(collection,
CollectionService.MD_LICENSE, Item.ANY);
if (fieldValue != null) {
Element sidebarElement = new Element("license");
sidebarElement.setText(collectionService.getMetadata(collection, "license"));
sidebarElement.setText(fieldValue);
element.addContent(sidebarElement);
}
if (collectionService.getMetadata(collection, "provenance_description") != null) {
fieldValue = collectionService.getMetadataFirstValue(collection,
CollectionService.MD_PROVENANCE_DESCRIPTION, Item.ANY);
if (fieldValue != null) {
Element sidebarElement = new Element("provenance");
sidebarElement.setText(collectionService.getMetadata(collection, "provenance_description"));
sidebarElement.setText(fieldValue);
element.addContent(sidebarElement);
}
@@ -538,5 +878,4 @@ public class StructBuilder {
return elements;
}
}

View File

@@ -0,0 +1,54 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.alerts;
/**
* Enum representing the options for allowing sessions:
* ALLOW_ALL_SESSIONS - Will allow all users to log in and continue their sessions
* ALLOW_CURRENT_SESSIONS_ONLY - Will prevent non admin users from logging in, however logged-in users
* will remain logged in
* ALLOW_ADMIN_SESSIONS_ONLY - Only admin users can log in, non admin sessions will be interrupted
*
* NOTE: This functionality can be stored in the database, but no support is present right now to interrupt and prevent
* sessions.
*/
public enum AllowSessionsEnum {
ALLOW_ALL_SESSIONS("all"),
ALLOW_CURRENT_SESSIONS_ONLY("current"),
ALLOW_ADMIN_SESSIONS_ONLY("admin");
private String allowSessionsType;
AllowSessionsEnum(String allowSessionsType) {
this.allowSessionsType = allowSessionsType;
}
public String getValue() {
return allowSessionsType;
}
public static AllowSessionsEnum fromString(String alertAllowSessionType) {
if (alertAllowSessionType == null) {
return AllowSessionsEnum.ALLOW_ALL_SESSIONS;
}
switch (alertAllowSessionType) {
case "all":
return AllowSessionsEnum.ALLOW_ALL_SESSIONS;
case "current":
return AllowSessionsEnum.ALLOW_CURRENT_SESSIONS_ONLY;
case "admin" :
return AllowSessionsEnum.ALLOW_ADMIN_SESSIONS_ONLY;
default:
throw new IllegalArgumentException("No corresponding enum value for provided string: "
+ alertAllowSessionType);
}
}
}

View File

@@ -0,0 +1,179 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.alerts;
import java.util.Date;
import javax.persistence.Cacheable;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.SequenceGenerator;
import javax.persistence.Table;
import javax.persistence.Temporal;
import javax.persistence.TemporalType;
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.dspace.core.ReloadableEntity;
import org.hibernate.annotations.CacheConcurrencyStrategy;
/**
* Database object representing system-wide alerts
*/
@Entity
@Cacheable
@org.hibernate.annotations.Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE, include = "non-lazy")
@Table(name = "systemwidealert")
public class SystemWideAlert implements ReloadableEntity<Integer> {
@Id
@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "alert_id_seq")
@SequenceGenerator(name = "alert_id_seq", sequenceName = "alert_id_seq", allocationSize = 1)
@Column(name = "alert_id", unique = true, nullable = false)
private Integer alertId;
@Column(name = "message", nullable = false)
private String message;
@Column(name = "allow_sessions")
private String allowSessions;
@Column(name = "countdown_to")
@Temporal(TemporalType.TIMESTAMP)
private Date countdownTo;
@Column(name = "active")
private boolean active;
protected SystemWideAlert() {
}
/**
* This method returns the ID that the system-wide alert holds within the database
*
* @return The ID that the system-wide alert holds within the database
*/
@Override
public Integer getID() {
return alertId;
}
/**
* Set the ID for the system-wide alert
*
* @param alertID The ID to set
*/
public void setID(final Integer alertID) {
this.alertId = alertID;
}
/**
* Retrieve the message of the system-wide alert
*
* @return the message of the system-wide alert
*/
public String getMessage() {
return message;
}
/**
* Set the message of the system-wide alert
*
* @param message The message to set
*/
public void setMessage(final String message) {
this.message = message;
}
/**
* Retrieve what kind of sessions are allowed while the system-wide alert is active
*
* @return what kind of sessions are allowed while the system-wide alert is active
*/
public AllowSessionsEnum getAllowSessions() {
return AllowSessionsEnum.fromString(allowSessions);
}
/**
* Set what kind of sessions are allowed while the system-wide alert is active
*
* @param allowSessions Integer representing what kind of sessions are allowed
*/
public void setAllowSessions(AllowSessionsEnum allowSessions) {
this.allowSessions = allowSessions.getValue();
}
/**
* Retrieve the date to which will be count down when the system-wide alert is active
*
* @return the date to which will be count down when the system-wide alert is active
*/
public Date getCountdownTo() {
return countdownTo;
}
/**
* Set the date to which will be count down when the system-wide alert is active
*
* @param countdownTo The date to which will be count down
*/
public void setCountdownTo(final Date countdownTo) {
this.countdownTo = countdownTo;
}
/**
* Retrieve whether the system-wide alert is active
*
* @return whether the system-wide alert is active
*/
public boolean isActive() {
return active;
}
/**
* Set whether the system-wide alert is active
*
* @param active Whether the system-wide alert is active
*/
public void setActive(final boolean active) {
this.active = active;
}
/**
* Return <code>true</code> if <code>other</code> is the same SystemWideAlert
* as this object, <code>false</code> otherwise
*
* @param other object to compare to
* @return <code>true</code> if object passed in represents the same
* system-wide alert as this object
*/
@Override
public boolean equals(Object other) {
return (other instanceof SystemWideAlert &&
new EqualsBuilder().append(this.getID(), ((SystemWideAlert) other).getID())
.append(this.getMessage(), ((SystemWideAlert) other).getMessage())
.append(this.getAllowSessions(), ((SystemWideAlert) other).getAllowSessions())
.append(this.getCountdownTo(), ((SystemWideAlert) other).getCountdownTo())
.append(this.isActive(), ((SystemWideAlert) other).isActive())
.isEquals());
}
@Override
public int hashCode() {
return new HashCodeBuilder(17, 37)
.append(this.getID())
.append(this.getMessage())
.append(this.getAllowSessions())
.append(this.getCountdownTo())
.append(this.isActive())
.toHashCode();
}
}

View File

@@ -0,0 +1,129 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.alerts;
import java.io.IOException;
import java.sql.SQLException;
import java.util.Date;
import java.util.List;
import org.apache.logging.log4j.Logger;
import org.dspace.alerts.dao.SystemWideAlertDAO;
import org.dspace.alerts.service.SystemWideAlertService;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.service.AuthorizeService;
import org.dspace.core.Context;
import org.dspace.core.LogHelper;
import org.dspace.eperson.EPerson;
import org.springframework.beans.factory.annotation.Autowired;
/**
* The implementation for the {@link SystemWideAlertService} class
*/
public class SystemWideAlertServiceImpl implements SystemWideAlertService {
private static final Logger log = org.apache.logging.log4j.LogManager.getLogger(SystemWideAlertService.class);
@Autowired
private SystemWideAlertDAO systemWideAlertDAO;
@Autowired
private AuthorizeService authorizeService;
@Override
public SystemWideAlert create(final Context context, final String message,
final AllowSessionsEnum allowSessionsType,
final Date countdownTo, final boolean active) throws SQLException,
AuthorizeException {
if (!authorizeService.isAdmin(context)) {
throw new AuthorizeException(
"Only administrators can create a system-wide alert");
}
SystemWideAlert systemWideAlert = new SystemWideAlert();
systemWideAlert.setMessage(message);
systemWideAlert.setAllowSessions(allowSessionsType);
systemWideAlert.setCountdownTo(countdownTo);
systemWideAlert.setActive(active);
SystemWideAlert createdAlert = systemWideAlertDAO.create(context, systemWideAlert);
log.info(LogHelper.getHeader(context, "system_wide_alert_create",
"System Wide Alert has been created with message: '" + message + "' and ID "
+ createdAlert.getID() + " and allowSessionsType " + allowSessionsType +
" and active set to " + active));
return createdAlert;
}
@Override
public SystemWideAlert find(final Context context, final int alertId) throws SQLException {
return systemWideAlertDAO.findByID(context, SystemWideAlert.class, alertId);
}
@Override
public List<SystemWideAlert> findAll(final Context context) throws SQLException {
return systemWideAlertDAO.findAll(context, SystemWideAlert.class);
}
@Override
public List<SystemWideAlert> findAll(final Context context, final int limit, final int offset) throws SQLException {
return systemWideAlertDAO.findAll(context, limit, offset);
}
@Override
public List<SystemWideAlert> findAllActive(final Context context, final int limit, final int offset)
throws SQLException {
return systemWideAlertDAO.findAllActive(context, limit, offset);
}
@Override
public void delete(final Context context, final SystemWideAlert systemWideAlert)
throws SQLException, IOException, AuthorizeException {
if (!authorizeService.isAdmin(context)) {
throw new AuthorizeException(
"Only administrators can create a system-wide alert");
}
systemWideAlertDAO.delete(context, systemWideAlert);
log.info(LogHelper.getHeader(context, "system_wide_alert_create",
"System Wide Alert with ID " + systemWideAlert.getID() + " has been deleted"));
}
@Override
public void update(final Context context, final SystemWideAlert systemWideAlert)
throws SQLException, AuthorizeException {
if (!authorizeService.isAdmin(context)) {
throw new AuthorizeException(
"Only administrators can create a system-wide alert");
}
systemWideAlertDAO.save(context, systemWideAlert);
}
@Override
public boolean canNonAdminUserLogin(Context context) throws SQLException {
List<SystemWideAlert> active = findAllActive(context, 1, 0);
if (active == null || active.isEmpty()) {
return true;
}
return active.get(0).getAllowSessions() == AllowSessionsEnum.ALLOW_ALL_SESSIONS;
}
@Override
public boolean canUserMaintainSession(Context context, EPerson ePerson) throws SQLException {
if (authorizeService.isAdmin(context, ePerson)) {
return true;
}
List<SystemWideAlert> active = findAllActive(context, 1, 0);
if (active == null || active.isEmpty()) {
return true;
}
return active.get(0).getAllowSessions() != AllowSessionsEnum.ALLOW_ADMIN_SESSIONS_ONLY;
}
}

View File

@@ -0,0 +1,45 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.alerts.dao;
import java.sql.SQLException;
import java.util.List;
import org.dspace.alerts.SystemWideAlert;
import org.dspace.core.Context;
import org.dspace.core.GenericDAO;
/**
* This is the Data Access Object for the {@link SystemWideAlert} object
*/
public interface SystemWideAlertDAO extends GenericDAO<SystemWideAlert> {
/**
* Returns a list of all SystemWideAlert objects in the database
*
* @param context The relevant DSpace context
* @param limit The limit for the amount of SystemWideAlerts returned
* @param offset The offset for the Processes to be returned
* @return The list of all SystemWideAlert objects in the Database
* @throws SQLException If something goes wrong
*/
List<SystemWideAlert> findAll(Context context, int limit, int offset) throws SQLException;
/**
* Returns a list of all active SystemWideAlert objects in the database
*
* @param context The relevant DSpace context
* @param limit The limit for the amount of SystemWideAlerts returned
* @param offset The offset for the Processes to be returned
* @return The list of all SystemWideAlert objects in the Database
* @throws SQLException If something goes wrong
*/
List<SystemWideAlert> findAllActive(Context context, int limit, int offset) throws SQLException;
}

View File

@@ -0,0 +1,48 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.alerts.dao.impl;
import java.sql.SQLException;
import java.util.List;
import javax.persistence.criteria.CriteriaBuilder;
import javax.persistence.criteria.CriteriaQuery;
import javax.persistence.criteria.Root;
import org.dspace.alerts.SystemWideAlert;
import org.dspace.alerts.SystemWideAlert_;
import org.dspace.alerts.dao.SystemWideAlertDAO;
import org.dspace.core.AbstractHibernateDAO;
import org.dspace.core.Context;
/**
* Implementation class for the {@link SystemWideAlertDAO}
*/
public class SystemWideAlertDAOImpl extends AbstractHibernateDAO<SystemWideAlert> implements SystemWideAlertDAO {
public List<SystemWideAlert> findAll(final Context context, final int limit, final int offset) throws SQLException {
CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, SystemWideAlert.class);
Root<SystemWideAlert> alertRoot = criteriaQuery.from(SystemWideAlert.class);
criteriaQuery.select(alertRoot);
return list(context, criteriaQuery, false, SystemWideAlert.class, limit, offset);
}
public List<SystemWideAlert> findAllActive(final Context context, final int limit, final int offset)
throws SQLException {
CriteriaBuilder criteriaBuilder = getCriteriaBuilder(context);
CriteriaQuery criteriaQuery = getCriteriaQuery(criteriaBuilder, SystemWideAlert.class);
Root<SystemWideAlert> alertRoot = criteriaQuery.from(SystemWideAlert.class);
criteriaQuery.select(alertRoot);
criteriaQuery.where(criteriaBuilder.equal(alertRoot.get(SystemWideAlert_.active), true));
return list(context, criteriaQuery, false, SystemWideAlert.class, limit, offset);
}
}

View File

@@ -0,0 +1,118 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.alerts.service;
import java.io.IOException;
import java.sql.SQLException;
import java.util.Date;
import java.util.List;
import org.dspace.alerts.AllowSessionsEnum;
import org.dspace.alerts.SystemWideAlert;
import org.dspace.authorize.AuthorizeException;
import org.dspace.core.Context;
import org.dspace.eperson.EPerson;
/**
* An interface for the SystemWideAlertService with methods regarding the SystemWideAlert workload
*/
public interface SystemWideAlertService {
/**
* This method will create a SystemWideAlert object in the database
*
* @param context The relevant DSpace context
* @param message The message of the system-wide alert
* @param allowSessionsType Which sessions need to be allowed for the system-wide alert
* @param countdownTo The date to which to count down to when the system-wide alert is active
* @param active Whether the system-wide alert os active
* @return The created SystemWideAlert object
* @throws SQLException If something goes wrong
*/
SystemWideAlert create(Context context, String message, AllowSessionsEnum allowSessionsType,
Date countdownTo, boolean active
) throws SQLException, AuthorizeException;
/**
* This method will retrieve a SystemWideAlert object from the Database with the given ID
*
* @param context The relevant DSpace context
* @param alertId The alert id on which we'll search for in the database
* @return The system-wide alert that holds the given alert id
* @throws SQLException If something goes wrong
*/
SystemWideAlert find(Context context, int alertId) throws SQLException;
/**
* Returns a list of all SystemWideAlert objects in the database
*
* @param context The relevant DSpace context
* @return The list of all SystemWideAlert objects in the Database
* @throws SQLException If something goes wrong
*/
List<SystemWideAlert> findAll(Context context) throws SQLException;
/**
* Returns a list of all SystemWideAlert objects in the database
*
* @param context The relevant DSpace context
* @param limit The limit for the amount of system-wide alerts returned
* @param offset The offset for the system-wide alerts to be returned
* @return The list of all SystemWideAlert objects in the Database
* @throws SQLException If something goes wrong
*/
List<SystemWideAlert> findAll(Context context, int limit, int offset) throws SQLException;
/**
* Returns a list of all active SystemWideAlert objects in the database
*
* @param context The relevant DSpace context
* @return The list of all active SystemWideAlert objects in the database
* @throws SQLException If something goes wrong
*/
List<SystemWideAlert> findAllActive(Context context, int limit, int offset) throws SQLException;
/**
* This method will delete the given SystemWideAlert object from the database
*
* @param context The relevant DSpace context
* @param systemWideAlert The SystemWideAlert object to be deleted
* @throws SQLException If something goes wrong
*/
void delete(Context context, SystemWideAlert systemWideAlert)
throws SQLException, IOException, AuthorizeException;
/**
* This method will be used to update the given SystemWideAlert object in the database
*
* @param context The relevant DSpace context
* @param systemWideAlert The SystemWideAlert object to be updated
* @throws SQLException If something goes wrong
*/
void update(Context context, SystemWideAlert systemWideAlert) throws SQLException, AuthorizeException;
/**
* Verifies if the user connected to the current context can retain its session
*
* @param context The relevant DSpace context
* @return if the user connected to the current context can retain its session
*/
boolean canUserMaintainSession(Context context, EPerson ePerson) throws SQLException;
/**
* Verifies if a non admin user can log in
*
* @param context The relevant DSpace context
* @return if a non admin user can log in
*/
boolean canNonAdminUserLogin(Context context) throws SQLException;
}

View File

@@ -0,0 +1,690 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol;
import static org.apache.commons.collections4.CollectionUtils.isEmpty;
import static org.apache.commons.collections4.CollectionUtils.isNotEmpty;
import static org.dspace.authorize.ResourcePolicy.TYPE_CUSTOM;
import static org.dspace.authorize.ResourcePolicy.TYPE_INHERITED;
import static org.dspace.core.Constants.CONTENT_BUNDLE_NAME;
import java.io.IOException;
import java.io.InputStream;
import java.sql.SQLException;
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.time.ZoneOffset;
import java.util.Arrays;
import java.util.Date;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.TimeZone;
import java.util.UUID;
import java.util.function.Function;
import java.util.stream.Collectors;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.apache.commons.cli.ParseException;
import org.apache.commons.lang3.StringUtils;
import org.dspace.app.bulkaccesscontrol.exception.BulkAccessControlException;
import org.dspace.app.bulkaccesscontrol.model.AccessCondition;
import org.dspace.app.bulkaccesscontrol.model.AccessConditionBitstream;
import org.dspace.app.bulkaccesscontrol.model.AccessConditionItem;
import org.dspace.app.bulkaccesscontrol.model.BulkAccessConditionConfiguration;
import org.dspace.app.bulkaccesscontrol.model.BulkAccessControlInput;
import org.dspace.app.bulkaccesscontrol.service.BulkAccessConditionConfigurationService;
import org.dspace.app.mediafilter.factory.MediaFilterServiceFactory;
import org.dspace.app.mediafilter.service.MediaFilterService;
import org.dspace.app.util.DSpaceObjectUtilsImpl;
import org.dspace.app.util.service.DSpaceObjectUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.authorize.factory.AuthorizeServiceFactory;
import org.dspace.authorize.service.ResourcePolicyService;
import org.dspace.content.Bitstream;
import org.dspace.content.Collection;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.ItemService;
import org.dspace.core.Constants;
import org.dspace.core.Context;
import org.dspace.discovery.DiscoverQuery;
import org.dspace.discovery.SearchService;
import org.dspace.discovery.SearchServiceException;
import org.dspace.discovery.SearchUtils;
import org.dspace.discovery.indexobject.IndexableItem;
import org.dspace.eperson.EPerson;
import org.dspace.eperson.factory.EPersonServiceFactory;
import org.dspace.eperson.service.EPersonService;
import org.dspace.scripts.DSpaceRunnable;
import org.dspace.services.ConfigurationService;
import org.dspace.services.factory.DSpaceServicesFactory;
import org.dspace.submit.model.AccessConditionOption;
import org.dspace.utils.DSpace;
/**
* Implementation of {@link DSpaceRunnable} to perform a bulk access control via json file.
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*
*/
public class BulkAccessControl extends DSpaceRunnable<BulkAccessControlScriptConfiguration<BulkAccessControl>> {
private DSpaceObjectUtils dSpaceObjectUtils;
private SearchService searchService;
private ItemService itemService;
private String filename;
private List<String> uuids;
private Context context;
private BulkAccessConditionConfigurationService bulkAccessConditionConfigurationService;
private ResourcePolicyService resourcePolicyService;
protected EPersonService epersonService;
private ConfigurationService configurationService;
private MediaFilterService mediaFilterService;
private Map<String, AccessConditionOption> itemAccessConditions;
private Map<String, AccessConditionOption> uploadAccessConditions;
private final String ADD_MODE = "add";
private final String REPLACE_MODE = "replace";
private boolean help = false;
protected String eperson = null;
@Override
@SuppressWarnings("unchecked")
public void setup() throws ParseException {
this.searchService = SearchUtils.getSearchService();
this.itemService = ContentServiceFactory.getInstance().getItemService();
this.resourcePolicyService = AuthorizeServiceFactory.getInstance().getResourcePolicyService();
this.epersonService = EPersonServiceFactory.getInstance().getEPersonService();
this.configurationService = DSpaceServicesFactory.getInstance().getConfigurationService();
mediaFilterService = MediaFilterServiceFactory.getInstance().getMediaFilterService();
mediaFilterService.setLogHandler(handler);
this.bulkAccessConditionConfigurationService = new DSpace().getServiceManager().getServiceByName(
"bulkAccessConditionConfigurationService", BulkAccessConditionConfigurationService.class);
this.dSpaceObjectUtils = new DSpace().getServiceManager().getServiceByName(
DSpaceObjectUtilsImpl.class.getName(), DSpaceObjectUtilsImpl.class);
BulkAccessConditionConfiguration bulkAccessConditionConfiguration =
bulkAccessConditionConfigurationService.getBulkAccessConditionConfiguration("default");
itemAccessConditions = bulkAccessConditionConfiguration
.getItemAccessConditionOptions()
.stream()
.collect(Collectors.toMap(AccessConditionOption::getName, Function.identity()));
uploadAccessConditions = bulkAccessConditionConfiguration
.getBitstreamAccessConditionOptions()
.stream()
.collect(Collectors.toMap(AccessConditionOption::getName, Function.identity()));
help = commandLine.hasOption('h');
filename = commandLine.getOptionValue('f');
uuids = commandLine.hasOption('u') ? Arrays.asList(commandLine.getOptionValues('u')) : null;
}
@Override
public void internalRun() throws Exception {
if (help) {
printHelp();
return;
}
ObjectMapper mapper = new ObjectMapper();
mapper.setTimeZone(TimeZone.getTimeZone(ZoneOffset.UTC));
BulkAccessControlInput accessControl;
context = new Context(Context.Mode.BATCH_EDIT);
setEPerson(context);
if (!isAuthorized(context)) {
handler.logError("Current user is not eligible to execute script bulk-access-control");
throw new AuthorizeException("Current user is not eligible to execute script bulk-access-control");
}
if (uuids == null || uuids.size() == 0) {
handler.logError("A target uuid must be provided with at least on uuid (run with -h flag for details)");
throw new IllegalArgumentException("At least one target uuid must be provided");
}
InputStream inputStream = handler.getFileStream(context, filename)
.orElseThrow(() -> new IllegalArgumentException("Error reading file, the file couldn't be "
+ "found for filename: " + filename));
try {
accessControl = mapper.readValue(inputStream, BulkAccessControlInput.class);
} catch (IOException e) {
handler.logError("Error parsing json file " + e.getMessage());
throw new IllegalArgumentException("Error parsing json file", e);
}
try {
validate(accessControl);
updateItemsAndBitstreamsPolices(accessControl);
context.complete();
} catch (Exception e) {
handler.handleException(e);
context.abort();
}
}
/**
* check the validation of mapped json data, it must
* provide item or bitstream information or both of them
* and check the validation of item node if provided,
* and check the validation of bitstream node if provided.
*
* @param accessControl mapped json data
* @throws SQLException if something goes wrong in the database
* @throws BulkAccessControlException if accessControl is invalid
*/
private void validate(BulkAccessControlInput accessControl) throws SQLException {
AccessConditionItem item = accessControl.getItem();
AccessConditionBitstream bitstream = accessControl.getBitstream();
if (Objects.isNull(item) && Objects.isNull(bitstream)) {
handler.logError("item or bitstream node must be provided");
throw new BulkAccessControlException("item or bitstream node must be provided");
}
if (Objects.nonNull(item)) {
validateItemNode(item);
}
if (Objects.nonNull(bitstream)) {
validateBitstreamNode(bitstream);
}
}
/**
* check the validation of item node, the item mode
* must be provided with value 'add' or 'replace'
* if mode equals to add so the information
* of accessCondition must be provided,
* also checking that accessConditions information are valid.
*
* @param item the item node
* @throws BulkAccessControlException if item node is invalid
*/
private void validateItemNode(AccessConditionItem item) {
String mode = item.getMode();
List<AccessCondition> accessConditions = item.getAccessConditions();
if (StringUtils.isEmpty(mode)) {
handler.logError("item mode node must be provided");
throw new BulkAccessControlException("item mode node must be provided");
} else if (!(StringUtils.equalsAny(mode, ADD_MODE, REPLACE_MODE))) {
handler.logError("wrong value for item mode<" + mode + ">");
throw new BulkAccessControlException("wrong value for item mode<" + mode + ">");
} else if (ADD_MODE.equals(mode) && isEmpty(accessConditions)) {
handler.logError("accessConditions of item must be provided with mode<" + ADD_MODE + ">");
throw new BulkAccessControlException(
"accessConditions of item must be provided with mode<" + ADD_MODE + ">");
}
for (AccessCondition accessCondition : accessConditions) {
validateAccessCondition(accessCondition);
}
}
/**
* check the validation of bitstream node, the bitstream mode
* must be provided with value 'add' or 'replace'
* if mode equals to add so the information of accessConditions
* must be provided,
* also checking that constraint information is valid,
* also checking that accessConditions information are valid.
*
* @param bitstream the bitstream node
* @throws SQLException if something goes wrong in the database
* @throws BulkAccessControlException if bitstream node is invalid
*/
private void validateBitstreamNode(AccessConditionBitstream bitstream) throws SQLException {
String mode = bitstream.getMode();
List<AccessCondition> accessConditions = bitstream.getAccessConditions();
if (StringUtils.isEmpty(mode)) {
handler.logError("bitstream mode node must be provided");
throw new BulkAccessControlException("bitstream mode node must be provided");
} else if (!(StringUtils.equalsAny(mode, ADD_MODE, REPLACE_MODE))) {
handler.logError("wrong value for bitstream mode<" + mode + ">");
throw new BulkAccessControlException("wrong value for bitstream mode<" + mode + ">");
} else if (ADD_MODE.equals(mode) && isEmpty(accessConditions)) {
handler.logError("accessConditions of bitstream must be provided with mode<" + ADD_MODE + ">");
throw new BulkAccessControlException(
"accessConditions of bitstream must be provided with mode<" + ADD_MODE + ">");
}
validateConstraint(bitstream);
for (AccessCondition accessCondition : bitstream.getAccessConditions()) {
validateAccessCondition(accessCondition);
}
}
/**
* check the validation of constraint node if provided,
* constraint isn't supported when multiple uuids are provided
* or when uuid isn't an Item
*
* @param bitstream the bitstream node
* @throws SQLException if something goes wrong in the database
* @throws BulkAccessControlException if constraint node is invalid
*/
private void validateConstraint(AccessConditionBitstream bitstream) throws SQLException {
if (uuids.size() > 1 && containsConstraints(bitstream)) {
handler.logError("constraint isn't supported when multiple uuids are provided");
throw new BulkAccessControlException("constraint isn't supported when multiple uuids are provided");
} else if (uuids.size() == 1 && containsConstraints(bitstream)) {
DSpaceObject dso =
dSpaceObjectUtils.findDSpaceObject(context, UUID.fromString(uuids.get(0)));
if (Objects.nonNull(dso) && dso.getType() != Constants.ITEM) {
handler.logError("constraint is not supported when uuid isn't an Item");
throw new BulkAccessControlException("constraint is not supported when uuid isn't an Item");
}
}
}
/**
* check the validation of access condition,
* the access condition name must equal to one of configured access conditions,
* then call {@link AccessConditionOption#validateResourcePolicy(
* Context, String, Date, Date)} if exception happens so, it's invalid.
*
* @param accessCondition the accessCondition
* @throws BulkAccessControlException if the accessCondition is invalid
*/
private void validateAccessCondition(AccessCondition accessCondition) {
if (!itemAccessConditions.containsKey(accessCondition.getName())) {
handler.logError("wrong access condition <" + accessCondition.getName() + ">");
throw new BulkAccessControlException("wrong access condition <" + accessCondition.getName() + ">");
}
try {
itemAccessConditions.get(accessCondition.getName()).validateResourcePolicy(
context, accessCondition.getName(), accessCondition.getStartDate(), accessCondition.getEndDate());
} catch (Exception e) {
handler.logError("invalid access condition, " + e.getMessage());
handler.handleException(e);
}
}
/**
* find all items of provided {@link #uuids} from solr,
* then update the resource policies of items
* or bitstreams of items (only bitstreams of ORIGINAL bundles)
* and derivative bitstreams, or both of them.
*
* @param accessControl the access control input
* @throws SQLException if something goes wrong in the database
* @throws SearchServiceException if a search error occurs
* @throws AuthorizeException if an authorization error occurs
*/
private void updateItemsAndBitstreamsPolices(BulkAccessControlInput accessControl)
throws SQLException, SearchServiceException, AuthorizeException {
int counter = 0;
int start = 0;
int limit = 20;
String query = buildSolrQuery(uuids);
Iterator<Item> itemIterator = findItems(query, start, limit);
while (itemIterator.hasNext()) {
Item item = context.reloadEntity(itemIterator.next());
if (Objects.nonNull(accessControl.getItem())) {
updateItemPolicies(item, accessControl);
}
if (Objects.nonNull(accessControl.getBitstream())) {
updateBitstreamsPolicies(item, accessControl);
}
context.commit();
context.uncacheEntity(item);
counter++;
if (counter == limit) {
counter = 0;
start += limit;
itemIterator = findItems(query, start, limit);
}
}
}
private String buildSolrQuery(List<String> uuids) throws SQLException {
String [] query = new String[uuids.size()];
for (int i = 0 ; i < query.length ; i++) {
DSpaceObject dso = dSpaceObjectUtils.findDSpaceObject(context, UUID.fromString(uuids.get(i)));
if (dso.getType() == Constants.COMMUNITY) {
query[i] = "location.comm:" + dso.getID();
} else if (dso.getType() == Constants.COLLECTION) {
query[i] = "location.coll:" + dso.getID();
} else if (dso.getType() == Constants.ITEM) {
query[i] = "search.resourceid:" + dso.getID();
}
}
return StringUtils.joinWith(" OR ", query);
}
private Iterator<Item> findItems(String query, int start, int limit)
throws SearchServiceException {
DiscoverQuery discoverQuery = buildDiscoveryQuery(query, start, limit);
return searchService.search(context, discoverQuery)
.getIndexableObjects()
.stream()
.map(indexableObject ->
((IndexableItem) indexableObject).getIndexedObject())
.collect(Collectors.toList())
.iterator();
}
private DiscoverQuery buildDiscoveryQuery(String query, int start, int limit) {
DiscoverQuery discoverQuery = new DiscoverQuery();
discoverQuery.setDSpaceObjectFilter(IndexableItem.TYPE);
discoverQuery.setQuery(query);
discoverQuery.setStart(start);
discoverQuery.setMaxResults(limit);
discoverQuery.setSortField("search.resourceid", DiscoverQuery.SORT_ORDER.asc);
return discoverQuery;
}
/**
* update the item resource policies,
* when mode equals to 'replace' will remove
* all current resource polices of types 'TYPE_CUSTOM'
* and 'TYPE_INHERITED' then, set the new resource policies.
*
* @param item the item
* @param accessControl the access control input
* @throws SQLException if something goes wrong in the database
* @throws AuthorizeException if an authorization error occurs
*/
private void updateItemPolicies(Item item, BulkAccessControlInput accessControl)
throws SQLException, AuthorizeException {
AccessConditionItem acItem = accessControl.getItem();
if (REPLACE_MODE.equals(acItem.getMode())) {
removeReadPolicies(item, TYPE_CUSTOM);
removeReadPolicies(item, TYPE_INHERITED);
}
setItemPolicies(item, accessControl);
logInfo(acItem.getAccessConditions(), acItem.getMode(), item);
}
/**
* create the new resource policies of item.
* then, call {@link ItemService#adjustItemPolicies(
* Context, Item, Collection)} to adjust item's default policies.
*
* @param item the item
* @param accessControl the access control input
* @throws SQLException if something goes wrong in the database
* @throws AuthorizeException if an authorization error occurs
*/
private void setItemPolicies(Item item, BulkAccessControlInput accessControl)
throws SQLException, AuthorizeException {
accessControl
.getItem()
.getAccessConditions()
.forEach(accessCondition -> createResourcePolicy(item, accessCondition,
itemAccessConditions.get(accessCondition.getName())));
itemService.adjustItemPolicies(context, item, item.getOwningCollection(), false);
}
/**
* update the resource policies of all item's bitstreams
* or bitstreams specified into constraint node,
* and derivative bitstreams.
*
* <strong>NOTE:</strong> only bitstreams of ORIGINAL bundles
*
* @param item the item contains bitstreams
* @param accessControl the access control input
*/
private void updateBitstreamsPolicies(Item item, BulkAccessControlInput accessControl) {
AccessConditionBitstream.Constraint constraints = accessControl.getBitstream().getConstraints();
// look over all the bundles and force initialization of bitstreams collection
// to avoid lazy initialization exception
long count = item.getBundles()
.stream()
.flatMap(bundle ->
bundle.getBitstreams().stream())
.count();
item.getBundles(CONTENT_BUNDLE_NAME).stream()
.flatMap(bundle -> bundle.getBitstreams().stream())
.filter(bitstream -> constraints == null ||
constraints.getUuid() == null ||
constraints.getUuid().size() == 0 ||
constraints.getUuid().contains(bitstream.getID().toString()))
.forEach(bitstream -> updateBitstreamPolicies(bitstream, item, accessControl));
}
/**
* check that the bitstream node is existed,
* and contains constraint node,
* and constraint contains uuids.
*
* @param bitstream the bitstream node
* @return true when uuids of constraint of bitstream is not empty,
* otherwise false
*/
private boolean containsConstraints(AccessConditionBitstream bitstream) {
return Objects.nonNull(bitstream) &&
Objects.nonNull(bitstream.getConstraints()) &&
isNotEmpty(bitstream.getConstraints().getUuid());
}
/**
* update the bitstream resource policies,
* when mode equals to replace will remove
* all current resource polices of types 'TYPE_CUSTOM'
* and 'TYPE_INHERITED' then, set the new resource policies.
*
* @param bitstream the bitstream
* @param item the item of bitstream
* @param accessControl the access control input
* @throws RuntimeException if something goes wrong in the database
* or an authorization error occurs
*/
private void updateBitstreamPolicies(Bitstream bitstream, Item item, BulkAccessControlInput accessControl) {
AccessConditionBitstream acBitstream = accessControl.getBitstream();
if (REPLACE_MODE.equals(acBitstream.getMode())) {
removeReadPolicies(bitstream, TYPE_CUSTOM);
removeReadPolicies(bitstream, TYPE_INHERITED);
}
try {
setBitstreamPolicies(bitstream, item, accessControl);
logInfo(acBitstream.getAccessConditions(), acBitstream.getMode(), bitstream);
} catch (SQLException | AuthorizeException e) {
throw new RuntimeException(e);
}
}
/**
* remove dspace object's read policies.
*
* @param dso the dspace object
* @param type resource policy type
* @throws BulkAccessControlException if something goes wrong
* in the database or an authorization error occurs
*/
private void removeReadPolicies(DSpaceObject dso, String type) {
try {
resourcePolicyService.removePolicies(context, dso, type, Constants.READ);
} catch (SQLException | AuthorizeException e) {
throw new BulkAccessControlException(e);
}
}
/**
* create the new resource policies of bitstream.
* then, call {@link ItemService#adjustItemPolicies(
* Context, Item, Collection)} to adjust bitstream's default policies.
* and also update the resource policies of its derivative bitstreams.
*
* @param bitstream the bitstream
* @param item the item of bitstream
* @param accessControl the access control input
* @throws SQLException if something goes wrong in the database
* @throws AuthorizeException if an authorization error occurs
*/
private void setBitstreamPolicies(Bitstream bitstream, Item item, BulkAccessControlInput accessControl)
throws SQLException, AuthorizeException {
accessControl.getBitstream()
.getAccessConditions()
.forEach(accessCondition -> createResourcePolicy(bitstream, accessCondition,
uploadAccessConditions.get(accessCondition.getName())));
itemService.adjustBitstreamPolicies(context, item, item.getOwningCollection(), bitstream);
mediaFilterService.updatePoliciesOfDerivativeBitstreams(context, item, bitstream);
}
/**
* create the resource policy from the information
* comes from the access condition.
*
* @param obj the dspace object
* @param accessCondition the access condition
* @param accessConditionOption the access condition option
* @throws BulkAccessControlException if an exception occurs
*/
private void createResourcePolicy(DSpaceObject obj, AccessCondition accessCondition,
AccessConditionOption accessConditionOption) {
String name = accessCondition.getName();
String description = accessCondition.getDescription();
Date startDate = accessCondition.getStartDate();
Date endDate = accessCondition.getEndDate();
try {
accessConditionOption.createResourcePolicy(context, obj, name, description, startDate, endDate);
} catch (Exception e) {
throw new BulkAccessControlException(e);
}
}
/**
* Set the eperson in the context
*
* @param context the context
* @throws SQLException if database error
*/
protected void setEPerson(Context context) throws SQLException {
EPerson myEPerson = epersonService.find(context, this.getEpersonIdentifier());
if (myEPerson == null) {
handler.logError("EPerson cannot be found: " + this.getEpersonIdentifier());
throw new UnsupportedOperationException("EPerson cannot be found: " + this.getEpersonIdentifier());
}
context.setCurrentUser(myEPerson);
}
private void logInfo(List<AccessCondition> accessConditions, String mode, DSpaceObject dso) {
String type = dso.getClass().getSimpleName();
if (REPLACE_MODE.equals(mode) && isEmpty(accessConditions)) {
handler.logInfo("Cleaning " + type + " {" + dso.getID() + "} policies");
handler.logInfo("Inheriting policies from owning Collection in " + type + " {" + dso.getID() + "}");
return;
}
StringBuilder message = new StringBuilder();
message.append(mode.equals(ADD_MODE) ? "Adding " : "Replacing ")
.append(type)
.append(" {")
.append(dso.getID())
.append("} policy")
.append(mode.equals(ADD_MODE) ? " with " : " to ")
.append("access conditions:");
AppendAccessConditionsInfo(message, accessConditions);
handler.logInfo(message.toString());
if (REPLACE_MODE.equals(mode) && isAppendModeEnabled()) {
handler.logInfo("Inheriting policies from owning Collection in " + type + " {" + dso.getID() + "}");
}
}
private void AppendAccessConditionsInfo(StringBuilder message, List<AccessCondition> accessConditions) {
DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");
message.append("{");
for (int i = 0; i < accessConditions.size(); i++) {
message.append(accessConditions.get(i).getName());
Optional.ofNullable(accessConditions.get(i).getStartDate())
.ifPresent(date -> message.append(", start_date=" + dateFormat.format(date)));
Optional.ofNullable(accessConditions.get(i).getEndDate())
.ifPresent(date -> message.append(", end_date=" + dateFormat.format(date)));
if (i != accessConditions.size() - 1) {
message.append(", ");
}
}
message.append("}");
}
private boolean isAppendModeEnabled() {
return configurationService.getBooleanProperty("core.authorization.installitem.inheritance-read.append-mode");
}
protected boolean isAuthorized(Context context) {
return true;
}
@Override
@SuppressWarnings("unchecked")
public BulkAccessControlScriptConfiguration<BulkAccessControl> getScriptConfiguration() {
return new DSpace().getServiceManager()
.getServiceByName("bulk-access-control", BulkAccessControlScriptConfiguration.class);
}
}

View File

@@ -0,0 +1,66 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol;
import java.sql.SQLException;
import java.util.Arrays;
import java.util.UUID;
import java.util.stream.Collectors;
import org.apache.commons.lang3.StringUtils;
import org.dspace.core.Context;
import org.dspace.eperson.EPerson;
import org.dspace.scripts.DSpaceCommandLineParameter;
/**
* Extension of {@link BulkAccessControl} for CLI.
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*
*/
public class BulkAccessControlCli extends BulkAccessControl {
@Override
protected void setEPerson(Context context) throws SQLException {
EPerson myEPerson;
eperson = commandLine.getOptionValue('e');
if (eperson == null) {
handler.logError("An eperson to do the the Bulk Access Control must be specified " +
"(run with -h flag for details)");
throw new UnsupportedOperationException("An eperson to do the Bulk Access Control must be specified");
}
if (StringUtils.contains(eperson, '@')) {
myEPerson = epersonService.findByEmail(context, eperson);
} else {
myEPerson = epersonService.find(context, UUID.fromString(eperson));
}
if (myEPerson == null) {
handler.logError("EPerson cannot be found: " + eperson + " (run with -h flag for details)");
throw new UnsupportedOperationException("EPerson cannot be found: " + eperson);
}
context.setCurrentUser(myEPerson);
}
@Override
protected boolean isAuthorized(Context context) {
if (context.getCurrentUser() == null) {
return false;
}
return getScriptConfiguration().isAllowedToExecute(context,
Arrays.stream(commandLine.getOptions())
.map(option ->
new DSpaceCommandLineParameter("-" + option.getOpt(), option.getValue()))
.collect(Collectors.toList()));
}
}

View File

@@ -0,0 +1,42 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol;
import java.io.InputStream;
import org.apache.commons.cli.Options;
/**
* Extension of {@link BulkAccessControlScriptConfiguration} for CLI.
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*
*/
public class BulkAccessControlCliScriptConfiguration<T extends BulkAccessControlCli>
extends BulkAccessControlScriptConfiguration<T> {
@Override
public Options getOptions() {
Options options = new Options();
options.addOption("u", "uuid", true, "target uuids of communities/collections/items");
options.getOption("u").setType(String.class);
options.getOption("u").setRequired(true);
options.addOption("f", "file", true, "source json file");
options.getOption("f").setType(InputStream.class);
options.getOption("f").setRequired(true);
options.addOption("e", "eperson", true, "email of EPerson used to perform actions");
options.getOption("e").setRequired(true);
options.addOption("h", "help", false, "help");
return options;
}
}

View File

@@ -0,0 +1,110 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol;
import java.io.InputStream;
import java.sql.SQLException;
import java.util.List;
import java.util.Objects;
import java.util.UUID;
import java.util.stream.Collectors;
import org.apache.commons.cli.Options;
import org.dspace.app.util.DSpaceObjectUtilsImpl;
import org.dspace.app.util.service.DSpaceObjectUtils;
import org.dspace.content.DSpaceObject;
import org.dspace.core.Context;
import org.dspace.scripts.DSpaceCommandLineParameter;
import org.dspace.scripts.configuration.ScriptConfiguration;
import org.dspace.utils.DSpace;
/**
* Script configuration for {@link BulkAccessControl}.
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*
* @param <T> the {@link BulkAccessControl} type
*/
public class BulkAccessControlScriptConfiguration<T extends BulkAccessControl> extends ScriptConfiguration<T> {
private Class<T> dspaceRunnableClass;
@Override
public boolean isAllowedToExecute(Context context, List<DSpaceCommandLineParameter> commandLineParameters) {
try {
if (Objects.isNull(commandLineParameters)) {
return authorizeService.isAdmin(context) || authorizeService.isComColAdmin(context)
|| authorizeService.isItemAdmin(context);
} else {
List<String> dspaceObjectIDs =
commandLineParameters.stream()
.filter(parameter -> "-u".equals(parameter.getName()))
.map(DSpaceCommandLineParameter::getValue)
.collect(Collectors.toList());
DSpaceObjectUtils dSpaceObjectUtils = new DSpace().getServiceManager().getServiceByName(
DSpaceObjectUtilsImpl.class.getName(), DSpaceObjectUtilsImpl.class);
for (String dspaceObjectID : dspaceObjectIDs) {
DSpaceObject dso = dSpaceObjectUtils.findDSpaceObject(context, UUID.fromString(dspaceObjectID));
if (Objects.isNull(dso)) {
throw new IllegalArgumentException();
}
if (!authorizeService.isAdmin(context, dso)) {
return false;
}
}
}
} catch (SQLException e) {
throw new RuntimeException(e);
}
return true;
}
@Override
public Options getOptions() {
if (options == null) {
Options options = new Options();
options.addOption("u", "uuid", true, "target uuids of communities/collections/items");
options.getOption("u").setType(String.class);
options.getOption("u").setRequired(true);
options.addOption("f", "file", true, "source json file");
options.getOption("f").setType(InputStream.class);
options.getOption("f").setRequired(true);
options.addOption("h", "help", false, "help");
super.options = options;
}
return options;
}
@Override
public Class<T> getDspaceRunnableClass() {
return dspaceRunnableClass;
}
/**
* Generic setter for the dspaceRunnableClass
*
* @param dspaceRunnableClass The dspaceRunnableClass to be set on this
* BulkImportScriptConfiguration
*/
@Override
public void setDspaceRunnableClass(Class<T> dspaceRunnableClass) {
this.dspaceRunnableClass = dspaceRunnableClass;
}
}

View File

@@ -0,0 +1,48 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol.exception;
/**
* Exception for errors that occurs during the bulk access control
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*
*/
public class BulkAccessControlException extends RuntimeException {
private static final long serialVersionUID = -74730626862418515L;
/**
* Constructor with error message and cause.
*
* @param message the error message
* @param cause the error cause
*/
public BulkAccessControlException(String message, Throwable cause) {
super(message, cause);
}
/**
* Constructor with error message.
*
* @param message the error message
*/
public BulkAccessControlException(String message) {
super(message);
}
/**
* Constructor with error cause.
*
* @param cause the error cause
*/
public BulkAccessControlException(Throwable cause) {
super(cause);
}
}

View File

@@ -0,0 +1,59 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol.model;
import java.util.Date;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import org.dspace.app.bulkaccesscontrol.BulkAccessControl;
import org.dspace.util.MultiFormatDateDeserializer;
/**
* Class that model the values of an Access Condition as expressed in the {@link BulkAccessControl} input file
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*/
public class AccessCondition {
private String name;
private String description;
@JsonDeserialize(using = MultiFormatDateDeserializer.class)
private Date startDate;
@JsonDeserialize(using = MultiFormatDateDeserializer.class)
private Date endDate;
public AccessCondition() {
}
public AccessCondition(String name, String description, Date startDate, Date endDate) {
this.name = name;
this.description = description;
this.startDate = startDate;
this.endDate = endDate;
}
public String getName() {
return name;
}
public String getDescription() {
return description;
}
public Date getStartDate() {
return startDate;
}
public Date getEndDate() {
return endDate;
}
}

View File

@@ -0,0 +1,69 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol.model;
import java.util.ArrayList;
import java.util.List;
import org.dspace.app.bulkaccesscontrol.BulkAccessControl;
/**
* Class that model the value of bitstream node
* from json file of the {@link BulkAccessControl}
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*/
public class AccessConditionBitstream {
private String mode;
private Constraint constraints;
private List<AccessCondition> accessConditions;
public String getMode() {
return mode;
}
public void setMode(String mode) {
this.mode = mode;
}
public Constraint getConstraints() {
return constraints;
}
public void setConstraints(Constraint constraints) {
this.constraints = constraints;
}
public List<AccessCondition> getAccessConditions() {
if (accessConditions == null) {
return new ArrayList<>();
}
return accessConditions;
}
public void setAccessConditions(List<AccessCondition> accessConditions) {
this.accessConditions = accessConditions;
}
public class Constraint {
private List<String> uuid;
public List<String> getUuid() {
return uuid;
}
public void setUuid(List<String> uuid) {
this.uuid = uuid;
}
}
}

View File

@@ -0,0 +1,45 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol.model;
import java.util.ArrayList;
import java.util.List;
import org.dspace.app.bulkaccesscontrol.BulkAccessControl;
/**
* Class that model the value of item node
* from json file of the {@link BulkAccessControl}
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*/
public class AccessConditionItem {
String mode;
List<AccessCondition> accessConditions;
public String getMode() {
return mode;
}
public void setMode(String mode) {
this.mode = mode;
}
public List<AccessCondition> getAccessConditions() {
if (accessConditions == null) {
return new ArrayList<>();
}
return accessConditions;
}
public void setAccessConditions(List<AccessCondition> accessConditions) {
this.accessConditions = accessConditions;
}
}

View File

@@ -0,0 +1,50 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol.model;
import java.util.List;
import org.dspace.submit.model.AccessConditionOption;
/**
* A collection of conditions to be met when bulk access condition.
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*/
public class BulkAccessConditionConfiguration {
private String name;
private List<AccessConditionOption> itemAccessConditionOptions;
private List<AccessConditionOption> bitstreamAccessConditionOptions;
public String getName() {
return name;
}
public void setName(String name) {
this.name = name;
}
public List<AccessConditionOption> getItemAccessConditionOptions() {
return itemAccessConditionOptions;
}
public void setItemAccessConditionOptions(
List<AccessConditionOption> itemAccessConditionOptions) {
this.itemAccessConditionOptions = itemAccessConditionOptions;
}
public List<AccessConditionOption> getBitstreamAccessConditionOptions() {
return bitstreamAccessConditionOptions;
}
public void setBitstreamAccessConditionOptions(
List<AccessConditionOption> bitstreamAccessConditionOptions) {
this.bitstreamAccessConditionOptions = bitstreamAccessConditionOptions;
}
}

View File

@@ -0,0 +1,72 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol.model;
import org.dspace.app.bulkaccesscontrol.BulkAccessControl;
/**
* Class that model the content of the JSON file used as input for the {@link BulkAccessControl}
*
* <code> <br/>
* { <br/>
* item: { <br/>
* mode: "replace", <br/>
* accessConditions: [ <br/>
* { <br/>
* "name": "openaccess" <br/>
* } <br/>
* ] <br/>
* }, <br/>
* bitstream: { <br/>
* constraints: { <br/>
* uuid: [bit-uuid1, bit-uuid2, ..., bit-uuidN], <br/>
* }, <br/>
* mode: "add", <br/>
* accessConditions: [ <br/>
* { <br/>
* "name": "embargo", <br/>
* "startDate": "2024-06-24T23:59:59.999+0000" <br/>
* } <br/>
* ] <br/>
* } <br/>
* }
* </code>
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*/
public class BulkAccessControlInput {
AccessConditionItem item;
AccessConditionBitstream bitstream;
public BulkAccessControlInput() {
}
public BulkAccessControlInput(AccessConditionItem item,
AccessConditionBitstream bitstream) {
this.item = item;
this.bitstream = bitstream;
}
public AccessConditionItem getItem() {
return item;
}
public void setItem(AccessConditionItem item) {
this.item = item;
}
public AccessConditionBitstream getBitstream() {
return bitstream;
}
public void setBitstream(AccessConditionBitstream bitstream) {
this.bitstream = bitstream;
}
}

View File

@@ -0,0 +1,45 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkaccesscontrol.service;
import java.util.ArrayList;
import java.util.List;
import org.apache.commons.collections4.CollectionUtils;
import org.dspace.app.bulkaccesscontrol.model.BulkAccessConditionConfiguration;
import org.springframework.beans.factory.annotation.Autowired;
/**
* Simple bean to manage different Bulk Access Condition configurations
*
* @author Mohamed Eskander (mohamed.eskander at 4science.it)
*/
public class BulkAccessConditionConfigurationService {
@Autowired
private List<BulkAccessConditionConfiguration> bulkAccessConditionConfigurations;
public List<BulkAccessConditionConfiguration> getBulkAccessConditionConfigurations() {
if (CollectionUtils.isEmpty(bulkAccessConditionConfigurations)) {
return new ArrayList<>();
}
return bulkAccessConditionConfigurations;
}
public BulkAccessConditionConfiguration getBulkAccessConditionConfiguration(String name) {
return getBulkAccessConditionConfigurations().stream()
.filter(x -> name.equals(x.getName()))
.findFirst()
.orElse(null);
}
public void setBulkAccessConditionConfigurations(
List<BulkAccessConditionConfiguration> bulkAccessConditionConfigurations) {
this.bulkAccessConditionConfigurations = bulkAccessConditionConfigurations;
}
}

View File

@@ -19,6 +19,7 @@ import org.dspace.content.Item;
* @author Stuart Lewis
*/
public class BulkEditChange {
/**
* The item these changes relate to
*/

View File

@@ -8,14 +8,10 @@
package org.dspace.app.bulkedit;
import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.io.Serializable;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
@@ -27,6 +23,8 @@ import java.util.UUID;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.apache.commons.io.IOUtils;
import org.apache.commons.lang3.StringUtils;
import org.dspace.authority.AuthorityValue;
import org.dspace.authority.factory.AuthorityServiceFactory;
import org.dspace.authority.service.AuthorityValueService;
@@ -34,6 +32,7 @@ import org.dspace.content.Collection;
import org.dspace.content.Item;
import org.dspace.content.MetadataField;
import org.dspace.content.MetadataSchema;
import org.dspace.content.MetadataSchemaEnum;
import org.dspace.content.MetadataValue;
import org.dspace.content.authority.Choices;
import org.dspace.content.factory.ContentServiceFactory;
@@ -139,18 +138,18 @@ public class DSpaceCSV implements Serializable {
/**
* Create a new instance, reading the lines in from file
*
* @param f The file to read from
* @param inputStream the input stream to read from
* @param c The DSpace Context
* @throws Exception thrown if there is an error reading or processing the file
*/
public DSpaceCSV(File f, Context c) throws Exception {
public DSpaceCSV(InputStream inputStream, Context c) throws Exception {
// Initialise the class
init();
// Open the CSV file
BufferedReader input = null;
try {
input = new BufferedReader(new InputStreamReader(new FileInputStream(f), "UTF-8"));
input = new BufferedReader(new InputStreamReader(inputStream, StandardCharsets.UTF_8));
// Read the heading line
String head = input.readLine();
@@ -160,7 +159,7 @@ public class DSpaceCSV implements Serializable {
columnCounter++;
// Remove surrounding quotes if there are any
if ((element.startsWith("\"")) && (element.endsWith("\""))) {
if (element.startsWith("\"") && element.endsWith("\"")) {
element = element.substring(1, element.length() - 1);
}
@@ -168,21 +167,36 @@ public class DSpaceCSV implements Serializable {
if ("collection".equals(element)) {
// Store the heading
headings.add(element);
} else if ("rowName".equals(element)) {
// Store the heading
headings.add(element);
} else if ("action".equals(element)) { // Store the action
// Store the heading
headings.add(element);
} else if (!"id".equals(element)) {
String authorityPrefix = "";
AuthorityValue authorityValueType = authorityValueService.getAuthorityValueType(element);
if (authorityValueType != null) {
String authorityType = authorityValueType.getAuthorityType();
authorityPrefix = element.substring(0, authorityType.length() + 1);
element = element.substring(authorityPrefix.length());
if (StringUtils.startsWith(element, "[authority]")) {
element = StringUtils.substringAfter(element, "[authority]");
AuthorityValue authorityValueType = authorityValueService.getAuthorityValueType(element);
if (authorityValueType != null) {
String authorityType = authorityValueType.getAuthorityType();
authorityPrefix = element.substring(0, authorityType.length() + 1);
element = element.substring(authorityPrefix.length());
}
}
// Verify that the heading is valid in the metadata registry
String[] clean = element.split("\\[");
String[] parts = clean[0].split("\\.");
// Check language if present, if it's ANY then throw an exception
if (clean.length > 1 && clean[1].equals(Item.ANY + "]")) {
throw new MetadataImportInvalidHeadingException("Language ANY (*) was found in the heading " +
"of the metadata value to import, " +
"this should never be the case",
MetadataImportInvalidHeadingException.ENTRY,
columnCounter);
}
if (parts.length < 2) {
throw new MetadataImportInvalidHeadingException(element,
@@ -198,19 +212,32 @@ public class DSpaceCSV implements Serializable {
}
// Check that the scheme exists
MetadataSchema foundSchema = metadataSchemaService.find(c, metadataSchema);
if (foundSchema == null) {
throw new MetadataImportInvalidHeadingException(clean[0],
MetadataImportInvalidHeadingException.SCHEMA,
columnCounter);
if (!StringUtils.equals(metadataSchema, MetadataSchemaEnum.RELATION.getName())) {
MetadataSchema foundSchema = metadataSchemaService.find(c, metadataSchema);
if (foundSchema == null) {
throw new MetadataImportInvalidHeadingException(clean[0],
MetadataImportInvalidHeadingException
.SCHEMA,
columnCounter);
}
// Check that the metadata element exists in the schema
MetadataField foundField = metadataFieldService
.findByElement(c, foundSchema, metadataElement, metadataQualifier);
if (foundField == null) {
throw new MetadataImportInvalidHeadingException(clean[0],
MetadataImportInvalidHeadingException
.ELEMENT,
columnCounter);
}
}
// Check that the metadata element exists in the schema
MetadataField foundField = metadataFieldService
.findByElement(c, foundSchema, metadataElement, metadataQualifier);
if (foundField == null) {
throw new MetadataImportInvalidHeadingException(clean[0],
MetadataImportInvalidHeadingException.ELEMENT,
// Verify there isnt already a header that is the same; if it already exists,
// throw MetadataImportInvalidHeadingException
String header = authorityPrefix + element;
if (headings.contains(header)) {
throw new MetadataImportInvalidHeadingException("Duplicate heading found: " + header,
MetadataImportInvalidHeadingException.ENTRY,
columnCounter);
}
@@ -297,7 +324,7 @@ public class DSpaceCSV implements Serializable {
// Specify default values
String[] defaultValues =
new String[] {
"dc.date.accessioned, dc.date.available, dc.date.updated, dc.description.provenance"
"dc.date.accessioned", "dc.date.available", "dc.date.updated", "dc.description.provenance"
};
String[] toIgnoreArray =
DSpaceServicesFactory.getInstance()
@@ -328,15 +355,15 @@ public class DSpaceCSV implements Serializable {
/**
* Set the value separator for multiple values stored in one csv value.
*
* Is set in bulkedit.cfg as valueseparator
* Is set in {@code bulkedit.cfg} as {@code valueseparator}.
*
* If not set, defaults to double pipe '||'
* If not set, defaults to double pipe '||'.
*/
private void setValueSeparator() {
// Get the value separator
valueSeparator = DSpaceServicesFactory.getInstance().getConfigurationService()
.getProperty("bulkedit.valueseparator");
if ((valueSeparator != null) && (!"".equals(valueSeparator.trim()))) {
if ((valueSeparator != null) && !valueSeparator.trim().isEmpty()) {
valueSeparator = valueSeparator.trim();
} else {
valueSeparator = "||";
@@ -351,7 +378,7 @@ public class DSpaceCSV implements Serializable {
/**
* Set the field separator use to separate fields in the csv.
*
* Is set in bulkedit.cfg as fieldseparator
* Is set in {@code bulkedit.cfg} as {@code fieldseparator}.
*
* If not set, defaults to comma ','.
*
@@ -362,7 +389,7 @@ public class DSpaceCSV implements Serializable {
// Get the value separator
fieldSeparator = DSpaceServicesFactory.getInstance().getConfigurationService()
.getProperty("bulkedit.fieldseparator");
if ((fieldSeparator != null) && (!"".equals(fieldSeparator.trim()))) {
if ((fieldSeparator != null) && !fieldSeparator.trim().isEmpty()) {
fieldSeparator = fieldSeparator.trim();
if ("tab".equals(fieldSeparator)) {
fieldSeparator = "\t";
@@ -386,15 +413,15 @@ public class DSpaceCSV implements Serializable {
/**
* Set the authority separator for value with authority data.
*
* Is set in dspace.cfg as bulkedit.authorityseparator
* Is set in {@code dspace.cfg} as {@code bulkedit.authorityseparator}.
*
* If not set, defaults to double colon '::'
* If not set, defaults to double colon '::'.
*/
private void setAuthoritySeparator() {
// Get the value separator
authoritySeparator = DSpaceServicesFactory.getInstance().getConfigurationService()
.getProperty("bulkedit.authorityseparator");
if ((authoritySeparator != null) && (!"".equals(authoritySeparator.trim()))) {
if ((authoritySeparator != null) && !authoritySeparator.trim().isEmpty()) {
authoritySeparator = authoritySeparator.trim();
} else {
authoritySeparator = "::";
@@ -499,7 +526,7 @@ public class DSpaceCSV implements Serializable {
int i = 0;
for (String part : bits) {
int bitcounter = part.length() - part.replaceAll("\"", "").length();
if ((part.startsWith("\"")) && ((!part.endsWith("\"")) || ((bitcounter & 1) == 1))) {
if (part.startsWith("\"") && (!part.endsWith("\"") || ((bitcounter & 1) == 1))) {
found = true;
String add = bits.get(i) + fieldSeparator + bits.get(i + 1);
bits.remove(i);
@@ -515,7 +542,7 @@ public class DSpaceCSV implements Serializable {
// Deal with quotes around the elements
int i = 0;
for (String part : bits) {
if ((part.startsWith("\"")) && (part.endsWith("\""))) {
if (part.startsWith("\"") && part.endsWith("\"")) {
part = part.substring(1, part.length() - 1);
bits.set(i, part);
}
@@ -555,7 +582,7 @@ public class DSpaceCSV implements Serializable {
for (String part : bits) {
if (i > 0) {
// Is this a last empty item?
if ((last) && (i == headings.size())) {
if (last && (i == headings.size())) {
part = "";
}
@@ -568,7 +595,7 @@ public class DSpaceCSV implements Serializable {
csvLine.add(headings.get(i - 1), null);
String[] elements = part.split(escapedValueSeparator);
for (String element : elements) {
if ((element != null) && (!"".equals(element))) {
if ((element != null) && !element.isEmpty()) {
csvLine.add(headings.get(i - 1), element);
}
}
@@ -614,30 +641,24 @@ public class DSpaceCSV implements Serializable {
}
/**
* Save the CSV file to the given filename
*
* @param filename The filename to save the CSV file to
* @throws IOException Thrown if an error occurs when writing the file
* Creates and returns an InputStream from the CSV Lines in this DSpaceCSV
* @return The InputStream created from the CSVLines in this DSpaceCSV
*/
public final void save(String filename) throws IOException {
// Save the file
BufferedWriter out = new BufferedWriter(
new OutputStreamWriter(
new FileOutputStream(filename), "UTF-8"));
public InputStream getInputStream() {
StringBuilder stringBuilder = new StringBuilder();
for (String csvLine : getCSVLinesAsStringArray()) {
out.write(csvLine + "\n");
stringBuilder.append(csvLine).append("\n");
}
out.flush();
out.close();
return IOUtils.toInputStream(stringBuilder.toString(), StandardCharsets.UTF_8);
}
/**
* Is it Ok to export this value? When exportAll is set to false, we don't export
* Is it okay to export this value? When exportAll is set to false, we don't export
* some of the metadata elements.
*
* The list can be configured via the key ignore-on-export in bulkedit.cfg
* The list can be configured via the key ignore-on-export in {@code bulkedit.cfg}.
*
* @param md The Metadatum to examine
* @param md The MetadataField to examine
* @return Whether or not it is OK to export this element
*/
protected boolean okToExport(MetadataField md) {
@@ -646,12 +667,8 @@ public class DSpaceCSV implements Serializable {
if (md.getQualifier() != null) {
key += "." + md.getQualifier();
}
if (ignore.get(key) != null) {
return false;
}
// Must be OK, so don't ignore
return true;
return ignore.get(key) == null;
}
/**

View File

@@ -0,0 +1,115 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import java.sql.SQLException;
import org.apache.commons.cli.ParseException;
import org.apache.commons.lang3.ArrayUtils;
import org.dspace.content.MetadataField;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.MetadataFieldService;
import org.dspace.content.service.MetadataValueService;
import org.dspace.core.Context;
import org.dspace.scripts.DSpaceRunnable;
import org.dspace.services.ConfigurationService;
import org.dspace.services.factory.DSpaceServicesFactory;
import org.dspace.utils.DSpace;
/**
* {@link DSpaceRunnable} implementation to delete all the values of the given
* metadata field.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class MetadataDeletion extends DSpaceRunnable<MetadataDeletionScriptConfiguration<MetadataDeletion>> {
private MetadataValueService metadataValueService;
private MetadataFieldService metadataFieldService;
private ConfigurationService configurationService;
private String metadataField;
private boolean list;
@Override
public void internalRun() throws Exception {
if (list) {
listErasableMetadata();
return;
}
Context context = new Context();
try {
context.turnOffAuthorisationSystem();
performMetadataValuesDeletion(context);
} finally {
context.restoreAuthSystemState();
context.complete();
}
}
private void listErasableMetadata() {
String[] erasableMetadata = getErasableMetadata();
if (ArrayUtils.isEmpty(erasableMetadata)) {
handler.logInfo("No fields has been configured to be cleared via bulk deletion");
} else {
handler.logInfo("The fields that can be bulk deleted are: " + String.join(", ", erasableMetadata));
}
}
private void performMetadataValuesDeletion(Context context) throws SQLException {
MetadataField field = metadataFieldService.findByString(context, metadataField, '.');
if (field == null) {
throw new IllegalArgumentException("No metadata field found with name " + metadataField);
}
if (!ArrayUtils.contains(getErasableMetadata(), metadataField)) {
throw new IllegalArgumentException("The given metadata field cannot be bulk deleted");
}
handler.logInfo(String.format("Deleting the field '%s' from all objects", metadataField));
metadataValueService.deleteByMetadataField(context, field);
}
private String[] getErasableMetadata() {
return configurationService.getArrayProperty("bulkedit.allow-bulk-deletion");
}
@Override
@SuppressWarnings("unchecked")
public MetadataDeletionScriptConfiguration<MetadataDeletion> getScriptConfiguration() {
return new DSpace().getServiceManager()
.getServiceByName("metadata-deletion", MetadataDeletionScriptConfiguration.class);
}
@Override
public void setup() throws ParseException {
metadataValueService = ContentServiceFactory.getInstance().getMetadataValueService();
metadataFieldService = ContentServiceFactory.getInstance().getMetadataFieldService();
configurationService = DSpaceServicesFactory.getInstance().getConfigurationService();
metadataField = commandLine.getOptionValue('m');
list = commandLine.hasOption('l');
if (!list && metadataField == null) {
throw new ParseException("One of the following parameters is required: -m or -l");
}
}
}

View File

@@ -0,0 +1,18 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
/**
* The {@link MetadataDeletion} for CLI.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class MetadataDeletionCli extends MetadataDeletion {
}

View File

@@ -0,0 +1,18 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
/**
* Script configuration for {@link MetadataDeletionCli}.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class MetadataDeletionCliScriptConfiguration extends MetadataDeletionScriptConfiguration<MetadataDeletionCli> {
}

View File

@@ -0,0 +1,49 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
/**
* The {@link ScriptConfiguration} for the {@link MetadataDeletion} script.
*/
public class MetadataDeletionScriptConfiguration<T extends MetadataDeletion> extends ScriptConfiguration<T> {
private Class<T> dspaceRunnableClass;
@Override
public Options getOptions() {
if (options == null) {
Options options = new Options();
options.addOption("m", "metadata", true, "metadata field name");
options.addOption("l", "list", false, "lists the metadata fields that can be deleted");
super.options = options;
}
return options;
}
@Override
public Class<T> getDspaceRunnableClass() {
return dspaceRunnableClass;
}
/**
* Generic setter for the dspaceRunnableClass
* @param dspaceRunnableClass The dspaceRunnableClass to be set on this MetadataDeletionScriptConfiguration
*/
@Override
public void setDspaceRunnableClass(Class<T> dspaceRunnableClass) {
this.dspaceRunnableClass = dspaceRunnableClass;
}
}

View File

@@ -8,271 +8,115 @@
package org.dspace.app.bulkedit;
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.UUID;
import com.google.common.collect.Iterators;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
import org.apache.commons.cli.PosixParser;
import org.dspace.content.Collection;
import org.dspace.content.Community;
import org.apache.commons.lang3.StringUtils;
import org.dspace.app.util.factory.UtilServiceFactory;
import org.dspace.app.util.service.DSpaceObjectUtils;
import org.dspace.content.DSpaceObject;
import org.dspace.content.Item;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.ItemService;
import org.dspace.core.Constants;
import org.dspace.content.service.MetadataDSpaceCsvExportService;
import org.dspace.core.Context;
import org.dspace.eperson.factory.EPersonServiceFactory;
import org.dspace.eperson.service.EPersonService;
import org.dspace.handle.factory.HandleServiceFactory;
import org.dspace.scripts.DSpaceRunnable;
import org.dspace.utils.DSpace;
/**
* Metadata exporter to allow the batch export of metadata into a file
*
* @author Stuart Lewis
*/
public class MetadataExport {
/**
* The items to export
*/
protected Iterator<Item> toExport;
public class MetadataExport extends DSpaceRunnable<MetadataExportScriptConfiguration> {
protected ItemService itemService;
private boolean help = false;
private String filename = null;
private String identifier = null;
private boolean exportAllMetadata = false;
private boolean exportAllItems = false;
protected Context context;
private static final String EXPORT_CSV = "exportCSV";
/**
* Whether to export all metadata, or just normally edited metadata
*/
protected boolean exportAll;
private MetadataDSpaceCsvExportService metadataDSpaceCsvExportService = new DSpace().getServiceManager()
.getServicesByType(MetadataDSpaceCsvExportService.class).get(0);
protected MetadataExport() {
itemService = ContentServiceFactory.getInstance().getItemService();
}
private EPersonService ePersonService = EPersonServiceFactory.getInstance().getEPersonService();
/**
* Set up a new metadata export
*
* @param c The Context
* @param toExport The ItemIterator of items to export
* @param exportAll whether to export all metadata or not (include handle, provenance etc)
*/
public MetadataExport(Context c, Iterator<Item> toExport, boolean exportAll) {
itemService = ContentServiceFactory.getInstance().getItemService();
private DSpaceObjectUtils dSpaceObjectUtils = UtilServiceFactory.getInstance().getDSpaceObjectUtils();
// Store the export settings
this.toExport = toExport;
this.exportAll = exportAll;
this.context = c;
}
/**
* Method to export a community (and sub-communities and collections)
*
* @param c The Context
* @param toExport The Community to export
* @param exportAll whether to export all metadata or not (include handle, provenance etc)
*/
public MetadataExport(Context c, Community toExport, boolean exportAll) {
itemService = ContentServiceFactory.getInstance().getItemService();
@Override
public void internalRun() throws Exception {
if (help) {
logHelpInfo();
printHelp();
return;
}
Context context = new Context();
context.turnOffAuthorisationSystem();
try {
// Try to export the community
this.toExport = buildFromCommunity(c, toExport, 0);
this.exportAll = exportAll;
this.context = c;
} catch (SQLException sqle) {
// Something went wrong...
System.err.println("Error running exporter:");
sqle.printStackTrace(System.err);
System.exit(1);
context.setCurrentUser(ePersonService.find(context, this.getEpersonIdentifier()));
} catch (SQLException e) {
handler.handleException(e);
}
DSpaceCSV dSpaceCSV = metadataDSpaceCsvExportService
.handleExport(context, exportAllItems, exportAllMetadata, identifier,
handler);
handler.writeFilestream(context, filename, dSpaceCSV.getInputStream(), EXPORT_CSV);
context.restoreAuthSystemState();
context.complete();
}
/**
* Build an array list of item ids that are in a community (include sub-communities and collections)
*
* @param context DSpace context
* @param community The community to build from
* @param indent How many spaces to use when writing out the names of items added
* @return The list of item ids
* @throws SQLException if database error
*/
protected Iterator<Item> buildFromCommunity(Context context, Community community, int indent)
throws SQLException {
// Add all the collections
List<Collection> collections = community.getCollections();
Iterator<Item> result = null;
for (Collection collection : collections) {
for (int i = 0; i < indent; i++) {
System.out.print(" ");
}
Iterator<Item> items = itemService.findByCollection(context, collection);
result = addItemsToResult(result, items);
}
// Add all the sub-communities
List<Community> communities = community.getSubcommunities();
for (Community subCommunity : communities) {
for (int i = 0; i < indent; i++) {
System.out.print(" ");
}
Iterator<Item> items = buildFromCommunity(context, subCommunity, indent + 1);
result = addItemsToResult(result, items);
}
return result;
protected void logHelpInfo() {
handler.logInfo("\nfull export: metadata-export");
handler.logInfo("partial export: metadata-export -i handle/UUID");
}
private Iterator<Item> addItemsToResult(Iterator<Item> result, Iterator<Item> items) {
if (result == null) {
result = items;
} else {
result = Iterators.concat(result, items);
}
return result;
@Override
public MetadataExportScriptConfiguration getScriptConfiguration() {
return new DSpace().getServiceManager().getServiceByName("metadata-export",
MetadataExportScriptConfiguration.class);
}
/**
* Run the export
*
* @return the exported CSV lines
*/
public DSpaceCSV export() {
@Override
public void setup() throws ParseException {
if (commandLine.hasOption('h')) {
help = true;
return;
}
if (!commandLine.hasOption('i')) {
exportAllItems = true;
}
identifier = commandLine.getOptionValue('i');
filename = getFileNameForExportFile();
exportAllMetadata = commandLine.hasOption('a');
}
protected String getFileNameForExportFile() throws ParseException {
Context context = new Context();
try {
Context.Mode originalMode = context.getCurrentMode();
context.setMode(Context.Mode.READ_ONLY);
// Process each item
DSpaceCSV csv = new DSpaceCSV(exportAll);
while (toExport.hasNext()) {
Item item = toExport.next();
csv.addItem(item);
context.uncacheEntity(item);
}
context.setMode(originalMode);
// Return the results
return csv;
} catch (Exception e) {
// Something went wrong...
System.err.println("Error exporting to CSV:");
e.printStackTrace();
return null;
}
}
/**
* Print the help message
*
* @param options The command line options the user gave
* @param exitCode the system exit code to use
*/
private static void printHelp(Options options, int exitCode) {
// print the help message
HelpFormatter myhelp = new HelpFormatter();
myhelp.printHelp("MetadataExport\n", options);
System.out.println("\nfull export: metadataexport -f filename");
System.out.println("partial export: metadataexport -i handle -f filename");
System.exit(exitCode);
}
/**
* main method to run the metadata exporter
*
* @param argv the command line arguments given
* @throws Exception if error occurs
*/
public static void main(String[] argv) throws Exception {
// Create an options object and populate it
CommandLineParser parser = new PosixParser();
Options options = new Options();
options.addOption("i", "id", true, "ID or handle of thing to export (item, collection, or community)");
options.addOption("f", "file", true, "destination where you want file written");
options.addOption("a", "all", false,
"include all metadata fields that are not normally changed (e.g. provenance)");
options.addOption("h", "help", false, "help");
CommandLine line = null;
try {
line = parser.parse(options, argv);
} catch (ParseException pe) {
System.err.println("Error with commands.");
printHelp(options, 1);
System.exit(0);
}
if (line.hasOption('h')) {
printHelp(options, 0);
}
// Check a filename is given
if (!line.hasOption('f')) {
System.err.println("Required parameter -f missing!");
printHelp(options, 1);
}
String filename = line.getOptionValue('f');
// Create a context
Context c = new Context(Context.Mode.READ_ONLY);
c.turnOffAuthorisationSystem();
// The things we'll export
Iterator<Item> toExport = null;
MetadataExport exporter = null;
// Export everything?
boolean exportAll = line.hasOption('a');
ContentServiceFactory contentServiceFactory = ContentServiceFactory.getInstance();
// Check we have an item OK
ItemService itemService = contentServiceFactory.getItemService();
if (!line.hasOption('i')) {
System.out.println("Exporting whole repository WARNING: May take some time!");
exporter = new MetadataExport(c, itemService.findAll(c), exportAll);
} else {
String handle = line.getOptionValue('i');
DSpaceObject dso = HandleServiceFactory.getInstance().getHandleService().resolveToObject(c, handle);
if (dso == null) {
System.err.println("Item '" + handle + "' does not resolve to an item in your repository!");
printHelp(options, 1);
}
if (dso.getType() == Constants.ITEM) {
System.out.println("Exporting item '" + dso.getName() + "' (" + handle + ")");
List<Item> item = new ArrayList<>();
item.add((Item) dso);
exporter = new MetadataExport(c, item.iterator(), exportAll);
} else if (dso.getType() == Constants.COLLECTION) {
System.out.println("Exporting collection '" + dso.getName() + "' (" + handle + ")");
Collection collection = (Collection) dso;
toExport = itemService.findByCollection(c, collection);
exporter = new MetadataExport(c, toExport, exportAll);
} else if (dso.getType() == Constants.COMMUNITY) {
System.out.println("Exporting community '" + dso.getName() + "' (" + handle + ")");
exporter = new MetadataExport(c, (Community) dso, exportAll);
DSpaceObject dso = null;
if (StringUtils.isNotBlank(identifier)) {
dso = HandleServiceFactory.getInstance().getHandleService().resolveToObject(context, identifier);
if (dso == null) {
dso = dSpaceObjectUtils.findDSpaceObject(context, UUID.fromString(identifier));
}
} else {
System.err.println("Error identifying '" + handle + "'");
System.exit(1);
dso = ContentServiceFactory.getInstance().getSiteService().findSite(context);
}
if (dso == null) {
throw new ParseException("An identifier was given that wasn't able to be parsed to a DSpaceObject");
}
return dso.getID().toString() + ".csv";
} catch (SQLException e) {
handler.handleException("Something went wrong trying to retrieve DSO for identifier: " + identifier, e);
}
// Perform the export
DSpaceCSV csv = exporter.export();
// Save the files to the file
csv.save(filename);
// Finish off and tidy up
c.restoreAuthSystemState();
c.complete();
return null;
}
}

View File

@@ -0,0 +1,33 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import org.apache.commons.cli.ParseException;
public class MetadataExportCli extends MetadataExport {
@Override
protected String getFileNameForExportFile() {
return commandLine.getOptionValue('f');
}
@Override
public void setup() throws ParseException {
super.setup();
// Check a filename is given
if (!commandLine.hasOption('f')) {
throw new ParseException("Required parameter -f missing!");
}
}
@Override
protected void logHelpInfo() {
handler.logInfo("\nfull export: metadata-export -f filename");
handler.logInfo("partial export: metadata-export -i handle -f filename");
}
}

View File

@@ -0,0 +1,26 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import java.io.OutputStream;
import org.apache.commons.cli.Options;
public class MetadataExportCliScriptConfiguration extends MetadataExportScriptConfiguration<MetadataExportCli> {
@Override
public Options getOptions() {
Options options = super.getOptions();
options.addOption("f", "file", true, "destination where you want file written");
options.getOption("f").setType(OutputStream .class);
options.getOption("f").setRequired(true);
super.options = options;
return options;
}
}

View File

@@ -0,0 +1,50 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
/**
* The {@link ScriptConfiguration} for the {@link MetadataExport} script
*/
public class MetadataExportScriptConfiguration<T extends MetadataExport> extends ScriptConfiguration<T> {
private Class<T> dspaceRunnableClass;
@Override
public Class<T> getDspaceRunnableClass() {
return dspaceRunnableClass;
}
/**
* Generic setter for the dspaceRunnableClass
* @param dspaceRunnableClass The dspaceRunnableClass to be set on this MetadataExportScriptConfiguration
*/
@Override
public void setDspaceRunnableClass(Class<T> dspaceRunnableClass) {
this.dspaceRunnableClass = dspaceRunnableClass;
}
@Override
public Options getOptions() {
if (options == null) {
Options options = new Options();
options.addOption("i", "id", true, "ID or handle of thing to export (item, collection, or community)");
options.addOption("a", "all", false,
"include all metadata fields that are not normally changed (e.g. provenance)");
options.addOption("h", "help", false, "help");
super.options = options;
}
return options;
}
}

View File

@@ -0,0 +1,182 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.UUID;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.DefaultParser.Builder;
import org.apache.commons.cli.ParseException;
import org.dspace.content.Item;
import org.dspace.content.MetadataDSpaceCsvExportServiceImpl;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.CollectionService;
import org.dspace.content.service.CommunityService;
import org.dspace.content.service.MetadataDSpaceCsvExportService;
import org.dspace.core.Context;
import org.dspace.discovery.DiscoverQuery;
import org.dspace.discovery.IndexableObject;
import org.dspace.discovery.SearchService;
import org.dspace.discovery.SearchUtils;
import org.dspace.discovery.configuration.DiscoveryConfiguration;
import org.dspace.discovery.configuration.DiscoveryConfigurationService;
import org.dspace.discovery.indexobject.IndexableCollection;
import org.dspace.discovery.indexobject.IndexableCommunity;
import org.dspace.discovery.utils.DiscoverQueryBuilder;
import org.dspace.discovery.utils.parameter.QueryBuilderSearchFilter;
import org.dspace.eperson.factory.EPersonServiceFactory;
import org.dspace.eperson.service.EPersonService;
import org.dspace.scripts.DSpaceRunnable;
import org.dspace.sort.SortOption;
import org.dspace.utils.DSpace;
/**
* Metadata exporter to allow the batch export of metadata from a discovery search into a file
*
*/
public class MetadataExportSearch extends DSpaceRunnable<MetadataExportSearchScriptConfiguration> {
private static final String EXPORT_CSV = "exportCSV";
private boolean help = false;
private String identifier;
private String discoveryConfigName;
private String[] filterQueryStrings;
private boolean hasScope = false;
private String query;
private SearchService searchService;
private MetadataDSpaceCsvExportService metadataDSpaceCsvExportService;
private EPersonService ePersonService;
private DiscoveryConfigurationService discoveryConfigurationService;
private CommunityService communityService;
private CollectionService collectionService;
private DiscoverQueryBuilder queryBuilder;
@Override
public MetadataExportSearchScriptConfiguration getScriptConfiguration() {
return new DSpace().getServiceManager()
.getServiceByName("metadata-export-search", MetadataExportSearchScriptConfiguration.class);
}
@Override
public void setup() throws ParseException {
searchService = SearchUtils.getSearchService();
metadataDSpaceCsvExportService = new DSpace().getServiceManager()
.getServiceByName(
MetadataDSpaceCsvExportServiceImpl.class.getCanonicalName(),
MetadataDSpaceCsvExportService.class
);
ePersonService = EPersonServiceFactory.getInstance().getEPersonService();
discoveryConfigurationService = SearchUtils.getConfigurationService();
communityService = ContentServiceFactory.getInstance().getCommunityService();
collectionService = ContentServiceFactory.getInstance().getCollectionService();
queryBuilder = SearchUtils.getQueryBuilder();
if (commandLine.hasOption('h')) {
help = true;
return;
}
if (commandLine.hasOption('q')) {
query = commandLine.getOptionValue('q');
}
if (commandLine.hasOption('s')) {
hasScope = true;
identifier = commandLine.getOptionValue('s');
}
if (commandLine.hasOption('c')) {
discoveryConfigName = commandLine.getOptionValue('c');
}
if (commandLine.hasOption('f')) {
filterQueryStrings = commandLine.getOptionValues('f');
}
}
@Override
public void internalRun() throws Exception {
if (help) {
loghelpinfo();
printHelp();
return;
}
handler.logDebug("starting search export");
IndexableObject dso = null;
Context context = new Context();
context.setCurrentUser(ePersonService.find(context, this.getEpersonIdentifier()));
if (hasScope) {
dso = resolveScope(context, identifier);
}
DiscoveryConfiguration discoveryConfiguration =
discoveryConfigurationService.getDiscoveryConfiguration(discoveryConfigName);
List<QueryBuilderSearchFilter> queryBuilderSearchFilters = new ArrayList<>();
handler.logDebug("processing filter queries");
if (filterQueryStrings != null) {
for (String filterQueryString: filterQueryStrings) {
String field = filterQueryString.split(",", 2)[0];
String operator = filterQueryString.split("(,|=)", 3)[1];
String value = filterQueryString.split("=", 2)[1];
QueryBuilderSearchFilter queryBuilderSearchFilter =
new QueryBuilderSearchFilter(field, operator, value);
queryBuilderSearchFilters.add(queryBuilderSearchFilter);
}
}
handler.logDebug("building query");
DiscoverQuery discoverQuery =
queryBuilder.buildQuery(context, dso, discoveryConfiguration, query, queryBuilderSearchFilters,
"Item", 10, Long.getLong("0"), null, SortOption.DESCENDING);
handler.logDebug("creating iterator");
Iterator<Item> itemIterator = searchService.iteratorSearch(context, dso, discoverQuery);
handler.logDebug("creating dspacecsv");
DSpaceCSV dSpaceCSV = metadataDSpaceCsvExportService.export(context, itemIterator, true, handler);
handler.logDebug("writing to file " + getFileNameOrExportFile());
handler.writeFilestream(context, getFileNameOrExportFile(), dSpaceCSV.getInputStream(), EXPORT_CSV);
context.restoreAuthSystemState();
context.complete();
}
protected void loghelpinfo() {
handler.logInfo("metadata-export");
}
protected String getFileNameOrExportFile() {
return "metadataExportSearch.csv";
}
public IndexableObject resolveScope(Context context, String id) throws SQLException {
UUID uuid = UUID.fromString(id);
IndexableObject scopeObj = new IndexableCommunity(communityService.find(context, uuid));
if (scopeObj.getIndexedObject() == null) {
scopeObj = new IndexableCollection(collectionService.find(context, uuid));
}
return scopeObj;
}
@Override
protected StepResult parse(String[] args) throws ParseException {
commandLine = new DefaultParser().parse(getScriptConfiguration().getOptions(), args);
Builder builder = new DefaultParser().builder();
builder.setStripLeadingAndTrailingQuotes(false);
commandLine = builder.build().parse(getScriptConfiguration().getOptions(), args);
setup();
return StepResult.Continue;
}
}

View File

@@ -0,0 +1,20 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
/**
* The cli version of the {@link MetadataExportSearch} script
*/
public class MetadataExportSearchCli extends MetadataExportSearch {
@Override
protected String getFileNameOrExportFile() {
return commandLine.getOptionValue('n');
}
}

View File

@@ -0,0 +1,26 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import org.apache.commons.cli.Options;
/**
* This is the CLI version of the {@link MetadataExportSearchScriptConfiguration} class that handles the
* configuration for the {@link MetadataExportSearchCli} script
*/
public class MetadataExportSearchCliScriptConfiguration
extends MetadataExportSearchScriptConfiguration<MetadataExportSearchCli> {
@Override
public Options getOptions() {
Options options = super.getOptions();
options.addOption("n", "filename", true, "the filename to export to");
return super.getOptions();
}
}

View File

@@ -0,0 +1,56 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
/**
* The {@link ScriptConfiguration} for the {@link MetadataExportSearch} script
*/
public class MetadataExportSearchScriptConfiguration<T extends MetadataExportSearch> extends ScriptConfiguration<T> {
private Class<T> dspaceRunnableclass;
@Override
public Class<T> getDspaceRunnableClass() {
return dspaceRunnableclass;
}
@Override
public void setDspaceRunnableClass(Class<T> dspaceRunnableClass) {
this.dspaceRunnableclass = dspaceRunnableClass;
}
@Override
public Options getOptions() {
if (options == null) {
Options options = new Options();
options.addOption("q", "query", true,
"The discovery search string to will be used to match records. Not URL encoded");
options.getOption("q").setType(String.class);
options.addOption("s", "scope", true,
"UUID of a specific DSpace container (site, community or collection) to which the search has to be " +
"limited");
options.getOption("s").setType(String.class);
options.addOption("c", "configuration", true,
"The name of a Discovery configuration that should be used by this search");
options.getOption("c").setType(String.class);
options.addOption("f", "filter", true,
"Advanced search filter that has to be used to filter the result set, with syntax `<:filter-name>," +
"<:filter-operator>=<:filter-value>`. Not URL encoded. For example `author," +
"authority=5df05073-3be7-410d-8166-e254369e4166` or `title,contains=sample text`");
options.getOption("f").setType(String.class);
options.addOption("h", "help", false, "help");
super.options = options;
}
return options;
}
}

View File

@@ -0,0 +1,68 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.UUID;
import org.apache.commons.cli.ParseException;
import org.dspace.core.Context;
import org.dspace.eperson.EPerson;
import org.dspace.eperson.factory.EPersonServiceFactory;
import org.dspace.scripts.handler.DSpaceRunnableHandler;
/**
* CLI variant for the {@link MetadataImport} class
* This has been made so that we can specify the behaviour of the determineChanges method to be specific for the CLI
*/
public class MetadataImportCLI extends MetadataImport {
@Override
protected boolean determineChange(DSpaceRunnableHandler handler) throws IOException {
handler.logInfo("Do you want to make these changes? [y/n] ");
try (BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(System.in))) {
String yn = bufferedReader.readLine();
if ("y".equalsIgnoreCase(yn)) {
return true;
}
return false;
}
}
@Override
protected void assignCurrentUserInContext(Context context) throws ParseException {
try {
if (commandLine.hasOption('e')) {
EPerson eperson;
String e = commandLine.getOptionValue('e');
if (e.indexOf('@') != -1) {
eperson = EPersonServiceFactory.getInstance().getEPersonService().findByEmail(context, e);
} else {
eperson = EPersonServiceFactory.getInstance().getEPersonService().find(context, UUID.fromString(e));
}
if (eperson == null) {
throw new ParseException("Error, eperson cannot be found: " + e);
}
context.setCurrentUser(eperson);
}
} catch (Exception e) {
throw new ParseException("Unable to find DSpace user: " + e.getMessage());
}
}
@Override
public void setup() throws ParseException {
super.setup();
if (!commandLine.hasOption('e')) {
throw new ParseException("Required parameter -e missing!");
}
}
}

View File

@@ -0,0 +1,26 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
/**
* The {@link ScriptConfiguration} for the {@link org.dspace.app.bulkedit.MetadataImportCLI} CLI script
*/
public class MetadataImportCliScriptConfiguration extends MetadataImportScriptConfiguration<MetadataImportCLI> {
@Override
public Options getOptions() {
Options options = super.getOptions();
options.addOption("e", "email", true, "email address or user id of user (required if adding new items)");
options.getOption("e").setRequired(true);
super.options = options;
return options;
}
}

View File

@@ -0,0 +1,59 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.bulkedit;
import java.io.InputStream;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
/**
* The {@link ScriptConfiguration} for the {@link MetadataImport} script
*/
public class MetadataImportScriptConfiguration<T extends MetadataImport> extends ScriptConfiguration<T> {
private Class<T> dspaceRunnableClass;
@Override
public Class<T> getDspaceRunnableClass() {
return dspaceRunnableClass;
}
/**
* Generic setter for the dspaceRunnableClass
* @param dspaceRunnableClass The dspaceRunnableClass to be set on this MetadataImportScriptConfiguration
*/
@Override
public void setDspaceRunnableClass(Class<T> dspaceRunnableClass) {
this.dspaceRunnableClass = dspaceRunnableClass;
}
@Override
public Options getOptions() {
if (options == null) {
Options options = new Options();
options.addOption("f", "file", true, "source file");
options.getOption("f").setType(InputStream.class);
options.getOption("f").setRequired(true);
options.addOption("s", "silent", false,
"silent operation - doesn't request confirmation of changes USE WITH CAUTION");
options.addOption("w", "workflow", false, "workflow - when adding new items, use collection workflow");
options.addOption("n", "notify", false,
"notify - when adding new items using a workflow, send notification emails");
options.addOption("v", "validate-only", false,
"validate - just validate the csv, don't run the import");
options.addOption("t", "template", false,
"template - when adding new items, use the collection template (if it exists)");
options.addOption("h", "help", false, "help");
super.options = options;
}
return options;
}
}

View File

@@ -17,13 +17,13 @@ import java.util.UUID;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.DefaultParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Option;
import org.apache.commons.cli.OptionBuilder;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.ParseException;
import org.apache.commons.cli.PosixParser;
import org.apache.log4j.Logger;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.dspace.checker.BitstreamDispatcher;
import org.dspace.checker.CheckerCommand;
import org.dspace.checker.HandleDispatcher;
@@ -48,7 +48,7 @@ import org.dspace.core.Utils;
* @author Nathan Sarr
*/
public final class ChecksumChecker {
private static final Logger LOG = Logger.getLogger(ChecksumChecker.class);
private static final Logger LOG = LogManager.getLogger(ChecksumChecker.class);
private static final BitstreamService bitstreamService = ContentServiceFactory.getInstance().getBitstreamService();
@@ -86,7 +86,7 @@ public final class ChecksumChecker {
*/
public static void main(String[] args) throws SQLException {
// set up command line parser
CommandLineParser parser = new PosixParser();
CommandLineParser parser = new DefaultParser();
CommandLine line = null;
// create an options object and populate it
@@ -101,19 +101,21 @@ public final class ChecksumChecker {
options.addOption("a", "handle", true, "Specify a handle to check");
options.addOption("v", "verbose", false, "Report all processing");
OptionBuilder.withArgName("bitstream-ids").hasArgs().withDescription(
"Space separated list of bitstream ids");
Option useBitstreamIds = OptionBuilder.create('b');
Option option;
options.addOption(useBitstreamIds);
option = Option.builder("b")
.longOpt("bitstream-ids")
.hasArgs()
.desc("Space separated list of bitstream ids")
.build();
options.addOption(option);
options.addOption("p", "prune", false, "Prune configuration file");
options.addOption(OptionBuilder
.withArgName("prune")
.hasOptionalArgs(1)
.withDescription(
"Prune old results (optionally using specified properties file for configuration)")
.create('p'));
option = Option.builder("p")
.longOpt("prune")
.optionalArg(true)
.desc("Prune old results (optionally using specified properties file for configuration)")
.build();
options.addOption(option);
try {
line = parser.parse(options, args);

View File

@@ -0,0 +1,152 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.client;
import static org.apache.commons.collections4.ListUtils.emptyIfNull;
import java.util.List;
import org.apache.http.HttpRequestInterceptor;
import org.apache.http.HttpResponseInterceptor;
import org.apache.http.client.HttpClient;
import org.apache.http.client.config.RequestConfig;
import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.HttpClientBuilder;
import org.dspace.services.ConfigurationService;
import org.dspace.utils.DSpace;
import org.springframework.beans.factory.annotation.Autowired;
/**
* Factory of {@link HttpClient} with common configurations.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class DSpaceHttpClientFactory {
@Autowired
private ConfigurationService configurationService;
@Autowired
private DSpaceProxyRoutePlanner proxyRoutePlanner;
@Autowired(required = false)
private List<HttpRequestInterceptor> requestInterceptors;
@Autowired(required = false)
private List<HttpResponseInterceptor> responseInterceptors;
/**
* Get an instance of {@link DSpaceHttpClientFactory} from the Spring context.
* @return the bean instance
*/
public static DSpaceHttpClientFactory getInstance() {
return new DSpace().getSingletonService(DSpaceHttpClientFactory.class);
}
/**
* Build an instance of {@link HttpClient} setting the proxy if configured.
*
* @return the client
*/
public CloseableHttpClient build() {
return build(HttpClientBuilder.create(), true);
}
/**
* return a Builder if an instance of {@link HttpClient} pre-setting the proxy if configured.
*
* @return the client
*/
public HttpClientBuilder builder(boolean setProxy) {
HttpClientBuilder clientBuilder = HttpClientBuilder.create();
if (setProxy) {
clientBuilder.setRoutePlanner(proxyRoutePlanner);
}
getRequestInterceptors().forEach(clientBuilder::addInterceptorLast);
getResponseInterceptors().forEach(clientBuilder::addInterceptorLast);
return clientBuilder;
}
/**
* Build an instance of {@link HttpClient} without setting the proxy, even if
* configured.
*
* @return the client
*/
public CloseableHttpClient buildWithoutProxy() {
return build(HttpClientBuilder.create(), false);
}
/**
* Build an instance of {@link HttpClient} setting the proxy if configured,
* disabling automatic retries and setting the maximum total connection.
*
* @param maxConnTotal the maximum total connection value
* @return the client
*/
public CloseableHttpClient buildWithoutAutomaticRetries(int maxConnTotal) {
HttpClientBuilder clientBuilder = HttpClientBuilder.create()
.disableAutomaticRetries()
.setMaxConnTotal(maxConnTotal);
return build(clientBuilder, true);
}
/**
* Build an instance of {@link HttpClient} setting the proxy if configured with
* the given request configuration.
* @param requestConfig the request configuration
* @return the client
*/
public CloseableHttpClient buildWithRequestConfig(RequestConfig requestConfig) {
HttpClientBuilder httpClientBuilder = HttpClientBuilder.create()
.setDefaultRequestConfig(requestConfig);
return build(httpClientBuilder, true);
}
private CloseableHttpClient build(HttpClientBuilder clientBuilder, boolean setProxy) {
if (setProxy) {
clientBuilder.setRoutePlanner(proxyRoutePlanner);
}
getRequestInterceptors().forEach(clientBuilder::addInterceptorLast);
getResponseInterceptors().forEach(clientBuilder::addInterceptorLast);
return clientBuilder.build();
}
public ConfigurationService getConfigurationService() {
return configurationService;
}
public void setConfigurationService(ConfigurationService configurationService) {
this.configurationService = configurationService;
}
public List<HttpRequestInterceptor> getRequestInterceptors() {
return emptyIfNull(requestInterceptors);
}
public void setRequestInterceptors(List<HttpRequestInterceptor> requestInterceptors) {
this.requestInterceptors = requestInterceptors;
}
public List<HttpResponseInterceptor> getResponseInterceptors() {
return emptyIfNull(responseInterceptors);
}
public void setResponseInterceptors(List<HttpResponseInterceptor> responseInterceptors) {
this.responseInterceptors = responseInterceptors;
}
public DSpaceProxyRoutePlanner getProxyRoutePlanner() {
return proxyRoutePlanner;
}
public void setProxyRoutePlanner(DSpaceProxyRoutePlanner proxyRoutePlanner) {
this.proxyRoutePlanner = proxyRoutePlanner;
}
}

View File

@@ -0,0 +1,73 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.client;
import java.util.Arrays;
import org.apache.commons.lang3.ArrayUtils;
import org.apache.commons.lang3.StringUtils;
import org.apache.http.HttpException;
import org.apache.http.HttpHost;
import org.apache.http.HttpRequest;
import org.apache.http.impl.conn.DefaultRoutePlanner;
import org.apache.http.protocol.HttpContext;
import org.dspace.services.ConfigurationService;
/**
* Extension of {@link DefaultRoutePlanner} that determine the proxy based on
* the configuration service, ignoring configured hosts.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class DSpaceProxyRoutePlanner extends DefaultRoutePlanner {
private ConfigurationService configurationService;
public DSpaceProxyRoutePlanner(ConfigurationService configurationService) {
super(null);
this.configurationService = configurationService;
}
@Override
protected HttpHost determineProxy(HttpHost target, HttpRequest request, HttpContext context) throws HttpException {
if (isTargetHostConfiguredToBeIgnored(target)) {
return null;
}
String proxyHost = configurationService.getProperty("http.proxy.host");
String proxyPort = configurationService.getProperty("http.proxy.port");
if (StringUtils.isAnyBlank(proxyHost, proxyPort)) {
return null;
}
try {
return new HttpHost(proxyHost, Integer.parseInt(proxyPort), "http");
} catch (NumberFormatException e) {
throw new RuntimeException("Invalid proxy port configuration: " + proxyPort);
}
}
private boolean isTargetHostConfiguredToBeIgnored(HttpHost target) {
String[] hostsToIgnore = configurationService.getArrayProperty("http.proxy.hosts-to-ignore");
if (ArrayUtils.isEmpty(hostsToIgnore)) {
return false;
}
return Arrays.stream(hostsToIgnore)
.anyMatch(host -> matchesHost(host, target.getHostName()));
}
private boolean matchesHost(String hostPattern, String hostName) {
if (hostName.equals(hostPattern)) {
return true;
} else if (hostPattern.startsWith("*")) {
return hostName.endsWith(StringUtils.removeStart(hostPattern, "*"));
} else if (hostPattern.endsWith("*")) {
return hostName.startsWith(StringUtils.removeEnd(hostPattern, "*"));
}
return false;
}
}

View File

@@ -0,0 +1,32 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.exception;
/**
* This class provides an exception to be used when trying to save a resource
* that already exists.
*
* @author Luca Giamminonni (luca.giamminonni at 4science.it)
*
*/
public class ResourceAlreadyExistsException extends RuntimeException {
private static final long serialVersionUID = 1L;
/**
* Create a ResourceAlreadyExistsException with a message and the already
* existing resource.
*
* @param message the error message
*/
public ResourceAlreadyExistsException(String message) {
super(message);
}
}

View File

@@ -13,11 +13,8 @@ import java.util.Iterator;
import java.util.List;
import java.util.UUID;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.PosixParser;
import org.apache.commons.cli.ParseException;
import org.apache.commons.lang3.StringUtils;
import org.dspace.authorize.AuthorizeException;
import org.dspace.content.Collection;
import org.dspace.content.DSpaceObject;
@@ -36,224 +33,223 @@ import org.dspace.harvest.HarvestingException;
import org.dspace.harvest.OAIHarvester;
import org.dspace.harvest.factory.HarvestServiceFactory;
import org.dspace.harvest.service.HarvestedCollectionService;
import org.dspace.scripts.DSpaceRunnable;
import org.dspace.utils.DSpace;
/**
* Test class for harvested collections.
*
* @author Alexey Maslov
*/
public class Harvest {
private static Context context;
public class Harvest extends DSpaceRunnable<HarvestScriptConfiguration> {
private static final HarvestedCollectionService harvestedCollectionService =
HarvestServiceFactory.getInstance().getHarvestedCollectionService();
private static final EPersonService ePersonService = EPersonServiceFactory.getInstance().getEPersonService();
private static final CollectionService collectionService =
ContentServiceFactory.getInstance().getCollectionService();
private HarvestedCollectionService harvestedCollectionService;
protected EPersonService ePersonService;
private CollectionService collectionService;
public static void main(String[] argv) throws Exception {
// create an options object and populate it
CommandLineParser parser = new PosixParser();
private boolean help;
private String command = null;
private String collection = null;
private String oaiSource = null;
private String oaiSetID = null;
private String metadataKey = null;
private int harvestType = 0;
Options options = new Options();
options.addOption("p", "purge", false, "delete all items in the collection");
options.addOption("r", "run", false, "run the standard harvest procedure");
options.addOption("g", "ping", false, "test the OAI server and set");
options.addOption("o", "once", false, "run the harvest procedure with specified parameters");
options.addOption("s", "setup", false, "Set the collection up for harvesting");
options.addOption("S", "start", false, "start the harvest loop");
options.addOption("R", "reset", false, "reset harvest status on all collections");
options.addOption("P", "purge", false, "purge all harvestable collections");
protected Context context;
options.addOption("e", "eperson", true,
"eperson");
options.addOption("c", "collection", true,
"harvesting collection (handle or id)");
options.addOption("t", "type", true,
"type of harvesting (0 for none)");
options.addOption("a", "address", true,
"address of the OAI-PMH server");
options.addOption("i", "oai_set_id", true,
"id of the PMH set representing the harvested collection");
options.addOption("m", "metadata_format", true,
"the name of the desired metadata format for harvesting, resolved to namespace and " +
"crosswalk in dspace.cfg");
public HarvestScriptConfiguration getScriptConfiguration() {
return new DSpace().getServiceManager()
.getServiceByName("harvest", HarvestScriptConfiguration.class);
}
options.addOption("h", "help", false, "help");
public void setup() throws ParseException {
harvestedCollectionService =
HarvestServiceFactory.getInstance().getHarvestedCollectionService();
ePersonService = EPersonServiceFactory.getInstance().getEPersonService();
collectionService =
ContentServiceFactory.getInstance().getCollectionService();
CommandLine line = parser.parse(options, argv);
assignCurrentUserInContext();
String command = null;
String eperson = null;
String collection = null;
String oaiSource = null;
String oaiSetID = null;
String metadataKey = null;
int harvestType = 0;
if (line.hasOption('h')) {
HelpFormatter myhelp = new HelpFormatter();
myhelp.printHelp("Harvest\n", options);
System.out.println("\nPING OAI server: Harvest -g -a oai_source -i oai_set_id");
System.out.println(
"RUNONCE harvest with arbitrary options: Harvest -o -e eperson -c collection -t harvest_type -a " +
"oai_source -i oai_set_id -m metadata_format");
System.out.println(
"SETUP a collection for harvesting: Harvest -s -c collection -t harvest_type -a oai_source -i " +
"oai_set_id -m metadata_format");
System.out.println("RUN harvest once: Harvest -r -e eperson -c collection");
System.out.println("START harvest scheduler: Harvest -S");
System.out.println("RESET all harvest status: Harvest -R");
System.out.println("PURGE a collection of items and settings: Harvest -p -e eperson -c collection");
System.out.println("PURGE all harvestable collections: Harvest -P -e eperson");
help = commandLine.hasOption('h');
System.exit(0);
}
if (line.hasOption('s')) {
if (commandLine.hasOption('s')) {
command = "config";
}
if (line.hasOption('p')) {
if (commandLine.hasOption('p')) {
command = "purge";
}
if (line.hasOption('r')) {
if (commandLine.hasOption('r')) {
command = "run";
}
if (line.hasOption('g')) {
if (commandLine.hasOption('g')) {
command = "ping";
}
if (line.hasOption('o')) {
command = "runOnce";
}
if (line.hasOption('S')) {
if (commandLine.hasOption('S')) {
command = "start";
}
if (line.hasOption('R')) {
if (commandLine.hasOption('R')) {
command = "reset";
}
if (line.hasOption('P')) {
if (commandLine.hasOption('P')) {
command = "purgeAll";
}
if (line.hasOption('e')) {
eperson = line.getOptionValue('e');
if (commandLine.hasOption('o')) {
command = "reimport";
}
if (line.hasOption('c')) {
collection = line.getOptionValue('c');
if (commandLine.hasOption('c')) {
collection = commandLine.getOptionValue('c');
}
if (line.hasOption('t')) {
harvestType = Integer.parseInt(line.getOptionValue('t'));
if (commandLine.hasOption('t')) {
harvestType = Integer.parseInt(commandLine.getOptionValue('t'));
} else {
harvestType = 0;
}
if (line.hasOption('a')) {
oaiSource = line.getOptionValue('a');
if (commandLine.hasOption('a')) {
oaiSource = commandLine.getOptionValue('a');
}
if (line.hasOption('i')) {
oaiSetID = line.getOptionValue('i');
if (commandLine.hasOption('i')) {
oaiSetID = commandLine.getOptionValue('i');
}
if (line.hasOption('m')) {
metadataKey = line.getOptionValue('m');
if (commandLine.hasOption('m')) {
metadataKey = commandLine.getOptionValue('m');
}
}
/**
* This method will assign the currentUser to the {@link Context} variable which is also created in this method.
* The instance of the method in this class will fetch the EPersonIdentifier from this class, this identifier
* was given to this class upon instantiation, it'll then be used to find the {@link EPerson} associated with it
* and this {@link EPerson} will be set as the currentUser of the created {@link Context}
* @throws ParseException If something went wrong with the retrieval of the EPerson Identifier
*/
protected void assignCurrentUserInContext() throws ParseException {
UUID currentUserUuid = this.getEpersonIdentifier();
try {
this.context = new Context(Context.Mode.BATCH_EDIT);
EPerson eperson = ePersonService.find(context, currentUserUuid);
if (eperson == null) {
super.handler.logError("EPerson not found: " + currentUserUuid);
throw new IllegalArgumentException("Unable to find a user with uuid: " + currentUserUuid);
}
this.context.setCurrentUser(eperson);
} catch (SQLException e) {
handler.handleException("Something went wrong trying to fetch eperson for uuid: " + currentUserUuid, e);
}
}
public void internalRun() throws Exception {
if (help) {
printHelp();
handler.logInfo("PING OAI server: Harvest -g -a oai_source -i oai_set_id");
handler.logInfo(
"SETUP a collection for harvesting: Harvest -s -c collection -t harvest_type -a oai_source -i " +
"oai_set_id -m metadata_format");
handler.logInfo("RUN harvest once: Harvest -r -e eperson -c collection");
handler.logInfo("START harvest scheduler: Harvest -S");
handler.logInfo("RESET all harvest status: Harvest -R");
handler.logInfo("PURGE a collection of items and settings: Harvest -p -e eperson -c collection");
handler.logInfo("PURGE all harvestable collections: Harvest -P -e eperson");
return;
}
// Instantiate our class
Harvest harvester = new Harvest();
harvester.context = new Context(Context.Mode.BATCH_EDIT);
// Check our options
if (command == null) {
System.out
.println("Error - no parameters specified (run with -h flag for details)");
System.exit(1);
if (StringUtils.isBlank(command)) {
handler.logError("No parameters specified (run with -h flag for details)");
throw new UnsupportedOperationException("No command specified");
} else if ("run".equals(command)) {
// Run a single harvest cycle on a collection using saved settings.
if (collection == null || eperson == null) {
System.out
.println("Error - a target collection and eperson must be provided");
System.out.println(" (run with -h flag for details)");
System.exit(1);
if (collection == null || context.getCurrentUser() == null) {
handler.logError("A target collection and eperson must be provided (run with -h flag for details)");
throw new UnsupportedOperationException("A target collection and eperson must be provided");
}
harvester.runHarvest(collection, eperson);
runHarvest(context, collection);
} else if ("start".equals(command)) {
// start the harvest loop
startHarvester();
} else if ("reset".equals(command)) {
// reset harvesting status
resetHarvesting();
resetHarvesting(context);
} else if ("purgeAll".equals(command)) {
// purge all collections that are set up for harvesting (obviously for testing purposes only)
if (eperson == null) {
System.out
.println("Error - an eperson must be provided");
System.out.println(" (run with -h flag for details)");
System.exit(1);
if (context.getCurrentUser() == null) {
handler.logError("An eperson must be provided (run with -h flag for details)");
throw new UnsupportedOperationException("An eperson must be provided");
}
List<HarvestedCollection> harvestedCollections = harvestedCollectionService.findAll(context);
for (HarvestedCollection harvestedCollection : harvestedCollections) {
System.out.println(
"Purging the following collections (deleting items and resetting harvest status): " +
harvestedCollection
.getCollection().getID().toString());
harvester.purgeCollection(harvestedCollection.getCollection().getID().toString(), eperson);
handler.logInfo(
"Purging the following collections (deleting items and resetting harvest status): " +
harvestedCollection
.getCollection().getID().toString());
purgeCollection(context, harvestedCollection.getCollection().getID().toString());
}
context.complete();
} else if ("purge".equals(command)) {
// Delete all items in a collection. Useful for testing fresh harvests.
if (collection == null || eperson == null) {
System.out
.println("Error - a target collection and eperson must be provided");
System.out.println(" (run with -h flag for details)");
System.exit(1);
if (collection == null || context.getCurrentUser() == null) {
handler.logError("A target collection and eperson must be provided (run with -h flag for details)");
throw new UnsupportedOperationException("A target collection and eperson must be provided");
}
harvester.purgeCollection(collection, eperson);
purgeCollection(context, collection);
context.complete();
} else if ("reimport".equals(command)) {
// Delete all items in a collection. Useful for testing fresh harvests.
if (collection == null || context.getCurrentUser() == null) {
handler.logError("A target collection and eperson must be provided (run with -h flag for details)");
throw new UnsupportedOperationException("A target collection and eperson must be provided");
}
purgeCollection(context, collection);
runHarvest(context, collection);
context.complete();
//TODO: implement this... remove all items and remember to unset "last-harvested" settings
} else if ("config".equals(command)) {
// Configure a collection with the three main settings
if (collection == null) {
System.out.println("Error - a target collection must be provided");
System.out.println(" (run with -h flag for details)");
System.exit(1);
handler.logError("A target collection must be provided (run with -h flag for details)");
throw new UnsupportedOperationException("A target collection must be provided");
}
if (oaiSource == null || oaiSetID == null) {
System.out.println("Error - both the OAI server address and OAI set id must be specified");
System.out.println(" (run with -h flag for details)");
System.exit(1);
handler.logError(
"Both the OAI server address and OAI set id must be specified (run with -h flag for details)");
throw new UnsupportedOperationException("Both the OAI server address and OAI set id must be specified");
}
if (metadataKey == null) {
System.out
.println("Error - a metadata key (commonly the prefix) must be specified for this collection");
System.out.println(" (run with -h flag for details)");
System.exit(1);
handler.logError(
"A metadata key (commonly the prefix) must be specified for this collection (run with -h flag" +
" for details)");
throw new UnsupportedOperationException(
"A metadata key (commonly the prefix) must be specified for this collection");
}
harvester.configureCollection(collection, harvestType, oaiSource, oaiSetID, metadataKey);
configureCollection(context, collection, harvestType, oaiSource, oaiSetID, metadataKey);
} else if ("ping".equals(command)) {
if (oaiSource == null || oaiSetID == null) {
System.out.println("Error - both the OAI server address and OAI set id must be specified");
System.out.println(" (run with -h flag for details)");
System.exit(1);
handler.logError(
"Both the OAI server address and OAI set id must be specified (run with -h flag for details)");
throw new UnsupportedOperationException("Both the OAI server address and OAI set id must be specified");
}
pingResponder(oaiSource, oaiSetID, metadataKey);
} else {
handler.logError(
"Your command '" + command + "' was not recognized properly (run with -h flag for details)");
throw new UnsupportedOperationException("Your command '" + command + "' was not recognized properly");
}
}
/*
* Resolve the ID into a collection and check to see if its harvesting options are set. If so, return
* the collection, if not, bail out.
*/
private Collection resolveCollection(String collectionID) {
private Collection resolveCollection(Context context, String collectionID) {
DSpaceObject dso;
Collection targetCollection = null;
@@ -272,16 +268,15 @@ public class Harvest {
targetCollection = (Collection) dso;
}
} else {
// not a handle, try and treat it as an integer collection database ID
System.out.println("Looking up by id: " + collectionID + ", parsed as '" + Integer
.parseInt(collectionID) + "', " + "in context: " + context);
// not a handle, try and treat it as an collection database UUID
handler.logInfo("Looking up by UUID: " + collectionID + ", " + "in context: " + context);
targetCollection = collectionService.find(context, UUID.fromString(collectionID));
}
}
// was the collection valid?
if (targetCollection == null) {
System.out.println("Cannot resolve " + collectionID + " to collection");
System.exit(1);
handler.logError("Cannot resolve " + collectionID + " to collection");
throw new UnsupportedOperationException("Cannot resolve " + collectionID + " to collection");
}
} catch (SQLException se) {
se.printStackTrace();
@@ -291,12 +286,12 @@ public class Harvest {
}
private void configureCollection(String collectionID, int type, String oaiSource, String oaiSetId,
private void configureCollection(Context context, String collectionID, int type, String oaiSource, String oaiSetId,
String mdConfigId) {
System.out.println("Running: configure collection");
handler.logInfo("Running: configure collection");
Collection collection = resolveCollection(collectionID);
System.out.println(collection.getID());
Collection collection = resolveCollection(context, collectionID);
handler.logInfo(String.valueOf(collection.getID()));
try {
HarvestedCollection hc = harvestedCollectionService.find(context, collection);
@@ -311,9 +306,8 @@ public class Harvest {
context.restoreAuthSystemState();
context.complete();
} catch (Exception e) {
System.out.println("Changes could not be committed");
e.printStackTrace();
System.exit(1);
handler.logError("Changes could not be committed");
handler.handleException(e);
} finally {
if (context != null) {
context.restoreAuthSystemState();
@@ -324,18 +318,15 @@ public class Harvest {
/**
* Purges a collection of all harvest-related data and settings. All items in the collection will be deleted.
* @param collectionID
*
* @param collectionID
* @param email
*/
private void purgeCollection(String collectionID, String email) {
System.out.println(
"Purging collection of all items and resetting last_harvested and harvest_message: " + collectionID);
Collection collection = resolveCollection(collectionID);
private void purgeCollection(Context context, String collectionID) {
handler.logInfo(
"Purging collection of all items and resetting last_harvested and harvest_message: " + collectionID);
Collection collection = resolveCollection(context, collectionID);
try {
EPerson eperson = ePersonService.findByEmail(context, email);
context.setCurrentUser(eperson);
context.turnOffAuthorisationSystem();
ItemService itemService = ContentServiceFactory.getInstance().getItemService();
@@ -344,7 +335,7 @@ public class Harvest {
while (it.hasNext()) {
i++;
Item item = it.next();
System.out.println("Deleting: " + item.getHandle());
handler.logInfo("Deleting: " + item.getHandle());
collectionService.removeItem(context, collection, item);
context.uncacheEntity(item);// Dispatch events every 50 items
if (i % 50 == 0) {
@@ -364,9 +355,8 @@ public class Harvest {
context.restoreAuthSystemState();
context.dispatchEvents();
} catch (Exception e) {
System.out.println("Changes could not be committed");
e.printStackTrace();
System.exit(1);
handler.logError("Changes could not be committed");
handler.handleException(e);
} finally {
context.restoreAuthSystemState();
}
@@ -376,50 +366,42 @@ public class Harvest {
/**
* Run a single harvest cycle on the specified collection under the authorization of the supplied EPerson
*/
private void runHarvest(String collectionID, String email) {
System.out.println("Running: a harvest cycle on " + collectionID);
private void runHarvest(Context context, String collectionID) {
handler.logInfo("Running: a harvest cycle on " + collectionID);
System.out.print("Initializing the harvester... ");
handler.logInfo("Initializing the harvester... ");
OAIHarvester harvester = null;
try {
Collection collection = resolveCollection(collectionID);
Collection collection = resolveCollection(context, collectionID);
HarvestedCollection hc = harvestedCollectionService.find(context, collection);
harvester = new OAIHarvester(context, collection, hc);
System.out.println("success. ");
handler.logInfo("Initialized the harvester successfully");
} catch (HarvestingException hex) {
System.out.print("failed. ");
System.out.println(hex.getMessage());
handler.logError("Initializing the harvester failed.");
throw new IllegalStateException("Unable to harvest", hex);
} catch (SQLException se) {
System.out.print("failed. ");
System.out.println(se.getMessage());
handler.logError("Initializing the harvester failed.");
throw new IllegalStateException("Unable to access database", se);
}
try {
// Harvest will not work for an anonymous user
EPerson eperson = ePersonService.findByEmail(context, email);
System.out.println("Harvest started... ");
context.setCurrentUser(eperson);
handler.logInfo("Harvest started... ");
harvester.runHarvest();
context.complete();
} catch (SQLException e) {
throw new IllegalStateException("Failed to run harvester", e);
} catch (AuthorizeException e) {
throw new IllegalStateException("Failed to run harvester", e);
} catch (IOException e) {
} catch (SQLException | AuthorizeException | IOException e) {
throw new IllegalStateException("Failed to run harvester", e);
}
System.out.println("Harvest complete. ");
handler.logInfo("Harvest complete. ");
}
/**
* Resets harvest_status and harvest_start_time flags for all collections that have a row in the
* harvested_collections table
*/
private static void resetHarvesting() {
System.out.print("Resetting harvest status flag on all collections... ");
private void resetHarvesting(Context context) {
handler.logInfo("Resetting harvest status flag on all collections... ");
try {
List<HarvestedCollection> harvestedCollections = harvestedCollectionService.findAll(context);
@@ -429,21 +411,21 @@ public class Harvest {
harvestedCollection.setHarvestStatus(HarvestedCollection.STATUS_READY);
harvestedCollectionService.update(context, harvestedCollection);
}
System.out.println("success. ");
handler.logInfo("Reset harvest status flag successfully");
} catch (Exception ex) {
System.out.println("failed. ");
ex.printStackTrace();
handler.logError("Resetting harvest status flag failed");
handler.handleException(ex);
}
}
/**
* Starts up the harvest scheduler. Terminating this process will stop the scheduler.
*/
private static void startHarvester() {
private void startHarvester() {
try {
System.out.print("Starting harvest loop... ");
handler.logInfo("Starting harvest loop... ");
HarvestServiceFactory.getInstance().getHarvestSchedulingService().startNewScheduler();
System.out.println("running. ");
handler.logInfo("running. ");
} catch (Exception ex) {
ex.printStackTrace();
}
@@ -456,29 +438,31 @@ public class Harvest {
* @param set name of an item set.
* @param metadataFormat local prefix name, or null for "dc".
*/
private static void pingResponder(String server, String set, String metadataFormat) {
private void pingResponder(String server, String set, String metadataFormat) {
List<String> errors;
System.out.print("Testing basic PMH access: ");
errors = OAIHarvester.verifyOAIharvester(server, set,
(null != metadataFormat) ? metadataFormat : "dc", false);
handler.logInfo("Testing basic PMH access: ");
errors = harvestedCollectionService.verifyOAIharvester(server, set,
(null != metadataFormat) ? metadataFormat : "dc", false);
if (errors.isEmpty()) {
System.out.println("OK");
handler.logInfo("OK");
} else {
for (String error : errors) {
System.err.println(error);
handler.logError(error);
}
}
System.out.print("Testing ORE support: ");
errors = OAIHarvester.verifyOAIharvester(server, set,
(null != metadataFormat) ? metadataFormat : "dc", true);
handler.logInfo("Testing ORE support: ");
errors = harvestedCollectionService.verifyOAIharvester(server, set,
(null != metadataFormat) ? metadataFormat : "dc", true);
if (errors.isEmpty()) {
System.out.println("OK");
handler.logInfo("OK");
} else {
for (String error : errors) {
System.err.println(error);
handler.logError(error);
}
}
}
}

View File

@@ -0,0 +1,45 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.harvest;
import java.sql.SQLException;
import org.apache.commons.cli.ParseException;
import org.dspace.core.Context;
import org.dspace.eperson.EPerson;
public class HarvestCli extends Harvest {
/**
* This is the overridden instance of the {@link Harvest#assignCurrentUserInContext()} method in the parent class
* {@link Harvest}.
* This is done so that the CLI version of the Script is able to retrieve its currentUser from the -e flag given
* with the parameters of the Script.
*
* @throws ParseException If the e flag was not given to the parameters when calling the script
*/
@Override
protected void assignCurrentUserInContext() throws ParseException {
if (this.commandLine.hasOption('e')) {
String ePersonEmail = this.commandLine.getOptionValue('e');
this.context = new Context(Context.Mode.BATCH_EDIT);
try {
EPerson ePerson = ePersonService.findByEmail(this.context, ePersonEmail);
if (ePerson == null) {
super.handler.logError("EPerson not found: " + ePersonEmail);
throw new IllegalArgumentException("Unable to find a user with email: " + ePersonEmail);
}
this.context.setCurrentUser(ePerson);
} catch (SQLException e) {
throw new IllegalArgumentException("SQLException trying to find user with email: " + ePersonEmail);
}
}
}
}

View File

@@ -0,0 +1,22 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.harvest;
import org.apache.commons.cli.Options;
public class HarvestCliScriptConfiguration extends HarvestScriptConfiguration {
public Options getOptions() {
Options options = super.getOptions();
options.addOption("e", "eperson", true,
"eperson");
return options;
}
}

View File

@@ -0,0 +1,56 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.harvest;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
public class HarvestScriptConfiguration<T extends Harvest> extends ScriptConfiguration<T> {
private Class<T> dspaceRunnableClass;
@Override
public Class<T> getDspaceRunnableClass() {
return dspaceRunnableClass;
}
@Override
public void setDspaceRunnableClass(Class<T> dspaceRunnableClass) {
this.dspaceRunnableClass = dspaceRunnableClass;
}
public Options getOptions() {
Options options = new Options();
options.addOption("p", "purge", false, "delete all items in the collection");
options.addOption("r", "run", false, "run the standard harvest procedure");
options.addOption("g", "ping", false, "test the OAI server and set");
options.addOption("s", "setup", false, "Set the collection up for harvesting");
options.addOption("S", "start", false, "start the harvest loop");
options.addOption("R", "reset", false, "reset harvest status on all collections");
options.addOption("P", "purgeCollections", false, "purge all harvestable collections");
options.addOption("o", "reimport", false, "reimport all items in the collection, " +
"this is equivalent to -p -r, purging all items in a collection and reimporting them");
options.addOption("c", "collection", true,
"harvesting collection (handle or id)");
options.addOption("t", "type", true,
"type of harvesting (0 for none)");
options.addOption("a", "address", true,
"address of the OAI-PMH server");
options.addOption("i", "oai_set_id", true,
"id of the PMH set representing the harvested collection");
options.addOption("m", "metadata_format", true,
"the name of the desired metadata format for harvesting, resolved to namespace and " +
"crosswalk in dspace.cfg");
options.addOption("h", "help", false, "help");
return options;
}
}

View File

@@ -0,0 +1,264 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.itemexport;
import java.io.File;
import java.io.FileInputStream;
import java.io.InputStream;
import java.nio.file.Path;
import java.sql.SQLException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.UUID;
import org.apache.commons.cli.ParseException;
import org.apache.commons.io.file.PathUtils;
import org.dspace.app.itemexport.factory.ItemExportServiceFactory;
import org.dspace.app.itemexport.service.ItemExportService;
import org.dspace.content.Collection;
import org.dspace.content.Item;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.CollectionService;
import org.dspace.content.service.ItemService;
import org.dspace.core.Constants;
import org.dspace.core.Context;
import org.dspace.eperson.EPerson;
import org.dspace.eperson.factory.EPersonServiceFactory;
import org.dspace.eperson.service.EPersonService;
import org.dspace.handle.factory.HandleServiceFactory;
import org.dspace.handle.service.HandleService;
import org.dspace.scripts.DSpaceRunnable;
import org.dspace.utils.DSpace;
/**
* Item exporter to create simple AIPs for DSpace content. Currently exports
* individual items, or entire collections. For instructions on use, see
* printUsage() method.
* <P>
* ItemExport creates the simple AIP package that the importer also uses. It
* consists of:
* <P>
* /exportdir/42/ (one directory per item) / dublin_core.xml - qualified dublin
* core in RDF schema / contents - text file, listing one file per line / file1
* - files contained in the item / file2 / ...
* <P>
* issues -doesn't handle special characters in metadata (needs to turn {@code &'s} into
* {@code &amp;}, etc.)
* <P>
* Modified by David Little, UCSD Libraries 12/21/04 to allow the registration
* of files (bitstreams) into DSpace.
*
* @author David Little
* @author Jay Paz
*/
public class ItemExport extends DSpaceRunnable<ItemExportScriptConfiguration> {
public static final String TEMP_DIR = "exportSAF";
public static final String ZIP_NAME = "exportSAFZip";
public static final String ZIP_FILENAME = "saf-export";
public static final String ZIP_EXT = "zip";
protected String typeString = null;
protected String destDirName = null;
protected String idString = null;
protected int seqStart = -1;
protected int type = -1;
protected Item item = null;
protected Collection collection = null;
protected boolean migrate = false;
protected boolean zip = false;
protected String zipFileName = "";
protected boolean excludeBitstreams = false;
protected boolean help = false;
protected static HandleService handleService = HandleServiceFactory.getInstance().getHandleService();
protected static ItemService itemService = ContentServiceFactory.getInstance().getItemService();
protected static CollectionService collectionService = ContentServiceFactory.getInstance().getCollectionService();
protected static final EPersonService epersonService =
EPersonServiceFactory.getInstance().getEPersonService();
@Override
public ItemExportScriptConfiguration getScriptConfiguration() {
return new DSpace().getServiceManager()
.getServiceByName("export", ItemExportScriptConfiguration.class);
}
@Override
public void setup() throws ParseException {
help = commandLine.hasOption('h');
if (commandLine.hasOption('t')) { // type
typeString = commandLine.getOptionValue('t');
if ("ITEM".equals(typeString)) {
type = Constants.ITEM;
} else if ("COLLECTION".equals(typeString)) {
type = Constants.COLLECTION;
}
}
if (commandLine.hasOption('i')) { // id
idString = commandLine.getOptionValue('i');
}
setNumber();
if (commandLine.hasOption('m')) { // number
migrate = true;
}
if (commandLine.hasOption('x')) {
excludeBitstreams = true;
}
}
@Override
public void internalRun() throws Exception {
if (help) {
printHelp();
return;
}
validate();
Context context = new Context();
context.turnOffAuthorisationSystem();
if (type == Constants.ITEM) {
// first, is myIDString a handle?
if (idString.indexOf('/') != -1) {
item = (Item) handleService.resolveToObject(context, idString);
if ((item == null) || (item.getType() != Constants.ITEM)) {
item = null;
}
} else {
item = itemService.find(context, UUID.fromString(idString));
}
if (item == null) {
handler.logError("The item cannot be found: " + idString + " (run with -h flag for details)");
throw new UnsupportedOperationException("The item cannot be found: " + idString);
}
} else {
if (idString.indexOf('/') != -1) {
// has a / must be a handle
collection = (Collection) handleService.resolveToObject(context,
idString);
// ensure it's a collection
if ((collection == null)
|| (collection.getType() != Constants.COLLECTION)) {
collection = null;
}
} else {
collection = collectionService.find(context, UUID.fromString(idString));
}
if (collection == null) {
handler.logError("The collection cannot be found: " + idString + " (run with -h flag for details)");
throw new UnsupportedOperationException("The collection cannot be found: " + idString);
}
}
ItemExportService itemExportService = ItemExportServiceFactory.getInstance()
.getItemExportService();
try {
itemExportService.setHandler(handler);
process(context, itemExportService);
context.complete();
} catch (Exception e) {
context.abort();
throw new Exception(e);
}
}
/**
* Validate the options
*/
protected void validate() {
if (type == -1) {
handler.logError("The type must be either COLLECTION or ITEM (run with -h flag for details)");
throw new UnsupportedOperationException("The type must be either COLLECTION or ITEM");
}
if (idString == null) {
handler.logError("The ID must be set to either a database ID or a handle (run with -h flag for details)");
throw new UnsupportedOperationException("The ID must be set to either a database ID or a handle");
}
}
/**
* Process the export
* @param context
* @throws Exception
*/
protected void process(Context context, ItemExportService itemExportService) throws Exception {
setEPerson(context);
setDestDirName(context, itemExportService);
setZip(context);
Iterator<Item> items;
if (item != null) {
List<Item> myItems = new ArrayList<>();
myItems.add(item);
items = myItems.iterator();
} else {
handler.logInfo("Exporting from collection: " + idString);
items = itemService.findByCollection(context, collection);
}
itemExportService.exportAsZip(context, items, destDirName, zipFileName,
seqStart, migrate, excludeBitstreams);
File zip = new File(destDirName + System.getProperty("file.separator") + zipFileName);
try (InputStream is = new FileInputStream(zip)) {
// write input stream on handler
handler.writeFilestream(context, ZIP_FILENAME + "." + ZIP_EXT, is, ZIP_NAME);
} finally {
PathUtils.deleteDirectory(Path.of(destDirName));
}
}
/**
* Set the destination directory option
*/
protected void setDestDirName(Context context, ItemExportService itemExportService) throws Exception {
destDirName = itemExportService.getExportWorkDirectory() + File.separator + TEMP_DIR;
}
/**
* Set the zip option
*/
protected void setZip(Context context) {
zip = true;
zipFileName = ZIP_FILENAME + "-" + context.getCurrentUser().getID() + "." + ZIP_EXT;
}
/**
* Set the number option
*/
protected void setNumber() {
seqStart = 1;
if (commandLine.hasOption('n')) { // number
seqStart = Integer.parseInt(commandLine.getOptionValue('n'));
}
}
private void setEPerson(Context context) throws SQLException {
EPerson myEPerson = epersonService.find(context, this.getEpersonIdentifier());
// check eperson
if (myEPerson == null) {
handler.logError("EPerson cannot be found: " + this.getEpersonIdentifier());
throw new UnsupportedOperationException("EPerson cannot be found: " + this.getEpersonIdentifier());
}
context.setCurrentUser(myEPerson);
}
}

View File

@@ -0,0 +1,96 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.itemexport;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import org.dspace.app.itemexport.service.ItemExportService;
import org.dspace.content.Item;
import org.dspace.core.Context;
/**
* CLI variant for the {@link ItemExport} class.
* This was done to specify the specific behaviors for the CLI.
*
* @author Francesco Pio Scognamiglio (francescopio.scognamiglio at 4science.com)
*/
public class ItemExportCLI extends ItemExport {
@Override
protected void validate() {
super.validate();
setDestDirName();
if (destDirName == null) {
handler.logError("The destination directory must be set (run with -h flag for details)");
throw new UnsupportedOperationException("The destination directory must be set");
}
if (seqStart == -1) {
handler.logError("The sequence start number must be set (run with -h flag for details)");
throw new UnsupportedOperationException("The sequence start number must be set");
}
}
@Override
protected void process(Context context, ItemExportService itemExportService) throws Exception {
setZip(context);
if (zip) {
Iterator<Item> items;
if (item != null) {
List<Item> myItems = new ArrayList<>();
myItems.add(item);
items = myItems.iterator();
} else {
handler.logInfo("Exporting from collection: " + idString);
items = itemService.findByCollection(context, collection);
}
itemExportService.exportAsZip(context, items, destDirName, zipFileName,
seqStart, migrate, excludeBitstreams);
} else {
if (item != null) {
// it's only a single item
itemExportService
.exportItem(context, Collections.singletonList(item).iterator(), destDirName,
seqStart, migrate, excludeBitstreams);
} else {
handler.logInfo("Exporting from collection: " + idString);
// it's a collection, so do a bunch of items
Iterator<Item> i = itemService.findByCollection(context, collection);
itemExportService.exportItem(context, i, destDirName, seqStart, migrate, excludeBitstreams);
}
}
}
protected void setDestDirName() {
if (commandLine.hasOption('d')) { // dest
destDirName = commandLine.getOptionValue('d');
}
}
@Override
protected void setZip(Context context) {
if (commandLine.hasOption('z')) {
zip = true;
zipFileName = commandLine.getOptionValue('z');
}
}
@Override
protected void setNumber() {
if (commandLine.hasOption('n')) { // number
seqStart = Integer.parseInt(commandLine.getOptionValue('n'));
}
}
}

View File

@@ -0,0 +1,56 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.itemexport;
import org.apache.commons.cli.Option;
import org.apache.commons.cli.Options;
import org.dspace.scripts.configuration.ScriptConfiguration;
/**
* The {@link ScriptConfiguration} for the {@link ItemExportCLI} script
*
* @author Francesco Pio Scognamiglio (francescopio.scognamiglio at 4science.com)
*/
public class ItemExportCLIScriptConfiguration extends ItemExportScriptConfiguration<ItemExportCLI> {
@Override
public Options getOptions() {
Options options = new Options();
options.addOption(Option.builder("t").longOpt("type")
.desc("type: COLLECTION or ITEM")
.hasArg().required().build());
options.addOption(Option.builder("i").longOpt("id")
.desc("ID or handle of thing to export")
.hasArg().required().build());
options.addOption(Option.builder("d").longOpt("dest")
.desc("destination where you want items to go")
.hasArg().required().build());
options.addOption(Option.builder("n").longOpt("number")
.desc("sequence number to begin exporting items with")
.hasArg().required().build());
options.addOption(Option.builder("z").longOpt("zip")
.desc("export as zip file (specify filename e.g. export.zip)")
.hasArg().required(false).build());
options.addOption(Option.builder("m").longOpt("migrate")
.desc("export for migration (remove handle and metadata that will be re-created in new system)")
.hasArg(false).required(false).build());
// as pointed out by Peter Dietz this provides similar functionality to export metadata
// but it is needed since it directly exports to Simple Archive Format (SAF)
options.addOption(Option.builder("x").longOpt("exclude-bitstreams")
.desc("do not export bitstreams")
.hasArg(false).required(false).build());
options.addOption(Option.builder("h").longOpt("help")
.desc("help")
.hasArg(false).required(false).build());
return options;
}
}

View File

@@ -1,246 +0,0 @@
/**
* The contents of this file are subject to the license and copyright
* detailed in the LICENSE and NOTICE files at the root of the source
* tree and available online at
*
* http://www.dspace.org/license/
*/
package org.dspace.app.itemexport;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.UUID;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.CommandLineParser;
import org.apache.commons.cli.HelpFormatter;
import org.apache.commons.cli.Options;
import org.apache.commons.cli.PosixParser;
import org.dspace.app.itemexport.factory.ItemExportServiceFactory;
import org.dspace.app.itemexport.service.ItemExportService;
import org.dspace.content.Collection;
import org.dspace.content.Item;
import org.dspace.content.factory.ContentServiceFactory;
import org.dspace.content.service.CollectionService;
import org.dspace.content.service.ItemService;
import org.dspace.core.Constants;
import org.dspace.core.Context;
import org.dspace.handle.factory.HandleServiceFactory;
import org.dspace.handle.service.HandleService;
/**
* Item exporter to create simple AIPs for DSpace content. Currently exports
* individual items, or entire collections. For instructions on use, see
* printUsage() method.
* <P>
* ItemExport creates the simple AIP package that the importer also uses. It
* consists of:
* <P>
* /exportdir/42/ (one directory per item) / dublin_core.xml - qualified dublin
* core in RDF schema / contents - text file, listing one file per line / file1
* - files contained in the item / file2 / ...
* <P>
* issues -doesn't handle special characters in metadata (needs to turn {@code &'s} into
* {@code &amp;}, etc.)
* <P>
* Modified by David Little, UCSD Libraries 12/21/04 to allow the registration
* of files (bitstreams) into DSpace.
*
* @author David Little
* @author Jay Paz
*/
public class ItemExportCLITool {
protected static ItemExportService itemExportService = ItemExportServiceFactory.getInstance()
.getItemExportService();
protected static HandleService handleService = HandleServiceFactory.getInstance().getHandleService();
protected static ItemService itemService = ContentServiceFactory.getInstance().getItemService();
protected static CollectionService collectionService = ContentServiceFactory.getInstance().getCollectionService();
/**
* Default constructor
*/
private ItemExportCLITool() { }
/*
*
*/
public static void main(String[] argv) throws Exception {
// create an options object and populate it
CommandLineParser parser = new PosixParser();
Options options = new Options();
options.addOption("t", "type", true, "type: COLLECTION or ITEM");
options.addOption("i", "id", true, "ID or handle of thing to export");
options.addOption("d", "dest", true,
"destination where you want items to go");
options.addOption("m", "migrate", false,
"export for migration (remove handle and metadata that will be re-created in new system)");
options.addOption("n", "number", true,
"sequence number to begin exporting items with");
options.addOption("z", "zip", true, "export as zip file (specify filename e.g. export.zip)");
options.addOption("h", "help", false, "help");
// as pointed out by Peter Dietz this provides similar functionality to export metadata
// but it is needed since it directly exports to Simple Archive Format (SAF)
options.addOption("x", "exclude-bitstreams", false, "do not export bitstreams");
CommandLine line = parser.parse(options, argv);
String typeString = null;
String destDirName = null;
String myIDString = null;
int seqStart = -1;
int myType = -1;
Item myItem = null;
Collection mycollection = null;
if (line.hasOption('h')) {
HelpFormatter myhelp = new HelpFormatter();
myhelp.printHelp("ItemExport\n", options);
System.out
.println("\nfull collection: ItemExport -t COLLECTION -i ID -d dest -n number");
System.out
.println("singleitem: ItemExport -t ITEM -i ID -d dest -n number");
System.exit(0);
}
if (line.hasOption('t')) { // type
typeString = line.getOptionValue('t');
if ("ITEM".equals(typeString)) {
myType = Constants.ITEM;
} else if ("COLLECTION".equals(typeString)) {
myType = Constants.COLLECTION;
}
}
if (line.hasOption('i')) { // id
myIDString = line.getOptionValue('i');
}
if (line.hasOption('d')) { // dest
destDirName = line.getOptionValue('d');
}
if (line.hasOption('n')) { // number
seqStart = Integer.parseInt(line.getOptionValue('n'));
}
boolean migrate = false;
if (line.hasOption('m')) { // number
migrate = true;
}
boolean zip = false;
String zipFileName = "";
if (line.hasOption('z')) {
zip = true;
zipFileName = line.getOptionValue('z');
}
boolean excludeBitstreams = false;
if (line.hasOption('x')) {
excludeBitstreams = true;
}
// now validate the args
if (myType == -1) {
System.out
.println("type must be either COLLECTION or ITEM (-h for help)");
System.exit(1);
}
if (destDirName == null) {
System.out
.println("destination directory must be set (-h for help)");
System.exit(1);
}
if (seqStart == -1) {
System.out
.println("sequence start number must be set (-h for help)");
System.exit(1);
}
if (myIDString == null) {
System.out
.println("ID must be set to either a database ID or a handle (-h for help)");
System.exit(1);
}
Context c = new Context(Context.Mode.READ_ONLY);
c.turnOffAuthorisationSystem();
if (myType == Constants.ITEM) {
// first, is myIDString a handle?
if (myIDString.indexOf('/') != -1) {
myItem = (Item) handleService.resolveToObject(c, myIDString);
if ((myItem == null) || (myItem.getType() != Constants.ITEM)) {
myItem = null;
}
} else {
myItem = itemService.find(c, UUID.fromString(myIDString));
}
if (myItem == null) {
System.out
.println("Error, item cannot be found: " + myIDString);
}
} else {
if (myIDString.indexOf('/') != -1) {
// has a / must be a handle
mycollection = (Collection) handleService.resolveToObject(c,
myIDString);
// ensure it's a collection
if ((mycollection == null)
|| (mycollection.getType() != Constants.COLLECTION)) {
mycollection = null;
}
} else if (myIDString != null) {
mycollection = collectionService.find(c, UUID.fromString(myIDString));
}
if (mycollection == null) {
System.out.println("Error, collection cannot be found: "
+ myIDString);
System.exit(1);
}
}
if (zip) {
Iterator<Item> items;
if (myItem != null) {
List<Item> myItems = new ArrayList<>();
myItems.add(myItem);
items = myItems.iterator();
} else {
System.out.println("Exporting from collection: " + myIDString);
items = itemService.findByCollection(c, mycollection);
}
itemExportService.exportAsZip(c, items, destDirName, zipFileName, seqStart, migrate, excludeBitstreams);
} else {
if (myItem != null) {
// it's only a single item
itemExportService
.exportItem(c, Collections.singletonList(myItem).iterator(), destDirName, seqStart, migrate,
excludeBitstreams);
} else {
System.out.println("Exporting from collection: " + myIDString);
// it's a collection, so do a bunch of items
Iterator<Item> i = itemService.findByCollection(c, mycollection);
itemExportService.exportItem(c, i, destDirName, seqStart, migrate, excludeBitstreams);
}
}
c.complete();
}
}

Some files were not shown because too many files have changed in this diff Show More